Page MenuHomePhabricator

aemerson (Amara Emerson)
Asian George Costanza

Projects

User does not belong to any projects.

User Details

User Since
Sep 9 2013, 3:45 AM (331 w, 5 d)

The sea was angry that day, my friends - like an old man trying to send back soup in a deli.

Recent Activity

Yesterday

aemerson added a comment to D72961: In early-ifconversion check that the operands of a PHI share a common regclass with the destination regclass..

My initial reaction was that the PHI was invalid, but according to @qcolombet it's ok to have different register banks on the operands

Okay... but the operand register class can't actually be *anything*, can it? We have restrictions on COPY instructions.

Those restrictions are target specific though aren’t they? I think it’s the responsibility of ISel to generate valid copies and similar should apply to PHIs.

Fri, Jan 17, 7:36 PM · Restricted Project
aemerson added a comment to D72961: In early-ifconversion check that the operands of a PHI share a common regclass with the destination regclass..

What is the restriction on the register classes of PHI operands, if they don't have to have to be same register class as the result? I don't see any relevant documentation, or checks in MachineVerifier::checkPHIOps().

Fri, Jan 17, 4:36 PM · Restricted Project
aemerson created D72961: In early-ifconversion check that the operands of a PHI share a common regclass with the destination regclass..
Fri, Jan 17, 2:52 PM · Restricted Project

Thu, Jan 16

aemerson accepted D72814: [AArch64][GlobalISel] Change G_FCONSTANTs feeding into stores into G_CONSTANTS.

LGTM.

Thu, Jan 16, 2:15 PM · Restricted Project
aemerson added a comment to D72814: [AArch64][GlobalISel] Change G_FCONSTANTs feeding into stores into G_CONSTANTS.

I think in cases where it's possible to use an fmov with immediate:

Thu, Jan 16, 9:25 AM · Restricted Project

Wed, Jan 15

aemerson removed a reviewer for D65656: AArch64: support @llvm.{return,frame}address in GlobalISel: RKSimon.

Re-closing.

Wed, Jan 15, 10:31 AM · Restricted Project
aemerson closed D65656: AArch64: support @llvm.{return,frame}address in GlobalISel.
Wed, Jan 15, 10:31 AM · Restricted Project
aemerson accepted D65656: AArch64: support @llvm.{return,frame}address in GlobalISel.

Fixed in 2e39ea726e9.

Wed, Jan 15, 10:31 AM · Restricted Project
aemerson committed rG2e39ea726e9c: Revert "Revert rG6078f2fedcac5797ac39ee5ef3fd7a35ef1202d5 - "[AArch64]… (authored by aemerson).
Revert "Revert rG6078f2fedcac5797ac39ee5ef3fd7a35ef1202d5 - "[AArch64]…
Wed, Jan 15, 10:22 AM
aemerson added a reverting change for rG6078f2fedcac: [AArch64][GlobalISel]: Support @llvm.{return,frame}address selection.: rG2e39ea726e9c: Revert "Revert rG6078f2fedcac5797ac39ee5ef3fd7a35ef1202d5 - "[AArch64]….
Wed, Jan 15, 10:22 AM
aemerson added a comment to rG6078f2fedcac: [AArch64][GlobalISel]: Support @llvm.{return,frame}address selection..

Sorry about that. I've pushed a fixed version in 2e39ea726e9.

Wed, Jan 15, 10:22 AM

Tue, Jan 14

aemerson committed rG6078f2fedcac: [AArch64][GlobalISel]: Support @llvm.{return,frame}address selection. (authored by aemerson).
[AArch64][GlobalISel]: Support @llvm.{return,frame}address selection.
Tue, Jan 14, 1:47 PM
aemerson closed D65656: AArch64: support @llvm.{return,frame}address in GlobalISel.
Tue, Jan 14, 1:47 PM · Restricted Project
aemerson accepted D72511: GlobalISel: Handle more cases of G_SEXT narrowing.

LGTM.

Tue, Jan 14, 1:28 PM · Restricted Project
aemerson accepted D72506: GlobalISel: Fix narrowScalar for G_ANYEXT results.

LGTM.

Tue, Jan 14, 1:19 PM · Restricted Project
aemerson accepted D72492: GlobalISel: Implement lower for G_BITCAST.
Tue, Jan 14, 1:19 PM · Restricted Project

Mon, Jan 13

aemerson added a comment to D70465: [Win64] Handle FP arguments more gracefully under -mno-sse.

Ping.

Mon, Jan 13, 2:39 PM · Restricted Project

Fri, Jan 10

aemerson committed rG695804508db0: Mark the test/Feature/load_extension.ll test as unsupported on Darwin. (authored by aemerson).
Mark the test/Feature/load_extension.ll test as unsupported on Darwin.
Fri, Jan 10, 8:28 PM
aemerson added a comment to D72492: GlobalISel: Implement lower for G_BITCAST.

On the topic of this particular change: IIRC the semantics of bitcast is that it's equivalent of doing a store of the source type and a load of the dest type, which can have differing results on big endian targets. Is this lowering code safe in that case?

Fri, Jan 10, 11:36 AM · Restricted Project
aemerson added a comment to D72492: GlobalISel: Implement lower for G_BITCAST.

On AArch64 we also use bitcast to convert from <n x p0> to <n x s64> types.

I thought that was illegal. It’s not legal in IR

I think this is a verifier bug. You're not allowed to bitcast between scalar pointers and scalars, so allowing it for vectors doesn't make much sense. I think allowing this is potentially problematic for non-integral pointers since it makes it easy to accidentally launder away the pointerness

We don't have an alternative way to easily convert between them though. Unless G_PTRTOINT is also allowed to take vectors of pointers.

G_PTRTOINT works with vectors. I'm not opposed to allowing G_BITCAST between scalar and (integral) pointers, although this differs from the IR. It makes more sense in codegen to have these be more flexible. The current state doesn't make sense though. We can either:

Ah, I didn't realize it was allowed in the IR. In that case AArch64 can move to using that instead.

  1. Allow casts between pointers and others types. This will need documenting as differing from the corresponding IR instructions. This should also maybe restrict this for nonintegral address spaces?
  1. Disallow bitcast between vectors of pointers and vectors of scalars and match the IR
Fri, Jan 10, 11:36 AM · Restricted Project
aemerson added a comment to D72492: GlobalISel: Implement lower for G_BITCAST.

On AArch64 we also use bitcast to convert from <n x p0> to <n x s64> types.

I thought that was illegal. It’s not legal in IR

I think this is a verifier bug. You're not allowed to bitcast between scalar pointers and scalars, so allowing it for vectors doesn't make much sense. I think allowing this is potentially problematic for non-integral pointers since it makes it easy to accidentally launder away the pointerness

Fri, Jan 10, 10:50 AM · Restricted Project
aemerson added a comment to D72492: GlobalISel: Implement lower for G_BITCAST.

On AArch64 we also use bitcast to convert from <n x p0> to <n x s64> types.

Fri, Jan 10, 10:12 AM · Restricted Project

Thu, Jan 9

aemerson committed rGcc95bb1f57c6: [AArch64][GlobalISel] Implement selection of <2 x float> vector splat. (authored by aemerson).
[AArch64][GlobalISel] Implement selection of <2 x float> vector splat.
Thu, Jan 9, 2:28 PM
aemerson closed D72422: [AArch64][GlobalISel] Implement selection of <2 x float> vector splat..
Thu, Jan 9, 2:28 PM · Restricted Project
aemerson accepted D70465: [Win64] Handle FP arguments more gracefully under -mno-sse.

No objections for a week, LGTM.

Thu, Jan 9, 12:16 PM · Restricted Project
aemerson updated the diff for D72422: [AArch64][GlobalISel] Implement selection of <2 x float> vector splat..

Add asserts.

Thu, Jan 9, 12:16 PM · Restricted Project
aemerson accepted D72002: GlobalISel: Handle llvm.read_register.

LGTM.

Thu, Jan 9, 9:36 AM · Restricted Project
aemerson accepted D72426: [GlobalISel][AArch64] Import + select LDR*roW and STR*roW patterns.

LGTM with some minor comments.

Thu, Jan 9, 9:36 AM · Restricted Project
aemerson accepted D72457: GlobalISel: Move getLLTForMVT/getMVTForLLT.

LGTM.

Thu, Jan 9, 9:36 AM · Restricted Project

Wed, Jan 8

aemerson created D72422: [AArch64][GlobalISel] Implement selection of <2 x float> vector splat..
Wed, Jan 8, 3:28 PM · Restricted Project

Tue, Jan 7

aemerson committed rGb6598bcf4b81: [AArch64][GlobalISel] Fold a chain of two G_PTR_ADDs of constant offsets. (authored by aemerson).
[AArch64][GlobalISel] Fold a chain of two G_PTR_ADDs of constant offsets.
Tue, Jan 7, 2:16 PM
aemerson closed D72351: [AArch64][GlobalISel] Fold a chain of two G_PTR_ADDs of constant offsets..
Tue, Jan 7, 2:15 PM · Restricted Project
aemerson added inline comments to D72351: [AArch64][GlobalISel] Fold a chain of two G_PTR_ADDs of constant offsets..
Tue, Jan 7, 12:30 PM · Restricted Project
aemerson updated the diff for D72351: [AArch64][GlobalISel] Fold a chain of two G_PTR_ADDs of constant offsets..

Use getConstantVRegValWithLookThrough.

Tue, Jan 7, 11:51 AM · Restricted Project
aemerson created D72351: [AArch64][GlobalISel] Fold a chain of two G_PTR_ADDs of constant offsets..
Tue, Jan 7, 11:02 AM · Restricted Project

Mon, Jan 6

aemerson updated subscribers of D72002: GlobalISel: Handle llvm.read_register.

Since you're introducing a new opcode for this, can't we implement a Lower action? Daniel mentioned a while ago that he also prefers having targets explicitly opt-in to using default lowerings/expansions.

Mon, Jan 6, 1:20 PM · Restricted Project
aemerson accepted D71256: llc: Don't overwrite frame-pointer attribute.

LGTM.

Mon, Jan 6, 1:01 PM · Restricted Project
aemerson accepted D71253: llc/MIR: Fix setFunctionAttributes for MIR functions.

Looks reasonable to me.

Mon, Jan 6, 1:01 PM · Restricted Project
aemerson committed rGdf3f4e0d77e5: [X86] Fix an 8 bit testb being selected when folding a volatile i32 load… (authored by aemerson).
[X86] Fix an 8 bit testb being selected when folding a volatile i32 load…
Mon, Jan 6, 11:55 AM
aemerson closed D71581: [X86] Fix an 8 bit testb being selected when folding a volatile i32 load pattern..
Mon, Jan 6, 11:55 AM · Restricted Project
aemerson updated the diff for D71581: [X86] Fix an 8 bit testb being selected when folding a volatile i32 load pattern..

Update patch to use !isSimple() instead of isVolatile().

Mon, Jan 6, 11:22 AM · Restricted Project

Mon, Dec 23

aemerson added inline comments to D71581: [X86] Fix an 8 bit testb being selected when folding a volatile i32 load pattern..
Mon, Dec 23, 9:51 PM · Restricted Project

Dec 16 2019

aemerson created D71581: [X86] Fix an 8 bit testb being selected when folding a volatile i32 load pattern..
Dec 16 2019, 4:34 PM · Restricted Project
aemerson added a comment to D70465: [Win64] Handle FP arguments more gracefully under -mno-sse.
In D70465#1776252, @rnk wrote:

Any thoughts on this?

Dec 16 2019, 4:25 PM · Restricted Project

Dec 12 2019

aemerson committed rG3ae687d22454: Fix member initialization order in FrontendOptions.h (authored by aemerson).
Fix member initialization order in FrontendOptions.h
Dec 12 2019, 2:23 PM
aemerson committed rGefd5f3b5f809: Merge branch 'llvm.org/master' into upstream-with-swift (authored by aemerson).
Merge branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 1:54 PM
aemerson committed rGd61b6cd33b9e: Merge 'llvm.org/master' into upstream-with-swift (authored by aemerson).
Merge 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 12:40 PM
aemerson committed rG3897af446b9b: Merge 'llvm.org/master' into upstream-with-swift (authored by aemerson).
Merge 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 12:40 PM

Dec 6 2019

aemerson committed rG7ac966240184: [AArch64][GlobalISel] Add missing default statement to a switch in the selector. (authored by aemerson).
[AArch64][GlobalISel] Add missing default statement to a switch in the selector.
Dec 6 2019, 6:05 PM
aemerson added a comment to D71153: [AArch64][GlobalISel] Add support for selection of vector G_SHL with immediates..

Committed aa3c877fb58db238a86e734511bdeed9bc40086c to fix the unused variable warning at AArch64InstructionSelector.cpp:1013

Thanks!

Dec 6 2019, 5:39 PM · Restricted Project
aemerson committed rGc77b44114058: [AArch64][GlobalISel] Add support for selection of vector G_SHL with immediates. (authored by aemerson).
[AArch64][GlobalISel] Add support for selection of vector G_SHL with immediates.
Dec 6 2019, 4:26 PM
aemerson closed D71153: [AArch64][GlobalISel] Add support for selection of vector G_SHL with immediates..
Dec 6 2019, 4:25 PM · Restricted Project
aemerson created D71153: [AArch64][GlobalISel] Add support for selection of vector G_SHL with immediates..
Dec 6 2019, 3:57 PM · Restricted Project
aemerson committed rG84fdd9d7a50b: [X86] Fix prolog/epilog mismatch for stack protectors on win32-macho. (authored by aemerson).
[X86] Fix prolog/epilog mismatch for stack protectors on win32-macho.
Dec 6 2019, 2:53 PM
aemerson closed D71095: [X86] Fix prolog/epilog mismatch for stack protectors on win32-macho..
Dec 6 2019, 2:53 PM · Restricted Project

Dec 5 2019

aemerson created D71095: [X86] Fix prolog/epilog mismatch for stack protectors on win32-macho..
Dec 5 2019, 3:54 PM · Restricted Project

Dec 4 2019

aemerson committed rG28f5ad5801d4: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64. (authored by aemerson).
[GlobalISel] Fix compiler crash lowering G_LOAD in AArch64.
Dec 4 2019, 5:10 PM
aemerson closed D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..
Dec 4 2019, 5:10 PM · Restricted Project

Dec 3 2019

aemerson added a comment to D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..

@aemerson: Thank you very much for accepting. I think I reduced the test case correctly. I needed to use the result of the G_LOAD, or the code was not being generated with the necessary G_TRUNC. I didn't imagine that it was as easy as returning the result. I hope the new test is better than the last.

Also, I don't have permission to merge, what's the next step for me to do? Thanks.

I can commit it for you later, after a few patches you can request commit access for yourself.

Dec 3 2019, 7:41 PM · Restricted Project
aemerson accepted D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..

I think the test can be simplified a bit to not have the extra blocks and just testing the relevant instructions, otherwise LGTM.

Dec 3 2019, 1:40 PM · Restricted Project

Dec 2 2019

aemerson added inline comments to D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..
Dec 2 2019, 5:07 PM · Restricted Project
aemerson added a comment to D70794: [GlobalISel] Fix compiler crash lowering G_LOAD in AArch64..

Could you upload a diff with more context (-U9999)?

Dec 2 2019, 1:48 PM · Restricted Project

Nov 19 2019

aemerson added reviewers for D70465: [Win64] Handle FP arguments more gracefully under -mno-sse: craig.topper, RKSimon.

Adding @craig.topper and @RKSimon to weigh in.

Nov 19 2019, 3:37 PM · Restricted Project
aemerson added a comment to D70465: [Win64] Handle FP arguments more gracefully under -mno-sse.

Is a compiler abort not preferable to generating non-ABI conforming code?

Nov 19 2019, 3:18 PM · Restricted Project
aemerson added a comment to D42512: [X86] When using Win64 ABI, exit with error if SSE is disabled for varargs.

This patch is not correct -- the crash is not with varargs functions specifically, llvm also crashes for a function declared to explicitly take a float/double. The Win64 calling convention code assigns values to xmm registers, but it should not when sse is disabled.

Additionally, this patch unnecessarily breaks calling vararg functions with _integer_ arguments, which in particular, the EDK2 project does, with windows ABI functions and sse disabled. So, since this breaks existing working code, I'm going to revert this change now, and then propose a different change to address the crash.

Nov 19 2019, 2:06 PM · Restricted Project
aemerson committed rGcf823ce4ad9d: [AArch64] Fix MIR test instruction to not have invalid operand. (authored by aemerson).
[AArch64] Fix MIR test instruction to not have invalid operand.
Nov 19 2019, 1:47 PM
aemerson added a comment to D63973: [MachineVerifier] Improve checks of target instructions operands..

I'm inclined to xfail those tests and open bugs for them

Like this?

Nov 19 2019, 1:47 PM · Restricted Project

Nov 13 2019

aemerson accepted D69470: [ExpandReductions] Don't push all intrinsics to the worklist. Just push reductions..

LGTM.

Nov 13 2019, 10:43 PM · Restricted Project

Oct 28 2019

aemerson committed rG0f6ed432d58e: [AArch64][GlobalISel] Fix assertion fail in C++ selection for vector zext of <4… (authored by aemerson).
[AArch64][GlobalISel] Fix assertion fail in C++ selection for vector zext of <4…
Oct 28 2019, 5:53 PM
aemerson added a comment to rGc07fe307b48a: [AArch64][GlobalISel] Simplify zext/sext selection, use MachineIRBuilder. NFC..

Should be fixed in 0f6ed432d58e47e7082bfd44d7b29f3ee54e2642, thanks for the report!

Oct 28 2019, 3:51 PM

Sep 30 2019

aemerson accepted D68043: [AArch64][GlobalISel] Support lowering variadic musttail calls.

LGTM with nit.

Sep 30 2019, 12:52 AM · Restricted Project

Sep 28 2019

aemerson committed rG7d62e480b5c7: [GlobalISel Enable memcpy inlining with optsize. (authored by aemerson).
[GlobalISel Enable memcpy inlining with optsize.
Sep 28 2019, 12:57 AM
aemerson committed rL373143: [GlobalISel Enable memcpy inlining with optsize..
[GlobalISel Enable memcpy inlining with optsize.
Sep 28 2019, 12:57 AM

Sep 27 2019

aemerson committed rG509a4947c911: Add an operand to memory intrinsics to denote the "tail" marker. (authored by aemerson).
Add an operand to memory intrinsics to denote the "tail" marker.
Sep 27 2019, 10:32 PM
aemerson committed rL373140: Add an operand to memory intrinsics to denote the "tail" marker..
Add an operand to memory intrinsics to denote the "tail" marker.
Sep 27 2019, 10:31 PM
aemerson closed D68151: [GlobalISel] Add an operand to memory intrinsics to denote the "tail" marker..
Sep 27 2019, 10:31 PM · Restricted Project
aemerson added a comment to D68151: [GlobalISel] Add an operand to memory intrinsics to denote the "tail" marker..

I'm somewhat worried about this wrt. eventually verifying intrinsics have the correct number of operands

At minimum the verifier should manually check this operand and manually verify these intrinsics

Sep 27 2019, 4:28 PM · Restricted Project
aemerson created D68151: [GlobalISel] Add an operand to memory intrinsics to denote the "tail" marker..
Sep 27 2019, 11:22 AM · Restricted Project

Sep 26 2019

aemerson added inline comments to D68043: [AArch64][GlobalISel] Support lowering variadic musttail calls.
Sep 26 2019, 2:43 PM · Restricted Project

Sep 24 2019

aemerson committed rGf674d7dab1b1: [AArch64][GlobalISel] Tweak legalization rule for G_BSWAP to handle widening… (authored by aemerson).
[AArch64][GlobalISel] Tweak legalization rule for G_BSWAP to handle widening…
Sep 24 2019, 9:57 PM
aemerson committed rL372812: [AArch64][GlobalISel] Tweak legalization rule for G_BSWAP to handle widening….
[AArch64][GlobalISel] Tweak legalization rule for G_BSWAP to handle widening…
Sep 24 2019, 9:51 PM
aemerson accepted D67939: [AArch64][GlobalISel] Choose CCAssignFns per-argument for tail call lowering.

I'm surprised this wasn't covered by an existing test?

Sep 24 2019, 4:25 PM · Restricted Project

Sep 23 2019

aemerson committed rGadec1209e627: [GlobalISel][IRTranslator] Fix switch table lowering to use signed LE not… (authored by aemerson).
[GlobalISel][IRTranslator] Fix switch table lowering to use signed LE not…
Sep 23 2019, 5:09 PM
aemerson committed rL372675: [GlobalISel][IRTranslator] Fix switch table lowering to use signed LE not….
[GlobalISel][IRTranslator] Fix switch table lowering to use signed LE not…
Sep 23 2019, 5:09 PM
aemerson added a comment to D67133: [GlobalISel]: Fix some non determinism exposed in CSE due to not notifying observers about mutations + add verification for CSE.

Ping. Can we combine the delegate and observer installers?

Thanks Amara for the feedback. The reason I haven't responded here (or committed this) is that I haven't had the chance to track and fix the issues in the various backends where this fails (probably missing Observer calls). Maybe for now, I will disable the verification by default and get this patch in, and we can work on enabling it by default in a follow up patch?

Sep 23 2019, 4:02 PM · Restricted Project

Sep 21 2019

aemerson committed rG9c7d599dec9c: [AArch64][GlobalISel] Implement selection for G_SHL of <2 x i64> (authored by aemerson).
[AArch64][GlobalISel] Implement selection for G_SHL of <2 x i64>
Sep 21 2019, 2:21 AM
aemerson committed rGa59a886832bd: [AArch64][GlobalISel] Selection support for G_ASHR of <2 x s64> (authored by aemerson).
[AArch64][GlobalISel] Selection support for G_ASHR of <2 x s64>
Sep 21 2019, 2:21 AM
aemerson committed rGfae979bc682b: [AArch64][GlobalISel] Make <4 x s32> G_ASHR and G_LSHR legal. (authored by aemerson).
[AArch64][GlobalISel] Make <4 x s32> G_ASHR and G_LSHR legal.
Sep 21 2019, 2:21 AM
aemerson committed rL372467: [AArch64][GlobalISel] Implement selection for G_SHL of <2 x i64>.
[AArch64][GlobalISel] Implement selection for G_SHL of <2 x i64>
Sep 21 2019, 2:19 AM
aemerson committed rL372466: [AArch64][GlobalISel] Selection support for G_ASHR of <2 x s64>.
[AArch64][GlobalISel] Selection support for G_ASHR of <2 x s64>
Sep 21 2019, 2:19 AM
aemerson committed rL372465: [AArch64][GlobalISel] Make <4 x s32> G_ASHR and G_LSHR legal..
[AArch64][GlobalISel] Make <4 x s32> G_ASHR and G_LSHR legal.
Sep 21 2019, 2:19 AM
aemerson committed rG3bb56fa47890: Revert "[SampleFDO] Expose an interface to return the size of a section or the… (authored by aemerson).
Revert "[SampleFDO] Expose an interface to return the size of a section or the…
Sep 21 2019, 2:12 AM
aemerson added a reverting change for rGf118852046a1: [SampleFDO] Expose an interface to return the size of a section or the size of…: rG3bb56fa47890: Revert "[SampleFDO] Expose an interface to return the size of a section or the….
Sep 21 2019, 2:11 AM
aemerson committed rL372464: Revert "[SampleFDO] Expose an interface to return the size of a section or the….
Revert "[SampleFDO] Expose an interface to return the size of a section or the…
Sep 21 2019, 2:11 AM

Sep 20 2019

aemerson committed rG7ac1039957f9: [GlobalISel] Defer setting HasCalls on MachineFrameInfo to selection time. (authored by aemerson).
[GlobalISel] Defer setting HasCalls on MachineFrameInfo to selection time.
Sep 20 2019, 4:52 PM
aemerson committed rL372443: [GlobalISel] Defer setting HasCalls on MachineFrameInfo to selection time..
[GlobalISel] Defer setting HasCalls on MachineFrameInfo to selection time.
Sep 20 2019, 4:52 PM
aemerson closed D67868: [GlobalISel] Defer setting HasCalls on MachineFrameInfo to selection time..
Sep 20 2019, 4:52 PM · Restricted Project
aemerson created D67868: [GlobalISel] Defer setting HasCalls on MachineFrameInfo to selection time..
Sep 20 2019, 3:59 PM · Restricted Project
aemerson added a comment to D67133: [GlobalISel]: Fix some non determinism exposed in CSE due to not notifying observers about mutations + add verification for CSE.

Ping. Can we combine the delegate and observer installers?

Sep 20 2019, 2:23 PM · Restricted Project

Sep 19 2019

aemerson closed D58232: GlobalISel: Don't materialize immarg arguments to intrinsics.
Sep 19 2019, 1:40 PM