The sea was angry that day, my friends - like an old man trying to send back soup in a deli.
User Details
- User Since
- Sep 9 2013, 3:45 AM (459 w, 2 d)
Mon, Jun 27
LGTM.
I'm curious, did we not already have support for these are part of the SVE2 ACLE implementation?
Tue, Jun 21
Fri, Jun 17
Thu, Jun 16
Wed, Jun 15
Can't the rdsvl immediate be used to do the scaling instead of a shift?
Tue, Jun 14
No further comments from me, LGTM if Cullen approves.
Mon, Jun 13
+ @aprantl
Could you upload with more context (-U9999).
We can revisit the opaque pointers issue later. LGTM otherwise with a nit.
Thu, Jun 9
LGTM.
Wed, Jun 8
May 27 2022
May 19 2022
Hi @craig.topper, this looks like it broke under EXPENSIVE_CHECKS? https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive/22475/
May 17 2022
Can the test be reduced? Do you really need a main()?
May 13 2022
May 9 2022
Only fold undef shifts, not LHS.
May 6 2022
May 5 2022
Actually G_SHL with undef LHS needs to be optimized to zero, not undef.
Mar 14 2022
Mar 12 2022
There's nothing wrong with using the ValueTracking infrastructure, the problem is that the only place we can use IR analysis are during the IRTranslator phase, and we try to avoid doing optimizations there as much as possible. Sometimes that might not be practical, but where we can do like to perform optimizations on generic MIR in combine passes instead.
Mar 7 2022
Thanks for the patch. Unfortunately I see the code that this was ported from in SelectionDAGBuilder does the optimization there because it relies on ValueTracking's matchSelectPattern() infrastructure. @arsenm @foad do you think it's worth it here to replicate that functionality for generic MIR so we can avoid adding this to the IRTranslator?
Feb 22 2022
Feb 20 2022
Feb 16 2022
LGTM.
Jan 12 2022
I have no strong preference of whether we emit a copy or not FWIW.
LGTM.
Jan 10 2022
Dec 17 2021
LGTM with the test nit unless anyone else has objections.
Dec 9 2021
Dec 6 2021
Thanks for the feedback folks. To be honest I don't have the time right now to discuss and redesign the whole thing with David (have some parental leave coming up as well). If anyone else wants to pick this up and continue it feel free to do so, I published the patches to help other people with their debugging problems, but unless someone else picks this up and works to reach a consensus on design, it will have to lie unmaintained as a patch for Q1/Q2 next year at least.
Nov 30 2021
LGTM, thanks.
LGTM. Can you rewrite the patch description for the commit message to more clearly explain what the actual problem this is solving too?
Nov 22 2021
We haven’t changed the meaning of the MIR, we just clarified the existing semantics on the RFC thread. There’s no middle ground here as far as I can see, either it’s valid to have undefined uses or not. If it is, then we’re free to do anything that leaves them around.
Nov 16 2021
Nov 15 2021
Nov 11 2021
I think that restricting it to only allow bisection across translation units would be artificially constraining the functionality to not step on the toes of other features. That in itself doesn't seem the right approach, because the simplest thing right now is to support arbitrary bisection granularities. If we constrained it to only allow bisection down to TUs, then we haven't really simplified or re-used any code, all we've done is to make the user experience worse.
Nov 9 2021
Nov 3 2021
LGTM.
Nov 2 2021
D113031 contains an example of a client for this in GlobalISel.
Oct 31 2021
Oct 29 2021
Oct 19 2021
Oct 18 2021
Please see the discussion here: https://groups.google.com/g/llvm-dev/c/R9lSoAqh5e4
Oct 15 2021
Oct 13 2021
Oct 12 2021
Oct 11 2021
Hoist end iterator eval in loop. Rebase on test check regeneration.
Oct 10 2021
Oct 9 2021
Oct 8 2021
Oct 7 2021
Oops sorry about that, I didn't realize this was already on my branch when I committed 72ce310bf0de so this went in by mistake.