The sea was angry that day, my friends - like an old man trying to send back soup in a deli.
- User Since
- Sep 9 2013, 3:45 AM (297 w, 1 d)
Can you post the actual performance results? It's hard to judge whether 0.3% cost across the entire compiler is acceptable without knowing the benefits.
Fri, May 17
Thu, May 16
LGTM if no one else has comments.
Mon, May 13
Fair enough, I've reverted this in r360589. The test case seemed cumbersome to reduce and commit just for a threshold change, but I'm not sure what the best approach is here yet beyond a depth limit change.
Fri, May 10
Thu, May 9
Wed, May 8
Mon, May 6
Sun, Apr 28
Apr 20 2019
Apr 19 2019
Apr 18 2019
Apr 17 2019
Yep, in that case might as well remove the entire helper.
Apr 16 2019
Apr 15 2019
New and improved patch.
Reviving this as the overall approach was fine, it seems the alignment of non pow2 types is assumed to be the alignment of the next largest pow-2 type, so we don't need to worry about alignment during the breakdown.
Apr 14 2019
Apr 12 2019
Yep, forgot to git add it. It's in this new diff, but I'll add it as a separate commit. Ok to proceed?
New patch uses a new CSEConfigBase class as the interface between TargetPassConfig and GlobalISel targets, since CodeGen can't depend on the GlobalISel lib.
Apr 11 2019
Fixed the places where custom legalization was not using full CSE.
Apr 10 2019
Updated patch to not use the custom legalization for non-p0 vectors.