Compilers at a fruit company
- User Since
- Sep 9 2013, 3:45 AM (289 w, 17 h)
Fri, Mar 22
This looks quite involved as the scalar intrinsics have illegal types etc, and at the moment I don't have a lot of time to spend on this, it was just intended as a fix for the unstable tests: http://lab.llvm.org:8011/builders/clang-cmake-aarch64-lld/builds/6257
Thu, Mar 21
Re-wording and making it more explicit who this is for.
Simplify logic and don't try to upgrade if IR is invalid.
I've put up a langref change as a separate review: D59657
Minor test tweak.
Wed, Mar 20
Tue, Mar 19
Mon, Mar 18
In that case I'll revert r356304 keeping in mind that we should take care not to enable COPY CSE in the selector in future, as it won't be subreg safe.
Fri, Mar 15
Committed in r356213
Thu, Mar 14
Can you switch to using MachineIRBuilder before committing.
Wed, Mar 13
Mon, Mar 11
Fri, Mar 8
Thu, Mar 7
LGTM, can you rename the test to something more specific like "fallback-ambiguous-addp-intrinsic.mir"
Wed, Mar 6
Tue, Mar 5
Mon, Mar 4
Since we can't use the proposed alternatives of -nolibc and -nostdlib++ reviving this patch as an Apple specific flag.
LGTM, though eventually we might want to change scalarizations to more efficient expansion lowerings.
LGTM with small change.
Sun, Mar 3
What about expanding the reductions into shuffle vector sequences? If we add support for that, such that the resulting constructed SDAG would be the same as the IR expansion shuffle vector sequence, then we pave the way for a move to using the intrinsics for all targets as the canonical form. So what we'd do is:
- Add the expansion to shuffle vector sequences (instead of a naive implementation)
- Move targets to use the intrinsic representation unconditionally. This means we don't need the useReductionIntrinsic TTI took any more. Targets' TargetLowering would need to specify which reduction kinds to expand using the new SDAG expansion code.
- ...and as a result we can kill the ExpandReductions pass and finally move these intrinsics from experimental to fully supported and preferred representations.
Thu, Feb 28
Tue, Feb 26
Explicitly check for valid element sizes or error out if not valid.
Mon, Feb 25
Feb 22 2019
Please add a test for regbank select.
I see. LGTM then.
Why is it valid for instructions to reference a dead frame index?
Feb 21 2019
Apart from the aforementioned refactorings which can be done later, using MachineIRBuilder would also simplify some the code.
Feb 20 2019
Addressed review comments. Also add an extra legalization check for source vector types being the same as the dest, this broke a lit test I missed.