The sea was angry that day, my friends - like an old man trying to send back soup in a deli.
- User Since
- Sep 9 2013, 3:45 AM (331 w, 5 d)
Those restrictions are target specific though aren’t they? I think it’s the responsibility of ISel to generate valid copies and similar should apply to PHIs.
Thu, Jan 16
I think in cases where it's possible to use an fmov with immediate:
Wed, Jan 15
Fixed in 2e39ea726e9.
Sorry about that. I've pushed a fixed version in 2e39ea726e9.
Tue, Jan 14
Mon, Jan 13
Fri, Jan 10
On the topic of this particular change: IIRC the semantics of bitcast is that it's equivalent of doing a store of the source type and a load of the dest type, which can have differing results on big endian targets. Is this lowering code safe in that case?
Ah, I didn't realize it was allowed in the IR. In that case AArch64 can move to using that instead.
- Allow casts between pointers and others types. This will need documenting as differing from the corresponding IR instructions. This should also maybe restrict this for nonintegral address spaces?
- Disallow bitcast between vectors of pointers and vectors of scalars and match the IR
On AArch64 we also use bitcast to convert from <n x p0> to <n x s64> types.
Thu, Jan 9
No objections for a week, LGTM.
LGTM with some minor comments.
Wed, Jan 8
Tue, Jan 7
Mon, Jan 6
Since you're introducing a new opcode for this, can't we implement a Lower action? Daniel mentioned a while ago that he also prefers having targets explicitly opt-in to using default lowerings/expansions.
Looks reasonable to me.
Update patch to use !isSimple() instead of isVolatile().
Mon, Dec 23
Dec 16 2019
Dec 12 2019
Dec 6 2019
Dec 5 2019
Dec 4 2019
Dec 3 2019
I can commit it for you later, after a few patches you can request commit access for yourself.
I think the test can be simplified a bit to not have the extra blocks and just testing the relevant instructions, otherwise LGTM.
Dec 2 2019
Could you upload a diff with more context (-U9999)?
Nov 19 2019
Is a compiler abort not preferable to generating non-ABI conforming code?
Nov 13 2019
Oct 28 2019
Should be fixed in 0f6ed432d58e47e7082bfd44d7b29f3ee54e2642, thanks for the report!
Sep 30 2019
LGTM with nit.
Sep 28 2019
Sep 27 2019
Sep 26 2019
Sep 24 2019
I'm surprised this wasn't covered by an existing test?
Sep 23 2019
Sep 21 2019
Sep 20 2019
Ping. Can we combine the delegate and observer installers?