Page MenuHomePhabricator

paulwalker-arm (Paul Walker)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 24 2016, 5:21 AM (165 w, 6 d)

Recent Activity

Dec 20 2019

paulwalker-arm created D71767: [POC][SVE] Allow code generation for fixed length vectorised loops [Patch 2/2]..
Dec 20 2019, 6:48 AM · Restricted Project
paulwalker-arm committed rG6cba90dc4de6: [AArch64][SVE] Correct intrinsics and patterns for logical predicate… (authored by paulwalker-arm).
[AArch64][SVE] Correct intrinsics and patterns for logical predicate…
Dec 20 2019, 6:38 AM
paulwalker-arm closed D71715: [AArch64][SVE] Correct intrinsics and patterns for logical predicate instructions.
Dec 20 2019, 6:38 AM · Restricted Project
paulwalker-arm updated the summary of D71760: [POC][SVE] Allow code generation for fixed length vectorised loops [Patch 1/2]..
Dec 20 2019, 6:38 AM · Restricted Project
paulwalker-arm created D71760: [POC][SVE] Allow code generation for fixed length vectorised loops [Patch 1/2]..
Dec 20 2019, 6:30 AM · Restricted Project
paulwalker-arm added a comment to D71636: [AArch64][SVE][WIP] Add support for vscale constants (?).

Can we guarantee "sizeof(<vscale x 1 x i8>) == vscale" for all future targets? much like how "sizeof(<vscale x 1 x i1>) == vscale" doesn't hold true for SVE. If not then this isn't a canonical form as the exact pattern becomes target specific. Or to put another, why should vscale be linked to data layout?

Dec 20 2019, 4:02 AM · Restricted Project

Dec 19 2019

paulwalker-arm added a comment to D71636: [AArch64][SVE][WIP] Add support for vscale constants (?).

Given this establishes that adding the scalable vector type has inadvertently created a way to represent the runtime constant of vscale as a constant, what's the downside to having a clearer representation in the form of an explicit constant?

Dec 19 2019, 1:03 PM · Restricted Project
paulwalker-arm created D71715: [AArch64][SVE] Correct intrinsics and patterns for logical predicate instructions.
Dec 19 2019, 9:43 AM · Restricted Project

Aug 17 2019

paulwalker-arm added a comment to D66337: [AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta instructions..

I've committed a better fix in r369138.

Aug 17 2019, 2:28 AM · Restricted Project
paulwalker-arm committed rG26295676a44d: Revert Revert [AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for… (authored by paulwalker-arm).
Revert Revert [AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for…
Aug 17 2019, 2:23 AM
paulwalker-arm committed rG93c7a4a47cc2: Revert [AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta… (authored by paulwalker-arm).
Revert [AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta…
Aug 17 2019, 2:23 AM

Aug 16 2019

paulwalker-arm committed rG2632c677f85c: [AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta… (authored by paulwalker-arm).
[AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta…
Aug 16 2019, 10:33 AM
paulwalker-arm committed rG19301d75f086: Revert [AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta… (authored by paulwalker-arm).
Revert [AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta…
Aug 16 2019, 10:33 AM
paulwalker-arm added a comment to D66337: [AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta instructions..

Thanks for the report, I've committed a version without the %s that will hopefully fix the issue.

Aug 16 2019, 10:32 AM · Restricted Project
paulwalker-arm committed rG3ccee5f7c408: [AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta… (authored by paulwalker-arm).
[AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta…
Aug 16 2019, 7:18 AM
paulwalker-arm added a comment to D66337: [AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta instructions..

Have I got the terminology the wrong way round? I assumed relaxing meant the act of converting a branch who destination is not within range into a one that is within range either by inversion or introducing a second branch with sufficient range. I just want to make sure my commit message makes sense.

Aug 16 2019, 4:14 AM · Restricted Project
paulwalker-arm created D66337: [AArch64InstrInfo] Stop getInstSizeInBytes returning non-zero for meta instructions..
Aug 16 2019, 2:57 AM · Restricted Project

Aug 17 2018

paulwalker-arm added a comment to D50900: [SimplifyLibCalls] Support pow(x, -0.5) in replacePowWithSqrt without NSZ/noInfs..

There is this nugget from the C documentation:

Aug 17 2018, 7:44 AM

Apr 30 2018

paulwalker-arm abandoned D45770: [AArch64] Disable spill slot scavenging when stack realignment required..

I also prefer Geoff's solution. Thanks Geoff.

Apr 30 2018, 8:05 AM

Apr 19 2018

paulwalker-arm added a comment to D45770: [AArch64] Disable spill slot scavenging when stack realignment required..

Ugh, good find. Isn't this an issue if variable sized stack objects are present as well?

Apr 19 2018, 8:14 AM

Apr 18 2018

paulwalker-arm created D45770: [AArch64] Disable spill slot scavenging when stack realignment required..
Apr 18 2018, 6:44 AM
paulwalker-arm created D45769: Fix typo in static_assert for size of LoadSDNodeBitfields..
Apr 18 2018, 6:32 AM

Dec 19 2017

paulwalker-arm added inline comments to D40299: [Complex] Don't use __div?c3 when building with fast-math..
Dec 19 2017, 7:52 AM
paulwalker-arm updated the diff for D40299: [Complex] Don't use __div?c3 when building with fast-math..

Query LangOpts for FastMast rather than IRBuilder and fleshed out the tests.

Dec 19 2017, 7:46 AM

Dec 15 2017

paulwalker-arm added a comment to D40069: [SimplifyLibCall] Inline calls to cabs when it's safe to do so..

Not yet.

Dec 15 2017, 7:46 AM
paulwalker-arm updated the diff for D40069: [SimplifyLibCall] Inline calls to cabs when it's safe to do so..

Adds support for versions of cabs that take discrete real and imaginary parameters.

Dec 15 2017, 7:32 AM

Nov 30 2017

paulwalker-arm updated the diff for D40012: [InstSimplify] More fcmp cases when comparing against negative constants..

Removed three instcombine tests that are either covered by existing instsimplify tests of have equivalent instsimplify tests provided by this patch.

Nov 30 2017, 10:17 AM

Nov 29 2017

paulwalker-arm added inline comments to D40012: [InstSimplify] More fcmp cases when comparing against negative constants..
Nov 29 2017, 8:57 AM
paulwalker-arm updated the diff for D40012: [InstSimplify] More fcmp cases when comparing against negative constants..

Extended to cover une and oeq conditions. Added an assert to protect against unintentional refactoring and a TODO for future improvements.

Nov 29 2017, 6:14 AM

Nov 28 2017

paulwalker-arm added a comment to D40012: [InstSimplify] More fcmp cases when comparing against negative constants..

Good point, I'll add the extra conditions along with the TODO.

Nov 28 2017, 9:37 AM
paulwalker-arm updated the diff for D40012: [InstSimplify] More fcmp cases when comparing against negative constants..

Broke out the isNegative case into its own block so that more conditions can be handled when it's known the constant is non-zero. Removed my original tests and updated the existing ones to reflect the optimised output.

Nov 28 2017, 9:20 AM

Nov 21 2017

paulwalker-arm created D40299: [Complex] Don't use __div?c3 when building with fast-math..
Nov 21 2017, 5:41 AM

Nov 15 2017

paulwalker-arm updated subscribers of D40012: [InstSimplify] More fcmp cases when comparing against negative constants..
Nov 15 2017, 2:55 AM
paulwalker-arm updated subscribers of D40069: [SimplifyLibCall] Inline calls to cabs when it's safe to do so..
Nov 15 2017, 2:55 AM
paulwalker-arm created D40069: [SimplifyLibCall] Inline calls to cabs when it's safe to do so..
Nov 15 2017, 2:46 AM

Nov 14 2017

paulwalker-arm created D40012: [InstSimplify] More fcmp cases when comparing against negative constants..
Nov 14 2017, 2:58 AM

Oct 11 2017

paulwalker-arm added inline comments to D38734: [MachineCombiner] Fix initialisation of LastUpdate for incremental update..
Oct 11 2017, 4:48 AM
paulwalker-arm updated the diff for D38734: [MachineCombiner] Fix initialisation of LastUpdate for incremental update..

As requested I've simplified the patch's mir test.

Oct 11 2017, 2:56 AM

Oct 10 2017

paulwalker-arm created D38734: [MachineCombiner] Fix initialisation of LastUpdate for incremental update..
Oct 10 2017, 7:52 AM

May 11 2017

paulwalker-arm abandoned D27101: [Type] Extend VectorType to support scalable vectors. [IR support for SVE scalable vectors 1/4].
May 11 2017, 4:22 AM
paulwalker-arm abandoned D27102: [Constants] Add scalable vector support to ConstantVector::getSplat. [IR support for SVE scalable vectors 2/4].
May 11 2017, 4:22 AM
paulwalker-arm abandoned D27103: [Constants] Represent the runtime length of a scalable vector. [IR support for SVE scalable vectors 3/4].
May 11 2017, 4:22 AM
paulwalker-arm abandoned D27105: [Constants] Add "stepvector" to represent the sequence 0,1,2,3... [IR support for SVE scalable vectors 4/4].
May 11 2017, 4:21 AM

Nov 29 2016

paulwalker-arm added a reviewer for D27102: [Constants] Add scalable vector support to ConstantVector::getSplat. [IR support for SVE scalable vectors 2/4]: chandlerc.
Nov 29 2016, 9:55 AM

Nov 24 2016

paulwalker-arm added a reviewer for D27101: [Type] Extend VectorType to support scalable vectors. [IR support for SVE scalable vectors 1/4]: mkuper.
Nov 24 2016, 7:26 AM
paulwalker-arm retitled D27105: [Constants] Add "stepvector" to represent the sequence 0,1,2,3... [IR support for SVE scalable vectors 4/4] from to [Constants] Add "stepvector" to represent the sequence 0,1,2,3... [IR support for SVE scalable vectors 4/4].
Nov 24 2016, 7:25 AM
paulwalker-arm retitled D27103: [Constants] Represent the runtime length of a scalable vector. [IR support for SVE scalable vectors 3/4] from to [Constants] Represent the runtime length of a scalable vector. [IR support for SVE scalable vectors 3/4].
Nov 24 2016, 7:20 AM
paulwalker-arm retitled D27102: [Constants] Add scalable vector support to ConstantVector::getSplat. [IR support for SVE scalable vectors 2/4] from to [Constants] Add scalable vector support to ConstantVector::getSplat. [IR support for SVE scalable vectors 2/4].
Nov 24 2016, 7:05 AM
paulwalker-arm retitled D27101: [Type] Extend VectorType to support scalable vectors. [IR support for SVE scalable vectors 1/4] from to [Type] Extend VectorType to support scalable vectors. [IR support for SVE scalable vectors 1/4].
Nov 24 2016, 6:41 AM