Page MenuHomePhabricator

david-arm (David Sherwood)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 20 2019, 6:41 AM (32 w, 5 d)

Recent Activity

Today

david-arm added a comment to D83137: [SVE][CodeGen] Legalisation of masked loads and stores.

The patch overall looks good to me - just a question about the assert!

Tue, Jul 7, 1:44 AM · Restricted Project
david-arm committed rG9a1a7d888b53: [SVE] Add more warnings checks to clang and LLVM SVE tests (authored by david-arm).
[SVE] Add more warnings checks to clang and LLVM SVE tests
Tue, Jul 7, 1:39 AM
david-arm closed D82943: [SVE] Add more warnings checks to clang and LLVM SVE tests.
Tue, Jul 7, 1:39 AM · Restricted Project, Restricted Project
david-arm committed rG79d34a5a1bce: [SVE][CodeGen] Fix bug when falling back to DAG ISel (authored by david-arm).
[SVE][CodeGen] Fix bug when falling back to DAG ISel
Tue, Jul 7, 1:32 AM
david-arm closed D82524: [SVE][CodeGen] Fix bug when falling back to DAG ISel.
Tue, Jul 7, 1:32 AM · Restricted Project
david-arm committed rGc061e56e880a: [CodeGen] Fix warnings in sve-vector-splat.ll and sve-trunc.ll (authored by david-arm).
[CodeGen] Fix warnings in sve-vector-splat.ll and sve-trunc.ll
Tue, Jul 7, 1:22 AM
david-arm closed D83028: [CodeGen] Fix warnings in sve-vector-splat.ll and sve-trunc.ll.
Tue, Jul 7, 1:22 AM · Restricted Project
david-arm updated the diff for D83196: [CodeGen] Fix a warning in DAGTypeLegalizer::SetSplitVector.
Tue, Jul 7, 12:02 AM · Restricted Project

Yesterday

david-arm updated the diff for D83205: [SVE] Add checks for no warnings in CodeGen/AArch64/sve-sext-zext.ll.
Mon, Jul 6, 11:56 PM · Restricted Project
david-arm updated the diff for D83203: [CodeGen] Fix warnings in SelectionDAG::SplitVector.
Mon, Jul 6, 11:56 PM · Restricted Project
david-arm updated the diff for D83198: [CodeGen] Fix warnings in DAGTypeLegalizer::SplitVecOp_EXTRACT_SUBVECTOR.
Mon, Jul 6, 11:55 PM · Restricted Project
david-arm updated the diff for D83197: [CodeGen] Fix warning in DAGTypeLegalizer::SplitVecRes_ExtendOp.
Mon, Jul 6, 11:54 PM · Restricted Project
david-arm updated the diff for D83195: [CodeGen] Fix a warning in DAGTypeLegalizer::PromoteIntRes_EXTRACT_SUBVECTOR.
Mon, Jul 6, 11:51 PM · Restricted Project
david-arm accepted D83125: [AArch64][SVE] Remove erroneous assert in resolveFrameOffsetReference.

LGTM!

Mon, Jul 6, 3:56 AM · Restricted Project
david-arm added reviewers for D83196: [CodeGen] Fix a warning in DAGTypeLegalizer::SetSplitVector: sdesmalen, ctetreau, c-rhodes.
Mon, Jul 6, 3:00 AM · Restricted Project
david-arm added reviewers for D83195: [CodeGen] Fix a warning in DAGTypeLegalizer::PromoteIntRes_EXTRACT_SUBVECTOR: sdesmalen, efriedma, fpetrogalli.
Mon, Jul 6, 3:00 AM · Restricted Project
david-arm added reviewers for D83203: [CodeGen] Fix warnings in SelectionDAG::SplitVector: sdesmalen, ctetreau, kmclaughlin.
Mon, Jul 6, 2:59 AM · Restricted Project
david-arm added reviewers for D83197: [CodeGen] Fix warning in DAGTypeLegalizer::SplitVecRes_ExtendOp: sdesmalen, efriedma, c-rhodes.
Mon, Jul 6, 2:59 AM · Restricted Project
david-arm added reviewers for D83198: [CodeGen] Fix warnings in DAGTypeLegalizer::SplitVecOp_EXTRACT_SUBVECTOR: sdesmalen, ctetreau, fpetrogalli.
Mon, Jul 6, 2:58 AM · Restricted Project
david-arm added reviewers for D83205: [SVE] Add checks for no warnings in CodeGen/AArch64/sve-sext-zext.ll: sdesmalen, kmclaughlin.
Mon, Jul 6, 2:58 AM · Restricted Project
david-arm added parent revisions for D83205: [SVE] Add checks for no warnings in CodeGen/AArch64/sve-sext-zext.ll: D83198: [CodeGen] Fix warnings in DAGTypeLegalizer::SplitVecOp_EXTRACT_SUBVECTOR, D83197: [CodeGen] Fix warning in DAGTypeLegalizer::SplitVecRes_ExtendOp, D83203: [CodeGen] Fix warnings in SelectionDAG::SplitVector, D83195: [CodeGen] Fix a warning in DAGTypeLegalizer::PromoteIntRes_EXTRACT_SUBVECTOR, D83196: [CodeGen] Fix a warning in DAGTypeLegalizer::SetSplitVector.
Mon, Jul 6, 2:56 AM · Restricted Project
Herald added a project to D83205: [SVE] Add checks for no warnings in CodeGen/AArch64/sve-sext-zext.ll: Restricted Project.
Mon, Jul 6, 2:54 AM · Restricted Project
Herald added a project to D83203: [CodeGen] Fix warnings in SelectionDAG::SplitVector: Restricted Project.
Mon, Jul 6, 2:38 AM · Restricted Project
Herald added a project to D83198: [CodeGen] Fix warnings in DAGTypeLegalizer::SplitVecOp_EXTRACT_SUBVECTOR: Restricted Project.
Mon, Jul 6, 2:01 AM · Restricted Project
Herald added a project to D83197: [CodeGen] Fix warning in DAGTypeLegalizer::SplitVecRes_ExtendOp: Restricted Project.
Mon, Jul 6, 1:55 AM · Restricted Project
Herald added a project to D83196: [CodeGen] Fix a warning in DAGTypeLegalizer::SetSplitVector: Restricted Project.
Mon, Jul 6, 1:51 AM · Restricted Project
Herald added a project to D83195: [CodeGen] Fix a warning in DAGTypeLegalizer::PromoteIntRes_EXTRACT_SUBVECTOR: Restricted Project.
Mon, Jul 6, 1:47 AM · Restricted Project

Fri, Jul 3

david-arm created D83124: [CodeGen] Fix warnings in sve-ld1-addressing-mode-reg-imm.ll.
Fri, Jul 3, 4:16 AM · Restricted Project

Thu, Jul 2

david-arm accepted D83041: [SVE][CodeGen] Legalisation of unpredicated store instructions.

LGTM, but good to let other reviewers have a look too!

Thu, Jul 2, 8:37 AM · Restricted Project
david-arm added inline comments to D82524: [SVE][CodeGen] Fix bug when falling back to DAG ISel.
Thu, Jul 2, 6:25 AM · Restricted Project
david-arm updated the diff for D82524: [SVE][CodeGen] Fix bug when falling back to DAG ISel.
Thu, Jul 2, 6:25 AM · Restricted Project
david-arm accepted D83029: [SVE] Fix invalid assert in expand_DestructiveOp..
Thu, Jul 2, 4:15 AM · Restricted Project
david-arm accepted D83001: [SVE] Make cstfp_pred_ty and cst_pred_ty work with scalable splats.
Thu, Jul 2, 4:15 AM · Restricted Project
david-arm committed rG00f5921609a5: [SVE] Add warnings checks in four more LLVM SVE tests (authored by david-arm).
[SVE] Add warnings checks in four more LLVM SVE tests
Thu, Jul 2, 3:10 AM
david-arm closed D82957: [SVE] Add warnings checks in four more LLVM SVE tests.
Thu, Jul 2, 3:10 AM · Restricted Project
david-arm created D83028: [CodeGen] Fix warnings in sve-vector-splat.ll and sve-trunc.ll.
Thu, Jul 2, 3:10 AM · Restricted Project
david-arm accepted D82792: [SVE][CodeGen] Legalisation of unpredicated load instructions.

LGTM!

Thu, Jul 2, 2:38 AM · Restricted Project
david-arm committed rGc7df35d2b28e: [CodeGen] Fix warnings in getCopyToPartsVector (authored by david-arm).
[CodeGen] Fix warnings in getCopyToPartsVector
Thu, Jul 2, 1:34 AM
david-arm closed D82744: [CodeGen] Fix warnings in getCopyToPartsVector.
Thu, Jul 2, 1:34 AM · Restricted Project

Wed, Jul 1

david-arm committed rGf11305780f08: [CodeGen] Fix warnings in DAGCombiner::visitSCALAR_TO_VECTOR (authored by david-arm).
[CodeGen] Fix warnings in DAGCombiner::visitSCALAR_TO_VECTOR
Wed, Jul 1, 10:50 AM
david-arm closed D82872: [CodeGen] Fix warnings in DAGCombiner::visitSCALAR_TO_VECTOR.
Wed, Jul 1, 10:50 AM · Restricted Project
david-arm committed rG97a7a9abb25d: [CodeGen] Fix up warnings in visitEXTRACT_SUBVECTOR (authored by david-arm).
[CodeGen] Fix up warnings in visitEXTRACT_SUBVECTOR
Wed, Jul 1, 7:33 AM
david-arm closed D82655: [CodeGen] Fix up warnings in visitEXTRACT_SUBVECTOR.
Wed, Jul 1, 7:33 AM · Restricted Project
david-arm added parent revisions for D82957: [SVE] Add warnings checks in four more LLVM SVE tests: D82655: [CodeGen] Fix up warnings in visitEXTRACT_SUBVECTOR, D82744: [CodeGen] Fix warnings in getCopyToPartsVector.
Wed, Jul 1, 7:00 AM · Restricted Project
david-arm removed a parent revision for D82655: [CodeGen] Fix up warnings in visitEXTRACT_SUBVECTOR: D82957: [SVE] Add warnings checks in four more LLVM SVE tests.
Wed, Jul 1, 7:00 AM · Restricted Project
david-arm added a child revision for D82655: [CodeGen] Fix up warnings in visitEXTRACT_SUBVECTOR: D82957: [SVE] Add warnings checks in four more LLVM SVE tests.
Wed, Jul 1, 7:00 AM · Restricted Project
david-arm removed child revisions for D82957: [SVE] Add warnings checks in four more LLVM SVE tests: D82744: [CodeGen] Fix warnings in getCopyToPartsVector, D82655: [CodeGen] Fix up warnings in visitEXTRACT_SUBVECTOR.
Wed, Jul 1, 7:00 AM · Restricted Project
david-arm removed a parent revision for D82744: [CodeGen] Fix warnings in getCopyToPartsVector: D82957: [SVE] Add warnings checks in four more LLVM SVE tests.
Wed, Jul 1, 7:00 AM · Restricted Project
david-arm added a child revision for D82744: [CodeGen] Fix warnings in getCopyToPartsVector: D82957: [SVE] Add warnings checks in four more LLVM SVE tests.
Wed, Jul 1, 7:00 AM · Restricted Project
david-arm added reviewers for D82957: [SVE] Add warnings checks in four more LLVM SVE tests: c-rhodes, sdesmalen.

These tests will currently fail as they depend upon the child revisions being committed.

Wed, Jul 1, 7:00 AM · Restricted Project
david-arm added a parent revision for D82744: [CodeGen] Fix warnings in getCopyToPartsVector: D82957: [SVE] Add warnings checks in four more LLVM SVE tests.
Wed, Jul 1, 7:00 AM · Restricted Project
david-arm added child revisions for D82957: [SVE] Add warnings checks in four more LLVM SVE tests: D82655: [CodeGen] Fix up warnings in visitEXTRACT_SUBVECTOR, D82744: [CodeGen] Fix warnings in getCopyToPartsVector.
Wed, Jul 1, 7:00 AM · Restricted Project
david-arm added a parent revision for D82655: [CodeGen] Fix up warnings in visitEXTRACT_SUBVECTOR: D82957: [SVE] Add warnings checks in four more LLVM SVE tests.
Wed, Jul 1, 7:00 AM · Restricted Project
david-arm created D82957: [SVE] Add warnings checks in four more LLVM SVE tests.
Wed, Jul 1, 7:00 AM · Restricted Project
david-arm created D82943: [SVE] Add more warnings checks to clang and LLVM SVE tests.
Wed, Jul 1, 3:12 AM · Restricted Project, Restricted Project
david-arm added a comment to D82872: [CodeGen] Fix warnings in DAGCombiner::visitSCALAR_TO_VECTOR.
  • Added extra check that SCALAR_TO_VECTOR result type is also a fixed length vector.
  • Actually added proper CHECK lines to my new test. Sorry about that @efriedma - that was a silly mistake.
Wed, Jul 1, 12:29 AM · Restricted Project
david-arm updated the diff for D82872: [CodeGen] Fix warnings in DAGCombiner::visitSCALAR_TO_VECTOR.
Wed, Jul 1, 12:29 AM · Restricted Project

Tue, Jun 30

david-arm accepted D82214: [SVE] Remove calls to VectorType::getNumElements from AArch64.
Tue, Jun 30, 7:00 AM · Restricted Project
david-arm created D82872: [CodeGen] Fix warnings in DAGCombiner::visitSCALAR_TO_VECTOR.
Tue, Jun 30, 6:28 AM · Restricted Project
david-arm committed rGc02332a69399: [CodeGen] Fix warning in getNode for EXTRACT_SUBVECTOR (authored by david-arm).
[CodeGen] Fix warning in getNode for EXTRACT_SUBVECTOR
Tue, Jun 30, 12:30 AM
david-arm closed D82746: [CodeGen] Fix warning in getNode for EXTRACT_SUBVECTOR.
Tue, Jun 30, 12:30 AM · Restricted Project, Restricted Project
david-arm added a comment to D82746: [CodeGen] Fix warning in getNode for EXTRACT_SUBVECTOR.

Hi @efriedma, sorry yes I forgot to mention in the ticket it fixes an existing warnings in these tests:

Tue, Jun 30, 12:30 AM · Restricted Project, Restricted Project

Mon, Jun 29

david-arm committed rG46a7f4d6f4bf: [SVE][CodeGen] Fix bug in DAGCombiner::reduceBuildVecToShuffle (authored by david-arm).
[SVE][CodeGen] Fix bug in DAGCombiner::reduceBuildVecToShuffle
Mon, Jun 29, 11:57 PM
david-arm closed D82564: [SVE][CodeGen] Fix bug in DAGCombiner::reduceBuildVecToShuffle.
Mon, Jun 29, 11:57 PM · Restricted Project
david-arm abandoned D82375: [SVE] Fix bug in DataLayout::getIndexType.

Looks like it has already been fixed by commit https://reviews.llvm.org/D82061

Mon, Jun 29, 5:21 AM · Restricted Project
david-arm created D82746: [CodeGen] Fix warning in getNode for EXTRACT_SUBVECTOR.
Mon, Jun 29, 2:39 AM · Restricted Project, Restricted Project
david-arm created D82744: [CodeGen] Fix warnings in getCopyToPartsVector.
Mon, Jun 29, 2:39 AM · Restricted Project

Fri, Jun 26

david-arm created D82655: [CodeGen] Fix up warnings in visitEXTRACT_SUBVECTOR.
Fri, Jun 26, 6:30 AM · Restricted Project
david-arm added a comment to D82655: [CodeGen] Fix up warnings in visitEXTRACT_SUBVECTOR.

Please note that I tried my best to find tests that exposed the change in behaviour where I added the fixed length vector check, but to no avail! I put that extra check in anyway as I think the optimisation makes no sense for scalable vector types. All we're doing here is removing an infrequently used (I looked for fixed length vector types hitting this path and there weren't many) optimisation for scalable vector types, so I think so long as no existing tests break it should be ok.

Fri, Jun 26, 6:30 AM · Restricted Project
david-arm committed rGae47d158a096: Remove "rm -f" workaround in acle_sve_adda.c (authored by david-arm).
Remove "rm -f" workaround in acle_sve_adda.c
Fri, Jun 26, 12:31 AM
david-arm added a reviewer for D82524: [SVE][CodeGen] Fix bug when falling back to DAG ISel: aemerson.
Fri, Jun 26, 12:31 AM · Restricted Project
david-arm added a comment to D82329: [SVE] Fix invalid Scalable to fixed width vetor type demotion in LLT.

Hi @aemerson @ctetreau, I have a fix here that prevents us entering this code for scalable types:

Fri, Jun 26, 12:31 AM · Restricted Project
david-arm accepted D82501: [sve][acle] Add reinterpret intrinsics for brain float..

Can you remove the duplicate tests before submitting? Otherwise LGTM!

Fri, Jun 26, 12:31 AM · Restricted Project, Restricted Project

Thu, Jun 25

david-arm committed rG7a834a0a4ee3: [SVE] Fix scalable vector bug in DataLayout::getIntPtrType (authored by david-arm).
[SVE] Fix scalable vector bug in DataLayout::getIntPtrType
Thu, Jun 25, 11:59 PM
david-arm closed D82294: [SVE] Fix scalable vector bug in DataLayout::getIntPtrType.
Thu, Jun 25, 11:59 PM · Restricted Project
david-arm added reviewers for D82564: [SVE][CodeGen] Fix bug in DAGCombiner::reduceBuildVecToShuffle: sdesmalen, c-rhodes, ctetreau.
Thu, Jun 25, 8:34 AM · Restricted Project
david-arm created D82564: [SVE][CodeGen] Fix bug in DAGCombiner::reduceBuildVecToShuffle.
Thu, Jun 25, 8:33 AM · Restricted Project
david-arm added a comment to D82483: [SVE] Code generation for fixed length vector adds..

Hi @paulwalker-arm, ok fair enough. It was just because you said "sve-fixed-length-int-arith.ll" fails due to missing D82466, but there are 4 tests failing. Just making sure these are all due to D82466 that's all. :)

Thu, Jun 25, 8:33 AM · Restricted Project
david-arm added a comment to D82483: [SVE] Code generation for fixed length vector adds..

Hi @paulwalker-arm, are you expecting those four tests to fail on this patch?

Thu, Jun 25, 8:00 AM · Restricted Project
david-arm updated the diff for D82524: [SVE][CodeGen] Fix bug when falling back to DAG ISel.
Thu, Jun 25, 7:25 AM · Restricted Project
david-arm added inline comments to D82214: [SVE] Remove calls to VectorType::getNumElements from AArch64.
Thu, Jun 25, 1:03 AM · Restricted Project
david-arm created D82524: [SVE][CodeGen] Fix bug when falling back to DAG ISel.
Thu, Jun 25, 1:03 AM · Restricted Project

Wed, Jun 24

david-arm committed rGee26a31e7b02: [SVE] Make ConstantFoldGetElementPtr work for scalable vectors of indices (authored by david-arm).
[SVE] Make ConstantFoldGetElementPtr work for scalable vectors of indices
Wed, Jun 24, 11:57 PM
david-arm closed D82183: [SVE] Make ConstantFoldGetElementPtr work for scalable vectors of indices.
Wed, Jun 24, 11:57 PM · Restricted Project
david-arm added inline comments to D82501: [sve][acle] Add reinterpret intrinsics for brain float..
Wed, Jun 24, 11:57 PM · Restricted Project, Restricted Project

Tue, Jun 23

david-arm added inline comments to D81500: [SVE] Remove calls to VectorType::getNumElements from IR.
Tue, Jun 23, 8:31 AM · Restricted Project
david-arm created D82375: [SVE] Fix bug in DataLayout::getIndexType.
Tue, Jun 23, 6:21 AM · Restricted Project
david-arm updated the diff for D82294: [SVE] Fix scalable vector bug in DataLayout::getIntPtrType.
Tue, Jun 23, 1:00 AM · Restricted Project
david-arm added a comment to D82329: [SVE] Fix invalid Scalable to fixed width vetor type demotion in LLT.

Perhaps this change is good enough? We call computeValueLLTs just before lowerFormalArguments, which will detect the scalable type and fall back anyway even if the LLT type is wrong. The other option is to add yet another fallBackOnDAGISel type callback that allows the backend to reject certain types before we create the vregs.

Tue, Jun 23, 1:00 AM · Restricted Project
david-arm added a comment to D82329: [SVE] Fix invalid Scalable to fixed width vetor type demotion in LLT.

This problem occurs in the IRTranslator just before we call lowerFormalArguments (which is currently the earliest point we detect scalable types and fall back to DAG ISel)

Tue, Jun 23, 12:28 AM · Restricted Project
david-arm added a comment to D82329: [SVE] Fix invalid Scalable to fixed width vetor type demotion in LLT.

#7 0x0000ffffa0f26760 llvm::getLLTForType(llvm::Type&, llvm::DataLayout const&) (/lib64/libc.so.6+0x36760)
#8 0x0000000002556f74 llvm::computeValueLLTs(llvm::DataLayout const&, llvm::Type&, llvm::SmallVectorImpl<llvm::LLT>&, llvm::SmallVectorImpl<unsigned long>*, unsigned long) (.localalias) (./bin/llc+0x2556f74)
#9 0x0000000001aeb108 llvm::IRTranslator::getOrCreateVRegs(llvm::Value const&) (.part.0) (./bin/llc+0x1aeb108)
#10 0x00000000019df8a4 llvm::IRTranslator::runOnMachineFunction(llvm::MachineFunction&) (./bin/llc+0x19df8a4)

Tue, Jun 23, 12:28 AM · Restricted Project
david-arm added inline comments to D82298: [AArch64][SVE] Add bfloat16 support to load intrinsics.
Tue, Jun 23, 12:28 AM · Restricted Project, Restricted Project

Mon, Jun 22

david-arm added reviewers for D82294: [SVE] Fix scalable vector bug in DataLayout::getIntPtrType: sdesmalen, c-rhodes.
Mon, Jun 22, 8:02 AM · Restricted Project
david-arm created D82294: [SVE] Fix scalable vector bug in DataLayout::getIntPtrType.
Mon, Jun 22, 6:24 AM · Restricted Project

Sun, Jun 21

david-arm accepted D82209: [SVE] Remove calls to VectorType::getNumElements from Bitcode.
Sun, Jun 21, 11:17 PM · Restricted Project

Fri, Jun 19

david-arm accepted D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics.

LGTM!

Fri, Jun 19, 9:44 AM · Restricted Project, Restricted Project
david-arm updated the diff for D82183: [SVE] Make ConstantFoldGetElementPtr work for scalable vectors of indices.
Fri, Jun 19, 9:12 AM · Restricted Project
david-arm added a comment to D82183: [SVE] Make ConstantFoldGetElementPtr work for scalable vectors of indices.
  • Added full CHECK lines for new test
Fri, Jun 19, 9:12 AM · Restricted Project
david-arm added inline comments to D82183: [SVE] Make ConstantFoldGetElementPtr work for scalable vectors of indices.
Fri, Jun 19, 8:40 AM · Restricted Project
david-arm created D82183: [SVE] Make ConstantFoldGetElementPtr work for scalable vectors of indices.
Fri, Jun 19, 6:59 AM · Restricted Project