Page MenuHomePhabricator

CarolineConcatto (Caroline)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2020, 3:58 AM (71 w, 2 d)

Recent Activity

Yesterday

CarolineConcatto accepted D104244: [SVE] Selection failure with scalable insertelements.

Thank you @DylanFleming-arm
LGTM

Wed, Jun 16, 5:04 AM · Restricted Project
CarolineConcatto added a comment to D104244: [SVE] Selection failure with scalable insertelements.

@DylanFleming-arm
Do you mind expanding your tests to add this ones test_insert_into_undef_<type>
but replacing:

Wed, Jun 16, 1:31 AM · Restricted Project
CarolineConcatto added a comment to D104244: [SVE] Selection failure with scalable insertelements.
Wed, Jun 16, 1:29 AM · Restricted Project

Tue, Jun 15

CarolineConcatto added a comment to D104115: [SVE] Fix PromoteIntRes_TRUNCATE not to call getVectorNumElements.

Hey, is anyone else seeing:
Context not available.
In the files?

Tue, Jun 15, 1:45 AM · Restricted Project
CarolineConcatto added a comment to D104239: [SVE] Fix cast<FixedVectorType> in truncateToMinimalBitwidths.

Hi @DylanFleming-arm
I believe something wrong happened when you uploaded this patch.
It is not showing LoopVectorize.cpp file.
I can only see Context not available.
Is that happening for you too?

Tue, Jun 15, 1:42 AM · Restricted Project

Thu, Jun 10

CarolineConcatto committed rG1ad52105eb88: [InstCombine] Add fold for extracting known elements from a stepvector (authored by CarolineConcatto).
[InstCombine] Add fold for extracting known elements from a stepvector
Thu, Jun 10, 5:38 AM
CarolineConcatto closed D103153: [InstCombine] Add fold for extracting known elements from a stepvector.
Thu, Jun 10, 5:37 AM · Restricted Project
CarolineConcatto committed rG3c1f0e9ef89f: [InstSimplify] Add constant fold for extractelement + splat for scalable vectors (authored by CarolineConcatto).
[InstSimplify] Add constant fold for extractelement + splat for scalable vectors
Thu, Jun 10, 4:42 AM
CarolineConcatto closed D103180: [InstSimplify] Add constant fold for extractelement + splat for scalable vectors.
Thu, Jun 10, 4:42 AM · Restricted Project
CarolineConcatto added inline comments to D103952: [CostModel][AArch64] Improve the cost estimate of CTPOP intrinsic.
Thu, Jun 10, 12:26 AM · Restricted Project

Wed, Jun 9

CarolineConcatto added inline comments to D102755: [AArch64] Add cost tests for bitreverse.
Wed, Jun 9, 5:23 AM · Restricted Project
CarolineConcatto updated the diff for D103180: [InstSimplify] Add constant fold for extractelement + splat for scalable vectors.
  • remove scalable vector check because getAggregateElement has safeguards for scalable vectors
Wed, Jun 9, 3:34 AM · Restricted Project
CarolineConcatto added a comment to D102755: [AArch64] Add cost tests for bitreverse.

Hey @Rin,
I don't think you need bitreverse-cost-model.ll, you can use only bitreverse.ll.
Why some costs are not being changed in bitreverse.ll?

Wed, Jun 9, 2:24 AM · Restricted Project
CarolineConcatto updated the diff for D103180: [InstSimplify] Add constant fold for extractelement + splat for scalable vectors.
  • s/extract/extracting in test commemts
Wed, Jun 9, 12:22 AM · Restricted Project

Tue, Jun 8

CarolineConcatto added inline comments to D103153: [InstCombine] Add fold for extracting known elements from a stepvector.
Tue, Jun 8, 10:15 AM · Restricted Project
CarolineConcatto updated the diff for D103153: [InstCombine] Add fold for extracting known elements from a stepvector.
  • Address Foad's comments
Tue, Jun 8, 10:04 AM · Restricted Project
CarolineConcatto added inline comments to D103153: [InstCombine] Add fold for extracting known elements from a stepvector.
Tue, Jun 8, 5:06 AM · Restricted Project
CarolineConcatto updated the diff for D103153: [InstCombine] Add fold for extracting known elements from a stepvector.
  • Add check when the index uses more bits than the number of bit available in the vector scalar type
Tue, Jun 8, 4:56 AM · Restricted Project
CarolineConcatto updated the diff for D103180: [InstSimplify] Add constant fold for extractelement + splat for scalable vectors.
  • update test vector_splat_indices_nxv2i64_ext0 in gep-vector-indices.ll
Tue, Jun 8, 4:38 AM · Restricted Project
CarolineConcatto committed rG6fd1604d1433: [InstCombine] Add instcombine fold for extractelement + splat for scalable… (authored by CarolineConcatto).
[InstCombine] Add instcombine fold for extractelement + splat for scalable…
Tue, Jun 8, 2:45 AM
CarolineConcatto closed D102404: [InstCombine] Add instcombine fold for extractelement + splat for scalable vectors.
Tue, Jun 8, 2:45 AM · Restricted Project
CarolineConcatto updated the diff for D102404: [InstCombine] Add instcombine fold for extractelement + splat for scalable vectors.
  • update test gep-vector-indices.ll
Tue, Jun 8, 2:31 AM · Restricted Project

Thu, Jun 3

CarolineConcatto updated the diff for D103180: [InstSimplify] Add constant fold for extractelement + splat for scalable vectors.
  • replace the use of !CIdx->ult() by !CIdx->getValue().uge(..)
Thu, Jun 3, 3:09 AM · Restricted Project
CarolineConcatto added inline comments to D103153: [InstCombine] Add fold for extracting known elements from a stepvector.
Thu, Jun 3, 2:50 AM · Restricted Project
CarolineConcatto updated the diff for D103153: [InstCombine] Add fold for extracting known elements from a stepvector.
  • Remove switch case as suggested
Thu, Jun 3, 2:50 AM · Restricted Project
CarolineConcatto added inline comments to D103180: [InstSimplify] Add constant fold for extractelement + splat for scalable vectors.
Thu, Jun 3, 1:23 AM · Restricted Project

Wed, Jun 2

CarolineConcatto updated the diff for D102404: [InstCombine] Add instcombine fold for extractelement + splat for scalable vectors.
  • Replace comment as suggested
Wed, Jun 2, 8:49 AM · Restricted Project
CarolineConcatto added a comment to D102404: [InstCombine] Add instcombine fold for extractelement + splat for scalable vectors.

Thank you @sdesmalen for you review.
I have made the changes you've asked.

Wed, Jun 2, 8:37 AM · Restricted Project
CarolineConcatto updated the diff for D102404: [InstCombine] Add instcombine fold for extractelement + splat for scalable vectors.
  • Address Sander's comments
Wed, Jun 2, 8:36 AM · Restricted Project
CarolineConcatto added a comment to D103180: [InstSimplify] Add constant fold for extractelement + splat for scalable vectors.

Thanks for splitting it up. I like small patches.

Definitely agree. :)

For the test where the index is presumed invalid (i32 -1), is that enforced somehow? Is there a hard limit somewhere that says i32 0xffffffff must be invalid?

Sorry, @spatel
I've missed your comment above
I think the reason it says is invalid is because of the test:
uge(ValSVTy->getMinNumElements() -> unsigned greater or equal

Wed, Jun 2, 7:58 AM · Restricted Project

Tue, Jun 1

CarolineConcatto added a comment to D102404: [InstCombine] Add instcombine fold for extractelement + splat for scalable vectors.

Hi @spatel,
Sorry for getting wrong in the first place.
I hope I get it correct now with your latest explanation.
I changed the splat test to be in SimplifyExtractElementInst (InstructionSimplify.cpp).

Tue, Jun 1, 7:18 AM · Restricted Project
CarolineConcatto updated the diff for D102404: [InstCombine] Add instcombine fold for extractelement + splat for scalable vectors.

-move splat test from instcombine to instsimplify

Tue, Jun 1, 7:13 AM · Restricted Project
CarolineConcatto added a comment to D103180: [InstSimplify] Add constant fold for extractelement + splat for scalable vectors.

Hi @foad,
Sorry for my miss interpretation.
I believe now it is as you suggested.

Tue, Jun 1, 6:05 AM · Restricted Project
CarolineConcatto updated the diff for D103180: [InstSimplify] Add constant fold for extractelement + splat for scalable vectors.
  • Remove vector of zeros check by a splat vector check
Tue, Jun 1, 6:03 AM · Restricted Project
CarolineConcatto added a comment to D103180: [InstSimplify] Add constant fold for extractelement + splat for scalable vectors.

Hi @foad,
I don't know if I understood correct your suggestion.
I did not change any line.
I have tried some combinations of IF removals, but they all broke some tests

Tue, Jun 1, 5:28 AM · Restricted Project
CarolineConcatto added inline comments to D103153: [InstCombine] Add fold for extracting known elements from a stepvector.
Tue, Jun 1, 2:42 AM · Restricted Project
CarolineConcatto updated the diff for D103153: [InstCombine] Add fold for extracting known elements from a stepvector.

--address Jay Foad's comments

Tue, Jun 1, 2:41 AM · Restricted Project

Wed, May 26

CarolineConcatto added a comment to D103180: [InstSimplify] Add constant fold for extractelement + splat for scalable vectors.

The implementation in this patch was previously in:
https://reviews.llvm.org/D101916.

Wed, May 26, 9:41 AM · Restricted Project
CarolineConcatto added a comment to D102404: [InstCombine] Add instcombine fold for extractelement + splat for scalable vectors.

Thank you @foad and @spatel for the fast review.
I have splited the patch in 2 as @spatel suggested.
The constant fold is in https://reviews.llvm.org/D103180.
@spatel let me know if I understood correct what you've asked.

Wed, May 26, 9:39 AM · Restricted Project
CarolineConcatto updated the diff for D102404: [InstCombine] Add instcombine fold for extractelement + splat for scalable vectors.
  • address reviewer's comment
  • reduce patch scope to only work with instcombine
Wed, May 26, 9:35 AM · Restricted Project
CarolineConcatto updated the summary of D103180: [InstSimplify] Add constant fold for extractelement + splat for scalable vectors.
Wed, May 26, 9:29 AM · Restricted Project
CarolineConcatto requested review of D103180: [InstSimplify] Add constant fold for extractelement + splat for scalable vectors.
Wed, May 26, 9:22 AM · Restricted Project
CarolineConcatto added a comment to D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF.

Thank you @david-arm for the review.
It is quite difficult to get the comments right, but I think that your comment is better than mine
So I've replaced.

Wed, May 26, 6:27 AM · Restricted Project
CarolineConcatto updated the diff for D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF.
  • Address comments
Wed, May 26, 6:22 AM · Restricted Project
CarolineConcatto added a comment to D103153: [InstCombine] Add fold for extracting known elements from a stepvector.

Thank you @foad for your fast review. I've tried to address all of them.
I believe one of the changes you've asked I could not apply.

Wed, May 26, 4:51 AM · Restricted Project
CarolineConcatto updated the diff for D103153: [InstCombine] Add fold for extracting known elements from a stepvector.

-address Jay Foad's comments

Wed, May 26, 4:49 AM · Restricted Project
CarolineConcatto added reviewers for D103153: [InstCombine] Add fold for extracting known elements from a stepvector: david-arm, foad, sdesmalen.
Wed, May 26, 4:04 AM · Restricted Project
CarolineConcatto requested review of D103153: [InstCombine] Add fold for extracting known elements from a stepvector.
Wed, May 26, 4:02 AM · Restricted Project

Tue, May 25

CarolineConcatto added inline comments to D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF.
Tue, May 25, 8:40 AM · Restricted Project
CarolineConcatto updated the summary of D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF.
Tue, May 25, 8:30 AM · Restricted Project
CarolineConcatto updated the diff for D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF.
  • Rebase patch bases on D102394 to use canWidenLoopWithScalableVectors
  • Address reviewer's comment on the test
Tue, May 25, 8:29 AM · Restricted Project
CarolineConcatto added reviewers for D102404: [InstCombine] Add instcombine fold for extractelement + splat for scalable vectors: david-arm, sdesmalen, spatel, foad.
Tue, May 25, 4:30 AM · Restricted Project
CarolineConcatto updated the diff for D102404: [InstCombine] Add instcombine fold for extractelement + splat for scalable vectors.
  • Add implementation and test to simplify constants
  • Change check for splat in visitExtractElement
Tue, May 25, 4:27 AM · Restricted Project

Thu, May 20

CarolineConcatto committed rG9199b6535df1: [CostModel][AArch64] Add missing costs for getShuffleCost with scalable vectors (authored by CarolineConcatto).
[CostModel][AArch64] Add missing costs for getShuffleCost with scalable vectors
Thu, May 20, 1:16 AM
CarolineConcatto closed D102490: [CostModel][AArch64] Add missing costs for getShuffleCost for scalable vectors.
Thu, May 20, 1:16 AM · Restricted Project

Wed, May 19

CarolineConcatto updated the diff for D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF.
  • Fix and simplify llvm-ir test when the epilogue is not allowed
Wed, May 19, 6:17 AM · Restricted Project
CarolineConcatto added inline comments to D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF.
Wed, May 19, 3:46 AM · Restricted Project
CarolineConcatto updated the diff for D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF.
  • add test when the loop does not need predication and epilogue not allowed
Wed, May 19, 3:35 AM · Restricted Project

May 18 2021

CarolineConcatto added inline comments to D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF.
May 18 2021, 3:40 AM · Restricted Project
CarolineConcatto updated the diff for D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF.
  • Address review's comment. Only check the loop body, that is when !isScalarEpilogueAllowed()
May 18 2021, 3:39 AM · Restricted Project
CarolineConcatto added a comment to D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF.

Thank you @david-arm and @sdesmalen for the review.
I believe I've addressed all your comments.
I've updated the patch based on D102437 because there was a dependency between the cost model and the scalarization.
I could only use predicateWithScalar if I was able to compute the cost model, but the cost model was only able to be computed if it was able to be scalarized, and in this case, that was not possible because of sdiv.

May 18 2021, 1:31 AM · Restricted Project
CarolineConcatto updated the diff for D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF.

-remove old comments in loopHasScalarWithPredication

May 18 2021, 12:31 AM · Restricted Project
CarolineConcatto updated the diff for D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF.
  • address review's comment about circular dependency with foldTailByMasking
  • add dependency in D102437 because of memory cost model
May 18 2021, 12:28 AM · Restricted Project

May 14 2021

CarolineConcatto retitled D102490: [CostModel][AArch64] Add missing costs for getShuffleCost for scalable vectors from [CostModel][AArch64] Add missing costs for getShuffleCost with scalable vectors to [CostModel][AArch64] Add missing costs for getShuffleCost for scalable vectors.
May 14 2021, 6:01 AM · Restricted Project
CarolineConcatto requested review of D102490: [CostModel][AArch64] Add missing costs for getShuffleCost for scalable vectors.
May 14 2021, 5:59 AM · Restricted Project
CarolineConcatto added a comment to D102437: [LV] NFC: Decouple foldTailByMasking from isScalarWithPredication..

Hey Sander,
This patch is a fresh air to my eyes.
Thank you!
I think you need to run git-clang-format and I have one more comment.

May 14 2021, 12:19 AM · Restricted Project

May 13 2021

CarolineConcatto requested review of D102404: [InstCombine] Add instcombine fold for extractelement + splat for scalable vectors.
May 13 2021, 7:58 AM · Restricted Project

May 10 2021

CarolineConcatto added a comment to D101945: [LV] Add -scalable-vectorization=<option> flag..

Hey @sdesmalen
I have more questions about the implementation.

May 10 2021, 8:15 AM · Restricted Project

May 7 2021

CarolineConcatto committed rGcf06c8eee3a5: [LoopVectorize][SVE] Remove assert for scalable vector in InnerLoopVectorizer… (authored by CarolineConcatto).
[LoopVectorize][SVE] Remove assert for scalable vector in InnerLoopVectorizer…
May 7 2021, 1:39 AM
CarolineConcatto closed D101260: [LoopVectorize][SVE] Remove assert for scalable vector in InnerLoopVectorizer::fixReduction.
May 7 2021, 1:39 AM · Restricted Project

May 6 2021

CarolineConcatto added a comment to D101945: [LV] Add -scalable-vectorization=<option> flag..

Hey @sdesmalen
Thank you for the patch. Nice to see the famous flag in Phabricator.
I have some comments.
I hope they are not too non-sense.

May 6 2021, 6:33 AM · Restricted Project
CarolineConcatto added a comment to D101900: [InstCombine] Fold extractelement + vector GEP with one use.

I had a looks, but not too sure I have more comments than the ones I've added.

May 6 2021, 5:34 AM · Restricted Project
CarolineConcatto retitled D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF from [LoopVectorize] Fix crach for predicated instruction with scalable VF to [LoopVectorize] Fix crash for predicated instructions with scalable VF.
May 6 2021, 1:02 AM · Restricted Project

May 5 2021

CarolineConcatto updated the diff for D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF.

-s/crach/crash/

May 5 2021, 9:12 AM · Restricted Project
CarolineConcatto retitled D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF from [LoopVectorize] Fix crach for predicate instruction with scalable VF to [LoopVectorize] Fix crach for predicated instruction with scalable VF.
May 5 2021, 9:07 AM · Restricted Project
CarolineConcatto added reviewers for D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF: sdesmalen, david-arm, kmclaughlin, Florian, dmgreen.
May 5 2021, 9:06 AM · Restricted Project
CarolineConcatto requested review of D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF.
May 5 2021, 9:01 AM · Restricted Project

Apr 30 2021

CarolineConcatto added inline comments to D101260: [LoopVectorize][SVE] Remove assert for scalable vector in InnerLoopVectorizer::fixReduction.
Apr 30 2021, 9:24 AM · Restricted Project
CarolineConcatto updated the diff for D101260: [LoopVectorize][SVE] Remove assert for scalable vector in InnerLoopVectorizer::fixReduction.

-Update the test to use -force-target-supports-scalable-vectors
-Move and rename test to scalable-reduction-inloop.ll
-Remove unnecessary checks

Apr 30 2021, 9:23 AM · Restricted Project
CarolineConcatto added a comment to D101260: [LoopVectorize][SVE] Remove assert for scalable vector in InnerLoopVectorizer::fixReduction.

Hi @david-arm,
I have addressed your comments.
I also moved the test to AArch64 folder. I believe is the correct folder for it.
Carol

Apr 30 2021, 6:33 AM · Restricted Project
CarolineConcatto updated the diff for D101260: [LoopVectorize][SVE] Remove assert for scalable vector in InnerLoopVectorizer::fixReduction.
  • address reviewer's comment about the test
Apr 30 2021, 6:29 AM · Restricted Project

Apr 26 2021

CarolineConcatto added inline comments to D101260: [LoopVectorize][SVE] Remove assert for scalable vector in InnerLoopVectorizer::fixReduction.
Apr 26 2021, 9:34 AM · Restricted Project
CarolineConcatto updated the diff for D101260: [LoopVectorize][SVE] Remove assert for scalable vector in InnerLoopVectorizer::fixReduction.
  • Address review's comment about the check in the llvm-ir test
Apr 26 2021, 9:30 AM · Restricted Project
CarolineConcatto added reviewers for D101260: [LoopVectorize][SVE] Remove assert for scalable vector in InnerLoopVectorizer::fixReduction: david-arm, sdesmalen, gilr, fhahn.
Apr 26 2021, 1:14 AM · Restricted Project

Apr 25 2021

CarolineConcatto requested review of D101260: [LoopVectorize][SVE] Remove assert for scalable vector in InnerLoopVectorizer::fixReduction.
Apr 25 2021, 10:29 AM · Restricted Project

Apr 21 2021

CarolineConcatto added inline comments to D100485: [AArch64][SVE] Fix crash with icmp+select.
Apr 21 2021, 6:27 AM · Restricted Project
CarolineConcatto committed rGca9b7e2e2f08: [AArch64][SVE] Fix crash with icmp+select (authored by CarolineConcatto).
[AArch64][SVE] Fix crash with icmp+select
Apr 21 2021, 6:16 AM
CarolineConcatto closed D100485: [AArch64][SVE] Fix crash with icmp+select.
Apr 21 2021, 6:16 AM · Restricted Project
CarolineConcatto added a comment to D100865: [COST] Improve shuffle kind detection if shuffle mask is provided..

Hello @ABataev,
Thank you for the patch and for adding me as a reviewer.
I did a comment on your patch, hope you don't mind.
Carol

Apr 21 2021, 1:02 AM · Restricted Project

Apr 20 2021

CarolineConcatto accepted D99935: [AArch64] Add instruction costs for FP_TO_UINT and FP_TO_SINT with half types.

Thank you @david-arm.
I like the way you put the table together now.
It is easier to check the types now/

Apr 20 2021, 5:11 AM · Restricted Project
CarolineConcatto accepted D100745: [AArch64] Add AArch64TTIImpl::getMaskedMemoryOpCost function.

@david-arm I believe this patch is ok.
If it is not possible to make masked stores illegal for fixed vector using isLegalMaskedLoadStore, then I believe that the cost model is another valid solution to avoid it for fixed vectors.
Thank you for the explanation earlier.
I am going to approve and let's hope that this will not be a curse like in Sander's cost model patch.

Apr 20 2021, 1:44 AM · Restricted Project

Apr 19 2021

CarolineConcatto added a comment to D99935: [AArch64] Add instruction costs for FP_TO_UINT and FP_TO_SINT with half types.

Hey @david-arm,
Just a comment, it is me or this table is not well suited to review?
It lists the types by their cost. It should have put together instruction/types instead of instruction/cost.
I see some types/sizes missing like nxv8i32 ->nxv8f32 and nxv4i64 -> nxv4f64, but I guess they are not legal types, or I could miss it, as this table does not help me to find the types.
Is that correct?

Apr 19 2021, 5:20 AM · Restricted Project

Apr 16 2021

CarolineConcatto added a comment to D100485: [AArch64][SVE] Fix crash with icmp+select.

Thank you @sdesmalen and @c-rhodes for the review.
I'll comment you reviews in here, because the file select-sve.ll is deleted and the tests moved to sve-select.ll
@sdesmalen I have removed the tests you have asked.
I also remove the Expand in the Lowering for these types:
{MVT::nxv8i8, MVT::nxv4i16, MVT::nxv2i32}
as I believe this happens by default.
@c-rhodes the tests from select-sve.ll are now in sve-select.ll and select-sve.ll deleted.
That is already on main.

Apr 16 2021, 6:02 AM · Restricted Project
CarolineConcatto updated the diff for D100485: [AArch64][SVE] Fix crash with icmp+select.
  • Rebase with main
  • Remove Expand for MVT::nxv8i8, MVT::nxv4i16, MVT::nxv2i32, as it is done by default
  • Remove tests for MVT::nxv8i8, MVT::nxv4i16, MVT::nxv2i32
Apr 16 2021, 5:53 AM · Restricted Project
CarolineConcatto committed rG394eb91854fe: [NFC][AArch64][SVE] Move select-sve.ll tests to sve-select.ll (authored by CarolineConcatto).
[NFC][AArch64][SVE] Move select-sve.ll tests to sve-select.ll
Apr 16 2021, 4:01 AM

Apr 15 2021

CarolineConcatto added a comment to D100485: [AArch64][SVE] Fix crash with icmp+select.

Thank you @sdesmalen for pointing out that I missed some types.
Now nxv[2|4|8|16]i1 works. I also removed the redundant tests that you've asked for.

Apr 15 2021, 3:14 AM · Restricted Project
CarolineConcatto updated the diff for D100485: [AArch64][SVE] Fix crash with icmp+select.

Addressing reviewer's comment

  • add support for missing types: nxv2i1, nxv4i1, nxv8i1, nxv16i1
  • remove redundant tests
Apr 15 2021, 3:04 AM · Restricted Project

Apr 14 2021

CarolineConcatto added reviewers for D100485: [AArch64][SVE] Fix crash with icmp+select: sdesmalen, c-rhodes, bsmith, joechrisellis.
Apr 14 2021, 8:09 AM · Restricted Project
CarolineConcatto requested review of D100485: [AArch64][SVE] Fix crash with icmp+select.
Apr 14 2021, 8:06 AM · Restricted Project

Apr 1 2021

CarolineConcatto accepted D99192: [NFC] Add tests for scalable vectorization of loops with large stride acesses.

LGMT David!
Learning new things every day!

Apr 1 2021, 2:24 AM · Restricted Project