Page MenuHomePhabricator

CarolineConcatto (Caroline)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2020, 3:58 AM (32 w, 4 d)

Recent Activity

Fri, Sep 11

CarolineConcatto committed rG257b29715bb2: [flang][driver] Add the new flang compiler and frontend drivers (authored by CarolineConcatto).
[flang][driver] Add the new flang compiler and frontend drivers
Fri, Sep 11, 3:01 AM
CarolineConcatto closed D86089: [flang][driver]Add experimental flang driver and frontend with help screen.
Fri, Sep 11, 3:00 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 10

CarolineConcatto added a comment to D87125: Update recipe for flang-aarch64 slaves.

Thank you @gkistanova, I did miss that.
It was updated on my local repo, but not in here.

Thu, Sep 10, 11:42 PM
CarolineConcatto retitled D87125: Update recipe for flang-aarch64 slaves from Add extra recipient mail for flang-aarch64 slaves to Update recipe for flang-aarch64 slaves.
Thu, Sep 10, 11:40 PM

Wed, Sep 9

CarolineConcatto updated the diff for D87125: Update recipe for flang-aarch64 slaves.

Add the build of the new driver as default for flang-aarch64 slaves

Wed, Sep 9, 5:43 AM
CarolineConcatto committed rG0fd425af071a: [flang]Add Semantic Checks for OpenMP Allocate Clause (authored by Rin).
[flang]Add Semantic Checks for OpenMP Allocate Clause
Wed, Sep 9, 4:09 AM
CarolineConcatto closed D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.
Wed, Sep 9, 4:09 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto added a comment to D87125: Update recipe for flang-aarch64 slaves.

@gkistanova is it fine for me to push?

Wed, Sep 9, 1:21 AM

Fri, Sep 4

CarolineConcatto updated the diff for D87125: Update recipe for flang-aarch64 slaves.

-correct mail for flang

Fri, Sep 4, 12:19 AM
CarolineConcatto requested review of D87125: Update recipe for flang-aarch64 slaves.
Fri, Sep 4, 12:16 AM

Sun, Aug 23

CarolineConcatto added a comment to D86089: [flang][driver]Add experimental flang driver and frontend with help screen.

Hey Folks,
Fist of all, thank you very much for your review.
I have answered some questions and update some of the requests.
There are some that I did not had time to go inside yet.
I have the week of 24th off. IN my return I will tackle all the reviews as:
out of build tree
and some question about the driver

Sun, Aug 23, 1:55 PM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto updated the diff for D86089: [flang][driver]Add experimental flang driver and frontend with help screen.

Address review comments

Sun, Aug 23, 1:15 PM · Restricted Project, Restricted Project, Restricted Project

Aug 19 2020

CarolineConcatto committed rG33c554d8444a: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive (authored by CarolineConcatto).
[clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive
Aug 19 2020, 9:55 AM
CarolineConcatto closed D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive.
Aug 19 2020, 9:55 AM · Restricted Project
CarolineConcatto added a comment to D85622: Separate the Registration from Loading dialects in the Context.

@mehdi_amini this patch is breaking flang buildbot.
http://lab.llvm.org:8011/builders/flang-aarch64-ubuntu/builds/2928
Do you mind to revert?

Aug 19 2020, 9:51 AM · Restricted Project

Aug 18 2020

CarolineConcatto updated the diff for D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive.

Missing a -

Aug 18 2020, 5:21 AM · Restricted Project
CarolineConcatto added a reviewer for D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive: echristo.
Aug 18 2020, 3:57 AM · Restricted Project
CarolineConcatto removed a reviewer for D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive: kiranchandramohan.
Aug 18 2020, 3:50 AM · Restricted Project
CarolineConcatto added a reviewer for D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive: peterwaller-arm.
Aug 18 2020, 3:50 AM · Restricted Project
CarolineConcatto added reviewers for D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive: DavidTruby, kiranchandramohan.
Aug 18 2020, 3:46 AM · Restricted Project
CarolineConcatto requested review of D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive.
Aug 18 2020, 3:46 AM · Restricted Project

Aug 17 2020

CarolineConcatto added a project to D86089: [flang][driver]Add experimental flang driver and frontend with help screen: Restricted Project.
Aug 17 2020, 9:24 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto retitled D86089: [flang][driver]Add experimental flang driver and frontend with help screen from Add experimental flang driver and frontend with help screen to [flang][driver]Add experimental flang driver and frontend with help screen.
Aug 17 2020, 9:24 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto updated the summary of D86089: [flang][driver]Add experimental flang driver and frontend with help screen.
Aug 17 2020, 9:22 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto added a reviewer for D86089: [flang][driver]Add experimental flang driver and frontend with help screen: Andrzej.
Aug 17 2020, 9:21 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto requested review of D86089: [flang][driver]Add experimental flang driver and frontend with help screen.
Aug 17 2020, 9:20 AM · Restricted Project, Restricted Project, Restricted Project

Aug 14 2020

CarolineConcatto committed rZORG3be3cca19be8: Fix binaries directory for flang slaves gcc10 and clang10 (authored by CarolineConcatto).
Fix binaries directory for flang slaves gcc10 and clang10
Aug 14 2020, 3:37 AM
CarolineConcatto closed D85816: Fix binaries directory for flang slaves gcc10 and clang10.
Aug 14 2020, 3:37 AM

Aug 12 2020

CarolineConcatto updated the diff for D85816: Fix binaries directory for flang slaves gcc10 and clang10.

Keep consistency between the names for clang

Aug 12 2020, 5:57 AM
CarolineConcatto added inline comments to D85816: Fix binaries directory for flang slaves gcc10 and clang10.
Aug 12 2020, 5:48 AM
CarolineConcatto requested review of D85816: Fix binaries directory for flang slaves gcc10 and clang10.
Aug 12 2020, 1:10 AM

Aug 11 2020

CarolineConcatto committed rZORGb06887ba004d: Add flang slaves builds with clang10 and gcc10 (authored by CarolineConcatto).
Add flang slaves builds with clang10 and gcc10
Aug 11 2020, 1:08 AM
CarolineConcatto closed D85529: Add flang slaves builds with clang10 and gcc10.
Aug 11 2020, 1:08 AM

Aug 7 2020

CarolineConcatto requested review of D85529: Add flang slaves builds with clang10 and gcc10.
Aug 7 2020, 8:27 AM

Aug 4 2020

CarolineConcatto added a comment to D69257: Outline non returning functions unless a longjmp.

So the build has as a target: cmake -DLLVM_TARGETS_TO_BUILD=AArch64

Aug 4 2020, 8:44 AM · Restricted Project

Aug 3 2020

CarolineConcatto added a comment to D69257: Outline non returning functions unless a longjmp.

@hiraditya
We believe that this patch has caused the Flang buildbots to fail:
http://lab.llvm.org:8011/builders/flang-aarch64-ubuntu/builds/2437
http://lab.llvm.org:8011/builders/flang-aarch64-ubuntu-clang/builds/579
It would be nice if someone could take and action to revert of fix it ASAP.
Otherwise we cannot verify the other patches properly.

Aug 3 2020, 6:11 AM · Restricted Project

Jul 24 2020

CarolineConcatto accepted D83946: [flang] Run non-gtest unit tests with lit..
Jul 24 2020, 6:45 AM · Restricted Project

Jul 20 2020

CarolineConcatto added a comment to D83946: [flang] Run non-gtest unit tests with lit..

Thank you David for these patch.
Do you mind to explain why you had to create this new non-gtest unit in the patch.

Jul 20 2020, 6:59 AM · Restricted Project

Jun 23 2020

CarolineConcatto abandoned D81002: Fix individual tests with lit when building out of tree.

This was re-implemented by :
https://reviews.llvm.org/D82120

Jun 23 2020, 12:29 AM · Restricted Project

Jun 15 2020

CarolineConcatto abandoned D79092: [Flang][Driver]Add new flang driver main() entrypoint.

I'll close this PR as we believe we will not need this flag for Flang driver.
There are some development happening in:
https://github.com/banach-space/llvm-project
for now.

Jun 15 2020, 7:00 AM · Restricted Project, Restricted Project
CarolineConcatto added a comment to D81828: [MLIR][NFC] Inline lambda to workaround gcc 9.1/9.2 bug.

It now works with gcc9.2. I did not try with other compilers.
Is is too much to ask to write the reason it is implemented the way it is?
Maybe say that this was a lambda function that needed to be expanded.
But otherwise it looks fine to me

Jun 15 2020, 5:56 AM · Restricted Project

Jun 8 2020

CarolineConcatto abandoned D73951: [Clang] [Driver]Add logic to search for flang frontend.

I'll close this PR as we believe we will not need this flag for Flang driver.
There are some development happening in:
https://github.com/banach-space/llvm-project
for now.

Jun 8 2020, 7:38 AM · Restricted Project
CarolineConcatto added a comment to D73951: [Clang] [Driver]Add logic to search for flang frontend.

I'll close this PR as we believe we will not need this flag for Flang driver.
There are some development happening in:
https://github.com/banach-space/llvm-project
for now.

Jun 8 2020, 7:38 AM · Restricted Project

Jun 3 2020

CarolineConcatto committed rZORG87b206fe85e7: Add aarch64 machine slave to build flang with clang-8 (authored by CarolineConcatto).
Add aarch64 machine slave to build flang with clang-8
Jun 3 2020, 6:33 AM
CarolineConcatto closed D80983: Add aarch64 machine slave to build flang with clang-8.
Jun 3 2020, 6:33 AM

Jun 2 2020

CarolineConcatto added a comment to D81002: Fix individual tests with lit when building out of tree.

It looks like that for in tree the lit needs to be like this:
add_lit_testsuites(FLANG ${CMAKE_CURRENT_SOURCE_DIR}
and out of tree like this:
add_lit_testsuites(FLANG ${CMAKE_CURRENT_BINARY_DIR}

Jun 2 2020, 10:58 AM · Restricted Project
CarolineConcatto added a reviewer for D81002: Fix individual tests with lit when building out of tree: tskeith.
Jun 2 2020, 7:08 AM · Restricted Project
CarolineConcatto added a reviewer for D81002: Fix individual tests with lit when building out of tree: sameeranjoshi.
Jun 2 2020, 7:08 AM · Restricted Project
CarolineConcatto created D81002: Fix individual tests with lit when building out of tree.
Jun 2 2020, 7:08 AM · Restricted Project
CarolineConcatto created D80983: Add aarch64 machine slave to build flang with clang-8.
Jun 2 2020, 1:04 AM
CarolineConcatto edited reviewers for D80983: Add aarch64 machine slave to build flang with clang-8, added: gkistanova; removed: DavidTruby, sscalpone.
Jun 2 2020, 1:04 AM

May 28 2020

GitHub <noreply@github.com> committed rZORG354aeff580c5: Merge 14f5bc090ce6d259e2055fea745fe0477aef6397 into… (authored by CarolineConcatto).
Merge 14f5bc090ce6d259e2055fea745fe0477aef6397 into…
May 28 2020, 12:08 PM
GitHub <noreply@github.com> committed rZORG79e9c3e270f1: Merge 14f5bc090ce6d259e2055fea745fe0477aef6397 into… (authored by CarolineConcatto).
Merge 14f5bc090ce6d259e2055fea745fe0477aef6397 into…
May 28 2020, 4:18 AM
GitHub <noreply@github.com> committed rZORGa3326d805094: Merge 14f5bc090ce6d259e2055fea745fe0477aef6397 into… (authored by CarolineConcatto).
Merge 14f5bc090ce6d259e2055fea745fe0477aef6397 into…
May 28 2020, 3:13 AM
CarolineConcatto committed rZORG14f5bc090ce6: Add aarch64 machine slave to build flang with clang-8 (authored by CarolineConcatto).
Add aarch64 machine slave to build flang with clang-8
May 28 2020, 3:13 AM

May 5 2020

CarolineConcatto added a comment to D79092: [Flang][Driver]Add new flang driver main() entrypoint.

Thank you all for your inputs!
This discussion has raised some valuable points and we’d like to address all of them.
Thank you for the suggestion @sscalpone! Yes, we will send and updated RFC shortly and continue the discussion on the mailing list.
The older RFC sent by Peter Waller was done before flang landed in llvm-project monorepo and needs some re-thinking and pruning.

May 5 2020, 2:39 AM · Restricted Project, Restricted Project

May 4 2020

CarolineConcatto updated the diff for D73951: [Clang] [Driver]Add logic to search for flang frontend.

Rename the flag and fix reviews comments

May 4 2020, 7:27 AM · Restricted Project
CarolineConcatto added a comment to D79092: [Flang][Driver]Add new flang driver main() entrypoint.

Is it fine to always build clang and the driver as a standard?

May 4 2020, 2:05 AM · Restricted Project, Restricted Project
CarolineConcatto added a comment to D79092: [Flang][Driver]Add new flang driver main() entrypoint.

@schweitz Ok, I am open to solutions for the concern @sscalpone brought.
I suggested the flag because I can see it is what is done with MLIR for FIR.
ATM it is not possible to remove clang from the libraries because the Driver class is inside clang.
Probably the Driver class will need to be refactored in the future, maybe when we have a stable flang driver.
But for now, it will only delay more flang driver functionality.

May 4 2020, 2:05 AM · Restricted Project, Restricted Project

May 1 2020

CarolineConcatto added inline comments to D73951: [Clang] [Driver]Add logic to search for flang frontend.
May 1 2020, 3:57 AM · Restricted Project
CarolineConcatto updated the diff for D73951: [Clang] [Driver]Add logic to search for flang frontend.

This patch updates the flag name from ffc-fortran-name to cfc-fortran-name,
where cfc stands for custom frontend compiler.

May 1 2020, 3:55 AM · Restricted Project
CarolineConcatto added a comment to D79092: [Flang][Driver]Add new flang driver main() entrypoint.

Ok, when the driver is fully implemented this could be true.
But for now if this is the problem I can do the same as MLIR for FIR.

May 1 2020, 1:31 AM · Restricted Project, Restricted Project
CarolineConcatto added a comment to D79092: [Flang][Driver]Add new flang driver main() entrypoint.

@sscalpone can you tell us what is your concern? It is compiling time now that the driver is not fully functional?

May 1 2020, 1:17 AM · Restricted Project, Restricted Project

Apr 30 2020

CarolineConcatto updated the diff for D79092: [Flang][Driver]Add new flang driver main() entrypoint.

Minor fixes on CMakeLists.txt

Apr 30 2020, 6:46 AM · Restricted Project, Restricted Project
CarolineConcatto abandoned D79170: Fix minor errors.

This patch has landed here by mistake.
This is should be an update on:
https://reviews.llvm.org/D73951

Apr 30 2020, 6:46 AM · Restricted Project
CarolineConcatto created D79170: Fix minor errors.
Apr 30 2020, 6:21 AM · Restricted Project
CarolineConcatto added a comment to D73951: [Clang] [Driver]Add logic to search for flang frontend.

@awarzynski If we don't foresee a use for this flag beside the problem I've faced, then I am fine to remove and only replace by flang-tmp.

Apr 30 2020, 3:01 AM · Restricted Project

Apr 29 2020

CarolineConcatto created D79092: [Flang][Driver]Add new flang driver main() entrypoint.
Apr 29 2020, 8:00 AM · Restricted Project, Restricted Project

Apr 9 2020

CarolineConcatto committed rG5c7ecef1e43a: [flang] Adjust supported compilers statement in F18 readme (authored by CarolineConcatto).
[flang] Adjust supported compilers statement in F18 readme
Apr 9 2020, 1:08 PM
CarolineConcatto committed rG8670e49901d1: [flang] [LLVMify F18] Replace the use std::ostream with LLVM streams llvm… (authored by CarolineConcatto).
[flang] [LLVMify F18] Replace the use std::ostream with LLVM streams llvm…
Apr 9 2020, 1:04 PM
GitHub <noreply@github.com> committed rG64ab3302d5a1: [flang] [LLVMify F18] Compiler module folders should have capitalised names… (authored by CarolineConcatto).
[flang] [LLVMify F18] Compiler module folders should have capitalised names…
Apr 9 2020, 12:55 PM
CarolineConcatto committed rGf4a6fe026d6d: [flang] Removing TODO comments as they are implemented by this patch (authored by CarolineConcatto).
[flang] Removing TODO comments as they are implemented by this patch
Apr 9 2020, 11:32 AM
CarolineConcatto committed rG7aaf74c1bcc3: [flang] Removing two sentence error (authored by CarolineConcatto).
[flang] Removing two sentence error
Apr 9 2020, 11:31 AM
CarolineConcatto committed rG23b033759847: [flang] Changes in SaveStmt message for Common Block name specifier (authored by CarolineConcatto).
[flang] Changes in SaveStmt message for Common Block name specifier
Apr 9 2020, 11:31 AM
CarolineConcatto committed rG6975bc3dd4cb: [flang] Changes requested by the comunity (authored by CarolineConcatto).
[flang] Changes requested by the comunity
Apr 9 2020, 11:31 AM
CarolineConcatto committed rGb8b0c82a18a9: [flang] Adding semantic checks for Block Construct (authored by CarolineConcatto).
[flang] Adding semantic checks for Block Construct
Apr 9 2020, 11:31 AM

Feb 14 2020

CarolineConcatto added inline comments to D73951: [Clang] [Driver]Add logic to search for flang frontend.
Feb 14 2020, 8:59 AM · Restricted Project
CarolineConcatto updated the diff for D73951: [Clang] [Driver]Add logic to search for flang frontend.
  • [Clang]Rename flag and update the tests
Feb 14 2020, 5:46 AM · Restricted Project
CarolineConcatto added a comment to D73951: [Clang] [Driver]Add logic to search for flang frontend.

@richard.barton.arm A new patch will land today with the changes asked by you.

Feb 14 2020, 1:47 AM · Restricted Project

Feb 4 2020

CarolineConcatto added inline comments to D73951: [Clang] [Driver]Add logic to search for flang frontend.
Feb 4 2020, 1:28 PM · Restricted Project
CarolineConcatto retitled D73951: [Clang] [Driver]Add logic to search for flang frontend from [Clang] Add logic to search for flang frontend to [Clang] [Driver]Add logic to search for flang frontend.
Feb 4 2020, 5:38 AM · Restricted Project
CarolineConcatto created D73951: [Clang] [Driver]Add logic to search for flang frontend.
Feb 4 2020, 4:16 AM · Restricted Project