Page MenuHomePhabricator

CarolineConcatto (Caroline)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2020, 3:58 AM (50 w, 3 d)

Recent Activity

Yesterday

CarolineConcatto added a reviewer for D94708: [IR] Introduce llvm.experimental.vector.splice intrinsic: CarolineConcatto.
Thu, Jan 21, 8:51 AM · Restricted Project

Tue, Jan 19

CarolineConcatto added inline comments to D94883: [CodeGen][SelectionDAG]Add new intrinsic experimental.vector.reverse.
Tue, Jan 19, 8:39 AM · Restricted Project
CarolineConcatto updated the diff for D94883: [CodeGen][SelectionDAG]Add new intrinsic experimental.vector.reverse.

-fix table gen style for TargetSelectionDAG.td

Tue, Jan 19, 8:37 AM · Restricted Project
CarolineConcatto updated the diff for D94883: [CodeGen][SelectionDAG]Add new intrinsic experimental.vector.reverse.

-fix style on LegalizeIntegerTypes.cpp

Tue, Jan 19, 8:24 AM · Restricted Project
CarolineConcatto updated the diff for D94883: [CodeGen][SelectionDAG]Add new intrinsic experimental.vector.reverse.

-remove AArch64 custom lowering
-move SNode vector_reverse to TargetSelectionDAG.td

Tue, Jan 19, 8:21 AM · Restricted Project
CarolineConcatto updated the summary of D94883: [CodeGen][SelectionDAG]Add new intrinsic experimental.vector.reverse.
Tue, Jan 19, 7:56 AM · Restricted Project
CarolineConcatto committed rG172f1f8952c9: [AArch64][SVE]Add cost model for vector reduce for scalable vector (authored by CarolineConcatto).
[AArch64][SVE]Add cost model for vector reduce for scalable vector
Tue, Jan 19, 3:55 AM
CarolineConcatto closed D93639: [AArch64][SVE]Add cost model for vector reduce for scalable vector.
Tue, Jan 19, 3:54 AM · Restricted Project

Mon, Jan 18

CarolineConcatto accepted D92238: [SCEVExpander] Migrate costAndCollectOperands to use InstructionCost..

It look to me now.

Mon, Jan 18, 6:42 AM · Restricted Project
CarolineConcatto added reviewers for D94883: [CodeGen][SelectionDAG]Add new intrinsic experimental.vector.reverse: rogfer01, cameron.mcinally.
Mon, Jan 18, 6:28 AM · Restricted Project
CarolineConcatto committed rG36710c38c1b7: [NFC]Migrate VectorCombine.cpp to use InstructionCost (authored by CarolineConcatto).
[NFC]Migrate VectorCombine.cpp to use InstructionCost
Mon, Jan 18, 5:38 AM
CarolineConcatto closed D94069: [NFC][InstructionCost]Migrate VectorCombine.cpp to use InstructionCost.
Mon, Jan 18, 5:37 AM · Restricted Project
CarolineConcatto updated the diff for D93639: [AArch64][SVE]Add cost model for vector reduce for scalable vector.

-re-arrange the test
-remove f<operand> tests with integer

Mon, Jan 18, 2:33 AM · Restricted Project

Sun, Jan 17

CarolineConcatto updated the diff for D93639: [AArch64][SVE]Add cost model for vector reduce for scalable vector.
  • change vector size to 128bits
Sun, Jan 17, 2:12 PM · Restricted Project
CarolineConcatto added reviewers for D94883: [CodeGen][SelectionDAG]Add new intrinsic experimental.vector.reverse: sdesmalen, david-arm, paulwalker-arm, kmclaughlin.
Sun, Jan 17, 11:56 AM · Restricted Project
CarolineConcatto added a comment to D93639: [AArch64][SVE]Add cost model for vector reduce for scalable vector.

@Thank you Sander,
I added more tests. Now we have tests for legal and not legal, besides the test with integer for FP operands.

Sun, Jan 17, 11:55 AM · Restricted Project
CarolineConcatto updated the diff for D93639: [AArch64][SVE]Add cost model for vector reduce for scalable vector.

-add missing test for fmax,fadd with integer

Sun, Jan 17, 11:55 AM · Restricted Project
CarolineConcatto requested review of D94883: [CodeGen][SelectionDAG]Add new intrinsic experimental.vector.reverse.
Sun, Jan 17, 11:45 AM · Restricted Project
CarolineConcatto updated the summary of D94069: [NFC][InstructionCost]Migrate VectorCombine.cpp to use InstructionCost.
Sun, Jan 17, 11:09 AM · Restricted Project
CarolineConcatto updated the diff for D94069: [NFC][InstructionCost]Migrate VectorCombine.cpp to use InstructionCost.

-replace (!NewCost.isValid && !OldCost.isvalid()) by !NewCost.isValid()

Sun, Jan 17, 11:08 AM · Restricted Project
CarolineConcatto updated the diff for D93639: [AArch64][SVE]Add cost model for vector reduce for scalable vector.
  • remove cost for vector.reduce.{mul"fmul}
  • add regression tests for not legal vectors
Sun, Jan 17, 10:40 AM · Restricted Project

Wed, Jan 13

CarolineConcatto updated the diff for D93639: [AArch64][SVE]Add cost model for vector reduce for scalable vector.

-remove redundant code
-change getArithmeticReductionCostScalableVectorType to getArithmeticReductionCostSVE
-replace unsigned by int

Wed, Jan 13, 10:18 AM · Restricted Project
CarolineConcatto added inline comments to D94069: [NFC][InstructionCost]Migrate VectorCombine.cpp to use InstructionCost.
Wed, Jan 13, 9:28 AM · Restricted Project
CarolineConcatto updated the diff for D94069: [NFC][InstructionCost]Migrate VectorCombine.cpp to use InstructionCost.

-remove missed assert

Wed, Jan 13, 9:22 AM · Restricted Project
CarolineConcatto updated the diff for D94069: [NFC][InstructionCost]Migrate VectorCombine.cpp to use InstructionCost.

-add missing invalid costs test for scalarizeBinopOrCmp

Wed, Jan 13, 1:35 AM · Restricted Project
CarolineConcatto added a comment to D94069: [NFC][InstructionCost]Migrate VectorCombine.cpp to use InstructionCost.

Hi @ctetreau,
Thank you for the review.
So I removed all the asserts and added the earlier return if both costs are invalid, because in this case it means that the transformation is not cheap.
If only OldCost is invalid I believe we should do nothing, for the same reason I removed the test for !NewCost.isValid().

Wed, Jan 13, 1:30 AM · Restricted Project
CarolineConcatto updated the diff for D94069: [NFC][InstructionCost]Migrate VectorCombine.cpp to use InstructionCost.

-remove asserts for OldCost invalid
-add return if both costs are invalid

Wed, Jan 13, 1:26 AM · Restricted Project

Tue, Jan 12

CarolineConcatto added a comment to D93639: [AArch64][SVE]Add cost model for vector reduce for scalable vector.

Thank you @sdesmalen for helping to refine the code.
I hope it is near to the end now.

Tue, Jan 12, 10:02 AM · Restricted Project
CarolineConcatto updated the diff for D93639: [AArch64][SVE]Add cost model for vector reduce for scalable vector.

-remove redundant code when computing Type for MinMax Cost

Tue, Jan 12, 9:59 AM · Restricted Project
CarolineConcatto updated the diff for D93639: [AArch64][SVE]Add cost model for vector reduce for scalable vector.
  • use EVT instead of MVT to get the vector type
  • use unreachable for the MinMax switch
  • add TODO for Arithmetic cost when the ISD is not supported
  • change MinMax horizontal reduction cost to be 2
Tue, Jan 12, 9:18 AM · Restricted Project

Mon, Jan 11

CarolineConcatto added a comment to D94069: [NFC][InstructionCost]Migrate VectorCombine.cpp to use InstructionCost.

Thank you, everyone, for the review.
I have removed the redundant invalid check.
Also, thank you for making clear that invalid, atm, means as well high cost.
I'll have that in mind for the next patches.

Mon, Jan 11, 1:35 AM · Restricted Project
CarolineConcatto updated the diff for D94069: [NFC][InstructionCost]Migrate VectorCombine.cpp to use InstructionCost.

-remove redundat invalid check

Mon, Jan 11, 1:27 AM · Restricted Project

Thu, Jan 7

CarolineConcatto updated the diff for D93639: [AArch64][SVE]Add cost model for vector reduce for scalable vector.

-Split the cost on legalization and horizontal vector reduction cost as
suggested in the review

Thu, Jan 7, 9:34 AM · Restricted Project
CarolineConcatto closed D93030: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector..

Patch submitted to main.

Thu, Jan 7, 6:23 AM · Restricted Project
CarolineConcatto added a comment to D93030: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector..

I push the fix patch to main in the commit:
01c190e907ca

Thu, Jan 7, 6:05 AM · Restricted Project
CarolineConcatto committed rG01c190e907ca: [AArch64][CostModel]Fix gather scatter cost model (authored by CarolineConcatto).
[AArch64][CostModel]Fix gather scatter cost model
Thu, Jan 7, 6:03 AM
CarolineConcatto added a comment to D93030: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector..

Thank you @dblaikie for pointing the problem.
I was able to generate a reproducer and I've added it as a test.
I'll push the fix to main ASAP

Thu, Jan 7, 5:06 AM · Restricted Project

Tue, Jan 5

CarolineConcatto added a comment to D94065: [NFC] Make remaining cost functions in LoopVectorize.cpp use InstructionCost.

Thank you David for this patch.
It looks all fine and the patch LGTM.
I have a question, maybe out of the scope of this patch.
Can we also change LoopVectorizationCostModel::computePredInstDiscount to return InstructionCost as well?

Tue, Jan 5, 4:08 AM · Restricted Project
CarolineConcatto retitled D94069: [NFC][InstructionCost]Migrate VectorCombine.cpp to use InstructionCost from [NFC]Migrate VectorCombine.cpp to use InstructionCost to [NFC][InstructionCost]Migrate VectorCombine.cpp to use InstructionCost.
Tue, Jan 5, 1:18 AM · Restricted Project
CarolineConcatto added reviewers for D94069: [NFC][InstructionCost]Migrate VectorCombine.cpp to use InstructionCost: david-arm, sdesmalen, ctetreau, spatel.
Tue, Jan 5, 1:10 AM · Restricted Project
CarolineConcatto requested review of D94069: [NFC][InstructionCost]Migrate VectorCombine.cpp to use InstructionCost.
Tue, Jan 5, 1:09 AM · Restricted Project

Mon, Jan 4

CarolineConcatto committed rG060cfd979548: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector. (authored by CarolineConcatto).
[AArch64][SVE]Add cost model for masked gather and scatter for scalable vector.
Mon, Jan 4, 6:01 AM
CarolineConcatto updated the diff for D93030: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector..
  • remove TODO from MaxVScale assert
  • replace LVF by LegalVF
  • rewrite return equation
Mon, Jan 4, 5:44 AM · Restricted Project

Dec 21 2020

CarolineConcatto added reviewers for D93639: [AArch64][SVE]Add cost model for vector reduce for scalable vector: sdesmalen, david-arm, ctetreau.
Dec 21 2020, 8:09 AM · Restricted Project
CarolineConcatto requested review of D93639: [AArch64][SVE]Add cost model for vector reduce for scalable vector.
Dec 21 2020, 8:07 AM · Restricted Project
CarolineConcatto accepted rGd6abd7317a26: [flang][driver] Make the names of files created in unit tests unique (nfc).

I believe this could be the problem, as I once faced that problem locally.
It could be a possible problem and difficult to reproduce.
Approving it so we could roll-out this assumption.

Dec 21 2020, 3:37 AM

Dec 18 2020

CarolineConcatto updated the diff for D93030: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector..
  • update TODO message on AArch64TTIImpl::getGatherScatterOpCost
Dec 18 2020, 5:43 AM · Restricted Project
CarolineConcatto added inline comments to D93030: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector..
Dec 18 2020, 3:47 AM · Restricted Project

Dec 17 2020

CarolineConcatto accepted D92854: [flang][driver] Add support for `-fsyntax-only`.

Thank you @awarzynski for implementing fsyntax-only.
It is another feature that the new driver provides, it is nice to see thing falling into place.
The patch looks good to me!

Dec 17 2020, 10:24 AM · Restricted Project, Restricted Project
CarolineConcatto added a comment to D93030: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector..

@tschuett I agree that we should refine the value if MaxVScale according to the Architecture by using flags.
But I believe this should be the scope of another patch.
Implementing the use of a flag to compute the value of MaxVScale will increase the complexity of the patch, and IMHO it is not related to the cost of gather and scatters.
The value of MaxVScale is/will be used to compute the cost of others intrinsic/instructions with vscale data type.

Dec 17 2020, 8:48 AM · Restricted Project
CarolineConcatto updated the diff for D93030: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector..
  • fix history with git
Dec 17 2020, 8:22 AM · Restricted Project
CarolineConcatto added inline comments to D93030: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector..
Dec 17 2020, 7:27 AM · Restricted Project
CarolineConcatto updated the diff for D93030: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector..
  • add test test for illegal gather
Dec 17 2020, 7:23 AM · Restricted Project

Dec 16 2020

CarolineConcatto committed rGbe9184bc557a: [SLPVectorizer]Migrate getEntryCost to return InstructionCost (authored by CarolineConcatto).
[SLPVectorizer]Migrate getEntryCost to return InstructionCost
Dec 16 2020, 6:20 AM
CarolineConcatto closed D93127: [SLPVectorizer]Migrate getEntryCost to return InstructionCost.
Dec 16 2020, 6:20 AM · Restricted Project
CarolineConcatto committed rG07217e0a1b7e: [CostModel]Migrate getTreeCost() to use InstructionCost (authored by CarolineConcatto).
[CostModel]Migrate getTreeCost() to use InstructionCost
Dec 16 2020, 5:10 AM
CarolineConcatto closed D93049: [SLPVectorizer]Migrate getTreeCost() to use InstructionCost.
Dec 16 2020, 5:10 AM · Restricted Project
CarolineConcatto committed rG60e4698b9aba: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost (authored by CarolineConcatto).
[CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost
Dec 16 2020, 5:08 AM
CarolineConcatto closed D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost.
Dec 16 2020, 5:08 AM · Restricted Project

Dec 14 2020

CarolineConcatto added inline comments to D92238: [SCEVExpander] Migrate costAndCollectOperands to use InstructionCost..
Dec 14 2020, 9:18 AM · Restricted Project
CarolineConcatto updated the diff for D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost.

-fix the work NEXT in the test

Dec 14 2020, 7:37 AM · Restricted Project
CarolineConcatto added inline comments to D92854: [flang][driver] Add support for `-fsyntax-only`.
Dec 14 2020, 6:18 AM · Restricted Project, Restricted Project
CarolineConcatto accepted D93043: [CostModel] Add costs for llvm.experimental.vector.{extract,insert} intrinsics.

Just in case I had a look at the other functions:
getIntrinsicInstrCost
getShuffleCost and
getVectorInstrCost
To see what would be their behave now that you change some of the types to accept scalable type.
It all looks good to me.

Dec 14 2020, 5:50 AM · Restricted Project
CarolineConcatto added inline comments to D93043: [CostModel] Add costs for llvm.experimental.vector.{extract,insert} intrinsics.
Dec 14 2020, 3:23 AM · Restricted Project
CarolineConcatto added inline comments to D93043: [CostModel] Add costs for llvm.experimental.vector.{extract,insert} intrinsics.
Dec 14 2020, 3:18 AM · Restricted Project
CarolineConcatto added a comment to D93030: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector..

Thank you @ctetreau and @sdesmalen for your reviews.
I believe I've updated the patch according to your suggestions.

Dec 14 2020, 2:55 AM · Restricted Project
CarolineConcatto updated the diff for D93030: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector..
  • update the cost model for gather and scatter using legalized type
Dec 14 2020, 2:50 AM · Restricted Project
CarolineConcatto updated the diff for D93049: [SLPVectorizer]Migrate getTreeCost() to use InstructionCost.
  • fix SLPCostThreshold to use getValue()
Dec 14 2020, 1:12 AM · Restricted Project

Dec 11 2020

CarolineConcatto added inline comments to D93043: [CostModel] Add costs for llvm.experimental.vector.{extract,insert} intrinsics.
Dec 11 2020, 9:47 AM · Restricted Project
CarolineConcatto added a reviewer for D93127: [SLPVectorizer]Migrate getEntryCost to return InstructionCost: ctetreau.
Dec 11 2020, 9:24 AM · Restricted Project
CarolineConcatto added reviewers for D93127: [SLPVectorizer]Migrate getEntryCost to return InstructionCost: sdesmalen, david-arm.
Dec 11 2020, 9:24 AM · Restricted Project
CarolineConcatto requested review of D93127: [SLPVectorizer]Migrate getEntryCost to return InstructionCost.
Dec 11 2020, 9:22 AM · Restricted Project
CarolineConcatto added a reviewer for D93030: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector.: fhahn.
Dec 11 2020, 8:01 AM · Restricted Project
CarolineConcatto updated the diff for D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost.
  • add llvm-ir instruction to the value in the cost model tests
Dec 11 2020, 7:59 AM · Restricted Project

Dec 10 2020

CarolineConcatto retitled D93049: [SLPVectorizer]Migrate getTreeCost() to use InstructionCost from [CostModel]Migrate getTreeCost() to use InstructionCost to [SLPVectorizer]Migrate getTreeCost() to use InstructionCost.
Dec 10 2020, 9:15 AM · Restricted Project
CarolineConcatto requested review of D93049: [SLPVectorizer]Migrate getTreeCost() to use InstructionCost.
Dec 10 2020, 9:10 AM · Restricted Project
CarolineConcatto updated the diff for D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost.
  • replace if statement by early return when facing scalable vector
Dec 10 2020, 9:04 AM · Restricted Project
CarolineConcatto added reviewers for D93030: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector.: ctetreau, samparker, sdesmalen, c-rhodes, david-arm, kmclaughlin.
Dec 10 2020, 5:47 AM · Restricted Project
CarolineConcatto requested review of D93030: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector..
Dec 10 2020, 5:45 AM · Restricted Project

Dec 9 2020

CarolineConcatto updated the diff for D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost.
  • add if statement for scalable vector for Intrinsics that not work with vscale
Dec 9 2020, 5:18 AM · Restricted Project

Dec 3 2020

CarolineConcatto added a comment to D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost.

Hi @ctetreau.
I don't know if you are asking tests for Scalable Vector or FixedVectorType.
For Scalable Vector:
I added on the commit message which intrinsics will follow this patch because these intrinsics are broken for scalable vector.
So new tests with scalable vector will fail.
The only intrinsic that works now for scalable vector is CCTT and CTLZ.
For FixedVectorType:
I believe that only gather and scatter does not have tests for FixedVector, but all the others have tests.

Dec 3 2020, 5:49 AM · Restricted Project
CarolineConcatto added inline comments to D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost.
Dec 3 2020, 3:15 AM · Restricted Project
CarolineConcatto updated the diff for D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost.

-address review's comment

Dec 3 2020, 3:13 AM · Restricted Project
CarolineConcatto updated the summary of D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost.
Dec 3 2020, 2:17 AM · Restricted Project
CarolineConcatto updated the summary of D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost.
Dec 3 2020, 2:16 AM · Restricted Project
CarolineConcatto updated the diff for D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost.
  • fix nit
  • remove failing tests
Dec 3 2020, 2:09 AM · Restricted Project

Dec 1 2020

CarolineConcatto committed rG4b0ef2b07500: [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type (authored by CarolineConcatto).
[NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type
Dec 1 2020, 3:13 AM
CarolineConcatto closed D91532: [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type.
Dec 1 2020, 3:13 AM · Restricted Project

Nov 30 2020

CarolineConcatto added a comment to D91957: [Support] Migrate more high level cost functions to using InstructionCost.

Thank you @david-arm for the patch.
It helps to understand a bit more how to use the new class InstructionCost in D91174
I hope you don't mind but I have a couple of questions.

Nov 30 2020, 4:27 AM · Restricted Project
CarolineConcatto added inline comments to D92237: [SCEVExpander] NFCI: Change Cost type in costAndCollectOperands from int -> unsigned..
Nov 30 2020, 3:09 AM · Restricted Project

Nov 27 2020

CarolineConcatto added a comment to D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost.

Thank you @samparker for your review. I agree with you that we should also test the code path of getCmpSelInstrCost and getArithmeticInstrCost, but at the moment these code paths were/are broken for scalable vector.
We are working to make these paths work for scalable vectors by replacing FixedVector with VectorType and using the ElementType class.
These will be addressed in upcoming patches. I don’t think that we should fix these code paths in this patch because the chain to fix it is long and will make the patch long and complex
What I can do is add tests with XFAIL for now, and remove in the future.
Is this a good solution for now?

Nov 27 2020, 1:57 AM · Restricted Project

Nov 25 2020

CarolineConcatto added reviewers for D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost: sdesmalen, david-arm, ctetreau, samparker.
Nov 25 2020, 5:33 AM · Restricted Project
CarolineConcatto requested review of D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost.
Nov 25 2020, 5:30 AM · Restricted Project

Nov 18 2020

CarolineConcatto added inline comments to D91532: [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type.
Nov 18 2020, 7:52 AM · Restricted Project
CarolineConcatto added inline comments to D91532: [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type.
Nov 18 2020, 5:29 AM · Restricted Project
CarolineConcatto updated the diff for D91532: [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type.

-address review's comment

Nov 18 2020, 5:20 AM · Restricted Project

Nov 16 2020

CarolineConcatto retitled D91532: [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type from [SVE][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type to [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type.
Nov 16 2020, 7:44 AM · Restricted Project
CarolineConcatto added reviewers for D91532: [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type: sdesmalen, david-arm, ctetreau, samparker.
Nov 16 2020, 5:32 AM · Restricted Project
CarolineConcatto updated the diff for D91532: [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type.

-remove non-related changes on Target AMDGPU

Nov 16 2020, 5:22 AM · Restricted Project
CarolineConcatto requested review of D91532: [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type.
Nov 16 2020, 5:14 AM · Restricted Project