This is an archive of the discontinued LLVM Phabricator instance.

[Clang] De-deprecate volatile compound operations
ClosedPublic

Authored by cor3ntin on Jul 23 2022, 5:41 AM.

Details

Summary

As per P2327R1,

=, &= and ^= are no longer deprecated in all languages mode.

Diff Detail

Event Timeline

cor3ntin created this revision.Jul 23 2022, 5:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 23 2022, 5:41 AM
cor3ntin requested review of this revision.Jul 23 2022, 5:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 23 2022, 5:41 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

@aaron.ballman I think getting that in 15 would avoid some churn, WDYT?

shafik added a subscriber: shafik.Jul 23 2022, 7:16 PM

LGTM but I will let Aaron accept it.

clang/docs/ReleaseNotes.rst
523

R3 did not work for me but R1 did.

cor3ntin updated this revision to Diff 447109.Jul 23 2022, 10:19 PM

Fix paper number in release notes.

@shafik Thanks for the review!

clang/docs/ReleaseNotes.rst
523

You are right it is R1 (I double checked on the straw polls page). Thanks for catching that!

aaron.ballman accepted this revision.Jul 24 2022, 6:44 AM

LGTM!

clang/docs/ReleaseNotes.rst
519–523

NFC nit: we should add the revision number to the link titles as well, as done above. (Feel free to land as an NFC change if you want).

clang/lib/Sema/SemaExpr.cpp
13943–13944

re-flowing the comment somewhat.

This revision is now accepted and ready to land.Jul 24 2022, 6:44 AM
This revision was landed with ongoing or failed builds.Jul 24 2022, 7:17 AM
This revision was automatically updated to reflect the committed changes.

@aaron.ballman Thanks a lot for the review. I made a separate nfc commit to address the missing revision numbers.