This patch allows the use of vector_quad and vector_pair, PPC MMA builtin
types, on all PowerPC 64-bit compilation units. When these types are
made available the builtins that use them automatically become available
so semantic checking for mma and pair vector memop __builtins is also
expanded to ensure these builtin function call are only allowed on
Power10 and new architectures. All related test cases are updated to
ensure test coverage.
Details
Details
- Reviewers
nemanjai lei saghir stefanp - Group Reviewers
Restricted Project - Commits
- rG8737c74fab3a: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
The condition for failing semantic chequing on mma builtins was incorrect,
updating this patch to correctly check the semantics and associated testing.
clang/test/Sema/ppc-mma-builtins.c | ||
---|---|---|
2 | can you please add // REQUIRES: powerpc-registered-target for the ppc specific test? |
Comment Actions
Rebasing this patch and addressing review comments
An upstream commit removed the need for this patch to modify a few
test cases so it has been rebased to remain up-to-date, also addressing
review comments.
Comment Actions
LGTM as long as you add the back end test.
clang/test/CodeGen/ppc-mma-types.c | ||
---|---|---|
2–6 | Please add this IR test to the back end codegen tests (for older CPUs). |
Comment Actions
Updated an existing test for the backend with pwr8 and pwr9 be/le targets during commit
Please add this IR test to the back end codegen tests (for older CPUs).