Compiler Engineer worked for IBM before, and now, for ByteDance
- User Since
- May 15 2018, 2:45 AM (253 w, 5 d)
Thu, Mar 16
Feb 22 2023
I didn't see any tests in the PR. Please add one.
Oct 3 2022
Sep 13 2022
I have re-commit as suggested. Thank you for pointing out the testing issue for windows.
Sep 12 2022
Sep 9 2022
Sep 8 2022
Thank for the suggestion, and I appreciate it. The issue of adding the build flags is that, it will pollute the remote cache. For example:
Aug 24 2022
Aug 2 2021
Jul 29 2021
Jul 27 2021
Jul 21 2021
May 17 2021
Apr 11 2021
LGTM. But please do a complete test before enabling it by default.
Hi, @djtodoro, do you have any concern on this ? If not, I will land this patch days later.
Apr 8 2021
Sorry, I don't mean to accept as PowerPC now ...
LGTM. But please hold on for some days to see if @nemanjai has more comments.
Mar 30 2021
Mar 3 2021
LGTM now. But please hold on for at least one week to see if @nemanjai has concern.
Mar 2 2021
It seems that, craig is working on this bugzallia issue. Thank you for reporting this.
Jan 24 2021
Jan 21 2021
The bif/bic difference seems logically fine and probably better overall since we're using less registers, but someone who knows AArch should comment.
Also, it would be interesting to know why the code changed because we are seemingly producing the same set of SDNode ops? There might be another combine/lowering opportunity.
Jan 20 2021
Split the BR_CC into another patch which will enhance the legalizer to support it. For SETCC/SELECT_CC, we will do it inside PowerPC as what other target did.
Jan 19 2021
Jan 18 2021
Jan 17 2021
@nemanjai Do you have any more comments on this ? Thank you!
Jan 12 2021
Thank you for doing this. LGTM now.
Jan 11 2021
This is the same as what I want to do in D86681. As D86684 is still pending, it makes sense to split from it now.
LGTM. Please hold on for days to see if @nemanjai has more comments.
Jan 10 2021
Rebase the patch.
LGTM, but please hold on for days to see if @craig.topper or @nemanjai have more comments.
Jan 7 2021
It surprises to me that you didn't see the difference between LE and AIX, which doesn't make sense to me. Please double confirm to see if there is any conflict when update the test with the script.
Jan 6 2021
Jan 5 2021
Gentle ping ...
Hmm, so we can try to remove those parts that not relative with the parameter arsenm mentioned. I guess most of the check in the DAGCombiner could be removed if I understand correctly. To remove it completely, some work is needed for parameters or others that current IR cannot represent the semantics of the global setting. Is it right ?
- Reason why we need to change the interface