Page MenuHomePhabricator

steven.zhang (Qing Shan Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2018, 2:45 AM (161 w, 2 d)

Compiler Engineer worked for IBM before, and now, for ByteDance

Recent Activity

May 17 2021

steven.zhang added a reviewer for D101759: [PowerPC] Scalar IBM MASS library conversion pass: Restricted Project.
May 17 2021, 10:24 PM · Restricted Project, Restricted Project

Apr 11 2021

steven.zhang committed rGd69c236e1d6b: [NFC][Debug] Fix unnecessary deep-copy for vector to save compiling time (authored by steven.zhang).
[NFC][Debug] Fix unnecessary deep-copy for vector to save compiling time
Apr 11 2021, 11:58 PM
steven.zhang closed D100162: [NFC][Debug] Fix unnecessary deep-copy for vector to save compiling time .
Apr 11 2021, 11:58 PM · Restricted Project
steven.zhang added a comment to D100162: [NFC][Debug] Fix unnecessary deep-copy for vector to save compiling time .

Does this solve the problem?

Apr 11 2021, 11:29 PM · Restricted Project
steven.zhang accepted D92374: [PowerPC] Support f128 under VSX.

LGTM. But please do a complete test before enabling it by default.

Apr 11 2021, 7:41 PM · Restricted Project
steven.zhang committed rG37388b8ad13f: Update personal info in CREDITS.TXT (authored by steven.zhang).
Update personal info in CREDITS.TXT
Apr 11 2021, 4:26 AM
steven.zhang updated steven.zhang.
Apr 11 2021, 4:19 AM
steven.zhang added a comment to D100162: [NFC][Debug] Fix unnecessary deep-copy for vector to save compiling time .

Hi, @djtodoro, do you have any concern on this ? If not, I will land this patch days later.

Apr 11 2021, 3:05 AM · Restricted Project

Apr 8 2021

steven.zhang retitled D100162: [NFC][Debug] Fix unnecessary deep-copy for vector to save compiling time from [Debug] Fix unnecessary deep-copy for vecto to save compiling time to [NFC][Debug] Fix unnecessary deep-copy for vector to save compiling time .
Apr 8 2021, 10:00 PM · Restricted Project
steven.zhang updated the diff for D100162: [NFC][Debug] Fix unnecessary deep-copy for vector to save compiling time .
Apr 8 2021, 9:04 PM · Restricted Project
steven.zhang requested review of D100162: [NFC][Debug] Fix unnecessary deep-copy for vector to save compiling time .
Apr 8 2021, 9:02 PM · Restricted Project
steven.zhang added a comment to D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.

Sorry, I don't mean to accept as PowerPC now ...

Apr 8 2021, 3:48 AM · Restricted Project
steven.zhang accepted D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.

LGTM. But please hold on for some days to see if @nemanjai has more comments.

Apr 8 2021, 3:48 AM · Restricted Project

Mar 30 2021

steven.zhang added inline comments to D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.
Mar 30 2021, 7:06 PM · Restricted Project
steven.zhang added a comment to D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.
Mar 30 2021, 7:05 PM · Restricted Project

Mar 3 2021

steven.zhang accepted D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets.

LGTM now. But please hold on for at least one week to see if @nemanjai has concern.

Mar 3 2021, 11:32 PM · Restricted Project

Mar 2 2021

steven.zhang added a comment to D86183: [DAGCombine] Remove dead node when it is created by getNegatedExpression.

It seems that, craig is working on this bugzallia issue. Thank you for reporting this.

Mar 2 2021, 8:42 PM · Restricted Project

Jan 24 2021

steven.zhang committed rGffc3e800c65e: [NFC] [DAGCombine] Correct the result for sqrt even the iteration is zero (authored by steven.zhang).
[NFC] [DAGCombine] Correct the result for sqrt even the iteration is zero
Jan 24 2021, 8:03 PM
steven.zhang closed D94480: [NFC] [DAGCombine] Correct the result for sqrt even the iteration is zero.
Jan 24 2021, 8:03 PM · Restricted Project

Jan 21 2021

steven.zhang added a comment to D94480: [NFC] [DAGCombine] Correct the result for sqrt even the iteration is zero.

The bif/bic difference seems logically fine and probably better overall since we're using less registers, but someone who knows AArch should comment.
Also, it would be interesting to know why the code changed because we are seemingly producing the same set of SDNode ops? There might be another combine/lowering opportunity.

Jan 21 2021, 7:12 PM · Restricted Project
steven.zhang updated the diff for D94480: [NFC] [DAGCombine] Correct the result for sqrt even the iteration is zero.
Jan 21 2021, 7:08 PM · Restricted Project

Jan 20 2021

steven.zhang updated the diff for D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.

Split the BR_CC into another patch which will enhance the legalizer to support it. For SETCC/SELECT_CC, we will do it inside PowerPC as what other target did.

Jan 20 2021, 9:41 PM · Restricted Project
steven.zhang retitled D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled from [PowerPC] Lower the SETCC/SELECT_CC/BR_CC as libcall for fp128 with Power9 vector disabled to [PowerPC] Lower the SETCC/SELECT_CC as libcall for fp128 with Power9 vector disabled.
Jan 20 2021, 9:36 PM · Restricted Project
steven.zhang updated the diff for D94480: [NFC] [DAGCombine] Correct the result for sqrt even the iteration is zero.

Address comments.

Jan 20 2021, 9:16 PM · Restricted Project
steven.zhang accepted D94464: [PowerPC] Duplicate inherited heuristic from base scheduler.

LGTM.

Jan 20 2021, 12:21 AM · Restricted Project

Jan 19 2021

steven.zhang added a comment to D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.

The description isn't really adequate - it does not answer my question at all really. The question is why not set the legalization action for BR_CC as Expand? Namely, what does the legalizer do that we don't want it to do if we let it expand the node? You just answered the question with the equivalent of "The legalizer does its job and that's not what we want." So please explain why that is not what we want.

Jan 19 2021, 1:52 AM · Restricted Project

Jan 18 2021

steven.zhang added a comment to D94480: [NFC] [DAGCombine] Correct the result for sqrt even the iteration is zero.

Gentle ping...

Jan 18 2021, 4:34 PM · Restricted Project
steven.zhang added reviewers for D94480: [NFC] [DAGCombine] Correct the result for sqrt even the iteration is zero: RKSimon, dmgreen.
Jan 18 2021, 4:34 PM · Restricted Project

Jan 17 2021

steven.zhang added a comment to D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.

@nemanjai Do you have any more comments on this ? Thank you!

Jan 17 2021, 7:55 PM · Restricted Project
steven.zhang added a comment to D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.

Ping...

Jan 17 2021, 4:22 PM · Restricted Project

Jan 12 2021

steven.zhang abandoned D94462: [PowerPC][AIX] Support calling convention for IEEE Long Double.
Jan 12 2021, 5:47 PM · Restricted Project
steven.zhang updated the summary of D94480: [NFC] [DAGCombine] Correct the result for sqrt even the iteration is zero.
Jan 12 2021, 2:27 AM · Restricted Project
steven.zhang requested review of D94480: [NFC] [DAGCombine] Correct the result for sqrt even the iteration is zero.
Jan 12 2021, 2:12 AM · Restricted Project
steven.zhang accepted D94159: [PowerPC] [NFC] Add AIX triple to some regression tests.

Thank you for doing this. LGTM now.

Jan 12 2021, 1:52 AM · Restricted Project

Jan 11 2021

steven.zhang added a comment to D94464: [PowerPC] Duplicate inherited heuristic from base scheduler.

This is the same as what I want to do in D86681. As D86684 is still pending, it makes sense to split from it now.

Jan 11 2021, 11:14 PM · Restricted Project
steven.zhang updated the summary of D94462: [PowerPC][AIX] Support calling convention for IEEE Long Double.
Jan 11 2021, 6:14 PM · Restricted Project
steven.zhang requested review of D94462: [PowerPC][AIX] Support calling convention for IEEE Long Double.
Jan 11 2021, 6:12 PM · Restricted Project
steven.zhang accepted D94054: [PowerPC] Try to fold sqrt/sdiv test results with the branch..
Jan 11 2021, 6:03 PM · Restricted Project
steven.zhang added a comment to D94054: [PowerPC] Try to fold sqrt/sdiv test results with the branch..

LGTM. Please hold on for days to see if @nemanjai has more comments.

Jan 11 2021, 6:03 PM · Restricted Project

Jan 10 2021

steven.zhang updated the diff for D86684: [Refactor] Add the SchedHeuristic for Scheduler to allow platform customizing the heuristics.

Rebase the patch.

Jan 10 2021, 10:44 PM · Restricted Project
steven.zhang added a comment to D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.

Ping ...

Jan 10 2021, 8:10 PM · Restricted Project
steven.zhang accepted D92473: [Legalizer] Promote result type in expanding FP_TO_XINT.

LGTM, but please hold on for days to see if @craig.topper or @nemanjai have more comments.

Jan 10 2021, 7:50 PM · Restricted Project
steven.zhang committed rG7539c75bb438: [DAGCombine] Remove the check for unsafe-fp-math when we are checking the AFN (authored by steven.zhang).
[DAGCombine] Remove the check for unsafe-fp-math when we are checking the AFN
Jan 10 2021, 6:28 PM
steven.zhang closed D93891: [DAGCombine] Remove the check for unsafe-fp-math when we are checking the AFN.
Jan 10 2021, 6:28 PM · Restricted Project

Jan 7 2021

steven.zhang added inline comments to D94282: [PowerPC] Support ppc-asm-full-reg-names for AIX.
Jan 7 2021, 11:32 PM · Restricted Project
steven.zhang updated the summary of D94162: [PowerPC] Add variants of 64-bit vector types for vec_sel..
Jan 7 2021, 6:18 PM · Restricted Project
steven.zhang added inline comments to D94211: [NFC][PowerPC] Format and clean the logic for setOperationActions to make it easier to maintain.
Jan 7 2021, 2:04 AM · Restricted Project
steven.zhang added a comment to D94159: [PowerPC] [NFC] Add AIX triple to some regression tests.

It surprises to me that you didn't see the difference between LE and AIX, which doesn't make sense to me. Please double confirm to see if there is any conflict when update the test with the script.

Jan 7 2021, 2:02 AM · Restricted Project
steven.zhang added inline comments to D94211: [NFC][PowerPC] Format and clean the logic for setOperationActions to make it easier to maintain.
Jan 7 2021, 1:33 AM · Restricted Project

Jan 6 2021

steven.zhang updated the summary of D94211: [NFC][PowerPC] Format and clean the logic for setOperationActions to make it easier to maintain.
Jan 6 2021, 7:18 PM · Restricted Project
steven.zhang requested review of D94211: [NFC][PowerPC] Format and clean the logic for setOperationActions to make it easier to maintain.
Jan 6 2021, 7:17 PM · Restricted Project

Jan 5 2021

steven.zhang added inline comments to D92473: [Legalizer] Promote result type in expanding FP_TO_XINT.
Jan 5 2021, 10:06 PM · Restricted Project
steven.zhang added a comment to D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.

Gentle ping ...

Jan 5 2021, 10:01 PM · Restricted Project
steven.zhang added a comment to D93891: [DAGCombine] Remove the check for unsafe-fp-math when we are checking the AFN.

Hmm, so we can try to remove those parts that not relative with the parameter arsenm mentioned. I guess most of the check in the DAGCombiner could be removed if I understand correctly. To remove it completely, some work is needed for parameters or others that current IR cannot represent the semantics of the global setting. Is it right ?

Jan 5 2021, 10:00 PM · Restricted Project
steven.zhang added a comment to D91050: [NFC] Add the EmitTargetCodeForConstantPool hook for target to customize it with MachineConstantPoolValue.
  • Reason why we need to change the interface
Jan 5 2021, 9:49 PM · Restricted Project
steven.zhang added a comment to D91050: [NFC] Add the EmitTargetCodeForConstantPool hook for target to customize it with MachineConstantPoolValue.

Ping...

Jan 5 2021, 4:10 PM · Restricted Project

Jan 4 2021

steven.zhang committed rG2962f1149c8f: [NFC] Add the getSizeInBytes() interface for MachineConstantPoolValue (authored by steven.zhang).
[NFC] Add the getSizeInBytes() interface for MachineConstantPoolValue
Jan 4 2021, 7:26 PM
steven.zhang closed D89108: [NFC] Add the getSizeInBytes() interface for MachineConstantPoolValue.
Jan 4 2021, 7:26 PM · Restricted Project
steven.zhang added inline comments to D94054: [PowerPC] Try to fold sqrt/sdiv test results with the branch..
Jan 4 2021, 6:44 PM · Restricted Project
steven.zhang added a comment to D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2).

Some code style comments.

Jan 4 2021, 2:53 AM · Restricted Project, Restricted Project
steven.zhang added a reviewer for D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2): Restricted Project.
Jan 4 2021, 2:46 AM · Restricted Project, Restricted Project

Dec 30 2020

steven.zhang accepted D93676: [UpdateTestChecks] Fix PowerPC RE to support AIX assembly.

Also LGTM.

Dec 30 2020, 5:18 PM · Restricted Project

Dec 29 2020

steven.zhang updated the diff for D93891: [DAGCombine] Remove the check for unsafe-fp-math when we are checking the AFN.
Dec 29 2020, 6:57 PM · Restricted Project
steven.zhang added a comment to D93891: [DAGCombine] Remove the check for unsafe-fp-math when we are checking the AFN.

We're trying to (very slowly...) move away from needing the global/target options. Also, I'm not sure how those translate with GlobalISel.
If there's a real-world case where the target options do not match the fast-math-flags on the IR, we should investigate if that was unexpected. Otherwise, I would prefer that we not add to the uses of target options.

Dec 29 2020, 6:53 PM · Restricted Project
steven.zhang requested review of D93891: [DAGCombine] Remove the check for unsafe-fp-math when we are checking the AFN.
Dec 29 2020, 12:32 AM · Restricted Project

Dec 28 2020

steven.zhang added a comment to D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets.

I understand that the back end only needs Altivec to support the operations, but enabling this on non-vsx subtargets is different from what GCC does. I don't see a good reason for us to depart from that.

Dec 28 2020, 6:37 PM · Restricted Project
steven.zhang added a comment to D91050: [NFC] Add the EmitTargetCodeForConstantPool hook for target to customize it with MachineConstantPoolValue.

Hmm... I think it is very surprising if DAG.getConstantPool() does not return ConstantPoolSDNode. I am not in favour of any design that violates such seemingly reasonable assumptions.

Dec 28 2020, 6:30 PM · Restricted Project
steven.zhang added a comment to D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.

Please explain in the description of the review (and subsequent commit message) why custom lowering is needed. I suppose for SELECT_CC, it is needed because using setOperationAction() uses the result type which is only guaranteed to match the true/false value but not the comparison types. However, it is not immediately obvious to me why we need custom lowering for BR_CC.

Dec 28 2020, 6:11 PM · Restricted Project
steven.zhang updated the summary of D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.
Dec 28 2020, 6:09 PM · Restricted Project
steven.zhang added a comment to D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.

Gentle ping...

Dec 28 2020, 1:17 AM · Restricted Project

Dec 27 2020

steven.zhang added a comment to D86864: [MachineSinking] sink more profitable loads.

Is it better to have the check before 'if (PDT->dominates(To, BB)) {' ?

Dec 27 2020, 9:48 PM · Restricted Project
steven.zhang updated the diff for D91053: [PowerPC] Lump the constants to save one addis for each constant access.

Rebase the patch again.

Dec 27 2020, 9:45 PM · Restricted Project
steven.zhang updated the diff for D91050: [NFC] Add the EmitTargetCodeForConstantPool hook for target to customize it with MachineConstantPoolValue.

Re-implement with SelectionDAGTargetInfo.

Dec 27 2020, 9:29 PM · Restricted Project

Dec 24 2020

steven.zhang planned changes to D91053: [PowerPC] Lump the constants to save one addis for each constant access.

The dependent patch changed. Need rebase.

Dec 24 2020, 2:06 AM · Restricted Project

Dec 23 2020

steven.zhang added a comment to D91050: [NFC] Add the EmitTargetCodeForConstantPool hook for target to customize it with MachineConstantPoolValue.

What should we do with SelectionDAG::getConstantPool? At the very least I'd expect better comments explaining when each should be used, but I'm wondering whether we can get away with just the TLI version?

Dec 23 2020, 6:35 PM · Restricted Project
steven.zhang updated the diff for D89108: [NFC] Add the getSizeInBytes() interface for MachineConstantPoolValue.

Thank you for the review and Merry Christmas !

Dec 23 2020, 5:25 PM · Restricted Project
steven.zhang added a comment to D91053: [PowerPC] Lump the constants to save one addis for each constant access.

The test you are looking for is llvm/test/CodeGen/PowerPC/constant-pool.ll in fact.

Not quite. There seems to only be float/double/double double/vector and only for P9/P10. What happens with:

  1. enough constants that the load is widened
Dec 23 2020, 1:32 AM · Restricted Project
steven.zhang updated the diff for D91053: [PowerPC] Lump the constants to save one addis for each constant access.

Address comments and add tests in llvm/test/CodeGen/PowerPC/constant-pool.ll to show the padding added for alignment. Also, add the RUN line for Power8 as requested.

Dec 23 2020, 1:26 AM · Restricted Project

Dec 22 2020

steven.zhang added a comment to D93676: [UpdateTestChecks] Fix PowerPC RE to support AIX assembly.

Yes, test is missing as MaskRay mentioned. You'd better update one PowerPC test at least so that, we can see what it looks like.

Dec 22 2020, 6:18 PM · Restricted Project
steven.zhang added a comment to D91053: [PowerPC] Lump the constants to save one addis for each constant access.

There are two parent revisions that this patch depends on. You need to apply them first. I will add a new test to summarize all the pattern we can handle.

Which ones? I don't see them listed in "Parent Revisions"

Dec 22 2020, 3:38 PM · Restricted Project

Dec 21 2020

steven.zhang added a comment to D91053: [PowerPC] Lump the constants to save one addis for each constant access.

The test you are looking for is llvm/test/CodeGen/PowerPC/constant-pool.ll in fact.

Dec 21 2020, 6:11 PM · Restricted Project
steven.zhang added a comment to D91053: [PowerPC] Lump the constants to save one addis for each constant access.

Rebase the patch.

Huh? Something wrong with this rebase? Not only is there an issue with getSize() I pointed out, but there are also uses of non-existent functions:

PPCISelLowering.h:740:61: error: only virtual member functions can be marked 'override'
                            unsigned TargetFlags = 0) const override;
                                                            ^~~~~~~~
PPCISelLowering.cpp:2997:12: error: no member named 'getConstantPool' in 'llvm::TargetLowering'; did you mean simply 'getConstantPool'?
    return TargetLowering::getConstantPool(C, DAG, NewAlign, VT, Alignment,
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           getConstantPool
PPCISelLowering.cpp:2987:28: note: 'getConstantPool' declared here
SDValue PPCTargetLowering::getConstantPool(const Constant *C, SelectionDAG &DAG,
                           ^
PPCISelLowering.cpp:3018:12: error: no member named 'getConstantPool' in 'llvm::TargetLowering'; did you mean simply 'getConstantPool'?
    return TargetLowering::getConstantPool(C, DAG, NewAlign, VT, Alignment,
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           getConstantPool
PPCISelLowering.cpp:2987:28: note: 'getConstantPool' declared here
SDValue PPCTargetLowering::getConstantPool(const Constant *C, SelectionDAG &DAG,
                           ^
3 errors generated.

Also, I don't see adequate testing here (it may be hidden among all the test case changes and I missed it). There should be a test case with multiple constants loaded from the constant pool for all the types as well as for mixed types. AFAICT most of the test changes are single constants getting their own symbol in the TOC - which neither adequately tests this feature nor provides improvements of any kind (as pointed out in the description).

Dec 21 2020, 6:07 PM · Restricted Project
steven.zhang added inline comments to D91053: [PowerPC] Lump the constants to save one addis for each constant access.
Dec 21 2020, 2:32 AM · Restricted Project
steven.zhang added a comment to D91053: [PowerPC] Lump the constants to save one addis for each constant access.

If there is only one constant, we will have one extra load with this patch. But the load could be optimized by linker if it merges the TOC. It is not easy inside compiler to handle it as ISEL is done basing on per BB, and we don't know if there are other constants until other BBs are selected. Any thoughts ?

As discussed, FunctionLoweringInfo is 'global' to SelectionDAG. Can we take advantage of it to record some global information? FunctionLoweringInfo::set has already scanned over each BB, each instruction.

Dec 21 2020, 2:30 AM · Restricted Project
steven.zhang updated the diff for D91053: [PowerPC] Lump the constants to save one addis for each constant access.

Rebase the patch.

Dec 21 2020, 2:28 AM · Restricted Project

Dec 17 2020

steven.zhang committed rG477b6505fa1d: [PowerPC] Select the D-Form load if we know its offset meets the requirement (authored by steven.zhang).
[PowerPC] Select the D-Form load if we know its offset meets the requirement
Dec 17 2020, 11:33 PM
steven.zhang closed D93099: [PowerPC] Select the D-Form load if we know its offset meets the requirement.
Dec 17 2020, 11:33 PM · Restricted Project
steven.zhang committed rG385e9a2a047b: [DAGCombiner] Improve shift by select of constant (authored by laytonio).
[DAGCombiner] Improve shift by select of constant
Dec 17 2020, 6:24 PM
steven.zhang added a comment to D90349: [DAGCombiner] Improve shift by select of constant.

Done in 385e9a2a047bc0bee13a21a9016763e694a686a3

Dec 17 2020, 6:24 PM · Restricted Project
steven.zhang closed D90349: [DAGCombiner] Improve shift by select of constant.
Dec 17 2020, 6:24 PM · Restricted Project
steven.zhang updated the diff for D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.
Dec 17 2020, 1:42 AM · Restricted Project
steven.zhang added a comment to D93254: [NFC][SampleFDO] Preparation to support multiple sections with the same type in ExtBinary format..

The new added field LayoutIndex miss to be initialized in include/llvm/ProfileData/SampleProfWriter.h:281 which cause the compiler(clang) warning if with option -Wmissing-field-initializers.
This is the error message:
error: missing field 'LayoutIndex' initializer [-Werror,-Wmissing-field-initializers]

Dec 17 2020, 12:28 AM · Restricted Project
steven.zhang committed rGebdd20f430c4: Expand the fp_to_int/int_to_fp/fp_round/fp_extend as libcall for fp128 (authored by steven.zhang).
Expand the fp_to_int/int_to_fp/fp_round/fp_extend as libcall for fp128
Dec 17 2020, 12:01 AM
steven.zhang closed D91331: Expand the fp_to_int/int_to_fp/fp_round/fp_extend as libcall for fp128.
Dec 17 2020, 12:00 AM · Restricted Project

Dec 16 2020

steven.zhang added inline comments to D90349: [DAGCombiner] Improve shift by select of constant.
Dec 16 2020, 11:52 PM · Restricted Project
steven.zhang planned changes to D91053: [PowerPC] Lump the constants to save one addis for each constant access.

That means we have to make it as target independent. I will take a look to see if there is nice way to make it as target independent.

Dec 16 2020, 11:28 PM · Restricted Project
steven.zhang added a comment to D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..

@steven.zhang The idea is that this patch should be NFC. All existing load/store test cases should pass with this refactoring. I do think there should be more tests added, perhaps in a follow up patch. What do you think?

Dec 16 2020, 7:05 PM · Restricted Project, Restricted Project
steven.zhang added inline comments to D93099: [PowerPC] Select the D-Form load if we know its offset meets the requirement.
Dec 16 2020, 7:01 PM · Restricted Project
steven.zhang updated the diff for D93099: [PowerPC] Select the D-Form load if we know its offset meets the requirement.

Address comments.

Dec 16 2020, 7:00 PM · Restricted Project
steven.zhang added inline comments to D93377: [Clang] Add __ibm128 type to represent ppc_fp128.
Dec 16 2020, 1:08 AM · Restricted Project