Page MenuHomePhabricator

kamaub (Kamau Bridgeman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 4 2019, 12:39 PM (174 w, 1 d)

Recent Activity

Yesterday

kamaub added inline comments to D133940: Change PowerPC64 bots to build runtimes with -DLLVM_ENABLE_RUNTIMES.
Tue, Oct 4, 7:28 AM · Restricted Project
kamaub committed rZORGc20e90d326ee: Change PowerPC64 bots to build runtimes with -DLLVM_ENABLE_RUNTIMES (authored by kamaub).
Change PowerPC64 bots to build runtimes with -DLLVM_ENABLE_RUNTIMES
Tue, Oct 4, 7:26 AM · Restricted Project
kamaub closed D133940: Change PowerPC64 bots to build runtimes with -DLLVM_ENABLE_RUNTIMES.
Tue, Oct 4, 7:26 AM · Restricted Project

Mon, Sep 19

kamaub added a comment to D133940: Change PowerPC64 bots to build runtimes with -DLLVM_ENABLE_RUNTIMES.

Thanks for the review! :)

Mon, Sep 19, 7:28 AM · Restricted Project

Thu, Sep 15

kamaub requested review of D133940: Change PowerPC64 bots to build runtimes with -DLLVM_ENABLE_RUNTIMES.
Thu, Sep 15, 6:28 AM · Restricted Project

Jul 26 2022

kamaub added a comment to D121276: [CMake] Include runtimes test suites in check-all.

@phosek Pinging this patch, our builders which run check-all and expect compiler-rt, enabled as a runtime with -DLLVM_ENABLE_RUNTIMES=compiler-rt, to be covered in testing are not doing this and are still being affected by this changeset.
clang-ppc64le-rhel and clang-ppc64-aix are not currently testing compiler-rt because of this change.
clang-ppc64le-linux-test-suite enables compiler-rt as a project with -DLLVM_ENABLE_PROJECTS=compiler-rt and test it under check-all as expected.
Before this, both bots would test compiler-rt under check-all. Could you please take a look at this?

Jul 26 2022, 10:35 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 19 2022

kamaub committed rG2a408f200cb5: [TSAN] Disable clone_setns test case on PPC64 RHEL 7.9 Targets (authored by kamaub).
[TSAN] Disable clone_setns test case on PPC64 RHEL 7.9 Targets
Jul 19 2022, 11:25 AM · Restricted Project, Restricted Project
kamaub closed D130086: [TSAN] Disable clone_setns test case on PPC64 RHEL 7.9 Targets.
Jul 19 2022, 11:25 AM · Restricted Project, Restricted Project
kamaub updated the summary of D130086: [TSAN] Disable clone_setns test case on PPC64 RHEL 7.9 Targets.
Jul 19 2022, 7:26 AM · Restricted Project, Restricted Project
kamaub requested review of D130086: [TSAN] Disable clone_setns test case on PPC64 RHEL 7.9 Targets.
Jul 19 2022, 7:02 AM · Restricted Project, Restricted Project

Jul 6 2022

kamaub committed rZORGf56b269c5ce2: Changing the ppc64[be|le] bots to TestSuiteBuilders (authored by kamaub).
Changing the ppc64[be|le] bots to TestSuiteBuilders
Jul 6 2022, 6:20 AM · Restricted Project
kamaub closed D128273: Changing the ppc64[be|le] bots to TestSuiteBuilders.
Jul 6 2022, 6:20 AM · Restricted Project

Jul 5 2022

kamaub added a comment to D128273: Changing the ppc64[be|le] bots to TestSuiteBuilders.

Thank you!

Jul 5 2022, 1:35 PM · Restricted Project

Jun 30 2022

kamaub added inline comments to D128273: Changing the ppc64[be|le] bots to TestSuiteBuilders.
Jun 30 2022, 9:35 AM · Restricted Project

Jun 29 2022

kamaub updated the diff for D128273: Changing the ppc64[be|le] bots to TestSuiteBuilders.

This update removes the edits made to the TestSuiteBuilder, as they are not
critical to the PR, we will not be moving away from the UnifiedTreeBuilder
as a base for the TestSuiteBuilder.

Jun 29 2022, 7:27 AM · Restricted Project

Jun 23 2022

kamaub planned changes to D128273: Changing the ppc64[be|le] bots to TestSuiteBuilders.

Planning to move away from the UnifiedTreeBuilder for our TestSuiteBuilder

Jun 23 2022, 1:38 PM · Restricted Project
kamaub updated the summary of D128273: Changing the ppc64[be|le] bots to TestSuiteBuilders.
Jun 23 2022, 12:50 PM · Restricted Project

Jun 21 2022

kamaub committed rZORGd995ac76d743: Changing number max number of build for ppc64le-flang-mlir-rhel-test (authored by kamaub).
Changing number max number of build for ppc64le-flang-mlir-rhel-test
Jun 21 2022, 1:14 PM · Restricted Project
kamaub closed D123060: Changing number max number of build for ppc64le-flang-mlir-rhel-test.
Jun 21 2022, 1:14 PM · Restricted Project
kamaub requested review of D128273: Changing the ppc64[be|le] bots to TestSuiteBuilders.
Jun 21 2022, 6:41 AM · Restricted Project

Jun 8 2022

kamaub added a comment to D125499: Enabling the detection of devtoolset-11 toolchain..

I'm curious what is your system configuration where this patch actually allows for detection of devtoolset? I noticed that if clang and gcc are both installed to /usr/, then driver will pick the gcc in /usr/ over the one in /opt/rh/.../

Jun 8 2022, 12:30 PM · Restricted Project, Restricted Project

May 19 2022

kamaub committed rZORG0f1b47ed6bf1: Enabling ccache for all ppc64 buildbots (authored by kamaub).
Enabling ccache for all ppc64 buildbots
May 19 2022, 6:43 AM · Restricted Project
kamaub closed D125890: Enabling ccache for all ppc64 buildbots.
May 19 2022, 6:43 AM · Restricted Project

May 18 2022

kamaub requested review of D125890: Enabling ccache for all ppc64 buildbots.
May 18 2022, 7:36 AM · Restricted Project

May 17 2022

kamaub committed rG99639e5a3e6e: Enabling the detection of devtoolset-11 toolchain. (authored by kamaub).
Enabling the detection of devtoolset-11 toolchain.
May 17 2022, 5:58 AM · Restricted Project, Restricted Project
kamaub closed D125499: Enabling the detection of devtoolset-11 toolchain..
May 17 2022, 5:57 AM · Restricted Project, Restricted Project

May 12 2022

kamaub requested review of D125499: Enabling the detection of devtoolset-11 toolchain..
May 12 2022, 1:18 PM · Restricted Project, Restricted Project

Apr 18 2022

kamaub added a comment to D123060: Changing number max number of build for ppc64le-flang-mlir-rhel-test.

Depending on the build requests queues any combination of 2 concurrent builds is possible. Yes, it is possible to have 2 ppc64le-flang-rhel-clang builds running and ppc64le-mlir-rhel-clang builds waiting.

Apr 18 2022, 11:34 AM · Restricted Project
kamaub updated the diff for D123060: Changing number max number of build for ppc64le-flang-mlir-rhel-test.

Creating separate workers for the flang and mlir ppc64le builders to remove any
dependency on build request order between the two bots as was pointed out in a
previous review.

Apr 18 2022, 11:31 AM · Restricted Project

Apr 12 2022

kamaub added a comment to D123060: Changing number max number of build for ppc64le-flang-mlir-rhel-test.

Hello Kamau,

ppc64le-flang-rhel-clang seems using a lot of resources. It takes up to 15 minutes to build when it uses the computer exclusively.

What is the expected build time when 2 ppc64le-flang-rhel-clang builds will be running simultaneously on the same computer?

Apr 12 2022, 7:53 AM · Restricted Project

Apr 7 2022

kamaub committed rZORGd5a468e601db: Enabling ccache for all ppc64le buildbots (authored by kamaub).
Enabling ccache for all ppc64le buildbots
Apr 7 2022, 1:28 PM · Restricted Project
kamaub closed D119757: Enabling ccache for all ppc64le buildbots.
Apr 7 2022, 1:28 PM · Restricted Project

Apr 4 2022

kamaub requested review of D123060: Changing number max number of build for ppc64le-flang-mlir-rhel-test.
Apr 4 2022, 12:08 PM · Restricted Project

Mar 25 2022

kamaub added a comment to D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators .

I'm sorry I took so long to notify you but I need to bring these bots back to green as soon as possible, they have been broken too long.

Mar 25 2022, 7:57 AM · Restricted Project, Restricted Project
kamaub added a comment to D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators .

This option appears to incorrectly warn warning that unsigned NumEntries = getNumEntries(); is "set but not used" in llvm/include/llvm/ADT/DenseMap.h:129 and so it is breaking the ppc64le-lld-multistage-test bot.
This could be because the only use is in an assert which is in a corner case maybe?

Mar 25 2022, 7:55 AM · Restricted Project, Restricted Project

Mar 18 2022

kamaub added a comment to D121654: [RISCV] Ensure PseudoLA* can be hoisted.

Does:

diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
index f52965dab759..299c68da7c2f 100644
--- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
+++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -3769,6 +3769,15 @@ SDValue RISCVTargetLowering::getAddr(NodeTy *N, SelectionDAG &DAG,
   }
 }
 
+template SDValue RISCVTargetLowering::getAddr<GlobalAddressSDNode>(
+    GlobalAddressSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+template SDValue RISCVTargetLowering::getAddr<BlockAddressSDNode>(
+    BlockAddressSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+template SDValue RISCVTargetLowering::getAddr<ConstantPoolSDNode>(
+    ConstantPoolSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+template SDValue RISCVTargetLowering::getAddr<JumpTableSDNode>(
+    JumpTableSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+
 SDValue RISCVTargetLowering::lowerGlobalAddress(SDValue Op,
                                                 SelectionDAG &DAG) const {
   SDLoc DL(Op);

fix the error for you?

I'd be happy to review and approve a patch with this change but I think the fastest resolution to getting the bot back to green would be to revert and then recommit with this change added. The bot has been broken for over 24 hours so we would like to get it back online as soon as possible, thank you for your quick response. :)

I've just committed the fix as 63ea7797dd5bb77cc7b2904e20a5b779d30d4f2d; strange how this exposes it but it's been lurking ready to break since 41454ab25645 / D114950.

Mar 18 2022, 7:39 AM · Restricted Project, Restricted Project
kamaub added a comment to D121837: [OpenMP][FIX] Allow device constructors for AMD GPU.

The test cases added with this commit failed on clang-ppc64be-linux-lnt # 13809 could you please revert this change, and recommit with the test case corrected? thank you.

Mar 18 2022, 7:25 AM · Restricted Project, Restricted Project

Mar 17 2022

kamaub added a comment to D121654: [RISCV] Ensure PseudoLA* can be hoisted.

Does:

diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
index f52965dab759..299c68da7c2f 100644
--- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
+++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -3769,6 +3769,15 @@ SDValue RISCVTargetLowering::getAddr(NodeTy *N, SelectionDAG &DAG,
   }
 }
 
+template SDValue RISCVTargetLowering::getAddr<GlobalAddressSDNode>(
+    GlobalAddressSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+template SDValue RISCVTargetLowering::getAddr<BlockAddressSDNode>(
+    BlockAddressSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+template SDValue RISCVTargetLowering::getAddr<ConstantPoolSDNode>(
+    ConstantPoolSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+template SDValue RISCVTargetLowering::getAddr<JumpTableSDNode>(
+    JumpTableSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+
 SDValue RISCVTargetLowering::lowerGlobalAddress(SDValue Op,
                                                 SelectionDAG &DAG) const {
   SDLoc DL(Op);

fix the error for you?

Mar 17 2022, 6:36 PM · Restricted Project, Restricted Project
kamaub added a comment to D121654: [RISCV] Ensure PseudoLA* can be hoisted.

I have confirmed that this patch cause a miscompile on our sanitizer-ppc64be-linux #4255 bot, please investigate and fix this as soon as possible, thank you.

The log says:

../../../../lib/libLLVMRISCVCodeGen.a(RISCVISelDAGToDAG.cpp.o): In function `selectImm(llvm::SelectionDAG*, llvm::SDLoc const&, llvm::MVT, long, llvm::RISCVSubtarget const&)':
RISCVISelDAGToDAG.cpp:(.text._ZL9selectImmPN4llvm12SelectionDAGERKNS_5SDLocENS_3MVTElRKNS_14RISCVSubtargetE+0x3d8): undefined reference to `llvm::SDValue llvm::RISCVTargetLowering::getAddr<llvm::ConstantPoolSDNode>(llvm::ConstantPoolSDNode*, llvm::SelectionDAG&, bool) const'
collect2: error: ld returned 1 exit status

Other buildbots are totally fine, as are my local builds. I really do not see how on earth _this_ change can cause the function I'm editing to no longer exist, unless the host toolchain is just broken.

Mar 17 2022, 5:53 PM · Restricted Project, Restricted Project
kamaub added a comment to D121654: [RISCV] Ensure PseudoLA* can be hoisted.

Does:

diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
index f52965dab759..299c68da7c2f 100644
--- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
+++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -3769,6 +3769,15 @@ SDValue RISCVTargetLowering::getAddr(NodeTy *N, SelectionDAG &DAG,
   }
 }
 
+template SDValue RISCVTargetLowering::getAddr<GlobalAddressSDNode>(
+    GlobalAddressSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+template SDValue RISCVTargetLowering::getAddr<BlockAddressSDNode>(
+    BlockAddressSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+template SDValue RISCVTargetLowering::getAddr<ConstantPoolSDNode>(
+    ConstantPoolSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+template SDValue RISCVTargetLowering::getAddr<JumpTableSDNode>(
+    JumpTableSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+
 SDValue RISCVTargetLowering::lowerGlobalAddress(SDValue Op,
                                                 SelectionDAG &DAG) const {
   SDLoc DL(Op);

fix the error for you?

Mar 17 2022, 5:51 PM · Restricted Project, Restricted Project
kamaub added a comment to D121654: [RISCV] Ensure PseudoLA* can be hoisted.

I have confirmed that this patch cause a miscompile on our sanitizer-ppc64be-linux #4255 bot, please investigate and fix this as soon as possible, thank you.

Mar 17 2022, 3:41 PM · Restricted Project, Restricted Project

Mar 16 2022

kamaub added a comment to D121276: [CMake] Include runtimes test suites in check-all.

This change broke the clang-ppc64le-rhel #15899 bot. It actually pass this and every other bot green
but the next build after sanitizer test cases on clang-ppc64le-rhel #15900 for continuous builds fails,
that is, some clean builds pass but mostly continuous builds fail.

Mar 16 2022, 5:34 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 14 2022

kamaub requested review of D119757: Enabling ccache for all ppc64le buildbots.
Feb 14 2022, 11:52 AM · Restricted Project

Feb 1 2022

kamaub committed rZORG0f8273778f3b: [zorg] Remove the clang-ppc64be-linux bot (authored by kamaub).
[zorg] Remove the clang-ppc64be-linux bot
Feb 1 2022, 6:04 AM
kamaub closed D117716: [zorg] Remove the clang-ppc64be-linux bot.
Feb 1 2022, 6:04 AM

Jan 19 2022

kamaub updated the summary of D117716: [zorg] Remove the clang-ppc64be-linux bot.
Jan 19 2022, 1:16 PM
kamaub requested review of D117716: [zorg] Remove the clang-ppc64be-linux bot.
Jan 19 2022, 1:11 PM

Nov 23 2021

kamaub added a comment to D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD.

Test case clang/test/CodeGen/ppc-mm-malloc.c fails on powerpc BE buildbots with this changeset
https://lab.llvm.org/buildbot/#/builders/93/builds/6031
https://lab.llvm.org/buildbot/#/builders/100/builds/10836
https://lab.llvm.org/buildbot/#/builders/52/builds/12719

Nov 23 2021, 7:04 AM · Restricted Project

Oct 13 2021

kamaub committed rG89ec99c77894: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter (authored by kamaub).
[PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter
Oct 13 2021, 7:40 AM
kamaub closed D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter.
Oct 13 2021, 7:40 AM · Restricted Project

Oct 12 2021

kamaub updated the diff for D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter.

Adding shift variable test case to builtins-ppc-xlcompat-rotate.c as per
review comment request.

Oct 12 2021, 12:50 PM · Restricted Project
kamaub updated the diff for D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter.

Addressing review request to remove unnecessary testing line.

Oct 12 2021, 10:33 AM · Restricted Project

Oct 7 2021

kamaub accepted D110934: [NFC] Update return type of vec_popcnt to vector unsigned..

Yeah this LGTM as well, accidentally commented without accepting a moment before.

Oct 7 2021, 5:01 AM · Restricted Project, Restricted Project, Restricted Project
kamaub added a comment to D110934: [NFC] Update return type of vec_popcnt to vector unsigned..
Oct 7 2021, 5:00 AM · Restricted Project, Restricted Project, Restricted Project

Oct 6 2021

kamaub requested review of D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter.
Oct 6 2021, 7:01 AM · Restricted Project

Oct 5 2021

kamaub added a comment to D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units.

Updated an existing test for the backend with pwr8 and pwr9 be/le targets during commit

Oct 5 2021, 6:02 AM · Restricted Project, Restricted Project
kamaub committed rG8737c74fab3a: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units (authored by kamaub).
[PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units
Oct 5 2021, 5:59 AM
kamaub closed D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units.
Oct 5 2021, 5:59 AM · Restricted Project, Restricted Project

Oct 4 2021

kamaub committed rG83289665200b: [PowerPC] Fix to guard fetch and cas 64-bit builtin versions (authored by kamaub).
[PowerPC] Fix to guard fetch and cas 64-bit builtin versions
Oct 4 2021, 12:46 PM
kamaub closed D110824: [PowerPC] Fix to guard fetch and cas 64-bit builtin versions.
Oct 4 2021, 12:45 PM · Restricted Project
kamaub updated the diff for D110824: [PowerPC] Fix to guard fetch and cas 64-bit builtin versions.

Moving test case to correct file before commiting as request in review comment.

Oct 4 2021, 11:32 AM · Restricted Project

Sep 30 2021

kamaub updated the diff for D110824: [PowerPC] Fix to guard fetch and cas 64-bit builtin versions.

Rebasing patch to get past intermittent test-suite failure

Sep 30 2021, 11:55 AM · Restricted Project
kamaub updated the diff for D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units.

Rebasing this patch and addressing review comments

Sep 30 2021, 11:23 AM · Restricted Project, Restricted Project
kamaub requested review of D110824: [PowerPC] Fix to guard fetch and cas 64-bit builtin versions.
Sep 30 2021, 6:27 AM · Restricted Project

Sep 21 2021

kamaub added inline comments to D109437: [PowerPC] FP compare and test XL compat builtins..
Sep 21 2021, 10:47 AM · Restricted Project, Restricted Project
kamaub added a reviewer for D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws: kamaub.

This patch seems almost ready to land to me, I'm just a bit concerned about the testing coverage,
is the little endian testing case suppose to target pwr7 as the big endian test does? The default
FileCheck line seems redundant to me, did I misunderstand?

Sep 21 2021, 7:58 AM · Restricted Project, Restricted Project, Restricted Project

Sep 10 2021

kamaub updated the diff for D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units.

The condition for failing semantic chequing on mma builtins was incorrect,
updating this patch to correctly check the semantics and associated testing.

Sep 10 2021, 10:19 AM · Restricted Project, Restricted Project
kamaub updated the summary of D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units.
Sep 10 2021, 5:18 AM · Restricted Project, Restricted Project
kamaub requested review of D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units.
Sep 10 2021, 5:14 AM · Restricted Project, Restricted Project

Sep 2 2021

kamaub accepted D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields..

This LGTM, small nit on the comment, but that can be fixed on commit

Sep 2 2021, 1:32 PM · Restricted Project

Jul 20 2021

kamaub committed rG59d2ba2a3de9: [PowerPC] Semachecking for XL compat builtin icbt (authored by quinnp).
[PowerPC] Semachecking for XL compat builtin icbt
Jul 20 2021, 9:05 AM
kamaub closed D105834: [PowerPC] Semachecking for XL compat builtin icbt.
Jul 20 2021, 9:05 AM · Restricted Project, Restricted Project
kamaub updated the summary of D105834: [PowerPC] Semachecking for XL compat builtin icbt.
Jul 20 2021, 8:53 AM · Restricted Project, Restricted Project
kamaub committed rGfd855c24c72c: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins (authored by quinnp).
[PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins
Jul 20 2021, 7:41 AM
kamaub closed D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins.
Jul 20 2021, 7:41 AM · Restricted Project

Jul 19 2021

kamaub committed rG0268e123bea5: [PowerPC] swdiv_nochk Builtins for XL Compat (authored by quinnp).
[PowerPC] swdiv_nochk Builtins for XL Compat
Jul 19 2021, 2:51 PM
kamaub closed D106150: [PowerPC] swdiv_nochk Builtins for XL Compat.
Jul 19 2021, 2:51 PM · Restricted Project

Jul 15 2021

kamaub committed rGde3956605a70: [PowerPC] Fix popcntb XL Compat Builtin for 32bit (authored by quinnp).
[PowerPC] Fix popcntb XL Compat Builtin for 32bit
Jul 15 2021, 11:20 AM
kamaub closed D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit.
Jul 15 2021, 11:20 AM · Restricted Project, Restricted Project

Jan 15 2021

kamaub requested review of D94816: [P10] [Power PC] Exploiting new load rightmost vector element instructions..
Jan 15 2021, 11:57 AM · Restricted Project

Oct 12 2020

kamaub accepted D88738: [PowerPC][PCRelative] Turn on TLS support for PCRel by default.

This LGTM

Oct 12 2020, 2:02 PM · Restricted Project

Oct 10 2020

kamaub added a project to D89195: [PowerPC][Power10] Exploit store rightmost vector element instructions.: Restricted Project.
Oct 10 2020, 11:44 AM · Restricted Project, Restricted Project
kamaub requested review of D89195: [PowerPC][Power10] Exploit store rightmost vector element instructions..
Oct 10 2020, 11:40 AM · Restricted Project, Restricted Project

Sep 1 2020

kamaub added inline comments to D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.
Sep 1 2020, 12:00 PM · Restricted Project, Restricted Project

Aug 21 2020

kamaub committed rG365f861c45bb: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec (authored by kamaub).
[PowerPC][PCRelative] Thread Local Storage Support for Initial Exec
Aug 21 2020, 8:13 AM
kamaub closed D81947: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec.
Aug 21 2020, 8:13 AM · Restricted Project, Restricted Project

Aug 20 2020

kamaub committed rGb74b80bb2d31: [PowerPC][PCRelative] Thread Local Storage Support for General Dynamic (authored by kamaub).
[PowerPC][PCRelative] Thread Local Storage Support for General Dynamic
Aug 20 2020, 1:08 PM
kamaub closed D82315: [PowerPC][PCRelative] Thread Local Storage Support for General Dynamic.
Aug 20 2020, 1:08 PM · Restricted Project, Restricted Project

Aug 14 2020

kamaub accepted D85978: [clang-tools-extra] Added missing comma.

This LGTM

Aug 14 2020, 10:54 AM · Restricted Project

Aug 10 2020

kamaub added a comment to D85545: [Diagnostics] Diagnose missing comma in string array initialization.

Hello, sorry but can you please revert this commit and recommit it when you have a fix or work around that doesn't break our bots:
It breaks http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/11228 which builds with -Werror
Please also note that it introduced 103 warnings in clang-ppc64le-linux-multistage/builds/13042

Aug 10 2020, 12:46 PM · Restricted Project

Aug 7 2020

kamaub committed rGd8c6d083c954: [PowerPC][PCRelative] Set TLS unsupported with PC relative memops (authored by kamaub).
[PowerPC][PCRelative] Set TLS unsupported with PC relative memops
Aug 7 2020, 8:57 AM
kamaub closed D85448: [PowerPC][PCRelative] Set TLS unsupported with PC relative memops.
Aug 7 2020, 8:56 AM · Restricted Project, Restricted Project
kamaub updated the diff for D81947: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec.

Rebasing and updating patch to use TLS enablement option.

Aug 7 2020, 6:39 AM · Restricted Project, Restricted Project

Aug 6 2020

kamaub updated the diff for D82315: [PowerPC][PCRelative] Thread Local Storage Support for General Dynamic.

Rebasing patch on D85448 and editing test cases to use enablement option.

Aug 6 2020, 12:09 PM · Restricted Project, Restricted Project
kamaub updated the summary of D85448: [PowerPC][PCRelative] Set TLS unsupported with PC relative memops.
Aug 6 2020, 11:21 AM · Restricted Project, Restricted Project
kamaub updated the diff for D85448: [PowerPC][PCRelative] Set TLS unsupported with PC relative memops.

Replacing assert() with report_fatal_error()

Aug 6 2020, 11:20 AM · Restricted Project, Restricted Project
kamaub added a project to D85448: [PowerPC][PCRelative] Set TLS unsupported with PC relative memops: Restricted Project.
Aug 6 2020, 10:34 AM · Restricted Project, Restricted Project
kamaub requested review of D85448: [PowerPC][PCRelative] Set TLS unsupported with PC relative memops.
Aug 6 2020, 10:32 AM · Restricted Project, Restricted Project

Aug 5 2020

kamaub updated the diff for D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.

Rebasing on most recent D81947 and addressing review comments:

  • rebasing on the updated version of D81947
  • updating test cases according to review comments
  • updating comments in code
  • updating llvm-readobj run lines to follow new interface
Aug 5 2020, 1:42 PM · Restricted Project, Restricted Project
kamaub updated the diff for D81947: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec.

Rebasing and addressing review comments:

  • rebased on the updated version of D82315
  • updated test cases according to reviews
  • updated llvm-readobj run lines in test cases to reflect interface change
Aug 5 2020, 11:08 AM · Restricted Project, Restricted Project