Page MenuHomePhabricator

kamaub (Kamau Bridgeman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 4 2019, 12:39 PM (27 w, 2 d)

Recent Activity

Mon, Nov 18

kamaub updated the diff for D62908: [PowerPC] Improve float vector gather codegen.
-Rebasing this patch to reflect the pre-commiting of the test case to master.
Mon, Nov 18, 12:30 PM · Restricted Project

Fri, Nov 15

kamaub updated the diff for D62908: [PowerPC] Improve float vector gather codegen.
  • Minor spelling change to test case.
Fri, Nov 15, 12:54 PM · Restricted Project
kamaub updated the diff for D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64.
  • Minor spelling change to test case.
Fri, Nov 15, 12:45 PM · Restricted Project
kamaub added a comment to D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64.

Fixed it, thank you.

Fri, Nov 15, 12:45 PM · Restricted Project

Thu, Nov 14

kamaub added a comment to D69730: [compiler-rt][builtins][PowerPC] Add __fixtfti builtin on PowerPC.

This LGTM, please unify the comment styles.

Thu, Nov 14, 12:16 PM · Restricted Project, Restricted Project

Wed, Nov 13

kamaub added a comment to D69168: [PowerPC] Fold redundant load immediates of zero and delete if possible.

All comments have been address, thank you.

Wed, Nov 13, 11:51 AM · Restricted Project
kamaub updated the diff for D69168: [PowerPC] Fold redundant load immediates of zero and delete if possible.
  • Changing some condition and fixing test cases.

This change edits some conditions to be more robust in their logic.
Of note is the change to clean up load immediates even if they weren't
folded, a side-effect of this is that one test case needs to fixed up.

Wed, Nov 13, 11:50 AM · Restricted Project

Nov 11 2019

kamaub added a comment to D69168: [PowerPC] Fold redundant load immediates of zero and delete if possible.

Thank you, comments were addressing in most recent commit.

Nov 11 2019, 11:26 AM · Restricted Project
kamaub updated the diff for D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64.
  • Updating test case to be less restrictive.
Nov 11 2019, 8:58 AM · Restricted Project

Oct 29 2019

kamaub updated the diff for D69168: [PowerPC] Fold redundant load immediates of zero and delete if possible.
  • Refractoring this patch to removed duplicated function
Oct 29 2019, 7:39 AM · Restricted Project

Oct 25 2019

kamaub updated the diff for D69108: [PowerPC] Clang Option for enabling absolute jumptables with command line.
  • Minor spelling correction to test case comment
Oct 25 2019, 12:56 PM · Restricted Project
kamaub added a comment to D69108: [PowerPC] Clang Option for enabling absolute jumptables with command line.

Thank you, comment addressed.

Oct 25 2019, 12:56 PM · Restricted Project
kamaub added a comment to D62908: [PowerPC] Improve float vector gather codegen.

LGTM. It would be better to pre-commit the testcase and rebase, so that the diff show only the change due to this patch.

Oct 25 2019, 12:29 PM · Restricted Project
kamaub added a comment to D62908: [PowerPC] Improve float vector gather codegen.

Thank you, comment addressed.

Oct 25 2019, 12:29 PM · Restricted Project
kamaub updated the diff for D62908: [PowerPC] Improve float vector gather codegen.
  • Minor spelling correction to test case comment
Oct 25 2019, 12:29 PM · Restricted Project
kamaub added a child revision for D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64: D62908: [PowerPC] Improve float vector gather codegen.
Oct 25 2019, 12:29 PM · Restricted Project
kamaub added a parent revision for D62908: [PowerPC] Improve float vector gather codegen: D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64.
Oct 25 2019, 12:29 PM · Restricted Project
kamaub added a reviewer for D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64: Restricted Project.
Oct 25 2019, 12:29 PM · Restricted Project
kamaub created D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64.
Oct 25 2019, 12:20 PM · Restricted Project

Oct 21 2019

kamaub added a comment to D68443: [PowerPC] Spill CR LT bits on P9 using setb.

Looks good to me, just a note about the summary:

Oct 21 2019, 10:46 AM · Restricted Project

Oct 18 2019

kamaub added a comment to D69108: [PowerPC] Clang Option for enabling absolute jumptables with command line.

Thank you for your comments, I have addressed them.

Oct 18 2019, 8:00 AM · Restricted Project
kamaub updated the diff for D69108: [PowerPC] Clang Option for enabling absolute jumptables with command line.
Oct 18 2019, 8:00 AM · Restricted Project
kamaub updated the diff for D69108: [PowerPC] Clang Option for enabling absolute jumptables with command line.
Minor formatting changes to the test case.
Oct 18 2019, 8:00 AM · Restricted Project
kamaub added a comment to D62908: [PowerPC] Improve float vector gather codegen.

Thank you all for your comments, I address them.

Oct 18 2019, 7:42 AM · Restricted Project
kamaub created D69168: [PowerPC] Fold redundant load immediates of zero and delete if possible.
Oct 18 2019, 7:32 AM · Restricted Project

Oct 17 2019

kamaub updated the diff for D62908: [PowerPC] Improve float vector gather codegen.

Updating the patch to improve float vector gather codegen

Oct 17 2019, 6:52 AM · Restricted Project
kamaub created D69108: [PowerPC] Clang Option for enabling absolute jumptables with command line.
Oct 17 2019, 6:31 AM · Restricted Project

Sep 17 2019

kamaub added reviewers for D66902: [PowerPC] Implementing overflow version for XO-Form instructions: adalava, echristo.
Sep 17 2019, 8:53 AM · Restricted Project
kamaub removed a reviewer for D62908: [PowerPC] Improve float vector gather codegen: adalava.
Sep 17 2019, 8:52 AM · Restricted Project
kamaub added a reviewer for D62908: [PowerPC] Improve float vector gather codegen: adalava.
Sep 17 2019, 8:52 AM · Restricted Project
kamaub added a reviewer for D66902: [PowerPC] Implementing overflow version for XO-Form instructions: hfinkel.
Sep 17 2019, 8:43 AM · Restricted Project
kamaub updated the diff for D66902: [PowerPC] Implementing overflow version for XO-Form instructions.

Fixed the spacing issues with the mutliclass comments and in the test cases as requested @amyk

Sep 17 2019, 7:19 AM · Restricted Project

Aug 29 2019

kamaub abandoned D66946: [Test] Testing Arcanist with this commit of a temporary file..
Aug 29 2019, 12:33 PM · Restricted Project
kamaub created D66946: [Test] Testing Arcanist with this commit of a temporary file..
Aug 29 2019, 7:53 AM · Restricted Project

Aug 28 2019

kamaub added reviewers for D66902: [PowerPC] Implementing overflow version for XO-Form instructions: nemanjai, stefanp, lei, kbarton.
Aug 28 2019, 1:11 PM · Restricted Project
kamaub updated the diff for D66902: [PowerPC] Implementing overflow version for XO-Form instructions.

Adding reviewers as part of the testing for arcanist

Aug 28 2019, 1:07 PM · Restricted Project
kamaub created D66902: [PowerPC] Implementing overflow version for XO-Form instructions.
Aug 28 2019, 1:04 PM · Restricted Project
kamaub abandoned D66891: [PowerPC] Implementing overflow version for XO-Form instructions.
Aug 28 2019, 11:51 AM · Restricted Project
kamaub created D66891: [PowerPC] Implementing overflow version for XO-Form instructions.
Aug 28 2019, 9:29 AM · Restricted Project

Jul 15 2019

kamaub added a comment to D64221: [zorg] Use https for svn-test-suite stage of buildbot.

Hi @gkistanova I don't have commit permissions for zorg, would you be able to commit it for me?

Jul 15 2019, 11:52 AM · Restricted Project, Restricted Project

Jul 11 2019

kamaub updated the diff for D64221: [zorg] Use https for svn-test-suite stage of buildbot.

So I made the change as recommend, thank you very much for all your help.

Jul 11 2019, 1:53 PM · Restricted Project, Restricted Project
kamaub added a comment to D64221: [zorg] Use https for svn-test-suite stage of buildbot.

Instead, please specify vcs_protocol property for your bots to be https. This would make your bots check the source code over HTTPS.

Jul 11 2019, 9:36 AM · Restricted Project, Restricted Project

Jul 4 2019

kamaub created D64221: [zorg] Use https for svn-test-suite stage of buildbot.
Jul 4 2019, 1:11 PM · Restricted Project, Restricted Project

Jul 3 2019

kamaub added a comment to rL364927: AMDGPU/GlobalISel: Select G_FENCE.

Hello, this commit has files affecting the tests which have been failing for the ppc64le-lld-multistage-test buildbot for 24 hours now, could you please investigate and correct this issue.

Jul 3 2019, 11:34 AM
kamaub added a comment to rL364926: GlobalISel: Add G_FENCE.

Hello, this commit has files affecting the tests which have been failing for the ppc64le-lld-multistage-test buildbot for 24 hours now, could you please investigate and correct this issue.

Jul 3 2019, 11:34 AM

Jun 6 2019

kamaub updated the summary of D62908: [PowerPC] Improve float vector gather codegen.
Jun 6 2019, 12:28 PM · Restricted Project

Jun 5 2019

kamaub created D62908: [PowerPC] Improve float vector gather codegen.
Jun 5 2019, 7:58 AM · Restricted Project