Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

kamaub (Kamau Bridgeman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 4 2019, 12:39 PM (224 w, 2 d)

Recent Activity

Jul 14 2023

kamaub committed rG62c1cf7c63f0: [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc (authored by kamaub).
[PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc
Jul 14 2023, 11:39 AM · Restricted Project, Restricted Project
kamaub closed D153034: [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc.
Jul 14 2023, 11:38 AM · Restricted Project, Restricted Project
kamaub committed rG4c1e36fa642f: [PowerPC] Add DFP test instruction definitions and MC tests (authored by kamaub).
[PowerPC] Add DFP test instruction definitions and MC tests
Jul 14 2023, 11:01 AM · Restricted Project, Restricted Project
kamaub closed D154606: [PowerPC] Add DFP test instruction definitions and MC tests.
Jul 14 2023, 11:00 AM · Restricted Project, Restricted Project

Jul 13 2023

kamaub accepted D154465: [PowerPC] Add DFP format instructions definitions and MC tests.

This looks good to me, just some request that can be done pre-commit

Jul 13 2023, 9:54 AM · Restricted Project, Restricted Project

Jul 7 2023

kamaub updated the diff for D154606: [PowerPC] Add DFP test instruction definitions and MC tests.

Removing the "mayRaiseFPException" predicate as it does not apply to these instructions.

Jul 7 2023, 9:41 AM · Restricted Project, Restricted Project

Jul 6 2023

kamaub requested review of D154606: [PowerPC] Add DFP test instruction definitions and MC tests.
Jul 6 2023, 6:59 AM · Restricted Project, Restricted Project

Jun 30 2023

kamaub updated the diff for D153034: [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc.

Addressing a review comment.

Jun 30 2023, 3:45 PM · Restricted Project, Restricted Project
kamaub added inline comments to D153034: [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc.
Jun 30 2023, 2:29 PM · Restricted Project, Restricted Project

Jun 26 2023

kamaub accepted D153645: [PowerPC][TLS] Add additional TLS X-Form loads/store instructions.

This LGTM, thank you.

Jun 26 2023, 1:50 PM · Restricted Project, Restricted Project

Jun 23 2023

kamaub updated the summary of D153034: [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc.
Jun 23 2023, 10:27 AM · Restricted Project, Restricted Project
kamaub updated the diff for D153034: [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc.

Addressing review comments.

Jun 23 2023, 10:26 AM · Restricted Project, Restricted Project
kamaub updated the summary of D153034: [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc.
Jun 23 2023, 6:44 AM · Restricted Project, Restricted Project
kamaub retitled D153034: [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc from [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc on future isa to [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc.
Jun 23 2023, 6:44 AM · Restricted Project, Restricted Project
kamaub updated the diff for D153034: [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc.

Addressing review comments.

Jun 23 2023, 6:44 AM · Restricted Project, Restricted Project

Jun 16 2023

kamaub updated the diff for D153034: [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc.

Spelling mistake

Jun 16 2023, 11:19 AM · Restricted Project, Restricted Project
kamaub retitled D153034: [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc from [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc on PFuture to [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc on future isa.
Jun 16 2023, 11:09 AM · Restricted Project, Restricted Project
kamaub updated the diff for D153034: [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc.

Updating wording.

Jun 16 2023, 11:04 AM · Restricted Project, Restricted Project

Jun 15 2023

kamaub requested review of D153034: [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc.
Jun 15 2023, 7:58 AM · Restricted Project, Restricted Project

Jun 14 2023

kamaub added a comment to D152669: [AIX][TLS] Generate 32-bit local-exec access code sequence.

First review, I'll try to comeback again soon.

Jun 14 2023, 10:19 AM · Restricted Project, Restricted Project, Restricted Project

Jun 2 2023

kamaub added a comment to D149722: [AIX][TLS] Generate 64-bit local-exec access code sequence.

Thank you for this patch, just some review comments.

Jun 2 2023, 7:46 AM · Restricted Project, Restricted Project

May 31 2023

kamaub committed rZORG9f633a04ed1f: Adding a clobber test suite step to the TestSuiteBuilder (authored by kamaub).
Adding a clobber test suite step to the TestSuiteBuilder
May 31 2023, 1:19 PM · Restricted Project
kamaub closed D151656: Adding a clobber test suite step to the TestSuiteBuilder.
May 31 2023, 1:19 PM · Restricted Project

May 29 2023

kamaub added reviewers for D151656: Adding a clobber test suite step to the TestSuiteBuilder: amyk, nemanjai, lei, Restricted Project.
May 29 2023, 11:11 AM · Restricted Project
kamaub requested review of D151656: Adding a clobber test suite step to the TestSuiteBuilder.
May 29 2023, 11:10 AM · Restricted Project

Apr 27 2023

kamaub accepted D143467: [PowerPC] Add target feature requirement to builtins.

Hello, sorry for missing you ping and delaying the patch so long just for test case adjustments, thank you for addressing them.
Everything LGTM but lei and I had one request that can be made before you commit:

Apr 27 2023, 12:41 PM · Restricted Project, Restricted Project

Apr 11 2023

kamaub requested changes to D143467: [PowerPC] Add target feature requirement to builtins.

Sorry I should have requested changes before for this comment below, but I do want these test moved to codegen and expanded, please let me know if anything is unclear.

Can you add a PowerPC codegen test case for __attribute__((target(? All of the updated test cases seem to only test -target-feature.
The only test case we have for __attribute((target( is a sema test ./clang/test/Sema/ppc-attr-target-inline.c.

Converting the deleted clang/test/Sema/ppc-mma-builtins.c and clang/test/Sema/ppc-paired-vector-builtins.c to a codegen test cases
like clang/test/CodeGen/PowerPC/builtins-ppc-htm.c using FileCheck seems like a nice solution since it would reintroduce the testing
for +paired-vector-memops,-mma situations, as well as a for __attribute__((target("no-mma")))

Apr 11 2023, 8:59 AM · Restricted Project, Restricted Project

Apr 3 2023

kamaub added a reviewer for D143467: [PowerPC] Add target feature requirement to builtins: kamaub.
Apr 3 2023, 3:01 PM · Restricted Project, Restricted Project
kamaub added a comment to D143467: [PowerPC] Add target feature requirement to builtins.

Can you add a PowerPC codegen test case for __attribute__((target(? All of the updated test cases seem to only test -target-feature.
The only test case we have for __attribute((target( is a sema test ./clang/test/Sema/ppc-attr-target-inline.c.

Apr 3 2023, 3:01 PM · Restricted Project, Restricted Project

Feb 28 2023

kamaub requested changes to D130487: [PowerPC] Fix vector_shuffle combines when inputs are scalar_to_vector of differing types..

Request changes because of the bug in the isShuffleMaskInRange() conditions

Feb 28 2023, 9:49 AM · Restricted Project, Restricted Project, Restricted Project

Feb 27 2023

kamaub added inline comments to D130487: [PowerPC] Fix vector_shuffle combines when inputs are scalar_to_vector of differing types..
Feb 27 2023, 10:27 AM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2023

kamaub added a comment to D143210: [PowerPC] Include vector bool and pixel when emitting lax warning.

We may also need an associated test case for the changed behaviour for using areCompatibleVectorTypes() instead of areSameVectorElemTypes().
The test coverage should display when warnings are emitted now that we account for vector bool, vector pixel and type qualifiers.

Feb 22 2023, 8:50 AM · Restricted Project, Restricted Project

Feb 15 2023

kamaub added a reviewer for D143210: [PowerPC] Include vector bool and pixel when emitting lax warning: Restricted Project.
Feb 15 2023, 8:21 AM · Restricted Project, Restricted Project

Feb 14 2023

kamaub added inline comments to D133103: [PowerPC] Improve kill flag computation and add verification after MI peephole.
Feb 14 2023, 7:33 AM · Restricted Project, Restricted Project

Jan 30 2023

kamaub added inline comments to D133103: [PowerPC] Improve kill flag computation and add verification after MI peephole.
Jan 30 2023, 12:32 AM · Restricted Project, Restricted Project

Jan 26 2023

kamaub added a comment to D133103: [PowerPC] Improve kill flag computation and add verification after MI peephole.

Some comments from the llvm-on-power team:

Jan 26 2023, 11:01 AM · Restricted Project, Restricted Project

Nov 30 2022

kamaub closed D139007: [TestSuiteBuilder] Updating the build config of the PPC Rhel bot.
Nov 30 2022, 12:46 PM · Restricted Project
kamaub committed rZORGefdae9a8f17f: [TestSuiteBuilder] Updating the build config of the PPC Rhel bot (authored by kamaub).
[TestSuiteBuilder] Updating the build config of the PPC Rhel bot
Nov 30 2022, 12:46 PM · Restricted Project
kamaub updated the summary of D139007: [TestSuiteBuilder] Updating the build config of the PPC Rhel bot.
Nov 30 2022, 11:41 AM · Restricted Project
kamaub requested review of D139007: [TestSuiteBuilder] Updating the build config of the PPC Rhel bot.
Nov 30 2022, 5:16 AM · Restricted Project

Nov 29 2022

kamaub committed rZORG1978f3e8989c: [sanitizers] Controlling the build width and targets for PowerPC sanitizers (authored by kamaub).
[sanitizers] Controlling the build width and targets for PowerPC sanitizers
Nov 29 2022, 6:12 AM · Restricted Project
kamaub closed D135806: [sanitizers] Controlling the build width and targets for PowerPC sanitizers.
Nov 29 2022, 6:12 AM · Restricted Project

Nov 7 2022

kamaub added a comment to D135806: [sanitizers] Controlling the build width and targets for PowerPC sanitizers.

Thank you for the review, I have removed the necessary quotations.

Nov 7 2022, 11:18 AM · Restricted Project
kamaub updated the diff for D135806: [sanitizers] Controlling the build width and targets for PowerPC sanitizers.

Addressing review comments

Nov 7 2022, 11:17 AM · Restricted Project

Oct 31 2022

kamaub added a comment to D135806: [sanitizers] Controlling the build width and targets for PowerPC sanitizers.

ping

Oct 31 2022, 5:49 AM · Restricted Project

Oct 18 2022

kamaub updated the diff for D135806: [sanitizers] Controlling the build width and targets for PowerPC sanitizers.

Addressing review comments

Oct 18 2022, 6:07 AM · Restricted Project

Oct 14 2022

kamaub added a comment to D135945: [scudo] Fix implicitly narrow casting (NFC).

https://lab.llvm.org/buildbot/#/builders/230/builds/4037/steps/7/logs/stdio Here is a example log, I will try to get a backtrace for you.

Oct 14 2022, 1:19 PM · Restricted Project, Restricted Project
kamaub added a comment to D135945: [scudo] Fix implicitly narrow casting (NFC).

Sorry, I didn’t see your message in time and I reverted. Please let me know if we can help by providing access to a machine where you can test any potential fixes so that you can re-commit.

Oct 14 2022, 1:17 PM · Restricted Project, Restricted Project
kamaub committed rGc929bcb7d857: Revert "[scudo] Manage free blocks in BatchGroup." (authored by kamaub).
Revert "[scudo] Manage free blocks in BatchGroup."
Oct 14 2022, 1:12 PM · Restricted Project, Restricted Project
kamaub added a reverting change for rGcf9d7f55d3be: [scudo] Manage free blocks in BatchGroup.: rGc929bcb7d857: Revert "[scudo] Manage free blocks in BatchGroup.".
Oct 14 2022, 1:12 PM · Restricted Project, Restricted Project
kamaub added a reverting change for rG9c26f51f5e17: [scudo] Support partial page releasing: rG1cf1b36112b3: Revert "[scudo] Support partial page releasing".
Oct 14 2022, 1:12 PM · Restricted Project, Restricted Project
kamaub committed rG1cf1b36112b3: Revert "[scudo] Support partial page releasing" (authored by kamaub).
Revert "[scudo] Support partial page releasing"
Oct 14 2022, 1:12 PM · Restricted Project, Restricted Project
kamaub added a reverting change for D133897: [scudo] Manage free blocks in BatchGroup.: rGc929bcb7d857: Revert "[scudo] Manage free blocks in BatchGroup.".
Oct 14 2022, 1:12 PM · Restricted Project, Restricted Project
kamaub added a reverting change for rGfd7c7ad4fe01: [scudo] Fix implicitly narrow casting (NFC): rG5fe6f3e0bc05: Revert "[scudo] Fix implicitly narrow casting (NFC)".
Oct 14 2022, 1:12 PM · Restricted Project, Restricted Project
kamaub added a reverting change for D134226: [scudo] Support partial page releasing: rG1cf1b36112b3: Revert "[scudo] Support partial page releasing".
Oct 14 2022, 1:12 PM · Restricted Project, Restricted Project
kamaub committed rG5fe6f3e0bc05: Revert "[scudo] Fix implicitly narrow casting (NFC)" (authored by kamaub).
Revert "[scudo] Fix implicitly narrow casting (NFC)"
Oct 14 2022, 1:12 PM · Restricted Project, Restricted Project
kamaub added a reverting change for D135945: [scudo] Fix implicitly narrow casting (NFC): rG5fe6f3e0bc05: Revert "[scudo] Fix implicitly narrow casting (NFC)".
Oct 14 2022, 1:12 PM · Restricted Project, Restricted Project
kamaub added a comment to D135945: [scudo] Fix implicitly narrow casting (NFC).

Please hold off on commit anymore patches until the test breaks identified by my colleague in https://reviews.llvm.org/D134226#3858268 are resolved.
Several scudo test are intermittently failing on multiple powerpc bots https://lab.llvm.org/buildbot/#/builders?tags=%2Bppc
I am able to reproduce the failure on a ppc machines with a stress test:

 ~/llvm/mono/bot_reprod $ cat ~/stress-scudo.sh
RC=0
while [[ $RC == 0 ]]; do
  ninja check-runtimes >> stress-scudo.log
  RC=$?
done

which fails on the 1st, 2nd or 3rd loops (hence the flaky behaviour on the bots)
and I was able to confirm that by applying these reverts the flaky behaviour of ./ScudoUnitTest-powerpc64le-Test/163/220 and ./ScudoUnitTest-powerpc64le-Test/ScudoPrimaryTestMemoryGroup_TestConfig3/MemoryGroup disappear

~/llvm/mono/llvm-project $ git revert fd7c7ad4fe0138314b922ea0db1691d5a679cc75
[main 77190d04d010] Revert "[scudo] Fix implicitly narrow casting (NFC)"
 3 files changed, 5 insertions(+), 10 deletions(-)
~/llvm/mono/llvm-project $ git revert 9c26f51f5e178ac0fda98419e3a61d205d3b58b1
[main d982b881645e] Revert "[scudo] Support partial page releasing"
 4 files changed, 19 insertions(+), 91 deletions(-)
~/llvm/mono/llvm-project $ git revert cf9d7f55d3bec7640fa8b2f8ec1d9c1268233caa
[main 556f28478a6c] Revert "[scudo] Manage free blocks in BatchGroup."
 8 files changed, 67 insertions(+), 635 deletions(-)

The flaky tests still fail after reverting 9c26f51f5e178ac0fda98419e3a61d205d3b58b1 so cf9d7f55d3bec7640fa8b2f8ec1d9c1268233caa is likely the culprit but I will have to revert all three patches since they are dependent on each other in a chain i.e I must revert fd7c7ad4fe0138314b922ea0db1691d5a679cc75 in order to revert 9c26f51f5e178ac0fda98419e3a61d205d3b58b1 in order to revert cf9d7f55d3bec7640fa8b2f8ec1d9c1268233caa

Oct 14 2022, 1:05 PM · Restricted Project, Restricted Project
kamaub added inline comments to D135806: [sanitizers] Controlling the build width and targets for PowerPC sanitizers.
Oct 14 2022, 11:33 AM · Restricted Project
kamaub added a comment to D135806: [sanitizers] Controlling the build width and targets for PowerPC sanitizers.

Thank you for the review, I am testing these changes at the moment, will post the update afterwards.

Oct 14 2022, 11:32 AM · Restricted Project

Oct 12 2022

kamaub requested review of D135806: [sanitizers] Controlling the build width and targets for PowerPC sanitizers.
Oct 12 2022, 12:27 PM · Restricted Project

Oct 7 2022

kamaub added a comment to D135245: [clang][Tooling] Move STL recognizer to its own library.

This change causes a linking failure during the check-all testing of 'clang-tools-extra' on the clang-ppc64le-rhel #22596 and clang-ppc64le-linux-multistage #23864 build bots, please address this failure as soon as possible.

Oct 7 2022, 10:46 AM · Restricted Project, Restricted Project, Restricted Project

Oct 4 2022

kamaub added inline comments to D133940: Change PowerPC64 bots to build runtimes with -DLLVM_ENABLE_RUNTIMES.
Oct 4 2022, 7:28 AM · Restricted Project
kamaub committed rZORGc20e90d326ee: Change PowerPC64 bots to build runtimes with -DLLVM_ENABLE_RUNTIMES (authored by kamaub).
Change PowerPC64 bots to build runtimes with -DLLVM_ENABLE_RUNTIMES
Oct 4 2022, 7:26 AM · Restricted Project
kamaub closed D133940: Change PowerPC64 bots to build runtimes with -DLLVM_ENABLE_RUNTIMES.
Oct 4 2022, 7:26 AM · Restricted Project

Sep 19 2022

kamaub added a comment to D133940: Change PowerPC64 bots to build runtimes with -DLLVM_ENABLE_RUNTIMES.

Thanks for the review! :)

Sep 19 2022, 7:28 AM · Restricted Project

Sep 15 2022

kamaub requested review of D133940: Change PowerPC64 bots to build runtimes with -DLLVM_ENABLE_RUNTIMES.
Sep 15 2022, 6:28 AM · Restricted Project

Jul 26 2022

kamaub added a comment to D121276: [CMake] Include runtimes test suites in check-all.

@phosek Pinging this patch, our builders which run check-all and expect compiler-rt, enabled as a runtime with -DLLVM_ENABLE_RUNTIMES=compiler-rt, to be covered in testing are not doing this and are still being affected by this changeset.
clang-ppc64le-rhel and clang-ppc64-aix are not currently testing compiler-rt because of this change.
clang-ppc64le-linux-test-suite enables compiler-rt as a project with -DLLVM_ENABLE_PROJECTS=compiler-rt and test it under check-all as expected.
Before this, both bots would test compiler-rt under check-all. Could you please take a look at this?

Jul 26 2022, 10:35 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 19 2022

kamaub committed rG2a408f200cb5: [TSAN] Disable clone_setns test case on PPC64 RHEL 7.9 Targets (authored by kamaub).
[TSAN] Disable clone_setns test case on PPC64 RHEL 7.9 Targets
Jul 19 2022, 11:25 AM · Restricted Project, Restricted Project
kamaub closed D130086: [TSAN] Disable clone_setns test case on PPC64 RHEL 7.9 Targets.
Jul 19 2022, 11:25 AM · Restricted Project, Restricted Project
kamaub updated the summary of D130086: [TSAN] Disable clone_setns test case on PPC64 RHEL 7.9 Targets.
Jul 19 2022, 7:26 AM · Restricted Project, Restricted Project
kamaub requested review of D130086: [TSAN] Disable clone_setns test case on PPC64 RHEL 7.9 Targets.
Jul 19 2022, 7:02 AM · Restricted Project, Restricted Project

Jul 6 2022

kamaub committed rZORGf56b269c5ce2: Changing the ppc64[be|le] bots to TestSuiteBuilders (authored by kamaub).
Changing the ppc64[be|le] bots to TestSuiteBuilders
Jul 6 2022, 6:20 AM · Restricted Project
kamaub closed D128273: Changing the ppc64[be|le] bots to TestSuiteBuilders.
Jul 6 2022, 6:20 AM · Restricted Project

Jul 5 2022

kamaub added a comment to D128273: Changing the ppc64[be|le] bots to TestSuiteBuilders.

Thank you!

Jul 5 2022, 1:35 PM · Restricted Project

Jun 30 2022

kamaub added inline comments to D128273: Changing the ppc64[be|le] bots to TestSuiteBuilders.
Jun 30 2022, 9:35 AM · Restricted Project

Jun 29 2022

kamaub updated the diff for D128273: Changing the ppc64[be|le] bots to TestSuiteBuilders.

This update removes the edits made to the TestSuiteBuilder, as they are not
critical to the PR, we will not be moving away from the UnifiedTreeBuilder
as a base for the TestSuiteBuilder.

Jun 29 2022, 7:27 AM · Restricted Project

Jun 23 2022

kamaub planned changes to D128273: Changing the ppc64[be|le] bots to TestSuiteBuilders.

Planning to move away from the UnifiedTreeBuilder for our TestSuiteBuilder

Jun 23 2022, 1:38 PM · Restricted Project
kamaub updated the summary of D128273: Changing the ppc64[be|le] bots to TestSuiteBuilders.
Jun 23 2022, 12:50 PM · Restricted Project

Jun 21 2022

kamaub committed rZORGd995ac76d743: Changing number max number of build for ppc64le-flang-mlir-rhel-test (authored by kamaub).
Changing number max number of build for ppc64le-flang-mlir-rhel-test
Jun 21 2022, 1:14 PM · Restricted Project
kamaub closed D123060: Changing number max number of build for ppc64le-flang-mlir-rhel-test.
Jun 21 2022, 1:14 PM · Restricted Project
kamaub requested review of D128273: Changing the ppc64[be|le] bots to TestSuiteBuilders.
Jun 21 2022, 6:41 AM · Restricted Project

Jun 8 2022

kamaub added a comment to D125499: Enabling the detection of devtoolset-11 toolchain..

I'm curious what is your system configuration where this patch actually allows for detection of devtoolset? I noticed that if clang and gcc are both installed to /usr/, then driver will pick the gcc in /usr/ over the one in /opt/rh/.../

Jun 8 2022, 12:30 PM · Restricted Project, Restricted Project

May 19 2022

kamaub committed rZORG0f1b47ed6bf1: Enabling ccache for all ppc64 buildbots (authored by kamaub).
Enabling ccache for all ppc64 buildbots
May 19 2022, 6:43 AM · Restricted Project
kamaub closed D125890: Enabling ccache for all ppc64 buildbots.
May 19 2022, 6:43 AM · Restricted Project

May 18 2022

kamaub requested review of D125890: Enabling ccache for all ppc64 buildbots.
May 18 2022, 7:36 AM · Restricted Project

May 17 2022

kamaub committed rG99639e5a3e6e: Enabling the detection of devtoolset-11 toolchain. (authored by kamaub).
Enabling the detection of devtoolset-11 toolchain.
May 17 2022, 5:58 AM · Restricted Project, Restricted Project
kamaub closed D125499: Enabling the detection of devtoolset-11 toolchain..
May 17 2022, 5:57 AM · Restricted Project, Restricted Project

May 12 2022

kamaub requested review of D125499: Enabling the detection of devtoolset-11 toolchain..
May 12 2022, 1:18 PM · Restricted Project, Restricted Project

Apr 18 2022

kamaub added a comment to D123060: Changing number max number of build for ppc64le-flang-mlir-rhel-test.

Depending on the build requests queues any combination of 2 concurrent builds is possible. Yes, it is possible to have 2 ppc64le-flang-rhel-clang builds running and ppc64le-mlir-rhel-clang builds waiting.

Apr 18 2022, 11:34 AM · Restricted Project
kamaub updated the diff for D123060: Changing number max number of build for ppc64le-flang-mlir-rhel-test.

Creating separate workers for the flang and mlir ppc64le builders to remove any
dependency on build request order between the two bots as was pointed out in a
previous review.

Apr 18 2022, 11:31 AM · Restricted Project

Apr 12 2022

kamaub added a comment to D123060: Changing number max number of build for ppc64le-flang-mlir-rhel-test.

Hello Kamau,

ppc64le-flang-rhel-clang seems using a lot of resources. It takes up to 15 minutes to build when it uses the computer exclusively.

What is the expected build time when 2 ppc64le-flang-rhel-clang builds will be running simultaneously on the same computer?

Apr 12 2022, 7:53 AM · Restricted Project

Apr 7 2022

kamaub committed rZORGd5a468e601db: Enabling ccache for all ppc64le buildbots (authored by kamaub).
Enabling ccache for all ppc64le buildbots
Apr 7 2022, 1:28 PM · Restricted Project
kamaub closed D119757: Enabling ccache for all ppc64le buildbots.
Apr 7 2022, 1:28 PM · Restricted Project

Apr 4 2022

kamaub requested review of D123060: Changing number max number of build for ppc64le-flang-mlir-rhel-test.
Apr 4 2022, 12:08 PM · Restricted Project

Mar 25 2022

kamaub added a comment to D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators .

I'm sorry I took so long to notify you but I need to bring these bots back to green as soon as possible, they have been broken too long.

Mar 25 2022, 7:57 AM · Restricted Project, Restricted Project
kamaub added a comment to D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators .

This option appears to incorrectly warn warning that unsigned NumEntries = getNumEntries(); is "set but not used" in llvm/include/llvm/ADT/DenseMap.h:129 and so it is breaking the ppc64le-lld-multistage-test bot.
This could be because the only use is in an assert which is in a corner case maybe?

Mar 25 2022, 7:55 AM · Restricted Project, Restricted Project

Mar 18 2022

kamaub added a comment to D121654: [RISCV] Ensure PseudoLA* can be hoisted.

Does:

diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
index f52965dab759..299c68da7c2f 100644
--- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
+++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -3769,6 +3769,15 @@ SDValue RISCVTargetLowering::getAddr(NodeTy *N, SelectionDAG &DAG,
   }
 }
 
+template SDValue RISCVTargetLowering::getAddr<GlobalAddressSDNode>(
+    GlobalAddressSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+template SDValue RISCVTargetLowering::getAddr<BlockAddressSDNode>(
+    BlockAddressSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+template SDValue RISCVTargetLowering::getAddr<ConstantPoolSDNode>(
+    ConstantPoolSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+template SDValue RISCVTargetLowering::getAddr<JumpTableSDNode>(
+    JumpTableSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+
 SDValue RISCVTargetLowering::lowerGlobalAddress(SDValue Op,
                                                 SelectionDAG &DAG) const {
   SDLoc DL(Op);

fix the error for you?

I'd be happy to review and approve a patch with this change but I think the fastest resolution to getting the bot back to green would be to revert and then recommit with this change added. The bot has been broken for over 24 hours so we would like to get it back online as soon as possible, thank you for your quick response. :)

I've just committed the fix as 63ea7797dd5bb77cc7b2904e20a5b779d30d4f2d; strange how this exposes it but it's been lurking ready to break since 41454ab25645 / D114950.

Mar 18 2022, 7:39 AM · Restricted Project, Restricted Project
kamaub added a comment to D121837: [OpenMP][FIX] Allow device constructors for AMD GPU.

The test cases added with this commit failed on clang-ppc64be-linux-lnt # 13809 could you please revert this change, and recommit with the test case corrected? thank you.

Mar 18 2022, 7:25 AM · Restricted Project, Restricted Project

Mar 17 2022

kamaub added a comment to D121654: [RISCV] Ensure PseudoLA* can be hoisted.

Does:

diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
index f52965dab759..299c68da7c2f 100644
--- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
+++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -3769,6 +3769,15 @@ SDValue RISCVTargetLowering::getAddr(NodeTy *N, SelectionDAG &DAG,
   }
 }
 
+template SDValue RISCVTargetLowering::getAddr<GlobalAddressSDNode>(
+    GlobalAddressSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+template SDValue RISCVTargetLowering::getAddr<BlockAddressSDNode>(
+    BlockAddressSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+template SDValue RISCVTargetLowering::getAddr<ConstantPoolSDNode>(
+    ConstantPoolSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+template SDValue RISCVTargetLowering::getAddr<JumpTableSDNode>(
+    JumpTableSDNode *N, SelectionDAG &DAG, bool IsLocal) const;
+
 SDValue RISCVTargetLowering::lowerGlobalAddress(SDValue Op,
                                                 SelectionDAG &DAG) const {
   SDLoc DL(Op);

fix the error for you?

Mar 17 2022, 6:36 PM · Restricted Project, Restricted Project