- User Since
- Jun 4 2019, 12:39 PM (224 w, 2 d)
Jul 14 2023
Jul 13 2023
This looks good to me, just some request that can be done pre-commit
Jul 7 2023
Removing the "mayRaiseFPException" predicate as it does not apply to these instructions.
Jul 6 2023
Jun 30 2023
Addressing a review comment.
Jun 26 2023
This LGTM, thank you.
Jun 23 2023
Addressing review comments.
Addressing review comments.
Jun 16 2023
Jun 15 2023
Jun 14 2023
First review, I'll try to comeback again soon.
Jun 2 2023
Thank you for this patch, just some review comments.
May 31 2023
May 29 2023
Apr 27 2023
Hello, sorry for missing you ping and delaying the patch so long just for test case adjustments, thank you for addressing them.
Everything LGTM but lei and I had one request that can be made before you commit:
Apr 11 2023
Sorry I should have requested changes before for this comment below, but I do want these test moved to codegen and expanded, please let me know if anything is unclear.
Apr 3 2023
Can you add a PowerPC codegen test case for __attribute__((target(? All of the updated test cases seem to only test -target-feature.
The only test case we have for __attribute((target( is a sema test ./clang/test/Sema/ppc-attr-target-inline.c.
Feb 28 2023
Request changes because of the bug in the isShuffleMaskInRange() conditions
Feb 27 2023
Feb 22 2023
We may also need an associated test case for the changed behaviour for using areCompatibleVectorTypes() instead of areSameVectorElemTypes().
The test coverage should display when warnings are emitted now that we account for vector bool, vector pixel and type qualifiers.
Feb 15 2023
Feb 14 2023
Jan 30 2023
Jan 26 2023
Some comments from the llvm-on-power team:
Nov 30 2022
Nov 29 2022
Nov 7 2022
Thank you for the review, I have removed the necessary quotations.
Addressing review comments
Oct 31 2022
Oct 18 2022
Addressing review comments
Oct 14 2022
https://lab.llvm.org/buildbot/#/builders/230/builds/4037/steps/7/logs/stdio Here is a example log, I will try to get a backtrace for you.
Sorry, I didn’t see your message in time and I reverted. Please let me know if we can help by providing access to a machine where you can test any potential fixes so that you can re-commit.
Please hold off on commit anymore patches until the test breaks identified by my colleague in https://reviews.llvm.org/D134226#3858268 are resolved.
Several scudo test are intermittently failing on multiple powerpc bots https://lab.llvm.org/buildbot/#/builders?tags=%2Bppc
I am able to reproduce the failure on a ppc machines with a stress test:
~/llvm/mono/bot_reprod $ cat ~/stress-scudo.sh RC=0 while [[ $RC == 0 ]]; do ninja check-runtimes >> stress-scudo.log RC=$? done
which fails on the 1st, 2nd or 3rd loops (hence the flaky behaviour on the bots)
and I was able to confirm that by applying these reverts the flaky behaviour of ./ScudoUnitTest-powerpc64le-Test/163/220 and ./ScudoUnitTest-powerpc64le-Test/ScudoPrimaryTestMemoryGroup_TestConfig3/MemoryGroup disappear
~/llvm/mono/llvm-project $ git revert fd7c7ad4fe0138314b922ea0db1691d5a679cc75 [main 77190d04d010] Revert "[scudo] Fix implicitly narrow casting (NFC)" 3 files changed, 5 insertions(+), 10 deletions(-) ~/llvm/mono/llvm-project $ git revert 9c26f51f5e178ac0fda98419e3a61d205d3b58b1 [main d982b881645e] Revert "[scudo] Support partial page releasing" 4 files changed, 19 insertions(+), 91 deletions(-) ~/llvm/mono/llvm-project $ git revert cf9d7f55d3bec7640fa8b2f8ec1d9c1268233caa [main 556f28478a6c] Revert "[scudo] Manage free blocks in BatchGroup." 8 files changed, 67 insertions(+), 635 deletions(-)
The flaky tests still fail after reverting 9c26f51f5e178ac0fda98419e3a61d205d3b58b1 so cf9d7f55d3bec7640fa8b2f8ec1d9c1268233caa is likely the culprit but I will have to revert all three patches since they are dependent on each other in a chain i.e I must revert fd7c7ad4fe0138314b922ea0db1691d5a679cc75 in order to revert 9c26f51f5e178ac0fda98419e3a61d205d3b58b1 in order to revert cf9d7f55d3bec7640fa8b2f8ec1d9c1268233caa
Thank you for the review, I am testing these changes at the moment, will post the update afterwards.
Oct 12 2022
Oct 7 2022
This change causes a linking failure during the check-all testing of 'clang-tools-extra' on the clang-ppc64le-rhel #22596 and clang-ppc64le-linux-multistage #23864 build bots, please address this failure as soon as possible.
Oct 4 2022
Sep 19 2022
Thanks for the review! :)
Sep 15 2022
Jul 26 2022
@phosek Pinging this patch, our builders which run check-all and expect compiler-rt, enabled as a runtime with -DLLVM_ENABLE_RUNTIMES=compiler-rt, to be covered in testing are not doing this and are still being affected by this changeset.
clang-ppc64le-rhel and clang-ppc64-aix are not currently testing compiler-rt because of this change.
clang-ppc64le-linux-test-suite enables compiler-rt as a project with -DLLVM_ENABLE_PROJECTS=compiler-rt and test it under check-all as expected.
Before this, both bots would test compiler-rt under check-all. Could you please take a look at this?
Jul 19 2022
Jul 6 2022
Jul 5 2022
Jun 30 2022
Jun 29 2022
This update removes the edits made to the TestSuiteBuilder, as they are not
critical to the PR, we will not be moving away from the UnifiedTreeBuilder
as a base for the TestSuiteBuilder.
Jun 23 2022
Planning to move away from the UnifiedTreeBuilder for our TestSuiteBuilder
Jun 21 2022
Jun 8 2022
May 19 2022
May 18 2022
May 17 2022
May 12 2022
Apr 18 2022
Creating separate workers for the flang and mlir ppc64le builders to remove any
dependency on build request order between the two bots as was pointed out in a
Apr 12 2022
Apr 7 2022
Apr 4 2022
Mar 25 2022
I'm sorry I took so long to notify you but I need to bring these bots back to green as soon as possible, they have been broken too long.
This option appears to incorrectly warn warning that unsigned NumEntries = getNumEntries(); is "set but not used" in llvm/include/llvm/ADT/DenseMap.h:129 and so it is breaking the ppc64le-lld-multistage-test bot.
This could be because the only use is in an assert which is in a corner case maybe?
Mar 18 2022
The test cases added with this commit failed on clang-ppc64be-linux-lnt # 13809 could you please revert this change, and recommit with the test case corrected? thank you.