User Details
- User Since
- Jun 4 2019, 12:39 PM (84 w, 4 d)
Yesterday
Oct 12 2020
This LGTM
Oct 10 2020
Sep 1 2020
Aug 21 2020
Aug 20 2020
Aug 14 2020
This LGTM
Aug 10 2020
Hello, sorry but can you please revert this commit and recommit it when you have a fix or work around that doesn't break our bots:
It breaks http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/11228 which builds with -Werror
Please also note that it introduced 103 warnings in clang-ppc64le-linux-multistage/builds/13042
Aug 7 2020
Rebasing and updating patch to use TLS enablement option.
Aug 6 2020
Rebasing patch on D85448 and editing test cases to use enablement option.
Replacing assert() with report_fatal_error()
Aug 5 2020
Rebasing and addressing review comments:
- rebased on the updated version of D82315
- updated test cases according to reviews
- updated llvm-readobj run lines in test cases to reflect interface change
Addressing review comments and updating test cases:
- rebasing the patch on to a more recent master and fixed merge conflicts
- changed test cases to remove unnecessary bloat and update run lines.
Jul 16 2020
LGTM
Jul 9 2020
Jul 8 2020
LGTM
Jul 7 2020
This is LGTM, one suggestion on the clang-format change that can be done pre-commit.
This LGTM
- rearranging conditional logic for emitting MCSymbolRefExpr::VK_PPC_TLS_PCREL so that it is less redundant and reads better.
- replacing future with pwr10 in test cases and adding better comments.
Jul 6 2020
- Renaming test functions names as per review comments.
- Rebasing branch to more recent version of master.
- Adding asserts to ensure values are always what they are expected to be.
- Code formating and comments added.
- Conditional logic for register operands rearranged to avoid potential bugs in PPCTLSDynamicCall.cpp.
Jul 1 2020
Jun 26 2020
- Rebasing patch to be dependant on D82315 - TLS Support for General Dynamic.
- Adding Combination flag MO_GOT_TPREL_PCREL_FLAG to more explicitly define the king that will output @got@tprel@pcrel relocation.
- Adding assembly reader test cases by request of reviewer for more robust testing.
- Minor format changes.
Jun 25 2020
Addressing clang format suggestion.
Adding a combination flag to more explicitly set the bits needed to produce
General Dynamic TLS model relocations.
Jun 24 2020
Jun 23 2020
Addressing review comments.
Updating test case.
Jun 22 2020
Updating patch with author's credits.
Jun 16 2020
Jun 3 2020
Third attempt to address clang-format.
Addressing clang-format suggestion.
Address clang-format suggestions.
Updating this patch to make it a target independent IPO module pass.
May 22 2020
May 15 2020
Addressed some review comments.
While using Arcanist I accidentally made the differential change BASE because the recorded HEAD commit hash on phabricator somehow became mixed-matched with my local HEAD that i use for this branch.
I am manually uploading the diff to correct this.
May 14 2020
Addressing review and clang-tidy comments
Addressing review and clang-tidy comments
LGTM, one pre-commit nit with the indentation.
I think the index for the StoreSpillOpcodesArray and LoadSpillOpcodesArray arrays are incorrect.
May 13 2020
I can definitely do this, I'll mark this patch as "changes planned" and then post the updated target independent version when it is completed.
2: Is there any plan to extend the light path definition. Currently in this pass a light path is a path from entry block directly to exit block. But I think light path can be more general. A simple example
// ENTRY // | // BB1 // / \ // | BB2 // | | \ // | ANY BLOCKS // | / // RET //A light path for this case can be ENTRY->BB1->RET and outline other blocks.
If we plan to extend light path definition, I think better to do a little change in the code framework. Eg: define a function like findLightPath() in tryOutlining instead of hard code the light path?
There are plans to improve this pass once that pass is completed and makes it into the compiler. Thank you for this guidance, I will keep it in mind.
3: After get the light path, I think it’s better to call interfaces in class CodeExtractor to do outlining like hotcoldsplitting pass and PartialInliner pass did.
I had not considered this , I will investigate this possibility as well.
May 12 2020
May 11 2020
May 4 2020
This LGTM, one minor comment about test case explanation, it can be done pre-commit for sure.
Apr 22 2020
Apr 21 2020
Apr 17 2020
Sorry I missed that git clang-format changed whitespace on unrelated lines.
Pulling out simply because of this seems like unnecessary churn for the bots
especially since the formatting is an improvement.
If someone would like me to pull it, I certainly don't mind.
I will definitely be more vigilant next time.
I commented on the commit b771c4a8, FYI
Sorry I missed that git clang-format changed whitespace on unrelated lines.
Pulling out simply because of this seems like unnecessary churn for the bots
especially since the formatting is an improvement.
If someone would like me to pull it, I certainly don't mind.
I will definitely be more vigilant next time.
Apr 16 2020
Apr 9 2020
Apr 8 2020
Apr 6 2020
Mar 19 2020
Mar 2 2020
Sorry to report but this is causing failures as well.
http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/1695
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/35741
Testing Time: 760.34s ******************** Unresolved Tests (1): Profile-powerpc64le :: instrprof-merging.cpp
Jan 30 2020
Jan 29 2020
@dschuff please note this patch causes build failures for PowerPC big endian buildbots with commit rGa928d127a52a
If the solution isn't a simple fix please revert the commit so we may continue testing the rest of the repository
Jan 22 2020
Jan 21 2020
@epastor The lastest commit for this patch: r5f6dfa800e0b causes build failures on:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/23101
http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/43182
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/34405