Page MenuHomePhabricator

stefanp (Stefan Pintilie)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2017, 8:02 AM (304 w, 5 d)

Recent Activity

Yesterday

stefanp added a comment to D143467: [PowerPC] Add target feature requirement to builtins.

Overall I think that this looks fine to me as well.
I had a couple of minor comments and you may decide that you don't need to do either one so if that's the case just mention why in a comment and I will approve the patch.

Fri, Mar 31, 11:25 AM · Restricted Project, Restricted Project
stefanp committed rG471f1664f382: [NFC][PowerPC] Marked the addr-label.ll test unsupported on PowerPC. (authored by stefanp).
[NFC][PowerPC] Marked the addr-label.ll test unsupported on PowerPC.
Fri, Mar 31, 7:42 AM · Restricted Project, Restricted Project

Wed, Mar 29

stefanp added inline comments to D146325: [PowerPC] Add statistics to show the number of entries in the TOC..
Wed, Mar 29, 12:31 PM · Restricted Project, Restricted Project
stefanp updated the diff for D146325: [PowerPC] Add statistics to show the number of entries in the TOC..

Updated test case to include another thread local value.
Updated the code to include all of the thread local flags.

Wed, Mar 29, 12:30 PM · Restricted Project, Restricted Project
stefanp added inline comments to D133103: [PowerPC] Improve kill flag computation and add verification after MI peephole.
Wed, Mar 29, 10:40 AM · Restricted Project, Restricted Project

Fri, Mar 24

stefanp added a comment to D133103: [PowerPC] Improve kill flag computation and add verification after MI peephole.

Overall I think that this patch makes sense to me. A few minor things:

  1. I think that there are some changes that are nice improvements but aren't really part of the kill flags fix. This is already a fairly large patch and removing these little fixes might make the patch clearer and easier to read. They can be made before or after with a (or several) NFC change(s).
  2. I know this is an older patch and I apologize for taking so long to look at it. When I tried to rebase this patch to the Top of main I realized that I had to add a couple more addRegToUpdate in order to get it working. This isn't an issue with the patch it's just that new changes to PPCMIPeephole will require additions or addRegToUpdate.
  3. Is there any way to provide an error or warning for the future when more peephole optimizations are added and for whatever reason the developer forgets to call addRegToUpdate? There may not be a way to do this and that's fine. I'm more curious.
Fri, Mar 24, 1:24 PM · Restricted Project, Restricted Project

Thu, Mar 23

stefanp added a comment to D146632: [PowerPC] Fix the xxperm swap requirements.

I realize that a lot of test cases have changed but it would be good to add the test case that is specific to this opportunity where the copy is removed.

Thu, Mar 23, 7:29 AM · Restricted Project, Restricted Project

Mon, Mar 20

stefanp updated the diff for D146325: [PowerPC] Add statistics to show the number of entries in the TOC..

Split the global TOC entries into Local and External Linkage.

Mon, Mar 20, 11:04 AM · Restricted Project, Restricted Project

Fri, Mar 17

stefanp updated the diff for D146325: [PowerPC] Add statistics to show the number of entries in the TOC..

Fixed a couple of spacing issues that I missed when I put the patch up.

Fri, Mar 17, 12:49 PM · Restricted Project, Restricted Project
stefanp added reviewers for D146325: [PowerPC] Add statistics to show the number of entries in the TOC.: Restricted Project, kamaub.
Fri, Mar 17, 12:43 PM · Restricted Project, Restricted Project
stefanp requested review of D146325: [PowerPC] Add statistics to show the number of entries in the TOC..
Fri, Mar 17, 12:42 PM · Restricted Project, Restricted Project

Mar 2 2023

stefanp added a comment to D142282: [Support] Implement findModulesAndOffsets on Apple 64-bit platforms.

@luismarques
Hi,
It looks like your patch broke our build bot on AIX:
https://lab.llvm.org/buildbot/#/builders/214/builds/6115

Mar 2 2023, 7:06 AM · Restricted Project, Restricted Project

Feb 24 2023

stefanp committed rGb47473908b32: [PowerPC] Add Binary Coded Decimal Assist Instructions (authored by stefanp).
[PowerPC] Add Binary Coded Decimal Assist Instructions
Feb 24 2023, 1:00 PM · Restricted Project, Restricted Project
stefanp closed D144068: [PowerPC] Add Binary Coded Decimal Assist Instructions.
Feb 24 2023, 12:59 PM · Restricted Project, Restricted Project
stefanp updated the diff for D144068: [PowerPC] Add Binary Coded Decimal Assist Instructions.

Rebased to top of trunk.

Feb 24 2023, 12:54 PM · Restricted Project, Restricted Project

Feb 15 2023

stefanp added a comment to D141407: [scudo] Call __scudo_deallocate_hook on reallocations..

@chelfi
It looks like this changeset has broken one of the bots on PowerPC.
https://lab.llvm.org/buildbot/#/builders/57

Feb 15 2023, 9:22 AM · Restricted Project, Restricted Project

Feb 14 2023

stefanp added a reviewer for D144068: [PowerPC] Add Binary Coded Decimal Assist Instructions: Restricted Project.
Feb 14 2023, 6:51 PM · Restricted Project, Restricted Project
stefanp requested review of D144068: [PowerPC] Add Binary Coded Decimal Assist Instructions.
Feb 14 2023, 6:50 PM · Restricted Project, Restricted Project

Feb 13 2023

stefanp committed rG2e47aafb02f3: [PowerPC] Fix float materialization patterns. (authored by stefanp).
[PowerPC] Fix float materialization patterns.
Feb 13 2023, 7:19 AM · Restricted Project, Restricted Project
stefanp closed D142120: [PowerPC] Fix float materialization patterns..
Feb 13 2023, 7:19 AM · Restricted Project, Restricted Project
stefanp updated the diff for D142120: [PowerPC] Fix float materialization patterns..

Added a comment to the test case.
Rebased to top of trunk.

Feb 13 2023, 6:35 AM · Restricted Project, Restricted Project

Jan 27 2023

stefanp added a comment to D137504: [PowerPC] Implement 64-bit ELFv2 Calling Convention in TableGen (for integers/floats/vectors in registers).

Overall I think this patch looks great.

Jan 27 2023, 12:34 PM · Restricted Project, Restricted Project, Restricted Project

Jan 19 2023

stefanp added a reviewer for D142120: [PowerPC] Fix float materialization patterns.: Restricted Project.
Jan 19 2023, 8:24 AM · Restricted Project, Restricted Project
stefanp updated the diff for D142120: [PowerPC] Fix float materialization patterns..

Removed one line of the test that was not required.

Jan 19 2023, 7:52 AM · Restricted Project, Restricted Project
stefanp requested review of D142120: [PowerPC] Fix float materialization patterns..
Jan 19 2023, 7:49 AM · Restricted Project, Restricted Project

Jan 4 2023

stefanp committed rGc1d0118459c8: [PowerPC] Materialize floats in the range [-16.0, 15.0]. (authored by stefanp).
[PowerPC] Materialize floats in the range [-16.0, 15.0].
Jan 4 2023, 10:52 AM · Restricted Project, Restricted Project
stefanp closed D138844: [PowerPC] Materialize floats in the range [-16.0, 15.0]..
Jan 4 2023, 10:52 AM · Restricted Project, Restricted Project
stefanp updated the diff for D138844: [PowerPC] Materialize floats in the range [-16.0, 15.0]..

Rebased to top of main branch.

Jan 4 2023, 10:51 AM · Restricted Project, Restricted Project

Dec 21 2022

stefanp added inline comments to D138844: [PowerPC] Materialize floats in the range [-16.0, 15.0]..
Dec 21 2022, 8:20 AM · Restricted Project, Restricted Project

Dec 20 2022

stefanp accepted D140414: [PowerPC] Implement P10 Byte Reverse Insructions.

LGTM

Dec 20 2022, 6:47 PM · Restricted Project, Restricted Project

Dec 16 2022

stefanp added inline comments to D140104: [clang][dataflow] Remove unused argument in getNullability.
Dec 16 2022, 6:47 AM · Restricted Project, Restricted Project, Restricted Project

Dec 9 2022

stefanp added a comment to D136335: [Assignment Tracking Analysis][5/*] Tests.

Test "DebugInfo/assignment-tracking/X86/remove-undef-fragment.ll" is failing on Fuchsia's Linux ARM64 Clang builder as well. Error message:

Dec 9 2022, 3:22 PM · Restricted Project, debug-info, Restricted Project
stefanp added a comment to D136335: [Assignment Tracking Analysis][5/*] Tests.

I've made the test X86 only to allow time for this to be investigated.
34a3259fab86aaa1a20224e08849775f3593e6a3
This should help bring the bots back to green in the meantime.

Dec 9 2022, 3:17 PM · Restricted Project, debug-info, Restricted Project
stefanp committed rG34a3259fab86: [NFC][Assignment Tracking Analysis] Stop failing test from running on PPC. (authored by stefanp).
[NFC][Assignment Tracking Analysis] Stop failing test from running on PPC.
Dec 9 2022, 3:05 PM · Restricted Project, Restricted Project
stefanp added a comment to D136335: [Assignment Tracking Analysis][5/*] Tests.

It looks like the test test/DebugInfo/assignment-tracking/X86/remove-undef-fragment.ll fails on multiple PPC bots.
https://lab.llvm.org/buildbot/#/builders/214/builds/4756
https://lab.llvm.org/buildbot/#/builders/231/builds/6006
https://lab.llvm.org/buildbot/#/builders/121/builds/26032

Dec 9 2022, 2:48 PM · Restricted Project, debug-info, Restricted Project

Dec 2 2022

stefanp added a comment to D137504: [PowerPC] Implement 64-bit ELFv2 Calling Convention in TableGen (for integers/floats/vectors in registers).

Silly question:
Can we now get rid of CC_PPC64_ELF_FIS completely?

Dec 2 2022, 8:38 AM · Restricted Project, Restricted Project, Restricted Project

Dec 1 2022

stefanp added a comment to D138844: [PowerPC] Materialize floats in the range [-16.0, 15.0]..

I would like to address the following comment because it is not at all obvious why I decided not to go with this approach.

This looks wrong. This will produce a pair of 32-bit single precision values in the FP portion of the VSX register. What you want is a 64-bit double precision value in each doubleword.
Don't forget that single precision values on PPC are in registers as double precison but rounded to single precision (i.e. a double precision representation of a single precision value).
I think you should use scalar instructions for scalar values (xscvsxdsp, xscvsxddp).
Dec 1 2022, 3:21 PM · Restricted Project, Restricted Project
stefanp updated the diff for D138844: [PowerPC] Materialize floats in the range [-16.0, 15.0]..

Removed unnecessary whitespace change.

Dec 1 2022, 2:54 PM · Restricted Project, Restricted Project
stefanp updated the diff for D138844: [PowerPC] Materialize floats in the range [-16.0, 15.0]..

Fixed the patch and a number of test cases.

Dec 1 2022, 2:51 PM · Restricted Project, Restricted Project

Nov 30 2022

stefanp commandeered D91053: [PowerPC] Lump the constants to save one addis for each constant access.

I'm going to commandeer this patch and rebase it to see if I can revive it.

Nov 30 2022, 5:42 PM · Restricted Project, Restricted Project
stefanp added a comment to D138844: [PowerPC] Materialize floats in the range [-16.0, 15.0]..

There are some tests failing with this patch. I'm looking into them now...

Nov 30 2022, 5:38 PM · Restricted Project, Restricted Project
stefanp added a comment to D138844: [PowerPC] Materialize floats in the range [-16.0, 15.0]..

Do we already handle vector constants that are splats (i.e. { 1.0f, 1.0f, 1.0f, 1.0f } or { 3.0, 3.0 })? If not, do we plan to?

Nov 30 2022, 7:29 AM · Restricted Project, Restricted Project
stefanp updated the diff for D138844: [PowerPC] Materialize floats in the range [-16.0, 15.0]..

Moved the constant materialization to the td file.

Nov 30 2022, 7:24 AM · Restricted Project, Restricted Project

Nov 29 2022

stefanp accepted D138736: [PowerPC] Fix vperm codegen.

Thank you for fixing this!
LGTM.

Nov 29 2022, 11:49 AM · Restricted Project, Restricted Project

Nov 28 2022

stefanp added a comment to D138736: [PowerPC] Fix vperm codegen.

Thank you for fixing this.
I do have a couple of comments related to the fix.

Nov 28 2022, 12:48 PM · Restricted Project, Restricted Project
stefanp added a reviewer for D138844: [PowerPC] Materialize floats in the range [-16.0, 15.0].: Restricted Project.
Nov 28 2022, 11:45 AM · Restricted Project, Restricted Project
stefanp updated the diff for D138844: [PowerPC] Materialize floats in the range [-16.0, 15.0]..

Forgot to do a clang-format.
Updated patch with that.

Nov 28 2022, 11:44 AM · Restricted Project, Restricted Project
stefanp requested review of D138844: [PowerPC] Materialize floats in the range [-16.0, 15.0]..
Nov 28 2022, 11:41 AM · Restricted Project, Restricted Project

Nov 22 2022

stefanp committed rG1ac6956b52c7: [PowerPC] Add handling for WACC register spilling. (authored by stefanp).
[PowerPC] Add handling for WACC register spilling.
Nov 22 2022, 7:38 AM · Restricted Project, Restricted Project
stefanp closed D136728: [PowerPC] Add handling for WACC register spilling..
Nov 22 2022, 7:38 AM · Restricted Project, Restricted Project
stefanp updated the diff for D136728: [PowerPC] Add handling for WACC register spilling..

Rebased to top of main branch.

Nov 22 2022, 7:36 AM · Restricted Project, Restricted Project

Nov 21 2022

stefanp accepted D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm.

Thank you for fixing that last test!
LGTM.

Nov 21 2022, 6:18 PM · Restricted Project, Restricted Project

Nov 10 2022

stefanp committed rG1ef2a92d6679: [PowerPC] Add the SUBFUS instruction to Future CPU. (authored by stefanp).
[PowerPC] Add the SUBFUS instruction to Future CPU.
Nov 10 2022, 6:32 AM · Restricted Project, Restricted Project
stefanp closed D137643: [PowerPC] Add the SUBFUS instruction to Future CPU..
Nov 10 2022, 6:32 AM · Restricted Project, Restricted Project

Nov 8 2022

stefanp requested changes to D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm.

Sorry, I know that I had approved this before but it seems that the test p10-splatImm32-undef.ll starts failing with this patch.
It may just be that the test needs to be updated but please make sure that is all it is.

Nov 8 2022, 6:03 PM · Restricted Project, Restricted Project
stefanp accepted D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm.

I think this looks good.
Thank you for addressing the comments!

Nov 8 2022, 12:12 PM · Restricted Project, Restricted Project
stefanp added a reviewer for D137643: [PowerPC] Add the SUBFUS instruction to Future CPU.: Restricted Project.
Nov 8 2022, 7:19 AM · Restricted Project, Restricted Project
stefanp requested review of D137643: [PowerPC] Add the SUBFUS instruction to Future CPU..
Nov 8 2022, 7:18 AM · Restricted Project, Restricted Project

Nov 3 2022

stefanp added inline comments to D136728: [PowerPC] Add handling for WACC register spilling..
Nov 3 2022, 7:07 PM · Restricted Project, Restricted Project
stefanp updated the diff for D136728: [PowerPC] Add handling for WACC register spilling..

Fixed some spacing and a couple of comments.

Nov 3 2022, 7:07 PM · Restricted Project, Restricted Project
stefanp accepted D136992: [PowerPC] Add new load/store with length instructions to Future CPU..

Other than a very minor nit I think this LGTM.

Nov 3 2022, 12:32 PM · Restricted Project, Restricted Project
stefanp committed rG9df924a634ac: [PowerPC] Add new DMR register classes to Future CPU. (authored by stefanp).
[PowerPC] Add new DMR register classes to Future CPU.
Nov 3 2022, 6:30 AM · Restricted Project, Restricted Project
stefanp closed D136366: [PowerPC] Add new DMR register classes to Future CPU..
Nov 3 2022, 6:29 AM · Restricted Project, Restricted Project
stefanp added inline comments to D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm.
Nov 3 2022, 5:52 AM · Restricted Project, Restricted Project

Nov 2 2022

stefanp updated the diff for D136366: [PowerPC] Add new DMR register classes to Future CPU..

Moved the include location for PPCInstrFutureMMA.td.

Nov 2 2022, 6:32 PM · Restricted Project, Restricted Project
stefanp updated the diff for D136366: [PowerPC] Add new DMR register classes to Future CPU..

Rebased patch to top of main branch.

Nov 2 2022, 1:36 PM · Restricted Project, Restricted Project
stefanp added inline comments to D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm.
Nov 2 2022, 1:09 PM · Restricted Project, Restricted Project

Oct 28 2022

stefanp added a comment to D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm.

Thank you for your patience and sorry it took me so long to get to this.

Oct 28 2022, 3:27 PM · Restricted Project, Restricted Project

Oct 27 2022

stefanp added inline comments to D136366: [PowerPC] Add new DMR register classes to Future CPU..
Oct 27 2022, 12:32 PM · Restricted Project, Restricted Project
stefanp updated the diff for D136366: [PowerPC] Add new DMR register classes to Future CPU..

Rebased patch to top of main and addressed a couple of nits.

Oct 27 2022, 12:32 PM · Restricted Project, Restricted Project

Oct 25 2022

stefanp added a reviewer for D136728: [PowerPC] Add handling for WACC register spilling.: Restricted Project.
Oct 25 2022, 6:32 PM · Restricted Project, Restricted Project
stefanp requested review of D136728: [PowerPC] Add handling for WACC register spilling..
Oct 25 2022, 6:32 PM · Restricted Project, Restricted Project

Oct 20 2022

stefanp updated the diff for D136366: [PowerPC] Add new DMR register classes to Future CPU..

nit: Fixed some spacing.

Oct 20 2022, 9:18 AM · Restricted Project, Restricted Project
stefanp added a reviewer for D136366: [PowerPC] Add new DMR register classes to Future CPU.: Restricted Project.
Oct 20 2022, 9:12 AM · Restricted Project, Restricted Project
stefanp requested review of D136366: [PowerPC] Add new DMR register classes to Future CPU..
Oct 20 2022, 9:12 AM · Restricted Project, Restricted Project

Oct 18 2022

stefanp committed rGb107ff485621: [NFC][PowerPC] Add a test to check power 10 features. (authored by stefanp).
[NFC][PowerPC] Add a test to check power 10 features.
Oct 18 2022, 7:10 AM · Restricted Project, Restricted Project

Oct 14 2022

stefanp committed rG6897dbc46329: [PowerPC] Fix parameters for __builtin_crypto_vsbox (authored by stefanp).
[PowerPC] Fix parameters for __builtin_crypto_vsbox
Oct 14 2022, 11:31 AM · Restricted Project, Restricted Project
stefanp closed D135834: [PowerPC] Fix parameters for __builtin_crypto_vsbox.
Oct 14 2022, 11:31 AM · Restricted Project, Restricted Project

Oct 12 2022

stefanp added a reviewer for D135834: [PowerPC] Fix parameters for __builtin_crypto_vsbox: amyk.
Oct 12 2022, 5:33 PM · Restricted Project, Restricted Project
stefanp added a reviewer for D135834: [PowerPC] Fix parameters for __builtin_crypto_vsbox: Restricted Project.
Oct 12 2022, 5:33 PM · Restricted Project, Restricted Project
stefanp requested review of D135834: [PowerPC] Fix parameters for __builtin_crypto_vsbox.
Oct 12 2022, 5:32 PM · Restricted Project, Restricted Project

Oct 6 2022

stefanp committed rG0e2e1fc90a01: [PowerPC] Fix types for vcipher builtins. (authored by stefanp).
[PowerPC] Fix types for vcipher builtins.
Oct 6 2022, 12:21 PM · Restricted Project, Restricted Project
stefanp closed D135300: [PowerPC] Fix types for vcipher builtins..
Oct 6 2022, 12:21 PM · Restricted Project, Restricted Project

Oct 5 2022

stefanp updated the summary of D135300: [PowerPC] Fix types for vcipher builtins..
Oct 5 2022, 12:10 PM · Restricted Project, Restricted Project
stefanp added a reviewer for D135300: [PowerPC] Fix types for vcipher builtins.: Restricted Project.
Oct 5 2022, 12:04 PM · Restricted Project, Restricted Project
stefanp requested review of D135300: [PowerPC] Fix types for vcipher builtins..
Oct 5 2022, 12:03 PM · Restricted Project, Restricted Project

Oct 4 2022

stefanp committed rG30d639180f67: [PowerPC] Fix the register allocation hints for ACC registers. (authored by stefanp).
[PowerPC] Fix the register allocation hints for ACC registers.
Oct 4 2022, 6:30 PM · Restricted Project, Restricted Project
stefanp closed D134501: [PowerPC] Fix the register allocation hints for ACC registers..
Oct 4 2022, 6:30 PM · Restricted Project, Restricted Project
stefanp updated the diff for D134501: [PowerPC] Fix the register allocation hints for ACC registers..

Rebased to top of main branch.

Oct 4 2022, 6:25 PM · Restricted Project, Restricted Project

Sep 22 2022

stefanp added reviewers for D134501: [PowerPC] Fix the register allocation hints for ACC registers.: amyk, Restricted Project.
Sep 22 2022, 4:13 PM · Restricted Project, Restricted Project
stefanp requested review of D134501: [PowerPC] Fix the register allocation hints for ACC registers..
Sep 22 2022, 4:13 PM · Restricted Project, Restricted Project

Sep 19 2022

stefanp abandoned D133426: [LSR] Address a special case involving NULL..

Thank you both for looking at this patch.
Looking at the comments I feel like I made an incorrect assumption about NULL pointers in this case and I'm just going to abandon this patch.

Sep 19 2022, 9:18 AM · Restricted Project, Restricted Project

Sep 13 2022

stefanp updated the summary of D133426: [LSR] Address a special case involving NULL..
Sep 13 2022, 11:41 AM · Restricted Project, Restricted Project
stefanp updated the summary of D133426: [LSR] Address a special case involving NULL..
Sep 13 2022, 11:41 AM · Restricted Project, Restricted Project
stefanp retitled D133426: [LSR] Address a special case involving NULL. from [LICM][LSR] Address a couple of special cases involving NULL. to [LSR] Address a special case involving NULL..
Sep 13 2022, 11:41 AM · Restricted Project, Restricted Project
stefanp updated the diff for D133426: [LSR] Address a special case involving NULL..

Sorry that this took a few days.
Removed the code from LICM.
Added a test for the loop strength reduction. The test shows simpler code when
the guard for the NULL is added. However, there may be other tests where the
reverse is true.

Sep 13 2022, 11:38 AM · Restricted Project, Restricted Project

Sep 8 2022

stefanp added inline comments to D133426: [LSR] Address a special case involving NULL..
Sep 8 2022, 12:17 PM · Restricted Project, Restricted Project
stefanp accepted D133485: [LICM] Allow promotion with non-load/store users.

This is better than what I initially tried to do in D133426.
LGTM

Sep 8 2022, 10:18 AM · Restricted Project, Restricted Project

Sep 7 2022

stefanp added a comment to D133426: [LSR] Address a special case involving NULL..

Please add some tests for the new conditions.

Sep 7 2022, 8:09 AM · Restricted Project, Restricted Project
stefanp added reviewers for D133426: [LSR] Address a special case involving NULL.: qcolombet, Restricted Project.
Sep 7 2022, 8:06 AM · Restricted Project, Restricted Project