Page MenuHomePhabricator

stefanp (Stefan Pintilie)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2017, 8:02 AM (149 w, 1 d)

Recent Activity

Tue, Mar 24

stefanp updated the diff for D76160: [PowerPC][Future] Add offsets to PC Relative relocations. .

Fixed bug with missing offset in object file.

Tue, Mar 24, 8:02 AM

Fri, Mar 20

stefanp added inline comments to D73664: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC..
Fri, Mar 20, 3:12 PM · Restricted Project, Restricted Project
stefanp updated the diff for D73664: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC..

Addressed review comments.
Added new test cases to cover a number of different call situations.

Fri, Mar 20, 3:12 PM · Restricted Project, Restricted Project

Tue, Mar 17

stefanp updated the diff for D76160: [PowerPC][Future] Add offsets to PC Relative relocations. .

Addressed review comments for the code.
Added a test case that will check both the assembly and do an llvm-objdump of the object file.

Tue, Mar 17, 1:29 PM

Fri, Mar 13

stefanp created D76160: [PowerPC][Future] Add offsets to PC Relative relocations. .
Fri, Mar 13, 2:01 PM

Thu, Mar 12

stefanp accepted D75819: [PowerPC][NFC] Rename instruction formats in PPCInstrPrefix.td.

Thank you for fixing this Amy.
LGTM.

Thu, Mar 12, 10:51 AM · Restricted Project
stefanp updated the diff for D75280: [PowerPC][Future] Add initial support for PC Relative addressing for global values.

It is correct that the code did not need to be moved. I've moved it back.

Thu, Mar 12, 7:35 AM · Restricted Project
stefanp created D76064: [PowerPC][Future] Add initial support for PC Relative addressing for global values that require GOT indirect addressing.
Thu, Mar 12, 7:03 AM · Restricted Project

Wed, Mar 11

stefanp requested changes to D75819: [PowerPC][NFC] Rename instruction formats in PPCInstrPrefix.td.

Talked this over with the team and we have decided on a way to rename that class. See the comment.

Wed, Mar 11, 1:35 PM · Restricted Project
stefanp updated the diff for D74486: [PowerPC][Future] Add initial support for PC Relative addressing for constant pool loads.

Accidentally added unnecessary code when I did a rebase. Removed that now.

Wed, Mar 11, 6:18 AM · Restricted Project

Tue, Mar 10

stefanp updated the diff for D75280: [PowerPC][Future] Add initial support for PC Relative addressing for global values.

Removed inaccurate debug statement.

Tue, Mar 10, 9:46 AM · Restricted Project

Mon, Mar 9

stefanp updated the diff for D74486: [PowerPC][Future] Add initial support for PC Relative addressing for constant pool loads.

Fixed comments in the code as requested by reviewers.

Mon, Mar 9, 2:03 PM · Restricted Project
stefanp updated the diff for D73664: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC..

Disabled Tail Calls for when using PC Relative. That will be fixed in a later patch.

Mon, Mar 9, 2:03 PM · Restricted Project, Restricted Project

Mar 5 2020

stefanp updated the diff for D73664: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC..

Address Review Comments

Mar 5 2020, 2:49 PM · Restricted Project, Restricted Project
stefanp added inline comments to D73664: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC..
Mar 5 2020, 2:49 PM · Restricted Project, Restricted Project

Feb 27 2020

stefanp created D75280: [PowerPC][Future] Add initial support for PC Relative addressing for global values.
Feb 27 2020, 11:35 AM · Restricted Project

Feb 26 2020

stefanp updated the diff for D74486: [PowerPC][Future] Add initial support for PC Relative addressing for constant pool loads.

Missed a tconstpool that should have been a pcreladdr.

Feb 26 2020, 6:16 PM · Restricted Project
stefanp updated the diff for D74486: [PowerPC][Future] Add initial support for PC Relative addressing for constant pool loads.

Removed the PCRelative guard that was incorrectly placed in PPCTargetLowering::SelectAddressRegRegOnly.
Removed the isPrefix class from the td file as it was not required.
Added more comments to the PPCInstrPrefix.td.

Feb 26 2020, 4:45 PM · Restricted Project
stefanp updated the summary of D74486: [PowerPC][Future] Add initial support for PC Relative addressing for constant pool loads.
Feb 26 2020, 4:45 PM · Restricted Project

Feb 20 2020

stefanp updated the diff for D74486: [PowerPC][Future] Add initial support for PC Relative addressing for constant pool loads.

Cleaned up patch and removed the NFC part.
Also added a couple of new patterns to the td file and added a new PPCISD node MAT_PCREL_ADDR. The only purpose of this new node is to materialize PC Relative addresses.

Feb 20 2020, 12:19 PM · Restricted Project

Feb 19 2020

stefanp updated the diff for D73664: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC..

Fixup for tests test/MC/PowerPC/ppc64-localentry-error1.s and test/MC/PowerPC/ppc64-localentry-error2.s.

Feb 19 2020, 10:58 AM · Restricted Project, Restricted Project
stefanp committed rG440ca29ea266: [Hexagon][NFC] Rename VK_Hexagon_PCREL to VK_PCREL (authored by stefanp).
[Hexagon][NFC] Rename VK_Hexagon_PCREL to VK_PCREL
Feb 19 2020, 7:56 AM
stefanp closed D74788: [Hexagon][NFC] Rename VK_Hexagon_PCREL to VK_PCREL.
Feb 19 2020, 7:55 AM · Restricted Project

Feb 18 2020

stefanp added a comment to D74486: [PowerPC][Future] Add initial support for PC Relative addressing for constant pool loads.

Created a new review for only the NFC Hexagon changes here: https://reviews.llvm.org/D74788
Next, I will rework this patch.

Feb 18 2020, 12:17 PM · Restricted Project
stefanp created D74788: [Hexagon][NFC] Rename VK_Hexagon_PCREL to VK_PCREL.
Feb 18 2020, 12:17 PM · Restricted Project
stefanp updated the diff for D73664: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC..

Addressed review comments as well as the issue with MO_ExternalSymbol. I've added a test case for the situation where MO_ExternalSymbol is required.

Feb 18 2020, 10:53 AM · Restricted Project, Restricted Project

Feb 12 2020

stefanp committed rGab4d60642142: [PowerPC] Add support for intrinsic llvm.ppc.eieio (authored by anil9).
[PowerPC] Add support for intrinsic llvm.ppc.eieio
Feb 12 2020, 7:27 AM
stefanp committed rGb413e5c3097c: [PowerPC] Add support for intrinsics llvm.ppc.dcbfl and llvm.ppc.dcbflp (authored by anil9).
[PowerPC] Add support for intrinsics llvm.ppc.dcbfl and llvm.ppc.dcbflp
Feb 12 2020, 7:27 AM
stefanp closed D69066: Add support for intrinsic llvm.ppc.eieio.
Feb 12 2020, 7:27 AM · Restricted Project
stefanp closed D68411: Add support for intrinsics llvm.ppc.dcbfl and llvm.ppc.dcbflp.
Feb 12 2020, 7:27 AM · Restricted Project
stefanp created D74486: [PowerPC][Future] Add initial support for PC Relative addressing for constant pool loads.
Feb 12 2020, 7:00 AM · Restricted Project

Feb 10 2020

stefanp added inline comments to D73664: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC..
Feb 10 2020, 10:27 AM · Restricted Project, Restricted Project

Feb 5 2020

stefanp added a comment to D68237: [PowerPC] Handle f16 as a storage type only.

Mostly nits from me.

Feb 5 2020, 5:23 PM · Restricted Project
stefanp accepted D73692: [PowerPC] Fix spilling of vector registers in PEI of EH aware functions.

Couple of nits but overall LGTM.

Feb 5 2020, 12:19 PM · Restricted Project, Restricted Project

Feb 4 2020

stefanp updated the diff for D73664: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC..

Address review comments.

Feb 4 2020, 6:12 PM · Restricted Project, Restricted Project
stefanp added a comment to D73664: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC..

Address a number of review comments.

Feb 4 2020, 6:03 PM · Restricted Project, Restricted Project

Jan 30 2020

stefanp committed rG9de1241bb2dd: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions (authored by stefanp).
[PowerPC][Future] Branch Distance Estimation For Prefixed Instructions
Jan 30 2020, 6:59 AM
stefanp closed D72572: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions.
Jan 30 2020, 6:59 AM · Restricted Project, Restricted Project
stefanp committed rGf00be8da62b8: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support (authored by stefanp).
[PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support
Jan 30 2020, 4:59 AM
stefanp closed D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support.
Jan 30 2020, 4:58 AM · Restricted Project, Restricted Project

Jan 29 2020

stefanp created D73664: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC..
Jan 29 2020, 1:59 PM · Restricted Project, Restricted Project

Jan 27 2020

stefanp updated the diff for D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support.

Address review comments.

Jan 27 2020, 5:38 PM · Restricted Project, Restricted Project

Jan 13 2020

stefanp updated the diff for D72572: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions.

Addressed review comments.

Jan 13 2020, 2:21 PM · Restricted Project, Restricted Project
stefanp updated the diff for D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.

Addressed review comment by hard coding the prefix for MLS_DForm2_r0.

Jan 13 2020, 1:15 PM · Restricted Project, Restricted Project
stefanp updated the diff for D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support.

Address review comments.

Jan 13 2020, 10:54 AM · Restricted Project, Restricted Project

Jan 12 2020

stefanp added a parent revision for D72574: [PowerPC][Future] Add pld and pstd to future CPU: D72572: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions.
Jan 12 2020, 12:01 PM · Restricted Project, Restricted Project
stefanp added a child revision for D72572: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions: D72574: [PowerPC][Future] Add pld and pstd to future CPU.
Jan 12 2020, 12:01 PM · Restricted Project, Restricted Project
stefanp added a child revision for D72574: [PowerPC][Future] Add pld and pstd to future CPU: D72577: [PowerPC][Future] Add prefixed loads and stores for future CPU.
Jan 12 2020, 12:01 PM · Restricted Project, Restricted Project
stefanp added a parent revision for D72577: [PowerPC][Future] Add prefixed loads and stores for future CPU: D72574: [PowerPC][Future] Add pld and pstd to future CPU.
Jan 12 2020, 12:01 PM · Restricted Project, Restricted Project
stefanp created D72577: [PowerPC][Future] Add prefixed loads and stores for future CPU.
Jan 12 2020, 12:01 PM · Restricted Project, Restricted Project
stefanp created D72574: [PowerPC][Future] Add pld and pstd to future CPU.
Jan 12 2020, 10:30 AM · Restricted Project, Restricted Project
stefanp updated the diff for D72572: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions.

Added full context.

Jan 12 2020, 10:12 AM · Restricted Project, Restricted Project
stefanp updated the diff for D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support.

Added full context.

Jan 12 2020, 10:06 AM · Restricted Project, Restricted Project
stefanp updated the diff for D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.

Added full context.

Jan 12 2020, 10:03 AM · Restricted Project, Restricted Project
stefanp added a child revision for D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support: D72572: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions.
Jan 12 2020, 8:58 AM · Restricted Project, Restricted Project
stefanp added a parent revision for D72572: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions: D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support.
Jan 12 2020, 8:58 AM · Restricted Project, Restricted Project
stefanp created D72572: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions.
Jan 12 2020, 8:58 AM · Restricted Project, Restricted Project
stefanp added a parent revision for D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support: D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.
Jan 12 2020, 8:12 AM · Restricted Project, Restricted Project
stefanp added a child revision for D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU: D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support.
Jan 12 2020, 8:12 AM · Restricted Project, Restricted Project
stefanp created D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support.
Jan 12 2020, 8:12 AM · Restricted Project, Restricted Project
stefanp created D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.
Jan 12 2020, 7:55 AM · Restricted Project, Restricted Project

Dec 18 2019

stefanp committed rGec3d6f3ecb4e: [PowerPC][NFC] Refactor splat of constant to vector. (authored by stefanp).
[PowerPC][NFC] Refactor splat of constant to vector.
Dec 18 2019, 10:46 AM
stefanp closed D71481: [PowerPC][NFC] Refactor splat of constant to vector..
Dec 18 2019, 10:46 AM · Restricted Project

Dec 17 2019

stefanp added a comment to D68237: [PowerPC] Handle f16 as a storage type only.

Other than the test case which still needs to be updated I think that this patch looks good to me.

Dec 17 2019, 2:37 PM · Restricted Project
stefanp accepted D71481: [PowerPC][NFC] Refactor splat of constant to vector..

It took me a while to determine that this was in fact NFC.
Removing the whole:

if (HasAnyUndefs || ISD::isBuildVectorAllOnes(BVN)) {
...
}

threw me off.
I'm convinced now so I'll approve it.
The minor nit that I have can be done on commit.

Dec 17 2019, 12:07 PM · Restricted Project

Dec 10 2019

stefanp closed D70976: [zorg] Add LNT testing to clang-ppc64le-rhel.
Dec 10 2019, 10:00 AM
stefanp committed rZORG622b3edf47e7: [zorg] Add LNT testing to clang-ppc64le-rhel (authored by stefanp).
[zorg] Add LNT testing to clang-ppc64le-rhel
Dec 10 2019, 10:00 AM

Dec 5 2019

stefanp requested changes to D69484: [PowerPC] Relax the restrictions on loading doubles with SPE.

Please add a test case for this.
Maybe an test were we have an SPE load of f64 with a 8 bit offset and one where the offset is larger or perhaps not aligned. Anyway, that's just a suggestion. You probably have a better idea of what you would like to test for this.

Dec 5 2019, 7:21 PM · Restricted Project
stefanp requested changes to D69486: PowerPC: Fix SPE f64 VAARG handling..
Dec 5 2019, 11:30 AM · Restricted Project
stefanp added a comment to D69486: PowerPC: Fix SPE f64 VAARG handling..

I think that for f64 on SPE the GprIndex you are computing it going to be ignored. (See my comment...)

Dec 5 2019, 11:21 AM · Restricted Project

Nov 27 2019

stefanp committed rG8e84c9ae9984: [PowerPC] Separate Features that are known to be Power9 specific from Future CPU (authored by stefanp).
[PowerPC] Separate Features that are known to be Power9 specific from Future CPU
Nov 27 2019, 1:42 PM
stefanp closed D70466: [PowerPC] Separate Features that are known to be Power9 specific from Future CPU.
Nov 27 2019, 1:42 PM · Restricted Project
stefanp committed rGdcceab1a0ace: [PowerPC] Add new Future CPU for PowerPC in LLVM (authored by stefanp).
[PowerPC] Add new Future CPU for PowerPC in LLVM
Nov 27 2019, 12:32 PM
stefanp closed D70333: [PowerPC] Add new Future CPU for PowerPC in LLVM.
Nov 27 2019, 12:32 PM · Restricted Project

Nov 21 2019

stefanp committed rG5fcf89f77893: [PowerPC] Add new Future CPU for PowerPC (authored by stefanp).
[PowerPC] Add new Future CPU for PowerPC
Nov 21 2019, 11:36 AM
stefanp closed D70262: [PowerPC] Add new Future CPU for PowerPC.
Nov 21 2019, 11:36 AM · Restricted Project

Nov 19 2019

stefanp added a parent revision for D70466: [PowerPC] Separate Features that are known to be Power9 specific from Future CPU: D70333: [PowerPC] Add new Future CPU for PowerPC in LLVM.
Nov 19 2019, 2:42 PM · Restricted Project
stefanp added a child revision for D70333: [PowerPC] Add new Future CPU for PowerPC in LLVM: D70466: [PowerPC] Separate Features that are known to be Power9 specific from Future CPU.
Nov 19 2019, 2:42 PM · Restricted Project
stefanp created D70466: [PowerPC] Separate Features that are known to be Power9 specific from Future CPU.
Nov 19 2019, 2:42 PM · Restricted Project

Nov 18 2019

stefanp committed rG6512473ceef2: [PowerPC] Improve float vector gather codegen (authored by stefanp).
[PowerPC] Improve float vector gather codegen
Nov 18 2019, 1:55 PM
stefanp closed D62908: [PowerPC] Improve float vector gather codegen.
Nov 18 2019, 1:55 PM · Restricted Project
stefanp committed rG9d9389391408: [PowerPC] Test case for vector float gather on ppc64le and ppc64 (authored by stefanp).
[PowerPC] Test case for vector float gather on ppc64le and ppc64
Nov 18 2019, 11:18 AM
stefanp closed D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64.
Nov 18 2019, 11:18 AM · Restricted Project

Nov 15 2019

stefanp added a comment to D69835: Add options for PPC to enable/disable using non-volatile CR.

I only saw a minor nit with this patch overall.

Nov 15 2019, 2:23 PM · Restricted Project
stefanp accepted D69168: [PowerPC] Fold redundant load immediates of zero and delete if possible.

LGTM

Nov 15 2019, 1:39 PM · Restricted Project
stefanp accepted D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64.

LGTM

Nov 15 2019, 12:54 PM · Restricted Project
stefanp accepted D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64.
Nov 15 2019, 12:54 PM · Restricted Project
stefanp added a comment to D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64.

I think this patch is fine now.
I only have one minor comment.

Nov 15 2019, 12:19 PM · Restricted Project
stefanp created D70333: [PowerPC] Add new Future CPU for PowerPC in LLVM.
Nov 15 2019, 11:43 AM · Restricted Project

Nov 14 2019

stefanp created D70262: [PowerPC] Add new Future CPU for PowerPC.
Nov 14 2019, 11:11 AM · Restricted Project

Nov 4 2019

stefanp added a comment to D69168: [PowerPC] Fold redundant load immediates of zero and delete if possible.

Mostly minor comments and a couple of questions.

Nov 4 2019, 12:41 PM · Restricted Project
stefanp requested changes to D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64.

Please make sure that your test does not put restrictions on the allocation of output registers. See my comments.
Otherwise I think this looks fine.

Nov 4 2019, 11:54 AM · Restricted Project

Oct 24 2019

stefanp accepted D66329: [PowerPC] [Peephole] fold frame offset by using index form to save add..

LGTM.
Sorry for taking so long to get to this.

Oct 24 2019, 1:13 PM · Restricted Project

Oct 2 2019

stefanp accepted D68344: [PowerPC] Remove assertion "Shouldn't overwrite a register before it is killed".

Thank you for fixing this.
LGTM.

Oct 2 2019, 1:12 PM · Restricted Project

Sep 30 2019

stefanp added a comment to D66329: [PowerPC] [Peephole] fold frame offset by using index form to save add..

I took this patch and applied it to master today and I noticed that one of the LIT tests fails.
The test is:

test-suite/MultiSource/Benchmarks/tramp3d-v4/

It segfaults with this patch and runs fine with out it.
I took a quick look at it and it seems that in this basic block:

; predecessors: %bb.11, %bb.12, %bb.13
  successors: %bb.21(0x80000000); %bb.21(100.00%)
  liveins: $r6, $r7, $r9, $x4, $x5, $x10, $x12, $x30, $r8
  renamable $x3 = ADDI8 $x1, 32
  STW killed renamable $r8, 32, $x1 :: (store 4 into %ir.arrayidx.i.i.i.i.i.i.i.i424, align 8), (store 4 into %ir.129, align 8)
  STW killed renamable $r6, 36, $x1 :: (store 4 into %ir.132)
  STW killed renamable $r7, 44, $x1 :: (store 4 into %ir.134)
  STW killed renamable $r9, 52, $x1 :: (store 4 into %ir.136)
  renamable $x3 = ADD8 killed renamable $x3, killed renamable $x5
  renamable $x5 = nsw ADD8 killed renamable $x10, killed renamable $x12
  renamable $r3 = LWZ 4, killed renamable $x3 :: (load 4 from %ir.137)
  renamable $x5 = nsw SUBF8 renamable $x4, killed renamable $x5
  STW8 killed renamable $x4, 24, renamable $x30 :: (store 4 into %ir.141)
  renamable $r3 = ADD4 killed renamable $r3, killed renamable $r5, implicit $x5
  B %bb.21

We replace

renamable $x3 = ADDI8 $x1, 32
renamable $x3 = ADD8 killed renamable $x3, killed renamable $x5
renamable $r3 = LWZ 4, killed renamable $x3 :: (load 4 from %ir.137)

with:

renamable $x3 = ADDI8 $x1, 36
renamable $r3 = LWZX killed $x5, killed $x3 :: (load 4 from %ir.137)

However, it looks like x5 is redefined before the load so using it in the LWZX is not safe because it is not the same x5 as before.

Sep 30 2019, 12:38 PM · Restricted Project

Sep 19 2019

stefanp closed D65820: [PowerPC] PPC LLD buildbot test instability fix..

Thank you Galina!
Committed at r371652.

Sep 19 2019, 11:33 AM
stefanp closed D67630: [PowerPC] PPC LLD buildbot fix previous patch.

Thank you Galina!
Committed at r372342.

Sep 19 2019, 11:33 AM

Sep 18 2019

stefanp added a comment to D67630: [PowerPC] PPC LLD buildbot fix previous patch.

@gkistanova
Thank you for reviewing this Galina.
I don't have commit access to zorg. Can you commit this for me?

Sep 18 2019, 9:23 AM

Sep 16 2019

stefanp created D67630: [PowerPC] PPC LLD buildbot fix previous patch.
Sep 16 2019, 1:05 PM

Sep 13 2019

stefanp added a comment to D66329: [PowerPC] [Peephole] fold frame offset by using index form to save add..

I do have a couple additional comments.

Sep 13 2019, 3:02 PM · Restricted Project