I'm sorry it took so long for me to look at this review.

Addressed review comments.

Removed the custom PPCISD node and it simplified the patch considerably.

Address Review Comments

Moved condition to the correct location and added a test case.

Update patch based on reviewer comments.

I'm not 100% sure if we can remove the default option -funwind-tables for x86.
I know that using -funwind-tables prevents (or hides) this issue but it may be required for another reason that this fix does not cover. I don't actually know what the initial intention was when that default was added.
I think that someone on the x86 side would be a better judge of this.

Sorry about that. I should have added the test cases earlier.

Added test case.
Address reviewers comments.

Determined this is not the correct way to solve this problem.
Going to abandon this change.

GCC does call the exception handler correctly for this example. However, it does not (at least not that I can tell) have a default option like the one llvm uses -funwind-tables.

We have determined that we do not require these builtin names.

I looked into the naming of those builtins.
GCC does document the overloaded versions of those functions:
scalar_extract_exp for __builtin_vsx_scalar_extract_expq
scalar_insert_exp for __builtin_vsx_scalar_insert_exp_qp

Added handling for the select f128.
Unlike the double type, the __float128 type cannot not use the fsel instruction but we should still expand it to something that functions correctly.

Done.
Committed in revision: rL336295

Hi Hal, Eric,

Hi Eric,

Fixed comments according to previous review.

Updated the comments.
Sorry.. I should have caught them initially.

Sorry for the late reply. I have been distracted with something else for a little while.
I have added the patch to remove needsAggressiveScheduling() here:
https://reviews.llvm.org/D48663

Fixed test case command.

Updated the test case to use clang cc1 instead of just clang.

@lattner
Added Chris Lattner as a reviewer in case I did something silly in the target indep code.

Fixed some of the style issues.

Hi Eric,