Page MenuHomePhabricator

stefanp (Stefan Pintilie)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2017, 8:02 AM (90 w, 1 d)

Recent Activity

Wed, Feb 13

stefanp updated the diff for D42590: [PowerPC] Try to move the stack pointer update instruction later in the prologue and earlier in the epilogue (Version 2).

Fixed according to review comments.

Wed, Feb 13, 5:17 PM
stefanp added a comment to D42590: [PowerPC] Try to move the stack pointer update instruction later in the prologue and earlier in the epilogue (Version 2).

Committed revision 353994 with the test cases as NFC.
Will update the patch for the remaining comments soon...

Wed, Feb 13, 3:50 PM
stefanp committed rG1113940df2f8: [PowerPC][NFC] Added tests for prologue and epilogue code gen. (authored by stefanp).
[PowerPC][NFC] Added tests for prologue and epilogue code gen.
Wed, Feb 13, 3:37 PM
stefanp committed rL353994: [PowerPC][NFC] Added tests for prologue and epilogue code gen..
[PowerPC][NFC] Added tests for prologue and epilogue code gen.
Wed, Feb 13, 3:36 PM

Tue, Feb 5

stefanp abandoned D57759: [PowerPC] Code Cleanup Remove u1imm.

Hi Hal,
I'm actually not going to do this in the end.... I'm just going to abandon this patch.
I realized that we did actually need this type too.

Tue, Feb 5, 3:57 PM
stefanp added a comment to D57759: [PowerPC] Code Cleanup Remove u1imm.

Hi Hal,
Thank you for the review.
I've looked around but the only place we use u1imm is where we only have 1 bit to use in the instruction anyway so we have no way to represent -1 anyway.

Tue, Feb 5, 1:31 PM
stefanp created D57759: [PowerPC] Code Cleanup Remove u1imm.
Tue, Feb 5, 9:05 AM
stefanp created D57752: [PowerPC] [Buildbots] Do not build shared libs for the PowerPC LLD buildbot.
Tue, Feb 5, 7:21 AM

Wed, Jan 30

stefanp closed D57110: [PowerPC] [Buildbots] Looking to add lld buildbot for PowerPC.

This patch was committed by Galina in r352652.

Wed, Jan 30, 1:45 PM

Tue, Jan 29

stefanp added a comment to D56286: [OPENMP] Deal with additional store inserted by Clang under -fno-PIC for PowerPC..

Gentle ping..

Tue, Jan 29, 1:07 PM · Restricted Project

Mon, Jan 28

stefanp added a comment to D57314: [PowerPC] more opportunity for converting reg+reg to reg+imm.

Looked through this and tried a couple of things but overall it looks good.
My only comments are a couple of minor nit items.

Mon, Jan 28, 10:15 AM
stefanp abandoned D45266: [PowerPC] Add a Memory Latency Mutation to the scheduler.

No longer working on this.

Mon, Jan 28, 6:56 AM
stefanp closed D39805: [Power9] Set MicroOpBufferSize for Power 9.

Closed.

Mon, Jan 28, 6:45 AM

Fri, Jan 25

stefanp updated the diff for D42590: [PowerPC] Try to move the stack pointer update instruction later in the prologue and earlier in the epilogue (Version 2).

Addressed comments from Jinsong.

Fri, Jan 25, 12:02 PM
stefanp updated the diff for D57110: [PowerPC] [Buildbots] Looking to add lld buildbot for PowerPC.

@gkistanova
Hi Galina,
Thank you for approving this.
I'm sorry but I have to change it a little bit. I just realized that the previous changeset was setting -DLLVM_ENABLE_LLD on both stage1 and stage2 builds and that won't work. We just want that option on stage2.

Fri, Jan 25, 10:27 AM

Wed, Jan 23

stefanp created D57110: [PowerPC] [Buildbots] Looking to add lld buildbot for PowerPC.
Wed, Jan 23, 11:33 AM
stefanp updated the diff for D42590: [PowerPC] Try to move the stack pointer update instruction later in the prologue and earlier in the epilogue (Version 2).

Addressed reviewer comments.
Limited optimization to cases where the fixed called saved regs fit in the red zone of 288 bytes.

Wed, Jan 23, 7:59 AM

Jan 3 2019

stefanp updated the diff for D56286: [OPENMP] Deal with additional store inserted by Clang under -fno-PIC for PowerPC..

Modified patch to completely revert rL349512.

Jan 3 2019, 1:33 PM · Restricted Project
stefanp created D56286: [OPENMP] Deal with additional store inserted by Clang under -fno-PIC for PowerPC..
Jan 3 2019, 12:10 PM · Restricted Project

Dec 18 2018

stefanp committed rL349521: [Tests] [OpenMP] XFAIL also for ppc64le..
[Tests] [OpenMP] XFAIL also for ppc64le.
Dec 18 2018, 11:08 AM
stefanp committed rOMP349521: [Tests] [OpenMP] XFAIL also for ppc64le..
[Tests] [OpenMP] XFAIL also for ppc64le.
Dec 18 2018, 11:08 AM
stefanp committed rOMP349512: XFAIL Pair of OpenMP Tests for PowerPC LE Linux.
XFAIL Pair of OpenMP Tests for PowerPC LE Linux
Dec 18 2018, 9:43 AM
stefanp committed rL349512: XFAIL Pair of OpenMP Tests for PowerPC LE Linux.
XFAIL Pair of OpenMP Tests for PowerPC LE Linux
Dec 18 2018, 9:42 AM
stefanp committed rC349489: [PowerPC] Make no-PIC default to match GCC - CLANG.
[PowerPC] Make no-PIC default to match GCC - CLANG
Dec 18 2018, 7:11 AM
stefanp committed rL349489: [PowerPC] Make no-PIC default to match GCC - CLANG.
[PowerPC] Make no-PIC default to match GCC - CLANG
Dec 18 2018, 7:11 AM
stefanp closed D53384: [PowerPC] Make no-PIC default to match GCC - CLANG.
Dec 18 2018, 7:11 AM
stefanp reopened D53384: [PowerPC] Make no-PIC default to match GCC - CLANG.
Dec 18 2018, 7:07 AM

Dec 11 2018

stefanp committed rC348858: Revert "[PowerPC] Make no-PIC default to match GCC - CLANG".
Revert "[PowerPC] Make no-PIC default to match GCC - CLANG"
Dec 11 2018, 7:52 AM
stefanp added a reverting change for rL348299: [PowerPC] Make no-PIC default to match GCC - CLANG: rL348858: Revert "[PowerPC] Make no-PIC default to match GCC - CLANG".
Dec 11 2018, 7:52 AM
stefanp committed rL348858: Revert "[PowerPC] Make no-PIC default to match GCC - CLANG".
Revert "[PowerPC] Make no-PIC default to match GCC - CLANG"
Dec 11 2018, 7:52 AM

Dec 4 2018

stefanp committed rC348299: [PowerPC] Make no-PIC default to match GCC - CLANG.
[PowerPC] Make no-PIC default to match GCC - CLANG
Dec 4 2018, 12:18 PM
stefanp committed rL348299: [PowerPC] Make no-PIC default to match GCC - CLANG.
[PowerPC] Make no-PIC default to match GCC - CLANG
Dec 4 2018, 12:18 PM
stefanp closed D53384: [PowerPC] Make no-PIC default to match GCC - CLANG.
Dec 4 2018, 12:18 PM
stefanp committed rL348298: [PowerPC] Make no-PIC default to match GCC - LLVM.
[PowerPC] Make no-PIC default to match GCC - LLVM
Dec 4 2018, 12:18 PM
stefanp closed D53383: [PowerPC] Make no-PIC default to match GCC - LLVM .
Dec 4 2018, 12:18 PM

Nov 26 2018

stefanp updated the diff for D53384: [PowerPC] Make no-PIC default to match GCC - CLANG.

Patch is now only for Little Endian.
Big Endian will remain PIC by default as it was before. This is due to a bug found on BE where -fsanitize=leak is not detecting leaks correctly. As Little Endian is a higher priority we will add that code first and then look at the BE issue at a later date.

Nov 26 2018, 11:09 AM
stefanp updated the diff for D53383: [PowerPC] Make no-PIC default to match GCC - LLVM .

Patch is now only for Little Endian.
Big Endian will remain PIC by default as it was before. This is due to a bug found on BE where -fsanitize=leak is not detecting leaks correctly. As Little Endian is a higher priority we will add that code first and then look at the BE issue at a later date.

Nov 26 2018, 11:09 AM

Nov 21 2018

stefanp committed rL347428: [PowerPC][NFC] Split PPCMCCodeEmitter into header and cpp file..
[PowerPC][NFC] Split PPCMCCodeEmitter into header and cpp file.
Nov 21 2018, 1:26 PM
stefanp committed rL347422: [PowerPC][NFC] Minor Code Cleaup for PPCMCCodeEmitter..
[PowerPC][NFC] Minor Code Cleaup for PPCMCCodeEmitter.
Nov 21 2018, 12:50 PM

Nov 16 2018

stefanp reopened D53383: [PowerPC] Make no-PIC default to match GCC - LLVM .
Nov 16 2018, 12:44 PM
stefanp reopened D53384: [PowerPC] Make no-PIC default to match GCC - CLANG.
Nov 16 2018, 12:44 PM
stefanp committed rL347076: Revert "[PowerPC] Make no-PIC default to match GCC - LLVM".
Revert "[PowerPC] Make no-PIC default to match GCC - LLVM"
Nov 16 2018, 11:27 AM
stefanp committed rC347075: Revert "[PowerPC] Make no-PIC default to match GCC - CLANG".
Revert "[PowerPC] Make no-PIC default to match GCC - CLANG"
Nov 16 2018, 11:24 AM
stefanp committed rL347075: Revert "[PowerPC] Make no-PIC default to match GCC - CLANG".
Revert "[PowerPC] Make no-PIC default to match GCC - CLANG"
Nov 16 2018, 11:24 AM
stefanp committed rC347070: [PowerPC] Make no-PIC default to match GCC - CLANG.
[PowerPC] Make no-PIC default to match GCC - CLANG
Nov 16 2018, 10:39 AM
stefanp committed rL347070: [PowerPC] Make no-PIC default to match GCC - CLANG.
[PowerPC] Make no-PIC default to match GCC - CLANG
Nov 16 2018, 10:39 AM
stefanp closed D53384: [PowerPC] Make no-PIC default to match GCC - CLANG.
Nov 16 2018, 10:39 AM
stefanp committed rL347069: [PowerPC] Make no-PIC default to match GCC - LLVM.
[PowerPC] Make no-PIC default to match GCC - LLVM
Nov 16 2018, 10:39 AM
stefanp closed D53383: [PowerPC] Make no-PIC default to match GCC - LLVM .
Nov 16 2018, 10:39 AM

Nov 2 2018

stefanp updated the diff for D53384: [PowerPC] Make no-PIC default to match GCC - CLANG.

Added the PIC version to the second test as well.
Removed the third test. It has nothing to do with this change and I should not have modified that test in the first place.

Nov 2 2018, 2:24 PM
stefanp added inline comments to D53384: [PowerPC] Make no-PIC default to match GCC - CLANG.
Nov 2 2018, 1:42 PM

Oct 25 2018

stefanp added a comment to D53383: [PowerPC] Make no-PIC default to match GCC - LLVM .

@joerg
When you say that we produce quite bad position dependent code do you mean in terms of performance or in terms of correctness? At this point I have not seen any issues with the no-PIC code. If you have an example of this bad code please share the test case.
Also, changing the default option to no-PIC does not mean that everything we do will become no-PIC. For example, the way that the TOC is handled on PPC remains position independent. However, going from PIC to no-PIC does offer a number of opportunities (for example in in-lining).
With respect to PIE I'm not sure what the difference is between PIE and static relocation models in terms of code generation. Is there any reason why you would prefer PIE in this case? Do you have an example that shows it to be better than say no-PIC?

Oct 25 2018, 1:06 PM

Oct 24 2018

stefanp added a comment to D53383: [PowerPC] Make no-PIC default to match GCC - LLVM .

Generally the way I decided on how to update the test depended on a couple of things:

  1. If the test had this line: ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py it means that we had an auto generate test and if I felt that the test had nothing really to do with PIC or no-PIC I would just regenerate it. For example a number of tests just had addis ld differences.
  2. If the test was not auto generated but it still had nothing to do with PIC / no-PIC I would just add -relocation-model=pic. Changing these tests would not get us very much and it would be a significant amount of work.
  3. For tests that had something to do with PIC / no-PIC I tried to make a judgement call as to what would be more useful to keep (the PIC test or the non-PIC test). If you feel that some of these tests I should have been the other way around let me know. I know you mentioned a couple in your comment and I'll take a look at those.
Oct 24 2018, 1:25 PM
stefanp added inline comments to D53384: [PowerPC] Make no-PIC default to match GCC - CLANG.
Oct 24 2018, 1:09 PM
stefanp updated the diff for D53383: [PowerPC] Make no-PIC default to match GCC - LLVM .

Default on all Power PC platforms is now no-PIC.
If any bugs are exposed by this change we will fix them as they are exposed.

Oct 24 2018, 10:14 AM
stefanp updated the diff for D53384: [PowerPC] Make no-PIC default to match GCC - CLANG.

Default on all Power PC platforms is now no-PIC.
If any bugs are exposed by this change we will fix them as they are exposed.

Oct 24 2018, 10:13 AM

Oct 23 2018

stefanp committed rL345053: [Power9] Add __float128 support in the backend for bitcast to a i128.
[Power9] Add __float128 support in the backend for bitcast to a i128
Oct 23 2018, 10:13 AM
stefanp closed D49507: [Power9] Add __float128 support in the backend for bitcast to a i128.
Oct 23 2018, 10:13 AM

Oct 22 2018

stefanp updated the diff for D49507: [Power9] Add __float128 support in the backend for bitcast to a i128.

Simplified the code further.

Oct 22 2018, 9:13 AM
stefanp updated the diff for D53383: [PowerPC] Make no-PIC default to match GCC - LLVM .

Updated test cases.

Oct 22 2018, 6:33 AM
stefanp updated the diff for D53384: [PowerPC] Make no-PIC default to match GCC - CLANG.

Test cases updated.

Oct 22 2018, 6:30 AM

Oct 19 2018

stefanp updated the diff for D49507: [Power9] Add __float128 support in the backend for bitcast to a i128.

Simplified some of the conditionals (easier to read) and added an early exit.

Oct 19 2018, 9:01 AM

Oct 17 2018

stefanp added a child revision for D53383: [PowerPC] Make no-PIC default to match GCC - LLVM : D53384: [PowerPC] Make no-PIC default to match GCC - CLANG.
Oct 17 2018, 12:39 PM
stefanp added a parent revision for D53384: [PowerPC] Make no-PIC default to match GCC - CLANG: D53383: [PowerPC] Make no-PIC default to match GCC - LLVM .
Oct 17 2018, 12:39 PM
stefanp created D53384: [PowerPC] Make no-PIC default to match GCC - CLANG.
Oct 17 2018, 12:38 PM
stefanp created D53383: [PowerPC] Make no-PIC default to match GCC - LLVM .
Oct 17 2018, 12:36 PM

Oct 10 2018

stefanp updated the diff for D42590: [PowerPC] Try to move the stack pointer update instruction later in the prologue and earlier in the epilogue (Version 2).

I'm sorry it took so long for me to look at this review.

Oct 10 2018, 1:08 PM

Oct 5 2018

stefanp updated the diff for D49507: [Power9] Add __float128 support in the backend for bitcast to a i128.

Addressed review comments.

Oct 5 2018, 12:16 PM

Oct 4 2018

stefanp updated the diff for D49507: [Power9] Add __float128 support in the backend for bitcast to a i128.

Removed the custom PPCISD node and it simplified the patch considerably.

Oct 4 2018, 11:14 AM

Oct 1 2018

stefanp committed rL343525: [PowerPC] Folding XForm to DForm loads requires alignment for some DForm loads..
[PowerPC] Folding XForm to DForm loads requires alignment for some DForm loads.
Oct 1 2018, 1:18 PM
stefanp closed D51988: [PowerPC] Folding XForm to DForm loads requires alignment for some DForm loads..
Oct 1 2018, 1:18 PM
stefanp updated the diff for D49507: [Power9] Add __float128 support in the backend for bitcast to a i128.

Address Review Comments

Oct 1 2018, 12:24 PM

Sep 28 2018

stefanp updated the diff for D51988: [PowerPC] Folding XForm to DForm loads requires alignment for some DForm loads..

Moved condition to the correct location and added a test case.

Sep 28 2018, 2:33 PM

Sep 24 2018

stefanp committed rL342911: [Power9] [CLANG] Add __float128 exponent GET and SET builtins.
[Power9] [CLANG] Add __float128 exponent GET and SET builtins
Sep 24 2018, 11:16 AM
stefanp committed rC342911: [Power9] [CLANG] Add __float128 exponent GET and SET builtins.
[Power9] [CLANG] Add __float128 exponent GET and SET builtins
Sep 24 2018, 11:16 AM
stefanp closed D48184: [Power9] [CLANG] Add __float128 exponent GET and SET builtins.
Sep 24 2018, 11:16 AM
stefanp committed rL342910: [Power9] [LLVM] Add __float128 exponent GET and SET builtins.
[Power9] [LLVM] Add __float128 exponent GET and SET builtins
Sep 24 2018, 11:16 AM
stefanp closed D48185: [Power9] [LLVM] Add __float128 exponent GET and SET builtins.
Sep 24 2018, 11:16 AM

Sep 12 2018

stefanp created D51988: [PowerPC] Folding XForm to DForm loads requires alignment for some DForm loads..
Sep 12 2018, 7:28 AM

Sep 10 2018

stefanp updated the diff for D48185: [Power9] [LLVM] Add __float128 exponent GET and SET builtins.

Update patch based on reviewer comments.

Sep 10 2018, 1:25 PM

Aug 27 2018

stefanp added a comment to D50987: [Exception Handling] Unwind tables are required for all functions that have an EH personality..

I'm not 100% sure if we can remove the default option -funwind-tables for x86.
I know that using -funwind-tables prevents (or hides) this issue but it may be required for another reason that this fix does not cover. I don't actually know what the initial intention was when that default was added.
I think that someone on the x86 side would be a better judge of this.

Aug 27 2018, 5:43 AM

Aug 24 2018

stefanp committed rL340643: [PowerPC] Emit xscpsgndp instead of xxlor when copying floating point scalar….
[PowerPC] Emit xscpsgndp instead of xxlor when copying floating point scalar…
Aug 24 2018, 1:01 PM
stefanp closed D50004: [PowerPC] Emit xscpsgndp instead of xxlor when copying floating point scalar registers for P9.
Aug 24 2018, 1:01 PM
stefanp committed rL340641: [Exception Handling] Unwind tables are required for all functions that have an….
[Exception Handling] Unwind tables are required for all functions that have an…
Aug 24 2018, 12:40 PM
stefanp closed D50987: [Exception Handling] Unwind tables are required for all functions that have an EH personality..
Aug 24 2018, 12:39 PM
stefanp committed rL340639: [PowerPC] Change Test Options [NFC].
[PowerPC] Change Test Options [NFC]
Aug 24 2018, 12:25 PM
stefanp reopened D50987: [Exception Handling] Unwind tables are required for all functions that have an EH personality..
Aug 24 2018, 11:00 AM
stefanp committed rL340625: Revert "[Exception Handling] Unwind tables are required for all functions that….
Revert "[Exception Handling] Unwind tables are required for all functions that…
Aug 24 2018, 10:28 AM
stefanp added a reverting change for rL340614: [Exception Handling] Unwind tables are required for all functions that have an…: rL340625: Revert "[Exception Handling] Unwind tables are required for all functions that….
Aug 24 2018, 10:28 AM
stefanp committed rL340614: [Exception Handling] Unwind tables are required for all functions that have an….
[Exception Handling] Unwind tables are required for all functions that have an…
Aug 24 2018, 8:52 AM
stefanp closed D50987: [Exception Handling] Unwind tables are required for all functions that have an EH personality..
Aug 24 2018, 8:52 AM

Aug 22 2018

stefanp updated the diff for D50987: [Exception Handling] Unwind tables are required for all functions that have an EH personality..

Sorry about that. I should have added the test cases earlier.

Aug 22 2018, 12:15 PM

Aug 20 2018

stefanp updated the diff for D49507: [Power9] Add __float128 support in the backend for bitcast to a i128.

Added test case.
Address reviewers comments.

Aug 20 2018, 1:46 PM
stefanp created D50987: [Exception Handling] Unwind tables are required for all functions that have an EH personality..
Aug 20 2018, 12:17 PM
stefanp abandoned D50908: [PowerPC] Enable -funwind-tables by default on powerpc.

Determined this is not the correct way to solve this problem.
Going to abandon this change.

Aug 20 2018, 11:38 AM

Aug 17 2018

stefanp added a comment to D50908: [PowerPC] Enable -funwind-tables by default on powerpc.

GCC does call the exception handler correctly for this example. However, it does not (at least not that I can tell) have a default option like the one llvm uses -funwind-tables.

Aug 17 2018, 12:20 PM
stefanp created D50908: [PowerPC] Enable -funwind-tables by default on powerpc.
Aug 17 2018, 9:54 AM
stefanp committed rL340037: [PowerPC] Generate lxsd instead of the ld->mtvsrd sequence for vector loads.
[PowerPC] Generate lxsd instead of the ld->mtvsrd sequence for vector loads
Aug 17 2018, 8:16 AM
stefanp closed D49698: [PowerPC] Generate lxsd instead of the ld->mtvsrd sequence for vector loads.
Aug 17 2018, 8:16 AM

Aug 8 2018

stefanp commandeered D49507: [Power9] Add __float128 support in the backend for bitcast to a i128.
Aug 8 2018, 11:00 AM