Page MenuHomePhabricator

stefanp (Stefan Pintilie)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2017, 8:02 AM (172 w, 6 d)

Recent Activity

Fri, Sep 18

stefanp added a comment to D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.

@MaskRay
FYI: All of the dependent patches have landed so you should now be able to just apply this patch on top of trunk.

Fri, Sep 18, 12:11 PM · Restricted Project
stefanp updated the diff for D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.

Updated the patch to use the NOP constant.

Fri, Sep 18, 12:08 PM · Restricted Project
stefanp added inline comments to D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits.
Fri, Sep 18, 10:52 AM · Restricted Project
stefanp added reviewers for D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits: sfertile, NeHuang, Restricted Project.
Fri, Sep 18, 9:24 AM · Restricted Project
stefanp requested review of D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits.
Fri, Sep 18, 9:23 AM · Restricted Project
stefanp updated the diff for D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.

Updated test case to check for .got.
Used warningOrErr.
Used NOP.

Fri, Sep 18, 7:14 AM · Restricted Project

Tue, Sep 15

stefanp committed rG65f6810d3a4b: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec (authored by stefanp).
[LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec
Tue, Sep 15, 7:08 AM
stefanp closed D86608: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec.
Tue, Sep 15, 7:07 AM · Restricted Project

Mon, Sep 14

stefanp added inline comments to D87486: [ELF] Define a reportRangeError() overload for thunks and tidy up recent PPC64 thunk range errors.
Mon, Sep 14, 8:59 AM · Restricted Project
stefanp updated the diff for D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.

Replace error() with errorOrWarn().

Mon, Sep 14, 7:34 AM · Restricted Project
stefanp updated the diff for D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.

Fixed formatting in source file.
Fixed spacing in test file.

Mon, Sep 14, 7:28 AM · Restricted Project
stefanp added inline comments to D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.
Mon, Sep 14, 6:12 AM · Restricted Project

Fri, Sep 11

stefanp updated the diff for D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.

I've updated the description to only use the correct version of the relocation: R_PPC64_GOT_TLSGD_PCREL34.

Fri, Sep 11, 2:36 PM · Restricted Project
stefanp updated the summary of D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.
Fri, Sep 11, 2:00 PM · Restricted Project
stefanp added inline comments to D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.
Fri, Sep 11, 12:06 PM · Restricted Project
stefanp updated the diff for D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.

Fixed formatting and comments in a few places.
Added --soname to the test file.

Fri, Sep 11, 12:05 PM · Restricted Project
stefanp updated the diff for D86608: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec.

Thank you for the reviews!

Fri, Sep 11, 7:20 AM · Restricted Project
stefanp updated the summary of D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.
Fri, Sep 11, 4:02 AM · Restricted Project
stefanp updated the summary of D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.
Fri, Sep 11, 3:58 AM · Restricted Project
stefanp added reviewers for D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic: NeHuang, sfertile.
Fri, Sep 11, 3:56 AM · Restricted Project
stefanp requested review of D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.
Fri, Sep 11, 3:55 AM · Restricted Project

Tue, Sep 8

stefanp added a comment to D87330: [zorg] [PowerPC] Limit number of threads to 256 on ppc64le-sanitizer bot.

It seems that most builders do have the extra_configure_args parameter but the builder that we use here does not.
You may have to add the parameter to the build factory to get this to work.

Tue, Sep 8, 3:31 PM · Restricted Project
stefanp accepted D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.

This mostly LGTM.
From my perspective you can add no-show-raw-insn on commit.

Tue, Sep 8, 12:08 PM · Restricted Project, Restricted Project
stefanp requested review of D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.
Tue, Sep 8, 11:50 AM · Restricted Project

Thu, Sep 3

stefanp retitled D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec from [PowerPC] Add support for TLS Initial Exec to [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.
Thu, Sep 3, 12:22 PM · Restricted Project
stefanp updated the diff for D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.

Removed a couple of variables that could be inlined.
Added an error in case the offset from the 4 byte alignment is 2 or 3.
Moved checks in the test case.

Thu, Sep 3, 12:21 PM · Restricted Project
stefanp updated the diff for D86608: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec.

Fixed a couple of things on the test case.
Added the function name inside <>:.
Removed the .size directives.
Added SYMBOL-NEXT: where possible.

Thu, Sep 3, 10:38 AM · Restricted Project
stefanp added inline comments to D86608: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec.
Thu, Sep 3, 4:32 AM · Restricted Project
stefanp updated the diff for D86608: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec.

Removed the linker script that was not needed.
Added a quick summary of the test case.

Thu, Sep 3, 4:32 AM · Restricted Project
stefanp committed rGf4f29b956c62: [PowerPC] Fix missing TLS symbol type. (authored by stefanp).
[PowerPC] Fix missing TLS symbol type.
Thu, Sep 3, 3:57 AM
stefanp closed D86777: [PowerPC] Fix missing TLS symbol type..
Thu, Sep 3, 3:57 AM · Restricted Project
stefanp updated the diff for D86777: [PowerPC] Fix missing TLS symbol type..

Fixed nit and moved the position of the case in the switch.

Thu, Sep 3, 3:34 AM · Restricted Project

Tue, Sep 1

stefanp added a comment to D86777: [PowerPC] Fix missing TLS symbol type..

I'll not say this is a bug. For an undefined symbol, STT_TLS is not strictly required. For a definition, STT_TLS is indeed better.

Tue, Sep 1, 12:18 PM · Restricted Project

Mon, Aug 31

stefanp updated the summary of D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.
Mon, Aug 31, 12:52 PM · Restricted Project
stefanp requested review of D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.
Mon, Aug 31, 12:51 PM · Restricted Project

Fri, Aug 28

stefanp requested review of D86777: [PowerPC] Fix missing TLS symbol type..
Fri, Aug 28, 4:58 AM · Restricted Project

Wed, Aug 26

stefanp requested review of D86608: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec.
Wed, Aug 26, 4:08 AM · Restricted Project

Mon, Aug 24

stefanp accepted D86343: [PowerPC] Use SDISel instead of FISel for calls and TOC-based accesses with PC-Rel.

LGTM

Mon, Aug 24, 1:51 PM · Restricted Project
stefanp added inline comments to D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.
Mon, Aug 24, 12:09 PM · Restricted Project, Restricted Project

Fri, Aug 21

stefanp committed rG0cadd162b7c1: Forgot to update the test case for ppc64-tls-missing-gdld.s for 02e02f5398d0 (authored by stefanp).
Forgot to update the test case for ppc64-tls-missing-gdld.s for 02e02f5398d0
Fri, Aug 21, 11:23 AM

Aug 21 2020

stefanp committed rG02e02f5398d0: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD (authored by stefanp).
[LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD
Aug 21 2020, 10:56 AM
stefanp closed D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.
Aug 21 2020, 10:56 AM · Restricted Project
stefanp requested changes to D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.

Also, please add a test where the offset is not zero.
So the assembly would be for example:

paddi 3, 13, x@TPREL+8, 0
Aug 21 2020, 5:55 AM · Restricted Project, Restricted Project
stefanp updated the diff for D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.

Adjusted one comment and moved the code around to merge the two errorOrWarn.

Aug 21 2020, 3:46 AM · Restricted Project

Aug 20 2020

stefanp accepted D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.

Only minor nits form me.
LGTM.

Aug 20 2020, 2:27 PM · Restricted Project, Restricted Project
stefanp accepted D81947: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec.

Couple of nits.
LGTM

Aug 20 2020, 2:00 PM · Restricted Project, Restricted Project
stefanp added inline comments to D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.
Aug 20 2020, 4:20 AM · Restricted Project
stefanp updated the diff for D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.

Updated the comment to make it more concise.
Updated the test case to add the missing : .

Aug 20 2020, 4:19 AM · Restricted Project

Aug 19 2020

stefanp updated the diff for D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.

Fix some formatting.
Fix a couple of nits.
Add the --triple to the test case.

Aug 19 2020, 11:21 AM · Restricted Project

Aug 18 2020

stefanp added a comment to D86142: [LLD] Search archives for non-tentative defintions..

The general idea makes sense to me.
I have a set of mostly minor comments here and there.

Aug 18 2020, 1:33 PM · Restricted Project, Restricted Project
stefanp updated the diff for D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.

Renamed the assembly test file and removed the other test file.

Aug 18 2020, 12:39 PM · Restricted Project
stefanp updated the diff for D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.

Added the new assembly test.

Aug 18 2020, 10:03 AM · Restricted Project
stefanp added a comment to D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.

Yes! That's the test I need.
Let me add that test and we can choose which one is preferred.

Aug 18 2020, 9:05 AM · Restricted Project
stefanp added inline comments to D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.
Aug 18 2020, 4:00 AM · Restricted Project
stefanp updated the diff for D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.

I've merged a couple of the tests using yaml2obj -D. I would prefer not to merge the tests any further because the actual code in the .text section is different between TLSGD and TLSLD.

Aug 18 2020, 4:00 AM · Restricted Project

Aug 17 2020

stefanp updated the summary of D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.
Aug 17 2020, 1:59 PM · Restricted Project
stefanp updated the diff for D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.

I've tried to address the concerns for this patch. I'm sorry that it took so long to make the code changes.

Aug 17 2020, 1:51 PM · Restricted Project

Aug 14 2020

stefanp requested review of D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.
Aug 14 2020, 1:34 PM · Restricted Project

Aug 12 2020

stefanp accepted D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.

This patch makes sense to me.
I have a question about the access instruction but I don't think we should worry about it now.
LGTM!

Aug 12 2020, 2:35 PM · Restricted Project, Restricted Project

Aug 10 2020

stefanp committed rG81883ca07455: [PowerPC] Add option to control PCRel GOT indirect linker optimization (authored by stefanp).
[PowerPC] Add option to control PCRel GOT indirect linker optimization
Aug 10 2020, 7:07 AM
stefanp closed D85377: [PowerPC] Add option to control PCRel GOT indirect linker optimization.
Aug 10 2020, 7:07 AM · Restricted Project

Aug 7 2020

stefanp added inline comments to D85377: [PowerPC] Add option to control PCRel GOT indirect linker optimization.
Aug 7 2020, 9:42 AM · Restricted Project
stefanp updated the diff for D85377: [PowerPC] Add option to control PCRel GOT indirect linker optimization.

Removed the attribute nounwind as it is not needed in the test case.

Aug 7 2020, 9:41 AM · Restricted Project
stefanp updated the diff for D85377: [PowerPC] Add option to control PCRel GOT indirect linker optimization.

Fixed the mcpu=future to make it mcpu=pwr10.

Aug 7 2020, 9:37 AM · Restricted Project

Aug 6 2020

stefanp accepted D85459: [PowerPC] Add compatibility check for PPC PLT stubs .

I think this looks good! Thank you for fixing this issue.

Aug 6 2020, 5:01 PM · Restricted Project

Aug 5 2020

stefanp added a reviewer for D85377: [PowerPC] Add option to control PCRel GOT indirect linker optimization: Restricted Project.
Aug 5 2020, 5:03 PM · Restricted Project
stefanp requested review of D85377: [PowerPC] Add option to control PCRel GOT indirect linker optimization.
Aug 5 2020, 5:01 PM · Restricted Project

Jul 28 2020

stefanp added a comment to D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.

Overall I think this looks good. I had a handful of comments but nothing major.
I wish we had a better way of doing the conversion between the old forms and the PCRel forms but I can't think of a better way.

Jul 28 2020, 12:10 PM · Restricted Project, Restricted Project
stefanp committed rG97470897c436: [PowerPC] Split s34imm into two types (authored by stefanp).
[PowerPC] Split s34imm into two types
Jul 28 2020, 3:56 AM
stefanp closed D83255: [PowerPC] Split s34imm into two types.
Jul 28 2020, 3:56 AM · Restricted Project

Jul 27 2020

stefanp updated the diff for D83255: [PowerPC] Split s34imm into two types.

Changed the way that the error is emitted.

Jul 27 2020, 11:47 AM · Restricted Project

Jul 23 2020

stefanp accepted D83669: [PowerPC] Support for R_PPC64_REL24_NOTOC calls where the caller has no TOC and the callee is not DSO local.

I only had one nit.
LGTM.

Jul 23 2020, 6:45 PM · Restricted Project

Jul 22 2020

stefanp committed rGa60251d739b9: [PowerPC] Add linker opt for PC Relative GOT indirect accesses (authored by stefanp).
[PowerPC] Add linker opt for PC Relative GOT indirect accesses
Jul 22 2020, 7:14 AM
stefanp closed D79864: [PowerPC] Add linker opt for PC Relative GOT indirect accesses.
Jul 22 2020, 7:14 AM · Restricted Project
stefanp committed rGe0a372ff10c8: [PowerPC] Extend .reloc directive on PowerPC (authored by stefanp).
[PowerPC] Extend .reloc directive on PowerPC
Jul 22 2020, 2:26 AM
stefanp closed D79625: [PowerPC] Extend .reloc directive on PowerPC.
Jul 22 2020, 2:26 AM · Restricted Project

Jul 21 2020

stefanp committed rG0d3a5d09e3ef: [NFC][PowerPC] Updated a number of Power PC tests used for PC Relative (authored by stefanp).
[NFC][PowerPC] Updated a number of Power PC tests used for PC Relative
Jul 21 2020, 10:46 AM

Jul 20 2020

stefanp updated the diff for D79864: [PowerPC] Add linker opt for PC Relative GOT indirect accesses.

Flipped the if statement.
Fixed a comment in the source and added a couple more comments in the test case.

Jul 20 2020, 9:16 PM · Restricted Project
stefanp added inline comments to D79625: [PowerPC] Extend .reloc directive on PowerPC.
Jul 20 2020, 9:16 PM · Restricted Project
stefanp updated the diff for D79625: [PowerPC] Extend .reloc directive on PowerPC.

Updated patch to correctly remove new fixup.
In order to create the fixup I can use:

MCFixup::create(Offset, Expr, FirstLiteralRelocationKind + R_PPC64_PCREL_OPT, Loc);
Jul 20 2020, 9:16 PM · Restricted Project
stefanp added inline comments to D79625: [PowerPC] Extend .reloc directive on PowerPC.
Jul 20 2020, 9:16 PM · Restricted Project
stefanp updated the diff for D79625: [PowerPC] Extend .reloc directive on PowerPC.

Removed the fixup name.
@MaskRay Let me know if this is what you were looking for.

Jul 20 2020, 9:16 PM · Restricted Project

Jul 17 2020

stefanp accepted D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins.

Please wait for Lei to give the approval as well before you commit.

Jul 17 2020, 12:08 PM · Restricted Project, Restricted Project, Restricted Project
stefanp updated the diff for D79864: [PowerPC] Add linker opt for PC Relative GOT indirect accesses.

I should not have changed the cast.
Changed it back now.

Jul 17 2020, 10:00 AM · Restricted Project
stefanp accepted D83504: [PowerPC] Implement R_PPC64_REL24_NOTOC local calls. callee has a TOC.

I only had one question.
Otherwise, LGTM.

Jul 17 2020, 9:30 AM · Restricted Project
stefanp updated the diff for D79864: [PowerPC] Add linker opt for PC Relative GOT indirect accesses.

Modified static_cast to cast.
Made use of MCSymbol::print.

Jul 17 2020, 9:25 AM · Restricted Project

Jul 16 2020

stefanp accepted D82315: [PowerPC][PCRelative] Thread Local Storage Support for General Dynamic.

I think the tests can be cleaned up a little but otherwise this LGTM.

Jul 16 2020, 2:45 PM · Restricted Project, Restricted Project
stefanp added a comment to D83504: [PowerPC] Implement R_PPC64_REL24_NOTOC local calls. callee has a TOC.

I only had a couple of comments.
Overall I think this looks good.

Jul 16 2020, 11:46 AM · Restricted Project
stefanp updated the diff for D79625: [PowerPC] Extend .reloc directive on PowerPC.

Forgot to rename the testcase in the previous update of the patch.
Renamed it now.

Jul 16 2020, 11:30 AM · Restricted Project
stefanp added a comment to D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.

Just a few nits for this patch.

Jul 16 2020, 9:14 AM · Restricted Project, Restricted Project, Restricted Project
stefanp added a comment to D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.

The title of the patch mentions both zero extend and sign extend.
However, it seems that we only have instructions for the zero extend case. Is that right?
I see both types of tests in:
test/CodeGen/builtins-ppc-p10vector.c
But I only see codegen tests for the zreo extend version.
test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll

Jul 16 2020, 9:05 AM · Restricted Project, Restricted Project, Restricted Project
stefanp added inline comments to D79864: [PowerPC] Add linker opt for PC Relative GOT indirect accesses.
Jul 16 2020, 7:00 AM · Restricted Project
stefanp updated the diff for D79864: [PowerPC] Add linker opt for PC Relative GOT indirect accesses.

Changed the way that the peephole finds candidates according to the suggestion by Nemanja.
Added/fixed some comments.
Cleaned up the testcase.

Jul 16 2020, 7:00 AM · Restricted Project

Jul 15 2020

stefanp updated the diff for D79625: [PowerPC] Extend .reloc directive on PowerPC.

Moved the rest of the work to the target indep side after the patch D83751.

Jul 15 2020, 12:01 PM · Restricted Project

Jul 14 2020

stefanp accepted D83751: [MC] Support .reloc sym+constant, *, *.

Nope, no more comments.
LGTM

Jul 14 2020, 1:18 PM · Restricted Project
stefanp added inline comments to D83751: [MC] Support .reloc sym+constant, *, *.
Jul 14 2020, 11:21 AM · Restricted Project
stefanp added inline comments to D83751: [MC] Support .reloc sym+constant, *, *.
Jul 14 2020, 9:11 AM · Restricted Project
stefanp added a comment to D83751: [MC] Support .reloc sym+constant, *, *.

Thank you for putting up a patch in response to your comment.
Once this goes in I'll rebase D79625 on top of it and that patch should become a lot smaller.

Jul 14 2020, 9:09 AM · Restricted Project

Jul 13 2020

stefanp updated the diff for D79625: [PowerPC] Extend .reloc directive on PowerPC.

Fixed a couple of spacing nits.

Jul 13 2020, 11:57 AM · Restricted Project
stefanp added inline comments to D79625: [PowerPC] Extend .reloc directive on PowerPC.
Jul 13 2020, 11:55 AM · Restricted Project