Page MenuHomePhabricator
People stefanp

stefanp (Stefan Pintilie)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2017, 8:02 AM (266 w, 2 d)

Recent Activity
View All

Wed, Jun 29

stefanp committed rG9c860598546c: Fix the eh-filter.ll test. (authored by stefanp).
Fix the eh-filter.ll test.
Wed, Jun 29, 2:15 PM · Restricted Project, Restricted Project
stefanp committed rGe50a8c8435e0: [GlobalMerge] Ensure that the MustKeepGlobalVariables has all globals from each… (authored by stefanp).
[GlobalMerge] Ensure that the MustKeepGlobalVariables has all globals from each…
Wed, Jun 29, 1:56 PM · Restricted Project, Restricted Project
stefanp closed D128287: [GlobalMerge] Ensure that the MustKeepGlobalVariables has all globals from each landingpad clause..
Wed, Jun 29, 1:55 PM · Restricted Project, Restricted Project
stefanp updated the diff for D128287: [GlobalMerge] Ensure that the MustKeepGlobalVariables has all globals from each landingpad clause..

Rebased to top of trunk.
Removed the extra space.

Wed, Jun 29, 1:54 PM · Restricted Project, Restricted Project

Wed, Jun 22

stefanp added reviewers for D128287: [GlobalMerge] Ensure that the MustKeepGlobalVariables has all globals from each landingpad clause.: scui, t.p.northover.
Wed, Jun 22, 11:07 AM · Restricted Project, Restricted Project

Tue, Jun 21

stefanp added reviewers for D128287: [GlobalMerge] Ensure that the MustKeepGlobalVariables has all globals from each landingpad clause.: amyk, Restricted Project, lattner.
Tue, Jun 21, 10:00 AM · Restricted Project, Restricted Project
stefanp requested review of D128287: [GlobalMerge] Ensure that the MustKeepGlobalVariables has all globals from each landingpad clause..
Tue, Jun 21, 9:56 AM · Restricted Project, Restricted Project

Wed, Jun 15

stefanp accepted D127309: [PowerPC] emit VSX instructions instead of VMX instructions for vector loads and stores.

LGTM

Wed, Jun 15, 9:24 AM · Restricted Project, Restricted Project

Tue, Jun 14

stefanp committed rG263f1b2f5df7: [PowerPC] Fix combine step for shufflevector. (authored by stefanp).
[PowerPC] Fix combine step for shufflevector.
Tue, Jun 14, 9:31 AM · Restricted Project, Restricted Project
stefanp closed D127439: [PowerPC] Fix combine step for shufflevector..
Tue, Jun 14, 9:31 AM · Restricted Project, Restricted Project
stefanp updated the diff for D127439: [PowerPC] Fix combine step for shufflevector..

And, I didn't see the follow up reply from Nemanja.
Okay. I've added the test back.

Tue, Jun 14, 9:30 AM · Restricted Project, Restricted Project
stefanp updated the diff for D127439: [PowerPC] Fix combine step for shufflevector..

Removed 32 bit LE test.
Rebased to top of main branch.

Tue, Jun 14, 7:58 AM · Restricted Project, Restricted Project

Mon, Jun 13

stefanp updated the diff for D127439: [PowerPC] Fix combine step for shufflevector..

Updated test case to include 32 bit as well as 64 bit tests.
I did check and the issue can been seen for both 32 bit and 64 bit.

Mon, Jun 13, 2:37 PM · Restricted Project, Restricted Project

Thu, Jun 9

stefanp updated the diff for D127439: [PowerPC] Fix combine step for shufflevector..

Added test case.

Thu, Jun 9, 3:07 PM · Restricted Project, Restricted Project
stefanp added reviewers for D127439: [PowerPC] Fix combine step for shufflevector.: ZarkoCA, Restricted Project.
Thu, Jun 9, 1:51 PM · Restricted Project, Restricted Project
stefanp requested review of D127439: [PowerPC] Fix combine step for shufflevector..
Thu, Jun 9, 1:50 PM · Restricted Project, Restricted Project

May 31 2022

stefanp added inline comments to D40554: [PowerPC] Fix bugs in sign-/zero-extension elimination.
May 31 2022, 11:10 AM · Restricted Project, Restricted Project
stefanp updated the diff for D40554: [PowerPC] Fix bugs in sign-/zero-extension elimination.

Rebased the patch to top of main branch.
Updated a couple of typos.
Moved a check earlier in the function.

May 31 2022, 11:10 AM · Restricted Project, Restricted Project

May 26 2022

stefanp committed rG610eb39c685c: [PowerPC][Future] Add an ISA Future to go with mcpu=future. (authored by stefanp).
[PowerPC][Future] Add an ISA Future to go with mcpu=future.
May 26 2022, 7:20 AM · Restricted Project, Restricted Project
stefanp closed D126075: [PowerPC][Future] Add an ISA Future to go with mcpu=future..
May 26 2022, 7:20 AM · Restricted Project, Restricted Project

May 20 2022

stefanp added a reviewer for D126075: [PowerPC][Future] Add an ISA Future to go with mcpu=future.: Restricted Project.
May 20 2022, 9:08 AM · Restricted Project, Restricted Project
stefanp requested review of D126075: [PowerPC][Future] Add an ISA Future to go with mcpu=future..
May 20 2022, 9:03 AM · Restricted Project, Restricted Project

May 19 2022

stefanp updated the diff for D40554: [PowerPC] Fix bugs in sign-/zero-extension elimination.

Rebased to top of main branch.

May 19 2022, 1:41 PM · Restricted Project, Restricted Project

Apr 29 2022

stefanp committed rGf685bce8080c: [PowerPC][NFC] Add a function to determine if a call needs to be NOTOC. (authored by stefanp).
[PowerPC][NFC] Add a function to determine if a call needs to be NOTOC.
Apr 29 2022, 6:36 AM · Restricted Project, Restricted Project
stefanp closed D124415: [PowerPC][NFC] Add a function to determine if a call needs to be NOTOC..
Apr 29 2022, 6:36 AM · Restricted Project, Restricted Project
stefanp updated the diff for D124415: [PowerPC][NFC] Add a function to determine if a call needs to be NOTOC..

Rebased patch to top of trunk.
Added the additional #ifndef NDEBUG.

Apr 29 2022, 6:33 AM · Restricted Project, Restricted Project

Apr 25 2022

stefanp added reviewers for D124415: [PowerPC][NFC] Add a function to determine if a call needs to be NOTOC.: lei, nemanjai, jsji, Restricted Project.
Apr 25 2022, 1:38 PM · Restricted Project, Restricted Project
stefanp requested review of D124415: [PowerPC][NFC] Add a function to determine if a call needs to be NOTOC..
Apr 25 2022, 1:37 PM · Restricted Project, Restricted Project

Apr 18 2022

stefanp committed rGef34442232fb: [NFC][PowerPC] Move the Regsiter Operands for PowerPC into PPCRegisterInfo.td (authored by stefanp).
[NFC][PowerPC] Move the Regsiter Operands for PowerPC into PPCRegisterInfo.td
Apr 18 2022, 12:50 PM · Restricted Project, Restricted Project
stefanp closed D123543: [NFC][PowerPC] Move the Regsiter Operands for PowerPC into PPCRegisterInfo.td.
Apr 18 2022, 12:50 PM · Restricted Project, Restricted Project
stefanp updated the diff for D123543: [NFC][PowerPC] Move the Regsiter Operands for PowerPC into PPCRegisterInfo.td.

Rebased to top of main branch.

Apr 18 2022, 12:36 PM · Restricted Project, Restricted Project
stefanp committed rGbc9916fff245: [NFC][PowerPC] Style and ordering changes for PPCInstrP10.td (authored by stefanp).
[NFC][PowerPC] Style and ordering changes for PPCInstrP10.td
Apr 18 2022, 11:29 AM · Restricted Project, Restricted Project
stefanp updated the diff for D123543: [NFC][PowerPC] Move the Regsiter Operands for PowerPC into PPCRegisterInfo.td.

Rebased patch to top of master.

Apr 18 2022, 8:04 AM · Restricted Project, Restricted Project
stefanp updated the diff for D40554: [PowerPC] Fix bugs in sign-/zero-extension elimination.

Rebased the patch to top of trunk again.

Apr 18 2022, 7:22 AM · Restricted Project, Restricted Project

Apr 14 2022

stefanp updated the diff for D40554: [PowerPC] Fix bugs in sign-/zero-extension elimination.

Added two new flags ZExt32To64 and SExt32To64.
Marked instructions that zero extend or sign extend in the TD files with those
flags.
Fixed a few comments as well.
Tried to extract an if statement to reduce the indentation a little.

Apr 14 2022, 1:57 PM · Restricted Project, Restricted Project

Apr 13 2022

stefanp requested review of D40554: [PowerPC] Fix bugs in sign-/zero-extension elimination.

Fairly significant changes have been made since I took over this patch and I would prefer to have another set of eyes take a look.
I will request a new review.

Apr 13 2022, 6:34 AM · Restricted Project, Restricted Project
stefanp updated the diff for D40554: [PowerPC] Fix bugs in sign-/zero-extension elimination.

Rebased patch to top of trunk.

Apr 13 2022, 6:30 AM · Restricted Project, Restricted Project

Apr 11 2022

stefanp planned changes to D40554: [PowerPC] Fix bugs in sign-/zero-extension elimination.

Need to rebase this patch again. Will request another review once I have done that.

Apr 11 2022, 1:59 PM · Restricted Project, Restricted Project
stefanp added a reviewer for D123543: [NFC][PowerPC] Move the Regsiter Operands for PowerPC into PPCRegisterInfo.td: Restricted Project.
Apr 11 2022, 1:36 PM · Restricted Project, Restricted Project
stefanp requested review of D123543: [NFC][PowerPC] Move the Regsiter Operands for PowerPC into PPCRegisterInfo.td.
Apr 11 2022, 1:36 PM · Restricted Project, Restricted Project

Mar 31 2022

stefanp committed rG585c85abe545: [PowerPC] Fix lowering of byval parameters for sizes greater than 8 bytes. (authored by stefanp).
[PowerPC] Fix lowering of byval parameters for sizes greater than 8 bytes.
Mar 31 2022, 1:13 PM · Restricted Project, Restricted Project
stefanp closed D121430: [PowerPC] Fix lowering of byval parameters for sizes greater than 8 bytes..
Mar 31 2022, 1:12 PM · Restricted Project, Restricted Project
stefanp updated the diff for D121430: [PowerPC] Fix lowering of byval parameters for sizes greater than 8 bytes..

Addressed comment and rebased to top of main.

Mar 31 2022, 1:08 PM · Restricted Project, Restricted Project
stefanp committed rG2e55bc9f3c23: [PowerPC] Set the special DSCR with a compiler option. (authored by stefanp).
[PowerPC] Set the special DSCR with a compiler option.
Mar 31 2022, 12:06 PM · Restricted Project, Restricted Project
stefanp closed D117013: [PowerPC] Set the special DSCR with a compiler option..
Mar 31 2022, 12:06 PM · Restricted Project, Restricted Project
stefanp updated the diff for D117013: [PowerPC] Set the special DSCR with a compiler option..

Addressed comments and rebased patch to top of main.

Mar 31 2022, 12:03 PM · Restricted Project, Restricted Project

Mar 24 2022

stefanp updated the diff for D121430: [PowerPC] Fix lowering of byval parameters for sizes greater than 8 bytes..

Rebased the patch to top of main branch.

Mar 24 2022, 8:40 PM · Restricted Project, Restricted Project

Mar 23 2022

stefanp committed rG2c25c65cdce2: [PowerPC] The BL8_NOTOC_RM instruction needs to produce a notoc relocation. (authored by stefanp).
[PowerPC] The BL8_NOTOC_RM instruction needs to produce a notoc relocation.
Mar 23 2022, 5:01 PM · Restricted Project
stefanp closed D122012: [PowerPC] The BL8_NOTOC_RM instruction needs to produce a notoc relocation..
Mar 23 2022, 5:01 PM · Restricted Project, Restricted Project

Mar 21 2022

stefanp committed rG4275d7e65aa1: [PowerPC][NFC] Add test case for byval argument passing (authored by stefanp).
[PowerPC][NFC] Add test case for byval argument passing
Mar 21 2022, 1:26 PM · Restricted Project

Mar 18 2022

stefanp added a reviewer for D122012: [PowerPC] The BL8_NOTOC_RM instruction needs to produce a notoc relocation.: Restricted Project.
Mar 18 2022, 8:28 AM · Restricted Project, Restricted Project
stefanp requested review of D122012: [PowerPC] The BL8_NOTOC_RM instruction needs to produce a notoc relocation..
Mar 18 2022, 8:27 AM · Restricted Project, Restricted Project

Mar 15 2022

stefanp committed rG78406ac8985b: [PowerPC][P10] Add Vector pair calling convention (authored by stefanp).
[PowerPC][P10] Add Vector pair calling convention
Mar 15 2022, 12:09 PM · Restricted Project
stefanp closed D117225: [PowerPC][P10] Add Vector pair calling convention.
Mar 15 2022, 12:08 PM · Restricted Project, Restricted Project
stefanp updated the diff for D117225: [PowerPC][P10] Add Vector pair calling convention.

Rebased patch to top of trunk.
Fixed comment as per review.

Mar 15 2022, 12:07 PM · Restricted Project, Restricted Project

Mar 10 2022

stefanp added a reviewer for D121430: [PowerPC] Fix lowering of byval parameters for sizes greater than 8 bytes.: Restricted Project.
Mar 10 2022, 5:30 PM · Restricted Project, Restricted Project
stefanp requested review of D121430: [PowerPC] Fix lowering of byval parameters for sizes greater than 8 bytes..
Mar 10 2022, 5:28 PM · Restricted Project, Restricted Project

Mar 1 2022

stefanp committed rGa84a8c937ba0: [PowerPC] Remove redundant MMA patterns. (authored by stefanp).
[PowerPC] Remove redundant MMA patterns.
Mar 1 2022, 7:13 AM
stefanp closed D120680: [PowerPC] Remove redundant MMA patterns..
Mar 1 2022, 7:13 AM · Restricted Project

Feb 28 2022

stefanp added a reviewer for D120680: [PowerPC] Remove redundant MMA patterns.: Restricted Project.
Feb 28 2022, 1:46 PM · Restricted Project
stefanp requested review of D120680: [PowerPC] Remove redundant MMA patterns..
Feb 28 2022, 1:36 PM · Restricted Project

Feb 25 2022

stefanp committed rG0625aed2fcfb: [PowerPC][NFC] Split out the MMA instructions from the P10 instructions. (authored by stefanp).
[PowerPC][NFC] Split out the MMA instructions from the P10 instructions.
Feb 25 2022, 9:41 AM
stefanp closed D120515: [PowerPC][NFC] Split out the MMA instructions from the P10 instructions..
Feb 25 2022, 9:41 AM · Restricted Project
stefanp committed rG4fbe60fd13a6: [PowerPC][NFC] Add file info and license that was missing from this file. (authored by stefanp).
[PowerPC][NFC] Add file info and license that was missing from this file.
Feb 25 2022, 8:28 AM
stefanp closed D120530: [PowerPC][NFC] Add file info and license that was missing from this file..
Feb 25 2022, 8:28 AM · Restricted Project
stefanp committed rG96918f2af67f: [libcxx] String format class marked as packed (authored by stefanp).
[libcxx] String format class marked as packed
Feb 25 2022, 8:07 AM
stefanp closed D119567: [libcxx] String format class marked as packed.
Feb 25 2022, 8:07 AM · Restricted Project, Restricted Project
stefanp committed rG9f5f08476e89: [libcxx] Fix the type in __estimate_column_width (authored by stefanp).
[libcxx] Fix the type in __estimate_column_width
Feb 25 2022, 7:05 AM
stefanp closed D119770: [libcxx] Fix the type in __estimate_column_width.
Feb 25 2022, 7:05 AM · Restricted Project

Feb 24 2022

stefanp added a reviewer for D120530: [PowerPC][NFC] Add file info and license that was missing from this file.: Restricted Project.
Feb 24 2022, 6:10 PM · Restricted Project
stefanp requested review of D120530: [PowerPC][NFC] Add file info and license that was missing from this file..
Feb 24 2022, 6:09 PM · Restricted Project
stefanp updated the diff for D120515: [PowerPC][NFC] Split out the MMA instructions from the P10 instructions..

Moved the include to PPCInstrInfo.td.

Feb 24 2022, 2:09 PM · Restricted Project
stefanp added a reviewer for D120515: [PowerPC][NFC] Split out the MMA instructions from the P10 instructions.: Restricted Project.
Feb 24 2022, 1:35 PM · Restricted Project
stefanp requested review of D120515: [PowerPC][NFC] Split out the MMA instructions from the P10 instructions..
Feb 24 2022, 1:35 PM · Restricted Project
stefanp added a comment to D119770: [libcxx] Fix the type in __estimate_column_width.

Gentle ping: libc++

Feb 24 2022, 1:30 PM · Restricted Project

Feb 23 2022

stefanp committed rGb3e63ee2e5bd: [NFC][PowerPC] Fix the check-cpu.ll test case. (authored by stefanp).
[NFC][PowerPC] Fix the check-cpu.ll test case.
Feb 23 2022, 12:10 PM
stefanp closed D120349: [NFC][PowerPC] Fix the check-cpu.ll test case..
Feb 23 2022, 12:09 PM · Restricted Project
stefanp committed rGeb1c5a9862b6: [PowerPC] Add the Power10 LXVKQ instrution. (authored by stefanp).
[PowerPC] Add the Power10 LXVKQ instrution.
Feb 23 2022, 6:49 AM
stefanp closed D117507: [PowerPC] Add the Power10 LXVKQ instrution..
Feb 23 2022, 6:49 AM · Restricted Project
stefanp updated the diff for D117507: [PowerPC] Add the Power10 LXVKQ instrution..

Rebased the patch.
Moved the def for LXVKQ lower down.

Feb 23 2022, 6:14 AM · Restricted Project

Feb 22 2022

stefanp added a reviewer for D120349: [NFC][PowerPC] Fix the check-cpu.ll test case.: Restricted Project.
Feb 22 2022, 12:54 PM · Restricted Project
stefanp requested review of D120349: [NFC][PowerPC] Fix the check-cpu.ll test case..
Feb 22 2022, 12:54 PM · Restricted Project

Feb 18 2022

stefanp updated the diff for D119567: [libcxx] String format class marked as packed.

Updated to use _Pragma pack instead of using the attribute.
Also, made the change only for AIX.

Feb 18 2022, 2:35 PM · Restricted Project, Restricted Project
stefanp updated the diff for D40554: [PowerPC] Fix bugs in sign-/zero-extension elimination.

Rebased this patch to the top of main and retested.

Feb 18 2022, 10:20 AM · Restricted Project, Restricted Project

Feb 15 2022

stefanp abandoned D119773: [PowerPC][LLD] Fix linking weak hidden callees..

MaskRay has fixed the issue with https://reviews.llvm.org/D119787

Feb 15 2022, 12:06 PM · Restricted Project
stefanp accepted D119787: [ELF][PPC64] Fix assertion failure for branches to hidden undefined weak for -no-pie.

I checked and this fixes the issue we were seeing.
Thank you for fixing this!

Feb 15 2022, 12:02 PM · Restricted Project, Restricted Project
stefanp updated the summary of D119567: [libcxx] String format class marked as packed.
Feb 15 2022, 6:04 AM · Restricted Project, Restricted Project
stefanp updated the diff for D119567: [libcxx] String format class marked as packed.

Moved the attribute to the top of the class.
Typo in the comment.

Feb 15 2022, 6:02 AM · Restricted Project, Restricted Project

Feb 14 2022

stefanp added a comment to D119567: [libcxx] String format class marked as packed.
In D119567#3321211, @ldionne wrote:

You have a typo in your commit message (becuase). Generally LGTM with a small style comment. I'd also like to better understand the motivation before shipping this: can someone explain why/how the tests currently depend on the class being packed?

Feb 14 2022, 4:11 PM · Restricted Project, Restricted Project
stefanp committed rGa601db30c6a2: [PowerPC] Remove the LDMX instruction. (authored by stefanp).
[PowerPC] Remove the LDMX instruction.
Feb 14 2022, 3:04 PM
stefanp closed D118074: [PowerPC] Remove the LDMX instruction..
Feb 14 2022, 3:03 PM · Restricted Project
stefanp added a reviewer for D119773: [PowerPC][LLD] Fix linking weak hidden callees.: Restricted Project.
Feb 14 2022, 1:22 PM · Restricted Project
stefanp requested review of D119773: [PowerPC][LLD] Fix linking weak hidden callees..
Feb 14 2022, 1:21 PM · Restricted Project
stefanp added a reviewer for D119770: [libcxx] Fix the type in __estimate_column_width: Restricted Project.
Feb 14 2022, 1:03 PM · Restricted Project
stefanp requested review of D119770: [libcxx] Fix the type in __estimate_column_width.
Feb 14 2022, 1:02 PM · Restricted Project
stefanp updated the diff for D119567: [libcxx] String format class marked as packed.

I've updated the packed attribute and added the under-under for it.

Feb 14 2022, 11:57 AM · Restricted Project, Restricted Project

Feb 11 2022

stefanp added reviewers for D119567: [libcxx] String format class marked as packed: Restricted Project, Mordante.
Feb 11 2022, 11:06 AM · Restricted Project, Restricted Project
stefanp requested review of D119567: [libcxx] String format class marked as packed.
Feb 11 2022, 10:59 AM · Restricted Project, Restricted Project

Feb 8 2022

stefanp added a comment to D101470: [XCOFF][AIX] Peephole optimization in 32-bit TocData transformation.

Note that I have reviewed this patch along with https://reviews.llvm.org/D118718. The following comment applies to both patches.

Feb 8 2022, 10:49 AM · Restricted Project, Restricted Project

Jan 24 2022

stefanp added a reviewer for D118074: [PowerPC] Remove the LDMX instruction.: Restricted Project.
Jan 24 2022, 1:27 PM · Restricted Project