- User Since
- May 29 2017, 8:02 AM (72 w, 1 d)
Wed, Oct 10
I'm sorry it took so long for me to look at this review.
Fri, Oct 5
Addressed review comments.
Thu, Oct 4
Removed the custom PPCISD node and it simplified the patch considerably.
Mon, Oct 1
Address Review Comments
Fri, Sep 28
Moved condition to the correct location and added a test case.
Mon, Sep 24
Sep 12 2018
Sep 10 2018
Update patch based on reviewer comments.
Aug 27 2018
I'm not 100% sure if we can remove the default option -funwind-tables for x86.
I know that using -funwind-tables prevents (or hides) this issue but it may be required for another reason that this fix does not cover. I don't actually know what the initial intention was when that default was added.
I think that someone on the x86 side would be a better judge of this.
Aug 24 2018
Aug 22 2018
Sorry about that. I should have added the test cases earlier.
Aug 20 2018
Added test case.
Address reviewers comments.
Determined this is not the correct way to solve this problem.
Going to abandon this change.
Aug 17 2018
GCC does call the exception handler correctly for this example. However, it does not (at least not that I can tell) have a default option like the one llvm uses -funwind-tables.
Aug 8 2018
Jul 19 2018
Jul 18 2018
Jul 12 2018
Jul 10 2018
We have determined that we do not require these builtin names.
I looked into the naming of those builtins.
GCC does document the overloaded versions of those functions:
scalar_extract_exp for __builtin_vsx_scalar_extract_expq
scalar_insert_exp for __builtin_vsx_scalar_insert_exp_qp
Jul 9 2018
Jul 5 2018
Added handling for the select f128.
Unlike the double type, the __float128 type cannot not use the fsel instruction but we should still expand it to something that functions correctly.
Committed in revision: rL336295
Jul 4 2018
Hi Hal, Eric,
Jun 29 2018
Jun 28 2018
Fixed comments according to previous review.
Jun 27 2018
Updated the comments.
Sorry.. I should have caught them initially.
Sorry for the late reply. I have been distracted with something else for a little while.
I have added the patch to remove needsAggressiveScheduling() here:
Jun 25 2018
Jun 23 2018
Jun 22 2018
Jun 20 2018
Jun 19 2018
Fixed test case command.
Jun 18 2018
Jun 15 2018
Jun 14 2018
Jun 13 2018
Jun 12 2018
Jun 11 2018
Updated the test case to use clang cc1 instead of just clang.
May 31 2018
Added Chris Lattner as a reviewer in case I did something silly in the target indep code.
Fixed some of the style issues.
May 30 2018
May 22 2018