- User Since
- May 29 2017, 8:02 AM (54 w, 6 d)
Fri, Jun 15
Thu, Jun 14
Wed, Jun 13
Tue, Jun 12
Mon, Jun 11
Updated the test case to use clang cc1 instead of just clang.
Thu, May 31
Added Chris Lattner as a reviewer in case I did something silly in the target indep code.
Fixed some of the style issues.
Wed, May 30
Tue, May 22
May 17 2018
Modifications based on review comments.
May 16 2018
Ran a series of tests on this patch.
Overall the results are positive. I'm going to list the degradations.
May 3 2018
Address comments from previous review.
Apr 20 2018
Apr 16 2018
I've updated the negative frame indices to use isFixedObjectIndex which is cleaner.
Committed in rL330117.
Closing this item.
Apr 13 2018
Apr 4 2018
Mar 28 2018
After some code cleanup that was required for requiresFrameIndexScavenging here is the new version of this patch.
It should take into consideration all of the reviewer's comments.
What is your opinion on this? Should I be adding the #if .. and #endif? Does it matter?
Mar 27 2018
Mar 26 2018
Mar 20 2018
Implemented the cleanup for the loads as well.
Addressed comments from the reviewer.
Mar 19 2018
Added the XFormMemOp flag to the td files for the instructions the require it. This flag indicates that this instructions is a memory instruction and that it is an X-Form instruction.
Used a script to compare the modifications against the ISA to make sure that the correct instructions have the flag set.
Mar 9 2018
I've reverted the change in rL327143.
Would you like me to pull this change out and fix the bug before I put it back in?
Mar 8 2018
With the patch rL327021 we should now be able to mark Power 9 as complete.
Mar 7 2018
Mar 5 2018
Mar 2 2018
Mar 1 2018
Thank you for the very quick review! :)
I'll add more comments to the files as I work on them over the next couple of days.
Feb 28 2018
Feb 23 2018
I also learned that we accept regexes here when I started doing this a couple of days ago. :)
Feb 22 2018
Feb 12 2018
Addressed comments from reviewer and removed work that was not really related to this patch.
Will split out the work that was not really related into a separate patch.
Feb 8 2018
Feb 5 2018
Fixed the issue where we could have assigned a VSR register to an instruction that requires a VR register.
Feb 1 2018
Modified the tuning formula to take into consideration the idea that we shouldn’t be enlarging the class of equal items.
After looking into the LSR algorithm we discovered that if we enlarge the space of equal items we do not favor unchanged code as we had initially desired.
Therefore, this change does almost exactly what the default isLSRCostLess function does (from the base class) except that number of instructions has been added as the most important category to compare.
Jan 31 2018
Fixed the issues mentioned in previous comments.
Jan 26 2018
Jan 16 2018
Yes that is correct. We are increasing the size of the class of equal elements.
The idea is that LSR will only replace one formula with another if it finds something with a lower cost. By returning false more often LSR will do fewer replacements and that is what we mean by more conservative. Maybe that's not really clear in the comment and I can update the comment to make it more clear.
Jan 12 2018
I'm going to start looking at this patch now.
Jan 9 2018
Jan 8 2018
Jan 5 2018
Yes, we are hand scheduling the prologue and epilogue.
However, this is a little more than moving instructions around. Since we are moving the stack pointer update instruction, spills that use the stack pointer may have to be updated with new offsets.
Fixed a typo and a missing set of brackets.
Jan 4 2018
Dec 20 2017
Thank you for the approval. After doing a bit more investigation I realized that the condition should always be true. Before calling this function we always check that this is a return block. Therefore, I've change it slightly so that the guard is now an assert.
Dec 18 2017
Dec 6 2017
Thank you for your comments.
Nov 22 2017
Nov 9 2017
Nov 8 2017
Oct 30 2017
Oct 24 2017
Oct 23 2017
Sorry for the late reply Eric. I was on vacation Thursday and Friday last week.