stefanp (Stefan Pintilie)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2017, 8:02 AM (63 w, 2 d)

Recent Activity

Wed, Aug 8

stefanp commandeered D49507: [Power9] Add __float128 support in the backend for bitcast to a i128.
Wed, Aug 8, 11:00 AM

Thu, Jul 19

stefanp committed rL337488: [Power9] Code Cleanup - Remove needsAggressiveScheduling().
[Power9] Code Cleanup - Remove needsAggressiveScheduling()
Thu, Jul 19, 12:39 PM
stefanp closed D48663: [Power9] Code Cleanup - Remove needsAggressiveScheduling().
Thu, Jul 19, 12:39 PM

Wed, Jul 18

stefanp created D49507: [Power9] Add __float128 support in the backend for bitcast to a i128.
Wed, Jul 18, 1:20 PM

Jul 12 2018

stefanp committed rL336940: [PowerPC] [NFC] Update __float128 tests.
[PowerPC] [NFC] Update __float128 tests
Jul 12 2018, 1:24 PM

Jul 10 2018

stefanp abandoned D48526: [Power9] Add six __float128 builtins found in gcc.

We have determined that we do not require these builtin names.

Jul 10 2018, 6:55 PM
stefanp committed rL336754: [Power9] Add remaining __flaot128 builtin support for FMA round to odd.
[Power9] Add remaining __flaot128 builtin support for FMA round to odd
Jul 10 2018, 6:47 PM
stefanp closed D48218: [Power9] Add remaining __flaot128 builtin support for FMA round to odd.
Jul 10 2018, 6:47 PM
stefanp added a comment to D48185: [Power9] [LLVM] Add __float128 exponent GET and SET builtins.

I looked into the naming of those builtins.
GCC does document the overloaded versions of those functions:
scalar_extract_exp for __builtin_vsx_scalar_extract_expq
scalar_insert_exp for __builtin_vsx_scalar_insert_exp_qp

Jul 10 2018, 10:17 AM

Jul 9 2018

stefanp committed rL336601: [Power9] Add __float128 builtins for Rounding Operations.
[Power9] Add __float128 builtins for Rounding Operations
Jul 9 2018, 1:43 PM
stefanp closed D48415: [Power9] Add __float128 builtins for Rounding Operations.
Jul 9 2018, 1:43 PM
stefanp committed rL336596: [Power9] [CLANG] Add __float128 support for trunc to double round to odd.
[Power9] [CLANG] Add __float128 support for trunc to double round to odd
Jul 9 2018, 1:15 PM
stefanp committed rC336596: [Power9] [CLANG] Add __float128 support for trunc to double round to odd.
[Power9] [CLANG] Add __float128 support for trunc to double round to odd
Jul 9 2018, 1:14 PM
stefanp closed D48482: [Power9] [CLANG] Add __float128 support for trunc to double round to odd.
Jul 9 2018, 1:14 PM
stefanp committed rL336595: [Power9] [LLVM] Add __float128 support for trunc to double round to odd.
[Power9] [LLVM] Add __float128 support for trunc to double round to odd
Jul 9 2018, 1:14 PM
stefanp closed D48483: [Power9] [LLVM] Add __float128 support for trunc to double round to odd.
Jul 9 2018, 1:14 PM
stefanp committed rC336579: [Power9] Add __float128 builtins for Round To Odd.
[Power9] Add __float128 builtins for Round To Odd
Jul 9 2018, 11:55 AM
stefanp committed rL336579: [Power9] Add __float128 builtins for Round To Odd.
[Power9] Add __float128 builtins for Round To Odd
Jul 9 2018, 11:55 AM
stefanp closed D47548: [Power9] Add __float128 builtins for Round To Odd.
Jul 9 2018, 11:55 AM
stefanp closed D47548: [Power9] Add __float128 builtins for Round To Odd.
Jul 9 2018, 11:55 AM
stefanp committed rL336578: [Power9] Add __float128 builtins for Round To Odd.
[Power9] Add __float128 builtins for Round To Odd
Jul 9 2018, 11:55 AM
stefanp closed D47550: [Power9] Add __float128 builtins for Round To Odd.
Jul 9 2018, 11:55 AM
stefanp committed rL336548: [Power9] Add __float128 support for compare operations.
[Power9] Add __float128 support for compare operations
Jul 9 2018, 6:41 AM
stefanp closed D48294: [Power9] Add __float128 support for compare operations.
Jul 9 2018, 6:41 AM

Jul 5 2018

stefanp committed rL336406: [Power9] Add __float128 library call for frem.
[Power9] Add __float128 library call for frem
Jul 5 2018, 7:52 PM
stefanp closed D48552: [Power9] Add __float128 library call for frem.
Jul 5 2018, 7:51 PM
stefanp updated the diff for D48294: [Power9] Add __float128 support for compare operations.

Added handling for the select f128.
Unlike the double type, the __float128 type cannot not use the fsel instruction but we should still expand it to something that functions correctly.

Jul 5 2018, 12:38 PM
stefanp closed D45265: [PowerPC] Replace the Post RA List Scheduler with the Machine Scheduler.

Done.
Committed in revision: rL336295

Jul 5 2018, 7:00 AM

Jul 4 2018

stefanp committed rL336295: [PowerPC] Replace the Post RA List Scheduler with the Machine Scheduler.
[PowerPC] Replace the Post RA List Scheduler with the Machine Scheduler
Jul 4 2018, 11:59 AM
stefanp added a comment to D48663: [Power9] Code Cleanup - Remove needsAggressiveScheduling().

Hi Hal, Eric,

Jul 4 2018, 10:48 AM

Jun 29 2018

stefanp added a comment to D48663: [Power9] Code Cleanup - Remove needsAggressiveScheduling().

Hi Eric,

Jun 29 2018, 6:43 AM

Jun 28 2018

stefanp updated the diff for D48663: [Power9] Code Cleanup - Remove needsAggressiveScheduling().

Fixed comments according to previous review.

Jun 28 2018, 12:33 PM

Jun 27 2018

stefanp updated the diff for D48663: [Power9] Code Cleanup - Remove needsAggressiveScheduling().

Updated the comments.
Sorry.. I should have caught them initially.

Jun 27 2018, 1:34 PM
stefanp added a comment to D45265: [PowerPC] Replace the Post RA List Scheduler with the Machine Scheduler.

Sorry for the late reply. I have been distracted with something else for a little while.
I have added the patch to remove needsAggressiveScheduling() here:
https://reviews.llvm.org/D48663

Jun 27 2018, 11:09 AM
stefanp created D48663: [Power9] Code Cleanup - Remove needsAggressiveScheduling().
Jun 27 2018, 11:06 AM

Jun 25 2018

stefanp added a dependency for D48552: [Power9] Add __float128 library call for frem: D47552: [Power9] Implement float128 parameter passing and return values.
Jun 25 2018, 10:36 AM
stefanp added a dependent revision for D47552: [Power9] Implement float128 parameter passing and return values: D48552: [Power9] Add __float128 library call for frem.
Jun 25 2018, 10:36 AM
stefanp created D48552: [Power9] Add __float128 library call for frem.
Jun 25 2018, 10:35 AM

Jun 23 2018

stefanp created D48526: [Power9] Add six __float128 builtins found in gcc.
Jun 23 2018, 5:49 PM

Jun 22 2018

stefanp created D48483: [Power9] [LLVM] Add __float128 support for trunc to double round to odd.
Jun 22 2018, 6:49 AM
stefanp created D48482: [Power9] [CLANG] Add __float128 support for trunc to double round to odd.
Jun 22 2018, 6:47 AM

Jun 20 2018

stefanp created D48415: [Power9] Add __float128 builtins for Rounding Operations.
Jun 20 2018, 7:32 PM

Jun 19 2018

stefanp updated the diff for D48294: [Power9] Add __float128 support for compare operations.

Fixed test case command.

Jun 19 2018, 1:02 PM

Jun 18 2018

stefanp created D48294: [Power9] Add __float128 support for compare operations.
Jun 18 2018, 12:42 PM

Jun 15 2018

stefanp added a dependency for D48218: [Power9] Add remaining __flaot128 builtin support for FMA round to odd: D47550: [Power9] Add __float128 builtins for Round To Odd.
Jun 15 2018, 7:00 AM
stefanp added a dependent revision for D47550: [Power9] Add __float128 builtins for Round To Odd: D48218: [Power9] Add remaining __flaot128 builtin support for FMA round to odd.
Jun 15 2018, 7:00 AM
stefanp created D48218: [Power9] Add remaining __flaot128 builtin support for FMA round to odd.
Jun 15 2018, 7:00 AM

Jun 14 2018

stefanp added a dependency for D48185: [Power9] [LLVM] Add __float128 exponent GET and SET builtins: D47550: [Power9] Add __float128 builtins for Round To Odd.
Jun 14 2018, 12:02 PM
stefanp added a dependent revision for D47550: [Power9] Add __float128 builtins for Round To Odd: D48185: [Power9] [LLVM] Add __float128 exponent GET and SET builtins.
Jun 14 2018, 12:02 PM
stefanp added a dependency for D48184: [Power9] [CLANG] Add __float128 exponent GET and SET builtins: D47550: [Power9] Add __float128 builtins for Round To Odd.
Jun 14 2018, 12:01 PM
stefanp added a dependent revision for D47550: [Power9] Add __float128 builtins for Round To Odd: D48184: [Power9] [CLANG] Add __float128 exponent GET and SET builtins.
Jun 14 2018, 12:01 PM
stefanp created D48185: [Power9] [LLVM] Add __float128 exponent GET and SET builtins.
Jun 14 2018, 11:58 AM
stefanp created D48184: [Power9] [CLANG] Add __float128 exponent GET and SET builtins.
Jun 14 2018, 11:56 AM

Jun 13 2018

stefanp committed rL334613: [PowerPC] The __float128 type should only be available on Power9.
[PowerPC] The __float128 type should only be available on Power9
Jun 13 2018, 9:09 AM
stefanp committed rC334613: [PowerPC] The __float128 type should only be available on Power9.
[PowerPC] The __float128 type should only be available on Power9
Jun 13 2018, 9:09 AM
stefanp closed D48088: [PowerPC] The __float128 type should only be available on Power9.
Jun 13 2018, 9:09 AM

Jun 12 2018

stefanp created D48088: [PowerPC] The __float128 type should only be available on Power9.
Jun 12 2018, 12:06 PM

Jun 11 2018

stefanp updated the diff for D47548: [Power9] Add __float128 builtins for Round To Odd.

Updated the test case to use clang cc1 instead of just clang.

Jun 11 2018, 8:40 AM

May 31 2018

stefanp added a comment to D47550: [Power9] Add __float128 builtins for Round To Odd.

@lattner
Added Chris Lattner as a reviewer in case I did something silly in the target indep code.

May 31 2018, 12:14 PM
stefanp added a reviewer for D47550: [Power9] Add __float128 builtins for Round To Odd: lattner.
May 31 2018, 12:13 PM
stefanp updated the diff for D47550: [Power9] Add __float128 builtins for Round To Odd.

Fixed some of the style issues.

May 31 2018, 12:12 PM
stefanp added a dependent revision for D47550: [Power9] Add __float128 builtins for Round To Odd: D47548: [Power9] Add __float128 builtins for Round To Odd.
May 31 2018, 11:36 AM
stefanp added a dependency for D47548: [Power9] Add __float128 builtins for Round To Odd: D47550: [Power9] Add __float128 builtins for Round To Odd.
May 31 2018, 11:36 AM
stefanp updated the summary of D47550: [Power9] Add __float128 builtins for Round To Odd.
May 31 2018, 11:35 AM

May 30 2018

stefanp created D47550: [Power9] Add __float128 builtins for Round To Odd.
May 30 2018, 11:51 AM
stefanp created D47548: [Power9] Add __float128 builtins for Round To Odd.
May 30 2018, 11:49 AM

May 22 2018

stefanp added a comment to D45265: [PowerPC] Replace the Post RA List Scheduler with the Machine Scheduler.

Hi Eric,

May 22 2018, 10:55 AM

May 17 2018

stefanp updated the diff for D45266: [PowerPC] Add a Memory Latency Mutation to the scheduler.

Modifications based on review comments.

May 17 2018, 10:57 AM

May 16 2018

stefanp requested review of D45265: [PowerPC] Replace the Post RA List Scheduler with the Machine Scheduler.
May 16 2018, 8:26 AM
stefanp added a comment to D45265: [PowerPC] Replace the Post RA List Scheduler with the Machine Scheduler.

Ran a series of tests on this patch.
Overall the results are positive. I'm going to list the degradations.

May 16 2018, 8:25 AM

May 3 2018

stefanp updated the diff for D42590: [PowerPC] Try to move the stack pointer update instruction later in the prologue and earlier in the epilogue (Version 2).

Address comments from previous review.

May 3 2018, 11:12 AM

Apr 20 2018

stefanp added inline comments to D39785: [PowerPC] Remove redundant register copies in late peephole.
Apr 20 2018, 2:01 PM

Apr 16 2018

stefanp updated the diff for D42590: [PowerPC] Try to move the stack pointer update instruction later in the prologue and earlier in the epilogue (Version 2).

I've updated the negative frame indices to use isFixedObjectIndex which is cleaner.

Apr 16 2018, 10:43 AM
stefanp added inline comments to D42590: [PowerPC] Try to move the stack pointer update instruction later in the prologue and earlier in the epilogue (Version 2).
Apr 16 2018, 10:41 AM
stefanp closed D44903: [LatencyPriorityQueue] The LatencyPriorityQueue class is missing the implementation for the dump function.

Committed in rL330117.
Closing this item.

Apr 16 2018, 4:04 AM
stefanp committed rL330117: [LatencyPriorityQueue] The LatencyPriorityQueue class is missing the….
[LatencyPriorityQueue] The LatencyPriorityQueue class is missing the…
Apr 16 2018, 3:26 AM

Apr 13 2018

stefanp committed rL330060: [Power9] Add the TLS store instructions to the Power 9 model.
[Power9] Add the TLS store instructions to the Power 9 model
Apr 13 2018, 12:54 PM

Apr 4 2018

stefanp created D45266: [PowerPC] Add a Memory Latency Mutation to the scheduler.
Apr 4 2018, 9:45 AM
stefanp added a dependent revision for D45265: [PowerPC] Replace the Post RA List Scheduler with the Machine Scheduler: D45266: [PowerPC] Add a Memory Latency Mutation to the scheduler.
Apr 4 2018, 9:45 AM
stefanp created D45265: [PowerPC] Replace the Post RA List Scheduler with the Machine Scheduler.
Apr 4 2018, 9:30 AM

Mar 28 2018

stefanp updated the diff for D42590: [PowerPC] Try to move the stack pointer update instruction later in the prologue and earlier in the epilogue (Version 2).

After some code cleanup that was required for requiresFrameIndexScavenging here is the new version of this patch.
It should take into consideration all of the reviewer's comments.

Mar 28 2018, 11:11 AM
stefanp added a comment to D44903: [LatencyPriorityQueue] The LatencyPriorityQueue class is missing the implementation for the dump function.

@echristo
Hi Eric,
What is your opinion on this? Should I be adding the #if .. and #endif? Does it matter?

Mar 28 2018, 8:08 AM

Mar 27 2018

stefanp committed rL328647: [Power9] Fix the resource list for the COPY instruction..
[Power9] Fix the resource list for the COPY instruction.
Mar 27 2018, 10:54 AM

Mar 26 2018

stefanp created D44903: [LatencyPriorityQueue] The LatencyPriorityQueue class is missing the implementation for the dump function.
Mar 26 2018, 11:29 AM
stefanp committed rL328556: [PowerPC] Infrastructure work. Implement getting the opcode for a spill in one….
[PowerPC] Infrastructure work. Implement getting the opcode for a spill in one…
Mar 26 2018, 10:42 AM
stefanp closed D43086: [PowerPC] Infrastructure work. Implement getting the opcode for a spill in one place..
Mar 26 2018, 10:42 AM
stefanp added inline comments to D43086: [PowerPC] Infrastructure work. Implement getting the opcode for a spill in one place..
Mar 26 2018, 10:13 AM

Mar 20 2018

stefanp updated the diff for D43086: [PowerPC] Infrastructure work. Implement getting the opcode for a spill in one place..

Implemented the cleanup for the loads as well.
Addressed comments from the reviewer.

Mar 20 2018, 6:28 PM

Mar 19 2018

stefanp updated the diff for D43086: [PowerPC] Infrastructure work. Implement getting the opcode for a spill in one place..

Added the XFormMemOp flag to the td files for the instructions the require it. This flag indicates that this instructions is a memory instruction and that it is an X-Form instruction.
Used a script to compare the modifications against the ISA to make sure that the correct instructions have the flag set.

Mar 19 2018, 12:24 PM

Mar 9 2018

stefanp committed rL327174: [Power9] Code Cleaup and adding Comments for Power 9 Scheduler.
[Power9] Code Cleaup and adding Comments for Power 9 Scheduler
Mar 9 2018, 1:13 PM
stefanp added a comment to D40855: [PowerPC] LSR tunings for PowerPC.

I've reverted the change in rL327143.

Mar 9 2018, 9:02 AM
stefanp committed rL327143: Revert "[PowerPC] LSR tunings for PowerPC".
Revert "[PowerPC] LSR tunings for PowerPC"
Mar 9 2018, 8:14 AM
stefanp committed rL327142: Revert "[PowerPC] Move test to correct location.".
Revert "[PowerPC] Move test to correct location."
Mar 9 2018, 8:14 AM
stefanp added a comment to D40855: [PowerPC] LSR tunings for PowerPC.

@echristo
Hi Eric,
Would you like me to pull this change out and fix the bug before I put it back in?

Mar 9 2018, 6:37 AM

Mar 8 2018

stefanp added a comment to D43235: [SchedModel] Complete models shouldn't match against itineraries when they don't use them (PR35639) (WIP).

With the patch rL327021 we should now be able to mark Power 9 as complete.

Mar 8 2018, 9:46 AM
stefanp committed rL327021: [Power9] Add more missing instructions to the Power 9 scheduler.
[Power9] Add more missing instructions to the Power 9 scheduler
Mar 8 2018, 8:27 AM

Mar 7 2018

stefanp committed rL326923: [PowerPC] Move test to correct location..
[PowerPC] Move test to correct location.
Mar 7 2018, 10:30 AM
stefanp committed rL326906: [PowerPC] LSR tunings for PowerPC.
[PowerPC] LSR tunings for PowerPC
Mar 7 2018, 8:57 AM
stefanp closed D40855: [PowerPC] LSR tunings for PowerPC.
Mar 7 2018, 8:56 AM

Mar 5 2018

stefanp committed rL326701: [Power9] Add more missing instructions to the Power 9 scheduler.
[Power9] Add more missing instructions to the Power 9 scheduler
Mar 5 2018, 6:38 AM