- User Since
- May 29 2017, 8:02 AM (210 w, 5 d)
Updated the name of the option to vector-compare compat.
Added clang test lines to the test cases.
Added deprecation warnings to the current default behaviour of vector bool and
Mon, Jun 7
Thu, Jun 3
Wed, Jun 2
Fri, May 28
I have reverted these changes (and subsequent related NFC patches) with the following patches:
commit 0159652058ca555b05db6a209fe9cf660c3bf8e6 (HEAD -> main, origin/main, origin/HEAD) Author: Stefan Pintilie <firstname.lastname@example.org> Date: Fri May 28 11:35:25 2021 -0500
Thu, May 27
This change is breaking a couple of Power PC buildbots.
Since the bots have been broken for more than 24 hours I ask that you please revert the change and then recommit once the issues have been addressed.
If you have questions about reproducing the issue or need help with it please let me know.
Updated author to Quinn.
Rebased revision to top of trunk.
Thu, May 20
The fix has been committed.
You may now try to recommit this patch.
Added code comment.
Wed, May 19
It seems that this patch has exposed an issue in the PowerPC backend where the partword atomics were not actually guaranteed to be zero extended.
I've added a patch:
to fix the issue.
May 13 2021
Added missing let isAllocatable = 0.
May 12 2021
I apologize but we have not been able to get to the bottom of this quickly. As a result we have pulled the change with:
commit 8d37411e48202b490c62ee3548df4b90f5974e12 (HEAD -> main, origin/main, origin/HEAD) Author: Stefan Pintilie <email@example.com> Date: Wed May 12 09:42:09 2021 -0500
May 11 2021
May 10 2021
Rebased patch and fixed typo in debug statement.
It looks like this patch has broken one of out Big Endian PowerPC buildbots:
May 6 2021
Rebased to top of trunk.
May 5 2021
Cleanup of test case.
Cleanup the source code according to clang format.
May 4 2021
Apr 30 2021
Apr 27 2021
Apr 26 2021
The point of the nt_flags= is to not overload the machine. We have noticed in the past that if we let the tests run all at the same time without a thread limit we sometimes get intermittent failing tests.
I think this is an option we should try to keep.
Apr 20 2021
Apr 15 2021
Was able to reproduce the issue that caused the left shift of -1.
Fixed the patch by replacing the shift with a multiply.
Also realized that the type should have been signed and not unsigned.
Apr 14 2021
Thank you for the explanation!
Apr 12 2021
Reopening review to investigate the issue.
Apr 9 2021
Apr 7 2021
Apr 5 2021
Updated test case to include -O0.
Mar 31 2021
Mar 30 2021
Removed extra whitespace.
Updated to always add the header to the got on PPC64.
Mar 25 2021
I'll need to go over this again to refresh my memory. As a quick recap though:
- On PPC, if we create a .got, then the first entry must be the tocbase.
- If .TOC. is not defined by one of the input objects, then we do not increment the number of .got entries here
- If we synthetically define .TOC. in the linker, then we end up with a .got section in some cases where we would otherwise not need one.
Rebased the patch to the latest top of trunk and added the test case.
Mar 24 2021
Looking at the test case changes there seem to be a few places where we are not generating expected code.
I've added comments to some of those places.
Mar 23 2021
I would like to restart the discussion on this patch.
I understand that the design of this fix is not ideal however I'm not sure of a better solution to this.
Adding the GOT to all linked binaries seems like too much. However, using hasGotOffRel isn't going to cover all of the test cases as it will not be set in all of the cases. The code needs to add a first symbol to the GOT in all cases where we use a GOT but we don't want to add a GOT if nothing else goes into it.