Page MenuHomePhabricator

stefanp (Stefan Pintilie)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2017, 8:02 AM (137 w, 4 d)

Recent Activity

Mon, Jan 13

stefanp updated the diff for D72572: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions.

Addressed review comments.

Mon, Jan 13, 2:21 PM · Restricted Project, Restricted Project
stefanp updated the diff for D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.

Addressed review comment by hard coding the prefix for MLS_DForm2_r0.

Mon, Jan 13, 1:15 PM · Restricted Project, Restricted Project
stefanp updated the diff for D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support.

Address review comments.

Mon, Jan 13, 10:54 AM · Restricted Project, Restricted Project

Sun, Jan 12

stefanp added a parent revision for D72574: [PowerPC][Future] Add pld and pstd to future CPU: D72572: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions.
Sun, Jan 12, 12:01 PM · Restricted Project, Restricted Project
stefanp added a child revision for D72572: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions: D72574: [PowerPC][Future] Add pld and pstd to future CPU.
Sun, Jan 12, 12:01 PM · Restricted Project, Restricted Project
stefanp added a child revision for D72574: [PowerPC][Future] Add pld and pstd to future CPU: D72577: [PowerPC][Future] Add prefixed loads and stores for future CPU.
Sun, Jan 12, 12:01 PM · Restricted Project, Restricted Project
stefanp added a parent revision for D72577: [PowerPC][Future] Add prefixed loads and stores for future CPU: D72574: [PowerPC][Future] Add pld and pstd to future CPU.
Sun, Jan 12, 12:01 PM · Restricted Project, Restricted Project
stefanp created D72577: [PowerPC][Future] Add prefixed loads and stores for future CPU.
Sun, Jan 12, 12:01 PM · Restricted Project, Restricted Project
stefanp created D72574: [PowerPC][Future] Add pld and pstd to future CPU.
Sun, Jan 12, 10:30 AM · Restricted Project, Restricted Project
stefanp updated the diff for D72572: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions.

Added full context.

Sun, Jan 12, 10:12 AM · Restricted Project, Restricted Project
stefanp updated the diff for D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support.

Added full context.

Sun, Jan 12, 10:06 AM · Restricted Project, Restricted Project
stefanp updated the diff for D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.

Added full context.

Sun, Jan 12, 10:03 AM · Restricted Project, Restricted Project
stefanp added a child revision for D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support: D72572: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions.
Sun, Jan 12, 8:58 AM · Restricted Project, Restricted Project
stefanp added a parent revision for D72572: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions: D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support.
Sun, Jan 12, 8:58 AM · Restricted Project, Restricted Project
stefanp created D72572: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions.
Sun, Jan 12, 8:58 AM · Restricted Project, Restricted Project
stefanp added a parent revision for D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support: D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.
Sun, Jan 12, 8:12 AM · Restricted Project, Restricted Project
stefanp added a child revision for D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU: D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support.
Sun, Jan 12, 8:12 AM · Restricted Project, Restricted Project
stefanp created D72570: [PowerPC][Future] Prefixed Instructions 64 Byte Boundary Support.
Sun, Jan 12, 8:12 AM · Restricted Project, Restricted Project
stefanp created D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.
Sun, Jan 12, 7:55 AM · Restricted Project, Restricted Project

Dec 18 2019

stefanp committed rGec3d6f3ecb4e: [PowerPC][NFC] Refactor splat of constant to vector. (authored by stefanp).
[PowerPC][NFC] Refactor splat of constant to vector.
Dec 18 2019, 10:46 AM
stefanp closed D71481: [PowerPC][NFC] Refactor splat of constant to vector..
Dec 18 2019, 10:46 AM · Restricted Project

Dec 17 2019

stefanp added a comment to D68237: [PowerPC] Handle f16 as a storage type only.

Other than the test case which still needs to be updated I think that this patch looks good to me.

Dec 17 2019, 2:37 PM · Restricted Project
stefanp accepted D71481: [PowerPC][NFC] Refactor splat of constant to vector..

It took me a while to determine that this was in fact NFC.
Removing the whole:

if (HasAnyUndefs || ISD::isBuildVectorAllOnes(BVN)) {
...
}

threw me off.
I'm convinced now so I'll approve it.
The minor nit that I have can be done on commit.

Dec 17 2019, 12:07 PM · Restricted Project

Dec 10 2019

stefanp closed D70976: [zorg] Add LNT testing to clang-ppc64le-rhel.
Dec 10 2019, 10:00 AM
stefanp committed rZORG622b3edf47e7: [zorg] Add LNT testing to clang-ppc64le-rhel (authored by stefanp).
[zorg] Add LNT testing to clang-ppc64le-rhel
Dec 10 2019, 10:00 AM

Dec 5 2019

stefanp requested changes to D69484: [PowerPC] Relax the restrictions on loading doubles with SPE.

Please add a test case for this.
Maybe an test were we have an SPE load of f64 with a 8 bit offset and one where the offset is larger or perhaps not aligned. Anyway, that's just a suggestion. You probably have a better idea of what you would like to test for this.

Dec 5 2019, 7:21 PM · Restricted Project
stefanp requested changes to D69486: PowerPC: Fix SPE f64 VAARG handling..
Dec 5 2019, 11:30 AM · Restricted Project
stefanp added a comment to D69486: PowerPC: Fix SPE f64 VAARG handling..

I think that for f64 on SPE the GprIndex you are computing it going to be ignored. (See my comment...)

Dec 5 2019, 11:21 AM · Restricted Project

Nov 27 2019

stefanp committed rG8e84c9ae9984: [PowerPC] Separate Features that are known to be Power9 specific from Future CPU (authored by stefanp).
[PowerPC] Separate Features that are known to be Power9 specific from Future CPU
Nov 27 2019, 1:42 PM
stefanp closed D70466: [PowerPC] Separate Features that are known to be Power9 specific from Future CPU.
Nov 27 2019, 1:42 PM · Restricted Project
stefanp committed rGdcceab1a0ace: [PowerPC] Add new Future CPU for PowerPC in LLVM (authored by stefanp).
[PowerPC] Add new Future CPU for PowerPC in LLVM
Nov 27 2019, 12:32 PM
stefanp closed D70333: [PowerPC] Add new Future CPU for PowerPC in LLVM.
Nov 27 2019, 12:32 PM · Restricted Project

Nov 21 2019

stefanp committed rG5fcf89f77893: [PowerPC] Add new Future CPU for PowerPC (authored by stefanp).
[PowerPC] Add new Future CPU for PowerPC
Nov 21 2019, 11:36 AM
stefanp closed D70262: [PowerPC] Add new Future CPU for PowerPC.
Nov 21 2019, 11:36 AM · Restricted Project

Nov 19 2019

stefanp added a parent revision for D70466: [PowerPC] Separate Features that are known to be Power9 specific from Future CPU: D70333: [PowerPC] Add new Future CPU for PowerPC in LLVM.
Nov 19 2019, 2:42 PM · Restricted Project
stefanp added a child revision for D70333: [PowerPC] Add new Future CPU for PowerPC in LLVM: D70466: [PowerPC] Separate Features that are known to be Power9 specific from Future CPU.
Nov 19 2019, 2:42 PM · Restricted Project
stefanp created D70466: [PowerPC] Separate Features that are known to be Power9 specific from Future CPU.
Nov 19 2019, 2:42 PM · Restricted Project

Nov 18 2019

stefanp committed rG6512473ceef2: [PowerPC] Improve float vector gather codegen (authored by stefanp).
[PowerPC] Improve float vector gather codegen
Nov 18 2019, 1:55 PM
stefanp closed D62908: [PowerPC] Improve float vector gather codegen.
Nov 18 2019, 1:55 PM · Restricted Project
stefanp committed rG9d9389391408: [PowerPC] Test case for vector float gather on ppc64le and ppc64 (authored by stefanp).
[PowerPC] Test case for vector float gather on ppc64le and ppc64
Nov 18 2019, 11:18 AM
stefanp closed D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64.
Nov 18 2019, 11:18 AM · Restricted Project

Nov 15 2019

stefanp added a comment to D69835: Add options for PPC to enable/disable using non-volatile CR.

I only saw a minor nit with this patch overall.

Nov 15 2019, 2:23 PM · Restricted Project
stefanp accepted D69168: [PowerPC] Fold redundant load immediates of zero and delete if possible.

LGTM

Nov 15 2019, 1:39 PM · Restricted Project
stefanp accepted D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64.

LGTM

Nov 15 2019, 12:54 PM · Restricted Project
stefanp accepted D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64.
Nov 15 2019, 12:54 PM · Restricted Project
stefanp added a comment to D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64.

I think this patch is fine now.
I only have one minor comment.

Nov 15 2019, 12:19 PM · Restricted Project
stefanp created D70333: [PowerPC] Add new Future CPU for PowerPC in LLVM.
Nov 15 2019, 11:43 AM · Restricted Project

Nov 14 2019

stefanp created D70262: [PowerPC] Add new Future CPU for PowerPC.
Nov 14 2019, 11:11 AM · Restricted Project

Nov 4 2019

stefanp added a comment to D69168: [PowerPC] Fold redundant load immediates of zero and delete if possible.

Mostly minor comments and a couple of questions.

Nov 4 2019, 12:41 PM · Restricted Project
stefanp requested changes to D69443: [PowerPC] Test case for vector float gather on ppc64le and ppc64.

Please make sure that your test does not put restrictions on the allocation of output registers. See my comments.
Otherwise I think this looks fine.

Nov 4 2019, 11:54 AM · Restricted Project

Oct 24 2019

stefanp accepted D66329: [PowerPC] [Peephole] fold frame offset by using index form to save add..

LGTM.
Sorry for taking so long to get to this.

Oct 24 2019, 1:13 PM · Restricted Project

Oct 2 2019

stefanp accepted D68344: [PowerPC] Remove assertion "Shouldn't overwrite a register before it is killed".

Thank you for fixing this.
LGTM.

Oct 2 2019, 1:12 PM · Restricted Project

Sep 30 2019

stefanp added a comment to D66329: [PowerPC] [Peephole] fold frame offset by using index form to save add..

I took this patch and applied it to master today and I noticed that one of the LIT tests fails.
The test is:

test-suite/MultiSource/Benchmarks/tramp3d-v4/

It segfaults with this patch and runs fine with out it.
I took a quick look at it and it seems that in this basic block:

; predecessors: %bb.11, %bb.12, %bb.13
  successors: %bb.21(0x80000000); %bb.21(100.00%)
  liveins: $r6, $r7, $r9, $x4, $x5, $x10, $x12, $x30, $r8
  renamable $x3 = ADDI8 $x1, 32
  STW killed renamable $r8, 32, $x1 :: (store 4 into %ir.arrayidx.i.i.i.i.i.i.i.i424, align 8), (store 4 into %ir.129, align 8)
  STW killed renamable $r6, 36, $x1 :: (store 4 into %ir.132)
  STW killed renamable $r7, 44, $x1 :: (store 4 into %ir.134)
  STW killed renamable $r9, 52, $x1 :: (store 4 into %ir.136)
  renamable $x3 = ADD8 killed renamable $x3, killed renamable $x5
  renamable $x5 = nsw ADD8 killed renamable $x10, killed renamable $x12
  renamable $r3 = LWZ 4, killed renamable $x3 :: (load 4 from %ir.137)
  renamable $x5 = nsw SUBF8 renamable $x4, killed renamable $x5
  STW8 killed renamable $x4, 24, renamable $x30 :: (store 4 into %ir.141)
  renamable $r3 = ADD4 killed renamable $r3, killed renamable $r5, implicit $x5
  B %bb.21

We replace

renamable $x3 = ADDI8 $x1, 32
renamable $x3 = ADD8 killed renamable $x3, killed renamable $x5
renamable $r3 = LWZ 4, killed renamable $x3 :: (load 4 from %ir.137)

with:

renamable $x3 = ADDI8 $x1, 36
renamable $r3 = LWZX killed $x5, killed $x3 :: (load 4 from %ir.137)

However, it looks like x5 is redefined before the load so using it in the LWZX is not safe because it is not the same x5 as before.

Sep 30 2019, 12:38 PM · Restricted Project

Sep 19 2019

stefanp closed D65820: [PowerPC] PPC LLD buildbot test instability fix..

Thank you Galina!
Committed at r371652.

Sep 19 2019, 11:33 AM
stefanp closed D67630: [PowerPC] PPC LLD buildbot fix previous patch.

Thank you Galina!
Committed at r372342.

Sep 19 2019, 11:33 AM

Sep 18 2019

stefanp added a comment to D67630: [PowerPC] PPC LLD buildbot fix previous patch.

@gkistanova
Thank you for reviewing this Galina.
I don't have commit access to zorg. Can you commit this for me?

Sep 18 2019, 9:23 AM

Sep 16 2019

stefanp created D67630: [PowerPC] PPC LLD buildbot fix previous patch.
Sep 16 2019, 1:05 PM

Sep 13 2019

stefanp added a comment to D66329: [PowerPC] [Peephole] fold frame offset by using index form to save add..

I do have a couple additional comments.

Sep 13 2019, 3:02 PM · Restricted Project

Sep 12 2019

stefanp accepted D66991: [PowerPC] Fix SH field overflow issue.

Sorry it took me so long to get back to this.
LGTM.

Sep 12 2019, 7:13 AM · Restricted Project

Sep 11 2019

stefanp added a comment to D65820: [PowerPC] PPC LLD buildbot test instability fix..

@gkistanova
Thank you for the review Galina.
I unfortunately don't have commit access to Zorg. Could you commit this for me?

Sep 11 2019, 11:26 AM

Aug 30 2019

stefanp accepted D62908: [PowerPC] Improve float vector gather codegen.

Overall this looks good. I have a couple of very minor comments that can be fixed on commit.
LGTM.

Aug 30 2019, 2:16 PM · Restricted Project
stefanp requested changes to D66991: [PowerPC] Fix SH field overflow issue.
Aug 30 2019, 1:01 PM · Restricted Project
stefanp added a comment to D66991: [PowerPC] Fix SH field overflow issue.

The fix looks good to me.
However, I feel that the test is over-specified. What you are looking for is a rotate or a shift with an immediate of zero and to make sure that we can safely print those kinds of instructions to assembly. I feel that using the update_llc_test_checks.py script only produces a test that will fail when other changes are made later on and forcing the developer of that changeset to regenerate your test.

Aug 30 2019, 12:57 PM · Restricted Project

Aug 29 2019

stefanp requested changes to D66329: [PowerPC] [Peephole] fold frame offset by using index form to save add..

I like what this patch is doing. Overall, I only have some refactoring comments.

Aug 29 2019, 12:08 PM · Restricted Project
stefanp added a comment to D66946: [Test] Testing Arcanist with this commit of a temporary file..

Added nit.

Aug 29 2019, 9:18 AM · Restricted Project

Aug 6 2019

stefanp created D65820: [PowerPC] PPC LLD buildbot test instability fix..
Aug 6 2019, 12:04 PM

Jul 19 2019

stefanp accepted D64220: [PowerPC] Remove redundant load immediate instructions.

I only have a number of very minor comments. Overall I think this looks good.
I think you can fix the comments when you commit.

Jul 19 2019, 2:40 PM · Restricted Project

Jul 9 2019

stefanp added a comment to D64221: [zorg] Use https for svn-test-suite stage of buildbot.

@gkistanova
Hi Galina,
We are having intermittent svn failures on our lnt build bot as a result of this http vs. https issue. (The bot: http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt)
Would it be possible to take a look at this patch because we think that this will fix our bot.
Thank you!

Jul 9 2019, 10:16 AM · Restricted Project, Restricted Project

Jul 8 2019

stefanp closed D57752: [PowerPC] [Buildbots] Do not build shared libs for the PowerPC LLD buildbot.

Committed by this patch:

commit 0a4f7b2312b55e8f3144cbb9e658bc37cc4fc779
Author: Galina Kistanova <gkistanova@gmail.com>
Date:   Mon Feb 25 20:19:36 2019 +0000
Jul 8 2019, 2:27 PM

Jul 5 2019

stefanp accepted D63654: [AIX] Add call lowering for parameters that could pass onto FPRs.

LGTM.

Jul 5 2019, 8:13 PM · Restricted Project
stefanp added a comment to D63547: [AIX]Global Address Lowering.

You have convinced me that this will only affect AIX. I only have minor comments remaining.

Jul 5 2019, 8:11 PM · Restricted Project

Jul 3 2019

stefanp updated subscribers of D63547: [AIX]Global Address Lowering.

I feel like this is supposed to be an AIX only patch.
However, there are some cases where you are making changes to PowerPC platforms that are not AIX. I don't know if those changes are safe.
I'm going to add two people to the review who may be interested in this and who work on 32 Bit PowerPC.

Jul 3 2019, 12:16 PM · Restricted Project

May 27 2019

stefanp added a comment to D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..

I'm not super familiar with the MC layer but overall this looks good to me.
I have a couple of minor comments.

May 27 2019, 10:38 AM · Restricted Project

May 24 2019

stefanp committed rG522307fa40da: [PowerPC] Remove CRBits Copy Of Unset/set CBit (authored by stefanp).
[PowerPC] Remove CRBits Copy Of Unset/set CBit
May 24 2019, 5:04 AM
stefanp committed rL361632: [PowerPC] Remove CRBits Copy Of Unset/set CBit.
[PowerPC] Remove CRBits Copy Of Unset/set CBit
May 24 2019, 5:03 AM
stefanp closed D62044: [PowerPC] Remove CRBits Copy Of Unset/set CBit.
May 24 2019, 5:03 AM · Restricted Project

May 2 2019

stefanp accepted D60037: [PowerPC] Use the two-constant NR algorithm for refining estimates.

I only have one comment here and I think it can be fixed when the patch is committed.
LGTM.

May 2 2019, 11:10 AM · Restricted Project
stefanp accepted D60402: [PowerPC] Collapse RLDICL/RLDICR into RLDIC when possible.

LGTM.
The one very minor comment I have I think can be addressed on commit.

May 2 2019, 10:53 AM · Restricted Project

Apr 16 2019

stefanp added a comment to D60037: [PowerPC] Use the two-constant NR algorithm for refining estimates.

I have a couple of nits. The main one being the test case for fma-mutate.ll.
I'm not sure if there is a way to use one const NR for just that one test.

Apr 16 2019, 10:57 AM · Restricted Project

Apr 15 2019

stefanp accepted D59843: [PowerPC] Add support for __dcbf builtin.

Looks good to me.
Then only thing I noticed was that in the description in the LanguageExtensions.rst file you use plural to refer to the chache builtins. Of course, you only added one builtin but I know that in the future you plan to add more builtins of the same type so I wouldn't worry about that wording now.

Apr 15 2019, 11:00 AM · Restricted Project, Restricted Project

Apr 12 2019

stefanp requested changes to D60402: [PowerPC] Collapse RLDICL/RLDICR into RLDIC when possible.

The patch does what we want it to do in most cases (including the example that motivated it) but some boundary conditions need to be considered before it is safe in all cases.

Apr 12 2019, 7:43 AM · Restricted Project

Apr 2 2019

stefanp committed rGfa6cd5ceb922: [PowerPC] Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp"… (authored by stefanp).
[PowerPC] Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp"…
Apr 2 2019, 9:58 AM
stefanp committed rL357494: [PowerPC] Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp"….
[PowerPC] Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp"…
Apr 2 2019, 9:57 AM
stefanp closed D59384: Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp" P9 implementation.
Apr 2 2019, 9:57 AM · Restricted Project

Apr 1 2019

stefanp added a comment to D59384: Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp" P9 implementation.

@nemanjai
I will commit this for Victor.

Apr 1 2019, 1:13 PM · Restricted Project

Mar 29 2019

stefanp accepted D59633: [PowerPC] Look through copies for compare elimination.

Have a couple of minor nits about the test case but that is all.
LGTM.

Mar 29 2019, 10:40 AM · Restricted Project
stefanp accepted D59384: Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp" P9 implementation.

LGTM

Mar 29 2019, 3:59 AM · Restricted Project

Mar 28 2019

stefanp accepted D59843: [PowerPC] Add support for __dcbf builtin.

Minor nit that can be fixed when this patch is committed.
LGTM.

Mar 28 2019, 11:19 AM · Restricted Project, Restricted Project

Mar 26 2019

stefanp committed rGe1d79a87c648: [PowerPC] Remove UseVSXReg (authored by stefanp).
[PowerPC] Remove UseVSXReg
Mar 26 2019, 1:28 PM
stefanp committed rL357028: [PowerPC] Remove UseVSXReg.
[PowerPC] Remove UseVSXReg
Mar 26 2019, 1:27 PM
stefanp closed D58685: [PowerPC] Remove UseVSXReg.
Mar 26 2019, 1:27 PM · Restricted Project

Mar 1 2019

stefanp committed rOMP355229: [OPENMP] Deal with additional store inserted by Clang under -fno-PIC for….
[OPENMP] Deal with additional store inserted by Clang under -fno-PIC for…
Mar 1 2019, 1:19 PM
stefanp committed rGa908829bf5dc: [OPENMP] Deal with additional store inserted by Clang under -fno-PIC for… (authored by stefanp).
[OPENMP] Deal with additional store inserted by Clang under -fno-PIC for…
Mar 1 2019, 1:19 PM
stefanp committed rL355229: [OPENMP] Deal with additional store inserted by Clang under -fno-PIC for….
[OPENMP] Deal with additional store inserted by Clang under -fno-PIC for…
Mar 1 2019, 1:19 PM
stefanp closed D56286: [OPENMP] Deal with additional store inserted by Clang under -fno-PIC for PowerPC..
Mar 1 2019, 1:19 PM · Restricted Project, Restricted Project
stefanp added a comment to D56286: [OPENMP] Deal with additional store inserted by Clang under -fno-PIC for PowerPC..

The reason why we don't clean up that extra store on no-PIC is because we run a couple of extra passes for PIC for PowerPC.
It is this code:

// FIXME: We probably don't need to run these for -fPIE.
if (getPPCTargetMachine().isPositionIndependent()) {
  // FIXME: LiveVariables should not be necessary here!
  // PPCTLSDynamicCallPass uses LiveIntervals which previously dependent on
  // LiveVariables. This (unnecessary) dependency has been removed now,
  // however a stage-2 clang build fails without LiveVariables computed here.
  addPass(&LiveVariablesID, false);
  addPass(createPPCTLSDynamicCallPass());
}

Those extra passes clean up the extra store.
If I remember correctly this is only really an issue at -O0. At higher opts other passes clean up stores like that.

Mar 1 2019, 7:59 AM · Restricted Project, Restricted Project

Feb 28 2019

stefanp added a comment to D56286: [OPENMP] Deal with additional store inserted by Clang under -fno-PIC for PowerPC..

@hfinkel @nemanjai
Hi,
Sorry for the late reply. It took me a little while to figure out that I had specified the wrong options for my test when trying to reproduce this....
Anyway, I've verified that what Nemanja said is indeed correct:
no-PIC

bl      100006b0 <00000017.plt_call.omp_control_tool@@VERSION>                                       
ld      r2,24(r1)                                                                                    
nop                                                                                                  
stw     r3,108(r31)
nop

PIC

bl      100006b0 <00000017.plt_call.omp_control_tool@@VERSION>
ld      r2,24(r1)
nop
nop

The store in the no-PIC version is just saving the return value from r3.

Feb 28 2019, 11:20 AM · Restricted Project, Restricted Project
stefanp committed rGa073a18460b4: [PowerPC] Removed STATISTIC that was causing build errors. (authored by stefanp).
[PowerPC] Removed STATISTIC that was causing build errors.
Feb 28 2019, 4:40 AM
stefanp committed rL355087: [PowerPC] Removed STATISTIC that was causing build errors..
[PowerPC] Removed STATISTIC that was causing build errors.
Feb 28 2019, 4:40 AM
stefanp committed rGbd5429ef38de: [PowerPC] Move the stack pointer update instruction later in the prologue and… (authored by stefanp).
[PowerPC] Move the stack pointer update instruction later in the prologue and…
Feb 28 2019, 4:24 AM