User Details
- User Since
- May 29 2017, 8:02 AM (63 w, 2 d)
Wed, Aug 8
Thu, Jul 19
Wed, Jul 18
Jul 12 2018
Jul 10 2018
We have determined that we do not require these builtin names.
I looked into the naming of those builtins.
GCC does document the overloaded versions of those functions:
scalar_extract_exp for __builtin_vsx_scalar_extract_expq
scalar_insert_exp for __builtin_vsx_scalar_insert_exp_qp
Jul 9 2018
Jul 5 2018
Added handling for the select f128.
Unlike the double type, the __float128 type cannot not use the fsel instruction but we should still expand it to something that functions correctly.
Done.
Committed in revision: rL336295
Jul 4 2018
Hi Hal, Eric,
Jun 29 2018
Hi Eric,
Jun 28 2018
Fixed comments according to previous review.
Jun 27 2018
Updated the comments.
Sorry.. I should have caught them initially.
Sorry for the late reply. I have been distracted with something else for a little while.
I have added the patch to remove needsAggressiveScheduling() here:
https://reviews.llvm.org/D48663
Jun 25 2018
Jun 23 2018
Jun 22 2018
Jun 20 2018
Jun 19 2018
Fixed test case command.
Jun 18 2018
Jun 15 2018
Jun 14 2018
Jun 13 2018
Jun 12 2018
Jun 11 2018
Updated the test case to use clang cc1 instead of just clang.
May 31 2018
@lattner
Added Chris Lattner as a reviewer in case I did something silly in the target indep code.
Fixed some of the style issues.
May 30 2018
May 22 2018
Hi Eric,
May 17 2018
Modifications based on review comments.
May 16 2018
Ran a series of tests on this patch.
Overall the results are positive. I'm going to list the degradations.
May 3 2018
Address comments from previous review.
Apr 20 2018
Apr 16 2018
I've updated the negative frame indices to use isFixedObjectIndex which is cleaner.
Committed in rL330117.
Closing this item.
Apr 13 2018
Apr 4 2018
Mar 28 2018
After some code cleanup that was required for requiresFrameIndexScavenging here is the new version of this patch.
It should take into consideration all of the reviewer's comments.
@echristo
Hi Eric,
What is your opinion on this? Should I be adding the #if .. and #endif? Does it matter?
Mar 27 2018
Mar 26 2018
Mar 20 2018
Implemented the cleanup for the loads as well.
Addressed comments from the reviewer.
Mar 19 2018
Added the XFormMemOp flag to the td files for the instructions the require it. This flag indicates that this instructions is a memory instruction and that it is an X-Form instruction.
Used a script to compare the modifications against the ISA to make sure that the correct instructions have the flag set.
Mar 9 2018
I've reverted the change in rL327143.
@echristo
Hi Eric,
Would you like me to pull this change out and fix the bug before I put it back in?
Mar 8 2018
With the patch rL327021 we should now be able to mark Power 9 as complete.