Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

saghir (Ahsan Saghir)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 15 2018, 1:02 PM (263 w, 4 d)

Recent Activity

Jul 21 2023

saghir added a comment to D155540: [clangd] Remove extra dependancies for clangd.

Thank you for the review and your comments @sammccall and @mstorsjo. As I understand there is no strong opinion here either way. I think we can leave things as they are for now. I am going to abandon this patch. If someone else feels strongly about removing them, they can put up a patch for this.

Jul 21 2023, 3:49 PM · Restricted Project, Restricted Project

Jul 17 2023

saghir updated the summary of D155540: [clangd] Remove extra dependancies for clangd.
Jul 17 2023, 8:02 PM · Restricted Project, Restricted Project
saghir retitled D155540: [clangd] Remove extra dependancies for clangd from [clangd] Move dependancies for clangd to [clangd] Remove extra dependancies for clangd.
Jul 17 2023, 8:02 PM · Restricted Project, Restricted Project
saghir added a comment to D155111: [clangd] Fix build failures observed on build bots for missing libs.

To clarify the issue - the kind of builds that seems to be broken is builds with BUILD_SHARED_LIBS=ON. The reason is that these libraries are needed is because the clangd target includes $<TARGET_OBJECTS:obj.clangDaemonTweaks>, so all the dependencies of clangDaemonTweaks would need to be included here as well. Please include that in the commit message description. (Is there a way to pull in those instead of duplicating the list?)

This looks mostly ok to me, but it does add slightly more libraries than what's needed. As the list of libraries that now are linked into clangdMain is the list of libraries that previously was linked for the two components that now are clangd and clangdMain, so some of the dependencies only need to be moved, not duplicated.

A more minimal set of dependencies, which seems to link successfully with BUILD_SHARED_LIBS=ON, is achieved with this diff on top of current git main:

diff --git a/clang-tools-extra/clangd/tool/CMakeLists.txt b/clang-tools-extra/clangd/tool/CMakeLists.txt
index ddf9c2488819..6c21175d7687 100644
--- a/clang-tools-extra/clangd/tool/CMakeLists.txt
+++ b/clang-tools-extra/clangd/tool/CMakeLists.txt
@@ -26,11 +26,7 @@ clang_target_link_libraries(clangdMain
   clangBasic
   clangFormat
   clangFrontend
-  clangLex
-  clangSema
   clangTooling
-  clangToolingCore
-  clangToolingRefactoring
   clangToolingSyntax
   )
 
@@ -44,7 +40,20 @@ target_link_libraries(clangdMain
   ${CLANGD_XPC_LIBS}
   )
 
+clang_target_link_libraries(clangd
+  PRIVATE
+  clangAST
+  clangBasic
+  clangLex
+  clangSema
+  clangToolingCore
+  clangToolingRefactoring
+  clangToolingSyntax
+  )
+
 target_link_libraries(clangd
   PRIVATE
   clangdMain
+  clangDaemon
+  clangdSupport
   )

Not sure if it's good hygiene to only link specifically to exactly those libraries that are needed and nothing else, or if it's just making things slightly more brittle?

Jul 17 2023, 8:00 PM · Restricted Project, Restricted Project
saghir requested review of D155540: [clangd] Remove extra dependancies for clangd.
Jul 17 2023, 8:00 PM · Restricted Project, Restricted Project

Jul 12 2023

saghir committed rG915659bfa1e9: [clangd] Fix build failures observed on build bots for missing libs (authored by saghir).
[clangd] Fix build failures observed on build bots for missing libs
Jul 12 2023, 2:16 PM · Restricted Project, Restricted Project
saghir closed D155111: [clangd] Fix build failures observed on build bots for missing libs.
Jul 12 2023, 2:15 PM · Restricted Project, Restricted Project
saghir added a comment to D155111: [clangd] Fix build failures observed on build bots for missing libs.

@mstorsjo @ivanmurashko Can you please take a look at this? This is blocking our builds on the PowerPC buildbots. Thanks a lot for your time!

Jul 12 2023, 1:19 PM · Restricted Project, Restricted Project
saghir added a comment to D155111: [clangd] Fix build failures observed on build bots for missing libs.

This is to fix failures in the build bot: https://lab.llvm.org/buildbot/#/builders/57/builds/28356

Jul 12 2023, 1:08 PM · Restricted Project, Restricted Project
saghir added reviewers for D155111: [clangd] Fix build failures observed on build bots for missing libs: nemanjai, mstorsjo, ivanmurashko.
Jul 12 2023, 1:02 PM · Restricted Project, Restricted Project
saghir requested review of D155111: [clangd] Fix build failures observed on build bots for missing libs.
Jul 12 2023, 1:00 PM · Restricted Project, Restricted Project

Jan 9 2023

saghir added inline comments to rG7c327c2fbb8a: AMDGPU: Fix broken opaque pointer handling in printf pass.
Jan 9 2023, 6:20 AM · Restricted Project, Restricted Project
saghir added a comment to D140560: AMDGPU: Fix broken opaque pointer handling in printf pass.

Hi, this seems to be causing our bots to fail. One example is https://lab.llvm.org/buildbot/#/builders/231/builds/6915. Can you please take a look? Thanks!

I have a patch ready for this, need to write some more tests for it

Try 40078a6b713730ffc164d4c0733d26352eb1e236

Jan 9 2023, 6:17 AM · Restricted Project, Restricted Project

Jan 6 2023

saghir added a comment to D140560: AMDGPU: Fix broken opaque pointer handling in printf pass.

Hi, this seems to be causing our bots to fail. One example is https://lab.llvm.org/buildbot/#/builders/231/builds/6915. Can you please take a look? Thanks!

Jan 6 2023, 2:24 AM · Restricted Project, Restricted Project

Dec 13 2022

saghir added a reverting change for D139633: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran: rTfe925ab05d2f: Revert "Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran".
Dec 13 2022, 12:20 PM · Restricted Project
saghir added a reverting change for rT8c18b1433474: Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran: rTfe925ab05d2f: Revert "Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran".
Dec 13 2022, 12:20 PM · Restricted Project
saghir committed rTfe925ab05d2f: Revert "Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran" (authored by saghir).
Revert "Enable Fortran testsuite when TEST_SUITE_SUBDIRS=Fortran"
Dec 13 2022, 12:20 PM · Restricted Project

Dec 9 2022

saghir added a comment to D136335: [Assignment Tracking Analysis][5/*] Tests.

Hi @Orlando, the test case (remove-undef-fragment.ll) that you added as part of 1d1de7467c32d52926ca56b9167a2c65c451ecfa is breaking one of our bots: https://lab.llvm.org/staging/#/builders/14/builds/1332. Can you please take a look? Thanks!

Dec 9 2022, 11:34 AM · Restricted Project, Restricted Project, debug-info
saghir added a comment to D139430: scudo-standalone: Add GetRSS method on Linux.

Oh. I think I know where this comes from - for fixing this: Would I submit to this changelist or open a new one?

Dec 9 2022, 8:50 AM · Restricted Project, Restricted Project
saghir added a comment to D139430: scudo-standalone: Add GetRSS method on Linux.

Just a heads up that this seems to be breaking one of our bots: https://lab.llvm.org/staging/#/builders/14/builds/1305.

Dec 9 2022, 7:00 AM · Restricted Project, Restricted Project

Nov 11 2022

saghir accepted D136728: [PowerPC] Add handling for WACC register spilling..

LGTM.

Nov 11 2022, 11:33 AM · Restricted Project, Restricted Project

Nov 4 2022

saghir accepted D136992: [PowerPC] Add new load/store with length instructions to Future CPU..

Besides other comments, LGTM. Thanks!

Nov 4 2022, 6:07 PM · Restricted Project, Restricted Project

Oct 28 2022

saghir accepted D136366: [PowerPC] Add new DMR register classes to Future CPU..

LGTM. Thanks!

Oct 28 2022, 4:09 PM · Restricted Project, Restricted Project

Jun 16 2022

saghir committed rG3d259a82da3e: [PowerPC] Fix LQ-STQ instructions to use correct offset and base (authored by saghir).
[PowerPC] Fix LQ-STQ instructions to use correct offset and base
Jun 16 2022, 8:47 AM · Restricted Project, Restricted Project
saghir closed D126807: [PowerPC] Fix LQ-STQ instructions to use correct offset and base.
Jun 16 2022, 8:47 AM · Restricted Project, Restricted Project

Jun 15 2022

saghir added inline comments to D126807: [PowerPC] Fix LQ-STQ instructions to use correct offset and base.
Jun 15 2022, 2:43 PM · Restricted Project, Restricted Project
saghir updated the diff for D126807: [PowerPC] Fix LQ-STQ instructions to use correct offset and base.

update test case output

Jun 15 2022, 2:41 PM · Restricted Project, Restricted Project
saghir updated the diff for D126807: [PowerPC] Fix LQ-STQ instructions to use correct offset and base.

updated test case.

Jun 15 2022, 2:35 PM · Restricted Project, Restricted Project
saghir added inline comments to D126807: [PowerPC] Fix LQ-STQ instructions to use correct offset and base.
Jun 15 2022, 11:17 AM · Restricted Project, Restricted Project
saghir updated the diff for D126807: [PowerPC] Fix LQ-STQ instructions to use correct offset and base.

Address review comments

Jun 15 2022, 11:12 AM · Restricted Project, Restricted Project

Jun 14 2022

saghir added a comment to D126807: [PowerPC] Fix LQ-STQ instructions to use correct offset and base.

This fix looks making offset handling more complex. We can make it easier by add LQX_PSEUDO and STQX_PSEUDO to ImmToIdxMap.

ImmToIdxMap[PPC::LQ]  = PPC::LQX_PSEUDO;
ImmToIdxMap[PPC::STQ] = PPC::STQX_PSEUDO;

And expand PPC::LQX_PSEUDO and PPC::STQX_PSEUDO post RA(They are expanded in PPCTargetLowering::EmitInstrWithCustomInserter right now). Something like

$x6 = LQX_PSEUDO $x0, $x1
=>
$x3 = ADD $x0, $x1
$x6 = LQ 0($x3)

Thus we make LQ/STQ fits in how we are handling frame index now, no more code is needed to handling the offset for LQ/STQ(When LQ/STQ are selected by ISEL, alignment is guaranteed to be 16 bytes since they are for atomic operations).

Jun 14 2022, 2:54 PM · Restricted Project, Restricted Project
saghir updated the diff for D126807: [PowerPC] Fix LQ-STQ instructions to use correct offset and base.

Added LQX_PSEUDO and STQX_PSEUDO to ImmToIdxMap, and rebased.

Jun 14 2022, 2:52 PM · Restricted Project, Restricted Project
saghir accepted D127439: [PowerPC] Fix combine step for shufflevector..

I think there is a minor comment from Zarko for removing a run line, but looks good other than that.

Jun 14 2022, 7:25 AM · Restricted Project, Restricted Project
saghir updated the diff for D126807: [PowerPC] Fix LQ-STQ instructions to use correct offset and base.

Handle unaligned offsets and offsets that do not fit in the instruction.

Jun 14 2022, 6:06 AM · Restricted Project, Restricted Project

Jun 9 2022

saghir accepted D127218: [PowerPC] Disable automatic generation of STXVP.

LGTM. Thanks!

Jun 9 2022, 4:26 AM · Restricted Project, Restricted Project

Jun 1 2022

saghir updated the diff for D126807: [PowerPC] Fix LQ-STQ instructions to use correct offset and base.

Use string substitution blocks for matching register and offset.

Jun 1 2022, 1:02 PM · Restricted Project, Restricted Project
saghir added reviewers for D126807: [PowerPC] Fix LQ-STQ instructions to use correct offset and base: Restricted Project, nemanjai, stefanp.
Jun 1 2022, 12:17 PM · Restricted Project, Restricted Project
saghir requested review of D126807: [PowerPC] Fix LQ-STQ instructions to use correct offset and base.
Jun 1 2022, 12:16 PM · Restricted Project, Restricted Project

May 20 2022

saghir added a comment to D110552: tsan: add lock free stack pattern test.

Looks like I missed something, probably because 'ppc' isn't a feature recognised by compiler-rt's lit config. Looking.

May 20 2022, 2:35 PM · Restricted Project, Restricted Project
saghir added a comment to D110552: tsan: add lock free stack pattern test.

Looks like I missed something, probably because 'ppc' isn't a feature recognised by compiler-rt's lit config. Looking.

May 20 2022, 2:00 PM · Restricted Project, Restricted Project
saghir added a comment to D110552: tsan: add lock free stack pattern test.

Hi @alexey-katranov, the test case added as part of this commit seems to be failing on our Power PC bots:

May 20 2022, 9:13 AM · Restricted Project, Restricted Project

Mar 15 2022

saghir accepted rG766ca2c59e21: [PowerPC] Add missed VSX shuffles instead of Altivec ones.

LGTM. Thanks for doing this!

Mar 15 2022, 7:18 AM · Restricted Project

Nov 17 2021

saghir accepted D113642: [PowerPC] Provide XL-compatible vec_round implementation.

LGTM.

Nov 17 2021, 9:54 AM · Restricted Project, Restricted Project
saghir accepted D114088: [PowerPC] Add BCD add/sub/cmp builtins.

LGTM.

Nov 17 2021, 9:50 AM · Restricted Project, Restricted Project
saghir accepted D113635: [PowerPC] Allow scalars for asm constraint "v" with VSX.

LGTM.

Nov 17 2021, 9:42 AM · Restricted Project

Nov 16 2021

saghir committed rG4c8b8e0154f0: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays (authored by saghir).
[PowerPC] Allow MMA built-ins to accept non-void pointers and arrays
Nov 16 2021, 7:15 AM
saghir closed D113306: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays.
Nov 16 2021, 7:14 AM · Restricted Project

Nov 5 2021

saghir added reviewers for D113306: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays: power-llvm-team, nemanjai, stefanp.
Nov 5 2021, 12:28 PM · Restricted Project
saghir requested review of D113306: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays.
Nov 5 2021, 12:27 PM · Restricted Project

Oct 12 2021

saghir abandoned D110608: [zorg] [PowerPC] Update version of gcc build compiler to 11.2.0 for sanitizer-ppc64be-linux bot.

Abandoning this since Galina suggested to do the changes locally for the buildbot.

Oct 12 2021, 6:57 AM · Restricted Project
saghir committed rG564e082d0954: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers (authored by saghir).
[PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers
Oct 12 2021, 6:52 AM
saghir closed D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers.
Oct 12 2021, 6:52 AM · Restricted Project, Restricted Project, Restricted Project

Oct 6 2021

saghir updated the summary of D110608: [zorg] [PowerPC] Update version of gcc build compiler to 11.2.0 for sanitizer-ppc64be-linux bot.
Oct 6 2021, 7:46 AM · Restricted Project
saghir requested review of D111234: [zorg] [PowerPC] Fix passing cmake args to sanitizer-ppc64le-linux bot..
Oct 6 2021, 7:39 AM · Restricted Project
saghir added inline comments to D110608: [zorg] [PowerPC] Update version of gcc build compiler to 11.2.0 for sanitizer-ppc64be-linux bot.
Oct 6 2021, 7:32 AM · Restricted Project
saghir updated the diff for D110608: [zorg] [PowerPC] Update version of gcc build compiler to 11.2.0 for sanitizer-ppc64be-linux bot.

Updates version of gcc build compiler.

Oct 6 2021, 7:30 AM · Restricted Project

Sep 28 2021

saghir added a comment to D110631: tsan: fix tls_race3 test on darwin.

Hi,

This change seems to be causing issues with Power PC buildbots. One such bot is https://lab.llvm.org/buildbot/#/builders/52/builds/10906. Can you please take a look to fix/revert the change? If there is anything I could do to help investigate, please let me know.

Thanks!

Sep 28 2021, 3:44 PM · Restricted Project
saghir updated the diff for D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers.

Stripped RV qualifiers for Sema checking.

Sep 28 2021, 10:03 AM · Restricted Project, Restricted Project, Restricted Project
saghir added a comment to rGc0687e1984a8: Add support for `NOLINTBEGIN` ... `NOLINTEND` comments.

Hi,
One of the tests added in this change is failing on PowerPC buildbots. One such bot is https://lab.llvm.org/buildbot/#/builders/121/builds/11903. Please revert and let us know how we can help you figure out what needs to be done to investigate/fix this on the PPC bots.
Thanks!

Sep 28 2021, 9:35 AM

Sep 27 2021

saghir retitled D110608: [zorg] [PowerPC] Update version of gcc build compiler to 11.2.0 for sanitizer-ppc64be-linux bot from [zorg] [PowerPC] Enable a runtimes build for ppc64be-sanitizer bot to [zorg] [PowerPC] Enable a runtimes build for sanitizer-ppc64be-linux bot.
Sep 27 2021, 7:47 PM · Restricted Project
saghir requested review of D110608: [zorg] [PowerPC] Update version of gcc build compiler to 11.2.0 for sanitizer-ppc64be-linux bot.
Sep 27 2021, 7:44 PM · Restricted Project
saghir added a comment to D110546: tsan: fix trace tests on darwin.

This was failing most of our buildbots, I reverted this change locally and the errors go away. I am reverting this change for now to get the buildbots back to green and give you a chance to look into it when you can.
Please feel free to reach out if you'd like any help with troubleshooting the issues that this patch was causing on PowerPC buildbots.

Sep 27 2021, 6:20 PM · Restricted Project
saghir added a reverting change for rG94ea36649ecc: tsan: fix trace tests on darwin: rG4f6a6ba1265d: Revert "tsan: fix trace tests on darwin".
Sep 27 2021, 6:17 PM
saghir committed rG4f6a6ba1265d: Revert "tsan: fix trace tests on darwin" (authored by saghir).
Revert "tsan: fix trace tests on darwin"
Sep 27 2021, 6:17 PM
saghir added a reverting change for D110546: tsan: fix trace tests on darwin: rG4f6a6ba1265d: Revert "tsan: fix trace tests on darwin".
Sep 27 2021, 6:17 PM · Restricted Project
saghir committed rG593b074a096c: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc… (authored by saghir).
[PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc…
Sep 27 2021, 5:51 PM
saghir closed D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.
Sep 27 2021, 5:51 PM · Restricted Project, Restricted Project, Restricted Project
saghir updated the diff for D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.

Addressed review comments.

Sep 27 2021, 5:49 PM · Restricted Project, Restricted Project, Restricted Project
saghir added a comment to D110546: tsan: fix trace tests on darwin.

Hi, this change seems to be breaking PowerPC buildbots:
One such bot is https://lab.llvm.org/buildbot/#/builders/57/builds/10548
Can you please take a look?

Sep 27 2021, 11:32 AM · Restricted Project

Sep 25 2021

saghir added a comment to D110338: [libc++] Require a C++20 capable compiler..

This seems to be breaking one of PPC buildbots: https://lab.llvm.org/buildbot/#/builders/18/builds/2553/steps/7/logs/stdio
Can you please take a look when you get a chance?

Sep 25 2021, 11:20 AM · Restricted Project

Sep 23 2021

saghir updated the diff for D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers.

Changed approach for Sema checks.

Sep 23 2021, 6:19 AM · Restricted Project, Restricted Project, Restricted Project

Sep 14 2021

saghir added a comment to D109708: [Windows build] Use "DIA SDK" in sysroot.

Hi, this patch is likely causing a failure on one of our bots:
https://lab.llvm.org/buildbot/#/builders/76/builds/3841

Can you please take a look at your convenience?
Thanks!

Sep 14 2021, 7:51 PM · Restricted Project, Restricted Project
saghir added a comment to D109708: [Windows build] Use "DIA SDK" in sysroot.

Hi, this patch is likely causing a failure on one of our bots:
https://lab.llvm.org/buildbot/#/builders/76/builds/3841

Sep 14 2021, 2:53 PM · Restricted Project, Restricted Project
saghir retitled D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers from [PowerPC] Allow MMA built-ins to accept restrict qualified pointers to [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers.
Sep 14 2021, 9:50 AM · Restricted Project, Restricted Project, Restricted Project
saghir updated the diff for D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers.

update test case name to be consistent with existing ones.

Sep 14 2021, 9:36 AM · Restricted Project, Restricted Project, Restricted Project

Sep 13 2021

saghir added a comment to D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs.

Hi, this change also breaks Power PC bots:

  1. https://lab.llvm.org/buildbot/#/builders/19/builds/6451/steps/24/logs/stdio
  2. https://lab.llvm.org/buildbot/#/builders/18/builds/2443/steps/23/logs/stdio

It fails consistently on our bots. Can you please take a look?

Thanks!

This will hopefully be better after b7bac5a172e51ed065b3b4dc64cc2d8831e8081c.

Sep 13 2021, 5:56 PM · Restricted Project
saghir added a comment to D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs.

Hi, this change also breaks Power PC bots:

  1. https://lab.llvm.org/buildbot/#/builders/19/builds/6451/steps/24/logs/stdio
  2. https://lab.llvm.org/buildbot/#/builders/18/builds/2443/steps/23/logs/stdio
Sep 13 2021, 2:51 PM · Restricted Project

Sep 12 2021

saghir updated the diff for D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers.

Addressed review comments.

Sep 12 2021, 7:58 PM · Restricted Project, Restricted Project, Restricted Project
saghir updated the diff for D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.

Addressed review comments.

Sep 12 2021, 7:27 PM · Restricted Project, Restricted Project, Restricted Project
saghir committed rG203cd01b54dd: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests (authored by saghir).
[PowerPC] [NFC] Add Big-Endian checks for existing MMA tests
Sep 12 2021, 6:39 PM
saghir closed D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests.
Sep 12 2021, 6:39 PM · Restricted Project
saghir updated the diff for D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests.

Rebased before commit.

Sep 12 2021, 6:33 PM · Restricted Project

Sep 10 2021

saghir updated the diff for D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests.

Rebased.

Sep 10 2021, 7:30 AM · Restricted Project

Sep 7 2021

saghir added inline comments to D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests.
Sep 7 2021, 1:27 PM · Restricted Project
saghir updated the diff for D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests.

Addressed review comments.

Sep 7 2021, 1:13 PM · Restricted Project

Sep 1 2021

saghir updated the summary of D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests.
Sep 1 2021, 8:34 PM · Restricted Project
saghir added reviewers for D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests: Restricted Project, nemanjai, lei.
Sep 1 2021, 8:33 PM · Restricted Project
saghir requested review of D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests.
Sep 1 2021, 8:32 PM · Restricted Project

Aug 23 2021

saghir updated the diff for D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.

Added comments, and re-organized tests.

Aug 23 2021, 12:37 PM · Restricted Project, Restricted Project, Restricted Project
saghir updated the diff for D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.

Added some more tests.

Aug 23 2021, 7:51 AM · Restricted Project, Restricted Project, Restricted Project

Aug 19 2021

saghir retitled D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins from [PowerPC] MMA - Remove deprecated built-ins and add new built-ins to [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.
Aug 19 2021, 10:10 AM · Restricted Project, Restricted Project, Restricted Project
saghir updated the diff for D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.

Change the implementation to add new builtins and keep the depracated builtins.

Aug 19 2021, 9:46 AM · Restricted Project, Restricted Project, Restricted Project

Aug 6 2021

saghir retitled D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers from [PowerPC] Allow MMA builtins to accept restrict qualified pointers to [PowerPC] Allow MMA built-ins to accept restrict qualified pointers.
Aug 6 2021, 7:50 AM · Restricted Project, Restricted Project, Restricted Project
saghir retitled D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins from Remove depracated built-ins for MMA and replace with new built-ins to [PowerPC] MMA - Remove deprecated built-ins and add new built-ins.
Aug 6 2021, 7:50 AM · Restricted Project, Restricted Project, Restricted Project
saghir requested review of D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.
Aug 6 2021, 7:44 AM · Restricted Project, Restricted Project, Restricted Project

Aug 5 2021

saghir updated the diff for D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers.

Addressed review comments. Added another test case.

Aug 5 2021, 7:50 AM · Restricted Project, Restricted Project, Restricted Project
saghir retitled D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers from [PowerPC] Allow MMA builtins to accpet restrict qualified pointers to [PowerPC] Allow MMA builtins to accept restrict qualified pointers.
Aug 5 2021, 7:30 AM · Restricted Project, Restricted Project, Restricted Project

Jul 22 2021

saghir added reviewers for D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers: Restricted Project, nemanjai, stefanp.
Jul 22 2021, 7:51 AM · Restricted Project, Restricted Project, Restricted Project
saghir requested review of D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers.
Jul 22 2021, 7:49 AM · Restricted Project, Restricted Project, Restricted Project

Jun 28 2021

saghir committed rG31ef15e0442a: Teach peephole optimizer to not emit sub-register defs (authored by saghir).
Teach peephole optimizer to not emit sub-register defs
Jun 28 2021, 7:24 AM