User Details
- User Since
- Nov 15 2018, 1:02 PM (263 w, 4 d)
Jul 21 2023
Thank you for the review and your comments @sammccall and @mstorsjo. As I understand there is no strong opinion here either way. I think we can leave things as they are for now. I am going to abandon this patch. If someone else feels strongly about removing them, they can put up a patch for this.
Jul 17 2023
Jul 12 2023
@mstorsjo @ivanmurashko Can you please take a look at this? This is blocking our builds on the PowerPC buildbots. Thanks a lot for your time!
This is to fix failures in the build bot: https://lab.llvm.org/buildbot/#/builders/57/builds/28356
Jan 9 2023
Jan 6 2023
Hi, this seems to be causing our bots to fail. One example is https://lab.llvm.org/buildbot/#/builders/231/builds/6915. Can you please take a look? Thanks!
Dec 13 2022
Dec 9 2022
Hi @Orlando, the test case (remove-undef-fragment.ll) that you added as part of 1d1de7467c32d52926ca56b9167a2c65c451ecfa is breaking one of our bots: https://lab.llvm.org/staging/#/builders/14/builds/1332. Can you please take a look? Thanks!
Just a heads up that this seems to be breaking one of our bots: https://lab.llvm.org/staging/#/builders/14/builds/1305.
Nov 11 2022
LGTM.
Nov 4 2022
Besides other comments, LGTM. Thanks!
Oct 28 2022
LGTM. Thanks!
Jun 16 2022
Jun 15 2022
update test case output
updated test case.
Address review comments
Jun 14 2022
Added LQX_PSEUDO and STQX_PSEUDO to ImmToIdxMap, and rebased.
I think there is a minor comment from Zarko for removing a run line, but looks good other than that.
Handle unaligned offsets and offsets that do not fit in the instruction.
Jun 9 2022
LGTM. Thanks!
Jun 1 2022
Use string substitution blocks for matching register and offset.
May 20 2022
Hi @alexey-katranov, the test case added as part of this commit seems to be failing on our Power PC bots:
Mar 15 2022
LGTM. Thanks for doing this!
Nov 17 2021
LGTM.
LGTM.
LGTM.
Nov 16 2021
Nov 5 2021
Oct 12 2021
Abandoning this since Galina suggested to do the changes locally for the buildbot.
Oct 6 2021
Updates version of gcc build compiler.
Sep 28 2021
Hi,
This change seems to be causing issues with Power PC buildbots. One such bot is https://lab.llvm.org/buildbot/#/builders/52/builds/10906. Can you please take a look to fix/revert the change? If there is anything I could do to help investigate, please let me know.
Thanks!
Stripped RV qualifiers for Sema checking.
Hi,
One of the tests added in this change is failing on PowerPC buildbots. One such bot is https://lab.llvm.org/buildbot/#/builders/121/builds/11903. Please revert and let us know how we can help you figure out what needs to be done to investigate/fix this on the PPC bots.
Thanks!
Sep 27 2021
This was failing most of our buildbots, I reverted this change locally and the errors go away. I am reverting this change for now to get the buildbots back to green and give you a chance to look into it when you can.
Please feel free to reach out if you'd like any help with troubleshooting the issues that this patch was causing on PowerPC buildbots.
Addressed review comments.
Hi, this change seems to be breaking PowerPC buildbots:
One such bot is https://lab.llvm.org/buildbot/#/builders/57/builds/10548
Can you please take a look?
Sep 25 2021
This seems to be breaking one of PPC buildbots: https://lab.llvm.org/buildbot/#/builders/18/builds/2553/steps/7/logs/stdio
Can you please take a look when you get a chance?
Sep 23 2021
Changed approach for Sema checks.
Sep 14 2021
Hi, this patch is likely causing a failure on one of our bots:
https://lab.llvm.org/buildbot/#/builders/76/builds/3841
update test case name to be consistent with existing ones.
Sep 13 2021
Hi, this change also breaks Power PC bots:
Sep 12 2021
Addressed review comments.
Addressed review comments.
Rebased before commit.
Sep 10 2021
Rebased.
Sep 7 2021
Addressed review comments.
Sep 1 2021
Aug 23 2021
Added comments, and re-organized tests.
Added some more tests.
Aug 19 2021
Change the implementation to add new builtins and keep the depracated builtins.
Aug 6 2021
Aug 5 2021
Addressed review comments. Added another test case.