Page MenuHomePhabricator

saghir (Ahsan Saghir)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 15 2018, 1:02 PM (39 w, 3 d)

Recent Activity

Apr 29 2019

saghir committed rL359517: Add __builtin_dcbf support for PPC.
Add __builtin_dcbf support for PPC
Apr 29 2019, 4:53 PM
saghir committed rG3962d6da1779: Add __builtin_dcbf support for PPC (authored by saghir).
Add __builtin_dcbf support for PPC
Apr 29 2019, 4:24 PM
saghir committed rC359517: Add __builtin_dcbf support for PPC.
Add __builtin_dcbf support for PPC
Apr 29 2019, 4:23 PM
saghir closed D59843: [PowerPC] Add support for __dcbf builtin.
Apr 29 2019, 4:23 PM · Restricted Project, Restricted Project

Apr 26 2019

saghir added a comment to rL359083: Let llvm-cvtres (and lld-link) report duplicate resources.

Hi, your patch seems to be causing buildbot failures for the following buildbots:
https://lab.llvm.org:8011/builders/clang-ppc64be-linux
https://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage
https://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt

Apr 26 2019, 12:48 PM

Apr 15 2019

saghir added a comment to D59843: [PowerPC] Add support for __dcbf builtin.

Looks good to me.
Then only thing I noticed was that in the description in the LanguageExtensions.rst file you use plural to refer to the chache builtins. Of course, you only added one builtin but I know that in the future you plan to add more builtins of the same type so I wouldn't worry about that wording now.

Apr 15 2019, 1:50 PM · Restricted Project, Restricted Project

Apr 14 2019

saghir updated the diff for D59843: [PowerPC] Add support for __dcbf builtin.

Moved cache builtins section to PowerPC Language extensions in LanguageExtensions.rst

Apr 14 2019, 10:23 PM · Restricted Project, Restricted Project

Apr 9 2019

saghir updated the diff for D59843: [PowerPC] Add support for __dcbf builtin.

Added documentation in clang/docs/LanguageExtensions.rst

Apr 9 2019, 9:52 PM · Restricted Project, Restricted Project

Apr 5 2019

saghir updated the diff for D59843: [PowerPC] Add support for __dcbf builtin.

Removed check for basic block in dcbf.ll

Apr 5 2019, 1:26 PM · Restricted Project, Restricted Project

Mar 26 2019

saghir updated the diff for D59843: [PowerPC] Add support for __dcbf builtin.

Updated test in dcbf.ll

Mar 26 2019, 2:18 PM · Restricted Project, Restricted Project
saghir edited reviewers for D59843: [PowerPC] Add support for __dcbf builtin, added: hfinkel; removed: llvm-commits.
Mar 26 2019, 1:53 PM · Restricted Project, Restricted Project
saghir created D59843: [PowerPC] Add support for __dcbf builtin.
Mar 26 2019, 1:49 PM · Restricted Project, Restricted Project

Feb 13 2019

saghir accepted D57857: [PowerPC] custom lower `v2f64 fpext v2f32`.

LGTM

Feb 13 2019, 12:31 PM · Restricted Project

Feb 7 2019

saghir added inline comments to D57857: [PowerPC] custom lower `v2f64 fpext v2f32`.
Feb 7 2019, 5:51 PM · Restricted Project
saghir requested changes to D57857: [PowerPC] custom lower `v2f64 fpext v2f32`.
Feb 7 2019, 2:31 PM · Restricted Project

Dec 19 2018

saghir created D55892: [OpenMP] 'close' map-type-modifier code generation.
Dec 19 2018, 10:24 AM · Restricted Project, Restricted Project

Dec 14 2018

saghir updated the diff for D55719: [OpenMP] parsing and sema support for 'close' map-type-modifier.

Made following changes:

  • added more tests for checking diagnostic error messages.
  • added initialization of modifiers' location in OMPMapClause.
  • improved variable names to depict multiple modifiers as opposed to a single modifier.
  • improved comments.
Dec 14 2018, 7:08 PM · Restricted Project
saghir created D55719: [OpenMP] parsing and sema support for 'close' map-type-modifier.
Dec 14 2018, 2:01 PM · Restricted Project

Nov 27 2018

saghir updated the summary of D54958: [OPENMP] remove redundant ColonExpected flag in ParseOpenMP.cpp - (NFC).
Nov 27 2018, 10:54 AM · Restricted Project
saghir updated the summary of D54958: [OPENMP] remove redundant ColonExpected flag in ParseOpenMP.cpp - (NFC).
Nov 27 2018, 10:54 AM · Restricted Project
saghir created D54958: [OPENMP] remove redundant ColonExpected flag in ParseOpenMP.cpp - (NFC).
Nov 27 2018, 10:53 AM · Restricted Project

Nov 16 2018

saghir retitled D54638: [OpenMP] remove redundant MapTypeModifierSpecified flag in ParseOpenMP.cpp (NFC) from [OpenMP] remove redundant MapTypeModifierSpecified flag in ParseOpenMP.cpp to [OpenMP] remove redundant MapTypeModifierSpecified flag in ParseOpenMP.cpp (NFC).
Nov 16 2018, 10:55 AM · Restricted Project
saghir retitled D54638: [OpenMP] remove redundant MapTypeModifierSpecified flag in ParseOpenMP.cpp (NFC) from OpenMP: remove redundant MapTypeModifierSpecified flag in ParseOpenMP.cpp to [OpenMP] remove redundant MapTypeModifierSpecified flag in ParseOpenMP.cpp.
Nov 16 2018, 10:38 AM · Restricted Project
saghir created D54638: [OpenMP] remove redundant MapTypeModifierSpecified flag in ParseOpenMP.cpp (NFC).
Nov 16 2018, 10:36 AM · Restricted Project