Page MenuHomePhabricator
People saghir

saghir (Ahsan Saghir)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 15 2018, 1:02 PM (184 w, 1 d)

Recent Activity
View All

Fri, May 20

saghir added a comment to D110552: tsan: add lock free stack pattern test.
In D110552#3528471, @hctim wrote:

Looks like I missed something, probably because 'ppc' isn't a feature recognised by compiler-rt's lit config. Looking.

Fri, May 20, 2:35 PM · Restricted Project, Restricted Project
saghir added a comment to D110552: tsan: add lock free stack pattern test.
In D110552#3528471, @hctim wrote:

Looks like I missed something, probably because 'ppc' isn't a feature recognised by compiler-rt's lit config. Looking.

Fri, May 20, 2:00 PM · Restricted Project, Restricted Project
saghir added a comment to D110552: tsan: add lock free stack pattern test.

Hi @alexey-katranov, the test case added as part of this commit seems to be failing on our Power PC bots:

Fri, May 20, 9:13 AM · Restricted Project, Restricted Project

Mar 15 2022

saghir accepted rG766ca2c59e21: [PowerPC] Add missed VSX shuffles instead of Altivec ones.

LGTM. Thanks for doing this!

Mar 15 2022, 7:18 AM · Restricted Project

Nov 17 2021

saghir accepted D113642: [PowerPC] Provide XL-compatible vec_round implementation.

LGTM.

Nov 17 2021, 9:54 AM · Restricted Project, Restricted Project
saghir accepted D114088: [PowerPC] Add BCD add/sub/cmp builtins.

LGTM.

Nov 17 2021, 9:50 AM · Restricted Project, Restricted Project
saghir accepted D113635: [PowerPC] Allow scalars for asm constraint "v" with VSX.

LGTM.

Nov 17 2021, 9:42 AM · Restricted Project

Nov 16 2021

saghir committed rG4c8b8e0154f0: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays (authored by saghir).
[PowerPC] Allow MMA built-ins to accept non-void pointers and arrays
Nov 16 2021, 7:15 AM
saghir closed D113306: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays.
Nov 16 2021, 7:14 AM · Restricted Project

Nov 5 2021

saghir added reviewers for D113306: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays: power-llvm-team, nemanjai, stefanp.
Nov 5 2021, 12:28 PM · Restricted Project
saghir requested review of D113306: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays.
Nov 5 2021, 12:27 PM · Restricted Project

Oct 12 2021

saghir abandoned D110608: [zorg] [PowerPC] Update version of gcc build compiler to 11.2.0 for sanitizer-ppc64be-linux bot.

Abandoning this since Galina suggested to do the changes locally for the buildbot.

Oct 12 2021, 6:57 AM · Restricted Project
saghir committed rG564e082d0954: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers (authored by saghir).
[PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers
Oct 12 2021, 6:52 AM
saghir closed D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers.
Oct 12 2021, 6:52 AM · Restricted Project, Restricted Project, Restricted Project

Oct 6 2021

saghir updated the summary of D110608: [zorg] [PowerPC] Update version of gcc build compiler to 11.2.0 for sanitizer-ppc64be-linux bot.
Oct 6 2021, 7:46 AM · Restricted Project
saghir requested review of D111234: [zorg] [PowerPC] Fix passing cmake args to sanitizer-ppc64le-linux bot..
Oct 6 2021, 7:39 AM · Restricted Project
saghir added inline comments to D110608: [zorg] [PowerPC] Update version of gcc build compiler to 11.2.0 for sanitizer-ppc64be-linux bot.
Oct 6 2021, 7:32 AM · Restricted Project
saghir updated the diff for D110608: [zorg] [PowerPC] Update version of gcc build compiler to 11.2.0 for sanitizer-ppc64be-linux bot.

Updates version of gcc build compiler.

Oct 6 2021, 7:30 AM · Restricted Project

Sep 28 2021

saghir added a comment to D110631: tsan: fix tls_race3 test on darwin.

Hi,

This change seems to be causing issues with Power PC buildbots. One such bot is https://lab.llvm.org/buildbot/#/builders/52/builds/10906. Can you please take a look to fix/revert the change? If there is anything I could do to help investigate, please let me know.

Thanks!

Sep 28 2021, 3:44 PM · Restricted Project
saghir updated the diff for D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers.

Stripped RV qualifiers for Sema checking.

Sep 28 2021, 10:03 AM · Restricted Project, Restricted Project, Restricted Project
saghir added a comment to rGc0687e1984a8: Add support for `NOLINTBEGIN` ... `NOLINTEND` comments.

Hi,
One of the tests added in this change is failing on PowerPC buildbots. One such bot is https://lab.llvm.org/buildbot/#/builders/121/builds/11903. Please revert and let us know how we can help you figure out what needs to be done to investigate/fix this on the PPC bots.
Thanks!

Sep 28 2021, 9:35 AM

Sep 27 2021

saghir retitled D110608: [zorg] [PowerPC] Update version of gcc build compiler to 11.2.0 for sanitizer-ppc64be-linux bot from [zorg] [PowerPC] Enable a runtimes build for ppc64be-sanitizer bot to [zorg] [PowerPC] Enable a runtimes build for sanitizer-ppc64be-linux bot.
Sep 27 2021, 7:47 PM · Restricted Project
saghir requested review of D110608: [zorg] [PowerPC] Update version of gcc build compiler to 11.2.0 for sanitizer-ppc64be-linux bot.
Sep 27 2021, 7:44 PM · Restricted Project
saghir added a comment to D110546: tsan: fix trace tests on darwin.

This was failing most of our buildbots, I reverted this change locally and the errors go away. I am reverting this change for now to get the buildbots back to green and give you a chance to look into it when you can.
Please feel free to reach out if you'd like any help with troubleshooting the issues that this patch was causing on PowerPC buildbots.

Sep 27 2021, 6:20 PM · Restricted Project
saghir added a reverting change for rG94ea36649ecc: tsan: fix trace tests on darwin: rG4f6a6ba1265d: Revert "tsan: fix trace tests on darwin".
Sep 27 2021, 6:17 PM
saghir committed rG4f6a6ba1265d: Revert "tsan: fix trace tests on darwin" (authored by saghir).
Revert "tsan: fix trace tests on darwin"
Sep 27 2021, 6:17 PM
saghir added a reverting change for D110546: tsan: fix trace tests on darwin: rG4f6a6ba1265d: Revert "tsan: fix trace tests on darwin".
Sep 27 2021, 6:17 PM · Restricted Project
saghir committed rG593b074a096c: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc… (authored by saghir).
[PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc…
Sep 27 2021, 5:51 PM
saghir closed D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.
Sep 27 2021, 5:51 PM · Restricted Project, Restricted Project, Restricted Project
saghir updated the diff for D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.

Addressed review comments.

Sep 27 2021, 5:49 PM · Restricted Project, Restricted Project, Restricted Project
saghir added a comment to D110546: tsan: fix trace tests on darwin.

Hi, this change seems to be breaking PowerPC buildbots:
One such bot is https://lab.llvm.org/buildbot/#/builders/57/builds/10548
Can you please take a look?

Sep 27 2021, 11:32 AM · Restricted Project

Sep 25 2021

saghir added a comment to D110338: [libc++] Require a C++20 capable compiler..

This seems to be breaking one of PPC buildbots: https://lab.llvm.org/buildbot/#/builders/18/builds/2553/steps/7/logs/stdio
Can you please take a look when you get a chance?

Sep 25 2021, 11:20 AM · Restricted Project

Sep 23 2021

saghir updated the diff for D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers.

Changed approach for Sema checks.

Sep 23 2021, 6:19 AM · Restricted Project, Restricted Project, Restricted Project

Sep 14 2021

saghir added a comment to D109708: [Windows build] Use "DIA SDK" in sysroot.
In D109708#3000526, @saghir wrote:

Hi, this patch is likely causing a failure on one of our bots:
https://lab.llvm.org/buildbot/#/builders/76/builds/3841

Can you please take a look at your convenience?
Thanks!

Sep 14 2021, 7:51 PM · Restricted Project, Restricted Project
saghir added a comment to D109708: [Windows build] Use "DIA SDK" in sysroot.

Hi, this patch is likely causing a failure on one of our bots:
https://lab.llvm.org/buildbot/#/builders/76/builds/3841

Sep 14 2021, 2:53 PM · Restricted Project, Restricted Project
saghir retitled D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers from [PowerPC] Allow MMA built-ins to accept restrict qualified pointers to [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers.
Sep 14 2021, 9:50 AM · Restricted Project, Restricted Project, Restricted Project
saghir updated the diff for D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers.

update test case name to be consistent with existing ones.

Sep 14 2021, 9:36 AM · Restricted Project, Restricted Project, Restricted Project

Sep 13 2021

saghir added a comment to D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs.
In D109624#2998665, @thakis wrote:
In D109624#2998550, @saghir wrote:

Hi, this change also breaks Power PC bots:

  1. https://lab.llvm.org/buildbot/#/builders/19/builds/6451/steps/24/logs/stdio
  2. https://lab.llvm.org/buildbot/#/builders/18/builds/2443/steps/23/logs/stdio

It fails consistently on our bots. Can you please take a look?

Thanks!

This will hopefully be better after b7bac5a172e51ed065b3b4dc64cc2d8831e8081c.

Sep 13 2021, 5:56 PM · Restricted Project
saghir added a comment to D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs.

Hi, this change also breaks Power PC bots:

  1. https://lab.llvm.org/buildbot/#/builders/19/builds/6451/steps/24/logs/stdio
  2. https://lab.llvm.org/buildbot/#/builders/18/builds/2443/steps/23/logs/stdio
Sep 13 2021, 2:51 PM · Restricted Project

Sep 12 2021

saghir updated the diff for D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers.

Addressed review comments.

Sep 12 2021, 7:58 PM · Restricted Project, Restricted Project, Restricted Project
saghir updated the diff for D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.

Addressed review comments.

Sep 12 2021, 7:27 PM · Restricted Project, Restricted Project, Restricted Project
saghir committed rG203cd01b54dd: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests (authored by saghir).
[PowerPC] [NFC] Add Big-Endian checks for existing MMA tests
Sep 12 2021, 6:39 PM
saghir closed D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests.
Sep 12 2021, 6:39 PM · Restricted Project
saghir updated the diff for D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests.

Rebased before commit.

Sep 12 2021, 6:33 PM · Restricted Project

Sep 10 2021

saghir updated the diff for D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests.

Rebased.

Sep 10 2021, 7:30 AM · Restricted Project

Sep 7 2021

saghir added inline comments to D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests.
Sep 7 2021, 1:27 PM · Restricted Project
saghir updated the diff for D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests.

Addressed review comments.

Sep 7 2021, 1:13 PM · Restricted Project

Sep 1 2021

saghir updated the summary of D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests.
Sep 1 2021, 8:34 PM · Restricted Project
saghir added reviewers for D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests: Restricted Project, nemanjai, lei.
Sep 1 2021, 8:33 PM · Restricted Project
saghir requested review of D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests.
Sep 1 2021, 8:32 PM · Restricted Project

Aug 23 2021

saghir updated the diff for D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.

Added comments, and re-organized tests.

Aug 23 2021, 12:37 PM · Restricted Project, Restricted Project, Restricted Project
saghir updated the diff for D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.

Added some more tests.

Aug 23 2021, 7:51 AM · Restricted Project, Restricted Project, Restricted Project

Aug 19 2021

saghir retitled D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins from [PowerPC] MMA - Remove deprecated built-ins and add new built-ins to [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.
Aug 19 2021, 10:10 AM · Restricted Project, Restricted Project, Restricted Project
saghir updated the diff for D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.

Change the implementation to add new builtins and keep the depracated builtins.

Aug 19 2021, 9:46 AM · Restricted Project, Restricted Project, Restricted Project

Aug 6 2021

saghir retitled D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers from [PowerPC] Allow MMA builtins to accept restrict qualified pointers to [PowerPC] Allow MMA built-ins to accept restrict qualified pointers.
Aug 6 2021, 7:50 AM · Restricted Project, Restricted Project, Restricted Project
saghir retitled D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins from Remove depracated built-ins for MMA and replace with new built-ins to [PowerPC] MMA - Remove deprecated built-ins and add new built-ins.
Aug 6 2021, 7:50 AM · Restricted Project, Restricted Project, Restricted Project
saghir requested review of D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.
Aug 6 2021, 7:44 AM · Restricted Project, Restricted Project, Restricted Project

Aug 5 2021

saghir updated the diff for D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers.

Addressed review comments. Added another test case.

Aug 5 2021, 7:50 AM · Restricted Project, Restricted Project, Restricted Project
saghir retitled D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers from [PowerPC] Allow MMA builtins to accpet restrict qualified pointers to [PowerPC] Allow MMA builtins to accept restrict qualified pointers.
Aug 5 2021, 7:30 AM · Restricted Project, Restricted Project, Restricted Project

Jul 22 2021

saghir added reviewers for D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers: Restricted Project, nemanjai, stefanp.
Jul 22 2021, 7:51 AM · Restricted Project, Restricted Project, Restricted Project
saghir requested review of D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers.
Jul 22 2021, 7:49 AM · Restricted Project, Restricted Project, Restricted Project

Jun 28 2021

saghir committed rG31ef15e0442a: Teach peephole optimizer to not emit sub-register defs (authored by saghir).
Teach peephole optimizer to not emit sub-register defs
Jun 28 2021, 7:24 AM
saghir closed D103408: Teach peephole optimizer to not emit sub-register defs.
Jun 28 2021, 7:24 AM · Restricted Project

Jun 25 2021

saghir added inline comments to D103408: Teach peephole optimizer to not emit sub-register defs.
Jun 25 2021, 9:27 AM · Restricted Project
saghir updated the diff for D103408: Teach peephole optimizer to not emit sub-register defs.

Removed the IR section from the test case.

Jun 25 2021, 9:26 AM · Restricted Project

Jun 24 2021

saghir added a comment to D103408: Teach peephole optimizer to not emit sub-register defs.
In D103408#2789491, @lebedev.ri wrote:

Does it trigger on any of the existing tests in Codegen/PowerPC/?

Jun 24 2021, 8:04 PM · Restricted Project
saghir added inline comments to D103408: Teach peephole optimizer to not emit sub-register defs.
Jun 24 2021, 8:00 PM · Restricted Project
saghir updated the diff for D103408: Teach peephole optimizer to not emit sub-register defs.

Added test case description.

Jun 24 2021, 7:51 PM · Restricted Project
saghir added inline comments to D103408: Teach peephole optimizer to not emit sub-register defs.
Jun 24 2021, 7:51 PM · Restricted Project
saghir updated the diff for D103408: Teach peephole optimizer to not emit sub-register defs.

Simplified test case and removed the code that introduces subreg def.

Jun 24 2021, 7:26 PM · Restricted Project

Jun 21 2021

saghir updated the diff for D103408: Teach peephole optimizer to not emit sub-register defs.

NFC change:
Changed the name of a variable.

Jun 21 2021, 1:24 PM · Restricted Project
saghir retitled D103408: Teach peephole optimizer to not emit sub-register defs from DetectDeadLanes: Remove assert for subregister defs to Teach peephole optimizer to not emit sub-register defs.
Jun 21 2021, 11:41 AM · Restricted Project
saghir updated the diff for D103408: Teach peephole optimizer to not emit sub-register defs.

Address comments:

  • Subreg defs are indeed illegal; taught peephole optimizer not to emit these.
  • Added mir test case.
Jun 21 2021, 11:39 AM · Restricted Project

Jun 1 2021

saghir updated the summary of D103408: Teach peephole optimizer to not emit sub-register defs.
Jun 1 2021, 7:35 AM · Restricted Project
saghir updated the diff for D103408: Teach peephole optimizer to not emit sub-register defs.

Added test case.

Jun 1 2021, 7:33 AM · Restricted Project

May 31 2021

saghir requested review of D103408: Teach peephole optimizer to not emit sub-register defs.
May 31 2021, 6:58 AM · Restricted Project

May 7 2021

saghir committed rG25bbff632d01: [PowerPC] Provide MMA builtins for compatibility (authored by saghir).
[PowerPC] Provide MMA builtins for compatibility
May 7 2021, 7:10 AM
saghir closed D100482: [PowerPC] Provide MMA builtins for compatibility.
May 7 2021, 7:10 AM · Restricted Project, Restricted Project

May 4 2021

saghir committed rG670736a90474: [PowerPC] Prevent argument promotion of types with size greater than 128 bits (authored by saghir).
[PowerPC] Prevent argument promotion of types with size greater than 128 bits
May 4 2021, 10:09 AM
saghir closed D101188: [PowerPC] Prevent argument promotion of types with size greater than 128 bits.
May 4 2021, 10:09 AM · Restricted Project
saghir updated the diff for D101188: [PowerPC] Prevent argument promotion of types with size greater than 128 bits.

Rebased before committing

May 4 2021, 10:06 AM · Restricted Project
saghir updated the diff for D101188: [PowerPC] Prevent argument promotion of types with size greater than 128 bits.

Added another test case

May 4 2021, 7:58 AM · Restricted Project
saghir updated the summary of D100482: [PowerPC] Provide MMA builtins for compatibility.
May 4 2021, 7:36 AM · Restricted Project, Restricted Project
saghir updated the diff for D100482: [PowerPC] Provide MMA builtins for compatibility.

Addressed review comments to add _mma_ version of the built-ins as
aliases to the existing _vsx_ versions.

May 4 2021, 7:32 AM · Restricted Project, Restricted Project

Apr 28 2021

saghir updated the summary of D101188: [PowerPC] Prevent argument promotion of types with size greater than 128 bits.
Apr 28 2021, 6:01 PM · Restricted Project
saghir updated the diff for D101188: [PowerPC] Prevent argument promotion of types with size greater than 128 bits.

Addressed review comments to check for primitive type size.

Apr 28 2021, 6:00 PM · Restricted Project

Apr 26 2021

saghir accepted D100918: [PowerPC] Turn Off PC Relative Linker Optimization by Default.

LGTM.

Apr 26 2021, 12:38 PM · Restricted Project

Apr 23 2021

saghir updated the diff for D101188: [PowerPC] Prevent argument promotion of types with size greater than 128 bits.

Fixed typo in commit message.

Apr 23 2021, 11:20 AM · Restricted Project
saghir updated the summary of D101188: [PowerPC] Prevent argument promotion of types with size greater than 128 bits.
Apr 23 2021, 11:19 AM · Restricted Project
saghir requested review of D101188: [PowerPC] Prevent argument promotion of types with size greater than 128 bits.
Apr 23 2021, 11:17 AM · Restricted Project
saghir added a comment to D101162: [PowerPC] Prevent argument promotion for certain types.

Not the right patch in terms of the test included, abandoning this one and will open a new revision with the correct patch.

Apr 23 2021, 7:09 AM · Restricted Project
saghir abandoned D101162: [PowerPC] Prevent argument promotion for certain types.
Apr 23 2021, 7:08 AM · Restricted Project
saghir requested review of D101162: [PowerPC] Prevent argument promotion for certain types.
Apr 23 2021, 7:06 AM · Restricted Project

Apr 15 2021

saghir retitled D100482: [PowerPC] Provide MMA builtins for compatibility from [PowerPC] Provide MMA builtins for compatability to [PowerPC] Provide MMA builtins for compatibility.
Apr 15 2021, 7:44 AM · Restricted Project, Restricted Project
saghir updated the diff for D100482: [PowerPC] Provide MMA builtins for compatibility.

Fixed spelling.

Apr 15 2021, 7:37 AM · Restricted Project, Restricted Project

Apr 14 2021

saghir accepted D100431: [Zorg] Change make to ninja instead for Clang RHEL buildbot.

This looks good to me, approving to unblock the failing bot.

Apr 14 2021, 1:47 PM · Restricted Project
saghir added reviewers for D100482: [PowerPC] Provide MMA builtins for compatibility: power-llvm-team, nemanjai, stefanp.
Apr 14 2021, 7:55 AM · Restricted Project, Restricted Project
saghir requested review of D100482: [PowerPC] Provide MMA builtins for compatibility.
Apr 14 2021, 7:54 AM · Restricted Project, Restricted Project

Apr 13 2021

saghir accepted D100389: [Zorg] Add space between script and args.

Hopefully this fixes the error:

sanitizer-ppc64le-linux runs: bash ../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_cmake.sh-- -CMAKE_ARGS='-DLLVM_LIT_ARGS=-v -j256'
bash: ../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_cmake.sh--: No such file or directory
Apr 13 2021, 10:32 AM · Restricted Project

Mar 8 2021

saghir committed rGacce401068e7: [PowerPC] Change target data layout for 16-byte stack alignment (authored by saghir).
[PowerPC] Change target data layout for 16-byte stack alignment
Mar 8 2021, 6:13 AM