Page MenuHomePhabricator

shchenz (ChenZheng)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2018, 9:57 PM (145 w, 5 d)

Recent Activity

Yesterday

shchenz added a comment to D85288: [PowerPC] Remove implicit use register after transformToImmFormFedByLI().

Thanks for the detailed explanation. I am thinking the replaceInstrOperandWithImm is functionality complete.
The issue here is checking an empty implicit operand set by MI.implicit_operands().empty() is not right as the MI is in the construction phase after calling setDesc()

Tue, Apr 13, 11:44 PM · Restricted Project
shchenz added a comment to D85288: [PowerPC] Remove implicit use register after transformToImmFormFedByLI().

implicit $x5 is in the explicit operand list.

Tue, Apr 13, 8:55 PM · Restricted Project
shchenz added a project to D100440: [Debug-Info] DW_AT_export_symbols shouldn't be generated before version-5 of DWARF.: debug-info.
Tue, Apr 13, 8:42 PM · debug-info, Restricted Project

Mon, Apr 12

shchenz added inline comments to D100166: [PowerPC] stop reverse mem op generation when the feeder has more than one users.
Mon, Apr 12, 7:45 PM · Restricted Project
shchenz committed rG80aa9b0f7b3e: [PowerPC] stop reverse mem op generation for some cases. (authored by shchenz).
[PowerPC] stop reverse mem op generation for some cases.
Mon, Apr 12, 7:42 PM
shchenz closed D100166: [PowerPC] stop reverse mem op generation when the feeder has more than one users.
Mon, Apr 12, 7:42 PM · Restricted Project

Sun, Apr 11

shchenz committed rGbb346146a52e: [Debug-Info] make fortran CHARACTER(1) type as valid unsigned type (authored by shchenz).
[Debug-Info] make fortran CHARACTER(1) type as valid unsigned type
Sun, Apr 11, 8:17 PM
shchenz closed D100015: [debug-info] make fortran CHARACTER(1) type as valid unsigned type.
Sun, Apr 11, 8:17 PM · Restricted Project, debug-info
shchenz added inline comments to D100015: [debug-info] make fortran CHARACTER(1) type as valid unsigned type.
Sun, Apr 11, 8:08 PM · Restricted Project, debug-info

Fri, Apr 9

shchenz requested review of D100166: [PowerPC] stop reverse mem op generation when the feeder has more than one users.
Fri, Apr 9, 12:48 AM · Restricted Project
shchenz committed rG4b54345e4770: [NFC][PowerPC] add test cases for reverse memory op transformation (authored by shchenz).
[NFC][PowerPC] add test cases for reverse memory op transformation
Fri, Apr 9, 12:43 AM

Thu, Apr 8

shchenz added a comment to D100015: [debug-info] make fortran CHARACTER(1) type as valid unsigned type.

Thanks for your review @aprantl . Updated accordingly.

Thu, Apr 8, 6:45 PM · Restricted Project, debug-info
shchenz updated the diff for D100015: [debug-info] make fortran CHARACTER(1) type as valid unsigned type.

1: check the DWARF info instead of the crash

Thu, Apr 8, 6:44 PM · Restricted Project, debug-info
shchenz added a comment to D97656: [llvm-objcopy] Initial XCOFF32 support..

The patch does not support reading and writing debug info. Do you think I should add it to the patch?

Thu, Apr 8, 2:26 AM · Restricted Project
shchenz added a comment to D97656: [llvm-objcopy] Initial XCOFF32 support..

Seems the functionality of the llvm-objcopy is not right. Could you please help to check? And maybe we need to add some other tests.

Thu, Apr 8, 1:48 AM · Restricted Project

Wed, Apr 7

shchenz committed rG74e77295e754: [PowerPC] fixup killed flags for ri + addi to ri transformation (authored by shchenz).
[PowerPC] fixup killed flags for ri + addi to ri transformation
Wed, Apr 7, 7:05 PM
shchenz closed D100023: [PowerPC] fixup killed flags for ri + addi to ri transformation.
Wed, Apr 7, 7:04 PM · Restricted Project
shchenz updated the summary of D100023: [PowerPC] fixup killed flags for ri + addi to ri transformation.
Wed, Apr 7, 12:19 AM · Restricted Project
shchenz updated the summary of D100023: [PowerPC] fixup killed flags for ri + addi to ri transformation.
Wed, Apr 7, 12:17 AM · Restricted Project
shchenz requested review of D100023: [PowerPC] fixup killed flags for ri + addi to ri transformation.
Wed, Apr 7, 12:15 AM · Restricted Project

Tue, Apr 6

shchenz added inline comments to D99933: [Debug-Info] Use inlined strings in .dwinfo section by default for DBX..
Tue, Apr 6, 10:20 PM · Restricted Project
shchenz requested review of D100015: [debug-info] make fortran CHARACTER(1) type as valid unsigned type.
Tue, Apr 6, 9:38 PM · Restricted Project, debug-info
shchenz added a comment to D99933: [Debug-Info] Use inlined strings in .dwinfo section by default for DBX..

Can we set this only for DBX? This should be a limitation for DBX not for AIX?

Tue, Apr 6, 3:10 AM · Restricted Project

Mon, Apr 5

shchenz added a comment to D99257: [XCOFF] dynamically allocating the section and csect group .

hi @jasonliu , thanks a lot for your review.

Mon, Apr 5, 8:27 PM · Restricted Project

Fri, Apr 2

shchenz added inline comments to D93191: [PowerPC] Fold select_cc constants when comparing zero into trivial ops.
Fri, Apr 2, 2:08 AM · Restricted Project
shchenz added inline comments to D93191: [PowerPC] Fold select_cc constants when comparing zero into trivial ops.
Fri, Apr 2, 2:06 AM · Restricted Project

Thu, Apr 1

shchenz updated the diff for D99785: [XCOFF] make .file directive have directory info.

Lint warning fix

Thu, Apr 1, 9:16 PM · Restricted Project
shchenz updated the summary of D99785: [XCOFF] make .file directive have directory info.
Thu, Apr 1, 9:14 PM · Restricted Project
shchenz requested review of D99785: [XCOFF] make .file directive have directory info.
Thu, Apr 1, 8:53 PM · Restricted Project
shchenz added a comment to D97184: [XCOFF] support DWARF for XCOFF for object output.

gentle ping

Thu, Apr 1, 6:48 PM · Restricted Project
shchenz added a comment to D97049: [XCOFF][NFC] add DWARF section support in XCOFF object writer.

gentle ping

Thu, Apr 1, 6:47 PM · Restricted Project
shchenz added inline comments to D99703: [debug-info][XCOFF] set `-gno-column-info` by default for DBX.
Thu, Apr 1, 6:31 PM · Restricted Project, debug-info
shchenz committed rGf026e1f52055: [debug-info][XCOFF] set `-gno-column-info` by default for DBX (authored by shchenz).
[debug-info][XCOFF] set `-gno-column-info` by default for DBX
Thu, Apr 1, 6:29 PM
shchenz closed D99703: [debug-info][XCOFF] set `-gno-column-info` by default for DBX.
Thu, Apr 1, 6:29 PM · Restricted Project, debug-info

Wed, Mar 31

shchenz requested review of D99703: [debug-info][XCOFF] set `-gno-column-info` by default for DBX.
Wed, Mar 31, 9:56 PM · Restricted Project, debug-info
shchenz committed rGbfcd21876adc: [debug-info] support new tuning debugger type DBX for XCOFF DWARF (authored by shchenz).
[debug-info] support new tuning debugger type DBX for XCOFF DWARF
Wed, Mar 31, 9:12 PM
shchenz added inline comments to D99400: [debug-info] support new tuning debugger type DBX for XCOFF DWARF.
Wed, Mar 31, 9:12 PM · debug-info, Restricted Project, Restricted Project
shchenz closed D99400: [debug-info] support new tuning debugger type DBX for XCOFF DWARF.
Wed, Mar 31, 9:12 PM · debug-info, Restricted Project, Restricted Project
shchenz accepted D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..

LGTM

Wed, Mar 31, 12:16 AM · debug-info, Restricted Project

Tue, Mar 30

shchenz added inline comments to D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..
Tue, Mar 30, 6:21 PM · debug-info, Restricted Project
shchenz added a comment to D97656: [llvm-objcopy] Initial XCOFF32 support..

Thanks for adding objcopy support on AIX.

Tue, Mar 30, 6:07 PM · Restricted Project

Fri, Mar 26

shchenz added a comment to D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..

Thanks for your comments @dblaikie @probinson .

Fri, Mar 26, 6:20 AM · debug-info, Restricted Project
shchenz updated the summary of D99400: [debug-info] support new tuning debugger type DBX for XCOFF DWARF.
Fri, Mar 26, 6:16 AM · debug-info, Restricted Project, Restricted Project
shchenz requested review of D99400: [debug-info] support new tuning debugger type DBX for XCOFF DWARF.
Fri, Mar 26, 1:08 AM · debug-info, Restricted Project, Restricted Project

Thu, Mar 25

shchenz added a comment to D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..

Thx! @aprantl The motivation of the patch came from the crash of tag name mismatching when using DBX under AIX. And modifying the debugger doesn't seem to make sense?

A consumer should not crash when it sees an unexpected value. This is clearly a DBX problem. It should have some fallback, for example it could do the same thing it would do if the language attribute was missing entirely.

Thu, Mar 25, 8:16 AM · debug-info, Restricted Project

Wed, Mar 24

shchenz updated the diff for D97184: [XCOFF] support DWARF for XCOFF for object output.

1: update due to change in D99257

Wed, Mar 24, 6:31 AM · Restricted Project
shchenz updated the diff for D99257: [XCOFF] dynamically allocating the section and csect group .

1: LINT warning fix

Wed, Mar 24, 6:29 AM · Restricted Project
shchenz updated the diff for D97184: [XCOFF] support DWARF for XCOFF for object output.

avoid to use raw new/delete

Wed, Mar 24, 6:05 AM · Restricted Project
shchenz requested review of D99257: [XCOFF] dynamically allocating the section and csect group .
Wed, Mar 24, 6:01 AM · Restricted Project
shchenz updated the diff for D97049: [XCOFF][NFC] add DWARF section support in XCOFF object writer.

update for dynamic allocating for the section entries.

Wed, Mar 24, 5:50 AM · Restricted Project
shchenz added inline comments to D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..
Wed, Mar 24, 4:53 AM · debug-info, Restricted Project

Fri, Mar 19

shchenz planned changes to D97049: [XCOFF][NFC] add DWARF section support in XCOFF object writer.
Fri, Mar 19, 6:57 PM · Restricted Project
shchenz planned changes to D97184: [XCOFF] support DWARF for XCOFF for object output.

thanks for your review @jasonliu
I will post an NFC patch first to make csect be allocated dynamically.

Fri, Mar 19, 6:57 PM · Restricted Project

Wed, Mar 17

shchenz accepted D97039: [PowerPC] Enable redundant TOC save removal on AIX.

LGTM with one minor comment and one idea about further improvement. Thanks for improving this.

Wed, Mar 17, 11:41 PM · Restricted Project
shchenz updated the diff for D97049: [XCOFF][NFC] add DWARF section support in XCOFF object writer.

fix lint warnings

Wed, Mar 17, 10:42 PM · Restricted Project
shchenz added a comment to D97184: [XCOFF] support DWARF for XCOFF for object output.

@jasonliu Thanks for your comments. Please see my inline reply.

Wed, Mar 17, 10:41 PM · Restricted Project
shchenz updated the diff for D97184: [XCOFF] support DWARF for XCOFF for object output.

address @jasonliu comments

Wed, Mar 17, 10:41 PM · Restricted Project
shchenz added a comment to rGd33b016ada56: [XCOFF][llvm-dwarfdump] llvm-dwarfdump support for XCOFF.

This commit causes some buildbots like X86 and avr fail as:

/home/buildbot/llvm-avr-linux/llvm-avr-linux/llvm/llvm/test/tools/llvm-dwarfdump/XCOFF/Inputs/basic32.o: No available targets are compatible with triple "powerpc-unknown-unknown"
Wed, Mar 17, 7:02 PM
shchenz committed rG12824266c76c: [NFC] make XCOFF dwarf dump test run only on PowerPC target. (authored by shchenz).
[NFC] make XCOFF dwarf dump test run only on PowerPC target.
Wed, Mar 17, 7:00 PM
shchenz committed rGd33b016ada56: [XCOFF][llvm-dwarfdump] llvm-dwarfdump support for XCOFF (authored by shchenz).
[XCOFF][llvm-dwarfdump] llvm-dwarfdump support for XCOFF
Wed, Mar 17, 6:22 PM
shchenz closed D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.
Wed, Mar 17, 6:22 PM · Restricted Project
shchenz updated the diff for D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.

1: correct xlc version

Wed, Mar 17, 6:07 PM · Restricted Project
shchenz added a comment to D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.

Thanks for review @echristo

a) Can you name it something other than empty? Maybe basic or something?

Done

b) Reasonable to loosen up the checks slightly? There's a lot of -NEXT in there that doesn't appear to be strictly necessary (unless you're autogenerating the checks - if so let me know).

Yeah, sort of auto-generating. But do we need to loosen up the checks? This DWARF info should be settled as the result of the tests comes from object files.

Yeah, it's tough. Right now if anything changes even slightly in the output the test will fail, but isn't necessarily everything you need to be checking if that makes sense? That said, it's probably on the small order of update probability so it's fine if you'd like to leave it this way and we can update it later if it becomes an issue.

Accepting (though fix any other feedback first).

-eric

Wed, Mar 17, 5:42 PM · Restricted Project
shchenz added a comment to D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.

Thanks for review @echristo

Wed, Mar 17, 8:32 AM · Restricted Project
shchenz updated the diff for D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.

use correct file mode

Wed, Mar 17, 8:29 AM · Restricted Project
shchenz updated the diff for D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.

1: rename the binary names

Wed, Mar 17, 8:22 AM · Restricted Project

Tue, Mar 16

shchenz updated the diff for D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.

1: update the testcases

Tue, Mar 16, 9:51 PM · Restricted Project
shchenz accepted D98620: [NFC] [XCOFF] Update PowerPC readobj test case with expression for Index and ContainingCsectSymbolIndex.

LGTM. Thanks for this improvement.

Tue, Mar 16, 6:54 PM · Restricted Project
shchenz added a reviewer for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj.: Higuoxing.
Tue, Mar 16, 6:19 AM · Restricted Project
shchenz updated the diff for D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.
Tue, Mar 16, 6:18 AM · Restricted Project
shchenz added a comment to D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.

Maybe it would be best to wait on basic XCOFF yaml2obj support to be finished, add DWARF emission support to that, and then use yaml2obj to generate the DWARF output as required?

Tue, Mar 16, 6:17 AM · Restricted Project

Mon, Mar 15

shchenz updated the summary of D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.
Mon, Mar 15, 11:12 PM · Restricted Project
shchenz added a comment to D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.

Thanks for your review @jasonliu @echristo. Could you please help to have another look?

Mon, Mar 15, 11:12 PM · Restricted Project
shchenz updated the diff for D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.

1: add test cases based on objects

Mon, Mar 15, 11:11 PM · Restricted Project
shchenz added a comment to D98620: [NFC] [XCOFF] Update PowerPC readobj test case with expression for Index and ContainingCsectSymbolIndex.

Please indicate this is for XCOFF in the title and a follow-up of the patch D97117 in the description.

Mon, Mar 15, 5:53 PM · Restricted Project

Mar 15 2021

shchenz added a reviewer for D98620: [NFC] [XCOFF] Update PowerPC readobj test case with expression for Index and ContainingCsectSymbolIndex: hubert.reinterpretcast.
Mar 15 2021, 12:07 AM · Restricted Project

Mar 10 2021

shchenz accepted D98383: [Debug-Info] Add names for the debug line prologue..

Thanks for doing this. LGTM too.

Mar 10 2021, 7:32 PM · Restricted Project
shchenz updated the diff for D97184: [XCOFF] support DWARF for XCOFF for object output.

rebase due to change in D97049

Mar 10 2021, 12:15 AM · Restricted Project
shchenz updated the diff for D97049: [XCOFF][NFC] add DWARF section support in XCOFF object writer.

format fix

Mar 10 2021, 12:14 AM · Restricted Project

Mar 9 2021

shchenz planned changes to D97184: [XCOFF] support DWARF for XCOFF for object output.
Mar 9 2021, 6:02 PM · Restricted Project
shchenz planned changes to D97049: [XCOFF][NFC] add DWARF section support in XCOFF object writer.
Mar 9 2021, 6:02 PM · Restricted Project
shchenz added a comment to D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.

gentle ping

Mar 9 2021, 1:20 AM · Restricted Project
shchenz added a comment to D97049: [XCOFF][NFC] add DWARF section support in XCOFF object writer.

gentle ping

Mar 9 2021, 1:18 AM · Restricted Project
shchenz updated the diff for D97049: [XCOFF][NFC] add DWARF section support in XCOFF object writer.

rebase

Mar 9 2021, 1:18 AM · Restricted Project
shchenz added a comment to D97184: [XCOFF] support DWARF for XCOFF for object output.

gentle ping

Mar 9 2021, 1:18 AM · Restricted Project
shchenz updated the diff for D97184: [XCOFF] support DWARF for XCOFF for object output.

rebase and some formatting change

Mar 9 2021, 1:18 AM · Restricted Project

Mar 8 2021

shchenz planned changes to D97184: [XCOFF] support DWARF for XCOFF for object output.
Mar 8 2021, 8:39 PM · Restricted Project
shchenz planned changes to D97049: [XCOFF][NFC] add DWARF section support in XCOFF object writer.
Mar 8 2021, 8:38 PM · Restricted Project
shchenz added inline comments to D97049: [XCOFF][NFC] add DWARF section support in XCOFF object writer.
Mar 8 2021, 8:38 PM · Restricted Project

Mar 5 2021

shchenz committed rGafa76fe67a42: [XCOFF][DWARF] set default DWARF version to 3. (authored by shchenz).
[XCOFF][DWARF] set default DWARF version to 3.
Mar 5 2021, 6:22 AM
shchenz closed D98010: [XCOFF] [DWARF] set default DWARF version to 3.
Mar 5 2021, 6:22 AM · Restricted Project

Mar 4 2021

shchenz requested review of D98010: [XCOFF] [DWARF] set default DWARF version to 3.
Mar 4 2021, 11:37 PM · Restricted Project
shchenz added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mar 4 2021, 7:04 PM · debug-info, Restricted Project
shchenz committed rG87bbf3d1f8c3: [XCOFF][DebugInfo] support DWARF for XCOFF for assembly output. (authored by shchenz).
[XCOFF][DebugInfo] support DWARF for XCOFF for assembly output.
Mar 4 2021, 6:08 PM
shchenz closed D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mar 4 2021, 6:08 PM · debug-info, Restricted Project
shchenz added a comment to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

@jasonliu Please see my inline comments for the corner case and the left FIXME. Thanks for your review.

Mar 4 2021, 5:17 PM · debug-info, Restricted Project
shchenz updated the diff for D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

1: add more comment

Mar 4 2021, 5:16 PM · debug-info, Restricted Project

Mar 3 2021

shchenz added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mar 3 2021, 6:23 PM · debug-info, Restricted Project
shchenz added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mar 3 2021, 6:06 PM · debug-info, Restricted Project
shchenz updated the diff for D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

1: address @jasonliu comments

Mar 3 2021, 6:06 PM · debug-info, Restricted Project