- User Since
- Jun 28 2018, 9:57 PM (55 w, 3 d)
Thu, Jul 18
Wed, Jul 17
Tue, Jul 16
Wed, Jul 10
Thanks very much for doing this, this is exactly what I want to do as a follow-up patch for https://reviews.llvm.org/D64422.
Tue, Jul 9
Thanks for reverting @jsji . I will see how to fix it.
address @samparker comments.
Mon, Jul 8
Thu, Jul 4
Wed, Jul 3
address review comments about test case.
@samparker Thanks for your comment, Sam. Updated the patch. I use the same source in both opt test and llc test, since the testing point is not the same, hope this is ok.
Tue, Jul 2
Wed, Jun 26
call target hook function outside the loop, it should be called once per loop.
Thanks for your comments @hfinkel .
codes moved to class TargetTransformInfo can not be called by both class HardwareLoops and class PPCTargetTransformInfo.
Move the code to class HardwareLoopInfo in NFC patch https://reviews.llvm.org/rL364415. FYI @samparker
committed in https://reviews.llvm.org/rL364397
Tue, Jun 25
This patch causes a lot of cases fail except platform X86 and ARM.
Jun 18 2019
Abandon this patch.
Jun 5 2019
Jun 4 2019
Jun 3 2019
May 27 2019
PowerPC case now LGTM. I think this also needs approval for x86 case?
May 26 2019
May 21 2019
May 20 2019
Apr 13 2019
Apr 9 2019
Sorry for breaking down unit testing. Could you please help to do another review for this patch. Thanks a lot.
Sorry for the faulty commit and thanks for reverting this @lebedev.ri
Apr 8 2019
LGTM except one minor formating issue. Thansk for fixing this.
LGTM for this patch.