Page MenuHomePhabricator

shchenz (ChenZheng)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2018, 9:57 PM (46 w, 4 d)

Recent Activity

Yesterday

shchenz created D62173: [PowerPC] [ISEL] select x-form instruction for unaligned offset.
Mon, May 20, 10:53 PM · Restricted Project
shchenz committed rGe64bcada5fa1: [PowerPC] test cases for selecting x-form instruction for unaligned offset - NFC (authored by shchenz).
[PowerPC] test cases for selecting x-form instruction for unaligned offset - NFC
Mon, May 20, 10:04 PM
shchenz committed rL361219: [PowerPC] test cases for selecting x-form instruction for unaligned offset….
[PowerPC] test cases for selecting x-form instruction for unaligned offset…
Mon, May 20, 10:04 PM
shchenz committed rGc4c407a0ebbe: [PowerPC] use more meaningful name - NFC (authored by shchenz).
[PowerPC] use more meaningful name - NFC
Mon, May 20, 8:54 PM
shchenz committed rL361218: [PowerPC] use more meaningful name - NFC.
[PowerPC] use more meaningful name - NFC
Mon, May 20, 8:52 PM

Apr 13 2019

shchenz committed rG87dd0e06dc99: [InstCombine] Canonicalize (-X srem Y) to -(X srem Y). (authored by shchenz).
[InstCombine] Canonicalize (-X srem Y) to -(X srem Y).
Apr 13 2019, 2:21 AM
shchenz committed rL358328: [InstCombine] Canonicalize (-X srem Y) to -(X srem Y)..
[InstCombine] Canonicalize (-X srem Y) to -(X srem Y).
Apr 13 2019, 2:21 AM
shchenz closed D60647: [InstCombine] Canonicalize (-X srem Y) to -(X srem Y).
Apr 13 2019, 2:21 AM · Restricted Project
shchenz created D60647: [InstCombine] Canonicalize (-X srem Y) to -(X srem Y).
Apr 13 2019, 12:59 AM · Restricted Project
shchenz committed rGfc59a0326b7c: [InstCombine] [NFC] add testcases for canonicalizing (-X srem Y) to -(X srem Y). (authored by shchenz).
[InstCombine] [NFC] add testcases for canonicalizing (-X srem Y) to -(X srem Y).
Apr 13 2019, 12:35 AM
shchenz committed rL358327: [InstCombine] [NFC] add testcases for canonicalizing (-X srem Y) to -(X srem Y)..
[InstCombine] [NFC] add testcases for canonicalizing (-X srem Y) to -(X srem Y).
Apr 13 2019, 12:33 AM

Apr 9 2019

shchenz committed rG5e13ff1da20b: [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y). (authored by shchenz).
[InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y).
Apr 9 2019, 11:51 PM
shchenz committed rL358050: [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y)..
[InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y).
Apr 9 2019, 11:51 PM
shchenz closed D60395: [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y).
Apr 9 2019, 11:51 PM · Restricted Project
shchenz added a comment to D60395: [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y).

LG, please do run at least the check-llvm before committing..

Apr 9 2019, 11:41 PM · Restricted Project
shchenz updated the diff for D60395: [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y).

Sorry for breaking down unit testing. Could you please help to do another review for this patch. Thanks a lot.

Apr 9 2019, 10:55 PM · Restricted Project
shchenz added a comment to D60395: [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y).

@shchenz how did rL358017 end up committing this diff into completely different place in this function?

Apr 9 2019, 7:06 PM · Restricted Project
shchenz added a comment to D60478: [InstCombine] Fix canonicalization of (-X s/ Y) to -(X s/ Y)..

Sorry for the faulty commit and thanks for reverting this @lebedev.ri

Apr 9 2019, 6:51 PM · Restricted Project
shchenz committed rG1383a9168948: [InstCombine] [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y). (authored by shchenz).
[InstCombine] [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y).
Apr 9 2019, 9:35 AM
shchenz committed rL358017: [InstCombine] [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y)..
[InstCombine] [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y).
Apr 9 2019, 9:35 AM
shchenz closed D60395: [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y).
Apr 9 2019, 9:35 AM · Restricted Project
shchenz added a comment to D60395: [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y).

address comments.

Ok, thank you, looks good now.

----------------------------------------
Optimization: nsw preserved
Precondition: true
  %o0 = sub nsw i8 0, %x
  %r = srem i8 %o0, %y
=>
  %n0 = srem i8 %x, %y
  %r = sub nsw i8 0, %n0

Done: 1
Optimization is correct!

@shchenz if you don't intend to immediately-ish submit a patch for that sibling pattern, could you please file a bug?

Apr 9 2019, 9:20 AM · Restricted Project
shchenz updated the diff for D60395: [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y).

address comments.

Apr 9 2019, 6:31 AM · Restricted Project
shchenz committed rG11cf39729257: [InstCombine] add more testcases for canonicalize (-X s/ Y) to -(X s/ Y). (authored by shchenz).
[InstCombine] add more testcases for canonicalize (-X s/ Y) to -(X s/ Y).
Apr 9 2019, 5:49 AM
shchenz committed rL358000: [InstCombine] add more testcases for canonicalize (-X s/ Y) to -(X s/ Y)..
[InstCombine] add more testcases for canonicalize (-X s/ Y) to -(X s/ Y).
Apr 9 2019, 5:49 AM

Apr 8 2019

shchenz accepted D60181: [PowerPC] More precise exploitation of P9 maddld instruction when operands are constant.

LGTM except one minor formating issue. Thansk for fixing this.

Apr 8 2019, 10:40 PM · Restricted Project
shchenz accepted D60426: [InstCombine] prevent possible miscompile with negate+sdiv of vector op.

LGTM for this patch.

Apr 8 2019, 10:38 PM · Restricted Project
shchenz added inline comments to D60395: [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y).
Apr 8 2019, 7:22 PM · Restricted Project
shchenz committed rG19ce6719bc84: [PowerPC] initialize SchedModel according to platform. Differential Revision… (authored by shchenz).
[PowerPC] initialize SchedModel according to platform. Differential Revision…
Apr 8 2019, 6:25 PM
shchenz committed rL357962: [PowerPC] initialize SchedModel according to platform..
[PowerPC] initialize SchedModel according to platform.
Apr 8 2019, 6:24 PM
shchenz closed D60177: [PowerPC] initialize SchedModel according to platform.
Apr 8 2019, 6:24 PM · Restricted Project
shchenz added inline comments to D60396: [InstCombine] sdiv exact flag fixup.
Apr 8 2019, 6:43 AM · Restricted Project
shchenz updated the diff for D60395: [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y).
Apr 8 2019, 6:09 AM · Restricted Project
shchenz updated the diff for D60395: [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y).

address comments.

Apr 8 2019, 5:39 AM · Restricted Project
shchenz committed rG923c7c9daaa5: [InstCombine] sdiv exact flag fixup. (authored by shchenz).
[InstCombine] sdiv exact flag fixup.
Apr 8 2019, 5:07 AM
shchenz committed rL357904: [InstCombine] sdiv exact flag fixup..
[InstCombine] sdiv exact flag fixup.
Apr 8 2019, 5:06 AM
shchenz closed D60396: [InstCombine] sdiv exact flag fixup.
Apr 8 2019, 5:06 AM · Restricted Project
shchenz added a comment to D60395: [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y).

Will fix it later. Thanks for your comments @lebedev.ri

Apr 8 2019, 2:33 AM · Restricted Project
shchenz added a comment to D60396: [InstCombine] sdiv exact flag fixup.

Thanks for your comments Roman @lebedev.ri . Updated.

Apr 8 2019, 2:27 AM · Restricted Project
shchenz updated the diff for D60396: [InstCombine] sdiv exact flag fixup.

address Roman's comments.

Apr 8 2019, 2:27 AM · Restricted Project
shchenz committed rGedf91ed85515: [InstCombine] add more testcases for sdiv exact flag fixup. (authored by shchenz).
[InstCombine] add more testcases for sdiv exact flag fixup.
Apr 8 2019, 2:19 AM
shchenz committed rL357894: [InstCombine] add more testcases for sdiv exact flag fixup..
[InstCombine] add more testcases for sdiv exact flag fixup.
Apr 8 2019, 2:18 AM
shchenz updated the diff for D60396: [InstCombine] sdiv exact flag fixup.

address comments

Apr 8 2019, 1:29 AM · Restricted Project

Apr 7 2019

shchenz updated the diff for D60395: [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y).

move ***exact* flag fixup code to a seperated patch https://reviews.llvm.org/D60396

Apr 7 2019, 11:07 PM · Restricted Project
shchenz created D60396: [InstCombine] sdiv exact flag fixup.
Apr 7 2019, 11:00 PM · Restricted Project
shchenz committed rGd3b1d74624b1: [InstCombine] add testcases for sdiv exact flag fixing - NFC. (authored by shchenz).
[InstCombine] add testcases for sdiv exact flag fixing - NFC.
Apr 7 2019, 10:49 PM
shchenz committed rL357884: [InstCombine] add testcases for sdiv exact flag fixing - NFC..
[InstCombine] add testcases for sdiv exact flag fixing - NFC.
Apr 7 2019, 10:49 PM
shchenz created D60395: [InstCombine] Canonicalize (-X s/ Y) to -(X s/ Y).
Apr 7 2019, 9:45 PM · Restricted Project
shchenz committed rGc84107612ad7: [InstCombine]add testcase for sdiv canonicalizetion - NFC (authored by shchenz).
[InstCombine]add testcase for sdiv canonicalizetion - NFC
Apr 7 2019, 8:09 PM
shchenz committed rL357883: [InstCombine]add testcase for sdiv canonicalizetion - NFC.
[InstCombine]add testcase for sdiv canonicalizetion - NFC
Apr 7 2019, 8:06 PM

Apr 2 2019

shchenz created D60177: [PowerPC] initialize SchedModel according to platform.
Apr 2 2019, 9:32 PM · Restricted Project
shchenz committed rG4178c1533020: [PowerPC]add testcase for ppcctrloops pass shortloop check (authored by shchenz).
[PowerPC]add testcase for ppcctrloops pass shortloop check
Apr 2 2019, 8:11 PM
shchenz committed rL357560: [PowerPC]add testcase for ppcctrloops pass shortloop check.
[PowerPC]add testcase for ppcctrloops pass shortloop check
Apr 2 2019, 8:10 PM

Mar 5 2019

shchenz added a comment to D58595: [TableGen][SelectionDAG][X86] Add specific isel matchers for immAllZerosV/immAllOnesV. Remove bitcasts from X86 patterns that are no longer necessary..

After accpet this patch, the elem MatcherTable[0] in lib/Target/PowerPC/PPCGenDAGISel.inc (same as X86GenDAGISel.inc) is not OPC_SwitchOpcode any more, it becomes OPC_Scope instead.

Mar 5 2019, 8:14 AM · Restricted Project

Mar 4 2019

shchenz committed rG9cfe7e81f154: [PowerPC] fix killed/dead flag after convert x-form to d-form tranformation. (authored by shchenz).
[PowerPC] fix killed/dead flag after convert x-form to d-form tranformation.
Mar 4 2019, 8:57 PM
shchenz committed rL355378: [PowerPC] fix killed/dead flag after convert x-form to d-form tranformation..
[PowerPC] fix killed/dead flag after convert x-form to d-form tranformation.
Mar 4 2019, 8:56 PM
shchenz closed D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.
Mar 4 2019, 8:56 PM · Restricted Project
shchenz updated the diff for D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.

address comments

Mar 4 2019, 7:35 PM · Restricted Project

Feb 26 2019

shchenz updated the diff for D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.

address @jsji comments.

Feb 26 2019, 6:47 PM · Restricted Project
shchenz updated the diff for D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.

address comments

Feb 26 2019, 6:50 AM · Restricted Project

Feb 25 2019

shchenz committed rGb9067e59905b: [NFC] Add to contributor list. (authored by shchenz).
[NFC] Add to contributor list.
Feb 25 2019, 9:46 PM
shchenz committed rL354847: [NFC] Add to contributor list..
[NFC] Add to contributor list.
Feb 25 2019, 9:46 PM
shchenz added inline comments to rL354438: [NFC] add/modify wrapper function for findRegisterDefOperand()..
Feb 25 2019, 5:47 PM

Feb 24 2019

shchenz added a comment to D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.

Thanks for your comments. @jsji

Feb 24 2019, 9:34 PM · Restricted Project
shchenz added inline comments to D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.
Feb 24 2019, 9:33 PM · Restricted Project
shchenz updated the diff for D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.

address @jsji comments

Feb 24 2019, 9:30 PM · Restricted Project

Feb 19 2019

shchenz created D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.
Feb 19 2019, 11:31 PM · Restricted Project
shchenz committed rGb934fce61320: [NFC] add/modify wrapper function for findRegisterDefOperand(). (authored by shchenz).
[NFC] add/modify wrapper function for findRegisterDefOperand().
Feb 19 2019, 11:02 PM
shchenz committed rL354438: [NFC] add/modify wrapper function for findRegisterDefOperand()..
[NFC] add/modify wrapper function for findRegisterDefOperand().
Feb 19 2019, 11:02 PM
shchenz committed rGffece2dfcfd8: [PowerPC] exploit P9 instruction maddld. Differential Revision: https://reviews. (authored by shchenz).
[PowerPC] exploit P9 instruction maddld. Differential Revision: https://reviews.
Feb 19 2019, 6:31 PM
shchenz committed rL354427: [PowerPC] exploit P9 instruction maddld..
[PowerPC] exploit P9 instruction maddld.
Feb 19 2019, 6:31 PM
shchenz closed D58364: [PowerPC] exploit P9 new instruction maddld.
Feb 19 2019, 6:30 PM · Restricted Project
shchenz updated the diff for D58364: [PowerPC] exploit P9 new instruction maddld.

address comments

Feb 19 2019, 6:11 PM · Restricted Project

Feb 18 2019

shchenz updated the summary of D58364: [PowerPC] exploit P9 new instruction maddld.
Feb 18 2019, 6:49 PM · Restricted Project
shchenz created D58364: [PowerPC] exploit P9 new instruction maddld.
Feb 18 2019, 6:41 PM · Restricted Project

Jan 30 2019

shchenz committed rL352689: [PowerPC] delete no more needed workaround for readsRegister() in PowerPC.
[PowerPC] delete no more needed workaround for readsRegister() in PowerPC
Jan 30 2019, 3:18 PM
shchenz closed D57439: [PowerPC] delete no more needed workaround for readsRegister() in PowerPC.
Jan 30 2019, 3:18 PM
shchenz created D57439: [PowerPC] delete no more needed workaround for readsRegister() in PowerPC.
Jan 30 2019, 12:12 AM

Jan 29 2019

shchenz committed rL352583: [PowerPC] more opportunity for converting reg+reg to reg+imm.
[PowerPC] more opportunity for converting reg+reg to reg+imm
Jan 29 2019, 5:59 PM
shchenz closed D57314: [PowerPC] more opportunity for converting reg+reg to reg+imm.
Jan 29 2019, 5:59 PM
shchenz updated the diff for D57314: [PowerPC] more opportunity for converting reg+reg to reg+imm.

use '#' as a comment marker outside of body.

Jan 29 2019, 5:55 PM
shchenz updated the diff for D57314: [PowerPC] more opportunity for converting reg+reg to reg+imm.

@nemanjai Thanks for your comments.

Jan 29 2019, 5:50 PM

Jan 28 2019

shchenz added a reviewer for D57314: [PowerPC] more opportunity for converting reg+reg to reg+imm: stefanp.
Jan 28 2019, 5:41 PM
shchenz updated the diff for D57314: [PowerPC] more opportunity for converting reg+reg to reg+imm.

Thanks for your comment @stefanp. Updated.

Jan 28 2019, 5:41 PM

Jan 27 2019

shchenz edited reviewers for D57314: [PowerPC] more opportunity for converting reg+reg to reg+imm, added: steven.zhang; removed: qshanz.
Jan 27 2019, 8:09 PM
shchenz created D57314: [PowerPC] more opportunity for converting reg+reg to reg+imm.
Jan 27 2019, 8:08 PM

Jan 14 2019

shchenz added a comment to D56679: [InstCombine] Don't undo 0 - (X * Y) canonicalization when combining subs..

Thanks for the fix.

Jan 14 2019, 6:30 PM

Jan 7 2019

shchenz committed rL350587: fix comment typo - NFC.
fix comment typo - NFC
Jan 7 2019, 4:43 PM

Dec 31 2018

shchenz committed rL350185: [InstCombine] canonicalize MUL with NEG operand.
[InstCombine] canonicalize MUL with NEG operand
Dec 31 2018, 5:13 PM
shchenz closed D55961: [InstCombine] canonicalize MUL with NEG operand.
Dec 31 2018, 5:13 PM

Dec 29 2018

shchenz added a comment to D55961: [InstCombine] canonicalize MUL with NEG operand.

@lebedev.ri Updated. Thanks.

Dec 29 2018, 3:59 PM
shchenz updated the diff for D55961: [InstCombine] canonicalize MUL with NEG operand.

fix Roman's comments

Dec 29 2018, 3:55 PM
shchenz added a comment to D55961: [InstCombine] canonicalize MUL with NEG operand.

Hi Roman @lebedev.ri, I have updated according to your comments. Updated testcases are committed in https://reviews.llvm.org/rL350154. Thanks very much.

Dec 29 2018, 4:45 AM
shchenz updated the diff for D55961: [InstCombine] canonicalize MUL with NEG operand.

fix according to Roman's comments.

Dec 29 2018, 4:43 AM
shchenz committed rL350154: [InstCombine] [NFC] update testcases for canonicalize MUL with NEG operand.
[InstCombine] [NFC] update testcases for canonicalize MUL with NEG operand
Dec 29 2018, 4:21 AM

Dec 28 2018

shchenz added a comment to D55961: [InstCombine] canonicalize MUL with NEG operand.

@spatel Hi Sanjay, thanks very much for your comments. I have updated accordingly. Could you please help to have another review? Thanks again.

Dec 28 2018, 6:12 AM
shchenz updated the diff for D55961: [InstCombine] canonicalize MUL with NEG operand.

fix according to Sanjay's comments

Dec 28 2018, 6:10 AM

Dec 27 2018

shchenz committed rL350111: [PowerPC] fix register class after converting X-FORM instruction to D-FORM….
[PowerPC] fix register class after converting X-FORM instruction to D-FORM…
Dec 27 2018, 5:06 PM
shchenz closed D55806: [PowerPC] fix register class after converting X-FORM instruction to D-FORM instruction.
Dec 27 2018, 5:06 PM

Dec 26 2018

shchenz added a comment to D55806: [PowerPC] fix register class after converting X-FORM instruction to D-FORM instruction.

ping.

Dec 26 2018, 10:49 PM