- User Since
- Jun 28 2018, 9:57 PM (145 w, 5 d)
Thanks for the detailed explanation. I am thinking the replaceInstrOperandWithImm is functionality complete.
The issue here is checking an empty implicit operand set by MI.implicit_operands().empty() is not right as the MI is in the construction phase after calling setDesc()
implicit $x5 is in the explicit operand list.
Mon, Apr 12
Sun, Apr 11
Fri, Apr 9
Thu, Apr 8
Thanks for your review @aprantl . Updated accordingly.
1: check the DWARF info instead of the crash
The patch does not support reading and writing debug info. Do you think I should add it to the patch?
Seems the functionality of the llvm-objcopy is not right. Could you please help to check? And maybe we need to add some other tests.
Wed, Apr 7
Tue, Apr 6
Can we set this only for DBX? This should be a limitation for DBX not for AIX?
Mon, Apr 5
hi @jasonliu , thanks a lot for your review.
Fri, Apr 2
Thu, Apr 1
Lint warning fix
Wed, Mar 31
Tue, Mar 30
Thanks for adding objcopy support on AIX.
Fri, Mar 26
Thu, Mar 25
Wed, Mar 24
1: update due to change in D99257
1: LINT warning fix
avoid to use raw new/delete
update for dynamic allocating for the section entries.
Fri, Mar 19
thanks for your review @jasonliu
I will post an NFC patch first to make csect be allocated dynamically.
Wed, Mar 17
LGTM with one minor comment and one idea about further improvement. Thanks for improving this.
fix lint warnings
@jasonliu Thanks for your comments. Please see my inline reply.
address @jasonliu comments
This commit causes some buildbots like X86 and avr fail as:
/home/buildbot/llvm-avr-linux/llvm-avr-linux/llvm/llvm/test/tools/llvm-dwarfdump/XCOFF/Inputs/basic32.o: No available targets are compatible with triple "powerpc-unknown-unknown"
1: correct xlc version
Thanks for review @echristo
use correct file mode
1: rename the binary names
Tue, Mar 16
1: update the testcases
LGTM. Thanks for this improvement.
Maybe it would be best to wait on basic XCOFF yaml2obj support to be finished, add DWARF emission support to that, and then use yaml2obj to generate the DWARF output as required?
Mon, Mar 15
1: add test cases based on objects
Please indicate this is for XCOFF in the title and a follow-up of the patch D97117 in the description.
Mar 15 2021
Mar 10 2021
Thanks for doing this. LGTM too.
rebase due to change in D97049
Mar 9 2021
rebase and some formatting change
Mar 8 2021
Mar 5 2021
Mar 4 2021
@jasonliu Please see my inline comments for the corner case and the left FIXME. Thanks for your review.
1: add more comment
Mar 3 2021
1: address @jasonliu comments