Page MenuHomePhabricator

shchenz (ChenZheng)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2018, 9:57 PM (37 w, 6 d)

Recent Activity

Tue, Mar 5

shchenz added a comment to D58595: [TableGen][SelectionDAG][X86] Add specific isel matchers for immAllZerosV/immAllOnesV. Remove bitcasts from X86 patterns that are no longer necessary..

After accpet this patch, the elem MatcherTable[0] in lib/Target/PowerPC/PPCGenDAGISel.inc (same as X86GenDAGISel.inc) is not OPC_SwitchOpcode any more, it becomes OPC_Scope instead.

Tue, Mar 5, 8:14 AM · Restricted Project

Mon, Mar 4

shchenz committed rG9cfe7e81f154: [PowerPC] fix killed/dead flag after convert x-form to d-form tranformation. (authored by shchenz).
[PowerPC] fix killed/dead flag after convert x-form to d-form tranformation.
Mon, Mar 4, 8:57 PM
shchenz committed rL355378: [PowerPC] fix killed/dead flag after convert x-form to d-form tranformation..
[PowerPC] fix killed/dead flag after convert x-form to d-form tranformation.
Mon, Mar 4, 8:56 PM
shchenz closed D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.
Mon, Mar 4, 8:56 PM · Restricted Project
shchenz updated the diff for D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.

address comments

Mon, Mar 4, 7:35 PM · Restricted Project

Tue, Feb 26

shchenz updated the diff for D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.

address @jsji comments.

Tue, Feb 26, 6:47 PM · Restricted Project
shchenz updated the diff for D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.

address comments

Tue, Feb 26, 6:50 AM · Restricted Project

Mon, Feb 25

shchenz committed rGb9067e59905b: [NFC] Add to contributor list. (authored by shchenz).
[NFC] Add to contributor list.
Mon, Feb 25, 9:46 PM
shchenz committed rL354847: [NFC] Add to contributor list..
[NFC] Add to contributor list.
Mon, Feb 25, 9:46 PM
shchenz added inline comments to rL354438: [NFC] add/modify wrapper function for findRegisterDefOperand()..
Mon, Feb 25, 5:47 PM

Sun, Feb 24

shchenz added a comment to D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.

Thanks for your comments. @jsji

Sun, Feb 24, 9:34 PM · Restricted Project
shchenz added inline comments to D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.
Sun, Feb 24, 9:33 PM · Restricted Project
shchenz updated the diff for D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.

address @jsji comments

Sun, Feb 24, 9:30 PM · Restricted Project

Tue, Feb 19

shchenz created D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.
Tue, Feb 19, 11:31 PM · Restricted Project
shchenz committed rGb934fce61320: [NFC] add/modify wrapper function for findRegisterDefOperand(). (authored by shchenz).
[NFC] add/modify wrapper function for findRegisterDefOperand().
Tue, Feb 19, 11:02 PM
shchenz committed rL354438: [NFC] add/modify wrapper function for findRegisterDefOperand()..
[NFC] add/modify wrapper function for findRegisterDefOperand().
Tue, Feb 19, 11:02 PM
shchenz committed rGffece2dfcfd8: [PowerPC] exploit P9 instruction maddld. Differential Revision: https://reviews. (authored by shchenz).
[PowerPC] exploit P9 instruction maddld. Differential Revision: https://reviews.
Tue, Feb 19, 6:31 PM
shchenz committed rL354427: [PowerPC] exploit P9 instruction maddld..
[PowerPC] exploit P9 instruction maddld.
Tue, Feb 19, 6:31 PM
shchenz closed D58364: [PowerPC] exploit P9 new instruction maddld.
Tue, Feb 19, 6:30 PM · Restricted Project
shchenz updated the diff for D58364: [PowerPC] exploit P9 new instruction maddld.

address comments

Tue, Feb 19, 6:11 PM · Restricted Project

Feb 18 2019

shchenz updated the summary of D58364: [PowerPC] exploit P9 new instruction maddld.
Feb 18 2019, 6:49 PM · Restricted Project
shchenz created D58364: [PowerPC] exploit P9 new instruction maddld.
Feb 18 2019, 6:41 PM · Restricted Project

Jan 30 2019

shchenz committed rL352689: [PowerPC] delete no more needed workaround for readsRegister() in PowerPC.
[PowerPC] delete no more needed workaround for readsRegister() in PowerPC
Jan 30 2019, 3:18 PM
shchenz closed D57439: [PowerPC] delete no more needed workaround for readsRegister() in PowerPC.
Jan 30 2019, 3:18 PM
shchenz created D57439: [PowerPC] delete no more needed workaround for readsRegister() in PowerPC.
Jan 30 2019, 12:12 AM

Jan 29 2019

shchenz committed rL352583: [PowerPC] more opportunity for converting reg+reg to reg+imm.
[PowerPC] more opportunity for converting reg+reg to reg+imm
Jan 29 2019, 5:59 PM
shchenz closed D57314: [PowerPC] more opportunity for converting reg+reg to reg+imm.
Jan 29 2019, 5:59 PM
shchenz updated the diff for D57314: [PowerPC] more opportunity for converting reg+reg to reg+imm.

use '#' as a comment marker outside of body.

Jan 29 2019, 5:55 PM
shchenz updated the diff for D57314: [PowerPC] more opportunity for converting reg+reg to reg+imm.

@nemanjai Thanks for your comments.

Jan 29 2019, 5:50 PM

Jan 28 2019

shchenz added a reviewer for D57314: [PowerPC] more opportunity for converting reg+reg to reg+imm: stefanp.
Jan 28 2019, 5:41 PM
shchenz updated the diff for D57314: [PowerPC] more opportunity for converting reg+reg to reg+imm.

Thanks for your comment @stefanp. Updated.

Jan 28 2019, 5:41 PM

Jan 27 2019

shchenz edited reviewers for D57314: [PowerPC] more opportunity for converting reg+reg to reg+imm, added: steven.zhang; removed: qshanz.
Jan 27 2019, 8:09 PM
shchenz created D57314: [PowerPC] more opportunity for converting reg+reg to reg+imm.
Jan 27 2019, 8:08 PM

Jan 14 2019

shchenz added a comment to D56679: [InstCombine] Don't undo 0 - (X * Y) canonicalization when combining subs..

Thanks for the fix.

Jan 14 2019, 6:30 PM

Jan 7 2019

shchenz committed rL350587: fix comment typo - NFC.
fix comment typo - NFC
Jan 7 2019, 4:43 PM

Dec 31 2018

shchenz committed rL350185: [InstCombine] canonicalize MUL with NEG operand.
[InstCombine] canonicalize MUL with NEG operand
Dec 31 2018, 5:13 PM
shchenz closed D55961: [InstCombine] canonicalize MUL with NEG operand.
Dec 31 2018, 5:13 PM

Dec 29 2018

shchenz added a comment to D55961: [InstCombine] canonicalize MUL with NEG operand.

@lebedev.ri Updated. Thanks.

Dec 29 2018, 3:59 PM
shchenz updated the diff for D55961: [InstCombine] canonicalize MUL with NEG operand.

fix Roman's comments

Dec 29 2018, 3:55 PM
shchenz added a comment to D55961: [InstCombine] canonicalize MUL with NEG operand.

Hi Roman @lebedev.ri, I have updated according to your comments. Updated testcases are committed in https://reviews.llvm.org/rL350154. Thanks very much.

Dec 29 2018, 4:45 AM
shchenz updated the diff for D55961: [InstCombine] canonicalize MUL with NEG operand.

fix according to Roman's comments.

Dec 29 2018, 4:43 AM
shchenz committed rL350154: [InstCombine] [NFC] update testcases for canonicalize MUL with NEG operand.
[InstCombine] [NFC] update testcases for canonicalize MUL with NEG operand
Dec 29 2018, 4:21 AM

Dec 28 2018

shchenz added a comment to D55961: [InstCombine] canonicalize MUL with NEG operand.

@spatel Hi Sanjay, thanks very much for your comments. I have updated accordingly. Could you please help to have another review? Thanks again.

Dec 28 2018, 6:12 AM
shchenz updated the diff for D55961: [InstCombine] canonicalize MUL with NEG operand.

fix according to Sanjay's comments

Dec 28 2018, 6:10 AM

Dec 27 2018

shchenz committed rL350111: [PowerPC] fix register class after converting X-FORM instruction to D-FORM….
[PowerPC] fix register class after converting X-FORM instruction to D-FORM…
Dec 27 2018, 5:06 PM
shchenz closed D55806: [PowerPC] fix register class after converting X-FORM instruction to D-FORM instruction.
Dec 27 2018, 5:06 PM

Dec 26 2018

shchenz added a comment to D55806: [PowerPC] fix register class after converting X-FORM instruction to D-FORM instruction.

ping.

Dec 26 2018, 10:49 PM

Dec 20 2018

shchenz added inline comments to rL349847: [InstCombine] [NFC] testcases for canonicalize MUL with NEG operand.
Dec 20 2018, 3:17 PM
shchenz created D55961: [InstCombine] canonicalize MUL with NEG operand.
Dec 20 2018, 3:16 PM
shchenz committed rL349847: [InstCombine] [NFC] testcases for canonicalize MUL with NEG operand.
[InstCombine] [NFC] testcases for canonicalize MUL with NEG operand
Dec 20 2018, 2:40 PM

Dec 17 2018

shchenz created D55806: [PowerPC] fix register class after converting X-FORM instruction to D-FORM instruction.
Dec 17 2018, 9:07 PM

Dec 13 2018

shchenz committed rL349030: [NFC][PowerPC] add verify-machineinstrs check.
[NFC][PowerPC] add verify-machineinstrs check
Dec 13 2018, 4:58 AM
shchenz committed rL349029: [PowerPC] intrinsic llvm.eh.sjlj.setjmp should not have flag isBarrier..
[PowerPC] intrinsic llvm.eh.sjlj.setjmp should not have flag isBarrier.
Dec 13 2018, 4:28 AM
shchenz closed D55499: [PowerPC] intrinsic llvm.eh.sjlj.setjmp should not have flag isBarrier..
Dec 13 2018, 4:28 AM
shchenz updated the diff for D55499: [PowerPC] intrinsic llvm.eh.sjlj.setjmp should not have flag isBarrier..

Update according to Nemanjai's comments

Dec 13 2018, 4:00 AM

Dec 9 2018

shchenz updated the summary of D55499: [PowerPC] intrinsic llvm.eh.sjlj.setjmp should not have flag isBarrier..
Dec 9 2018, 5:50 PM
shchenz created D55499: [PowerPC] intrinsic llvm.eh.sjlj.setjmp should not have flag isBarrier..
Dec 9 2018, 5:33 PM

Aug 17 2018

shchenz committed rL340000: [MISC]Fix wrong usage of std::equal().
[MISC]Fix wrong usage of std::equal()
Aug 17 2018, 12:51 AM
shchenz closed D49958: [MISC]Fix wrong usage of std::equal().
Aug 17 2018, 12:51 AM

Aug 16 2018

shchenz added a comment to D49958: [MISC]Fix wrong usage of std::equal().

This looks good to me in principle. A few thoughts:

  1. Would be great to have test coverage for [at least some of] this. If it is possible and reasonably easy of course.
  2. I wonder if we should instead create a llvm::is_splat() helper and use it here?
Aug 16 2018, 11:49 PM
shchenz updated the diff for D49958: [MISC]Fix wrong usage of std::equal().
Aug 16 2018, 11:45 PM

Aug 13 2018

shchenz added inline comments to D49958: [MISC]Fix wrong usage of std::equal().
Aug 13 2018, 7:55 PM
shchenz added a comment to D49958: [MISC]Fix wrong usage of std::equal().

Ping?

Aug 13 2018, 7:54 PM

Aug 6 2018

shchenz added a comment to D49958: [MISC]Fix wrong usage of std::equal().

ping? ^_^

Aug 6 2018, 1:24 AM

Jul 29 2018

shchenz added a comment to D49958: [MISC]Fix wrong usage of std::equal().

Thanks all for your comments.

Jul 29 2018, 1:40 AM

Jul 28 2018

shchenz updated the summary of D49958: [MISC]Fix wrong usage of std::equal().
Jul 28 2018, 5:16 PM
shchenz created D49958: [MISC]Fix wrong usage of std::equal().
Jul 28 2018, 7:03 AM
shchenz added a comment to D49837: [SelectionDAG] Handle unary SelectPatternFlavor for ABS case in SelectionDAGBuilder::visitSelect..

Please merge your code with the patch in D48754 and run related tests to check there is no failure.

I merged my code with the latest commits and run tests for X86 arch. For X86 everything is OK.
Now, I plan to make tests for other architectures and test them.
Or should I leave this for follow-up patches?

Jul 28 2018, 5:57 AM · Restricted Project

Jul 26 2018

shchenz added a comment to D49837: [SelectionDAG] Handle unary SelectPatternFlavor for ABS case in SelectionDAGBuilder::visitSelect..

Please merge your code with the patch in D48754 and run related tests to check there is no failure.

Jul 26 2018, 10:02 PM · Restricted Project
shchenz committed rL338092: [InstCombine] canonicalize abs pattern.
[InstCombine] canonicalize abs pattern
Jul 26 2018, 6:50 PM
shchenz closed D48754: [InstCombine] canonicalize abs pattern.
Jul 26 2018, 6:50 PM

Jul 25 2018

shchenz added inline comments to D48754: [InstCombine] canonicalize abs pattern.
Jul 25 2018, 9:39 PM
shchenz updated the diff for D48754: [InstCombine] canonicalize abs pattern.

fix Sanjay's comments.

Jul 25 2018, 9:32 PM

Jul 23 2018

shchenz updated the diff for D48754: [InstCombine] canonicalize abs pattern.

rebase the patch

Jul 23 2018, 11:03 PM

Jul 21 2018

shchenz committed rL337642: [InstrSimplify] fold sdiv if two operands are negated and non-overflow.
[InstrSimplify] fold sdiv if two operands are negated and non-overflow
Jul 21 2018, 5:33 AM
shchenz closed D49382: [InstrSimplify] fold sdiv if two operands are negatived and non-overflow.
Jul 21 2018, 5:33 AM

Jul 20 2018

shchenz added a comment to D49382: [InstrSimplify] fold sdiv if two operands are negatived and non-overflow.

new testcases are added at rL337549

Jul 20 2018, 7:08 AM
shchenz updated the diff for D49382: [InstrSimplify] fold sdiv if two operands are negatived and non-overflow.

Fix Roman's comments

Jul 20 2018, 7:06 AM
shchenz added a comment to D49382: [InstrSimplify] fold sdiv if two operands are negatived and non-overflow.

@lebedev.ri Hi Roman, thanks for your comments. Testcases are committed. And waiting for other reviewer's comment.

Jul 20 2018, 6:45 AM
shchenz committed rL337549: [NFC][testcases] fold sdiv if two operands are negated and non-overflow.
[NFC][testcases] fold sdiv if two operands are negated and non-overflow
Jul 20 2018, 6:44 AM
shchenz committed rL337545: [InstSimplify] fold srem instruction if its two operands are negated..
[InstSimplify] fold srem instruction if its two operands are negated.
Jul 20 2018, 6:06 AM
shchenz closed D49423: [InstSimplify] fold srem instruction if its two operands are negatived..
Jul 20 2018, 6:06 AM
shchenz added a comment to D49423: [InstSimplify] fold srem instruction if its two operands are negatived..

more testcases are added at rL337543

Jul 20 2018, 6:05 AM
shchenz committed rL337543: [NFC][testcases] more testcases for folding srem if its two operands are….
[NFC][testcases] more testcases for folding srem if its two operands are…
Jul 20 2018, 5:59 AM
shchenz updated the diff for D48754: [InstCombine] canonicalize abs pattern.

fix Sanjay's comments

Jul 20 2018, 4:37 AM

Jul 19 2018

shchenz updated the diff for D49423: [InstSimplify] fold srem instruction if its two operands are negatived..

fix Roman's comments

Jul 19 2018, 11:49 PM
shchenz updated the diff for D49382: [InstrSimplify] fold sdiv if two operands are negatived and non-overflow.

fix Roman's comments.

Jul 19 2018, 11:37 PM
shchenz added a comment to D49382: [InstrSimplify] fold sdiv if two operands are negatived and non-overflow.

@lebedev.ri Hi Roman, thanks very much for your comments. I wrongly assumed we only need the cases which are truly transformed by code patch. I will add the cases you point out.

Jul 19 2018, 6:34 PM

Jul 17 2018

shchenz created D49423: [InstSimplify] fold srem instruction if its two operands are negatived..
Jul 17 2018, 6:05 AM
shchenz committed rL337270: [NFC][testcases] add testcases for folding srem whose operands are negatived..
[NFC][testcases] add testcases for folding srem whose operands are negatived.
Jul 17 2018, 5:37 AM
shchenz added a comment to D49382: [InstrSimplify] fold sdiv if two operands are negatived and non-overflow.

@spatel Hi Sanjay, thanks for your comments. I have updated accordingly. For srem instruction, I will make another patch for it. Have a good break^-^

Jul 17 2018, 2:30 AM
shchenz updated the diff for D49382: [InstrSimplify] fold sdiv if two operands are negatived and non-overflow.

fix Sanjay's comments

Jul 17 2018, 2:28 AM

Jul 16 2018

shchenz added a comment to D49409: [testcases] move testcases to right place - NFC.

hmm, no need to create this differential. I just need to commit this directly since this is a little change and already reviewed in D49365.

Jul 16 2018, 6:43 PM
shchenz committed rL337230: [testcases] move testcases to right place - NFC.
[testcases] move testcases to right place - NFC
Jul 16 2018, 6:10 PM
shchenz closed D49409: [testcases] move testcases to right place - NFC.
Jul 16 2018, 6:09 PM
shchenz created D49409: [testcases] move testcases to right place - NFC.
Jul 16 2018, 6:05 PM
shchenz created D49382: [InstrSimplify] fold sdiv if two operands are negatived and non-overflow.
Jul 16 2018, 8:42 AM
shchenz added a comment to D48754: [InstCombine] canonicalize abs pattern.

Actually, it will fail even without the extra use, so this is a minimal test:

define i32 @abs_canonical_9(i32 %a, i32 %b) {
  %tmp2 = sub i32 %b, %a
  %tmp1 = sub i32 %a, %b
  %cmp = icmp sgt i32 %tmp1, -1
  %abs = select i1 %cmp, i32 %tmp1, i32 %tmp2
  ret i32 %abs
}

We can not just replace operands without considering the order of the instructions. It would be better to create a new instruction with the IRBuilder, so we don't have to worry about this problem.

Jul 16 2018, 8:27 AM
shchenz committed rL337179: [InstrSimplify] add testcases for fold sdiv if two operands are negatived and….
[InstrSimplify] add testcases for fold sdiv if two operands are negatived and…
Jul 16 2018, 8:11 AM
shchenz closed D49365: [InstrSimplify] add testcases for fold sdiv if two operands are negatived and non-overflow.
Jul 16 2018, 8:11 AM