Page MenuHomePhabricator
People NeHuang

NeHuang (Victor Huang)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2019, 9:07 AM (167 w, 4 d)

Recent Activity
View All

Feb 25 2022

NeHuang abandoned D117355: [PowerPC] Fix the undef virtual register reading failure for PPC backend trap optimization .
Feb 25 2022, 2:35 PM · Restricted Project

Feb 22 2022

NeHuang added a comment to D117355: [PowerPC] Fix the undef virtual register reading failure for PPC backend trap optimization .

Ping

Feb 22 2022, 11:54 AM · Restricted Project

Feb 11 2022

NeHuang updated the diff for D117355: [PowerPC] Fix the undef virtual register reading failure for PPC backend trap optimization .

Address review comments.

Feb 11 2022, 12:56 PM · Restricted Project

Jan 14 2022

NeHuang requested review of D117355: [PowerPC] Fix the undef virtual register reading failure for PPC backend trap optimization .
Jan 14 2022, 1:01 PM · Restricted Project

Nov 30 2021

NeHuang added inline comments to D114656: [ELF][PPC64] Remove unneeded PPC64PCRelLongBranchThunk.
Nov 30 2021, 8:54 AM · Restricted Project
NeHuang accepted D114656: [ELF][PPC64] Remove unneeded PPC64PCRelLongBranchThunk.
Nov 30 2021, 8:44 AM · Restricted Project

Nov 19 2021

NeHuang committed rG86e77cdb081f: [PowerPC] Add a flag for conditional trap optimization (authored by NeHuang).
[PowerPC] Add a flag for conditional trap optimization
Nov 19 2021, 8:26 AM

Nov 18 2021

NeHuang committed rG40c65655aff9: [PowerPC] Remove the redundant terminator instruction when optimizing… (authored by NeHuang).
[PowerPC] Remove the redundant terminator instruction when optimizing…
Nov 18 2021, 3:53 PM

Nov 17 2021

NeHuang added a comment to D114088: [PowerPC] Add BCD add/sub/cmp builtins.
Nov 17 2021, 11:27 AM · Restricted Project, Restricted Project

Nov 16 2021

NeHuang committed rGae27ca9a6783: [PowerPC] PPC backend optimization on conditional trap intrustions (authored by NeHuang).
[PowerPC] PPC backend optimization on conditional trap intrustions
Nov 16 2021, 11:14 AM
NeHuang closed D111434: [PowerPC] PPC backend optimization on conditional trap intrustions.
Nov 16 2021, 11:13 AM · Restricted Project, Restricted Project
NeHuang updated the diff for D111434: [PowerPC] PPC backend optimization on conditional trap intrustions.

Addressed review comments

Nov 16 2021, 8:15 AM · Restricted Project, Restricted Project
NeHuang added inline comments to D111434: [PowerPC] PPC backend optimization on conditional trap intrustions.
Nov 16 2021, 8:09 AM · Restricted Project, Restricted Project

Nov 11 2021

NeHuang added inline comments to D86706: [LLD][PowerPC] Add a pc-rel based long branch thunk.
Nov 11 2021, 8:24 AM · Restricted Project
NeHuang committed rG18fe0a0d9eb1: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics… (authored by NeHuang).
[PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics…
Nov 11 2021, 7:52 AM
NeHuang closed D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions.
Nov 11 2021, 7:52 AM · Restricted Project

Nov 6 2021

NeHuang updated the diff for D111434: [PowerPC] PPC backend optimization on conditional trap intrustions.

Address review comments

Nov 6 2021, 8:54 AM · Restricted Project, Restricted Project

Nov 4 2021

NeHuang updated the diff for D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions.

Address review comments from @nemanjai

Nov 4 2021, 2:18 PM · Restricted Project
NeHuang updated the diff for D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions.

Addressed review comments from @amy

Nov 4 2021, 5:17 AM · Restricted Project

Nov 3 2021

NeHuang added inline comments to D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions.
Nov 3 2021, 7:54 AM · Restricted Project

Oct 29 2021

NeHuang updated the diff for D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions.

Addressed review comments from @nemanjai and @amyk

Oct 29 2021, 2:49 PM · Restricted Project

Oct 28 2021

NeHuang committed rG40cad47fd82e: [PowerPC][NFC] Update builtins-ppc-xlcompat-trap-64bit-only.ll and builtins-ppc… (authored by NeHuang).
[PowerPC][NFC] Update builtins-ppc-xlcompat-trap-64bit-only.ll and builtins-ppc…
Oct 28 2021, 10:00 AM

Oct 25 2021

NeHuang added a reviewer for D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions: amyk.
Oct 25 2021, 8:18 AM · Restricted Project
NeHuang added a reviewer for D111434: [PowerPC] PPC backend optimization on conditional trap intrustions: amyk.
Oct 25 2021, 8:18 AM · Restricted Project, Restricted Project
NeHuang added a comment to D111434: [PowerPC] PPC backend optimization on conditional trap intrustions.

gentle ping

Oct 25 2021, 8:07 AM · Restricted Project, Restricted Project

Oct 21 2021

NeHuang requested review of D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions.
Oct 21 2021, 5:49 PM · Restricted Project

Oct 18 2021

NeHuang added a comment to D111434: [PowerPC] PPC backend optimization on conditional trap intrustions.

gentle ping

Oct 18 2021, 6:09 PM · Restricted Project, Restricted Project

Oct 12 2021

NeHuang accepted D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter.

Thanks. LGTM. One minor can be addressed when commit it.

Oct 12 2021, 1:11 PM · Restricted Project
NeHuang added a comment to D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter.

Please check and add a test in clang/test/CodeGen/builtins-ppc-xlcompat-rotate.c with shift as a variable.

Oct 12 2021, 11:51 AM · Restricted Project

Oct 8 2021

NeHuang added inline comments to D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter.
Oct 8 2021, 10:38 AM · Restricted Project
NeHuang accepted D110935: [NFC] Update vec_extract builtin signatures to take signed int..

LTGM

Oct 8 2021, 10:28 AM · Restricted Project, Restricted Project, Restricted Project
NeHuang updated the diff for D111434: [PowerPC] PPC backend optimization on conditional trap intrustions.

clang-format

Oct 8 2021, 9:51 AM · Restricted Project, Restricted Project
NeHuang requested review of D111434: [PowerPC] PPC backend optimization on conditional trap intrustions.
Oct 8 2021, 9:07 AM · Restricted Project, Restricted Project

Sep 24 2021

NeHuang committed rG6e1aaf18af6c: [PowerPC] Mark splat immediate instructions as rematerializable (authored by NeHuang).
[PowerPC] Mark splat immediate instructions as rematerializable
Sep 24 2021, 10:07 AM
NeHuang closed D108823: [PowerPC] Mark splat immediate instructions as rematerializable.
Sep 24 2021, 10:06 AM · Restricted Project
NeHuang added inline comments to D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units.
Sep 24 2021, 10:00 AM · Restricted Project, Restricted Project
NeHuang added a comment to D106959: [PowerPC] swdiv builtins for XL compatibility.

Do we already have a backend test case for fdiv emitting a software estimate when -Ofast is used?

Sep 24 2021, 9:46 AM · Restricted Project, Restricted Project
NeHuang added inline comments to D110273: [PowerPC] Fix lharx and lbarx builtin signatures.
Sep 24 2021, 9:01 AM · Restricted Project, Restricted Project, Restricted Project

Sep 7 2021

NeHuang committed rG4a226529e2cf: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields (authored by NeHuang).
[PowerPC] Fixed the crash due to early if conversion with fixed CR fields
Sep 7 2021, 8:51 AM
NeHuang closed D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields..
Sep 7 2021, 8:51 AM · Restricted Project

Sep 3 2021

NeHuang added inline comments to D109178: [PowerPC] Disable vector types when not supported by subtarget features.
Sep 3 2021, 7:28 AM · Restricted Project
NeHuang added inline comments to D108783: [Zorg][PowerPC] Move RHEL bot back to cmake clang factory and add cmake option for test-suite.
Sep 3 2021, 6:57 AM · Restricted Project, Restricted Project

Sep 2 2021

NeHuang updated the diff for D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields..

Address review comments

  • typo update
  • use proper mcpu in the test case.
Sep 2 2021, 3:19 PM · Restricted Project

Aug 30 2021

NeHuang updated the diff for D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields..

Address review comment.

Aug 30 2021, 1:39 PM · Restricted Project
NeHuang committed rG2e5c17d19e37: [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and… (authored by NeHuang).
[PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and…
Aug 30 2021, 7:53 AM
NeHuang closed D108702: [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and vec_clr_last .
Aug 30 2021, 7:53 AM · Restricted Project, Restricted Project

Aug 27 2021

NeHuang requested review of D108823: [PowerPC] Mark splat immediate instructions as rematerializable.
Aug 27 2021, 7:54 AM · Restricted Project

Aug 25 2021

NeHuang requested review of D108702: [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and vec_clr_last .
Aug 25 2021, 7:23 AM · Restricted Project, Restricted Project

Aug 18 2021

NeHuang requested review of D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields..
Aug 18 2021, 7:42 AM · Restricted Project

Aug 12 2021

NeHuang committed rG99e00663d4cd: [PowerPC] Fix return address computation for "__builtin_return_address" (authored by NeHuang).
[PowerPC] Fix return address computation for "__builtin_return_address"
Aug 12 2021, 8:15 AM
NeHuang closed D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address` .
Aug 12 2021, 8:15 AM · Restricted Project

Aug 11 2021

NeHuang updated the diff for D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address` .

Address review comment from Nemanja.

Aug 11 2021, 7:59 AM · Restricted Project
NeHuang committed rGa0977c3f69aa: [PowerPC][NFC] Update llvm/test/CodeGen/PowerPC/2010-05-03-retaddr1.ll with… (authored by NeHuang).
[PowerPC][NFC] Update llvm/test/CodeGen/PowerPC/2010-05-03-retaddr1.ll with…
Aug 11 2021, 7:13 AM
NeHuang accepted D107138: [PowerPC] Implement cmplxl builtins.

LGTM

Aug 11 2021, 5:56 AM · Restricted Project, Restricted Project
NeHuang accepted D107461: [PowerPC] Do not define __PRIVILEGED__.

LGTM

Aug 11 2021, 5:52 AM · Restricted Project
NeHuang accepted D107002: [PowerPC] Implement XL compatibility builtin __addex.
Aug 11 2021, 5:50 AM · Restricted Project, Restricted Project
NeHuang added a comment to D107002: [PowerPC] Implement XL compatibility builtin __addex.

LGTM.

Aug 11 2021, 5:50 AM · Restricted Project, Restricted Project

Aug 10 2021

NeHuang updated the diff for D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address` .

Address review comments on the test case.

Aug 10 2021, 1:03 PM · Restricted Project

Aug 6 2021

NeHuang updated the diff for D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address` .
  • Rebased with ToT
  • Clang-format
Aug 6 2021, 11:32 AM · Restricted Project
NeHuang added inline comments to D106959: [PowerPC] swdiv builtins for XL compatibility.
Aug 6 2021, 9:15 AM · Restricted Project, Restricted Project
NeHuang added inline comments to D107461: [PowerPC] Do not define __PRIVILEGED__.
Aug 6 2021, 9:08 AM · Restricted Project
NeHuang requested review of D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address` .
Aug 6 2021, 7:36 AM · Restricted Project
NeHuang added inline comments to D107138: [PowerPC] Implement cmplxl builtins.
Aug 6 2021, 7:32 AM · Restricted Project, Restricted Project

Jul 30 2021

NeHuang added inline comments to D106959: [PowerPC] swdiv builtins for XL compatibility.
Jul 30 2021, 11:52 AM · Restricted Project, Restricted Project
NeHuang added inline comments to D107138: [PowerPC] Implement cmplxl builtins.
Jul 30 2021, 11:51 AM · Restricted Project, Restricted Project
NeHuang added inline comments to D107002: [PowerPC] Implement XL compatibility builtin __addex.
Jul 30 2021, 11:51 AM · Restricted Project, Restricted Project

Jul 29 2021

NeHuang added a comment to D107050: tsan: add intrusive doubly-linked list.

Hi @dvyukov, this patch was causing a failure on clang-ppc64le-rhel bot https://lab.llvm.org/buildbot/#/builders/57/builds/8932 with a unmatching type issue - line 30 EXPECT_EQ(list.Size(), 0); in compiler-rt/lib/tsan/tests/unit/tsan_ilist_test.cpp.
To unblock our bot, I have committed a fix ac2ffdef9cc8d152801ca87d81736fb1dec9cb88. The latest build passed at https://lab.llvm.org/buildbot/#/builders/57/builds/8971 If you want a different fix, feel free to commit a follow-up fix patch. Thanks.

Jul 29 2021, 7:52 PM · Restricted Project
NeHuang committed rGac2ffdef9cc8: tsan: Fix the improper argument type in tsan_ilist_test.cpp (authored by NeHuang).
tsan: Fix the improper argument type in tsan_ilist_test.cpp
Jul 29 2021, 6:52 PM

Jul 26 2021

NeHuang accepted D106812: [PowerPC] Fix materialization of SP float values on Power10.

LGTM. Thanks.

Jul 26 2021, 3:02 PM · Restricted Project
NeHuang accepted D106817: [PowerPC] Changed sema checking range for tdw td builtin.

LGTM.

Jul 26 2021, 12:50 PM · Restricted Project
NeHuang added inline comments to D106812: [PowerPC] Fix materialization of SP float values on Power10.
Jul 26 2021, 10:50 AM · Restricted Project
NeHuang accepted D106666: [PowerPC]Add addex instruction definition and MC tests.

LGTM.

Jul 26 2021, 7:48 AM · Restricted Project

Jul 22 2021

NeHuang committed rG26ea4a443243: [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility (authored by NeHuang).
[PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility
Jul 22 2021, 8:49 AM
NeHuang closed D106484: [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility.
Jul 22 2021, 8:49 AM · Restricted Project, Restricted Project
NeHuang added inline comments to D106484: [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility.
Jul 22 2021, 7:16 AM · Restricted Project, Restricted Project
NeHuang updated the diff for D106484: [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility.
  • Addressed review comments from Lei
  • Rebased the patch
Jul 22 2021, 7:14 AM · Restricted Project, Restricted Project

Jul 21 2021

NeHuang requested review of D106484: [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility.
Jul 21 2021, 12:54 PM · Restricted Project, Restricted Project
NeHuang updated subscribers of D105946: [PowerPC] Store, load, move from and to registers related builtins.

@jroelofs committed f6769b663a0d4432b5e00e0c03904a5dfba7b077 to move the backend test cases from CodeGen -> CodeGen/PowerPC so they don't fail when the PPC backend isn't built.

Jul 21 2021, 6:32 AM · Restricted Project, Restricted Project
NeHuang added a comment to D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility.

Thanks @jroelofs for moving the test cases! Those cases were added in https://reviews.llvm.org/D105946 and I have notified the author.

Jul 21 2021, 6:30 AM · Restricted Project, Restricted Project

Jul 20 2021

NeHuang committed rG1a762f93f816: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL… (authored by NeHuang).
[PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL…
Jul 20 2021, 11:10 AM
NeHuang closed D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility.
Jul 20 2021, 11:10 AM · Restricted Project, Restricted Project
NeHuang updated the diff for D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility.

clang-format

Jul 20 2021, 6:47 AM · Restricted Project, Restricted Project

Jul 19 2021

NeHuang added a comment to D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility.

Rebased the patch with ToT.

Jul 19 2021, 10:53 AM · Restricted Project, Restricted Project
NeHuang updated the diff for D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility.

Address review comments from Nemanja.

Jul 19 2021, 10:52 AM · Restricted Project, Restricted Project
NeHuang accepted D103986: [PowerPC] Floating Point Builtins for XL Compat..

LGTM

Jul 19 2021, 6:32 AM · Restricted Project, Restricted Project

Jul 16 2021

NeHuang updated the diff for D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility.

Address review comment to rework 32 bit handling.

Jul 16 2021, 3:42 PM · Restricted Project, Restricted Project

Jul 15 2021

NeHuang committed rG4eb107ccbad7: [PowerPC] Add PowerPC population count, reversed load and store related… (authored by NeHuang).
[PowerPC] Add PowerPC population count, reversed load and store related…
Jul 15 2021, 3:24 PM
NeHuang closed D106021: [PowerPC] Add PowerPC population count, reversed load and store related builtins and instrinsics for XL compatibility.
Jul 15 2021, 3:24 PM · Restricted Project, Restricted Project
NeHuang committed rG803cf7ac0c7b: [PowerPC][NFC] Add the missing 'REQUIRES: powerpc-registered-target.' in the… (authored by NeHuang).
[PowerPC][NFC] Add the missing 'REQUIRES: powerpc-registered-target.' in the…
Jul 15 2021, 2:10 PM
NeHuang committed rGd40e8091bd1f: [PowerPC] Add PowerPC rotate related builtins and emit target independent code… (authored by NeHuang).
[PowerPC] Add PowerPC rotate related builtins and emit target independent code…
Jul 15 2021, 8:27 AM
NeHuang closed D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility .
Jul 15 2021, 8:26 AM · Restricted Project, Restricted Project

Jul 14 2021

NeHuang updated the diff for D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility .

Address review comments from Nemanja.

Jul 14 2021, 5:10 PM · Restricted Project, Restricted Project
NeHuang added inline comments to D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility.
Jul 14 2021, 5:10 PM · Restricted Project, Restricted Project
NeHuang updated the summary of D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility.
Jul 14 2021, 2:51 PM · Restricted Project, Restricted Project
NeHuang requested review of D106021: [PowerPC] Add PowerPC population count, reversed load and store related builtins and instrinsics for XL compatibility.
Jul 14 2021, 2:41 PM · Restricted Project, Restricted Project
NeHuang added inline comments to D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility.
Jul 14 2021, 7:52 AM · Restricted Project, Restricted Project

Jul 13 2021

NeHuang committed rG18c19414eb70: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for… (authored by NeHuang).
[PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for…
Jul 13 2021, 2:55 PM
NeHuang closed D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility.
Jul 13 2021, 2:55 PM · Restricted Project, Restricted Project
NeHuang updated the diff for D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility.

Addressed review comments from Nemanja.

Jul 13 2021, 12:53 PM · Restricted Project, Restricted Project
NeHuang committed rG781929b4236b: [PowerPC][NFC] Power ISA features for Semachecking (authored by NeHuang).
[PowerPC][NFC] Power ISA features for Semachecking
Jul 13 2021, 11:24 AM