Page MenuHomePhabricator

NeHuang (Victor Huang)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2019, 9:07 AM (46 w, 3 d)

Recent Activity

Fri, Jan 24

NeHuang added a comment to D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.

Thanks @Yi-Hong.Lyu @nemanjai. The test was in https://reviews.llvm.org/D72574 and moved to this patch.

Fri, Jan 24, 5:55 AM · Restricted Project, Restricted Project
NeHuang committed rG5cee34013cfd: [PowerPC][Future] Add prefixed instruction paddi to future CPU (authored by NeHuang).
[PowerPC][Future] Add prefixed instruction paddi to future CPU
Fri, Jan 24, 5:55 AM
NeHuang closed D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.
Fri, Jan 24, 5:55 AM · Restricted Project, Restricted Project

Wed, Jan 22

NeHuang updated the diff for D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.

Addressed review comments.

Wed, Jan 22, 7:46 AM · Restricted Project, Restricted Project

Fri, Jan 17

NeHuang added inline comments to D72574: [PowerPC][Future] Add pld and pstd to future CPU.
Fri, Jan 17, 3:39 PM · Restricted Project, Restricted Project
NeHuang updated the diff for D72574: [PowerPC][Future] Add pld and pstd to future CPU.

Addressed review comments above.

Fri, Jan 17, 3:39 PM · Restricted Project, Restricted Project
NeHuang updated the diff for D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.

Addressed comments above.

Fri, Jan 17, 3:39 PM · Restricted Project, Restricted Project

Thu, Jan 16

NeHuang added inline comments to D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.
Thu, Jan 16, 7:23 AM · Restricted Project, Restricted Project

Wed, Jan 15

NeHuang updated the diff for D72574: [PowerPC][Future] Add pld and pstd to future CPU.

Thanks @dsanders. Comment addressed.

Wed, Jan 15, 2:52 PM · Restricted Project, Restricted Project
NeHuang commandeered D72574: [PowerPC][Future] Add pld and pstd to future CPU.

Commandeer the patch as Stefan is on vacation.

Wed, Jan 15, 2:52 PM · Restricted Project, Restricted Project
NeHuang updated the diff for D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.

Addressed Nemanja and Daniel's comment to give Inst type uint64_t

Wed, Jan 15, 2:46 PM · Restricted Project, Restricted Project
NeHuang commandeered D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.

Commandeer this patch as Stefan is on vacation.

Wed, Jan 15, 2:37 PM · Restricted Project, Restricted Project
NeHuang updated the summary of D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.
Wed, Jan 15, 12:51 PM · Restricted Project, Restricted Project
NeHuang updated the summary of D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU.
Wed, Jan 15, 12:51 PM · Restricted Project, Restricted Project

Mon, Jan 6

NeHuang updated the diff for D69835: Add options for PPC to enable/disable using non-volatile CR.

Addressed the comments by

  • Add "DisableNonVolatileCR" into "PPCFunctionInfo" as a new property, add the functions to set and check it.
  • Set the new member in the constructor based on the value of the option.
  • Clean up redundant "#2" in the test case.
Mon, Jan 6, 12:42 PM · Restricted Project

Thu, Jan 2

NeHuang added a comment to D71693: [NFC][PowerPC] Add a function tryAndWithMask.

Though the logic in this new function looks consistent with original code with optimized condition check, it is still not that readable to me. Agree with @nemanjai 's suggestion, adding conceptual functions for"SingleRLWINM", "SingleRLWIMI", "SingleRLDICL" and "PairOfRLDICL" will make it more readable. Also added comments for variable re-def issues.

Thu, Jan 2, 12:50 PM · Restricted Project

Nov 14 2019

NeHuang added a comment to D69835: Add options for PPC to enable/disable using non-volatile CR.

@Yi-Hong.Lyu For PowerPC, CR2, CR3, CR4 are non-volatile CR fields according to ELFv2ABI, which will not hold for other ABIs.

Nov 14 2019, 7:58 AM · Restricted Project

Nov 11 2019

NeHuang committed rG6b0af41ad7be: Fixing PowerPC llc test cases for Disable hoisting MI to hotter basic blocks by… (authored by NeHuang).
Fixing PowerPC llc test cases for Disable hoisting MI to hotter basic blocks by…
Nov 11 2019, 3:50 PM
NeHuang committed rGedab7dd42624: Disable hoisting MI to hotter basic blocks (authored by NeHuang).
Disable hoisting MI to hotter basic blocks
Nov 11 2019, 1:43 PM
NeHuang closed D63676: Disable hoisting MI to hotter basic blocks.
Nov 11 2019, 1:43 PM · Restricted Project

Nov 4 2019

NeHuang created D69835: Add options for PPC to enable/disable using non-volatile CR.
Nov 4 2019, 5:33 PM · Restricted Project

Nov 1 2019

NeHuang added a comment to D63676: Disable hoisting MI to hotter basic blocks.

Thanks @xbolva00 for your comment.

Nov 1 2019, 4:16 PM · Restricted Project
NeHuang added a comment to D63676: Disable hoisting MI to hotter basic blocks.

Since the patch is approved, I will hold it for another 3 days if any comment and commit it on Monday.

Nov 1 2019, 5:06 AM · Restricted Project

Oct 28 2019

NeHuang added a comment to D63676: Disable hoisting MI to hotter basic blocks.

ping

Oct 28 2019, 7:34 AM · Restricted Project

Oct 22 2019

NeHuang updated the diff for D63676: Disable hoisting MI to hotter basic blocks.

Addressed review comments from @nemanjai

Oct 22 2019, 11:28 AM · Restricted Project
NeHuang retitled D63676: Disable hoisting MI to hotter basic blocks from Disable hosting MI to hotter basic blocks to Disable hoisting MI to hotter basic blocks.
Oct 22 2019, 10:08 AM · Restricted Project

Oct 21 2019

NeHuang added inline comments to D68443: [PowerPC] Spill CR LT bits on P9 using setb.
Oct 21 2019, 7:53 AM · Restricted Project

Oct 18 2019

NeHuang added inline comments to D69168: [PowerPC] Fold redundant load immediates of zero and delete if possible.
Oct 18 2019, 10:58 AM · Restricted Project

Oct 17 2019

NeHuang added a comment to D69108: [PowerPC] Clang Option for enabling absolute jumptables with command line.

Overall looks good to me. Some minor changes needed.

Oct 17 2019, 7:12 AM · Restricted Project

Oct 7 2019

NeHuang added a comment to D63676: Disable hoisting MI to hotter basic blocks.
  • Merged to latest code base and compiled with -O3 and PGO
  • Collected stats for SPECInt and SPECFP benchmarks (SPEC2017) with baseline and patch.
Benchmark Number of machine instructions hoisted out of loops (Baseline) Number of machine instructions hoisted out of loops (Patch) Number of instructions not hoisted to hotter destination (Patch)
SPECInt206914132007476157
SPECFP425913638368215
  • With the feature enabled, found performance gain for SPEC benchmarks, e.g. 2.1% for perlbench_r and 1.6% for povray_r.
Oct 7 2019, 8:58 AM · Restricted Project

Sep 23 2019

NeHuang added a comment to D63676: Disable hoisting MI to hotter basic blocks.

Collected stats below for SPECInt and SPECFP benchmarks (SPEC2017) with this feature enabled, compiled with -O3 and PGO.

Sep 23 2019, 2:29 PM · Restricted Project
NeHuang added a comment to D63676: Disable hoisting MI to hotter basic blocks.

Thanks @nemanjai 's review. Addressed all the comments and updated the test cases accordingly.

Sep 23 2019, 2:16 PM · Restricted Project
NeHuang updated the diff for D63676: Disable hoisting MI to hotter basic blocks.

Addressed @nemanjai 's review comment.

Sep 23 2019, 2:10 PM · Restricted Project

Sep 13 2019

NeHuang added inline comments to D63676: Disable hoisting MI to hotter basic blocks.
Sep 13 2019, 5:03 AM · Restricted Project

Sep 12 2019

NeHuang added inline comments to D63676: Disable hoisting MI to hotter basic blocks.
Sep 12 2019, 7:25 PM · Restricted Project
NeHuang added inline comments to D63676: Disable hoisting MI to hotter basic blocks.
Sep 12 2019, 7:16 PM · Restricted Project
NeHuang updated the diff for D63676: Disable hoisting MI to hotter basic blocks.

Thanks @lei for the review. Updated the patch to r

  1. Resolve the indentation issues
  2. Modify the variable name to be consistent with current naming convention.
Sep 12 2019, 7:13 PM · Restricted Project
NeHuang updated the summary of D63676: Disable hoisting MI to hotter basic blocks.
Sep 12 2019, 6:46 PM · Restricted Project
NeHuang retitled D63676: Disable hoisting MI to hotter basic blocks from Early exit from Hoist() in machine licm pass based on block hotness to Disable hosting MI to hotter basic blocks.
Sep 12 2019, 6:46 PM · Restricted Project

Aug 22 2019

NeHuang added a comment to D63676: Disable hoisting MI to hotter basic blocks.

@jsji Yes, please ignore diff 216684. Thanks you for the remind.

Aug 22 2019, 1:01 PM · Restricted Project
NeHuang updated the diff for D63676: Disable hoisting MI to hotter basic blocks.
Aug 22 2019, 1:00 PM · Restricted Project
NeHuang added a comment to D63676: Disable hoisting MI to hotter basic blocks.
Aug 22 2019, 12:13 PM · Restricted Project
NeHuang updated the diff for D63676: Disable hoisting MI to hotter basic blocks.
Aug 22 2019, 12:08 PM · Restricted Project

Aug 15 2019

NeHuang added a comment to D63676: Disable hoisting MI to hotter basic blocks.

Thanks @efriedma for the review and remind.

Aug 15 2019, 3:42 PM · Restricted Project

Aug 13 2019

NeHuang added a reviewer for D63676: Disable hoisting MI to hotter basic blocks: Whitney.
Aug 13 2019, 1:11 PM · Restricted Project
NeHuang added a comment to D63676: Disable hoisting MI to hotter basic blocks.

ping

Aug 13 2019, 10:09 AM · Restricted Project

Jul 3 2019

NeHuang added a comment to D63676: Disable hoisting MI to hotter basic blocks.

ping

Jul 3 2019, 2:42 PM · Restricted Project

Jun 21 2019

NeHuang created D63676: Disable hoisting MI to hotter basic blocks.
Jun 21 2019, 2:58 PM · Restricted Project

May 22 2019

NeHuang updated the diff for D62044: [PowerPC] Remove CRBits Copy Of Unset/set CBit.

After re-basing the patch with latest master ToT, there is a LIT failure for the KnowCRBitSpill.ll. As per discussed and reviewed in the meeting, the CRSET test case behavior change is as expected. The test case check logic is updated accordingly.

May 22 2019, 11:29 AM · Restricted Project

May 16 2019

NeHuang created D62044: [PowerPC] Remove CRBits Copy Of Unset/set CBit.
May 16 2019, 4:04 PM · Restricted Project

Apr 1 2019

NeHuang added a comment to D59384: Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp" P9 implementation.

Thanks all for the review!

Apr 1 2019, 12:11 PM · Restricted Project

Mar 25 2019

NeHuang added a comment to D59384: Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp" P9 implementation.

Ping..

Mar 25 2019, 9:32 AM · Restricted Project

Mar 14 2019

NeHuang created D59384: Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp" P9 implementation.
Mar 14 2019, 1:10 PM · Restricted Project