Page MenuHomePhabricator
People NeHuang

NeHuang (Victor Huang)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2019, 9:07 AM (84 w, 4 d)

Recent Activity
View All

Today

NeHuang added a reviewer for D89727: [PowerPC] Fix the Predicates for enabling pcrelative-memops and PLXVP/PSTXVP definitions : steven.zhang.
Mon, Oct 19, 1:45 PM · Restricted Project
NeHuang requested review of D89727: [PowerPC] Fix the Predicates for enabling pcrelative-memops and PLXVP/PSTXVP definitions .
Mon, Oct 19, 1:44 PM · Restricted Project

Mon, Oct 5

NeHuang added inline comments to D87705: [PowerPC] Implement Set Boolean Condition Instructions.
Mon, Oct 5, 12:54 PM · Restricted Project, Restricted Project
NeHuang accepted D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.
Mon, Oct 5, 12:34 PM · Restricted Project
NeHuang added a comment to D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.

LGTM but of course please wait to hear from @sfertile/@MaskRay before committing it.

Mon, Oct 5, 12:34 PM · Restricted Project

Fri, Oct 2

NeHuang requested review of D88738: [PowerPC][PCRelative] Turn on TLS support for PCRel by default.
Fri, Oct 2, 7:51 AM · Restricted Project

Mon, Sep 28

NeHuang added inline comments to D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.
Mon, Sep 28, 1:02 PM · Restricted Project
NeHuang accepted D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.

LGTM but of course, please wait to hear from @sfertile/@MaskRay before committing.

Mon, Sep 28, 12:43 PM · Restricted Project

Thu, Sep 24

NeHuang added inline comments to D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.
Thu, Sep 24, 9:56 AM · Restricted Project
NeHuang added inline comments to D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.
Thu, Sep 24, 9:37 AM · Restricted Project
NeHuang added inline comments to D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits.
Thu, Sep 24, 7:00 AM · Restricted Project

Wed, Sep 23

NeHuang accepted D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits.

LGTM. Only two nits comment.

Wed, Sep 23, 2:36 PM · Restricted Project
NeHuang committed rG652a8f150d49: [PowerPC][PCRelative] Thread Local Storage Support for Local Dynamic (authored by NeHuang).
[PowerPC][PCRelative] Thread Local Storage Support for Local Dynamic
Wed, Sep 23, 11:50 AM
NeHuang closed D87721: [PowerPC][PCRelative] Thread Local Storage Support for Local Dynamic.
Wed, Sep 23, 11:50 AM · Restricted Project
NeHuang updated the diff for D87721: [PowerPC][PCRelative] Thread Local Storage Support for Local Dynamic.

Addressed nits in the implementation and test cases.

Wed, Sep 23, 11:17 AM · Restricted Project

Tue, Sep 22

NeHuang committed rG967e29ff8c8f: [LLD][PowerPC][test] Update thunk range error report for… (authored by NeHuang).
[LLD][PowerPC][test] Update thunk range error report for…
Tue, Sep 22, 5:40 AM
NeHuang closed D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk.
Tue, Sep 22, 5:39 AM · Restricted Project

Mon, Sep 21

NeHuang added inline comments to D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits.
Mon, Sep 21, 1:51 PM · Restricted Project
NeHuang accepted D88030: [PowerPC] Fix for compiler side issue in PCRelative Local Exec.

LGTM.

Mon, Sep 21, 1:36 PM · Restricted Project
NeHuang updated the diff for D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk.

Thanks @MaskRay and @sfertile Test cases have been updated with PHDRS to assign sections to different text segments.

Mon, Sep 21, 1:23 PM · Restricted Project
NeHuang updated the diff for D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk.

Move up the comment in the test case.

Mon, Sep 21, 8:46 AM · Restricted Project
NeHuang added a comment to D87721: [PowerPC][PCRelative] Thread Local Storage Support for Local Dynamic.

Ping.

Mon, Sep 21, 6:16 AM · Restricted Project
NeHuang added a comment to D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk.

Ping.

Mon, Sep 21, 6:15 AM · Restricted Project

Sep 18 2020

NeHuang added inline comments to D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk.
Sep 18 2020, 7:42 AM · Restricted Project

Sep 17 2020

NeHuang updated the diff for D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk.

Clang-format

Sep 17 2020, 2:43 PM · Restricted Project
NeHuang updated the summary of D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk.
Sep 17 2020, 2:41 PM · Restricted Project
NeHuang retitled D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk from [LLD][PowerPC][test] Add test cases for all pc-rel based stubs when the offset not fit in 34 bits to [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk.
Sep 17 2020, 2:40 PM · Restricted Project
NeHuang updated the diff for D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk.

Rebased with ToT to integrate with the changes in https://reviews.llvm.org/D87486

Sep 17 2020, 2:28 PM · Restricted Project
NeHuang committed rGa4bb71b1c0d9: Disable hoisting MI to hotter basic blocks when using pgo (authored by NeHuang).
Disable hoisting MI to hotter basic blocks when using pgo
Sep 17 2020, 12:21 PM
NeHuang closed D85240: Disable hoisting MI to hotter basic blocks when using pgo.
Sep 17 2020, 12:20 PM · Restricted Project

Sep 15 2020

NeHuang requested review of D87721: [PowerPC][PCRelative] Thread Local Storage Support for Local Dynamic.
Sep 15 2020, 1:38 PM · Restricted Project

Sep 11 2020

NeHuang added a comment to D85240: Disable hoisting MI to hotter basic blocks when using pgo.

@davidxl We found SPEC2017 performance gain for PPC. Some experiments results available at https://reviews.llvm.org/D63676

Sep 11 2020, 10:12 AM · Restricted Project
NeHuang added inline comments to D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk.
Sep 11 2020, 9:14 AM · Restricted Project
NeHuang updated the diff for D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk.

Addressed review comments to

  • Change the error message
  • Change the LIT test accordingly
Sep 11 2020, 9:14 AM · Restricted Project
NeHuang added a comment to D85240: Disable hoisting MI to hotter basic blocks when using pgo.

Ping.

Sep 11 2020, 8:52 AM · Restricted Project

Sep 10 2020

NeHuang added inline comments to D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk.
Sep 10 2020, 1:41 PM · Restricted Project

Sep 9 2020

NeHuang requested review of D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk.
Sep 9 2020, 7:52 AM · Restricted Project

Sep 3 2020

NeHuang accepted D86608: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec.

LGTM. I only have some comments on the nits.

Sep 3 2020, 8:34 AM · Restricted Project
NeHuang added inline comments to D86608: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec.
Sep 3 2020, 8:34 AM · Restricted Project
NeHuang committed rGdb367ff2d8d0: [LLD][PowerPC][test] Fix out-of-memory issue running ppc64-pcrel-long-branch… (authored by NeHuang).
[LLD][PowerPC][test] Fix out-of-memory issue running ppc64-pcrel-long-branch…
Sep 3 2020, 7:09 AM

Sep 1 2020

NeHuang added inline comments to D86608: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec.
Sep 1 2020, 1:20 PM · Restricted Project
NeHuang added inline comments to D86893: [PowerPC] Add support for R_PPC64_GOT_TPREL_PCREL34 used in TLS Initial Exec.
Sep 1 2020, 12:47 PM · Restricted Project

Aug 28 2020

NeHuang committed rG0becc27ebfec: [LLD][PowerPC] Remove redundant file write out in the test cases (authored by NeHuang).
[LLD][PowerPC] Remove redundant file write out in the test cases
Aug 28 2020, 1:10 PM
NeHuang committed rGbfc76366125b: [LLD][PowerPC] Add a pc-rel based long branch thunk (authored by NeHuang).
[LLD][PowerPC] Add a pc-rel based long branch thunk
Aug 28 2020, 8:42 AM
NeHuang closed D86706: [LLD][PowerPC] Add a pc-rel based long branch thunk.
Aug 28 2020, 8:42 AM · Restricted Project
NeHuang retitled D86706: [LLD][PowerPC] Add a pc-rel based long branch thunk from [LLD][PowerPC] Add pc-rel based long branch thunks to [LLD][PowerPC] Add a pc-rel based long branch thunk.
Aug 28 2020, 8:38 AM · Restricted Project
NeHuang updated the diff for D86706: [LLD][PowerPC] Add a pc-rel based long branch thunk.

Updated fatal error message in the LIT test

Aug 28 2020, 8:33 AM · Restricted Project
NeHuang added inline comments to D86706: [LLD][PowerPC] Add a pc-rel based long branch thunk.
Aug 28 2020, 7:52 AM · Restricted Project
NeHuang updated the diff for D86706: [LLD][PowerPC] Add a pc-rel based long branch thunk.

Address Sean's comment for fatal error message.

Aug 28 2020, 7:50 AM · Restricted Project

Aug 27 2020

NeHuang updated the diff for D86706: [LLD][PowerPC] Add a pc-rel based long branch thunk.
Aug 27 2020, 2:35 PM · Restricted Project
NeHuang added inline comments to D86706: [LLD][PowerPC] Add a pc-rel based long branch thunk.
Aug 27 2020, 2:34 PM · Restricted Project
NeHuang added inline comments to D86706: [LLD][PowerPC] Add a pc-rel based long branch thunk.
Aug 27 2020, 1:31 PM · Restricted Project
NeHuang updated the diff for D86706: [LLD][PowerPC] Add a pc-rel based long branch thunk.

Update the patch without using branch_lt table.

Aug 27 2020, 10:29 AM · Restricted Project
NeHuang added inline comments to D86706: [LLD][PowerPC] Add a pc-rel based long branch thunk.
Aug 27 2020, 10:28 AM · Restricted Project
NeHuang edited reviewers for D86706: [LLD][PowerPC] Add a pc-rel based long branch thunk, added: sfertile; removed: Sean.
Aug 27 2020, 6:18 AM · Restricted Project
NeHuang requested review of D86706: [LLD][PowerPC] Add a pc-rel based long branch thunk.
Aug 27 2020, 6:17 AM · Restricted Project

Aug 24 2020

NeHuang accepted D86343: [PowerPC] Use SDISel instead of FISel for calls and TOC-based accesses with PC-Rel.

LGTM. Only a nit can be addressed while committing the patch.

Aug 24 2020, 2:16 PM · Restricted Project

Aug 18 2020

NeHuang added inline comments to D86142: [LLD] Search archives for non-tentative defintions..
Aug 18 2020, 9:48 AM · Restricted Project, Restricted Project

Aug 17 2020

NeHuang added inline comments to D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.
Aug 17 2020, 3:24 PM · Restricted Project
NeHuang added inline comments to D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang.
Aug 17 2020, 1:50 PM · Restricted Project, Restricted Project, Restricted Project
NeHuang added a comment to D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang.

Overall LGTM. I only have some comments on the nits.

Aug 17 2020, 1:27 PM · Restricted Project, Restricted Project
NeHuang added inline comments to D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.
Aug 17 2020, 11:39 AM · Restricted Project
NeHuang committed rG7b391245d8ea: [PowerPC] Fix thunk alignment issue when using pc-rel instruction (authored by NeHuang).
[PowerPC] Fix thunk alignment issue when using pc-rel instruction
Aug 17 2020, 7:10 AM
NeHuang closed D85973: [PowerPC] Fix thunk alignment issue when using pc-rel instruction .
Aug 17 2020, 7:10 AM · Restricted Project

Aug 14 2020

NeHuang added inline comments to D85973: [PowerPC] Fix thunk alignment issue when using pc-rel instruction .
Aug 14 2020, 2:08 PM · Restricted Project
NeHuang added inline comments to D85973: [PowerPC] Fix thunk alignment issue when using pc-rel instruction .
Aug 14 2020, 12:59 PM · Restricted Project
NeHuang updated the diff for D85973: [PowerPC] Fix thunk alignment issue when using pc-rel instruction .

Thanks MaskRay. The additional test removed.

Aug 14 2020, 12:56 PM · Restricted Project
NeHuang edited reviewers for D85973: [PowerPC] Fix thunk alignment issue when using pc-rel instruction , added: sfertile; removed: Sean.
Aug 14 2020, 12:12 PM · Restricted Project
NeHuang updated the diff for D85973: [PowerPC] Fix thunk alignment issue when using pc-rel instruction .
  • Updated the LIT cases accordingly.
  • Create a test case for thunk alignment fix.
Aug 14 2020, 11:38 AM · Restricted Project
NeHuang requested review of D85973: [PowerPC] Fix thunk alignment issue when using pc-rel instruction .
Aug 14 2020, 7:33 AM · Restricted Project

Aug 12 2020

NeHuang added inline comments to D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.
Aug 12 2020, 4:56 PM · Restricted Project, Restricted Project
NeHuang added a comment to D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.

Overall the patch looks good to me. I only have two questions and a clang-format nit which can be resolved before committing the code.

Aug 12 2020, 3:31 PM · Restricted Project, Restricted Project

Aug 7 2020

NeHuang accepted D85377: [PowerPC] Add option to control PCRel GOT indirect linker optimization.

Thanks! LGTM.

Aug 7 2020, 12:29 PM · Restricted Project
NeHuang committed rG6c64f05b905e: [PowerPC] Add compatibility check for PPC PLT stubs (authored by NeHuang).
[PowerPC] Add compatibility check for PPC PLT stubs
Aug 7 2020, 6:51 AM
NeHuang closed D85459: [PowerPC] Add compatibility check for PPC PLT stubs .
Aug 7 2020, 6:51 AM · Restricted Project
NeHuang added inline comments to D85459: [PowerPC] Add compatibility check for PPC PLT stubs .
Aug 7 2020, 5:58 AM · Restricted Project
NeHuang updated the diff for D85459: [PowerPC] Add compatibility check for PPC PLT stubs .

Addressed the comment to check R_PPC64_REL24 and R_PPC64_REL14 for PPC64PltCallStub compatibility check.

Aug 7 2020, 5:57 AM · Restricted Project

Aug 6 2020

NeHuang added a comment to D85377: [PowerPC] Add option to control PCRel GOT indirect linker optimization.

Overall LGTM. I only have some nits comment/question for the test case and clang-format related issue.

Aug 6 2020, 1:51 PM · Restricted Project
NeHuang updated the diff for D85459: [PowerPC] Add compatibility check for PPC PLT stubs .

Fixed nits in the test case to

  • Add start address.
  • Fix indentations.
Aug 6 2020, 1:14 PM · Restricted Project
NeHuang added a reviewer for D85459: [PowerPC] Add compatibility check for PPC PLT stubs : hfinkel.
Aug 6 2020, 11:40 AM · Restricted Project
NeHuang requested review of D85459: [PowerPC] Add compatibility check for PPC PLT stubs .
Aug 6 2020, 11:39 AM · Restricted Project

Aug 4 2020

NeHuang updated the summary of D85240: Disable hoisting MI to hotter basic blocks when using pgo.
Aug 4 2020, 12:37 PM · Restricted Project
NeHuang requested review of D85240: Disable hoisting MI to hotter basic blocks when using pgo.
Aug 4 2020, 12:37 PM · Restricted Project

Jul 30 2020

NeHuang accepted D84901: [Sanitizers] Fix lint failure with Python 3.6.

LGTM.

Jul 30 2020, 2:17 PM · Restricted Project
NeHuang added inline comments to D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.
Jul 30 2020, 11:24 AM · Restricted Project, Restricted Project, Restricted Project

Jul 29 2020

NeHuang committed rG8dbea4785c10: [PowerPC] Support for R_PPC64_REL24_NOTOC calls where the caller has no TOC and… (authored by NeHuang).
[PowerPC] Support for R_PPC64_REL24_NOTOC calls where the caller has no TOC and…
Jul 29 2020, 12:51 PM
NeHuang closed D83669: [PowerPC] Support for R_PPC64_REL24_NOTOC calls where the caller has no TOC and the callee is not DSO local.
Jul 29 2020, 12:51 PM · Restricted Project
NeHuang updated subscribers of D83669: [PowerPC] Support for R_PPC64_REL24_NOTOC calls where the caller has no TOC and the callee is not DSO local.
Jul 29 2020, 5:30 AM · Restricted Project
NeHuang updated the diff for D83669: [PowerPC] Support for R_PPC64_REL24_NOTOC calls where the caller has no TOC and the callee is not DSO local.

Thanks Sean for the review. Addressed the nits for clang-format and alignment issues.

Jul 29 2020, 5:30 AM · Restricted Project

Jul 28 2020

NeHuang updated the diff for D83669: [PowerPC] Support for R_PPC64_REL24_NOTOC calls where the caller has no TOC and the callee is not DSO local.

As the patch https://reviews.llvm.org/D83834 is reverted, updated the test case accordingly to combine ppc64-callee-global.s and ppc64-pcrel-call-to-extern.s with .ifdef AUX

Jul 28 2020, 3:09 PM · Restricted Project
NeHuang added inline comments to D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.
Jul 28 2020, 1:27 PM · Restricted Project, Restricted Project
NeHuang added inline comments to D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.
Jul 28 2020, 1:20 PM · Restricted Project, Restricted Project

Jul 24 2020

NeHuang added inline comments to D83669: [PowerPC] Support for R_PPC64_REL24_NOTOC calls where the caller has no TOC and the callee is not DSO local.
Jul 24 2020, 10:10 AM · Restricted Project
NeHuang updated the diff for D83669: [PowerPC] Support for R_PPC64_REL24_NOTOC calls where the caller has no TOC and the callee is not DSO local.

Thank you all for the review!

  • Addressed the nits and update the test case.
  • Combined ppc64-callee-global.s with ppc64-pcrel-call-to-extern.s using extract.
Jul 24 2020, 9:58 AM · Restricted Project

Jul 21 2020

NeHuang added inline comments to D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.
Jul 21 2020, 3:43 PM · Restricted Project, Restricted Project
NeHuang added a comment to D81947: [PowerPC][PCRelative] Thread Local Storage Support for Initial Exec.

Overall looks fine to me, but of course please wait to hear from Stefan and Nemanja.
Some nits added.

Jul 21 2020, 3:04 PM · Restricted Project, Restricted Project

Jul 20 2020

NeHuang committed rG91cce1a2bc34: [PowerPC] Implement R_PPC64_REL24_NOTOC local calls, callee requires a TOC (authored by NeHuang).
[PowerPC] Implement R_PPC64_REL24_NOTOC local calls, callee requires a TOC
Jul 20 2020, 9:17 PM
NeHuang closed D83504: [PowerPC] Implement R_PPC64_REL24_NOTOC local calls. callee has a TOC.
Jul 20 2020, 9:17 PM · Restricted Project
NeHuang updated the diff for D83669: [PowerPC] Support for R_PPC64_REL24_NOTOC calls where the caller has no TOC and the callee is not DSO local.

Thanks Sean.

  • Removed the redundant check in needsThunk
  • Renamed the new stub as suggested, updated comments and the test case accordingly.
Jul 20 2020, 9:16 PM · Restricted Project

Jul 17 2020

NeHuang added inline comments to D83504: [PowerPC] Implement R_PPC64_REL24_NOTOC local calls. callee has a TOC.
Jul 17 2020, 10:14 AM · Restricted Project