User Details
- User Since
- Mar 7 2019, 9:07 AM (167 w, 4 d)
Feb 25 2022
Feb 22 2022
Ping
Feb 11 2022
Address review comments.
Jan 14 2022
Nov 30 2021
Nov 19 2021
Nov 18 2021
Nov 17 2021
Nov 16 2021
Addressed review comments
Nov 11 2021
Nov 6 2021
Address review comments
Nov 4 2021
Address review comments from @nemanjai
Addressed review comments from @amy
Nov 3 2021
Oct 29 2021
Oct 28 2021
Oct 25 2021
gentle ping
Oct 21 2021
Oct 18 2021
gentle ping
Oct 12 2021
Thanks. LGTM. One minor can be addressed when commit it.
Please check and add a test in clang/test/CodeGen/builtins-ppc-xlcompat-rotate.c with shift as a variable.
Oct 8 2021
LTGM
clang-format
Sep 24 2021
Do we already have a backend test case for fdiv emitting a software estimate when -Ofast is used?
Sep 7 2021
Sep 3 2021
Sep 2 2021
Address review comments
- typo update
- use proper mcpu in the test case.
Aug 30 2021
Address review comment.
Aug 27 2021
Aug 25 2021
Aug 18 2021
Aug 12 2021
Aug 11 2021
Address review comment from Nemanja.
LGTM
LGTM
LGTM.
Aug 10 2021
Address review comments on the test case.
Aug 6 2021
- Rebased with ToT
- Clang-format
Jul 30 2021
Jul 29 2021
Hi @dvyukov, this patch was causing a failure on clang-ppc64le-rhel bot https://lab.llvm.org/buildbot/#/builders/57/builds/8932 with a unmatching type issue - line 30 EXPECT_EQ(list.Size(), 0); in compiler-rt/lib/tsan/tests/unit/tsan_ilist_test.cpp.
To unblock our bot, I have committed a fix ac2ffdef9cc8d152801ca87d81736fb1dec9cb88. The latest build passed at https://lab.llvm.org/buildbot/#/builders/57/builds/8971 If you want a different fix, feel free to commit a follow-up fix patch. Thanks.
Jul 26 2021
LGTM. Thanks.
LGTM.
LGTM.
Jul 22 2021
- Addressed review comments from Lei
- Rebased the patch
Jul 21 2021
@jroelofs committed f6769b663a0d4432b5e00e0c03904a5dfba7b077 to move the backend test cases from CodeGen -> CodeGen/PowerPC so they don't fail when the PPC backend isn't built.
Thanks @jroelofs for moving the test cases! Those cases were added in https://reviews.llvm.org/D105946 and I have notified the author.
Jul 20 2021
clang-format
Jul 19 2021
Rebased the patch with ToT.
Address review comments from Nemanja.
LGTM
Jul 16 2021
Address review comment to rework 32 bit handling.
Jul 15 2021
Jul 14 2021
Address review comments from Nemanja.
Jul 13 2021
Addressed review comments from Nemanja.