Page MenuHomePhabricator

NeHuang (Victor Huang)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2019, 9:07 AM (31 w, 5 d)

Recent Activity

Mon, Oct 7

NeHuang added a comment to D63676: Disable hosting MI to hotter basic blocks.
  • Merged to latest code base and compiled with -O3 and PGO
  • Collected stats for SPECInt and SPECFP benchmarks (SPEC2017) with baseline and patch.
Benchmark Number of machine instructions hoisted out of loops (Baseline) Number of machine instructions hoisted out of loops (Patch) Number of instructions not hoisted to hotter destination (Patch)
SPECInt206914132007476157
SPECFP425913638368215
  • With the feature enabled, found performance gain for SPEC benchmarks, e.g. 2.1% for perlbench_r and 1.6% for povray_r.
Mon, Oct 7, 8:58 AM · Restricted Project

Mon, Sep 23

NeHuang added a comment to D63676: Disable hosting MI to hotter basic blocks.

Collected stats below for SPECInt and SPECFP benchmarks (SPEC2017) with this feature enabled, compiled with -O3 and PGO.

Mon, Sep 23, 2:29 PM · Restricted Project
NeHuang added a comment to D63676: Disable hosting MI to hotter basic blocks.

Thanks @nemanjai 's review. Addressed all the comments and updated the test cases accordingly.

Mon, Sep 23, 2:16 PM · Restricted Project
NeHuang updated the diff for D63676: Disable hosting MI to hotter basic blocks.

Addressed @nemanjai 's review comment.

Mon, Sep 23, 2:10 PM · Restricted Project

Sep 13 2019

NeHuang added inline comments to D63676: Disable hosting MI to hotter basic blocks.
Sep 13 2019, 5:03 AM · Restricted Project

Sep 12 2019

NeHuang added inline comments to D63676: Disable hosting MI to hotter basic blocks.
Sep 12 2019, 7:25 PM · Restricted Project
NeHuang added inline comments to D63676: Disable hosting MI to hotter basic blocks.
Sep 12 2019, 7:16 PM · Restricted Project
NeHuang updated the diff for D63676: Disable hosting MI to hotter basic blocks.

Thanks @lei for the review. Updated the patch to r

  1. Resolve the indentation issues
  2. Modify the variable name to be consistent with current naming convention.
Sep 12 2019, 7:13 PM · Restricted Project
NeHuang updated the summary of D63676: Disable hosting MI to hotter basic blocks.
Sep 12 2019, 6:46 PM · Restricted Project
NeHuang retitled D63676: Disable hosting MI to hotter basic blocks from Early exit from Hoist() in machine licm pass based on block hotness to Disable hosting MI to hotter basic blocks.
Sep 12 2019, 6:46 PM · Restricted Project

Aug 22 2019

NeHuang added a comment to D63676: Disable hosting MI to hotter basic blocks.

@jsji Yes, please ignore diff 216684. Thanks you for the remind.

Aug 22 2019, 1:01 PM · Restricted Project
NeHuang updated the diff for D63676: Disable hosting MI to hotter basic blocks.
Aug 22 2019, 1:00 PM · Restricted Project
NeHuang added a comment to D63676: Disable hosting MI to hotter basic blocks.
Aug 22 2019, 12:13 PM · Restricted Project
NeHuang updated the diff for D63676: Disable hosting MI to hotter basic blocks.
Aug 22 2019, 12:08 PM · Restricted Project

Aug 15 2019

NeHuang added a comment to D63676: Disable hosting MI to hotter basic blocks.

Thanks @efriedma for the review and remind.

Aug 15 2019, 3:42 PM · Restricted Project

Aug 13 2019

NeHuang added a reviewer for D63676: Disable hosting MI to hotter basic blocks: Whitney.
Aug 13 2019, 1:11 PM · Restricted Project
NeHuang added a comment to D63676: Disable hosting MI to hotter basic blocks.

ping

Aug 13 2019, 10:09 AM · Restricted Project

Jul 3 2019

NeHuang added a comment to D63676: Disable hosting MI to hotter basic blocks.

ping

Jul 3 2019, 2:42 PM · Restricted Project

Jun 21 2019

NeHuang created D63676: Disable hosting MI to hotter basic blocks.
Jun 21 2019, 2:58 PM · Restricted Project

May 22 2019

NeHuang updated the diff for D62044: [PowerPC] Remove CRBits Copy Of Unset/set CBit.

After re-basing the patch with latest master ToT, there is a LIT failure for the KnowCRBitSpill.ll. As per discussed and reviewed in the meeting, the CRSET test case behavior change is as expected. The test case check logic is updated accordingly.

May 22 2019, 11:29 AM · Restricted Project

May 16 2019

NeHuang created D62044: [PowerPC] Remove CRBits Copy Of Unset/set CBit.
May 16 2019, 4:04 PM · Restricted Project

Apr 1 2019

NeHuang added a comment to D59384: Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp" P9 implementation.

Thanks all for the review!

Apr 1 2019, 12:11 PM · Restricted Project

Mar 25 2019

NeHuang added a comment to D59384: Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp" P9 implementation.

Ping..

Mar 25 2019, 9:32 AM · Restricted Project

Mar 14 2019

NeHuang created D59384: Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp" P9 implementation.
Mar 14 2019, 1:10 PM · Restricted Project