User Details
- User Since
- Oct 24 2016, 11:46 AM (297 w, 1 d)
Wed, Jun 29
Wed, Jun 22
LGTM
Thx!
Tue, Jun 21
Mon, Jun 20
Thu, Jun 16
Address review comments from Nemanja
Simplify vec_replace_[elt|unaligned] code gen.
Move error checking for vec_replace_unaligned to during code gen.
Wed, Jun 15
rebase to ToT
LGTM, just a few nit that can be addressed on commit.
Add fix for vec_replace_elt and vec_replace_unaligned.
Please document all new functions added.
Tue, Jun 7
LGTM
Thx
May 25 2022
LGTM
LGTM
Thx for fixing this.
May 18 2022
May 17 2022
LGTM with minor updates before commit.
Mar 9 2022
This also failing on all our bots:
https://lab.llvm.org/buildbot/#/builders/105/builds/22623
https://lab.llvm.org/buildbot/#/builders/100/builds/13530
Mar 4 2022
Mar 3 2022
Commited to release/14.x via ce1e90fc8dbacdaff0310e50090ec3cfdfce4def
remove unintented change
Feb 28 2022
LGTM
Feb 25 2022
LGTM
Thx
Feb 24 2022
LGTM
Thx for cleaning up.
Feb 16 2022
Feb 3 2022
Not a silly question at all!
Initially I thought that I didn't need to update the tests because I wan't changing code and the CHECK/CHECK-NEXT lines don't really care that there are comments that come after the instructions. This is true in most cases but there are tests that already have a comment after the instruction line (for example # 8-byte Folded Spill) and in those cases by adding a second comment I'm adding a new line and the CHECK-NEXT lines don't work anymore. Anyway, I'm going to update those tests now.
LGTM
Thx for the cleanup!
Jan 18 2022
LGTM, just a minor comment.
Nov 25 2021
fix indentation.
Nov 24 2021
LGTM other then the comment about the unecessary code block.
Nov 18 2021
Switch to using new cmake variable to control comments.
Nov 17 2021
Nov 16 2021
Instead of adding:
if (isMMAType(Src)) return InstructionCost::getMax();
to all the different cost calculating functions, is it possible to just add them the underlying functions?
Nov 15 2021
address review comments
Nov 12 2021
Oct 18 2021
LGTM
I think you went a bit overkill with the tests for this patch 🙂. Please cut down the number of run lines before committing.
Oct 4 2021
address line comment and update tc to reflect new behaviour.
Sep 27 2021
LGTM
Address review comments and add handling for vector long types without vsx.
Sep 24 2021
LGTM
Pleases address nit on commit.
Sep 23 2021
LGTM
Please add comment to tc upon commit.
LGTM once the code is simplified as Nemanja suggested.
LGTM.
Pleases address the test issue on commit.
Sep 21 2021
LGTM
thx
Sep 20 2021
LGTM
thx!
LGTM
Thx.
LGTM.
Thx!
LTGM
Thx!
LGTM
Thx!
Sep 7 2021
LGTM
Thx!
Sep 2 2021
fix spelling in commit message.
Is it really necessary to add the BE checks in this patch if they are the same as LE checks? Why not just add it later when there is a diff seen?
Aug 26 2021
Aug 25 2021
LGTM
I think there is something wrong with this diff cause there is no context available for PPCInstrInfo.cpp.
Aug 12 2021
Fix name of new warning message to be more accuratly represent the diagnostic.
Update diag id
Aug 11 2021
Add -W flag to new warning message
Aug 10 2021
Actually we should not be removing the deprecated bultins. Just need to add the new ones.