User Details
- User Since
- Oct 24 2016, 11:46 AM (221 w, 3 d)
Dec 17 2020
LGTM
Dec 16 2020
Minor nit to be addressed upon commit. Thx!
Nov 25 2020
Thank-you!
Nov 24 2020
This seem to be only failing for our bot that uses the lld linker. Does not affect bots using the ld linker.
Testscase is expecting
This patch broke our rhel bot: clang-ppc64le-rhel
The subsequent patch to fix symlink name did not fix the original failure seen:
Nov 18 2020
Actually it;s the previous patch that causes the regression: 246b428fb3b5d58685064966bcea6592f8839b7e
Nov 17 2020
This patch broke the clang-ppc64le* buildbots: http://lab.llvm.org:8011/#/builders/105/builds/1907
Pleases upload fix or pull.
Nov 9 2020
Nov 2 2020
thx for the fix.
Oct 23 2020
LGTM. Thanks for the update.
Please address the additional comments on commit.
Oct 22 2020
For the p10 specific tests, I think just use the default CHECK vs CHECK-P10.
Also, please ensure we are testing on both BE and LE.
Sep 18 2020
LGTM. Thx!
please fix the clang format issues.
Just some minor comments. Please address them prior to commit.
Sep 17 2020
LGTM
Sep 11 2020
LGTM
Aug 26 2020
LGTM
Thx!
Jul 29 2020
Jul 27 2020
Please address the auto generated clang-format issues for the added code in this patch.
Jul 23 2020
LGTM
thx!
LGTM
Why are you removing MC tests for here?
LGTM,
Please add tests for BE in llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll prior to committing.
Jul 10 2020
LGTM
Please address the nits on commit.
Jul 9 2020
LGTM
LGTM thx.
Jul 8 2020
This LGTM, just wondering why you have not included testing for BE.
Jul 7 2020
Jul 6 2020
LGTM
LGTM
Jul 3 2020
This patch doesn't contain full context. Please regenerate with -U999999.
I will commit this for Biplob since he does't have commit access yet.
Jul 2 2020
LGTM.
LGTM
Jul 1 2020
rename test file and add additional ccomments to code.
revert changes to the if condition
Remove unnecessary FIXME message, accidental formating, and simplify if-condition as suggested by Victor.
- clean up condition code in isFPImmLegal()
- split test file into pcrel and non-pcrel related, clean up checks
- add test for BE elfv2
Taking over ownership to address review comments.
Please address nits and file name changes on commit.
p10-permute-ops.ll => builtins-ppc-p10permute.ll
Looks like this file is being created in several diff patches you have up for review.
p10-permute-ops.ll => builtins-ppc-p10permute.ll
Please use similar naming for all new builtin test files:
p10-permute-ops.ll => builtins-ppc-p10permute.ll