Page MenuHomePhabricator

lei (Lei Huang)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2016, 11:46 AM (344 w, 5 d)

Recent Activity

Mar 13 2023

lei accepted D144611: [PowerPC] Adding test coverage for vector compatibility warning.

thx for the added coverage.
LGTM

Mar 13 2023, 12:07 PM · Restricted Project, Restricted Project
lei accepted D145506: [PowerPC] Emit warn_deprecated_lax_vec_conv_all warning only for PPC.

LGTM
Thx

Mar 13 2023, 11:52 AM · Restricted Project, Restricted Project

Feb 21 2023

lei added a comment to D126122: Fix RUNPATH not accounting for LLVM_ENABLE_PER_TARGET_RUNTIME_DIR.

Since @phosek requested changes, this now require his review to see if his concerns are addressed.
@phosek can you please take a look at this patch to see if it addresses your concerns? PowerPC require this patch for our libcxx builds.

Feb 21 2023, 7:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 2 2023

lei added a comment to D126122: Fix RUNPATH not accounting for LLVM_ENABLE_PER_TARGET_RUNTIME_DIR.

@lei long time ago. Let me rebase it on main.
I assume after that is committed you'll "cherry-pick" into 16.x via GH issue?

Feb 2 2023, 9:35 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
lei added a comment to D126122: Fix RUNPATH not accounting for LLVM_ENABLE_PER_TARGET_RUNTIME_DIR.

Since Eric mentioned above that he didn't mean to block this patch and he hasn't come back to it, I am going to assume it is okay to land this patch now. I can help to commit this tomorrow if we don't get any blocking comments by then.

Feb 2 2023, 9:30 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
lei added a comment to D126122: Fix RUNPATH not accounting for LLVM_ENABLE_PER_TARGET_RUNTIME_DIR.

@arcivanov are you still waiting for Eric to respond or are you looking for help to commit this patch?

Feb 2 2023, 8:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 30 2023

lei updated subscribers of D126122: Fix RUNPATH not accounting for LLVM_ENABLE_PER_TARGET_RUNTIME_DIR.

@tstellar PowerPC would need this patch enable to publish a build with libcxx. When does this patch need to land enable to get this into LLVM 16.0?

Jan 30 2023, 2:40 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
lei added a comment to D126122: Fix RUNPATH not accounting for LLVM_ENABLE_PER_TARGET_RUNTIME_DIR.

It would be great if we can get this in 16.

Jan 30 2023, 10:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 26 2023

lei added inline comments to D133103: [PowerPC] Improve kill flag computation and add verification after MI peephole.
Jan 26 2023, 7:40 AM · Restricted Project, Restricted Project

Jan 23 2023

lei accepted D126122: Fix RUNPATH not accounting for LLVM_ENABLE_PER_TARGET_RUNTIME_DIR.

This patch fixes the exact problem I am seeing when building on PowerPC for -DLLVM_ENABLE_RUNTIMES=compiler-rt;libcxx;libcxxabi -DLLVM_ENABLE_LIBCXX:BOOL=ON.
I have applied this patch and tested it on the ppcle rhel/aix/flang/mlir bots and it does not cause any regressions so this LGTM.

Jan 23 2023, 1:23 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 16 2023

lei committed rGee559b21b961: [P10] Fix the implementation for BRH (authored by lei).
[P10] Fix the implementation for BRH
Jan 16 2023, 11:54 AM · Restricted Project, Restricted Project
lei closed D141697: [P10] Fix the implementation for BRH.
Jan 16 2023, 11:53 AM · Restricted Project, Restricted Project

Jan 13 2023

lei committed rGb227c6a8fd1d: [PowerPC][NFC] Add missing P10 code enablement asm/disasm tests (authored by lei).
[PowerPC][NFC] Add missing P10 code enablement asm/disasm tests
Jan 13 2023, 10:29 AM · Restricted Project, Restricted Project
lei requested review of D141697: [P10] Fix the implementation for BRH.
Jan 13 2023, 8:09 AM · Restricted Project, Restricted Project

Dec 21 2022

lei accepted D138844: [PowerPC] Materialize floats in the range [-16.0, 15.0]..

Thanks! This LGTM

Dec 21 2022, 11:25 AM · Restricted Project, Restricted Project
lei committed rG7a7e9109a2d6: [PowerPC] Implement P10 Byte Reverse Insructions (authored by lei).
[PowerPC] Implement P10 Byte Reverse Insructions
Dec 21 2022, 7:16 AM · Restricted Project, Restricted Project
lei closed D140414: [PowerPC] Implement P10 Byte Reverse Insructions.
Dec 21 2022, 7:16 AM · Restricted Project, Restricted Project

Dec 20 2022

lei committed rGbfde3bdd2609: [PowerPC][NFC] Update p10 scheduler (authored by lei).
[PowerPC][NFC] Update p10 scheduler
Dec 20 2022, 12:58 PM · Restricted Project, Restricted Project
lei updated the diff for D140414: [PowerPC] Implement P10 Byte Reverse Insructions.

fix test doc wording

Dec 20 2022, 12:01 PM · Restricted Project, Restricted Project
lei added inline comments to D138844: [PowerPC] Materialize floats in the range [-16.0, 15.0]..
Dec 20 2022, 11:14 AM · Restricted Project, Restricted Project
lei requested review of D140414: [PowerPC] Implement P10 Byte Reverse Insructions.
Dec 20 2022, 9:10 AM · Restricted Project, Restricted Project

Dec 12 2022

lei added a reverting change for rGa2b0673dbe5d: [scudo] Enable more warnings for standalone build: rG58f153432031: Revert "[scudo] Enable more warnings for standalone build".
Dec 12 2022, 7:26 AM · Restricted Project, Restricted Project
lei committed rG58f153432031: Revert "[scudo] Enable more warnings for standalone build" (authored by lei).
Revert "[scudo] Enable more warnings for standalone build"
Dec 12 2022, 7:26 AM · Restricted Project, Restricted Project
lei added a reverting change for D122761: [scudo] Enable more warnings for standalone build: rG58f153432031: Revert "[scudo] Enable more warnings for standalone build".
Dec 12 2022, 7:26 AM · Restricted Project, Restricted Project
lei added a comment to D122761: [scudo] Enable more warnings for standalone build.

Please note that this patch broke any bots that build this project with -Werror (example: https://lab.llvm.org/buildbot/#/builders/19/builds/14037). As a result, I have reverted it since there has been no fix within a reasonable time.
May I advise ensuring that a project is clean wrt. to the additional warnings when turning on extra warnings as there are bound to be some builds that use -Werror. Also, new warnings are almost always disruptive changes as there are many different build configurations that may be affected in unforeseen ways. If you have such a disruptive change ready to commit, it is advisable to wait until Monday to commit it rather than committing it on a Friday evening as most people are disconnecting.

Dec 12 2022, 7:26 AM · Restricted Project, Restricted Project

Nov 30 2022

lei accepted D139007: [TestSuiteBuilder] Updating the build config of the PPC Rhel bot.

LGTM
Thx!

Nov 30 2022, 10:38 AM · Restricted Project

Nov 29 2022

lei committed rGa25f7c530a91: [NFC] Fix indentation in td file (authored by lei).
[NFC] Fix indentation in td file
Nov 29 2022, 10:12 AM · Restricted Project, Restricted Project

Nov 4 2022

lei added inline comments to D136992: [PowerPC] Add new load/store with length instructions to Future CPU..
Nov 4 2022, 6:06 AM · Restricted Project, Restricted Project
lei added inline comments to D135806: [sanitizers] Controlling the build width and targets for PowerPC sanitizers.
Nov 4 2022, 5:52 AM · Restricted Project

Sep 28 2022

lei accepted D133577: [PowerPC] Change CRNOT to a code gen single operand instruction.

LGTM
Thx

Sep 28 2022, 2:46 PM · Restricted Project, Restricted Project
lei accepted D134501: [PowerPC] Fix the register allocation hints for ACC registers..

LGTM
Thx

Sep 28 2022, 2:38 PM · Restricted Project, Restricted Project

Sep 26 2022

lei added inline comments to D133940: Change PowerPC64 bots to build runtimes with -DLLVM_ENABLE_RUNTIMES.
Sep 26 2022, 7:56 AM · Restricted Project

Aug 16 2022

lei committed rG7d8ae9f755d7: [NFC][PowerPC] Add missing NOCOMPAT checks for builtins-ppc-xlcompat.c (authored by lei).
[NFC][PowerPC] Add missing NOCOMPAT checks for builtins-ppc-xlcompat.c
Aug 16 2022, 11:56 AM · Restricted Project, Restricted Project
lei closed D131622: [NFC][PowerPC] Add missing NOCOMPAT checks for builtins-ppc-xlcompat.c.
Aug 16 2022, 11:56 AM · Restricted Project, Restricted Project

Aug 10 2022

lei requested review of D131622: [NFC][PowerPC] Add missing NOCOMPAT checks for builtins-ppc-xlcompat.c.
Aug 10 2022, 2:48 PM · Restricted Project, Restricted Project

Jul 28 2022

lei added inline comments to D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard.
Jul 28 2022, 6:08 AM · Restricted Project, Restricted Project, Restricted Project

Jul 20 2022

lei accepted D130090: [PowerPC][NFC] Convert the MMA test cases to use opaque pointers..

1 missed bitcast, otherwise LGTM

Jul 20 2022, 7:18 AM · Restricted Project, Restricted Project

Jul 18 2022

lei added a comment to D121276: [CMake] Include runtimes test suites in check-all.

@phosek It seems the runtime tests are no longer running for us after this patch in PPC bot https://lab.llvm.org/buildbot/#/builders/57. I can see they are still ran when it's part of LLVM_ENABLE_PROJECTS, but this bot specifies compiler-rt as LLVM_ENABLE_RT=compiler-rt.

Jul 18 2022, 1:17 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 29 2022

lei committed rGcaf7243a6b53: [PowerPC] Fix signatures for vec_replace_unaligned builtin (authored by lei).
[PowerPC] Fix signatures for vec_replace_unaligned builtin
Jun 29 2022, 7:36 AM · Restricted Project, Restricted Project
lei closed D128288: [PowerPC] Fix signatures for vec_replace_unaligned builtin.
Jun 29 2022, 7:36 AM · Restricted Project, Restricted Project

Jun 22 2022

lei accepted D128287: [GlobalMerge] Ensure that the MustKeepGlobalVariables has all globals from each landingpad clause..

LGTM
Thx!

Jun 22 2022, 7:09 AM · Restricted Project, Restricted Project

Jun 21 2022

lei requested review of D128288: [PowerPC] Fix signatures for vec_replace_unaligned builtin.
Jun 21 2022, 9:59 AM · Restricted Project, Restricted Project

Jun 20 2022

lei committed rGe09f6ff3c19a: [PowerPC] Disable automatic generation of STXVP (authored by nemanjai).
[PowerPC] Disable automatic generation of STXVP
Jun 20 2022, 12:31 PM · Restricted Project, Restricted Project
lei closed D127218: [PowerPC] Disable automatic generation of STXVP.
Jun 20 2022, 12:31 PM · Restricted Project, Restricted Project

Jun 16 2022

lei committed rG711a71d1ab10: PowerPC] Emit warning for incompatible vector types that are currently… (authored by maryammo).
PowerPC] Emit warning for incompatible vector types that are currently…
Jun 16 2022, 6:29 PM · Restricted Project, Restricted Project
lei closed D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.
Jun 16 2022, 6:28 PM · Restricted Project, Restricted Project
lei committed rGfebe4f650b87: [PowerPC][NFC] Undefine __XL_COMPAT_ALTIVEC__ in builtin lit test (authored by lei).
[PowerPC][NFC] Undefine __XL_COMPAT_ALTIVEC__ in builtin lit test
Jun 16 2022, 6:17 PM · Restricted Project, Restricted Project
lei committed rGdba2ff500d5b: fix x86 sanitizer failure due to use of or (authored by lei).
fix x86 sanitizer failure due to use of or
Jun 16 2022, 3:21 PM · Restricted Project, Restricted Project
lei committed rGa9ddb7d54e34: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions (authored by maryammo).
[PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions
Jun 16 2022, 3:07 PM · Restricted Project, Restricted Project
lei closed D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.
Jun 16 2022, 3:07 PM · Restricted Project, Restricted Project, Restricted Project
lei added inline comments to D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.
Jun 16 2022, 12:43 PM · Restricted Project, Restricted Project, Restricted Project
lei updated the diff for D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.

Address review comments from Nemanja

Jun 16 2022, 11:24 AM · Restricted Project, Restricted Project, Restricted Project
lei commandeered D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.
Jun 16 2022, 10:10 AM · Restricted Project, Restricted Project, Restricted Project
lei updated the diff for D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.

Simplify vec_replace_[elt|unaligned] code gen.

Jun 16 2022, 7:48 AM · Restricted Project, Restricted Project, Restricted Project
lei updated the diff for D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.

Move error checking for vec_replace_unaligned to during code gen.

Jun 16 2022, 5:45 AM · Restricted Project, Restricted Project, Restricted Project
lei added inline comments to D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.
Jun 16 2022, 5:44 AM · Restricted Project, Restricted Project
lei added inline comments to D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.
Jun 16 2022, 5:40 AM · Restricted Project, Restricted Project

Jun 15 2022

lei updated the diff for D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.

rebase to ToT

Jun 15 2022, 8:06 PM · Restricted Project, Restricted Project, Restricted Project
lei added a comment to D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.

LGTM, just a few nit that can be addressed on commit.

Jun 15 2022, 7:37 PM · Restricted Project, Restricted Project
lei updated the diff for D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.

Add fix for vec_replace_elt and vec_replace_unaligned.

Jun 15 2022, 7:05 PM · Restricted Project, Restricted Project, Restricted Project
lei added a comment to D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.

Please document all new functions added.

Jun 15 2022, 10:46 AM · Restricted Project, Restricted Project

Jun 7 2022

lei accepted D127218: [PowerPC] Disable automatic generation of STXVP.

LGTM
Thx

Jun 7 2022, 11:36 AM · Restricted Project, Restricted Project

May 25 2022

lei accepted D126075: [PowerPC][Future] Add an ISA Future to go with mcpu=future..

LGTM

May 25 2022, 12:35 PM · Restricted Project, Restricted Project
lei accepted D125389: [PowerPC][AIX] Allow VSX patterns to be 32-bit and 64-bit safe on P8+..

LGTM
Thx for fixing this.

May 25 2022, 12:28 PM · Restricted Project, Restricted Project

May 18 2022

lei added inline comments to D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins..
May 18 2022, 7:38 AM · Restricted Project, Restricted Project, Restricted Project

May 17 2022

lei accepted D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins..

LGTM with minor updates before commit.

May 17 2022, 11:56 AM · Restricted Project, Restricted Project, Restricted Project

Mar 9 2022

lei added a comment to D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.

This also failing on all our bots:
https://lab.llvm.org/buildbot/#/builders/105/builds/22623
https://lab.llvm.org/buildbot/#/builders/100/builds/13530

Mar 9 2022, 4:37 AM · Restricted Project, Restricted Project

Mar 4 2022

Herald added a project to D117013: [PowerPC] Set the special DSCR with a compiler option.: Restricted Project.
Mar 4 2022, 9:22 AM · Restricted Project, Restricted Project

Mar 3 2022

lei closed D120907: [docs] Add PowerPC release notes for LLVM 14.

Commited to release/14.x via ce1e90fc8dbacdaff0310e50090ec3cfdfce4def

Mar 3 2022, 10:27 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
lei added a comment to D120907: [docs] Add PowerPC release notes for LLVM 14.

LGTM for libc++. I assume this is targeting release/14.x only.

Mar 3 2022, 9:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
lei updated the diff for D120907: [docs] Add PowerPC release notes for LLVM 14.

remove unintented change

Mar 3 2022, 7:00 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
lei requested review of D120907: [docs] Add PowerPC release notes for LLVM 14.
Mar 3 2022, 6:58 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 28 2022

lei accepted D120680: [PowerPC] Remove redundant MMA patterns..

LGTM

Feb 28 2022, 5:15 PM · Restricted Project

Feb 25 2022

lei accepted D120530: [PowerPC][NFC] Add file info and license that was missing from this file..

LGTM
Thx

Feb 25 2022, 7:50 AM · Restricted Project

Feb 24 2022

lei accepted D120515: [PowerPC][NFC] Split out the MMA instructions from the P10 instructions..

LGTM
Thx for cleaning up.

Feb 24 2022, 3:25 PM · Restricted Project
lei added inline comments to D120515: [PowerPC][NFC] Split out the MMA instructions from the P10 instructions..
Feb 24 2022, 1:55 PM · Restricted Project

Feb 16 2022

lei committed rG5abe6c312bb2: [PowerPC] Rename PPCInstrPrefix.td to PPCInstrP10.td (authored by lei).
[PowerPC] Rename PPCInstrPrefix.td to PPCInstrP10.td
Feb 16 2022, 8:23 AM

Feb 3 2022

lei added a comment to D116743: [PowerPC] Add assembly comments for instructions that use the vector registers..

Not a silly question at all!
Initially I thought that I didn't need to update the tests because I wan't changing code and the CHECK/CHECK-NEXT lines don't really care that there are comments that come after the instructions. This is true in most cases but there are tests that already have a comment after the instruction line (for example # 8-byte Folded Spill) and in those cases by adding a second comment I'm adding a new line and the CHECK-NEXT lines don't work anymore. Anyway, I'm going to update those tests now.

Feb 3 2022, 12:35 PM · Restricted Project
lei added inline comments to D116743: [PowerPC] Add assembly comments for instructions that use the vector registers..
Feb 3 2022, 12:31 PM · Restricted Project
lei accepted D118074: [PowerPC] Remove the LDMX instruction..

LGTM
Thx for the cleanup!

Feb 3 2022, 11:16 AM · Restricted Project

Jan 18 2022

lei accepted D117507: [PowerPC] Add the Power10 LXVKQ instrution..

LGTM, just a minor comment.

Jan 18 2022, 7:15 AM · Restricted Project

Nov 25 2021

lei committed rG1db1cb028db5: [CMake] Add new cmake option to control adding comments in GenDAGISel (authored by lei).
[CMake] Add new cmake option to control adding comments in GenDAGISel
Nov 25 2021, 10:11 AM
lei closed D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel.
Nov 25 2021, 10:11 AM · Restricted Project
lei updated the diff for D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel.

fix indentation.

Nov 25 2021, 8:37 AM · Restricted Project
lei updated the summary of D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel.
Nov 25 2021, 6:25 AM · Restricted Project

Nov 24 2021

lei accepted D113900: [PowerPC] Prevent the optimizer from producing wide vector types in IR..

LGTM other then the comment about the unecessary code block.

Nov 24 2021, 11:41 AM · Restricted Project, Unknown Object (Project)

Nov 18 2021

lei retitled D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel from [CMake] Add LLVM_OMIT_DAGISEL_COMMENTS to control adding comments in GenDAGISel to [CMake] Add new cmake option to control adding comments in GenDAGISel.
Nov 18 2021, 3:57 PM · Restricted Project
lei retitled D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel from [CMake] Use NDEBUG macro to control adding comments in GenDAGISel.inc to [CMake] Add LLVM_OMIT_DAGISEL_COMMENTS to control adding comments in GenDAGISel.
Nov 18 2021, 3:56 PM · Restricted Project
lei updated the diff for D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel.

Switch to using new cmake variable to control comments.

Nov 18 2021, 3:48 PM · Restricted Project

Nov 17 2021

lei added a reviewer for D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel: Restricted Project.
Nov 17 2021, 2:05 PM · Restricted Project
lei requested review of D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel.
Nov 17 2021, 2:03 PM · Restricted Project

Nov 16 2021

lei added a comment to D113900: [PowerPC] Prevent the optimizer from producing wide vector types in IR..

Instead of adding:

if (isMMAType(Src))
    return InstructionCost::getMax();

to all the different cost calculating functions, is it possible to just add them the underlying functions?

Nov 16 2021, 12:17 PM · Restricted Project, Unknown Object (Project)

Nov 15 2021

lei committed rGf50c6c17185c: [PowerPC] Fix 32bit vector insert instructions for ISA3.1 (authored by lei).
[PowerPC] Fix 32bit vector insert instructions for ISA3.1
Nov 15 2021, 12:37 PM
lei closed D113802: [PowerPC] Fix 32bit vector insert instructions for ISA3.1.
Nov 15 2021, 12:36 PM · Restricted Project
lei updated the diff for D113802: [PowerPC] Fix 32bit vector insert instructions for ISA3.1.

address review comments

Nov 15 2021, 10:31 AM · Restricted Project
lei added inline comments to D113802: [PowerPC] Fix 32bit vector insert instructions for ISA3.1.
Nov 15 2021, 10:10 AM · Restricted Project
lei added inline comments to D113802: [PowerPC] Fix 32bit vector insert instructions for ISA3.1.
Nov 15 2021, 9:20 AM · Restricted Project

Nov 12 2021

lei added reviewers for D113802: [PowerPC] Fix 32bit vector insert instructions for ISA3.1: nemanjai, stefanp, ZarkoCA, power-llvm-team.
Nov 12 2021, 1:19 PM · Restricted Project
lei requested review of D113802: [PowerPC] Fix 32bit vector insert instructions for ISA3.1.
Nov 12 2021, 1:17 PM · Restricted Project

Oct 18 2021

lei accepted D109652: [PowerPC] Restrict various P10 options to P10 only..

LGTM
I think you went a bit overkill with the tests for this patch 🙂. Please cut down the number of run lines before committing.

Oct 18 2021, 7:50 AM · Restricted Project, Restricted Project, Restricted Project