Page MenuHomePhabricator

lei (Lei Huang)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2016, 11:46 AM (297 w, 1 d)

Recent Activity

Wed, Jun 29

lei committed rGcaf7243a6b53: [PowerPC] Fix signatures for vec_replace_unaligned builtin (authored by lei).
[PowerPC] Fix signatures for vec_replace_unaligned builtin
Wed, Jun 29, 7:36 AM · Restricted Project, Restricted Project
lei closed D128288: [PowerPC] Fix signatures for vec_replace_unaligned builtin.
Wed, Jun 29, 7:36 AM · Restricted Project, Restricted Project

Wed, Jun 22

lei accepted D128287: [GlobalMerge] Ensure that the MustKeepGlobalVariables has all globals from each landingpad clause..

LGTM
Thx!

Wed, Jun 22, 7:09 AM · Restricted Project, Restricted Project

Tue, Jun 21

lei requested review of D128288: [PowerPC] Fix signatures for vec_replace_unaligned builtin.
Tue, Jun 21, 9:59 AM · Restricted Project, Restricted Project

Mon, Jun 20

lei committed rGe09f6ff3c19a: [PowerPC] Disable automatic generation of STXVP (authored by nemanjai).
[PowerPC] Disable automatic generation of STXVP
Mon, Jun 20, 12:31 PM · Restricted Project, Restricted Project
lei closed D127218: [PowerPC] Disable automatic generation of STXVP.
Mon, Jun 20, 12:31 PM · Restricted Project, Restricted Project

Thu, Jun 16

lei committed rG711a71d1ab10: PowerPC] Emit warning for incompatible vector types that are currently… (authored by maryammo).
PowerPC] Emit warning for incompatible vector types that are currently…
Thu, Jun 16, 6:29 PM · Restricted Project, Restricted Project
lei closed D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.
Thu, Jun 16, 6:28 PM · Restricted Project, Restricted Project
lei committed rGfebe4f650b87: [PowerPC][NFC] Undefine __XL_COMPAT_ALTIVEC__ in builtin lit test (authored by lei).
[PowerPC][NFC] Undefine __XL_COMPAT_ALTIVEC__ in builtin lit test
Thu, Jun 16, 6:17 PM · Restricted Project, Restricted Project
lei committed rGdba2ff500d5b: fix x86 sanitizer failure due to use of or (authored by lei).
fix x86 sanitizer failure due to use of or
Thu, Jun 16, 3:21 PM · Restricted Project, Restricted Project
lei committed rGa9ddb7d54e34: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions (authored by maryammo).
[PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions
Thu, Jun 16, 3:07 PM · Restricted Project, Restricted Project
lei closed D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.
Thu, Jun 16, 3:07 PM · Restricted Project, Restricted Project, Restricted Project
lei added inline comments to D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.
Thu, Jun 16, 12:43 PM · Restricted Project, Restricted Project, Restricted Project
lei updated the diff for D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.

Address review comments from Nemanja

Thu, Jun 16, 11:24 AM · Restricted Project, Restricted Project, Restricted Project
lei commandeered D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.
Thu, Jun 16, 10:10 AM · Restricted Project, Restricted Project, Restricted Project
lei updated the diff for D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.

Simplify vec_replace_[elt|unaligned] code gen.

Thu, Jun 16, 7:48 AM · Restricted Project, Restricted Project, Restricted Project
lei updated the diff for D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.

Move error checking for vec_replace_unaligned to during code gen.

Thu, Jun 16, 5:45 AM · Restricted Project, Restricted Project, Restricted Project
lei added inline comments to D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.
Thu, Jun 16, 5:44 AM · Restricted Project, Restricted Project
lei added inline comments to D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.
Thu, Jun 16, 5:40 AM · Restricted Project, Restricted Project

Wed, Jun 15

lei updated the diff for D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.

rebase to ToT

Wed, Jun 15, 8:06 PM · Restricted Project, Restricted Project, Restricted Project
lei added a comment to D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.

LGTM, just a few nit that can be addressed on commit.

Wed, Jun 15, 7:37 PM · Restricted Project, Restricted Project
lei updated the diff for D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions.

Add fix for vec_replace_elt and vec_replace_unaligned.

Wed, Jun 15, 7:05 PM · Restricted Project, Restricted Project, Restricted Project
lei added a comment to D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions.

Please document all new functions added.

Wed, Jun 15, 10:46 AM · Restricted Project, Restricted Project

Tue, Jun 7

lei accepted D127218: [PowerPC] Disable automatic generation of STXVP.

LGTM
Thx

Tue, Jun 7, 11:36 AM · Restricted Project, Restricted Project

May 25 2022

lei accepted D126075: [PowerPC][Future] Add an ISA Future to go with mcpu=future..

LGTM

May 25 2022, 12:35 PM · Restricted Project, Restricted Project
lei accepted D125389: [PowerPC][AIX] Allow VSX patterns to be 32-bit and 64-bit safe on P8+..

LGTM
Thx for fixing this.

May 25 2022, 12:28 PM · Restricted Project, Restricted Project

May 18 2022

lei added inline comments to D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins..
May 18 2022, 7:38 AM · Restricted Project, Restricted Project, Restricted Project

May 17 2022

lei accepted D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins..

LGTM with minor updates before commit.

May 17 2022, 11:56 AM · Restricted Project, Restricted Project, Restricted Project

Mar 9 2022

lei added a comment to D120602: [MSAN] add interceptor for timer_create, timer_settime, timer_gettime.

This also failing on all our bots:
https://lab.llvm.org/buildbot/#/builders/105/builds/22623
https://lab.llvm.org/buildbot/#/builders/100/builds/13530

Mar 9 2022, 4:37 AM · Restricted Project, Restricted Project

Mar 4 2022

Herald added a project to D117013: [PowerPC] Set the special DSCR with a compiler option.: Restricted Project.
Mar 4 2022, 9:22 AM · Restricted Project, Restricted Project

Mar 3 2022

lei closed D120907: [docs] Add PowerPC release notes for LLVM 14.

Commited to release/14.x via ce1e90fc8dbacdaff0310e50090ec3cfdfce4def

Mar 3 2022, 10:27 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
lei added a comment to D120907: [docs] Add PowerPC release notes for LLVM 14.

LGTM for libc++. I assume this is targeting release/14.x only.

Mar 3 2022, 9:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
lei updated the diff for D120907: [docs] Add PowerPC release notes for LLVM 14.

remove unintented change

Mar 3 2022, 7:00 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
lei requested review of D120907: [docs] Add PowerPC release notes for LLVM 14.
Mar 3 2022, 6:58 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 28 2022

lei accepted D120680: [PowerPC] Remove redundant MMA patterns..

LGTM

Feb 28 2022, 5:15 PM · Restricted Project

Feb 25 2022

lei accepted D120530: [PowerPC][NFC] Add file info and license that was missing from this file..

LGTM
Thx

Feb 25 2022, 7:50 AM · Restricted Project

Feb 24 2022

lei accepted D120515: [PowerPC][NFC] Split out the MMA instructions from the P10 instructions..

LGTM
Thx for cleaning up.

Feb 24 2022, 3:25 PM · Restricted Project
lei added inline comments to D120515: [PowerPC][NFC] Split out the MMA instructions from the P10 instructions..
Feb 24 2022, 1:55 PM · Restricted Project

Feb 16 2022

lei committed rG5abe6c312bb2: [PowerPC] Rename PPCInstrPrefix.td to PPCInstrP10.td (authored by lei).
[PowerPC] Rename PPCInstrPrefix.td to PPCInstrP10.td
Feb 16 2022, 8:23 AM

Feb 3 2022

lei added a comment to D116743: [PowerPC] Add assembly comments for instructions that use the vector registers..

Not a silly question at all!
Initially I thought that I didn't need to update the tests because I wan't changing code and the CHECK/CHECK-NEXT lines don't really care that there are comments that come after the instructions. This is true in most cases but there are tests that already have a comment after the instruction line (for example # 8-byte Folded Spill) and in those cases by adding a second comment I'm adding a new line and the CHECK-NEXT lines don't work anymore. Anyway, I'm going to update those tests now.

Feb 3 2022, 12:35 PM · Restricted Project
lei added inline comments to D116743: [PowerPC] Add assembly comments for instructions that use the vector registers..
Feb 3 2022, 12:31 PM · Restricted Project
lei accepted D118074: [PowerPC] Remove the LDMX instruction..

LGTM
Thx for the cleanup!

Feb 3 2022, 11:16 AM · Restricted Project

Jan 18 2022

lei accepted D117507: [PowerPC] Add the Power10 LXVKQ instrution..

LGTM, just a minor comment.

Jan 18 2022, 7:15 AM · Restricted Project

Nov 25 2021

lei committed rG1db1cb028db5: [CMake] Add new cmake option to control adding comments in GenDAGISel (authored by lei).
[CMake] Add new cmake option to control adding comments in GenDAGISel
Nov 25 2021, 10:11 AM
lei closed D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel.
Nov 25 2021, 10:11 AM · Restricted Project
lei updated the diff for D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel.

fix indentation.

Nov 25 2021, 8:37 AM · Restricted Project
lei updated the summary of D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel.
Nov 25 2021, 6:25 AM · Restricted Project

Nov 24 2021

lei accepted D113900: [PowerPC] Prevent the optimizer from producing wide vector types in IR..

LGTM other then the comment about the unecessary code block.

Nov 24 2021, 11:41 AM · Restricted Project, Unknown Object (Project)

Nov 18 2021

lei retitled D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel from [CMake] Add LLVM_OMIT_DAGISEL_COMMENTS to control adding comments in GenDAGISel to [CMake] Add new cmake option to control adding comments in GenDAGISel.
Nov 18 2021, 3:57 PM · Restricted Project
lei retitled D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel from [CMake] Use NDEBUG macro to control adding comments in GenDAGISel.inc to [CMake] Add LLVM_OMIT_DAGISEL_COMMENTS to control adding comments in GenDAGISel.
Nov 18 2021, 3:56 PM · Restricted Project
lei updated the diff for D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel.

Switch to using new cmake variable to control comments.

Nov 18 2021, 3:48 PM · Restricted Project

Nov 17 2021

lei added a reviewer for D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel: Restricted Project.
Nov 17 2021, 2:05 PM · Restricted Project
lei requested review of D114122: [CMake] Add new cmake option to control adding comments in GenDAGISel.
Nov 17 2021, 2:03 PM · Restricted Project

Nov 16 2021

lei added a comment to D113900: [PowerPC] Prevent the optimizer from producing wide vector types in IR..

Instead of adding:

if (isMMAType(Src))
    return InstructionCost::getMax();

to all the different cost calculating functions, is it possible to just add them the underlying functions?

Nov 16 2021, 12:17 PM · Restricted Project, Unknown Object (Project)

Nov 15 2021

lei committed rGf50c6c17185c: [PowerPC] Fix 32bit vector insert instructions for ISA3.1 (authored by lei).
[PowerPC] Fix 32bit vector insert instructions for ISA3.1
Nov 15 2021, 12:37 PM
lei closed D113802: [PowerPC] Fix 32bit vector insert instructions for ISA3.1.
Nov 15 2021, 12:36 PM · Restricted Project
lei updated the diff for D113802: [PowerPC] Fix 32bit vector insert instructions for ISA3.1.

address review comments

Nov 15 2021, 10:31 AM · Restricted Project
lei added inline comments to D113802: [PowerPC] Fix 32bit vector insert instructions for ISA3.1.
Nov 15 2021, 10:10 AM · Restricted Project
lei added inline comments to D113802: [PowerPC] Fix 32bit vector insert instructions for ISA3.1.
Nov 15 2021, 9:20 AM · Restricted Project

Nov 12 2021

lei added reviewers for D113802: [PowerPC] Fix 32bit vector insert instructions for ISA3.1: nemanjai, stefanp, ZarkoCA, power-llvm-team.
Nov 12 2021, 1:19 PM · Restricted Project
lei requested review of D113802: [PowerPC] Fix 32bit vector insert instructions for ISA3.1.
Nov 12 2021, 1:17 PM · Restricted Project

Oct 18 2021

lei accepted D109652: [PowerPC] Restrict various P10 options to P10 only..

LGTM
I think you went a bit overkill with the tests for this patch 🙂. Please cut down the number of run lines before committing.

Oct 18 2021, 7:50 AM · Restricted Project, Unknown Object (Project), Restricted Project

Oct 4 2021

lei committed rG8b3d944a97cc: [PowerPC] Disable vector types when not supported by subtarget features (authored by lei).
[PowerPC] Disable vector types when not supported by subtarget features
Oct 4 2021, 12:17 PM
lei closed D109178: [PowerPC] Disable vector types when not supported by subtarget features.
Oct 4 2021, 12:16 PM · Restricted Project
lei updated the diff for D109178: [PowerPC] Disable vector types when not supported by subtarget features.

address line comment and update tc to reflect new behaviour.

Oct 4 2021, 11:49 AM · Restricted Project

Sep 27 2021

lei accepted D107899: [PowerPC] Implement builtin for vbpermd.

LGTM

Sep 27 2021, 2:43 PM · Restricted Project, Restricted Project
lei updated the diff for D109178: [PowerPC] Disable vector types when not supported by subtarget features.

Address review comments and add handling for vector long types without vsx.

Sep 27 2021, 12:19 PM · Restricted Project

Sep 24 2021

lei added inline comments to D108795: [PowerPC] Fix issue with lowering byval parameters..
Sep 24 2021, 10:12 AM · Restricted Project
lei accepted D109437: [PowerPC] FP compare and test XL compat builtins..
Sep 24 2021, 8:52 AM · Restricted Project, Restricted Project
lei accepted D109437: [PowerPC] FP compare and test XL compat builtins..

LGTM
Pleases address nit on commit.

Sep 24 2021, 8:51 AM · Restricted Project, Restricted Project

Sep 23 2021

lei requested changes to D109437: [PowerPC] FP compare and test XL compat builtins..
Sep 23 2021, 7:09 AM · Restricted Project, Restricted Project
lei accepted D109710: [PowerPC] Add range checks for P10 Vector Builtins.

LGTM
Please add comment to tc upon commit.

Sep 23 2021, 6:44 AM · Restricted Project
lei accepted D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.

LGTM once the code is simplified as Nemanja suggested.

Sep 23 2021, 6:39 AM · Unknown Object (Project), Restricted Project, Restricted Project
lei accepted D110282: [PowerPC] SemaChecking for darn family of builtins.

LGTM.
Pleases address the test issue on commit.

Sep 23 2021, 6:34 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Sep 21 2021

lei accepted D110084: [PowerPC] Support for vector bool int128 on vector comparison builtins.

LGTM
thx

Sep 21 2021, 7:47 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Sep 20 2021

lei added inline comments to D109710: [PowerPC] Add range checks for P10 Vector Builtins.
Sep 20 2021, 2:27 PM · Restricted Project
lei added inline comments to D109437: [PowerPC] FP compare and test XL compat builtins..
Sep 20 2021, 2:21 PM · Restricted Project, Restricted Project
lei accepted D109887: [PowerPC] Add prefix load pattern for fpext to v2f64.

LGTM
thx!

Sep 20 2021, 1:59 PM · Unknown Object (Project), Restricted Project
lei accepted D108823: [PowerPC] Mark splat immediate instructions as rematerializable.

LGTM
Thx.

Sep 20 2021, 1:51 PM · Restricted Project
lei accepted D109780: [PowerPC] Add range check for vec_genpcvm builtins.

LGTM.
Thx!

Sep 20 2021, 11:34 AM · Restricted Project
lei accepted D109996: [PowerPC] Fix signature of lxvp and stxvp builtins.

LTGM
Thx!

Sep 20 2021, 11:30 AM · Restricted Project
lei added inline comments to D109652: [PowerPC] Restrict various P10 options to P10 only..
Sep 20 2021, 11:27 AM · Restricted Project, Unknown Object (Project), Restricted Project
lei accepted D109920: [PowerPC] Fix td pattern for P10 VSLDBI and VSRDBI.

LGTM
Thx!

Sep 20 2021, 10:44 AM · Restricted Project

Sep 7 2021

lei accepted D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields..

LGTM
Thx!

Sep 7 2021, 6:47 AM · Restricted Project
lei added inline comments to D109178: [PowerPC] Disable vector types when not supported by subtarget features.
Sep 7 2021, 6:42 AM · Restricted Project

Sep 2 2021

lei updated the summary of D109178: [PowerPC] Disable vector types when not supported by subtarget features.
Sep 2 2021, 11:56 AM · Restricted Project
lei updated the diff for D109178: [PowerPC] Disable vector types when not supported by subtarget features.

fix spelling in commit message.

Sep 2 2021, 11:55 AM · Restricted Project
lei requested review of D109178: [PowerPC] Disable vector types when not supported by subtarget features.
Sep 2 2021, 11:42 AM · Restricted Project
lei added a comment to D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests.

Is it really necessary to add the BE checks in this patch if they are the same as LE checks? Why not just add it later when there is a diff seen?

Sep 2 2021, 7:37 AM · Restricted Project

Aug 26 2021

lei added inline comments to D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.
Aug 26 2021, 8:30 AM · Unknown Object (Project), Restricted Project, Restricted Project

Aug 25 2021

lei accepted D108702: [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and vec_clr_last .

LGTM

Aug 25 2021, 2:41 PM · Restricted Project, Restricted Project
lei requested changes to D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields..

I think there is something wrong with this diff cause there is no context available for PPCInstrInfo.cpp.

Aug 25 2021, 6:22 AM · Restricted Project

Aug 12 2021

lei committed rG8930af45c35b: [PowerPC] Implement XL compatibility builtin __addex (authored by lei).
[PowerPC] Implement XL compatibility builtin __addex
Aug 12 2021, 2:38 PM
lei closed D107002: [PowerPC] Implement XL compatibility builtin __addex.
Aug 12 2021, 2:38 PM · Restricted Project, Restricted Project
lei updated the diff for D107002: [PowerPC] Implement XL compatibility builtin __addex.

Fix name of new warning message to be more accuratly represent the diagnostic.

Aug 12 2021, 1:53 PM · Restricted Project, Restricted Project
lei updated the diff for D107002: [PowerPC] Implement XL compatibility builtin __addex.

Update diag id

Aug 12 2021, 11:54 AM · Restricted Project, Restricted Project

Aug 11 2021

lei updated the diff for D107002: [PowerPC] Implement XL compatibility builtin __addex.

Add -W flag to new warning message

Aug 11 2021, 12:04 PM · Restricted Project, Restricted Project

Aug 10 2021

lei requested changes to D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.

Actually we should not be removing the deprecated bultins. Just need to add the new ones.

Aug 10 2021, 11:35 AM · Unknown Object (Project), Restricted Project, Restricted Project
lei accepted D107461: [PowerPC] Do not define __PRIVILEGED__.
Aug 10 2021, 10:53 AM · Restricted Project
lei accepted D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins.
Aug 10 2021, 9:44 AM · Restricted Project, Restricted Project, Restricted Project