LGTM
Thx!

Address review comments from Nemanja

Simplify vec_replace_[elt|unaligned] code gen.

Move error checking for vec_replace_unaligned to during code gen.

rebase to ToT

LGTM, just a few nit that can be addressed on commit.

Add fix for vec_replace_elt and vec_replace_unaligned.

Please document all new functions added.

LGTM
Thx

LGTM

LGTM
Thx for fixing this.

LGTM with minor updates before commit.

This also failing on all our bots:
https://lab.llvm.org/buildbot/#/builders/105/builds/22623
https://lab.llvm.org/buildbot/#/builders/100/builds/13530

Commited to release/14.x via ce1e90fc8dbacdaff0310e50090ec3cfdfce4def

In D120907#3357433, @ldionne wrote:

LGTM for libc++. I assume this is targeting release/14.x only.

remove unintented change

LGTM

LGTM
Thx

LGTM
Thx for cleaning up.

Not a silly question at all!
Initially I thought that I didn't need to update the tests because I wan't changing code and the CHECK/CHECK-NEXT lines don't really care that there are comments that come after the instructions. This is true in most cases but there are tests that already have a comment after the instruction line (for example # 8-byte Folded Spill) and in those cases by adding a second comment I'm adding a new line and the CHECK-NEXT lines don't work anymore. Anyway, I'm going to update those tests now.

LGTM
Thx for the cleanup!

LGTM, just a minor comment.

fix indentation.

LGTM other then the comment about the unecessary code block.

Switch to using new cmake variable to control comments.

Instead of adding:

if (isMMAType(Src))
    return InstructionCost::getMax();

to all the different cost calculating functions, is it possible to just add them the underlying functions?

address review comments

LGTM
I think you went a bit overkill with the tests for this patch 🙂. Please cut down the number of run lines before committing.

address line comment and update tc to reflect new behaviour.

LGTM

Address review comments and add handling for vector long types without vsx.

LGTM
Pleases address nit on commit.

LGTM
Please add comment to tc upon commit.

LGTM once the code is simplified as Nemanja suggested.

LGTM.
Pleases address the test issue on commit.

LGTM
thx

LGTM
thx!

LGTM
Thx.

LGTM.
Thx!

LTGM
Thx!

LGTM
Thx!

LGTM
Thx!

fix spelling in commit message.

Is it really necessary to add the BE checks in this patch if they are the same as LE checks? Why not just add it later when there is a diff seen?

LGTM

I think there is something wrong with this diff cause there is no context available for PPCInstrInfo.cpp.

Fix name of new warning message to be more accuratly represent the diagnostic.

Update diag id

Add -W flag to new warning message

Actually we should not be removing the deprecated bultins. Just need to add the new ones.