User Details
- User Since
- Oct 24 2016, 11:46 AM (344 w, 5 d)
Mar 13 2023
thx for the added coverage.
LGTM
LGTM
Thx
Feb 21 2023
Since @phosek requested changes, this now require his review to see if his concerns are addressed.
@phosek can you please take a look at this patch to see if it addresses your concerns? PowerPC require this patch for our libcxx builds.
Feb 2 2023
Since Eric mentioned above that he didn't mean to block this patch and he hasn't come back to it, I am going to assume it is okay to land this patch now. I can help to commit this tomorrow if we don't get any blocking comments by then.
@arcivanov are you still waiting for Eric to respond or are you looking for help to commit this patch?
Jan 30 2023
@tstellar PowerPC would need this patch enable to publish a build with libcxx. When does this patch need to land enable to get this into LLVM 16.0?
It would be great if we can get this in 16.
Jan 26 2023
Jan 23 2023
This patch fixes the exact problem I am seeing when building on PowerPC for -DLLVM_ENABLE_RUNTIMES=compiler-rt;libcxx;libcxxabi -DLLVM_ENABLE_LIBCXX:BOOL=ON.
I have applied this patch and tested it on the ppcle rhel/aix/flang/mlir bots and it does not cause any regressions so this LGTM.
Jan 16 2023
Jan 13 2023
Dec 21 2022
Thanks! This LGTM
Dec 20 2022
fix test doc wording
Dec 12 2022
Please note that this patch broke any bots that build this project with -Werror (example: https://lab.llvm.org/buildbot/#/builders/19/builds/14037). As a result, I have reverted it since there has been no fix within a reasonable time.
May I advise ensuring that a project is clean wrt. to the additional warnings when turning on extra warnings as there are bound to be some builds that use -Werror. Also, new warnings are almost always disruptive changes as there are many different build configurations that may be affected in unforeseen ways. If you have such a disruptive change ready to commit, it is advisable to wait until Monday to commit it rather than committing it on a Friday evening as most people are disconnecting.
Nov 30 2022
LGTM
Thx!
Nov 29 2022
Nov 4 2022
Sep 28 2022
LGTM
Thx
LGTM
Thx
Sep 26 2022
Aug 16 2022
Aug 10 2022
Jul 28 2022
Jul 20 2022
1 missed bitcast, otherwise LGTM
Jul 18 2022
@phosek It seems the runtime tests are no longer running for us after this patch in PPC bot https://lab.llvm.org/buildbot/#/builders/57. I can see they are still ran when it's part of LLVM_ENABLE_PROJECTS, but this bot specifies compiler-rt as LLVM_ENABLE_RT=compiler-rt.
Jun 29 2022
Jun 22 2022
LGTM
Thx!
Jun 21 2022
Jun 20 2022
Jun 16 2022
Address review comments from Nemanja
Simplify vec_replace_[elt|unaligned] code gen.
Move error checking for vec_replace_unaligned to during code gen.
Jun 15 2022
rebase to ToT
LGTM, just a few nit that can be addressed on commit.
Add fix for vec_replace_elt and vec_replace_unaligned.
Please document all new functions added.
Jun 7 2022
LGTM
Thx
May 25 2022
LGTM
LGTM
Thx for fixing this.
May 18 2022
May 17 2022
LGTM with minor updates before commit.
Mar 9 2022
This also failing on all our bots:
https://lab.llvm.org/buildbot/#/builders/105/builds/22623
https://lab.llvm.org/buildbot/#/builders/100/builds/13530
Mar 4 2022
Mar 3 2022
Commited to release/14.x via ce1e90fc8dbacdaff0310e50090ec3cfdfce4def
remove unintented change
Feb 28 2022
LGTM
Feb 25 2022
LGTM
Thx
Feb 24 2022
LGTM
Thx for cleaning up.
Feb 16 2022
Feb 3 2022
Not a silly question at all!
Initially I thought that I didn't need to update the tests because I wan't changing code and the CHECK/CHECK-NEXT lines don't really care that there are comments that come after the instructions. This is true in most cases but there are tests that already have a comment after the instruction line (for example # 8-byte Folded Spill) and in those cases by adding a second comment I'm adding a new line and the CHECK-NEXT lines don't work anymore. Anyway, I'm going to update those tests now.
LGTM
Thx for the cleanup!
Jan 18 2022
LGTM, just a minor comment.
Nov 25 2021
fix indentation.
Nov 24 2021
LGTM other then the comment about the unecessary code block.
Nov 18 2021
Switch to using new cmake variable to control comments.
Nov 17 2021
Nov 16 2021
Instead of adding:
if (isMMAType(Src)) return InstructionCost::getMax();
to all the different cost calculating functions, is it possible to just add them the underlying functions?
Nov 15 2021
address review comments
Nov 12 2021
Oct 18 2021
LGTM
I think you went a bit overkill with the tests for this patch 🙂. Please cut down the number of run lines before committing.