[Sema][RISCV][SVE] Allow ?: to select Typedef BuiltinType in C

[arcbbb]

Summary

This patch solves an error such as:

incompatible operand types ('vbool4_t' (aka '__rvv_bool4_t') and '__rvv_bool4_t')

when one of the value is a TypedefType of the other value in ?:.

[kito-cheng]

Testcase for AArch64/SVE:

#include <arm_sve.h>

svint8_t a();
__SVInt8_t b();

svint8_t foo(int cond){
  return cond ? a(): b();
}

[kito-cheng]

The testcase I provided in last comment could be compile successfully with aarch64-gcc, but failed on clang.

[rsandifo-arm]

Thanks for the fix. I agree this is the right behaviour FWIW. I held off approving it in case there's another idiom that's preferred when comparing canonical types.

[frasercrmck]

In D103603#2795899, @kito-cheng wrote:

Testcase for AArch64/SVE:

#include <arm_sve.h>

svint8_t a();
__SVInt8_t b();

svint8_t foo(int cond){
  return cond ? a(): b();
}

Could that AArch64 test also be part of this patch?

[jrtc27]

clang/lib/Sema/SemaExpr.cpp

8397

This is Context.hasSameType, and the braces are unnecessary.

[arcbbb]

Add a case in AArch64 test and address review comments.

[rjmccall]

LGTM

clang/lib/Sema/SemaExpr.cpp

if (checkPointerIntegerMismatch(*this, LHS, RHS.get(), QuestionLoc,
       /*IsIntFirstExpr=*/true))
     return RHSTy;
   if (checkPointerIntegerMismatch(*this, RHS, LHS.get(), QuestionLoc,
       /*IsIntFirstExpr=*/false))
     return LHSTy;
 
   // Allow ?: operations in which both operands have the same
   // built-in sizeless type.
-  if (LHSTy->isSizelessBuiltinType() && LHSTy == RHSTy)
+  if (LHSTy->isSizelessBuiltinType() && Context.hasSameType(LHSTy, RHSTy))
     return LHSTy;
 
   // Emit a better diagnostic if one of the expressions is a null pointer
   // constant and the other is not a pointer type. In this case, the user most
   // likely forgot to take the address of the other expression.
   if (DiagnoseConditionalForNull(LHS.get(), RHS.get(), QuestionLoc))
     return QualType();
 
   // Otherwise, the operands are not compatible.

clang/test/Sema/riscv-types.c

void bar(void) {
   __rvv_int8mf8_t x41;
 
   // CHECK: __rvv_int8mf4_t x42;
   __rvv_int8mf4_t x42;
 
   // CHECK: __rvv_int8mf2_t x43;
   __rvv_int8mf2_t x43;
 }
+
+typedef __rvv_bool4_t vbool4_t;
+__rvv_bool4_t get_rvv_bool4();
+vbool4_t get_vbool4_t();
+
+void func1(int sel) {
+  // CHECK: vbool4_t t0 = sel ? get_rvv_bool4() : get_vbool4_t();
+  vbool4_t t0 = sel ? get_rvv_bool4() : get_vbool4_t();
+}

clang/test/Sema/sizeless-1.c

 struct incomplete_struct *incomplete_ptr;
 
 typedef svint8_t sizeless_array[1]; // expected-error {{array has sizeless element type}}
 
 void func(int sel) {
   static svint8_t static_int8; // expected-error {{non-local variable with sizeless type 'svint8_t'}}
 
   svint8_t local_int8;
+  int8_typedef typedef_int8;
   svint16_t local_int16;
 
   svint8_t __attribute__((aligned)) aligned_int8_1;    // expected-error {{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
   svint8_t __attribute__((aligned(4))) aligned_int8_2; // expected-error {{'aligned' attribute cannot be applied to sizeless type 'svint8_t'}}
   svint8_t _Alignas(int) aligned_int8_3;               // expected-error {{'_Alignas' attribute cannot be applied to sizeless type 'svint8_t'}}
 
   int _Alignas(svint8_t) aligned_int; // expected-error {{invalid application of 'alignof' to sizeless type 'svint8_t'}}
 
void func(int sel) {
   volatile_int8 = local_int8;
   volatile_int8 = const_int8;
   volatile_int8 = volatile_int8;
   volatile_int8 = const_volatile_int8;
 
   const_volatile_int8 = local_int8; // expected-error {{cannot assign to variable 'const_volatile_int8' with const-qualified type 'const volatile svint8_t'}}
 
   init_int8 = sel ? init_int8 : local_int8;
+  init_int8 = sel ? init_int8 : typedef_int8;
   init_int8 = sel ? init_int8 : const_int8;
   init_int8 = sel ? volatile_int8 : const_int8;
   init_int8 = sel ? volatile_int8 : const_volatile_int8;
 
   pass_int8(local_int8);
   pass_int8(local_int16); // expected-error {{passing 'svint16_t' (aka '__SVInt16_t') to parameter of incompatible type 'svint8_t'}}
 
   local_int8 = return_int8();