- User Since
- Oct 19 2012, 12:57 AM (361 w, 3 d)
Fri, Sep 20
Mon, Sep 16
Added some context comments in D67601.
For context, read_register was introduced to allow use of the "global named register" GNU extension.
Wed, Sep 4
Aug 6 2019
Nope, Asan failures from the sanitizer commit.
Aug 1 2019
This is a tricky one which may vary depending on the libraries available on different systems. Which toolchain is this? Can you add more context?
Jul 30 2019
I see, makes sense. LGTM, thanks!
Jul 29 2019
I understand (and agree with) the reasoning of this patch, but wouldn't this also make it harder to test the current behaviour?
Right, ArchExtKind was supposed to be shared between Arm and AArch64, but that ship has sailed a long time ago. LGTM, thanks!
Jul 26 2019
Jul 24 2019
Jul 23 2019
Jul 19 2019
Better this way, let's keep the changes contained to one per patch. If there's interest to change that behaviour or not, it should not hold this patch, which looks good to me now. Thanks!
Jul 18 2019
Jul 5 2019
As far as I can see this is an NFC refactoring with obvious benefits to readability and extensibility. LGTM too. :)
Jul 2 2019
Adding llvm-commits for wider audience
Jun 24 2019
Jun 21 2019
Jun 17 2019
I agree with Hideki, this could be in LoopVectorize.h.
Jun 14 2019
Sorry Pavel, tough week. it's at the top of my list.
Jun 10 2019
@huntergr do you have an account on bugzilla? I couldn't CC you on that bug.
Jun 6 2019
Committed as r362736
Jun 5 2019
Much cleaner, thanks! I think we should deal with extending the functionality in a separate patch, since that's already a good localized improvement.
May 28 2019
May 27 2019
Looks nice, thanks! Though, does it need to be a member function? Why not just a local static function?
May 22 2019
May 20 2019
Can expectedCost ever return zero?
May 8 2019
looks obviously good to me. thanks!
Apr 30 2019
Apr 24 2019
Apr 15 2019
Apr 13 2019
Apr 6 2019
Apr 5 2019
Mar 20 2019
Mar 19 2019
Mar 16 2019
I'm curious as to how will we generate these flags.
Mar 13 2019
The concept of "hacked" is lost when you move up to TTI. I'd change the logic to reflect that this is making it "prohibitively expensive" instead of "hacked value".
Mar 7 2019
I'm not against moving docs there but I think there should be a conversation about the broader subject of docs, github, wiki, etc.
Feb 27 2019
Hi @steleman, that wasn't a "loaded question", it was an honest one. Let me try to clarify what that means for all parties.
Feb 19 2019
Feb 18 2019
@t.p.northover Is this the correct behaviour for Apple's syntax?
Sorry for the delay, this fell out of my radar and just saw the ping now.
Feb 16 2019
Feb 15 2019
Thanks Stephan, now looks good.
Thanks for your answers, they make sense. Other than the mistake I made on disabling exp calls (you were right), looks fine.
Feb 14 2019
Feb 13 2019
Funny thing is, SVML is also only supported, AFAIK, for Intel. I agree that we should emit errors, but we should also emit a similar error on SVML.
I have a few comments inline, mostly harmless, as the change is almost entirely mechanical and makes sense.
Feb 9 2019
Right, this is a completely different patch and it seems that the original proposal hadn't been tested thoroughly.
Since the previous version was approved already, I'm "requesting changes" so that we can look at it again, together with D53927 to make sure it's still the right way to go.
Feb 8 2019
Adding llvm-commits for wider audience
Feb 6 2019
Jan 31 2019
dword is indeed widely used. I'm surprised we didn't support that yet. Apparently, neither does Arm, only X86, Mips and RiscV.
Jan 30 2019
Jan 29 2019
Jan 23 2019
Jan 22 2019
Sounds good. Please add simple tests for +inf and -inf on both double and float. Perhaps also float to double and vice versa from the IR constant (like the changed test shows), too. Thanks!
Jan 20 2019
Hal approved the Clang side, so this one looks good, too.
Jan 10 2019
Perhaps best to ping Clang's commit, as that's the review that is blocking this one.
Dec 19 2018
Thanks! I've updated the reviewers on the Clang review (D53928).
Adding clang/omp developers for proper review. Please feel free to add more.
Dec 17 2018
If you git log cmake/config.guess you'll see that all the past changes either remove functionality or add obvious parts that shouldn't inflict on copyright.
Dec 14 2018
Right, that's all very hypothetical, but the change is harmless otherwise and generally an improvement of the code. I can't see any impact this would have in code generation or compilation time, so LGTM.
Getting a bit late in this discussion, as we had an internal one just recently.
Dec 13 2018
Right, I'm happy with the patch and will let @fhahn do the final review and approval. Thanks!
Dec 12 2018
As a starting point, this sure looks good to me. Thanks!