Page MenuHomePhabricator

rengolin (Renato Golin)
Toolchain Engineer

Projects

User does not belong to any projects.

User Details

User Since
Oct 19 2012, 12:57 AM (544 w, 2 d)

Recent Activity

Mon, Mar 13

rengolin added a comment to D89322: [LV] Initial VPlan cost modelling.

This too old to be useful now and I don't have any plans to work on it in the near term. (It would be good to see improvements though, where the vplan is costed more directly as opposed continuing to go through the IR instructions).

Mon, Mar 13, 6:01 AM · Restricted Project, Restricted Project

Sat, Mar 11

rengolin accepted D145833: Switch ABI references to env/environment.

IIRC, "abi" used to be what Arm called, but "env" is equally good. And it it's consistent with Triple.h, even better. LGTM, thanks!

Sat, Mar 11, 3:43 AM · Restricted Project, Restricted Project

Fri, Mar 10

rengolin added a comment to D144692: [mlir] Introduce IRDL dialect.

I don't believe there is any rule like that: I merge my patches as they get approved in general. We mostly need to agree about the overall design, then we can develop incrementally in tree. Stacked patches are mostly a convenient way of streamlining the development and review process.

Fri, Mar 10, 1:34 AM · Restricted Project, Restricted Project

Thu, Mar 9

rengolin added a comment to D144692: [mlir] Introduce IRDL dialect.

That makes sense, I'm adding this in a follow-up patch.

Thu, Mar 9, 3:28 PM · Restricted Project, Restricted Project
rengolin added a comment to D144692: [mlir] Introduce IRDL dialect.

PS: I have just merged the dependency D144690.

Thu, Mar 9, 10:54 AM · Restricted Project, Restricted Project
rengolin committed rGc5b060900e98: [mlir] Add setters for Dynamic[Type|Attr]Definition (authored by math-fehr).
[mlir] Add setters for Dynamic[Type|Attr]Definition
Thu, Mar 9, 10:54 AM · Restricted Project, Restricted Project
rengolin closed D144690: [mlir] Add setters for Dynamic[Type|Attr]Definition.
Thu, Mar 9, 10:53 AM · Restricted Project, Restricted Project
rengolin added a comment to D144692: [mlir] Introduce IRDL dialect.

To further simplify this patch (and the registration one), I removed any_of from irdl.
I'll add it in the patch right after the registrations one.

However, I kept the mentions to any_of in the documentation, if that is fine for you, to not rewrite almost all the code snippets (since all of them used any_of).

Thu, Mar 9, 10:40 AM · Restricted Project, Restricted Project
rengolin added a comment to D144101: [test-suite] Increase the --filter-short threshold.

This looks good to me. @fhahn ?

Thu, Mar 9, 5:44 AM · Restricted Project
rengolin added inline comments to D144101: [test-suite] Increase the --filter-short threshold.
Thu, Mar 9, 3:32 AM · Restricted Project

Wed, Mar 8

rengolin added inline comments to D144692: [mlir] Introduce IRDL dialect.
Wed, Mar 8, 12:09 PM · Restricted Project, Restricted Project
rengolin added inline comments to D89322: [LV] Initial VPlan cost modelling.
Wed, Mar 8, 10:46 AM · Restricted Project, Restricted Project

Tue, Mar 7

rengolin added a comment to D144101: [test-suite] Increase the --filter-short threshold.

It would probably be even better to make the threshold an argument (perhaps pass the threshold optionally like --filter-short=N), with the default being 1.0?

Tue, Mar 7, 1:52 AM · Restricted Project

Fri, Mar 3

rengolin added a comment to D145133: [mlir][TilingInterface] Modify `TilingInterface` methods to better return the state of the transformed IR..

Overall looks good to me, thanks!

Fri, Mar 3, 2:54 AM · Restricted Project, Restricted Project

Sun, Feb 26

rengolin added a comment to D144692: [mlir] Introduce IRDL dialect.

Nice work! I have some comments inline, mostly to understand the dialect.

Sun, Feb 26, 6:01 AM · Restricted Project, Restricted Project

Feb 20 2023

rengolin added inline comments to D144246: [MLIR][Linalg] Change insertion point for `bubbleUpPackOpThroughElemGenericOp`.
Feb 20 2023, 9:23 AM · Restricted Project, Restricted Project
rengolin added inline comments to D144246: [MLIR][Linalg] Change insertion point for `bubbleUpPackOpThroughElemGenericOp`.
Feb 20 2023, 8:51 AM · Restricted Project, Restricted Project

Feb 6 2023

rengolin added a comment to D143365: Remove -j argument to llvm-clang-x86_64-sie-win builder for lit testing.

Running with ninja without -j means it will take more than the number of cores by default. If you want a single core, you need to specify -j1.

Feb 6 2023, 1:42 AM · Restricted Project, Restricted Project

Jan 26 2023

rengolin added a comment to D141836: [AArch64] Disable __muloti4 libcalls for AArch64.

Ok, created a proposal to split builtins: https://discourse.llvm.org/t/proposal-split-built-ins-from-the-rest-of-compiler-rt/67978

Jan 26 2023, 4:21 AM · Restricted Project, Restricted Project

Jan 25 2023

rengolin requested changes to D141836: [AArch64] Disable __muloti4 libcalls for AArch64.

Just to make sure there's no panic, I'm blocking the revision until more people looked over. I'll remove once we have a number of approvals from people in different positions.

Jan 25 2023, 1:48 PM · Restricted Project, Restricted Project
rengolin added a comment to D141836: [AArch64] Disable __muloti4 libcalls for AArch64.

+1 to trying to add these to libgcc instead of removing from compiler-rt.

Jan 25 2023, 1:44 PM · Restricted Project, Restricted Project

Jan 23 2023

rengolin added a comment to D141836: [AArch64] Disable __muloti4 libcalls for AArch64.

The right move here is to check about muloti, not disable it unless the
aarch64 backend doesn't need it.

Jan 23 2023, 12:04 PM · Restricted Project, Restricted Project
rengolin updated subscribers of D141836: [AArch64] Disable __muloti4 libcalls for AArch64.

From reading the thread on https://github.com/llvm/llvm-project/issues/16778 (which is closed, although the issue doesn't seem resolved), this is a stop-gap for toolchains that don't include an implementation for __muloti4. An implementation seems to exist in compiler-rt, but compiler-rt isn't linked with by default. It seems unfortunate that there is no way to still emit a call to __muloti4 when we do link with compiler-rt, but from reading that thread there is currently no way to tell LLVM that an implementation of __muloti4 is available.

That's my understanding as well.

Jan 23 2023, 10:10 AM · Restricted Project, Restricted Project

Jan 15 2023

rengolin accepted D141750: [docs] Add llvm & clang release notes for LoongArch.

Nice! Thanks for the detailed reporting. LGTM.

Jan 15 2023, 11:43 PM · Restricted Project, Restricted Project, Restricted Project

Jan 11 2023

rengolin accepted D141466: Update number of threads for building to take advantage of distributed build cores on doug-worker-* builders.

LGTM, thanks!

Jan 11 2023, 2:33 AM · Restricted Project, Restricted Project

Jan 10 2023

rengolin added a comment to D141191: [CMake][LoongArch] Add LoongArch to LLVM_ALL_TARGETS so it is built by default.

Thanks everyone, this looks like a good state and consensus. @SixWeining please check with @tstellar directly before merging, to make sure you get the right time for the release.

Jan 10 2023, 10:49 AM · Restricted Project, Restricted Project
rengolin added a comment to D141123: [MLIR][Tensor] Add canonicalization patterns for `tensor.pack`.

Thanks @chelini, LGTM now, but I'll let others make the final approval.

Jan 10 2023, 3:12 AM · Restricted Project, Restricted Project

Jan 9 2023

rengolin added inline comments to D141123: [MLIR][Tensor] Add canonicalization patterns for `tensor.pack`.
Jan 9 2023, 8:44 AM · Restricted Project, Restricted Project

Jan 7 2023

rengolin added reviewers for D141191: [CMake][LoongArch] Add LoongArch to LLVM_ALL_TARGETS so it is built by default: lattner, echristo, asl, t.p.northover, RKSimon, probinson, iliya-diyachkov, myhsu, tstellar.

Thank you for your continued contributions, @SixWeining!

Jan 7 2023, 4:23 AM · Restricted Project, Restricted Project

Jan 6 2023

rengolin added inline comments to D141123: [MLIR][Tensor] Add canonicalization patterns for `tensor.pack`.
Jan 6 2023, 5:39 AM · Restricted Project, Restricted Project

Dec 15 2022

rengolin added a comment to D140088: Add LLVM type support for fp8.

Make sure you add a note to the changelog, so people know you've changed all the enums involved.

Dec 15 2022, 11:23 AM · Restricted Project, Restricted Project

Dec 12 2022

rengolin added inline comments to D139680: [mlir][tensor][linalg] Enhance pack op propagation across generic ops..
Dec 12 2022, 2:29 AM · Restricted Project, Restricted Project

Dec 9 2022

rengolin added a comment to D139680: [mlir][tensor][linalg] Enhance pack op propagation across generic ops..

Small nit, but this looks great, thanks!

Dec 9 2022, 4:28 AM · Restricted Project, Restricted Project

Dec 8 2022

rengolin added a comment to D138672: [buildbot] Add a LoongArch buildbot on CLFS.

If self-maintained buildbot can meet the requirement for a back-end to be promoted to official, we would have a try.

Dec 8 2022, 3:50 AM · Restricted Project
rengolin added a comment to D138672: [buildbot] Add a LoongArch buildbot on CLFS.

Galina may be on extended holiday.

Dec 8 2022, 1:26 AM · Restricted Project

Dec 2 2022

rengolin accepted D138672: [buildbot] Add a LoongArch buildbot on CLFS.

LGTM, thanks! Please check with @gkistanova before merging.

Dec 2 2022, 4:06 AM · Restricted Project

Dec 1 2022

rengolin added inline comments to D138672: [buildbot] Add a LoongArch buildbot on CLFS.
Dec 1 2022, 9:02 AM · Restricted Project
rengolin added inline comments to D138672: [buildbot] Add a LoongArch buildbot on CLFS.
Dec 1 2022, 5:02 AM · Restricted Project
rengolin added inline comments to D138672: [buildbot] Add a LoongArch buildbot on CLFS.
Dec 1 2022, 3:19 AM · Restricted Project

Nov 29 2022

rengolin accepted D138924: [test-suite][tsvc] Use fabs in s318 and s3113.

LGTM, thanks!

Nov 29 2022, 8:09 AM · Restricted Project

Nov 26 2022

rengolin accepted D138631: [mlir][tensor] Implement TilingInterface for tensor.pack op..

LGTM, thanks! @chelini any comments?

Nov 26 2022, 5:09 AM · Restricted Project, Restricted Project

Nov 24 2022

rengolin added inline comments to D138631: [mlir][tensor] Implement TilingInterface for tensor.pack op..
Nov 24 2022, 6:18 AM · Restricted Project, Restricted Project

Nov 21 2022

rengolin accepted D138119: Introduce `tensor.pack` and `tensor.unpack` operations.

LGTM too, with a nit.

Nov 21 2022, 12:45 AM · Restricted Project, Restricted Project

Nov 17 2022

rengolin added inline comments to D138119: Introduce `tensor.pack` and `tensor.unpack` operations.
Nov 17 2022, 3:24 AM · Restricted Project, Restricted Project

Nov 16 2022

rengolin added inline comments to D138119: Introduce `tensor.pack` and `tensor.unpack` operations.
Nov 16 2022, 5:20 AM · Restricted Project, Restricted Project

Nov 13 2022

rengolin committed rG1b99e8ba487b: [MLIR] Move JitRunner Options to header, pass to mlirTransformer (authored by rengolin).
[MLIR] Move JitRunner Options to header, pass to mlirTransformer
Nov 13 2022, 10:56 AM · Restricted Project, Restricted Project
rengolin closed D137861: [MLIR] Move JitRunner Options to header, pass to mlirTransformer.
Nov 13 2022, 10:56 AM · Restricted Project, Restricted Project

Nov 12 2022

rengolin updated the diff for D137861: [MLIR] Move JitRunner Options to header, pass to mlirTransformer.

Simplified what's exposed to the methods, keeping the Options on the CPP file. Rebased and all tests pass.

Nov 12 2022, 1:50 PM · Restricted Project, Restricted Project
rengolin added inline comments to D137861: [MLIR] Move JitRunner Options to header, pass to mlirTransformer.
Nov 12 2022, 1:29 PM · Restricted Project, Restricted Project

Nov 11 2022

rengolin requested review of D137861: [MLIR] Move JitRunner Options to header, pass to mlirTransformer.
Nov 11 2022, 12:29 PM · Restricted Project, Restricted Project

Oct 27 2022

rengolin added a comment to D136376: Make scf.for and affine.for conditionally speculatable.

@chelini

Oct 27 2022, 3:32 PM · Restricted Project, Restricted Project

Oct 21 2022

rengolin added inline comments to D136376: Make scf.for and affine.for conditionally speculatable.
Oct 21 2022, 1:57 AM · Restricted Project, Restricted Project

Oct 12 2022

rengolin accepted D134367: [test][LoongArch] Mark old JIT ExecutionEngine tests as unsupported.

As per that thread, indeed MCJIT is on the way out and you should go for OrcJIT if you want JIT support in LoongArch.

Oct 12 2022, 4:01 AM · Restricted Project, Restricted Project
rengolin added a comment to D92132: [LV] Support widened induction variables in epilogue vectorization..

All my comments addressed, if other people are happy, I'm also happy. Thanks!

Oct 12 2022, 2:56 AM · Restricted Project, Restricted Project

Sep 28 2022

rengolin added inline comments to D92132: [LV] Support widened induction variables in epilogue vectorization..
Sep 28 2022, 6:17 AM · Restricted Project, Restricted Project

Sep 27 2022

rengolin accepted D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC.

Looks good, with some nits. Thanks!

Sep 27 2022, 2:40 PM · Restricted Project, Restricted Project, Restricted Project
rengolin added a comment to D134451: [MLIR] Expose `getAsValues` in `StaticValueUtils.h` (NFC).

@chelini if you roll forward, please consider updating the Bazel BUILD files like I did in the two revisions mentioned above

Sep 27 2022, 1:59 AM · Restricted Project, Restricted Project

Sep 26 2022

rengolin accepted D133823: Add APFloat and MLIR type support for fp8 (e5m2)..

Honestly, there isn't much meat here, other than the decision to support and the name bikeshedding, both of which I think are well covered in the RFC.

Sep 26 2022, 9:34 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 23 2022

rengolin accepted D134157: [Clang][LoongArch] Add inline asm support for constraints f/l/I/K.

Thanks, looks good to me!

Sep 23 2022, 7:14 AM · Restricted Project, Restricted Project, Restricted Project

Sep 22 2022

rengolin added inline comments to D134157: [Clang][LoongArch] Add inline asm support for constraints f/l/I/K.
Sep 22 2022, 6:31 AM · Restricted Project, Restricted Project, Restricted Project

Sep 17 2022

rengolin accepted D132285: [Clang][LoongArch] Implement ABI lowering.

I can't vouch for your ABI correctness, but you seem to have a lot of tests covering what you claim to have implemented, so looks good to me.

Sep 17 2022, 12:10 PM · Restricted Project, Restricted Project

Sep 15 2022

rengolin added a comment to D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M.

I think we can safely say that we care less about jazelle than we care about armv1/2/3, so feel free to ignore that, too.

Sep 15 2022, 7:42 AM · Restricted Project, Restricted Project, Restricted Project

Sep 8 2022

rengolin accepted D133448: Make llvm-tli-checker support static libraries.

LGTM, thanks!

Sep 8 2022, 7:59 AM · Restricted Project, Restricted Project

Sep 7 2022

rengolin added a comment to D133448: Make llvm-tli-checker support static libraries.

A few nits, but looks good to me, thanks!

Sep 7 2022, 2:50 PM · Restricted Project, Restricted Project

Sep 2 2022

rengolin accepted D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M.

Agree. Even 10 years ago we made the concerted effort not to care about pre-v4, so I'd be a little surprised if people are actually using modern clang to target those platforms.

Sep 2 2022, 3:56 AM · Restricted Project, Restricted Project, Restricted Project

Aug 26 2022

rengolin accepted D132550: Changes to code ownership in clang and clang-tidy.

W00t!

Aug 26 2022, 6:35 AM · Restricted Project, Restricted Project, Restricted Project

Aug 9 2022

rengolin accepted D131427: [ARM] Do not use LOAD_STACK_GUARD with ROPI/RWPI.
Aug 9 2022, 12:41 PM · Restricted Project, Restricted Project
rengolin added inline comments to D131427: [ARM] Do not use LOAD_STACK_GUARD with ROPI/RWPI.
Aug 9 2022, 1:55 AM · Restricted Project, Restricted Project

Jul 30 2022

rengolin accepted D130821: [cmake] Support native LoongArch builds.

Looks simple enough!

Jul 30 2022, 10:50 AM · Restricted Project, Restricted Project

Jul 27 2022

rengolin committed rG94761b9dba14: Update ProgrammersManual STL docs (authored by rengolin).
Update ProgrammersManual STL docs
Jul 27 2022, 2:31 AM · Restricted Project, Restricted Project

Jul 21 2022

rengolin added a comment to D130255: [Clang][LoongArch] Add initial LoongArch target and driver support.

This looks great, thanks!

Jul 21 2022, 5:58 AM · Restricted Project, Restricted Project

Jun 16 2022

rengolin accepted D127153: [DirectX] Add DXILAsmPrinter.

No requests, this looks simple enough for me, thanks!

Jun 16 2022, 9:35 AM · Restricted Project, Restricted Project

Jun 9 2022

rengolin added a comment to D127165: [DirectX][MC] Add MC support for DXContainer.

Makes sense, I have no additional comments. LGTM, thanks!

Jun 9 2022, 1:49 PM · Restricted Project, Restricted Project
rengolin added a comment to D127165: [DirectX][MC] Add MC support for DXContainer.

I don't know much about DX but this looks like object emission to me. :)

Jun 9 2022, 8:43 AM · Restricted Project, Restricted Project
rengolin added a comment to D127153: [DirectX] Add DXILAsmPrinter.

I don't know much about DirectX but I'm assuming all of those (what, dialects?) will be coming through the same printers/parsers, right?

Jun 9 2022, 8:34 AM · Restricted Project, Restricted Project
rengolin added a comment to D127153: [DirectX] Add DXILAsmPrinter.

Is this the only thing the Asm Printer will ever do? Does it mean you'll never emit asm files or is there another way to get it out (and if there is, why aren't the constants there, too)?

Jun 9 2022, 8:24 AM · Restricted Project, Restricted Project
rengolin added a comment to D127147: [DirectX] Add MC Register and Frame stubs.

This looks fine to me. I don't see how this can be tested and if it never will have functionality in the future, there's not point in even trying.

Jun 9 2022, 8:20 AM · Restricted Project, Restricted Project
rengolin accepted D126889: [NFC] format InstructionSimplify & lowerCaseFunctionNames.

We got one accept and no opposition. This passes all testing locally. If pre-merge checks are ok (except for unrelated breakage), I will go forward and commit this.

Jun 9 2022, 6:33 AM · Restricted Project, Restricted Project

Jun 7 2022

rengolin added a comment to D127199: [LoongArch] Add codegen support for the binary operations.

Does anyone have any idea about "why the CI is failing"? It seems happening for this batch of LoongArch patches and also one MIPS patch I've reviewed today. I guess something is wrong in the CI system or LLVM codebase.

Jun 7 2022, 10:56 AM · Restricted Project, Restricted Project
rengolin accepted D127204: [LoongArch] Add codegen support for part of conversion operations.

LGTM, super simple, too.

Jun 7 2022, 5:38 AM · Restricted Project, Restricted Project
rengolin accepted D127200: [LoongArch] Add codegen support for fneg.

LGTM, simple and straightforward.

Jun 7 2022, 5:31 AM · Restricted Project, Restricted Project
rengolin accepted D127199: [LoongArch] Add codegen support for the binary operations.

Perhaps wait a few days to make sure other people have time to comment, too.

Jun 7 2022, 5:30 AM · Restricted Project, Restricted Project

Jun 2 2022

rengolin added a comment to D126889: [NFC] format InstructionSimplify & lowerCaseFunctionNames.

As with the alternative, this needs more agreements, but in this case, it touches more files and the probability it will create merge conflicts with other people's in-flight work increases.

Jun 2 2022, 9:02 AM · Restricted Project, Restricted Project
rengolin accepted D126783: [NFC] clang-format InstructionSimplify.cpp.
Jun 2 2022, 8:54 AM · Restricted Project, Restricted Project

Jun 1 2022

rengolin added a comment to D126783: [NFC] clang-format InstructionSimplify.cpp.

I don't know how people feel nowadays about clang-formatting an entire file.

Jun 1 2022, 8:50 AM · Restricted Project, Restricted Project

May 27 2022

rengolin added a comment to D126451: [Clang][CSKY] Add support about CSKYABIInfo.

I don't think it is largely similar to RISCV implementation except for the code structure and test reuse. And the test result is big different.

May 27 2022, 3:57 AM · Restricted Project, Restricted Project

May 26 2022

rengolin added a comment to D126451: [Clang][CSKY] Add support about CSKYABIInfo.

This looks good to me, but wait to make sure others see it, too.

May 26 2022, 4:08 AM · Restricted Project, Restricted Project

May 25 2022

rengolin added a comment to D92086: Generalized PatternMatch & InstSimplify.

First, I think this is a good idea and can eventually mitigate the general problem of intrinsics vs. instructions in other LLVM passes.

May 25 2022, 1:36 AM · Restricted Project, Restricted Project

May 12 2022

rengolin added a comment to D125404: [SPIRV] Add simple tests to improve test coverage.

And what about build failures? It seems, these are not related to my patch...

May 12 2022, 6:30 AM · Restricted Project, Restricted Project
rengolin added a comment to D125404: [SPIRV] Add simple tests to improve test coverage.

Concerning "[[#]] instead of {{[0-9]+}}":
This style {{[0-9]+}} is widely used in SPIRV-LLVM-Translator's tests repository. So, it has to change nearly 150-200 converted tests in LLVM-SPIRV-Backend' tests repository. (?) Moreover, it will break link to original source SPIRV-LLVM-Translator's tests.
Is it required?

May 12 2022, 5:34 AM · Restricted Project, Restricted Project

May 7 2022

rengolin added inline comments to D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different.
May 7 2022, 6:20 AM · Restricted Project, Restricted Project

May 6 2022

rengolin added inline comments to D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different.
May 6 2022, 4:42 AM · Restricted Project, Restricted Project

Apr 21 2022

rengolin added a comment to D123988: [LoongArch] Add basic floating-point instructions definition.

https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted says "If it is likely that others will want to review a recently-posted patch, especially if there might be objections, but no one else has done so yet, it is also polite to provide a qualified approval (e.g., “LGTM, but please wait for a couple of days in case others wish to review”). If approval is received very quickly, a patch author may also elect to wait before committing (and this is certainly considered polite for non-trivial patches). Especially given the global nature of our community, this waiting time should be at least 24 hours. Please also be mindful of weekends and major holidays."

Apr 21 2022, 1:00 AM · Restricted Project, Restricted Project

Apr 20 2022

rengolin accepted D123988: [LoongArch] Add basic floating-point instructions definition.

LGTM, thanks!

Apr 20 2022, 10:24 AM · Restricted Project, Restricted Project

Apr 19 2022

rengolin added a comment to D123988: [LoongArch] Add basic floating-point instructions definition.

Looks reasonable to me. Some nits on file naming and definition placement. Thanks!

Apr 19 2022, 9:31 AM · Restricted Project, Restricted Project

Apr 14 2022

rengolin accepted D116464: [SPIRV 5/6] Add LegalizerInfo, InstructionSelector and utilities.

Thanks @iliya-diyachkov, it looks cleaner, even if still very long. A table generated output will hopefully fix this soon.

Apr 14 2022, 1:57 AM · Restricted Project, Restricted Project

Apr 13 2022

rengolin added inline comments to D116464: [SPIRV 5/6] Add LegalizerInfo, InstructionSelector and utilities.
Apr 13 2022, 7:30 AM · Restricted Project, Restricted Project

Apr 6 2022

rengolin committed rG060ff6633708: Add support for more archs in `Triple::getArchTypeForLLVMName` (authored by antoniofrighetto).
Add support for more archs in `Triple::getArchTypeForLLVMName`
Apr 6 2022, 2:44 AM · Restricted Project, Restricted Project
rengolin closed D122003: Add support for more archs in `Triple::getArchTypeForLLVMName`.
Apr 6 2022, 2:44 AM · Restricted Project, Restricted Project
rengolin added a comment to D116465: [SPIRV 6/6] Add the module analysis pass and the simplest tests.

Apologies, it seems I was looking into a very old version of the review!

Apr 6 2022, 2:07 AM · Restricted Project, Restricted Project