- User Since
- Oct 19 2012, 12:57 AM (378 w, 1 d)
Fri, Jan 10
Mon, Jan 6
Thu, Jan 2
Some inline comments, but otherwise, LGTM. Thanks!
Tue, Dec 24
Fri, Dec 20
Thu, Dec 19
Dec 18 2019
Dec 11 2019
This change may conflict with your other two. How are we supposed to review them? Are they a set?
Dec 10 2019
This change introduces a number of new branches in the code. While not necessarily the hottest code, it may prove significant on short loops, especially nested loops. Without evidence in the form of benchmarks etc. it's hard to justify.
Dec 9 2019
Dec 6 2019
Dec 5 2019
Is this change inspired by a real world case? If so, how relevant / pervasive is this case?
Nov 30 2019
As far as I can see, this shouldn't introduce behavioural changes and does add some nice cleanups.
Nov 1 2019
Oct 29 2019
Oct 28 2019
Oct 27 2019
This plan has all the requirements for adding a new target (http://llvm.org/docs/DeveloperPolicy.html#new-targets), mainly: ISA document, current implementation, code owner, buildbots. You just need to make sure it's marked as *experimental*, as stated in the policy.
Oct 18 2019
Oct 9 2019
So, IIUC, this is changing tryCreateRecipe to move the interleave recipe creation to the caller, buildVPlanWithVPRecipes. The dependencies with the sink values is recorded initially, then the plans are created, then the sinks are applied and, if any, the interleave groups.
Oct 7 2019
This work was mentioned on the SVE discussion about predication, adding arm folks, just in case.
Sep 26 2019
Sep 20 2019
Sep 16 2019
Added some context comments in D67601.
For context, read_register was introduced to allow use of the "global named register" GNU extension.
Sep 4 2019
Aug 6 2019
Nope, Asan failures from the sanitizer commit.
Aug 1 2019
This is a tricky one which may vary depending on the libraries available on different systems. Which toolchain is this? Can you add more context?
Jul 30 2019
I see, makes sense. LGTM, thanks!
Jul 29 2019
I understand (and agree with) the reasoning of this patch, but wouldn't this also make it harder to test the current behaviour?
Right, ArchExtKind was supposed to be shared between Arm and AArch64, but that ship has sailed a long time ago. LGTM, thanks!
Jul 26 2019
Jul 24 2019
Jul 23 2019
Jul 19 2019
Better this way, let's keep the changes contained to one per patch. If there's interest to change that behaviour or not, it should not hold this patch, which looks good to me now. Thanks!
Jul 18 2019
Jul 5 2019
As far as I can see this is an NFC refactoring with obvious benefits to readability and extensibility. LGTM too. :)
Jul 2 2019
Adding llvm-commits for wider audience
Jun 24 2019
Jun 21 2019
Jun 17 2019
I agree with Hideki, this could be in LoopVectorize.h.
Jun 14 2019
Sorry Pavel, tough week. it's at the top of my list.
Jun 10 2019
@huntergr do you have an account on bugzilla? I couldn't CC you on that bug.
Jun 6 2019
Committed as r362736
Jun 5 2019
Much cleaner, thanks! I think we should deal with extending the functionality in a separate patch, since that's already a good localized improvement.
May 28 2019
May 27 2019
Looks nice, thanks! Though, does it need to be a member function? Why not just a local static function?
May 22 2019
May 20 2019
Can expectedCost ever return zero?
May 8 2019
looks obviously good to me. thanks!
Apr 30 2019
Apr 24 2019
Apr 15 2019
Apr 13 2019
Apr 6 2019
Apr 5 2019
Mar 20 2019
Mar 19 2019
Mar 16 2019
I'm curious as to how will we generate these flags.
Mar 13 2019
The concept of "hacked" is lost when you move up to TTI. I'd change the logic to reflect that this is making it "prohibitively expensive" instead of "hacked value".
Mar 7 2019
I'm not against moving docs there but I think there should be a conversation about the broader subject of docs, github, wiki, etc.
Feb 27 2019
Hi @steleman, that wasn't a "loaded question", it was an honest one. Let me try to clarify what that means for all parties.
Feb 19 2019
Feb 18 2019
@t.p.northover Is this the correct behaviour for Apple's syntax?
Sorry for the delay, this fell out of my radar and just saw the ping now.
Feb 16 2019
Feb 15 2019
Thanks Stephan, now looks good.
Thanks for your answers, they make sense. Other than the mistake I made on disabling exp calls (you were right), looks fine.