- User Since
- Oct 19 2012, 12:57 AM (325 w, 5 d)
Thu, Jan 10
Perhaps best to ping Clang's commit, as that's the review that is blocking this one.
Wed, Dec 19
Thanks! I've updated the reviewers on the Clang review (D53928).
Adding clang/omp developers for proper review. Please feel free to add more.
Mon, Dec 17
If you git log cmake/config.guess you'll see that all the past changes either remove functionality or add obvious parts that shouldn't inflict on copyright.
Dec 14 2018
Right, that's all very hypothetical, but the change is harmless otherwise and generally an improvement of the code. I can't see any impact this would have in code generation or compilation time, so LGTM.
Getting a bit late in this discussion, as we had an internal one just recently.
Dec 13 2018
Right, I'm happy with the patch and will let @fhahn do the final review and approval. Thanks!
Dec 12 2018
As a starting point, this sure looks good to me. Thanks!
Dec 11 2018
Overall, this change looks ok to me. The tests look good, too.
Dec 7 2018
Adding more folks due to the license issue.
Dec 5 2018
Dec 3 2018
Right, that one is a hairy test, and I can see how this would break that test if not right. :)
Dec 1 2018
That's very useful, thanks! LGTM.
Nice clean solution, thanks!
Nov 30 2018
Accepting as this seems to fix the fast-math issue that was the reason why we reverted. Let me know if this still breaks things.
Nov 25 2018
This makes sense to me, but I'm not well versed in LLDB testing. Adding Pavel and Omair to approve it.
Nov 23 2018
LGTM, do we have any tests for llvm-mc output?
Nov 21 2018
I'm not sure what's the supposed behaviour on Apple syntax, but the tests show both apple and eabi syntax changing to the recommended encoding, so this LGTM.
Nov 14 2018
@Carrot, can you check if this fixes the fast math issues on your side, please?
Nov 13 2018
Perfect, LGTM. Thanks!
So, IIUC, the way you only get the interleave info on instructions and map to VPlan is because we don't yet have scalar evolution in VPlan, so we need to do that in Instruction and then map to VPInstruction.
Nov 12 2018
Just had a look again and it's looking great, thanks Florian!
Nov 10 2018
I had no idea Hurd was still alive, but hey!
Nov 8 2018
Nov 3 2018
This looks ok to me, but I'd rather more people look at it before approving.
Oct 31 2018
Oct 30 2018
Right, I don't see anything wrong with it, but I'm adding other back-end maintainers and Jakob, TableGen's maintainer, so we're sure this is as harmless as I seem to think it is. :)
Oct 27 2018
Reverted in r345465. Will take a look and land again when fixed. Thanks!
Oct 26 2018
This is looking good to me, thanks!
Oct 23 2018
I also have a list somewhere, that I will add once I find it.
Oct 20 2018
Oct 16 2018
Oct 15 2018
(very gentle ping) :)
Oct 12 2018
Oct 11 2018
Oh, you've done that. The diff isn't clear.
The failure in Arm had nothing to do with not being ELF, but the asm syntax was different.
I'm wondering... should we choose between dot and png? Or should we always print the dot file and, upon --png flag, also the png file?
Thanks Florian, your regex version is still easy to use and much cleaner.
Oct 10 2018
Seems trivial. instructionsWithoutDebug is just an iterator filter and there are no early continues in the body of the outer loop, so this actually saves time.
Good catch! LGTM, thanks!
Oct 9 2018
Could also be an architectural flag, giving this is a particular behaviour from Exynos. Then a simple splitsJumpTables() or whatever check would be enough.
Changes to comment:
- Improved comments on isConditionalRdxPattern
- Removed instcombine pass from test
- Added write negative test
- Fix typo in CHECK line
Oct 8 2018
Oct 4 2018
Are there no other ways to identify an outliner function, say a function flag or a needed pattern, so we can change the verifier instead, and not fail when called-saved regs are used?
Oct 2 2018
Oct 1 2018
Adding more people that work around triples...
This is a slight duplication of what we already have in ARMSubtarget.h, and given that this is *only* relevant for AArch32, I see no point in this being in the Triple.
Sep 27 2018
The other two reviews were approved. This one can now be closed. Thanks!
Thanks Peter. LGTM!
Thanks Peter! LGTM.
Sep 14 2018
Corrections are always welcome. Please submit an update to this thread (or a new patch) to fix the changes you propose.
If j-s doesn't exists (remember, most of that list came from the ancient days of llvm, so could very easily be completely wrong, but "works"), I all for removing it and making a new (correct) CPU name as the default for armv6k.
Sep 13 2018
Sep 11 2018
Thanks Florian! LGTM too.
Aug 30 2018
Very detailed, using the modern infrastructure and helpful even to those not using clang or wanting to run external benchmarks.