- User Since
- Oct 19 2012, 12:57 AM (544 w, 2 d)
Mon, Mar 13
Sat, Mar 11
IIRC, "abi" used to be what Arm called, but "env" is equally good. And it it's consistent with Triple.h, even better. LGTM, thanks!
Fri, Mar 10
Thu, Mar 9
PS: I have just merged the dependency D144690.
This looks good to me. @fhahn ?
Wed, Mar 8
Tue, Mar 7
Fri, Mar 3
Overall looks good to me, thanks!
Sun, Feb 26
Nice work! I have some comments inline, mostly to understand the dialect.
Feb 20 2023
Feb 6 2023
Running with ninja without -j means it will take more than the number of cores by default. If you want a single core, you need to specify -j1.
Jan 26 2023
Ok, created a proposal to split builtins: https://discourse.llvm.org/t/proposal-split-built-ins-from-the-rest-of-compiler-rt/67978
Jan 25 2023
Just to make sure there's no panic, I'm blocking the revision until more people looked over. I'll remove once we have a number of approvals from people in different positions.
Jan 23 2023
Jan 15 2023
Nice! Thanks for the detailed reporting. LGTM.
Jan 11 2023
Jan 10 2023
Thanks everyone, this looks like a good state and consensus. @SixWeining please check with @tstellar directly before merging, to make sure you get the right time for the release.
Thanks @chelini, LGTM now, but I'll let others make the final approval.
Jan 9 2023
Jan 7 2023
Thank you for your continued contributions, @SixWeining!
Jan 6 2023
Dec 15 2022
Make sure you add a note to the changelog, so people know you've changed all the enums involved.
Dec 12 2022
Dec 9 2022
Small nit, but this looks great, thanks!
Dec 8 2022
Galina may be on extended holiday.
Dec 2 2022
LGTM, thanks! Please check with @gkistanova before merging.
Dec 1 2022
Nov 29 2022
Nov 26 2022
LGTM, thanks! @chelini any comments?
Nov 24 2022
Nov 21 2022
LGTM too, with a nit.
Nov 17 2022
Nov 16 2022
Nov 13 2022
Nov 12 2022
Simplified what's exposed to the methods, keeping the Options on the CPP file. Rebased and all tests pass.
Nov 11 2022
Oct 27 2022
Oct 21 2022
Oct 12 2022
As per that thread, indeed MCJIT is on the way out and you should go for OrcJIT if you want JIT support in LoongArch.
All my comments addressed, if other people are happy, I'm also happy. Thanks!
Sep 28 2022
Sep 27 2022
Looks good, with some nits. Thanks!
Sep 26 2022
Honestly, there isn't much meat here, other than the decision to support and the name bikeshedding, both of which I think are well covered in the RFC.
Sep 23 2022
Thanks, looks good to me!
Sep 22 2022
Sep 17 2022
I can't vouch for your ABI correctness, but you seem to have a lot of tests covering what you claim to have implemented, so looks good to me.
Sep 15 2022
I think we can safely say that we care less about jazelle than we care about armv1/2/3, so feel free to ignore that, too.
Sep 8 2022
Sep 7 2022
A few nits, but looks good to me, thanks!
Sep 2 2022
Agree. Even 10 years ago we made the concerted effort not to care about pre-v4, so I'd be a little surprised if people are actually using modern clang to target those platforms.
Aug 26 2022
Aug 9 2022
Jul 30 2022
Looks simple enough!
Jul 27 2022
Jul 21 2022
This looks great, thanks!
Jun 16 2022
No requests, this looks simple enough for me, thanks!
Jun 9 2022
Makes sense, I have no additional comments. LGTM, thanks!
I don't know much about DX but this looks like object emission to me. :)
I don't know much about DirectX but I'm assuming all of those (what, dialects?) will be coming through the same printers/parsers, right?
Is this the only thing the Asm Printer will ever do? Does it mean you'll never emit asm files or is there another way to get it out (and if there is, why aren't the constants there, too)?
This looks fine to me. I don't see how this can be tested and if it never will have functionality in the future, there's not point in even trying.
Jun 7 2022
LGTM, super simple, too.
LGTM, simple and straightforward.
Perhaps wait a few days to make sure other people have time to comment, too.
Jun 2 2022
As with the alternative, this needs more agreements, but in this case, it touches more files and the probability it will create merge conflicts with other people's in-flight work increases.
Jun 1 2022
I don't know how people feel nowadays about clang-formatting an entire file.
May 27 2022
May 26 2022
This looks good to me, but wait to make sure others see it, too.
May 25 2022
First, I think this is a good idea and can eventually mitigate the general problem of intrinsics vs. instructions in other LLVM passes.
May 12 2022
May 7 2022
May 6 2022
Apr 21 2022
Apr 20 2022
Apr 19 2022
Looks reasonable to me. Some nits on file naming and definition placement. Thanks!
Apr 14 2022
Thanks @iliya-diyachkov, it looks cleaner, even if still very long. A table generated output will hopefully fix this soon.
Apr 13 2022
Apr 6 2022
Apologies, it seems I was looking into a very old version of the review!