Page MenuHomePhabricator

rovka (Diana Picus)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2016, 3:27 AM (156 w, 6 d)

Recent Activity

Wed, Apr 10

rovka committed rG6bdade85de47: Fixup r358063 (authored by rovka).
Fixup r358063
Wed, Apr 10, 2:30 AM
rovka committed rL358065: Fixup r358063.
Fixup r358063
Wed, Apr 10, 2:29 AM
rovka committed rG4a7f8d8d6b18: [ARM GlobalISel] Add some asserts. NFC. (authored by rovka).
[ARM GlobalISel] Add some asserts. NFC.
Wed, Apr 10, 2:15 AM
rovka committed rGb6e83b98f94a: [ARM GlobalISel] Select G_FCONSTANT for VFP3 (authored by rovka).
[ARM GlobalISel] Select G_FCONSTANT for VFP3
Wed, Apr 10, 2:15 AM
rovka committed rG3533ad6801e5: [ARM GlobalISel] Select G_FCONSTANT into pools (authored by rovka).
[ARM GlobalISel] Select G_FCONSTANT into pools
Wed, Apr 10, 2:14 AM
rovka committed rG165846b031c8: [ARM GlobalISel] Map G_FCONSTANT (authored by rovka).
[ARM GlobalISel] Map G_FCONSTANT
Wed, Apr 10, 2:14 AM
rovka committed rL358064: [ARM GlobalISel] Add some asserts. NFC..
[ARM GlobalISel] Add some asserts. NFC.
Wed, Apr 10, 2:14 AM
rovka committed rL358063: [ARM GlobalISel] Select G_FCONSTANT for VFP3.
[ARM GlobalISel] Select G_FCONSTANT for VFP3
Wed, Apr 10, 2:14 AM
rovka committed rL358062: [ARM GlobalISel] Select G_FCONSTANT into pools.
[ARM GlobalISel] Select G_FCONSTANT into pools
Wed, Apr 10, 2:14 AM
rovka committed rL358061: [ARM GlobalISel] Map G_FCONSTANT.
[ARM GlobalISel] Map G_FCONSTANT
Wed, Apr 10, 2:14 AM

Thu, Apr 4

rovka committed rG153c3887e4e7: [ARM GlobalISel] Support DBG_VALUE (authored by rovka).
[ARM GlobalISel] Support DBG_VALUE
Thu, Apr 4, 3:24 AM
rovka committed rL357681: [ARM GlobalISel] Support DBG_VALUE.
[ARM GlobalISel] Support DBG_VALUE
Thu, Apr 4, 3:23 AM
rovka added a comment to D32530: [SVE][IR] Scalable Vector IR Type.

I'd advise caution here, it's really significant/impactful change, and a single sign-off is a bit worrying.

There were several people who voted for a scalable vector type in the llvm-dev thread that I referred to
http://lists.llvm.org/pipermail/llvm-dev/2019-March/131137.html
Maybe those people can also sign-off to accept this change.

I am somewhat against extending the IR with the SV type
and I recognize that as we stand today adding the SV type is a good way to get ARM-SVE support in LLVM.

Thu, Apr 4, 2:04 AM

Wed, Apr 3

rovka added a comment to D32530: [SVE][IR] Scalable Vector IR Type.

I'd advise caution here, it's really significant/impactful change, and a single sign-off is a bit worrying.

Wed, Apr 3, 1:48 AM

Thu, Mar 28

rovka committed rG13ef0c530913: [ARM GlobalISel] Run regbankselect test for Thumb. NFCI (authored by rovka).
[ARM GlobalISel] Run regbankselect test for Thumb. NFCI
Thu, Mar 28, 3:59 AM
rovka committed rL357159: [ARM GlobalISel] Run regbankselect test for Thumb. NFCI.
[ARM GlobalISel] Run regbankselect test for Thumb. NFCI
Thu, Mar 28, 3:58 AM
rovka committed rG52495c472ff8: [ARM GlobalISel] Fix G_STORE with s1 (authored by rovka).
[ARM GlobalISel] Fix G_STORE with s1
Thu, Mar 28, 2:09 AM
rovka committed rG4d512df30035: [ARM GlobalISel] Fix selection of G_SELECT (authored by rovka).
[ARM GlobalISel] Fix selection of G_SELECT
Thu, Mar 28, 2:09 AM
rovka committed rL357154: [ARM GlobalISel] Fix G_STORE with s1.
[ARM GlobalISel] Fix G_STORE with s1
Thu, Mar 28, 2:09 AM
rovka committed rL357153: [ARM GlobalISel] Fix selection of G_SELECT.
[ARM GlobalISel] Fix selection of G_SELECT
Thu, Mar 28, 2:09 AM

Mar 25 2019

rovka committed rG254b11a0fd86: [ARM GlobalISel] 64-bit memops should be aligned (authored by rovka).
[ARM GlobalISel] 64-bit memops should be aligned
Mar 25 2019, 1:55 AM
rovka committed rL356872: [ARM GlobalISel] 64-bit memops should be aligned.
[ARM GlobalISel] 64-bit memops should be aligned
Mar 25 2019, 1:55 AM

Mar 20 2019

rovka added a comment to D32530: [SVE][IR] Scalable Vector IR Type.

Seems fine in general, just some nits.

Mar 20 2019, 9:32 AM

Mar 1 2019

rovka committed rG54829ec5d037: [ARM GlobalISel] Support G_CTLZ for Thumb2 (authored by rovka).
[ARM GlobalISel] Support G_CTLZ for Thumb2
Mar 1 2019, 2:14 AM
rovka committed rL355191: [ARM GlobalISel] Support G_CTLZ for Thumb2.
[ARM GlobalISel] Support G_CTLZ for Thumb2
Mar 1 2019, 2:12 AM
rovka committed rGafb3398da0fe: [ARM GlobalISel] Check target flags in test. NFCI (authored by rovka).
[ARM GlobalISel] Check target flags in test. NFCI
Mar 1 2019, 2:01 AM
rovka committed rL355189: [ARM GlobalISel] Check target flags in test. NFCI.
[ARM GlobalISel] Check target flags in test. NFCI
Mar 1 2019, 2:00 AM

Feb 28 2019

rovka committed rGcf0ff638bce4: [ARM GlobalISel] Make arm_i32imm an IntImmLeaf (authored by rovka).
[ARM GlobalISel] Make arm_i32imm an IntImmLeaf
Feb 28 2019, 3:13 AM
rovka committed rL355083: [ARM GlobalISel] Make arm_i32imm an IntImmLeaf.
[ARM GlobalISel] Make arm_i32imm an IntImmLeaf
Feb 28 2019, 3:13 AM
rovka closed D58031: [ARM GlobalISel] Make arm_i32imm an IntImmLeaf.
Feb 28 2019, 3:13 AM · Restricted Project
rovka committed rG3b7beafc775d: [ARM GlobalISel] Support global variables for Thumb2 (authored by rovka).
[ARM GlobalISel] Support global variables for Thumb2
Feb 28 2019, 2:43 AM
rovka committed rL355077: [ARM GlobalISel] Support global variables for Thumb2.
[ARM GlobalISel] Support global variables for Thumb2
Feb 28 2019, 2:43 AM

Feb 25 2019

rovka added a comment to D58031: [ARM GlobalISel] Make arm_i32imm an IntImmLeaf.

Ping

Feb 25 2019, 2:20 AM · Restricted Project

Feb 22 2019

rovka committed rG35e1c6663c37: [ARM GlobalISel] Support floating point for Thumb2 (authored by rovka).
[ARM GlobalISel] Support floating point for Thumb2
Feb 22 2019, 1:55 AM
rovka committed rL354665: [ARM GlobalISel] Support floating point for Thumb2.
[ARM GlobalISel] Support floating point for Thumb2
Feb 22 2019, 1:54 AM

Feb 21 2019

rovka accepted D58351: ARM: Add ImmArg to intrinsics.

Ok, thanks!

Feb 21 2019, 6:17 AM
rovka committed rGdcaa939ab75e: [ARM GlobalISel] Support G_FRAME_INDEX for Thumb2 (authored by rovka).
[ARM GlobalISel] Support G_FRAME_INDEX for Thumb2
Feb 21 2019, 5:00 AM
rovka committed rL354579: [ARM GlobalISel] Support G_FRAME_INDEX for Thumb2.
[ARM GlobalISel] Support G_FRAME_INDEX for Thumb2
Feb 21 2019, 4:59 AM

Feb 20 2019

rovka added a comment to D58351: ARM: Add ImmArg to intrinsics.

Can you explain why this is relevant only for GCC builtins that don't require mangling? Otherwise LGTM.

Feb 20 2019, 2:24 AM

Feb 19 2019

rovka committed rG55d41a78ac45: Fix obsolete comment. NFC (authored by rovka).
Fix obsolete comment. NFC
Feb 19 2019, 3:35 AM
rovka committed rL354316: Fix obsolete comment. NFC.
Fix obsolete comment. NFC
Feb 19 2019, 3:35 AM
rovka committed rG19dbc6245fd9: [ARM GlobalISel] Support G_PHI for Thumb2 (authored by rovka).
[ARM GlobalISel] Support G_PHI for Thumb2
Feb 19 2019, 2:27 AM
rovka committed rL354310: [ARM GlobalISel] Support G_PHI for Thumb2.
[ARM GlobalISel] Support G_PHI for Thumb2
Feb 19 2019, 2:27 AM

Feb 15 2019

rovka committed rGc0f964eb2f19: [ARM GlobalISel] Style fix. NFCI (authored by rovka).
[ARM GlobalISel] Style fix. NFCI
Feb 15 2019, 2:54 AM
rovka committed rL354115: [ARM GlobalISel] Style fix. NFCI.
[ARM GlobalISel] Style fix. NFCI
Feb 15 2019, 2:54 AM
rovka committed rGa00425ff0d04: [ARM GlobalISel] Support branches for Thumb2 (authored by rovka).
[ARM GlobalISel] Support branches for Thumb2
Feb 15 2019, 2:24 AM
rovka committed rL354113: [ARM GlobalISel] Support branches for Thumb2.
[ARM GlobalISel] Support branches for Thumb2
Feb 15 2019, 2:23 AM

Feb 13 2019

rovka added a comment to D58171: Fix thread sanitizer on aarch64.

Looks good to me.

How do we submit this now? Perhaps we need to squash the main fibers patch, check_analyze patch and this into one.

Feb 13 2019, 4:52 AM · Restricted Project, Restricted Project
rovka added a comment to D58171: Fix thread sanitizer on aarch64.

This seems to solve the problem on AArch64. I'll let the others approve if it's the right fix from a compiler-rt perspective.

Feb 13 2019, 4:18 AM · Restricted Project, Restricted Project
rovka added a comment to D58171: Fix thread sanitizer on aarch64.

Testing in progress, I'll let you know how it went. Thanks for the quick fix!

Feb 13 2019, 4:06 AM · Restricted Project, Restricted Project
rovka committed rGd3f13f160899: Revert "tsan: update check_analyze.sh" (authored by rovka).
Revert "tsan: update check_analyze.sh"
Feb 13 2019, 4:06 AM
rovka committed rL353942: Revert "tsan: update check_analyze.sh".
Revert "tsan: update check_analyze.sh"
Feb 13 2019, 4:06 AM
rovka committed rCRT353942: Revert "tsan: update check_analyze.sh".
Revert "tsan: update check_analyze.sh"
Feb 13 2019, 4:05 AM
rovka committed rG4152a09e5537: Revert "tsan: add fiber support" (authored by rovka).
Revert "tsan: add fiber support"
Feb 13 2019, 3:33 AM
rovka committed rCRT353939: Revert "tsan: add fiber support".
Revert "tsan: add fiber support"
Feb 13 2019, 3:32 AM
rovka committed rL353939: Revert "tsan: add fiber support".
Revert "tsan: add fiber support"
Feb 13 2019, 3:32 AM
rovka committed rGaa4118a8738e: [ARM GlobalISel] Support G_SELECT for Thumb2 (authored by rovka).
[ARM GlobalISel] Support G_SELECT for Thumb2
Feb 13 2019, 3:26 AM
rovka committed rL353938: [ARM GlobalISel] Support G_SELECT for Thumb2.
[ARM GlobalISel] Support G_SELECT for Thumb2
Feb 13 2019, 3:26 AM
rovka added a comment to D54889: Fiber support for thread sanitizer.

Hi Yuri,

Feb 13 2019, 3:26 AM · Restricted Project, Restricted Project

Feb 11 2019

rovka edited reviewers for D58031: [ARM GlobalISel] Make arm_i32imm an IntImmLeaf, added: eli.friedman; removed: eliben.
Feb 11 2019, 2:59 AM · Restricted Project
rovka created D58031: [ARM GlobalISel] Make arm_i32imm an IntImmLeaf.
Feb 11 2019, 2:58 AM · Restricted Project
rovka closed D57941: test-release.sh: Add option to use ninja.

Thanks! r353685

Feb 11 2019, 2:31 AM · Restricted Project
rovka committed rG2d29cc311be9: test-release.sh: Add option to use ninja (authored by rovka).
test-release.sh: Add option to use ninja
Feb 11 2019, 2:30 AM
rovka committed rL353685: test-release.sh: Add option to use ninja.
test-release.sh: Add option to use ninja
Feb 11 2019, 2:30 AM

Feb 8 2019

rovka added inline comments to D57812: [ARM] Add OptMinSize Subtarget feature.
Feb 8 2019, 2:34 AM · Restricted Project
rovka created D57941: test-release.sh: Add option to use ninja.
Feb 8 2019, 1:47 AM · Restricted Project

Feb 7 2019

rovka committed rG75a04e2a77e1: [ARM GlobalISel] Support G_ICMP for Thumb2 (authored by rovka).
[ARM GlobalISel] Support G_ICMP for Thumb2
Feb 7 2019, 3:06 AM
rovka committed rL353392: [ARM GlobalISel] Support G_ICMP for Thumb2.
[ARM GlobalISel] Support G_ICMP for Thumb2
Feb 7 2019, 3:05 AM

Feb 5 2019

rovka committed rGe24b104a112b: [ARM GlobalISel] Support G_GEP for Thumb2 (authored by rovka).
[ARM GlobalISel] Support G_GEP for Thumb2
Feb 5 2019, 2:22 AM
rovka committed rL353151: [ARM GlobalISel] Support G_GEP for Thumb2.
[ARM GlobalISel] Support G_GEP for Thumb2
Feb 5 2019, 2:21 AM

Jan 28 2019

rovka committed rL352346: [ARM GlobalISel] Support integer division for Thumb2.
[ARM GlobalISel] Support integer division for Thumb2
Jan 28 2019, 2:37 AM

Jan 25 2019

rovka committed rL352188: [ARM GlobalISel] Support shifts for Thumb2.
[ARM GlobalISel] Support shifts for Thumb2
Jan 25 2019, 2:49 AM
rovka committed rL352187: [ARM GlobalISel] Remove rebase artifact from r351882. NFC.
[ARM GlobalISel] Remove rebase artifact from r351882. NFC
Jan 25 2019, 2:49 AM

Jan 17 2019

rovka committed rL351425: Fix capitalization. NFC.
Fix capitalization. NFC
Jan 17 2019, 2:18 AM
rovka committed rL351424: [ARM GlobalISel] Allow calls to varargs functions.
[ARM GlobalISel] Allow calls to varargs functions
Jan 17 2019, 2:17 AM

Jan 14 2019

rovka committed rL351056: [ARM GlobalISel] Import MOVi32imm into GlobalISel.
[ARM GlobalISel] Import MOVi32imm into GlobalISel
Jan 14 2019, 4:07 AM
rovka committed rCRT351040: [asan] Add fallback for Thumb after r350139.
[asan] Add fallback for Thumb after r350139
Jan 14 2019, 1:52 AM
rovka committed rL351040: [asan] Add fallback for Thumb after r350139.
[asan] Add fallback for Thumb after r350139
Jan 14 2019, 1:49 AM
rovka closed D56594: [asan] Add fallback for Thumb after r350139.
Jan 14 2019, 1:49 AM
rovka added a comment to D56594: [asan] Add fallback for Thumb after r350139.

Thanks for the review, I'll commit with your suggestions in place.

Jan 14 2019, 1:47 AM

Jan 11 2019

rovka created D56594: [asan] Add fallback for Thumb after r350139.
Jan 11 2019, 4:52 AM

Jan 10 2019

rovka committed rL350806: [asan] Mark tests as UNSUPPORTED on arm.
[asan] Mark tests as UNSUPPORTED on arm
Jan 10 2019, 1:44 AM
rovka committed rCRT350806: [asan] Mark tests as UNSUPPORTED on arm.
[asan] Mark tests as UNSUPPORTED on arm
Jan 10 2019, 1:44 AM

Dec 19 2018

rovka committed rL349610: [ARM GlobalISel] Support G_CONSTANT for Thumb2.
[ARM GlobalISel] Support G_CONSTANT for Thumb2
Dec 19 2018, 1:58 AM

Dec 14 2018

rovka committed rL349147: [ARM GlobalISel] Thumb2: casts between int and ptr.
[ARM GlobalISel] Thumb2: casts between int and ptr
Dec 14 2018, 5:49 AM
rovka committed rL349146: [ARM GlobalISel] Remove duplicate test. NFCI.
[ARM GlobalISel] Remove duplicate test. NFCI
Dec 14 2018, 5:31 AM
rovka committed rL349143: [ARM GlobalISel] Minor refactoring. NFCI.
[ARM GlobalISel] Minor refactoring. NFCI
Dec 14 2018, 4:40 AM
rovka committed rL349142: [ARM GlobalISel] Allow simple binary ops in Thumb2.
[ARM GlobalISel] Allow simple binary ops in Thumb2
Dec 14 2018, 4:01 AM

Dec 13 2018

rovka committed rL349026: [ARM GlobalISel] Support exts and truncs for Thumb2.
[ARM GlobalISel] Support exts and truncs for Thumb2
Dec 13 2018, 4:10 AM

Dec 12 2018

rovka committed rL348920: [ARM GlobalISel] Select load/store for Thumb2.
[ARM GlobalISel] Select load/store for Thumb2
Dec 12 2018, 2:35 AM

Dec 6 2018

rovka committed rL348472: [ARM GlobalISel] Nothing is legal for Thumb.
[ARM GlobalISel] Nothing is legal for Thumb
Dec 6 2018, 1:31 AM
rovka committed rL348466: Fixup r348306: Require x86 for test.
Fixup r348306: Require x86 for test
Dec 6 2018, 12:57 AM
rovka committed rLLD348466: Fixup r348306: Require x86 for test.
Fixup r348306: Require x86 for test
Dec 6 2018, 12:57 AM

Dec 5 2018

rovka committed rL348347: [ARM GlobalISel] Implement call lowering for Thumb2.
[ARM GlobalISel] Implement call lowering for Thumb2
Dec 5 2018, 2:38 AM

Nov 26 2018

rovka committed rL347545: [ARM GlobalISel] Support G_CTLZ and G_CTLZ_ZERO_UNDEF.
[ARM GlobalISel] Support G_CTLZ and G_CTLZ_ZERO_UNDEF
Nov 26 2018, 3:10 AM
rovka committed rL347544: Fix typo in comment. NFC.
Fix typo in comment. NFC
Nov 26 2018, 3:10 AM

Nov 22 2018

rovka committed rL347447: [ARM GlobalISel] Add test for BFC. NFCI.
[ARM GlobalISel] Add test for BFC. NFCI
Nov 22 2018, 1:57 AM

Nov 14 2018

rovka committed rLLD346842: Fix r346747 and r346796.
Fix r346747 and r346796
Nov 14 2018, 2:02 AM
rovka committed rL346842: Fix r346747 and r346796.
Fix r346747 and r346796
Nov 14 2018, 2:00 AM

Feb 15 2018

rovka abandoned D40074: [GISel] Canonicalize constants to RHS for commutative operations.

This doesn't seem to be what we want to do in the long run.

Feb 15 2018, 4:24 AM