Page MenuHomePhabricator

rovka (Diana Picus)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2016, 3:27 AM (164 w, 4 d)

Recent Activity

Mon, May 27

rovka committed rGc675215f6799: [ARM GlobalISel] Un-XFAIL some tests. NFC (authored by rovka).
[ARM GlobalISel] Un-XFAIL some tests. NFC
Mon, May 27, 3:31 AM
rovka committed rL361756: [ARM GlobalISel] Un-XFAIL some tests. NFC.
[ARM GlobalISel] Un-XFAIL some tests. NFC
Mon, May 27, 3:31 AM
rovka committed rG68b20c589c48: [ARM GlobalISel] Cleanup CallLowering a bit (authored by rovka).
[ARM GlobalISel] Cleanup CallLowering a bit
Mon, May 27, 3:31 AM
rovka committed rL361755: [ARM GlobalISel] Cleanup CallLowering a bit.
[ARM GlobalISel] Cleanup CallLowering a bit
Mon, May 27, 3:27 AM

May 17 2019

rovka accepted D62000: [AArch64][SVE2] Asm: add int halving add/sub (predicated) instructions.

LGTM but I have one question :)

May 17 2019, 1:35 AM · Restricted Project
rovka accepted D61998: [AArch64][SVE2] Asm: add saturating multiply-add interleaved long instructions.

LGTM

May 17 2019, 1:18 AM · Restricted Project

May 16 2019

rovka accepted D61951: [AArch64][SVE2] Asm: add integer multiply-add long instructions.

LGTM

May 16 2019, 1:25 AM · Restricted Project
rovka accepted D61936: [AArch64][SVE2] Asm: add integer multiply long instructions.

LGTM

May 16 2019, 1:15 AM · Restricted Project

May 15 2019

rovka added a comment to D61903: [AArch64][SVE2] Asm: implement CDOT instruction.

Ah, sorry, didn't noticed the LGTM until I clicked the submit button.

May 15 2019, 1:42 AM · Restricted Project
rovka accepted D61902: [AArch64][SVE2] Asm: add unpredicated integer multiply instructions.

LGTM with minor nits.

May 15 2019, 1:40 AM · Restricted Project
rovka accepted D61903: [AArch64][SVE2] Asm: implement CDOT instruction.

LGTM

May 15 2019, 12:50 AM · Restricted Project

May 14 2019

rovka committed rGa568222ddd4c: [IRTranslator] Don't hardcode GEP index type (authored by rovka).
[IRTranslator] Don't hardcode GEP index type
May 14 2019, 2:24 AM
rovka committed rL360656: [IRTranslator] Don't hardcode GEP index type.
[IRTranslator] Don't hardcode GEP index type
May 14 2019, 2:24 AM
rovka closed D61852: [IRTranslator] Don't hardcode GEP index type.
May 14 2019, 2:24 AM · Restricted Project
rovka accepted D61514: [AArch64][SVE2] Asm: add integer multiply-add/subtract (indexed) instructions.

LGTM

May 14 2019, 1:32 AM · Restricted Project
rovka accepted D61515: [AArch64][SVE2] Asm: add SQRDMLAH/SQRDMLSH instructions.

Ok, thanks for looking into it! LGTM

May 14 2019, 1:32 AM · Restricted Project

May 13 2019

rovka added inline comments to D61289: [globalisel] Add G_SEXT_INREG.
May 13 2019, 5:36 AM · Restricted Project
rovka created D61852: [IRTranslator] Don't hardcode GEP index type.
May 13 2019, 4:18 AM · Restricted Project
rovka added a comment to D61844: ARMDefines.h: fix -Wimplicit-fallthrough in -DLLVM_ENABLE_ASSERTIONS=OFF builds.

Why not remove the default clause and put the unreachable after the switch?

May 13 2019, 1:16 AM · Restricted Project

May 9 2019

rovka committed rG3531453371d8: [ARM GlobalISel] Map DBG_VALUE for types != s32 (authored by rovka).
[ARM GlobalISel] Map DBG_VALUE for types != s32
May 9 2019, 2:48 AM
rovka committed rL360321: [ARM GlobalISel] Map DBG_VALUE for types != s32.
[ARM GlobalISel] Map DBG_VALUE for types != s32
May 9 2019, 2:47 AM

May 8 2019

rovka accepted D61435: [AArch64] NFC: Add generic StackOffset to describe scalable offsets..

LGTM with nits. Thanks!

May 8 2019, 2:19 AM
rovka accepted D61513: [AArch64][SVE2] Add SVE2 target features to backend and TargetParser.

LGTM also with the remaining comments addressed.

May 8 2019, 1:10 AM · Restricted Project

May 7 2019

rovka committed rG0a47fb888477: [ARM GlobalISel] Widen G_SELECT operands (authored by rovka).
[ARM GlobalISel] Widen G_SELECT operands
May 7 2019, 4:39 AM
rovka committed rL360135: [ARM GlobalISel] Widen G_SELECT operands.
[ARM GlobalISel] Widen G_SELECT operands
May 7 2019, 4:37 AM
rovka added a comment to D61289: [globalisel] Add G_SEXT_INREG.

Thanks for the explanations. I think you have some good points. Overall, it still looks to me like we're complicating things for backend writers and introducing a lot of subtle distinctions to keep in mind. It would be useful to hear what other people think about this.

May 7 2019, 4:35 AM · Restricted Project
rovka committed rGd6d3808fa432: [ARM GlobalISel] Widen G_INTTOPTR/G_PTRTOINT (authored by rovka).
[ARM GlobalISel] Widen G_INTTOPTR/G_PTRTOINT
May 7 2019, 3:48 AM
rovka committed rL360130: [ARM GlobalISel] Widen G_INTTOPTR/G_PTRTOINT.
[ARM GlobalISel] Widen G_INTTOPTR/G_PTRTOINT
May 7 2019, 3:45 AM
rovka committed rGd18bac5d190c: [ARM GlobalISel] Widen G_GEP index operand (authored by rovka).
[ARM GlobalISel] Widen G_GEP index operand
May 7 2019, 3:11 AM
rovka committed rL360127: [ARM GlobalISel] Widen G_GEP index operand.
[ARM GlobalISel] Widen G_GEP index operand
May 7 2019, 3:10 AM

May 6 2019

rovka added inline comments to D61515: [AArch64][SVE2] Asm: add SQRDMLAH/SQRDMLSH instructions.
May 6 2019, 3:30 AM · Restricted Project
rovka added inline comments to D61513: [AArch64][SVE2] Add SVE2 target features to backend and TargetParser.
May 6 2019, 2:14 AM · Restricted Project

May 3 2019

rovka added a comment to D61435: [AArch64] NFC: Add generic StackOffset to describe scalable offsets..

I'd also add a unit test for StackOffset.

May 3 2019, 4:05 AM

May 2 2019

rovka added inline comments to D61289: [globalisel] Add G_SEXT_INREG.
May 2 2019, 5:18 AM · Restricted Project
rovka committed rG1136ea2d446d: [ARM GlobalISel] Fixup r359768 (authored by rovka).
[ARM GlobalISel] Fixup r359768
May 2 2019, 3:08 AM
rovka committed rL359772: [ARM GlobalISel] Fixup r359768.
[ARM GlobalISel] Fixup r359768
May 2 2019, 3:08 AM
rovka committed rG06a61ccc42ae: [ARM GlobalISel] Select extensions to < 32 bits (authored by rovka).
[ARM GlobalISel] Select extensions to < 32 bits
May 2 2019, 2:26 AM
rovka committed rL359768: [ARM GlobalISel] Select extensions to < 32 bits.
[ARM GlobalISel] Select extensions to < 32 bits
May 2 2019, 2:26 AM
rovka committed rG7da389818d9d: [ARM GlobalISel] Rename some inst selector tests. NFC (authored by rovka).
[ARM GlobalISel] Rename some inst selector tests. NFC
May 2 2019, 2:24 AM
rovka committed rL359767: [ARM GlobalISel] Rename some inst selector tests. NFC.
[ARM GlobalISel] Rename some inst selector tests. NFC
May 2 2019, 2:24 AM
rovka committed rG53bcf6f2e7fc: [ARM GlobalISel] Legalize extensions to < 32 bits (authored by rovka).
[ARM GlobalISel] Legalize extensions to < 32 bits
May 2 2019, 2:20 AM
rovka committed rL359766: [ARM GlobalISel] Legalize extensions to < 32 bits.
[ARM GlobalISel] Legalize extensions to < 32 bits
May 2 2019, 2:20 AM

Apr 30 2019

rovka added inline comments to D61289: [globalisel] Add G_SEXT_INREG.
Apr 30 2019, 5:04 AM · Restricted Project
rovka committed rG59a4c0481a83: [ARM GlobalISel] Widen small shift operands (authored by rovka).
[ARM GlobalISel] Widen small shift operands
Apr 30 2019, 2:23 AM
rovka committed rL359542: [ARM GlobalISel] Widen small shift operands.
[ARM GlobalISel] Widen small shift operands
Apr 30 2019, 2:23 AM
rovka committed rG1e88ac213b63: [ARM GlobalISel] Be more careful about bailing out (authored by rovka).
[ARM GlobalISel] Be more careful about bailing out
Apr 30 2019, 2:04 AM
rovka committed rL359540: [ARM GlobalISel] Be more careful about bailing out.
[ARM GlobalISel] Be more careful about bailing out
Apr 30 2019, 2:03 AM

Apr 10 2019

rovka committed rG6bdade85de47: Fixup r358063 (authored by rovka).
Fixup r358063
Apr 10 2019, 2:30 AM
rovka committed rL358065: Fixup r358063.
Fixup r358063
Apr 10 2019, 2:29 AM
rovka committed rG4a7f8d8d6b18: [ARM GlobalISel] Add some asserts. NFC. (authored by rovka).
[ARM GlobalISel] Add some asserts. NFC.
Apr 10 2019, 2:15 AM
rovka committed rGb6e83b98f94a: [ARM GlobalISel] Select G_FCONSTANT for VFP3 (authored by rovka).
[ARM GlobalISel] Select G_FCONSTANT for VFP3
Apr 10 2019, 2:15 AM
rovka committed rG3533ad6801e5: [ARM GlobalISel] Select G_FCONSTANT into pools (authored by rovka).
[ARM GlobalISel] Select G_FCONSTANT into pools
Apr 10 2019, 2:14 AM
rovka committed rG165846b031c8: [ARM GlobalISel] Map G_FCONSTANT (authored by rovka).
[ARM GlobalISel] Map G_FCONSTANT
Apr 10 2019, 2:14 AM
rovka committed rL358064: [ARM GlobalISel] Add some asserts. NFC..
[ARM GlobalISel] Add some asserts. NFC.
Apr 10 2019, 2:14 AM
rovka committed rL358063: [ARM GlobalISel] Select G_FCONSTANT for VFP3.
[ARM GlobalISel] Select G_FCONSTANT for VFP3
Apr 10 2019, 2:14 AM
rovka committed rL358062: [ARM GlobalISel] Select G_FCONSTANT into pools.
[ARM GlobalISel] Select G_FCONSTANT into pools
Apr 10 2019, 2:14 AM
rovka committed rL358061: [ARM GlobalISel] Map G_FCONSTANT.
[ARM GlobalISel] Map G_FCONSTANT
Apr 10 2019, 2:14 AM

Apr 4 2019

rovka committed rG153c3887e4e7: [ARM GlobalISel] Support DBG_VALUE (authored by rovka).
[ARM GlobalISel] Support DBG_VALUE
Apr 4 2019, 3:24 AM
rovka committed rL357681: [ARM GlobalISel] Support DBG_VALUE.
[ARM GlobalISel] Support DBG_VALUE
Apr 4 2019, 3:23 AM
rovka added a comment to D32530: [SVE][IR] Scalable Vector IR Type.

I'd advise caution here, it's really significant/impactful change, and a single sign-off is a bit worrying.

There were several people who voted for a scalable vector type in the llvm-dev thread that I referred to
http://lists.llvm.org/pipermail/llvm-dev/2019-March/131137.html
Maybe those people can also sign-off to accept this change.

I am somewhat against extending the IR with the SV type
and I recognize that as we stand today adding the SV type is a good way to get ARM-SVE support in LLVM.

Apr 4 2019, 2:04 AM · Restricted Project

Apr 3 2019

rovka added a comment to D32530: [SVE][IR] Scalable Vector IR Type.

I'd advise caution here, it's really significant/impactful change, and a single sign-off is a bit worrying.

Apr 3 2019, 1:48 AM · Restricted Project

Mar 28 2019

rovka committed rG13ef0c530913: [ARM GlobalISel] Run regbankselect test for Thumb. NFCI (authored by rovka).
[ARM GlobalISel] Run regbankselect test for Thumb. NFCI
Mar 28 2019, 3:59 AM
rovka committed rL357159: [ARM GlobalISel] Run regbankselect test for Thumb. NFCI.
[ARM GlobalISel] Run regbankselect test for Thumb. NFCI
Mar 28 2019, 3:58 AM
rovka committed rG52495c472ff8: [ARM GlobalISel] Fix G_STORE with s1 (authored by rovka).
[ARM GlobalISel] Fix G_STORE with s1
Mar 28 2019, 2:09 AM
rovka committed rG4d512df30035: [ARM GlobalISel] Fix selection of G_SELECT (authored by rovka).
[ARM GlobalISel] Fix selection of G_SELECT
Mar 28 2019, 2:09 AM
rovka committed rL357154: [ARM GlobalISel] Fix G_STORE with s1.
[ARM GlobalISel] Fix G_STORE with s1
Mar 28 2019, 2:09 AM
rovka committed rL357153: [ARM GlobalISel] Fix selection of G_SELECT.
[ARM GlobalISel] Fix selection of G_SELECT
Mar 28 2019, 2:09 AM

Mar 25 2019

rovka committed rG254b11a0fd86: [ARM GlobalISel] 64-bit memops should be aligned (authored by rovka).
[ARM GlobalISel] 64-bit memops should be aligned
Mar 25 2019, 1:55 AM
rovka committed rL356872: [ARM GlobalISel] 64-bit memops should be aligned.
[ARM GlobalISel] 64-bit memops should be aligned
Mar 25 2019, 1:55 AM

Mar 20 2019

rovka added a comment to D32530: [SVE][IR] Scalable Vector IR Type.

Seems fine in general, just some nits.

Mar 20 2019, 9:32 AM · Restricted Project

Mar 1 2019

rovka committed rG54829ec5d037: [ARM GlobalISel] Support G_CTLZ for Thumb2 (authored by rovka).
[ARM GlobalISel] Support G_CTLZ for Thumb2
Mar 1 2019, 2:14 AM
rovka committed rL355191: [ARM GlobalISel] Support G_CTLZ for Thumb2.
[ARM GlobalISel] Support G_CTLZ for Thumb2
Mar 1 2019, 2:12 AM
rovka committed rGafb3398da0fe: [ARM GlobalISel] Check target flags in test. NFCI (authored by rovka).
[ARM GlobalISel] Check target flags in test. NFCI
Mar 1 2019, 2:01 AM
rovka committed rL355189: [ARM GlobalISel] Check target flags in test. NFCI.
[ARM GlobalISel] Check target flags in test. NFCI
Mar 1 2019, 2:00 AM

Feb 28 2019

rovka committed rGcf0ff638bce4: [ARM GlobalISel] Make arm_i32imm an IntImmLeaf (authored by rovka).
[ARM GlobalISel] Make arm_i32imm an IntImmLeaf
Feb 28 2019, 3:13 AM
rovka committed rL355083: [ARM GlobalISel] Make arm_i32imm an IntImmLeaf.
[ARM GlobalISel] Make arm_i32imm an IntImmLeaf
Feb 28 2019, 3:13 AM
rovka closed D58031: [ARM GlobalISel] Make arm_i32imm an IntImmLeaf.
Feb 28 2019, 3:13 AM · Restricted Project
rovka committed rG3b7beafc775d: [ARM GlobalISel] Support global variables for Thumb2 (authored by rovka).
[ARM GlobalISel] Support global variables for Thumb2
Feb 28 2019, 2:43 AM
rovka committed rL355077: [ARM GlobalISel] Support global variables for Thumb2.
[ARM GlobalISel] Support global variables for Thumb2
Feb 28 2019, 2:43 AM

Feb 25 2019

rovka added a comment to D58031: [ARM GlobalISel] Make arm_i32imm an IntImmLeaf.

Ping

Feb 25 2019, 2:20 AM · Restricted Project

Feb 22 2019

rovka committed rG35e1c6663c37: [ARM GlobalISel] Support floating point for Thumb2 (authored by rovka).
[ARM GlobalISel] Support floating point for Thumb2
Feb 22 2019, 1:55 AM
rovka committed rL354665: [ARM GlobalISel] Support floating point for Thumb2.
[ARM GlobalISel] Support floating point for Thumb2
Feb 22 2019, 1:54 AM

Feb 21 2019

rovka accepted D58351: ARM: Add ImmArg to intrinsics.

Ok, thanks!

Feb 21 2019, 6:17 AM
rovka committed rGdcaa939ab75e: [ARM GlobalISel] Support G_FRAME_INDEX for Thumb2 (authored by rovka).
[ARM GlobalISel] Support G_FRAME_INDEX for Thumb2
Feb 21 2019, 5:00 AM
rovka committed rL354579: [ARM GlobalISel] Support G_FRAME_INDEX for Thumb2.
[ARM GlobalISel] Support G_FRAME_INDEX for Thumb2
Feb 21 2019, 4:59 AM

Feb 20 2019

rovka added a comment to D58351: ARM: Add ImmArg to intrinsics.

Can you explain why this is relevant only for GCC builtins that don't require mangling? Otherwise LGTM.

Feb 20 2019, 2:24 AM

Feb 19 2019

rovka committed rG55d41a78ac45: Fix obsolete comment. NFC (authored by rovka).
Fix obsolete comment. NFC
Feb 19 2019, 3:35 AM
rovka committed rL354316: Fix obsolete comment. NFC.
Fix obsolete comment. NFC
Feb 19 2019, 3:35 AM
rovka committed rG19dbc6245fd9: [ARM GlobalISel] Support G_PHI for Thumb2 (authored by rovka).
[ARM GlobalISel] Support G_PHI for Thumb2
Feb 19 2019, 2:27 AM
rovka committed rL354310: [ARM GlobalISel] Support G_PHI for Thumb2.
[ARM GlobalISel] Support G_PHI for Thumb2
Feb 19 2019, 2:27 AM

Feb 15 2019

rovka committed rGc0f964eb2f19: [ARM GlobalISel] Style fix. NFCI (authored by rovka).
[ARM GlobalISel] Style fix. NFCI
Feb 15 2019, 2:54 AM
rovka committed rL354115: [ARM GlobalISel] Style fix. NFCI.
[ARM GlobalISel] Style fix. NFCI
Feb 15 2019, 2:54 AM
rovka committed rGa00425ff0d04: [ARM GlobalISel] Support branches for Thumb2 (authored by rovka).
[ARM GlobalISel] Support branches for Thumb2
Feb 15 2019, 2:24 AM
rovka committed rL354113: [ARM GlobalISel] Support branches for Thumb2.
[ARM GlobalISel] Support branches for Thumb2
Feb 15 2019, 2:23 AM

Feb 13 2019

rovka added a comment to D58171: Fix thread sanitizer on aarch64.

Looks good to me.

How do we submit this now? Perhaps we need to squash the main fibers patch, check_analyze patch and this into one.

Feb 13 2019, 4:52 AM · Restricted Project, Restricted Project
rovka added a comment to D58171: Fix thread sanitizer on aarch64.

This seems to solve the problem on AArch64. I'll let the others approve if it's the right fix from a compiler-rt perspective.

Feb 13 2019, 4:18 AM · Restricted Project, Restricted Project
rovka added a comment to D58171: Fix thread sanitizer on aarch64.

Testing in progress, I'll let you know how it went. Thanks for the quick fix!

Feb 13 2019, 4:06 AM · Restricted Project, Restricted Project
rovka committed rGd3f13f160899: Revert "tsan: update check_analyze.sh" (authored by rovka).
Revert "tsan: update check_analyze.sh"
Feb 13 2019, 4:06 AM
rovka committed rL353942: Revert "tsan: update check_analyze.sh".
Revert "tsan: update check_analyze.sh"
Feb 13 2019, 4:06 AM
rovka committed rCRT353942: Revert "tsan: update check_analyze.sh".
Revert "tsan: update check_analyze.sh"
Feb 13 2019, 4:05 AM