- User Since
- Apr 21 2016, 3:27 AM (361 w, 3 d)
Wed, Mar 22
Mon, Mar 20
It seems arc didn't want to update the revision Summary from my commit message, so I'll add this as a comment:
I'm also planning to add this paragraph to the commit message:
Moved the new address space to 128, and clarified that it is an internal address space that can be freely renumbered.
Wed, Mar 15
Tue, Mar 14
Thu, Mar 9
Mon, Feb 27
Feb 23 2023
Feb 22 2023
Feb 17 2023
Thanks for catching those :)
Feb 16 2023
Include new tests in check-all
Jan 30 2023
Sorry, I just noticed this, I'll have a look.
Jan 24 2023
Thanks for the updates, LGTM with nits.
Jan 19 2023
Smaller functions FTW, regardless of whether or not we ever override them :)
Why do we need a new pass? Could we achieve the same goals with a new RegBankSelect mode instead? (Sorry if this was discussed somewhere else and I missed it, in any case I think the commit message should either explain the rationale or point to wherever it's been discussed)
Jan 18 2023
Add tests with undef
Jan 17 2023
This looks very cool! Are there any plans to run it during the pre-merge checks?
Jan 13 2023
Jan 11 2023
Jan 10 2023
Thanks for the quick review! I'm going to leave this around until tomorrow, in case anyone wants to bikeshed about the new name.
Jan 5 2023
Jan 4 2023
Oct 21 2022
Nice tests! :) I have one microscopic nit and one question (because I don't know an awful lot about config files). Thanks for working on this.
Oct 20 2022
Address review comments.
Thanks for the feedback :)
Oct 13 2022
Hi! This is a rework of https://reviews.llvm.org/D134860
Oct 7 2022
Sep 30 2022
Right, I see what you mean. I'll rework this, thanks!
Sep 29 2022
I'm planning to add more tests (see TODO), but I thought it would be good to get some general feedback on the approach first. @Meinersbur had also suggested adding a hypotf to the runtime when compiling for Windows, but this approach seems more flexible and straightforward to me. Other opinions welcome, thanks!
Sep 27 2022
Sep 20 2022
IMO this is a reasonable approach, I only have a few nits.
Sep 16 2022
Hi, I have a couple of questions:
- Are you actually testing on all these platforms? I don't think I've seen any BSD binaries for LLVM 15.
- Do you plan to add any buildbots with flang on *BSD?
- How different is the ABI from plain Linux? Will you need any changes in the handling of Complex / Character types (see the target-rewrite-* tests like this one) ?
Sep 15 2022
This doesn't have any tests, could you please add some? If memory holds, you should be able to add some RUN/CHECK lines here: https://github.com/llvm/llvm-project/blob/main/flang/test/Fir/target-rewrite-complex.fir
Sep 13 2022
Sep 8 2022
Sep 5 2022
LGTM! Thanks for putting up with so many rounds of review. I have 2 more nits, but you don't have to submit another diff. Do you have commit access?
Sep 1 2022
Thanks for getting back to this, it's starting to look very nice and slender! :) I have a few more comments, all pretty minor.
Aug 29 2022
Aug 23 2022
@gkistanova Can we please have a buildmaster restart to include this? This should fix the failures we're seeing on https://lab.llvm.org/buildbot/#/builders/197
Thanks & sorry about the trouble!