rovka (Diana Picus)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2016, 3:27 AM (91 w, 3 d)

Recent Activity

Thu, Jan 18

rovka added inline comments to D42244: [globalisel] Introduce LegalityQuery to better encapsulate the legalizer decisions. NFC..
Thu, Jan 18, 1:11 PM

Wed, Jan 17

rovka committed rL322667: [ARM GlobalISel] Rename local variable. NFC.
[ARM GlobalISel] Rename local variable. NFC
Wed, Jan 17, 7:27 AM
rovka committed rL322665: [ARM GlobalISel] Add instselect tests for G_FPEXT and G_FPTRUNC.
[ARM GlobalISel] Add instselect tests for G_FPEXT and G_FPTRUNC
Wed, Jan 17, 7:02 AM
rovka committed rL322657: [ARM GlobalISel] Map G_FPEXT and G_FPTRUNC to FPR.
[ARM GlobalISel] Map G_FPEXT and G_FPTRUNC to FPR
Wed, Jan 17, 6:15 AM
rovka committed rL322651: [ARM GlobalISel] Legalize G_FPEXT and G_FPTRUNC.
[ARM GlobalISel] Legalize G_FPEXT and G_FPTRUNC
Wed, Jan 17, 5:35 AM

Mon, Jan 15

rovka accepted D42041: [PATCH 6/6] [zorg] Don't use -DCMAKE_C_COMPILER*/-DCMAKE_CXX_COMPILER*.

LGTM.

Mon, Jan 15, 6:10 AM
rovka added inline comments to D42040: [PATCH 5/6] [zorg] Add linaro-armv8-01-arm-* slaves.
Mon, Jan 15, 5:50 AM
rovka accepted D42039: [PATCH 4/6] [zorg] Rename linaro-d05-01-* slaves to linaro-armv8-01-*.

LGTM, but I think you should commit the BOTO change separately.

Mon, Jan 15, 5:37 AM
rovka accepted D42038: [PATCH 3/6] [zorg] Remove clang-cmake-thumbv7-a15 bot.

LGTM.

Mon, Jan 15, 5:21 AM
rovka accepted D42037: [PATCH 2/6] [zorg] Use slave's "jobs" setting for ARM 32-bit bots..

LGTM, but I have a couple of nitpicks:

  • Why is this PATCH 2/6? It doesn't seem related to either 1/6 or 3/6 and can be committed independently
  • The summary just repeats the title. A better summary would be something along the lines of "Don't force the number of jobs on the ARM builders. This makes it possible to fall back on the number of jobs configured for the slave instead."
Mon, Jan 15, 5:20 AM

Fri, Jan 12

rovka committed rL322368: [ARM GlobalISel] Add inst selector tests for G_FMA.
[ARM GlobalISel] Add inst selector tests for G_FMA
Fri, Jan 12, 4:45 AM
rovka committed rL322367: [ARM GlobalISel] Map G_FMA to FPR.
[ARM GlobalISel] Map G_FMA to FPR
Fri, Jan 12, 4:07 AM
rovka committed rL322366: [ARM GlobalISel] Legalize G_FMA.
[ARM GlobalISel] Legalize G_FMA
Fri, Jan 12, 3:32 AM

Wed, Jan 10

rovka committed rL322170: [ARM GlobalISel] Add inst selector tests for G_FNEG s32 and s64.
[ARM GlobalISel] Add inst selector tests for G_FNEG s32 and s64
Wed, Jan 10, 3:14 AM
rovka committed rL322169: [ARM GlobalISel] Map G_FNEG to the FPR bank.
[ARM GlobalISel] Map G_FNEG to the FPR bank
Wed, Jan 10, 3:14 AM
rovka committed rL322168: [ARM GlobalISel] Legalize G_FNEG for s32 and s64.
[ARM GlobalISel] Legalize G_FNEG for s32 and s64
Wed, Jan 10, 2:46 AM
rovka committed rL322164: [ARM GlobalISel] Legalize s32/s64 G_FCONSTANT.
[ARM GlobalISel] Legalize s32/s64 G_FCONSTANT
Wed, Jan 10, 2:03 AM
rovka committed rL322162: [ARM GlobalISel] Legalize G_CONSTANT for scalars > 32 bits.
[ARM GlobalISel] Legalize G_CONSTANT for scalars > 32 bits
Wed, Jan 10, 1:33 AM

Thu, Jan 4

rovka committed rL321797: [ARM GlobalISel] Select G_PHI.
[ARM GlobalISel] Select G_PHI
Thu, Jan 4, 5:10 AM
rovka committed rL321796: [ARM GlobalISel] Add RegBankSelect tests for G_PHI.
[ARM GlobalISel] Add RegBankSelect tests for G_PHI
Thu, Jan 4, 5:10 AM
rovka committed rL321795: [ARM GlobalISel] Legalize scalar G_PHI.
[ARM GlobalISel] Legalize scalar G_PHI
Thu, Jan 4, 5:10 AM
rovka committed rL321793: [ARM GlobalISel] Fix selection of pointer constants.
[ARM GlobalISel] Fix selection of pointer constants
Thu, Jan 4, 2:56 AM

Dec 22 2017

rovka committed rL321356: [ARM GlobalISel] Support G_INTTOPTR and G_PTRTOINT for s32.
[ARM GlobalISel] Support G_INTTOPTR and G_PTRTOINT for s32
Dec 22 2017, 5:06 AM
rovka committed rL321354: [ARM GlobalISel] Support pointer constants.
[ARM GlobalISel] Support pointer constants
Dec 22 2017, 3:10 AM

Dec 20 2017

rovka committed rL321165: [ARM GlobalISel] Fix assertion in RegBankSelect.
[ARM GlobalISel] Fix assertion in RegBankSelect
Dec 20 2017, 3:28 AM

Dec 18 2017

rovka committed rL320980: [ARM GlobalISel] Fix G_(UN)MERGE_VALUES handling after r319524.
[ARM GlobalISel] Fix G_(UN)MERGE_VALUES handling after r319524
Dec 18 2017, 5:23 AM

Dec 11 2017

rovka committed rL320367: [zorg] Cleanup CC/CXX settings for Linaro Arm/AArch64 bots.
[zorg] Cleanup CC/CXX settings for Linaro Arm/AArch64 bots
Dec 11 2017, 6:32 AM
rovka closed D40608: [PATCH 2/3] [zorg] Cleanup CC/CXX settings for Linaro Arm/AArch64 bots by committing rL320367: [zorg] Cleanup CC/CXX settings for Linaro Arm/AArch64 bots.
Dec 11 2017, 6:32 AM
rovka committed rL320364: [zorg] Add linaro-d05-* builders.
[zorg] Add linaro-d05-* builders
Dec 11 2017, 6:12 AM
rovka closed D40607: [zorg] Add linaro-d05-* builders by committing rL320364: [zorg] Add linaro-d05-* builders.
Dec 11 2017, 6:12 AM
rovka committed rL320362: [ARM GlobalISel] Add test for a MOVTi16 pattern. NFC.
[ARM GlobalISel] Add test for a MOVTi16 pattern. NFC
Dec 11 2017, 5:29 AM
rovka committed rL320352: [ARM GlobalISel] Add tests for PKHBT and PKHTB.
[ARM GlobalISel] Add tests for PKHBT and PKHTB
Dec 11 2017, 3:45 AM
rovka accepted D40789: [GlobalISel] Disable GISel for big endian.

LGTM until we can handle big endian. Sorry about the delay.

Dec 11 2017, 2:07 AM

Dec 4 2017

rovka accepted D40607: [zorg] Add linaro-d05-* builders.

@rovka , slaves linaro-d05-01-* will run in different containers on the same machine (linaro-d05-01). In this context there is no need to repurpose a slave.
I plan to add a second machine linaro-d05-02 that would host the same set of slaves/builders for redundancy.

Dec 4 2017, 1:13 AM

Dec 1 2017

rovka added a reviewer for D40609: [PATCH 1/6] [zorg] Remove obsolete workarounds for Arm/AArch64 libcxx bots: mclow.lists.
Dec 1 2017, 3:07 AM
rovka accepted D40608: [PATCH 2/3] [zorg] Cleanup CC/CXX settings for Linaro Arm/AArch64 bots.

LGTM, thanks.

Dec 1 2017, 3:04 AM
rovka added a comment to D40607: [zorg] Add linaro-d05-* builders.

This looks fine, but I think it would be better if the slave names weren't tied to what is currently running on them, but rather to the machine configurations. E.g. if there's no difference in the environment of linaro-d05-01-quick and linaro-d05-global-isel, they should just be linaro-d05-01 and linaro-d05-02. But for instance if the machines running the libcxx bots need something special, then they can be linaro-d05-libcxx-01 and linaro-d05-libcxx-02. That way, if we want to repurpose a slave to run a different builder, it can keep its name without looking awkward, and it's also easy for us to tell which machines have different environments. What do you think?

Dec 1 2017, 2:45 AM

Nov 30 2017

rovka committed rL319428: [ARM GlobalISel] Bail out for byval.
[ARM GlobalISel] Bail out for byval
Nov 30 2017, 4:24 AM
rovka added a comment to D40074: [GISel] Canonicalize constants to RHS for commutative operations.

FWIW, if we did end up introducing canonicalization, we'd prefer it to be a separate pass (so that it can be skipped) and we'd like it to be possible for targets to opt out of (at least some) canonicalizations. We've had a few occasions where we have to repeatedly de-canonicalize in DAGISel.

Nov 30 2017, 4:18 AM

Nov 29 2017

rovka committed rL319313: [ARM GlobalISel] Fix selecting G_BRCOND.
[ARM GlobalISel] Fix selecting G_BRCOND
Nov 29 2017, 6:20 AM
rovka updated subscribers of D40532: [globalisel][tablegen] Fix PR35375 by sign-extending the table value to match getConstantVRegVal().

I think GIM_CheckLiteralInt might have the same issue but I don't think there's any existing rules that would detect the problem. As far as I know X86 is the only user and only uses 0 and 1. We should probably change it to match GIM_CheckConstantInt if only for consistency. Do you agree?

Nov 29 2017, 3:58 AM

Nov 28 2017

rovka accepted D40532: [globalisel][tablegen] Fix PR35375 by sign-extending the table value to match getConstantVRegVal().

I don't know if this fixes every edge case that we currently have with and/or immediates in DAGISel, but it works for the PKHBT and doesn't seem to break anything else, so in the interest of simplicity it's probably a good route to take. You should add a summary when you commit though.

Nov 28 2017, 3:37 AM

Nov 23 2017

rovka committed rL318915: [ARM GlobalISel] Support G_FDIV for s32 and s64.
[ARM GlobalISel] Support G_FDIV for s32 and s64
Nov 23 2017, 5:27 AM
rovka committed rL318910: [ARM GlobalISel] Support G_FMUL for s32 and s64.
[ARM GlobalISel] Support G_FMUL for s32 and s64
Nov 23 2017, 4:44 AM

Nov 21 2017

rovka committed rL318747: [ARM GlobalISel] Add comment for r318398. NFC..
[ARM GlobalISel] Add comment for r318398. NFC.
Nov 21 2017, 2:17 AM

Nov 20 2017

rovka committed rL318643: [ARM GlobalISel] Add test for RSBri. NFC.
[ARM GlobalISel] Add test for RSBri. NFC
Nov 20 2017, 3:05 AM
rovka committed rL318642: [ARM GlobalISel] Clean up binary operator tests. NFC.
[ARM GlobalISel] Clean up binary operator tests. NFC
Nov 20 2017, 2:36 AM

Nov 16 2017

rovka committed rL318398: [ARM GlobalISel] Add tests for BIC. NFC.
[ARM GlobalISel] Add tests for BIC. NFC
Nov 16 2017, 5:33 AM
rovka committed rL318393: [ARM GlobalISel] Add tests for REVSH patterns. NFC.
[ARM GlobalISel] Add tests for REVSH patterns. NFC
Nov 16 2017, 4:30 AM
rovka added a comment to D40074: [GISel] Canonicalize constants to RHS for commutative operations.

If this is the first canonicalization (of potentially many to come) in the IRTranslator, would it make sense to try and document the canonical representation(s) somewhere and/or somehow?

Even better would be a pass that verified canonical order, that could be inserted between other passes in debug mode to verify that optimisations preserve canonical-ness

Nov 16 2017, 3:45 AM

Nov 15 2017

rovka created D40074: [GISel] Canonicalize constants to RHS for commutative operations.
Nov 15 2017, 5:51 AM

Nov 14 2017

rovka committed rL318146: [ARM GlobalISel] Remove C++ code for G_CONSTANT.
[ARM GlobalISel] Remove C++ code for G_CONSTANT
Nov 14 2017, 3:20 AM

Nov 13 2017

rovka added a comment to D39267: [GISel]: Change Legalization from top down to bottom up + DCE.

Hi, I've updated the ARM tests, and you'll need to also commit this together with your patch: https://reviews.llvm.org/differential/diff/122657/

Nov 13 2017, 8:18 AM
rovka committed rL318047: [ARM GlobalISel] Update legalizer test.
[ARM GlobalISel] Update legalizer test
Nov 13 2017, 8:03 AM

Nov 10 2017

rovka added inline comments to D39808: [ARM GlobalISel] Fix call opcode for Thumb .
Nov 10 2017, 10:04 AM

Nov 7 2017

rovka accepted D39747: [globalisel][tablegen] Generate rule coverage and use it to identify untested rules.

Awesome, I could use something like this. LGTM with a few nits.

Nov 7 2017, 10:44 PM
rovka added a comment to D39267: [GISel]: Change Legalization from top down to bottom up + DCE.

Sure, will do.

Nov 7 2017, 8:47 PM
rovka added inline comments to D39592: [ARM|GlobalISel] : Adding legalizer tests for Thumb.
Nov 7 2017, 4:04 AM

Nov 6 2017

rovka added inline comments to D39592: [ARM|GlobalISel] : Adding legalizer tests for Thumb.
Nov 6 2017, 3:05 AM

Nov 3 2017

rovka added a comment to D39592: [ARM|GlobalISel] : Adding legalizer tests for Thumb.

I think it would be simpler to add a RUN line to the existing test (you can rename it to just legalizer.mir if you think the current name would be misleading).

Nov 3 2017, 8:52 AM
rovka added a comment to D39592: [ARM|GlobalISel] : Adding legalizer tests for Thumb.

Hi Javed,

Nov 3 2017, 6:10 AM
rovka committed rL317313: [globalisel][tablegen] Skip src child predicates.
[globalisel][tablegen] Skip src child predicates
Nov 3 2017, 3:30 AM
rovka closed D39554: [globalisel][tablegen] Skip src child predicates by committing rL317313: [globalisel][tablegen] Skip src child predicates.
Nov 3 2017, 3:30 AM
rovka committed rL317312: [ARM GlobalISel] Move the check for Thumb higher up.
[ARM GlobalISel] Move the check for Thumb higher up
Nov 3 2017, 3:30 AM

Nov 2 2017

rovka added a comment to D39554: [globalisel][tablegen] Skip src child predicates.

Sorry about the indirect test, but it's a bit difficult to test directly since this is restricting functionality rather than adding it. Are we interested in having tests for failed imports? I haven't seen any, but I may have missed them...

Nov 2 2017, 8:14 AM
rovka created D39554: [globalisel][tablegen] Skip src child predicates.
Nov 2 2017, 8:09 AM

Nov 1 2017

rovka added a comment to D39415: [ARMISelLowering] Better handling of NEON load/store for sequential memory regions.

I tried to give this a run [1] on top of r317072 on an NVIDIA TK1 (Cortex-A15) and I'm getting some failures in the test-suite (in 42 of the benchmarks) along the lines of [2]. I think we should fix those before worrying about performance numbers...

Nov 1 2017, 6:24 AM

Oct 30 2017

rovka accepted D39261: [GlobalISel|ARM] : Allow legalizing G_FSUB.

LGTM, thanks!

Oct 30 2017, 5:00 AM
rovka committed rL316897: [ARM GlobalISel] Fixup r316572. NFC.
[ARM GlobalISel] Fixup r316572. NFC
Oct 30 2017, 4:58 AM

Oct 26 2017

rovka added inline comments to D39264: [GISel]: Make the combiner check if shifts are legal before creating them.
Oct 26 2017, 2:58 AM

Oct 25 2017

rovka committed rL316573: [ARM GlobalISel] Remove redundant testcases. NFC.
[ARM GlobalISel] Remove redundant testcases. NFC
Oct 25 2017, 5:22 AM
rovka committed rL316572: [ARM GlobalISel] Update test after r316479. NFC.
[ARM GlobalISel] Update test after r316479. NFC
Oct 25 2017, 5:22 AM
rovka committed rL316570: [ARM GlobalISel] Fix call opcodes.
[ARM GlobalISel] Fix call opcodes
Oct 25 2017, 4:43 AM
rovka committed rL316569: [ARM GlobalISel] Split test into 3. NFC.
[ARM GlobalISel] Split test into 3. NFC
Oct 25 2017, 4:21 AM
rovka accepted D39264: [GISel]: Make the combiner check if shifts are legal before creating them.

LGTM with nit.

Oct 25 2017, 1:16 AM
rovka added a comment to D39261: [GlobalISel|ARM] : Allow legalizing G_FSUB.

Hi Javed,

Oct 25 2017, 1:03 AM

Oct 24 2017

rovka committed rL316438: Switch ARM & AArch64 test-suite builders to CMake.
Switch ARM & AArch64 test-suite builders to CMake
Oct 24 2017, 7:05 AM

Oct 19 2017

rovka added a comment to D37775: Add a verifier test to check the access on both sides of COPY are the same.

Hi, here's the patch for the ARM GlobalISel tests: https://reviews.llvm.org/differential/diff/119563/
Let me know if there's anything else that needs addressing on ARM.

Oct 19 2017, 4:14 AM
rovka committed rL316155: [ARM GlobalISel] Fix liveins in test. NFC.
[ARM GlobalISel] Fix liveins in test. NFC
Oct 19 2017, 2:29 AM
rovka committed rL316154: [ARM GlobalISel] Remove redundant tests.
[ARM GlobalISel] Remove redundant tests
Oct 19 2017, 1:51 AM

Oct 18 2017

rovka added a comment to D38918: Update successor after branch relaxation in ARM.

I only cared about not having the Dest BB as a successor because it might cause scheduling issues and\or labels not being emitted, having extra successor wont.

Oct 18 2017, 2:08 AM

Oct 17 2017

rovka added a comment to D37775: Add a verifier test to check the access on both sides of COPY are the same.

Sorry, I just noticed this. I'll have a look at the ARM side of things.

Oct 17 2017, 1:56 AM
rovka added a comment to D38918: Update successor after branch relaxation in ARM.

This looks correct, but is there anything removing DestBB from the newly created block's successors if necessary?

Oct 17 2017, 1:33 AM

Oct 12 2017

rovka committed rL315579: MachineInstr: Make isEqual agree with getHashValue in….
MachineInstr: Make isEqual agree with getHashValue in…
Oct 12 2017, 7:00 AM
rovka closed D38789: MachineInstr: Make isEqual agree with getHashValue in MachineInstrExpressionTrait by committing rL315579: MachineInstr: Make isEqual agree with getHashValue in….
Oct 12 2017, 7:00 AM
rovka updated the diff for D38789: MachineInstr: Make isEqual agree with getHashValue in MachineInstrExpressionTrait.

Add unit tests and update summary before commit.

Oct 12 2017, 6:49 AM

Oct 11 2017

rovka updated the diff for D38789: MachineInstr: Make isEqual agree with getHashValue in MachineInstrExpressionTrait.

Update to take into account isDef only when ignoring virtual defs, since this is what the getHashValue function assumes.
First of all, this changes from using isPhysicalRegister to using !isVirtualRegisters, which also includes the sentinel values that we're interested in.
Secondly, it changes from checking MO.getReg to checking MO.isIdenticalTo, which takes into account MO.getReg, MO.getSubReg and MO.isDef. These are the same things that the hash function combines when getting the hashes.

Oct 11 2017, 9:11 AM
rovka added a comment to D38789: MachineInstr: Make isEqual agree with getHashValue in MachineInstrExpressionTrait.

Here's a comment from include/llvm/CodeGen/MachineInstr.h (definition of MachineInstrExpressionTrait)

/// Special DenseMapInfo traits to compare MachineInstr* by *value* of the
/// instruction rather than by pointer value.
/// The hashing and equality testing functions ignore definitions so this is
/// useful for CSE, etc.

The isEqual function explicitly requests IgnoreVRegDefs, supposedly on the basis that getHashValue would do the same. Your observation is that this is not the case. Assuming that this comment was true at some point, it may be worthwhile to check how the deviation was introduced.

Oct 11 2017, 7:48 AM
rovka added a comment to D38789: MachineInstr: Make isEqual agree with getHashValue in MachineInstrExpressionTrait.

This is a latent issue that triggers on one of the buildbots if the planets align. I'm holding one of Sanjay's InstCombine patches (r314698) hostage because of this bug, so please have a look. Thanks!

Oct 11 2017, 2:24 AM
rovka created D38789: MachineInstr: Make isEqual agree with getHashValue in MachineInstrExpressionTrait.
Oct 11 2017, 2:22 AM

Oct 6 2017

rovka added a comment to D37640: [GISel]: Fix generation of illegal COPYs (of different sizes) during CallLowering .

Hi Aditya,

Oct 6 2017, 11:06 AM
rovka committed rL315083: [ARM] GlobalISel: Make tests less strict.
[ARM] GlobalISel: Make tests less strict
Oct 6 2017, 10:49 AM
rovka committed rL315071: [ARM] GlobalISel: Select shifts.
[ARM] GlobalISel: Select shifts
Oct 6 2017, 8:41 AM
rovka committed rL315067: [ARM] GlobalISel: Map shift operands to GPRs.
[ARM] GlobalISel: Map shift operands to GPRs
Oct 6 2017, 7:54 AM
rovka committed rL315064: [ARM] GlobalISel: Mark shifts as legal for s32.
[ARM] GlobalISel: Mark shifts as legal for s32
Oct 6 2017, 7:31 AM

Oct 3 2017

rovka added a comment to D37640: [GISel]: Fix generation of illegal COPYs (of different sizes) during CallLowering .

Could someone familiar with ARM codebase implement that?

Oct 3 2017, 3:34 AM

Sep 6 2017

rovka committed rL312647: [zorg] Remove clang-cmake-aarch64-42vma builder.
[zorg] Remove clang-cmake-aarch64-42vma builder
Sep 6 2017, 9:35 AM
rovka closed D37459: [buildbot] Remove clang-cmake-aarch64-42vma builder by committing rL312647: [zorg] Remove clang-cmake-aarch64-42vma builder.
Sep 6 2017, 9:35 AM

Sep 5 2017

rovka committed rL312522: [ARM] GlobalISel: Minor cleanups in inst selector.
[ARM] GlobalISel: Minor cleanups in inst selector
Sep 5 2017, 1:24 AM
rovka committed rL312521: [ARM] GlobalISel: Support global variables for RWPI.
[ARM] GlobalISel: Support global variables for RWPI
Sep 5 2017, 12:59 AM