Page MenuHomePhabricator

rovka (Diana Picus)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2016, 3:27 AM (148 w, 2 d)

Recent Activity

Yesterday

rovka committed rG35e1c6663c37: [ARM GlobalISel] Support floating point for Thumb2 (authored by rovka).
[ARM GlobalISel] Support floating point for Thumb2
Fri, Feb 22, 1:55 AM
rovka committed rL354665: [ARM GlobalISel] Support floating point for Thumb2.
[ARM GlobalISel] Support floating point for Thumb2
Fri, Feb 22, 1:54 AM

Thu, Feb 21

rovka accepted D58351: ARM: Add ImmArg to intrinsics.

Ok, thanks!

Thu, Feb 21, 6:17 AM
rovka committed rGdcaa939ab75e: [ARM GlobalISel] Support G_FRAME_INDEX for Thumb2 (authored by rovka).
[ARM GlobalISel] Support G_FRAME_INDEX for Thumb2
Thu, Feb 21, 5:00 AM
rovka committed rL354579: [ARM GlobalISel] Support G_FRAME_INDEX for Thumb2.
[ARM GlobalISel] Support G_FRAME_INDEX for Thumb2
Thu, Feb 21, 4:59 AM

Wed, Feb 20

rovka added a comment to D58351: ARM: Add ImmArg to intrinsics.

Can you explain why this is relevant only for GCC builtins that don't require mangling? Otherwise LGTM.

Wed, Feb 20, 2:24 AM

Tue, Feb 19

rovka committed rG55d41a78ac45: Fix obsolete comment. NFC (authored by rovka).
Fix obsolete comment. NFC
Tue, Feb 19, 3:35 AM
rovka committed rL354316: Fix obsolete comment. NFC.
Fix obsolete comment. NFC
Tue, Feb 19, 3:35 AM
rovka committed rG19dbc6245fd9: [ARM GlobalISel] Support G_PHI for Thumb2 (authored by rovka).
[ARM GlobalISel] Support G_PHI for Thumb2
Tue, Feb 19, 2:27 AM
rovka committed rL354310: [ARM GlobalISel] Support G_PHI for Thumb2.
[ARM GlobalISel] Support G_PHI for Thumb2
Tue, Feb 19, 2:27 AM

Fri, Feb 15

rovka committed rGc0f964eb2f19: [ARM GlobalISel] Style fix. NFCI (authored by rovka).
[ARM GlobalISel] Style fix. NFCI
Fri, Feb 15, 2:54 AM
rovka committed rL354115: [ARM GlobalISel] Style fix. NFCI.
[ARM GlobalISel] Style fix. NFCI
Fri, Feb 15, 2:54 AM
rovka committed rGa00425ff0d04: [ARM GlobalISel] Support branches for Thumb2 (authored by rovka).
[ARM GlobalISel] Support branches for Thumb2
Fri, Feb 15, 2:24 AM
rovka committed rL354113: [ARM GlobalISel] Support branches for Thumb2.
[ARM GlobalISel] Support branches for Thumb2
Fri, Feb 15, 2:23 AM

Wed, Feb 13

rovka added a comment to D58171: Fix thread sanitizer on aarch64.

Looks good to me.

How do we submit this now? Perhaps we need to squash the main fibers patch, check_analyze patch and this into one.

Wed, Feb 13, 4:52 AM · Restricted Project, Restricted Project
rovka added a comment to D58171: Fix thread sanitizer on aarch64.

This seems to solve the problem on AArch64. I'll let the others approve if it's the right fix from a compiler-rt perspective.

Wed, Feb 13, 4:18 AM · Restricted Project, Restricted Project
rovka added a comment to D58171: Fix thread sanitizer on aarch64.

Testing in progress, I'll let you know how it went. Thanks for the quick fix!

Wed, Feb 13, 4:06 AM · Restricted Project, Restricted Project
rovka committed rGd3f13f160899: Revert "tsan: update check_analyze.sh" (authored by rovka).
Revert "tsan: update check_analyze.sh"
Wed, Feb 13, 4:06 AM
rovka committed rL353942: Revert "tsan: update check_analyze.sh".
Revert "tsan: update check_analyze.sh"
Wed, Feb 13, 4:06 AM
rovka committed rCRT353942: Revert "tsan: update check_analyze.sh".
Revert "tsan: update check_analyze.sh"
Wed, Feb 13, 4:05 AM
rovka committed rG4152a09e5537: Revert "tsan: add fiber support" (authored by rovka).
Revert "tsan: add fiber support"
Wed, Feb 13, 3:33 AM
rovka committed rCRT353939: Revert "tsan: add fiber support".
Revert "tsan: add fiber support"
Wed, Feb 13, 3:32 AM
rovka committed rL353939: Revert "tsan: add fiber support".
Revert "tsan: add fiber support"
Wed, Feb 13, 3:32 AM
rovka committed rGaa4118a8738e: [ARM GlobalISel] Support G_SELECT for Thumb2 (authored by rovka).
[ARM GlobalISel] Support G_SELECT for Thumb2
Wed, Feb 13, 3:26 AM
rovka committed rL353938: [ARM GlobalISel] Support G_SELECT for Thumb2.
[ARM GlobalISel] Support G_SELECT for Thumb2
Wed, Feb 13, 3:26 AM
rovka added a comment to D54889: Fiber support for thread sanitizer.

Hi Yuri,

Wed, Feb 13, 3:26 AM · Restricted Project, Restricted Project

Mon, Feb 11

rovka edited reviewers for D58031: [ARM GlobalISel] Make arm_i32imm an IntImmLeaf, added: eli.friedman; removed: eliben.
Mon, Feb 11, 2:59 AM · Restricted Project
rovka created D58031: [ARM GlobalISel] Make arm_i32imm an IntImmLeaf.
Mon, Feb 11, 2:58 AM · Restricted Project
rovka closed D57941: test-release.sh: Add option to use ninja.

Thanks! r353685

Mon, Feb 11, 2:31 AM · Restricted Project
rovka committed rG2d29cc311be9: test-release.sh: Add option to use ninja (authored by rovka).
test-release.sh: Add option to use ninja
Mon, Feb 11, 2:30 AM
rovka committed rL353685: test-release.sh: Add option to use ninja.
test-release.sh: Add option to use ninja
Mon, Feb 11, 2:30 AM

Fri, Feb 8

rovka added inline comments to D57812: [ARM] Add OptMinSize Subtarget feature.
Fri, Feb 8, 2:34 AM · Restricted Project
rovka created D57941: test-release.sh: Add option to use ninja.
Fri, Feb 8, 1:47 AM · Restricted Project

Thu, Feb 7

rovka committed rG75a04e2a77e1: [ARM GlobalISel] Support G_ICMP for Thumb2 (authored by rovka).
[ARM GlobalISel] Support G_ICMP for Thumb2
Thu, Feb 7, 3:06 AM
rovka committed rL353392: [ARM GlobalISel] Support G_ICMP for Thumb2.
[ARM GlobalISel] Support G_ICMP for Thumb2
Thu, Feb 7, 3:05 AM

Tue, Feb 5

rovka committed rGe24b104a112b: [ARM GlobalISel] Support G_GEP for Thumb2 (authored by rovka).
[ARM GlobalISel] Support G_GEP for Thumb2
Tue, Feb 5, 2:22 AM
rovka committed rL353151: [ARM GlobalISel] Support G_GEP for Thumb2.
[ARM GlobalISel] Support G_GEP for Thumb2
Tue, Feb 5, 2:21 AM

Mon, Jan 28

rovka committed rL352346: [ARM GlobalISel] Support integer division for Thumb2.
[ARM GlobalISel] Support integer division for Thumb2
Mon, Jan 28, 2:37 AM

Fri, Jan 25

rovka committed rL352188: [ARM GlobalISel] Support shifts for Thumb2.
[ARM GlobalISel] Support shifts for Thumb2
Fri, Jan 25, 2:49 AM
rovka committed rL352187: [ARM GlobalISel] Remove rebase artifact from r351882. NFC.
[ARM GlobalISel] Remove rebase artifact from r351882. NFC
Fri, Jan 25, 2:49 AM

Jan 17 2019

rovka committed rL351425: Fix capitalization. NFC.
Fix capitalization. NFC
Jan 17 2019, 2:18 AM
rovka committed rL351424: [ARM GlobalISel] Allow calls to varargs functions.
[ARM GlobalISel] Allow calls to varargs functions
Jan 17 2019, 2:17 AM

Jan 14 2019

rovka committed rL351056: [ARM GlobalISel] Import MOVi32imm into GlobalISel.
[ARM GlobalISel] Import MOVi32imm into GlobalISel
Jan 14 2019, 4:07 AM
rovka committed rCRT351040: [asan] Add fallback for Thumb after r350139.
[asan] Add fallback for Thumb after r350139
Jan 14 2019, 1:52 AM
rovka committed rL351040: [asan] Add fallback for Thumb after r350139.
[asan] Add fallback for Thumb after r350139
Jan 14 2019, 1:49 AM
rovka closed D56594: [asan] Add fallback for Thumb after r350139.
Jan 14 2019, 1:49 AM
rovka added a comment to D56594: [asan] Add fallback for Thumb after r350139.

Thanks for the review, I'll commit with your suggestions in place.

Jan 14 2019, 1:47 AM

Jan 11 2019

rovka created D56594: [asan] Add fallback for Thumb after r350139.
Jan 11 2019, 4:52 AM

Jan 10 2019

rovka committed rL350806: [asan] Mark tests as UNSUPPORTED on arm.
[asan] Mark tests as UNSUPPORTED on arm
Jan 10 2019, 1:44 AM
rovka committed rCRT350806: [asan] Mark tests as UNSUPPORTED on arm.
[asan] Mark tests as UNSUPPORTED on arm
Jan 10 2019, 1:44 AM

Dec 19 2018

rovka committed rL349610: [ARM GlobalISel] Support G_CONSTANT for Thumb2.
[ARM GlobalISel] Support G_CONSTANT for Thumb2
Dec 19 2018, 1:58 AM

Dec 14 2018

rovka committed rL349147: [ARM GlobalISel] Thumb2: casts between int and ptr.
[ARM GlobalISel] Thumb2: casts between int and ptr
Dec 14 2018, 5:49 AM
rovka committed rL349146: [ARM GlobalISel] Remove duplicate test. NFCI.
[ARM GlobalISel] Remove duplicate test. NFCI
Dec 14 2018, 5:31 AM
rovka committed rL349143: [ARM GlobalISel] Minor refactoring. NFCI.
[ARM GlobalISel] Minor refactoring. NFCI
Dec 14 2018, 4:40 AM
rovka committed rL349142: [ARM GlobalISel] Allow simple binary ops in Thumb2.
[ARM GlobalISel] Allow simple binary ops in Thumb2
Dec 14 2018, 4:01 AM

Dec 13 2018

rovka committed rL349026: [ARM GlobalISel] Support exts and truncs for Thumb2.
[ARM GlobalISel] Support exts and truncs for Thumb2
Dec 13 2018, 4:10 AM

Dec 12 2018

rovka committed rL348920: [ARM GlobalISel] Select load/store for Thumb2.
[ARM GlobalISel] Select load/store for Thumb2
Dec 12 2018, 2:35 AM

Dec 6 2018

rovka committed rL348472: [ARM GlobalISel] Nothing is legal for Thumb.
[ARM GlobalISel] Nothing is legal for Thumb
Dec 6 2018, 1:31 AM
rovka committed rL348466: Fixup r348306: Require x86 for test.
Fixup r348306: Require x86 for test
Dec 6 2018, 12:57 AM
rovka committed rLLD348466: Fixup r348306: Require x86 for test.
Fixup r348306: Require x86 for test
Dec 6 2018, 12:57 AM

Dec 5 2018

rovka committed rL348347: [ARM GlobalISel] Implement call lowering for Thumb2.
[ARM GlobalISel] Implement call lowering for Thumb2
Dec 5 2018, 2:38 AM

Nov 26 2018

rovka committed rL347545: [ARM GlobalISel] Support G_CTLZ and G_CTLZ_ZERO_UNDEF.
[ARM GlobalISel] Support G_CTLZ and G_CTLZ_ZERO_UNDEF
Nov 26 2018, 3:10 AM
rovka committed rL347544: Fix typo in comment. NFC.
Fix typo in comment. NFC
Nov 26 2018, 3:10 AM

Nov 22 2018

rovka committed rL347447: [ARM GlobalISel] Add test for BFC. NFCI.
[ARM GlobalISel] Add test for BFC. NFCI
Nov 22 2018, 1:57 AM

Nov 14 2018

rovka committed rLLD346842: Fix r346747 and r346796.
Fix r346747 and r346796
Nov 14 2018, 2:02 AM
rovka committed rL346842: Fix r346747 and r346796.
Fix r346747 and r346796
Nov 14 2018, 2:00 AM

Feb 15 2018

rovka abandoned D40074: [GISel] Canonicalize constants to RHS for commutative operations.

This doesn't seem to be what we want to do in the long run.

Feb 15 2018, 4:24 AM

Feb 14 2018

rovka accepted D43195: [CMake] Add -fno-experimental-isel for testing.

Seems to pass now.

Feb 14 2018, 9:09 PM

Feb 13 2018

rovka added a comment to D43195: [CMake] Add -fno-experimental-isel for testing.

I'm not familiar enough with the CMake infrastructure to know if this does the trick for the openmp tests, but as I said on the bug report, I'm ok with this general direction.

Feb 13 2018, 6:36 AM
rovka added inline comments to D43119: [zorg] Add AArch32 global-isel bots.
Feb 13 2018, 5:58 AM

Feb 12 2018

rovka added inline comments to D43090: GlobalISel: IRTranslate llvm.fmuladd.* intrinsic.
Feb 12 2018, 1:36 AM
rovka added inline comments to D43119: [zorg] Add AArch32 global-isel bots.
Feb 12 2018, 1:19 AM

Feb 9 2018

rovka added inline comments to D43119: [zorg] Add AArch32 global-isel bots.
Feb 9 2018, 7:02 AM
rovka added inline comments to D43117: [zorg] Cleanup unnecessary options for ARM and AArch64 bots.
Feb 9 2018, 6:51 AM

Jan 31 2018

rovka committed rL323878: Fix formatting for r323876. NFC.
Fix formatting for r323876. NFC
Jan 31 2018, 7:18 AM
rovka added a comment to D42251: [globalisel][legalizer] Adapt LegalizerInfo to support inter-type dependencies and other things..

I've been playing a bit with this for ARM (r323876) and it's been pretty straightforward to update. I have a few observations that I thought I could share, but feel free to ignore them depending on how you intend to evolve this in the future.

Jan 31 2018, 7:14 AM
rovka committed rL323876: [ARM GlobalISel] Modernize LegalizerInfo. NFCI.
[ARM GlobalISel] Modernize LegalizerInfo. NFCI
Jan 31 2018, 6:57 AM

Jan 30 2018

rovka committed rL323732: [ARM GlobalISel] Add inst selector tests for G_SITOFP and G_UITOFP.
[ARM GlobalISel] Add inst selector tests for G_SITOFP and G_UITOFP
Jan 30 2018, 1:17 AM
rovka committed rL323731: [ARM GlobalISel] Map G_SITOFP and G_UITOFP.
[ARM GlobalISel] Map G_SITOFP and G_UITOFP
Jan 30 2018, 1:17 AM
rovka committed rL323730: [ARM GlobalISel] Legalize G_SITOFP and G_UITOFP.
[ARM GlobalISel] Legalize G_SITOFP and G_UITOFP
Jan 30 2018, 1:17 AM

Jan 29 2018

rovka committed rL323728: [ARM GlobalISel] Add inst selector tests for G_FPTOSI and G_FPTOUI.
[ARM GlobalISel] Add inst selector tests for G_FPTOSI and G_FPTOUI
Jan 29 2018, 11:58 PM
rovka committed rL323727: [ARM GlobalISel] Map G_FPTOSI and G_FPTOUI.
[ARM GlobalISel] Map G_FPTOSI and G_FPTOUI
Jan 29 2018, 11:58 PM
rovka committed rL323726: [ARM GlobalISel] Legalize G_FPTOSI and G_FPTOUI.
[ARM GlobalISel] Legalize G_FPTOSI and G_FPTOUI
Jan 29 2018, 11:58 PM

Jan 26 2018

rovka accepted D42565: [ARM][GISel] PR35965 Constrain RegClasses of nested instructions built from Dst Pattern.

LGTM, thanks!

Jan 26 2018, 3:31 AM

Jan 23 2018

rovka accepted D42040: [PATCH 5/6] [zorg] Add linaro-armv8-01-arm-* slaves.

Ok, LGTM.

Jan 23 2018, 4:46 AM

Jan 18 2018

rovka added inline comments to D42244: [globalisel] Introduce LegalityQuery to better encapsulate the legalizer decisions. NFC..
Jan 18 2018, 1:11 PM

Jan 17 2018

rovka committed rL322667: [ARM GlobalISel] Rename local variable. NFC.
[ARM GlobalISel] Rename local variable. NFC
Jan 17 2018, 7:27 AM
rovka committed rL322665: [ARM GlobalISel] Add instselect tests for G_FPEXT and G_FPTRUNC.
[ARM GlobalISel] Add instselect tests for G_FPEXT and G_FPTRUNC
Jan 17 2018, 7:02 AM
rovka committed rL322657: [ARM GlobalISel] Map G_FPEXT and G_FPTRUNC to FPR.
[ARM GlobalISel] Map G_FPEXT and G_FPTRUNC to FPR
Jan 17 2018, 6:15 AM
rovka committed rL322651: [ARM GlobalISel] Legalize G_FPEXT and G_FPTRUNC.
[ARM GlobalISel] Legalize G_FPEXT and G_FPTRUNC
Jan 17 2018, 5:35 AM

Jan 15 2018

rovka accepted D42041: [PATCH 6/6] [zorg] Don't use -DCMAKE_C_COMPILER*/-DCMAKE_CXX_COMPILER*.

LGTM.

Jan 15 2018, 6:10 AM
rovka added inline comments to D42040: [PATCH 5/6] [zorg] Add linaro-armv8-01-arm-* slaves.
Jan 15 2018, 5:50 AM
rovka accepted D42039: [PATCH 4/6] [zorg] Rename linaro-d05-01-* slaves to linaro-armv8-01-*.

LGTM, but I think you should commit the BOTO change separately.

Jan 15 2018, 5:37 AM
rovka accepted D42038: [PATCH 3/6] [zorg] Remove clang-cmake-thumbv7-a15 bot.

LGTM.

Jan 15 2018, 5:21 AM
rovka accepted D42037: [PATCH 2/6] [zorg] Use slave's "jobs" setting for ARM 32-bit bots..

LGTM, but I have a couple of nitpicks:

  • Why is this PATCH 2/6? It doesn't seem related to either 1/6 or 3/6 and can be committed independently
  • The summary just repeats the title. A better summary would be something along the lines of "Don't force the number of jobs on the ARM builders. This makes it possible to fall back on the number of jobs configured for the slave instead."
Jan 15 2018, 5:20 AM

Jan 12 2018

rovka committed rL322368: [ARM GlobalISel] Add inst selector tests for G_FMA.
[ARM GlobalISel] Add inst selector tests for G_FMA
Jan 12 2018, 4:45 AM
rovka committed rL322367: [ARM GlobalISel] Map G_FMA to FPR.
[ARM GlobalISel] Map G_FMA to FPR
Jan 12 2018, 4:07 AM
rovka committed rL322366: [ARM GlobalISel] Legalize G_FMA.
[ARM GlobalISel] Legalize G_FMA
Jan 12 2018, 3:32 AM

Jan 10 2018

rovka committed rL322170: [ARM GlobalISel] Add inst selector tests for G_FNEG s32 and s64.
[ARM GlobalISel] Add inst selector tests for G_FNEG s32 and s64
Jan 10 2018, 3:14 AM
rovka committed rL322169: [ARM GlobalISel] Map G_FNEG to the FPR bank.
[ARM GlobalISel] Map G_FNEG to the FPR bank
Jan 10 2018, 3:14 AM