Page MenuHomePhabricator

rovka (Diana Picus)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2016, 3:27 AM (269 w, 4 d)

Recent Activity

Today

rovka added a comment to D104150: [test-suite] NIST Fortran Compiler Validation Suite..

This passes now, thanks :)

Mon, Jun 21, 4:23 AM
rovka added a comment to D104019: [flang] Add initial implementation for CPU_TIME.

Hmm, that's probably better - if it never changes then we'll timeout eventually, right? I'll try to commit that today.

Correct. Change looks good, does not fail anymore.

Assuming that a look takes a minimum time to execute broke some famous program in the past. For instance, Windows 3.11, some old games, and every program compiled with Turbo Pascal.

But just for the record, are you sure that the loop is optimized away? Have you checked the assembly? I'm thinking there might be an issue with the resolution of the timer used on Windows - we might need a better implementation for it than the default (just like I added for POSIX systems).

It was just an assumption, I haven't checked the disassembly. Embedded (where volatile is important) is not really a domain for msvc so ignoring volatile looked like a reasonable explanation.

It would be nice if our test could flag when the resolution of the timer isn't good enough on a given implementation, for some definition of "good enough". Naturally, one can expect that the definition of "good enough" will change in the future, and our test can change with it. Ideally, the test would be representative of the amount of work that we expect to be able to time. OTOH I don't know if this test is the place for that, or if we should just add some microbenchmarks to the test-suite.

Here is the /Ox disassembly of LookBusy by msvc:

00007FF79D37F770  xor         eax,eax  
00007FF79D37F772  nop         dword ptr [rax]  
00007FF79D37F776  nop         word ptr [rax+rax]  
    x = i;
00007FF79D37F780  mov         dword ptr [x (07FF79DB49F50h)],eax  
00007FF79D37F786  inc         eax  
00007FF79D37F788  cmp         eax,100h  
00007FF79D37F78D  jl          LookBusy+10h (07FF79D37F780h)

That is, msvc actually did honor the volatile. The test actually also fails when compiling with gcc and running with WSL1 (Windows Subsystem for Linux), i.e. your clock resolution theory seems correct. Which makes the test platform-dependent.

IMHO a MicroBenchmark would be a better place (e.g. llvm-test-suite already has MicroBenchmarks, @naromero77 currently works on adding Fortran tests) than a regression test error. A too granular timer resolution could also mitigated by running the microbenchmark multiple times, as GoogleBenchmark does. If precision is important, std::chrono::high_resolution_clock would be the API to use, which maps to QueryPerformanceCounter on Windows.

Mon, Jun 21, 1:25 AM · Restricted Project, Restricted Project

Fri, Jun 18

rovka added a comment to D104150: [test-suite] NIST Fortran Compiler Validation Suite..

Is this expected to pass with current upstream flang?
I gave this a quick spin on an AArch64 machine similar to our buildbots (same hardware, not necessarily same ubuntu version, system compiler etc) and I'm seeing one failure in FM509:

/path/to/build/bin/flang -DNDEBUG  -w -Werror=date-time -c /path/to/llvm-test-suite/Fortran/UnitTests/fcvs21_f95/FM509.f -o CMakeFiles/FM509.dir/FM509.f.o
f18-c234.f90:237:12:

  237 |  CALL sn512(c1n001(5)(2:9), cvcomp)
      |            1
Error: Actual argument contains too few elements for dummy argument ‘c1d001’ (19/48) at (1)
execvp(gfortran) failed: 
flang: in /path/to/test-suite-sandbox/build/Fortran/UnitTests/fcvs21_f95, f18 failed with exit status 0: /path/to/build/bin/f18 -module-suffix .f18.mod -DNDEBUG -w -Werror=date-time -c /path/to/llvm-test-suite/Fortran/UnitTests/fcvs21_f95/FM509.f -o CMakeFiles/FM509.dir/FM509.f.o

I'm attaching the produced f18-c234.f90 in case anyone wants to have a look.

Sorry for the slow reply. I am on vacation this week and will return to a regular schedule next week. I had no failures with an GCC 7.5, but did have one failure with GCC 10.2 with this same test. Are you using the Flang throw away driver? If so, which GCC are you using.

Fri, Jun 18, 2:30 AM
rovka committed rG4498137bd785: [flang] Rewrite test for CPU_TIME (authored by rovka).
[flang] Rewrite test for CPU_TIME
Fri, Jun 18, 2:21 AM
rovka added a comment to D104019: [flang] Add initial implementation for CPU_TIME.

This fails with msvc which apparently optimized the loop away:

[ RUN      ] TimeIntrinsics.CpuTime
C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\flang\unittests\RuntimeGTest\Time.cpp(34): error: Expected: (end) > (start), actual: 2.000000e-03 vs 2.000000e-03
[  FAILED  ] TimeIntrinsics.CpuTime (1 ms)

I think assuming how long it takes to complete a volatile write is fragile.

Instead I suggest to test CpuTime by repeatedly calling it until it changes.

Hmm, that's probably better - if it never changes then we'll timeout eventually, right? I'll try to commit that today.

Fri, Jun 18, 1:15 AM · Restricted Project, Restricted Project
rovka added a comment to D104019: [flang] Add initial implementation for CPU_TIME.

Could you please address the build failure mentioned in https://reviews.llvm.org/rG57e85622bbdb2eb18cc03df2ea457019c58f6912#inline-6002:

Fri, Jun 18, 12:51 AM · Restricted Project, Restricted Project

Wed, Jun 16

rovka updated subscribers of D104290: [flang] Check there's no dependency on C++ libs.

Hi Andrzej,

Wed, Jun 16, 5:35 AM · Restricted Project, Restricted Project
rovka committed rG0ad051b5fc22: [flang] Check there's no dependency on C++ libs. NFC (authored by rovka).
[flang] Check there's no dependency on C++ libs. NFC
Wed, Jun 16, 4:40 AM
rovka added a reverting change for rG7ddbf2633911: [flang] Check there's no dependency on C++ libs: rGdfa0f3ee0ea1: Revert "[flang] Check there's no dependency on C++ libs".
Wed, Jun 16, 4:10 AM
rovka committed rGdfa0f3ee0ea1: Revert "[flang] Check there's no dependency on C++ libs" (authored by rovka).
Revert "[flang] Check there's no dependency on C++ libs"
Wed, Jun 16, 4:10 AM
rovka added a reverting change for D104290: [flang] Check there's no dependency on C++ libs: rGdfa0f3ee0ea1: Revert "[flang] Check there's no dependency on C++ libs".
Wed, Jun 16, 4:10 AM · Restricted Project, Restricted Project
rovka committed rG10ae933b0b1a: [flang] Fixup 7ddbf2633911a5c378ad6af01e250f6f252b9032 (authored by rovka).
[flang] Fixup 7ddbf2633911a5c378ad6af01e250f6f252b9032
Wed, Jun 16, 2:43 AM
rovka committed rG45cd405dc07b: [flang] Add clang-tidy check for braces around if (authored by rovka).
[flang] Add clang-tidy check for braces around if
Wed, Jun 16, 2:14 AM
rovka closed D104100: [flang] Add clang-tidy check for braces around if.
Wed, Jun 16, 2:14 AM · Restricted Project, Restricted Project
rovka added a comment to D104100: [flang] Add clang-tidy check for braces around if.

Could you also update https://github.com/llvm/llvm-project/blob/main/flang/docs/C%2B%2Bstyle.md#layout to reflect this change? Otherwise our documentation and clang-tidy scripts are out-of-sync. Thank you!

Wed, Jun 16, 2:00 AM · Restricted Project, Restricted Project
rovka committed rG7ddbf2633911: [flang] Check there's no dependency on C++ libs (authored by rovka).
[flang] Check there's no dependency on C++ libs
Wed, Jun 16, 1:24 AM
rovka closed D104290: [flang] Check there's no dependency on C++ libs.
Wed, Jun 16, 1:24 AM · Restricted Project, Restricted Project
rovka added a comment to D104290: [flang] Check there's no dependency on C++ libs.

I would like to have some automated check in the build that would catch an inadvertent binary dependency, but this scheme seems to admit false negative results when the linkage is static.

Wed, Jun 16, 1:02 AM · Restricted Project, Restricted Project

Tue, Jun 15

rovka requested review of D104290: [flang] Check there's no dependency on C++ libs.
Tue, Jun 15, 4:06 AM · Restricted Project, Restricted Project
rovka updated the diff for D104100: [flang] Add clang-tidy check for braces around if.
Tue, Jun 15, 1:32 AM · Restricted Project, Restricted Project
rovka added a comment to D104100: [flang] Add clang-tidy check for braces around if.

I disabled the check for Optimizer and Lower. With the newest version of the patch, I'm seeing several violations in lib/Semantics, tools (f18, f18-parse-demo, tco) and 2 rogue ones in the runtime. I'm going to fix the ones from the runtime, but I'm not sure about the others. What's the preferred style for lib/Semantics and tools?

I wouldn't worry about the tools; few if any of those will survive in the llvm tree. The semantics code uses the stricter style.

Tue, Jun 15, 1:30 AM · Restricted Project, Restricted Project
rovka added a comment to D104150: [test-suite] NIST Fortran Compiler Validation Suite..

Is this expected to pass with current upstream flang?
I gave this a quick spin on an AArch64 machine similar to our buildbots (same hardware, not necessarily same ubuntu version, system compiler etc) and I'm seeing one failure in FM509:

Tue, Jun 15, 12:37 AM

Mon, Jun 14

rovka added a reviewer for D104100: [flang] Add clang-tidy check for braces around if: jeanPerier.
Mon, Jun 14, 3:03 AM · Restricted Project, Restricted Project
rovka updated the diff for D104100: [flang] Add clang-tidy check for braces around if.

I disabled the check for Optimizer and Lower. With the newest version of the patch, I'm seeing several violations in lib/Semantics, tools (f18, f18-parse-demo, tco) and 2 rogue ones in the runtime. I'm going to fix the ones from the runtime, but I'm not sure about the others. What's the preferred style for lib/Semantics and tools?

Mon, Jun 14, 3:02 AM · Restricted Project, Restricted Project
rovka committed rG166192eb78cd: [flang] Add POSIX implementation for CPU_TIME (authored by rovka).
[flang] Add POSIX implementation for CPU_TIME
Mon, Jun 14, 2:42 AM
rovka closed D104020: [flang] Add POSIX implementation for CPU_TIME.
Mon, Jun 14, 2:42 AM · Restricted Project, Restricted Project
rovka added a comment to D104019: [flang] Add initial implementation for CPU_TIME.

Tested with this:

Mon, Jun 14, 1:11 AM · Restricted Project, Restricted Project
rovka added a comment to D104019: [flang] Add initial implementation for CPU_TIME.

Please ensure that this code does not make the Fortran runtime library binary dependent on a C++ runtime library. We're trying to restrict dependences to C to make things easier for vendors and application writers to ship binaries without having to also ship one or more C++ environments alongside them.

Mon, Jun 14, 12:59 AM · Restricted Project, Restricted Project
rovka committed rG57e85622bbdb: [flang] Add initial implementation for CPU_TIME (authored by rovka).
[flang] Add initial implementation for CPU_TIME
Mon, Jun 14, 12:52 AM
rovka closed D104019: [flang] Add initial implementation for CPU_TIME.
Mon, Jun 14, 12:52 AM · Restricted Project, Restricted Project
rovka added a comment to D104100: [flang] Add clang-tidy check for braces around if.

This should probably not be applied to all of f18; the lowering code, which interacts heavily with mlir and llvm, respects their styles.

Mon, Jun 14, 12:42 AM · Restricted Project, Restricted Project
rovka added inline comments to D104019: [flang] Add initial implementation for CPU_TIME.
Mon, Jun 14, 12:41 AM · Restricted Project, Restricted Project

Fri, Jun 11

rovka requested review of D104100: [flang] Add clang-tidy check for braces around if.
Fri, Jun 11, 2:15 AM · Restricted Project, Restricted Project
rovka added a comment to D104020: [flang] Add POSIX implementation for CPU_TIME.

Thanks for figuring this out.

Fri, Jun 11, 1:14 AM · Restricted Project, Restricted Project
rovka updated the diff for D104020: [flang] Add POSIX implementation for CPU_TIME.

Added braces around if. NFCI.

Fri, Jun 11, 1:13 AM · Restricted Project, Restricted Project
rovka updated the diff for D104019: [flang] Add initial implementation for CPU_TIME.

Added braces around if. NFCI.

Fri, Jun 11, 1:12 AM · Restricted Project, Restricted Project

Thu, Jun 10

rovka requested review of D104020: [flang] Add POSIX implementation for CPU_TIME.
Thu, Jun 10, 3:55 AM · Restricted Project, Restricted Project
rovka requested review of D104019: [flang] Add initial implementation for CPU_TIME.
Thu, Jun 10, 3:48 AM · Restricted Project, Restricted Project
rovka added a comment to D103957: [zorg] Rename Linaro's AArch64 and ARM bots to use consistent names.

I have a couple of minor comments, overall looks good.

Thu, Jun 10, 1:01 AM

Wed, Jun 9

rovka accepted D103470: [zorg] Add AArch64 SVE vector-length-specific (VLS) bot.

Seems ok, I just have one minor nit.

Wed, Jun 9, 5:35 AM
rovka accepted D103469: [zorg] Build all targets on Linaro-maintained bots.

LGTM

Wed, Jun 9, 5:30 AM
rovka accepted D103468: [zorg] Cleanup clang-cmake-{armv7,aarch64}-quick bots.

LGTM, thanks!

Wed, Jun 9, 5:28 AM
rovka committed rG35b0ddab0ee8: [flang] Define the API for CPU_TIME (authored by rovka).
[flang] Define the API for CPU_TIME
Wed, Jun 9, 1:33 AM
rovka closed D103805: [flang] Define the runtime API for CPU_TIME.
Wed, Jun 9, 1:33 AM · Restricted Project, Restricted Project

Tue, Jun 8

rovka updated the diff for D103805: [flang] Define the runtime API for CPU_TIME.

Addressed review comments.

Tue, Jun 8, 12:53 AM · Restricted Project, Restricted Project
rovka added inline comments to D103805: [flang] Define the runtime API for CPU_TIME.
Tue, Jun 8, 12:52 AM · Restricted Project, Restricted Project

Mon, Jun 7

rovka added inline comments to D103805: [flang] Define the runtime API for CPU_TIME.
Mon, Jun 7, 5:53 AM · Restricted Project, Restricted Project
rovka requested review of D103805: [flang] Define the runtime API for CPU_TIME.
Mon, Jun 7, 5:50 AM · Restricted Project, Restricted Project

Fri, Jun 4

rovka committed rG263a89c9b788: [flang] Change capitalization for Adjustl/r (authored by rovka).
[flang] Change capitalization for Adjustl/r
Fri, Jun 4, 1:35 AM
rovka closed D103392: [flang] Change capitalization for Adjustl/r.
Fri, Jun 4, 1:35 AM · Restricted Project, Restricted Project

Thu, Jun 3

rovka updated the diff for D103392: [flang] Change capitalization for Adjustl/r.

Right, I wasn't sure so I just picked the one that seemed to look more like the rest of the runtime :) Is there a convention somewhere, or is it just that once we committed something to the header we shouldn't change it? In any case, I updated the patch, hope it looks better now.

Thu, Jun 3, 12:55 AM · Restricted Project, Restricted Project

Wed, Jun 2

rovka committed rG5f25145306e7: [flang] Add tests for REPEAT. NFC (authored by rovka).
[flang] Add tests for REPEAT. NFC
Wed, Jun 2, 1:29 AM
rovka closed D103402: [flang] Add tests for REPEAT. NFC.
Wed, Jun 2, 1:29 AM · Restricted Project, Restricted Project

Mon, May 31

rovka requested review of D103402: [flang] Add tests for REPEAT. NFC.
Mon, May 31, 4:47 AM · Restricted Project, Restricted Project
rovka requested review of D103392: [flang] Change capitalization for Adjustl/r.
Mon, May 31, 2:45 AM · Restricted Project, Restricted Project

Tue, May 25

rovka closed D102319: [zorg] Remove flang-aarch64-ubuntu-out-of-tree-new-driver.
Tue, May 25, 1:24 AM · Restricted Project, Restricted Project
rovka committed rZORGde74f83353c3: [zorg] Remove flang-aarch64-ubuntu-out-of-tree-new-driver (authored by rovka).
[zorg] Remove flang-aarch64-ubuntu-out-of-tree-new-driver
Tue, May 25, 1:24 AM

May 21 2021

rovka accepted D102877: [flang][docs] Initial documentation for the Fortran LLVM Test Suite..

Thanks for writing this! I left a lot of comments, but most of them are just typos / nitpicks, otherwise it looks good :)

May 21 2021, 1:25 AM · Restricted Project

May 17 2021

rovka committed rZORG1062df17752f: Remove -DFLANG_BUILD_NEW_DRIVER=ON from builders. NFCI (authored by rovka).
Remove -DFLANG_BUILD_NEW_DRIVER=ON from builders. NFCI
May 17 2021, 12:51 AM
rovka closed D102320: [zorg] Remove -DFLANG_BUILD_NEW_DRIVER=ON from builders. NFCI.
May 17 2021, 12:51 AM · Restricted Project, Restricted Project
rovka accepted D102323: [flang][cmake] Set the default for FLANG_BUILD_NEW_DRIVER for oot builds.

Makes sense, thanks!

May 17 2021, 12:38 AM · Restricted Project, Restricted Project

May 12 2021

rovka requested review of D102320: [zorg] Remove -DFLANG_BUILD_NEW_DRIVER=ON from builders. NFCI.
May 12 2021, 1:54 AM · Restricted Project, Restricted Project
rovka requested review of D102319: [zorg] Remove flang-aarch64-ubuntu-out-of-tree-new-driver.
May 12 2021, 1:52 AM · Restricted Project, Restricted Project

May 7 2021

rovka committed rG2ea36e94927c: [flang] Remove redundant reallocation (authored by rovka).
[flang] Remove redundant reallocation
May 7 2021, 1:54 AM
rovka committed rG778487a22149: [flang] Add tests for MIN for character arrays. NFC (authored by rovka).
[flang] Add tests for MIN for character arrays. NFC
May 7 2021, 1:54 AM
rovka closed D101984: [flang] Remove redundant reallocation.
May 7 2021, 1:54 AM · Restricted Project, Restricted Project
rovka closed D101983: [flang] Add tests for MIN for character arrays.
May 7 2021, 1:54 AM · Restricted Project, Restricted Project
rovka added a comment to D101983: [flang] Add tests for MIN for character arrays.

Thanks so much for the additional test cases! Do they already pass?

May 7 2021, 1:36 AM · Restricted Project, Restricted Project

May 6 2021

rovka added a comment to D101983: [flang] Add tests for MIN for character arrays.

This is NFC, I forgot to mention. I'll update the title before committing...

May 6 2021, 2:53 AM · Restricted Project, Restricted Project
rovka requested review of D101984: [flang] Remove redundant reallocation.
May 6 2021, 2:46 AM · Restricted Project, Restricted Project
rovka requested review of D101983: [flang] Add tests for MIN for character arrays.
May 6 2021, 2:44 AM · Restricted Project, Restricted Project

May 3 2021

rovka committed rG5112bd6b6e10: [flang] Fix a bug in the character runtime (authored by rovka).
[flang] Fix a bug in the character runtime
May 3 2021, 1:18 AM
rovka committed rGaaab70407beb: [flang] Fix handling of elem_len in CFI_establish (authored by rovka).
[flang] Fix handling of elem_len in CFI_establish
May 3 2021, 1:17 AM
rovka committed rG32f901bdf9b5: [flang] Use CFI_TYPE_LAST instead of CFI_type_struct (authored by rovka).
[flang] Use CFI_TYPE_LAST instead of CFI_type_struct
May 3 2021, 1:17 AM
rovka closed D101355: Fix a bug in the character runtime.
May 3 2021, 1:17 AM · Restricted Project
rovka closed D101659: [flang] Fix handling of elem_len in CFI_establish.
May 3 2021, 1:17 AM · Restricted Project, Restricted Project
rovka closed D101658: [flang] Use CFI_TYPE_LAST instead of CFI_type_struct.
May 3 2021, 1:17 AM · Restricted Project, Restricted Project

Apr 30 2021

rovka updated the diff for D101355: Fix a bug in the character runtime.
  • Enabled the tests for all character types (and added dependencies for the fixes that made that possible)
  • Simplified test expectation (no need to dump raw pointer values)
Apr 30 2021, 12:36 PM · Restricted Project
rovka requested review of D101659: [flang] Fix handling of elem_len in CFI_establish.
Apr 30 2021, 12:33 PM · Restricted Project, Restricted Project
rovka requested review of D101658: [flang] Use CFI_TYPE_LAST instead of CFI_type_struct.
Apr 30 2021, 12:21 PM · Restricted Project, Restricted Project

Apr 28 2021

rovka added inline comments to D100261: [lldb] [gdb-remote server] Support selecting process via Hg.
Apr 28 2021, 2:54 AM
rovka added a comment to D100459: [lldb] [gdb-remote client] Refactor SetCurrentThread*().

This looks good to me, but I'll let others comment on whether or not we want to send extra leading zeroes for the thread ID. In my opinion it would be nice to 1) be consistent between all packages that deal with thread ids, and 2) send as little clutter as possible. But these are just theoretical concerns, I'm not sure if it matters in practice.

Apr 28 2021, 2:14 AM
rovka added a comment to D101153: [lldb][NFC] Specify guidelines for API tests.

This is awesome, thanks for writing this up!

Apr 28 2021, 1:25 AM · Restricted Project
rovka committed rGa58f362fb5dd: [flang] Remove interfaces for Character[Min|Max][Val|Loc]. NFC (authored by rovka).
[flang] Remove interfaces for Character[Min|Max][Val|Loc]. NFC
Apr 28 2021, 12:58 AM
rovka closed D101354: Remove unimplemented interfaces for Character[Min|Max][Val|Loc]. NFC.
Apr 28 2021, 12:58 AM · Restricted Project

Apr 27 2021

rovka requested review of D101355: Fix a bug in the character runtime.
Apr 27 2021, 4:31 AM · Restricted Project
rovka requested review of D101354: Remove unimplemented interfaces for Character[Min|Max][Val|Loc]. NFC.
Apr 27 2021, 4:28 AM · Restricted Project

Apr 12 2021

rovka accepted D100146: [lldb] [gdb-remote client] Refactor handling qSupported.

LGTM

Apr 12 2021, 4:50 AM · Restricted Project
rovka added inline comments to D100140: [lldb] [gdb-remote server] Refactor handling qSupported.
Apr 12 2021, 4:41 AM · Restricted Project

Mar 23 2021

rovka accepted D99088: [flang][cmake] Improve how CLANG_DIR is handled.

LGTM

Mar 23 2021, 4:58 AM · Restricted Project, Restricted Project

Mar 22 2021

rovka added a comment to D98787: Add Clang dependency for new Flang driver in out-of-tree builder..

I think the issue might be here: https://github.com/llvm/llvm-project/blob/7515e81e8c58ca07ac5fede7149634c0dfacae8a/flang/CMakeLists.txt#L52
We seem to be using CLANG_DIR directly, but for LLVM_DIR and MLIR_DIR we build absolute paths if needed.
@awarzynski, does this sound correct to you?

Mar 22 2021, 4:13 AM

Mar 18 2021

rovka added a comment to D98787: Add Clang dependency for new Flang driver in out-of-tree builder..

This seems fine to me, but maybe @awarzynski can also have a look, since he knows the details of the new driver build better :)

Mar 18 2021, 2:18 AM

Mar 17 2021

rovka accepted D98768: Fix flang out-of-tree with new driver builder..

LGTM, thanks!

Mar 17 2021, 3:10 AM

Mar 5 2021

rovka added a comment to D96458: [LLDB] Add support for Arm64/Linux dynamic register sets.

Hi Omair,

Mar 5 2021, 4:25 AM · Restricted Project

Feb 9 2021

rovka accepted D96006: [AArch64] Stack probing for dynamic allocas in GlobalISel.

LGTM as far as GlobalISel is concerned.

Feb 9 2021, 4:40 AM · Restricted Project

Feb 5 2021

rovka added a comment to D96006: [AArch64] Stack probing for dynamic allocas in GlobalISel.

Seems fine from a GlobalISel perspective, and I'm guessing the stack clashing details will be reviewed in the SelectionDAG patch which adds the test.

Feb 5 2021, 3:41 AM · Restricted Project
rovka added a comment to D96006: [AArch64] Stack probing for dynamic allocas in GlobalISel.

Can you please upload with context? :) Thanks!

Feb 5 2021, 1:29 AM · Restricted Project

Jan 28 2021

rovka accepted D95604: Explicitly use python3 for lit sandbox.

LGTM.

Jan 28 2021, 3:08 AM

Jan 26 2021

rovka committed rZORGe2f431ab9994: ClangBuilder: Enable fortran in test-suite (authored by rovka).
ClangBuilder: Enable fortran in test-suite
Jan 26 2021, 1:54 AM
rovka closed D94945: ClangBuilder: Enable fortran in test-suite.
Jan 26 2021, 1:54 AM