rovka (Diana Picus)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2016, 3:27 AM (65 w, 4 d)

Recent Activity

Thu, Jul 20

rovka committed rL308603: Revert "GlobalISel: select G_EXTRACT and G_INSERT instructions on AArch64.".
Revert "GlobalISel: select G_EXTRACT and G_INSERT instructions on AArch64."
Thu, Jul 20, 4:36 AM

Wed, Jul 19

rovka accepted D35117: [globalisel][tablegen] Add control-flow to the MatchTable..

LGTM with minor nits.

Wed, Jul 19, 3:04 AM

Tue, Jul 18

rovka committed rL308285: [ARM] GlobalISel: Support G_(S|U)REM for s8 and s16.
[ARM] GlobalISel: Support G_(S|U)REM for s8 and s16
Tue, Jul 18, 3:07 AM
rovka committed rL308278: GlobalISel: Support G_(S|U)REM widening in LegalizerHelper.
GlobalISel: Support G_(S|U)REM widening in LegalizerHelper
Tue, Jul 18, 2:09 AM

Mon, Jul 17

rovka added a comment to D35117: [globalisel][tablegen] Add control-flow to the MatchTable..

I think the commit message should elaborate a bit on why we want a single table.
Other nits:

Mon, Jul 17, 4:46 AM
rovka committed rL308165: Set higher timeouts for Misc-C++ on AArch64.
Set higher timeouts for Misc-C++ on AArch64
Mon, Jul 17, 2:04 AM
rovka accepted D35419: [CodeGen] Add begin-end iterators to MachineInstr.

LGTM.

Mon, Jul 17, 1:30 AM

Fri, Jul 14

rovka added a reviewer for D35419: [CodeGen] Add begin-end iterators to MachineInstr: echristo.
Fri, Jul 14, 9:26 AM
rovka accepted D35130: [globalisel][tablegen] Enable the import of rules involving fma..

Looks pretty trivial.

Fri, Jul 14, 9:07 AM
rovka accepted D35402: [zorg] Enable running 'lnt runtest test-suite' instead of 'lnt runtest nt'..

Hi, I tested this on our internal buildmaster and it seems to work. LGTM.

Fri, Jul 14, 7:47 AM
rovka added a comment to D34875: ARM: Report error for invalid use of AAPCS_VFP calling convention.

Hi, you could try looking into LLVMContext::emitError - it shouldn't be too hard to get hold of an LLVMContext, and that's what we use to report e.g. errors in inline asm in SelectionDAGBuilder.

Fri, Jul 14, 5:13 AM
rovka committed rL308009: [ARM] GlobalISel: Support G_BRCOND.
[ARM] GlobalISel: Support G_BRCOND
Fri, Jul 14, 2:46 AM

Thu, Jul 13

rovka committed rL307904: [ARM] GlobalISel: Support G_BR.
[ARM] GlobalISel: Support G_BR
Thu, Jul 13, 4:10 AM
rovka committed rL307896: Fixup r307893: Silence warning.
Fixup r307893: Silence warning
Thu, Jul 13, 2:52 AM
rovka committed rL307893: [ARM] GlobalISel: Move local variable. NFC.
[ARM] GlobalISel: Move local variable. NFC
Thu, Jul 13, 2:30 AM
rovka accepted D35248: [ARM] Tidy up and organise better ARM.td. NFC..

I don't see anything wrong with this.
I'm not a huge fan of splitting string literals, since it makes it harder to grep for things, but I see there was already some precedent for that in the file and I assume this is what clang-format does too, so it's fine.

Thu, Jul 13, 1:35 AM

Wed, Jul 12

rovka added a comment to D35156: [ARM] Make ARMExpandPseudo add implicit uses for predicated instructions.

Thanks for the test-case and the explanations.
LGTM but you should probably wait for someone more versed in these things to give the final approval.

Wed, Jul 12, 4:44 AM
rovka committed rL307766: [ARM] GlobalISel: Simplify inst selector code. NFC.
[ARM] GlobalISel: Simplify inst selector code. NFC
Wed, Jul 12, 3:31 AM
rovka committed rL307763: [ARM] GlobalISel: Select s64 G_FCMP.
[ARM] GlobalISel: Select s64 G_FCMP
Wed, Jul 12, 2:02 AM

Tue, Jul 11

rovka committed rL307656: [ARM] GlobalISel: Tighten G_FCMP selection test. NFC.
[ARM] GlobalISel: Tighten G_FCMP selection test. NFC
Tue, Jul 11, 5:35 AM
rovka committed rL307653: [ARM] GlobalISel: Add reg mapping for s64 G_FCMP.
[ARM] GlobalISel: Add reg mapping for s64 G_FCMP
Tue, Jul 11, 4:48 AM
rovka committed rL307647: [ARM] GlobalISel: Tighten legalizer tests. NFC.
[ARM] GlobalISel: Tighten legalizer tests. NFC
Tue, Jul 11, 3:52 AM
rovka committed rL307639: [ARM] GlobalISel: Fix oversight in G_FCMP legalization.
[ARM] GlobalISel: Fix oversight in G_FCMP legalization
Tue, Jul 11, 2:44 AM
rovka committed rL307633: [ARM] GlobalISel: Legalize s64 G_FCMP.
[ARM] GlobalISel: Legalize s64 G_FCMP
Tue, Jul 11, 1:50 AM

Mon, Jul 10

rovka added a comment to D35156: [ARM] Make ARMExpandPseudo add implicit uses for predicated instructions.

Hi Eli,

Mon, Jul 10, 2:47 AM

Fri, Jul 7

rovka added a comment to D35116: [ARM] Tidy up ARMBaseRegisterInfo implementation. NFC.

Actually, I do have one nit :)

Fri, Jul 7, 5:27 AM
rovka accepted D35116: [ARM] Tidy up ARMBaseRegisterInfo implementation. NFC.

LGTM, thanks!

Fri, Jul 7, 5:26 AM
rovka committed rL307366: [ARM] GlobalISel: Fixup r307365.
[ARM] GlobalISel: Fixup r307365
Fri, Jul 7, 1:54 AM
rovka committed rL307365: [ARM] GlobalISel: Select hard G_FCMP for s32.
[ARM] GlobalISel: Select hard G_FCMP for s32
Fri, Jul 7, 1:39 AM

Thu, Jul 6

rovka committed rL307245: [ARM] GlobalISel: Map s32 G_FCMP in reg bank select.
[ARM] GlobalISel: Map s32 G_FCMP in reg bank select
Thu, Jul 6, 2:58 AM
rovka committed rL307243: [ARM] GlobalISel: Legalize G_FCMP for s32.
[ARM] GlobalISel: Legalize G_FCMP for s32
Thu, Jul 6, 2:10 AM
rovka committed rL307239: [ARM] GlobalISel: Widen s1, s8, s16 G_CONSTANT.
[ARM] GlobalISel: Widen s1, s8, s16 G_CONSTANT
Thu, Jul 6, 1:04 AM

Wed, Jul 5

rovka committed rL307149: [GlobalISel] Refactor Legalizer helpers for libcalls.
[GlobalISel] Refactor Legalizer helpers for libcalls
Wed, Jul 5, 5:57 AM
rovka committed rL307145: [ARM] GlobalISel: Extract tiny helper. NFC.
[ARM] GlobalISel: Extract tiny helper. NFC
Wed, Jul 5, 4:54 AM
rovka committed rL307144: [MachineIRBuilder] Fix formatting. NFC..
[MachineIRBuilder] Fix formatting. NFC.
Wed, Jul 5, 4:47 AM
rovka committed rL307141: [MachineIRBuilder] Add buildOr helper. NFC..
[MachineIRBuilder] Add buildOr helper. NFC.
Wed, Jul 5, 4:32 AM
rovka added a comment to rL307126: [IndVars] Canonicalize comparisons between non-negative values and indvars.

Oops, I looked into it more closely and they're not timeouts, they're real issues:
Execution Context Diff:
/home/buildslave/buildslave/clang-native-arm-lnt/test/sandbox/build/tools/fpcmp: files differ without tolerance allowance

Wed, Jul 5, 4:11 AM
rovka committed rL307139: [MachineIRBuilder] Add buildBinaryOp helper. NFC.
[MachineIRBuilder] Add buildBinaryOp helper. NFC
Wed, Jul 5, 4:03 AM
rovka added a comment to rL307126: [IndVars] Canonicalize comparisons between non-negative values and indvars.

Hi, I just wanted to point out that this change also slows down some test-suite apps on ARM, as you can see here:
http://lab.llvm.org:8011/builders/clang-native-arm-lnt/builds/5997

Wed, Jul 5, 3:50 AM

Wed, Jun 28

rovka committed rL306523: Add AArch64 GlobalISel buildbot.
Add AArch64 GlobalISel buildbot
Wed, Jun 28, 2:22 AM

Tue, Jun 27

rovka committed rL306390: [ARM] GlobalISel: Support G_SELECT for pointers.
[ARM] GlobalISel: Support G_SELECT for pointers
Tue, Jun 27, 3:30 AM
rovka committed rL306382: [ARM] GlobalISel: Support G_SELECT for i32.
[ARM] GlobalISel: Support G_SELECT for i32
Tue, Jun 27, 2:20 AM

Jun 22 2017

rovka added a comment to D33758: [globalisel][tablegen] Partially fix compile-time regressions by converting matcher to state-machine(s).

Not for this patch, but I feel like some of the names and comments (e.g. emitCxxCaptureStmts) are starting to drift a bit from the implementation. Maybe at the end of this patch stack you could look into brushing them up?

Jun 22 2017, 5:41 AM
rovka committed rL305990: Revert "Enable vectorizer-maximize-bandwidth by default.".
Revert "Enable vectorizer-maximize-bandwidth by default."
Jun 22 2017, 3:01 AM

Jun 19 2017

rovka committed rL305683: [ARM] GlobalISel: Support G_ICMP for s8 and s16.
[ARM] GlobalISel: Support G_ICMP for s8 and s16
Jun 19 2017, 4:48 AM
rovka committed rL305672: [ARM] GlobalISel: Support G_ICMP for i32 and pointers.
[ARM] GlobalISel: Support G_ICMP for i32 and pointers
Jun 19 2017, 2:41 AM
rovka committed rL305671: Set higher timeouts for PAQ8p and SciMark2-C on AArch64.
Set higher timeouts for PAQ8p and SciMark2-C on AArch64
Jun 19 2017, 1:59 AM

Jun 15 2017

rovka committed rL305459: [ARM] GlobalISel: Add support for i32 modulo.
[ARM] GlobalISel: Add support for i32 modulo
Jun 15 2017, 3:54 AM
rovka committed rL305458: [ARM] GlobalISel: Lower only homogeneous struct args.
[ARM] GlobalISel: Lower only homogeneous struct args
Jun 15 2017, 2:42 AM

Jun 13 2017

rovka committed rL305287: Revert "Revert r301742 which made ExprConstant checking apply to all full-exprs..
Revert "Revert r301742 which made ExprConstant checking apply to all full-exprs.
Jun 13 2017, 5:51 AM

Jun 8 2017

rovka committed rL304971: [ARM] GlobalISel: Add more tests. NFC.
[ARM] GlobalISel: Add more tests. NFC
Jun 8 2017, 2:48 AM

Jun 7 2017

rovka committed rL304902: [ARM] GlobalISel: Purge G_SEQUENCE.
[ARM] GlobalISel: Purge G_SEQUENCE
Jun 7 2017, 5:35 AM
rovka committed rL304898: [ARM] GlobalISel: Support G_XOR.
[ARM] GlobalISel: Support G_XOR
Jun 7 2017, 4:57 AM
rovka committed rL304890: [ARM] GlobalISel: Support G_OR.
[ARM] GlobalISel: Support G_OR
Jun 7 2017, 3:14 AM
rovka committed rL304885: [ARM] GlobalISel: Support G_AND.
[ARM] GlobalISel: Support G_AND
Jun 7 2017, 2:18 AM

Jun 5 2017

rovka committed rL304712: [ARM] GlobalISel: Constrain callee register on indirect calls.
[ARM] GlobalISel: Constrain callee register on indirect calls
Jun 5 2017, 5:55 AM
rovka committed rL304703: Retire clang-cmake-aarch64-39vma.
Retire clang-cmake-aarch64-39vma
Jun 5 2017, 2:45 AM

Jun 2 2017

rovka committed rL304536: [ARM] GlobalISel: Support struct params/returns.
[ARM] GlobalISel: Support struct params/returns
Jun 2 2017, 3:17 AM
rovka added a comment to D33786: [ARM] Fix Neon vector type alignment to 64-bit.

It certainly seems more restrictive than the previous patch, so I think it should be ok. @rengolin probably understands the subtleties here a bit better than I do.

Jun 2 2017, 2:55 AM

May 30 2017

rovka committed rL304211: Fixup r304205 - Require PowerPC target.
Fixup r304205 - Require PowerPC target
May 30 2017, 7:06 AM

May 29 2017

rovka committed rL304143: [ARM] GlobalISel: Extract helper. NFCI..
[ARM] GlobalISel: Extract helper. NFCI.
May 29 2017, 2:10 AM
rovka committed rL304137: [ARM] GlobalISel: Support array returns.
[ARM] GlobalISel: Support array returns
May 29 2017, 1:19 AM
rovka committed rL304132: [ARM] GlobalISel: Support array parameters/arguments.
[ARM] GlobalISel: Support array parameters/arguments
May 29 2017, 12:02 AM

May 24 2017

rovka committed rL303747: Revert "[SCEV] Do not fold dominated SCEVUnknown into AddRecExpr start".
Revert "[SCEV] Do not fold dominated SCEVUnknown into AddRecExpr start"
May 24 2017, 7:16 AM

May 18 2017

rovka committed rL303338: Fixup r303324 - temporary disable stndup interceptor, due to r302781 being buggy.
Fixup r303324 - temporary disable stndup interceptor, due to r302781 being buggy
May 18 2017, 2:25 AM

May 17 2017

rovka committed rL303252: Reland r303247: [ARM] GlobalISel: Remove dead instruction selection code.
Reland r303247: [ARM] GlobalISel: Remove dead instruction selection code
May 17 2017, 5:56 AM
rovka committed rL303249: Revert "[ARM] GlobalISel: Remove dead instruction selection code".
Revert "[ARM] GlobalISel: Remove dead instruction selection code"
May 17 2017, 5:09 AM
rovka committed rL303247: [ARM] GlobalISel: Remove dead instruction selection code.
[ARM] GlobalISel: Remove dead instruction selection code
May 17 2017, 4:52 AM
rovka committed rL303243: Fixup r303240: Use llvm::to_string instead of std::to_string.
Fixup r303240: Use llvm::to_string instead of std::to_string
May 17 2017, 2:38 AM
rovka committed rL303240: [GlobalISel][TableGen] Fix handling of default operands.
[GlobalISel][TableGen] Fix handling of default operands
May 17 2017, 2:11 AM
rovka closed D33031: [GlobalISel][TableGen] Fix handling of default operands by committing rL303240: [GlobalISel][TableGen] Fix handling of default operands.
May 17 2017, 2:10 AM

May 12 2017

rovka committed rL302900: Add -lm to plot2fig.
Add -lm to plot2fig
May 12 2017, 7:42 AM

May 11 2017

rovka updated the diff for D33031: [GlobalISel][TableGen] Fix handling of default operands.

Removed the first loop and extracted a helper for adding renderers for default ops. I think this makes the body of the loop easier to read.

May 11 2017, 5:53 AM
rovka committed rL302782: [ARM][GlobalISel] Legalize narrow scalar ops by widening.
[ARM][GlobalISel] Legalize narrow scalar ops by widening
May 11 2017, 2:59 AM
rovka committed rL302778: [ARM][GlobalISel] Support for G_ANYEXT.
[ARM][GlobalISel] Support for G_ANYEXT
May 11 2017, 1:41 AM
rovka committed rL302776: Revert "PR22877: When constructing an array via a constructor with a default….
Revert "PR22877: When constructing an array via a constructor with a default…
May 11 2017, 1:23 AM

May 10 2017

rovka added inline comments to D33031: [GlobalISel][TableGen] Fix handling of default operands.
May 10 2017, 3:29 PM
rovka added inline comments to D33031: [GlobalISel][TableGen] Fix handling of default operands.
May 10 2017, 12:19 AM
rovka created D33031: [GlobalISel][TableGen] Fix handling of default operands.
May 10 2017, 12:11 AM

May 9 2017

rovka committed rL302524: Revert "[Dwarf] Disable reference verification for now (PR32972)".
Revert "[Dwarf] Disable reference verification for now (PR32972)"
May 9 2017, 6:19 AM
rovka committed rL302511: [ARM GlobalISel] Remove hand-written G_FADD selection.
[ARM GlobalISel] Remove hand-written G_FADD selection
May 9 2017, 1:46 AM

May 2 2017

rovka committed rL301905: [ARM] GlobalISel: Use TableGen instruction selector.
[ARM] GlobalISel: Use TableGen instruction selector
May 2 2017, 2:53 AM

Apr 28 2017

rovka added a comment to D32491: [globalisel][tablegen] Compute available feature bits correctly..

I just checked and the existing ARM tests fail without this patch because the available features aren't reset when entering the functions. They work with this patch + enabling the TableGen selector for ARM, so we'll have tests then :)

Apr 28 2017, 8:24 AM
rovka added a comment to D32491: [globalisel][tablegen] Compute available feature bits correctly..

I think this patch is already doing a lot of things, I'd prefer committing the support for immediates separately and opening a PR for the test (and you can attach the X86 test to it so we can discuss with Igor). I need to double check this, but I think if I enable this for ARM (which I intend to do after this goes in) the existing ARM tests will already exercise this (for G_SDIV).

Apr 28 2017, 7:55 AM
rovka committed rL301633: [ARM] GlobalISel: fixup r301632.
[ARM] GlobalISel: fixup r301632
Apr 28 2017, 2:33 AM
rovka committed rL301632: [ARM] GlobalISel: Get rid of ARMInstructionSelector.h. NFC..
[ARM] GlobalISel: Get rid of ARMInstructionSelector.h. NFC.
Apr 28 2017, 2:23 AM
rovka committed rL301627: [ARM] GlobalISel: Tighten test. NFC.
[ARM] GlobalISel: Tighten test. NFC
Apr 28 2017, 1:03 AM

Apr 27 2017

rovka added a comment to D32491: [globalisel][tablegen] Compute available feature bits correctly..

I'm having trouble improving the test case since the function-level predicates don't show up in any importable rules yet. I'll see if I can uncover one

Apr 27 2017, 8:05 AM
rovka committed rL301531: [ARM] GlobalISel: Fix extended stack operands.
[ARM] GlobalISel: Fix extended stack operands
Apr 27 2017, 3:36 AM

Apr 26 2017

rovka added a comment to D32529: [GlobalISel] Make multi-step legalization work..

Thanks for splitting this out! The ARM part looks excellent :)
I think you could add some target-independent tests for this in unittests/CodeGen/GlobalISel/LegalizerInfoTest.cpp, to make sure it works to WidenScalar/MoreElements etc to a type that has a Libcall or Custom action. That way we won't have to depend on ARM for testing this functionality.

Apr 26 2017, 8:44 AM
rovka accepted D32491: [globalisel][tablegen] Compute available feature bits correctly..
Apr 26 2017, 7:58 AM
rovka added a comment to D32491: [globalisel][tablegen] Compute available feature bits correctly..

Thanks for all the explanations!
LGTM with that extra test, we can keep discussing the remaining points but I think it's ok to iterate in-tree. I'd really, really like to see the default change from 0 to 1 on RecomputePerFunction, it seems safer that way.

Apr 26 2017, 7:58 AM
rovka added a comment to D32491: [globalisel][tablegen] Compute available feature bits correctly..

So, we have a new GISelAccessor with a new InstructionSelector for each unique subtarget (module + function attributes, as hashed in getSubtargetImpl). Why do we need to have module features and function features in each InstructionSelector? Isn't there a different InstructionSelector for each kind of function, and don't we magically get the right one when processing each function? What am I missing? It seems to me that we could get away with a single set of availableFeatures per InstructionSelector.

Apr 26 2017, 2:40 AM

Apr 25 2017

rovka accepted D32438: [LNT] Document how to capture linux perf profiles..

I tried it and I can confirm that it works. Thanks!

Apr 25 2017, 9:58 AM
rovka added a comment to D32275: [globalisel][tablegen] Add several GINodeEquiv's for operators that do not require additional support..

I decided to have a look at code coverage differences before committing this. This patch made no difference to the code coverage. On closer inspection it turns out beginFunction() isn't being executed so no rules with rule predicates can match. I'll take a look at this, maybe something from the rule-predicates patch didn't make it into the final commit.

Apr 25 2017, 3:46 AM

Apr 24 2017

rovka committed rL301166: [ARM] GlobalISel: Legalize s8 and s16 G_(S|U)DIV.
[ARM] GlobalISel: Legalize s8 and s16 G_(S|U)DIV
Apr 24 2017, 2:25 AM
rovka committed rL301164: [ARM] GlobalISel: Support G_(S|U)DIV for s32.
[ARM] GlobalISel: Support G_(S|U)DIV for s32
Apr 24 2017, 1:33 AM
rovka committed rL301163: [GlobalISel] Legalize G_(S|U)DIV libcalls.
[GlobalISel] Legalize G_(S|U)DIV libcalls
Apr 24 2017, 12:35 AM

Apr 23 2017

rovka committed rL301162: [ARM] GlobalISel: Select G_CONSTANT with CImm operands.
[ARM] GlobalISel: Select G_CONSTANT with CImm operands
Apr 23 2017, 11:43 PM

Apr 21 2017

rovka committed rL300971: [ARM] GlobalISel: Add support for G_TRUNC.
[ARM] GlobalISel: Add support for G_TRUNC
Apr 21 2017, 6:29 AM