rovka (Diana Picus)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2016, 3:27 AM (73 w, 6 d)

Recent Activity

Wed, Sep 6

rovka committed rL312647: [zorg] Remove clang-cmake-aarch64-42vma builder.
[zorg] Remove clang-cmake-aarch64-42vma builder
Wed, Sep 6, 9:35 AM
rovka closed D37459: [buildbot] Remove clang-cmake-aarch64-42vma builder by committing rL312647: [zorg] Remove clang-cmake-aarch64-42vma builder.
Wed, Sep 6, 9:35 AM

Tue, Sep 5

rovka committed rL312522: [ARM] GlobalISel: Minor cleanups in inst selector.
[ARM] GlobalISel: Minor cleanups in inst selector
Tue, Sep 5, 1:24 AM
rovka committed rL312521: [ARM] GlobalISel: Support global variables for RWPI.
[ARM] GlobalISel: Support global variables for RWPI
Tue, Sep 5, 12:59 AM

Fri, Sep 1

rovka committed rL312323: [ARM] GlobalISel: Support ROPI global variables.
[ARM] GlobalISel: Support ROPI global variables
Fri, Sep 1, 4:15 AM
rovka committed rL312320: Move static helper into ARMTargetLowering. NFC.
Move static helper into ARMTargetLowering. NFC
Fri, Sep 1, 3:46 AM
rovka committed rL312319: [ARM] GlobalISel: More tests. NFC..
[ARM] GlobalISel: More tests. NFC.
Fri, Sep 1, 3:20 AM

Wed, Aug 30

rovka added a comment to D36534: [aarch64] Support APInt and APFloat in ImmLeaf subclasses and make AArch64 use them..

I can see why you need to change the patterns to be more general, but is the distinction between APInt, APFloat and 64-bit values really relevant? I looked a bit at the following patch which uses this for GlobalISel and I'm wondering if we could just get away with checking for each immediate a combination of isCImm, isFPImm and getBitWidth (so we wouldn't need to introduce different states for different kinds of immediates).

Wed, Aug 30, 7:44 AM

Tue, Aug 29

rovka committed rL311992: [ARM] GlobalISel: Select globals in PIC mode.
[ARM] GlobalISel: Select globals in PIC mode
Tue, Aug 29, 2:49 AM
rovka closed D36507: [ARM] GlobalISel: Select globals in PIC mode by committing rL311992: [ARM] GlobalISel: Select globals in PIC mode.
Tue, Aug 29, 2:49 AM
rovka committed rL311989: [ARM] GlobalISel: Rename tests. NFC..
[ARM] GlobalISel: Rename tests. NFC.
Tue, Aug 29, 2:02 AM

Thu, Aug 24

rovka committed rL311638: clang-native-arm-lnt-perf: Move to test-suite producer.
clang-native-arm-lnt-perf: Move to test-suite producer
Thu, Aug 24, 1:41 AM

Tue, Aug 22

rovka accepted D36086: [globalisel][tablegen] Add support for ImmLeaf without SDNodeXForm.

Thanks for the updates, this looks really good now!

Tue, Aug 22, 7:09 PM

Aug 21 2017

rovka added a comment to D36507: [ARM] GlobalISel: Select globals in PIC mode.

@t.p.northover Could you have a quick look at this, please?

Aug 21 2017, 9:47 AM

Aug 18 2017

rovka committed rL311151: Revert "GlobalISel (AArch64): fix ABI at border between GPRs and SP.".
Revert "GlobalISel (AArch64): fix ABI at border between GPRs and SP."
Aug 18 2017, 2:32 AM

Aug 17 2017

rovka added a comment to D36086: [globalisel][tablegen] Add support for ImmLeaf without SDNodeXForm.

This should have a summary.

Aug 17 2017, 9:17 AM

Aug 11 2017

rovka accepted D36085: [globalisel][tablegen] Generate TypeObject table. NFC.

LGTM now.

Aug 11 2017, 2:06 AM
rovka added a comment to D36084: [globalisel][tablegen] Support zero-instruction emission..

I had a testcase for this one but it seems to have gone missing. I'll update with one shortly

Aug 11 2017, 1:55 AM

Aug 10 2017

rovka added a comment to D36576: Fix -fPIC handling on arm64.

Thanks for sending the patch.

Aug 10 2017, 6:14 AM
rovka updated the diff for D36507: [ARM] GlobalISel: Select globals in PIC mode.

Thanks for the comments! I've updated the code to never use MOVT for ELF. I've also reworded the FIXME and mentioned the bug report in it.

Aug 10 2017, 4:23 AM

Aug 9 2017

rovka committed rL310464: Revert "PR19668, PR23034: Fix handling of move constructors and deleted copy….
Revert "PR19668, PR23034: Fix handling of move constructors and deleted copy…
Aug 9 2017, 5:23 AM
rovka created D36507: [ARM] GlobalISel: Select globals in PIC mode.
Aug 9 2017, 2:22 AM

Aug 3 2017

rovka added a comment to D35833: [globalisel][tablegen] Add support for importing 'imm' operands..

Well, considering that Mips prefers SExt and nothing (that we're aware of) prefers ZExt, it might be better to just use SExt from the start. But if you're feeling lazy ZExt is fine too :)

Aug 3 2017, 6:27 AM
rovka committed rL309927: [ARM] GlobalISel: Select simple G_GLOBAL_VALUE instructions.
[ARM] GlobalISel: Select simple G_GLOBAL_VALUE instructions
Aug 3 2017, 2:15 AM
rovka closed D35883: [ARM] GlobalISel: Select simple G_GLOBAL_VALUE instructions by committing rL309927: [ARM] GlobalISel: Select simple G_GLOBAL_VALUE instructions.
Aug 3 2017, 2:15 AM

Aug 2 2017

rovka added inline comments to D36219: [ARM] Tidy up banked registers encoding.
Aug 2 2017, 7:34 AM
rovka added inline comments to D35833: [globalisel][tablegen] Add support for importing 'imm' operands..
Aug 2 2017, 7:22 AM
rovka added a comment to D35883: [ARM] GlobalISel: Select simple G_GLOBAL_VALUE instructions.

Ping

Aug 2 2017, 7:16 AM
rovka added a comment to D36085: [globalisel][tablegen] Generate TypeObject table. NFC.

You should add checks for the GILLT enum in GlobalISelEmitter.td, since now it won't be the same enum for all targets.

Aug 2 2017, 7:05 AM
rovka added a comment to D36084: [globalisel][tablegen] Support zero-instruction emission..

Hi Daniel,

Aug 2 2017, 5:51 AM
rovka committed rL309806: [MIR] Print target-specific constant pools.
[MIR] Print target-specific constant pools
Aug 2 2017, 4:10 AM
rovka closed D36092: [MIR] Print target specific constant pools by committing rL309806: [MIR] Print target-specific constant pools.
Aug 2 2017, 4:10 AM
rovka updated the diff for D36092: [MIR] Print target specific constant pools.

Refresh before commit. Now including a test for the error-path!

Aug 2 2017, 3:04 AM

Aug 1 2017

rovka updated the diff for D36092: [MIR] Print target specific constant pools.

Thanks for the detailed response!

Aug 1 2017, 4:31 AM

Jul 31 2017

rovka created D36092: [MIR] Print target specific constant pools.
Jul 31 2017, 8:07 AM

Jul 27 2017

rovka accepted D35884: Update to use enum classes for various ARM *Kind enums.

Looks entirely mechanical, I don't see any problem with it (just a couple of nits).

Jul 27 2017, 8:00 AM
rovka accepted D35882: [TargetParser] Use enum classes for various ARM kind enums..

LGTM.

Jul 27 2017, 7:45 AM
rovka added a comment to D29840: test-release.sh: Remove workaround for test-suite build.

Hi Tom,

Jul 27 2017, 6:43 AM
rovka added inline comments to D35882: [TargetParser] Use enum classes for various ARM kind enums..
Jul 27 2017, 5:15 AM
rovka accepted D35833: [globalisel][tablegen] Add support for importing 'imm' operands..

Seems fine.

Jul 27 2017, 4:15 AM

Jul 26 2017

rovka committed rL309101: [ARM] GlobalISel: Map G_GLOBAL_VALUE to GPR.
[ARM] GlobalISel: Map G_GLOBAL_VALUE to GPR
Jul 26 2017, 4:01 AM
rovka created D35883: [ARM] GlobalISel: Select simple G_GLOBAL_VALUE instructions.
Jul 26 2017, 2:33 AM
rovka committed rL309090: [ARM] GlobalISel: Mark G_GLOBAL_VALUE as legal.
[ARM] GlobalISel: Mark G_GLOBAL_VALUE as legal
Jul 26 2017, 2:27 AM

Jul 25 2017

rovka accepted D35681: [globalisel][tablegen] Fuse the generated tables together..

Cool, LGTM, thanks.

Jul 25 2017, 6:11 AM
rovka added inline comments to D35681: [globalisel][tablegen] Fuse the generated tables together..
Jul 25 2017, 3:30 AM

Jul 20 2017

rovka committed rL308603: Revert "GlobalISel: select G_EXTRACT and G_INSERT instructions on AArch64.".
Revert "GlobalISel: select G_EXTRACT and G_INSERT instructions on AArch64."
Jul 20 2017, 4:36 AM

Jul 19 2017

rovka accepted D35117: [globalisel][tablegen] Add control-flow to the MatchTable..

LGTM with minor nits.

Jul 19 2017, 3:04 AM

Jul 18 2017

rovka committed rL308285: [ARM] GlobalISel: Support G_(S|U)REM for s8 and s16.
[ARM] GlobalISel: Support G_(S|U)REM for s8 and s16
Jul 18 2017, 3:07 AM
rovka committed rL308278: GlobalISel: Support G_(S|U)REM widening in LegalizerHelper.
GlobalISel: Support G_(S|U)REM widening in LegalizerHelper
Jul 18 2017, 2:09 AM

Jul 17 2017

rovka added a comment to D35117: [globalisel][tablegen] Add control-flow to the MatchTable..

I think the commit message should elaborate a bit on why we want a single table.
Other nits:

Jul 17 2017, 4:46 AM
rovka committed rL308165: Set higher timeouts for Misc-C++ on AArch64.
Set higher timeouts for Misc-C++ on AArch64
Jul 17 2017, 2:04 AM
rovka accepted D35419: [CodeGen] Add begin-end iterators to MachineInstr.

LGTM.

Jul 17 2017, 1:30 AM

Jul 14 2017

rovka added a reviewer for D35419: [CodeGen] Add begin-end iterators to MachineInstr: echristo.
Jul 14 2017, 9:26 AM
rovka accepted D35130: [globalisel][tablegen] Enable the import of rules involving fma..

Looks pretty trivial.

Jul 14 2017, 9:07 AM
rovka accepted D35402: [zorg] Enable running 'lnt runtest test-suite' instead of 'lnt runtest nt'..

Hi, I tested this on our internal buildmaster and it seems to work. LGTM.

Jul 14 2017, 7:47 AM
rovka added a comment to D34875: ARM: Report error for invalid use of AAPCS_VFP calling convention.

Hi, you could try looking into LLVMContext::emitError - it shouldn't be too hard to get hold of an LLVMContext, and that's what we use to report e.g. errors in inline asm in SelectionDAGBuilder.

Jul 14 2017, 5:13 AM
rovka committed rL308009: [ARM] GlobalISel: Support G_BRCOND.
[ARM] GlobalISel: Support G_BRCOND
Jul 14 2017, 2:46 AM

Jul 13 2017

rovka committed rL307904: [ARM] GlobalISel: Support G_BR.
[ARM] GlobalISel: Support G_BR
Jul 13 2017, 4:10 AM
rovka committed rL307896: Fixup r307893: Silence warning.
Fixup r307893: Silence warning
Jul 13 2017, 2:52 AM
rovka committed rL307893: [ARM] GlobalISel: Move local variable. NFC.
[ARM] GlobalISel: Move local variable. NFC
Jul 13 2017, 2:30 AM
rovka accepted D35248: [ARM] Tidy up and organise better ARM.td. NFC..

I don't see anything wrong with this.
I'm not a huge fan of splitting string literals, since it makes it harder to grep for things, but I see there was already some precedent for that in the file and I assume this is what clang-format does too, so it's fine.

Jul 13 2017, 1:35 AM

Jul 12 2017

rovka added a comment to D35156: [ARM] Make ARMExpandPseudo add implicit uses for predicated instructions.

Thanks for the test-case and the explanations.
LGTM but you should probably wait for someone more versed in these things to give the final approval.

Jul 12 2017, 4:44 AM
rovka committed rL307766: [ARM] GlobalISel: Simplify inst selector code. NFC.
[ARM] GlobalISel: Simplify inst selector code. NFC
Jul 12 2017, 3:31 AM
rovka committed rL307763: [ARM] GlobalISel: Select s64 G_FCMP.
[ARM] GlobalISel: Select s64 G_FCMP
Jul 12 2017, 2:02 AM

Jul 11 2017

rovka committed rL307656: [ARM] GlobalISel: Tighten G_FCMP selection test. NFC.
[ARM] GlobalISel: Tighten G_FCMP selection test. NFC
Jul 11 2017, 5:35 AM
rovka committed rL307653: [ARM] GlobalISel: Add reg mapping for s64 G_FCMP.
[ARM] GlobalISel: Add reg mapping for s64 G_FCMP
Jul 11 2017, 4:48 AM
rovka committed rL307647: [ARM] GlobalISel: Tighten legalizer tests. NFC.
[ARM] GlobalISel: Tighten legalizer tests. NFC
Jul 11 2017, 3:52 AM
rovka committed rL307639: [ARM] GlobalISel: Fix oversight in G_FCMP legalization.
[ARM] GlobalISel: Fix oversight in G_FCMP legalization
Jul 11 2017, 2:44 AM
rovka committed rL307633: [ARM] GlobalISel: Legalize s64 G_FCMP.
[ARM] GlobalISel: Legalize s64 G_FCMP
Jul 11 2017, 1:50 AM

Jul 10 2017

rovka added a comment to D35156: [ARM] Make ARMExpandPseudo add implicit uses for predicated instructions.

Hi Eli,

Jul 10 2017, 2:47 AM

Jul 7 2017

rovka added a comment to D35116: [ARM] Tidy up ARMBaseRegisterInfo implementation. NFC.

Actually, I do have one nit :)

Jul 7 2017, 5:27 AM
rovka accepted D35116: [ARM] Tidy up ARMBaseRegisterInfo implementation. NFC.

LGTM, thanks!

Jul 7 2017, 5:26 AM
rovka committed rL307366: [ARM] GlobalISel: Fixup r307365.
[ARM] GlobalISel: Fixup r307365
Jul 7 2017, 1:54 AM
rovka committed rL307365: [ARM] GlobalISel: Select hard G_FCMP for s32.
[ARM] GlobalISel: Select hard G_FCMP for s32
Jul 7 2017, 1:39 AM

Jul 6 2017

rovka committed rL307245: [ARM] GlobalISel: Map s32 G_FCMP in reg bank select.
[ARM] GlobalISel: Map s32 G_FCMP in reg bank select
Jul 6 2017, 2:58 AM
rovka committed rL307243: [ARM] GlobalISel: Legalize G_FCMP for s32.
[ARM] GlobalISel: Legalize G_FCMP for s32
Jul 6 2017, 2:10 AM
rovka committed rL307239: [ARM] GlobalISel: Widen s1, s8, s16 G_CONSTANT.
[ARM] GlobalISel: Widen s1, s8, s16 G_CONSTANT
Jul 6 2017, 1:04 AM

Jul 5 2017

rovka committed rL307149: [GlobalISel] Refactor Legalizer helpers for libcalls.
[GlobalISel] Refactor Legalizer helpers for libcalls
Jul 5 2017, 5:57 AM
rovka committed rL307145: [ARM] GlobalISel: Extract tiny helper. NFC.
[ARM] GlobalISel: Extract tiny helper. NFC
Jul 5 2017, 4:54 AM
rovka committed rL307144: [MachineIRBuilder] Fix formatting. NFC..
[MachineIRBuilder] Fix formatting. NFC.
Jul 5 2017, 4:47 AM
rovka committed rL307141: [MachineIRBuilder] Add buildOr helper. NFC..
[MachineIRBuilder] Add buildOr helper. NFC.
Jul 5 2017, 4:32 AM
rovka added a comment to rL307126: [IndVars] Canonicalize comparisons between non-negative values and indvars.

Oops, I looked into it more closely and they're not timeouts, they're real issues:
Execution Context Diff:
/home/buildslave/buildslave/clang-native-arm-lnt/test/sandbox/build/tools/fpcmp: files differ without tolerance allowance

Jul 5 2017, 4:11 AM
rovka committed rL307139: [MachineIRBuilder] Add buildBinaryOp helper. NFC.
[MachineIRBuilder] Add buildBinaryOp helper. NFC
Jul 5 2017, 4:03 AM
rovka added a comment to rL307126: [IndVars] Canonicalize comparisons between non-negative values and indvars.

Hi, I just wanted to point out that this change also slows down some test-suite apps on ARM, as you can see here:
http://lab.llvm.org:8011/builders/clang-native-arm-lnt/builds/5997

Jul 5 2017, 3:50 AM

Jun 28 2017

rovka committed rL306523: Add AArch64 GlobalISel buildbot.
Add AArch64 GlobalISel buildbot
Jun 28 2017, 2:22 AM

Jun 27 2017

rovka committed rL306390: [ARM] GlobalISel: Support G_SELECT for pointers.
[ARM] GlobalISel: Support G_SELECT for pointers
Jun 27 2017, 3:30 AM
rovka committed rL306382: [ARM] GlobalISel: Support G_SELECT for i32.
[ARM] GlobalISel: Support G_SELECT for i32
Jun 27 2017, 2:20 AM

Jun 22 2017

rovka added a comment to D33758: [globalisel][tablegen] Partially fix compile-time regressions by converting matcher to state-machine(s).

Not for this patch, but I feel like some of the names and comments (e.g. emitCxxCaptureStmts) are starting to drift a bit from the implementation. Maybe at the end of this patch stack you could look into brushing them up?

Jun 22 2017, 5:41 AM
rovka committed rL305990: Revert "Enable vectorizer-maximize-bandwidth by default.".
Revert "Enable vectorizer-maximize-bandwidth by default."
Jun 22 2017, 3:01 AM

Jun 19 2017

rovka committed rL305683: [ARM] GlobalISel: Support G_ICMP for s8 and s16.
[ARM] GlobalISel: Support G_ICMP for s8 and s16
Jun 19 2017, 4:48 AM
rovka committed rL305672: [ARM] GlobalISel: Support G_ICMP for i32 and pointers.
[ARM] GlobalISel: Support G_ICMP for i32 and pointers
Jun 19 2017, 2:41 AM
rovka committed rL305671: Set higher timeouts for PAQ8p and SciMark2-C on AArch64.
Set higher timeouts for PAQ8p and SciMark2-C on AArch64
Jun 19 2017, 1:59 AM

Jun 15 2017

rovka committed rL305459: [ARM] GlobalISel: Add support for i32 modulo.
[ARM] GlobalISel: Add support for i32 modulo
Jun 15 2017, 3:54 AM
rovka committed rL305458: [ARM] GlobalISel: Lower only homogeneous struct args.
[ARM] GlobalISel: Lower only homogeneous struct args
Jun 15 2017, 2:42 AM

Jun 13 2017

rovka committed rL305287: Revert "Revert r301742 which made ExprConstant checking apply to all full-exprs..
Revert "Revert r301742 which made ExprConstant checking apply to all full-exprs.
Jun 13 2017, 5:51 AM

Jun 8 2017

rovka committed rL304971: [ARM] GlobalISel: Add more tests. NFC.
[ARM] GlobalISel: Add more tests. NFC
Jun 8 2017, 2:48 AM

Jun 7 2017

rovka committed rL304902: [ARM] GlobalISel: Purge G_SEQUENCE.
[ARM] GlobalISel: Purge G_SEQUENCE
Jun 7 2017, 5:35 AM
rovka committed rL304898: [ARM] GlobalISel: Support G_XOR.
[ARM] GlobalISel: Support G_XOR
Jun 7 2017, 4:57 AM
rovka committed rL304890: [ARM] GlobalISel: Support G_OR.
[ARM] GlobalISel: Support G_OR
Jun 7 2017, 3:14 AM
rovka committed rL304885: [ARM] GlobalISel: Support G_AND.
[ARM] GlobalISel: Support G_AND
Jun 7 2017, 2:18 AM