rovka (Diana Picus)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2016, 3:27 AM (52 w, 5 d)

Recent Activity

Today

rovka added a comment to D32275: [globalisel][tablegen] Add several GINodeEquiv's for operators that do not require additional support..

I decided to have a look at code coverage differences before committing this. This patch made no difference to the code coverage. On closer inspection it turns out beginFunction() isn't being executed so no rules with rule predicates can match. I'll take a look at this, maybe something from the rule-predicates patch didn't make it into the final commit.

Tue, Apr 25, 3:46 AM

Yesterday

rovka committed rL301166: [ARM] GlobalISel: Legalize s8 and s16 G_(S|U)DIV.
[ARM] GlobalISel: Legalize s8 and s16 G_(S|U)DIV
Mon, Apr 24, 2:25 AM
rovka committed rL301164: [ARM] GlobalISel: Support G_(S|U)DIV for s32.
[ARM] GlobalISel: Support G_(S|U)DIV for s32
Mon, Apr 24, 1:33 AM
rovka committed rL301163: [GlobalISel] Legalize G_(S|U)DIV libcalls.
[GlobalISel] Legalize G_(S|U)DIV libcalls
Mon, Apr 24, 12:35 AM

Sun, Apr 23

rovka committed rL301162: [ARM] GlobalISel: Select G_CONSTANT with CImm operands.
[ARM] GlobalISel: Select G_CONSTANT with CImm operands
Sun, Apr 23, 11:43 PM

Fri, Apr 21

rovka committed rL300971: [ARM] GlobalISel: Add support for G_TRUNC.
[ARM] GlobalISel: Add support for G_TRUNC
Fri, Apr 21, 6:29 AM
rovka committed rL300967: [ARM] GlobalISel: Make struct arguments fail elegantly.
[ARM] GlobalISel: Make struct arguments fail elegantly
Fri, Apr 21, 5:06 AM
rovka committed rL300955: Revert r300889, r300906, r300935, r300939.
Revert r300889, r300906, r300935, r300939
Fri, Apr 21, 1:34 AM

Thu, Apr 20

rovka accepted D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc.

I don't see anything wrong with this, I think you can commit it in a couple of days if nobody comes up with a reason why the DiagnosticRenderer shouldn't use FullSourceLoc.

Thu, Apr 20, 5:20 AM
rovka accepted D31418: [globalisel][tablegen] Import SelectionDAG's rule predicates and support the equivalent in GIRule..

LGTM with nits.

Thu, Apr 20, 5:10 AM
rovka committed rL300827: [ARM] Rename HW div feature to HW div Thumb. NFCI..
[ARM] Rename HW div feature to HW div Thumb. NFCI.
Thu, Apr 20, 2:51 AM
rovka closed D32160: [ARM] Rename HW div feature to HW div Thumb. NFCI. by committing rL300827: [ARM] Rename HW div feature to HW div Thumb. NFCI..
Thu, Apr 20, 2:51 AM

Wed, Apr 19

rovka committed rL300665: [ARM] GlobalISel: Add support for G_MUL.
[ARM] GlobalISel: Add support for G_MUL
Wed, Apr 19, 12:42 AM

Tue, Apr 18

rovka committed rL300546: [ARM] GlobalISel: Add support for G_SUB.
[ARM] GlobalISel: Add support for G_SUB
Tue, Apr 18, 5:48 AM
rovka created D32160: [ARM] Rename HW div feature to HW div Thumb. NFCI..
Tue, Apr 18, 3:30 AM
rovka committed rL300536: [ARM] Check for correct HW div when lowering divmod.
[ARM] Check for correct HW div when lowering divmod
Tue, Apr 18, 1:45 AM
rovka closed D32005: [ARM] Check for correct HW div when lowering divmod by committing rL300536: [ARM] Check for correct HW div when lowering divmod.
Tue, Apr 18, 1:45 AM

Thu, Apr 13

rovka added a comment to D32005: [ARM] Check for correct HW div when lowering divmod.

Thanks for the review

Thu, Apr 13, 8:59 AM
rovka added reviewers for D32005: [ARM] Check for correct HW div when lowering divmod: jmolloy, olista01, samparker, compnerd.
Thu, Apr 13, 4:19 AM
rovka updated the summary of D32005: [ARM] Check for correct HW div when lowering divmod.
Thu, Apr 13, 4:17 AM
rovka created D32005: [ARM] Check for correct HW div when lowering divmod.
Thu, Apr 13, 4:14 AM
rovka committed rL300180: Revert "Cache size per class size in SizeClassAllocatorXLocalCache.".
Revert "Cache size per class size in SizeClassAllocatorXLocalCache."
Thu, Apr 13, 12:51 AM

Tue, Apr 11

rovka committed rL299931: GlobalISel: Allow legalizing G_FADD to a libcall.
GlobalISel: Allow legalizing G_FADD to a libcall
Tue, Apr 11, 4:05 AM
rovka accepted D31135: [globalisel][tablegen] Add experimental support for OperandWithDefaultOps, PredicateOperand, and OptionalDefOperand.

LGTM, thanks.

Tue, Apr 11, 3:57 AM
rovka committed rL299928: Revert "Turn some C-style vararg into variadic templates".
Revert "Turn some C-style vararg into variadic templates"
Tue, Apr 11, 3:20 AM

Mon, Apr 10

rovka committed rL299841: [ARM] GlobalISel: Support G_FPOW for float and double.
[ARM] GlobalISel: Support G_FPOW for float and double
Mon, Apr 10, 2:40 AM

Fri, Apr 7

rovka committed rL299761: [ARM] GlobalISel: Test hard float properly.
[ARM] GlobalISel: Test hard float properly
Fri, Apr 7, 5:17 AM
rovka committed rL299756: [ARM] GlobalISel: Support frem for 64-bit values.
[ARM] GlobalISel: Support frem for 64-bit values
Fri, Apr 7, 4:02 AM
rovka committed rL299753: [ARM] GlobalISel: Support frem for 32-bit values.
[ARM] GlobalISel: Support frem for 32-bit values
Fri, Apr 7, 2:54 AM

Mon, Apr 3

rovka added inline comments to D31135: [globalisel][tablegen] Add experimental support for OperandWithDefaultOps, PredicateOperand, and OptionalDefOperand.
Mon, Apr 3, 9:28 AM
rovka accepted D31054: [globalisel][tablegen] Fix patterns involving multiple ComplexPatterns..

LGTM.

Mon, Apr 3, 7:14 AM

Fri, Mar 31

rovka added inline comments to D30539: [tablegen][globalisel] Add support for nested instruction matching..
Fri, Mar 31, 8:16 AM

Thu, Mar 30

rovka added a comment to D30299: [tablegen] Optionally format tablegen targets with clang-format.

Hi Daniel,

That's interesting.
I am a bit concerned about making GISel special in terms of how the output looks. I can see the argument but I am also wondering if we don't what to have a control on that. For instance, in SDISel, each entry in the array is on its own line and clang-format could break that.

Is that the case for many of the files that we generate? If not, maybe we can make it opt-out instead?
Alternatively, clang-format accepts some configuration options, is there any combination of those that would make the output of SDISel look ok when clang-formatted?

Thu, Mar 30, 4:41 AM

Mar 23 2017

rovka accepted D30973: [GlobalISel][X86] Support G_STORE/G_LOAD operation.

Could you commit the unrelated changes separately (e.g. the space changes and the include reordering)?
Other than that, LGTM.

Mar 23 2017, 3:35 AM

Mar 20 2017

rovka committed rL298254: [GlobalISel] Use the correct calling conv for calls.
[GlobalISel] Use the correct calling conv for calls
Mar 20 2017, 7:52 AM
rovka closed D31039: [GlobalISel] Use the correct calling conv for calls by committing rL298254: [GlobalISel] Use the correct calling conv for calls.
Mar 20 2017, 7:52 AM

Mar 17 2017

rovka updated the diff for D31039: [GlobalISel] Use the correct calling conv for calls.

Thanks for reviewing!

Mar 17 2017, 3:06 AM

Mar 16 2017

rovka created D31039: [GlobalISel] Use the correct calling conv for calls.
Mar 16 2017, 10:16 AM
rovka accepted D30535: [tablegen][globalisel] Capture instructions into locals and related infrastructure for multiple instructions matches..

LGTM.

Mar 16 2017, 9:14 AM

Mar 14 2017

rovka added a comment to D30535: [tablegen][globalisel] Capture instructions into locals and related infrastructure for multiple instructions matches..

I think this looks ok overall, just a few nits.

Mar 14 2017, 6:20 AM

Mar 13 2017

rovka accepted D30531: [tablegen][globalisel] Trivial changes to reduce size of following patch. NFC..

LGTM.

Mar 13 2017, 10:51 AM
rovka committed rL297621: [ARM] GlobalISel: Support SP in regbankselect.
[ARM] GlobalISel: Support SP in regbankselect
Mar 13 2017, 7:40 AM

Mar 1 2017

rovka committed rL296634: clang-format r296631.
clang-format r296631
Mar 1 2017, 8:06 AM
rovka committed rL296631: [ARM] GlobalISel: Lower call params that need extensions.
[ARM] GlobalISel: Lower call params that need extensions
Mar 1 2017, 7:47 AM

Feb 28 2017

rovka committed rL296473: [ARM] GlobalISel: Lower i32 and fp call parameters on the stack.
[ARM] GlobalISel: Lower i32 and fp call parameters on the stack
Feb 28 2017, 6:29 AM
rovka committed rL296471: [ARM] GlobalISel: Select 32-bit G_CONSTANT.
[ARM] GlobalISel: Select 32-bit G_CONSTANT
Feb 28 2017, 5:17 AM
rovka committed rL296469: [ARM] GlobalISel: Add mapping for G_CONSTANT.
[ARM] GlobalISel: Add mapping for G_CONSTANT
Feb 28 2017, 4:25 AM
rovka committed rL296468: [ARM] GlobalISel: Legalize 32-bit constants.
[ARM] GlobalISel: Legalize 32-bit constants
Feb 28 2017, 3:45 AM
rovka committed rL296462: [ARM] GlobalISel: Select G_GEP.
[ARM] GlobalISel: Select G_GEP
Feb 28 2017, 2:26 AM
rovka committed rL296455: [ARM] GlobalISel: Add reg bank mapping for G_GEP.
[ARM] GlobalISel: Add reg bank mapping for G_GEP
Feb 28 2017, 1:47 AM
rovka committed rL296452: [ARM] GlobalISel: Legalize G_GEP with 32-bit offsets.
[ARM] GlobalISel: Legalize G_GEP with 32-bit offsets
Feb 28 2017, 1:14 AM

Feb 24 2017

rovka committed rL296122: [ARM] GlobalISel: Select G_STORE.
[ARM] GlobalISel: Select G_STORE
Feb 24 2017, 6:13 AM
rovka committed rL296120: Minor test fix.
Minor test fix
Feb 24 2017, 5:39 AM
rovka committed rL296115: [ARM] GlobalISel: Add reg bank mappings for stores.
[ARM] GlobalISel: Add reg bank mappings for stores
Feb 24 2017, 5:19 AM
rovka committed rL296111: Fixup r296105 - only run tests on Mips.
Fixup r296105 - only run tests on Mips
Feb 24 2017, 4:59 AM
rovka committed rL296108: [ARM] GlobalISel: Legalize stores.
[ARM] GlobalISel: Legalize stores
Feb 24 2017, 3:40 AM
rovka committed rL296104: Revert "[ARM] GlobalISel: Legalize stores".
Revert "[ARM] GlobalISel: Legalize stores"
Feb 24 2017, 2:47 AM
rovka committed rL296103: [ARM] GlobalISel: Legalize stores.
[ARM] GlobalISel: Legalize stores
Feb 24 2017, 2:31 AM

Feb 23 2017

rovka accepted D29712: [globalisel] Decouple src pattern operands from dst pattern operands..

LGTM.

Feb 23 2017, 8:29 AM
rovka accepted D29711: [globalisel] Sort RuleMatchers by priority..

I don't see anything wrong with it, I think it's ok to iterate on the ordering and other tricky parts in tree.

Feb 23 2017, 8:13 AM
rovka committed rL295973: [ARM] GlobalISel: Lower call returns.
[ARM] GlobalISel: Lower call returns
Feb 23 2017, 6:30 AM
rovka committed rL295971: [ARM] GlobalISel: Lower call parameters in regs.
[ARM] GlobalISel: Lower call parameters in regs
Feb 23 2017, 5:37 AM

Feb 22 2017

rovka added a comment to D30047: [GlobalISel] Split LowLevelType to a fundamental type in libSupport..

Ok, let's go with the standalone method. I'd like to give it a more descriptive name though seeing as it's in the llvm namespace. How about getLLTForType()?

For the header name, I agree with not having LowLevelTypes.h in both libraries. Let's go with GlobalISel/Utils.h.

Feb 22 2017, 1:05 AM

Feb 21 2017

rovka added a comment to D30047: [GlobalISel] Split LowLevelType to a fundamental type in libSupport..

I've been trying to preserve the current style of LLT usage but having seen this I realize there's no need to do that.

I think we should make llvm::getLLT() a member of Type (see example usage below and https://reviews.llvm.org/differential/diff/88897/) but aside from that and a couple nits I think this seems like a reasonable way to fix the layering problem.

Feb 21 2017, 6:43 AM
rovka accepted D29953: [ARM] Classification Improvements to ARM Sched-Models. NFCI..

Thanks, Javed. LGTM.

Feb 21 2017, 4:23 AM
rovka committed rL295716: [ARM] GlobalISel: Lower calls to void() functions.
[ARM] GlobalISel: Lower calls to void() functions
Feb 21 2017, 3:45 AM

Feb 20 2017

rovka committed rL295667: Revert "[tsan] Provide external tags (object types) via debugging API".
Revert "[tsan] Provide external tags (object types) via debugging API"
Feb 20 2017, 7:38 AM
rovka committed rL295662: [ARM] GlobalISel: Don't select atomic loads.
[ARM] GlobalISel: Don't select atomic loads
Feb 20 2017, 6:57 AM

Feb 17 2017

rovka committed rL295446: [ARM] GlobalISel: Clean up some helpers.
[ARM] GlobalISel: Clean up some helpers
Feb 17 2017, 5:55 AM
rovka committed rL295441: [ARM] GlobalISel: Check mappings used by reg bank select.
[ARM] GlobalISel: Check mappings used by reg bank select
Feb 17 2017, 5:26 AM
rovka committed rL295439: [ARM] GlobalISel: Use Subtarget in Legalizer.
[ARM] GlobalISel: Use Subtarget in Legalizer
Feb 17 2017, 3:37 AM
rovka committed rL295438: [ARM] GlobalISel: Add end-to-end tests for double.
[ARM] GlobalISel: Add end-to-end tests for double
Feb 17 2017, 3:36 AM

Feb 16 2017

rovka accepted D29816: [X86][GlobalISel] Initial implementation , select G_ADD gpr, gpr.

LGTM in general. Should you also add tests for s64?

Feb 16 2017, 8:11 AM
rovka added a comment to D29953: [ARM] Classification Improvements to ARM Sched-Models. NFCI..

Could you also add tests for some of the other instructions, like t2SDIV, t2LDR etc? Or are they already covered elsewhere?

Feb 16 2017, 7:26 AM
rovka committed rL295321: [ARM] GlobalISel: Select floating point loads.
[ARM] GlobalISel: Select floating point loads
Feb 16 2017, 6:22 AM
rovka committed rL295310: [ARM] GlobalISel: Select G_SEQUENCE and G_EXTRACT.
[ARM] GlobalISel: Select G_SEQUENCE and G_EXTRACT
Feb 16 2017, 4:31 AM
rovka committed rL295309: [ARM] GlobalISel: Select double G_FADD and copies.
[ARM] GlobalISel: Select double G_FADD and copies
Feb 16 2017, 4:31 AM
rovka committed rL295308: [ARM] GlobalISel: Assert that we don't use the FPR bank if we don't have VFP.
[ARM] GlobalISel: Assert that we don't use the FPR bank if we don't have VFP
Feb 16 2017, 3:36 AM
rovka committed rL295306: [ARM] GlobalISel: Add reg bank mappings for G_SEQUENCE and G_EXTRACT.
[ARM] GlobalISel: Add reg bank mappings for G_SEQUENCE and G_EXTRACT
Feb 16 2017, 3:12 AM
rovka committed rL295302: [ARM] GlobalISel: Make the FPR bank 64-bit wide.
[ARM] GlobalISel: Make the FPR bank 64-bit wide
Feb 16 2017, 2:24 AM
rovka committed rL295300: [ARM] GlobalISel: Legalize 64-bit G_FADD and G_LOAD.
[ARM] GlobalISel: Legalize 64-bit G_FADD and G_LOAD
Feb 16 2017, 1:21 AM
rovka committed rL295295: [ARM] GlobalISel: Lower double precision FP args.
[ARM] GlobalISel: Lower double precision FP args
Feb 16 2017, 12:06 AM

Feb 10 2017

rovka added a comment to D29623: [ARM] Replace HasT2ExtractPack with HasDSP.

This looks mechanically sound to me, and I'm always in favor of removing subtarget features if we don't really need them. That being said, I'd appreciate it if someone that knows more about these extensions gave the final ok.

Feb 10 2017, 6:49 AM
rovka added inline comments to D29712: [globalisel] Decouple src pattern operands from dst pattern operands..
Feb 10 2017, 5:25 AM

Feb 9 2017

rovka added inline comments to D29711: [globalisel] Sort RuleMatchers by priority..
Feb 9 2017, 8:11 AM
rovka added a comment to D29711: [globalisel] Sort RuleMatchers by priority..

Is this NFC in general, or just NFC with regards to the existing AArch64 description? More to the point, is it possible to concoct a useful test case that would fail without this ordering?

Feb 9 2017, 6:22 AM
rovka added a comment to D29711: [globalisel] Sort RuleMatchers by priority..

Hi Daniel,

Feb 9 2017, 6:12 AM
rovka committed rL294584: [ARM] GlobalISel: Lower single precision FP args.
[ARM] GlobalISel: Lower single precision FP args
Feb 9 2017, 5:21 AM

Feb 8 2017

rovka added inline comments to D29710: [globalisel] OperandPredicateMatcher's shouldn't need to generate the MachineOperand expr. NFC.
Feb 8 2017, 7:45 AM
rovka committed rL294451: Fix test to work on swift/cyclone too.
Fix test to work on swift/cyclone too
Feb 8 2017, 6:35 AM
rovka committed rL294448: Revert "[Assembler] Enable nicer diagnostics for inline assembly.".
Revert "[Assembler] Enable nicer diagnostics for inline assembly."
Feb 8 2017, 6:13 AM
rovka committed rL294446: Move test from r294430 to target-specific directory.
Move test from r294430 to target-specific directory
Feb 8 2017, 5:59 AM
rovka committed rL294442: [ARM] GlobalISel: Add FPR reg bank.
[ARM] GlobalISel: Add FPR reg bank
Feb 8 2017, 5:34 AM

Feb 6 2017

rovka committed rL294180: Revert "[AVR] Allow specifying the CPU on the command line".
Revert "[AVR] Allow specifying the CPU on the command line"
Feb 6 2017, 3:47 AM

Feb 2 2017

rovka committed rL293889: [ARM] GlobalISel: Lower pointer args and returns.
[ARM] GlobalISel: Lower pointer args and returns
Feb 2 2017, 6:12 AM
rovka committed rL293888: [ARM] GlobalISel: Error out instead of asserting.
[ARM] GlobalISel: Error out instead of asserting
Feb 2 2017, 6:12 AM
rovka committed rL293886: [ARM] GlobalISel: Legalize loading pointers.
[ARM] GlobalISel: Legalize loading pointers
Feb 2 2017, 5:32 AM
rovka committed rL293883: [ARM] GlobalISel: Test default banks for load results. NFC..
[ARM] GlobalISel: Test default banks for load results. NFC.
Feb 2 2017, 5:11 AM
rovka accepted D29127: [ARM] Classification Improvements to ARM Sched-Model. NFCI..

Thanks, Javed. LGTM now.

Feb 2 2017, 4:19 AM

Feb 1 2017

rovka edited reviewers for D29380: [ARM] const cast fix for ARMAttributeParser test, added: mkuper; removed: rovka.
Feb 1 2017, 4:37 AM