Page MenuHomePhabricator

rovka (Diana Picus)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2016, 3:27 AM (173 w, 5 d)

Recent Activity

Thu, Aug 1

rovka added a comment to D53137: Scalable vector core instruction support + size queries.

Several more general comments:

  • Should all the getXSize assert when called on a scalable type? I see that for MVT::getSizeInBits and for Type::getPrimitiveSize, but not for the others. This should also be made clear in the comments for each of them.
  • Great test for the IR, thanks!
  • I don't see any test for the CodeGen stuff though. Is it possible to add one? (If not, maybe add the changes to EVT etc when we can actually test them).
  • Ditto for TableGen (or if that's too difficult/hairy to test, just update the commit message to explain exactly why the change belongs in this patch).
Thu, Aug 1, 5:01 AM · Restricted Project

Wed, Jul 31

rovka committed rG7117881fdb2f: [docs] Add cmake to Software requirements (authored by rovka).
[docs] Add cmake to Software requirements
Wed, Jul 31, 1:49 AM
rovka committed rL367395: [docs] Add cmake to Software requirements.
[docs] Add cmake to Software requirements
Wed, Jul 31, 1:49 AM
rovka closed D65438: [docs] Add cmake to Software requirements.
Wed, Jul 31, 1:49 AM · Restricted Project

Tue, Jul 30

rovka created D65438: [docs] Add cmake to Software requirements.
Tue, Jul 30, 4:49 AM · Restricted Project
rovka added a comment to D65436: [docs] Add note about git version to git-llvm section.

Some people might be interested just in compiling LLVM (e.g. fetching some release sources from releases.llvm.org and building them). We should probably keep the package list here focused on that. If we want to add git at all, we should probably mention it somewhere else. I'm not sure where that would be - I suppose somewhere where it makes sense to worry about the minimum version, e.g. where the git-llvm script is concerned. Do we have any other reason to bind ourselves to a certain minimum version of git?

Tue, Jul 30, 4:32 AM · Restricted Project, Restricted Project

Fri, Jul 26

rovka accepted D65321: [MIPS GlobalISel] Fix check for void return during lowerCall.

LGTM

Fri, Jul 26, 1:09 AM · Restricted Project

Tue, Jul 23

rovka added a comment to D53137: Scalable vector core instruction support + size queries.

Hi Diana,

Thanks for the comments.

I think this patch is difficult to review. It covers many different source files with only a small unit test to check the correctness. This isn't very robust against future changes and it makes it hard to know exactly what is and isn't supported.

Yeah, I was worried about that -- this is basically the size queries alone without anything actually using scalable vectors. It demonstrates roughly where changes will be needed, but doesn't actually change the surrounding code to use e.g. getElementCount instead of getNumElements.

I would find it much easier to review with an incremental strategy based on regression tests. For instance, with ToT opt, the attached testcase fails (error: '%r' defined with type '<4 x i1>' but expected '<vscale x 4 x i1>'). I would add a patch to fix that, and maybe other similar, really simple cases. We could then proceed to more complex examples, run some of the passes that come after the vectorizer on them, and progressively fix the places required to make them pass, with focused tests for each hurdle that we run into. It shouldn't be too hard to reduce such snippets from the tests you've already been running.

An incremental approach sounds good; assuming nobody objects, I'll remove most of the code in this patch and just leave the core mechanism behind (in enforcing mode) and add in that test case. We can fill in the other cases as we enable codegen/acle/autovec in separate patches.

Tue, Jul 23, 4:21 AM · Restricted Project
rovka added a comment to D53137: Scalable vector core instruction support + size queries.

Hi Graham,

Tue, Jul 23, 2:22 AM · Restricted Project

Mon, Jul 22

rovka added inline comments to D64739: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list.
Mon, Jul 22, 3:45 AM · Restricted Project, Restricted Project

Jul 19 2019

rovka added a comment to D62960: Add SVE opaque built-in types.

FWIW, I think the tests look great. Would be nice if someone more experienced with clang could also have a look though.

Jul 19 2019, 2:41 AM · Restricted Project, Restricted Project

Jul 18 2019

rovka added inline comments to D64739: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list.
Jul 18 2019, 2:51 AM · Restricted Project, Restricted Project
rovka committed rGf26706fa1c15: Fixup r366333 (require x86 in test) (authored by rovka).
Fixup r366333 (require x86 in test)
Jul 18 2019, 1:32 AM
rovka committed rL366416: Fixup r366333 (require x86 in test).
Fixup r366333 (require x86 in test)
Jul 18 2019, 1:32 AM

Jul 17 2019

rovka committed rG37e403d18c1a: [ARM GlobalISel] Cleanup CallLowering. NFC (authored by rovka).
[ARM GlobalISel] Cleanup CallLowering. NFC
Jul 17 2019, 3:06 AM
rovka committed rL366308: [ARM GlobalISel] Cleanup CallLowering. NFC.
[ARM GlobalISel] Cleanup CallLowering. NFC
Jul 17 2019, 3:05 AM

Jul 15 2019

rovka committed rG0bf0b8ff7c7e: [libFuzzer] Disable fork.test on AArch64 (authored by rovka).
[libFuzzer] Disable fork.test on AArch64
Jul 15 2019, 4:35 AM
rovka committed rL366055: [libFuzzer] Disable fork.test on AArch64.
[libFuzzer] Disable fork.test on AArch64
Jul 15 2019, 4:35 AM

Jul 2 2019

rovka added a comment to D62960: Add SVE opaque built-in types.

This looks much better, thanks! Shouldn't there be more tests, e.g. for mangling and maybe the ASTImporter?

Jul 2 2019, 3:23 AM · Restricted Project, Restricted Project

Jul 1 2019

rovka added a comment to D63905: Fix ASAN error caused by commit r364512.

Thanks, committed in r364778!

Jul 1 2019, 8:16 AM · Restricted Project
rovka committed rG2ba16011c139: Fixup r364512 (authored by rovka).
Fixup r364512
Jul 1 2019, 8:10 AM
rovka committed rL364778: Fixup r364512.
Fixup r364512
Jul 1 2019, 8:08 AM

Jun 28 2019

rovka added a comment to D63905: Fix ASAN error caused by commit r364512.

Looks good to me, please commit

(@rovka - this is at least a short-term fix, I'm approving this to unbreak LLVM's mainline - feel free to refix with other ideas if you have any (also happy to discuss this further with you here, IRC, or elsewhere on the mailing lists)

Jun 28 2019, 3:08 AM · Restricted Project

Jun 27 2019

rovka added a comment to D62960: Add SVE opaque built-in types.

Just a few nits/suggestions.

Jun 27 2019, 4:59 AM · Restricted Project, Restricted Project
rovka committed rG74a50a723bfd: [GlobalISel] Remove [un]packRegs from IRTranslator (authored by rovka).
[GlobalISel] Remove [un]packRegs from IRTranslator
Jun 27 2019, 2:50 AM
rovka committed rL364514: [GlobalISel] Remove [un]packRegs from IRTranslator.
[GlobalISel] Remove [un]packRegs from IRTranslator
Jun 27 2019, 2:49 AM
rovka committed rG253b53b2ecf6: [AArch64 GlobalISel] Cleanup CallLowering. NFCI (authored by rovka).
[AArch64 GlobalISel] Cleanup CallLowering. NFCI
Jun 27 2019, 2:27 AM
rovka committed rL364513: [AArch64 GlobalISel] Cleanup CallLowering. NFCI.
[AArch64 GlobalISel] Cleanup CallLowering. NFCI
Jun 27 2019, 2:26 AM
rovka closed D63552: [AArch64 GlobalISel] Cleanup CallLowering. NFCI.
Jun 27 2019, 2:26 AM · Restricted Project
rovka committed rG43fb5ae50c53: [GlobalISel] Accept multiple vregs for lowerCall's args (authored by rovka).
[GlobalISel] Accept multiple vregs for lowerCall's args
Jun 27 2019, 2:21 AM
rovka committed rL364512: [GlobalISel] Accept multiple vregs for lowerCall's args.
[GlobalISel] Accept multiple vregs for lowerCall's args
Jun 27 2019, 2:21 AM
rovka committed rG8138996128cd: [GlobalISel] Accept multiple vregs for lowerCall's result (authored by rovka).
[GlobalISel] Accept multiple vregs for lowerCall's result
Jun 27 2019, 2:21 AM
rovka committed rL364511: [GlobalISel] Accept multiple vregs for lowerCall's result.
[GlobalISel] Accept multiple vregs for lowerCall's result
Jun 27 2019, 2:21 AM
rovka closed D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments.
Jun 27 2019, 2:21 AM · Restricted Project
rovka closed D63550: [GlobalISel] Accept multiple vregs for lowerCall's result.
Jun 27 2019, 2:21 AM · Restricted Project
rovka committed rGc3dbe2397792: [GlobalISel] Accept multiple vregs in lowerFormalArgs (authored by rovka).
[GlobalISel] Accept multiple vregs in lowerFormalArgs
Jun 27 2019, 1:55 AM
rovka committed rL364510: [GlobalISel] Accept multiple vregs in lowerFormalArgs.
[GlobalISel] Accept multiple vregs in lowerFormalArgs
Jun 27 2019, 1:55 AM
rovka closed D63549: [GlobalISel] Accept multiple vregs in lowerFormalArgs.
Jun 27 2019, 1:54 AM · Restricted Project
rovka committed rG69ce1c131963: [GlobalISel] Allow multiple VRegs in ArgInfo. NFC (authored by rovka).
[GlobalISel] Allow multiple VRegs in ArgInfo. NFC
Jun 27 2019, 1:52 AM
rovka committed rL364509: [GlobalISel] Allow multiple VRegs in ArgInfo. NFC.
[GlobalISel] Allow multiple VRegs in ArgInfo. NFC
Jun 27 2019, 1:51 AM
rovka closed D63548: [GlobalISel] Allow multiple VRegs in ArgInfo. NFC.
Jun 27 2019, 1:51 AM · Restricted Project

Jun 25 2019

rovka added a comment to D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments.

Hi Amara,

Jun 25 2019, 3:43 AM · Restricted Project

Jun 24 2019

rovka added a comment to D63552: [AArch64 GlobalISel] Cleanup CallLowering. NFCI.

Thanks so much for working on these patches Diana! It's tricky business, can you be sure to run test suites thoroughly before committing if you haven't already.

Jun 24 2019, 1:42 AM · Restricted Project
rovka added a comment to D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments.

LGTM too if we remove the last packRegs use and delete the IRTranslator pack/unpackRegs() implementations.

Jun 24 2019, 1:37 AM · Restricted Project

Jun 20 2019

rovka accepted D63585: [ARM GlobalISel] Add support for s64 G_ADD and G_SUB..

LGTM, thanks!

Jun 20 2019, 3:24 AM · Restricted Project
rovka updated the diff for D63552: [AArch64 GlobalISel] Cleanup CallLowering. NFCI.

More context.

Jun 20 2019, 2:38 AM · Restricted Project
rovka updated the diff for D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments.

Thanks for the review! More context for posterity though :)

Jun 20 2019, 2:38 AM · Restricted Project
rovka updated the diff for D63550: [GlobalISel] Accept multiple vregs for lowerCall's result.

More context.

Jun 20 2019, 2:34 AM · Restricted Project
rovka updated the diff for D63549: [GlobalISel] Accept multiple vregs in lowerFormalArgs.

More context.

Jun 20 2019, 2:33 AM · Restricted Project
rovka updated the diff for D63548: [GlobalISel] Allow multiple VRegs in ArgInfo. NFC.

Oops! Fixed :)

Jun 20 2019, 2:33 AM · Restricted Project

Jun 19 2019

rovka retitled D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments from [GlobalISel] Accept multiple vregs for lowerCall's result to [GlobalISel] Accept multiple vregs for lowerCall's arguments.
Jun 19 2019, 7:06 AM · Restricted Project
rovka added a parent revision for D63549: [GlobalISel] Accept multiple vregs in lowerFormalArgs: D63548: [GlobalISel] Allow multiple VRegs in ArgInfo. NFC.
Jun 19 2019, 7:03 AM · Restricted Project
rovka added a child revision for D63548: [GlobalISel] Allow multiple VRegs in ArgInfo. NFC: D63549: [GlobalISel] Accept multiple vregs in lowerFormalArgs.
Jun 19 2019, 7:03 AM · Restricted Project
rovka added a child revision for D63549: [GlobalISel] Accept multiple vregs in lowerFormalArgs: D63550: [GlobalISel] Accept multiple vregs for lowerCall's result.
Jun 19 2019, 7:03 AM · Restricted Project
rovka added a parent revision for D63550: [GlobalISel] Accept multiple vregs for lowerCall's result: D63549: [GlobalISel] Accept multiple vregs in lowerFormalArgs.
Jun 19 2019, 7:03 AM · Restricted Project
rovka added a child revision for D63550: [GlobalISel] Accept multiple vregs for lowerCall's result: D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments.
Jun 19 2019, 7:03 AM · Restricted Project
rovka added a parent revision for D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments: D63550: [GlobalISel] Accept multiple vregs for lowerCall's result.
Jun 19 2019, 7:03 AM · Restricted Project
rovka added a parent revision for D63552: [AArch64 GlobalISel] Cleanup CallLowering. NFCI: D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments.
Jun 19 2019, 7:03 AM · Restricted Project
rovka added a child revision for D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments: D63552: [AArch64 GlobalISel] Cleanup CallLowering. NFCI.
Jun 19 2019, 7:03 AM · Restricted Project
rovka created D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments.
Jun 19 2019, 7:01 AM · Restricted Project
rovka created D63552: [AArch64 GlobalISel] Cleanup CallLowering. NFCI.
Jun 19 2019, 7:01 AM · Restricted Project
rovka created D63550: [GlobalISel] Accept multiple vregs for lowerCall's result.
Jun 19 2019, 6:57 AM · Restricted Project
rovka created D63549: [GlobalISel] Accept multiple vregs in lowerFormalArgs.
Jun 19 2019, 6:54 AM · Restricted Project
rovka created D63548: [GlobalISel] Allow multiple VRegs in ArgInfo. NFC.
Jun 19 2019, 6:51 AM · Restricted Project

May 27 2019

rovka committed rGc675215f6799: [ARM GlobalISel] Un-XFAIL some tests. NFC (authored by rovka).
[ARM GlobalISel] Un-XFAIL some tests. NFC
May 27 2019, 3:31 AM
rovka committed rL361756: [ARM GlobalISel] Un-XFAIL some tests. NFC.
[ARM GlobalISel] Un-XFAIL some tests. NFC
May 27 2019, 3:31 AM
rovka committed rG68b20c589c48: [ARM GlobalISel] Cleanup CallLowering a bit (authored by rovka).
[ARM GlobalISel] Cleanup CallLowering a bit
May 27 2019, 3:31 AM
rovka committed rL361755: [ARM GlobalISel] Cleanup CallLowering a bit.
[ARM GlobalISel] Cleanup CallLowering a bit
May 27 2019, 3:27 AM

May 17 2019

rovka accepted D62000: [AArch64][SVE2] Asm: add int halving add/sub (predicated) instructions.

LGTM but I have one question :)

May 17 2019, 1:35 AM · Restricted Project
rovka accepted D61998: [AArch64][SVE2] Asm: add saturating multiply-add interleaved long instructions.

LGTM

May 17 2019, 1:18 AM · Restricted Project

May 16 2019

rovka accepted D61951: [AArch64][SVE2] Asm: add integer multiply-add long instructions.

LGTM

May 16 2019, 1:25 AM · Restricted Project
rovka accepted D61936: [AArch64][SVE2] Asm: add integer multiply long instructions.

LGTM

May 16 2019, 1:15 AM · Restricted Project

May 15 2019

rovka added a comment to D61903: [AArch64][SVE2] Asm: implement CDOT instruction.

Ah, sorry, didn't noticed the LGTM until I clicked the submit button.

May 15 2019, 1:42 AM · Restricted Project
rovka accepted D61902: [AArch64][SVE2] Asm: add unpredicated integer multiply instructions.

LGTM with minor nits.

May 15 2019, 1:40 AM · Restricted Project
rovka accepted D61903: [AArch64][SVE2] Asm: implement CDOT instruction.

LGTM

May 15 2019, 12:50 AM · Restricted Project

May 14 2019

rovka committed rGa568222ddd4c: [IRTranslator] Don't hardcode GEP index type (authored by rovka).
[IRTranslator] Don't hardcode GEP index type
May 14 2019, 2:24 AM
rovka committed rL360656: [IRTranslator] Don't hardcode GEP index type.
[IRTranslator] Don't hardcode GEP index type
May 14 2019, 2:24 AM
rovka closed D61852: [IRTranslator] Don't hardcode GEP index type.
May 14 2019, 2:24 AM · Restricted Project
rovka accepted D61514: [AArch64][SVE2] Asm: add integer multiply-add/subtract (indexed) instructions.

LGTM

May 14 2019, 1:32 AM · Restricted Project
rovka accepted D61515: [AArch64][SVE2] Asm: add SQRDMLAH/SQRDMLSH instructions.

Ok, thanks for looking into it! LGTM

May 14 2019, 1:32 AM · Restricted Project

May 13 2019

rovka added inline comments to D61289: [globalisel] Add G_SEXT_INREG.
May 13 2019, 5:36 AM · Restricted Project
rovka created D61852: [IRTranslator] Don't hardcode GEP index type.
May 13 2019, 4:18 AM · Restricted Project
rovka added a comment to D61844: ARMDefines.h: fix -Wimplicit-fallthrough in -DLLVM_ENABLE_ASSERTIONS=OFF builds.

Why not remove the default clause and put the unreachable after the switch?

May 13 2019, 1:16 AM · Restricted Project

May 9 2019

rovka committed rG3531453371d8: [ARM GlobalISel] Map DBG_VALUE for types != s32 (authored by rovka).
[ARM GlobalISel] Map DBG_VALUE for types != s32
May 9 2019, 2:48 AM
rovka committed rL360321: [ARM GlobalISel] Map DBG_VALUE for types != s32.
[ARM GlobalISel] Map DBG_VALUE for types != s32
May 9 2019, 2:47 AM

May 8 2019

rovka accepted D61435: [AArch64] NFC: Add generic StackOffset to describe scalable offsets..

LGTM with nits. Thanks!

May 8 2019, 2:19 AM · Restricted Project
rovka accepted D61513: [AArch64][SVE2] Add SVE2 target features to backend and TargetParser.

LGTM also with the remaining comments addressed.

May 8 2019, 1:10 AM · Restricted Project

May 7 2019

rovka committed rG0a47fb888477: [ARM GlobalISel] Widen G_SELECT operands (authored by rovka).
[ARM GlobalISel] Widen G_SELECT operands
May 7 2019, 4:39 AM
rovka committed rL360135: [ARM GlobalISel] Widen G_SELECT operands.
[ARM GlobalISel] Widen G_SELECT operands
May 7 2019, 4:37 AM
rovka added a comment to D61289: [globalisel] Add G_SEXT_INREG.

Thanks for the explanations. I think you have some good points. Overall, it still looks to me like we're complicating things for backend writers and introducing a lot of subtle distinctions to keep in mind. It would be useful to hear what other people think about this.

May 7 2019, 4:35 AM · Restricted Project
rovka committed rGd6d3808fa432: [ARM GlobalISel] Widen G_INTTOPTR/G_PTRTOINT (authored by rovka).
[ARM GlobalISel] Widen G_INTTOPTR/G_PTRTOINT
May 7 2019, 3:48 AM
rovka committed rL360130: [ARM GlobalISel] Widen G_INTTOPTR/G_PTRTOINT.
[ARM GlobalISel] Widen G_INTTOPTR/G_PTRTOINT
May 7 2019, 3:45 AM
rovka committed rGd18bac5d190c: [ARM GlobalISel] Widen G_GEP index operand (authored by rovka).
[ARM GlobalISel] Widen G_GEP index operand
May 7 2019, 3:11 AM
rovka committed rL360127: [ARM GlobalISel] Widen G_GEP index operand.
[ARM GlobalISel] Widen G_GEP index operand
May 7 2019, 3:10 AM

May 6 2019

rovka added inline comments to D61515: [AArch64][SVE2] Asm: add SQRDMLAH/SQRDMLSH instructions.
May 6 2019, 3:30 AM · Restricted Project
rovka added inline comments to D61513: [AArch64][SVE2] Add SVE2 target features to backend and TargetParser.
May 6 2019, 2:14 AM · Restricted Project

May 3 2019

rovka added a comment to D61435: [AArch64] NFC: Add generic StackOffset to describe scalable offsets..

I'd also add a unit test for StackOffset.

May 3 2019, 4:05 AM · Restricted Project

May 2 2019

rovka added inline comments to D61289: [globalisel] Add G_SEXT_INREG.
May 2 2019, 5:18 AM · Restricted Project
rovka committed rG1136ea2d446d: [ARM GlobalISel] Fixup r359768 (authored by rovka).
[ARM GlobalISel] Fixup r359768
May 2 2019, 3:08 AM
rovka committed rL359772: [ARM GlobalISel] Fixup r359768.
[ARM GlobalISel] Fixup r359768
May 2 2019, 3:08 AM