Page MenuHomePhabricator

arcbbb (ShihPo Hung)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 25 2019, 1:09 AM (60 w, 2 d)

Recent Activity

Today

arcbbb requested review of D95028: [RISCV] Add intrinsics for vector unordered indexed loads in RVV 1.0.
Wed, Jan 20, 1:13 AM · Restricted Project

Yesterday

arcbbb updated the diff for D95014: [RISCV] Add intrinsics for vrgatherei16 instruction.
Tue, Jan 19, 11:12 PM · Restricted Project
arcbbb committed rG4dae2247fd62: [RISCV] refactor VPatBinary (NFC) (authored by arcbbb).
[RISCV] refactor VPatBinary (NFC)
Tue, Jan 19, 7:17 PM
arcbbb closed D94951: [RISCV] refactor VPatBinary (NFC).
Tue, Jan 19, 7:17 PM · Restricted Project
arcbbb added a comment to D94951: [RISCV] refactor VPatBinary (NFC).

I'm not sure I understand what's special about vrgathere16 that needs this refactor. Can you provide an explanation?

Tue, Jan 19, 6:28 PM · Restricted Project
arcbbb requested review of D95014: [RISCV] Add intrinsics for vrgatherei16 instruction.
Tue, Jan 19, 6:22 PM · Restricted Project
arcbbb requested review of D94951: [RISCV] refactor VPatBinary (NFC).
Tue, Jan 19, 12:34 AM · Restricted Project

Mon, Jan 18

arcbbb committed rG9cf511aa08ae: [RISCV] Add intrinsics for vector AMO operations (authored by arcbbb).
[RISCV] Add intrinsics for vector AMO operations
Mon, Jan 18, 11:12 PM
arcbbb closed D94589: [RISCV] Add intrinsics for vector AMO instructions.
Mon, Jan 18, 11:12 PM · Restricted Project

Sun, Jan 17

arcbbb updated the diff for D94589: [RISCV] Add intrinsics for vector AMO instructions.

changed sra to srl

Sun, Jan 17, 6:43 PM · Restricted Project

Sat, Jan 16

arcbbb added inline comments to D94589: [RISCV] Add intrinsics for vector AMO instructions.
Sat, Jan 16, 4:49 AM · Restricted Project
arcbbb updated the diff for D94589: [RISCV] Add intrinsics for vector AMO instructions.
  1. fix value type to match result type
  2. share octuple utility function with vlxei & vsxei patterns
Sat, Jan 16, 4:46 AM · Restricted Project

Thu, Jan 14

arcbbb added a comment to D94589: [RISCV] Add intrinsics for vector AMO instructions.
In D94589#2498139, @asb wrote:

Nitpick: this would be better titled "[RISCV] Add intrinsics for vector AMO instructions" - I was a little confused seeing the title come past :)

Thu, Jan 14, 9:08 AM · Restricted Project
arcbbb retitled D94589: [RISCV] Add intrinsics for vector AMO instructions from [RISCV] Add intrinsics for AMO instructions to [RISCV] Add intrinsics for vector AMO instructions.
Thu, Jan 14, 9:07 AM · Restricted Project
arcbbb updated the diff for D94589: [RISCV] Add intrinsics for vector AMO instructions.

add double type for vamoswap-rv32.ll

Thu, Jan 14, 1:06 AM · Restricted Project

Wed, Jan 13

arcbbb updated the diff for D94589: [RISCV] Add intrinsics for vector AMO instructions.

address @khchen's comment

Wed, Jan 13, 6:27 PM · Restricted Project
arcbbb added inline comments to D94589: [RISCV] Add intrinsics for vector AMO instructions.
Wed, Jan 13, 6:16 PM · Restricted Project
arcbbb requested review of D94589: [RISCV] Add intrinsics for vector AMO instructions.
Wed, Jan 13, 4:16 AM · Restricted Project

Tue, Dec 29

arcbbb committed rG096b02ebbff7: [RISCV] Add intrinsics for vcompress instruction (authored by arcbbb).
[RISCV] Add intrinsics for vcompress instruction
Tue, Dec 29, 6:43 PM
arcbbb closed D93809: [RISCV] Add intrinsics for vcompress instruction.
Tue, Dec 29, 6:43 PM · Restricted Project

Mon, Dec 28

arcbbb added inline comments to D93809: [RISCV] Add intrinsics for vcompress instruction.
Mon, Dec 28, 1:38 AM · Restricted Project

Fri, Dec 25

arcbbb updated the diff for D93809: [RISCV] Add intrinsics for vcompress instruction.

rebased.

Fri, Dec 25, 10:40 AM · Restricted Project
arcbbb requested review of D93809: [RISCV] Add intrinsics for vcompress instruction.
Fri, Dec 25, 12:31 AM · Restricted Project

Thu, Dec 24

arcbbb committed rG912740a864fe: [RISCV] Add intrinsics for vrgather instruction (authored by arcbbb).
[RISCV] Add intrinsics for vrgather instruction
Thu, Dec 24, 6:24 PM
arcbbb closed D93797: [RISCV] Add intrinsics for vrgather instruction.
Thu, Dec 24, 6:24 PM · Restricted Project
arcbbb requested review of D93797: [RISCV] Add intrinsics for vrgather instruction.
Thu, Dec 24, 1:14 AM · Restricted Project

Wed, Dec 23

arcbbb committed rG6301871d06d6: [RISCV] Add intrinsics for vfwmacc, vfwnmacc, vfwmsac, vfwnmsac instructions (authored by arcbbb).
[RISCV] Add intrinsics for vfwmacc, vfwnmacc, vfwmsac, vfwnmsac instructions
Wed, Dec 23, 12:47 AM
arcbbb closed D93693: [RISCV] Add intrinsics for vfwmacc, vfwnmacc, vfwmsac, vfwnmsac instructions.
Wed, Dec 23, 12:47 AM · Restricted Project

Tue, Dec 22

arcbbb updated the diff for D93693: [RISCV] Add intrinsics for vfwmacc, vfwnmacc, vfwmsac, vfwnmsac instructions.

Updates

  1. rebased
  2. remove unneeded !eq
  3. use true/false instead of 1/0
Tue, Dec 22, 6:49 PM · Restricted Project
arcbbb committed rGad0a7ad950fe: [RISCV] Add intrinsics for vf[n]macc/vf[n]msac/vf[n]madd/vf[n]msub instructions (authored by arcbbb).
[RISCV] Add intrinsics for vf[n]macc/vf[n]msac/vf[n]madd/vf[n]msub instructions
Tue, Dec 22, 6:35 PM
arcbbb closed D93691: [RISCV] Add intrinsics for vf[n]macc/vf[n]msac/vf[n]madd/vf[n]msub instructions.
Tue, Dec 22, 6:35 PM · Restricted Project
arcbbb committed rG426878399803: [RISCV] Add intrinsics for vwmacc[u|su|us] instructions (authored by arcbbb).
[RISCV] Add intrinsics for vwmacc[u|su|us] instructions
Tue, Dec 22, 6:24 PM
arcbbb closed D93675: [RISCV] Add intrinsics for vwmacc[u|su|us] instructions.
Tue, Dec 22, 6:24 PM · Restricted Project
arcbbb committed rGc8874464b5f6: [RISCV] Add intrinsics for vslide1up/down, vfslide1up/down instruction (authored by arcbbb).
[RISCV] Add intrinsics for vslide1up/down, vfslide1up/down instruction
Tue, Dec 22, 6:14 PM
arcbbb closed D93608: [RISCV] Add intrinsics for vslide1up/down, vfslide1up/down instruction.
Tue, Dec 22, 6:14 PM · Restricted Project
arcbbb updated the diff for D93608: [RISCV] Add intrinsics for vslide1up/down, vfslide1up/down instruction.

rebased

Tue, Dec 22, 5:52 AM · Restricted Project
arcbbb requested review of D93693: [RISCV] Add intrinsics for vfwmacc, vfwnmacc, vfwmsac, vfwnmsac instructions.
Tue, Dec 22, 5:40 AM · Restricted Project
arcbbb requested review of D93691: [RISCV] Add intrinsics for vf[n]macc/vf[n]msac/vf[n]madd/vf[n]msub instructions.
Tue, Dec 22, 5:04 AM · Restricted Project
arcbbb requested review of D93675: [RISCV] Add intrinsics for vwmacc[u|su|us] instructions.
Tue, Dec 22, 1:29 AM · Restricted Project

Mon, Dec 21

arcbbb updated the diff for D93608: [RISCV] Add intrinsics for vslide1up/down, vfslide1up/down instruction.

updated again

Mon, Dec 21, 10:49 PM · Restricted Project
arcbbb updated the diff for D93608: [RISCV] Add intrinsics for vslide1up/down, vfslide1up/down instruction.

Updates the tests and earlyclobber takes effect.

Mon, Dec 21, 10:28 PM · Restricted Project
arcbbb added inline comments to D93608: [RISCV] Add intrinsics for vslide1up/down, vfslide1up/down instruction.
Mon, Dec 21, 10:20 PM · Restricted Project
arcbbb updated the diff for D93608: [RISCV] Add intrinsics for vslide1up/down, vfslide1up/down instruction.

Updates:

  1. Fixed missing earlyclobber for VSLIDE1UP pseudos
  2. Added missing Predicate for VSLIDE pseudos
  3. updated tests with update_llc_test_checks.py
Mon, Dec 21, 7:28 PM · Restricted Project
arcbbb committed rGb15ba2cf6fde: [RISCV] Add intrinsics for vmacc/vnmsac/vmadd/vnmsub instructions (authored by arcbbb).
[RISCV] Add intrinsics for vmacc/vnmsac/vmadd/vnmsub instructions
Mon, Dec 21, 5:38 PM
arcbbb closed D93632: [RISCV] Add intrinsics for vmacc/vnmsac/vmadd/vnmsub instructions.
Mon, Dec 21, 5:38 PM · Restricted Project

Dec 21 2020

arcbbb updated the diff for D93608: [RISCV] Add intrinsics for vslide1up/down, vfslide1up/down instruction.

Fixed test failures.

Dec 21 2020, 6:43 AM · Restricted Project
arcbbb updated the diff for D93632: [RISCV] Add intrinsics for vmacc/vnmsac/vmadd/vnmsub instructions.

Added missing ExtendOperand definition.

Dec 21 2020, 6:39 AM · Restricted Project
arcbbb requested review of D93632: [RISCV] Add intrinsics for vmacc/vnmsac/vmadd/vnmsub instructions.
Dec 21 2020, 6:19 AM · Restricted Project

Dec 20 2020

arcbbb requested review of D93608: [RISCV] Add intrinsics for vslide1up/down, vfslide1up/down instruction.
Dec 20 2020, 7:40 PM · Restricted Project
arcbbb committed rGd86a00d8febd: [RISCV] Define vslideup/vslidedown intrinsics (authored by arcbbb).
[RISCV] Define vslideup/vslidedown intrinsics
Dec 20 2020, 5:09 AM
arcbbb closed D93286: [RISCV] Define vslideup/vslidedown intrinsics and lower to V instructions..
Dec 20 2020, 5:09 AM · Restricted Project

Dec 17 2020

arcbbb updated the diff for D93286: [RISCV] Define vslideup/vslidedown intrinsics and lower to V instructions..
  1. rebased
  2. fixed tests based on Craig's comment
Dec 17 2020, 6:54 PM · Restricted Project
arcbbb updated the diff for D93286: [RISCV] Define vslideup/vslidedown intrinsics and lower to V instructions..

Updates:

  1. fixed @earlyclobber on vslideup
  2. fixed llvm_any_ty to llvm_anyint_ty, and VL to LLVMMatchType<1>
  3. fixed tests based on above reviews.
  4. rebase to latest master.
  5. use LLVMScalarOrSameVectorWidth for mask type.
Dec 17 2020, 1:36 AM · Restricted Project

Dec 15 2020

arcbbb updated the diff for D93286: [RISCV] Define vslideup/vslidedown intrinsics and lower to V instructions..

rebase the patch.

Dec 15 2020, 6:12 PM · Restricted Project
arcbbb requested review of D93286: [RISCV] Define vslideup/vslidedown intrinsics and lower to V instructions..
Dec 15 2020, 1:33 AM · Restricted Project

Dec 3 2020

arcbbb added a comment to D92228: [RISCV] Add MIR tests exposing missed InstAliases.
  1. Regarding @earlyclobber, yes it is not ideal as it is now. But it doesn't only impact masking (though perhaps that is the clearest case).

Unless the ISA has changed (and I admit I might be a bit outdated here) my understanding is that we still have cases where @earlyclobber will be needed and it will still fall short.

For instance, mixed widenings such as vwadd.wv are complex to model because iirc an instruction like vwadd.wv v2, v2, v1 is fine while vwadd.wv v2, v2, v3 is not. I understand that using @earlyclobber a thing like vwadd.wv v4, v2, v1 is the best we can get.

I asked about this here http://lists.llvm.org/pipermail/llvm-dev/2020-May/141383.html

Dec 3 2020, 1:21 AM · Restricted Project

Oct 20 2020

arcbbb abandoned D89288: [RISCV] Enable the use of the old sptbr name.

Thanks for the discussion.

Oct 20 2020, 2:07 AM · Restricted Project
arcbbb added a comment to D89288: [RISCV] Enable the use of the old sptbr name.

Supporting old names without change of function is sensible, but, in this case, the bit fields in satp are different from stpbr. Then, the sensible result should be an error, because the code does need to be ported to the new version of the spec.

Oct 20 2020, 2:06 AM · Restricted Project

Oct 19 2020

arcbbb added a reviewer for D89288: [RISCV] Enable the use of the old sptbr name: mmxsrup.
Oct 19 2020, 1:28 AM · Restricted Project
arcbbb added a comment to D89288: [RISCV] Enable the use of the old sptbr name.

I agree to just fix the code.
The motivation was that I saw there were two v1.9 aliases added two months ago [1,2],
and I thought it may be acceptable to add the third one. (sptbr is currently used by pk[3])
If we are not going to merge this, should the existing aliases be removed as well to make the policy clear?

Oct 19 2020, 1:25 AM · Restricted Project

Oct 12 2020

arcbbb updated the diff for D89288: [RISCV] Enable the use of the old sptbr name.
Oct 12 2020, 8:18 PM · Restricted Project
arcbbb requested review of D89288: [RISCV] Enable the use of the old sptbr name.
Oct 12 2020, 8:15 PM · Restricted Project