Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

rsandifo-arm (Richard Sandiford)
User

Projects

User does not belong to any projects.

User Details

User Since
May 1 2018, 4:00 AM (282 w, 6 d)

Recent Activity

Yesterday

rsandifo-arm added a comment to D154045: [compiler-rt][aarch64] Add SME ABI support routines..

We should move this onto GitHub PRs.

Anyway, having a static initializer seems like a bad idea. It seems wasteful to force static initializers to be generated & run just so we can check if we have SME, which in reality is never going to be false if we're in these routines. @rsandifo-arm can we relax this check requirement?

The requirement exists for streaming-compatible calls to normal functions.

Sun, Oct 1, 2:22 AM · Restricted Project, Restricted Project

Aug 7 2023

rsandifo-arm added inline comments to D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions..
Aug 7 2023, 5:33 PM · Restricted Project, Restricted Project
rsandifo-arm added inline comments to D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'.
Aug 7 2023, 10:56 AM · Restricted Project, Restricted Project, Restricted Project
rsandifo-arm added a comment to D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'.

LGTM in terms of intent.

Aug 7 2023, 9:48 AM · Restricted Project, Restricted Project, Restricted Project
rsandifo-arm added inline comments to D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions..
Aug 7 2023, 9:18 AM · Restricted Project, Restricted Project
rsandifo-arm accepted D127762: [Clang][AArch64] Add/implement ACLE keywords for SME..

LGTM too, thanks.

Aug 7 2023, 6:53 AM · Restricted Project, Restricted Project
rsandifo-arm added inline comments to D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions..
Aug 7 2023, 6:48 AM · Restricted Project, Restricted Project
rsandifo-arm added a comment to D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'.

The intent looks good to me, but I'm not in a position to approve. Very pedantic, sorry, but on the description, I think:

Aug 7 2023, 6:41 AM · Restricted Project, Restricted Project, Restricted Project
rsandifo-arm abandoned D139028: [RFC][clang] Add attribute-like keywords.

Superceded by D148700

Aug 7 2023, 3:55 AM · Restricted Project, Restricted Project

Aug 3 2023

rsandifo-arm added a comment to D127762: [Clang][AArch64] Add/implement ACLE keywords for SME..

Thanks for dropping the attribute requirements down to TargetAArch64. But the offsetting requirement was that something somewhere (CodeGen?) must raise an error if code requires SME and SME isn't present. I think that means:

Aug 3 2023, 12:54 AM · Restricted Project, Restricted Project

Aug 2 2023

rsandifo-arm added a comment to D127762: [Clang][AArch64] Add/implement ACLE keywords for SME..

Mostly LGTM from a spec POV, but some comments below.

Aug 2 2023, 1:46 AM · Restricted Project, Restricted Project

Jul 12 2023

rsandifo-arm added inline comments to D154045: [compiler-rt][aarch64] Add SME ABI support routines..
Jul 12 2023, 2:07 AM · Restricted Project, Restricted Project

Jun 13 2023

rsandifo-arm added a comment to D148700: [clang] Add support for “regular” keyword attributes.

Do you have any more thoughts on the above? Quick version is:

  1. Is it OK to have [[…]] attributes in the arm namespace that affect semantics?
  2. Is it OK to raise an error for unrecognised attributes in the arm namespace (for a measure of future-proofing)?
Jun 13 2023, 12:45 PM · Restricted Project, Restricted Project, Restricted Project

Jun 7 2023

rsandifo-arm added a comment to D148700: [clang] Add support for “regular” keyword attributes.

Yes, standard attributes aren't supposed to be used for things which affect the type system (although, we certainly have many, already, which do, since we expose most GCC-syntax attributes also as C++-standard attribute syntax!)

The rule that standard attributes don't affect semantics only applies to attributes specified by the language standard. There is no expectation that vendor attributes avoid such effects.

Jun 7 2023, 2:38 AM · Restricted Project, Restricted Project, Restricted Project

May 31 2023

rsandifo-arm added inline comments to D148700: [clang] Add support for “regular” keyword attributes.
May 31 2023, 5:42 AM · Restricted Project, Restricted Project, Restricted Project
rsandifo-arm committed rG33ee5c466346: [clang] Add Parse and Sema support for RegularKeyword attributes (authored by rsandifo-arm).
[clang] Add Parse and Sema support for RegularKeyword attributes
May 31 2023, 2:46 AM · Restricted Project, Restricted Project
rsandifo-arm committed rG301eb6b68f30: [clang] Add support for “regular” keyword attributes (authored by rsandifo-arm).
[clang] Add support for “regular” keyword attributes
May 31 2023, 2:46 AM · Restricted Project, Restricted Project, Restricted Project
rsandifo-arm committed rGac5c996d5aaa: [clang] Mark keywords that have their own parsing rules (authored by rsandifo-arm).
[clang] Mark keywords that have their own parsing rules
May 31 2023, 2:46 AM · Restricted Project, Restricted Project
rsandifo-arm closed D148702: [clang] Add Parse and Sema support for RegularKeyword attributes.
May 31 2023, 2:46 AM · Restricted Project, Restricted Project
rsandifo-arm closed D148700: [clang] Add support for “regular” keyword attributes.
May 31 2023, 2:45 AM · Restricted Project, Restricted Project, Restricted Project
rsandifo-arm closed D148699: [clang] Mark keywords that have their own parsing rules.
May 31 2023, 2:45 AM · Restricted Project, Restricted Project
rsandifo-arm updated the diff for D148699: [clang] Mark keywords that have their own parsing rules.

Update base commit.

May 31 2023, 12:52 AM · Restricted Project, Restricted Project
rsandifo-arm updated the diff for D148702: [clang] Add Parse and Sema support for RegularKeyword attributes.

Rebase to account for a diagnostic that has moved.
No other changes from the previous version.

May 31 2023, 12:32 AM · Restricted Project, Restricted Project

May 30 2023

rsandifo-arm added inline comments to D148702: [clang] Add Parse and Sema support for RegularKeyword attributes.
May 30 2023, 7:26 AM · Restricted Project, Restricted Project
rsandifo-arm updated the diff for D148702: [clang] Add Parse and Sema support for RegularKeyword attributes.

Avoid most uses of << 0. Add comments to those that remain.

May 30 2023, 7:19 AM · Restricted Project, Restricted Project

May 25 2023

rsandifo-arm added a comment to D148700: [clang] Add support for “regular” keyword attributes.

Thanks @aaron.ballman and @erichkeane for your patience in reviewing the patch and steering me in the right direction.

May 25 2023, 3:35 AM · Restricted Project, Restricted Project, Restricted Project

May 23 2023

rsandifo-arm updated the diff for D148702: [clang] Add Parse and Sema support for RegularKeyword attributes.

Update onto current main. Only change is to replace C++2b with C++23.

May 23 2023, 12:36 PM · Restricted Project, Restricted Project
rsandifo-arm added a comment to D148700: [clang] Add support for “regular” keyword attributes.

This basically LGTM, but we should add documentation to the internals manual too: https://clang.llvm.org/docs/InternalsManual.html#spellings

May 23 2023, 12:34 PM · Restricted Project, Restricted Project, Restricted Project
rsandifo-arm updated the diff for D148700: [clang] Add support for “regular” keyword attributes.

Add internals documentation. Add FIXME to temporary code.

May 23 2023, 12:31 PM · Restricted Project, Restricted Project, Restricted Project
rsandifo-arm added a comment to D148700: [clang] Add support for “regular” keyword attributes.

Hi @erichkeane and @aaron.ballman. Does the updated patch look OK?

May 23 2023, 3:23 AM · Restricted Project, Restricted Project, Restricted Project

May 16 2023

rsandifo-arm added a comment to D148700: [clang] Add support for “regular” keyword attributes.

Thanks @erichkeane . Adding the documentation with that kind of disclaimer sounds good to me. I've done that in the updated version, and also fixed the comment problem that Aaron pointed out.

May 16 2023, 10:43 AM · Restricted Project, Restricted Project, Restricted Project
rsandifo-arm updated the diff for D148700: [clang] Add support for “regular” keyword attributes.

Add documentation. Fix a comment cut-&-pasto that Aaron pointed out.

May 16 2023, 10:42 AM · Restricted Project, Restricted Project, Restricted Project
rsandifo-arm added a comment to D148700: [clang] Add support for “regular” keyword attributes.

Hi @aaron.ballman and @erichkeane . Do you have any more thoughts on this? In principle, I'm happy to convert an existing attribute over to the new scheme, but in practice, I can't find one that seems to be suitable. If we're going to do that, I think I'll need guidance as to which attribute to convert.

May 16 2023, 7:24 AM · Restricted Project, Restricted Project, Restricted Project

May 10 2023

rsandifo-arm updated subscribers of D148700: [clang] Add support for “regular” keyword attributes.

Thanks for the review.

May 10 2023, 1:26 AM · Restricted Project, Restricted Project, Restricted Project

May 8 2023

rsandifo-arm added a comment to D148700: [clang] Add support for “regular” keyword attributes.

Generally ok with all of this, but want some time to think about it/give aaron/etc time to see it.

May 8 2023, 11:57 PM · Restricted Project, Restricted Project, Restricted Project

Apr 26 2023

rsandifo-arm committed rG5794ea421a0d: [Sema] Fix _Alignas/isCXX11Attribute() FIXME (authored by rsandifo-arm).
[Sema] Fix _Alignas/isCXX11Attribute() FIXME
Apr 26 2023, 1:50 AM · Restricted Project, Restricted Project
rsandifo-arm closed D149148: [Sema] Fix _Alignas/isCXX11Attribute() FIXME.
Apr 26 2023, 1:50 AM · Restricted Project, Restricted Project

Apr 25 2023

rsandifo-arm requested review of D149148: [Sema] Fix _Alignas/isCXX11Attribute() FIXME.
Apr 25 2023, 5:25 AM · Restricted Project, Restricted Project

Apr 19 2023

rsandifo-arm added inline comments to D148700: [clang] Add support for “regular” keyword attributes.
Apr 19 2023, 11:48 AM · Restricted Project, Restricted Project, Restricted Project
rsandifo-arm updated the diff for D148700: [clang] Add support for “regular” keyword attributes.

Add #ifndef guard.

Apr 19 2023, 11:47 AM · Restricted Project, Restricted Project, Restricted Project
rsandifo-arm added inline comments to D148700: [clang] Add support for “regular” keyword attributes.
Apr 19 2023, 9:40 AM · Restricted Project, Restricted Project, Restricted Project
rsandifo-arm updated the diff for D148700: [clang] Add support for “regular” keyword attributes.

Make AttrTokenKinds.inc use a new KEYWORD_ATTRIBUTE macro, rather than
using KEYWORD directly. Move the #undef to the .inc file.

Apr 19 2023, 9:37 AM · Restricted Project, Restricted Project, Restricted Project
rsandifo-arm added a comment to D148702: [clang] Add Parse and Sema support for RegularKeyword attributes.

Thanks for the reviews!

Apr 19 2023, 7:24 AM · Restricted Project, Restricted Project
rsandifo-arm updated the summary of D148699: [clang] Mark keywords that have their own parsing rules.
Apr 19 2023, 3:28 AM · Restricted Project, Restricted Project
rsandifo-arm added a comment to D148699: [clang] Mark keywords that have their own parsing rules.

See https://reviews.llvm.org/D139028 for previous discussion on this topic. https://reviews.llvm.org/D148700 contains the Attr.td support (and the main rationale) while https://reviews.llvm.org/D148702 contains the main Parse & Sema support.

Apr 19 2023, 3:26 AM · Restricted Project, Restricted Project
rsandifo-arm requested review of D148702: [clang] Add Parse and Sema support for RegularKeyword attributes.
Apr 19 2023, 3:23 AM · Restricted Project, Restricted Project
rsandifo-arm requested review of D148700: [clang] Add support for “regular” keyword attributes.
Apr 19 2023, 3:21 AM · Restricted Project, Restricted Project, Restricted Project
rsandifo-arm requested review of D148699: [clang] Mark keywords that have their own parsing rules.
Apr 19 2023, 3:20 AM · Restricted Project, Restricted Project

Apr 13 2023

rsandifo-arm committed rG053bdb77b0ce: [clang] Bump AS_GNU to 1 (authored by rsandifo-arm).
[clang] Bump AS_GNU to 1
Apr 13 2023, 2:16 AM · Restricted Project, Restricted Project
rsandifo-arm committed rGbd41371be02f: [clang] Fix FIXME in isAlignasAttribute() (authored by rsandifo-arm).
[clang] Fix FIXME in isAlignasAttribute()
Apr 13 2023, 2:16 AM · Restricted Project, Restricted Project
rsandifo-arm committed rGaec3f951bf36: [clang] Type safety tweak for AttributeCommonInfo::Form (authored by rsandifo-arm).
[clang] Type safety tweak for AttributeCommonInfo::Form
Apr 13 2023, 2:16 AM · Restricted Project, Restricted Project
rsandifo-arm committed rG265d87e46535: [clang] Allow attributes to be constructed from keyword tokens (authored by rsandifo-arm).
[clang] Allow attributes to be constructed from keyword tokens
Apr 13 2023, 2:16 AM · Restricted Project, Restricted Project
rsandifo-arm committed rGb6d4d51f8f5a: [clang] Specify attribute syntax & spelling with a single argument (authored by rsandifo-arm).
[clang] Specify attribute syntax & spelling with a single argument
Apr 13 2023, 2:16 AM · Restricted Project, Restricted Project
rsandifo-arm closed D148148: [clang] Bump AS_GNU to 1.
Apr 13 2023, 2:16 AM · Restricted Project, Restricted Project
rsandifo-arm committed rGe841d5092634: [clang] Ensure that Attr::Create(Implicit) chooses a valid syntax (authored by rsandifo-arm).
[clang] Ensure that Attr::Create(Implicit) chooses a valid syntax
Apr 13 2023, 2:16 AM · Restricted Project, Restricted Project
rsandifo-arm closed D148105: [clang] Fix FIXME in isAlignasAttribute().
Apr 13 2023, 2:16 AM · Restricted Project, Restricted Project
rsandifo-arm closed D148104: [clang] Type safety tweak for AttributeCommonInfo::Form.
Apr 13 2023, 2:16 AM · Restricted Project, Restricted Project
rsandifo-arm closed D148103: [clang] Allow attributes to be constructed from keyword tokens.
Apr 13 2023, 2:16 AM · Restricted Project, Restricted Project
rsandifo-arm closed D148102: [clang] Specify attribute syntax & spelling with a single argument.
Apr 13 2023, 2:16 AM · Restricted Project, Restricted Project
rsandifo-arm closed D148101: [clang] Ensure that Attr::Create(Implicit) chooses a valid syntax.
Apr 13 2023, 2:16 AM · Restricted Project, Restricted Project

Apr 12 2023

rsandifo-arm updated the diff for D148102: [clang] Specify attribute syntax & spelling with a single argument.

Tweak initializer to avoid an MSVC error: https://godbolt.org/z/sMxsW8G8j

Apr 12 2023, 3:53 PM · Restricted Project, Restricted Project
rsandifo-arm updated the diff for D148148: [clang] Bump AS_GNU to 1.

Gah, sorry. Due to a botched git operation, I posted a first cut with a stupid typo, rather than the version that passed testing.

Apr 12 2023, 1:02 PM · Restricted Project, Restricted Project
rsandifo-arm added inline comments to D148148: [clang] Bump AS_GNU to 1.
Apr 12 2023, 10:55 AM · Restricted Project, Restricted Project
rsandifo-arm added inline comments to D148101: [clang] Ensure that Attr::Create(Implicit) chooses a valid syntax.
Apr 12 2023, 10:52 AM · Restricted Project, Restricted Project
rsandifo-arm requested review of D148148: [clang] Bump AS_GNU to 1.
Apr 12 2023, 10:47 AM · Restricted Project, Restricted Project
rsandifo-arm added a comment to D148105: [clang] Fix FIXME in isAlignasAttribute().

FWIW, the original reason for looking at this was to explore ways of removing AS_AttributeLikeKeyword from https://reviews.llvm.org/D139028 . I wanted to find a way of conveying extra information about a spelling without having to change the existing enums. It seemed like that was essentially the same problem as the one described in the FIXME being fixed here.

Apr 12 2023, 3:16 AM · Restricted Project, Restricted Project
rsandifo-arm requested review of D148105: [clang] Fix FIXME in isAlignasAttribute().
Apr 12 2023, 3:06 AM · Restricted Project, Restricted Project
rsandifo-arm requested review of D148104: [clang] Type safety tweak for AttributeCommonInfo::Form.
Apr 12 2023, 3:06 AM · Restricted Project, Restricted Project
rsandifo-arm requested review of D148103: [clang] Allow attributes to be constructed from keyword tokens.
Apr 12 2023, 3:06 AM · Restricted Project, Restricted Project
rsandifo-arm requested review of D148102: [clang] Specify attribute syntax & spelling with a single argument.
Apr 12 2023, 3:05 AM · Restricted Project, Restricted Project
rsandifo-arm requested review of D148101: [clang] Ensure that Attr::Create(Implicit) chooses a valid syntax.
Apr 12 2023, 3:05 AM · Restricted Project, Restricted Project

Apr 10 2023

rsandifo-arm added a comment to D147661: [Sema] Tweak merging of availability attributes.

I threw together a patch to make the constructors explicit and the only two compile failures I have are with what you're fixing in this patch. If you'd like, I can commandeer this patch and subsume it with the larger refactor. Alternatively, we can land this (I'd drop the test though) and I can rebase on top of your changes. Either is fine by me.

Apr 10 2023, 2:49 AM · Restricted Project, Restricted Project

Apr 6 2023

rsandifo-arm added a comment to D147661: [Sema] Tweak merging of availability attributes.

This test doesn't show a change in behavior.

Yeah. Is there a way to force the syntax and spelling fields to be dumped, even for implicit attributes? I was struggling to find one, which is why I wasn't sure this made a difference in practice.

Apr 6 2023, 9:59 AM · Restricted Project, Restricted Project
rsandifo-arm added a comment to D147661: [Sema] Tweak merging of availability attributes.

I think the change is probably fine,

Apr 6 2023, 8:31 AM · Restricted Project, Restricted Project
rsandifo-arm updated the diff for D147661: [Sema] Tweak merging of availability attributes.

Add AST dump test

Apr 6 2023, 8:29 AM · Restricted Project, Restricted Project
rsandifo-arm committed rG03a9a1e664de: [Sema] Fix reporting of invalid shader attribute on HLSL entry function (authored by rsandifo-arm).
[Sema] Fix reporting of invalid shader attribute on HLSL entry function
Apr 6 2023, 2:57 AM · Restricted Project, Restricted Project
rsandifo-arm closed D147657: [Sema] Fix reporting of invalid shader attribute on HLSL entry function.
Apr 6 2023, 2:57 AM · Restricted Project, Restricted Project

Apr 5 2023

rsandifo-arm requested review of D147661: [Sema] Tweak merging of availability attributes.
Apr 5 2023, 2:32 PM · Restricted Project, Restricted Project
rsandifo-arm requested review of D147657: [Sema] Fix reporting of invalid shader attribute on HLSL entry function.
Apr 5 2023, 1:04 PM · Restricted Project, Restricted Project

Mar 31 2023

rsandifo-arm added inline comments to D127317: [AArch64][SME] Add ldr/str (fill/spill) intrinsics.
Mar 31 2023, 3:31 AM · Restricted Project, Restricted Project

Feb 28 2023

rsandifo-arm added a comment to D139028: [RFC][clang] Add attribute-like keywords.

Thanks @aaron.ballman and @erichkeane for the comments. I'll split it into stages and use tablegen more, like you say.

Feb 28 2023, 10:43 AM · Restricted Project, Restricted Project

Jan 26 2023

rsandifo-arm added a comment to D141650: [VectorUtils] Enhance VFABI demangling API.

I'm just responding to the above without having full context, so sorry if this is rehashing old discussions.

Jan 26 2023, 3:03 PM · Restricted Project, Restricted Project

Jan 25 2023

rsandifo-arm added a comment to D139028: [RFC][clang] Add attribute-like keywords.

Ping. If this approach is acceptable, I think we could use it for future ACLE features too (rather than the GNU attributes that we've used previously).

Jan 25 2023, 8:53 AM · Restricted Project, Restricted Project

Jan 4 2023

rsandifo-arm updated the summary of D139028: [RFC][clang] Add attribute-like keywords.
Jan 4 2023, 2:44 AM · Restricted Project, Restricted Project
rsandifo-arm updated the diff for D139028: [RFC][clang] Add attribute-like keywords.

Reupload with proper linting. No change in code.

Jan 4 2023, 2:32 AM · Restricted Project, Restricted Project
rsandifo-arm added a comment to D127762: [Clang][AArch64] Add/implement ACLE keywords for SME..

Thanks @aaron.ballman for the feedback about spellings. I've gone with the lower-case names like __arm_streaming in what follows, as a plausible strawman.

My main concern with keywords is:

This approach means there's plenty of flexibility available to parse the keyword where you think it makes sense.

If everyone parses keywords where it makes sense to them personally, for their specific use case, I'm worried that we'll end up with a lot of slightly different rules. (This tended to happen for pre-standard features, and like you say, is still the case for GNU attribute handling between Clang and GCC, given GCC's poorly-defined rules.)

Ah, I meant more that we have flexibility on what we want the grammar of the extension to be. If other implementations wanted to pick up the functionality, hopefully they'd pick up the same grammar as well.

Jan 4 2023, 2:20 AM · Restricted Project, Restricted Project

Nov 30 2022

rsandifo-arm added reviewers for D139028: [RFC][clang] Add attribute-like keywords: paulwalker-arm, sdesmalen.
Nov 30 2022, 9:32 AM · Restricted Project, Restricted Project
rsandifo-arm added a comment to D127762: [Clang][AArch64] Add/implement ACLE keywords for SME..

Thanks @aaron.ballman for the feedback about spellings. I've gone with the lower-case names like __arm_streaming in what follows, as a plausible strawman.

Nov 30 2022, 9:30 AM · Restricted Project, Restricted Project
rsandifo-arm requested review of D139028: [RFC][clang] Add attribute-like keywords.
Nov 30 2022, 9:26 AM · Restricted Project, Restricted Project

Nov 22 2022

rsandifo-arm added inline comments to D127762: [Clang][AArch64] Add/implement ACLE keywords for SME..
Nov 22 2022, 12:52 AM · Restricted Project, Restricted Project

Nov 16 2022

rsandifo-arm added inline comments to D127762: [Clang][AArch64] Add/implement ACLE keywords for SME..
Nov 16 2022, 11:08 AM · Restricted Project, Restricted Project
rsandifo-arm added inline comments to D127762: [Clang][AArch64] Add/implement ACLE keywords for SME..
Nov 16 2022, 10:54 AM · Restricted Project, Restricted Project

Oct 28 2022

rsandifo-arm added inline comments to D127762: [Clang][AArch64] Add/implement ACLE keywords for SME..
Oct 28 2022, 11:35 AM · Restricted Project, Restricted Project

Oct 14 2022

rsandifo-arm added a comment to D134681: [Clang][AArch64][SME] Add outer product intrinsics.

Thanks for the patch. This is going to be inconvenient, sorry, but: while implementing the specification in GCC, I noticed that the ZA functions weren't consistent about whether they had an _m suffix. svwrite (MOVA) had one, but the MOP intrinsics that you're implementing here didn't. Since SME2 does have some unpredicated instructions, it seems like it would be better to make the MOP intrinsics consistent with svwrite, with an _m suffix.

Oct 14 2022, 9:40 AM · Restricted Project, Restricted Project

Sep 8 2022

rsandifo-arm added a comment to D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features..

I can see at least three ways of handling this:

  1. @paulwalker-arm's suggestion to allow -march= without a base architecture (or with a dummy base architecture that means “no change”)
  2. a single new option -mfoo= that applies on top of -march and can be used to add or remove architecture features
  3. individual -m and -mno- options for each ISA feature.
Sep 8 2022, 2:21 AM · Restricted Project, Restricted Project

Jul 5 2022

rsandifo-arm added inline comments to D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209.
Jul 5 2022, 5:04 AM · Restricted Project, Restricted Project
rsandifo-arm added inline comments to D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209.
Jul 5 2022, 3:29 AM · Restricted Project, Restricted Project

Mar 16 2022

rsandifo-arm added a comment to D121208: [AArch64][SME] Split up SME features. (alternative approach).

This approach looks good to me FWIW. The main advantages as I see it are:

  • Treating PSTATE.SM and PSTATE.ZA as orthogonal to the set of implemented features follows the scheme used in the ISA specification, so it's easy to cross-check the two. The IsSVEEnabled review comment is an example of this.
  • It is likely to cope better with any future extensions to SVE or SME: the streaming-compatible, streaming and non-streaming subsets of each ISA extension would not need to be identified individually on the command line or in IR. Or to put it another way: requiring multiple +streaming-foo flags (and so repeating the “streaming”) feels like specifying the same bit of information multiple times.
  • It avoids the risk of combinatorial explosion if we ever need to do something similar for another degree of freedom.
Mar 16 2022, 7:27 AM · Restricted Project, Restricted Project
rsandifo-arm abandoned D77056: [Sema] Allow non-member operators for sizeless SVE types.
Mar 16 2022, 6:29 AM · Restricted Project, Restricted Project

Oct 19 2021

rsandifo-arm added a comment to D109246: [AArch64][MC] Merge FeaturePMU into FeaturePerfMon.

Sorry to ask about an already-closed ticket, but: it looks like this makes the register unconditionally available, rather than making it conditional on FeaturePerfMon. Is that the intended behaviour? GNU as does still require v8.4 for this register.

Oct 19 2021, 4:34 AM · Restricted Project