• Remove pointless "SVE Types" comments
• Expand commentary about SVE type layout and future debug info handling
• Make macro formatting more consistent with the surrounding code

@rjmccall: thanks for the positive feedback. Is there a particular reviewer you'd like to hear from before the patch lands?

Thanks. I think the current version of the patch addresses all review comments so far and the last set of comments seemed positive. Does the patch look OK to land?

In D65448#1606567, @ostannard wrote:

Out of interest, why does the ABI allow functions which don't have SVE args/returns to clobber the P registers? For Z registers, we've got to be compatible with old code which only needed to save the bottom half of v8-v15, but there should be no existing code which uses P registers, so we could enforce a mixture of callee- and caller-saved P registers for all code. Existing code is already compliant with this, because it doesn't touch the P regs.

Ping, and thanks for the reviews so far. I think I've addressed all the comments to date and I've tried to make the patch ready to commit in its current state (rather than the RFC that it originally was).

In D62960#1566265, @rovka wrote:

This looks much better, thanks! Shouldn't there be more tests, e.g. for mangling and maybe the ASTImporter?

Changes since last version:

• Update for new version of D62960

Thanks for the reviews!

• Fix comments in AArch64SVEACLETypes.def
• Rename BUILTIN_TYPE to SVE_TYPE and use it where possible
• Report errors for TODOs instead of using llvm_unreachable
• Add a test for the errors
• Formatting fixes

Thanks for the review.

Improve atomic built-in tests.

Add tests for ext_vector_type

Abandoning in favour of:

Abandoning in favour of:

Abandoning in favour of: