Page MenuHomePhabricator

rsandifo-arm (Richard Sandiford)
User

Projects

User does not belong to any projects.

User Details

User Since
May 1 2018, 4:00 AM (72 w, 2 d)

Recent Activity

Aug 9 2019

rsandifo-arm committed rGeb485fbc7128: Add SVE opaque built-in types (authored by rsandifo-arm).
Add SVE opaque built-in types
Aug 9 2019, 1:54 AM

Aug 8 2019

rsandifo-arm added inline comments to D62960: Add SVE opaque built-in types.
Aug 8 2019, 3:16 AM · Restricted Project, Restricted Project
rsandifo-arm updated the diff for D62960: Add SVE opaque built-in types.
  • Remove pointless "SVE Types" comments
  • Expand commentary about SVE type layout and future debug info handling
  • Make macro formatting more consistent with the surrounding code
Aug 8 2019, 3:00 AM · Restricted Project, Restricted Project

Aug 7 2019

rsandifo-arm added a comment to D62960: Add SVE opaque built-in types.

@rjmccall: thanks for the positive feedback. Is there a particular reviewer you'd like to hear from before the patch lands?

Aug 7 2019, 12:34 PM · Restricted Project, Restricted Project

Jul 30 2019

rsandifo-arm added a comment to D62960: Add SVE opaque built-in types.

Thanks. I think the current version of the patch addresses all review comments so far and the last set of comments seemed positive. Does the patch look OK to land?

Jul 30 2019, 12:21 PM · Restricted Project, Restricted Project
rsandifo-arm added a comment to D65448: [AArch64] Implement initial SVE calling convention support.

Out of interest, why does the ABI allow functions which don't have SVE args/returns to clobber the P registers? For Z registers, we've got to be compatible with old code which only needed to save the bottom half of v8-v15, but there should be no existing code which uses P registers, so we could enforce a mixture of callee- and caller-saved P registers for all code. Existing code is already compliant with this, because it doesn't touch the P regs.

Jul 30 2019, 11:45 AM · Restricted Project

Jul 15 2019

rsandifo-arm committed rGea36cdcec318: DeveloperPolicy: fix a typo (authored by rsandifo-arm).
DeveloperPolicy: fix a typo
Jul 15 2019, 1:12 AM

Jul 11 2019

rsandifo-arm added a comment to D62960: Add SVE opaque built-in types.

Ping, and thanks for the reviews so far. I think I've addressed all the comments to date and I've tried to make the patch ready to commit in its current state (rather than the RFC that it originally was).

Jul 11 2019, 12:48 PM · Restricted Project, Restricted Project

Jul 4 2019

rsandifo-arm added a comment to D62960: Add SVE opaque built-in types.

This looks much better, thanks! Shouldn't there be more tests, e.g. for mangling and maybe the ASTImporter?

Jul 4 2019, 2:03 AM · Restricted Project, Restricted Project
rsandifo-arm retitled D62960: Add SVE opaque built-in types from SVE opaque type for C intrinsics demo to Add SVE opaque built-in types.
Jul 4 2019, 2:00 AM · Restricted Project, Restricted Project
rsandifo-arm updated the diff for D62960: Add SVE opaque built-in types.

Changes since last version:

Jul 4 2019, 1:55 AM · Restricted Project, Restricted Project

Jun 27 2019

rsandifo-arm updated the diff for D62961: [AST] Add new Type queries for sizeless types.
  • Update for new version of D62960
Jun 27 2019, 11:22 AM · Restricted Project
rsandifo-arm added a comment to D62960: Add SVE opaque built-in types.

Thanks for the reviews!

Jun 27 2019, 11:21 AM · Restricted Project, Restricted Project
rsandifo-arm updated the diff for D62960: Add SVE opaque built-in types.
  • Fix comments in AArch64SVEACLETypes.def
  • Rename BUILTIN_TYPE to SVE_TYPE and use it where possible
  • Report errors for TODOs instead of using llvm_unreachable
  • Add a test for the errors
  • Formatting fixes
Jun 27 2019, 11:07 AM · Restricted Project, Restricted Project

Jun 19 2019

rsandifo-arm added inline comments to D62960: Add SVE opaque built-in types.
Jun 19 2019, 7:15 AM · Restricted Project, Restricted Project

Jun 10 2019

rsandifo-arm added inline comments to D62962: Clang implementation of sizeless types.
Jun 10 2019, 10:58 AM · Restricted Project
rsandifo-arm added a comment to D62962: Clang implementation of sizeless types.

Thanks for the review.

Jun 10 2019, 1:57 AM · Restricted Project
rsandifo-arm updated the diff for D62962: Clang implementation of sizeless types.

Improve atomic built-in tests.

Jun 10 2019, 1:50 AM · Restricted Project

Jun 7 2019

rsandifo-arm updated the diff for D62962: Clang implementation of sizeless types.

Add tests for ext_vector_type

Jun 7 2019, 6:17 AM · Restricted Project

Jun 6 2019

rsandifo-arm abandoned D46309: [PATCH 3/3] [RFC only][NFC] More comments about completeness.

Abandoning in favour of:

Jun 6 2019, 9:01 AM
rsandifo-arm abandoned D46308: [PATCH 2/3] [RFC only] clang implementation of sizeless types.

Abandoning in favour of:

Jun 6 2019, 9:01 AM · Restricted Project
rsandifo-arm abandoned D46307: [PATCH 1/3] [RFC only] Hack to add some sizeless built-in types.

Abandoning in favour of:

Jun 6 2019, 8:57 AM · Restricted Project
rsandifo-arm created D62962: Clang implementation of sizeless types.
Jun 6 2019, 8:48 AM · Restricted Project
rsandifo-arm created D62961: [AST] Add new Type queries for sizeless types.
Jun 6 2019, 8:47 AM · Restricted Project
rsandifo-arm created D62960: Add SVE opaque built-in types.
Jun 6 2019, 8:47 AM · Restricted Project, Restricted Project

May 1 2018

rsandifo-arm added a parent revision for D46308: [PATCH 2/3] [RFC only] clang implementation of sizeless types: D46307: [PATCH 1/3] [RFC only] Hack to add some sizeless built-in types.
May 1 2018, 5:03 AM · Restricted Project
rsandifo-arm added a child revision for D46307: [PATCH 1/3] [RFC only] Hack to add some sizeless built-in types: D46308: [PATCH 2/3] [RFC only] clang implementation of sizeless types.
May 1 2018, 5:03 AM · Restricted Project
rsandifo-arm added parent revisions for D46309: [PATCH 3/3] [RFC only][NFC] More comments about completeness: D46308: [PATCH 2/3] [RFC only] clang implementation of sizeless types, D46307: [PATCH 1/3] [RFC only] Hack to add some sizeless built-in types.
May 1 2018, 5:02 AM
rsandifo-arm added a child revision for D46308: [PATCH 2/3] [RFC only] clang implementation of sizeless types: D46309: [PATCH 3/3] [RFC only][NFC] More comments about completeness.
May 1 2018, 5:02 AM · Restricted Project
rsandifo-arm added a child revision for D46307: [PATCH 1/3] [RFC only] Hack to add some sizeless built-in types: D46309: [PATCH 3/3] [RFC only][NFC] More comments about completeness.
May 1 2018, 5:02 AM · Restricted Project
rsandifo-arm created D46309: [PATCH 3/3] [RFC only][NFC] More comments about completeness.
May 1 2018, 5:02 AM
rsandifo-arm created D46308: [PATCH 2/3] [RFC only] clang implementation of sizeless types.
May 1 2018, 5:00 AM · Restricted Project
rsandifo-arm created D46307: [PATCH 1/3] [RFC only] Hack to add some sizeless built-in types.
May 1 2018, 4:55 AM · Restricted Project