This is an archive of the discontinued LLVM Phabricator instance.

[NFC] clean up the AsmPrinter::emitLinkage for AIX part
ClosedPublic

Authored by DiggerLin on Jun 10 2020, 2:06 PM.

Details

Summary

Since we deal with aix emitLinkage in the PPCAIXAsmPrinter::emitLinkage() in the patch https://reviews.llvm.org/D75866. It do not go to AsmPrinter::emitLinkage() any more, we clean up some aix related code in the AsmPrinter::emitLinkage()

Diff Detail

Event Timeline

DiggerLin created this revision.Jun 10 2020, 2:06 PM
jasonliu accepted this revision.Jun 11 2020, 6:57 AM

LGTM with minor nit.

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
423–424

nit: remove this return.

This revision is now accepted and ready to land.Jun 11 2020, 6:57 AM
DiggerLin marked an inline comment as done.Jun 11 2020, 7:19 AM
This revision was automatically updated to reflect the committed changes.