Page MenuHomePhabricator

jasonliu (Jason Liu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2016, 1:13 PM (221 w, 3 d)

Recent Activity

Wed, Oct 14

jasonliu abandoned D88493: [XCOFF] Use -data-sections=true as default for llc on AIX.
Wed, Oct 14, 8:59 AM · Restricted Project
jasonliu committed rGf85bcc21ddad: [AIX] Turn -fdata-sections on by default in Clang (authored by jasonliu).
[AIX] Turn -fdata-sections on by default in Clang
Wed, Oct 14, 8:59 AM
jasonliu closed D88737: [AIX] Turn -fdata-sections on by default in Clang.
Wed, Oct 14, 8:58 AM · Restricted Project, Restricted Project

Tue, Oct 13

jasonliu added a comment to D88737: [AIX] Turn -fdata-sections on by default in Clang.

Hi Fangrui(@MaskRay), are you okay with this patch to land as is?

Tue, Oct 13, 6:47 AM · Restricted Project, Restricted Project

Fri, Oct 9

jasonliu added a comment to D88737: [AIX] Turn -fdata-sections on by default in Clang.

A less intrusive approach is to not touch the existing InitTargetOptionsFromCodeGenFlags without parameters. You can add an initTargetOptionsFromCodeGenFlags with const Tripe & as its parameter.

Fri, Oct 9, 10:29 AM · Restricted Project, Restricted Project

Thu, Oct 8

jasonliu added inline comments to D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Thu, Oct 8, 1:57 PM · Restricted Project
jasonliu added inline comments to D88737: [AIX] Turn -fdata-sections on by default in Clang.
Thu, Oct 8, 7:13 AM · Restricted Project, Restricted Project
jasonliu updated the diff for D88737: [AIX] Turn -fdata-sections on by default in Clang.
Thu, Oct 8, 7:12 AM · Restricted Project, Restricted Project

Wed, Oct 7

jasonliu updated subscribers of D88737: [AIX] Turn -fdata-sections on by default in Clang.
Wed, Oct 7, 12:01 PM · Restricted Project, Restricted Project
jasonliu updated subscribers of D88737: [AIX] Turn -fdata-sections on by default in Clang.
Wed, Oct 7, 12:00 PM · Restricted Project, Restricted Project
jasonliu added inline comments to D87451: add new option -mignore-xcoff-visibility.
Wed, Oct 7, 10:28 AM · Restricted Project, Restricted Project
jasonliu added inline comments to D88615: [XCOFF] Enable explicit sections on AIX.
Wed, Oct 7, 10:13 AM · Restricted Project
jasonliu updated the diff for D88737: [AIX] Turn -fdata-sections on by default in Clang.

Change lld's forwarder function's signature to match LLVM style.

Wed, Oct 7, 7:12 AM · Restricted Project, Restricted Project
jasonliu added inline comments to D88737: [AIX] Turn -fdata-sections on by default in Clang.
Wed, Oct 7, 7:08 AM · Restricted Project, Restricted Project

Fri, Oct 2

jasonliu added a comment to D88493: [XCOFF] Use -data-sections=true as default for llc on AIX.

This patch could be abandoned if D88737 gets acceptance.

Fri, Oct 2, 8:04 PM · Restricted Project
jasonliu updated the summary of D88737: [AIX] Turn -fdata-sections on by default in Clang.
Fri, Oct 2, 8:03 PM · Restricted Project, Restricted Project
jasonliu updated the diff for D88737: [AIX] Turn -fdata-sections on by default in Clang.

An update follows up with the idea in D88748.

Fri, Oct 2, 8:00 PM · Restricted Project, Restricted Project
jasonliu planned changes to D88493: [XCOFF] Use -data-sections=true as default for llc on AIX.
Fri, Oct 2, 5:01 PM · Restricted Project
jasonliu planned changes to D88737: [AIX] Turn -fdata-sections on by default in Clang.
Fri, Oct 2, 5:01 PM · Restricted Project, Restricted Project
jasonliu accepted D88748: [llc] Initialize TargetOptions after Triple is available.
Fri, Oct 2, 11:33 AM · Restricted Project
jasonliu added inline comments to D88748: [llc] Initialize TargetOptions after Triple is available.
Fri, Oct 2, 11:05 AM · Restricted Project
jasonliu added inline comments to D88737: [AIX] Turn -fdata-sections on by default in Clang.
Fri, Oct 2, 9:35 AM · Restricted Project, Restricted Project
jasonliu added inline comments to D88737: [AIX] Turn -fdata-sections on by default in Clang.
Fri, Oct 2, 9:17 AM · Restricted Project, Restricted Project
jasonliu added a comment to D88737: [AIX] Turn -fdata-sections on by default in Clang.

Not sure if there is a better way to do this. But I have to admit this approach along with D88493 is a bit fragile.
If plug-in writer forgets to set HasExplicitDataSections to true, then the final result that TargetMachine give for getDataSections() could be false on most platform even when they deliberately set DataSections to true.
We have other targets in LLVM that have -fdata-sections by default as well. And they do it differently as well, which makes this a bit more complicate to be consistent.
For example, cloudABI would pass -fdata-sections through the Clang Driver by default. But that approach means if some user just invoke llc directly, they could get the wrong default on llc for that platform.
Wasm would just overwrite the DataSections option to true in their TargetMachine. But that means you could not set it to false even if you want to.
I've thought about making the DataSections option in TargetOptions an enum instead of boolean value, where you could have Default, On and Off to represent what we actually want for the options. That's not a trivial change, as a lot of consumers for TargetOptions are relying it to be a boolean.
If you think it's a better way to solve this problem and I should explore, let me know.

Fri, Oct 2, 7:21 AM · Restricted Project, Restricted Project
jasonliu requested review of D88737: [AIX] Turn -fdata-sections on by default in Clang.
Fri, Oct 2, 7:00 AM · Restricted Project, Restricted Project

Thu, Oct 1

jasonliu committed rG78a9e62aa6f8: [XCOFF] Enable -fdata-sections on AIX (authored by jasonliu).
[XCOFF] Enable -fdata-sections on AIX
Thu, Oct 1, 5:16 PM
jasonliu closed D88339: [XCOFF] Enable -fdata-sections on AIX.
Thu, Oct 1, 5:16 PM · Restricted Project
jasonliu added inline comments to D88339: [XCOFF] Enable -fdata-sections on AIX.
Thu, Oct 1, 2:27 PM · Restricted Project
jasonliu added inline comments to D88339: [XCOFF] Enable -fdata-sections on AIX.
Thu, Oct 1, 12:54 PM · Restricted Project

Wed, Sep 30

jasonliu added inline comments to D88615: [XCOFF] Enable explicit sections on AIX.
Wed, Sep 30, 2:28 PM · Restricted Project
jasonliu updated the diff for D88615: [XCOFF] Enable explicit sections on AIX.
Wed, Sep 30, 2:22 PM · Restricted Project
jasonliu requested review of D88615: [XCOFF] Enable explicit sections on AIX.
Wed, Sep 30, 2:20 PM · Restricted Project
jasonliu added a comment to D88493: [XCOFF] Use -data-sections=true as default for llc on AIX.

@jasonliu: There's a lot of test adjustments to explicitly use the non-default, but I am not sure there is testing here to validate that the llc default when producing XCOFF assembly/object output is with unique data sections.

Wed, Sep 30, 1:58 PM · Restricted Project
jasonliu updated the diff for D88493: [XCOFF] Use -data-sections=true as default for llc on AIX.

Address comments.

Wed, Sep 30, 1:57 PM · Restricted Project
jasonliu updated the diff for D88339: [XCOFF] Enable -fdata-sections on AIX.

Rebase and addresses comments.

Wed, Sep 30, 1:35 PM · Restricted Project

Tue, Sep 29

jasonliu added inline comments to D88339: [XCOFF] Enable -fdata-sections on AIX.
Tue, Sep 29, 10:03 AM · Restricted Project
jasonliu updated the diff for D88339: [XCOFF] Enable -fdata-sections on AIX.
Tue, Sep 29, 10:02 AM · Restricted Project
jasonliu requested review of D88493: [XCOFF] Use -data-sections=true as default for llc on AIX.
Tue, Sep 29, 8:11 AM · Restricted Project
jasonliu accepted D88260: [NFC][FE] Replace TypeSize with StorageUnitSize.

LGTM.

Tue, Sep 29, 7:26 AM · Restricted Project

Mon, Sep 28

jasonliu accepted D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .

LGTM.

Mon, Sep 28, 1:53 PM · Restricted Project
jasonliu added inline comments to D88339: [XCOFF] Enable -fdata-sections on AIX.
Mon, Sep 28, 12:12 PM · Restricted Project
jasonliu added inline comments to D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .
Mon, Sep 28, 8:10 AM · Restricted Project

Fri, Sep 25

jasonliu updated the summary of D88339: [XCOFF] Enable -fdata-sections on AIX.
Fri, Sep 25, 2:09 PM · Restricted Project
jasonliu requested review of D88339: [XCOFF] Enable -fdata-sections on AIX.
Fri, Sep 25, 2:08 PM · Restricted Project

Thu, Sep 24

jasonliu added inline comments to D87451: add new option -mignore-xcoff-visibility.
Thu, Sep 24, 11:52 AM · Restricted Project, Restricted Project
jasonliu added inline comments to D87451: add new option -mignore-xcoff-visibility.
Thu, Sep 24, 11:49 AM · Restricted Project, Restricted Project

Mon, Sep 21

jasonliu added a comment to D87029: [AIX] Implement AIX special bitfield related alignment rules.

I think it would help the review if we could put the NFC portion(e.g. TypeSize -> StorageUnitSize) to a new patch, and give some rationale about the NFC change.

Mon, Sep 21, 8:09 AM · Restricted Project
jasonliu accepted D87914: [AIX][Clang][Driver] Add handling of shared option.

LGTM.

Mon, Sep 21, 7:23 AM · Restricted Project

Sep 18 2020

jasonliu accepted D87904: [AIX][Clang][Driver] Add handling of nostartfiles option.

LGTM.

Sep 18 2020, 2:24 PM · Restricted Project
jasonliu added inline comments to D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Sep 18 2020, 1:56 PM · Restricted Project
jasonliu added inline comments to D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .
Sep 18 2020, 8:36 AM · Restricted Project

Sep 16 2020

jasonliu committed rG1321160a26e7: Disable a large test for EXPENSIVE_CHECKS and debug build (authored by jasonliu).
Disable a large test for EXPENSIVE_CHECKS and debug build
Sep 16 2020, 2:58 PM
jasonliu closed D87794: Disable a large test for EXPENSIVE_CHECKS and debug build.
Sep 16 2020, 2:58 PM · Restricted Project
jasonliu updated the diff for D87794: Disable a large test for EXPENSIVE_CHECKS and debug build.

Added debug

Sep 16 2020, 2:40 PM · Restricted Project
jasonliu requested review of D87794: Disable a large test for EXPENSIVE_CHECKS and debug build.
Sep 16 2020, 2:07 PM · Restricted Project
jasonliu added inline comments to D87451: add new option -mignore-xcoff-visibility.
Sep 16 2020, 8:35 AM · Restricted Project, Restricted Project

Sep 15 2020

jasonliu added inline comments to D86461: [AIX][XCOFF][Patch2] decode vector information and extent long table of the traceback table of the xcoff..
Sep 15 2020, 1:31 PM · Restricted Project
jasonliu committed rGec2b0a519778: [XCOFF] Run resource intense test only on platforms where it makes sense (authored by jasonliu).
[XCOFF] Run resource intense test only on platforms where it makes sense
Sep 15 2020, 8:54 AM
jasonliu added a comment to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.

We believe that the test is necessarily large. Has the associated bot encountered similar issues before? What was the recommended fix to retain the test in more appropriate environments?

Perhaps the test case should be restricted to some key platforms where cross-compilation to AIX is relevant? Perhaps Linux (PPC is already required).

Sep 15 2020, 7:16 AM · Restricted Project

Sep 14 2020

jasonliu added a comment to rG9868ea764f31: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in….

I think this could achieve the same effect by writing out a loop, and running the unroller to generate the target IR. Alternatively, I think you can craft the same situations without giant IR. For example with the spill-O1 case, you should be able to use some large stack objects and then trigger spilling with a shorter sequence. I assume all of the objects leading up to the spill don't need to be spills to hit the out of range behavior

Sep 14 2020, 12:55 PM
jasonliu added a comment to rG9868ea764f31: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in….

I think it's inappropriate to have test IR be generated like this. This test is also incredibly slow. It takes a full 30 seconds for me with a debug build

Sep 14 2020, 11:56 AM
jasonliu committed rG9868ea764f31: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in… (authored by jasonliu).
[XCOFF][AIX] Handle TOC entries that could not be reached by positive range in…
Sep 14 2020, 6:43 AM
jasonliu closed D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Sep 14 2020, 6:43 AM · Restricted Project

Sep 11 2020

jasonliu updated the diff for D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

Address comments from Digger.

Sep 11 2020, 11:54 AM · Restricted Project
jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Sep 11 2020, 11:23 AM · Restricted Project
jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Sep 11 2020, 10:46 AM · Restricted Project

Sep 10 2020

jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Sep 10 2020, 5:39 PM · Restricted Project
jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Sep 10 2020, 5:28 PM · Restricted Project
jasonliu updated the diff for D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.

Address comments.

Sep 10 2020, 3:43 PM · Restricted Project
jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Sep 10 2020, 1:48 PM · Restricted Project
jasonliu added inline comments to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Sep 10 2020, 1:05 PM · Restricted Project
jasonliu added inline comments to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Sep 10 2020, 10:50 AM · Restricted Project
jasonliu updated the diff for D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.

Address review comments.

Sep 10 2020, 10:49 AM · Restricted Project

Sep 9 2020

jasonliu added a comment to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

It seems to me like this should be using inheritance here. You have a base class that has the common members, and provides pure virtual declarations of the various getters, with the sub-classes defining them to do the right thing. Yes, it would introduce a number of getters, but I feel like it would make everything a bit cleaner from a usability standpoint. In most cases, you then don't need any is64Bit queries, because the getters hide that from you.

Sep 9 2020, 1:04 PM · Restricted Project
jasonliu updated the diff for D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

Addresses comments.
Add in test case to test errors.
Use view/reference class to encapsulate 32-bit and 64-bit differences instead.

Sep 9 2020, 12:47 PM · Restricted Project

Sep 3 2020

jasonliu added inline comments to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Sep 3 2020, 10:59 AM · Restricted Project
jasonliu added inline comments to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Sep 3 2020, 9:11 AM · Restricted Project
jasonliu updated the diff for D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.

Address comments.

Sep 3 2020, 9:11 AM · Restricted Project

Sep 2 2020

jasonliu added inline comments to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Sep 2 2020, 2:38 PM · Restricted Project
jasonliu added inline comments to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Sep 2 2020, 2:30 PM · Restricted Project

Aug 31 2020

jasonliu updated the summary of D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Aug 31 2020, 8:44 AM · Restricted Project
jasonliu updated the summary of D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Aug 31 2020, 8:44 AM · Restricted Project
jasonliu requested review of D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Aug 31 2020, 8:36 AM · Restricted Project

Aug 26 2020

jasonliu committed rG413054400d94: [XCOFF][AIX] Support relocation generation for large code model (authored by jasonliu).
[XCOFF][AIX] Support relocation generation for large code model
Aug 26 2020, 10:13 AM
jasonliu closed D84549: [XCOFF][AIX] Support relocation generation for large code model.
Aug 26 2020, 10:12 AM · Restricted Project

Aug 25 2020

jasonliu added inline comments to D84549: [XCOFF][AIX] Support relocation generation for large code model.
Aug 25 2020, 7:47 AM · Restricted Project

Aug 20 2020

jasonliu added inline comments to D84549: [XCOFF][AIX] Support relocation generation for large code model.
Aug 20 2020, 10:02 AM · Restricted Project
jasonliu updated the diff for D84549: [XCOFF][AIX] Support relocation generation for large code model.

Report fatal error when we know the initial 64kb TOC region is not enough to contain all the TOC entries.

Aug 20 2020, 9:55 AM · Restricted Project

Aug 18 2020

jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Aug 18 2020, 10:00 AM · Restricted Project
jasonliu committed rGf48eced390dc: [XCOFF] emit .rename for .lcomm when necessary (authored by jasonliu).
[XCOFF] emit .rename for .lcomm when necessary
Aug 18 2020, 8:33 AM
jasonliu closed D86075: [XCOFF] emit .rename for .lcomm when necessary.
Aug 18 2020, 8:33 AM · Restricted Project
jasonliu added inline comments to D84549: [XCOFF][AIX] Support relocation generation for large code model.
Aug 18 2020, 8:29 AM · Restricted Project

Aug 17 2020

jasonliu accepted D84265: [AIX][XCOFF] emit symbol visibility for xcoff object file..

LGTM.

Aug 17 2020, 1:43 PM · Restricted Project
jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Aug 17 2020, 8:12 AM · Restricted Project
jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Aug 17 2020, 7:58 AM · Restricted Project
jasonliu requested review of D86075: [XCOFF] emit .rename for .lcomm when necessary.
Aug 17 2020, 6:58 AM · Restricted Project
jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Aug 17 2020, 6:33 AM · Restricted Project
jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Aug 17 2020, 6:31 AM · Restricted Project

Aug 14 2020

jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Aug 14 2020, 12:38 PM · Restricted Project

Aug 13 2020

jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Aug 13 2020, 1:31 PM · Restricted Project