Page MenuHomePhabricator

jasonliu (Jason Liu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2016, 1:13 PM (182 w, 3 d)

Recent Activity

Today

jasonliu added a comment to D72973: using symbol index+symbol name + storage mapping class as label for llvm-objdump -D.

I'm not seeing any changes to the output of llvm-readobj's relocation symbol info (We still only print the symbol name). Are we planning to do it in a follow up patch instead?

Mon, Jan 20, 3:14 PM · Restricted Project
jasonliu added a comment to D72027: [XCOFF][AIX] Support basic relocation type on AIX.

Ping.

Mon, Jan 20, 9:02 AM · Restricted Project
jasonliu added a comment to D72644: [clang] Add -fignore-exceptions.

Ping.

Mon, Jan 20, 9:02 AM

Thu, Jan 16

jasonliu updated the diff for D72027: [XCOFF][AIX] Support basic relocation type on AIX.

Addressed David's comment.

  1. Added const.
  2. Make the assertions useful.
Thu, Jan 16, 2:06 PM · Restricted Project
jasonliu accepted D72347: [NFC][XCOFF] Refactor Csect creation into TargetLoweringObjectFile.

Other than some minor nits. LGTM.

Thu, Jan 16, 7:01 AM · Restricted Project

Wed, Jan 15

jasonliu added inline comments to D72347: [NFC][XCOFF] Refactor Csect creation into TargetLoweringObjectFile.
Wed, Jan 15, 7:16 AM · Restricted Project

Mon, Jan 13

jasonliu created D72644: [clang] Add -fignore-exceptions.
Mon, Jan 13, 1:43 PM
jasonliu updated the diff for D72027: [XCOFF][AIX] Support basic relocation type on AIX.

Address some minor concerns Hubert have in the offline discussion:

  1. Get symbol table index using SymA directly, if we can't find it in the symbol table, then find its csect in the symbol table.
  2. return pairs using uniform init directly in the switch.
Mon, Jan 13, 7:53 AM · Restricted Project
jasonliu added a comment to D71845: [AIX][XCOFF] add test for raw text section content and test section header.

Ping on author. Any plan to move this forward? Should it sit in "Plan Changes" queue.

Mon, Jan 13, 7:06 AM · Restricted Project

Fri, Jan 10

jasonliu added inline comments to D72347: [NFC][XCOFF] Refactor Csect creation into TargetLoweringObjectFile.
Fri, Jan 10, 9:53 AM · Restricted Project
jasonliu committed rGdfed052fb3ec: [AIX] Allow vararg calls when all arguments reside in registers (authored by jasonliu).
[AIX] Allow vararg calls when all arguments reside in registers
Fri, Jan 10, 9:35 AM
jasonliu closed D71013: [AIX] Allow vararg calls when all arguments reside in registers..
Fri, Jan 10, 9:35 AM · Restricted Project

Thu, Jan 9

jasonliu accepted D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.

LGTM.

Thu, Jan 9, 10:42 AM · Restricted Project

Wed, Jan 8

jasonliu added inline comments to D72027: [XCOFF][AIX] Support basic relocation type on AIX.
Wed, Jan 8, 11:08 AM · Restricted Project
jasonliu updated the diff for D72027: [XCOFF][AIX] Support basic relocation type on AIX.

Addressed first round of comments.

Wed, Jan 8, 10:59 AM · Restricted Project
jasonliu added inline comments to D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.
Wed, Jan 8, 7:40 AM · Restricted Project

Tue, Jan 7

jasonliu added inline comments to D72027: [XCOFF][AIX] Support basic relocation type on AIX.
Tue, Jan 7, 8:49 AM · Restricted Project
jasonliu added inline comments to D72027: [XCOFF][AIX] Support basic relocation type on AIX.
Tue, Jan 7, 8:11 AM · Restricted Project

Mon, Jan 6

jasonliu added inline comments to D72027: [XCOFF][AIX] Support basic relocation type on AIX.
Mon, Jan 6, 1:57 PM · Restricted Project
jasonliu updated the summary of D72027: [XCOFF][AIX] Support basic relocation type on AIX.
Mon, Jan 6, 12:33 PM · Restricted Project
jasonliu added inline comments to D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.
Mon, Jan 6, 8:06 AM · Restricted Project

Fri, Jan 3

jasonliu added inline comments to D72027: [XCOFF][AIX] Support basic relocation type on AIX.
Fri, Jan 3, 6:21 PM · Restricted Project

Mon, Dec 30

jasonliu created D72027: [XCOFF][AIX] Support basic relocation type on AIX.
Mon, Dec 30, 7:55 PM · Restricted Project
jasonliu committed rG991f7abdfc55: [NFC] Add comments in unit test aix-xcoff-toc.ll to clarify the intent (authored by jasonliu).
[NFC] Add comments in unit test aix-xcoff-toc.ll to clarify the intent
Mon, Dec 30, 7:37 PM

Dec 19 2019

jasonliu added inline comments to D71667: [XCOFF][AIX] Fix for missing of undefined symbols from symbol table.
Dec 19 2019, 2:04 PM · Restricted Project
jasonliu added inline comments to D71667: [XCOFF][AIX] Fix for missing of undefined symbols from symbol table.
Dec 19 2019, 1:42 PM · Restricted Project
jasonliu committed rGac741f98c177: [XCOFF][AIX] Fix for missing of undefined symbols from symbol table (authored by jasonliu).
[XCOFF][AIX] Fix for missing of undefined symbols from symbol table
Dec 19 2019, 1:23 PM
jasonliu closed D71667: [XCOFF][AIX] Fix for missing of undefined symbols from symbol table.
Dec 19 2019, 1:22 PM · Restricted Project

Dec 18 2019

jasonliu retitled D71667: [XCOFF][AIX] Fix for missing of undefined symbols from symbol table from [XCOFF][AIX] Fix for some undefined symbol are not generated issue to [XCOFF][AIX] Fix for missing of undefined symbols from symbol table.
Dec 18 2019, 11:26 AM · Restricted Project
jasonliu created D71667: [XCOFF][AIX] Fix for missing of undefined symbols from symbol table.
Dec 18 2019, 9:26 AM · Restricted Project
jasonliu added inline comments to D71144: [AIX] Use csect reference for function address constants.
Dec 18 2019, 8:38 AM · Restricted Project

Dec 17 2019

jasonliu added inline comments to D71144: [AIX] Use csect reference for function address constants.
Dec 17 2019, 1:56 PM · Restricted Project
jasonliu added inline comments to D71144: [AIX] Use csect reference for function address constants.
Dec 17 2019, 12:37 PM · Restricted Project

Dec 16 2019

jasonliu added inline comments to D71551: [AIX][XCOFF]Implement mergeable const.
Dec 16 2019, 3:27 PM · Restricted Project

Dec 5 2019

jasonliu added a comment to D70859: [BUG-FIX][XCOFF] fixed a bug of XCOFFObjectFile.cpp when there is padding at the last csect of a sections.

I agree with David about splitting. There are 4 issues mentioned in this patch, and they are not related. (I'm not sure if 1 or 3 could be combine or not)
Putting them together makes it hard to review, and hard to determine if the test case actually covered the issue that's raised.
Let's make separate patches if possible.

Dec 5 2019, 9:14 AM · Restricted Project
jasonliu accepted D71032: [AIX] Make sure to use QualNames for external global objects.

LGTM with minor nit.

Dec 5 2019, 9:05 AM · Restricted Project
jasonliu added inline comments to D71032: [AIX] Make sure to use QualNames for external global objects.
Dec 5 2019, 7:33 AM · Restricted Project

Dec 4 2019

jasonliu committed rG5422e81a89f5: [XCOFF][AIX] Emit TOC entries for object file generation (authored by jasonliu).
[XCOFF][AIX] Emit TOC entries for object file generation
Dec 4 2019, 8:46 AM
jasonliu closed D70798: [XCOFF][AIX] Emit TOC entries for object file generation.
Dec 4 2019, 8:46 AM · Restricted Project

Dec 3 2019

jasonliu added inline comments to D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.
Dec 3 2019, 12:53 PM · Restricted Project
jasonliu updated the diff for D70798: [XCOFF][AIX] Emit TOC entries for object file generation.

Address David and Digger's comment.

Dec 3 2019, 9:00 AM · Restricted Project
jasonliu added inline comments to D70798: [XCOFF][AIX] Emit TOC entries for object file generation.
Dec 3 2019, 8:59 AM · Restricted Project

Nov 28 2019

jasonliu updated the diff for D70798: [XCOFF][AIX] Emit TOC entries for object file generation.

Fixed incorrect TOC-base alignment.

Nov 28 2019, 8:53 AM · Restricted Project

Nov 27 2019

jasonliu created D70798: [XCOFF][AIX] Emit TOC entries for object file generation.
Nov 27 2019, 2:54 PM · Restricted Project
jasonliu accepted D70461: [AIX] Emit TOC entries for ASM printing.

Minor nit that could be address while landing.
Otherwise LGTM.

Nov 27 2019, 1:38 PM · Restricted Project
jasonliu added inline comments to D70461: [AIX] Emit TOC entries for ASM printing.
Nov 27 2019, 12:47 PM · Restricted Project

Nov 26 2019

jasonliu added inline comments to D70461: [AIX] Emit TOC entries for ASM printing.
Nov 26 2019, 8:23 PM · Restricted Project
jasonliu added inline comments to D70461: [AIX] Emit TOC entries for ASM printing.
Nov 26 2019, 12:06 PM · Restricted Project
jasonliu accepted D70675: [AIX] Disable clang python binding tests.

LGTM.

Nov 26 2019, 10:58 AM · Restricted Project
jasonliu added inline comments to D70461: [AIX] Emit TOC entries for ASM printing.
Nov 26 2019, 10:40 AM · Restricted Project
jasonliu committed rG7707d8aa9db8: [XCOFF][AIX] Check linkage on the function, and two fixes for comments (authored by jasonliu).
[XCOFF][AIX] Check linkage on the function, and two fixes for comments
Nov 26 2019, 8:16 AM
jasonliu added a comment to D70443: [AIX][XCOFF] Generate undefined symbol in symbol table for external function call.

Addressed post review comments in https://github.com/llvm/llvm-project/commit/7707d8aa9db8aa3814593f9c40cc707f306e3ae2

Nov 26 2019, 8:16 AM · Restricted Project

Nov 25 2019

jasonliu added inline comments to D70461: [AIX] Emit TOC entries for ASM printing.
Nov 25 2019, 3:24 PM · Restricted Project
jasonliu committed rG906ecae2ed8b: [AIX][XCOFF] Generate undefined symbol in symbol table for external function… (authored by jasonliu).
[AIX][XCOFF] Generate undefined symbol in symbol table for external function…
Nov 25 2019, 7:19 AM
jasonliu closed D70443: [AIX][XCOFF] Generate undefined symbol in symbol table for external function call.
Nov 25 2019, 7:19 AM · Restricted Project

Nov 22 2019

jasonliu committed rGaf8576ff9d5a: [XCOFF][AIX] Read-only data section object file generation (authored by jasonliu).
[XCOFF][AIX] Read-only data section object file generation
Nov 22 2019, 7:50 AM
jasonliu closed D70455: [XCOFF][AIX] Read-only data section object file generation.
Nov 22 2019, 7:50 AM · Restricted Project

Nov 21 2019

jasonliu added inline comments to D70455: [XCOFF][AIX] Read-only data section object file generation.
Nov 21 2019, 9:10 AM · Restricted Project
jasonliu updated the diff for D70455: [XCOFF][AIX] Read-only data section object file generation.

Added -verify-machine-instr and -mcpu for consistency.
Added raw data testing.

Nov 21 2019, 9:06 AM · Restricted Project
jasonliu added inline comments to D70455: [XCOFF][AIX] Read-only data section object file generation.
Nov 21 2019, 7:14 AM · Restricted Project

Nov 20 2019

jasonliu updated the diff for D70455: [XCOFF][AIX] Read-only data section object file generation.

Fix test.

Nov 20 2019, 10:58 AM · Restricted Project
jasonliu added inline comments to D70443: [AIX][XCOFF] Generate undefined symbol in symbol table for external function call.
Nov 20 2019, 8:07 AM · Restricted Project
jasonliu updated the diff for D70443: [AIX][XCOFF] Generate undefined symbol in symbol table for external function call.

Removed unnecessary assertion.

Nov 20 2019, 8:07 AM · Restricted Project
jasonliu added inline comments to D70461: [AIX] Emit TOC entries for ASM printing.
Nov 20 2019, 7:38 AM · Restricted Project

Nov 19 2019

jasonliu updated the summary of D70455: [XCOFF][AIX] Read-only data section object file generation.
Nov 19 2019, 12:15 PM · Restricted Project
jasonliu created D70455: [XCOFF][AIX] Read-only data section object file generation.
Nov 19 2019, 12:06 PM · Restricted Project
jasonliu added a comment to D70243: Lowering CPI/JTI/BA to assembly.

For comparison, gcc generates the value of constant pool data directly into the TC entry. It's faster and garbage collectable if not used.

I did some investigation about LLVM constant pool, as I remember, except for int value which will be put directly into TC entry, others like double, float etc. will be put into constant pool in LLVM. If we want to mimic GCC behavior, it probably would be a large piece of refactoring.

I don't think llvm actually try to put int directly into TC entry, it always put a label in TC entry, or we just use that integer value directly in the assembly. But please correct me if I'm wrong.
We don't need to switch to that behavior right now, but later when we care about performance then we might want to think about it.
Here's my test case:

Nov 19 2019, 9:11 AM · Restricted Project
jasonliu closed D70271: [AIX][XCOFF] Write Function descriptors and TOC base to data section.

Landed with https://github.com/llvm/llvm-project/commit/c9edaa828eb84a62af2042a1a64168e32ea32924

Nov 19 2019, 8:24 AM · Restricted Project
jasonliu committed rGc9edaa828eb8: [AIX][XCOFF] Write Function descriptors and TOC base to data section (authored by jasonliu).
[AIX][XCOFF] Write Function descriptors and TOC base to data section
Nov 19 2019, 8:15 AM
jasonliu created D70443: [AIX][XCOFF] Generate undefined symbol in symbol table for external function call.
Nov 19 2019, 7:46 AM · Restricted Project
jasonliu accepted D70243: Lowering CPI/JTI/BA to assembly.
Nov 19 2019, 6:54 AM · Restricted Project

Nov 18 2019

jasonliu added inline comments to D70243: Lowering CPI/JTI/BA to assembly.
Nov 18 2019, 4:36 PM · Restricted Project
jasonliu added a comment to D70243: Lowering CPI/JTI/BA to assembly.

Some observation for constant pool lowering:
We put all the constant pool data into rodata section, and create one TC entry per constant pool reference.
It hinders the ability for linker to garbage collect unused data. (Generates them into a separate RO section helps a bit, but won't fully solve this issue)
And we would also create a lot of TC entries for constant pool that might not get cleanup.

Nov 18 2019, 4:00 PM · Restricted Project
jasonliu added a comment to D70243: Lowering CPI/JTI/BA to assembly.

Sorry, please ignore the test did not come clean comments. I realized my branch did not have D70182 in it. After pulling it in, the test works as expected.
I will continue my review.

Nov 18 2019, 2:31 PM · Restricted Project
jasonliu requested changes to D70243: Lowering CPI/JTI/BA to assembly.
Nov 18 2019, 2:19 PM · Restricted Project
jasonliu added a comment to D70243: Lowering CPI/JTI/BA to assembly.

The "make check-all" did not return clean for the test case you just added.
There is mismatch for the test result and assertions. You might be missing something in the code that you modified.

Nov 18 2019, 2:19 PM · Restricted Project
jasonliu added a comment to D70182: Add read-only data assembly writing.

Test case is missing when the change is landed. Please add it back.

Nov 18 2019, 2:01 PM · Restricted Project
jasonliu added inline comments to D70271: [AIX][XCOFF] Write Function descriptors and TOC base to data section.
Nov 18 2019, 12:48 PM · Restricted Project
jasonliu added a comment to D70271: [AIX][XCOFF] Write Function descriptors and TOC base to data section.

I believe I addressed all the comments. Thanks.

Nov 18 2019, 12:48 PM · Restricted Project
jasonliu updated the diff for D70271: [AIX][XCOFF] Write Function descriptors and TOC base to data section.

Added separate CsectGroup to contain function descriptor csects.
Added assertion to assert uniqueness TOC base.

Nov 18 2019, 12:48 PM · Restricted Project

Nov 15 2019

jasonliu added inline comments to D70271: [AIX][XCOFF] Write Function descriptors and TOC base to data section.
Nov 15 2019, 1:12 PM · Restricted Project
jasonliu added a comment to D70271: [AIX][XCOFF] Write Function descriptors and TOC base to data section.

Do we care about asserting the uniqueness of the TOC anchor somewhere?

Nov 15 2019, 1:12 PM · Restricted Project
jasonliu added inline comments to D70126: [PowerPC] Refactor FinishCall [NFC].
Nov 15 2019, 12:28 PM · Restricted Project
jasonliu added a comment to D70243: Lowering CPI/JTI/BA to assembly.

When I apply your patch to master, it didn't apply cleanly. So please rebase.
And when I did some work to manually apply it, and run through clang-format, clang-format changed several places.
I suspect it's due to the tabs vs space issue.
I suggest to update this patch with after running the clang-format on it.

Nov 15 2019, 10:59 AM · Restricted Project
jasonliu added inline comments to D70243: Lowering CPI/JTI/BA to assembly.
Nov 15 2019, 7:42 AM · Restricted Project
jasonliu added a comment to D70243: Lowering CPI/JTI/BA to assembly.

I'm not able to apply this patch cleanly because rebase. Thank you.

Nov 15 2019, 7:33 AM · Restricted Project
jasonliu added inline comments to D69578: [AIX] Add support for lowering int, float and double formal arguments..
Nov 15 2019, 7:15 AM · Restricted Project

Nov 14 2019

jasonliu created D70271: [AIX][XCOFF] Write Function descriptors and TOC base to data section.
Nov 14 2019, 1:57 PM · Restricted Project

Nov 5 2019

jasonliu added inline comments to D69633: [XCOFF][AIX] Differentiate usage of label symbol and csect symbol.
Nov 5 2019, 3:15 PM · Restricted Project
jasonliu added inline comments to D69633: [XCOFF][AIX] Differentiate usage of label symbol and csect symbol.
Nov 5 2019, 8:37 AM · Restricted Project

Oct 30 2019

jasonliu created D69633: [XCOFF][AIX] Differentiate usage of label symbol and csect symbol.
Oct 30 2019, 12:38 PM · Restricted Project
jasonliu committed rG8bd0c9781001: [PowerPC][AIX] Adds support for writing the data section in object files (authored by jasonliu).
[PowerPC][AIX] Adds support for writing the data section in object files
Oct 30 2019, 11:51 AM
jasonliu closed D67125: [PowerPC][AIX] Adds support for writing the data section in object files.
Oct 30 2019, 11:50 AM · Restricted Project

Oct 28 2019

jasonliu committed rGd83a2faacd3b: [NFCI][XCOFF][AIX] Skip empty Section during object file generation (authored by jasonliu).
[NFCI][XCOFF][AIX] Skip empty Section during object file generation
Oct 28 2019, 3:30 PM
jasonliu closed D69447: [NFCI][XCOFF][AIX] Skip empty Section during object file generation.
Oct 28 2019, 3:29 PM · Restricted Project
jasonliu added a comment to D69528: [PowerPC][XCOFF] Add assembly support for zero initalized global values..

This patch is going to have conflict with D67125. Depending on which patch is going to go land first. The test case is likely need to get modified.

Oct 28 2019, 2:56 PM · Restricted Project

Oct 26 2019

jasonliu added inline comments to D69447: [NFCI][XCOFF][AIX] Skip empty Section during object file generation.
Oct 26 2019, 9:44 AM · Restricted Project
jasonliu updated the diff for D69447: [NFCI][XCOFF][AIX] Skip empty Section during object file generation.

Change SectionCount type to unsigned.

Oct 26 2019, 9:39 AM · Restricted Project

Oct 25 2019

jasonliu updated the diff for D69447: [NFCI][XCOFF][AIX] Skip empty Section during object file generation.
Oct 25 2019, 2:01 PM · Restricted Project
jasonliu created D69447: [NFCI][XCOFF][AIX] Skip empty Section during object file generation.
Oct 25 2019, 1:15 PM · Restricted Project