Page MenuHomePhabricator

jasonliu (Jason Liu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2016, 1:13 PM (310 w, 5 d)

Recent Activity

Aug 27 2021

jasonliu committed rGfe177a1773e4: Fix assertion when passing function into inline asm's input operand (authored by jasonliu).
Fix assertion when passing function into inline asm's input operand
Aug 27 2021, 10:40 AM
jasonliu closed D107941: Fix assertion when passing function into inline asm's input operand.
Aug 27 2021, 10:40 AM · Restricted Project

Aug 8 2021

jasonliu added a comment to D100777: [libc++] Add missing short wchar handling for codecvt_utf8, codecvt_utf16 and codecvt_utf8_utf16 .

@daltenty @xingxue
Since I don't have access to AIX machine any more, would you help to test and land this patch if this still aligns to what you want on AIX?
If not, feel free to commandeering this patch if needed.

Aug 8 2021, 8:21 PM · Restricted Project

Jul 28 2021

jasonliu committed rG363a8a05988d: [libc++] money_get::do_get() set failbit and eofbit if iterator begin equals end (authored by jasonliu).
[libc++] money_get::do_get() set failbit and eofbit if iterator begin equals end
Jul 28 2021, 7:23 PM
jasonliu closed D100510: [libc++] money_get::do_get() set failbit and eofbit if iterator begin equals end.
Jul 28 2021, 7:23 PM · Restricted Project
jasonliu added a comment to D100777: [libc++] Add missing short wchar handling for codecvt_utf8, codecvt_utf16 and codecvt_utf8_utf16 .

In practice, which cases didn't work as they should in that configuration before? I haven't noticed that aspect anywhere in the libc++ tests on Windows (although it could be hidden by some XFAIL: LIBCXX-WINDOWS-FIXME, but that would show up as XPASS in that case too).

Jul 28 2021, 3:25 PM · Restricted Project

Jul 27 2021

jasonliu updated the diff for D100777: [libc++] Add missing short wchar handling for codecvt_utf8, codecvt_utf16 and codecvt_utf8_utf16 .

Rebase to trigger CI.

Jul 27 2021, 5:01 PM · Restricted Project

Jul 1 2021

jasonliu committed rGa319eafd160d: [libc++] Provide c++03 alternative for va_copy if available in xlocale.h (authored by jasonliu).
[libc++] Provide c++03 alternative for va_copy if available in xlocale.h
Jul 1 2021, 11:03 AM
jasonliu closed D100336: [libc++] Provide c++03 alternative for va_copy if available in xlocale.h.
Jul 1 2021, 11:03 AM · Restricted Project

Jun 30 2021

jasonliu added a comment to D100336: [libc++] Provide c++03 alternative for va_copy if available in xlocale.h.

Ping.
@ldionne Any comments?

Jun 30 2021, 12:50 PM · Restricted Project
jasonliu added a comment to D100510: [libc++] money_get::do_get() set failbit and eofbit if iterator begin equals end.

Ping.
@ldionne Any comments?

Jun 30 2021, 12:48 PM · Restricted Project
jasonliu added 1 blocking reviewer(s) for D100510: [libc++] money_get::do_get() set failbit and eofbit if iterator begin equals end: Restricted Project.
Jun 30 2021, 12:47 PM · Restricted Project
jasonliu added a comment to D102172: [libc++][AIX] Use C++ overloads from libc++'s math.h.

Ping.
@ldionne any comments?

Jun 30 2021, 12:46 PM · Restricted Project, Restricted Project
jasonliu added 1 blocking reviewer(s) for D102172: [libc++][AIX] Use C++ overloads from libc++'s math.h: Restricted Project.
Jun 30 2021, 12:46 PM · Restricted Project, Restricted Project
jasonliu accepted D105195: [AIX][XCOFF][BUG-Fixed] need to switch back to text section after emit a dumy eh structure.

LGTM. Thanks.

Jun 30 2021, 7:54 AM · Restricted Project

Jun 28 2021

jasonliu added inline comments to D105023: [AIX][XCOFF][Bug-Fixed] parse the parameter type of the traceback table..
Jun 28 2021, 8:24 AM · Restricted Project
jasonliu added inline comments to D105023: [AIX][XCOFF][Bug-Fixed] parse the parameter type of the traceback table..
Jun 28 2021, 6:54 AM · Restricted Project

Jun 22 2021

jasonliu abandoned D102844: XFAIL align.pass.pass.cpp on aix regarding atomic alignment.

is_lock_free actually returns false for this structure:
struct LLIArr2 { long long int i[2]; };

Jun 22 2021, 12:14 PM
jasonliu commandeered D102844: XFAIL align.pass.pass.cpp on aix regarding atomic alignment.
Jun 22 2021, 12:14 PM
jasonliu accepted D103651: [AIX][XCOFF] generate eh_info when vector registers are saved according to the traceback table..

LGTM. Thanks!

Jun 22 2021, 6:58 AM · Restricted Project

Jun 21 2021

jasonliu added inline comments to D103651: [AIX][XCOFF] generate eh_info when vector registers are saved according to the traceback table..
Jun 21 2021, 8:48 AM · Restricted Project
jasonliu added inline comments to D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.
Jun 21 2021, 7:58 AM · Restricted Project, Restricted Project, Restricted Project

Jun 17 2021

jasonliu added inline comments to D103651: [AIX][XCOFF] generate eh_info when vector registers are saved according to the traceback table..
Jun 17 2021, 11:51 AM · Restricted Project
jasonliu added inline comments to D103651: [AIX][XCOFF] generate eh_info when vector registers are saved according to the traceback table..
Jun 17 2021, 11:39 AM · Restricted Project
jasonliu committed rG4e2aee8d3bab: [AIX] Remove --as-needed passing into aix linker (authored by jasonliu).
[AIX] Remove --as-needed passing into aix linker
Jun 17 2021, 10:17 AM
jasonliu closed D104314: [AIX] Remove --as-needed passing into aix linker.
Jun 17 2021, 10:17 AM · Restricted Project

Jun 15 2021

jasonliu requested review of D104314: [AIX] Remove --as-needed passing into aix linker.
Jun 15 2021, 11:40 AM · Restricted Project

Jun 11 2021

jasonliu accepted D93659: [AIX][XCOFF] emit vector info of traceback table..

LGTM; Thanks!

Jun 11 2021, 10:24 AM · Restricted Project

Jun 10 2021

jasonliu added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Jun 10 2021, 11:31 AM · Restricted Project
jasonliu added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Jun 10 2021, 11:26 AM · Restricted Project

Jun 9 2021

jasonliu added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Jun 9 2021, 12:00 PM · Restricted Project

Jun 7 2021

jasonliu added inline comments to D103651: [AIX][XCOFF] generate eh_info when vector registers are saved according to the traceback table..
Jun 7 2021, 1:30 PM · Restricted Project
jasonliu added a comment to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

Looks good again. Sorry for the delay - I was off work last week.

Jun 7 2021, 10:27 AM · Restricted Project
jasonliu committed rG8e84311a84b3: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing (authored by jasonliu).
[XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing
Jun 7 2021, 10:26 AM
jasonliu closed D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Jun 7 2021, 10:25 AM · Restricted Project

Jun 4 2021

jasonliu added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Jun 4 2021, 9:52 AM · Restricted Project
jasonliu added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Jun 4 2021, 9:18 AM · Restricted Project
jasonliu added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Jun 4 2021, 8:35 AM · Restricted Project

Jun 3 2021

jasonliu added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Jun 3 2021, 7:18 AM · Restricted Project

May 28 2021

jasonliu accepted D102632: [libcxx/cxxabi/unwind][AIX] Add an AIX target and config for testing..
May 28 2021, 11:26 AM · Restricted Project
jasonliu added a comment to D102632: [libcxx/cxxabi/unwind][AIX] Add an AIX target and config for testing..

LGTM on AIX perspective.
FYI, we will need two reviewers from libc++ review group or the maintainer of libc++ project to approve before we could land.

May 28 2021, 11:26 AM · Restricted Project
jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
May 28 2021, 8:21 AM · Restricted Project
jasonliu updated the diff for D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

Adjustment the print out.

May 28 2021, 8:20 AM · Restricted Project

May 27 2021

jasonliu committed rG7922ff601094: [AIX] Add -lc++abi and -lunwind for linking (authored by jasonliu).
[AIX] Add -lc++abi and -lunwind for linking
May 27 2021, 8:49 AM
jasonliu closed D102813: [AIX] Add -lc++abi and -lunwind for linking.
May 27 2021, 8:49 AM · Restricted Project

May 19 2021

jasonliu updated the diff for D102813: [AIX] Add -lc++abi and -lunwind for linking.
May 19 2021, 4:53 PM · Restricted Project
jasonliu added a comment to D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen".

Good idea, fyi, this is the patch: https://reviews.llvm.org/D83252

May 19 2021, 2:33 PM · Restricted Project, Restricted Project
jasonliu requested review of D102813: [AIX] Add -lc++abi and -lunwind for linking.
May 19 2021, 2:18 PM · Restricted Project
jasonliu accepted D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen".

LGTM.

May 19 2021, 2:11 PM · Restricted Project, Restricted Project

May 18 2021

jasonliu added inline comments to D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen".
May 18 2021, 2:28 PM · Restricted Project, Restricted Project

May 17 2021

jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
May 17 2021, 8:51 AM · Restricted Project
jasonliu updated the diff for D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

Address comments.

May 17 2021, 8:50 AM · Restricted Project

May 14 2021

jasonliu added a comment to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

I took a quick look at the pre-merge output. The message is that the object isn't recognised as a valid object file, not that it wasn't found, which suggests either the object or code is broken in some manner, or you're missing a dependent patch. Does this patch depend on another patch that isn't in main yet?

May 14 2021, 10:49 AM · Restricted Project
jasonliu updated the diff for D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

Address comments.

May 14 2021, 10:46 AM · Restricted Project

May 13 2021

jasonliu updated the diff for D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

Address comments.

May 13 2021, 2:12 PM · Restricted Project
jasonliu updated the diff for D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
May 13 2021, 1:12 PM · Restricted Project
jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
May 13 2021, 12:47 PM · Restricted Project
jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
May 13 2021, 11:19 AM · Restricted Project
jasonliu updated the diff for D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

Address comments.

May 13 2021, 11:15 AM · Restricted Project

May 10 2021

jasonliu requested review of D102172: [libc++][AIX] Use C++ overloads from libc++'s math.h.
May 10 2021, 7:55 AM · Restricted Project, Restricted Project
jasonliu committed rG4677d795b204: [libc++][AIX] Define _LIBCPP_ELAST (authored by jasonliu).
[libc++][AIX] Define _LIBCPP_ELAST
May 10 2021, 6:55 AM
jasonliu closed D100986: [libc++][AIX] Define _LIBCPP_ELAST.
May 10 2021, 6:54 AM · Restricted Project

May 6 2021

jasonliu added inline comments to D101959: [libc++/abi/unwind][AIX] Add scripts and cache file for building libc++/libc++abi/libunwind.
May 6 2021, 12:11 PM · Restricted Project
jasonliu added a comment to D101959: [libc++/abi/unwind][AIX] Add scripts and cache file for building libc++/libc++abi/libunwind.

It would help if we could put the sample invocation in the summary.

May 6 2021, 11:54 AM · Restricted Project

May 5 2021

jasonliu added a comment to D100986: [libc++][AIX] Define _LIBCPP_ELAST.

Gentle ping.

May 5 2021, 11:52 AM · Restricted Project
jasonliu updated the diff for D100777: [libc++] Add missing short wchar handling for codecvt_utf8, codecvt_utf16 and codecvt_utf8_utf16 .

Updated test case to account for short wchar_t.

May 5 2021, 11:08 AM · Restricted Project
jasonliu added a comment to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

@jhenderson @DiggerLin @Esme
Any more comments?

I'll try to take another look in the next day or two. The pre-merge bots are failing. Is that an issue with this patch?

May 5 2021, 8:05 AM · Restricted Project
jasonliu added a comment to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

@jhenderson @DiggerLin @Esme
Any more comments?

May 5 2021, 7:52 AM · Restricted Project

Apr 30 2021

jasonliu added a comment to D100510: [libc++] money_get::do_get() set failbit and eofbit if iterator begin equals end.

Ping.

Apr 30 2021, 7:47 AM · Restricted Project
jasonliu updated the diff for D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

Address comments.

Apr 30 2021, 7:22 AM · Restricted Project

Apr 29 2021

jasonliu committed rG7049fbf960df: [XCOFF] Handle the case when personality routine is an alias (authored by jasonliu).
[XCOFF] Handle the case when personality routine is an alias
Apr 29 2021, 3:03 PM
jasonliu closed D101401: [XCOFF] Handle the case when personality routine is an alias.
Apr 29 2021, 3:03 PM · Restricted Project
jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Apr 29 2021, 2:22 PM · Restricted Project
jasonliu updated the diff for D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

Address comments.

Apr 29 2021, 2:21 PM · Restricted Project
jasonliu planned changes to D100777: [libc++] Add missing short wchar handling for codecvt_utf8, codecvt_utf16 and codecvt_utf8_utf16 .

As expected, this changes the behavior of windows platform for the do_length and do_max_length of __codecvt_utf8<wchar_t>.
But I think the changes are actually desired. Could anyone working on Windows platform confirm that?
If we could agree on that, then I could work on updating the test case.

Apr 29 2021, 1:35 PM · Restricted Project
jasonliu updated the diff for D101401: [XCOFF] Handle the case when personality routine is an alias.

Address comments.

Apr 29 2021, 8:33 AM · Restricted Project

Apr 28 2021

jasonliu added a reviewer for D101401: [XCOFF] Handle the case when personality routine is an alias: sfertile.
Apr 28 2021, 10:44 AM · Restricted Project
jasonliu updated the diff for D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

Address comments.

Apr 28 2021, 9:07 AM · Restricted Project
jasonliu updated the diff for D100986: [libc++][AIX] Define _LIBCPP_ELAST.

rebase to clean the pre-commit ci

Apr 28 2021, 7:33 AM · Restricted Project

Apr 27 2021

jasonliu requested review of D101401: [XCOFF] Handle the case when personality routine is an alias.
Apr 27 2021, 2:39 PM · Restricted Project
jasonliu added a comment to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

Ping.

Apr 27 2021, 8:33 AM · Restricted Project
jasonliu updated the diff for D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

Address clang-tidy comment and added binary file.

Apr 27 2021, 8:33 AM · Restricted Project

Apr 26 2021

jasonliu added a comment to D100777: [libc++] Add missing short wchar handling for codecvt_utf8, codecvt_utf16 and codecvt_utf8_utf16 .

Why did you have to add a specialization based on size? Could you provide a test case or two to help explain. My first thought is the _LIBCPP_SHORT_WCHAR macro should be good enough since aix & z/OS only support one wchar_t size per 32/64 bit mode.

With -fshort-wchar, you could have a short wchar in 64 bit mode. So this implementation still gives you the correct result if that's used.

Apr 26 2021, 10:24 AM · Restricted Project
jasonliu updated the diff for D100777: [libc++] Add missing short wchar handling for codecvt_utf8, codecvt_utf16 and codecvt_utf8_utf16 .
Apr 26 2021, 10:21 AM · Restricted Project

Apr 23 2021

jasonliu added a comment to D100510: [libc++] money_get::do_get() set failbit and eofbit if iterator begin equals end.

Gentle ping for libc++ group's review.

Apr 23 2021, 7:16 AM · Restricted Project
jasonliu added a comment to D100336: [libc++] Provide c++03 alternative for va_copy if available in xlocale.h.

Gentle ping.

Apr 23 2021, 7:04 AM · Restricted Project

Apr 22 2021

jasonliu added a comment to D100777: [libc++] Add missing short wchar handling for codecvt_utf8, codecvt_utf16 and codecvt_utf8_utf16 .

Why did you have to add a specialization based on size? Could you provide a test case or two to help explain. My first thought is the _LIBCPP_SHORT_WCHAR macro should be good enough since aix & z/OS only support one wchar_t size per 32/64 bit mode.

Apr 22 2021, 1:11 PM · Restricted Project
jasonliu added inline comments to D100986: [libc++][AIX] Define _LIBCPP_ELAST.
Apr 22 2021, 9:17 AM · Restricted Project

Apr 21 2021

jasonliu added inline comments to D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.
Apr 21 2021, 1:04 PM · Restricted Project, Restricted Project, Restricted Project
jasonliu requested review of D100986: [libc++][AIX] Define _LIBCPP_ELAST.
Apr 21 2021, 12:01 PM · Restricted Project

Apr 20 2021

jasonliu added inline comments to D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.
Apr 20 2021, 12:31 PM · Restricted Project, Restricted Project, Restricted Project
jasonliu updated the diff for D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Apr 20 2021, 9:16 AM · Restricted Project
jasonliu added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Apr 20 2021, 9:12 AM · Restricted Project
jasonliu updated the diff for D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

Rebase and Address comments.

Apr 20 2021, 9:11 AM · Restricted Project

Apr 19 2021

jasonliu added a comment to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

@Esme I will rebase and address comments asap.

Apr 19 2021, 3:18 PM · Restricted Project
jasonliu requested review of D100777: [libc++] Add missing short wchar handling for codecvt_utf8, codecvt_utf16 and codecvt_utf8_utf16 .
Apr 19 2021, 11:07 AM · Restricted Project

Apr 16 2021

jasonliu abandoned D100333: [libc++] Config `pointer_safety` type to be backward compatible on AIX.

Abandoning this patch in favour of the approach in https://reviews.llvm.org/D100410.

Apr 16 2021, 1:22 PM

Apr 15 2021

jasonliu updated the diff for D100510: [libc++] money_get::do_get() set failbit and eofbit if iterator begin equals end.

rebase.

Apr 15 2021, 1:37 PM · Restricted Project
jasonliu updated the diff for D100510: [libc++] money_get::do_get() set failbit and eofbit if iterator begin equals end.

Run clang-format and hopefully it fix the pre-commit CI.

Apr 15 2021, 1:27 PM · Restricted Project
jasonliu updated the diff for D100510: [libc++] money_get::do_get() set failbit and eofbit if iterator begin equals end.
Apr 15 2021, 11:21 AM · Restricted Project