Page MenuHomePhabricator

DiggerLin (Digger)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 28 2019, 10:08 AM (81 w, 3 d)

Recent Activity

Tue, Sep 15

DiggerLin updated the summary of D87451: add new clang option -mignore-xcoff-visibility.
Tue, Sep 15, 10:27 AM · Restricted Project
DiggerLin updated the diff for D87451: add new clang option -mignore-xcoff-visibility.
Tue, Sep 15, 10:24 AM · Restricted Project

Mon, Sep 14

DiggerLin updated the diff for D82549: [AIX][XCOFF] parsing xcoff object file auxiliary header.

Using crtp to implement XCOFFAuxiliaryHeader32 and XCOFFAuxiliaryHeader64

Mon, Sep 14, 12:51 PM · Restricted Project
DiggerLin added inline comments to D82549: [AIX][XCOFF] parsing xcoff object file auxiliary header.
Mon, Sep 14, 12:50 PM · Restricted Project
DiggerLin added inline comments to D82549: [AIX][XCOFF] parsing xcoff object file auxiliary header.
Mon, Sep 14, 12:46 PM · Restricted Project

Fri, Sep 11

DiggerLin added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Fri, Sep 11, 6:24 AM · Restricted Project

Thu, Sep 10

DiggerLin added a reviewer for D87451: add new clang option -mignore-xcoff-visibility: Xiangling_L.
Thu, Sep 10, 1:24 PM · Restricted Project
DiggerLin added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Thu, Sep 10, 12:56 PM · Restricted Project
DiggerLin updated the summary of D87451: add new clang option -mignore-xcoff-visibility.
Thu, Sep 10, 10:25 AM · Restricted Project
DiggerLin updated the summary of D87451: add new clang option -mignore-xcoff-visibility.
Thu, Sep 10, 10:25 AM · Restricted Project
DiggerLin updated the diff for D87451: add new clang option -mignore-xcoff-visibility.

address comment

Thu, Sep 10, 8:37 AM · Restricted Project
DiggerLin updated the diff for D87451: add new clang option -mignore-xcoff-visibility.

add a pragma test case

Thu, Sep 10, 8:08 AM · Restricted Project
DiggerLin updated the summary of D87451: add new clang option -mignore-xcoff-visibility.
Thu, Sep 10, 6:43 AM · Restricted Project
DiggerLin updated the summary of D87451: add new clang option -mignore-xcoff-visibility.
Thu, Sep 10, 6:42 AM · Restricted Project
DiggerLin requested review of D87451: add new clang option -mignore-xcoff-visibility.
Thu, Sep 10, 6:39 AM · Restricted Project

Thu, Aug 27

DiggerLin added a reverting change for rGa08186892132: [AIX][XCOFF] emit symbol visibility for xcoff object file.: rG6923b0a76e06: Revert "[AIX][XCOFF] emit symbol visibility for xcoff object file.".
Thu, Aug 27, 8:09 AM
DiggerLin committed rG6923b0a76e06: Revert "[AIX][XCOFF] emit symbol visibility for xcoff object file." (authored by DiggerLin).
Revert "[AIX][XCOFF] emit symbol visibility for xcoff object file."
Thu, Aug 27, 8:09 AM
DiggerLin added a reverting change for D84265: [AIX][XCOFF] emit symbol visibility for xcoff object file.: rG6923b0a76e06: Revert "[AIX][XCOFF] emit symbol visibility for xcoff object file.".
Thu, Aug 27, 8:09 AM · Restricted Project

Tue, Aug 25

DiggerLin updated the diff for D86461: [AIX][XCOFF][Patch2] decode vector information and extent long table of the traceback table of the xcoff..
Tue, Aug 25, 6:26 AM · Restricted Project

Mon, Aug 24

DiggerLin updated the summary of D86461: [AIX][XCOFF][Patch2] decode vector information and extent long table of the traceback table of the xcoff..
Mon, Aug 24, 12:12 PM · Restricted Project
DiggerLin accepted D84549: [XCOFF][AIX] Support relocation generation for large code model.

LGTM

Mon, Aug 24, 11:58 AM · Restricted Project
DiggerLin retitled D86461: [AIX][XCOFF][Patch2] decode vector information and extent long table of the traceback table of the xcoff. from [AIX][XCOFF] decode vector information and extent long table of the traceback table of the xcoff. to [AIX][XCOFF][Patch2] decode vector information and extent long table of the traceback table of the xcoff..
Mon, Aug 24, 7:49 AM · Restricted Project
DiggerLin updated the summary of D86461: [AIX][XCOFF][Patch2] decode vector information and extent long table of the traceback table of the xcoff..
Mon, Aug 24, 7:47 AM · Restricted Project
DiggerLin updated the summary of D86461: [AIX][XCOFF][Patch2] decode vector information and extent long table of the traceback table of the xcoff..
Mon, Aug 24, 7:46 AM · Restricted Project
DiggerLin requested review of D86461: [AIX][XCOFF][Patch2] decode vector information and extent long table of the traceback table of the xcoff..
Mon, Aug 24, 7:36 AM · Restricted Project

Aug 21 2020

DiggerLin committed rGa08186892132: [AIX][XCOFF] emit symbol visibility for xcoff object file. (authored by DiggerLin).
[AIX][XCOFF] emit symbol visibility for xcoff object file.
Aug 21 2020, 8:01 AM
DiggerLin closed D84265: [AIX][XCOFF] emit symbol visibility for xcoff object file..
Aug 21 2020, 8:01 AM · Restricted Project

Aug 17 2020

DiggerLin committed rG2f0d755d8156: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for… (authored by DiggerLin).
[AIX][XCOFF][Patch1] Provide decoding trace back table information API for…
Aug 17 2020, 1:25 PM
DiggerLin closed D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Aug 17 2020, 1:24 PM · Restricted Project
DiggerLin added inline comments to D84549: [XCOFF][AIX] Support relocation generation for large code model.
Aug 17 2020, 6:14 AM · Restricted Project
DiggerLin added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Aug 17 2020, 6:02 AM · Restricted Project

Aug 14 2020

DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

address comment

Aug 14 2020, 7:20 AM · Restricted Project

Aug 13 2020

DiggerLin added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Aug 13 2020, 1:21 PM · Restricted Project
DiggerLin updated the diff for D84265: [AIX][XCOFF] emit symbol visibility for xcoff object file..
Aug 13 2020, 11:53 AM · Restricted Project
DiggerLin added a comment to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

I just wonder whether we can implement two separate structure XCOFFSymbolEntry32 and XCOFFSymbolEntry64 without so much union be used on currently implement.

Aug 13 2020, 11:40 AM · Restricted Project
DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

address comment

Aug 13 2020, 7:34 AM · Restricted Project
DiggerLin added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Aug 13 2020, 7:07 AM · Restricted Project

Aug 12 2020

DiggerLin updated the diff for D84265: [AIX][XCOFF] emit symbol visibility for xcoff object file..

address comment

Aug 12 2020, 12:47 PM · Restricted Project
DiggerLin added inline comments to D84549: [XCOFF][AIX] Support relocation generation for large code model.
Aug 12 2020, 10:53 AM · Restricted Project
DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

address comment

Aug 12 2020, 7:39 AM · Restricted Project
DiggerLin added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Aug 12 2020, 6:53 AM · Restricted Project

Aug 11 2020

DiggerLin committed rGe9ac1495e208: [AIX][XCOFF] change the operand of branch instruction from symbol name to… (authored by DiggerLin).
[AIX][XCOFF] change the operand of branch instruction from symbol name to…
Aug 11 2020, 12:26 PM
DiggerLin closed D84765: [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations.
Aug 11 2020, 12:26 PM · Restricted Project
DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

address comment

Aug 11 2020, 7:30 AM · Restricted Project
DiggerLin added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Aug 11 2020, 6:18 AM · Restricted Project
DiggerLin added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Aug 11 2020, 6:00 AM · Restricted Project

Aug 10 2020

DiggerLin accepted D85675: [XCOFF][llvm-readobj] Move XCOFF test to XCOFF directory.

LGTM

Aug 10 2020, 12:20 PM · Restricted Project
DiggerLin updated the diff for D84765: [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations.

address comment

Aug 10 2020, 10:13 AM · Restricted Project
DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

add new test case.

Aug 10 2020, 8:36 AM · Restricted Project

Aug 7 2020

DiggerLin updated the diff for D84765: [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations.
Aug 7 2020, 3:04 PM · Restricted Project
DiggerLin retitled D84765: [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations from [AIX][XCOFF] [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations to [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations.
Aug 7 2020, 12:33 PM · Restricted Project
DiggerLin updated the diff for D84765: [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations.

address comment

Aug 7 2020, 10:30 AM · Restricted Project
DiggerLin added a comment to D84765: [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations.

As you mentioned in the summary, this patch seems be addressing two orthogonal things:

  1. remove SC from MCSectionXCOFF and let it only be a property of MCSymbolXCOFF
  2. when branching to an undefined function, branch to qualname instead.

If I am right, I would suggest we split them into two patches.

And for the second patch when branching to an undefined function, branch to qualname instead, I think we need to adjust the patch title to a more accurate one[maybe [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations]since the scope is actually limited to function declarations only.

Aug 7 2020, 9:46 AM · Restricted Project
DiggerLin added inline comments to D84765: [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations.
Aug 7 2020, 9:26 AM · Restricted Project
DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

address comment

Aug 7 2020, 8:52 AM · Restricted Project
DiggerLin added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Aug 7 2020, 8:42 AM · Restricted Project

Aug 6 2020

DiggerLin retitled D84765: [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations from [AIX][XCOFF] change oprand of branch instruction from symbol name to qualify symbol name. to [AIX][XCOFF] [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations.
Aug 6 2020, 2:50 PM · Restricted Project
DiggerLin updated the diff for D84265: [AIX][XCOFF] emit symbol visibility for xcoff object file..
Aug 6 2020, 1:42 PM · Restricted Project
DiggerLin added inline comments to D84765: [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations.
Aug 6 2020, 1:26 PM · Restricted Project
DiggerLin added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Aug 6 2020, 1:12 PM · Restricted Project

Aug 5 2020

DiggerLin updated the diff for D84765: [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations.
Aug 5 2020, 11:54 AM · Restricted Project
DiggerLin retitled D84765: [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations from [NFC][AIX][XCOFF] remove setting storageclass in function .getXCOFFSection and construct function of class MCSectionXCOFF to [AIX][XCOFF] change oprand of branch instruction from symbol name to qualify symbol name..
Aug 5 2020, 8:53 AM · Restricted Project
DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

added a truncated test case

Aug 5 2020, 7:58 AM · Restricted Project
DiggerLin added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Aug 5 2020, 7:57 AM · Restricted Project

Jul 29 2020

DiggerLin removed a reviewer for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d : DiggerLin.
Jul 29 2020, 7:29 AM · Restricted Project
DiggerLin added a comment to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Jul 29 2020, 7:29 AM · Restricted Project
DiggerLin accepted D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

Any new comments ?

Jul 29 2020, 7:27 AM · Restricted Project

Jul 28 2020

DiggerLin requested review of D84765: [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations.
Jul 28 2020, 9:35 AM · Restricted Project

Jul 27 2020

DiggerLin added inline comments to D84265: [AIX][XCOFF] emit symbol visibility for xcoff object file..
Jul 27 2020, 10:18 AM · Restricted Project
DiggerLin accepted D83875: [XCOFF][AIX] Enable -ffunction-sections.

LGTM

Jul 27 2020, 8:14 AM · Restricted Project

Jul 24 2020

DiggerLin accepted D84363: [XCOFF][AIX] Handle llvm.used and llvm.compiler.used global array.

LGTM.

Jul 24 2020, 12:35 PM · Restricted Project
DiggerLin added inline comments to D83875: [XCOFF][AIX] Enable -ffunction-sections.
Jul 24 2020, 12:13 PM · Restricted Project
DiggerLin committed rG77b61177d7d4: [AIX] remove -u from the clang when invoke aix as assembler (authored by DiggerLin).
[AIX] remove -u from the clang when invoke aix as assembler
Jul 24 2020, 8:29 AM
DiggerLin closed D84356: [AIX] remove -u from the clang when invoke aix as assembler.
Jul 24 2020, 8:28 AM · Restricted Project
DiggerLin added inline comments to D84363: [XCOFF][AIX] Handle llvm.used and llvm.compiler.used global array.
Jul 24 2020, 6:19 AM · Restricted Project

Jul 23 2020

DiggerLin added inline comments to D84363: [XCOFF][AIX] Handle llvm.used and llvm.compiler.used global array.
Jul 23 2020, 1:57 PM · Restricted Project
DiggerLin accepted D84363: [XCOFF][AIX] Handle llvm.used and llvm.compiler.used global array.
Jul 23 2020, 1:02 PM · Restricted Project
DiggerLin updated the summary of D84356: [AIX] remove -u from the clang when invoke aix as assembler.
Jul 23 2020, 8:04 AM · Restricted Project
DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

address comment

Jul 23 2020, 7:57 AM · Restricted Project
DiggerLin added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Jul 23 2020, 7:55 AM · Restricted Project
DiggerLin retitled D84356: [AIX] remove -u from the clang when invoke aix as assembler from [AIX] remote -u from the clang when invoke aix as assembler to [AIX] remove -u from the clang when invoke aix as assembler.
Jul 23 2020, 6:15 AM · Restricted Project

Jul 22 2020

DiggerLin edited reviewers for D84356: [AIX] remove -u from the clang when invoke aix as assembler, added: stevewan; removed: yuanwu.
Jul 22 2020, 1:25 PM · Restricted Project
Herald added a project to D84356: [AIX] remove -u from the clang when invoke aix as assembler: Restricted Project.
Jul 22 2020, 1:00 PM · Restricted Project
DiggerLin added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Jul 22 2020, 10:59 AM · Restricted Project

Jul 21 2020

Herald added a project to D84265: [AIX][XCOFF] emit symbol visibility for xcoff object file.: Restricted Project.
Jul 21 2020, 1:16 PM · Restricted Project
DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

address comment

Jul 21 2020, 1:08 PM · Restricted Project
DiggerLin committed rG11546898e2ff: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol (authored by DiggerLin).
[AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol
Jul 21 2020, 1:04 PM
DiggerLin closed D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
Jul 21 2020, 1:03 PM · Restricted Project
DiggerLin added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Jul 21 2020, 8:03 AM · Restricted Project
DiggerLin added a comment to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

@DiggerLin, for context (since I will be on vacation), I've gotten through the functional code changes, but have not reviewed the testing.

Jul 21 2020, 7:23 AM · Restricted Project

Jul 20 2020

DiggerLin added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Jul 20 2020, 7:01 AM · Restricted Project
DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

address comment

Jul 20 2020, 7:01 AM · Restricted Project

Jul 19 2020

DiggerLin added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Jul 19 2020, 9:38 AM · Restricted Project
DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

address comment

Jul 19 2020, 9:38 AM · Restricted Project

Jul 17 2020

DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Jul 17 2020, 1:48 PM · Restricted Project
DiggerLin added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Jul 17 2020, 1:48 PM · Restricted Project
DiggerLin accepted D83252: [XCOFF] Enable symbol alias for AIX.

LGTM

Jul 17 2020, 8:58 AM · Restricted Project
DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Jul 17 2020, 7:36 AM · Restricted Project

Jul 16 2020

DiggerLin updated the diff for D82549: [AIX][XCOFF] parsing xcoff object file auxiliary header.

address comment

Jul 16 2020, 2:07 PM · Restricted Project
DiggerLin added inline comments to D82549: [AIX][XCOFF] parsing xcoff object file auxiliary header.
Jul 16 2020, 12:10 PM · Restricted Project