Page MenuHomePhabricator

DiggerLin (Digger Lin)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 28 2019, 10:08 AM (120 w, 4 d)

Recent Activity

Thu, Jun 17

DiggerLin updated the diff for D103651: [AIX][XCOFF] generate eh_info when vector registers are saved according to the traceback table..

address comment

Thu, Jun 17, 1:55 PM · Restricted Project
DiggerLin added inline comments to D103651: [AIX][XCOFF] generate eh_info when vector registers are saved according to the traceback table..
Thu, Jun 17, 1:54 PM · Restricted Project

Tue, Jun 15

DiggerLin retitled D103651: [AIX][XCOFF] generate eh_info when vector registers are saved according to the traceback table. from [AIX] generate eh_info when vector registers are saved according to the traceback table. to [AIX][XCOFF] generate eh_info when vector registers are saved according to the traceback table..
Tue, Jun 15, 1:40 PM · Restricted Project
DiggerLin updated the diff for D103651: [AIX][XCOFF] generate eh_info when vector registers are saved according to the traceback table..

address comment

Tue, Jun 15, 1:38 PM · Restricted Project

Mon, Jun 14

DiggerLin added inline comments to D103651: [AIX][XCOFF] generate eh_info when vector registers are saved according to the traceback table..
Mon, Jun 14, 6:13 AM · Restricted Project

Fri, Jun 11

DiggerLin updated the diff for D93659: [AIX][XCOFF] emit vector info of traceback table..

rebased code

Fri, Jun 11, 9:30 AM · Restricted Project

Thu, Jun 10

DiggerLin updated the diff for D93659: [AIX][XCOFF] emit vector info of traceback table..
Thu, Jun 10, 1:23 PM · Restricted Project
DiggerLin added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Thu, Jun 10, 1:20 PM · Restricted Project
DiggerLin updated the diff for D93659: [AIX][XCOFF] emit vector info of traceback table..

added a padding comment for the vector info

Thu, Jun 10, 8:40 AM · Restricted Project
DiggerLin added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Thu, Jun 10, 8:39 AM · Restricted Project
DiggerLin added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Thu, Jun 10, 8:38 AM · Restricted Project

Wed, Jun 9

DiggerLin added inline comments to D103651: [AIX][XCOFF] generate eh_info when vector registers are saved according to the traceback table..
Wed, Jun 9, 6:18 AM · Restricted Project

Tue, Jun 8

DiggerLin updated the diff for D93659: [AIX][XCOFF] emit vector info of traceback table..

address comment

Tue, Jun 8, 11:29 AM · Restricted Project
DiggerLin added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Tue, Jun 8, 10:53 AM · Restricted Project
DiggerLin added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Tue, Jun 8, 7:34 AM · Restricted Project

Fri, Jun 4

DiggerLin updated the diff for D103651: [AIX][XCOFF] generate eh_info when vector registers are saved according to the traceback table..

fix a bug

Fri, Jun 4, 10:10 AM · Restricted Project

Thu, Jun 3

DiggerLin requested review of D103651: [AIX][XCOFF] generate eh_info when vector registers are saved according to the traceback table..
Thu, Jun 3, 3:07 PM · Restricted Project
DiggerLin updated the diff for D93659: [AIX][XCOFF] emit vector info of traceback table..

address comment

Thu, Jun 3, 12:11 PM · Restricted Project
DiggerLin added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Thu, Jun 3, 12:10 PM · Restricted Project

Wed, Jun 2

DiggerLin updated the diff for D93659: [AIX][XCOFF] emit vector info of traceback table..

rebased on the latest source code

Wed, Jun 2, 10:29 AM · Restricted Project

May 13 2021

DiggerLin added a comment to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

and please run clang-format

May 13 2021, 2:07 PM · Restricted Project
DiggerLin accepted D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

LGTM with address comment.

May 13 2021, 1:59 PM · Restricted Project
DiggerLin added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
May 13 2021, 12:22 PM · Restricted Project
DiggerLin added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
May 13 2021, 12:07 PM · Restricted Project

May 10 2021

DiggerLin added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
May 10 2021, 1:03 PM · Restricted Project
DiggerLin added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
May 10 2021, 12:37 PM · Restricted Project

Apr 14 2021

DiggerLin added inline comments to D100214: [AIX][TLS] Add support for TLSGD relocations to XCOFF objects.
Apr 14 2021, 1:45 PM · Restricted Project
DiggerLin updated the summary of D66969: Output XCOFF object text section header and symbol entry for program code.
Apr 14 2021, 12:18 PM · Restricted Project

Apr 11 2021

DiggerLin updated the summary of D66969: Output XCOFF object text section header and symbol entry for program code.
Apr 11 2021, 6:58 PM · Restricted Project
DiggerLin updated the summary of D66969: Output XCOFF object text section header and symbol entry for program code.
Apr 11 2021, 6:52 PM · Restricted Project
DiggerLin updated the summary of D66969: Output XCOFF object text section header and symbol entry for program code.
Apr 11 2021, 6:35 PM · Restricted Project

Mar 24 2021

DiggerLin accepted D98946: [AIX][TLS] Add support for TLS variables to XCOFF object writer.

LGTM, please wait for 24 hours before commit . maybe other reviewer still have some comment.

Mar 24 2021, 10:58 AM · Restricted Project

Mar 23 2021

DiggerLin added inline comments to D98946: [AIX][TLS] Add support for TLS variables to XCOFF object writer.
Mar 23 2021, 8:15 AM · Restricted Project

Mar 22 2021

DiggerLin added inline comments to D98946: [AIX][TLS] Add support for TLS variables to XCOFF object writer.
Mar 22 2021, 11:58 AM · Restricted Project
DiggerLin accepted D99090: [llvm-readobj] Add XMC_UL in the enum entry of CsectStorageMapping class.

LGTM

Mar 22 2021, 10:29 AM · Restricted Project
DiggerLin added a comment to D98946: [AIX][TLS] Add support for TLS variables to XCOFF object writer.

and I am slightly prefer to combine the two test files into one. because the only different is data-section is on or off. we can use different --check-prefix for them

Mar 22 2021, 8:56 AM · Restricted Project
DiggerLin added a comment to D98946: [AIX][TLS] Add support for TLS variables to XCOFF object writer.

I think we also need to use llvm-objdump to test the content of .tdata ?

Mar 22 2021, 8:53 AM · Restricted Project
DiggerLin added inline comments to D98946: [AIX][TLS] Add support for TLS variables to XCOFF object writer.
Mar 22 2021, 8:52 AM · Restricted Project
DiggerLin added a comment to D98946: [AIX][TLS] Add support for TLS variables to XCOFF object writer.

we maybe also need to use llvm-objdump to test the data content of .tdata

Mar 22 2021, 8:41 AM · Restricted Project
DiggerLin added inline comments to D98946: [AIX][TLS] Add support for TLS variables to XCOFF object writer.
Mar 22 2021, 8:02 AM · Restricted Project

Mar 19 2021

DiggerLin added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Mar 19 2021, 8:07 AM · Restricted Project

Mar 18 2021

DiggerLin added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Mar 18 2021, 2:09 PM · Restricted Project
DiggerLin added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Mar 18 2021, 1:51 PM · Restricted Project
DiggerLin added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Mar 18 2021, 11:12 AM · Restricted Project

Mar 15 2021

DiggerLin committed rGd1f1bff81bd9: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore… (authored by DiggerLin).
[AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore…
Mar 15 2021, 2:34 PM
DiggerLin closed D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default..
Mar 15 2021, 2:34 PM · Restricted Project
DiggerLin added inline comments to D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default..
Mar 15 2021, 2:05 PM · Restricted Project
DiggerLin requested review of D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default..
Mar 15 2021, 1:48 PM · Restricted Project

Mar 11 2021

DiggerLin updated the diff for D93659: [AIX][XCOFF] emit vector info of traceback table..

address comment.

Mar 11 2021, 8:11 AM · Restricted Project

Mar 9 2021

DiggerLin updated the diff for D89049: [AIX][XCOFF] print out the traceback info .

address comment

Mar 9 2021, 1:12 PM · Restricted Project
DiggerLin added inline comments to D89049: [AIX][XCOFF] print out the traceback info .
Mar 9 2021, 1:11 PM · Restricted Project
DiggerLin added inline comments to D89049: [AIX][XCOFF] print out the traceback info .
Mar 9 2021, 10:18 AM · Restricted Project
DiggerLin committed rG46d4d1fea401: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff… (authored by DiggerLin).
[AIX] do not emit visibility attribute into IR when there is -mignore-xcoff…
Mar 9 2021, 7:39 AM
DiggerLin closed D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.
Mar 9 2021, 7:38 AM · Restricted Project
DiggerLin updated the diff for D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.

slight change , move to

Mar 9 2021, 6:40 AM · Restricted Project

Mar 8 2021

DiggerLin added a comment to D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.

Gentle ping . @jansvoboda11 . Do you have any comment on it the last update on "added -round-trip-args functionality for the lang opt "-mignore-xcoff-visibility" ?

Mar 8 2021, 11:52 AM · Restricted Project
DiggerLin updated the diff for D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.

added extra comment back.

Mar 8 2021, 6:42 AM · Restricted Project
DiggerLin added a comment to D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.
Mar 8 2021, 6:39 AM · Restricted Project

Mar 6 2021

DiggerLin updated the diff for D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.

added -round-trip-args functionality for the lang opt "-mignore-xcoff-visibility"

Mar 6 2021, 8:59 AM · Restricted Project

Mar 5 2021

DiggerLin added a comment to D97552: [clang][cli] Fix generation of '-fvisibility' with regards to '-mignore-xcoff-visibility'.
  1. in your summary , it looks clang will emit "-fvisibility default" to cc1 even if there is no -fvisibility in the clang command ? I compiled the clang with your patch, it looks do not always emit "-fvisibility default" to cc1. I understand wrong on your summary ?
  2. If clang will emit "-fvisibility default" to cc1 when there is no -fvisibility in the clang command, it is a new functionality , there should be a test case for it?
Mar 5 2021, 2:08 PM · Restricted Project
DiggerLin updated the diff for D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.

rebase code

Mar 5 2021, 1:24 PM · Restricted Project

Mar 3 2021

DiggerLin updated the diff for D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.

modify a test case

Mar 3 2021, 1:10 PM · Restricted Project
DiggerLin added inline comments to D97588: [AIX] Disable $ORIGIN rpath.
Mar 3 2021, 9:31 AM · Restricted Project
DiggerLin added a reviewer for D97588: [AIX] Disable $ORIGIN rpath: DiggerLin.
Mar 3 2021, 9:21 AM · Restricted Project
DiggerLin updated the diff for D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.

rebased the patch

Mar 3 2021, 8:18 AM · Restricted Project

Mar 2 2021

DiggerLin added a comment to D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.

Gentle ping @sfertile , any new comment on the patch ?

Mar 2 2021, 6:29 AM · Restricted Project

Feb 9 2021

DiggerLin updated DiggerLin.
Feb 9 2021, 6:57 AM

Jan 21 2021

DiggerLin updated the diff for D94984: [AIX] simplify xcoff part of function TargetMachine::shouldAssumeDSOLocal() .
Jan 21 2021, 1:49 PM · Restricted Project
DiggerLin retitled D94984: [AIX] simplify xcoff part of function TargetMachine::shouldAssumeDSOLocal() from [NFC][AIX] not functionality changing of function TargetMachine::shouldAssumeDSOLocal() to [AIX] simplify xcoff part of function TargetMachine::shouldAssumeDSOLocal() .
Jan 21 2021, 1:46 PM · Restricted Project

Jan 19 2021

DiggerLin requested review of D94984: [AIX] simplify xcoff part of function TargetMachine::shouldAssumeDSOLocal() .
Jan 19 2021, 10:27 AM · Restricted Project

Jan 18 2021

DiggerLin added inline comments to D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.
Jan 18 2021, 6:47 AM · Restricted Project

Jan 15 2021

DiggerLin updated the diff for D93659: [AIX][XCOFF] emit vector info of traceback table..
Jan 15 2021, 11:33 AM · Restricted Project

Jan 11 2021

DiggerLin updated the diff for D93659: [AIX][XCOFF] emit vector info of traceback table..
Jan 11 2021, 10:25 AM · Restricted Project
DiggerLin added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Jan 11 2021, 9:02 AM · Restricted Project

Jan 4 2021

DiggerLin updated the diff for D93659: [AIX][XCOFF] emit vector info of traceback table..
Jan 4 2021, 1:45 PM · Restricted Project
DiggerLin added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Jan 4 2021, 1:18 PM · Restricted Project

Dec 22 2020

DiggerLin updated the diff for D89049: [AIX][XCOFF] print out the traceback info .

addressed comment and rebased the patch on the https://reviews.llvm.org/D93659 [AIX][XCOFF] emit vector info of traceback table.

Dec 22 2020, 9:38 AM · Restricted Project
DiggerLin added inline comments to D89049: [AIX][XCOFF] print out the traceback info .
Dec 22 2020, 9:19 AM · Restricted Project

Dec 21 2020

DiggerLin requested review of D93659: [AIX][XCOFF] emit vector info of traceback table..
Dec 21 2020, 12:41 PM · Restricted Project

Dec 18 2020

DiggerLin committed rGd551e40f1cff: [AIX] Change the code based on https://lists.llvm.org/pipermail/llvm… (authored by DiggerLin).
[AIX] Change the code based on https://lists.llvm.org/pipermail/llvm…
Dec 18 2020, 10:03 AM

Dec 16 2020

DiggerLin committed rGa1e1dcabe4fb: [XCOFF][AIX] Emit EH information in traceback table (authored by DiggerLin).
[XCOFF][AIX] Emit EH information in traceback table
Dec 16 2020, 6:36 AM
DiggerLin closed D92766: [XCOFF][AIX] Emit EH information in traceback table.
Dec 16 2020, 6:36 AM · Restricted Project

Dec 15 2020

DiggerLin updated the diff for D92766: [XCOFF][AIX] Emit EH information in traceback table.

rebased the patch based on the https://reviews.llvm.org/D92398.

Dec 15 2020, 8:16 AM · Restricted Project
DiggerLin commandeered D92766: [XCOFF][AIX] Emit EH information in traceback table.

for Jason is on vacation , I will take over the revision and rebase the patch based on the committed https://reviews.llvm.org/D92398

Dec 15 2020, 8:15 AM · Restricted Project

Dec 14 2020

DiggerLin added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 14 2020, 8:45 AM · Restricted Project
DiggerLin committed rG15f2d4f19838: [AIX] Fixed "comparison of unsigned expression >= 0 is always true" gcc… (authored by DiggerLin).
[AIX] Fixed "comparison of unsigned expression >= 0 is always true" gcc…
Dec 14 2020, 8:09 AM

Dec 11 2020

DiggerLin committed rG7c8072ce2dbc: [AIX] Fixed a link error. (authored by DiggerLin).
[AIX] Fixed a link error.
Dec 11 2020, 3:54 PM
DiggerLin committed rG997d286f2d0f: [AIX][XCOFF] emit traceback table for function in aix (authored by DiggerLin).
[AIX][XCOFF] emit traceback table for function in aix
Dec 11 2020, 2:51 PM
DiggerLin closed D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 11 2020, 2:50 PM · Restricted Project
DiggerLin added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 11 2020, 1:00 PM · Restricted Project
DiggerLin updated the diff for D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 11 2020, 11:29 AM · Restricted Project
DiggerLin updated the diff for D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 11 2020, 10:21 AM · Restricted Project
DiggerLin updated the diff for D92398: [AIX][XCOFF] emit traceback table for function in aix.

change function from setParameterType to appendParameterType

Dec 11 2020, 9:22 AM · Restricted Project
DiggerLin updated the diff for D92398: [AIX][XCOFF] emit traceback table for function in aix.

address comment including fixing a paramtype bug and adding a new content in test case.

Dec 11 2020, 9:01 AM · Restricted Project
DiggerLin added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 11 2020, 8:55 AM · Restricted Project
DiggerLin added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 11 2020, 8:54 AM · Restricted Project

Dec 10 2020

DiggerLin added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 10 2020, 3:41 PM · Restricted Project
DiggerLin updated the diff for D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 10 2020, 3:40 PM · Restricted Project
DiggerLin updated the diff for D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 10 2020, 10:23 AM · Restricted Project
DiggerLin added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 10 2020, 8:19 AM · Restricted Project