Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

DiggerLin (Digger Lin)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 28 2019, 10:08 AM (249 w, 3 d)

Recent Activity

Oct 30 2023

DiggerLin added inline comments to D153907: [AIX] [TOC] Add -mtocdata/-mno-tocdata options on AIX .
Oct 30 2023, 1:08 PM · Restricted Project, Restricted Project, Restricted Project

Oct 16 2023

DiggerLin abandoned D94984: [AIX] simplify xcoff part of function TargetMachine::shouldAssumeDSOLocal() .

since the commit did the same change , I closed the patch

Oct 16 2023, 11:58 AM · Restricted Project, Restricted Project
DiggerLin abandoned D126705: [libc++][CI][AIX] modify the equivalence classes of regex_match for locale "cs_CZ.ISO8859-2".
Oct 16 2023, 11:27 AM · Restricted Project, Restricted Project

Oct 5 2023

DiggerLin planned changes to D126705: [libc++][CI][AIX] modify the equivalence classes of regex_match for locale "cs_CZ.ISO8859-2".
Oct 5 2023, 12:02 PM · Restricted Project, Restricted Project

Sep 29 2023

DiggerLin abandoned D159539: [NFC] refactor demangle of llvm-nm .
Sep 29 2023, 12:56 PM · Restricted Project, Restricted Project

Sep 26 2023

DiggerLin added inline comments to D139864: [llvm-cxxfilt] Do not consider the prefix dot as part of the demangled symbol name..
Sep 26 2023, 7:04 AM · Restricted Project, Restricted Project

Sep 25 2023

DiggerLin updated the diff for D139864: [llvm-cxxfilt] Do not consider the prefix dot as part of the demangled symbol name..
Sep 25 2023, 3:37 PM · Restricted Project, Restricted Project
DiggerLin added a comment to D139864: [llvm-cxxfilt] Do not consider the prefix dot as part of the demangled symbol name..

Thanks for the update. Doing the following looks good to me.

bool CanHaveLeadingDot = true;
if (StripUnderscore)
  if (DecoratedStr[0].consume_front("_")) // simplified
    CanHaveLeadingDot = false;

std::string Result;
if (nonMicrosoftDemangle(DecoratedStr, Result, CanHaveLeadingDot))
Sep 25 2023, 1:40 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D139864: [llvm-cxxfilt] Do not consider the prefix dot as part of the demangled symbol name..

rebase the code and address James' comment.

Sep 25 2023, 11:53 AM · Restricted Project, Restricted Project

Sep 22 2023

DiggerLin updated the diff for D139864: [llvm-cxxfilt] Do not consider the prefix dot as part of the demangled symbol name..

address comment

Sep 22 2023, 10:11 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D139864: [llvm-cxxfilt] Do not consider the prefix dot as part of the demangled symbol name..

Could you not just modify nonMicrosoftDemangle to handle the dot prefix? That would mean this works for all tools, including llvm-cxxfilt, rather than needing this and the separate D159539 patch.

Sep 22 2023, 6:47 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D139864: [llvm-cxxfilt] Do not consider the prefix dot as part of the demangled symbol name..
Sep 22 2023, 6:31 AM · Restricted Project, Restricted Project

Sep 21 2023

DiggerLin updated the diff for D139864: [llvm-cxxfilt] Do not consider the prefix dot as part of the demangled symbol name..

rebase the code

Sep 21 2023, 7:07 PM · Restricted Project, Restricted Project
DiggerLin added a comment to D159539: [NFC] refactor demangle of llvm-nm .

llvm::demangle is used by a lot of ELF tools to assume ELF style mangling where there is no extra prefix. I think many don't expect demangling ._Zxxxx symbols.

Sep 21 2023, 5:32 PM · Restricted Project, Restricted Project
DiggerLin requested review of D159539: [NFC] refactor demangle of llvm-nm .
Sep 21 2023, 1:28 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D139864: [llvm-cxxfilt] Do not consider the prefix dot as part of the demangled symbol name..

address comment

Sep 21 2023, 1:17 PM · Restricted Project, Restricted Project
DiggerLin retitled D139864: [llvm-cxxfilt] Do not consider the prefix dot as part of the demangled symbol name. from [llvm-cxxfilt] Not consider the prefix dot as part of the demangled symbol name. to [llvm-cxxfilt] Do not consider the prefix dot as part of the demangled symbol name..
Sep 21 2023, 12:13 PM · Restricted Project, Restricted Project
DiggerLin added a comment to D139864: [llvm-cxxfilt] Do not consider the prefix dot as part of the demangled symbol name..

My opinion hasn't changed that it's a mistake to put the dot demangling in llvm-cxxfilt specifically. That will mean you'll need to make the same change in llvm-nm, llvm-readelf, llvm-objdump and probably other tools too. Code duplication is bad. The next tool to be added might not realise that they can't just use the main demangler library as-is to do their name demangling.

If there is tool code that conflicts with that behaviour (such as the llvm-nm mach-o code), perhaps it's that tool code that should change instead, or perhaps we need to enhance the demangler library a little further, for example by adding an optional "strip underscore" behaviour to it. Adding @MaskRay as a reviewer in case he's got a different opinion.

Sep 21 2023, 11:49 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D139864: [llvm-cxxfilt] Do not consider the prefix dot as part of the demangled symbol name..

My opinion hasn't changed that it's a mistake to put the dot demangling in llvm-cxxfilt specifically. That will mean you'll need to make the same change in llvm-nm, llvm-readelf, llvm-objdump and probably other tools too. Code duplication is bad. The next tool to be added might not realise that they can't just use the main demangler library as-is to do their name demangling.

If there is tool code that conflicts with that behaviour (such as the llvm-nm mach-o code), perhaps it's that tool code that should change instead, or perhaps we need to enhance the demangler library a little further, for example by adding an optional "strip underscore" behaviour to it. Adding @MaskRay as a reviewer in case he's got a different opinion.

Sep 21 2023, 11:19 AM · Restricted Project, Restricted Project

Sep 20 2023

DiggerLin added inline comments to D126705: [libc++][CI][AIX] modify the equivalence classes of regex_match for locale "cs_CZ.ISO8859-2".
Sep 20 2023, 11:49 AM · Restricted Project, Restricted Project
DiggerLin requested review of D126705: [libc++][CI][AIX] modify the equivalence classes of regex_match for locale "cs_CZ.ISO8859-2".
Sep 20 2023, 11:13 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D126705: [libc++][CI][AIX] modify the equivalence classes of regex_match for locale "cs_CZ.ISO8859-2".
Sep 20 2023, 11:13 AM · Restricted Project, Restricted Project

Sep 7 2023

DiggerLin added a comment to D139864: [llvm-cxxfilt] Do not consider the prefix dot as part of the demangled symbol name..

gentle ping, @jhenderson

Sep 7 2023, 5:51 PM · Restricted Project, Restricted Project

Sep 6 2023

DiggerLin added inline comments to D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Sep 6 2023, 8:08 AM · Restricted Project, Restricted Project

Sep 5 2023

DiggerLin updated the diff for D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .

address comment

Sep 5 2023, 12:55 PM · Restricted Project, Restricted Project

Sep 1 2023

DiggerLin updated the diff for D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .

delete an empty line

Sep 1 2023, 10:03 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .

address comment

Sep 1 2023, 10:01 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Sep 1 2023, 10:00 AM · Restricted Project, Restricted Project

Aug 31 2023

DiggerLin added inline comments to D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Aug 31 2023, 8:56 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .

added more test scenario and address comment.

Aug 31 2023, 8:54 AM · Restricted Project, Restricted Project

Aug 30 2023

DiggerLin accepted D151335: [AIX][TLS] Generate .extern and .ref references to __tls_get_addr for local-exec accesses..

LGTM.

Aug 30 2023, 12:25 PM · Restricted Project, Restricted Project, Restricted Project

Aug 29 2023

DiggerLin added inline comments to D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Aug 29 2023, 10:53 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .

address comment

Aug 29 2023, 10:51 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..
Aug 29 2023, 8:16 AM · Restricted Project, Restricted Project
DiggerLin accepted D158739: AIX: Issue an error when specifying an alias for a common symbol.

LGTM

Aug 29 2023, 6:55 AM · Restricted Project, Restricted Project, Restricted Project

Aug 28 2023

DiggerLin added inline comments to D158739: AIX: Issue an error when specifying an alias for a common symbol.
Aug 28 2023, 12:07 PM · Restricted Project, Restricted Project, Restricted Project
DiggerLin added a comment to D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..

@jhenderson , I would greatly appreciate your thoughts on the possibility of using the implement proposed in https://reviews.llvm.org/D158004?id=552000 for the patch.

Aug 28 2023, 6:24 AM · Restricted Project, Restricted Project

Aug 25 2023

DiggerLin added inline comments to D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Aug 25 2023, 3:45 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Aug 25 2023, 3:45 PM · Restricted Project, Restricted Project
DiggerLin added inline comments to D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Aug 25 2023, 3:37 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .

add new test scenario

Aug 25 2023, 3:37 PM · Restricted Project, Restricted Project
DiggerLin added inline comments to D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..
Aug 25 2023, 6:54 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..

what is preventing the change to clang to not call llvm-nm with import files?

Aug 25 2023, 6:49 AM · Restricted Project, Restricted Project

Aug 24 2023

DiggerLin updated the diff for D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..

rebase the patch.

Aug 24 2023, 10:49 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..

implement a new class AIXLinkerImportFile

Aug 24 2023, 7:08 AM · Restricted Project, Restricted Project

Aug 21 2023

DiggerLin added a comment to D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..

@jhenderson ,May I kindly ask if you have any further comments? If not, would it be acceptable for me to move forward with committing the patch? Your valuable input would be sincerely appreciated.

Aug 21 2023, 1:52 PM · Restricted Project, Restricted Project
DiggerLin added a comment to D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.

@MaskRay, would you have any additional comments to share? If not, would it be appropriate for me to proceed with committing the patch? Your input would be greatly appreciated.

Aug 21 2023, 6:26 AM · Restricted Project, Restricted Project, Restricted Project
DiggerLin updated the diff for D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..

address minor comment.

Aug 21 2023, 6:22 AM · Restricted Project, Restricted Project

Aug 18 2023

DiggerLin added inline comments to D157483: [AIX] Handle ReadOnlyWithRel kind on AIX..
Aug 18 2023, 1:53 PM · Restricted Project, Restricted Project
DiggerLin added inline comments to D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..
Aug 18 2023, 10:51 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..

address comment

Aug 18 2023, 10:49 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..

yes, your understand is correct. but I need to clarify following.

Aug 18 2023, 10:34 AM · Restricted Project, Restricted Project
DiggerLin updated the summary of D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..
Aug 18 2023, 10:34 AM · Restricted Project, Restricted Project

Aug 17 2023

DiggerLin added a reviewer for D158004: llvm-nm ignore the Import symbol file for the --export-symbol option.: MaskRay.
Aug 17 2023, 11:30 AM · Restricted Project, Restricted Project

Aug 16 2023

DiggerLin added a comment to D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..

I think the changes look okay. (In your patch description, I would specify a link to the 7.3 AIX documentation rather than the 7.2 version.)

Aug 16 2023, 12:52 PM · Restricted Project, Restricted Project
DiggerLin updated the summary of D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..
Aug 16 2023, 12:51 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..
Aug 16 2023, 11:34 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.
Aug 16 2023, 10:08 AM · Restricted Project, Restricted Project, Restricted Project
DiggerLin added inline comments to D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Aug 16 2023, 6:42 AM · Restricted Project, Restricted Project

Aug 15 2023

DiggerLin updated the summary of D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..
Aug 15 2023, 12:51 PM · Restricted Project, Restricted Project
DiggerLin updated the summary of D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..
Aug 15 2023, 12:51 PM · Restricted Project, Restricted Project
DiggerLin updated the summary of D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..
Aug 15 2023, 11:01 AM · Restricted Project, Restricted Project
DiggerLin requested review of D158004: llvm-nm ignore the Import symbol file for the --export-symbol option..
Aug 15 2023, 10:52 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .

added new test scenarios .

Aug 15 2023, 8:25 AM · Restricted Project, Restricted Project

Aug 14 2023

DiggerLin updated the diff for D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .

rebase the patch

Aug 14 2023, 1:55 PM · Restricted Project, Restricted Project
DiggerLin added inline comments to D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Aug 14 2023, 9:40 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Aug 14 2023, 9:36 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.
Aug 14 2023, 8:01 AM · Restricted Project, Restricted Project, Restricted Project
DiggerLin updated the diff for D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.
Aug 14 2023, 7:57 AM · Restricted Project, Restricted Project, Restricted Project
DiggerLin added a comment to D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .

I'll be honest, I'm not convinced the test coverage looks to be anywhere near comprehensive enough. However, I also haven't attempted to review it versus the code changes to check how much of the new code is actually covered. I'd suggest you consider using a code coverage tool to see how much coverage there is of your new code.

Aug 14 2023, 7:08 AM · Restricted Project, Restricted Project

Aug 3 2023

DiggerLin updated the diff for D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.
Aug 3 2023, 7:44 AM · Restricted Project, Restricted Project, Restricted Project

Aug 2 2023

DiggerLin added a comment to D155600: [AIX][TLS] Produce a faster local-exec access sequence with -maix-small-local-exec-tls (And optimize when load/store offsets are 0).

according to https://www.ibm.com/docs/en/aix/7.2?topic=program-using-thread-local-storage

Aug 2 2023, 8:18 AM · Restricted Project, Restricted Project, Restricted Project
DiggerLin updated the diff for D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.
Aug 2 2023, 6:48 AM · Restricted Project, Restricted Project, Restricted Project

Aug 1 2023

DiggerLin added inline comments to D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.
Aug 1 2023, 8:42 AM · Restricted Project, Restricted Project, Restricted Project
DiggerLin updated the diff for D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.

address comment

Aug 1 2023, 8:05 AM · Restricted Project, Restricted Project, Restricted Project
DiggerLin added a comment to D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .

Just as a heads-up, I'm off for the rest of the week. Hopefully I'll be able to get to any final points either before the end of my workday or later next week.

Aug 1 2023, 6:45 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Aug 1 2023, 6:44 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.

I'd still rather the invalid OBJECT_MODE value be read and rejected upfront before even parsing the -X option.

Aug 1 2023, 5:54 AM · Restricted Project, Restricted Project, Restricted Project

Jul 31 2023

DiggerLin updated the diff for D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Jul 31 2023, 10:26 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Jul 31 2023, 10:23 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .

address comment

Jul 31 2023, 10:23 AM · Restricted Project, Restricted Project

Jul 29 2023

DiggerLin updated the diff for D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .

rebase code

Jul 29 2023, 7:16 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.
Jul 29 2023, 6:01 PM · Restricted Project, Restricted Project, Restricted Project

Jul 28 2023

DiggerLin updated the diff for D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.
Jul 28 2023, 12:49 PM · Restricted Project, Restricted Project, Restricted Project

Jul 27 2023

DiggerLin updated the diff for D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.

addressed comment and let llvm-ranlib supports -Xany option

Jul 27 2023, 8:59 AM · Restricted Project, Restricted Project, Restricted Project
DiggerLin added a comment to D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.

I do see the appeal of a single enum parameter in the meantime. I would suggest it should be called SymtabWritingMode and have values NoSymtab, NormalSymtab, BigArchive64Bit, BigArchive32Bit, and BigArchiveBoth. You could optionally drop one of the BigArchive* values, and treat NormalSymtab as that value for BigArchive (as long as "Normal" is clear as to its meaning to someone familiar with BigArchive). All existing WriteSymtab false values would be replaced with NoSymtab and true with NormalSymtab (except for BigArchive cases).

Jul 27 2023, 8:43 AM · Restricted Project, Restricted Project, Restricted Project
DiggerLin added a comment to D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.

As an alternative (but I think adds unnecessary complexity, due to needing an extra variable), you could have both tools read the environment variable into a string variable, then, if the -X option is present, overwrite that variable, and finally feed that string into the parsing code that converts into a BitMode value. If the string is invalid, the parsing code could report an error along the lines of "invalid OBJECT_MODE or -X option value".

if I do not think it is better than my current implement, If I implement as your suggestion, I need another variable to recoded the where the string come from(from OBJECT_MODE  or -X option value). otherwise when the invalid value of string , how can I report it is an invalid OBJECT_MODE"  or "invalid -X option value"
Jul 27 2023, 7:41 AM · Restricted Project, Restricted Project, Restricted Project
DiggerLin added inline comments to D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.
Jul 27 2023, 6:41 AM · Restricted Project, Restricted Project, Restricted Project

Jul 25 2023

DiggerLin updated the diff for D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.

addressed partial comments, after deciding whether to delete the bool NeedSymbols parameter from functions API,(writeArchiveToStream etc), I will upload a update patch.

Jul 25 2023, 12:01 PM · Restricted Project, Restricted Project, Restricted Project
DiggerLin added inline comments to D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.
Jul 25 2023, 11:56 AM · Restricted Project, Restricted Project, Restricted Project
DiggerLin added inline comments to D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.
Jul 25 2023, 10:47 AM · Restricted Project, Restricted Project, Restricted Project
DiggerLin added inline comments to D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.
Jul 25 2023, 10:10 AM · Restricted Project, Restricted Project, Restricted Project
DiggerLin added inline comments to D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Jul 25 2023, 8:43 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Jul 25 2023, 8:42 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.
Jul 25 2023, 6:47 AM · Restricted Project, Restricted Project, Restricted Project

Jul 21 2023

DiggerLin added inline comments to D155544: [AIX][TLS][clang] Add -maix-small-local-exec-tls clang option..
Jul 21 2023, 11:15 AM · Restricted Project, Restricted Project, Restricted Project
DiggerLin added a reviewer for D155544: [AIX][TLS][clang] Add -maix-small-local-exec-tls clang option.: DiggerLin.
Jul 21 2023, 11:15 AM · Restricted Project, Restricted Project, Restricted Project

Jul 20 2023

DiggerLin updated the diff for D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.
  1. rebase the code
  2. for the env OBJECT_MODE= or is env OBJECT_MODE="" , the ranlib and ar in AIX OS , have different behaviors(ranlib looks as -X32 , but ar and nm output error ),

I change llvm-ranlib as the same behavior as ar and llvm-ar, output an error(I think output error is more reasonable). and look env OBJECT_MODE unset as default 32-BIT for llvm-ranlib as AIX OS command ranlib , nm ,ar.

Jul 20 2023, 2:05 PM · Restricted Project, Restricted Project, Restricted Project

Jul 19 2023

DiggerLin updated the diff for D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.

address comment

Jul 19 2023, 2:56 PM · Restricted Project, Restricted Project, Restricted Project
DiggerLin added inline comments to D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.
Jul 19 2023, 2:37 PM · Restricted Project, Restricted Project, Restricted Project