Page MenuHomePhabricator

DiggerLin (Digger)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 28 2019, 10:08 AM (56 w, 5 d)

Recent Activity

Today

DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

simplify some code.

Tue, Mar 31, 4:33 PM · Restricted Project
DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Tue, Mar 31, 3:27 PM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

address comment

Tue, Mar 31, 3:27 PM · Restricted Project
DiggerLin added inline comments to D76932: [AIX] emit .extern and .weak directive linkage.
Tue, Mar 31, 2:52 PM · Restricted Project
DiggerLin added reviewers for D77170: [NFC] run clang format on the file llvm/include/llvm/MC/MCDirectives.h: jasonliu, hubert.reinterpretcast.
Tue, Mar 31, 2:17 PM · Restricted Project
DiggerLin created D77170: [NFC] run clang format on the file llvm/include/llvm/MC/MCDirectives.h.
Tue, Mar 31, 2:17 PM · Restricted Project
DiggerLin added inline comments to D77080: [NFC][XCOFF][AIX] Refactor get/setContainingCsect.
Tue, Mar 31, 10:01 AM · Restricted Project
DiggerLin added inline comments to D77080: [NFC][XCOFF][AIX] Refactor get/setContainingCsect.
Tue, Mar 31, 10:00 AM · Restricted Project

Yesterday

DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Mon, Mar 30, 1:04 PM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

address comment

Mon, Mar 30, 1:04 PM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

address comment and rebased the code based on https://reviews.llvm.org/D75131 [llvm-objdump][XCOFF][AIX] Implement -r option

Mon, Mar 30, 8:37 AM · Restricted Project
DiggerLin added inline comments to D76932: [AIX] emit .extern and .weak directive linkage.
Mon, Mar 30, 7:00 AM · Restricted Project
DiggerLin updated the diff for D76932: [AIX] emit .extern and .weak directive linkage.

delete -u from clang test case aix-as.c

Mon, Mar 30, 6:28 AM · Restricted Project

Fri, Mar 27

DiggerLin updated the diff for D76932: [AIX] emit .extern and .weak directive linkage.

clang reformat

Fri, Mar 27, 7:51 PM · Restricted Project
DiggerLin committed rG9c20f09985db: [AIX] Address comment https://reviews.llvm.org/D76162#inline-701237 (authored by DiggerLin).
[AIX] Address comment https://reviews.llvm.org/D76162#inline-701237
Fri, Mar 27, 1:43 PM
DiggerLin updated the summary of D76932: [AIX] emit .extern and .weak directive linkage.
Fri, Mar 27, 9:05 AM · Restricted Project
DiggerLin updated the summary of D76932: [AIX] emit .extern and .weak directive linkage.
Fri, Mar 27, 9:05 AM · Restricted Project
DiggerLin updated the summary of D76932: [AIX] emit .extern and .weak directive linkage.
Fri, Mar 27, 9:05 AM · Restricted Project
DiggerLin created D76932: [AIX] emit .extern and .weak directive linkage.
Fri, Mar 27, 9:05 AM · Restricted Project

Thu, Mar 26

DiggerLin committed rGfdfe411e7c9a: [AIX] discard the label in the csect of function description and use qualname… (authored by DiggerLin).
[AIX] discard the label in the csect of function description and use qualname…
Thu, Mar 26, 1:03 PM
DiggerLin closed D76162: [AIX] discard the label in the csect of function description and use qualname for linkage .
Thu, Mar 26, 1:03 PM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

address comment

Thu, Mar 26, 8:06 AM · Restricted Project
DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Thu, Mar 26, 8:06 AM · Restricted Project

Wed, Mar 25

DiggerLin added inline comments to D76162: [AIX] discard the label in the csect of function description and use qualname for linkage .
Wed, Mar 25, 9:43 AM · Restricted Project
DiggerLin updated the diff for D76162: [AIX] discard the label in the csect of function description and use qualname for linkage .
Wed, Mar 25, 9:43 AM · Restricted Project
DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Wed, Mar 25, 8:04 AM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

address comment

Wed, Mar 25, 8:04 AM · Restricted Project
DiggerLin updated the diff for D76162: [AIX] discard the label in the csect of function description and use qualname for linkage .

address comment

Wed, Mar 25, 7:32 AM · Restricted Project

Tue, Mar 24

DiggerLin added inline comments to D76162: [AIX] discard the label in the csect of function description and use qualname for linkage .
Tue, Mar 24, 3:39 PM · Restricted Project
DiggerLin updated the diff for D76162: [AIX] discard the label in the csect of function description and use qualname for linkage .
Tue, Mar 24, 10:44 AM · Restricted Project
DiggerLin updated the diff for D76162: [AIX] discard the label in the csect of function description and use qualname for linkage .

address comment

Tue, Mar 24, 10:11 AM · Restricted Project

Sun, Mar 22

DiggerLin updated the diff for D76162: [AIX] discard the label in the csect of function description and use qualname for linkage .
Sun, Mar 22, 6:15 PM · Restricted Project
DiggerLin added inline comments to D76162: [AIX] discard the label in the csect of function description and use qualname for linkage .
Sun, Mar 22, 6:15 PM · Restricted Project

Mon, Mar 16

DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Mon, Mar 16, 3:51 PM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

address comment

Mon, Mar 16, 3:51 PM · Restricted Project
DiggerLin accepted D75131: [llvm-objdump][XCOFF][AIX] Implement -r option.

LGTM

Mon, Mar 16, 10:21 AM · Restricted Project
DiggerLin updated the summary of D76162: [AIX] discard the label in the csect of function description and use qualname for linkage .
Mon, Mar 16, 9:14 AM · Restricted Project
DiggerLin updated the diff for D76162: [AIX] discard the label in the csect of function description and use qualname for linkage .

change .globl symbolName
to .globl qualSymbolName
in the test cases.

Mon, Mar 16, 9:14 AM · Restricted Project
DiggerLin updated the summary of D76162: [AIX] discard the label in the csect of function description and use qualname for linkage .
Mon, Mar 16, 9:14 AM · Restricted Project

Fri, Mar 13

DiggerLin retitled D76162: [AIX] discard the label in the csect of function description and use qualname for linkage from [AIX] discard the label of the function description and use qualname for linkage to [AIX] discard the label in the csect of function description and use qualname for linkage .
Fri, Mar 13, 2:34 PM · Restricted Project
DiggerLin created D76162: [AIX] discard the label in the csect of function description and use qualname for linkage .
Fri, Mar 13, 2:34 PM · Restricted Project
DiggerLin added a comment to D75866: [AIX] supporting the visibility attribute for aix assembly.

We(David, Hubert, Jason, Sean and me) has discussed about the visibility this afternoon.

  1. We agree to separate into three patch.

First patch:

cat > test.c
void foo() {};

Currently, llc will generate assembly code as (assembly patch)

.globl  foo
.globl  .foo
.csect foo[DS]

foo:

     .long   .foo
     .long   TOC[TC0]
     .long   0
and symbol table as (xcoff object file)
[4]     m   0x00000004     .data     1  unamex                    foo
[5]     a4  0x0000000c       0    0     SD       DS    0    0
[6]     m   0x00000004     .data     1  extern                    foo
[7]     a4  0x00000004       0    0     LD       DS    0    0
After first patch, the assembly will be as
     .globl  foo[DS]                 # -- Begin function foo
     .globl  .foo
     .align  2
     .csect foo[DS]
     .long   .foo
     .long   TOC[TC0]
     .long   0
 and symbol table will as
[6]     m   0x00000004     .data     1  extern                    foo
[7]     a4  0x00000004       0    0     DS      DS    0    0

we need to change the code for the assembly path and xcoff object file patch for llc.
and also need to modify all the aix test cases which relate to above change
Second Patch.

We will support .extern and .weak directive in Second Patch.

Third Patch

We will support visibility in third patch. (this patch will be the third patch)
Fri, Mar 13, 6:22 AM · Restricted Project

Wed, Mar 11

DiggerLin added inline comments to D75866: [AIX] supporting the visibility attribute for aix assembly.
Wed, Mar 11, 2:07 PM · Restricted Project
DiggerLin updated the diff for D75866: [AIX] supporting the visibility attribute for aix assembly.

address comment

Wed, Mar 11, 2:07 PM · Restricted Project
DiggerLin added inline comments to D75131: [llvm-objdump][XCOFF][AIX] Implement -r option.
Wed, Mar 11, 9:04 AM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

add option "symbol-description" information for llvm-objdump.rst

Wed, Mar 11, 7:26 AM · Restricted Project

Tue, Mar 10

DiggerLin added inline comments to D75866: [AIX] supporting the visibility attribute for aix assembly.
Tue, Mar 10, 1:39 PM · Restricted Project
DiggerLin updated the diff for D75866: [AIX] supporting the visibility attribute for aix assembly.

address comment

Tue, Mar 10, 1:39 PM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

address comment

Tue, Mar 10, 11:25 AM · Restricted Project
DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Tue, Mar 10, 11:25 AM · Restricted Project

Mon, Mar 9

DiggerLin created D75866: [AIX] supporting the visibility attribute for aix assembly.
Mon, Mar 9, 12:25 PM · Restricted Project
DiggerLin retitled D75866: [AIX] supporting the visibility attribute for aix assembly from [AIX] supporting the visibility attribute for XCOFF assembly to [AIX] supporting the visibility attribute for aix assembly.
Mon, Mar 9, 12:25 PM · Restricted Project

Tue, Mar 3

DiggerLin committed rGf9896435c99b: [AIX][XCOFF] Fix XCOFFObjectWriter assertion failure with alignment-related gap… (authored by DiggerLin).
[AIX][XCOFF] Fix XCOFFObjectWriter assertion failure with alignment-related gap…
Tue, Mar 3, 7:05 AM
DiggerLin closed D71845: [AIX][XCOFF] Fix XCOFFObjectWriter assertion failure with alignment-related gap and improve text section output testing.
Tue, Mar 3, 7:05 AM · Restricted Project

Mon, Mar 2

DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

address comment

Mon, Mar 2, 12:55 PM · Restricted Project
DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Mon, Mar 2, 12:55 PM · Restricted Project
DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Mon, Mar 2, 12:06 PM · Restricted Project
DiggerLin updated the diff for D71845: [AIX][XCOFF] Fix XCOFFObjectWriter assertion failure with alignment-related gap and improve text section output testing.

address comment

Mon, Mar 2, 7:12 AM · Restricted Project

Feb 28 2020

DiggerLin added inline comments to D75131: [llvm-objdump][XCOFF][AIX] Implement -r option.
Feb 28 2020, 1:14 PM · Restricted Project
DiggerLin added inline comments to D71845: [AIX][XCOFF] Fix XCOFFObjectWriter assertion failure with alignment-related gap and improve text section output testing.
Feb 28 2020, 12:56 PM · Restricted Project
DiggerLin updated the diff for D71845: [AIX][XCOFF] Fix XCOFFObjectWriter assertion failure with alignment-related gap and improve text section output testing.
Feb 28 2020, 12:48 PM · Restricted Project
DiggerLin updated the diff for D71845: [AIX][XCOFF] Fix XCOFFObjectWriter assertion failure with alignment-related gap and improve text section output testing.

address comment

Feb 28 2020, 10:23 AM · Restricted Project

Feb 27 2020

DiggerLin added a comment to D71845: [AIX][XCOFF] Fix XCOFFObjectWriter assertion failure with alignment-related gap and improve text section output testing.

Hi Digger, I would suggest being more descriptive in the title regarding the nature of the bug:
[AIX] Fix XCOFFObjectWriter assertion failure with alignment-related gap; improve text section output testing

Feb 27 2020, 1:46 PM · Restricted Project
DiggerLin retitled D71845: [AIX][XCOFF] Fix XCOFFObjectWriter assertion failure with alignment-related gap and improve text section output testing from [AIX][XCOFF][BUG-FIXED]Fixed a bug of XCOFFObjectWriter.cpp and add test for raw text section content and test section header to [AIX][XCOFF][AIX] Fix XCOFFObjectWriter assertion failure with alignment-related gap and improve text section output testing.
Feb 27 2020, 1:46 PM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

address comment

Feb 27 2020, 1:31 PM · Restricted Project
DiggerLin retitled D71845: [AIX][XCOFF] Fix XCOFFObjectWriter assertion failure with alignment-related gap and improve text section output testing from [AIX][XCOFF] add test for raw text section content and test section header and Fixed a bug of XCOFFObjectWriter.cpp to [AIX][XCOFF][BUG-FIXED]Fixed a bug of XCOFFObjectWriter.cpp and add test for raw text section content and test section header.
Feb 27 2020, 11:47 AM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Feb 27 2020, 7:00 AM · Restricted Project

Feb 26 2020

DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

implement as

Feb 26 2020, 2:20 PM · Restricted Project
DiggerLin retitled D71845: [AIX][XCOFF] Fix XCOFFObjectWriter assertion failure with alignment-related gap and improve text section output testing from [AIX][XCOFF] Fixed a bug of XCOFFObjectWriter.cpp and add test for raw text section content and test section header to [AIX][XCOFF] add test for raw text section content and test section header and Fixed a bug of XCOFFObjectWriter.cpp .
Feb 26 2020, 6:14 AM · Restricted Project

Feb 25 2020

DiggerLin updated the diff for D71845: [AIX][XCOFF] Fix XCOFFObjectWriter assertion failure with alignment-related gap and improve text section output testing.
Feb 25 2020, 5:48 PM · Restricted Project
DiggerLin added inline comments to D71845: [AIX][XCOFF] Fix XCOFFObjectWriter assertion failure with alignment-related gap and improve text section output testing.
Feb 25 2020, 3:59 PM · Restricted Project
DiggerLin updated the diff for D71845: [AIX][XCOFF] Fix XCOFFObjectWriter assertion failure with alignment-related gap and improve text section output testing.

fixed a bug of llvm/lib/MC/XCOFFObjectWriter.cpp which will hit assert

Feb 25 2020, 3:54 PM · Restricted Project
DiggerLin retitled D71845: [AIX][XCOFF] Fix XCOFFObjectWriter assertion failure with alignment-related gap and improve text section output testing from [AIX][XCOFF] add test for raw text section content and test section header to [AIX][XCOFF] Fixed a bug of XCOFFObjectWriter.cpp and add test for raw text section content and test section header.
Feb 25 2020, 3:54 PM · Restricted Project
DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Feb 25 2020, 11:15 AM · Restricted Project

Feb 21 2020

DiggerLin accepted D74924: [XCOFF][AIX] Put undefined symbol name into StringTable when neccessary.

LGTM

Feb 21 2020, 8:32 AM · Restricted Project

Feb 20 2020

DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Feb 20 2020, 12:38 PM · Restricted Project
DiggerLin updated the summary of D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Feb 20 2020, 12:38 PM · Restricted Project
DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Feb 20 2020, 10:20 AM · Restricted Project
DiggerLin updated the diff for D71845: [AIX][XCOFF] Fix XCOFFObjectWriter assertion failure with alignment-related gap and improve text section output testing.
Feb 20 2020, 8:48 AM · Restricted Project

Feb 19 2020

DiggerLin updated the summary of D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Feb 19 2020, 2:09 PM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

add a new option --symbol_description to control the symbol format of the llvm-objdump -D

Feb 19 2020, 2:09 PM · Restricted Project
DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Feb 19 2020, 1:59 PM · Restricted Project

Feb 14 2020

DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Feb 14 2020, 6:23 AM · Restricted Project

Feb 13 2020

DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Feb 13 2020, 8:15 AM · Restricted Project

Feb 12 2020

DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

change code based on the patch https://reviews.llvm.org/D74240
[NFC] Refactor the tuple of symbol information with structure for llvm-objdump

Feb 12 2020, 10:42 AM · Restricted Project
DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Feb 12 2020, 10:24 AM · Restricted Project

Feb 11 2020

DiggerLin committed rG9c1a88c96457: [NFC] Refactor the tuple of symbol information with structure for llvm-objdump (authored by DiggerLin).
[NFC] Refactor the tuple of symbol information with structure for llvm-objdump
Feb 11 2020, 11:47 AM
DiggerLin added inline comments to D74240: [NFC] Refactor the tuple of symbol information with structure for llvm-objdump.
Feb 11 2020, 8:35 AM · Restricted Project

Feb 10 2020

DiggerLin committed rG09d26b79d295: [NFC] Refactor the tuple of symbol information with structure for llvm-objdump (authored by DiggerLin).
[NFC] Refactor the tuple of symbol information with structure for llvm-objdump
Feb 10 2020, 4:24 PM
DiggerLin closed D74240: [NFC] Refactor the tuple of symbol information with structure for llvm-objdump.
Feb 10 2020, 4:23 PM · Restricted Project
DiggerLin added inline comments to D74240: [NFC] Refactor the tuple of symbol information with structure for llvm-objdump.
Feb 10 2020, 12:36 PM · Restricted Project
DiggerLin committed rGaa86311e6204: [AIX][XCOFF] Support Mergeable2ByteCString and Mergeable4ByteCString (authored by DiggerLin).
[AIX][XCOFF] Support Mergeable2ByteCString and Mergeable4ByteCString
Feb 10 2020, 11:51 AM
DiggerLin closed D74164: [AIX][XCOFF] Support Mergeable2ByteCString and Mergeable4ByteCString.
Feb 10 2020, 11:51 AM · Restricted Project
DiggerLin added inline comments to D74240: [NFC] Refactor the tuple of symbol information with structure for llvm-objdump.
Feb 10 2020, 10:09 AM · Restricted Project
DiggerLin accepted D74256: [AIX] Improve 32/64-bit build configuration.

LGTM

Feb 10 2020, 8:38 AM · Restricted Project
DiggerLin updated the diff for D74164: [AIX][XCOFF] Support Mergeable2ByteCString and Mergeable4ByteCString.
Feb 10 2020, 7:57 AM · Restricted Project

Feb 7 2020

DiggerLin updated the diff for D74240: [NFC] Refactor the tuple of symbol information with structure for llvm-objdump.
Feb 7 2020, 11:30 AM · Restricted Project
DiggerLin retitled D74240: [NFC] Refactor the tuple of symbol information with structure for llvm-objdump from refactor the tuple of symbol information with structure. to refactor the tuple of symbol information with structure for llvm-objdump.
Feb 7 2020, 10:54 AM · Restricted Project
DiggerLin edited reviewers for D74240: [NFC] Refactor the tuple of symbol information with structure for llvm-objdump, added: daltenty, Xiangling_L; removed: jhenderson.
Feb 7 2020, 10:45 AM · Restricted Project
DiggerLin removed a reviewer for D74240: [NFC] Refactor the tuple of symbol information with structure for llvm-objdump: jhenderson.
Feb 7 2020, 10:26 AM · Restricted Project