Page MenuHomePhabricator

DiggerLin (Digger Lin)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 28 2019, 10:08 AM (212 w, 10 h)

Recent Activity

Thu, Mar 16

DiggerLin added a comment to D142479: [AIX] support 64bit global symbol table for big archive.

gentle ping. if you have time , would you like to take sometime to review @jhenderson

Thu, Mar 16, 11:52 AM · Restricted Project, Restricted Project

Wed, Mar 15

DiggerLin updated the diff for D146071: [AIX] unset bit "IsBackChainStored" of traceback table for leaf functions with no stack frame.

add a redzone boundary test case

Wed, Mar 15, 2:28 PM · Restricted Project, Restricted Project
DiggerLin added inline comments to D146071: [AIX] unset bit "IsBackChainStored" of traceback table for leaf functions with no stack frame.
Wed, Mar 15, 10:01 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D146071: [AIX] unset bit "IsBackChainStored" of traceback table for leaf functions with no stack frame.

Are there still tests where IsBackChainStored is true?

Wed, Mar 15, 6:43 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D146071: [AIX] unset bit "IsBackChainStored" of traceback table for leaf functions with no stack frame.

fixed part of comment.

Wed, Mar 15, 6:41 AM · Restricted Project, Restricted Project

Tue, Mar 14

DiggerLin requested review of D146071: [AIX] unset bit "IsBackChainStored" of traceback table for leaf functions with no stack frame.
Tue, Mar 14, 10:50 AM · Restricted Project, Restricted Project

Thu, Mar 9

DiggerLin added a comment to D142479: [AIX] support 64bit global symbol table for big archive.

gentle ping.

Thu, Mar 9, 8:16 AM · Restricted Project, Restricted Project

Wed, Mar 8

DiggerLin updated the summary of D145600: [AIX] change "llvm-ar" to "env OBJECT_MODE=any llvm-ar" in clang/test for AIX OS.
Wed, Mar 8, 11:48 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D142484: [LinkerWrapper] Only import static libraries with needed symbols.

I might just put that this test requires Linux. Because I don't think I can debug it without access to the system. We don't really support offloading on anything but Linux anyway.

I think that makes sense. We'd need time to investigate it on AIX anyways.

Wed, Mar 8, 10:37 AM · Restricted Project, Restricted Project, Restricted Project
DiggerLin requested review of D145600: [AIX] change "llvm-ar" to "env OBJECT_MODE=any llvm-ar" in clang/test for AIX OS.
Wed, Mar 8, 10:19 AM · Restricted Project, Restricted Project

Tue, Mar 7

DiggerLin added inline comments to D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Tue, Mar 7, 2:02 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Tue, Mar 7, 2:02 PM · Restricted Project, Restricted Project

Thu, Mar 2

DiggerLin accepted D144281: Update output for timestamp with llvm-readobj on XCOFF files..

LGTM

Thu, Mar 2, 7:58 AM · Restricted Project, Restricted Project

Mon, Feb 27

DiggerLin added inline comments to D139864: [AIX] Demangle the name prefix with '.' in AIX OS for llvm-cxxfilt.
Mon, Feb 27, 10:38 AM · Restricted Project, Restricted Project
DiggerLin updated subscribers of D139864: [AIX] Demangle the name prefix with '.' in AIX OS for llvm-cxxfilt.
Mon, Feb 27, 10:27 AM · Restricted Project, Restricted Project
DiggerLin requested review of D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive. .
Mon, Feb 27, 6:51 AM · Restricted Project, Restricted Project

Fri, Feb 24

DiggerLin added a comment to D123949: [AIX] support write operation of big archive..

Hi @DiggerLin. Currently the --help text states --format=aix but llvm-ar accepts --format=bigarchive. Could you fix that please.

Fri, Feb 24, 10:41 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D142479: [AIX] support 64bit global symbol table for big archive.

fixed a bug

Fri, Feb 24, 6:45 AM · Restricted Project, Restricted Project

Feb 16 2023

DiggerLin updated the diff for D139864: [AIX] Demangle the name prefix with '.' in AIX OS for llvm-cxxfilt.
Feb 16 2023, 10:45 AM · Restricted Project, Restricted Project

Feb 13 2023

DiggerLin added inline comments to D139864: [AIX] Demangle the name prefix with '.' in AIX OS for llvm-cxxfilt.
Feb 13 2023, 7:28 AM · Restricted Project, Restricted Project

Feb 6 2023

DiggerLin updated the diff for D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.

In my previous implementation, It will only work on big archives with an empty global symbol table. if there is already a global symbol table (regardless of whether it's 32-bit or 64-bit) in the big archive, then llvm-ranlib -X will not do anything. (For example, if a big archive has a 64-bit global symbol table, then llvm-ranlib -X32 will not do anything). This is different from the AIX ranlib, where if there is only a 64-bit global symbol table, then -X32 will generate a 32-bit global symbol table, resulting in both the 32-bit and 64-bit global symbol tables being present in the big archive at the same time. I added the new functionality as AIX OS "ranlib"

Feb 6 2023, 2:05 PM · Restricted Project, Restricted Project

Feb 3 2023

DiggerLin added a comment to D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.

I'm not sure I understand why the logic for llvm-ranlib seems to be significantly different to how the option is implemented for llvm-ar? Could you explain this, please?

Feb 3 2023, 2:05 PM · Restricted Project, Restricted Project
DiggerLin added inline comments to D142479: [AIX] support 64bit global symbol table for big archive.
Feb 3 2023, 10:20 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D142479: [AIX] support 64bit global symbol table for big archive.

address comment and add bit code into test case.

Feb 3 2023, 10:19 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D143097: [NFC] add new function is64Bit for SymbolicFile class .
Feb 3 2023, 6:03 AM · Restricted Project, Restricted Project

Feb 2 2023

DiggerLin updated the diff for D143097: [NFC] add new function is64Bit for SymbolicFile class .

address comment .

Feb 2 2023, 8:20 AM · Restricted Project, Restricted Project

Feb 1 2023

DiggerLin added a comment to D142479: [AIX] support 64bit global symbol table for big archive.

I'm out of time for now. Please take a look at my inline comments and I'll come back to this at some point after you've addressed them (I have a big backlog to catch up on, so it may be a while).

Feb 1 2023, 12:23 PM · Restricted Project, Restricted Project
DiggerLin added inline comments to D142479: [AIX] support 64bit global symbol table for big archive.
Feb 1 2023, 12:22 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D143097: [NFC] add new function is64Bit for SymbolicFile class .

run git format

Feb 1 2023, 11:11 AM · Restricted Project, Restricted Project
DiggerLin requested review of D143097: [NFC] add new function is64Bit for SymbolicFile class .
Feb 1 2023, 11:07 AM · Restricted Project, Restricted Project

Jan 30 2023

DiggerLin accepted D142727: [AIX][CMake] Use top-level tools in llvm_ExternalProject_Add.

LGTM.

Jan 30 2023, 1:38 PM · Restricted Project, Restricted Project
DiggerLin added a comment to D142727: [AIX][CMake] Use top-level tools in llvm_ExternalProject_Add.

when using CMake versions >= 3.22 we'll pickup the built llvm-ranlib by default if it's in the path (which it is when doing a sub build via llvm_ExternalProject_Add for the runtimes),

Jan 30 2023, 11:10 AM · Restricted Project, Restricted Project

Jan 26 2023

DiggerLin retitled D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS from [AIX] supportting -X options for llvm-ranlib in AIX OS to [AIX] supporting -X options for llvm-ranlib in AIX OS.
Jan 26 2023, 3:37 PM · Restricted Project, Restricted Project
DiggerLin retitled D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS from [AIX] llvm-ranlib accept -X options in AIX OS to [AIX] supportting -X options for llvm-ranlib in AIX OS.
Jan 26 2023, 3:37 PM · Restricted Project, Restricted Project
DiggerLin retitled D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS from [AIX] llvm-ranlib accept -X options when acting as in AIX OS to [AIX] llvm-ranlib accept -X options in AIX OS.
Jan 26 2023, 1:09 PM · Restricted Project, Restricted Project
DiggerLin retitled D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS from [AIX] llvm-ar doesn't accept -X options when acting as llvm-ranlib in AIX OS to [AIX] llvm-ranlib accept -X options when acting as in AIX OS.
Jan 26 2023, 1:07 PM · Restricted Project, Restricted Project
DiggerLin added reviewers for D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS: gbreynoo, MaskRay.
Jan 26 2023, 1:06 PM · Restricted Project, Restricted Project
DiggerLin requested review of D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS.
Jan 26 2023, 1:04 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D142479: [AIX] support 64bit global symbol table for big archive.
Jan 26 2023, 10:01 AM · Restricted Project, Restricted Project

Jan 24 2023

DiggerLin added a reviewer for D142479: [AIX] support 64bit global symbol table for big archive: Esme.
Jan 24 2023, 8:46 AM · Restricted Project, Restricted Project
DiggerLin requested review of D142479: [AIX] support 64bit global symbol table for big archive.
Jan 24 2023, 8:28 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D139864: [AIX] Demangle the name prefix with '.' in AIX OS for llvm-cxxfilt.

Gentle Ping.

Jan 24 2023, 8:26 AM · Restricted Project, Restricted Project

Jan 12 2023

DiggerLin accepted D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.

LGTM

Jan 12 2023, 8:18 AM · Restricted Project, Restricted Project

Jan 4 2023

DiggerLin added a reviewer for D139864: [AIX] Demangle the name prefix with '.' in AIX OS for llvm-cxxfilt: stephenpeckham.
Jan 4 2023, 6:24 AM · Restricted Project, Restricted Project

Dec 15 2022

DiggerLin added inline comments to D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Dec 15 2022, 7:35 AM · Restricted Project, Restricted Project

Dec 14 2022

DiggerLin added inline comments to D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Dec 14 2022, 12:12 PM · Restricted Project, Restricted Project
DiggerLin accepted D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Dec 14 2022, 6:47 AM · Restricted Project, Restricted Project

Dec 13 2022

DiggerLin added inline comments to D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Dec 13 2022, 1:37 PM · Restricted Project, Restricted Project
DiggerLin added inline comments to D89049: [AIX][XCOFF] print out the traceback info .
Dec 13 2022, 10:40 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D89049: [AIX][XCOFF] print out the traceback info .

added --traceback-table imply --disassemble-all and addressed comments.

Dec 13 2022, 10:40 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.

thanks for adding a new malform empty archive test case.

Dec 13 2022, 10:07 AM · Restricted Project, Restricted Project

Dec 12 2022

DiggerLin retitled D139864: [AIX] Demangle the name prefix with '.' in AIX OS for llvm-cxxfilt from [AIX] Demangle the name prefix with '.' in AIX OS to [AIX] Demangle the name prefix with '.' in AIX OS for llvm-cxxfilt.
Dec 12 2022, 11:09 AM · Restricted Project, Restricted Project
DiggerLin requested review of D139864: [AIX] Demangle the name prefix with '.' in AIX OS for llvm-cxxfilt.
Dec 12 2022, 11:08 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.
Dec 12 2022, 6:23 AM · Restricted Project, Restricted Project
DiggerLin accepted D138985: [AIX][BigArchive][NFC] Add test case that list members of archive with free list in it.

LGTM

Dec 12 2022, 6:08 AM · Restricted Project, Restricted Project

Dec 9 2022

DiggerLin added inline comments to D138985: [AIX][BigArchive][NFC] Add test case that list members of archive with free list in it.
Dec 9 2022, 10:24 AM · Restricted Project, Restricted Project
DiggerLin accepted D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations..

LGTM , but wait for several days to see whether other reviewer has comment or not.

Dec 9 2022, 8:08 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj.
Dec 9 2022, 7:56 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj.

Btw. Do you have any plans to implement an option like "--loader-section" to embrace all this loader section related information?

Dec 9 2022, 7:43 AM · Restricted Project, Restricted Project

Dec 8 2022

DiggerLin updated the diff for D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj.

added decode size of relocation type in --expand-relocs

Dec 8 2022, 1:07 PM · Restricted Project, Restricted Project

Dec 7 2022

DiggerLin updated the diff for D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj.

added a new no expand relocation format.

Dec 7 2022, 3:27 PM · Restricted Project, Restricted Project
DiggerLin added a comment to D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj.

Btw. Do you have any plans to implement an option like "--loader-section" to embrace all this loader section related information?

Dec 7 2022, 7:11 AM · Restricted Project, Restricted Project

Dec 6 2022

DiggerLin added inline comments to D89049: [AIX][XCOFF] print out the traceback info .
Dec 6 2022, 10:54 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D89049: [AIX][XCOFF] print out the traceback info .
Dec 6 2022, 10:53 AM · Restricted Project, Restricted Project
DiggerLin added a reviewer for D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj: stephenpeckham.
Dec 6 2022, 10:44 AM · Restricted Project, Restricted Project
DiggerLin edited reviewers for D89049: [AIX][XCOFF] print out the traceback info , added: stephenpeckham; removed: jasonliu.
Dec 6 2022, 10:43 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Dec 6 2022, 8:49 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations..
Dec 6 2022, 8:16 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations..

Hi @DiggerLin, thank you for your review. I'm also confused by the description from the doc, if my understanding is correct, according to the doc, the FixedValue will ignore the value of Fixup.getOffset(), because the address of the csect containing the branch instruction to be modified equals to SectionMap[ParentSec]->Address + Layout.getFragmentOffset(Fragment). This is obviously incorrect. I have tested LNT and bootstrap for this patch under the options of -fintegrated-as -ffunction-sections, and both are clean.

Dec 6 2022, 7:54 AM · Restricted Project, Restricted Project

Dec 5 2022

DiggerLin added inline comments to D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Dec 5 2022, 10:19 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj.

Essentially looks reasonable to me, although I haven't verified that all the call paths are properly covered by tests. @Esme or another XCOFF developer should take a look at this before landing it.

FYI, my last day working before Christmas is next Friday, and I may have limited reviewing time next week. I won't be back and able to review things further after that until late January.

Dec 5 2022, 7:05 AM · Restricted Project, Restricted Project

Dec 2 2022

DiggerLin added inline comments to D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations..
Dec 2 2022, 1:46 PM · Restricted Project, Restricted Project
DiggerLin added inline comments to D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations..
Dec 2 2022, 8:50 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D89049: [AIX][XCOFF] print out the traceback info .

address James' comment. thanks James.

Dec 2 2022, 7:47 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D89049: [AIX][XCOFF] print out the traceback info .
Dec 2 2022, 7:46 AM · Restricted Project, Restricted Project

Dec 1 2022

DiggerLin updated the diff for D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj.

added a new test case to test invalid symbol name for relocation.

Dec 1 2022, 8:06 AM · Restricted Project, Restricted Project

Nov 28 2022

DiggerLin added inline comments to D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj.
Nov 28 2022, 12:59 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj.
Nov 28 2022, 12:59 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D89049: [AIX][XCOFF] print out the traceback info .

address James' comment

Nov 28 2022, 10:58 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D89049: [AIX][XCOFF] print out the traceback info .
Nov 28 2022, 10:56 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Nov 28 2022, 10:20 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..

change the description to 'support the relocation overflow section."

As the doc says, the overflow section is required when either of the relocation entries or the line number entries exceeds 65,534. As long as one of the counts exceeds 65,534, the other one will also be set to 65535 in the primary section header, and then the overflow section will record actual counts for both relocation entries and line number entries, where the s_paddr for relocation entries and s_vaddr for line number entries.
Therefore I reckon there's no need to identify whether it's a relocation overflow section or line number overflow section.

Nov 28 2022, 6:49 AM · Restricted Project, Restricted Project

Nov 25 2022

DiggerLin updated the diff for D89049: [AIX][XCOFF] print out the traceback info .
Nov 25 2022, 12:49 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D89049: [AIX][XCOFF] print out the traceback info .

addressed comment , rebased the patch , changed the test case from using canned xcoff object file to using yaml2obj.

Nov 25 2022, 10:41 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D89049: [AIX][XCOFF] print out the traceback info .
Nov 25 2022, 10:34 AM · Restricted Project, Restricted Project

Nov 23 2022

DiggerLin added inline comments to D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj.
Nov 23 2022, 1:09 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj.

address James's comment. thanks @jhenderson

Nov 23 2022, 1:08 PM · Restricted Project, Restricted Project

Nov 21 2022

DiggerLin added a comment to D135887: [XCOFF] llvm-readobj support display symbol table of loader section of xcoff object file..

there is a use of uninitialized value:
https://lab.llvm.org/buildbot/#/builders/5/builds/29299

Nov 21 2022, 10:10 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D135887: [XCOFF] llvm-readobj support display symbol table of loader section of xcoff object file..

(Note, a typo in the commit [XCOFF] llvvm-readobj ...)

Nov 21 2022, 6:47 AM · Restricted Project, Restricted Project

Nov 18 2022

DiggerLin retitled D135887: [XCOFF] llvm-readobj support display symbol table of loader section of xcoff object file. from [XCOFF] llvvm-readobj support display symbol table of loader section of xcoff object file. to [XCOFF] llvm-readobj support display symbol table of loader section of xcoff object file..
Nov 18 2022, 9:39 AM · Restricted Project, Restricted Project

Nov 17 2022

DiggerLin updated the summary of D89049: [AIX][XCOFF] print out the traceback info .
Nov 17 2022, 12:28 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj.
Nov 17 2022, 7:07 AM · Restricted Project, Restricted Project

Nov 16 2022

DiggerLin added inline comments to D135887: [XCOFF] llvm-readobj support display symbol table of loader section of xcoff object file..
Nov 16 2022, 6:13 AM · Restricted Project, Restricted Project

Nov 15 2022

DiggerLin added inline comments to D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..
Nov 15 2022, 10:11 AM · Restricted Project, Restricted Project

Nov 14 2022

DiggerLin added a comment to D137819: [XCOFF] support the overflow section (only relocation overflow is handled)..

change the description to 'support the relocation overflow section."

Nov 14 2022, 1:42 PM · Restricted Project, Restricted Project

Nov 11 2022

DiggerLin accepted D137230: [XCOFF] set fragment for XMC_PR csects..

LGTM, please wait for several days and Hubert maybe has comment on it. I do not think we need to check so many symbol items and relocation items in the test case, but I can not give any suggestion on it.

Nov 11 2022, 11:56 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D135887: [XCOFF] llvm-readobj support display symbol table of loader section of xcoff object file..
Nov 11 2022, 8:09 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D135887: [XCOFF] llvm-readobj support display symbol table of loader section of xcoff object file..

address James' comment

Nov 11 2022, 8:08 AM · Restricted Project, Restricted Project

Nov 9 2022

DiggerLin added inline comments to D135887: [XCOFF] llvm-readobj support display symbol table of loader section of xcoff object file..
Nov 9 2022, 10:27 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D135887: [XCOFF] llvm-readobj support display symbol table of loader section of xcoff object file..

address comment

Nov 9 2022, 10:26 AM · Restricted Project, Restricted Project