Page MenuHomePhabricator

DiggerLin (Digger Lin)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 28 2019, 10:08 AM (174 w, 23 h)

Recent Activity

Wed, Jun 29

DiggerLin added inline comments to D128148: [XCOFF] write the aux header when the visibility is specified in XCOFF32..
Wed, Jun 29, 1:28 PM · Restricted Project, Restricted Project

Tue, Jun 28

DiggerLin added inline comments to D127864: [llvm-ar] Add object mode option -X for AIX.
Tue, Jun 28, 1:45 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D124865: [AIX] support read global symbol of big archive.

address James' comment

Tue, Jun 28, 1:34 PM · Restricted Project, Restricted Project
DiggerLin added inline comments to D124865: [AIX] support read global symbol of big archive.
Tue, Jun 28, 1:32 PM · Restricted Project, Restricted Project
DiggerLin added a comment to D124865: [AIX] support read global symbol of big archive.

delete.test is a test that shows that llvm-ar can delete symbols when its members are deleted. It's hardly comprehensive coverage of the archive symbol table code. However, there are many other symbol table tests both in the Object and tools/llvm-ar test directories. It's not clear to me why the changes you've made didn't cause a test to start passing/failing when it wasn't before, at least on AIX OS. You need to investigate, and ensure there is coverage of the new code you've added in a test dedicated to symbol table reading etc.

Tue, Jun 28, 8:56 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D127864: [llvm-ar] Add object mode option -X for AIX.

address James' comment.

Tue, Jun 28, 7:13 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D127864: [llvm-ar] Add object mode option -X for AIX.
Tue, Jun 28, 6:24 AM · Restricted Project, Restricted Project

Fri, Jun 24

DiggerLin added inline comments to D127864: [llvm-ar] Add object mode option -X for AIX.
Fri, Jun 24, 9:18 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D127864: [llvm-ar] Add object mode option -X for AIX.
Fri, Jun 24, 9:17 AM · Restricted Project, Restricted Project

Wed, Jun 22

DiggerLin accepted D128220: [libc++][lit][AIX] Port tests for money format to AIX.

LGTM

Wed, Jun 22, 8:57 AM · Restricted Project, Restricted Project, Restricted Project
DiggerLin added a comment to D124865: [AIX] support read global symbol of big archive.

I feel like this code is missing testing for the non-error cases. In particular, I'd expect to see some sort of test that shows that the archive symbol table can be read successfully. I think you can do that using llvm-nm --print-armap. I'd be surprised if there aren't already equivalent test cases for other formats that do this, so you may be able to copy/modify those to cover big archives too.

Wed, Jun 22, 6:11 AM · Restricted Project, Restricted Project

Tue, Jun 21

DiggerLin updated the diff for D124865: [AIX] support read global symbol of big archive.
Tue, Jun 21, 8:08 AM · Restricted Project, Restricted Project

Mon, Jun 20

DiggerLin added inline comments to D128148: [XCOFF] write the aux header when the visibility is specified in XCOFF32..
Mon, Jun 20, 9:51 AM · Restricted Project, Restricted Project

Fri, Jun 17

DiggerLin updated the diff for D127864: [llvm-ar] Add object mode option -X for AIX.
Fri, Jun 17, 12:50 PM · Restricted Project, Restricted Project

Thu, Jun 16

DiggerLin updated the diff for D127864: [llvm-ar] Add object mode option -X for AIX.

address comment

Thu, Jun 16, 11:15 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D127864: [llvm-ar] Add object mode option -X for AIX.
Thu, Jun 16, 10:57 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D124865: [AIX] support read global symbol of big archive.
Thu, Jun 16, 6:55 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D124865: [AIX] support read global symbol of big archive.
Thu, Jun 16, 6:47 AM · Restricted Project, Restricted Project

Wed, Jun 15

DiggerLin updated the summary of D127864: [llvm-ar] Add object mode option -X for AIX.
Wed, Jun 15, 6:08 PM · Restricted Project, Restricted Project
DiggerLin retitled D127864: [llvm-ar] Add object mode option -X for AIX from [AIX] add object mode -X option for llvm-ar on AIX OS. to [llvm-ar] Add object mode option -X for AIX.
Wed, Jun 15, 5:56 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D127864: [llvm-ar] Add object mode option -X for AIX.

reformat llvm-ar.rst with Sphinx

Wed, Jun 15, 12:56 PM · Restricted Project, Restricted Project
DiggerLin retitled D127864: [llvm-ar] Add object mode option -X for AIX from [AIX] add object mode -X option for llvm-ar in AIX OS. to [AIX] add object mode -X option for llvm-ar on AIX OS..
Wed, Jun 15, 11:30 AM · Restricted Project, Restricted Project
DiggerLin updated the summary of D127864: [llvm-ar] Add object mode option -X for AIX.
Wed, Jun 15, 7:57 AM · Restricted Project, Restricted Project
DiggerLin requested review of D127864: [llvm-ar] Add object mode option -X for AIX.
Wed, Jun 15, 7:56 AM · Restricted Project, Restricted Project

May 31 2022

DiggerLin requested review of D126705: [libc++][CI][AIX] modify the equivalence classes of regex_match for locale "cs_CZ.ISO8859-2".
May 31 2022, 8:22 AM · Restricted Project, Restricted Project

May 30 2022

DiggerLin retitled D126376: [libc++][CI] AIX does not have alternative for time_put_byname from [libc++][CI] aix os do not have alternative for my_facet to [libc++][CI] AIX does not have alternative for time_put_byname.
May 30 2022, 8:12 AM · Restricted Project, Restricted Project

May 26 2022

DiggerLin requested review of D126474: [libc++][CI][AIX] change grouping() return value of std::moneypunct_byname for en_US.UTF-8.
May 26 2022, 7:39 AM · Restricted Project, Restricted Project

May 25 2022

DiggerLin requested review of D126407: [libc++][CI][AIX] modify the equivalence classes of regex_match for locale "cs_CZ.ISO8859-2".
May 25 2022, 12:40 PM · Restricted Project, Restricted Project
DiggerLin requested review of D126376: [libc++][CI] AIX does not have alternative for time_put_byname.
May 25 2022, 6:44 AM · Restricted Project, Restricted Project

May 19 2022

DiggerLin updated the diff for D125923: [libc++][CI] fixed convert_thousands_sep_ru_RU for Russian in the libcxx/test/support/locale_helpers.h for AIX.

git clang format

May 19 2022, 7:41 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D125927: [libc++][CI] fixed "LOCALE_fr_FR_UTF_8" for my_facet for AIX.
May 19 2022, 7:28 AM · Restricted Project, Restricted Project

May 18 2022

DiggerLin requested review of D125927: [libc++][CI] fixed "LOCALE_fr_FR_UTF_8" for my_facet for AIX.
May 18 2022, 1:51 PM · Restricted Project, Restricted Project
DiggerLin requested review of D125923: [libc++][CI] fixed convert_thousands_sep_ru_RU for Russian in the libcxx/test/support/locale_helpers.h for AIX.
May 18 2022, 1:06 PM · Restricted Project, Restricted Project
DiggerLin added a reviewer for D125801: [libc++][CI] fixed a return curr_symbol() for Russian in the libcxx/test/support/locale_helpers.h for AIX: xingxue.
May 18 2022, 11:57 AM · Restricted Project, Restricted Project

May 17 2022

DiggerLin requested review of D125801: [libc++][CI] fixed a return curr_symbol() for Russian in the libcxx/test/support/locale_helpers.h for AIX.
May 17 2022, 8:53 AM · Restricted Project, Restricted Project
DiggerLin accepted D125772: [NFC][AIX] Reenable mri1.test.

LGTM , thanks

May 17 2022, 7:24 AM · Restricted Project, Restricted Project

May 13 2022

DiggerLin added a comment to D123949: [AIX] support write operation of big archive..

All looks good to me, but I think it would be worth getting a second pair of eyes on it (@Esme?)

May 13 2022, 8:22 AM · Restricted Project, Restricted Project

May 12 2022

DiggerLin updated the diff for D124865: [AIX] support read global symbol of big archive.

address comment

May 12 2022, 9:35 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D123949: [AIX] support write operation of big archive..
May 12 2022, 6:37 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D123949: [AIX] support write operation of big archive..
May 12 2022, 6:20 AM · Restricted Project, Restricted Project

May 11 2022

DiggerLin accepted D125141: [clang][AIX] Don't ignore XCOFF visibility by default.

LGTM.

May 11 2022, 8:35 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D123949: [AIX] support write operation of big archive..

addressed comment. thanks James.

May 11 2022, 7:12 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D123949: [AIX] support write operation of big archive..
May 11 2022, 6:57 AM · Restricted Project, Restricted Project

May 10 2022

DiggerLin updated the diff for D124865: [AIX] support read global symbol of big archive.

address Jame's comment. thanks for the comments

May 10 2022, 10:30 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D124865: [AIX] support read global symbol of big archive.
May 10 2022, 10:28 AM · Restricted Project, Restricted Project

May 5 2022

DiggerLin updated the diff for D124865: [AIX] support read global symbol of big archive.

address James's comment and a new global symbol table malformed test case , thanks

May 5 2022, 1:43 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and .

address MaskRay's comment.

May 5 2022, 6:26 AM · Restricted Project, Restricted Project
DiggerLin updated the summary of D124940: [AIX] llvm-link support big archive..
May 5 2022, 6:14 AM · Restricted Project, Restricted Project

May 4 2022

DiggerLin added a comment to D124940: [AIX] llvm-link support big archive..

It's unclear why the old code doesn't support big archives while the new code supports big archives. Can you explain it in the summary and the comment?

May 4 2022, 2:22 PM · Restricted Project, Restricted Project
DiggerLin updated the summary of D124940: [AIX] llvm-link support big archive..
May 4 2022, 2:21 PM · Restricted Project, Restricted Project
DiggerLin added inline comments to D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and .
May 4 2022, 10:56 AM · Restricted Project, Restricted Project
DiggerLin requested review of D124940: [AIX] llvm-link support big archive..
May 4 2022, 10:00 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and .
May 4 2022, 8:14 AM · Restricted Project, Restricted Project

May 3 2022

DiggerLin added inline comments to D124654: [AIX] Handling the label alignment of a global variable with its multiple aliases..
May 3 2022, 12:59 PM · Restricted Project, Restricted Project
DiggerLin requested review of D124865: [AIX] support read global symbol of big archive.
May 3 2022, 10:33 AM · Restricted Project, Restricted Project

May 2 2022

DiggerLin added inline comments to D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..
May 2 2022, 10:10 AM · Restricted Project, Restricted Project

Apr 27 2022

DiggerLin updated the diff for D123949: [AIX] support write operation of big archive..
Apr 27 2022, 3:17 PM · Restricted Project, Restricted Project
DiggerLin added inline comments to D123949: [AIX] support write operation of big archive..
Apr 27 2022, 11:20 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D123949: [AIX] support write operation of big archive..
Apr 27 2022, 11:19 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D123949: [AIX] support write operation of big archive..

address comment and fix some bug

Apr 27 2022, 10:43 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D123949: [AIX] support write operation of big archive..

It looks like in the latest diff you've reinstated some XFAIL/--format=gnu commands. Why?

Not looked at everything quite today, as am out of time.

Apr 27 2022, 6:25 AM · Restricted Project, Restricted Project

Apr 26 2022

DiggerLin accepted D123951: [LLVM][AIX] Implement XCOFF exported visibility.

LGTM.

Apr 26 2022, 11:30 AM · Restricted Project, Restricted Project

Apr 25 2022

DiggerLin accepted D124392: [AIX][XCOFF] error on emit symbol visibility for XCOFF object file .
Apr 25 2022, 8:46 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D123949: [AIX] support write operation of big archive..
Apr 25 2022, 7:37 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D123949: [AIX] support write operation of big archive..

address comment

Apr 25 2022, 7:37 AM · Restricted Project, Restricted Project

Apr 22 2022

DiggerLin added a comment to D123949: [AIX] support write operation of big archive..

Could you link to the spec again for Big Archive, so I can try to check the code against it, please?

https://www.ibm.com/docs/en/aix/7.2?topic=formats-ar-file-format-big
Apr 22 2022, 7:20 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D124017: [AIX] fixed llvm-ar can not read empty big archive correctly..

Are the dependent patches in the right order? I wouldn't expect this patch to depend on the writing patch necessarily.

Apr 22 2022, 7:19 AM · Restricted Project, Restricted Project

Apr 21 2022

DiggerLin updated the diff for D124174: [libc++][CI] added XFAIL LIBCXX-AIX-FIXME to new runnning test cases after install locale on AIX OS..

added " XFAIL LIBCXX-AIX-FIXME " to new runnning test cases after install locale on AIX OS

Apr 21 2022, 9:33 AM · Restricted Project, Restricted Project
DiggerLin retitled D124174: [libc++][CI] added XFAIL LIBCXX-AIX-FIXME to new runnning test cases after install locale on AIX OS. from [libc++][CI] remove XFAIL: LIBCXX-AIX-FIXME for compare.pass.cpp to [libc++][CI] added XFAIL LIBCXX-AIX-FIXME to new runnning test cases after install locale on AIX OS..
Apr 21 2022, 9:31 AM · Restricted Project, Restricted Project
DiggerLin requested review of D124174: [libc++][CI] added XFAIL LIBCXX-AIX-FIXME to new runnning test cases after install locale on AIX OS..
Apr 21 2022, 7:19 AM · Restricted Project, Restricted Project

Apr 20 2022

DiggerLin added inline comments to D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and .
Apr 20 2022, 12:01 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and .

address comment

Apr 20 2022, 11:20 AM · Restricted Project, Restricted Project
DiggerLin updated the summary of D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and .
Apr 20 2022, 10:57 AM · Restricted Project, Restricted Project
DiggerLin updated the summary of D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and .
Apr 20 2022, 10:55 AM · Restricted Project, Restricted Project
DiggerLin retitled D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and from [AIX][clang][driver] Check the command string to the linker for exportlist opts to [AIX][clang][driver] Check the command string to the linker for exportlist opts and .
Apr 20 2022, 10:54 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D123951: [LLVM][AIX] Implement XCOFF exported visibility.

we need to change the following functions to deal with MCSA_Exported

MCWasmStreamer::emitSymbolAttribute(MCSymbol *S, MCSymbolAttr Attribute) too .
MCXCOFFStreamer::emitSymbolAttribute(MCSymbol *Sym, MCSymbolAttr Attribute)

Apr 20 2022, 10:46 AM · Restricted Project, Restricted Project

Apr 19 2022

DiggerLin added a reviewer for D123949: [AIX] support write operation of big archive.: MaskRay.
Apr 19 2022, 10:33 AM · Restricted Project, Restricted Project
DiggerLin requested review of D124017: [AIX] fixed llvm-ar can not read empty big archive correctly..
Apr 19 2022, 10:32 AM · Restricted Project, Restricted Project
Herald added a project to D104367: [AIX] Support of Big archive (write): Restricted Project.

I took over the patch and create a patch https://reviews.llvm.org/D123949. thanks for your work. @EGuesnet .

Apr 19 2022, 6:14 AM · Restricted Project, Restricted Project
DiggerLin added a comment to D123949: [AIX] support write operation of big archive..

Just FYI, I've got a few urgent pieces of work to do, which will mean reviewing may be a bit slow. I'll try to get to this later this week, but no guarantee.

Apr 19 2022, 5:40 AM · Restricted Project, Restricted Project

Apr 18 2022

DiggerLin added inline comments to D123951: [LLVM][AIX] Implement XCOFF exported visibility.
Apr 18 2022, 2:16 PM · Restricted Project, Restricted Project
DiggerLin added a comment to D123951: [LLVM][AIX] Implement XCOFF exported visibility.

we need to change the following functions to deal with MCSA_Exported

  1. MCWasmStreamer::emitSymbolAttribute(MCSymbol *S, MCSymbolAttr Attribute) too .
  2. MCXCOFFStreamer::emitSymbolAttribute(MCSymbol *Sym, MCSymbolAttr Attribute)
Apr 18 2022, 1:57 PM · Restricted Project, Restricted Project
DiggerLin added a reviewer for D123949: [AIX] support write operation of big archive.: stevewan.
Apr 18 2022, 12:47 PM · Restricted Project, Restricted Project
DiggerLin added a reviewer for D123949: [AIX] support write operation of big archive.: EGuesnet.
Apr 18 2022, 11:00 AM · Restricted Project, Restricted Project
DiggerLin updated the summary of D123949: [AIX] support write operation of big archive..
Apr 18 2022, 10:29 AM · Restricted Project, Restricted Project
DiggerLin updated the summary of D123949: [AIX] support write operation of big archive..
Apr 18 2022, 10:28 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D123949: [AIX] support write operation of big archive..
  1. refactor the first commit
  2. implement write symbol table for the big archive.
  3. fixed bugs and added more test cases
Apr 18 2022, 10:23 AM · Restricted Project, Restricted Project
DiggerLin requested review of D123949: [AIX] support write operation of big archive..
Apr 18 2022, 10:21 AM · Restricted Project, Restricted Project

Apr 4 2022

DiggerLin accepted D123063: Specify --format for tests to workaround AIX big archive write operation.

LGTM

Apr 4 2022, 5:59 PM · Restricted Project, Restricted Project

Mar 31 2022

DiggerLin added inline comments to D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..
Mar 31 2022, 10:54 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..
Mar 31 2022, 8:46 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D122746: [AIX][XCOFF] print unsupported message for llvm-ar big archive write operation .

address James comment

Mar 31 2022, 7:29 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D122746: [AIX][XCOFF] print unsupported message for llvm-ar big archive write operation .
Mar 31 2022, 7:28 AM · Restricted Project, Restricted Project

Mar 30 2022

DiggerLin updated the summary of D122746: [AIX][XCOFF] print unsupported message for llvm-ar big archive write operation .
Mar 30 2022, 11:29 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D122746: [AIX][XCOFF] print unsupported message for llvm-ar big archive write operation .
Mar 30 2022, 11:21 AM · Restricted Project, Restricted Project
DiggerLin added a reviewer for D122746: [AIX][XCOFF] print unsupported message for llvm-ar big archive write operation : MaskRay.
Mar 30 2022, 10:21 AM · Restricted Project, Restricted Project
DiggerLin requested review of D122746: [AIX][XCOFF] print unsupported message for llvm-ar big archive write operation .
Mar 30 2022, 10:07 AM · Restricted Project, Restricted Project

Mar 29 2022

DiggerLin added inline comments to D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..
Mar 29 2022, 9:27 AM · Restricted Project, Restricted Project

Mar 18 2022

DiggerLin accepted D120861: [XCOFF][1/3] support fileHeader and sectionHeaders in 64-bit XCOFF..

LGTM.
I do not have further comment, but please wait for James approve.

Mar 18 2022, 8:44 AM · Restricted Project, Restricted Project

Mar 17 2022

DiggerLin added inline comments to D120861: [XCOFF][1/3] support fileHeader and sectionHeaders in 64-bit XCOFF..
Mar 17 2022, 6:30 AM · Restricted Project, Restricted Project