User Details
- User Since
- Feb 28 2019, 10:08 AM (249 w, 3 d)
Oct 30 2023
Oct 16 2023
since the commit did the same change , I closed the patch
Oct 5 2023
Sep 29 2023
Sep 26 2023
Sep 25 2023
rebase the code and address James' comment.
Sep 22 2023
address comment
Sep 21 2023
rebase the code
address comment
Sep 20 2023
Sep 7 2023
gentle ping, @jhenderson
Sep 6 2023
Sep 5 2023
address comment
Sep 1 2023
delete an empty line
address comment
Aug 31 2023
added more test scenario and address comment.
Aug 30 2023
LGTM.
Aug 29 2023
address comment
LGTM
Aug 28 2023
@jhenderson , I would greatly appreciate your thoughts on the possibility of using the implement proposed in https://reviews.llvm.org/D158004?id=552000 for the patch.
Aug 25 2023
add new test scenario
what is preventing the change to clang to not call llvm-nm with import files?
Aug 24 2023
rebase the patch.
implement a new class AIXLinkerImportFile
Aug 21 2023
@jhenderson ,May I kindly ask if you have any further comments? If not, would it be acceptable for me to move forward with committing the patch? Your valuable input would be sincerely appreciated.
@MaskRay, would you have any additional comments to share? If not, would it be appropriate for me to proceed with committing the patch? Your input would be greatly appreciated.
address minor comment.
Aug 18 2023
address comment
yes, your understand is correct. but I need to clarify following.
Aug 17 2023
Aug 16 2023
Aug 15 2023
added new test scenarios .
Aug 14 2023
rebase the patch
Aug 3 2023
Aug 2 2023
Aug 1 2023
address comment
I'd still rather the invalid OBJECT_MODE value be read and rejected upfront before even parsing the -X option.
Jul 31 2023
address comment
Jul 29 2023
rebase code
Jul 28 2023
Jul 27 2023
addressed comment and let llvm-ranlib supports -Xany option
I do see the appeal of a single enum parameter in the meantime. I would suggest it should be called SymtabWritingMode and have values NoSymtab, NormalSymtab, BigArchive64Bit, BigArchive32Bit, and BigArchiveBoth. You could optionally drop one of the BigArchive* values, and treat NormalSymtab as that value for BigArchive (as long as "Normal" is clear as to its meaning to someone familiar with BigArchive). All existing WriteSymtab false values would be replaced with NoSymtab and true with NormalSymtab (except for BigArchive cases).
As an alternative (but I think adds unnecessary complexity, due to needing an extra variable), you could have both tools read the environment variable into a string variable, then, if the -X option is present, overwrite that variable, and finally feed that string into the parsing code that converts into a BitMode value. If the string is invalid, the parsing code could report an error along the lines of "invalid OBJECT_MODE or -X option value".
if I do not think it is better than my current implement, If I implement as your suggestion, I need another variable to recoded the where the string come from(from OBJECT_MODE or -X option value). otherwise when the invalid value of string , how can I report it is an invalid OBJECT_MODE" or "invalid -X option value"
Jul 25 2023
addressed partial comments, after deciding whether to delete the bool NeedSymbols parameter from functions API,(writeArchiveToStream etc), I will upload a update patch.
Jul 21 2023
Jul 20 2023
- rebase the code
- for the env OBJECT_MODE= or is env OBJECT_MODE="" , the ranlib and ar in AIX OS , have different behaviors(ranlib looks as -X32 , but ar and nm output error ),
I change llvm-ranlib as the same behavior as ar and llvm-ar, output an error(I think output error is more reasonable). and look env OBJECT_MODE unset as default 32-BIT for llvm-ranlib as AIX OS command ranlib , nm ,ar.
Jul 19 2023
address comment