Size queries for MVTs, split out from D53137.
Contains a fix for FindMemType to avoid using scalable vector types to contain non-scalable types.
Differential D66871
[SVE] MVT scalable size queries huntergr on Aug 28 2019, 4:15 AM. Authored by
Details Size queries for MVTs, split out from D53137. Contains a fix for FindMemType to avoid using scalable vector types to contain non-scalable types.
Diff Detail
Event TimelineComment Actions LGTM
Comment Actions
Comment Actions
Comment Actions I also changed the SelectionDAGBuilder code for masked loads/stores/gathers/scatters to use the known min size when creating a MachineMemoryOperand, since MMO isn't aware of scalable types yet. I've left TODOs as reminders.
Comment Actions Regarding the change to return const, I'm not convinced that's a good idea (we actually have a clang-tidy check that warns about that). I think it would be better to either name those temporaries or use std::make_tuple instead of std::tie (whichever you prefer).
Comment Actions
Comment Actions I don't see anything else wrong with this. LGTM if you rename the LE predicate.
|