Page MenuHomePhabricator

cameron.mcinally (Cameron McInally)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 6 2015, 6:21 AM (233 w, 7 h)

Recent Activity

Yesterday

cameron.mcinally committed rG1e5116cbb3a0: [NFC][Reassociate] Add unary FNeg tests to fast-ReassociateVector.ll (authored by cameron.mcinally).
[NFC][Reassociate] Add unary FNeg tests to fast-ReassociateVector.ll
Mon, Jun 24, 2:38 PM
cameron.mcinally committed rGfe3f15cf9001: [SLP] Support unary FNeg vectorization (authored by cameron.mcinally).
[SLP] Support unary FNeg vectorization
Mon, Jun 24, 12:25 PM
cameron.mcinally added a comment to D63609: [SLP] Support unary FNeg vectorization.

Answering myself - doesn't look like anything has changed since:
D62444 / rL361788

Mon, Jun 24, 11:25 AM · Restricted Project

Fri, Jun 21

cameron.mcinally added inline comments to D62158: [InstCombine] canonicalize minnum/maxnum with 'nnan' to fcmp+select.
Fri, Jun 21, 11:09 AM · Restricted Project

Thu, Jun 20

cameron.mcinally committed rG1c0bd6dd2ca7: [Reassociate] Remove bogus assert reported in PR42349. (authored by cameron.mcinally).
[Reassociate] Remove bogus assert reported in PR42349.
Thu, Jun 20, 4:04 PM
cameron.mcinally updated the diff for D63609: [SLP] Support unary FNeg vectorization.

Add two more tests (X86/propagate_ir_flags.ll).

Thu, Jun 20, 2:02 PM · Restricted Project
cameron.mcinally committed rG9589db7a98ea: [NFC][SLP] Pre-commit unary FNeg test to X86/propagate_ir_flags.ll (authored by cameron.mcinally).
[NFC][SLP] Pre-commit unary FNeg test to X86/propagate_ir_flags.ll
Thu, Jun 20, 1:56 PM
cameron.mcinally created D63609: [SLP] Support unary FNeg vectorization.
Thu, Jun 20, 9:34 AM · Restricted Project
cameron.mcinally committed rG4452c3b490e9: [NFC][SLP] Pre-commit unary FNeg test to X86/phi3.ll (authored by cameron.mcinally).
[NFC][SLP] Pre-commit unary FNeg test to X86/phi3.ll
Thu, Jun 20, 8:16 AM

Wed, Jun 19

cameron.mcinally committed rG11e7357a052d: [NFC][IR] Move CreateFNegFMF(...) next to CreateFNeg(...). (authored by cameron.mcinally).
[NFC][IR] Move CreateFNegFMF(...) next to CreateFNeg(...).
Wed, Jun 19, 9:33 AM
cameron.mcinally committed rG7aa898e61e19: [DFSan] Add UnaryOperator visitor to DataFlowSanitizer (authored by cameron.mcinally).
[DFSan] Add UnaryOperator visitor to DataFlowSanitizer
Wed, Jun 19, 8:09 AM
cameron.mcinally committed rGa027cf47640c: [Reassociate] Handle unary FNeg in the Reassociate pass (authored by cameron.mcinally).
[Reassociate] Handle unary FNeg in the Reassociate pass
Wed, Jun 19, 7:57 AM

Tue, Jun 18

cameron.mcinally accepted D63294: [Analysis] enhance FP library function prototype checking to match types with name suffix .

LGTM, assuming the test writer was not intentionally playing games with the fabs(...) calls.

Tue, Jun 18, 9:09 AM · Restricted Project
cameron.mcinally added a comment to D62815: Add UnaryOperator visitor to DataFlowSanitizer.

Ping*2.

Tue, Jun 18, 8:10 AM · Restricted Project
cameron.mcinally updated the diff for D63445: [Reassociate] Handle unary FNeg in the Reassociate pass.

Remove unintentional changes. Also fix up a poor naming choice.

Tue, Jun 18, 7:39 AM · Restricted Project
cameron.mcinally added inline comments to D63445: [Reassociate] Handle unary FNeg in the Reassociate pass.
Tue, Jun 18, 7:19 AM · Restricted Project

Mon, Jun 17

cameron.mcinally updated the diff for D63445: [Reassociate] Handle unary FNeg in the Reassociate pass.

Correct comment. Should be 'nnan', not 'nnan and nsz'.

Mon, Jun 17, 12:45 PM · Restricted Project
cameron.mcinally added a comment to D63405: GlobalISel: Don't lose fneg flags when lowering to fsub.

But there's a separate question that is raised here: why is it legal to convert fneg to fsub -0.0? That loosens the IEEE requirement when dealing with a NAN. I'd think this should be legalized by converting to integer and flipping the sign bit (xor).
ping @cameron.mcinally

Mon, Jun 17, 12:45 PM
cameron.mcinally created D63445: [Reassociate] Handle unary FNeg in the Reassociate pass.
Mon, Jun 17, 10:33 AM · Restricted Project

Thu, Jun 13

cameron.mcinally committed rG79ec1a29572e: Revert "[NFC][CodeGen] Add unary fneg tests to fp-fast.ll fp-fold.ll fp-in… (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to fp-fast.ll fp-fold.ll fp-in…
Thu, Jun 13, 12:26 PM
cameron.mcinally added a reverting change for rG1d85a7518c6b: [NFC][CodeGen] Add unary fneg tests to fp-fast.ll fp-fold.ll fp-in-intregs.ll…: rG79ec1a29572e: Revert "[NFC][CodeGen] Add unary fneg tests to fp-fast.ll fp-fold.ll fp-in….
Thu, Jun 13, 12:26 PM
cameron.mcinally committed rG07514a1b1625: Revert "[NFC][CodeGen] Add unary fneg tests to fmul-combines.ll fnabs.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to fmul-combines.ll fnabs.ll"
Thu, Jun 13, 12:26 PM
cameron.mcinally added a reverting change for rG5c0114058126: [NFC][CodeGen] Add unary fneg tests to fmul-combines.ll fnabs.ll: rG07514a1b1625: Revert "[NFC][CodeGen] Add unary fneg tests to fmul-combines.ll fnabs.ll".
Thu, Jun 13, 12:26 PM
cameron.mcinally committed rG8984dbc27c37: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma_patterns_wide.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma_patterns_wide.ll"
Thu, Jun 13, 12:26 PM
cameron.mcinally committed rG5d9271802ba6: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma_patterns.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma_patterns.ll"
Thu, Jun 13, 12:25 PM
cameron.mcinally added a reverting change for rG06de52674da7: [NFC][CodeGen] Add unary fneg tests to X86/fma_patterns.ll: rG5d9271802ba6: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma_patterns.ll".
Thu, Jun 13, 12:25 PM
cameron.mcinally added a reverting change for rGf1b8c6ac4f9d: [NFC][CodeGen] Add unary fneg tests to X86/fma_patterns_wide.ll: rG8984dbc27c37: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma_patterns_wide.ll".
Thu, Jun 13, 12:25 PM
cameron.mcinally committed rGd331e71bdb67: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma4-fneg-combine.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma4-fneg-combine.ll"
Thu, Jun 13, 12:25 PM
cameron.mcinally added a reverting change for rGf288a0685f87: [NFC][CodeGen] Add unary fneg tests to X86/fma4-fneg-combine.ll: rGd331e71bdb67: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma4-fneg-combine.ll".
Thu, Jun 13, 12:25 PM
cameron.mcinally added a reverting change for rG3d2ee0053aa2: [NFC][CodeGen] Add unary fneg tests to X86/fma-scalar-combine.ll: rG31da4f80d5bb: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-scalar-combine.ll".
Thu, Jun 13, 12:25 PM
cameron.mcinally committed rG31da4f80d5bb: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-scalar-combine.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-scalar-combine.ll"
Thu, Jun 13, 12:25 PM
cameron.mcinally committed rG2aff82bfa675: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma4-intrinsics-x86.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma4-intrinsics-x86.ll"
Thu, Jun 13, 12:25 PM
cameron.mcinally committed rGd3eaa332e4a4: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-intrinsics-x86.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-intrinsics-x86.ll"
Thu, Jun 13, 12:25 PM
cameron.mcinally added a reverting change for rG169fc2b0209d: [NFC][CodeGen] Add unary fneg tests to X86/fma-intrinsics-x86.ll: rGd3eaa332e4a4: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-intrinsics-x86.ll".
Thu, Jun 13, 12:25 PM
cameron.mcinally added a reverting change for rG66f286845cad: [NFC][CodeGen] Add unary fneg tests to X86/fma4-intrinsics-x86.ll: rG2aff82bfa675: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma4-intrinsics-x86.ll".
Thu, Jun 13, 12:25 PM
cameron.mcinally committed rG0a3fe05047e6: Revert "[NFC][CodeGen] Add unary FNeg tests to some X86/ and XCore/ tests." (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary FNeg tests to some X86/ and XCore/ tests."
Thu, Jun 13, 12:25 PM
cameron.mcinally added a reverting change for rG4f3cf3853e11: [NFC][CodeGen] Add unary FNeg tests to some X86/ and XCore/ tests.: rG0a3fe05047e6: Revert "[NFC][CodeGen] Add unary FNeg tests to some X86/ and XCore/ tests.".
Thu, Jun 13, 12:25 PM
cameron.mcinally committed rGa0d06a626ffa: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/fma-intrinsics-canonical.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary FNeg tests to X86/fma-intrinsics-canonical.ll"
Thu, Jun 13, 12:25 PM
cameron.mcinally added a reverting change for rGee5881a88cbe: [NFC][CodeGen] Add unary FNeg tests to X86/fma-intrinsics-canonical.ll: rGa0d06a626ffa: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/fma-intrinsics-canonical.ll".
Thu, Jun 13, 12:25 PM
cameron.mcinally committed rGa37d925d3d89: Revert "[NFC][CodeGen] Forgot 2 unary FNeg tests in X86/fma-intrinsics… (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Forgot 2 unary FNeg tests in X86/fma-intrinsics…
Thu, Jun 13, 12:25 PM
cameron.mcinally added a reverting change for rG5f39a3096f8e: [NFC][CodeGen] Forgot 2 unary FNeg tests in X86/fma-intrinsics-canonical.ll: rGa37d925d3d89: Revert "[NFC][CodeGen] Forgot 2 unary FNeg tests in X86/fma-intrinsics….
Thu, Jun 13, 12:25 PM
cameron.mcinally committed rGe00198f7a875: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-fneg-combine.ll" (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-fneg-combine.ll"
Thu, Jun 13, 12:24 PM
cameron.mcinally added a reverting change for rG10c085554215: [NFC][CodeGen] Add unary fneg tests to X86/fma-fneg-combine.ll: rGe00198f7a875: Revert "[NFC][CodeGen] Add unary fneg tests to X86/fma-fneg-combine.ll".
Thu, Jun 13, 12:24 PM
cameron.mcinally committed rGea28a063fd8e: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/combine-fcopysign.ll X86/dag… (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary FNeg tests to X86/combine-fcopysign.ll X86/dag…
Thu, Jun 13, 12:24 PM
cameron.mcinally added a reverting change for rGe04c4b6af81d: [NFC][CodeGen] Add unary FNeg tests to X86/combine-fcopysign.ll X86/dag-fmf-cse.: rGea28a063fd8e: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/combine-fcopysign.ll X86/dag….
Thu, Jun 13, 12:24 PM
cameron.mcinally committed rG489045719614: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast… (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast…
Thu, Jun 13, 12:24 PM
cameron.mcinally added a reverting change for rG6fe46ec25d84: [NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll…: rG489045719614: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast….
Thu, Jun 13, 12:24 PM
cameron.mcinally committed rG21a29a9e653a: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast… (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast…
Thu, Jun 13, 12:24 PM
cameron.mcinally added a reverting change for rG2aa5ada267d2: [NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll: rG21a29a9e653a: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast….
Thu, Jun 13, 12:24 PM
cameron.mcinally committed rG7d4e7efd2e16: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast… (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast…
Thu, Jun 13, 12:24 PM
cameron.mcinally added a reverting change for rG27a5db9de57d: [NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll: rG7d4e7efd2e16: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast….
Thu, Jun 13, 12:24 PM
cameron.mcinally committed rG8608afa964d2: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel. (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel.
Thu, Jun 13, 12:24 PM
cameron.mcinally added a reverting change for rG41e0b9f28030: [NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel.ll: rG8608afa964d2: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel..
Thu, Jun 13, 12:24 PM
cameron.mcinally committed rG675be5db469f: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel. (authored by cameron.mcinally).
Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel.
Thu, Jun 13, 12:24 PM
cameron.mcinally added a reverting change for rGaeb89f8b33d8: [NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel.ll: rG675be5db469f: Revert "[NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel..
Thu, Jun 13, 12:24 PM
cameron.mcinally committed rGaeb89f8b33d8: [NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel.ll
Thu, Jun 13, 8:53 AM

Wed, Jun 12

cameron.mcinally committed rG41e0b9f28030: [NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary FNeg tests to X86/avx512-intrinsics-fast-isel.ll
Wed, Jun 12, 3:49 PM
cameron.mcinally committed rG27a5db9de57d: [NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll
Wed, Jun 12, 1:55 PM
cameron.mcinally committed rG2aa5ada267d2: [NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll
Wed, Jun 12, 12:37 PM
cameron.mcinally accepted D63214: [InstCombine] canonicalize fmin/fmax to LLVM intrinsics minnum/maxnum.

LGTM

Wed, Jun 12, 11:37 AM · Restricted Project

Tue, Jun 11

cameron.mcinally committed rG6fe46ec25d84: [NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll… (authored by cameron.mcinally).
[NFC][CodeGen] Add unary FNeg tests to X86/avx512vl-intrinsics-fast-isel.ll…
Tue, Jun 11, 5:16 PM
cameron.mcinally committed rGe04c4b6af81d: [NFC][CodeGen] Add unary FNeg tests to X86/combine-fcopysign.ll X86/dag-fmf-cse. (authored by cameron.mcinally).
[NFC][CodeGen] Add unary FNeg tests to X86/combine-fcopysign.ll X86/dag-fmf-cse.
Tue, Jun 11, 11:55 AM
cameron.mcinally committed rG10c085554215: [NFC][CodeGen] Add unary fneg tests to X86/fma-fneg-combine.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary fneg tests to X86/fma-fneg-combine.ll
Tue, Jun 11, 10:03 AM
cameron.mcinally committed rG08200d6d26e9: [InstCombine] Handle -(X-Y) --> (Y-X) for unary fneg when NSZ (authored by cameron.mcinally).
[InstCombine] Handle -(X-Y) --> (Y-X) for unary fneg when NSZ
Tue, Jun 11, 9:21 AM
cameron.mcinally accepted D62414: [InstCombine] canonicalize fcmp+select to minnum/maxnum intrinsics.

LGTM

Tue, Jun 11, 9:17 AM · Restricted Project
cameron.mcinally committed rG796de11331e6: [InstCombine] Update fptrunc (fneg x)) -> (fneg (fptrunc x) for unary FNeg (authored by cameron.mcinally).
[InstCombine] Update fptrunc (fneg x)) -> (fneg (fptrunc x) for unary FNeg
Tue, Jun 11, 8:46 AM
cameron.mcinally added inline comments to D62414: [InstCombine] canonicalize fcmp+select to minnum/maxnum intrinsics.
Tue, Jun 11, 8:41 AM · Restricted Project
cameron.mcinally added inline comments to D62414: [InstCombine] canonicalize fcmp+select to minnum/maxnum intrinsics.
Tue, Jun 11, 7:43 AM · Restricted Project
cameron.mcinally added inline comments to D62414: [InstCombine] canonicalize fcmp+select to minnum/maxnum intrinsics.
Tue, Jun 11, 7:37 AM · Restricted Project

Mon, Jun 10

cameron.mcinally committed rG5f39a3096f8e: [NFC][CodeGen] Forgot 2 unary FNeg tests in X86/fma-intrinsics-canonical.ll (authored by cameron.mcinally).
[NFC][CodeGen] Forgot 2 unary FNeg tests in X86/fma-intrinsics-canonical.ll
Mon, Jun 10, 4:02 PM
cameron.mcinally committed rGee5881a88cbe: [NFC][CodeGen] Add unary FNeg tests to X86/fma-intrinsics-canonical.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary FNeg tests to X86/fma-intrinsics-canonical.ll
Mon, Jun 10, 3:44 PM
cameron.mcinally committed rG4f3cf3853e11: [NFC][CodeGen] Add unary FNeg tests to some X86/ and XCore/ tests. (authored by cameron.mcinally).
[NFC][CodeGen] Add unary FNeg tests to some X86/ and XCore/ tests.
Mon, Jun 10, 2:31 PM
cameron.mcinally added a comment to D62612: [InstCombine] Handle -(X-Y) --> (Y-X) for unary fneg when NSZ.

Ping.

Mon, Jun 10, 11:43 AM · Restricted Project
cameron.mcinally added inline comments to D62629: [InstCombine] Update fptrunc (fneg x)) -> (fneg (fptrunc x) for unary FNeg.
Mon, Jun 10, 10:06 AM · Restricted Project
cameron.mcinally updated the diff for D62629: [InstCombine] Update fptrunc (fneg x)) -> (fneg (fptrunc x) for unary FNeg.

Add context to Diff.

Mon, Jun 10, 10:04 AM · Restricted Project
cameron.mcinally added a comment to D62629: [InstCombine] Update fptrunc (fneg x)) -> (fneg (fptrunc x) for unary FNeg.

Check hasOneUse() before performing combine.

That's an independent fix and needs a test?

Mon, Jun 10, 10:03 AM · Restricted Project
cameron.mcinally added a comment to D62815: Add UnaryOperator visitor to DataFlowSanitizer.

Ping.

Mon, Jun 10, 9:30 AM · Restricted Project
cameron.mcinally added a comment to D62629: [InstCombine] Update fptrunc (fneg x)) -> (fneg (fptrunc x) for unary FNeg.

Also note that this change will require UnaryOperator::CreateFNegFMF(...) from D62521, so cannot be committed until that is complete.

Mon, Jun 10, 9:28 AM · Restricted Project
cameron.mcinally updated the diff for D62629: [InstCombine] Update fptrunc (fneg x)) -> (fneg (fptrunc x) for unary FNeg.

Check hasOneUse() before performing combine.

Mon, Jun 10, 9:28 AM · Restricted Project
cameron.mcinally committed rG670d0f478ba1: [ExecutionEngine] Fix rL362941: Add UnaryOperator visitor to the interpreter (authored by cameron.mcinally).
[ExecutionEngine] Fix rL362941: Add UnaryOperator visitor to the interpreter
Mon, Jun 10, 9:03 AM
cameron.mcinally committed rG8cd25d462d3a: [IRBuilder] Add CreateFNegFMF(...) to the IRBuilder (authored by cameron.mcinally).
[IRBuilder] Add CreateFNegFMF(...) to the IRBuilder
Mon, Jun 10, 8:05 AM
cameron.mcinally committed rGce49e2231bb6: [ExecutionEngine] Add UnaryOperator visitor to the interpreter (authored by cameron.mcinally).
[ExecutionEngine] Add UnaryOperator visitor to the interpreter
Mon, Jun 10, 7:36 AM

Fri, Jun 7

cameron.mcinally updated the diff for D62881: [ExecutionEngine] Add UnaryOperator visitor to the interpreter.

Update llvm_unreachable strings...

Fri, Jun 7, 1:45 PM · Restricted Project
cameron.mcinally accepted D62979: [InstSimplify] enhance/fix fcmp fold with never-nan operand.

Good compromise. LGTM.

Fri, Jun 7, 12:30 PM · Restricted Project
cameron.mcinally accepted D62963: [DAGCombine] GetNegatedExpression - constant float vector support (PR42105).

LGTM, although I'm not fluent in AMDGPU assembly. You may want to wait a little while to see if an expert comes along.

Fri, Jun 7, 12:22 PM · Restricted Project
cameron.mcinally committed rGef57e50bd2b8: [IR] Add UnaryOperator::CreateFNegFMF(...) (authored by cameron.mcinally).
[IR] Add UnaryOperator::CreateFNegFMF(...)
Fri, Jun 7, 11:58 AM
cameron.mcinally added inline comments to D62705: [IR] Add UnaryOperator::CreateFNegFMF(...).
Fri, Jun 7, 10:52 AM · Restricted Project
cameron.mcinally added a comment to D62705: [IR] Add UnaryOperator::CreateFNegFMF(...).

Ping...

Fri, Jun 7, 9:26 AM · Restricted Project
cameron.mcinally added a comment to D62521: [IRBuilder] Add CreateFNegFMF(...) to the IRBuilder.

Ping...

Fri, Jun 7, 9:26 AM · Restricted Project
cameron.mcinally added a comment to D62979: [InstSimplify] enhance/fix fcmp fold with never-nan operand.

This LGTM, with one clarification inline...

Fri, Jun 7, 8:47 AM · Restricted Project
cameron.mcinally added a comment to D62963: [DAGCombine] GetNegatedExpression - constant float vector support (PR42105).

I haven't enabled handling of undefs in build vector - but can anyone think of a reason that I shouldn't?

Fri, Jun 7, 8:33 AM · Restricted Project

Thu, Jun 6

cameron.mcinally committed rG66f286845cad: [NFC][CodeGen] Add unary fneg tests to X86/fma4-intrinsics-x86.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary fneg tests to X86/fma4-intrinsics-x86.ll
Thu, Jun 6, 2:48 PM
cameron.mcinally committed rG169fc2b0209d: [NFC][CodeGen] Add unary fneg tests to X86/fma-intrinsics-x86.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary fneg tests to X86/fma-intrinsics-x86.ll
Thu, Jun 6, 2:10 PM
cameron.mcinally committed rG3d2ee0053aa2: [NFC][CodeGen] Add unary fneg tests to X86/fma-scalar-combine.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary fneg tests to X86/fma-scalar-combine.ll
Thu, Jun 6, 1:10 PM
cameron.mcinally committed rGf288a0685f87: [NFC][CodeGen] Add unary fneg tests to X86/fma4-fneg-combine.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary fneg tests to X86/fma4-fneg-combine.ll
Thu, Jun 6, 12:00 PM
cameron.mcinally committed rG06de52674da7: [NFC][CodeGen] Add unary fneg tests to X86/fma_patterns.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary fneg tests to X86/fma_patterns.ll
Thu, Jun 6, 11:40 AM
cameron.mcinally committed rGf1b8c6ac4f9d: [NFC][CodeGen] Add unary fneg tests to X86/fma_patterns_wide.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary fneg tests to X86/fma_patterns_wide.ll
Thu, Jun 6, 9:54 AM
cameron.mcinally committed rG5c0114058126: [NFC][CodeGen] Add unary fneg tests to fmul-combines.ll fnabs.ll (authored by cameron.mcinally).
[NFC][CodeGen] Add unary fneg tests to fmul-combines.ll fnabs.ll
Thu, Jun 6, 9:11 AM
cameron.mcinally committed rG1d85a7518c6b: [NFC][CodeGen] Add unary fneg tests to fp-fast.ll fp-fold.ll fp-in-intregs.ll… (authored by cameron.mcinally).
[NFC][CodeGen] Add unary fneg tests to fp-fast.ll fp-fold.ll fp-in-intregs.ll…
Thu, Jun 6, 8:28 AM
cameron.mcinally committed rG0924f4485921: [NFC][CodeGen] Remove duplicate test in fp-fast.ll (authored by cameron.mcinally).
[NFC][CodeGen] Remove duplicate test in fp-fast.ll
Thu, Jun 6, 7:51 AM