User Details
User Details
- User Since
- May 18 2016, 6:13 AM (358 w, 3 d)
Tue, Mar 28
Tue, Mar 28
LGTM, cheers
LGTM
c-rhodes added inline comments to D146917: [mlir][mlir-cpu-runner] Add support for `-mattr` and `-march` flags.
Feb 27 2023
Feb 27 2023
Feb 23 2023
Feb 23 2023
One minor nit but otherwise LGTM
Feb 14 2023
Feb 14 2023
Jan 25 2023
Jan 25 2023
c-rhodes accepted D142516: [SVE] Move isel for casting between NEON and SVE vector types into tablegen..
Couple of minor nits but otherwise LGTM
Nov 18 2022
Nov 18 2022
c-rhodes accepted D137547: [AArch64][SVE] Use PTRUE instruction for get_active_lane_mask intrinsic if the range is appropriate for predicator constant.
LGTM
c-rhodes committed rG34d88cf6cfe9: [DAG] Allow folding AND of anyext masked_load with >1 user to zext version (authored by benmxwl-arm).
[DAG] Allow folding AND of anyext masked_load with >1 user to zext version
Nov 17 2022
Nov 17 2022
c-rhodes accepted D137844: [DAG] Allow folding AND of anyext masked_load with >1 user to zext version.
c-rhodes added inline comments to D128631: [AArch64] Initial sched model for Neoverse N2.
Nov 16 2022
Nov 16 2022
c-rhodes added a comment to D137844: [DAG] Allow folding AND of anyext masked_load with >1 user to zext version.
c-rhodes accepted D138116: [AArch64][SVE] Ensure redundant PTEST are removed with an 'invalid' PTRUE.
LGTM
c-rhodes committed rGa95a8188e897: [AArch64] Lower fixed-length vector_shuffle to SVE splat if possible (authored by benmxwl-arm).
[AArch64] Lower fixed-length vector_shuffle to SVE splat if possible
c-rhodes committed rG181492189397: [AArch64][CodeGen] Remove redundant vector negations before concat (authored by benmxwl-arm).
[AArch64][CodeGen] Remove redundant vector negations before concat
Nov 15 2022
Nov 15 2022
I've just left one suggestion but otherwise LGTM
c-rhodes committed rG8699efba6dc8: [AArch64][SVE] Fix bad PTEST(PTRUE_ALL, PTEST_LIKE) optimization (authored by c-rhodes).
[AArch64][SVE] Fix bad PTEST(PTRUE_ALL, PTEST_LIKE) optimization
c-rhodes committed rGa290668ec547: [AArch64][SVE] Fix bad PTEST(X, X) optimization (authored by c-rhodes).
[AArch64][SVE] Fix bad PTEST(X, X) optimization
c-rhodes committed rGce3e7eb96888: [AArch64][SVE] Fix bad PTEST(PG, OP(PG, ...)) optimization (authored by c-rhodes).
[AArch64][SVE] Fix bad PTEST(PG, OP(PG, ...)) optimization
c-rhodes committed rG3ddd5a848f0d: [AArch64][SVE] Add more ptest removal tests (authored by c-rhodes).
[AArch64][SVE] Add more ptest removal tests
Nov 14 2022
Nov 14 2022
just one suggestion but otherwise LGTM, cheers
Couple of minor spelling nits but otherwise LGTM, cheers
c-rhodes added inline comments to D128631: [AArch64] Initial sched model for Neoverse N2.
Nov 11 2022
Nov 11 2022
c-rhodes added inline comments to D128631: [AArch64] Initial sched model for Neoverse N2.
Nov 9 2022
Nov 9 2022
c-rhodes requested review of D137718: [AArch64][SVE] Fix bad PTEST(PTRUE_ALL, PTEST_LIKE) optimization.
c-rhodes requested review of D137717: [AArch64][SVE] Fix bad PTEST(X, X) optimization.
c-rhodes requested review of D137716: [AArch64][SVE] Fix bad PTEST(PG, OP(PG, ...)) optimization.
c-rhodes requested review of D137715: [AArch64][SVE] Add more ptest removal tests.
Nov 7 2022
Nov 7 2022
Nov 4 2022
Nov 4 2022
c-rhodes added inline comments to rG73d2a4cfd82a: [AArch64] SME2 -Fix failing buildbots because of warning.
c-rhodes committed rG901e5a7539e6: Precommit test for redundant mvn instructions (authored by benmxwl-arm).
Precommit test for redundant mvn instructions
c-rhodes committed rG50621169ae1e: [AArch64][SVE] Extend PTEST_ANY(X=OP(PG,...), X) -> PTEST_ANY(PG, X))… (authored by c-rhodes).
[AArch64][SVE] Extend PTEST_ANY(X=OP(PG,...), X) -> PTEST_ANY(PG, X))…
Nov 3 2022
Nov 3 2022
c-rhodes added inline comments to D137321: [AArch64][SVE2] Add the SVE2.1 BF16 instructions.
c-rhodes added inline comments to D136088: [AArch64]SME2 instructions that use ZTO operand.
c-rhodes added inline comments to D136088: [AArch64]SME2 instructions that use ZTO operand.
c-rhodes added inline comments to D137245: [AArch64][SVE2] Add the SVE2.1 quadword variants of ld1w/ld1d/st1w/st1d.
Oct 25 2022
Oct 25 2022
c-rhodes committed rG1e02a29e4753: [AArch64][SVE] Use more flag-setting instructions (authored by c-rhodes).
[AArch64][SVE] Use more flag-setting instructions
c-rhodes committed rG5621caeb8248: [AArch64][SVE] NFC: extend tests for flag-setting predicate instructions (authored by c-rhodes).
[AArch64][SVE] NFC: extend tests for flag-setting predicate instructions
Oct 21 2022
Oct 21 2022
c-rhodes added inline comments to D136439: [AArch64][SVE2] Add the SVE2.1 bfmlslb and bfmlslt instructions.
c-rhodes added a comment to D88663: [AArch64] Use TargetRegisterClass::hasSubClassEq in tryToFindRegisterToRename.
Just one nit but otherwise LGTM
c-rhodes added inline comments to D136427: [AArch64][SVE2] Add the SVE2.1 fdot instructions.
Oct 18 2022
Oct 18 2022
LGTM
Oct 17 2022
Oct 17 2022
c-rhodes requested review of D136083: [AArch64][SVE] Use more flag-setting instructions.
Oct 12 2022
Oct 12 2022
c-rhodes committed rG5b5756e6e314: [AArch64][SVE] NFC: auto-generate llvm/test/Transforms/InstCombine/AArch64/sve… (authored by c-rhodes).
[AArch64][SVE] NFC: auto-generate llvm/test/Transforms/InstCombine/AArch64/sve…
c-rhodes committed rG388cacb34191: [AArch64][SVE] Add instcombine for PTEST_ANY(X=OP(PG,...), X) -> PTEST_ANY(PG… (authored by c-rhodes).
[AArch64][SVE] Add instcombine for PTEST_ANY(X=OP(PG,...), X) -> PTEST_ANY(PG…
c-rhodes committed rGa17fcb223036: [AArch64][SVE] Fix BRKNS bug in optimizePTestInstr (authored by c-rhodes).
[AArch64][SVE] Fix BRKNS bug in optimizePTestInstr
c-rhodes committed rG495d9e1f3fe6: [AArch64] NFC: Auto-generate llvm/test/CodeGen/AArch64/sve-ptest-removal-brk.ll (authored by c-rhodes).
[AArch64] NFC: Auto-generate llvm/test/CodeGen/AArch64/sve-ptest-removal-brk.ll
Oct 11 2022
Oct 11 2022
c-rhodes added inline comments to D135655: [AArch64][SVE] Fix BRKNS bug in optimizePTestInstr.
c-rhodes updated the diff for D135655: [AArch64][SVE] Fix BRKNS bug in optimizePTestInstr.
Replace checks for is ptrue opcode + assert with single check for PTRUE_B opcode.
c-rhodes added inline comments to D134946: [AArch64][SVE] Add instcombine for PTEST_ANY(X=OP(PG,...), X) -> PTEST_ANY(PG, X)).
c-rhodes requested review of D135655: [AArch64][SVE] Fix BRKNS bug in optimizePTestInstr.
c-rhodes added inline comments to D134946: [AArch64][SVE] Add instcombine for PTEST_ANY(X=OP(PG,...), X) -> PTEST_ANY(PG, X)).
c-rhodes updated the diff for D134946: [AArch64][SVE] Add instcombine for PTEST_ANY(X=OP(PG,...), X) -> PTEST_ANY(PG, X)).
Remove zext from tests.
c-rhodes updated the diff for D134946: [AArch64][SVE] Add instcombine for PTEST_ANY(X=OP(PG,...), X) -> PTEST_ANY(PG, X)).
- Don't transform brkn intrinsic.
- Update comment.
Oct 7 2022
Oct 7 2022
c-rhodes added inline comments to D134946: [AArch64][SVE] Add instcombine for PTEST_ANY(X=OP(PG,...), X) -> PTEST_ANY(PG, X)).
c-rhodes updated the diff for D134946: [AArch64][SVE] Add instcombine for PTEST_ANY(X=OP(PG,...), X) -> PTEST_ANY(PG, X)).
Restrict optimization to ptest.any and move to inst combine.
Oct 3 2022
Oct 3 2022
c-rhodes added a comment to D134946: [AArch64][SVE] Add instcombine for PTEST_ANY(X=OP(PG,...), X) -> PTEST_ANY(PG, X)).
Sep 30 2022
Sep 30 2022
Sep 28 2022
Sep 28 2022
c-rhodes committed rG3918ef07c4e6: [AArch64][SVE] Remove redundant ptest after match/nmatch (authored by c-rhodes).
[AArch64][SVE] Remove redundant ptest after match/nmatch
c-rhodes committed rGe36ffdf42ee6: [AArch64][SVE] Precommit tests for redundant ptest after match/nmatch (authored by c-rhodes).
[AArch64][SVE] Precommit tests for redundant ptest after match/nmatch
Aug 8 2022
Aug 8 2022
c-rhodes committed rGa6dec9f5b284: [AArch64][SVE] Add patterns to select masked FP arith (authored by c-rhodes).
[AArch64][SVE] Add patterns to select masked FP arith
c-rhodes committed rG17ac26a78eaa: [AArch64][SVE] NFC: Add tests for masked FP arith patterns (D130564) (authored by c-rhodes).
[AArch64][SVE] NFC: Add tests for masked FP arith patterns (D130564)
Aug 4 2022
Aug 4 2022
LGTM, just one minor comment
Aug 3 2022
Aug 3 2022
c-rhodes updated the diff for D130564: [AArch64][SVE] Add patterns to select masked FP arith.
- fmul(a, select(mask, b, splat(0))) transform isn’t correct, remove it.
- contract fast-math flag only required on the fadd/fsub op.
- fadd(a, select(mask, b, splat(0))’transform is unsafe unless nsz fast-math flag is specified.
Aug 2 2022
Aug 2 2022
c-rhodes added inline comments to D130564: [AArch64][SVE] Add patterns to select masked FP arith.
Jul 29 2022
Jul 29 2022
c-rhodes added inline comments to D130564: [AArch64][SVE] Add patterns to select masked FP arith.
Jul 27 2022
Jul 27 2022
c-rhodes added inline comments to D130564: [AArch64][SVE] Add patterns to select masked FP arith.
c-rhodes updated the diff for D130564: [AArch64][SVE] Add patterns to select masked FP arith.
- Check ‘contract’ fast-math flag is set for FMLA/FMLS transform.
- Tests moved to existing sve-fp-combine.ll
Jul 26 2022
Jul 26 2022
c-rhodes requested review of D130564: [AArch64][SVE] Add patterns to select masked FP arith.
c-rhodes committed rG6082051da158: [AArch64][SVE] Add patterns to select mla/mls (authored by c-rhodes).
[AArch64][SVE] Add patterns to select mla/mls
c-rhodes committed rG816a395bf613: [AArch64][SVE] NFC: Add tests for masked mla/mls patterns (D130492) (authored by c-rhodes).
[AArch64][SVE] NFC: Add tests for masked mla/mls patterns (D130492)
Jul 25 2022
Jul 25 2022
c-rhodes updated the diff for D130492: [AArch64][SVE] Add patterns to select mla/mls.
AArch64ml[as]_p -> AArch64ml[as]_m1
(AArch64ptrue 31) -> (SVEAllActive)
c-rhodes added inline comments to D130492: [AArch64][SVE] Add patterns to select mla/mls.
c-rhodes updated the diff for D130492: [AArch64][SVE] Add patterns to select mla/mls.
Re-write patterns to match more generic ‘b * c’. Also moves patterns to PatFrag.
c-rhodes requested review of D130492: [AArch64][SVE] Add patterns to select mla/mls.
c-rhodes committed rGc04ff587dce2: [AArch64] Combine setcc (iN (bitcast (vNi1 X))) with vecreduce_or (authored by c-rhodes).
[AArch64] Combine setcc (iN (bitcast (vNi1 X))) with vecreduce_or
c-rhodes committed rG5fa185bc73d7: [AArch64][NFC] Add test case for setcc (iN bitcast (vNi1 X)), (iN 0), (eq|ne) (authored by c-rhodes).
[AArch64][NFC] Add test case for setcc (iN bitcast (vNi1 X)), (iN 0), (eq|ne)