- User Since
- May 18 2016, 6:13 AM (170 w, 3 d)
Thu, Aug 22
- Used existing masked.load intrinsic in .ll test that checks the verifier catches bad type when passing a fixed-width vector where a scalable is expected.
- Removed definition of abs and neg intrinsics that were previously used in the above test, these are implemented in the follow-up patch.
- Updated call to CreateIntrinsic in IRBuilderTest to make types argument empty for call to fp-convert intrinsic, only required for overloaded types.
Mon, Aug 19
Fri, Aug 16
@greened sorry for the delayed response, thanks for taking a look at this.
- Moved the intrinsic implementation for abs/neg (without codegen) from D65931 so this patch can be tested.
- Added tests for IRBuilder to test scalable vectors work as expected when using intrinsics through the IRBuilder interface. This required implementing an intrinsic that is explicitly defined with scalable vectors, e.g. LLVMType<nxv4i32>, an SVE floating-point convert intrinsic was used for this. Also tested the behaviour of the overloaded type LLVMScalarOrSameVectorWidth with scalable vectors using the existing masked load intrinsic.
- Replace uses of getNumElements with getElementCount when handling intrinsic type LLVMScalarOrSameVectorWidth so it can correctly support scalable vectors.
- Added an .ll test to test the Verifier catches a bad intrinsic argument when passing a fixed-width predicate (mask) to the abs intrinsic where a scalable is expected.
Thu, Aug 8
I've posted a follow-up patch (D65931) to Phabricator that tests this functionality by implementing intrinsics for a couple of SVE arithmetic instructions.
Tue, Aug 6
Mon, Aug 5
Fri, Aug 2
@ostannard Thanks for review!
Wed, Jul 31
- Improved tests
- Fixed up comments
Tue, Jul 30
Mon, Jul 29
Fri, Jul 26
Jun 7 2019
Jun 6 2019
Jun 3 2019
This was split up into smaller patches, all have now been merged. Abandoning this revision.
Addressed Momchil's comments: explicitly enable/disable arch features in negative directive tests.