♟ atanasyan

[mips] Provide more detailed description for MIPS targets. NFC

[mips] Remove obsoleted "experimental" tag from MIPS 64-bit targets. NFC

Do you have commit access?

This patch fails the following test cases:

Looks good. Thanks. There are a couple notes only:

Let's extend existing triple unit tests and check that Triple::getSubArch() returns Triple::NoSubArch for non-R6 architectures.
I think it's redundant to add R6 target triple to so many "invalid.s" test cases. We check parsing of a target triple by unit tests. It's enough to take a few MIPS MC or CodeGen tests which use combination of non-R6 target triple and -mcpu=mips32r6 argument, remove -mcpu and replace target triple to R6 variant.

[mips][microMIPS] Extending size reduction pass with MOVEP

[mips][microMIPS] Fix the definition of MOVEP instruction

LGTM. Thanks for the patch.

Do you have commit access?

Could that be tested somehow?

Thanks for the patch.

[mips] Fix MIPS N32 ABI triples support

[mips] Enable the mnemonic spell corrector

[MIPS] Fix illegal type assert in single-float mode

LGTM. Thanks. Do you have commit access?

[mips] Add a pattern for 64-bit GPR variant of the `rdhwr` instruction

[mips] Disable the selection of mixed microMIPS/MIPS code

Could you please include more context to patches sent for review?
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

In D51483#1220850, @smaksimovic wrote:

It seems that I cannot apply this patch without applying D51482 first, because that patch introduces the test file.
They should be either decoupled or made dependent on phabricator to indicate the relation.

[mips] Fix `mtc1` and `mfc1` definitions for microMIPS R6

[docs][mips] 7.0 Release notes

[docs][mips] Clang 7.0 Release notes

[mips] Fix microMIPS unconditional branch offset handling

[mips] Involves microMIPS's jump in the analyzable branch set

It would be nice to split this patch - the first one introduces new R6 target triples, the second one fixes N32 ABI handling.

In D51234#1213813, @ruiu wrote:

If this piece of code used to be working correctly, there is another piece of code that adds -flavor ld to the command line. But if that's the case, this change wouldn't work because it constructs something like "ld.lld -flavor ld ...". ld.lld doesn't accept -flavor option.

So my guess is this code is dead. Or, am I missing something?

[docs][mips] Add MIPS specific release notes for LLD 7.0

LGTM
MIPS code becomes a bit longer, but I think it can be fixed in the future.

Could you add test cases to cover these changes?

Thanks for the patch.

[mips] Remove dead code from MipsPassConfig

LGTM
Do you have commit access?

LGTM from MIPS point of view.

I forget that tramp3d-v4 test case consists a single file and this file is big enough. Could you apply the same changes to the CMakeLists.txt?

[mips] Replace custom parsing logic for data directives by the…

atanasyan (Simon Atanasyan)
User

Projects

User Details

Recent Activity
View All

Today

Yesterday

Fri, Sep 21

Thu, Sep 20

Wed, Sep 19

Tue, Sep 18

Mon, Sep 17

Thu, Sep 13

Tue, Sep 11

Sun, Sep 9

Sat, Sep 8

Fri, Sep 7

Mon, Sep 3

Sat, Sep 1

Fri, Aug 31

Thu, Aug 30

Wed, Aug 29

Tue, Aug 28

Mon, Aug 27

Aug 26 2018

Aug 23 2018

Aug 22 2018

Aug 21 2018

Aug 20 2018

Aug 18 2018

Aug 16 2018

Aug 15 2018

Aug 14 2018

Aug 12 2018

Aug 3 2018

Aug 1 2018

Jul 31 2018

Jul 29 2018

Jul 26 2018

Jul 25 2018

atanasyan (Simon Atanasyan)User