Page MenuHomePhabricator

atanasyan (Simon Atanasyan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 6 2013, 6:15 AM (393 w, 5 d)

Recent Activity

Yesterday

atanasyan accepted D87977: [XRay] Change mips to use version 2 sled (PC-relative address).

LGTM

Sun, Sep 20, 2:19 AM · Restricted Project, Restricted Project

Aug 17 2020

atanasyan accepted D86080: [llvm-readobj/elf] - Merge mips-got-overlapped.test to mips-got.test and refine testing..

LGTM

Aug 17 2020, 9:29 AM · Restricted Project

Aug 7 2020

atanasyan accepted D85515: [llvm-readobj] - Remove 3 excessive test cases..

LGTM

Aug 7 2020, 4:40 AM · Restricted Project
atanasyan accepted D85511: [llvm-readelf/obj] - Refine the implementation of printMipsReginfo()..

LGTM

Aug 7 2020, 3:01 AM · Restricted Project

Jul 29 2020

atanasyan accepted D84854: [llvm-readobj/readelf] - Refine the implementation of printMipsOptions()..

LGTM

Jul 29 2020, 9:19 AM · Restricted Project

Jul 17 2020

atanasyan accepted D84033: [llvm-readelf/readobj] - Refine the error reporting in printMipsABIFlags() methods..

LGTM. Thanks

Jul 17 2020, 9:20 AM · Restricted Project

Jul 16 2020

atanasyan accepted D83954: [llvm-readobj] - Add proper testing for the SHT_MIPS_ABIFLAGS section..

LGTM

Jul 16 2020, 1:27 PM · Restricted Project

Jul 15 2020

atanasyan added a comment to D83778: MIPS: add build time option to disable madd.fmt.

Maybe it's better to switch off generation of the madd.fmt by default if the problem is so wide spread? I'm concerned that AFAIK no one other architectures supported by LLVM has configuration options like the proposed LLVM_DISABLE_MIPS_MADD4.

Jul 15 2020, 4:56 AM · Restricted Project
atanasyan committed rG3a6c2a61c642: [mips] Rename FeatureMadd4 to FeatureNoMadd4. NFC (authored by wzssyqa).
[mips] Rename FeatureMadd4 to FeatureNoMadd4. NFC
Jul 15 2020, 4:40 AM
atanasyan closed D83780: MIPS: change FeatureMadd4 to FeatureNoMadd4.
Jul 15 2020, 4:40 AM · Restricted Project

Jul 14 2020

atanasyan accepted D83780: MIPS: change FeatureMadd4 to FeatureNoMadd4.

Do you have commit access?

Jul 14 2020, 9:11 AM · Restricted Project

Jul 6 2020

atanasyan accepted D83225: [llvm-readobj] - Refactor the MipsGOTParser<ELFT> to stop using report_fatal_error()..

LGTM. Thanks

Jul 6 2020, 1:18 PM · Restricted Project

Jun 19 2020

atanasyan accepted D81908: [Mips] Error if a non-immediate operand is used while an immediate is expected.

Do you have commit access?

Jun 19 2020, 11:58 AM · Restricted Project

Jun 16 2020

atanasyan added a comment to D81908: [Mips] Error if a non-immediate operand is used while an immediate is expected.

Does this patch depend on D81919?

No!

Jun 16 2020, 6:04 AM · Restricted Project
atanasyan added a comment to D81908: [Mips] Error if a non-immediate operand is used while an immediate is expected.

Does this patch depend on D81919?

Jun 16 2020, 4:58 AM · Restricted Project
atanasyan added a comment to D81919: [MIPS64] Workaround fixup_Mips_32 for getExprOpValue.

Please include context in all patches sent to review.
To get a full diff, use one of the following commands:

git show HEAD -U999999 > mypatch.patch
git diff -U999999 @{u} > mypatch.patch
git diff HEAD~1 -U999999 > mypatch.patch

https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Jun 16 2020, 4:58 AM · Restricted Project

Jun 3 2020

atanasyan updated subscribers of D80392: [WIP][mips] Use pc-relative relocations in .eh_frame.
Jun 3 2020, 2:43 AM · Restricted Project

Jun 2 2020

atanasyan committed rGb00f0d4238cb: [mips] Support 64-bit relative relocations (authored by atanasyan).
[mips] Support 64-bit relative relocations
Jun 2 2020, 2:13 AM
atanasyan closed D80390: [mips] Support 64-bit relative relocations.
Jun 2 2020, 2:12 AM · Restricted Project
atanasyan added a comment to D80392: [WIP][mips] Use pc-relative relocations in .eh_frame.

I cannot select default behaviour for the LLVM in case of generating .eh_frame sections for MIPS:

  1. Unconditionally use pc-relative relocations.
  2. Use pc-relative relocations by default, but provide options for switching to absolute relocations.
  3. Use absolute relocations by default, but provide options for switching to pc-relative relocations.
Jun 2 2020, 2:12 AM · Restricted Project
atanasyan updated the diff for D80390: [mips] Support 64-bit relative relocations.

Thanks for review, testing and comments.

Jun 2 2020, 1:04 AM · Restricted Project
atanasyan retitled D80390: [mips] Support 64-bit relative relocations from [WIP][mips] Support 64-bit relative relocations to [mips] Support 64-bit relative relocations.
Jun 2 2020, 1:04 AM · Restricted Project

May 22 2020

atanasyan added a comment to D80390: [mips] Support 64-bit relative relocations.
  • .quad foo - . is representable
  • ld.so supports such relocation chain.
  • D78590 can be fixed for MIPS
  • D72228 can get rid of the FDECFIEncoding = dwarf::DW_EH_PE_pcrel | dwarf::DW_EH_PE_sdata4; hack
  • For various relocation processing tool, it supporting a relocation chain as easy as supporting an addition relocation type (R_MIPS_PC64), by, adding case R_MIPS_PC64:?
May 22 2020, 1:13 AM · Restricted Project
atanasyan added a reviewer for D80421: [Mips] use correct ld.so for musl soft float: atanasyan.
  1. Please include as much context as possible with your diff. This instruction helps to do that.
  2. Such patch needs test case(s). Maybe it's enough to update the linux-ld.c test case which is failed now. Update failed cases and check both "soft" and "hard" float cases in this test.
May 22 2020, 12:01 AM · Restricted Project

May 21 2020

atanasyan committed rGc7923e7705d0: [mips] Reorganize check directives in the test. NFC (authored by atanasyan).
[mips] Reorganize check directives in the test. NFC
May 21 2020, 11:22 AM
atanasyan created D80390: [mips] Support 64-bit relative relocations.
May 21 2020, 11:21 AM · Restricted Project
atanasyan created D80392: [WIP][mips] Use pc-relative relocations in .eh_frame.
May 21 2020, 11:21 AM · Restricted Project

May 13 2020

atanasyan committed rG524457edbc3d: [mips] Fix typo in FileCheck directives - replace \0xa0 char by space. NFC (authored by atanasyan).
[mips] Fix typo in FileCheck directives - replace \0xa0 char by space. NFC
May 13 2020, 2:39 AM

May 7 2020

atanasyan accepted D78108: [CSInfo][MIPS] Describe parameter value loaded by ADDiu instruction.

Looks good overall, just a few nits inline.

May 7 2020, 11:16 PM · Restricted Project, debug-info

May 1 2020

atanasyan accepted D79270: [test] Fix lld's ELF/linkerscript/thunk-gen-mips.s.

Initially the test case just checks that LLD does not crash under some conditions. It's not mandatory to test exact symbols' values and/or offsets between symbols. But after this fix the test additionally becomes more tolerant to exact symbol addresses. It's fine.
As to me, I'd remove the "Ideally we'd use..." comment.

May 1 2020, 11:25 PM · Restricted Project

Apr 24 2020

atanasyan committed rG0eec6662f669: [MC][mips] Replace setRType## methods by single setRTypes function. NFC (authored by atanasyan).
[MC][mips] Replace setRType## methods by single setRTypes function. NFC
Apr 24 2020, 2:41 AM

Apr 3 2020

atanasyan committed rGf22445bf5760: [mips][test] Remove redundant and invalid `CHECK-NOT` directives. NFC (authored by atanasyan).
[mips][test] Remove redundant and invalid `CHECK-NOT` directives. NFC
Apr 3 2020, 6:58 AM
atanasyan added a comment to D77354: [DO NOT MERGE] added FileCheck colons that broke things.

I have fixed MIPS-related mistakes at rGf22445b. Thanks for finding them.

Apr 3 2020, 6:57 AM · Restricted Project

Mar 27 2020

atanasyan added inline comments to D76842: [Mips] Make MipsBranchExpansion::replaceBranch() aware of BBIT family of branch.
Mar 27 2020, 2:52 PM · Restricted Project
atanasyan accepted D76842: [Mips] Make MipsBranchExpansion::replaceBranch() aware of BBIT family of branch.

LGTM. Two nits inlined.

Mar 27 2020, 1:43 PM · Restricted Project

Mar 22 2020

atanasyan added a comment to D76247: [MIPS] Implement MIPS3D vector instructions..

Thanks for the catching the issues.

Mar 22 2020, 2:28 PM · Restricted Project
atanasyan committed rG2dc4eb08cd99: [mips] Implement .cpadd directive (authored by atanasyan).
[mips] Implement .cpadd directive
Mar 22 2020, 1:56 PM
atanasyan committed rG9bbddfbeaabd: [mips] Implement sne pseudo instruction (authored by atanasyan).
[mips] Implement sne pseudo instruction
Mar 22 2020, 1:56 PM
atanasyan committed rG862f120fdb0e: [mips] Remove instructions related to "wired paired single" from the P5600… (authored by atanasyan).
[mips] Remove instructions related to "wired paired single" from the P5600…
Mar 22 2020, 1:56 PM
atanasyan committed rGdca9e40c0cf8: [mips] Implement sle/sleu pseudo instructions (authored by atanasyan).
[mips] Implement sle/sleu pseudo instructions
Mar 22 2020, 1:56 PM
atanasyan committed rGecc92fd018c6: [mips] Add HasMips3D to the list of features unsupported by P5600 model. (authored by atanasyan).
[mips] Add HasMips3D to the list of features unsupported by P5600 model.
Mar 22 2020, 1:56 PM
atanasyan committed rG0f15ace018bf: [mips] Rename target feature Mips3D => HasMips3D. NFC (authored by atanasyan).
[mips] Rename target feature Mips3D => HasMips3D. NFC
Mar 22 2020, 1:56 PM

Mar 17 2020

atanasyan committed rG73b1da160513: [MIPS] Implement MIPS3D vector instructions (authored by atanasyan).
[MIPS] Implement MIPS3D vector instructions
Mar 17 2020, 7:26 AM
atanasyan closed D76247: [MIPS] Implement MIPS3D vector instructions..
Mar 17 2020, 7:26 AM · Restricted Project
atanasyan accepted D76247: [MIPS] Implement MIPS3D vector instructions..

LGTM

Mar 17 2020, 7:25 AM · Restricted Project

Mar 15 2020

atanasyan committed rGe0ab0e6a281f: [MIPS] Implement PUL.PS and PUU.PS instructions (authored by atanasyan).
[MIPS] Implement PUL.PS and PUU.PS instructions
Mar 15 2020, 11:42 PM
atanasyan closed D75812: [MIPS] Implement PUL.PS and PUU.PS instructions.
Mar 15 2020, 11:42 PM · Restricted Project

Mar 13 2020

atanasyan accepted D75812: [MIPS] Implement PUL.PS and PUU.PS instructions.

LGTM Thanks for the patch.

Mar 13 2020, 3:40 PM · Restricted Project

Mar 8 2020

atanasyan requested changes to D75812: [MIPS] Implement PUL.PS and PUU.PS instructions.

The following test cases failed on my machine. Initially, assembler shows error: unknown instruction. Now assembler shows correct error message instruction requires a CPU feature not currently enabled and the checks should be updated and moved to invalid-xxx.s files.

MC/Mips/mips1/invalid-mips5-wrong-error.s
MC/Mips/mips2/invalid-mips5-wrong-error.s
MC/Mips/mips3/invalid-mips5-wrong-error.s
MC/Mips/mips4/invalid-mips5-wrong-error.s
MC/Mips/mips64r6/invalid-mips5-wrong-error.s
Mar 8 2020, 5:50 AM · Restricted Project

Feb 27 2020

atanasyan added inline comments to D75216: [lld][ELF] Add some release notes.
Feb 27 2020, 12:21 AM · Restricted Project

Feb 26 2020

atanasyan added inline comments to D75216: [lld][ELF] Add some release notes.
Feb 26 2020, 10:08 PM · Restricted Project

Feb 16 2020

atanasyan accepted D74624: [MIPS GlobalISel] Select 4 byte unaligned load and store.

LGTM

Feb 16 2020, 10:13 PM · Restricted Project
atanasyan accepted D74625: [MIPS GlobalISel] Legalize non-power-of-2 and unaligned load and store.

LGTM

Feb 16 2020, 10:13 PM · Restricted Project
atanasyan accepted D74623: [MIPS GlobalISel] RegBankSelect G_MERGE_VALUES and G_UNMERGE_VALUES.

LGTM

Feb 16 2020, 10:13 PM · Restricted Project

Feb 10 2020

atanasyan accepted D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores..

Looking good to me as-is.

Feb 10 2020, 4:26 AM · Restricted Project, Restricted Project

Feb 6 2020

atanasyan added a comment to D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores..

I see, thanks. Is there the same or similar functionality in GCC?

Feb 6 2020, 8:34 AM · Restricted Project, Restricted Project

Jan 30 2020

atanasyan added a comment to D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores..

Is it possible to emulate these new intrinsics using existing ones and some additional code? Is code generated in this case much larger/slower then the code generated by the new intrinsics?

Jan 30 2020, 5:17 AM · Restricted Project, Restricted Project

Jan 29 2020

atanasyan accepted D73648: Don't mark MIPS TRAP as isTerminator.

LGTM
Thanks

Jan 29 2020, 2:35 PM · Restricted Project

Jan 27 2020

atanasyan accepted D73489: [mips][NFC] Remove unused instruction formats.

LGTM
Thanks

Jan 27 2020, 11:55 AM · Restricted Project

Jan 26 2020

atanasyan closed D73108: [docs][mips] 10.0 Release notes.

Closed by commit rG27f93515.

Jan 26 2020, 6:16 AM · Restricted Project, Restricted Project
atanasyan committed rG27f93515c68b: [docs][mips] 10.0 Release notes (authored by atanasyan).
[docs][mips] 10.0 Release notes
Jan 26 2020, 6:11 AM

Jan 25 2020

atanasyan accepted D73214: [MIPS GlobalISel] Select count leading zeros.

LGTM

Jan 25 2020, 1:51 AM · Restricted Project

Jan 23 2020

atanasyan accepted D73215: [MIPS GlobalISel] Select count trailing zeros.

LGTM

Jan 23 2020, 6:39 AM · Restricted Project
atanasyan accepted D73216: [MIPS GlobalISel] Select population count (popcount).

LGTM

Jan 23 2020, 5:44 AM · Restricted Project
atanasyan added inline comments to D73214: [MIPS GlobalISel] Select count leading zeros.
Jan 23 2020, 4:59 AM · Restricted Project
atanasyan added inline comments to D73214: [MIPS GlobalISel] Select count leading zeros.
Jan 23 2020, 4:41 AM · Restricted Project

Jan 21 2020

atanasyan updated the diff for D73108: [docs][mips] 10.0 Release notes.
  • Add llvm-exegesis note.
Jan 21 2020, 8:33 AM · Restricted Project, Restricted Project
atanasyan added a comment to D73108: [docs][mips] 10.0 Release notes.

Initial MIPS support was also added to llvm-exegesis.

Jan 21 2020, 8:33 AM · Restricted Project, Restricted Project
atanasyan created D73108: [docs][mips] 10.0 Release notes.
Jan 21 2020, 7:25 AM · Restricted Project, Restricted Project

Jan 17 2020

atanasyan accepted D72858: [llvm-exegesis][mips] Add support for memory instructions.

LGTM

Jan 17 2020, 2:10 AM · Restricted Project

Jan 16 2020

atanasyan accepted D72004: [llvm-exegesis][mips] Add RegisterAliasingTest unit test.

LGTM

Jan 16 2020, 8:38 AM · Restricted Project
atanasyan accepted D72794: [LegalizeDAG][Mips] Add an assert to protect a uint_to_fp implementation from double rounding. Add a i32->f32 uint_to_fp implementation that avoids this code..

LGTM

Jan 16 2020, 4:30 AM · Restricted Project
atanasyan accepted D72771: TableGen: Work around assert on Mips register definitions.

I'll take a look on MIPS vector register definitions. Four register classes looks really ill formed.

Jan 16 2020, 4:08 AM · Restricted Project

Jan 13 2020

atanasyan accepted D72571: [MIPS] Don't add R_(MICRO)MIPS_JALR relocations against data symbols.

LGTM

Jan 13 2020, 5:29 AM · Restricted Project

Jan 11 2020

atanasyan accepted D72228: [MIPS][ELF] Use PC-relative relocations in .eh_frame when possible.

I'm sorry for the delay. The patch is LGTM.
Thanks.

Jan 11 2020, 1:47 PM · Restricted Project

Jan 6 2020

atanasyan accepted D72254: MipsDelaySlotFiller: Update registers def-uses for BUNDLE instructions.

LGTM

Jan 6 2020, 8:00 AM · Restricted Project

Jan 4 2020

atanasyan added inline comments to D72003: [llvm-exegesis][NFC] Refactor Mips tests fixtures into a base class.
Jan 4 2020, 3:52 AM · Restricted Project

Dec 27 2019

atanasyan accepted D71363: [MIPS GlobalISel] Select bitreverse.

LGTM

Dec 27 2019, 6:12 AM · Restricted Project

Dec 25 2019

atanasyan accepted D71873: [llvm-exegesis][mips] Expand loadImmediate().

LGTM

Dec 25 2019, 7:01 AM · Restricted Project

Dec 17 2019

atanasyan accepted D71605: [llvm-exegesis][mips] Add lit test.

LGTM

Dec 17 2019, 11:05 AM · Restricted Project

Dec 16 2019

atanasyan accepted D71471: [llvm-exegesis][mips] Add SnippetGeneratorTest unit test.

LGTM

Dec 16 2019, 6:08 AM · Restricted Project
atanasyan accepted D71477: [mips] Add an assert in getTargetStreamer().

LGTM

Dec 16 2019, 6:07 AM · Restricted Project

Dec 12 2019

atanasyan added a comment to D71363: [MIPS GlobalISel] Select bitreverse.

I'll check again on my side tomorrow.

******************** TEST 'LLVM :: CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll' FAILED ********************
Script:
--
: 'RUN: at line 2';   /home/simon/work/llvm/bld/bin/llc -O0 -mtriple=mipsel-linux-gnu -global-isel -verify-machineinstrs /home/simon/work/llvm/git/llvm/test/CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll -o -| /home/simon/work/llvm/bld/bin/FileCheck /home/simon/work/llvm/git/llvm/test/CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll -check-prefixes=MIPS32                                                                                                  
: 'RUN: at line 3';   /home/simon/work/llvm/bld/bin/llc -O0 -mtriple=mipsel-linux-gnu -global-isel -mattr=+mips32r2 -verify-machineinstrs /home/simon/work/llvm/git/llvm/test/CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll -o -|
/home/simon/work/llvm/bld/bin/FileCheck /home/simon/work/llvm/git/llvm/test/CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll -check-prefixes=MIPS32R2                                                                               
--
Exit Code: 1
Dec 12 2019, 10:23 AM · Restricted Project
atanasyan accepted D71265: [llvm-exegesis][mips] Add BenchmarkResultTest unit test.

LGTM

Dec 12 2019, 9:46 AM · Restricted Project
atanasyan accepted D71399: Mips: Make test resistant to future changes.

LGTM

Dec 12 2019, 9:37 AM · Restricted Project
atanasyan accepted D71362: [MIPS GlobalISel] Select bswap.

LGTM

Dec 12 2019, 9:37 AM · Restricted Project
atanasyan added a comment to D71363: [MIPS GlobalISel] Select bitreverse.

When I apply this one and D71362 to the master branch I get a couple of failed tests:

LLVM :: CodeGen/Mips/GlobalISel/legalizer/bitreverse.mir
LLVM :: CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll
Dec 12 2019, 9:37 AM · Restricted Project

Dec 11 2019

atanasyan accepted D71028: [Mips] Add support for min/max/umin/umax atomics.

LGTM

Dec 11 2019, 9:05 AM · Restricted Project

Dec 7 2019

atanasyan added a comment to D71137: [RFC][mips][llvm-exegesis] Fix missing TargetStreamer in the Streamer for reading snippets.

AsmParsers in other architectures have references and use a TargetStreamer too. What's a difference in MIPS? Does MIPS need a TargetStreamer in places where other architectures do not use it?

Dec 7 2019, 1:48 AM · Restricted Project

Dec 5 2019

atanasyan accepted D71028: [Mips] Add support for min/max/umin/umax atomics.

I do not think we can modify the Incr.

Dec 5 2019, 3:16 AM · Restricted Project

Dec 3 2019

atanasyan accepted D70953: Allow negative offsets in MipsMCInstLower::LowerOperand.

LGTM

Dec 3 2019, 7:09 AM · Restricted Project
atanasyan accepted D70945: Handle BUNDLE instructions in MipsAsmPrinter.

LGTM

Dec 3 2019, 5:18 AM · Restricted Project
atanasyan accepted D70944: MipsDelaySlotFiller: Don't move BUNDLE instructions into the delay slot.

LGTM

Dec 3 2019, 5:18 AM · Restricted Project
atanasyan accepted D70940: Add debug output to MipsDelaySlotFiller pass.

LGTM

Dec 3 2019, 5:09 AM · Restricted Project

Nov 28 2019

atanasyan committed rGf4d32ae75bf5: [mips] Check that features required by built-ins are enabled (authored by atanasyan).
[mips] Check that features required by built-ins are enabled
Nov 28 2019, 1:33 PM
atanasyan closed D70808: [mips] Check that features required by built-ins are enabled.
Nov 28 2019, 1:32 PM · Restricted Project
atanasyan created D70808: [mips] Check that features required by built-ins are enabled.
Nov 28 2019, 2:41 AM · Restricted Project

Nov 27 2019

atanasyan commandeered D16674: [mips] Expansion of SC[D] and LL[D] for R6.
Nov 27 2019, 2:40 AM
atanasyan abandoned D16674: [mips] Expansion of SC[D] and LL[D] for R6.

Implemented at https://reviews.llvm.org/rG11074bfffee.

Nov 27 2019, 2:40 AM

Nov 26 2019

atanasyan committed rG11074bfffee0: [mips] Fix sc, scs, ll, lld instructions expanding (authored by atanasyan).
[mips] Fix sc, scs, ll, lld instructions expanding
Nov 26 2019, 1:45 PM