Page MenuHomePhabricator

atanasyan (Simon Atanasyan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 6 2013, 6:15 AM (307 w, 9 h)

Recent Activity

Today

atanasyan committed rL351987: [mips] Handle MipsMCExpr sub-expression for the MEK_DTPREL tag.
[mips] Handle MipsMCExpr sub-expression for the MEK_DTPREL tag
Wed, Jan 23, 2:03 PM
atanasyan added a comment to D53416: [MIPS GlobalISel] Select sub.

I'm sorry for the delay. I'll review the patch soon.

Wed, Jan 23, 12:15 PM
atanasyan accepted D57099: [MIPS GlobalISel] Select zero extending and sign extending load.

LGTM

Wed, Jan 23, 12:13 PM
atanasyan accepted D56914: [MIPS GlobalISel] Combine extending loads.

LGTM

Wed, Jan 23, 12:13 PM
atanasyan accepted D52878: [test-suite] Add flags for stdthreadbug.cpp when building static.

LGTM

Wed, Jan 23, 6:21 AM

Fri, Jan 18

atanasyan added a comment to D56836: [mips] Include whole lpthread when using both -pthread and -static.

As an option, we can provide necessary flags for the test to finish successfully instead of not testing it.

Fri, Jan 18, 5:12 AM
atanasyan accepted D56878: [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls'.

LGTM with a nit.

Fri, Jan 18, 5:11 AM

Thu, Jan 17

atanasyan added a comment to D56836: [mips] Include whole lpthread when using both -pthread and -static.

I am not sure if -static option passed as --cflag to lnt runtest enters the LDFLAGS. I guess it doesn't.
But if there is a way to check which options are passed as --cflags, we might be able to add -Wl, -whole-archive -lpthread -Wl -no-whole-archive only in case when static is used.
That would be my preferable option in this situation, but I couldn't find any clues on how to do that.

Thu, Jan 17, 2:16 PM
atanasyan accepted D56694: [mips] Emit .reloc R_{MICRO}MIPS_JALR along with j(al)r(c) $25.

LGTM

Thu, Jan 17, 12:54 PM
atanasyan added a comment to D56836: [mips] Include whole lpthread when using both -pthread and -static.

Now I'm not sure that we really need to make this code more complicated. As to the stdthreadbug test case, maybe we can just exclude this test if LDFLAGS contains the -static option.

Thu, Jan 17, 3:34 AM

Wed, Jan 16

atanasyan added a comment to D52878: [test-suite] Add flags for stdthreadbug.cpp when building static.

The problem (if we forget that static linking is usually not a good idea) is not MIPS specific so maybe the following patch solves the problem generally and better?

Wed, Jan 16, 10:06 AM
atanasyan added a comment to D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.

I am pretty sure we can land this because having a patch on a review for about a year is always a terrible thing. My comments are inline.

Wed, Jan 16, 8:23 AM · lld
atanasyan added inline comments to D56694: [mips] Emit .reloc R_{MICRO}MIPS_JALR along with j(al)r(c) $25.
Wed, Jan 16, 8:10 AM

Sat, Jan 12

atanasyan committed rL351001: [ORC][MIPS] Fill delay-slot after `jr` instruction.
[ORC][MIPS] Fill delay-slot after `jr` instruction
Sat, Jan 12, 3:16 AM
atanasyan committed rL351000: [ORC][MIPS] Setup t9 register and call function through this register.
[ORC][MIPS] Setup t9 register and call function through this register
Sat, Jan 12, 3:16 AM
atanasyan closed D56058: [ORC][MIPS] Setup t9 register and call function through this register.
Sat, Jan 12, 3:16 AM
atanasyan added a comment to D56058: [ORC][MIPS] Setup t9 register and call function through this register.

Thanks for review.

Sat, Jan 12, 1:32 AM

Thu, Jan 10

atanasyan added a comment to D56058: [ORC][MIPS] Setup t9 register and call function through this register.

Gentle ping...

Thu, Jan 10, 2:03 AM
atanasyan edited reviewers for D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps, added: grimar; removed: espindola.

Gentle ping...

Thu, Jan 10, 2:02 AM · lld

Wed, Jan 9

atanasyan accepted D56320: [mips] Optimize shifts for types larger than GPR size (mips2/mips3).

LGTM with a couple of nits

Wed, Jan 9, 1:29 PM
atanasyan accepted D56269: [MIPS GlobalISel] Add pre legalizer combiner pass.

LGTM

Wed, Jan 9, 12:50 PM

Fri, Jan 4

atanasyan added a comment to D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.

Gentle ping...

Fri, Jan 4, 5:48 AM · lld
atanasyan added a comment to D56058: [ORC][MIPS] Setup t9 register and call function through this register.

Gentle ping...

Fri, Jan 4, 5:48 AM

Sat, Dec 29

atanasyan committed rL350152: [mips] Show an error on attempt to use 64-bit PC-relative relocation.
[mips] Show an error on attempt to use 64-bit PC-relative relocation
Sat, Dec 29, 2:13 AM
atanasyan committed rL350151: [mips] Show a regular error message on attempt to use one byte relocation.
[mips] Show a regular error message on attempt to use one byte relocation
Sat, Dec 29, 2:13 AM

Fri, Dec 28

atanasyan accepted D56083: [llvm-objdump] - Implement -z/--disassemble-zeroes.

LGTM

Fri, Dec 28, 5:29 AM

Wed, Dec 26

atanasyan committed rT350066: [test-suite][mips] Disable setlocale calls in consumer-typeset test.
[test-suite][mips] Disable setlocale calls in consumer-typeset test
Wed, Dec 26, 6:44 AM
atanasyan committed rL350066: [test-suite][mips] Disable setlocale calls in consumer-typeset test.
[test-suite][mips] Disable setlocale calls in consumer-typeset test
Wed, Dec 26, 6:41 AM
atanasyan closed D55708: [test-suite][mips] Disable setlocale calls in consumer-typeset test.
Wed, Dec 26, 6:41 AM
atanasyan added inline comments to D56083: [llvm-objdump] - Implement -z/--disassemble-zeroes.
Wed, Dec 26, 6:17 AM

Tue, Dec 25

atanasyan accepted D56001: [MIPS GlobalISel] Select G_SELECT.

LGTM

Tue, Dec 25, 5:32 AM

Dec 23 2018

atanasyan created D56058: [ORC][MIPS] Setup t9 register and call function through this register.
Dec 23 2018, 4:14 AM
atanasyan committed rL350023: [ORC] Rename register in the OrcMips64 resolver code comments. NFC.
[ORC] Rename register in the OrcMips64 resolver code comments. NFC
Dec 23 2018, 4:09 AM
atanasyan committed rL350022: [ORC] clang-format OrcMips32 and OrcMips64 code. NFC.
[ORC] clang-format OrcMips32 and OrcMips64 code. NFC
Dec 23 2018, 4:09 AM
atanasyan committed rL350021: [ORC] Remove redundant instruction from MIPS resolver code. NFC.
[ORC] Remove redundant instruction from MIPS resolver code. NFC
Dec 23 2018, 4:09 AM

Dec 22 2018

atanasyan added a comment to D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.

Gentle ping...

Dec 22 2018, 8:27 AM · lld

Dec 20 2018

atanasyan accepted D55708: [test-suite][mips] Disable setlocale calls in consumer-typeset test.

Do you have commit access?

Dec 20 2018, 6:41 AM

Dec 18 2018

atanasyan added inline comments to D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD.
Dec 18 2018, 11:43 PM
atanasyan accepted D55651: [MIPS GlobalISel] Select G_SDIV, G_UDIV, G_SREM and G_UREM.

LGTM

Dec 18 2018, 7:29 AM

Dec 17 2018

atanasyan accepted D55362: [MIPS GlobalISel] ClampScalar G_AND G_OR and G_XOR.

LGTM

Dec 17 2018, 1:40 PM
atanasyan added a comment to D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.

Gentle ping...

Dec 17 2018, 7:15 AM · lld

Dec 16 2018

atanasyan accepted D54580: [MIPS GlobalISel] Lower G_UADDE and narrowScalar G_ADD.

I see. Then we can agree that renumbering of the fixedStack ids is a bug not connected with this patch.
Are we ready to commit?

...

I can prepare another patch to fix renumbering of the fixedStack ids.

Dec 16 2018, 12:57 PM

Dec 12 2018

atanasyan closed D42790: [ELF] Check that Elf_Rela addends are always written with -r.

Is this patch still needs to be applied?

Dec 12 2018, 9:14 AM
atanasyan closed D48217: [mips][wip] Disable the selection of mixed microMIPS/MIPS code.

Equivalent changes have been applied by D51483 / rL341338.

Dec 12 2018, 9:07 AM
atanasyan abandoned D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected.

Commits rL348934 and rL348935 enable using of integrated assembler for MIPS targets in all cases.

Dec 12 2018, 7:45 AM
atanasyan committed rC348935: [mips] Enable using of integrated assembler in all cases..
[mips] Enable using of integrated assembler in all cases.
Dec 12 2018, 7:37 AM
atanasyan committed rL348934: [mips] Enable using of integrated assembler in all cases..
[mips] Enable using of integrated assembler in all cases.
Dec 12 2018, 7:37 AM
atanasyan committed rL348935: [mips] Enable using of integrated assembler in all cases..
[mips] Enable using of integrated assembler in all cases.
Dec 12 2018, 7:37 AM

Dec 11 2018

atanasyan committed rL348914: [mips] Use llvm-mc -triple option instead of combination of arch,target-abi….
[mips] Use llvm-mc -triple option instead of combination of arch,target-abi…
Dec 11 2018, 11:07 PM
atanasyan updated the diff for D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.
  • Remove new argument from relocateOne methods
  • Introduce new helper function setMicroMipsBit and call it before the relocateOne
Dec 11 2018, 2:04 PM · lld

Dec 5 2018

atanasyan accepted D55292: [mips][mc] Emit R_{MICRO}MIPS_JALR when expanding jal to jalr.

LGTM

Dec 5 2018, 8:35 AM
atanasyan accepted D55323: [mips][micrompis] Emit 16bit NOPs by default.

LGTM

Dec 5 2018, 8:06 AM

Dec 3 2018

atanasyan committed rL348194: [mips] Fix TestDWARF32Version5Addr8AllForms test failure on MIPS hosts.
[mips] Fix TestDWARF32Version5Addr8AllForms test failure on MIPS hosts
Dec 3 2018, 1:57 PM
atanasyan closed D54937: [mips] Fix TestDWARF32Version5Addr8AllForms test failure on MIPS hosts.
Dec 3 2018, 1:57 PM
atanasyan added a comment to D54937: [mips] Fix TestDWARF32Version5Addr8AllForms test failure on MIPS hosts.

Thanks for review.

Dec 3 2018, 1:57 PM

Nov 28 2018

atanasyan updated the diff for D54937: [mips] Fix TestDWARF32Version5Addr8AllForms test failure on MIPS hosts.
  • Rebased against the trunk
Nov 28 2018, 6:09 AM
atanasyan added a comment to D54937: [mips] Fix TestDWARF32Version5Addr8AllForms test failure on MIPS hosts.

I'm not sure I follow this well enough (probably because I know nothing about MIPS relocation types) to be a primary reviewer - but could you explain a bit more how this came to be an issue? Which commit broke MIPS here? Is this something we need to support, or perhaps just an overly general unit test that doesn't quite need the coverage it has?

Nov 28 2018, 5:16 AM
atanasyan committed rL347744: [DebugInfo] Rename EmitDebugThreadLocal back to EmitDebugValue. NFC.
[DebugInfo] Rename EmitDebugThreadLocal back to EmitDebugValue. NFC
Nov 28 2018, 3:51 AM
atanasyan committed rLLD347742: [ELF][MIPS] Handle mips in the OUTPUT_FORMAT directive.
[ELF][MIPS] Handle mips in the OUTPUT_FORMAT directive
Nov 28 2018, 3:44 AM
atanasyan committed rL347742: [ELF][MIPS] Handle mips in the OUTPUT_FORMAT directive.
[ELF][MIPS] Handle mips in the OUTPUT_FORMAT directive
Nov 28 2018, 3:44 AM
atanasyan closed D54920: [ELF][MIPS] Handle mips in the OUTPUT_FORMAT directive.
Nov 28 2018, 3:44 AM · lld

Nov 27 2018

atanasyan updated the diff for D54920: [ELF][MIPS] Handle mips in the OUTPUT_FORMAT directive.
  • Simplify handling of the readBfdName return value
Nov 27 2018, 10:05 PM · lld
atanasyan added a comment to D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.

Adding a new parameter to relocateOne doesn't look beautiful, but that makes me think whether you are editing the right place of the code. relocateOne is supposed to apply a single relocation based on a value passed to the function. No complex logic should be in the function. Passing one more parameter so that you can do more complex computation in the function may not be a good idea.

Nov 27 2018, 8:06 AM · lld
atanasyan added a comment to D54580: [MIPS GlobalISel] Lower G_UADDE and narrowScalar G_ADD.

Sorry for the belated reply.

Nov 27 2018, 4:50 AM
atanasyan added inline comments to D54920: [ELF][MIPS] Handle mips in the OUTPUT_FORMAT directive.
Nov 27 2018, 2:06 AM · lld
atanasyan created D54937: [mips] Fix TestDWARF32Version5Addr8AllForms test failure on MIPS hosts.
Nov 27 2018, 1:56 AM
atanasyan updated the diff for D54920: [ELF][MIPS] Handle mips in the OUTPUT_FORMAT directive.
  • Return a boolean value indicating whether the name is MIPS N32 ABI or not from the readBfdName .
Nov 27 2018, 12:40 AM · lld

Nov 26 2018

atanasyan updated the diff for D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.
  • Really remove default nullptr argument value from the relocateOne method
Nov 26 2018, 3:15 PM · lld
atanasyan updated the diff for D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.
  • Rebase against the trunk
  • Remove default nullptr value from the relocateOne method
Nov 26 2018, 3:12 PM · lld
atanasyan created D54920: [ELF][MIPS] Handle mips in the OUTPUT_FORMAT directive.
Nov 26 2018, 3:10 PM · lld

Nov 20 2018

atanasyan committed rL347346: [unittests] Fix ExpandTilde test to match handling home dirs with trailing slash.
[unittests] Fix ExpandTilde test to match handling home dirs with trailing slash
Nov 20 2018, 1:16 PM
atanasyan closed D54752: [unittests] Fix ExpandTilde test to match handling home dirs with trailing slash.
Nov 20 2018, 1:16 PM
atanasyan accepted D54721: [mips][mc] Add basic support for R_MIPS_JALR/R_MICROMIPS_JALR.

LGTM

Nov 20 2018, 10:57 AM
atanasyan created D54752: [unittests] Fix ExpandTilde test to match handling home dirs with trailing slash.
Nov 20 2018, 5:49 AM

Nov 19 2018

atanasyan added inline comments to D54721: [mips][mc] Add basic support for R_MIPS_JALR/R_MICROMIPS_JALR.
Nov 19 2018, 8:53 PM
atanasyan accepted D54703: [TargetLowering] expandFP_TO_UINT - improve fp16 support.

LGTM

Nov 19 2018, 10:41 AM
atanasyan added a comment to D53794: [TargetLowering] expandFP_TO_UINT - avoid FPE due to out of range conversion (PR17686).

@atanasyan The f16 conversion fix should probably be pulled out - do you want me to add 'in overflow range' and 'out of overflow range' fptoui tests to f16-llvm-ir.ll ?

Nov 19 2018, 7:11 AM

Nov 16 2018

atanasyan committed rL347049: [DWARF] Use PRIx64 instead of 'x' to format 64-bit values.
[DWARF] Use PRIx64 instead of 'x' to format 64-bit values
Nov 16 2018, 5:18 AM

Nov 15 2018

atanasyan added a comment to D54154: [ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction.

Thanks for review.

Nov 15 2018, 9:33 PM
atanasyan committed rL347029: [ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction.
[ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction
Nov 15 2018, 9:33 PM
atanasyan committed rLLD347029: [ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction.
[ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction
Nov 15 2018, 9:33 PM
atanasyan closed D54154: [ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction.
Nov 15 2018, 9:33 PM

Nov 14 2018

atanasyan updated the diff for D54154: [ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction.
  • Add a separate test case to check trap instruction encoding in case of bi and little endian.
  • Use TrapInstr array.
Nov 14 2018, 2:57 PM
atanasyan committed rLLD346893: [ELF] Make TrapInstr and Filler byte arrays. NFC..
[ELF] Make TrapInstr and Filler byte arrays. NFC.
Nov 14 2018, 1:08 PM
atanasyan committed rL346893: [ELF] Make TrapInstr and Filler byte arrays. NFC..
[ELF] Make TrapInstr and Filler byte arrays. NFC.
Nov 14 2018, 1:08 PM
atanasyan closed D54207: [ELF] Make TrapInstr and Filler byte arrays. NFC..
Nov 14 2018, 1:08 PM
atanasyan added a comment to D54207: [ELF] Make TrapInstr and Filler byte arrays. NFC..

Any plan on committing this change?

If that's directed at me, I don't have commit rights.

Nov 14 2018, 12:39 PM
atanasyan added a comment to rL346773: [WebAssembly] Mark immediates.ll as XFAILed on MIPS hosts.

The problem is related to NaN representation all the same :)

Nov 14 2018, 9:08 AM
atanasyan added a comment to D54207: [ELF] Make TrapInstr and Filler byte arrays. NFC..

Any plan on committing this change?

Nov 14 2018, 7:38 AM
atanasyan added a comment to rL346773: [WebAssembly] Mark immediates.ll as XFAILed on MIPS hosts.

-mnan and --with-nan= are MIPS target options, however I'm asking about targeting WebAssembly with a MIPS host.

WebAssembly always uses the 754-2008 NaN encoding, so compiling C to it should always do so as well, even on a MIPS host. Is that the case?

Nov 14 2018, 6:15 AM

Nov 13 2018

atanasyan added a comment to rL346773: [WebAssembly] Mark immediates.ll as XFAILed on MIPS hosts.

By default mips gcc uses legacy nan. It might be changed by -mnan=2008
/ -mnan=legacy
options. Or by --with-nan=2008 for gcc configuration.

Nov 13 2018, 11:34 AM
atanasyan committed rL346773: [WebAssembly] Mark immediates.ll as XFAILed on MIPS hosts.
[WebAssembly] Mark immediates.ll as XFAILed on MIPS hosts
Nov 13 2018, 10:17 AM
atanasyan added a comment to D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected.

Simon?

Nov 13 2018, 9:17 AM

Nov 12 2018

atanasyan committed rL346715: [DWARF] Do not use PRIx32 for printing uint64_t values.
[DWARF] Do not use PRIx32 for printing uint64_t values
Nov 12 2018, 2:46 PM
atanasyan closed D54424: [DWARF] Do not use PRIx32 for printing uint64_t values.
Nov 12 2018, 2:46 PM
atanasyan added a comment to D54424: [DWARF] Do not use PRIx32 for printing uint64_t values.

Any chance of a test case?

I hope the following test case starts to pass on mips buildbot:
http://lab.llvm.org:8011/builders/llvm-mips-linux/builds/3739/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3Adebug_addr.ll

Could this also be tested cross-platform (on any platform that's building the mips backend)? (ie: a version of this test that 'REQUIRES: ' the mips target and specifically targets it)

Nov 12 2018, 12:05 PM
atanasyan added a comment to D54424: [DWARF] Do not use PRIx32 for printing uint64_t values.

Any chance of a test case?

Nov 12 2018, 11:22 AM
atanasyan created D54424: [DWARF] Do not use PRIx32 for printing uint64_t values.
Nov 12 2018, 5:49 AM

Nov 8 2018

atanasyan added inline comments to D53990: [MC] Support labels as offsets in .reloc directive.
Nov 8 2018, 12:42 PM
atanasyan accepted D53990: [MC] Support labels as offsets in .reloc directive.
Nov 8 2018, 12:39 PM