Page MenuHomePhabricator

atanasyan (Simon Atanasyan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 6 2013, 6:15 AM (486 w, 16 h)

Recent Activity

May 10 2022

atanasyan accepted D124723: [MIPS} Address ISel failures for 64 bit fpus in microMIPS.

LGTM

May 10 2022, 9:23 AM · Restricted Project, Restricted Project

May 9 2022

atanasyan added inline comments to D124723: [MIPS} Address ISel failures for 64 bit fpus in microMIPS.
May 9 2022, 10:23 PM · Restricted Project, Restricted Project

May 7 2022

atanasyan accepted D124742: [MIPS] Correct the implementation of the msub optimization.

LGTM. Thanks.

May 7 2022, 11:55 PM · Restricted Project, Restricted Project
atanasyan accepted D124716: [MIPS] Remove an incorrect microMIPS instruction alias.

LGTM. Thanks.

May 7 2022, 10:07 AM · Restricted Project, Restricted Project

Apr 28 2022

atanasyan added a comment to D124651: [MIPS] Address instruction selection failure for abs.[sd].

It looks like this resolves PR/53722 not 53772.

Apr 28 2022, 10:13 PM · Restricted Project, Restricted Project
atanasyan accepted D124651: [MIPS] Address instruction selection failure for abs.[sd].

LGTM

Apr 28 2022, 10:11 PM · Restricted Project, Restricted Project

Mar 7 2022

atanasyan committed rG7daed359111f: Remove Simon Atanasyan from the code owners list. MIPS Backend. (authored by atanasyan).
Remove Simon Atanasyan from the code owners list. MIPS Backend.
Mar 7 2022, 2:17 AM · Restricted Project

Mar 3 2022

atanasyan added a comment to D120926: [Mips] support "sp" named register.

Do you have commit access?

Mar 3 2022, 1:37 PM · Restricted Project, Restricted Project
atanasyan accepted D120926: [Mips] support "sp" named register.
Mar 3 2022, 1:36 PM · Restricted Project, Restricted Project

Feb 23 2022

atanasyan committed rG3c840e3c00e9: [MIPS] Recognize DT_MIPS_XHASH dynamic table tag (authored by atanasyan).
[MIPS] Recognize DT_MIPS_XHASH dynamic table tag
Feb 23 2022, 5:07 AM

Feb 22 2022

atanasyan added a comment to D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON.

@atanasyan A few mips test/Driver tests will fail. Wonder if you have time making them more portable... Otherwise I'll just add UNSUPPORTED: default-pie-on-linux to them.

Failed Tests (6):
  Clang :: Driver/hip-fpie-option.hip
  Clang :: Driver/mips-cs.cpp
  Clang :: Driver/mips-fsf.cpp
  Clang :: Driver/mips-img-v2.cpp
  Clang :: Driver/mips-img.cpp
  Clang :: Driver/mips-mti-linux.c

I will take a look at the tests. Probably hip-fpie-option.hip is unrelated to MIPS?

Feb 22 2022, 9:27 AM · Restricted Project, Restricted Project, Restricted Project
atanasyan committed rGcedc23bc8612: [MIPS] Add `-no-pie` option to the clang driver's tests depend on it (authored by atanasyan).
[MIPS] Add `-no-pie` option to the clang driver's tests depend on it
Feb 22 2022, 9:25 AM
atanasyan added a comment to D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON.

@atanasyan A few mips test/Driver tests will fail. Wonder if you have time making them more portable... Otherwise I'll just add UNSUPPORTED: default-pie-on-linux to them.

Failed Tests (6):
  Clang :: Driver/hip-fpie-option.hip
  Clang :: Driver/mips-cs.cpp
  Clang :: Driver/mips-fsf.cpp
  Clang :: Driver/mips-img-v2.cpp
  Clang :: Driver/mips-img.cpp
  Clang :: Driver/mips-mti-linux.c
Feb 22 2022, 12:47 AM · Restricted Project, Restricted Project, Restricted Project

Jan 20 2022

atanasyan committed rGee198df2e14c: [mips] Improve vr4300 mulmul bugfix pass (authored by Random06457).
[mips] Improve vr4300 mulmul bugfix pass
Jan 20 2022, 9:10 AM
atanasyan closed D117615: [mips] fix -mfix4300.
Jan 20 2022, 9:10 AM · Restricted Project
atanasyan accepted D117615: [mips] fix -mfix4300.

LGTM with a small fix. I will commit the changes shortly.

Jan 20 2022, 9:03 AM · Restricted Project

Jan 11 2022

atanasyan committed rG0199e4737349: [mips][lld] Add test case to check symbol index reading on mips64el. NFC (authored by atanasyan).
[mips][lld] Add test case to check symbol index reading on mips64el. NFC
Jan 11 2022, 8:09 AM
atanasyan committed rG962e8d9976c5: [mips] Use `push_back` to insert element at the end of a container. NFC (authored by atanasyan).
[mips] Use `push_back` to insert element at the end of a container. NFC
Jan 11 2022, 8:09 AM

Dec 31 2021

atanasyan committed rG2edcde00cb39: [MIPS] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass (authored by Random06457).
[MIPS] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass
Dec 31 2021, 5:01 AM
atanasyan closed D116238: [mips] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass.
Dec 31 2021, 5:01 AM · Restricted Project, Restricted Project
atanasyan accepted D116238: [mips] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass.

LGTM. Thanks for the patch.

Dec 31 2021, 5:01 AM · Restricted Project, Restricted Project

Dec 24 2021

atanasyan requested changes to D116238: [mips] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass.

Thanks for the patch. Some notes are below.

Dec 24 2021, 10:13 AM · Restricted Project, Restricted Project

Dec 14 2021

atanasyan committed rGd5d8b1c972bc: [llvm-objcopy] Fix handling of MIPS64 little endian files (authored by atanasyan).
[llvm-objcopy] Fix handling of MIPS64 little endian files
Dec 14 2021, 6:22 AM
atanasyan added a comment to D115635: [llvm-objcopy] Fix handling of MIPS64 little endian files.

Thanks for review.

Dec 14 2021, 6:22 AM · Restricted Project
atanasyan closed D115635: [llvm-objcopy] Fix handling of MIPS64 little endian files.
Dec 14 2021, 6:21 AM · Restricted Project

Dec 13 2021

atanasyan committed rG2de9338587ff: [MIPS] Allow i1 values for 'r' constraint in inline-asm (authored by atanasyan).
[MIPS] Allow i1 values for 'r' constraint in inline-asm
Dec 13 2021, 2:20 PM
atanasyan updated the diff for D115635: [llvm-objcopy] Fix handling of MIPS64 little endian files.
  • Reduce redundancy of the test case
  • Add IsMips64 field to the Object class.
  • Save reference to an Object in the RelocationSection class.
Dec 13 2021, 9:39 AM · Restricted Project
atanasyan added a comment to D115635: [llvm-objcopy] Fix handling of MIPS64 little endian files.

Since the "Mips64EL" property is a property of the input object, I wonder if we should just make it a member of the object,
and then put a reference to that object in the relocation sections, so that we can query that, rather than needing
to a) pass around the variable, and b) have to have the property in the relocation section? What do you think?

Dec 13 2021, 9:36 AM · Restricted Project
atanasyan requested review of D115635: [llvm-objcopy] Fix handling of MIPS64 little endian files.
Dec 13 2021, 7:02 AM · Restricted Project

Dec 5 2021

atanasyan accepted D115127: [MIPS] Add FPU Delay Slot for MIPS1/2/3.

LGTM with some nits.

Dec 5 2021, 2:57 PM · Restricted Project

Oct 28 2021

atanasyan committed rG284c2ebc5e05: [clang][MIPS] Fix search path for Debian multilib O32 (authored by wzssyqa).
[clang][MIPS] Fix search path for Debian multilib O32
Oct 28 2021, 12:24 AM
atanasyan closed D112158: mips: fix search path for multilib o32.
Oct 28 2021, 12:24 AM · Restricted Project
atanasyan accepted D112158: mips: fix search path for multilib o32.

LGTM

Oct 28 2021, 12:17 AM · Restricted Project

Oct 21 2021

atanasyan closed D110514: MIPS: Triple::setArch as R6 if MipsSubArch_r6.

The patch committed at rG302a165

Oct 21 2021, 5:07 AM · Restricted Project
atanasyan committed rG302a165e18fd: [MIPS] Fix switching between 32/64-bit variants of r6 target triples (authored by wzssyqa).
[MIPS] Fix switching between 32/64-bit variants of r6 target triples
Oct 21 2021, 5:04 AM
atanasyan added a comment to D110514: MIPS: Triple::setArch as R6 if MipsSubArch_r6.

Do you have commit access?

Oct 21 2021, 12:04 AM · Restricted Project
atanasyan added a comment to D112158: mips: fix search path for multilib o32.
  • Does this problem exist on all versions of Debian or starting from specific version only?
  • This fix needs test cases. Take a look at "Check linker invocation on Debian 6 MIPS 32/64-bit" in the clang/test/Driver/linux-ld.c for example.
Oct 21 2021, 12:02 AM · Restricted Project

Oct 18 2021

atanasyan accepted D110514: MIPS: Triple::setArch as R6 if MipsSubArch_r6.

LGTM. But get one more acceptance from any other reviewer before commit.

Oct 18 2021, 12:53 AM · Restricted Project
atanasyan accepted D111967: [Mips] Add glue between CopyFromReg, CopyToReg and RDHWR nodes for TLS.

LGTM. Thanks for the fix.

Oct 18 2021, 12:50 AM · Restricted Project

Oct 12 2021

atanasyan added a comment to D111486: [Support][mips] Remove unnecessary includes from Memory.inc.

Thanks for the patch.

Oct 12 2021, 9:51 PM · Restricted Project
atanasyan committed rGa5de04d26171: [Support][mips] Remove unnecessary includes from Memory.inc (authored by visa).
[Support][mips] Remove unnecessary includes from Memory.inc
Oct 12 2021, 9:50 PM
atanasyan closed D111486: [Support][mips] Remove unnecessary includes from Memory.inc.
Oct 12 2021, 9:50 PM · Restricted Project
atanasyan accepted D111486: [Support][mips] Remove unnecessary includes from Memory.inc.

LGTM. Do you have commit access?

Oct 12 2021, 12:41 AM · Restricted Project
atanasyan added a reviewer for D110514: MIPS: Triple::setArch as R6 if MipsSubArch_r6: MaskRay.
Oct 12 2021, 12:31 AM · Restricted Project
atanasyan updated subscribers of D110514: MIPS: Triple::setArch as R6 if MipsSubArch_r6.
  • This patch needs test cases. Take a look at llvm/unittests/ADT/TripleTest.cpp
  • IMHO the current fix is not the best solution. It solves the problem but looks a bit strange. For example, the following code (unusual but correct) stops working. Without the patch it produces a correct "arm-linux-gnu" target triple.
Triple T("mipsisa32r6-linux-gnu");
T.setArch(Triple::arm);

It's better to modify Triple::setArch() function so it takes two arguments ArchType and SubArchType. The second argument is NoSubARch by default. Then the setArch() passes both arguments to the getArchTypeName(). We need to teach this function to generate architecture's name in accordance with ArchType and SubArchType arguments. In this patch we can do it for MIPS only. @MaskRay - what do you think?

Oct 12 2021, 12:31 AM · Restricted Project

Sep 27 2021

atanasyan added a comment to D110514: MIPS: Triple::setArch as R6 if MipsSubArch_r6.

If we construct T = Triple("mipsisa64r6el-unknown-linux-gnuabi64") what is result of the T.getArchName() call (without your patch)? If getArchName() returns mipsisa64r6el we need to investigate what is the reason for redundant setArch() call somewhere in the clang driver code. If getArchName() does not return mipsisa64r6el we need to fix triple parsing. One more question - why other targets which has "sub architectures" does not need to extend the Triple::setArch method?

Sep 27 2021, 2:44 PM · Restricted Project

Sep 24 2021

atanasyan accepted D100027: [update_llc_test_checks.py] Fix MIPS ASM regex for functions with EH.

LGTM

Sep 24 2021, 9:21 AM · Restricted Project

Sep 15 2021

atanasyan committed rG533471ff2f82: [MIPS] Remove unused tblgen template args. NFC (authored by atanasyan).
[MIPS] Remove unused tblgen template args. NFC
Sep 15 2021, 2:16 AM

Sep 14 2021

atanasyan added a comment to D109359: [TableGen] Emit a warning for unused template args.

Patches fixing warnings have either landed or are in review for all but AMDGPU and MIPS now. @tstellar please could you take a look at the warnings in the AMDGPU backend or tag another contributor? Understand you might be busy with the 13 release.

Sep 14 2021, 6:30 AM · Restricted Project

Aug 19 2021

atanasyan updated the diff for D80392: [mips][mc][clang] Use pc-relative relocations in .eh_frame.

For compatibility with tools unsupported 64-bit pc-relative relocations the patch introduces new command line options in Clang: mmips-pc64-rel and mno-mips-pc64-rel. These options passed to LLVM by Clang driver as -mmips-pc64-rel={true|false}. I could not find any better way to pass the option into MC layer.

Aug 19 2021, 5:48 AM · Restricted Project, Restricted Project

Aug 8 2021

atanasyan committed rG990e8025b5fc: [MC][ELF] Do not error on parsing .debug_* section directive for MIPS (authored by atanasyan).
[MC][ELF] Do not error on parsing .debug_* section directive for MIPS
Aug 8 2021, 10:55 PM
atanasyan added a comment to D107707: [MC][ELF] Do not error on parsing .debug_* section directive for MIPS.

Thanks for review.

Aug 8 2021, 10:55 PM · Restricted Project
atanasyan closed D107707: [MC][ELF] Do not error on parsing .debug_* section directive for MIPS.
Aug 8 2021, 10:55 PM · Restricted Project
atanasyan updated the diff for D107707: [MC][ELF] Do not error on parsing .debug_* section directive for MIPS.
  • Check section name prefix .debug_ instead of section type. This approach is closer to other MIPS toolchains.
Aug 8 2021, 12:29 PM · Restricted Project
atanasyan added a comment to D107707: [MC][ELF] Do not error on parsing .debug_* section directive for MIPS.

MIPS .debug_* sections should have SHT_MIPS_DWARF section type to distinguish among sections contain DWARF and ECOFF debug formats

If SHT_PROGBITS is a valid value, now what's the value keeping using SHT_MIPS_DWARF?

Aug 8 2021, 12:26 PM · Restricted Project
atanasyan added inline comments to D107707: [MC][ELF] Do not error on parsing .debug_* section directive for MIPS.
Aug 8 2021, 12:25 PM · Restricted Project

Aug 7 2021

atanasyan requested review of D107707: [MC][ELF] Do not error on parsing .debug_* section directive for MIPS.
Aug 7 2021, 10:30 PM · Restricted Project
atanasyan committed rG454f69bcc17e: [LLD] Add required `ppc` target to the test cases. NFC (authored by atanasyan).
[LLD] Add required `ppc` target to the test cases. NFC
Aug 7 2021, 3:31 AM
atanasyan added a comment to D107635: [LLD] Support compressed input sections on big-endian targets.

Thanks for review.

Aug 7 2021, 3:21 AM · Restricted Project
atanasyan committed rGc6ebc651b6fa: [LLD] Support compressed input sections on big-endian targets (authored by atanasyan).
[LLD] Support compressed input sections on big-endian targets
Aug 7 2021, 3:21 AM
atanasyan closed D107635: [LLD] Support compressed input sections on big-endian targets.
Aug 7 2021, 3:20 AM · Restricted Project

Aug 6 2021

atanasyan requested review of D107635: [LLD] Support compressed input sections on big-endian targets.
Aug 6 2021, 3:57 AM · Restricted Project

Jul 12 2021

atanasyan accepted D105739: Mips/GlobalISel: Use more standard call lowering infrastructure.

LGTM

Jul 12 2021, 12:29 AM · Restricted Project

Jul 10 2021

atanasyan accepted D105738: Mips: Mark special case calling convention handling as custom.

LGTM

Jul 10 2021, 7:37 AM · Restricted Project

May 5 2021

atanasyan accepted D101863: [DebugInfo][test][MIPS] Use mtriple in tests.

LGTM

May 5 2021, 1:32 AM · Restricted Project
atanasyan accepted D101342: [SelectionDAG][Mips][PowerPC][RISCV][WebAssembly] Teach computeKnownBits/ComputeNumSignBits about atomics.

The MIPS changes LGTM

May 5 2021, 1:31 AM · Restricted Project

May 3 2021

atanasyan accepted D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem.

LGTM

May 3 2021, 1:45 PM · Restricted Project

Apr 27 2021

atanasyan accepted D101381: [ELF][MIPS] Emit dynamic relocations for PIC non-preemptible static TLS.

LGTM

Apr 27 2021, 11:03 AM · Restricted Project
atanasyan accepted D101382: [ELF][MIPS] Don't emit dynamic relocations for PIE non-preemptible TLS.

LGTM

Apr 27 2021, 10:56 AM · Restricted Project

Apr 26 2021

atanasyan added inline comments to D100218: Fix for "Bug 49146 - Crash with MIPS16 multiply".
Apr 26 2021, 3:38 AM · Restricted Project

Apr 21 2021

atanasyan accepted D100949: [ELF] Update URL for MIPS TLS wiki page.

LGTM

Apr 21 2021, 6:39 AM · Restricted Project

Apr 7 2021

atanasyan accepted D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name.

AFAIK the MIPS LLVM-based toolchain mentioned in D13340 have not been implemented.

Apr 7 2021, 1:30 AM · Restricted Project

Mar 17 2021

atanasyan added a comment to D98659: [MachineCopyPropagation] Do more backward copy propagations.

I don't know why it only affects microMIPS (presumably it does its lowering subtly differently from normal MIPS) but those changes look sensible to me

Mar 17 2021, 8:13 AM · Restricted Project

Mar 11 2021

atanasyan accepted D98273: [SelectionDAG] Improve scalarization of irregular vector types.

LGTM

Mar 11 2021, 7:29 AM · Restricted Project

Mar 10 2021

atanasyan accepted D98189: [MIPS] Fix lowering of irregular vector arguments.

LGTM

Mar 10 2021, 2:37 AM · Restricted Project

Mar 9 2021

atanasyan added a comment to D98189: [MIPS] Fix lowering of irregular vector arguments.

I see. Thanks. One more question - is it possible to split the patch: one for "fixing a couple of rounding issues" and another for "Introducing a few more conversion rules"?

Mar 9 2021, 8:00 AM · Restricted Project
atanasyan added a comment to D98189: [MIPS] Fix lowering of irregular vector arguments.

I have not checked the patch carefully yet. But it looks like some tests was removed. For example MIPS64R5EL-LABEL: i8_2... Is it intended?

Mar 9 2021, 7:39 AM · Restricted Project

Feb 2 2021

atanasyan added a comment to D80392: [mips][mc][clang] Use pc-relative relocations in .eh_frame.

Hi guys,

any chance of this making it into 11.1.0 or 12?

Feb 2 2021, 11:48 PM · Restricted Project, Restricted Project

Jan 18 2021

atanasyan added a comment to D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.

@ntesic Do you have commit access?

Jan 18 2021, 3:46 AM · Restricted Project, debug-info

Jan 14 2021

atanasyan accepted D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.

LGTM

Jan 14 2021, 10:44 AM · Restricted Project, debug-info
atanasyan added a reviewer for D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller: atanasyan.
Jan 14 2021, 10:43 AM · Restricted Project, debug-info

Nov 25 2020

atanasyan accepted D92090: [llvm-readelf/obj] - Stop calling `reportError` in `printArchSpecificInfo()`..

LGTM

Nov 25 2020, 7:39 AM · Restricted Project

Nov 13 2020

atanasyan committed rG7da0d0a67ffc: [MC][mips] Remove unused check prefixes. NFC (authored by atanasyan).
[MC][mips] Remove unused check prefixes. NFC
Nov 13 2020, 3:31 AM
atanasyan committed rG8fbe07a4bec2: [mips] Add tests to check disassembling of add.ps/mul.ps/sub.ps instructions (authored by atanasyan).
[mips] Add tests to check disassembling of add.ps/mul.ps/sub.ps instructions
Nov 13 2020, 3:31 AM

Nov 4 2020

atanasyan added a comment to D90570: [mips] Add a -mmips3d command line option to clang.

My bad, I missed that you implemented passing the option to backend.

Nov 4 2020, 6:09 AM · Restricted Project

Nov 2 2020

atanasyan added a comment to D90570: [mips] Add a -mmips3d command line option to clang.

What's a goal of this change? Do you want to suppress an error message when the option provided to Clang? If so, is it a real-life case?

Nov 2 2020, 1:13 AM · Restricted Project

Oct 30 2020

atanasyan committed rGfc0892c1f9a3: [mips] Implement add.ps, mul.ps and sub.ps (authored by michael-roe).
[mips] Implement add.ps, mul.ps and sub.ps
Oct 30 2020, 1:00 AM
atanasyan closed D90321: [mips] Implement add.ps, mul.ps and sub.ps.
Oct 30 2020, 12:59 AM · Restricted Project

Oct 28 2020

atanasyan accepted D90321: [mips] Implement add.ps, mul.ps and sub.ps.

LGTM with a few nits. Thanks.

Oct 28 2020, 3:21 PM · Restricted Project

Oct 12 2020

atanasyan accepted D89139: [DAG][ARM][MIPS][RISCV] Improve funnel shift promotion to use 'double shift' patterns.

MIPS changes LGTM

Oct 12 2020, 2:02 AM · Restricted Project

Oct 9 2020

atanasyan accepted D89097: [llvm-readelf/obj][test] - Stop using precompiled binary in mips-plt.test.

LGTM

Oct 9 2020, 1:37 AM · Restricted Project

Oct 6 2020

atanasyan accepted D88565: [llvm-readobj/elf][test] - Stop using precompiled binaries in mips-got.test.

LGTM. Thanks!

Oct 6 2020, 1:52 AM · Restricted Project

Sep 29 2020

atanasyan accepted D88488: [llvm-readobj][test] - Stop using few precompiled binaries in mips-got.test.

LGTM

Sep 29 2020, 8:03 AM · Restricted Project

Sep 25 2020

atanasyan committed rGc6c5629f2fb4: [CodeGen] Do not call `emitGlobalConstantLargeInt` for constant requires 8… (authored by atanasyan).
[CodeGen] Do not call `emitGlobalConstantLargeInt` for constant requires 8…
Sep 25 2020, 10:59 PM
atanasyan closed D88261: [CodeGen] Do not call `emitGlobalConstantLargeInt` for constant requires 8 bytes to store.
Sep 25 2020, 10:59 PM · Restricted Project
atanasyan accepted D88294: [obj2yaml][yaml2obj] - Stop recognizing SHT_MIPS_ABIFLAGS on non-MIPS targets..

LGTM

Sep 25 2020, 11:59 AM · Restricted Project

Sep 24 2020

atanasyan requested review of D88261: [CodeGen] Do not call `emitGlobalConstantLargeInt` for constant requires 8 bytes to store.
Sep 24 2020, 2:20 PM · Restricted Project
atanasyan accepted D88231: [Object/yaml2obj/obj2yaml][test] - Split, cleanup and move MIPS abi-flags.yaml test. NFCI..

LGTM

Sep 24 2020, 10:00 AM · Restricted Project

Sep 20 2020

atanasyan accepted D87977: [XRay] Change mips to use version 2 sled (PC-relative address).

LGTM

Sep 20 2020, 2:19 AM · Restricted Project, Restricted Project

Aug 17 2020

atanasyan accepted D86080: [llvm-readobj/elf] - Merge mips-got-overlapped.test to mips-got.test and refine testing..

LGTM

Aug 17 2020, 9:29 AM · Restricted Project