Page MenuHomePhabricator

atanasyan (Simon Atanasyan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 6 2013, 6:15 AM (341 w, 4 d)

Recent Activity

Yesterday

atanasyan committed rGe03007cb4e52: [mips] Deduce MIPS specific ELF header flags from `emulation` (authored by atanasyan).
[mips] Deduce MIPS specific ELF header flags from `emulation`
Sun, Sep 22, 9:26 AM
atanasyan committed rL372513: [mips] Deduce MIPS specific ELF header flags from `emulation`.
[mips] Deduce MIPS specific ELF header flags from `emulation`
Sun, Sep 22, 9:26 AM

Sat, Sep 21

atanasyan accepted D67756: [MIPS GlobalISel] VarArg argument lowering, select G_VASTART and vacopy.

LGTM wit a few nits

Sat, Sep 21, 2:06 PM · Restricted Project

Wed, Sep 18

atanasyan added inline comments to D66805: [MIPS] For vectors, select `add %x, C` as `sub %x, -C` if it results in inline immediate.
Wed, Sep 18, 12:32 PM · Restricted Project
atanasyan committed rG164dbd386d00: [mips] Expand 'lw/sw' instructions for 32-bit GOT (authored by atanasyan).
[mips] Expand 'lw/sw' instructions for 32-bit GOT
Wed, Sep 18, 12:20 PM
atanasyan committed rL372251: [mips] Expand 'lw/sw' instructions for 32-bit GOT.
[mips] Expand 'lw/sw' instructions for 32-bit GOT
Wed, Sep 18, 12:18 PM
atanasyan closed D67705: [mips] Expand 'lw/sw' instructions for 32-bit GOT.
Wed, Sep 18, 12:18 PM · Restricted Project
atanasyan added inline comments to D67705: [mips] Expand 'lw/sw' instructions for 32-bit GOT.
Wed, Sep 18, 11:49 AM · Restricted Project
atanasyan created D67705: [mips] Expand 'lw/sw' instructions for 32-bit GOT.
Wed, Sep 18, 6:41 AM · Restricted Project
atanasyan committed rG9c36de99caa5: [mips] Pass "xgot" flag as a subtarget feature (authored by atanasyan).
[mips] Pass "xgot" flag as a subtarget feature
Wed, Sep 18, 5:26 AM
atanasyan committed rG1ebdbad4751c: [mips] Mark tests for lw/sw expansion in PIC by a separate "check prefix". NFC (authored by atanasyan).
[mips] Mark tests for lw/sw expansion in PIC by a separate "check prefix". NFC
Wed, Sep 18, 5:26 AM
atanasyan committed rG59d0cc82b5c0: [mips] Reduce code duplication in the `loadAndAddSymbolAddress`. NFC (authored by atanasyan).
[mips] Reduce code duplication in the `loadAndAddSymbolAddress`. NFC
Wed, Sep 18, 5:25 AM
atanasyan committed rL372220: [mips] Pass "xgot" flag as a subtarget feature.
[mips] Pass "xgot" flag as a subtarget feature
Wed, Sep 18, 5:23 AM
atanasyan committed rL372219: [mips] Mark tests for lw/sw expansion in PIC by a separate "check prefix". NFC.
[mips] Mark tests for lw/sw expansion in PIC by a separate "check prefix". NFC
Wed, Sep 18, 5:23 AM
atanasyan committed rL372218: [mips] Reduce code duplication in the `loadAndAddSymbolAddress`. NFC.
[mips] Reduce code duplication in the `loadAndAddSymbolAddress`. NFC
Wed, Sep 18, 5:23 AM

Wed, Sep 11

atanasyan accepted D67441: [MIPS GlobalISel] Select indirect branch.

LGTM

Wed, Sep 11, 10:01 AM · Restricted Project
atanasyan accepted D67440: [MIPS GlobalISel] Lower G_DYN_STACKALLOC.

LGTM

Wed, Sep 11, 10:00 AM · Restricted Project
atanasyan accepted D67439: [MIPS GlobalISel] Select G_IMPLICIT_DEF.

LGTM

Wed, Sep 11, 9:51 AM · Restricted Project
atanasyan committed rGd811d9115b0b: [mips][msa] Fix infinite loop for mips.nori.b intrinsic (authored by atanasyan).
[mips][msa] Fix infinite loop for mips.nori.b intrinsic
Wed, Sep 11, 4:19 AM
atanasyan committed rL371607: [mips][msa] Fix infinite loop for mips.nori.b intrinsic.
[mips][msa] Fix infinite loop for mips.nori.b intrinsic
Wed, Sep 11, 4:15 AM
atanasyan closed D67280: [Mips][msa] Fix inifinite loop for mips.nori.b intrinsic.
Wed, Sep 11, 4:15 AM · Restricted Project

Tue, Sep 10

atanasyan accepted D67280: [Mips][msa] Fix inifinite loop for mips.nori.b intrinsic.

LGTM

Tue, Sep 10, 10:14 PM · Restricted Project
atanasyan committed rG6c6f5a998452: [mips] Allow PT_LOAD to have overlapping p_offset ranges on EM_MIPS (authored by atanasyan).
[mips] Allow PT_LOAD to have overlapping p_offset ranges on EM_MIPS
Tue, Sep 10, 1:21 PM
atanasyan committed rL371554: [mips] Allow PT_LOAD to have overlapping p_offset ranges on EM_MIPS.
[mips] Allow PT_LOAD to have overlapping p_offset ranges on EM_MIPS
Tue, Sep 10, 1:21 PM

Mon, Sep 9

atanasyan committed rG2439b8b0c5f3: [mips] Make another set of test cases more tolerant to exact symbol addresses. (authored by atanasyan).
[mips] Make another set of test cases more tolerant to exact symbol addresses.
Mon, Sep 9, 3:06 PM
atanasyan committed rL371458: [mips] Make another set of test cases more tolerant to exact symbol addresses..
[mips] Make another set of test cases more tolerant to exact symbol addresses.
Mon, Sep 9, 3:03 PM
atanasyan committed rG56e4ea2bff9e: [mips] Fix decoding of microMIPS JALX instruction (authored by atanasyan).
[mips] Fix decoding of microMIPS JALX instruction
Mon, Sep 9, 10:28 AM
atanasyan committed rL371428: [mips] Fix decoding of microMIPS JALX instruction.
[mips] Fix decoding of microMIPS JALX instruction
Mon, Sep 9, 10:28 AM
atanasyan closed D67320: [mips] Fix decoding of microMIPS JALX instruction.
Mon, Sep 9, 10:28 AM · Restricted Project

Sat, Sep 7

atanasyan created D67320: [mips] Fix decoding of microMIPS JALX instruction.
Sat, Sep 7, 9:46 AM · Restricted Project
atanasyan committed rG9443c18704ff: [mips] Follow-up to r371313 - fix failed test case. NFC (authored by atanasyan).
[mips] Follow-up to r371313 - fix failed test case. NFC
Sat, Sep 7, 9:35 AM
atanasyan committed rL371316: [mips] Follow-up to r371313 - fix failed test case. NFC.
[mips] Follow-up to r371313 - fix failed test case. NFC
Sat, Sep 7, 9:35 AM
atanasyan committed rGfcef13344db8: [mips] Make another set of test cases more tolerant to exact symbol addresses. (authored by atanasyan).
[mips] Make another set of test cases more tolerant to exact symbol addresses.
Sat, Sep 7, 8:45 AM
atanasyan added a comment to rL371174: [mips] Make another set of test cases more tolerant to exact symbol addresses..

Thanks for doing this! FileCheck checks substrings. So you can even leave out {{.*}} at the beginning of a CHECK line.

Sat, Sep 7, 8:45 AM
atanasyan committed rL371313: [mips] Make another set of test cases more tolerant to exact symbol addresses..
[mips] Make another set of test cases more tolerant to exact symbol addresses.
Sat, Sep 7, 8:43 AM

Fri, Sep 6

atanasyan committed rGff2172c9f4a0: [mips] Make another set of test cases more tolerant to exact symbol addresses. (authored by atanasyan).
[mips] Make another set of test cases more tolerant to exact symbol addresses.
Fri, Sep 6, 12:23 AM
atanasyan committed rL371174: [mips] Make another set of test cases more tolerant to exact symbol addresses..
[mips] Make another set of test cases more tolerant to exact symbol addresses.
Fri, Sep 6, 12:21 AM

Thu, Sep 5

atanasyan committed rG2172f3f49d27: [mips] Make a few test cases more tolerant to exact symbol addresses. NFC (authored by atanasyan).
[mips] Make a few test cases more tolerant to exact symbol addresses. NFC
Thu, Sep 5, 6:39 AM
atanasyan committed rL371065: [mips] Make a few test cases more tolerant to exact symbol addresses. NFC.
[mips] Make a few test cases more tolerant to exact symbol addresses. NFC
Thu, Sep 5, 6:36 AM

Wed, Sep 4

atanasyan accepted D67181: [MIPS GlobalISel] Select G_FENCE.

LGTM

Wed, Sep 4, 1:18 PM · Restricted Project
atanasyan accepted D67180: [MIPS GlobalISel] Select llvm.trap intrinsic.

LGTM

Wed, Sep 4, 1:16 PM · Restricted Project
atanasyan accepted D67179: [MIPS GlobalISel] Lower SRet pointer arguments.

LGTM

Wed, Sep 4, 1:16 PM · Restricted Project

Tue, Sep 3

atanasyan accepted D66805: [MIPS] For vectors, select `add %x, C` as `sub %x, -C` if it results in inline immediate.

LGTM

Tue, Sep 3, 5:15 AM · Restricted Project
atanasyan committed rG25d5b54542e0: [mips] Switch to the `.text` section after emitting asm file preamble (authored by atanasyan).
[mips] Switch to the `.text` section after emitting asm file preamble
Tue, Sep 3, 3:24 AM
atanasyan committed rL370735: [mips] Switch to the `.text` section after emitting asm file preamble.
[mips] Switch to the `.text` section after emitting asm file preamble
Tue, Sep 3, 3:23 AM
atanasyan closed D67014: [mips] Switch to the `.text` section after emitting asm file preamble.
Tue, Sep 3, 3:23 AM · Restricted Project
atanasyan committed rL370722: Request commit access for atanasyan.
Request commit access for atanasyan
Tue, Sep 3, 2:34 AM

Sun, Sep 1

atanasyan added a comment to D47192: [utils] Reflow asm check generation to tolerate blank lines.

What do you think about teaching UpdateTestChecks to generate CHECK-EMPTY when a line is empty?

Sun, Sep 1, 6:05 AM · Restricted Project

Fri, Aug 30

atanasyan added a comment to D62341: [DAGCombine][X86][AArch64][AMDGPU][MIPS][PPC] (sub x, c) -> (add x, -c) vector edition..

Could you rebase the patch against the master branch?

Fri, Aug 30, 11:24 AM · Restricted Project
atanasyan created D67014: [mips] Switch to the `.text` section after emitting asm file preamble.
Fri, Aug 30, 11:10 AM · Restricted Project
atanasyan committed rG68f73bf26247: [mips] Merge common checkings under the same check prefix. NFC (authored by atanasyan).
[mips] Merge common checkings under the same check prefix. NFC
Fri, Aug 30, 5:19 AM
atanasyan committed rL370467: [mips] Merge common checkings under the same check prefix. NFC.
[mips] Merge common checkings under the same check prefix. NFC
Fri, Aug 30, 5:19 AM

Thu, Aug 29

atanasyan accepted D66930: [MIPS GlobalISel] Lower uitofp.

LGTM

Thu, Aug 29, 6:57 AM · Restricted Project
atanasyan accepted D66929: [MIPS GlobalISel] Lower fptoui.

LGTM

Thu, Aug 29, 6:57 AM · Restricted Project
atanasyan committed rGb23857c14904: [mips] Inline emitStoreWithSymOffset and emitLoadWithSymOffset methods. NFC (authored by atanasyan).
[mips] Inline emitStoreWithSymOffset and emitLoadWithSymOffset methods. NFC
Thu, Aug 29, 6:22 AM
atanasyan committed rG3464b91ef731: [mips] Fix expanding `lw/sw $reg1, symbol($reg2)` instruction (authored by atanasyan).
[mips] Fix expanding `lw/sw $reg1, symbol($reg2)` instruction
Thu, Aug 29, 6:19 AM
atanasyan committed rL370354: [mips] Inline emitStoreWithSymOffset and emitLoadWithSymOffset methods. NFC.
[mips] Inline emitStoreWithSymOffset and emitLoadWithSymOffset methods. NFC
Thu, Aug 29, 6:18 AM
atanasyan committed rL370353: [mips] Fix expanding `lw/sw $reg1, symbol($reg2)` instruction.
[mips] Fix expanding `lw/sw $reg1, symbol($reg2)` instruction
Thu, Aug 29, 6:18 AM
atanasyan closed D66894: [mips] Fix expanding `lw/sw $reg1, symbol($reg2)` instruction.
Thu, Aug 29, 6:18 AM · Restricted Project

Wed, Aug 28

atanasyan added a comment to D66795: [Mips] Use appropriate private label prefix based on Mips ABI.

I would prefer always passing MCTargetOptions to MCAsmInfo too. Could you try this approach? But take a look at LLVMCreateDisasmCPUFeatures function from Disassembler.cpp. If we cannot retrieve MCTargetOptions right in this function, we will have to change "LLVM-C" interface LLVMCreateDisasmCPUFeatures function. There is an interesting comment in the D20916 - "Why not use MCTargetOptions::ABIName".

Wed, Aug 28, 11:04 PM · Restricted Project, Restricted Project, Restricted Project
atanasyan committed rG027f1da0104a: [mips] Add an empty line to separate different patterns. NFC (authored by atanasyan).
[mips] Add an empty line to separate different patterns. NFC
Wed, Aug 28, 3:36 PM
atanasyan committed rG59bb3609fa5f: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result (authored by atanasyan).
[mips] Fix 64-bit address loading in case of applying 32-bit mask to the result
Wed, Aug 28, 3:36 PM
atanasyan committed rL370269: [mips] Add an empty line to separate different patterns. NFC.
[mips] Add an empty line to separate different patterns. NFC
Wed, Aug 28, 3:36 PM
atanasyan committed rL370268: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.
[mips] Fix 64-bit address loading in case of applying 32-bit mask to the result
Wed, Aug 28, 3:36 PM
atanasyan closed D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.
Wed, Aug 28, 3:36 PM · Restricted Project
atanasyan added a comment to D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.

Thanks for review.

Wed, Aug 28, 3:36 PM · Restricted Project
atanasyan created D66894: [mips] Fix expanding `lw/sw $reg1, symbol($reg2)` instruction.
Wed, Aug 28, 9:54 AM · Restricted Project
atanasyan committed rGf46ba4f0771b: [mips] Use less registers to load address of TargetExternalSymbol (authored by atanasyan).
[mips] Use less registers to load address of TargetExternalSymbol
Wed, Aug 28, 5:36 AM
atanasyan committed rL370196: [mips] Use less registers to load address of TargetExternalSymbol.
[mips] Use less registers to load address of TargetExternalSymbol
Wed, Aug 28, 5:35 AM
atanasyan closed D66771: [mips] Use less registers to load address of TargetExternalSymbol.
Wed, Aug 28, 5:35 AM · Restricted Project

Tue, Aug 27

atanasyan added a comment to D62341: [DAGCombine][X86][AArch64][AMDGPU][MIPS][PPC] (sub x, c) -> (add x, -c) vector edition..

@atanasyan D66805 addresses all llvm/test/CodeGen/Mips/msa/arithmetic.ll regressions,
but llvm/test/CodeGen/Mips/msa/i5-s.ll one remains, i don't know what's going on there;
PTAL, thank you.

Tue, Aug 27, 9:12 AM · Restricted Project
atanasyan accepted D66533: [MIPS GlobalISel] ClampScalar G_SHL, G_ASHR and G_LSHR .

LGTM

Tue, Aug 27, 6:23 AM · Restricted Project
atanasyan accepted D66589: [GlobalISel] Factor narrowScalar for G_ASHR and G_LSHR. NFC.

LGTM

Tue, Aug 27, 6:23 AM · Restricted Project

Mon, Aug 26

atanasyan updated the diff for D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.
  • Fix SYM_32/SYM64 predicates definitions
  • Add missed patterns to load 64-bit symbol's address
Mon, Aug 26, 3:51 PM · Restricted Project
atanasyan added a parent revision for D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result: D66771: [mips] Use less registers to load address of TargetExternalSymbol.
Mon, Aug 26, 3:48 PM · Restricted Project
atanasyan added a child revision for D66771: [mips] Use less registers to load address of TargetExternalSymbol: D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.
Mon, Aug 26, 3:48 PM · Restricted Project
atanasyan created D66771: [mips] Use less registers to load address of TargetExternalSymbol.
Mon, Aug 26, 3:48 PM · Restricted Project
atanasyan committed rGd5918edf0dd3: [mips] Fix indentation. NFC (authored by atanasyan).
[mips] Fix indentation. NFC
Mon, Aug 26, 3:41 PM
atanasyan committed rGac64924a55b8: [mips] clang-format the code. NFC (authored by atanasyan).
[mips] clang-format the code. NFC
Mon, Aug 26, 3:41 PM
atanasyan committed rL369983: [mips] Fix indentation. NFC.
[mips] Fix indentation. NFC
Mon, Aug 26, 3:40 PM
atanasyan committed rL369982: [mips] clang-format the code. NFC.
[mips] clang-format the code. NFC
Mon, Aug 26, 3:40 PM

Aug 23 2019

atanasyan committed rG5f7d6ac7bf3b: [mips] Reduce number of instructions used for loading a global symbol's value (authored by atanasyan).
[mips] Reduce number of instructions used for loading a global symbol's value
Aug 23 2019, 6:39 AM
atanasyan committed rG58492b1895e2: [mips] Do not include offset into `%got` expression for global symbols (authored by atanasyan).
[mips] Do not include offset into `%got` expression for global symbols
Aug 23 2019, 6:38 AM
atanasyan committed rL369756: [mips] Reduce number of instructions used for loading a global symbol's value.
[mips] Reduce number of instructions used for loading a global symbol's value
Aug 23 2019, 6:38 AM
atanasyan committed rL369755: [mips] Do not include offset into `%got` expression for global symbols.
[mips] Do not include offset into `%got` expression for global symbols
Aug 23 2019, 6:38 AM
atanasyan closed D66552: [mips] Do not include offset into `%got` expression for global symbols.
Aug 23 2019, 6:38 AM · Restricted Project
atanasyan closed D66553: [mips] Reduce number of instructions used for loading a global symbol's value.
Aug 23 2019, 6:38 AM · Restricted Project

Aug 21 2019

atanasyan added a parent revision for D66553: [mips] Reduce number of instructions used for loading a global symbol's value: D66552: [mips] Do not include offset into `%got` expression for global symbols.
Aug 21 2019, 1:49 PM · Restricted Project
atanasyan added a child revision for D66552: [mips] Do not include offset into `%got` expression for global symbols: D66553: [mips] Reduce number of instructions used for loading a global symbol's value.
Aug 21 2019, 1:49 PM · Restricted Project
atanasyan removed a parent revision for D66553: [mips] Reduce number of instructions used for loading a global symbol's value: D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.
Aug 21 2019, 1:44 PM · Restricted Project
atanasyan removed a child revision for D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result: D66553: [mips] Reduce number of instructions used for loading a global symbol's value.
Aug 21 2019, 1:44 PM · Restricted Project
atanasyan added a reviewer for D66553: [mips] Reduce number of instructions used for loading a global symbol's value: Petar.Avramovic.
Aug 21 2019, 1:42 PM · Restricted Project
atanasyan added a reviewer for D66552: [mips] Do not include offset into `%got` expression for global symbols: Petar.Avramovic.
Aug 21 2019, 1:42 PM · Restricted Project
atanasyan added a parent revision for D66553: [mips] Reduce number of instructions used for loading a global symbol's value: D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.
Aug 21 2019, 1:41 PM · Restricted Project
atanasyan created D66553: [mips] Reduce number of instructions used for loading a global symbol's value.
Aug 21 2019, 1:41 PM · Restricted Project
atanasyan updated the summary of D66552: [mips] Do not include offset into `%got` expression for global symbols.
Aug 21 2019, 1:41 PM · Restricted Project
atanasyan added a child revision for D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result: D66553: [mips] Reduce number of instructions used for loading a global symbol's value.
Aug 21 2019, 1:41 PM · Restricted Project
atanasyan created D66552: [mips] Do not include offset into `%got` expression for global symbols.
Aug 21 2019, 1:41 PM · Restricted Project
atanasyan committed rG159f621c5c84: [mips] Replace call `expandLoadAddress` by `loadAndAddSymbolAddress`. NFC (authored by atanasyan).
[mips] Replace call `expandLoadAddress` by `loadAndAddSymbolAddress`. NFC
Aug 21 2019, 11:59 AM
atanasyan committed rGbb2f85724722: [mips] Remove duplicated case from the `StringSwitch`. NFC (authored by atanasyan).
[mips] Remove duplicated case from the `StringSwitch`. NFC
Aug 21 2019, 11:58 AM