Page MenuHomePhabricator

atanasyan (Simon Atanasyan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 6 2013, 6:15 AM (432 w, 5 d)

Recent Activity

May 5 2021

atanasyan accepted D101863: [DebugInfo][test][MIPS] Use mtriple in tests.

LGTM

May 5 2021, 1:32 AM · Restricted Project
atanasyan accepted D101342: [SelectionDAG][Mips][PowerPC][RISCV][WebAssembly] Teach computeKnownBits/ComputeNumSignBits about atomics.

The MIPS changes LGTM

May 5 2021, 1:31 AM · Restricted Project

May 3 2021

atanasyan accepted D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem.

LGTM

May 3 2021, 1:45 PM · Restricted Project

Apr 27 2021

atanasyan accepted D101381: [ELF][MIPS] Emit dynamic relocations for PIC non-preemptible static TLS.

LGTM

Apr 27 2021, 11:03 AM · Restricted Project
atanasyan accepted D101382: [ELF][MIPS] Don't emit dynamic relocations for PIE non-preemptible TLS.

LGTM

Apr 27 2021, 10:56 AM · Restricted Project

Apr 26 2021

atanasyan added inline comments to D100218: Fix for "Bug 49146 - Crash with MIPS16 multiply".
Apr 26 2021, 3:38 AM · Restricted Project

Apr 21 2021

atanasyan accepted D100949: [ELF] Update URL for MIPS TLS wiki page.

LGTM

Apr 21 2021, 6:39 AM · Restricted Project

Apr 7 2021

atanasyan accepted D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name.

AFAIK the MIPS LLVM-based toolchain mentioned in D13340 have not been implemented.

Apr 7 2021, 1:30 AM · Restricted Project

Mar 17 2021

atanasyan added a comment to D98659: [MachineCopyPropagation] Do more backward copy propagations.

I don't know why it only affects microMIPS (presumably it does its lowering subtly differently from normal MIPS) but those changes look sensible to me

Mar 17 2021, 8:13 AM · Restricted Project

Mar 11 2021

atanasyan accepted D98273: [SelectionDAG] Improve scalarization of irregular vector types.

LGTM

Mar 11 2021, 7:29 AM · Restricted Project

Mar 10 2021

atanasyan accepted D98189: [MIPS] Fix lowering of irregular vector arguments.

LGTM

Mar 10 2021, 2:37 AM · Restricted Project

Mar 9 2021

atanasyan added a comment to D98189: [MIPS] Fix lowering of irregular vector arguments.

I see. Thanks. One more question - is it possible to split the patch: one for "fixing a couple of rounding issues" and another for "Introducing a few more conversion rules"?

Mar 9 2021, 8:00 AM · Restricted Project
atanasyan added a comment to D98189: [MIPS] Fix lowering of irregular vector arguments.

I have not checked the patch carefully yet. But it looks like some tests was removed. For example MIPS64R5EL-LABEL: i8_2... Is it intended?

Mar 9 2021, 7:39 AM · Restricted Project

Feb 2 2021

atanasyan added a comment to D80392: [WIP][mips] Use pc-relative relocations in .eh_frame.

Hi guys,

any chance of this making it into 11.1.0 or 12?

Feb 2 2021, 11:48 PM · Restricted Project

Jan 18 2021

atanasyan added a comment to D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.

@ntesic Do you have commit access?

Jan 18 2021, 3:46 AM · Restricted Project, debug-info

Jan 14 2021

atanasyan accepted D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.

LGTM

Jan 14 2021, 10:44 AM · Restricted Project, debug-info
atanasyan added a reviewer for D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller: atanasyan.
Jan 14 2021, 10:43 AM · Restricted Project, debug-info

Nov 25 2020

atanasyan accepted D92090: [llvm-readelf/obj] - Stop calling `reportError` in `printArchSpecificInfo()`..

LGTM

Nov 25 2020, 7:39 AM · Restricted Project

Nov 13 2020

atanasyan committed rG7da0d0a67ffc: [MC][mips] Remove unused check prefixes. NFC (authored by atanasyan).
[MC][mips] Remove unused check prefixes. NFC
Nov 13 2020, 3:31 AM
atanasyan committed rG8fbe07a4bec2: [mips] Add tests to check disassembling of add.ps/mul.ps/sub.ps instructions (authored by atanasyan).
[mips] Add tests to check disassembling of add.ps/mul.ps/sub.ps instructions
Nov 13 2020, 3:31 AM

Nov 4 2020

atanasyan added a comment to D90570: [mips] Add a -mmips3d command line option to clang.

My bad, I missed that you implemented passing the option to backend.

Nov 4 2020, 6:09 AM · Restricted Project

Nov 2 2020

atanasyan added a comment to D90570: [mips] Add a -mmips3d command line option to clang.

What's a goal of this change? Do you want to suppress an error message when the option provided to Clang? If so, is it a real-life case?

Nov 2 2020, 1:13 AM · Restricted Project

Oct 30 2020

atanasyan committed rGfc0892c1f9a3: [mips] Implement add.ps, mul.ps and sub.ps (authored by michael-roe).
[mips] Implement add.ps, mul.ps and sub.ps
Oct 30 2020, 1:00 AM
atanasyan closed D90321: [mips] Implement add.ps, mul.ps and sub.ps.
Oct 30 2020, 12:59 AM · Restricted Project

Oct 28 2020

atanasyan accepted D90321: [mips] Implement add.ps, mul.ps and sub.ps.

LGTM with a few nits. Thanks.

Oct 28 2020, 3:21 PM · Restricted Project

Oct 12 2020

atanasyan accepted D89139: [DAG][ARM][MIPS][RISCV] Improve funnel shift promotion to use 'double shift' patterns.

MIPS changes LGTM

Oct 12 2020, 2:02 AM · Restricted Project

Oct 9 2020

atanasyan accepted D89097: [llvm-readelf/obj][test] - Stop using precompiled binary in mips-plt.test.

LGTM

Oct 9 2020, 1:37 AM · Restricted Project

Oct 6 2020

atanasyan accepted D88565: [llvm-readobj/elf][test] - Stop using precompiled binaries in mips-got.test.

LGTM. Thanks!

Oct 6 2020, 1:52 AM · Restricted Project

Sep 29 2020

atanasyan accepted D88488: [llvm-readobj][test] - Stop using few precompiled binaries in mips-got.test.

LGTM

Sep 29 2020, 8:03 AM · Restricted Project

Sep 25 2020

atanasyan committed rGc6c5629f2fb4: [CodeGen] Do not call `emitGlobalConstantLargeInt` for constant requires 8… (authored by atanasyan).
[CodeGen] Do not call `emitGlobalConstantLargeInt` for constant requires 8…
Sep 25 2020, 10:59 PM
atanasyan closed D88261: [CodeGen] Do not call `emitGlobalConstantLargeInt` for constant requires 8 bytes to store.
Sep 25 2020, 10:59 PM · Restricted Project
atanasyan accepted D88294: [obj2yaml][yaml2obj] - Stop recognizing SHT_MIPS_ABIFLAGS on non-MIPS targets..

LGTM

Sep 25 2020, 11:59 AM · Restricted Project

Sep 24 2020

atanasyan requested review of D88261: [CodeGen] Do not call `emitGlobalConstantLargeInt` for constant requires 8 bytes to store.
Sep 24 2020, 2:20 PM · Restricted Project
atanasyan accepted D88231: [Object/yaml2obj/obj2yaml][test] - Split, cleanup and move MIPS abi-flags.yaml test. NFCI..

LGTM

Sep 24 2020, 10:00 AM · Restricted Project

Sep 20 2020

atanasyan accepted D87977: [XRay] Change mips to use version 2 sled (PC-relative address).

LGTM

Sep 20 2020, 2:19 AM · Restricted Project, Restricted Project

Aug 17 2020

atanasyan accepted D86080: [llvm-readobj/elf] - Merge mips-got-overlapped.test to mips-got.test and refine testing..

LGTM

Aug 17 2020, 9:29 AM · Restricted Project

Aug 7 2020

atanasyan accepted D85515: [llvm-readobj] - Remove 3 excessive test cases..

LGTM

Aug 7 2020, 4:40 AM · Restricted Project
atanasyan accepted D85511: [llvm-readelf/obj] - Refine the implementation of printMipsReginfo()..

LGTM

Aug 7 2020, 3:01 AM · Restricted Project

Jul 29 2020

atanasyan accepted D84854: [llvm-readobj/readelf] - Refine the implementation of printMipsOptions()..

LGTM

Jul 29 2020, 9:19 AM · Restricted Project

Jul 17 2020

atanasyan accepted D84033: [llvm-readelf/readobj] - Refine the error reporting in printMipsABIFlags() methods..

LGTM. Thanks

Jul 17 2020, 9:20 AM · Restricted Project

Jul 16 2020

atanasyan accepted D83954: [llvm-readobj] - Add proper testing for the SHT_MIPS_ABIFLAGS section..

LGTM

Jul 16 2020, 1:27 PM · Restricted Project

Jul 15 2020

atanasyan added a comment to D83778: MIPS: add build time option to disable madd.fmt.

Maybe it's better to switch off generation of the madd.fmt by default if the problem is so wide spread? I'm concerned that AFAIK no one other architectures supported by LLVM has configuration options like the proposed LLVM_DISABLE_MIPS_MADD4.

Jul 15 2020, 4:56 AM · Restricted Project
atanasyan committed rG3a6c2a61c642: [mips] Rename FeatureMadd4 to FeatureNoMadd4. NFC (authored by wzssyqa).
[mips] Rename FeatureMadd4 to FeatureNoMadd4. NFC
Jul 15 2020, 4:40 AM
atanasyan closed D83780: MIPS: change FeatureMadd4 to FeatureNoMadd4.
Jul 15 2020, 4:40 AM · Restricted Project

Jul 14 2020

atanasyan accepted D83780: MIPS: change FeatureMadd4 to FeatureNoMadd4.

Do you have commit access?

Jul 14 2020, 9:11 AM · Restricted Project

Jul 6 2020

atanasyan accepted D83225: [llvm-readobj] - Refactor the MipsGOTParser<ELFT> to stop using report_fatal_error()..

LGTM. Thanks

Jul 6 2020, 1:18 PM · Restricted Project

Jun 19 2020

atanasyan accepted D81908: [Mips] Error if a non-immediate operand is used while an immediate is expected.

Do you have commit access?

Jun 19 2020, 11:58 AM · Restricted Project

Jun 16 2020

atanasyan added a comment to D81908: [Mips] Error if a non-immediate operand is used while an immediate is expected.

Does this patch depend on D81919?

No!

Jun 16 2020, 6:04 AM · Restricted Project
atanasyan added a comment to D81908: [Mips] Error if a non-immediate operand is used while an immediate is expected.

Does this patch depend on D81919?

Jun 16 2020, 4:58 AM · Restricted Project
atanasyan added a comment to D81919: [MIPS64] Workaround fixup_Mips_32 for getExprOpValue.

Please include context in all patches sent to review.
To get a full diff, use one of the following commands:

git show HEAD -U999999 > mypatch.patch
git diff -U999999 @{u} > mypatch.patch
git diff HEAD~1 -U999999 > mypatch.patch

https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Jun 16 2020, 4:58 AM · Restricted Project

Jun 3 2020

atanasyan updated subscribers of D80392: [WIP][mips] Use pc-relative relocations in .eh_frame.
Jun 3 2020, 2:43 AM · Restricted Project

Jun 2 2020

atanasyan committed rGb00f0d4238cb: [mips] Support 64-bit relative relocations (authored by atanasyan).
[mips] Support 64-bit relative relocations
Jun 2 2020, 2:13 AM
atanasyan closed D80390: [mips] Support 64-bit relative relocations.
Jun 2 2020, 2:12 AM · Restricted Project
atanasyan added a comment to D80392: [WIP][mips] Use pc-relative relocations in .eh_frame.

I cannot select default behaviour for the LLVM in case of generating .eh_frame sections for MIPS:

  1. Unconditionally use pc-relative relocations.
  2. Use pc-relative relocations by default, but provide options for switching to absolute relocations.
  3. Use absolute relocations by default, but provide options for switching to pc-relative relocations.
Jun 2 2020, 2:12 AM · Restricted Project
atanasyan updated the diff for D80390: [mips] Support 64-bit relative relocations.

Thanks for review, testing and comments.

Jun 2 2020, 1:04 AM · Restricted Project
atanasyan retitled D80390: [mips] Support 64-bit relative relocations from [WIP][mips] Support 64-bit relative relocations to [mips] Support 64-bit relative relocations.
Jun 2 2020, 1:04 AM · Restricted Project

May 22 2020

atanasyan added a comment to D80390: [mips] Support 64-bit relative relocations.
  • .quad foo - . is representable
  • ld.so supports such relocation chain.
  • D78590 can be fixed for MIPS
  • D72228 can get rid of the FDECFIEncoding = dwarf::DW_EH_PE_pcrel | dwarf::DW_EH_PE_sdata4; hack
  • For various relocation processing tool, it supporting a relocation chain as easy as supporting an addition relocation type (R_MIPS_PC64), by, adding case R_MIPS_PC64:?
May 22 2020, 1:13 AM · Restricted Project
atanasyan added a reviewer for D80421: [Mips] use correct ld.so for musl soft float: atanasyan.
  1. Please include as much context as possible with your diff. This instruction helps to do that.
  2. Such patch needs test case(s). Maybe it's enough to update the linux-ld.c test case which is failed now. Update failed cases and check both "soft" and "hard" float cases in this test.
May 22 2020, 12:01 AM · Restricted Project

May 21 2020

atanasyan committed rGc7923e7705d0: [mips] Reorganize check directives in the test. NFC (authored by atanasyan).
[mips] Reorganize check directives in the test. NFC
May 21 2020, 11:22 AM
atanasyan created D80390: [mips] Support 64-bit relative relocations.
May 21 2020, 11:21 AM · Restricted Project
atanasyan created D80392: [WIP][mips] Use pc-relative relocations in .eh_frame.
May 21 2020, 11:21 AM · Restricted Project

May 13 2020

atanasyan committed rG524457edbc3d: [mips] Fix typo in FileCheck directives - replace \0xa0 char by space. NFC (authored by atanasyan).
[mips] Fix typo in FileCheck directives - replace \0xa0 char by space. NFC
May 13 2020, 2:39 AM

May 7 2020

atanasyan accepted D78108: [CSInfo][MIPS] Describe parameter value loaded by ADDiu instruction.

Looks good overall, just a few nits inline.

May 7 2020, 11:16 PM · Restricted Project, debug-info

May 1 2020

atanasyan accepted D79270: [test] Fix lld's ELF/linkerscript/thunk-gen-mips.s.

Initially the test case just checks that LLD does not crash under some conditions. It's not mandatory to test exact symbols' values and/or offsets between symbols. But after this fix the test additionally becomes more tolerant to exact symbol addresses. It's fine.
As to me, I'd remove the "Ideally we'd use..." comment.

May 1 2020, 11:25 PM · Restricted Project

Apr 24 2020

atanasyan committed rG0eec6662f669: [MC][mips] Replace setRType## methods by single setRTypes function. NFC (authored by atanasyan).
[MC][mips] Replace setRType## methods by single setRTypes function. NFC
Apr 24 2020, 2:41 AM

Apr 3 2020

atanasyan committed rGf22445bf5760: [mips][test] Remove redundant and invalid `CHECK-NOT` directives. NFC (authored by atanasyan).
[mips][test] Remove redundant and invalid `CHECK-NOT` directives. NFC
Apr 3 2020, 6:58 AM
atanasyan added a comment to D77354: [DO NOT MERGE] added FileCheck colons that broke things.

I have fixed MIPS-related mistakes at rGf22445b. Thanks for finding them.

Apr 3 2020, 6:57 AM · Restricted Project

Mar 27 2020

atanasyan added inline comments to D76842: [Mips] Make MipsBranchExpansion::replaceBranch() aware of BBIT family of branch.
Mar 27 2020, 2:52 PM · Restricted Project
atanasyan accepted D76842: [Mips] Make MipsBranchExpansion::replaceBranch() aware of BBIT family of branch.

LGTM. Two nits inlined.

Mar 27 2020, 1:43 PM · Restricted Project

Mar 22 2020

atanasyan added a comment to D76247: [MIPS] Implement MIPS3D vector instructions..

Thanks for the catching the issues.

Mar 22 2020, 2:28 PM · Restricted Project
atanasyan committed rG2dc4eb08cd99: [mips] Implement .cpadd directive (authored by atanasyan).
[mips] Implement .cpadd directive
Mar 22 2020, 1:56 PM
atanasyan committed rG9bbddfbeaabd: [mips] Implement sne pseudo instruction (authored by atanasyan).
[mips] Implement sne pseudo instruction
Mar 22 2020, 1:56 PM
atanasyan committed rG862f120fdb0e: [mips] Remove instructions related to "wired paired single" from the P5600… (authored by atanasyan).
[mips] Remove instructions related to "wired paired single" from the P5600…
Mar 22 2020, 1:56 PM
atanasyan committed rGdca9e40c0cf8: [mips] Implement sle/sleu pseudo instructions (authored by atanasyan).
[mips] Implement sle/sleu pseudo instructions
Mar 22 2020, 1:56 PM
atanasyan committed rGecc92fd018c6: [mips] Add HasMips3D to the list of features unsupported by P5600 model. (authored by atanasyan).
[mips] Add HasMips3D to the list of features unsupported by P5600 model.
Mar 22 2020, 1:56 PM
atanasyan committed rG0f15ace018bf: [mips] Rename target feature Mips3D => HasMips3D. NFC (authored by atanasyan).
[mips] Rename target feature Mips3D => HasMips3D. NFC
Mar 22 2020, 1:56 PM

Mar 17 2020

atanasyan committed rG73b1da160513: [MIPS] Implement MIPS3D vector instructions (authored by atanasyan).
[MIPS] Implement MIPS3D vector instructions
Mar 17 2020, 7:26 AM
atanasyan closed D76247: [MIPS] Implement MIPS3D vector instructions..
Mar 17 2020, 7:26 AM · Restricted Project
atanasyan accepted D76247: [MIPS] Implement MIPS3D vector instructions..

LGTM

Mar 17 2020, 7:25 AM · Restricted Project

Mar 15 2020

atanasyan committed rGe0ab0e6a281f: [MIPS] Implement PUL.PS and PUU.PS instructions (authored by atanasyan).
[MIPS] Implement PUL.PS and PUU.PS instructions
Mar 15 2020, 11:42 PM
atanasyan closed D75812: [MIPS] Implement PUL.PS and PUU.PS instructions.
Mar 15 2020, 11:42 PM · Restricted Project

Mar 13 2020

atanasyan accepted D75812: [MIPS] Implement PUL.PS and PUU.PS instructions.

LGTM Thanks for the patch.

Mar 13 2020, 3:40 PM · Restricted Project

Mar 8 2020

atanasyan requested changes to D75812: [MIPS] Implement PUL.PS and PUU.PS instructions.

The following test cases failed on my machine. Initially, assembler shows error: unknown instruction. Now assembler shows correct error message instruction requires a CPU feature not currently enabled and the checks should be updated and moved to invalid-xxx.s files.

MC/Mips/mips1/invalid-mips5-wrong-error.s
MC/Mips/mips2/invalid-mips5-wrong-error.s
MC/Mips/mips3/invalid-mips5-wrong-error.s
MC/Mips/mips4/invalid-mips5-wrong-error.s
MC/Mips/mips64r6/invalid-mips5-wrong-error.s
Mar 8 2020, 5:50 AM · Restricted Project

Feb 27 2020

atanasyan added inline comments to D75216: [lld][ELF] Add some release notes.
Feb 27 2020, 12:21 AM · Restricted Project

Feb 26 2020

atanasyan added inline comments to D75216: [lld][ELF] Add some release notes.
Feb 26 2020, 10:08 PM · Restricted Project

Feb 16 2020

atanasyan accepted D74624: [MIPS GlobalISel] Select 4 byte unaligned load and store.

LGTM

Feb 16 2020, 10:13 PM · Restricted Project
atanasyan accepted D74625: [MIPS GlobalISel] Legalize non-power-of-2 and unaligned load and store.

LGTM

Feb 16 2020, 10:13 PM · Restricted Project
atanasyan accepted D74623: [MIPS GlobalISel] RegBankSelect G_MERGE_VALUES and G_UNMERGE_VALUES.

LGTM

Feb 16 2020, 10:13 PM · Restricted Project

Feb 10 2020

atanasyan accepted D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores..

Looking good to me as-is.

Feb 10 2020, 4:26 AM · Restricted Project, Restricted Project

Feb 6 2020

atanasyan added a comment to D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores..

I see, thanks. Is there the same or similar functionality in GCC?

Feb 6 2020, 8:34 AM · Restricted Project, Restricted Project

Jan 30 2020

atanasyan added a comment to D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores..

Is it possible to emulate these new intrinsics using existing ones and some additional code? Is code generated in this case much larger/slower then the code generated by the new intrinsics?

Jan 30 2020, 5:17 AM · Restricted Project, Restricted Project

Jan 29 2020

atanasyan accepted D73648: Don't mark MIPS TRAP as isTerminator.

LGTM
Thanks

Jan 29 2020, 2:35 PM · Restricted Project

Jan 27 2020

atanasyan accepted D73489: [mips][NFC] Remove unused instruction formats.

LGTM
Thanks

Jan 27 2020, 11:55 AM · Restricted Project

Jan 26 2020

atanasyan closed D73108: [docs][mips] 10.0 Release notes.

Closed by commit rG27f93515.

Jan 26 2020, 6:16 AM · Restricted Project, Restricted Project
atanasyan committed rG27f93515c68b: [docs][mips] 10.0 Release notes (authored by atanasyan).
[docs][mips] 10.0 Release notes
Jan 26 2020, 6:11 AM

Jan 25 2020

atanasyan accepted D73214: [MIPS GlobalISel] Select count leading zeros.

LGTM

Jan 25 2020, 1:51 AM · Restricted Project

Jan 23 2020

atanasyan accepted D73215: [MIPS GlobalISel] Select count trailing zeros.

LGTM

Jan 23 2020, 6:39 AM · Restricted Project
atanasyan accepted D73216: [MIPS GlobalISel] Select population count (popcount).

LGTM

Jan 23 2020, 5:44 AM · Restricted Project
atanasyan added inline comments to D73214: [MIPS GlobalISel] Select count leading zeros.
Jan 23 2020, 4:59 AM · Restricted Project
atanasyan added inline comments to D73214: [MIPS GlobalISel] Select count leading zeros.
Jan 23 2020, 4:41 AM · Restricted Project