atanasyan (Simon Atanasyan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 6 2013, 6:15 AM (289 w, 6 d)

Recent Activity

Today

atanasyan added a comment to D52290: [driver][mips] Adjust target triple accordingly to provided ABI name.

Ping?

Tue, Sep 25, 3:51 AM

Yesterday

atanasyan created D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected.
Mon, Sep 24, 7:20 AM

Fri, Sep 21

atanasyan committed rL342799: [mips] Provide more detailed description for MIPS targets. NFC.
[mips] Provide more detailed description for MIPS targets. NFC
Fri, Sep 21, 11:08 PM
atanasyan committed rL342798: [mips] Remove obsoleted "experimental" tag from MIPS 64-bit targets. NFC.
[mips] Remove obsoleted "experimental" tag from MIPS 64-bit targets. NFC
Fri, Sep 21, 11:08 PM

Thu, Sep 20

atanasyan added a comment to D52045: [Mips][FastISel] Fix selectBranch on icmp i1.

Do you have commit access?

Thu, Sep 20, 4:46 AM
atanasyan requested changes to D51464: clang: fix MIPS/N32 triple and paths.

This patch fails the following test cases:

Thu, Sep 20, 4:39 AM
atanasyan accepted D52045: [Mips][FastISel] Fix selectBranch on icmp i1.

LGTM

Thu, Sep 20, 3:55 AM
atanasyan added a comment to D50857: llvm: Add support MIPS r6 Debian triples.

Looks good. Thanks. There are a couple notes only:

  • Let's extend existing triple unit tests and check that Triple::getSubArch() returns Triple::NoSubArch for non-R6 architectures.
  • I think it's redundant to add R6 target triple to so many "invalid.s" test cases. We check parsing of a target triple by unit tests. It's enough to take a few MIPS MC or CodeGen tests which use combination of non-R6 target triple and -mcpu=mips32r6 argument, remove -mcpu and replace target triple to R6 variant.
Thu, Sep 20, 3:21 AM
atanasyan created D52290: [driver][mips] Adjust target triple accordingly to provided ABI name.
Thu, Sep 20, 2:13 AM

Wed, Sep 19

atanasyan committed rL342572: [mips][microMIPS] Extending size reduction pass with MOVEP.
[mips][microMIPS] Extending size reduction pass with MOVEP
Wed, Sep 19, 11:48 AM
atanasyan closed D52037: [MIPS][MicroMIPS] Extending size reduction pass with MOVEP.
Wed, Sep 19, 11:48 AM
atanasyan committed rL342571: [mips][microMIPS] Fix the definition of MOVEP instruction.
[mips][microMIPS] Fix the definition of MOVEP instruction
Wed, Sep 19, 11:48 AM
atanasyan closed D52035: [MIPS][MicroMIPS] Fix the definition of MOVEP instruction.
Wed, Sep 19, 11:48 AM
atanasyan accepted D52035: [MIPS][MicroMIPS] Fix the definition of MOVEP instruction.

LGTM. Thanks for the patch.

Wed, Sep 19, 11:47 AM

Tue, Sep 18

atanasyan accepted D52037: [MIPS][MicroMIPS] Extending size reduction pass with MOVEP.

Do you have commit access?

Tue, Sep 18, 8:06 AM
atanasyan added a comment to D52035: [MIPS][MicroMIPS] Fix the definition of MOVEP instruction.

Could that be tested somehow?

Tue, Sep 18, 8:06 AM
atanasyan added inline comments to D50857: llvm: Add support MIPS r6 Debian triples.
Tue, Sep 18, 1:14 AM

Mon, Sep 17

atanasyan added a comment to D51408: llvm: Fix MIPS N32 triples support.

Thanks for the patch.

Mon, Sep 17, 2:32 PM
atanasyan committed rL342416: [mips] Fix MIPS N32 ABI triples support.
[mips] Fix MIPS N32 ABI triples support
Mon, Sep 17, 2:24 PM
atanasyan closed D51408: llvm: Fix MIPS N32 triples support.
Mon, Sep 17, 2:24 PM

Thu, Sep 13

atanasyan created D52027: [llvm-readobj] Print ELF header flags names in GNU output.
Thu, Sep 13, 5:34 AM
atanasyan committed rL342119: [mips] Enable the mnemonic spell corrector.
[mips] Enable the mnemonic spell corrector
Thu, Sep 13, 1:39 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Thu, Sep 13, 1:39 AM

Tue, Sep 11

atanasyan committed rL341952: [MIPS] Fix illegal type assert in single-float mode.
[MIPS] Fix illegal type assert in single-float mode
Tue, Sep 11, 8:37 AM
atanasyan closed D51810: [MIPS] Fix illegal type assert in single-float mode.
Tue, Sep 11, 8:37 AM
atanasyan accepted D51810: [MIPS] Fix illegal type assert in single-float mode.

LGTM. Thanks. Do you have commit access?

Tue, Sep 11, 5:56 AM
atanasyan committed rL341919: [mips] Add a pattern for 64-bit GPR variant of the `rdhwr` instruction.
[mips] Add a pattern for 64-bit GPR variant of the `rdhwr` instruction
Tue, Sep 11, 2:59 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Tue, Sep 11, 2:59 AM

Sun, Sep 9

atanasyan added inline comments to D51810: [MIPS] Fix illegal type assert in single-float mode.
Sun, Sep 9, 2:08 PM

Sat, Sep 8

atanasyan accepted D51684: [mips] Correct MUL pattern for mips64.

LGTM

Sat, Sep 8, 10:34 PM
atanasyan accepted D51489: [MIPS GlobalISel] Select icmp.

LGTM

Sat, Sep 8, 10:32 PM

Fri, Sep 7

atanasyan created D51773: [mips] Add a pattern for 64-bit GPR variant of the `rdhwr` instruction.
Fri, Sep 7, 12:50 AM

Mon, Sep 3

atanasyan committed rL341338: [mips] Disable the selection of mixed microMIPS/MIPS code.
[mips] Disable the selection of mixed microMIPS/MIPS code
Mon, Sep 3, 1:51 PM
atanasyan closed D51483: [mips] Disable the selection of mixed microMIPS/MIPS code.
Mon, Sep 3, 1:51 PM

Sat, Sep 1

atanasyan added a comment to D50850: clang: Add triples support for MIPS r6.

Could you please include more context to patches sent for review?
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Sat, Sep 1, 12:44 AM
atanasyan added a comment to D51464: clang: fix MIPS/N32 triple and paths.

Could you please include more context to patches sent for review?
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Sat, Sep 1, 12:32 AM
atanasyan accepted D51408: llvm: Fix MIPS N32 triples support.

LGTM

Sat, Sep 1, 12:07 AM

Fri, Aug 31

atanasyan added inline comments to D50857: llvm: Add support MIPS r6 Debian triples.
Fri, Aug 31, 11:55 PM
atanasyan added a comment to D51483: [mips] Disable the selection of mixed microMIPS/MIPS code.

It seems that I cannot apply this patch without applying D51482 first, because that patch introduces the test file.
They should be either decoupled or made dependent on phabricator to indicate the relation.

Fri, Aug 31, 9:12 AM
atanasyan added a comment to D51482: [mips] Fix `mtc1` and `mfc1` definitions for microMIPS R6.

Thanks for review.

Fri, Aug 31, 8:59 AM
atanasyan committed rL341221: [mips] Fix `mtc1` and `mfc1` definitions for microMIPS R6.
[mips] Fix `mtc1` and `mfc1` definitions for microMIPS R6
Fri, Aug 31, 8:58 AM
atanasyan closed D51482: [mips] Fix `mtc1` and `mfc1` definitions for microMIPS R6.
Fri, Aug 31, 8:58 AM
atanasyan added a comment to D51356: [docs][mips] Clang 7.0 Release notes.

Thanks for review.

Fri, Aug 31, 4:29 AM
atanasyan committed rL341203: [docs][mips] 7.0 Release notes.
[docs][mips] 7.0 Release notes
Fri, Aug 31, 4:28 AM
atanasyan closed D51355: [docs][mips] 7.0 Release notes.
Fri, Aug 31, 4:28 AM
atanasyan committed rL341201: [docs][mips] Clang 7.0 Release notes.
[docs][mips] Clang 7.0 Release notes
Fri, Aug 31, 4:27 AM
atanasyan closed D51356: [docs][mips] Clang 7.0 Release notes.
Fri, Aug 31, 4:27 AM

Thu, Aug 30

atanasyan created D51483: [mips] Disable the selection of mixed microMIPS/MIPS code.
Thu, Aug 30, 3:31 AM
atanasyan created D51482: [mips] Fix `mtc1` and `mfc1` definitions for microMIPS R6.
Thu, Aug 30, 3:30 AM

Wed, Aug 29

atanasyan committed rL340932: [mips] Fix microMIPS unconditional branch offset handling.
[mips] Fix microMIPS unconditional branch offset handling
Wed, Aug 29, 7:55 AM
atanasyan closed D50615: [mips] Fix microMIPS unconditional branch offset handling.
Wed, Aug 29, 7:55 AM
atanasyan committed rL340931: [mips] Involves microMIPS's jump in the analyzable branch set.
[mips] Involves microMIPS's jump in the analyzable branch set
Wed, Aug 29, 7:55 AM
atanasyan closed D50613: [mips] Involves microMIPS's jump in the analyzable branch set.
Wed, Aug 29, 7:55 AM
atanasyan added inline comments to D51408: llvm: Fix MIPS N32 triples support.
Wed, Aug 29, 2:29 AM
atanasyan closed D51358: [driver] Do not pass "-flavor old-gnu" option to LLD linker.

Fixed by rL340845.

Wed, Aug 29, 1:08 AM
atanasyan accepted D50986: [mips] Prevent shrink-wrap for BuildPairF64, ExtractElementF64 when they use $sp.

LGTM

Wed, Aug 29, 1:01 AM

Tue, Aug 28

atanasyan created D51358: [driver] Do not pass "-flavor old-gnu" option to LLD linker.
Tue, Aug 28, 7:49 AM
atanasyan created D51356: [docs][mips] Clang 7.0 Release notes.
Tue, Aug 28, 7:00 AM
atanasyan created D51355: [docs][mips] 7.0 Release notes.
Tue, Aug 28, 6:59 AM
atanasyan added a comment to D50857: llvm: Add support MIPS r6 Debian triples.

It would be nice to split this patch - the first one introduces new R6 target triples, the second one fixes N32 ABI handling.

Tue, Aug 28, 2:38 AM
atanasyan added a comment to D51234: [Driver] Change MipsLinux default linker from "lld" to "ld.lld".

If this piece of code used to be working correctly, there is another piece of code that adds -flavor ld to the command line. But if that's the case, this change wouldn't work because it constructs something like "ld.lld -flavor ld ...". ld.lld doesn't accept -flavor option.

So my guess is this code is dead. Or, am I missing something?

Tue, Aug 28, 2:04 AM
atanasyan committed rL340803: [docs][mips] Add MIPS specific release notes for LLD 7.0.
[docs][mips] Add MIPS specific release notes for LLD 7.0
Tue, Aug 28, 1:27 AM
atanasyan closed D51309: [docs][mips] Add MIPS specific release notes for LLD 7.0.
Tue, Aug 28, 1:26 AM · lld

Mon, Aug 27

atanasyan created D51309: [docs][mips] Add MIPS specific release notes for LLD 7.0.
Mon, Aug 27, 8:34 AM · lld

Aug 26 2018

atanasyan accepted D51234: [Driver] Change MipsLinux default linker from "lld" to "ld.lld".

LGTM

Aug 26 2018, 12:08 AM
atanasyan accepted D51213: [MIPS GlobalISel] Legalize i8 and i16 add.

LGTM

Aug 26 2018, 12:05 AM

Aug 23 2018

atanasyan added a comment to D51031: [MIPS GlobalISel] Lower i8 and i16 arguments.

Let's commit.

Aug 23 2018, 8:13 AM
atanasyan accepted D50578: [DAGCombiner][Mips] Don't combine bitcast+store after LegalOperations when the store is volatile, if the resulting store isn't Legal.

LGTM
MIPS code becomes a bit longer, but I think it can be fixed in the future.

Aug 23 2018, 1:13 AM

Aug 22 2018

atanasyan added a comment to D50615: [mips] Fix microMIPS unconditional branch offset handling.

Ping?

Aug 22 2018, 2:45 AM
atanasyan added a comment to D50613: [mips] Involves microMIPS's jump in the analyzable branch set.

Ping?

Aug 22 2018, 2:45 AM
atanasyan accepted D51031: [MIPS GlobalISel] Lower i8 and i16 arguments.

LGTM with minor nit

Aug 22 2018, 12:11 AM

Aug 21 2018

atanasyan accepted D50557: [clang][mips] Set __mips_fpr correctly for -mfpxx.

LGTM

Aug 21 2018, 6:28 AM
atanasyan accepted D50757: [mips] Handle missing CondCodes.

LGTM

Aug 21 2018, 3:10 AM

Aug 20 2018

atanasyan accepted D50853: [zorg][mips] Update build failure email address to wavecomp.com.

LGTM

Aug 20 2018, 7:17 AM
atanasyan added inline comments to D50557: [clang][mips] Set __mips_fpr correctly for -mfpxx.
Aug 20 2018, 7:04 AM
atanasyan accepted D50183: [MIPS GlobalISel] Select bitwise instructions.

LGTM

Aug 20 2018, 4:21 AM
atanasyan added inline comments to D50757: [mips] Handle missing CondCodes.
Aug 20 2018, 4:03 AM

Aug 18 2018

atanasyan added a comment to D50850: clang: Add triples support for MIPS r6.

Could you add test cases to cover these changes?

Aug 18 2018, 1:27 PM
atanasyan added a comment to D50857: llvm: Add support MIPS r6 Debian triples.

Could you add test cases to cover these changes?

Aug 18 2018, 1:06 PM

Aug 16 2018

atanasyan added a comment to D50612: Remove dead code from MipsPassConfig.

Thanks for the patch.

Aug 16 2018, 1:45 AM
atanasyan committed rL339847: [mips] Remove dead code from MipsPassConfig.
[mips] Remove dead code from MipsPassConfig
Aug 16 2018, 1:44 AM
atanasyan closed D50612: Remove dead code from MipsPassConfig.
Aug 16 2018, 1:44 AM

Aug 15 2018

atanasyan accepted D50612: Remove dead code from MipsPassConfig.

LGTM
Do you have commit access?

Aug 15 2018, 11:26 PM
atanasyan added inline comments to D50183: [MIPS GlobalISel] Select bitwise instructions.
Aug 15 2018, 10:20 PM
atanasyan added a comment to D50557: [clang][mips] Set __mips_fpr correctly for -mfpxx.

Any test cases?

Aug 15 2018, 10:13 PM

Aug 14 2018

atanasyan accepted D50437: [mips] Implement pll.ps, plu.ps and some of the missing cvt.* instructions.

LGTM

Aug 14 2018, 10:42 PM
atanasyan accepted D50243: [libunwind][mips] Include gcc_s for linkage.

LGTM from MIPS point of view.

Aug 14 2018, 10:34 PM
atanasyan added inline comments to D50183: [MIPS GlobalISel] Select bitwise instructions.
Aug 14 2018, 10:29 PM

Aug 12 2018

atanasyan updated the diff for D50615: [mips] Fix microMIPS unconditional branch offset handling.
  • Fixed test case
Aug 12 2018, 11:16 PM
atanasyan created D50615: [mips] Fix microMIPS unconditional branch offset handling.
Aug 12 2018, 1:10 PM
atanasyan created D50613: [mips] Involves microMIPS's jump in the analyzable branch set.
Aug 12 2018, 12:15 PM

Aug 3 2018

atanasyan accepted D50244: [libunwind][mips] Guard accumulator registers.

LGTM

Aug 3 2018, 4:16 PM
atanasyan accepted D50245: [libunwind][mips] Modify the __mips_fpr macro check.

LGTM

Aug 3 2018, 4:15 PM

Aug 1 2018

atanasyan accepted D49487: [mips] Fix compile options for tramp3d-v4 test.

LGTM

Aug 1 2018, 8:15 AM

Jul 31 2018

atanasyan accepted D49803: [MIPS GlobalISel] Select global address.

LGTM with a nit.

Jul 31 2018, 6:41 AM

Jul 29 2018

atanasyan added a comment to D49487: [mips] Fix compile options for tramp3d-v4 test.

I forget that tramp3d-v4 test case consists a single file and this file is big enough. Could you apply the same changes to the CMakeLists.txt?

Jul 29 2018, 10:40 PM
atanasyan accepted D49289: [mips64][clang] Provide the signext attribute for i32 return values.

LGTM

Jul 29 2018, 1:56 AM
atanasyan accepted D49939: [ASAN] Use the correct shadow offset for ASAN on FreeBSD/mips64..

LGTM

Jul 29 2018, 1:48 AM

Jul 26 2018

atanasyan accepted D48374: [mips] Sign extend i32 return values on MIPS64.

LGTM

Jul 26 2018, 2:59 AM

Jul 25 2018

atanasyan committed rL337893: [mips] Replace custom parsing logic for data directives by the….
[mips] Replace custom parsing logic for data directives by the…
Jul 25 2018, 12:08 AM