atanasyan (Simon Atanasyan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 6 2013, 6:15 AM (272 w, 2 d)

Recent Activity

Thu, May 24

atanasyan created D47316: [mips] Support 64-bit offsets for lb/sb/ld/sd/lld ... instructions.
Thu, May 24, 4:20 AM
atanasyan committed rL333164: [mips] Remove duplicated code from the expandLoadInst. NFC.
[mips] Remove duplicated code from the expandLoadInst. NFC
Thu, May 24, 12:40 AM
atanasyan committed rL333163: [mips] Remove redundant argument from expandLoadInst/expandStoreInst. NFC.
[mips] Remove redundant argument from expandLoadInst/expandStoreInst. NFC
Thu, May 24, 12:40 AM
atanasyan committed rL333162: [mips] Add precondition asserts to the expandLoadInst/expandStoreInst. NFC.
[mips] Add precondition asserts to the expandLoadInst/expandStoreInst. NFC
Thu, May 24, 12:40 AM
atanasyan committed rL333161: [mips] Cleanup the code a bit. NFC.
[mips] Cleanup the code a bit. NFC
Thu, May 24, 12:39 AM

Wed, May 23

atanasyan accepted D47255: [mips] Fix the definitions of lwp, swp.

LGTM with a nit.

Wed, May 23, 7:53 AM

Tue, May 22

atanasyan added a comment to D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.

Ping?

Tue, May 22, 10:05 PM · lld
atanasyan added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

Ping?

Tue, May 22, 10:05 PM · lld
atanasyan created D47220: [mips] Emit R_MICROMIPS_GPREL16/R_MICROMIPS_SUB/R_MICROMIPS_LO16 / HI16 relocations.
Tue, May 22, 1:01 PM
atanasyan created D47219: [mips] Emit R_MICROMIPS_HIGHER / R_MICROMIPS_HIGHEST relocations.
Tue, May 22, 12:58 PM

Sun, May 20

atanasyan accepted D46948: [mips] Add microMIPSR6 ll/sc instructions..

LGTM

Sun, May 20, 2:27 AM
atanasyan accepted D47075: [mips] Correct the predicates of arithmetic and logic instructions..

LGTM

Sun, May 20, 12:43 AM

Thu, May 17

atanasyan accepted D46956: [mips] Correct the predicates of arithmetic and logic instructions..

LGTM

Thu, May 17, 8:59 AM
atanasyan accepted D46949: [mips] Correct the predicates of the cache and pref instructions.

LGTM

Thu, May 17, 8:47 AM
atanasyan accepted D46947: [mips] Correct the predicates for a number of instructions..

LGTM

Thu, May 17, 6:50 AM

Tue, May 15

atanasyan added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

Ping?

Tue, May 15, 5:29 AM · lld
atanasyan added a comment to D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.

Ping?

Tue, May 15, 5:29 AM · lld

Mon, May 14

atanasyan accepted D46702: [mips] Mark select instructions correctly.

LGTM

Mon, May 14, 7:13 AM
atanasyan accepted D46691: [mips] Fix the predicates of round, ceiling, floor and trunc..

LGTM

Mon, May 14, 3:53 AM

Thu, May 10

atanasyan accepted D46692: [mips] Fix predicates of mfc1, mtc1 instructions.

LGTM

Thu, May 10, 10:59 PM
atanasyan accepted D46689: [mips] Correct the predicates of indexed floating point stores and loads..

LGTM

Thu, May 10, 10:14 PM
atanasyan committed rL331997: [mips] Accept 32-bit offsets for ld/sd/lld commands.
[mips] Accept 32-bit offsets for ld/sd/lld commands
Thu, May 10, 9:05 AM
atanasyan closed D46629: [mips] Accept 32-bit offsets for ld/sd/lld commands.
Thu, May 10, 9:05 AM
atanasyan added a comment to D46629: [mips] Accept 32-bit offsets for ld/sd/lld commands.

Thanks for review.

Thu, May 10, 9:05 AM
atanasyan added a comment to D46513: [mips] Accept 32-bit offsets for lh and lhu commands.

Thanks for review.

Thu, May 10, 9:05 AM
atanasyan committed rL331996: [mips] Accept 32-bit offsets for lh and lhu commands.
[mips] Accept 32-bit offsets for lh and lhu commands
Thu, May 10, 9:05 AM
atanasyan closed D46513: [mips] Accept 32-bit offsets for lh and lhu commands.
Thu, May 10, 9:04 AM
atanasyan committed rL331995: [ELF][MIPS] Add test case to check some microMIPS R6 relocations. NFC.
[ELF][MIPS] Add test case to check some microMIPS R6 relocations. NFC
Thu, May 10, 9:00 AM
atanasyan committed rLLD331995: [ELF][MIPS] Add test case to check some microMIPS R6 relocations. NFC.
[ELF][MIPS] Add test case to check some microMIPS R6 relocations. NFC
Thu, May 10, 9:00 AM
atanasyan committed rL331994: [ELF][MIPS] Add test case to check N32 ABI PLT generation. NFC.
[ELF][MIPS] Add test case to check N32 ABI PLT generation. NFC
Thu, May 10, 9:00 AM
atanasyan committed rLLD331994: [ELF][MIPS] Add test case to check N32 ABI PLT generation. NFC.
[ELF][MIPS] Add test case to check N32 ABI PLT generation. NFC
Thu, May 10, 9:00 AM

Wed, May 9

atanasyan added a comment to D46450: [Driver] Add mips_Features_Group to Options to improve documentation sorting.

Committed at rL331856.

Wed, May 9, 1:47 AM
atanasyan committed rC331856: [driver] Add mips_Features_Group to Options to improve documentation sorting.
[driver] Add mips_Features_Group to Options to improve documentation sorting
Wed, May 9, 1:46 AM
atanasyan committed rL331856: [driver] Add mips_Features_Group to Options to improve documentation sorting.
[driver] Add mips_Features_Group to Options to improve documentation sorting
Wed, May 9, 1:46 AM
atanasyan closed D46450: [Driver] Add mips_Features_Group to Options to improve documentation sorting.
Wed, May 9, 1:46 AM

Tue, May 8

atanasyan committed rLLD331851: [ELF][MIPS] Add test case to cover LA25 r6 thunks generation. NFC.
[ELF][MIPS] Add test case to cover LA25 r6 thunks generation. NFC
Tue, May 8, 11:55 PM
atanasyan committed rL331851: [ELF][MIPS] Add test case to cover LA25 r6 thunks generation. NFC.
[ELF][MIPS] Add test case to cover LA25 r6 thunks generation. NFC
Tue, May 8, 11:55 PM
atanasyan created D46629: [mips] Accept 32-bit offsets for ld/sd/lld commands.
Tue, May 8, 11:01 PM
atanasyan committed rL331774: [ELF][MIPS] Fix test case in attempt to restore Windows build-bot. NFC.
[ELF][MIPS] Fix test case in attempt to restore Windows build-bot. NFC
Tue, May 8, 9:15 AM
atanasyan committed rLLD331774: [ELF][MIPS] Fix test case in attempt to restore Windows build-bot. NFC.
[ELF][MIPS] Fix test case in attempt to restore Windows build-bot. NFC
Tue, May 8, 9:15 AM
atanasyan committed rLLD331772: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable….
[ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable…
Tue, May 8, 8:38 AM
atanasyan committed rL331772: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable….
[ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable…
Tue, May 8, 8:38 AM
atanasyan closed D45972: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable output.
Tue, May 8, 8:37 AM · lld
atanasyan updated the diff for D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.

Rebased against the trunk.

Tue, May 8, 7:07 AM · lld
atanasyan updated the diff for D31528: [ELF][MIPS] Multi-GOT implementation.

Rebased against the trunk.

Tue, May 8, 7:06 AM · lld

Sun, May 6

atanasyan created D46513: [mips] Accept 32-bit offsets for lh and lhu commands.
Sun, May 6, 11:13 PM

Sat, May 5

atanasyan accepted D46450: [Driver] Add mips_Features_Group to Options to improve documentation sorting.

Do you have commit access?

Sat, May 5, 6:21 AM

Fri, May 4

atanasyan committed rLLD331554: [ELF][MIPS] Add STO_MIPS_MICROMIPS flag to symbols point to microMIPS PLT….
[ELF][MIPS] Add STO_MIPS_MICROMIPS flag to symbols point to microMIPS PLT…
Fri, May 4, 1:52 PM
atanasyan committed rLLD331555: [ELF][MIPS] Reorganize isMipsPIC routine. NFC.
[ELF][MIPS] Reorganize isMipsPIC routine. NFC
Fri, May 4, 1:52 PM
atanasyan committed rL331555: [ELF][MIPS] Reorganize isMipsPIC routine. NFC.
[ELF][MIPS] Reorganize isMipsPIC routine. NFC
Fri, May 4, 1:52 PM
atanasyan committed rL331554: [ELF][MIPS] Add STO_MIPS_MICROMIPS flag to symbols point to microMIPS PLT….
[ELF][MIPS] Add STO_MIPS_MICROMIPS flag to symbols point to microMIPS PLT…
Fri, May 4, 1:52 PM
atanasyan accepted D46389: [mips][microMIPS] Move conditional moves out of isCodeGenOnly.

LGTM

Fri, May 4, 12:42 AM
atanasyan accepted D46392: [mips] Enable disassembly of fused (negative) multiply add/sub instructions.

LGTM

Fri, May 4, 12:24 AM
atanasyan accepted D46390: [mips] Correct the predicates of cvt.fmt.fmt instructions.

LGTM

Fri, May 4, 12:10 AM
atanasyan accepted D46388: [mips] Mark various memory instructions as being in microMIPS (NFC).

LGTM

Fri, May 4, 12:01 AM

Thu, May 3

atanasyan committed rLLD331470: [ELF][MIPS] Check that a section has a valid reference to a file in the….
[ELF][MIPS] Check that a section has a valid reference to a file in the…
Thu, May 3, 10:36 AM
atanasyan committed rL331470: [ELF][MIPS] Check that a section has a valid reference to a file in the….
[ELF][MIPS] Check that a section has a valid reference to a file in the…
Thu, May 3, 10:36 AM
atanasyan accepted D46117: [mips] Correct the predicates of sign extension instructions.

LGTM

Thu, May 3, 5:03 AM
atanasyan accepted D46125: [mips] Correct clo/clz predicates.

LGTM

Thu, May 3, 4:01 AM

Sun, Apr 29

atanasyan accepted D46123: [mips] Correct the predicates for shifts..

LGTM

Sun, Apr 29, 12:16 AM

Sat, Apr 28

atanasyan accepted D46055: [mips] Fix microMIPS loads and stores..

LGTM

Sat, Apr 28, 12:15 AM

Fri, Apr 27

atanasyan added a comment to D46055: [mips] Fix microMIPS loads and stores..

Please rebase the patch.

Fri, Apr 27, 12:09 AM

Thu, Apr 26

atanasyan updated the diff for D31528: [ELF][MIPS] Multi-GOT implementation.

Rebased against the trunk.

Thu, Apr 26, 11:38 PM · lld
atanasyan abandoned D46105: [mips] Check lb / lbu offset range in the expandLoadInst routine.
Thu, Apr 26, 1:02 PM
atanasyan committed rL330983: [mips] Accept 32-bit offsets for lb and lbu commands.
[mips] Accept 32-bit offsets for lb and lbu commands
Thu, Apr 26, 12:59 PM
atanasyan closed D45020: [mips] Accept 32-bit offsets for lb and lbu commands.
Thu, Apr 26, 12:59 PM
atanasyan added a comment to D45020: [mips] Accept 32-bit offsets for lb and lbu commands.

Thanks for review.

Thu, Apr 26, 12:58 PM
atanasyan accepted D46114: [mips] Fix the predicates of jump and branch and link instructions.

LGTM

Thu, Apr 26, 8:29 AM
atanasyan accepted D46113: [mips] Analyze and provide selection patterns microMIPSR6 branches.

LGTM

Thu, Apr 26, 8:22 AM

Apr 25 2018

atanasyan updated the summary of D45020: [mips] Accept 32-bit offsets for lb and lbu commands.
Apr 25 2018, 11:09 PM
atanasyan updated the summary of D46105: [mips] Check lb / lbu offset range in the expandLoadInst routine.
Apr 25 2018, 11:09 PM
atanasyan updated the diff for D45020: [mips] Accept 32-bit offsets for lb and lbu commands.

I created an alternative patch D46105 which replaces mem_simm16 by mem and performs range checking in the expandLoadInst routine. But there is a problem with that patch - in the expandLoadInst routine we do not know position of invalid operand, so an error message points to the beginning of the incorrect instructions. This patch attempts to use new mem_simmptr operand for lb and lbu instructions and performs range checking in a uniform way with other instructions which use ParserMatchClass.

Apr 25 2018, 11:06 PM
atanasyan created D46105: [mips] Check lb / lbu offset range in the expandLoadInst routine.
Apr 25 2018, 10:57 PM
atanasyan updated subscribers of D45972: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable output.

Thanks for review.

Apr 25 2018, 8:44 AM · lld
atanasyan updated the diff for D45972: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable output.
  • Fix comments in the test file.
  • Add command line and version numbers of GNU tools used to produce input test files.
Apr 25 2018, 6:56 AM · lld
atanasyan added a comment to D45972: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable output.

It seems you can produce .o files you have added (mips-micro-gp0-non-zero.o, mips-n64-gp0-non-zero.o) with use of llvm-mc, right?

Apr 25 2018, 3:54 AM · lld

Apr 24 2018

atanasyan added a comment to D45919: [mips] Show an error if register number is out of range.

Thanks for review.

Apr 24 2018, 9:21 AM
atanasyan committed rL330732: [mips] Show an error if register number is out of range.
[mips] Show an error if register number is out of range
Apr 24 2018, 9:17 AM
atanasyan closed D45919: [mips] Show an error if register number is out of range.
Apr 24 2018, 9:17 AM
atanasyan accepted D45870: [mips] Fix the definition of sync, synci.

LGTM

Apr 24 2018, 9:00 AM
atanasyan updated the diff for D45972: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable output.
  • Add more tests
  • Fix handling non-zero GP0 in case of microMIPS code
Apr 24 2018, 8:45 AM · lld
atanasyan added a comment to D45972: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable output.

What bfd/gold do to solve this? I guess the same?

Apr 24 2018, 8:44 AM · lld
atanasyan accepted D45939: [mips] Correct the definitions of some control instructions.

LGTM

Apr 24 2018, 2:30 AM

Apr 23 2018

atanasyan created D45972: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable output.
Apr 23 2018, 9:54 AM · lld
atanasyan added a comment to D40646: [mips] Enable the mnemonic spell corrector.

Does it have a sense to continue to work on this patch now?

Apr 23 2018, 9:50 AM
atanasyan accepted D45816: [mips] Correct the patterns for bswap.

LGTM

Apr 23 2018, 9:28 AM

Apr 21 2018

atanasyan created D45919: [mips] Show an error if register number is out of range.
Apr 21 2018, 12:55 AM

Apr 17 2018

atanasyan accepted D45626: [mips] Correct the definitions of the unaligned word memory operation instructions.

LGTM

Apr 17 2018, 2:47 AM

Apr 13 2018

atanasyan updated the diff for D31528: [ELF][MIPS] Multi-GOT implementation.

Rebased against the trunk.

Apr 13 2018, 1:50 AM · lld
atanasyan committed rL329996: [ELF][MIPS] Support linking of PIE for MIPS.
[ELF][MIPS] Support linking of PIE for MIPS
Apr 13 2018, 1:18 AM
atanasyan committed rLLD329996: [ELF][MIPS] Support linking of PIE for MIPS.
[ELF][MIPS] Support linking of PIE for MIPS
Apr 13 2018, 1:18 AM
atanasyan closed D43347: [ELF][MIPS] Support linking of PIE for MIPS.
Apr 13 2018, 1:18 AM · lld

Apr 12 2018

atanasyan added a comment to D45020: [mips] Accept 32-bit offsets for lb and lbu commands.

we should use the 'mem' operand for the lb and lbu instructions. That will allow the parser to match larger offsets than those instructions permit.

Apr 12 2018, 7:17 AM

Apr 9 2018

atanasyan added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

Ping?

Apr 9 2018, 6:48 AM · lld
Herald added a reviewer for D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps: espindola.

Ping? I'm going to commit this patch in a couple of weeks if I do not receive any objections. We can always perform a post-commit review.

Apr 9 2018, 6:48 AM · lld

Apr 6 2018

atanasyan added a comment to D45020: [mips] Accept 32-bit offsets for lb and lbu commands.

I don't think this is quite the correct approach, especially if you're going to be implementing support for 64-bit pointers with those instructions, as we would need to modify the existing lb64 and friends to be available to the AsmParser with a different set of operands.

Instead, we should use the 'mem' operand for the lb and lbu instructions. That will allow the parser to match larger offsets than those instructions permit.

Apr 6 2018, 6:41 AM

Apr 5 2018

atanasyan added inline comments to D45316: [mips] Materialize constants for multiplication.
Apr 5 2018, 10:13 PM

Apr 1 2018

atanasyan added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

Let's celebrate the first anniversary of the patch.

Apr 1 2018, 2:19 PM · lld
atanasyan added a comment to D43347: [ELF][MIPS] Support linking of PIE for MIPS.

Thanks for review.

Apr 1 2018, 2:13 PM · lld
atanasyan added a comment to D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.

This patch have not got any comments since Feb 16. Does it mean that the patch cab be committed without any additional approval?

Apr 1 2018, 2:13 PM · lld