atanasyan (Simon Atanasyan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 6 2013, 6:15 AM (280 w, 1 d)

Recent Activity

Today

atanasyan accepted D48019: [mips] Handle branch expansion corner cases.

LGTM

Thu, Jul 19, 6:09 AM
atanasyan created D49539: [mips] Replace custom parsing logic for data directives by the `addAliasForDirective`.
Thu, Jul 19, 5:05 AM
atanasyan added inline comments to D49487: [mips] Fix Makefile for tramp3d-v4 test.
Thu, Jul 19, 4:12 AM
atanasyan added inline comments to D49487: [mips] Fix Makefile for tramp3d-v4 test.
Thu, Jul 19, 3:15 AM
atanasyan added a comment to D49422: [ELF][MIPS] Fix primary GOT sometimes overflowing by one or two words.

BTW it would be nice if you add a test case

Thu, Jul 19, 3:09 AM
atanasyan created D49533: [mips] Move out the WrapperPat declaration from the NotInMicroMips predicate.
Thu, Jul 19, 12:41 AM

Yesterday

atanasyan added a comment to D49469: [mips] Fix predicate for the MipsTruncIntFP pattern.

Thanks for review.

Wed, Jul 18, 7:17 AM
atanasyan committed rL337392: [mips] Fix predicate for the MipsTruncIntFP pattern.
[mips] Fix predicate for the MipsTruncIntFP pattern
Wed, Jul 18, 7:16 AM
atanasyan closed D49469: [mips] Fix predicate for the MipsTruncIntFP pattern.
Wed, Jul 18, 7:16 AM
atanasyan created D49469: [mips] Fix predicate for the MipsTruncIntFP pattern.
Wed, Jul 18, 3:27 AM

Tue, Jul 17

atanasyan accepted D49422: [ELF][MIPS] Fix primary GOT sometimes overflowing by one or two words.

LGTM. Thanks.

Tue, Jul 17, 7:12 AM

Mon, Jul 16

atanasyan added a comment to D49262: [DAGCombiner] Call SimplifyDemandedVectorElts from EXTRACT_VECTOR_ELT.

MIPS changes LGTM

Mon, Jul 16, 10:41 PM
atanasyan accepted D49290: [Mips][FastISel] Fix handling of icmp with i1 type..

LGTM

Mon, Jul 16, 8:40 AM
atanasyan committed rL337171: [mips] Eliminate the usage of hasStdEnc in MipsPat..
[mips] Eliminate the usage of hasStdEnc in MipsPat.
Mon, Jul 16, 6:57 AM
atanasyan closed D48365: [mips] Eliminate the usage of hasStdEnc in MipsPat..
Mon, Jul 16, 6:57 AM

Sat, Jul 14

atanasyan added a comment to D48365: [mips] Eliminate the usage of hasStdEnc in MipsPat..

There appear to be a couple of test failures for this patch, at least on my end.
I am at r335143.

Sat, Jul 14, 1:36 AM
atanasyan updated the diff for D48365: [mips] Eliminate the usage of hasStdEnc in MipsPat..

The test case changes have been committed at rL337004.

Sat, Jul 14, 1:35 AM
atanasyan commandeered D48365: [mips] Eliminate the usage of hasStdEnc in MipsPat..
Sat, Jul 14, 1:31 AM

Fri, Jul 13

atanasyan committed rL337004: [mips] Add microMIPS case to the tests and regenerate assertions using….
[mips] Add microMIPS case to the tests and regenerate assertions using…
Fri, Jul 13, 8:08 AM
atanasyan accepted D48957: [MIPS GlobalISel] Select all instructions required to load and store i32 on stack.

LGTM

Fri, Jul 13, 8:06 AM

Thu, Jul 12

atanasyan added inline comments to D6229: [mips][microMIPS] Use swm32/lwm32 instructions in function prologue/epilogue.
Thu, Jul 12, 1:43 PM
atanasyan added inline comments to D48957: [MIPS GlobalISel] Select all instructions required to load and store i32 on stack.
Thu, Jul 12, 4:28 AM
atanasyan committed rL336893: [mips] Mark standard encoded instructions as not being in MIPS16e.
[mips] Mark standard encoded instructions as not being in MIPS16e
Thu, Jul 12, 1:55 AM
atanasyan closed D48379: [mips] Mark standard encoded instructions as not being in MIPS16e.
Thu, Jul 12, 1:55 AM

Wed, Jul 11

atanasyan committed rL336802: [mips] Update the P5600 scheduler model not to use instruction itineraries..
[mips] Update the P5600 scheduler model not to use instruction itineraries.
Wed, Jul 11, 6:26 AM
atanasyan closed D45245: [mips] Update the P5600 scheduler model not to use instruction itineraries..
Wed, Jul 11, 6:26 AM
atanasyan committed rL336777: [mips] Remove dead code. NFC.
[mips] Remove dead code. NFC
Wed, Jul 11, 2:46 AM

Tue, Jul 10

atanasyan accepted D49143: Fix a typo/regression in r335495..

LGTM

Tue, Jul 10, 10:37 AM
atanasyan added a comment to D47192: [utils] Reflow asm check generation to tolerate blank lines.

Does the following patch uses new CHECK-EMPTY directive solves the problem?

Tue, Jul 10, 10:32 AM
atanasyan accepted D48982: [mips] Add '-mvirt', '-mno-virt', '-mginv', '-mno-ginv' options.

LGTM

Tue, Jul 10, 9:58 AM
atanasyan committed rLLD336704: [ELF][MIPS] Add mote tests on MipsArchTree routines, fix typos in error messages.
[ELF][MIPS] Add mote tests on MipsArchTree routines, fix typos in error messages
Tue, Jul 10, 9:56 AM
atanasyan committed rL336704: [ELF][MIPS] Add mote tests on MipsArchTree routines, fix typos in error messages.
[ELF][MIPS] Add mote tests on MipsArchTree routines, fix typos in error messages
Tue, Jul 10, 9:56 AM
atanasyan added a comment to D49143: Fix a typo/regression in r335495..

It would be nice to have a test for this regression.

Tue, Jul 10, 9:16 AM

Thu, Jul 5

atanasyan committed rLLD336414: [ELF][MIPS] Simplify `checkFlags` routine and inline `rejectMicroMips64`. NFC.
[ELF][MIPS] Simplify `checkFlags` routine and inline `rejectMicroMips64`. NFC
Thu, Jul 5, 10:55 PM
atanasyan committed rL336414: [ELF][MIPS] Simplify `checkFlags` routine and inline `rejectMicroMips64`. NFC.
[ELF][MIPS] Simplify `checkFlags` routine and inline `rejectMicroMips64`. NFC
Thu, Jul 5, 10:55 PM
atanasyan committed rLLD336413: [ELF][MIPS] Remove support for linking microMIPS 64-bit code.
[ELF][MIPS] Remove support for linking microMIPS 64-bit code
Thu, Jul 5, 10:55 PM
atanasyan committed rL336413: [ELF][MIPS] Remove support for linking microMIPS 64-bit code.
[ELF][MIPS] Remove support for linking microMIPS 64-bit code
Thu, Jul 5, 10:55 PM
atanasyan closed D48949: [ELF][MIPS] Remove support for linking microMIPS 64-bit code.
Thu, Jul 5, 10:55 PM · lld
atanasyan added inline comments to D48949: [ELF][MIPS] Remove support for linking microMIPS 64-bit code.
Thu, Jul 5, 3:06 AM · lld

Wed, Jul 4

atanasyan created D48949: [ELF][MIPS] Remove support for linking microMIPS 64-bit code.
Wed, Jul 4, 11:59 AM · lld
Herald added a reviewer for D41821: [MIPS] Disassemble the 0xefefefef trap padding used by LLD: espindola.

Let's abandon this review because we need to implement the SIGRIE instruction support and use it for a trap padding in the LLD. I'm going to implement both parts of the plan.

Wed, Jul 4, 7:59 AM
atanasyan added a comment to D47001: [Mips] Use addAliasForDirective rather than custom parsing logic for data directives.

I suggest to abandon / close this review. Any objections?

Wed, Jul 4, 7:36 AM
atanasyan commandeered D45245: [mips] Update the P5600 scheduler model not to use instruction itineraries..
Wed, Jul 4, 7:30 AM
atanasyan abandoned D38800: [mips] Add Triple::getABIVariant() to form a triple variant accordingly to the ABI.
Wed, Jul 4, 7:29 AM
atanasyan abandoned D38799: [mips] Add MIPS ABI enumeration and getter function to the Triple class.
Wed, Jul 4, 7:29 AM
atanasyan commandeered D46577: [compiler-rt][cmake][mips] Correct the option handling for GCC 7.

Ping?

Wed, Jul 4, 7:27 AM
atanasyan added inline comments to D48019: [mips] Handle branch expansion corner cases.
Wed, Jul 4, 4:22 AM

Tue, Jul 3

atanasyan committed rL336201: [ELF][MIPS] Use llvm-mc to generate test case input file. NFC.
[ELF][MIPS] Use llvm-mc to generate test case input file. NFC
Tue, Jul 3, 7:44 AM
atanasyan committed rLLD336201: [ELF][MIPS] Use llvm-mc to generate test case input file. NFC.
[ELF][MIPS] Use llvm-mc to generate test case input file. NFC
Tue, Jul 3, 7:44 AM
atanasyan accepted D48843: [mips] Warn when crc, ginv, virt flags are used with too old revision.

LGTM with one minor note.

Tue, Jul 3, 4:19 AM

Mon, Jul 2

atanasyan accepted D47934: [MIPS GlobalISel] Lower arguments using stack .

Sorry for the delay.

Mon, Jul 2, 8:15 AM

Fri, Jun 29

atanasyan closed D31557: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el..

Closed by commit rL335434.

Fri, Jun 29, 12:40 AM

Thu, Jun 28

atanasyan accepted D48642: [Mips][FastISel] Do not duplicate condition while lowering branches.

LGTM

Thu, Jun 28, 8:02 AM
atanasyan accepted D47947: [mips] Support shrink-wrapping.

LGTM

Thu, Jun 28, 1:23 AM

Tue, Jun 26

atanasyan accepted D48507: [mips] Explicitly specify the linker emulation for MIPS on FreeBSD..
Tue, Jun 26, 9:15 AM
atanasyan accepted D48499: [mips] Use more conservative default CPUs for MIPS on FreeBSD..

LGTM

Tue, Jun 26, 6:15 AM
atanasyan accepted D48515: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el..
Tue, Jun 26, 4:41 AM
atanasyan added a comment to D48515: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el..

LGTM, but before commit please add a test case into the freebsd.c.

Tue, Jun 26, 4:41 AM
atanasyan added inline comments to D48507: [mips] Explicitly specify the linker emulation for MIPS on FreeBSD..
Tue, Jun 26, 4:27 AM

Mon, Jun 25

atanasyan accepted D48548: Add Triple::isMIPS()/isMIPS32()/isMIPS64(). NFC.

LGTM

Mon, Jun 25, 8:29 AM
atanasyan accepted D48549: Use Triple::isMIPS() instead of enumerating all Triples. NFC.

LGTM. the only minor nit

Mon, Jun 25, 7:25 AM
atanasyan added inline comments to D48548: Add Triple::isMIPS()/isMIPS32()/isMIPS64(). NFC.
Mon, Jun 25, 7:17 AM

Sun, Jun 24

atanasyan accepted D31557: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el..

LGTM

Sun, Jun 24, 5:18 AM

Thu, Jun 21

atanasyan accepted D48374: [mips] Sign extend i32 return values on MIPS64.

LGTM

Thu, Jun 21, 10:47 PM
atanasyan accepted D31557: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el..

By the way, what is a typical EnvironmentType on BSD systems?

Thu, Jun 21, 8:25 AM
atanasyan committed rL335213: CODE_OWNERS: Take ownership of the MIPS backend.
CODE_OWNERS: Take ownership of the MIPS backend
Thu, Jun 21, 3:04 AM

Wed, Jun 20

atanasyan added inline comments to D48405: [ELF] Assign RF_EXEC rank even if --no-rosegment or SECTIONS command is used.
Wed, Jun 20, 11:23 PM
atanasyan committed rLLD335140: [ELF][MIPS] Fill a primary-GOT as much as possible.
[ELF][MIPS] Fill a primary-GOT as much as possible
Wed, Jun 20, 9:04 AM
atanasyan committed rL335140: [ELF][MIPS] Fill a primary-GOT as much as possible.
[ELF][MIPS] Fill a primary-GOT as much as possible
Wed, Jun 20, 9:03 AM

Jun 19 2018

atanasyan committed rL335059: [ELF][MIPS] Temporarily mark failed MIPS tests as XFAIL..
[ELF][MIPS] Temporarily mark failed MIPS tests as XFAIL.
Jun 19 2018, 9:53 AM
atanasyan committed rLLD335059: [ELF][MIPS] Temporarily mark failed MIPS tests as XFAIL..
[ELF][MIPS] Temporarily mark failed MIPS tests as XFAIL.
Jun 19 2018, 9:53 AM
atanasyan committed rLLD335056: Remove empty unused folders. NFC.
Remove empty unused folders. NFC
Jun 19 2018, 9:03 AM
atanasyan committed rL335056: Remove empty unused folders. NFC.
Remove empty unused folders. NFC
Jun 19 2018, 9:02 AM
atanasyan accepted D48216: [mips] Correct predicates for loads, bit manipulation instructions and some pseudos.

LGTM

Jun 19 2018, 7:18 AM
atanasyan accepted D48321: [mips] Fix the predicates of some aliases.

LGTM

Jun 19 2018, 7:15 AM
Herald added a reviewer for D41761: Introduce llvm.nospeculateload intrinsic: javed.absar.
Jun 19 2018, 6:15 AM

Jun 18 2018

atanasyan accepted D48217: [mips][wip] Disable the selection of mixed microMIPS/MIPS code.

LGTM

Jun 18 2018, 2:33 AM

Jun 15 2018

atanasyan committed rLLD334851: [ELF][MIPS] Fix stable_sort predicate to satisfy strict-ordering requirement..
[ELF][MIPS] Fix stable_sort predicate to satisfy strict-ordering requirement.
Jun 15 2018, 11:20 AM
atanasyan committed rL334851: [ELF][MIPS] Fix stable_sort predicate to satisfy strict-ordering requirement..
[ELF][MIPS] Fix stable_sort predicate to satisfy strict-ordering requirement.
Jun 15 2018, 11:19 AM
atanasyan added a comment to D48216: [mips] Correct predicates for loads, bit manipulation instructions and some pseudos.

Could you add a test case?

Jun 15 2018, 7:01 AM
atanasyan accepted D48169: [mips] Add '-mcrc', '-mno-crc' options to enable/disable CRC ASE.
Jun 15 2018, 6:36 AM
atanasyan added inline comments to D47934: [MIPS GlobalISel] Lower arguments using stack .
Jun 15 2018, 6:17 AM
atanasyan added inline comments to D48169: [mips] Add '-mcrc', '-mno-crc' options to enable/disable CRC ASE.
Jun 15 2018, 6:08 AM
atanasyan accepted D48166: [mips] Fix the predicates of some DSP instructions from AdditionalPredicates to ASEPredicate.

LGTM

Jun 15 2018, 6:04 AM

Jun 14 2018

atanasyan committed rLLD334705: [ELF][MIPS] Replace calls to MapVector::find by MapVector::lookup. NFC.
[ELF][MIPS] Replace calls to MapVector::find by MapVector::lookup. NFC
Jun 14 2018, 4:58 AM
atanasyan committed rL334705: [ELF][MIPS] Replace calls to MapVector::find by MapVector::lookup. NFC.
[ELF][MIPS] Replace calls to MapVector::find by MapVector::lookup. NFC
Jun 14 2018, 4:58 AM

Jun 11 2018

atanasyan accepted D48002: [ELF][MIPS] Fix TLS GOT entries for local symbols in shared libraries.

LGTM. I would make the test case smaller by removing commands, directives etc unrelated to the problem.

Jun 11 2018, 2:04 AM
atanasyan committed rLLD334392: [ELF] Pass a pointer to InputFile to the getRelocTargetVA to escape….
[ELF] Pass a pointer to InputFile to the getRelocTargetVA to escape…
Jun 11 2018, 1:43 AM
atanasyan committed rL334392: [ELF] Pass a pointer to InputFile to the getRelocTargetVA to escape….
[ELF] Pass a pointer to InputFile to the getRelocTargetVA to escape…
Jun 11 2018, 1:43 AM
atanasyan committed rLLD334390: [ELF][MIPS] Multi-GOT implementation.
[ELF][MIPS] Multi-GOT implementation
Jun 11 2018, 12:30 AM
atanasyan added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

Thanks for all for your support, review and comments.

Jun 11 2018, 12:29 AM · lld
atanasyan committed rL334390: [ELF][MIPS] Multi-GOT implementation.
[ELF][MIPS] Multi-GOT implementation
Jun 11 2018, 12:29 AM
atanasyan closed D31528: [ELF][MIPS] Multi-GOT implementation.
Jun 11 2018, 12:28 AM · lld

Jun 8 2018

atanasyan accepted D47636: [mips] Guard some floating point instructions correctly.

LGTM

Jun 8 2018, 6:09 AM

Jun 7 2018

atanasyan updated the diff for D31528: [ELF][MIPS] Multi-GOT implementation.

Rebased against the trunk.

Jun 7 2018, 8:28 AM · lld
atanasyan added inline comments to D47876: [Mips] Silencing warnings in instruction info (NFC).
Jun 7 2018, 5:27 AM

Jun 5 2018

atanasyan accepted D47635: [mips] Fix the predicates for arithmetic operations.

LGTM

Jun 5 2018, 4:26 AM

Jun 3 2018

atanasyan added a comment to D47635: [mips] Fix the predicates for arithmetic operations.

Is it possible to check these changes by test cases?

Jun 3 2018, 12:10 AM

Jun 1 2018

atanasyan added a comment to D47316: [mips] Support 64-bit offsets for lb/sb/ld/sd/lld ... instructions.

Thanks for review.

Jun 1 2018, 9:43 AM
atanasyan committed rL333774: [mips] Support 64-bit offsets for lb/sb/ld/sd/lld ... instructions.
[mips] Support 64-bit offsets for lb/sb/ld/sd/lld ... instructions
Jun 1 2018, 9:42 AM