atanasyan (Simon Atanasyan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 6 2013, 6:15 AM (298 w, 20 h)

Recent Activity

Tue, Nov 20

atanasyan committed rL347346: [unittests] Fix ExpandTilde test to match handling home dirs with trailing slash.
[unittests] Fix ExpandTilde test to match handling home dirs with trailing slash
Tue, Nov 20, 1:16 PM
atanasyan closed D54752: [unittests] Fix ExpandTilde test to match handling home dirs with trailing slash.
Tue, Nov 20, 1:16 PM
atanasyan accepted D54721: [mips][mc] Add basic support for R_MIPS_JALR/R_MICROMIPS_JALR.

LGTM

Tue, Nov 20, 10:57 AM
atanasyan created D54752: [unittests] Fix ExpandTilde test to match handling home dirs with trailing slash.
Tue, Nov 20, 5:49 AM

Mon, Nov 19

atanasyan added inline comments to D54721: [mips][mc] Add basic support for R_MIPS_JALR/R_MICROMIPS_JALR.
Mon, Nov 19, 8:53 PM
atanasyan accepted D54703: [TargetLowering] expandFP_TO_UINT - improve fp16 support.

LGTM

Mon, Nov 19, 10:41 AM
atanasyan added a comment to D53794: [TargetLowering] expandFP_TO_UINT - avoid FPE due to out of range conversion (PR17686).

@atanasyan The f16 conversion fix should probably be pulled out - do you want me to add 'in overflow range' and 'out of overflow range' fptoui tests to f16-llvm-ir.ll ?

Mon, Nov 19, 7:11 AM

Fri, Nov 16

atanasyan committed rL347049: [DWARF] Use PRIx64 instead of 'x' to format 64-bit values.
[DWARF] Use PRIx64 instead of 'x' to format 64-bit values
Fri, Nov 16, 5:18 AM

Thu, Nov 15

atanasyan added a comment to D54154: [ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction.

Thanks for review.

Thu, Nov 15, 9:33 PM
atanasyan committed rL347029: [ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction.
[ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction
Thu, Nov 15, 9:33 PM
atanasyan committed rLLD347029: [ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction.
[ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction
Thu, Nov 15, 9:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Thu, Nov 15, 9:33 PM

Wed, Nov 14

atanasyan updated the diff for D54154: [ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction.
  • Add a separate test case to check trap instruction encoding in case of bi and little endian.
  • Use TrapInstr array.
Wed, Nov 14, 2:57 PM
atanasyan committed rLLD346893: [ELF] Make TrapInstr and Filler byte arrays. NFC..
[ELF] Make TrapInstr and Filler byte arrays. NFC.
Wed, Nov 14, 1:08 PM
atanasyan committed rL346893: [ELF] Make TrapInstr and Filler byte arrays. NFC..
[ELF] Make TrapInstr and Filler byte arrays. NFC.
Wed, Nov 14, 1:08 PM
atanasyan closed D54207: [ELF] Make TrapInstr and Filler byte arrays. NFC..
Wed, Nov 14, 1:08 PM
atanasyan added a comment to D54207: [ELF] Make TrapInstr and Filler byte arrays. NFC..

Any plan on committing this change?

If that's directed at me, I don't have commit rights.

Wed, Nov 14, 12:39 PM
atanasyan added a comment to rL346773: [WebAssembly] Mark immediates.ll as XFAILed on MIPS hosts.

The problem is related to NaN representation all the same :)

Wed, Nov 14, 9:08 AM
atanasyan added a comment to D54207: [ELF] Make TrapInstr and Filler byte arrays. NFC..

Any plan on committing this change?

Wed, Nov 14, 7:38 AM
atanasyan added a comment to rL346773: [WebAssembly] Mark immediates.ll as XFAILed on MIPS hosts.

-mnan and --with-nan= are MIPS target options, however I'm asking about targeting WebAssembly with a MIPS host.

WebAssembly always uses the 754-2008 NaN encoding, so compiling C to it should always do so as well, even on a MIPS host. Is that the case?

Wed, Nov 14, 6:15 AM

Tue, Nov 13

atanasyan added a comment to rL346773: [WebAssembly] Mark immediates.ll as XFAILed on MIPS hosts.

By default mips gcc uses legacy nan. It might be changed by -mnan=2008
/ -mnan=legacy
options. Or by --with-nan=2008 for gcc configuration.

Tue, Nov 13, 11:34 AM
atanasyan committed rL346773: [WebAssembly] Mark immediates.ll as XFAILed on MIPS hosts.
[WebAssembly] Mark immediates.ll as XFAILed on MIPS hosts
Tue, Nov 13, 10:17 AM
atanasyan added a comment to D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected.

Simon?

Tue, Nov 13, 9:17 AM

Mon, Nov 12

atanasyan committed rL346715: [DWARF] Do not use PRIx32 for printing uint64_t values.
[DWARF] Do not use PRIx32 for printing uint64_t values
Mon, Nov 12, 2:46 PM
atanasyan closed D54424: [DWARF] Do not use PRIx32 for printing uint64_t values.
Mon, Nov 12, 2:46 PM
atanasyan added a comment to D54424: [DWARF] Do not use PRIx32 for printing uint64_t values.

Any chance of a test case?

I hope the following test case starts to pass on mips buildbot:
http://lab.llvm.org:8011/builders/llvm-mips-linux/builds/3739/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3Adebug_addr.ll

Could this also be tested cross-platform (on any platform that's building the mips backend)? (ie: a version of this test that 'REQUIRES: ' the mips target and specifically targets it)

Mon, Nov 12, 12:05 PM
atanasyan added a comment to D54424: [DWARF] Do not use PRIx32 for printing uint64_t values.

Any chance of a test case?

Mon, Nov 12, 11:22 AM
atanasyan created D54424: [DWARF] Do not use PRIx32 for printing uint64_t values.
Mon, Nov 12, 5:49 AM

Thu, Nov 8

atanasyan added inline comments to D53990: [MC] Support labels as offsets in .reloc directive.
Thu, Nov 8, 12:42 PM
atanasyan accepted D53990: [MC] Support labels as offsets in .reloc directive.
Thu, Nov 8, 12:39 PM
atanasyan added a reviewer for D53990: [MC] Support labels as offsets in .reloc directive: echristo.

LGTM, nit below.

Thu, Nov 8, 12:39 PM

Wed, Nov 7

atanasyan accepted D54098: [MIPS GlobalISel] Set operand order for G_MERGE and G_UNMERGE.

LGTM

Wed, Nov 7, 2:00 AM

Tue, Nov 6

atanasyan added a reviewer for D52010: RegAllocFast: Rewrite and improve: abeserminji.

@abeserminji: Aleksandar, could you take a look at the RegAllocFast::reloadAtBegin? It looks like a necessity of using the rafast-ignore-missing-defs option is caused by the rL336328 commit.

Tue, Nov 6, 10:10 PM
atanasyan added inline comments to D54154: [ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction.
Tue, Nov 6, 2:46 PM
atanasyan accepted D54038: [mips][msa] Fix msa_[st/ld] offset check.

LGTM

Tue, Nov 6, 7:59 AM
atanasyan added a comment to D41821: [MIPS] Disassemble the 0xefefefef trap padding used by LLD.

Support of SIGRIE instruction is implemented at rL346230. LLD related patch with new trap instruction is D54154.

Tue, Nov 6, 7:07 AM
atanasyan created D54154: [ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction.
Tue, Nov 6, 7:05 AM
atanasyan committed rL346230: [mips] Support sigrie instruction.
[mips] Support sigrie instruction
Tue, Nov 6, 6:41 AM
atanasyan closed D53861: [mips] Support sigrie instruction.
Tue, Nov 6, 6:41 AM

Sat, Nov 3

atanasyan accepted D53977: [Mips] Supplement long branch pseudo instructions.

LGTM

Sat, Nov 3, 1:54 PM
atanasyan added a comment to D53990: [MC] Support labels as offsets in .reloc directive.

With this patch I get the following failed test cases.

Clang :: CodeGen/asm-parser-info.S
Clang :: CodeGen/mips-inline-asm-abi.c
Clang :: CodeGen/thinlto-diagnostic-handler-remarks-with-hotness.ll
Clang :: CodeGen/thinlto-distributed-cfi-devirt.ll
Clang :: CodeGen/thinlto-distributed-cfi.ll
Clang :: CodeGen/thinlto-distributed.ll
Clang :: CodeGen/thinlto-multi-module.ll
Clang :: CodeGen/thinlto-split-dwarf.c
Clang :: CodeGen/thinlto_backend.ll
Clang :: Driver/clang-offload-bundler.c
Clang :: Driver/mips-mabs-warning.c
Clang :: Driver/relax.s
Clang :: Misc/cc1as-split-dwarf.s
Clang :: Modules/DebugInfoTransitiveImport.m
Clang :: Modules/ExtDebugInfo.cpp
Clang :: Modules/ModuleDebugInfo.cpp
Clang :: Modules/ModuleDebugInfo.m
Clang :: Modules/debug-info-moduleimport-in-module.m
Clang :: Modules/lsv-debuginfo.cpp
Clang :: Modules/module_file_info.m
Clang :: Modules/pch_container.m
Clang :: PCH/debug-info-pch-path.c
Sat, Nov 3, 1:44 PM

Fri, Nov 2

atanasyan accepted D53984: [mips] Fix broken MSA test.

LGTM

Fri, Nov 2, 7:09 AM

Wed, Oct 31

atanasyan accepted D53756: [Mips] Conditionally remove successor block.

LGTM

Wed, Oct 31, 8:14 AM

Mon, Oct 29

atanasyan created D53861: [mips] Support sigrie instruction.
Mon, Oct 29, 10:41 PM

Wed, Oct 24

atanasyan committed rL345238: [llvm-readobj] Print ELF header flags names in GNU output.
[llvm-readobj] Print ELF header flags names in GNU output
Wed, Oct 24, 10:42 PM
atanasyan closed D52027: [llvm-readobj] Print ELF header flags names in GNU output.
Wed, Oct 24, 10:42 PM
atanasyan added a comment to D52027: [llvm-readobj] Print ELF header flags names in GNU output.

Thanks for review.

Wed, Oct 24, 10:41 PM

Tue, Oct 23

atanasyan added a comment to D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected.

How is it going with regard to N32 fixes / testing?

Tue, Oct 23, 8:39 AM

Oct 21 2018

atanasyan accepted D53366: [mips][micromips] Add pattern for JmpLink to TargetExternalSymbol.

LGTM

Oct 21 2018, 7:52 AM

Oct 16 2018

atanasyan committed rC344608: [driver][mips] Support MIPS R6 target triples.
[driver][mips] Support MIPS R6 target triples
Oct 16 2018, 7:32 AM
atanasyan committed rL344608: [driver][mips] Support MIPS R6 target triples.
[driver][mips] Support MIPS R6 target triples
Oct 16 2018, 7:31 AM
atanasyan closed D50850: clang: Add triples support for MIPS r6.
Oct 16 2018, 7:31 AM
atanasyan accepted D50850: clang: Add triples support for MIPS r6.

LGTM. Thanks for the patch.

Oct 16 2018, 7:31 AM
atanasyan committed rL344603: [driver][mips] Adjust target triple's environment accordingly to provided ABI….
[driver][mips] Adjust target triple's environment accordingly to provided ABI…
Oct 16 2018, 3:21 AM
atanasyan committed rC344603: [driver][mips] Adjust target triple's environment accordingly to provided ABI….
[driver][mips] Adjust target triple's environment accordingly to provided ABI…
Oct 16 2018, 3:21 AM

Oct 15 2018

atanasyan committed rC344583: [mips] Group similar commands in the test case. NFC.
[mips] Group similar commands in the test case. NFC
Oct 15 2018, 10:20 PM
atanasyan committed rL344583: [mips] Group similar commands in the test case. NFC.
[mips] Group similar commands in the test case. NFC
Oct 15 2018, 10:20 PM
atanasyan added a comment to D50850: clang: Add triples support for MIPS r6.

Could you please rebase this patch against the trunk?

Oct 15 2018, 10:18 PM
atanasyan committed rL344570: [mips] Fix handling of GNUABIN32 environment in a target triple.
[mips] Fix handling of GNUABIN32 environment in a target triple
Oct 15 2018, 3:45 PM
atanasyan committed rC344570: [mips] Fix handling of GNUABIN32 environment in a target triple.
[mips] Fix handling of GNUABIN32 environment in a target triple
Oct 15 2018, 3:45 PM
atanasyan closed D51464: clang: fix MIPS/N32 triple and paths.
Oct 15 2018, 3:45 PM
atanasyan accepted D51464: clang: fix MIPS/N32 triple and paths.

LGTM. Thanks for the patch.

Oct 15 2018, 3:45 PM
atanasyan accepted D53077: [MIPS GlobalISel] Legalize constants.

LGTM

Oct 15 2018, 6:28 AM

Oct 10 2018

atanasyan added a comment to D51464: clang: fix MIPS/N32 triple and paths.

I'm going to test current MIPS N32 ABI implementation. Maybe we are ready to enable integrated assembler for it. In that case both Generic_GCC::IsIntegratedAssemblerDefault() and MipsMCAsmInfo ctor can be simplified.

Oct 10 2018, 9:05 AM
atanasyan added a comment to D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected.

Simon, and what about lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp?

Oct 10 2018, 9:03 AM

Oct 9 2018

atanasyan accepted D52987: [mips][micromips] Fix overlaping FDEs error.

LGTM

Oct 9 2018, 7:12 AM
atanasyan accepted D52985: [mips][micromips] Fix how values in .gcc_except_table are calculated.

LGTM

Oct 9 2018, 7:12 AM
atanasyan committed rL344040: [mips] Fix FDE/CFI encoding in case of N32 ABI.
[mips] Fix FDE/CFI encoding in case of N32 ABI
Oct 9 2018, 4:32 AM
atanasyan closed D52876: [mips] Fix FDE/CFI encoding in case of N32 ABI.
Oct 9 2018, 4:32 AM
atanasyan committed rL344039: [mips] Set pointer size to 4 bytes for N32 ABI.
[mips] Set pointer size to 4 bytes for N32 ABI
Oct 9 2018, 4:32 AM
atanasyan closed D52874: [mips] Set pointer size to 4 bytes for N32 ABI.
Oct 9 2018, 4:32 AM

Oct 8 2018

atanasyan added a comment to D52985: [mips][micromips] Fix how values in .gcc_except_table are calculated.

And the test case failed:

test/CodeGen/Mips/micromips-gcc-except-table.ll:4:15: error: CHECK-NEXT: expected string not foundin input
; CHECK-NEXT: 0000 ff9b1501 0c010f00 000f1025 011f1e00
              ^
<stdin>:5:2: note: scanning from here
 0000 ff9b1501 0c011100 00110e1f 011f1800 ................
 ^
Oct 8 2018, 9:59 PM
atanasyan added inline comments to D52985: [mips][micromips] Fix how values in .gcc_except_table are calculated.
Oct 8 2018, 3:43 PM
atanasyan accepted D52652: [MIPS GlobalISel] Legalize i64 add.

LGTM

Oct 8 2018, 3:32 PM

Oct 4 2018

atanasyan added a dependency for D52876: [mips] Fix FDE/CFI encoding in case of N32 ABI: D52874: [mips] Set pointer size to 4 bytes for N32 ABI.
Oct 4 2018, 3:43 AM
atanasyan added a dependent revision for D52874: [mips] Set pointer size to 4 bytes for N32 ABI: D52876: [mips] Fix FDE/CFI encoding in case of N32 ABI.
Oct 4 2018, 3:43 AM
atanasyan created D52876: [mips] Fix FDE/CFI encoding in case of N32 ABI.
Oct 4 2018, 3:43 AM
atanasyan created D52874: [mips] Set pointer size to 4 bytes for N32 ABI.
Oct 4 2018, 3:38 AM

Oct 3 2018

atanasyan added a comment to D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected.

Ping?

Oct 3 2018, 10:51 PM
atanasyan committed rL343730: [mips] Remove -allow-deprecated-dag-overlap flag from tests. NFC.
[mips] Remove -allow-deprecated-dag-overlap flag from tests. NFC
Oct 3 2018, 3:04 PM

Oct 2 2018

atanasyan accepted D52649: [mips] Mark fmaxl as a long double emulation routine.

LGTM

Oct 2 2018, 7:08 AM

Oct 1 2018

atanasyan added a comment to D52668: [DAGCombiner] Improve X div/rem Y fold if single bit element type.

I hope rL343485 helps.

Oct 1 2018, 7:47 AM
atanasyan committed rL343485: [mips] Generate tests expectations using update_llc_test_checks. NFC.
[mips] Generate tests expectations using update_llc_test_checks. NFC
Oct 1 2018, 7:46 AM
atanasyan added a comment to D52668: [DAGCombiner] Improve X div/rem Y fold if single bit element type.

I will fix the MIPS test cases soon.

Oct 1 2018, 5:46 AM

Sep 30 2018

atanasyan added a comment to D50850: clang: Add triples support for MIPS r6.

This is really for Clang. I guess you mean that compiler-rt directory also need to be patched.

Sep 30 2018, 12:10 AM

Sep 29 2018

atanasyan added a comment to D51464: clang: fix MIPS/N32 triple and paths.

Please run test suite before sending a patch to review. After applying this patch the following tests failed:

  • test/CodeGen/target-data.c
  • test/Driver/mips-cs.cpp
Sep 29 2018, 11:15 PM
atanasyan added a comment to D52668: [DAGCombiner] Improve X div/rem Y fold if single bit element type.

xbolva00@xbolva00:~/LLVM/llvm/utils$ ./update_llc_test_checks.py /home/xbolva00/LLVM/llvm/test/CodeGen/Mips/llvm-ir/urem.ll
Cannot find a triple. Assume 'x86'

Sep 29 2018, 10:38 PM

Sep 28 2018

atanasyan added inline comments to D51464: clang: fix MIPS/N32 triple and paths.
Sep 28 2018, 7:16 AM
atanasyan added a comment to D50850: clang: Add triples support for MIPS r6.

Fine. Now this patch has modifications for LLVM (not Clang) and all these changes were applied at rL343185 already. Could you attach an actual patch brings R6 support to the Clang driver?

Sep 28 2018, 6:50 AM
atanasyan resigned from D42839: [MC] Allow overriding whether to output Elf_Rel or Elf_Rela relocations.
Sep 28 2018, 6:33 AM
atanasyan resigned from D29681: Handle -G as an alias to -shared.
Sep 28 2018, 6:31 AM
atanasyan abandoned D46577: [compiler-rt][cmake][mips] Correct the option handling for GCC 7.

Initial problem has been fixed by rL343182.

Sep 28 2018, 6:18 AM

Sep 27 2018

atanasyan accepted D52619: Fix greedy FileCheck expression in test/Driver/mips-abi.c.

LGTM. Thanks!

Sep 27 2018, 10:22 AM
atanasyan added a comment to D50850: clang: Add triples support for MIPS r6.

Could you please update the patch against the current trunk?

Sep 27 2018, 5:23 AM
atanasyan accepted D52409: [MIPS GlobalISel] Lower i64 arguments.

LGTM

Sep 27 2018, 5:16 AM
atanasyan committed rL343185: [mips] Add support MIPS r6 Debian triples.
[mips] Add support MIPS r6 Debian triples
Sep 27 2018, 1:53 AM
atanasyan closed D50857: llvm: Add support MIPS r6 Debian triples.
Sep 27 2018, 1:53 AM
atanasyan accepted D50857: llvm: Add support MIPS r6 Debian triples.

LGTM. Thanks for the patch.

Sep 27 2018, 1:52 AM
atanasyan committed rCRT343182: [compiler-rt][cmake][mips] Use -mabi option to select target architecture.
[compiler-rt][cmake][mips] Use -mabi option to select target architecture
Sep 27 2018, 12:18 AM
atanasyan committed rL343182: [compiler-rt][cmake][mips] Use -mabi option to select target architecture.
[compiler-rt][cmake][mips] Use -mabi option to select target architecture
Sep 27 2018, 12:18 AM