LGTM

LGTM

In D53794#1302856, @RKSimon wrote:

@atanasyan The f16 conversion fix should probably be pulled out - do you want me to add 'in overflow range' and 'out of overflow range' fptoui tests to f16-llvm-ir.ll ?

Thanks for review.

• Add a separate test case to check trap instruction encoding in case of bi and little endian.
• Use TrapInstr array.

In D54207#1298851, @jrtc27 wrote:

In D54207#1298509, @atanasyan wrote:

Any plan on committing this change?

If that's directed at me, I don't have commit rights.

The problem is related to NaN representation all the same :)

Any plan on committing this change?

In rL346773#297373, @sunfish wrote:

-mnan and --with-nan= are MIPS target options, however I'm asking about targeting WebAssembly with a MIPS host.

WebAssembly always uses the 754-2008 NaN encoding, so compiling C to it should always do so as well, even on a MIPS host. Is that the case?

By default mips gcc uses legacy nan. It might be changed by -mnan=2008
/ -mnan=legacy
options. Or by --with-nan=2008 for gcc configuration.

In D52418#1294699, @brad wrote:

Simon?

In D54424#1295873, @dblaikie wrote:

In D54424#1295850, @atanasyan wrote:

In D54424#1295814, @dblaikie wrote:

Any chance of a test case?

I hope the following test case starts to pass on mips buildbot:
http://lab.llvm.org:8011/builders/llvm-mips-linux/builds/3739/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3Adebug_addr.ll

Could this also be tested cross-platform (on any platform that's building the mips backend)? (ie: a version of this test that 'REQUIRES: ' the mips target and specifically targets it)

In D54424#1295814, @dblaikie wrote:

Any chance of a test case?

LGTM, nit below.

LGTM

@abeserminji: Aleksandar, could you take a look at the RegAllocFast::reloadAtBegin? It looks like a necessity of using the rafast-ignore-missing-defs option is caused by the rL336328 commit.

LGTM

Support of SIGRIE instruction is implemented at rL346230. LLD related patch with new trap instruction is D54154.

LGTM

With this patch I get the following failed test cases.

Clang :: CodeGen/asm-parser-info.S
Clang :: CodeGen/mips-inline-asm-abi.c
Clang :: CodeGen/thinlto-diagnostic-handler-remarks-with-hotness.ll
Clang :: CodeGen/thinlto-distributed-cfi-devirt.ll
Clang :: CodeGen/thinlto-distributed-cfi.ll
Clang :: CodeGen/thinlto-distributed.ll
Clang :: CodeGen/thinlto-multi-module.ll
Clang :: CodeGen/thinlto-split-dwarf.c
Clang :: CodeGen/thinlto_backend.ll
Clang :: Driver/clang-offload-bundler.c
Clang :: Driver/mips-mabs-warning.c
Clang :: Driver/relax.s
Clang :: Misc/cc1as-split-dwarf.s
Clang :: Modules/DebugInfoTransitiveImport.m
Clang :: Modules/ExtDebugInfo.cpp
Clang :: Modules/ModuleDebugInfo.cpp
Clang :: Modules/ModuleDebugInfo.m
Clang :: Modules/debug-info-moduleimport-in-module.m
Clang :: Modules/lsv-debuginfo.cpp
Clang :: Modules/module_file_info.m
Clang :: Modules/pch_container.m
Clang :: PCH/debug-info-pch-path.c

LGTM

LGTM

Thanks for review.

In D52418#1271779, @brad wrote:

How is it going with regard to N32 fixes / testing?

LGTM

LGTM. Thanks for the patch.

Could you please rebase this patch against the trunk?

LGTM. Thanks for the patch.

LGTM

I'm going to test current MIPS N32 ABI implementation. Maybe we are ready to enable integrated assembler for it. In that case both Generic_GCC::IsIntegratedAssemblerDefault() and MipsMCAsmInfo ctor can be simplified.

In D52418#1256189, @brad wrote:

Simon, and what about lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp?

LGTM

LGTM

And the test case failed:

test/CodeGen/Mips/micromips-gcc-except-table.ll:4:15: error: CHECK-NEXT: expected string not foundin input
; CHECK-NEXT: 0000 ff9b1501 0c010f00 000f1025 011f1e00
              ^
<stdin>:5:2: note: scanning from here
 0000 ff9b1501 0c011100 00110e1f 011f1800 ................
 ^

LGTM

Ping?

LGTM

I hope rL343485 helps.

I will fix the MIPS test cases soon.

In D50850#1250285, @wzssyqa wrote:

This is really for Clang. I guess you mean that compiler-rt directory also need to be patched.

Please run test suite before sending a patch to review. After applying this patch the following tests failed:

• test/CodeGen/target-data.c
• test/Driver/mips-cs.cpp

In D52668#1250229, @xbolva00 wrote:

xbolva00@xbolva00:~/LLVM/llvm/utils$ ./update_llc_test_checks.py /home/xbolva00/LLVM/llvm/test/CodeGen/Mips/llvm-ir/urem.ll
Cannot find a triple. Assume 'x86'

Fine. Now this patch has modifications for LLVM (not Clang) and all these changes were applied at rL343185 already. Could you attach an actual patch brings R6 support to the Clang driver?

Initial problem has been fixed by rL343182.

LGTM. Thanks!

Could you please update the patch against the current trunk?

LGTM

LGTM. Thanks for the patch.