I created an alternative patch D46105 which replaces mem_simm16 by mem and performs range checking in the expandLoadInst routine. But there is a problem with that patch - in the expandLoadInst routine we do not know position of invalid operand, so an error message points to the beginning of the incorrect instructions. This patch attempts to use new mem_simmptr operand for lb and lbu instructions and performs range checking in a uniform way with other instructions which use ParserMatchClass.

Apr 25 2018, 11:06 PM

atanasyan created D46105: [mips] Check lb / lbu offset range in the expandLoadInst routine.

Apr 25 2018, 10:57 PM

atanasyan updated subscribers of D45972: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable output.

Thanks for review.

Apr 25 2018, 8:44 AM · lld

atanasyan updated the diff for D45972: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable output.

Fix comments in the test file.
Add command line and version numbers of GNU tools used to produce input test files.

Apr 25 2018, 6:56 AM · lld

atanasyan added a comment to D45972: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable output.

In D45972#1077893, @grimar wrote:

It seems you can produce .o files you have added (mips-micro-gp0-non-zero.o, mips-n64-gp0-non-zero.o) with use of llvm-mc, right?

Apr 25 2018, 3:54 AM · lld

Apr 24 2018

atanasyan added a comment to D45919: [mips] Show an error if register number is out of range.

Thanks for review.

Apr 24 2018, 9:21 AM

atanasyan committed rL330732: [mips] Show an error if register number is out of range.

[mips] Show an error if register number is out of range

Apr 24 2018, 9:17 AM

atanasyan closed D45919: [mips] Show an error if register number is out of range.

Apr 24 2018, 9:17 AM

atanasyan accepted D45870: [mips] Fix the definition of sync, synci.

LGTM

Apr 24 2018, 9:00 AM

atanasyan updated the diff for D45972: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable output.

Add more tests
Fix handling non-zero GP0 in case of microMIPS code

Apr 24 2018, 8:45 AM · lld

atanasyan added a comment to D45972: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable output.

What bfd/gold do to solve this? I guess the same?

Apr 24 2018, 8:44 AM · lld

atanasyan accepted D45939: [mips] Correct the definitions of some control instructions.

LGTM

Apr 24 2018, 2:30 AM

Apr 23 2018

atanasyan created D45972: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable output.

Apr 23 2018, 9:54 AM · lld

atanasyan added a comment to D40646: [mips] Enable the mnemonic spell corrector.

Does it have a sense to continue to work on this patch now?

Apr 23 2018, 9:50 AM

atanasyan accepted D45816: [mips] Correct the patterns for bswap.

LGTM

Apr 23 2018, 9:28 AM

Apr 21 2018

atanasyan created D45919: [mips] Show an error if register number is out of range.

Apr 21 2018, 12:55 AM

Apr 17 2018

atanasyan accepted D45626: [mips] Correct the definitions of the unaligned word memory operation instructions.

LGTM

Apr 17 2018, 2:47 AM

Apr 13 2018

atanasyan updated the diff for D31528: [ELF][MIPS] Multi-GOT implementation.

Rebased against the trunk.

Apr 13 2018, 1:50 AM · lld

atanasyan committed rL329996: [ELF][MIPS] Support linking of PIE for MIPS.

[ELF][MIPS] Support linking of PIE for MIPS

Apr 13 2018, 1:18 AM

atanasyan committed rLLD329996: [ELF][MIPS] Support linking of PIE for MIPS.

[ELF][MIPS] Support linking of PIE for MIPS

Apr 13 2018, 1:18 AM

atanasyan closed D43347: [ELF][MIPS] Support linking of PIE for MIPS.

Apr 13 2018, 1:18 AM · lld

Apr 12 2018

atanasyan added a comment to D45020: [mips] Accept 32-bit offsets for lb and lbu commands.

In D45020#1056816, @sdardis wrote:

we should use the 'mem' operand for the lb and lbu instructions. That will allow the parser to match larger offsets than those instructions permit.

Apr 12 2018, 7:17 AM

Apr 9 2018

atanasyan added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

Ping?

Apr 9 2018, 6:48 AM · lld

Herald added a reviewer for D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps: espindola.

Ping? I'm going to commit this patch in a couple of weeks if I do not receive any objections. We can always perform a post-commit review.

Apr 9 2018, 6:48 AM · lld

Apr 6 2018

atanasyan added a comment to D45020: [mips] Accept 32-bit offsets for lb and lbu commands.

In D45020#1056816, @sdardis wrote:

I don't think this is quite the correct approach, especially if you're going to be implementing support for 64-bit pointers with those instructions, as we would need to modify the existing lb64 and friends to be available to the AsmParser with a different set of operands.

Instead, we should use the 'mem' operand for the lb and lbu instructions. That will allow the parser to match larger offsets than those instructions permit.

Apr 6 2018, 6:41 AM