Page MenuHomePhabricator

atanasyan (Simon Atanasyan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 6 2013, 6:15 AM (368 w, 6 d)

Recent Activity

Fri, Mar 27

atanasyan added inline comments to D76842: [Mips] Make MipsBranchExpansion::replaceBranch() aware of BBIT family of branch.
Fri, Mar 27, 2:52 PM · Restricted Project
atanasyan accepted D76842: [Mips] Make MipsBranchExpansion::replaceBranch() aware of BBIT family of branch.

LGTM. Two nits inlined.

Fri, Mar 27, 1:43 PM · Restricted Project

Sun, Mar 22

atanasyan added a comment to D76247: [MIPS] Implement MIPS3D vector instructions..

Thanks for the catching the issues.

Sun, Mar 22, 2:28 PM · Restricted Project
atanasyan committed rG2dc4eb08cd99: [mips] Implement .cpadd directive (authored by atanasyan).
[mips] Implement .cpadd directive
Sun, Mar 22, 1:56 PM
atanasyan committed rG9bbddfbeaabd: [mips] Implement sne pseudo instruction (authored by atanasyan).
[mips] Implement sne pseudo instruction
Sun, Mar 22, 1:56 PM
atanasyan committed rG862f120fdb0e: [mips] Remove instructions related to "wired paired single" from the P5600… (authored by atanasyan).
[mips] Remove instructions related to "wired paired single" from the P5600…
Sun, Mar 22, 1:56 PM
atanasyan committed rGdca9e40c0cf8: [mips] Implement sle/sleu pseudo instructions (authored by atanasyan).
[mips] Implement sle/sleu pseudo instructions
Sun, Mar 22, 1:56 PM
atanasyan committed rGecc92fd018c6: [mips] Add HasMips3D to the list of features unsupported by P5600 model. (authored by atanasyan).
[mips] Add HasMips3D to the list of features unsupported by P5600 model.
Sun, Mar 22, 1:56 PM
atanasyan committed rG0f15ace018bf: [mips] Rename target feature Mips3D => HasMips3D. NFC (authored by atanasyan).
[mips] Rename target feature Mips3D => HasMips3D. NFC
Sun, Mar 22, 1:56 PM

Tue, Mar 17

atanasyan committed rG73b1da160513: [MIPS] Implement MIPS3D vector instructions (authored by atanasyan).
[MIPS] Implement MIPS3D vector instructions
Tue, Mar 17, 7:26 AM
atanasyan closed D76247: [MIPS] Implement MIPS3D vector instructions..
Tue, Mar 17, 7:26 AM · Restricted Project
atanasyan accepted D76247: [MIPS] Implement MIPS3D vector instructions..

LGTM

Tue, Mar 17, 7:25 AM · Restricted Project

Sun, Mar 15

atanasyan committed rGe0ab0e6a281f: [MIPS] Implement PUL.PS and PUU.PS instructions (authored by atanasyan).
[MIPS] Implement PUL.PS and PUU.PS instructions
Sun, Mar 15, 11:42 PM
atanasyan closed D75812: [MIPS] Implement PUL.PS and PUU.PS instructions.
Sun, Mar 15, 11:42 PM · Restricted Project

Fri, Mar 13

atanasyan accepted D75812: [MIPS] Implement PUL.PS and PUU.PS instructions.

LGTM Thanks for the patch.

Fri, Mar 13, 3:40 PM · Restricted Project

Sun, Mar 8

atanasyan requested changes to D75812: [MIPS] Implement PUL.PS and PUU.PS instructions.

The following test cases failed on my machine. Initially, assembler shows error: unknown instruction. Now assembler shows correct error message instruction requires a CPU feature not currently enabled and the checks should be updated and moved to invalid-xxx.s files.

MC/Mips/mips1/invalid-mips5-wrong-error.s
MC/Mips/mips2/invalid-mips5-wrong-error.s
MC/Mips/mips3/invalid-mips5-wrong-error.s
MC/Mips/mips4/invalid-mips5-wrong-error.s
MC/Mips/mips64r6/invalid-mips5-wrong-error.s
Sun, Mar 8, 5:50 AM · Restricted Project

Feb 27 2020

atanasyan added inline comments to D75216: [lld][ELF] Add some release notes.
Feb 27 2020, 12:21 AM · Restricted Project

Feb 26 2020

atanasyan added inline comments to D75216: [lld][ELF] Add some release notes.
Feb 26 2020, 10:08 PM · Restricted Project

Feb 16 2020

atanasyan accepted D74624: [MIPS GlobalISel] Select 4 byte unaligned load and store.

LGTM

Feb 16 2020, 10:13 PM · Restricted Project
atanasyan accepted D74625: [MIPS GlobalISel] Legalize non-power-of-2 and unaligned load and store.

LGTM

Feb 16 2020, 10:13 PM · Restricted Project
atanasyan accepted D74623: [MIPS GlobalISel] RegBankSelect G_MERGE_VALUES and G_UNMERGE_VALUES.

LGTM

Feb 16 2020, 10:13 PM · Restricted Project

Feb 10 2020

atanasyan accepted D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores..

Looking good to me as-is.

Feb 10 2020, 4:26 AM · Restricted Project, Restricted Project

Feb 6 2020

atanasyan added a comment to D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores..

I see, thanks. Is there the same or similar functionality in GCC?

Feb 6 2020, 8:34 AM · Restricted Project, Restricted Project

Jan 30 2020

atanasyan added a comment to D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores..

Is it possible to emulate these new intrinsics using existing ones and some additional code? Is code generated in this case much larger/slower then the code generated by the new intrinsics?

Jan 30 2020, 5:17 AM · Restricted Project, Restricted Project

Jan 29 2020

atanasyan accepted D73648: Don't mark MIPS TRAP as isTerminator.

LGTM
Thanks

Jan 29 2020, 2:35 PM · Restricted Project

Jan 27 2020

atanasyan accepted D73489: [mips][NFC] Remove unused instruction formats.

LGTM
Thanks

Jan 27 2020, 11:55 AM · Restricted Project

Jan 26 2020

atanasyan closed D73108: [docs][mips] 10.0 Release notes.

Closed by commit rG27f93515.

Jan 26 2020, 6:16 AM · Restricted Project, Restricted Project
atanasyan committed rG27f93515c68b: [docs][mips] 10.0 Release notes (authored by atanasyan).
[docs][mips] 10.0 Release notes
Jan 26 2020, 6:11 AM

Jan 25 2020

atanasyan accepted D73214: [MIPS GlobalISel] Select count leading zeros.

LGTM

Jan 25 2020, 1:51 AM · Restricted Project

Jan 23 2020

atanasyan accepted D73215: [MIPS GlobalISel] Select count trailing zeros.

LGTM

Jan 23 2020, 6:39 AM · Restricted Project
atanasyan accepted D73216: [MIPS GlobalISel] Select population count (popcount).

LGTM

Jan 23 2020, 5:44 AM · Restricted Project
atanasyan added inline comments to D73214: [MIPS GlobalISel] Select count leading zeros.
Jan 23 2020, 4:59 AM · Restricted Project
atanasyan added inline comments to D73214: [MIPS GlobalISel] Select count leading zeros.
Jan 23 2020, 4:41 AM · Restricted Project

Jan 21 2020

atanasyan updated the diff for D73108: [docs][mips] 10.0 Release notes.
  • Add llvm-exegesis note.
Jan 21 2020, 8:33 AM · Restricted Project, Restricted Project
atanasyan added a comment to D73108: [docs][mips] 10.0 Release notes.

Initial MIPS support was also added to llvm-exegesis.

Jan 21 2020, 8:33 AM · Restricted Project, Restricted Project
atanasyan created D73108: [docs][mips] 10.0 Release notes.
Jan 21 2020, 7:25 AM · Restricted Project, Restricted Project

Jan 17 2020

atanasyan accepted D72858: [llvm-exegesis][mips] Add support for memory instructions.

LGTM

Jan 17 2020, 2:10 AM · Restricted Project

Jan 16 2020

atanasyan accepted D72004: [llvm-exegesis][mips] Add RegisterAliasingTest unit test.

LGTM

Jan 16 2020, 8:38 AM · Restricted Project
atanasyan accepted D72794: [LegalizeDAG][Mips] Add an assert to protect a uint_to_fp implementation from double rounding. Add a i32->f32 uint_to_fp implementation that avoids this code..

LGTM

Jan 16 2020, 4:30 AM · Restricted Project
atanasyan accepted D72771: TableGen: Work around assert on Mips register definitions.

I'll take a look on MIPS vector register definitions. Four register classes looks really ill formed.

Jan 16 2020, 4:08 AM · Restricted Project

Jan 13 2020

atanasyan accepted D72571: [MIPS] Don't add R_(MICRO)MIPS_JALR relocations against data symbols.

LGTM

Jan 13 2020, 5:29 AM · Restricted Project

Jan 11 2020

atanasyan accepted D72228: [MIPS][ELF] Use PC-relative relocations in .eh_frame when possible.

I'm sorry for the delay. The patch is LGTM.
Thanks.

Jan 11 2020, 1:47 PM · Restricted Project

Jan 6 2020

atanasyan accepted D72254: MipsDelaySlotFiller: Update registers def-uses for BUNDLE instructions.

LGTM

Jan 6 2020, 8:00 AM · Restricted Project

Jan 4 2020

atanasyan added inline comments to D72003: [llvm-exegesis][NFC] Refactor Mips tests fixtures into a base class.
Jan 4 2020, 3:52 AM · Restricted Project

Dec 27 2019

atanasyan accepted D71363: [MIPS GlobalISel] Select bitreverse.

LGTM

Dec 27 2019, 6:12 AM · Restricted Project

Dec 25 2019

atanasyan accepted D71873: [llvm-exegesis][mips] Expand loadImmediate().

LGTM

Dec 25 2019, 7:01 AM · Restricted Project

Dec 17 2019

atanasyan accepted D71605: [llvm-exegesis][mips] Add lit test.

LGTM

Dec 17 2019, 11:05 AM · Restricted Project

Dec 16 2019

atanasyan accepted D71471: [llvm-exegesis][mips] Add SnippetGeneratorTest unit test.

LGTM

Dec 16 2019, 6:08 AM · Restricted Project
atanasyan accepted D71477: [mips] Add an assert in getTargetStreamer().

LGTM

Dec 16 2019, 6:07 AM · Restricted Project

Dec 12 2019

atanasyan added a comment to D71363: [MIPS GlobalISel] Select bitreverse.

I'll check again on my side tomorrow.

******************** TEST 'LLVM :: CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll' FAILED ********************
Script:
--
: 'RUN: at line 2';   /home/simon/work/llvm/bld/bin/llc -O0 -mtriple=mipsel-linux-gnu -global-isel -verify-machineinstrs /home/simon/work/llvm/git/llvm/test/CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll -o -| /home/simon/work/llvm/bld/bin/FileCheck /home/simon/work/llvm/git/llvm/test/CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll -check-prefixes=MIPS32                                                                                                  
: 'RUN: at line 3';   /home/simon/work/llvm/bld/bin/llc -O0 -mtriple=mipsel-linux-gnu -global-isel -mattr=+mips32r2 -verify-machineinstrs /home/simon/work/llvm/git/llvm/test/CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll -o -|
/home/simon/work/llvm/bld/bin/FileCheck /home/simon/work/llvm/git/llvm/test/CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll -check-prefixes=MIPS32R2                                                                               
--
Exit Code: 1
Dec 12 2019, 10:23 AM · Restricted Project
atanasyan accepted D71265: [llvm-exegesis][mips] Add BenchmarkResultTest unit test.

LGTM

Dec 12 2019, 9:46 AM · Restricted Project
atanasyan accepted D71399: Mips: Make test resistant to future changes.

LGTM

Dec 12 2019, 9:37 AM · Restricted Project
atanasyan accepted D71362: [MIPS GlobalISel] Select bswap.

LGTM

Dec 12 2019, 9:37 AM · Restricted Project
atanasyan added a comment to D71363: [MIPS GlobalISel] Select bitreverse.

When I apply this one and D71362 to the master branch I get a couple of failed tests:

LLVM :: CodeGen/Mips/GlobalISel/legalizer/bitreverse.mir
LLVM :: CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll
Dec 12 2019, 9:37 AM · Restricted Project

Dec 11 2019

atanasyan accepted D71028: [Mips] Add support for min/max/umin/umax atomics.

LGTM

Dec 11 2019, 9:05 AM · Restricted Project

Dec 7 2019

atanasyan added a comment to D71137: [RFC][mips][llvm-exegesis] Fix missing TargetStreamer in the Streamer for reading snippets.

AsmParsers in other architectures have references and use a TargetStreamer too. What's a difference in MIPS? Does MIPS need a TargetStreamer in places where other architectures do not use it?

Dec 7 2019, 1:48 AM · Restricted Project

Dec 5 2019

atanasyan accepted D71028: [Mips] Add support for min/max/umin/umax atomics.

I do not think we can modify the Incr.

Dec 5 2019, 3:16 AM · Restricted Project

Dec 3 2019

atanasyan accepted D70953: Allow negative offsets in MipsMCInstLower::LowerOperand.

LGTM

Dec 3 2019, 7:09 AM · Restricted Project
atanasyan accepted D70945: Handle BUNDLE instructions in MipsAsmPrinter.

LGTM

Dec 3 2019, 5:18 AM · Restricted Project
atanasyan accepted D70944: MipsDelaySlotFiller: Don't move BUNDLE instructions into the delay slot.

LGTM

Dec 3 2019, 5:18 AM · Restricted Project
atanasyan accepted D70940: Add debug output to MipsDelaySlotFiller pass.

LGTM

Dec 3 2019, 5:09 AM · Restricted Project

Nov 28 2019

atanasyan committed rGf4d32ae75bf5: [mips] Check that features required by built-ins are enabled (authored by atanasyan).
[mips] Check that features required by built-ins are enabled
Nov 28 2019, 1:33 PM
atanasyan closed D70808: [mips] Check that features required by built-ins are enabled.
Nov 28 2019, 1:32 PM · Restricted Project
atanasyan created D70808: [mips] Check that features required by built-ins are enabled.
Nov 28 2019, 2:41 AM · Restricted Project

Nov 27 2019

atanasyan commandeered D16674: [mips] Expansion of SC[D] and LL[D] for R6.
Nov 27 2019, 2:40 AM
atanasyan abandoned D16674: [mips] Expansion of SC[D] and LL[D] for R6.

Implemented at https://reviews.llvm.org/rG11074bfffee.

Nov 27 2019, 2:40 AM

Nov 26 2019

atanasyan committed rG11074bfffee0: [mips] Fix sc, scs, ll, lld instructions expanding (authored by atanasyan).
[mips] Fix sc, scs, ll, lld instructions expanding
Nov 26 2019, 1:45 PM
atanasyan closed D70648: [mips] Fix sc, scs, ll, lld instructions expanding.
Nov 26 2019, 1:44 PM · Restricted Project
atanasyan added inline comments to D70648: [mips] Fix sc, scs, ll, lld instructions expanding.
Nov 26 2019, 6:33 AM · Restricted Project

Nov 24 2019

atanasyan updated the summary of D70648: [mips] Fix sc, scs, ll, lld instructions expanding.
Nov 24 2019, 1:29 PM · Restricted Project
atanasyan created D70648: [mips] Fix sc, scs, ll, lld instructions expanding.
Nov 24 2019, 1:29 PM · Restricted Project
atanasyan committed rG1de788a1f16e: [mips] Split test into MIPS and microMIPS parts. NFC (authored by atanasyan).
[mips] Split test into MIPS and microMIPS parts. NFC
Nov 24 2019, 1:20 PM · Restricted Project

Nov 21 2019

atanasyan accepted D70490: [mips] Add a 'generic' Mips CPU.

LGTM

Nov 21 2019, 6:08 AM · Restricted Project
atanasyan added a comment to D70490: [mips] Add a 'generic' Mips CPU.

It gets the 'generic' CPU name with sys::getHostCPUName() and calls createTargetMachine(), which then emits a warning:

'generic' is not a recognized processor for this target (ignoring processor)

Should I add a unittest that recreates this process?

Nov 21 2019, 5:31 AM · Restricted Project
atanasyan committed rGd9cb1b34e068: [mips] Rename test case. NFC (authored by atanasyan).
[mips] Rename test case. NFC
Nov 21 2019, 2:51 AM
atanasyan committed rGcc80695f6f17: [mips] Remove unused `IsPCRelativeLoad` MIPS instructions attribute. NFC (authored by atanasyan).
[mips] Remove unused `IsPCRelativeLoad` MIPS instructions attribute. NFC
Nov 21 2019, 2:51 AM
atanasyan committed rG3d07c3cf7c92: [mips] Remove addresses from the test case. NFC (authored by atanasyan).
[mips] Remove addresses from the test case. NFC
Nov 21 2019, 2:51 AM

Nov 20 2019

atanasyan added a comment to D70490: [mips] Add a 'generic' Mips CPU.

removes a warning when creating a subtarget without the CPU being explicitly specified

Nov 20 2019, 1:58 PM · Restricted Project
atanasyan committed rGa21940eac149: [mips] Define mem_simm# operands using tblgen `foreach` loop. NFC (authored by atanasyan).
[mips] Define mem_simm# operands using tblgen `foreach` loop. NFC
Nov 20 2019, 6:46 AM
atanasyan committed rG452d0b21e00d: [mips] Make MipsAsmParser::isEvaluated static function. NFC (authored by atanasyan).
[mips] Make MipsAsmParser::isEvaluated static function. NFC
Nov 20 2019, 5:13 AM
atanasyan committed rG8ac68f9dc58a: [mips] Put conditions when we need to expand memory operand into a separate… (authored by atanasyan).
[mips] Put conditions when we need to expand memory operand into a separate…
Nov 20 2019, 5:13 AM
atanasyan accepted D70406: Ignore R_MIPS_JALR relocations against non-function symbols.

LGTM. Thanks

Nov 20 2019, 4:02 AM · Restricted Project

Nov 19 2019

atanasyan added inline comments to D70406: Ignore R_MIPS_JALR relocations against non-function symbols.
Nov 19 2019, 5:50 AM · Restricted Project
atanasyan added inline comments to D70406: Ignore R_MIPS_JALR relocations against non-function symbols.
Nov 19 2019, 3:41 AM · Restricted Project
atanasyan committed rG7deb8ce4c161: [mips] Joint MipsMemSimmXXXAsmOperand into the single template class. NFC (authored by atanasyan).
[mips] Joint MipsMemSimmXXXAsmOperand into the single template class. NFC
Nov 19 2019, 3:06 AM

Nov 16 2019

atanasyan committed rG584704c725a2: [mips] Remove redundant cast. NFC (authored by atanasyan).
[mips] Remove redundant cast. NFC
Nov 16 2019, 9:23 AM
atanasyan committed rG6d7fa65c38e7: [mips] Remove old FIXME comment. NFC (authored by atanasyan).
[mips] Remove old FIXME comment. NFC
Nov 16 2019, 9:23 AM

Nov 15 2019

atanasyan committed rG6108eb4e5c9f: [mips] Enable `la` pseudo instruction on 64-bit arch. (authored by atanasyan).
[mips] Enable `la` pseudo instruction on 64-bit arch.
Nov 15 2019, 12:46 PM
atanasyan committed rG0287efb891c1: [mips] Do not emit R_MIPS_JALR for sym+offset in case of O32 ABI (authored by atanasyan).
[mips] Do not emit R_MIPS_JALR for sym+offset in case of O32 ABI
Nov 15 2019, 12:46 PM
atanasyan closed D70202: [mips] Enable `la` pseudo instruction on 64-bit arch.
Nov 15 2019, 12:46 PM · Restricted Project
atanasyan closed D70201: [mips] Do not emit R_MIPS_JALR for sym+offset in case of O32 ABI.
Nov 15 2019, 12:45 PM · Restricted Project
atanasyan added a comment to D70201: [mips] Do not emit R_MIPS_JALR for sym+offset in case of O32 ABI.

Thanks for review.

Nov 15 2019, 12:45 PM · Restricted Project
atanasyan added a comment to D70202: [mips] Enable `la` pseudo instruction on 64-bit arch.

Thanks for review.

Nov 15 2019, 12:45 PM · Restricted Project

Nov 14 2019

atanasyan accepted D70231: [mips][NFC] Remove old FIXME comment.

LGTM

Nov 14 2019, 4:01 AM · Restricted Project

Nov 13 2019

atanasyan committed rGfeee1d58dcd8: [mips] Use local variable to escape repetitive calls of `getOpcode`. NFC (authored by atanasyan).
[mips] Use local variable to escape repetitive calls of `getOpcode`. NFC
Nov 13 2019, 10:34 PM
atanasyan committed rGc2292502d896: [mips] Use isInt<> call instead of explicit range checking. NFC (authored by atanasyan).
[mips] Use isInt<> call instead of explicit range checking. NFC
Nov 13 2019, 10:34 PM
atanasyan created D70202: [mips] Enable `la` pseudo instruction on 64-bit arch.
Nov 13 2019, 12:28 PM · Restricted Project
atanasyan created D70201: [mips] Do not emit R_MIPS_JALR for sym+offset in case of O32 ABI.
Nov 13 2019, 12:26 PM · Restricted Project
atanasyan committed rG63bbbcde9f62: [mips] Reduce number of nested `if` statements. NFC (authored by atanasyan).
[mips] Reduce number of nested `if` statements. NFC
Nov 13 2019, 12:00 PM
atanasyan committed rG14d316228515: [mips] Add test to check ELF output for JAL XGOT expansion. NFC (authored by atanasyan).
[mips] Add test to check ELF output for JAL XGOT expansion. NFC
Nov 13 2019, 12:00 PM