Page MenuHomePhabricator
People atanasyan

atanasyan (Simon Atanasyan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 6 2013, 6:15 AM (323 w, 4 d)

Recent Activity
View All

Wed, May 15

atanasyan committed rCRT360825: [mips] Always use _LARGEFILE_SOURCE / _FILE_OFFSET_BITS for building MIPS 32-bit.
[mips] Always use _LARGEFILE_SOURCE / _FILE_OFFSET_BITS for building MIPS 32-bit
Wed, May 15, 3:28 PM
atanasyan added a comment to D59702: Unbreak the build of compiler-rt on Linux/mips64el.

I hope the rL360825 fixes the problem so this patch can be switch to the abandoned state.

Wed, May 15, 3:28 PM · Restricted Project, Restricted Project
atanasyan committed rG7684d05d95b9: [mips] Always use _LARGEFILE_SOURCE / _FILE_OFFSET_BITS for building MIPS 32-bit (authored by atanasyan).
[mips] Always use _LARGEFILE_SOURCE / _FILE_OFFSET_BITS for building MIPS 32-bit
Wed, May 15, 3:28 PM
atanasyan committed rL360825: [mips] Always use _LARGEFILE_SOURCE / _FILE_OFFSET_BITS for building MIPS 32-bit.
[mips] Always use _LARGEFILE_SOURCE / _FILE_OFFSET_BITS for building MIPS 32-bit
Wed, May 15, 3:25 PM
atanasyan committed rG0b0cc23fb610: [mips] Use range-based `for` loops. NFC (authored by atanasyan).
[mips] Use range-based `for` loops. NFC
Wed, May 15, 2:27 PM
atanasyan committed rL360817: [mips] Use range-based `for` loops. NFC.
[mips] Use range-based `for` loops. NFC
Wed, May 15, 2:27 PM
atanasyan added inline comments to D61787: [GlobalISel Legalizer] Improve artifact combiner.
Wed, May 15, 6:39 AM · Restricted Project
atanasyan committed rG4c68c5ae7194: [mips] LLVM and GAS now use same instructions for CFA Definition. NFCI (authored by atanasyan).
[mips] LLVM and GAS now use same instructions for CFA Definition. NFCI
Wed, May 15, 5:04 AM
atanasyan committed rL360765: [mips] LLVM and GAS now use same instructions for CFA Definition. NFCI.
[mips] LLVM and GAS now use same instructions for CFA Definition. NFCI
Wed, May 15, 5:04 AM
atanasyan closed D61899: [Mips] LLVM and GAS now use same instructions for CFA Definition. NFCI.
Wed, May 15, 5:04 AM · Restricted Project
atanasyan added a comment to D61787: [GlobalISel Legalizer] Improve artifact combiner.

LGTM with a few nits. But I'm not an expert in GlobalISel so get reply from other reviewers.

Wed, May 15, 3:55 AM · Restricted Project
atanasyan accepted D61899: [Mips] LLVM and GAS now use same instructions for CFA Definition. NFCI.

LGTM

Wed, May 15, 2:50 AM · Restricted Project
atanasyan added a comment to D61563: [ELF] Error on relocations to local undefined symbols.

I do not remember a reason of adding the .reloc 0, R_MIPS_GOT_PAGE, 0 statement to the test. I think now we can change mips-abs-got.s like that:

--- a/lld/test/ELF/mips-abs-got.s
+++ b/lld/test/ELF/mips-abs-got.s
@@ -4,7 +4,7 @@
Wed, May 15, 1:54 AM · Restricted Project

Tue, May 7

atanasyan committed rG3bdb81c26da6: [mips] Fix ld instruction in PLT entries on MIPS64 (authored by atanasyan).
[mips] Fix ld instruction in PLT entries on MIPS64
Tue, May 7, 1:26 PM
atanasyan committed rG494b763cfc6a: [mips] Rename test case. NFC (authored by atanasyan).
[mips] Rename test case. NFC
Tue, May 7, 1:26 PM
atanasyan committed rL360187: [mips] Fix ld instruction in PLT entries on MIPS64.
[mips] Fix ld instruction in PLT entries on MIPS64
Tue, May 7, 1:25 PM
atanasyan committed rLLD360187: [mips] Fix ld instruction in PLT entries on MIPS64.
[mips] Fix ld instruction in PLT entries on MIPS64
Tue, May 7, 1:25 PM
atanasyan closed D61586: [mips] fix segment fault for plt on mips64..
Tue, May 7, 1:25 PM · lld, Restricted Project
atanasyan committed rLLD360186: [mips] Rename test case. NFC.
[mips] Rename test case. NFC
Tue, May 7, 1:25 PM
atanasyan committed rL360186: [mips] Rename test case. NFC.
[mips] Rename test case. NFC
Tue, May 7, 1:25 PM

Mon, May 6

atanasyan added a comment to D61586: [mips] fix segment fault for plt on mips64..

Good catch, thanks. BTW on what OS do you get this problem? PLT records on MIPS 64-bit code are not widely used.

Mon, May 6, 3:45 AM · lld, Restricted Project

Sun, May 5

atanasyan abandoned D21292: [mips] Correct ELF format for N32..

Now LLVM/Clang generates correct relocations for N32 ABI:

$ clang -target mips64 -mabi=n32 -mcpu=mips4 -fpic -fPIC -mabicalls -integrated-as -c main.c -o -| llvm-readobj -r -
Sun, May 5, 12:32 AM
atanasyan commandeered D21292: [mips] Correct ELF format for N32..
Sun, May 5, 12:32 AM

Sat, Apr 27

atanasyan committed rGb82144b6e4b5: [cmake] Disable a GCC optimization when building LLVM for MIPS (authored by atanasyan).
[cmake] Disable a GCC optimization when building LLVM for MIPS
Sat, Apr 27, 2:28 AM
atanasyan committed rL359376: [cmake] Disable a GCC optimization when building LLVM for MIPS.
[cmake] Disable a GCC optimization when building LLVM for MIPS
Sat, Apr 27, 2:28 AM
atanasyan closed D48069: [cmake] Disable a GCC optimization when building LLVM for MIPS.
Sat, Apr 27, 2:28 AM · Restricted Project

Thu, Apr 25

atanasyan committed rGa0291110da68: [MIPS] Use custom bitcast lowering to avoid excessive instructions (authored by atanasyan).
[MIPS] Use custom bitcast lowering to avoid excessive instructions
Thu, Apr 25, 12:46 AM
atanasyan committed rL359171: [MIPS] Use custom bitcast lowering to avoid excessive instructions.
[MIPS] Use custom bitcast lowering to avoid excessive instructions
Thu, Apr 25, 12:45 AM
atanasyan closed D61069: [MIPS] Use custom bitcast lowering to avoid excessive instructions.
Thu, Apr 25, 12:45 AM · Restricted Project

Wed, Apr 24

atanasyan accepted D61069: [MIPS] Use custom bitcast lowering to avoid excessive instructions.

LGTM. I would reduce number of tests in the bitcast.ll. I think we can delete all checks with the -mno-ldc1-sdc1 because this option required only to force backend to use the mthc1 instruction.

Wed, Apr 24, 9:21 AM · Restricted Project

Tue, Apr 23

atanasyan accepted D60936: [Mips][CodeGen] Remove MachineFunction::setSubtarget. Change Mips to just copy the subtarget from the MachineFunction instead of recalculating it..

LGTM

Tue, Apr 23, 2:22 PM · Restricted Project
atanasyan added a comment to D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes.

I do not see any problem from MIPS targets point of view.

Tue, Apr 23, 2:01 PM · Restricted Project
atanasyan added a comment to D59702: Unbreak the build of compiler-rt on Linux/mips64el.

I'm sorry for delay with handling this issue.

Tue, Apr 23, 1:58 PM · Restricted Project, Restricted Project

Apr 7 2019

atanasyan added a comment to D35985: Skip live range segment verification for reserved physregs.

This problem has been fixed at rL357472 and the no-odd-spreg-msa.ll test case passes with the -verify-machineinstrs option. D35985 can be closed / abandoned.

Apr 7 2019, 5:52 AM

Apr 3 2019

atanasyan accepted D60191: [MIPS GlobalISel] Select floating point arithmetic operations.

LGTM

Apr 3 2019, 6:31 AM · Restricted Project
atanasyan committed rGeb9ae56157d7: [mips] Remove unused FGRH32 register class. NFC (authored by atanasyan).
[mips] Remove unused FGRH32 register class. NFC
Apr 3 2019, 3:09 AM
atanasyan committed rL357570: [mips] Remove unused FGRH32 register class. NFC.
[mips] Remove unused FGRH32 register class. NFC
Apr 3 2019, 3:09 AM
atanasyan closed D60132: [mips] Remove unused FGRH32 register class. NFC.
Apr 3 2019, 3:09 AM · Restricted Project

Apr 2 2019

atanasyan committed rG751510cd78fb: [driver][mips] Check both `gnuabi64` and `gnu` suffixes in `getMultiarchTriple` (authored by atanasyan).
[driver][mips] Check both `gnuabi64` and `gnu` suffixes in `getMultiarchTriple`
Apr 2 2019, 11:04 AM
atanasyan committed rG27c0f204d79e: [driver] clang-format. Fix indentation, split long lines. NFC (authored by atanasyan).
[driver] clang-format. Fix indentation, split long lines. NFC
Apr 2 2019, 11:03 AM
atanasyan committed rC357506: [driver][mips] Check both `gnuabi64` and `gnu` suffixes in `getMultiarchTriple`.
[driver][mips] Check both `gnuabi64` and `gnu` suffixes in `getMultiarchTriple`
Apr 2 2019, 11:03 AM
atanasyan committed rL357506: [driver][mips] Check both `gnuabi64` and `gnu` suffixes in `getMultiarchTriple`.
[driver][mips] Check both `gnuabi64` and `gnu` suffixes in `getMultiarchTriple`
Apr 2 2019, 11:03 AM
atanasyan committed rC357505: [driver] clang-format. Fix indentation, split long lines. NFC.
[driver] clang-format. Fix indentation, split long lines. NFC
Apr 2 2019, 11:03 AM
atanasyan committed rL357505: [driver] clang-format. Fix indentation, split long lines. NFC.
[driver] clang-format. Fix indentation, split long lines. NFC
Apr 2 2019, 11:03 AM
atanasyan created D60132: [mips] Remove unused FGRH32 register class. NFC.
Apr 2 2019, 8:33 AM · Restricted Project
atanasyan committed rG4cefa15a149e: [mips] Remove the override of the `isMachineVerifierClean()` (authored by atanasyan).
[mips] Remove the override of the `isMachineVerifierClean()`
Apr 2 2019, 6:57 AM
atanasyan committed rG2634a141fdf4: [mips] Use AltOrders to prevent using odd FP-registers (authored by atanasyan).
[mips] Use AltOrders to prevent using odd FP-registers
Apr 2 2019, 6:57 AM
atanasyan committed rL357473: [mips] Remove the override of the `isMachineVerifierClean()`.
[mips] Remove the override of the `isMachineVerifierClean()`
Apr 2 2019, 6:56 AM
atanasyan committed rL357472: [mips] Use AltOrders to prevent using odd FP-registers.
[mips] Use AltOrders to prevent using odd FP-registers
Apr 2 2019, 6:56 AM
atanasyan closed D59799: [wip][mips] Use AltOrders to prevent using odd FP-registers.
Apr 2 2019, 6:56 AM · Restricted Project

Mar 29 2019

atanasyan added a comment to D60006: [SelectionDAG] Add fcmp UNDEF handling to SelectionDAG::FoldSetCC.

The MIPS test change looks good.

Mar 29 2019, 10:05 PM · Restricted Project
atanasyan added a comment to D59799: [wip][mips] Use AltOrders to prevent using odd FP-registers.

Thanks for review.

Mar 29 2019, 8:52 AM · Restricted Project
atanasyan committed rGf26f56d6d3d6: [mips] Fix lowering a signed immediate for *.d MSA instructions (authored by atanasyan).
[mips] Fix lowering a signed immediate for *.d MSA instructions
Mar 29 2019, 8:16 AM
atanasyan committed rL357264: [mips] Fix lowering a signed immediate for *.d MSA instructions.
[mips] Fix lowering a signed immediate for *.d MSA instructions
Mar 29 2019, 8:14 AM
atanasyan closed D59884: [mips] Fix lowering a signed immediate for *.d MSA instructions.
Mar 29 2019, 8:14 AM · Restricted Project

Mar 28 2019

atanasyan accepted D59933: [MIPS GlobalISel] Select float constants.

LGTM

Mar 28 2019, 9:31 AM · Restricted Project

Mar 27 2019

atanasyan updated the diff for D59799: [wip][mips] Use AltOrders to prevent using odd FP-registers.
  • Use more compact definitions of AltOrders
  • Add comments
Mar 27 2019, 3:27 PM · Restricted Project
atanasyan created D59884: [mips] Fix lowering a signed immediate for *.d MSA instructions.
Mar 27 2019, 9:03 AM · Restricted Project

Mar 25 2019

atanasyan created D59799: [wip][mips] Use AltOrders to prevent using odd FP-registers.
Mar 25 2019, 2:28 PM · Restricted Project
atanasyan added a comment to D59702: Unbreak the build of compiler-rt on Linux/mips64el.

How do you build compiler-rt? What OS do yo use?

Mar 25 2019, 7:51 AM · Restricted Project, Restricted Project
atanasyan added inline comments to D59702: Unbreak the build of compiler-rt on Linux/mips64el.
Mar 25 2019, 7:40 AM · Restricted Project, Restricted Project

Mar 24 2019

atanasyan accepted D59644: [MIPS GlobalISel] Select copy for arguments from FPRBRegBank.

LGTM with a nit

Mar 24 2019, 2:44 PM · Restricted Project
atanasyan accepted D59643: [MIPS GlobalISel] Add floating point register bank.

LGTM

Mar 24 2019, 2:37 PM · Restricted Project
atanasyan accepted D59642: [MIPS GlobalISel] Lower float and double arguments in registers.

LGTM

Mar 24 2019, 2:34 PM · Restricted Project
atanasyan committed rT356863: [test-suite][mips] Fix compile options for tramp3d-v4 test.
[test-suite][mips] Fix compile options for tramp3d-v4 test
Mar 24 2019, 11:43 AM
atanasyan committed rL356863: [test-suite][mips] Fix compile options for tramp3d-v4 test.
[test-suite][mips] Fix compile options for tramp3d-v4 test
Mar 24 2019, 11:27 AM
atanasyan closed D59612: [test-suite][mips] Fix compile options for tramp3d-v4 test.
Mar 24 2019, 11:26 AM · Restricted Project
atanasyan accepted D59612: [test-suite][mips] Fix compile options for tramp3d-v4 test.

LGTM

Mar 24 2019, 11:26 AM · Restricted Project

Mar 21 2019

atanasyan added a comment to D59612: [test-suite][mips] Fix compile options for tramp3d-v4 test.

Thanks. I could reproduce the problem with the -O0 option. But I could reproduce the problem for both -mips64r2 and -mips64r6 flags. Is it true for you? If so, I would check for something like $(findstring -mabi=64, $(TARGET_FLAGS)).

Mar 21 2019, 3:03 PM · Restricted Project
atanasyan added a comment to D59612: [test-suite][mips] Fix compile options for tramp3d-v4 test.

Generally the patch looks good. But when I remove -mxgot option completely and unconditionally and run LLVM test suite in both 32 and 64-bit modes, I did not see any new failures. I used both LLD and GNU BFD linkers. Could you check it? What tests and what configurations will fail?

Mar 21 2019, 6:28 AM · Restricted Project

Mar 20 2019

atanasyan added a reviewer for D59575: Mips: Don't create copy of nothing: sdardis.

The patch LGTM. SimonD, as far as I know you are an author of original patch D31287. Do you have any comments / objections against this fix?

Mar 20 2019, 8:22 AM

Mar 19 2019

atanasyan committed rGdb4601e60a0f: [MIPS][microMIPS] Enable dynamic stack realignment (authored by atanasyan).
[MIPS][microMIPS] Enable dynamic stack realignment
Mar 19 2019, 10:05 AM
atanasyan committed rL356478: [MIPS][microMIPS] Enable dynamic stack realignment.
[MIPS][microMIPS] Enable dynamic stack realignment
Mar 19 2019, 10:00 AM
atanasyan closed D59499: [MIPS] [microMIPS] Enable dynamic stack realignment..
Mar 19 2019, 10:00 AM · Restricted Project
atanasyan committed rGaf40d4371d89: [mips] Fix crash on recursive using of .set (authored by atanasyan).
[mips] Fix crash on recursive using of .set
Mar 19 2019, 8:16 AM
atanasyan committed rL356461: [mips] Fix crash on recursive using of .set.
[mips] Fix crash on recursive using of .set
Mar 19 2019, 8:16 AM
atanasyan closed D59452: [mips] Fix crash on recursive using of .set.
Mar 19 2019, 8:16 AM · Restricted Project
atanasyan accepted D59499: [MIPS] [microMIPS] Enable dynamic stack realignment..

LGTM with a few nits

Mar 19 2019, 6:51 AM · Restricted Project

Mar 16 2019

atanasyan created D59452: [mips] Fix crash on recursive using of .set.
Mar 16 2019, 6:47 AM · Restricted Project

Mar 14 2019

atanasyan accepted D59369: [MIPS GlobalISel] Improve selection of constants.

Nice. LGTM

Mar 14 2019, 10:42 PM · Restricted Project

Mar 13 2019

atanasyan committed rLLD356058: [mips] Remove redundant setup of less-significant bit. NFC.
[mips] Remove redundant setup of less-significant bit. NFC
Mar 13 2019, 9:03 AM
atanasyan committed rG3f4870b69270: [mips] Join some adjacent `let DecoderNamespace` blocks. NFC (authored by atanasyan).
[mips] Join some adjacent `let DecoderNamespace` blocks. NFC
Mar 13 2019, 9:03 AM
atanasyan committed rG2e855675eb21: [mips] Remove redundant setup of less-significant bit. NFC (authored by atanasyan).
[mips] Remove redundant setup of less-significant bit. NFC
Mar 13 2019, 9:02 AM
atanasyan committed rL356059: [mips] Join some adjacent `let DecoderNamespace` blocks. NFC.
[mips] Join some adjacent `let DecoderNamespace` blocks. NFC
Mar 13 2019, 9:02 AM
atanasyan committed rL356058: [mips] Remove redundant setup of less-significant bit. NFC.
[mips] Remove redundant setup of less-significant bit. NFC
Mar 13 2019, 9:02 AM
atanasyan committed rG9bfd140ddb82: [mips] Fix encoding of the `mov.d` command for microMIPS R6 (authored by atanasyan).
[mips] Fix encoding of the `mov.d` command for microMIPS R6
Mar 13 2019, 7:26 AM
atanasyan committed rGab45d684066e: [mips] Define `mov.d` instructions using `ABSS_M` multiclass. NFC (authored by atanasyan).
[mips] Define `mov.d` instructions using `ABSS_M` multiclass. NFC
Mar 13 2019, 7:25 AM
atanasyan added a comment to D59045: [mips] Fix encoding of the `mov.d` command for microMIPS R6.

Thanks for the thorough review.

Mar 13 2019, 7:25 AM · Restricted Project
atanasyan committed rL356052: [mips] Fix encoding of the `mov.d` command for microMIPS R6.
[mips] Fix encoding of the `mov.d` command for microMIPS R6
Mar 13 2019, 7:25 AM
atanasyan closed D59045: [mips] Fix encoding of the `mov.d` command for microMIPS R6.
Mar 13 2019, 7:25 AM · Restricted Project
atanasyan committed rL356051: [mips] Define `mov.d` instructions using `ABSS_M` multiclass. NFC.
[mips] Define `mov.d` instructions using `ABSS_M` multiclass. NFC
Mar 13 2019, 7:25 AM
atanasyan committed rGb9d9e0be3cb7: [mips] Map SW instruction to its microMIPS R6 variant (authored by atanasyan).
[mips] Map SW instruction to its microMIPS R6 variant
Mar 13 2019, 6:13 AM
atanasyan added a comment to D59046: [mips] Map SW instruction to its microMIPS R6 variant.

Thanks for the thorough review.

Mar 13 2019, 6:13 AM · Restricted Project
atanasyan committed rL356045: [mips] Map SW instruction to its microMIPS R6 variant.
[mips] Map SW instruction to its microMIPS R6 variant
Mar 13 2019, 6:08 AM
atanasyan closed D59046: [mips] Map SW instruction to its microMIPS R6 variant.
Mar 13 2019, 6:08 AM · Restricted Project
atanasyan added a comment to D59204: [MIPS] [microMIPS] Fix PseudoMTLOHI_MM expansion.

OK, thanks. Probably I missed the revision status update.

Mar 13 2019, 5:54 AM
atanasyan added a comment to D59204: [MIPS] [microMIPS] Fix PseudoMTLOHI_MM expansion.

Could you abandon the patch because the changes have been committed at the rL356039?

Mar 13 2019, 4:09 AM
atanasyan committed rGc2b975a75cad: [MIPS][microMIPS] Fix PseudoMTLOHI_MM matching and expansion (authored by atanasyan).
[MIPS][microMIPS] Fix PseudoMTLOHI_MM matching and expansion
Mar 13 2019, 4:04 AM
atanasyan committed rGc71100204153: [mips] Fix CPU used in the test case to suppress warning. NFC (authored by atanasyan).
[mips] Fix CPU used in the test case to suppress warning. NFC
Mar 13 2019, 4:04 AM
atanasyan committed rL356039: [MIPS][microMIPS] Fix PseudoMTLOHI_MM matching and expansion.
[MIPS][microMIPS] Fix PseudoMTLOHI_MM matching and expansion
Mar 13 2019, 4:03 AM