Page MenuHomePhabricator
People atanasyan

atanasyan (Simon Atanasyan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 6 2013, 6:15 AM (358 w, 2 d)

Recent Activity
View All

Yesterday

atanasyan accepted D72858: [llvm-exegesis][mips] Add support for memory instructions.

LGTM

Fri, Jan 17, 2:10 AM · Restricted Project

Thu, Jan 16

atanasyan accepted D72004: [llvm-exegesis][mips] Add RegisterAliasingTest unit test.

LGTM

Thu, Jan 16, 8:38 AM · Restricted Project
atanasyan accepted D72794: [LegalizeDAG][Mips] Add an assert to protect a uint_to_fp implementation from double rounding. Add a i32->f32 uint_to_fp implementation that avoids this code..

LGTM

Thu, Jan 16, 4:30 AM · Restricted Project
atanasyan accepted D72771: TableGen: Work around assert on Mips register definitions.

I'll take a look on MIPS vector register definitions. Four register classes looks really ill formed.

Thu, Jan 16, 4:08 AM · Restricted Project

Mon, Jan 13

atanasyan accepted D72571: [MIPS] Don't add R_(MICRO)MIPS_JALR relocations against data symbols.

LGTM

Mon, Jan 13, 5:29 AM · Restricted Project

Sat, Jan 11

atanasyan accepted D72228: [MIPS][ELF] Use PC-relative relocations in .eh_frame when possible.

I'm sorry for the delay. The patch is LGTM.
Thanks.

Sat, Jan 11, 1:47 PM · Restricted Project

Mon, Jan 6

atanasyan accepted D72254: MipsDelaySlotFiller: Update registers def-uses for BUNDLE instructions.

LGTM

Mon, Jan 6, 8:00 AM · Restricted Project

Sat, Jan 4

atanasyan added inline comments to D72003: [llvm-exegesis][NFC] Refactor Mips tests fixtures into a base class.
Sat, Jan 4, 3:52 AM · Restricted Project

Fri, Dec 27

atanasyan accepted D71363: [MIPS GlobalISel] Select bitreverse.

LGTM

Fri, Dec 27, 6:12 AM · Restricted Project

Wed, Dec 25

atanasyan accepted D71873: [llvm-exegesis][mips] Expand loadImmediate().

LGTM

Wed, Dec 25, 7:01 AM · Restricted Project

Dec 17 2019

atanasyan accepted D71605: [llvm-exegesis][mips] Add lit test.

LGTM

Dec 17 2019, 11:05 AM · Restricted Project

Dec 16 2019

atanasyan accepted D71471: [llvm-exegesis][mips] Add SnippetGeneratorTest unit test.

LGTM

Dec 16 2019, 6:08 AM · Restricted Project
atanasyan accepted D71477: [mips] Add an assert in getTargetStreamer().

LGTM

Dec 16 2019, 6:07 AM · Restricted Project

Dec 12 2019

atanasyan added a comment to D71363: [MIPS GlobalISel] Select bitreverse.

I'll check again on my side tomorrow.

******************** TEST 'LLVM :: CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll' FAILED ********************
Script:
--
: 'RUN: at line 2';   /home/simon/work/llvm/bld/bin/llc -O0 -mtriple=mipsel-linux-gnu -global-isel -verify-machineinstrs /home/simon/work/llvm/git/llvm/test/CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll -o -| /home/simon/work/llvm/bld/bin/FileCheck /home/simon/work/llvm/git/llvm/test/CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll -check-prefixes=MIPS32                                                                                                  
: 'RUN: at line 3';   /home/simon/work/llvm/bld/bin/llc -O0 -mtriple=mipsel-linux-gnu -global-isel -mattr=+mips32r2 -verify-machineinstrs /home/simon/work/llvm/git/llvm/test/CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll -o -|
/home/simon/work/llvm/bld/bin/FileCheck /home/simon/work/llvm/git/llvm/test/CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll -check-prefixes=MIPS32R2                                                                               
--
Exit Code: 1
Dec 12 2019, 10:23 AM · Restricted Project
atanasyan accepted D71265: [llvm-exegesis][mips] Add BenchmarkResultTest unit test.

LGTM

Dec 12 2019, 9:46 AM · Restricted Project
atanasyan accepted D71399: Mips: Make test resistant to future changes.

LGTM

Dec 12 2019, 9:37 AM · Restricted Project
atanasyan accepted D71362: [MIPS GlobalISel] Select bswap.

LGTM

Dec 12 2019, 9:37 AM · Restricted Project
atanasyan added a comment to D71363: [MIPS GlobalISel] Select bitreverse.

When I apply this one and D71362 to the master branch I get a couple of failed tests:

LLVM :: CodeGen/Mips/GlobalISel/legalizer/bitreverse.mir
LLVM :: CodeGen/Mips/GlobalISel/llvm-ir/bitreverse.ll
Dec 12 2019, 9:37 AM · Restricted Project

Dec 11 2019

atanasyan accepted D71028: [Mips] Add support for min/max/umin/umax atomics.

LGTM

Dec 11 2019, 9:05 AM · Restricted Project

Dec 7 2019

atanasyan added a comment to D71137: [RFC][mips][llvm-exegesis] Fix missing TargetStreamer in the Streamer for reading snippets.

AsmParsers in other architectures have references and use a TargetStreamer too. What's a difference in MIPS? Does MIPS need a TargetStreamer in places where other architectures do not use it?

Dec 7 2019, 1:48 AM · Restricted Project

Dec 5 2019

atanasyan accepted D71028: [Mips] Add support for min/max/umin/umax atomics.

I do not think we can modify the Incr.

Dec 5 2019, 3:16 AM · Restricted Project

Dec 3 2019

atanasyan accepted D70953: Allow negative offsets in MipsMCInstLower::LowerOperand.

LGTM

Dec 3 2019, 7:09 AM · Restricted Project
atanasyan accepted D70945: Handle BUNDLE instructions in MipsAsmPrinter.

LGTM

Dec 3 2019, 5:18 AM · Restricted Project
atanasyan accepted D70944: MipsDelaySlotFiller: Don't move BUNDLE instructions into the delay slot.

LGTM

Dec 3 2019, 5:18 AM · Restricted Project
atanasyan accepted D70940: Add debug output to MipsDelaySlotFiller pass.

LGTM

Dec 3 2019, 5:09 AM · Restricted Project

Nov 28 2019

atanasyan committed rGf4d32ae75bf5: [mips] Check that features required by built-ins are enabled (authored by atanasyan).
[mips] Check that features required by built-ins are enabled
Nov 28 2019, 1:33 PM
atanasyan closed D70808: [mips] Check that features required by built-ins are enabled.
Nov 28 2019, 1:32 PM · Restricted Project
atanasyan created D70808: [mips] Check that features required by built-ins are enabled.
Nov 28 2019, 2:41 AM · Restricted Project

Nov 27 2019

atanasyan commandeered D16674: [mips] Expansion of SC[D] and LL[D] for R6.
Nov 27 2019, 2:40 AM
atanasyan abandoned D16674: [mips] Expansion of SC[D] and LL[D] for R6.

Implemented at https://reviews.llvm.org/rG11074bfffee.

Nov 27 2019, 2:40 AM

Nov 26 2019

atanasyan committed rG11074bfffee0: [mips] Fix sc, scs, ll, lld instructions expanding (authored by atanasyan).
[mips] Fix sc, scs, ll, lld instructions expanding
Nov 26 2019, 1:45 PM
atanasyan closed D70648: [mips] Fix sc, scs, ll, lld instructions expanding.
Nov 26 2019, 1:44 PM · Restricted Project
atanasyan added inline comments to D70648: [mips] Fix sc, scs, ll, lld instructions expanding.
Nov 26 2019, 6:33 AM · Restricted Project

Nov 24 2019

atanasyan updated the summary of D70648: [mips] Fix sc, scs, ll, lld instructions expanding.
Nov 24 2019, 1:29 PM · Restricted Project
atanasyan created D70648: [mips] Fix sc, scs, ll, lld instructions expanding.
Nov 24 2019, 1:29 PM · Restricted Project
atanasyan committed rG1de788a1f16e: [mips] Split test into MIPS and microMIPS parts. NFC (authored by atanasyan).
[mips] Split test into MIPS and microMIPS parts. NFC
Nov 24 2019, 1:20 PM · Restricted Project

Nov 21 2019

atanasyan accepted D70490: [mips] Add a 'generic' Mips CPU.

LGTM

Nov 21 2019, 6:08 AM · Restricted Project
atanasyan added a comment to D70490: [mips] Add a 'generic' Mips CPU.
In D70490#1754970, @mstojanovic wrote:

It gets the 'generic' CPU name with sys::getHostCPUName() and calls createTargetMachine(), which then emits a warning:

'generic' is not a recognized processor for this target (ignoring processor)

Should I add a unittest that recreates this process?

Nov 21 2019, 5:31 AM · Restricted Project
atanasyan committed rGd9cb1b34e068: [mips] Rename test case. NFC (authored by atanasyan).
[mips] Rename test case. NFC
Nov 21 2019, 2:51 AM
atanasyan committed rGcc80695f6f17: [mips] Remove unused `IsPCRelativeLoad` MIPS instructions attribute. NFC (authored by atanasyan).
[mips] Remove unused `IsPCRelativeLoad` MIPS instructions attribute. NFC
Nov 21 2019, 2:51 AM
atanasyan committed rG3d07c3cf7c92: [mips] Remove addresses from the test case. NFC (authored by atanasyan).
[mips] Remove addresses from the test case. NFC
Nov 21 2019, 2:51 AM

Nov 20 2019

atanasyan added a comment to D70490: [mips] Add a 'generic' Mips CPU.

removes a warning when creating a subtarget without the CPU being explicitly specified

Nov 20 2019, 1:58 PM · Restricted Project
atanasyan committed rGa21940eac149: [mips] Define mem_simm# operands using tblgen `foreach` loop. NFC (authored by atanasyan).
[mips] Define mem_simm# operands using tblgen `foreach` loop. NFC
Nov 20 2019, 6:46 AM
atanasyan committed rG452d0b21e00d: [mips] Make MipsAsmParser::isEvaluated static function. NFC (authored by atanasyan).
[mips] Make MipsAsmParser::isEvaluated static function. NFC
Nov 20 2019, 5:13 AM
atanasyan committed rG8ac68f9dc58a: [mips] Put conditions when we need to expand memory operand into a separate… (authored by atanasyan).
[mips] Put conditions when we need to expand memory operand into a separate…
Nov 20 2019, 5:13 AM
atanasyan accepted D70406: Ignore R_MIPS_JALR relocations against non-function symbols.

LGTM. Thanks

Nov 20 2019, 4:02 AM · Restricted Project

Nov 19 2019

atanasyan added inline comments to D70406: Ignore R_MIPS_JALR relocations against non-function symbols.
Nov 19 2019, 5:50 AM · Restricted Project
atanasyan added inline comments to D70406: Ignore R_MIPS_JALR relocations against non-function symbols.
Nov 19 2019, 3:41 AM · Restricted Project
atanasyan committed rG7deb8ce4c161: [mips] Joint MipsMemSimmXXXAsmOperand into the single template class. NFC (authored by atanasyan).
[mips] Joint MipsMemSimmXXXAsmOperand into the single template class. NFC
Nov 19 2019, 3:06 AM

Nov 16 2019

atanasyan committed rG584704c725a2: [mips] Remove redundant cast. NFC (authored by atanasyan).
[mips] Remove redundant cast. NFC
Nov 16 2019, 9:23 AM
atanasyan committed rG6d7fa65c38e7: [mips] Remove old FIXME comment. NFC (authored by atanasyan).
[mips] Remove old FIXME comment. NFC
Nov 16 2019, 9:23 AM

Nov 15 2019

atanasyan committed rG6108eb4e5c9f: [mips] Enable `la` pseudo instruction on 64-bit arch. (authored by atanasyan).
[mips] Enable `la` pseudo instruction on 64-bit arch.
Nov 15 2019, 12:46 PM
atanasyan committed rG0287efb891c1: [mips] Do not emit R_MIPS_JALR for sym+offset in case of O32 ABI (authored by atanasyan).
[mips] Do not emit R_MIPS_JALR for sym+offset in case of O32 ABI
Nov 15 2019, 12:46 PM
atanasyan closed D70202: [mips] Enable `la` pseudo instruction on 64-bit arch.
Nov 15 2019, 12:46 PM · Restricted Project
atanasyan closed D70201: [mips] Do not emit R_MIPS_JALR for sym+offset in case of O32 ABI.
Nov 15 2019, 12:45 PM · Restricted Project
atanasyan added a comment to D70201: [mips] Do not emit R_MIPS_JALR for sym+offset in case of O32 ABI.

Thanks for review.

Nov 15 2019, 12:45 PM · Restricted Project
atanasyan added a comment to D70202: [mips] Enable `la` pseudo instruction on 64-bit arch.

Thanks for review.

Nov 15 2019, 12:45 PM · Restricted Project

Nov 14 2019

atanasyan accepted D70231: [mips][NFC] Remove old FIXME comment.

LGTM

Nov 14 2019, 4:01 AM · Restricted Project

Nov 13 2019

atanasyan committed rGfeee1d58dcd8: [mips] Use local variable to escape repetitive calls of `getOpcode`. NFC (authored by atanasyan).
[mips] Use local variable to escape repetitive calls of `getOpcode`. NFC
Nov 13 2019, 10:34 PM
atanasyan committed rGc2292502d896: [mips] Use isInt<> call instead of explicit range checking. NFC (authored by atanasyan).
[mips] Use isInt<> call instead of explicit range checking. NFC
Nov 13 2019, 10:34 PM
atanasyan created D70202: [mips] Enable `la` pseudo instruction on 64-bit arch.
Nov 13 2019, 12:28 PM · Restricted Project
atanasyan created D70201: [mips] Do not emit R_MIPS_JALR for sym+offset in case of O32 ABI.
Nov 13 2019, 12:26 PM · Restricted Project
atanasyan committed rG63bbbcde9f62: [mips] Reduce number of nested `if` statements. NFC (authored by atanasyan).
[mips] Reduce number of nested `if` statements. NFC
Nov 13 2019, 12:00 PM
atanasyan committed rG14d316228515: [mips] Add test to check ELF output for JAL XGOT expansion. NFC (authored by atanasyan).
[mips] Add test to check ELF output for JAL XGOT expansion. NFC
Nov 13 2019, 12:00 PM
atanasyan committed rG3216d284491f: [mips] Add tests to check `jal sym+offset`. NFC (authored by atanasyan).
[mips] Add tests to check `jal sym+offset`. NFC
Nov 13 2019, 12:00 PM
atanasyan accepted D70184: [MIPS GlobalISel] Select addiu.

LGTM

Nov 13 2019, 10:55 AM · Restricted Project
atanasyan accepted D70185: [MIPS GlobalISel] Select andi, ori and xori.

LGTM

Nov 13 2019, 10:55 AM · Restricted Project
atanasyan committed rGb3853d852629: [mips][test] Add Mips CPU tests. NFC (authored by atanasyan).
[mips][test] Add Mips CPU tests. NFC
Nov 13 2019, 2:34 AM
atanasyan committed rG068db2ed4d18: [mips] Show an error if 64-bit target triple provided with 32-bit CPU (authored by atanasyan).
[mips] Show an error if 64-bit target triple provided with 32-bit CPU
Nov 13 2019, 2:34 AM
atanasyan closed D70018: [mips][test] Check if the subtarget can support the requested triple width.
Nov 13 2019, 2:33 AM · Restricted Project
atanasyan closed D70017: [mips][test] Add Mips CPU tests.
Nov 13 2019, 2:33 AM · Restricted Project

Nov 12 2019

atanasyan accepted D69898: [Mips] Add rematerialization support for ldi.fmt.

LGTM

Nov 12 2019, 12:10 PM · Restricted Project
atanasyan accepted D70017: [mips][test] Add Mips CPU tests.
In D70017#1742283, @mstojanovic wrote:

Do you think the tests from D70018 should also be in the same file or is it fine how it is?

Nov 12 2019, 7:41 AM · Restricted Project
atanasyan accepted D70018: [mips][test] Check if the subtarget can support the requested triple width.

LGTM

Nov 12 2019, 7:41 AM · Restricted Project

Nov 11 2019

atanasyan added a comment to D69898: [Mips] Add rematerialization support for ldi.fmt.

As far as I understand the code, overriding isReallyTriviallyReMaterializable and reMaterialize is not mandatory to avoid spill for ldi.fmt. Let's split the patch. The first patch could adds isReMaterializable flag to the MSA_I10_LDI_DESC_BASE and test the change. The second one - overrides isReallyTriviallyReMaterializable and reMaterialize. By the way, what is a goal of overriding reMaterialize? Does it give any benefit?

Nov 11 2019, 8:13 AM · Restricted Project

Nov 8 2019

atanasyan added a comment to D70017: [mips][test] Add Mips CPU tests.
  • I suggest to join both test cases into the single one
  • Let's check more then empty stderr in case of success. For example, we can generate an object file, run llvm-readelf -A and check ISA: and ISA Extension: lines. Something like this:
; RUN: llc -mtriple=mips64 -mcpu=mips64r3 -filetype=obj < %s | llvm-readelf -A | FileCheck %s --check-prefix=MIPS64R3
; MIPS64R3: ISA: MIPS64r3
Nov 8 2019, 10:34 PM · Restricted Project
atanasyan added inline comments to D70018: [mips][test] Check if the subtarget can support the requested triple width.
Nov 8 2019, 10:15 PM · Restricted Project

Nov 7 2019

atanasyan added a comment to D69556: [CodeGen] Move ARMCodegenPrepare to TypePromotion.
In D69556#1726776, @samparker wrote:

@asb and @atanasyan would you be interested in getting some numbers for your targets?

Nov 7 2019, 3:33 AM · Restricted Project
atanasyan committed rGa751f557d824: [mips] Set macros for Octeon+ CPU (authored by atanasyan).
[mips] Set macros for Octeon+ CPU
Nov 7 2019, 3:05 AM
atanasyan committed rG3552d3e0f7c9: [mips] Add `octeon+` to the list of CPUs accepted by the driver (authored by atanasyan).
[mips] Add `octeon+` to the list of CPUs accepted by the driver
Nov 7 2019, 3:05 AM
atanasyan committed rGbf996f761b99: [mips] Write `AFL_EXT_OCTEONP` flag to the `.MIPS.abiflags` section (authored by atanasyan).
[mips] Write `AFL_EXT_OCTEONP` flag to the `.MIPS.abiflags` section
Nov 7 2019, 3:04 AM
atanasyan closed D69851: [mips] Write `AFL_EXT_OCTEONP` flag to the `.MIPS.abiflags` section.
Nov 7 2019, 3:04 AM · Restricted Project
atanasyan committed rG3718102d40d6: [mips] Support `octeon+` CPU in the `.set arch=` directive (authored by atanasyan).
[mips] Support `octeon+` CPU in the `.set arch=` directive
Nov 7 2019, 3:04 AM
atanasyan closed D69850: [mips] Support `octeon+` CPU in the `.set arch=` directive.
Nov 7 2019, 3:04 AM · Restricted Project
atanasyan committed rG7bed381eae12: [mips] Implement Octeon+ `saa` and `saad` instructions (authored by atanasyan).
[mips] Implement Octeon+ `saa` and `saad` instructions
Nov 7 2019, 3:04 AM
atanasyan closed D69849: [mips] Implement Octeon+ `saa` and `saad` instructions.
Nov 7 2019, 3:04 AM · Restricted Project
atanasyan abandoned D48006: [WIP][utils][mips] Modify scrubbing to handle inline ASM .

The problem fixed at rGa8a89c77ea3c

Nov 7 2019, 12:22 AM · Restricted Project
atanasyan commandeered D48006: [WIP][utils][mips] Modify scrubbing to handle inline ASM .
Nov 7 2019, 12:22 AM · Restricted Project
atanasyan added a comment to D69849: [mips] Implement Octeon+ `saa` and `saad` instructions.

Thanks for review.

Nov 7 2019, 12:13 AM · Restricted Project

Nov 5 2019

atanasyan committed rG37f4955c9bab: [mips] Fix `getRegForInlineAsmConstraint` to do not crash on empty Constraint (authored by atanasyan).
[mips] Fix `getRegForInlineAsmConstraint` to do not crash on empty Constraint
Nov 5 2019, 1:52 PM
atanasyan added a parent revision for D69851: [mips] Write `AFL_EXT_OCTEONP` flag to the `.MIPS.abiflags` section: D69849: [mips] Implement Octeon+ `saa` and `saad` instructions.
Nov 5 2019, 8:10 AM · Restricted Project
atanasyan added a child revision for D69849: [mips] Implement Octeon+ `saa` and `saad` instructions: D69851: [mips] Write `AFL_EXT_OCTEONP` flag to the `.MIPS.abiflags` section.
Nov 5 2019, 8:10 AM · Restricted Project
atanasyan created D69850: [mips] Support `octeon+` CPU in the `.set arch=` directive.
Nov 5 2019, 8:10 AM · Restricted Project
atanasyan created D69851: [mips] Write `AFL_EXT_OCTEONP` flag to the `.MIPS.abiflags` section.
Nov 5 2019, 8:10 AM · Restricted Project
atanasyan added a parent revision for D69850: [mips] Support `octeon+` CPU in the `.set arch=` directive: D69849: [mips] Implement Octeon+ `saa` and `saad` instructions.
Nov 5 2019, 8:10 AM · Restricted Project
atanasyan added a child revision for D69849: [mips] Implement Octeon+ `saa` and `saad` instructions: D69850: [mips] Support `octeon+` CPU in the `.set arch=` directive.
Nov 5 2019, 8:10 AM · Restricted Project
atanasyan created D69849: [mips] Implement Octeon+ `saa` and `saad` instructions.
Nov 5 2019, 8:01 AM · Restricted Project
atanasyan committed rG0d14656b9d8c: [mips] Set __OCTEON__ macros (authored by atanasyan).
[mips] Set __OCTEON__ macros
Nov 5 2019, 1:13 AM
atanasyan committed rGe578d0fd295a: [mips] Fix `__mips_isa_rev` macros value for Octeon CPU (authored by atanasyan).
[mips] Fix `__mips_isa_rev` macros value for Octeon CPU
Nov 5 2019, 1:13 AM
atanasyan accepted D69712: [MIPS GlobalISel] Select MSA insert_vector_elt with variable index.

LGTM

Nov 5 2019, 12:33 AM · Restricted Project