Page MenuHomePhabricator

atanasyan (Simon Atanasyan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 6 2013, 6:15 AM (315 w, 8 h)

Recent Activity

Today

atanasyan added a reviewer for D59575: Mips: Don't create copy of nothing: sdardis.

The patch LGTM. SimonD, as far as I know you are an author of original patch D31287. Do you have any comments / objections against this fix?

Wed, Mar 20, 8:22 AM

Yesterday

atanasyan committed rGdb4601e60a0f: [MIPS][microMIPS] Enable dynamic stack realignment (authored by atanasyan).
[MIPS][microMIPS] Enable dynamic stack realignment
Tue, Mar 19, 10:05 AM
atanasyan committed rL356478: [MIPS][microMIPS] Enable dynamic stack realignment.
[MIPS][microMIPS] Enable dynamic stack realignment
Tue, Mar 19, 10:00 AM
atanasyan closed D59499: [MIPS] [microMIPS] Enable dynamic stack realignment..
Tue, Mar 19, 10:00 AM · Restricted Project
atanasyan committed rGaf40d4371d89: [mips] Fix crash on recursive using of .set (authored by atanasyan).
[mips] Fix crash on recursive using of .set
Tue, Mar 19, 8:16 AM
atanasyan committed rL356461: [mips] Fix crash on recursive using of .set.
[mips] Fix crash on recursive using of .set
Tue, Mar 19, 8:16 AM
atanasyan closed D59452: [mips] Fix crash on recursive using of .set.
Tue, Mar 19, 8:16 AM · Restricted Project
atanasyan accepted D59499: [MIPS] [microMIPS] Enable dynamic stack realignment..

LGTM with a few nits

Tue, Mar 19, 6:51 AM · Restricted Project

Sat, Mar 16

atanasyan created D59452: [mips] Fix crash on recursive using of .set.
Sat, Mar 16, 6:47 AM · Restricted Project

Thu, Mar 14

atanasyan accepted D59369: [MIPS GlobalISel] Improve selection of constants.

Nice. LGTM

Thu, Mar 14, 10:42 PM · Restricted Project

Wed, Mar 13

atanasyan committed rLLD356058: [mips] Remove redundant setup of less-significant bit. NFC.
[mips] Remove redundant setup of less-significant bit. NFC
Wed, Mar 13, 9:03 AM
atanasyan committed rG3f4870b69270: [mips] Join some adjacent `let DecoderNamespace` blocks. NFC (authored by atanasyan).
[mips] Join some adjacent `let DecoderNamespace` blocks. NFC
Wed, Mar 13, 9:03 AM
atanasyan committed rG2e855675eb21: [mips] Remove redundant setup of less-significant bit. NFC (authored by atanasyan).
[mips] Remove redundant setup of less-significant bit. NFC
Wed, Mar 13, 9:02 AM
atanasyan committed rL356059: [mips] Join some adjacent `let DecoderNamespace` blocks. NFC.
[mips] Join some adjacent `let DecoderNamespace` blocks. NFC
Wed, Mar 13, 9:02 AM
atanasyan committed rL356058: [mips] Remove redundant setup of less-significant bit. NFC.
[mips] Remove redundant setup of less-significant bit. NFC
Wed, Mar 13, 9:02 AM
atanasyan committed rG9bfd140ddb82: [mips] Fix encoding of the `mov.d` command for microMIPS R6 (authored by atanasyan).
[mips] Fix encoding of the `mov.d` command for microMIPS R6
Wed, Mar 13, 7:26 AM
atanasyan committed rGab45d684066e: [mips] Define `mov.d` instructions using `ABSS_M` multiclass. NFC (authored by atanasyan).
[mips] Define `mov.d` instructions using `ABSS_M` multiclass. NFC
Wed, Mar 13, 7:25 AM
atanasyan added a comment to D59045: [mips] Fix encoding of the `mov.d` command for microMIPS R6.

Thanks for the thorough review.

Wed, Mar 13, 7:25 AM · Restricted Project
atanasyan committed rL356052: [mips] Fix encoding of the `mov.d` command for microMIPS R6.
[mips] Fix encoding of the `mov.d` command for microMIPS R6
Wed, Mar 13, 7:25 AM
atanasyan closed D59045: [mips] Fix encoding of the `mov.d` command for microMIPS R6.
Wed, Mar 13, 7:25 AM · Restricted Project
atanasyan committed rL356051: [mips] Define `mov.d` instructions using `ABSS_M` multiclass. NFC.
[mips] Define `mov.d` instructions using `ABSS_M` multiclass. NFC
Wed, Mar 13, 7:25 AM
atanasyan committed rGb9d9e0be3cb7: [mips] Map SW instruction to its microMIPS R6 variant (authored by atanasyan).
[mips] Map SW instruction to its microMIPS R6 variant
Wed, Mar 13, 6:13 AM
atanasyan added a comment to D59046: [mips] Map SW instruction to its microMIPS R6 variant.

Thanks for the thorough review.

Wed, Mar 13, 6:13 AM · Restricted Project
atanasyan committed rL356045: [mips] Map SW instruction to its microMIPS R6 variant.
[mips] Map SW instruction to its microMIPS R6 variant
Wed, Mar 13, 6:08 AM
atanasyan closed D59046: [mips] Map SW instruction to its microMIPS R6 variant.
Wed, Mar 13, 6:08 AM · Restricted Project
atanasyan added a comment to D59204: [MIPS] [microMIPS] Fix PseudoMTLOHI_MM expansion.

OK, thanks. Probably I missed the revision status update.

Wed, Mar 13, 5:54 AM
atanasyan added a comment to D59204: [MIPS] [microMIPS] Fix PseudoMTLOHI_MM expansion.

Could you abandon the patch because the changes have been committed at the rL356039?

Wed, Mar 13, 4:09 AM
atanasyan committed rGc2b975a75cad: [MIPS][microMIPS] Fix PseudoMTLOHI_MM matching and expansion (authored by atanasyan).
[MIPS][microMIPS] Fix PseudoMTLOHI_MM matching and expansion
Wed, Mar 13, 4:04 AM
atanasyan committed rGc71100204153: [mips] Fix CPU used in the test case to suppress warning. NFC (authored by atanasyan).
[mips] Fix CPU used in the test case to suppress warning. NFC
Wed, Mar 13, 4:04 AM
atanasyan committed rL356039: [MIPS][microMIPS] Fix PseudoMTLOHI_MM matching and expansion.
[MIPS][microMIPS] Fix PseudoMTLOHI_MM matching and expansion
Wed, Mar 13, 4:03 AM
atanasyan closed D59203: [MIPS] [microMIPS] Fix PseudoMTLOHI_MM matching and expansion.
Wed, Mar 13, 4:03 AM · Restricted Project
atanasyan committed rL356038: [mips] Fix CPU used in the test case to suppress warning. NFC.
[mips] Fix CPU used in the test case to suppress warning. NFC
Wed, Mar 13, 4:03 AM

Mon, Mar 11

atanasyan added inline comments to D35985: Skip live range segment verification for reserved physregs.
Mon, Mar 11, 3:53 PM
atanasyan added a reviewer for D35985: Skip live range segment verification for reserved physregs: arsenm.

Matt, Matthias, could you please review the last version of the patch again? Stefan's comments look reasonable to me.

Mon, Mar 11, 1:32 PM
atanasyan added inline comments to D58826: [MIPS GlobalISel] NarrowScalar G_SMULH.
Mon, Mar 11, 8:29 AM
atanasyan added a comment to D59046: [mips] Map SW instruction to its microMIPS R6 variant.

SWSP instruction has the same encoding for both standard and r6 microMIPS (LOAD_STORE_SP_FM_MM16<0x32>).
If we change SWSP_MM from ISA_MICROMIPS32_NOT_MIPS32R6 to ISA_MICROMIPS, SWSP_MM could be used for R6 size reduction also.
SWSP_MMR6 looks redundant?

Mon, Mar 11, 8:20 AM · Restricted Project
atanasyan accepted D59203: [MIPS] [microMIPS] Fix PseudoMTLOHI_MM matching and expansion.

We can drop micromips-pseudo-mtlohi-match.ll and keep the micromips-pseudo-mtlohi-expand.ll only because this test checks all that is necessary. With this modification the patch is LGTM.

Mon, Mar 11, 6:48 AM · Restricted Project
atanasyan updated the diff for D59045: [mips] Fix encoding of the `mov.d` command for microMIPS R6.
  • Select microMIPS R6 variant of the mov.d instruction in the MipsSEInstrInfo::copyPhysReg method.
Mon, Mar 11, 6:32 AM · Restricted Project
atanasyan added a comment to D59203: [MIPS] [microMIPS] Fix PseudoMTLOHI_MM matching and expansion.

I think we can join D59203 and D59204 patches. Now LLVM incorrectly generates dsp instructions in all cases. After applying D59203 it starts to use PseudoMTLOHI_MM, but test case from the D59204 crashes llc. And after applying the D59204 everything work okay. Let's do an atomic change.

Mon, Mar 11, 4:32 AM · Restricted Project
atanasyan added a comment to D58826: [MIPS GlobalISel] NarrowScalar G_SMULH.

Could you rebase the patch?

Mon, Mar 11, 4:14 AM

Sun, Mar 10

atanasyan accepted D58825: [MIPS GlobalISel] NarrowScalar G_UMULH.

LGTM

Sun, Mar 10, 9:17 PM · Restricted Project

Thu, Mar 7

atanasyan accepted D58715: [MIPS GlobalISel] Fix mul operands.

LGTM

Thu, Mar 7, 4:45 AM · Restricted Project

Wed, Mar 6

atanasyan committed rG83b88441ad95: [mips] Replace assertion by error message while lowering `RETURNADDR` and… (authored by atanasyan).
[mips] Replace assertion by error message while lowering `RETURNADDR` and…
Wed, Mar 6, 2:40 PM
atanasyan committed rL355558: [mips] Replace assertion by error message while lowering `RETURNADDR` and….
[mips] Replace assertion by error message while lowering `RETURNADDR` and…
Wed, Mar 6, 2:40 PM
atanasyan created D59046: [mips] Map SW instruction to its microMIPS R6 variant.
Wed, Mar 6, 1:35 PM · Restricted Project
atanasyan created D59045: [mips] Fix encoding of the `mov.d` command for microMIPS R6.
Wed, Mar 6, 1:34 PM · Restricted Project

Thu, Feb 28

atanasyan accepted D58714: [MIPS GlobalISel] Select G_UMULH.

LGTM

Thu, Feb 28, 6:52 AM · Restricted Project
atanasyan accepted D58715: [MIPS GlobalISel] Fix mul operands.

LGTM

Thu, Feb 28, 6:52 AM · Restricted Project

Tue, Feb 26

atanasyan accepted D58671: [MIPS GlobalISel] Select G_UADDO .

LGTM

Tue, Feb 26, 8:44 AM · Restricted Project
atanasyan committed rG8cb497027d26: [mips] Emit `.module softfloat` directive (authored by atanasyan).
[mips] Emit `.module softfloat` directive
Tue, Feb 26, 6:47 AM
atanasyan committed rL354882: [mips] Emit `.module softfloat` directive.
[mips] Emit `.module softfloat` directive
Tue, Feb 26, 6:47 AM

Mon, Feb 25

atanasyan committed rG478cd32bcb7a: [mips] Reduce number of tools invocations in the test. NFC (authored by atanasyan).
[mips] Reduce number of tools invocations in the test. NFC
Mon, Feb 25, 3:30 AM
atanasyan committed rL354772: [mips] Reduce number of tools invocations in the test. NFC.
[mips] Reduce number of tools invocations in the test. NFC
Mon, Feb 25, 3:30 AM
atanasyan committed rLLD354772: [mips] Reduce number of tools invocations in the test. NFC.
[mips] Reduce number of tools invocations in the test. NFC
Mon, Feb 25, 3:29 AM
atanasyan accepted D58576: [Mips] Fix missing masking in fast-isel of br (PR40325).

Do you have commit access?

Mon, Feb 25, 12:24 AM · Restricted Project

Wed, Feb 20

atanasyan accepted D58352: Mips: Add ImmArg to intrinsics.

LGTM

Wed, Feb 20, 7:22 AM
atanasyan committed rG14b09810a03e: [mips] Put some MIPS-specific sections to separate segments (authored by atanasyan).
[mips] Put some MIPS-specific sections to separate segments
Wed, Feb 20, 6:47 AM
atanasyan committed rLLD354468: [mips] Put some MIPS-specific sections to separate segments.
[mips] Put some MIPS-specific sections to separate segments
Wed, Feb 20, 6:47 AM
atanasyan committed rL354468: [mips] Put some MIPS-specific sections to separate segments.
[mips] Put some MIPS-specific sections to separate segments
Wed, Feb 20, 6:47 AM
atanasyan closed D58381: [mips] Put some MIPS-specific sections to separate segments.
Wed, Feb 20, 6:46 AM · Restricted Project, lld
atanasyan accepted D58225: [MIPS MSA] Avoid some DAG combines for vector shifts.

LGTM

Wed, Feb 20, 5:17 AM · Restricted Project

Tue, Feb 19

atanasyan updated the diff for D58381: [mips] Put some MIPS-specific sections to separate segments.
  • Fixed function arguments' names
  • Added test for the PT_MIPS_OPTIONS segment creation
Tue, Feb 19, 8:04 AM · Restricted Project, lld
atanasyan committed rG2fdd1597153e: [mips] Fix indentations in the test. NFC (authored by atanasyan).
[mips] Fix indentations in the test. NFC
Tue, Feb 19, 8:00 AM
atanasyan committed rL354341: [mips] Fix indentations in the test. NFC.
[mips] Fix indentations in the test. NFC
Tue, Feb 19, 8:00 AM
atanasyan committed rLLD354341: [mips] Fix indentations in the test. NFC.
[mips] Fix indentations in the test. NFC
Tue, Feb 19, 8:00 AM
atanasyan committed rG37a1d6eca3bc: Convert the eh-frame-hdr-abs-fde.s test to use x86 as a target architecture (authored by atanasyan).
Convert the eh-frame-hdr-abs-fde.s test to use x86 as a target architecture
Tue, Feb 19, 7:21 AM
atanasyan committed rL354336: Convert the eh-frame-hdr-abs-fde.s test to use x86 as a target architecture.
Convert the eh-frame-hdr-abs-fde.s test to use x86 as a target architecture
Tue, Feb 19, 7:21 AM
atanasyan committed rLLD354336: Convert the eh-frame-hdr-abs-fde.s test to use x86 as a target architecture.
Convert the eh-frame-hdr-abs-fde.s test to use x86 as a target architecture
Tue, Feb 19, 7:20 AM
atanasyan added a comment to D58381: [mips] Put some MIPS-specific sections to separate segments.

Thanks for review.

Tue, Feb 19, 6:30 AM · Restricted Project, lld
atanasyan added a comment to D58352: Mips: Add ImmArg to intrinsics.

Unfortunately the current patch shows the error on compilation:

Tue, Feb 19, 5:43 AM
atanasyan added a comment to D58352: Mips: Add ImmArg to intrinsics.

Thanks for pointing to the problem. Could you provide the "assertion" used for finding the issue?

Tue, Feb 19, 3:33 AM
atanasyan committed rG40fb1c95eea9: [mips] Remove trailing whitespaces from the test case. NFC (authored by atanasyan).
[mips] Remove trailing whitespaces from the test case. NFC
Tue, Feb 19, 3:20 AM
atanasyan committed rLLD354315: [mips] Remove trailing whitespaces from the test case. NFC.
[mips] Remove trailing whitespaces from the test case. NFC
Tue, Feb 19, 3:19 AM
atanasyan committed rL354315: [mips] Remove trailing whitespaces from the test case. NFC.
[mips] Remove trailing whitespaces from the test case. NFC
Tue, Feb 19, 3:19 AM
atanasyan created D58381: [mips] Put some MIPS-specific sections to separate segments.
Tue, Feb 19, 3:19 AM · Restricted Project, lld
atanasyan committed rGa6012a65d47d: [mips] Create LA25 thunks for MIPS R6 code (authored by atanasyan).
[mips] Create LA25 thunks for MIPS R6 code
Tue, Feb 19, 3:12 AM
atanasyan committed rL354312: [mips] Create LA25 thunks for MIPS R6 code.
[mips] Create LA25 thunks for MIPS R6 code
Tue, Feb 19, 3:11 AM
atanasyan committed rLLD354312: [mips] Create LA25 thunks for MIPS R6 code.
[mips] Create LA25 thunks for MIPS R6 code
Tue, Feb 19, 3:10 AM
atanasyan committed rGfae2a509fa5a: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps (authored by atanasyan).
[MIPS] Handle cross-mode (regular <-> microMIPS) jumps
Tue, Feb 19, 2:39 AM
atanasyan committed rLLD354311: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.
[MIPS] Handle cross-mode (regular <-> microMIPS) jumps
Tue, Feb 19, 2:38 AM
atanasyan committed rL354311: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.
[MIPS] Handle cross-mode (regular <-> microMIPS) jumps
Tue, Feb 19, 2:37 AM
atanasyan closed D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.
Tue, Feb 19, 2:36 AM · Restricted Project, lld

Feb 14 2019

atanasyan accepted D58183: [MIPS GlobalISel] Select phi instruction for integers .

LGTM

Feb 14 2019, 2:35 AM · Restricted Project
atanasyan accepted D58182: [MIPS GlobalISel] Select branch instructions .

LGTM

Feb 14 2019, 2:33 AM · Restricted Project

Feb 13 2019

atanasyan committed rG4c22a574140c: [Headers][mips] Add `__attribute__((__mode__(__unwind_word__)))` to the… (authored by atanasyan).
[Headers][mips] Add `__attribute__((__mode__(__unwind_word__)))` to the…
Feb 13 2019, 10:27 AM
atanasyan committed rL353965: [Headers][mips] Add `__attribute__((__mode__(__unwind_word__)))` to the….
[Headers][mips] Add `__attribute__((__mode__(__unwind_word__)))` to the…
Feb 13 2019, 10:27 AM
atanasyan committed rC353965: [Headers][mips] Add `__attribute__((__mode__(__unwind_word__)))` to the….
[Headers][mips] Add `__attribute__((__mode__(__unwind_word__)))` to the…
Feb 13 2019, 10:27 AM
atanasyan closed D58165: [Headers][mips] Add `__attribute__((__mode__(__unwind_word__)))` to the _Unwind_Word / _Unwind_SWord definitions.
Feb 13 2019, 10:27 AM · Restricted Project

Feb 12 2019

atanasyan created D58165: [Headers][mips] Add `__attribute__((__mode__(__unwind_word__)))` to the _Unwind_Word / _Unwind_SWord definitions.
Feb 12 2019, 11:10 PM · Restricted Project

Feb 11 2019

atanasyan added a comment to D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.

@ruiu : Do you have any comments?

Feb 11 2019, 7:43 AM · Restricted Project, lld

Feb 8 2019

atanasyan accepted D57454: [MIPS GlobalISel] Select any extending load and truncating store.

LGTM

Feb 8 2019, 6:22 AM · Restricted Project
atanasyan added a comment to D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.

LGTM, but please wait for Rui's opinion too.

Feb 8 2019, 3:45 AM · Restricted Project, lld
atanasyan updated the diff for D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.
  • Use if instead of switch
Feb 8 2019, 3:45 AM · Restricted Project, lld

Feb 7 2019

atanasyan accepted D57816: [MIPS GlobalISel] Select mul.

LGTM

Feb 7 2019, 3:08 PM · Restricted Project

Feb 6 2019

atanasyan updated the diff for D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.
  • Move the most part of manipulations with the less-significant bit to the getSymVA and Symbol::getPltVA() methods.
Feb 6 2019, 11:59 PM · Restricted Project, lld
atanasyan added a comment to D57816: [MIPS GlobalISel] Select mul.

The mul.mir failed on my machine:

mul.mir:22:12: error: MIPS32: expected string not found in input
Feb 6 2019, 2:24 PM · Restricted Project
atanasyan accepted D57677: [mips][micromips] Fix values in .gcc_except_table for -fPIC.

LGTM

Feb 6 2019, 2:11 PM · Restricted Project

Jan 30 2019

atanasyan committed rL352682: [docs][mips] 8.0 Release notes.
[docs][mips] 8.0 Release notes
Jan 30 2019, 2:45 PM
atanasyan closed D57457: [docs][mips] 8.0 Release notes.
Jan 30 2019, 2:45 PM
atanasyan committed rL352675: [docs][mips] Clang 8.0 Release notes.
[docs][mips] Clang 8.0 Release notes
Jan 30 2019, 1:19 PM