Page MenuHomePhabricator
People atanasyan

atanasyan (Simon Atanasyan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 6 2013, 6:15 AM (332 w, 4 d)

Recent Activity
View All

Wed, Jul 17

atanasyan added inline comments to D58232: WIP: GlobalISel: Don't materialize immarg arguments to intrinsics.
Wed, Jul 17, 11:01 AM
atanasyan accepted D64856: [MIPS GlobalISel] ClampScalar and select pointer G_ICMP.

LGTM

Wed, Jul 17, 4:51 AM · Restricted Project
atanasyan accepted D64778: Mips: Remove immarg from copy and insert intrinsics.

LGTM

Wed, Jul 17, 2:43 AM
atanasyan committed rG1292464125fd: [mips] Remove redundant test case. NFC (authored by atanasyan).
[mips] Remove redundant test case. NFC
Wed, Jul 17, 1:14 AM
atanasyan committed rG6d4b1c046b82: [mips] Name inline asm constraint test cases in a uniform manner. NFC (authored by atanasyan).
[mips] Name inline asm constraint test cases in a uniform manner. NFC
Wed, Jul 17, 1:14 AM
atanasyan committed rG7f308af5eeea: [mips] Support the "o" inline asm constraint (authored by atanasyan).
[mips] Support the "o" inline asm constraint
Wed, Jul 17, 1:14 AM
atanasyan committed rG4c1e4408927e: [mips] Use mult/mflo pattern on 64-bit targets prior to MIPS64 (authored by atanasyan).
[mips] Use mult/mflo pattern on 64-bit targets prior to MIPS64
Wed, Jul 17, 1:14 AM
atanasyan committed rGa884afb6f8ea: [mips] Implement .cplocal directive (authored by atanasyan).
[mips] Implement .cplocal directive
Wed, Jul 17, 1:14 AM
atanasyan committed rL366302: [mips] Name inline asm constraint test cases in a uniform manner. NFC.
[mips] Name inline asm constraint test cases in a uniform manner. NFC
Wed, Jul 17, 1:14 AM
atanasyan committed rL366303: [mips] Remove redundant test case. NFC.
[mips] Remove redundant test case. NFC
Wed, Jul 17, 1:14 AM
atanasyan committed rL366300: [mips] Implement .cplocal directive.
[mips] Implement .cplocal directive
Wed, Jul 17, 1:14 AM
atanasyan committed rL366301: [mips] Use mult/mflo pattern on 64-bit targets prior to MIPS64.
[mips] Use mult/mflo pattern on 64-bit targets prior to MIPS64
Wed, Jul 17, 1:14 AM
atanasyan closed D64743: [mips] Implement .cplocal directive.
Wed, Jul 17, 1:14 AM · Restricted Project
atanasyan committed rL366299: [mips] Support the "o" inline asm constraint.
[mips] Support the "o" inline asm constraint
Wed, Jul 17, 1:13 AM
atanasyan closed D64792: [mips] Support the "o" inline asm constraint.
Wed, Jul 17, 1:13 AM · Restricted Project

Tue, Jul 16

atanasyan created D64792: [mips] Support the "o" inline asm constraint.
Tue, Jul 16, 5:32 AM · Restricted Project

Mon, Jul 15

atanasyan added a comment to D6016: [mips] MIPS BEQZL and BNEZL instructions.
In D6016#1585878, @mstojanovic wrote:

Maybe we should add the tests that this patch had since they were not added in rL234401.
rL234401 also disabled printing of the alias instruction while it's enabled in here. Not sure which one is preferable.

Mon, Jul 15, 2:53 PM
atanasyan committed rGbecae2b2324f: [mips] Print BEQZL and BNEZL pseudo instructions (authored by atanasyan).
[mips] Print BEQZL and BNEZL pseudo instructions
Mon, Jul 15, 2:47 PM
atanasyan committed rL366133: [mips] Print BEQZL and BNEZL pseudo instructions.
[mips] Print BEQZL and BNEZL pseudo instructions
Mon, Jul 15, 2:47 PM
atanasyan created D64743: [mips] Implement .cplocal directive.
Mon, Jul 15, 7:39 AM · Restricted Project
atanasyan committed rG83ae0b5eb4f8: [mips] Remove "else-after-return". NFC (authored by atanasyan).
[mips] Remove "else-after-return". NFC
Mon, Jul 15, 6:13 AM
atanasyan committed rL366064: [mips] Remove "else-after-return". NFC.
[mips] Remove "else-after-return". NFC
Mon, Jul 15, 6:12 AM

Fri, Jul 12

atanasyan abandoned D10119: [mips][microMIPS] Implement SB, SBE, SCE, SH and SHE instructions.

Implemented at the rL246999.

Fri, Jul 12, 10:55 PM
atanasyan commandeered D10119: [mips][microMIPS] Implement SB, SBE, SCE, SH and SHE instructions.
Fri, Jul 12, 10:55 PM
atanasyan abandoned D8823: [mips][microMIPSr6] Implement LL and SC instructions.

Implemented at the rL332820.

Fri, Jul 12, 10:48 PM
atanasyan commandeered D8823: [mips][microMIPSr6] Implement LL and SC instructions.
Fri, Jul 12, 10:47 PM
atanasyan abandoned D6016: [mips] MIPS BEQZL and BNEZL instructions.

Implemented at the rL234401.

Fri, Jul 12, 10:43 PM
atanasyan commandeered D6016: [mips] MIPS BEQZL and BNEZL instructions.
Fri, Jul 12, 10:43 PM

Thu, Jul 11

atanasyan added a comment to D63973: [MachineVerifier] Improve checks of target instructions operands..

I hope the problem with MIPS tests was fixed at the rL365870.

Thu, Jul 11, 10:25 PM
atanasyan committed rGee5af50eb0c3: [mips] Fix JmpLink to texternalsym and tglobaladdr on mcroMIPS R6 (authored by atanasyan).
[mips] Fix JmpLink to texternalsym and tglobaladdr on mcroMIPS R6
Thu, Jul 11, 10:00 PM
atanasyan committed rL365870: [mips] Fix JmpLink to texternalsym and tglobaladdr on mcroMIPS R6.
[mips] Fix JmpLink to texternalsym and tglobaladdr on mcroMIPS R6
Thu, Jul 11, 9:58 PM
atanasyan closed D64552: [mips] Fix JmpLink to texternalsym and tglobaladdr on mcroMIPS R6.
Thu, Jul 11, 9:58 PM · Restricted Project
atanasyan added a comment to rL365619: [ELF] Update test case due to llvm r365618.

I simplify the test at rL365834. Hope this help.

Thu, Jul 11, 2:59 PM
atanasyan committed rG5dd5541d9f6b: [mips] Simplify test case. NFC (authored by atanasyan).
[mips] Simplify test case. NFC
Thu, Jul 11, 2:57 PM
atanasyan committed rL365834: [mips] Simplify test case. NFC.
[mips] Simplify test case. NFC
Thu, Jul 11, 2:56 PM
atanasyan created D64552: [mips] Fix JmpLink to texternalsym and tglobaladdr on mcroMIPS R6.
Thu, Jul 11, 3:13 AM · Restricted Project

Wed, Jul 10

atanasyan accepted D64486: [MIPS GlobalISel] Skip copies in addUseDef and addDefUses.

LGTM

Wed, Jul 10, 11:12 PM · Restricted Project
atanasyan accepted D64485: [MIPS GlobalISel] RegBankSelect for chains of ambiguous instructions.

LGTM with a nit

Wed, Jul 10, 11:10 PM · Restricted Project
atanasyan accepted D64420: [MIPS GlobalISel] Select float and double phi.

LGTM with a nit

Wed, Jul 10, 3:13 AM · Restricted Project
atanasyan accepted D64419: [MIPS GlobalISel] Select float and double load and store.

LGTM with a nit

Wed, Jul 10, 3:13 AM · Restricted Project

Tue, Jul 9

atanasyan committed rGe3892d84e0c1: [mips] Show error in case of using FP64 mode on pre MIPS32R2 CPU (authored by atanasyan).
[mips] Show error in case of using FP64 mode on pre MIPS32R2 CPU
Tue, Jul 9, 8:49 AM
atanasyan committed rG623282f0dd7f: [mips] Explicitly select `mips32r2` CPU for test cases require 64-bit FPU. NFC (authored by atanasyan).
[mips] Explicitly select `mips32r2` CPU for test cases require 64-bit FPU. NFC
Tue, Jul 9, 8:49 AM
atanasyan committed rL365507: [mips] Explicitly select `mips32r2` CPU for test cases require 64-bit FPU. NFC.
[mips] Explicitly select `mips32r2` CPU for test cases require 64-bit FPU. NFC
Tue, Jul 9, 8:48 AM
atanasyan committed rL365508: [mips] Show error in case of using FP64 mode on pre MIPS32R2 CPU.
[mips] Show error in case of using FP64 mode on pre MIPS32R2 CPU
Tue, Jul 9, 8:48 AM
atanasyan accepted D64351: [MIPS GlobalISel] Register bank select for G_PHI. Select i64 phi.

LGTM

Tue, Jul 9, 6:50 AM · Restricted Project
atanasyan accepted D64350: [MIPS GlobalISel] Regbanks for G_SELECT. Select i64, f32 and f64 select.

LGTM

Tue, Jul 9, 6:50 AM · Restricted Project
atanasyan committed rG2fa6b5463563: [mips] Implement sge/sgeu pseudo instructions (authored by atanasyan).
[mips] Implement sge/sgeu pseudo instructions
Tue, Jul 9, 5:57 AM
atanasyan committed rG00df4d92edac: [mips] Implement sgt/sgtu pseudo instructions with immediate operand (authored by atanasyan).
[mips] Implement sgt/sgtu pseudo instructions with immediate operand
Tue, Jul 9, 5:57 AM
atanasyan committed rL365476: [mips] Implement sge/sgeu pseudo instructions.
[mips] Implement sge/sgeu pseudo instructions
Tue, Jul 9, 5:57 AM
atanasyan closed D64314: [mips] Implement sge/sgeu pseudo instructions.
Tue, Jul 9, 5:56 AM · Restricted Project
atanasyan committed rL365475: [mips] Implement sgt/sgtu pseudo instructions with immediate operand.
[mips] Implement sgt/sgtu pseudo instructions with immediate operand
Tue, Jul 9, 5:56 AM
atanasyan closed D64313: [mips] Implement sgt/sgtu pseudo instructions with immediate operand.
Tue, Jul 9, 5:56 AM · Restricted Project

Mon, Jul 8

atanasyan added a comment to D63973: [MachineVerifier] Improve checks of target instructions operands..
In D63973#1570197, @jonpa wrote:

The tests I listed are still failing, see above for details. What should be done about them? Could perhaps someone from each target look into the problems?

Mon, Jul 8, 4:31 AM
atanasyan created D64314: [mips] Implement sge/sgeu pseudo instructions.
Mon, Jul 8, 1:42 AM · Restricted Project
atanasyan created D64313: [mips] Implement sgt/sgtu pseudo instructions with immediate operand.
Mon, Jul 8, 1:38 AM · Restricted Project
atanasyan added a comment to D64252: [Mips] Instruction `sc` now accepts symbol as an argument.

I cannot invent any negative test case / example, but I'm concerned a bit that we completely drop information about out-register. The sc instruction has output result but we do not track that fact in td file just in our mind.

Mon, Jul 8, 1:20 AM · Restricted Project

Sat, Jul 6

atanasyan accepted D64269: [MIPS GlobalISel] Register bank select for G_LOAD. Select i64 load.

LGTM with a nit

Sat, Jul 6, 6:59 AM · Restricted Project
atanasyan accepted D64268: [MIPS GlobalISel] Register bank select for G_STORE. Select i64 store.

LGTM with a few code-style nits.

Sat, Jul 6, 6:59 AM · Restricted Project

Thu, Jul 4

atanasyan committed rG1e9c00308b0d: [mips] Refactor expandSeq and expandSeqI methods. NFC (authored by atanasyan).
[mips] Refactor expandSeq and expandSeqI methods. NFC
Thu, Jul 4, 3:46 PM
atanasyan committed rL365161: [mips] Refactor expandSeq and expandSeqI methods. NFC.
[mips] Refactor expandSeq and expandSeqI methods. NFC
Thu, Jul 4, 3:45 PM

Wed, Jul 3

atanasyan committed rGa10bf0939d65: [mips] Mark general scheduling model as complete (authored by atanasyan).
[mips] Mark general scheduling model as complete
Wed, Jul 3, 5:30 AM
atanasyan committed rG4d364659f9d7: [mips] Add missing atomic instructions to general scheduling definitions (authored by atanasyan).
[mips] Add missing atomic instructions to general scheduling definitions
Wed, Jul 3, 5:29 AM
atanasyan committed rG3e4c7eb33ef4: [mips] Add missing microMIPS instructions to general scheduling definitions (authored by atanasyan).
[mips] Add missing microMIPS instructions to general scheduling definitions
Wed, Jul 3, 5:29 AM
atanasyan committed rL365034: [mips] Mark general scheduling model as complete.
[mips] Mark general scheduling model as complete
Wed, Jul 3, 5:29 AM
atanasyan committed rL365033: [mips] Add missing atomic instructions to general scheduling definitions.
[mips] Add missing atomic instructions to general scheduling definitions
Wed, Jul 3, 5:29 AM
atanasyan committed rL365032: [mips] Add missing microMIPS instructions to general scheduling definitions.
[mips] Add missing microMIPS instructions to general scheduling definitions
Wed, Jul 3, 5:29 AM
atanasyan committed rG3e41b97f141e: [mips] Add SIGRIE,GINVI,GINVT to general scheduling definitions (authored by atanasyan).
[mips] Add SIGRIE,GINVI,GINVT to general scheduling definitions
Wed, Jul 3, 3:38 AM
atanasyan committed rGdc3c67bbe218: [mips] Add missing mips16 instructions to general scheduling definitions (authored by atanasyan).
[mips] Add missing mips16 instructions to general scheduling definitions
Wed, Jul 3, 3:38 AM
atanasyan committed rGe5dfbe83b601: [mips] Replace some itineraries by instructions in the general scheduling… (authored by atanasyan).
[mips] Replace some itineraries by instructions in the general scheduling…
Wed, Jul 3, 3:38 AM
atanasyan committed rGb04f6a1a25d5: [mips] Add missing MSA and ASE instructions to general scheduling definitions (authored by atanasyan).
[mips] Add missing MSA and ASE instructions to general scheduling definitions
Wed, Jul 3, 3:38 AM
atanasyan committed rL365023: [mips] Add SIGRIE,GINVI,GINVT to general scheduling definitions.
[mips] Add SIGRIE,GINVI,GINVT to general scheduling definitions
Wed, Jul 3, 3:33 AM
atanasyan committed rL365022: [mips] Add missing mips16 instructions to general scheduling definitions.
[mips] Add missing mips16 instructions to general scheduling definitions
Wed, Jul 3, 3:33 AM
atanasyan committed rL365021: [mips] Add missing MSA and ASE instructions to general scheduling definitions.
[mips] Add missing MSA and ASE instructions to general scheduling definitions
Wed, Jul 3, 3:33 AM
atanasyan committed rL365020: [mips] Replace some itineraries by instructions in the general scheduling….
[mips] Replace some itineraries by instructions in the general scheduling…
Wed, Jul 3, 3:33 AM

Tue, Jul 2

atanasyan committed rG1d7d0e21263c: [mips] Mark P5600 scheduling model as complete (authored by atanasyan).
[mips] Mark P5600 scheduling model as complete
Tue, Jul 2, 3:25 AM
atanasyan committed rGf2867518b315: [mips] Add missing schedinfo for FPU load/store/conv instructions (authored by atanasyan).
[mips] Add missing schedinfo for FPU load/store/conv instructions
Tue, Jul 2, 3:24 AM
atanasyan committed rG116cf95c00a3: [mips] Map SNOP, NOP to the P5600Nop scheduler resource (authored by atanasyan).
[mips] Map SNOP, NOP to the P5600Nop scheduler resource
Tue, Jul 2, 3:24 AM
atanasyan committed rL364902: [mips] Mark P5600 scheduling model as complete.
[mips] Mark P5600 scheduling model as complete
Tue, Jul 2, 3:24 AM
atanasyan committed rL364900: [mips] Add missing schedinfo for FPU load/store/conv instructions.
[mips] Add missing schedinfo for FPU load/store/conv instructions
Tue, Jul 2, 3:24 AM
atanasyan committed rL364899: [mips] Map SNOP, NOP to the P5600Nop scheduler resource.
[mips] Map SNOP, NOP to the P5600Nop scheduler resource
Tue, Jul 2, 3:24 AM

Mon, Jul 1

atanasyan committed rGfa27500676ab: [mips] Add missing schedinfo for MIPSeh_return[32|64] instructions (authored by atanasyan).
[mips] Add missing schedinfo for MIPSeh_return[32|64] instructions
Mon, Jul 1, 2:26 PM
atanasyan committed rG29801f78515b: [mips] Add virtualization ASE to P5600 scheduling definitions (authored by atanasyan).
[mips] Add virtualization ASE to P5600 scheduling definitions
Mon, Jul 1, 2:26 PM
atanasyan committed rG574d0a61bdda: [mips] Add missing schedinfo for LONG_BRANCH_* instructions (authored by atanasyan).
[mips] Add missing schedinfo for LONG_BRANCH_* instructions
Mon, Jul 1, 2:26 PM
atanasyan committed rL364850: [mips] Add missing schedinfo for MIPSeh_return[32|64] instructions.
[mips] Add missing schedinfo for MIPSeh_return[32|64] instructions
Mon, Jul 1, 2:26 PM
atanasyan committed rL364849: [mips] Add virtualization ASE to P5600 scheduling definitions.
[mips] Add virtualization ASE to P5600 scheduling definitions
Mon, Jul 1, 2:25 PM
atanasyan committed rL364848: [mips] Add missing schedinfo for LONG_BRANCH_* instructions.
[mips] Add missing schedinfo for LONG_BRANCH_* instructions
Mon, Jul 1, 2:25 PM
atanasyan committed rGceb9da5bc792: [mips] Add missing schedinfo for MSA and ASE instructions (authored by atanasyan).
[mips] Add missing schedinfo for MSA and ASE instructions
Mon, Jul 1, 6:23 AM
atanasyan committed rGc0121bf87415: [mips] Add missing schedinfo for atomic instructions (authored by atanasyan).
[mips] Add missing schedinfo for atomic instructions
Mon, Jul 1, 6:23 AM
atanasyan committed rG3a10810b7ab0: [mips] Add missing schedinfo for ADJCALLSTACKDOWN, ADJCALLSTACKUP (authored by atanasyan).
[mips] Add missing schedinfo for ADJCALLSTACKDOWN, ADJCALLSTACKUP
Mon, Jul 1, 6:23 AM
atanasyan committed rL364757: [mips] Add missing schedinfo for MSA and ASE instructions.
[mips] Add missing schedinfo for MSA and ASE instructions
Mon, Jul 1, 6:22 AM
atanasyan committed rL364756: [mips] Add missing schedinfo for atomic instructions.
[mips] Add missing schedinfo for atomic instructions
Mon, Jul 1, 6:22 AM
atanasyan committed rL364755: [mips] Add missing schedinfo for ADJCALLSTACKDOWN, ADJCALLSTACKUP.
[mips] Add missing schedinfo for ADJCALLSTACKDOWN, ADJCALLSTACKUP
Mon, Jul 1, 6:22 AM

Thu, Jun 27

atanasyan committed rGe9ec0b6f094f: [mips] Mark pseudo select instructions by the `hasNoSchedulingInfo` tag (authored by atanasyan).
[mips] Mark pseudo select instructions by the `hasNoSchedulingInfo` tag
Thu, Jun 27, 6:42 AM
atanasyan committed rG7c83f0705a8c: [mips] Add new items to the list of features unsupported by P5600 (authored by atanasyan).
[mips] Add new items to the list of features unsupported by P5600
Thu, Jun 27, 6:42 AM
atanasyan committed rL364540: [mips] Mark pseudo select instructions by the `hasNoSchedulingInfo` tag.
[mips] Mark pseudo select instructions by the `hasNoSchedulingInfo` tag
Thu, Jun 27, 6:42 AM
atanasyan committed rL364539: [mips] Add new items to the list of features unsupported by P5600.
[mips] Add new items to the list of features unsupported by P5600
Thu, Jun 27, 6:42 AM
atanasyan committed rG8c35c438162e: [mips] Add GPR_64 predicate to some mov[zn] instructions (authored by atanasyan).
[mips] Add GPR_64 predicate to some mov[zn] instructions
Thu, Jun 27, 5:10 AM
atanasyan committed rGbf5fc620d95b: [mips] Fix indentation and split long lines. NFC (authored by atanasyan).
[mips] Fix indentation and split long lines. NFC
Thu, Jun 27, 5:10 AM
atanasyan committed rG3b184cf7e102: [mips] Reformat MSA instruction definitions. NFC (authored by atanasyan).
[mips] Reformat MSA instruction definitions. NFC
Thu, Jun 27, 5:09 AM
atanasyan committed rL364527: [mips] Add GPR_64 predicate to some mov[zn] instructions.
[mips] Add GPR_64 predicate to some mov[zn] instructions
Thu, Jun 27, 5:08 AM