Page MenuHomePhabricator

greened (David Greene)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 1 2015, 10:19 AM (224 w, 1 d)

Recent Activity

Today

greened accepted D67550: [AArch64][SVE] Implement unpack intrinsics.

LGTM.

Thu, Oct 17, 8:49 AM

Thu, Oct 10

greened added a comment to D68819: [Utils] Allow update_test_checks to check function arguments.

We can, or should, combine D68153 and this, either in one or two patches.

Thu, Oct 10, 9:02 PM · Restricted Project
greened committed rG7c562f12869f: [System Model] [TTI] Move default cache/prefetch implementations (authored by greened).
[System Model] [TTI] Move default cache/prefetch implementations
Thu, Oct 10, 1:46 PM
greened closed D68804: [System Model] [TTI] Move default cache/prefetch implementations.
Thu, Oct 10, 1:46 PM · Restricted Project
greened committed rL374446: [System Model] [TTI] Move default cache/prefetch implementations.
[System Model] [TTI] Move default cache/prefetch implementations
Thu, Oct 10, 1:37 PM
greened added a comment to D68819: [Utils] Allow update_test_checks to check function arguments.

Does this subsume the goal of D68153? If so I am happy to abandon that revision. D68153 attempts to solve the problem of a CHECK-LABEL matching a function call instead of the start of a function definition. It looks like with --function-signature the CHECK-LABEL will include the arguments in the label pattern which should be enough to disambiguate it from a call to the function. Do I have that right?

Thu, Oct 10, 1:25 PM · Restricted Project
greened added a comment to D68793: [System Model] [TTI] Add TTI interfaces for write-combining buffers.

we might say something like:

\return the number of write-combining buffers. A write-combining buffer is a per-core resource used for collecting writes to a particular cache line before further processing those writes using other parts of the memory subsystem.
Thu, Oct 10, 1:16 PM · Restricted Project
greened added a comment to D68793: [System Model] [TTI] Add TTI interfaces for write-combining buffers.

How do you imagine that we'd use this? Do we need some kind of size to go along with this?

Thu, Oct 10, 11:50 AM · Restricted Project
greened added a comment to D67551: [AArch64][SVE] Implement sdot and udot (lane) intrinsics.

LGTM.

Thu, Oct 10, 9:18 AM · Restricted Project
greened added inline comments to D67550: [AArch64][SVE] Implement unpack intrinsics.
Thu, Oct 10, 9:08 AM
greened created D68804: [System Model] [TTI] Move default cache/prefetch implementations.
Thu, Oct 10, 8:50 AM · Restricted Project
greened created D68793: [System Model] [TTI] Add TTI interfaces for write-combining buffers.
Thu, Oct 10, 8:23 AM · Restricted Project

Wed, Oct 9

greened added a comment to D63614: [System Model] [TTI] Update cache and prefetch TTI interfaces.

This patch causes lots of warning spews because it adds virtual methods to a class that doesn't have a virtual destructor.

Wed, Oct 9, 2:34 PM · Restricted Project
greened committed rL374205: [System Model] [TTI] Update cache and prefetch TTI interfaces.
[System Model] [TTI] Update cache and prefetch TTI interfaces
Wed, Oct 9, 12:51 PM
greened committed rG2e6f6b4dadbf: [System Model] [TTI] Update cache and prefetch TTI interfaces (authored by greened).
[System Model] [TTI] Update cache and prefetch TTI interfaces
Wed, Oct 9, 12:51 PM

Tue, Oct 8

greened added a comment to D67728: Scrub FileCheck regex delimiters from test checks.
I could mock-up a testcase but where does it go?

As you mentioned SCEV, you can add new/update test for SCEV. But I dont think this "step" is required.

So, that leaves me with a question. What else needs to be done before getting this committed?

Tue, Oct 8, 10:57 AM · Restricted Project
greened committed rGeb6698572623: [UpdateCCTestChecks] Detect function mangled name on separate line (authored by greened).
[UpdateCCTestChecks] Detect function mangled name on separate line
Tue, Oct 8, 9:27 AM
greened closed D68272: [UpdateCCTestChecks] Detect function mangled name on separate line.
Tue, Oct 8, 9:26 AM · Restricted Project
greened committed rL374078: [UpdateCCTestChecks] Detect function mangled name on separate line.
[UpdateCCTestChecks] Detect function mangled name on separate line
Tue, Oct 8, 9:24 AM

Mon, Oct 7

greened committed rGa14ffc7eb741: Allow update_test_checks.py to not scrub names. (authored by greened).
Allow update_test_checks.py to not scrub names.
Mon, Oct 7, 10:14 PM
greened committed rL373912: Allow update_test_checks.py to not scrub names..
Allow update_test_checks.py to not scrub names.
Mon, Oct 7, 10:14 PM
greened added a comment to D68153: Make IR labels more precise.

Wouldn't this mean that every regeneration would see this change?

Mon, Oct 7, 7:23 PM · Restricted Project
greened closed D68081: Allow update_test_checks.py to not scrub names.

For some reason the commit did not auto-update this. Closing with commit r373912/a14ffc7eb741de4fd7484350d11947dea40991fd.

Mon, Oct 7, 5:52 PM · Restricted Project
greened added a comment to D68272: [UpdateCCTestChecks] Detect function mangled name on separate line.

Can you give an example demonstrating the issue?

Mon, Oct 7, 9:07 AM · Restricted Project

Fri, Oct 4

greened added a comment to D68230: [UpdateCCTestChecks] Allow asm in output with --allow-asm.

It then becomes a problem of maintenance - if a developer is just building/testing the llvm project for backend work are they responsible for keeping that test project passing? If not then it prevents us using CI bots to test and breaks are likely to linger for long lengths of time.

Fri, Oct 4, 12:32 PM · Restricted Project, Restricted Project
greened accepted D68138: [utils] Fix incompatibility of bisect[-skip-count] with Python 3.

LGTM, thanks!

Fri, Oct 4, 9:23 AM · Restricted Project

Tue, Oct 1

greened created D68272: [UpdateCCTestChecks] Detect function mangled name on separate line.
Tue, Oct 1, 7:29 AM · Restricted Project
greened added a comment to D68230: [UpdateCCTestChecks] Allow asm in output with --allow-asm.

My thinking on this is now that we have the monorepo and that the monorepo will become the canonical source after the conference this month, it's much more feasible to create end-to-end tests. They could live in a subdirectory of the monorepo root. They wouldn't be largish things like in test-suite but rather more focused tests that ensure some behavior works in the context of the entire tool pipeline.

Tue, Oct 1, 7:22 AM · Restricted Project, Restricted Project
greened added inline comments to D68230: [UpdateCCTestChecks] Allow asm in output with --allow-asm.
Tue, Oct 1, 7:20 AM · Restricted Project, Restricted Project
greened updated the diff for D68230: [UpdateCCTestChecks] Allow asm in output with --allow-asm.

We also need to use the asm check generator so that LABEL expressions are generated correctly.

Tue, Oct 1, 7:20 AM · Restricted Project, Restricted Project

Mon, Sep 30

greened added a comment to D68230: [UpdateCCTestChecks] Allow asm in output with --allow-asm.

For the record, is this for the use in upstream clang tests?

Mon, Sep 30, 10:55 AM · Restricted Project, Restricted Project
greened added a comment to D68230: [UpdateCCTestChecks] Allow asm in output with --allow-asm.

Can you show simple example? Is it something like

int foo(void) {
; CHECK: xor eax, eax
return 0;
}

Than great, +1

Mon, Sep 30, 10:13 AM · Restricted Project, Restricted Project
greened created D68230: [UpdateCCTestChecks] Allow asm in output with --allow-asm.
Mon, Sep 30, 9:30 AM · Restricted Project, Restricted Project
greened requested changes to D68138: [utils] Fix incompatibility of bisect[-skip-count] with Python 3.

The more I think about this, the more I do think this should use from __future__ import print_function.

Mon, Sep 30, 8:58 AM · Restricted Project
greened added a comment to D68138: [utils] Fix incompatibility of bisect[-skip-count] with Python 3.

Should this use from __future__ import print_function to avoid someone accidentially printing arguments as a tuple?

Mon, Sep 30, 8:56 AM · Restricted Project
greened accepted D68138: [utils] Fix incompatibility of bisect[-skip-count] with Python 3.

LGTM.

Mon, Sep 30, 8:53 AM · Restricted Project
greened added a comment to D68153: Make IR labels more precise.

Is there an existing test file in trunk that you can regenerate to the show the diff?

Mon, Sep 30, 8:49 AM · Restricted Project
greened updated the summary of D68153: Make IR labels more precise.
Mon, Sep 30, 6:50 AM · Restricted Project

Fri, Sep 27

greened added a comment to D67728: Scrub FileCheck regex delimiters from test checks.
I could mock-up a testcase but where does it go?

As you mentioned SCEV, you can add new/update test for SCEV. But I dont think this "step" is required.

Fri, Sep 27, 1:48 PM · Restricted Project
greened added a comment to D68081: Allow update_test_checks.py to not scrub names.
Fri, Sep 27, 1:48 PM · Restricted Project
greened added a comment to D68138: [utils] Fix incompatibility of bisect[-skip-count] with Python 3.

What happens when this is run with python 2 in the path? Should this explicitly run via python3?

Fri, Sep 27, 1:44 PM · Restricted Project
greened created D68153: Make IR labels more precise.
Fri, Sep 27, 12:09 PM · Restricted Project
greened added a comment to D68081: Allow update_test_checks.py to not scrub names.

Perhaps there is another way to handle situations like this. I am open to ideas!

Fri, Sep 27, 11:37 AM · Restricted Project
greened added a comment to D68081: Allow update_test_checks.py to not scrub names.

I also don't see the value in this. With autogenerated checks, the name of the instructions shouldn't be required to tell if the test is getting the correct behaviour and preserving the names makes test checks much more fragile.

Fri, Sep 27, 11:32 AM · Restricted Project

Thu, Sep 26

greened added inline comments to D68061: [docs] Document pattern of using CHECK-SAME to skip irrelevant lines.
Thu, Sep 26, 11:38 AM · Restricted Project
greened added a comment to D68081: Allow update_test_checks.py to not scrub names.

I'm not sure this is a good idea.

Thu, Sep 26, 11:17 AM · Restricted Project
greened created D68081: Allow update_test_checks.py to not scrub names.
Thu, Sep 26, 5:01 AM · Restricted Project

Thu, Sep 19

greened added a comment to D67728: Scrub FileCheck regex delimiters from test checks.

Is there a suitable test case change?

Thu, Sep 19, 10:26 AM · Restricted Project

Wed, Sep 18

greened created D67728: Scrub FileCheck regex delimiters from test checks.
Wed, Sep 18, 12:24 PM · Restricted Project

Sep 5 2019

greened accepted D65931: [AArch64][SVE] Implement abs and neg intrinsics.

LGTM.

Sep 5 2019, 7:17 AM · Restricted Project

Sep 3 2019

greened committed rL370771: Request commit access for greened.
Request commit access for greened
Sep 3 2019, 9:11 AM
greened added a comment to D66148: [SemanticTypedef] Provide a semantic typedef class and operators.

Ping?

Sep 3 2019, 8:21 AM · Restricted Project
greened added inline comments to D66524: [SVE][Inline-Asm] Add constraints for SVE predicate registers.
Sep 3 2019, 7:33 AM · Restricted Project
greened added a comment to D53137: Scalable vector core instruction support + size queries.
Sep 3 2019, 7:19 AM · Restricted Project, Restricted Project
greened added inline comments to D61437: [AArch64] Static (de)allocation of SVE stack objects..
Sep 3 2019, 7:13 AM · Restricted Project
greened added inline comments to D65931: [AArch64][SVE] Implement abs and neg intrinsics.
Sep 3 2019, 7:10 AM · Restricted Project
greened accepted D66339: [SVE] Fixed-length vector MVT ranges.
Sep 3 2019, 7:04 AM · Restricted Project
greened added a comment to D66339: [SVE] Fixed-length vector MVT ranges.

Since I don't see anything strange that was introduced by this patch, LGTM.

Sep 3 2019, 7:01 AM · Restricted Project
greened added inline comments to D66339: [SVE] Fixed-length vector MVT ranges.
Sep 3 2019, 7:00 AM · Restricted Project

Aug 27 2019

greened added a comment to D66148: [SemanticTypedef] Provide a semantic typedef class and operators.

Ping.

Aug 27 2019, 7:40 PM · Restricted Project

Aug 20 2019

greened added a comment to D66098: [CostModel] Model all `extractvalue`s as free..

LGTM, though are we sure this is true for all targets? The comments in the referenced patch only consider X86. I'm pretty sure it is true for common architectures like AArch64 but I'm not as sure for more exotic things.

I have asked the exact same question before:

Did anything happen with the extractvalue cost suggestion?

I was planning to look into that, and i just did. Some observations:

  1. I'm not sure we can literally treat any extractvalue as free, it clearly isn't: https://godbolt.org/z/6wIxAa

For the short cases, the mov belongs to the return not the extractvalue. For the large cases all of that code is the result of passing an array by value.

So it seems to be the right thing to do..

Aug 20 2019, 1:52 PM · Restricted Project
greened added a comment to D66339: [SVE] Fixed-length vector MVT ranges.

I was suggesting to change the order of the MVTs to keep all the fixed-width types contiguous (int and fp), as a lighter weight alternative to introducing the filter/concat iterators, since this would probably suffice for most use-cases. We can always introduce the concat iterators later if needed.

Aug 20 2019, 1:46 PM · Restricted Project

Aug 19 2019

greened added inline comments to D66148: [SemanticTypedef] Provide a semantic typedef class and operators.
Aug 19 2019, 9:17 AM · Restricted Project
greened updated the diff for D66148: [SemanticTypedef] Provide a semantic typedef class and operators.

Removed casts, default constructors, added all operators where it makes sense (unary *, ->, ->*, unary &, comma, [] and () not added because a default return type is not obvious), placed operators in their own namespace to avoid collisions, rewrote example, updated tests.

Aug 19 2019, 9:17 AM · Restricted Project

Aug 16 2019

greened added inline comments to D66339: [SVE] Fixed-length vector MVT ranges.
Aug 16 2019, 10:26 AM · Restricted Project
greened added a comment to D66339: [SVE] Fixed-length vector MVT ranges.

I like your suggestion of using concat_iterator(_range), but I think grouping all fixed-width types together is sufficient for now. If there is ever a good reason to iterate through (all combined scalable and fixed-width fp vector types)or (all combined scalable and fixed-width integer vector types), we can always introduce the extra concat_iterators then.

Aug 16 2019, 10:26 AM · Restricted Project

Aug 15 2019

greened added inline comments to D66148: [SemanticTypedef] Provide a semantic typedef class and operators.
Aug 15 2019, 8:13 AM · Restricted Project

Aug 14 2019

greened added inline comments to D66148: [SemanticTypedef] Provide a semantic typedef class and operators.
Aug 14 2019, 2:09 PM · Restricted Project
greened added inline comments to D66148: [SemanticTypedef] Provide a semantic typedef class and operators.
Aug 14 2019, 12:09 PM · Restricted Project
greened added inline comments to D66148: [SemanticTypedef] Provide a semantic typedef class and operators.
Aug 14 2019, 8:31 AM · Restricted Project
greened added a comment to D66148: [SemanticTypedef] Provide a semantic typedef class and operators.

A strong motivation for using this over enum class should be provided. The default behavior is too minimalistic.

Aug 14 2019, 8:23 AM · Restricted Project

Aug 13 2019

greened added a comment to D66098: [CostModel] Model all `extractvalue`s as free..

LGTM, though are we sure this is true for all targets? The comments in the referenced patch only consider X86. I'm pretty sure it is true for common architectures like AArch64 but I'm not as sure for more exotic things.

Aug 13 2019, 10:34 AM · Restricted Project
greened added a comment to D63459: Loop Cache Analysis.

Oops, I missed that this landed already. Perhaps a later commit can improve the debug message.

Aug 13 2019, 10:26 AM · Restricted Project
greened added inline comments to D63459: Loop Cache Analysis.
Aug 13 2019, 10:26 AM · Restricted Project
greened added inline comments to D65931: [AArch64][SVE] Implement abs and neg intrinsics.
Aug 13 2019, 10:17 AM · Restricted Project
greened added a comment to D65930: [IntrinsicEmitter] Support scalable vectors in intrinsics.
Aug 13 2019, 10:17 AM · Restricted Project
greened added a comment to D61437: [AArch64] Static (de)allocation of SVE stack objects..

This LGTM but I think someone else should probably sign off on it as well.

Aug 13 2019, 10:00 AM · Restricted Project
greened added a comment to D65653: [AArch64] Change location of frame-record within callee-save area..

Thanks for all the feedback so far. I think I've addressed all comments and suggestions, are we happy to move forward with this patch?

Aug 13 2019, 9:55 AM · Restricted Project
greened updated the summary of D66148: [SemanticTypedef] Provide a semantic typedef class and operators.
Aug 13 2019, 9:42 AM · Restricted Project
greened created D66148: [SemanticTypedef] Provide a semantic typedef class and operators.
Aug 13 2019, 9:42 AM · Restricted Project

Aug 2 2019

greened accepted D47770: [MVT][SVE] Add EVT strings and Type mapping.
Aug 2 2019, 8:58 AM · Restricted Project
greened accepted D61435: [AArch64] NFC: Add generic StackOffset to describe scalable offsets..

This was accepted. Did it land?

Not yet, I initially thought about landing it together with D61437 because there was no need for it otherwise. But if everyone is happy, I guess this one can just land.

Aug 2 2019, 8:56 AM · Restricted Project
greened added a comment to D47770: [MVT][SVE] Add EVT strings and Type mapping.

LGTM, thanks!

Aug 2 2019, 8:54 AM · Restricted Project
greened added a comment to D61437: [AArch64] Static (de)allocation of SVE stack objects..

I wonder if this should have a test that ensures we generate VL-scaled addressing modes for SVE object addressing. If there's not enough codegen yet to emit the asm, then we should probably add such a test when we can. After all, it's the stated goal of this patch. :)

Aug 2 2019, 8:49 AM · Restricted Project
greened added a comment to D65653: [AArch64] Change location of frame-record within callee-save area..

I can't really comment on the correctness of this but other than the one comment I'd like to see added, LGTM.

Aug 2 2019, 8:46 AM · Restricted Project

Aug 1 2019

greened added a comment to D61435: [AArch64] NFC: Add generic StackOffset to describe scalable offsets..

This was accepted. Did it land?

Aug 1 2019, 12:56 PM · Restricted Project
greened added inline comments to D61437: [AArch64] Static (de)allocation of SVE stack objects..
Aug 1 2019, 12:56 PM · Restricted Project
greened added a comment to D61437: [AArch64] Static (de)allocation of SVE stack objects..

I wouldn't really worry about optimizing this; dynamic stack allocation is rare in most C and C++ codebases, and one integer register likely doesn't matter much.

Aug 1 2019, 12:42 PM · Restricted Project
greened added inline comments to D47770: [MVT][SVE] Add EVT strings and Type mapping.
Aug 1 2019, 12:13 PM · Restricted Project

Jul 31 2019

greened added inline comments to D53137: Scalable vector core instruction support + size queries.
Jul 31 2019, 1:06 PM · Restricted Project, Restricted Project
greened added inline comments to D63459: Loop Cache Analysis.
Jul 31 2019, 12:50 PM · Restricted Project
greened added a comment to D47770: [MVT][SVE] Add EVT strings and Type mapping.

What's the status of this?

Jul 31 2019, 11:41 AM · Restricted Project

Jul 24 2019

greened added inline comments to D63459: Loop Cache Analysis.
Jul 24 2019, 10:13 AM · Restricted Project

Jul 18 2019

greened added inline comments to D63459: Loop Cache Analysis.
Jul 18 2019, 5:54 PM · Restricted Project
greened added inline comments to D63459: Loop Cache Analysis.
Jul 18 2019, 10:32 AM · Restricted Project

Jul 17 2019

greened added inline comments to D63902: [InlineCost] separate stats from CallAnalyzer into InliningStats.
Jul 17 2019, 10:36 AM · Restricted Project
greened added a comment to D57400: Add a .gitignore file to the root that ignores any files outside of the project directories..

What about downstream users that have added directories in their local forks? Having git suddenly ignore them would be surprising. We are in that situation.

Jul 17 2019, 10:28 AM

Jul 10 2019

greened committed rGd300a493df36: Revert "[System Model] [TTI] Update cache and prefetch TTI interfaces" (authored by greened).
Revert "[System Model] [TTI] Update cache and prefetch TTI interfaces"
Jul 10 2019, 11:27 AM
greened added a reverting change for rG9fdfb045ae8b: [System Model] [TTI] Update cache and prefetch TTI interfaces: rGd300a493df36: Revert "[System Model] [TTI] Update cache and prefetch TTI interfaces".
Jul 10 2019, 11:27 AM
greened committed rL365680: Revert "[System Model] [TTI] Update cache and prefetch TTI interfaces".
Revert "[System Model] [TTI] Update cache and prefetch TTI interfaces"
Jul 10 2019, 11:27 AM