- User Since
- Jul 1 2015, 10:19 AM (198 w, 1 d)
Wed, Apr 17
We need to clarify on insertelement/extractelement. Maybe already done in some other patches, but that clarification should be part of this patch.
Is the "length of val" under the semantics "scalable * n" in <scalable n x ElemTy>, right? Or is it still n?
Wed, Apr 3
Wed, Mar 20
Mar 14 2019
Mar 8 2019
This all LGTM.
Mar 7 2019
I know this isn't ready for merge, but since the mailing list discussion has died down it seems like maybe we should move the discussion here. If so, it would be helpful to have comments on all the routines explaining what they do and how they differ from the existing routines, in order to aid discussion.
Mar 6 2019
Feb 28 2019
Cool,. I've wanted this for a while. LGTM.
Feb 27 2019
A larger design question I have about this is the proper place to put software prefetching configuration. Right now it lives at the memory model level, in that a memory model specifies a cache heirachy along with a software prefetch configuration. I wonder if we should allow for software prefetching configuration for each cache level, as targets might want different policies depending on which cache level they are prefetching into. I don't think we have any examples of that in the codebase today but I can imagine cases where targets might want it.
Feb 22 2019
I believe https://reviews.llvm.org/D56266 is working for me.
+1. Is there any reason not to use "%4" in the definition?
Feb 11 2019
Feb 7 2019
Feb 4 2019
Jan 31 2019
Jan 29 2019
Note important considerations with respect to upstream merges after zipping.
Added --source-kind=split to the migrate-downstream-fork.py example.
Jan 28 2019
Updated for new and improved zipping tool.
Jan 10 2019
Updated with blessed monorepo URL.
Fixed more typos.
Fixed various typos.
Do a lot of people use the old monorepo for development? We don't so I haven't developed any process for migrating from that. I'll leave that to someone else to add.
I could certainly put these instructions in a separate document, but where should it go? This is a one-time operation and so it doesn't make sense to put it in with the regular LLVM docs. It's not a proposal, per se, so I don't think it belongs in docs/Proposals other than as an addition to a related proposal, which is this document.
Noted that when zipping, and non-LLVM repositories added as submodules need to be imported into the monorepo.
I created some instructions in D56550 which should cover the most common cases.
Jan 9 2019
As @bogner mentioned, the last section (Multirepo to Monorepo, With Merges) is almost certainly the most common downstream situation. I may write up some recipes under this header and move it to a more prominent position in a separate patch. The discussion of the other situations is orthogonal to the kinds of things I found I needed to do downstream.
What's the status of this? Since the monorepo prototype seems very likely to be blessed soon, I was thinking of writing up some recipes for common downstream migrations. This document would seem to be the right place to put them but it seems from all the comments that this is very much in flux.
Jan 7 2019
Better handle clang-tools-extra too.
Updated to use CACHE_STRING as suggested.
Jan 6 2019
This also looks fine to me but I'm in the same boat as Jonas when it comes to (non-)knowledge of GlobalISel.
It's still just an intrinsic so i do not see how transformations that only look at Instruction and don't dig deeper could break the EVL intrinsic call.
Jan 4 2019
No, I haven't implemented `frameaddress` or done any GISel work at all. From our ML conversation, I was under the impression that the tests didn't need `-fno-experimental-isel`` anymore.
Jan 2 2019
Dec 21 2018
What are the semantics for a call that doesn't have a passthrough attribute? For disabled lanes what's the expected output value? I hope it's undef.
Sorry, I'm joining this conversation late.
Nov 13 2018
Oops, I didn't realize this hadn't been formally accepted yet. Still learning the Phab process. Let me know if you want it reverted for a formal accept.
Nov 5 2018
I'm not a Fortran expert. The last Fortran I used was 77 and didn't have all these newfangled features. :) Some questions come up on our end so I'll relay them.
Oct 30 2018
We are probably going to reconfigure our machines so this isn't a problem, so these tests should start working for us. However, this took some effort to track down and I wonder if we ought to have a warning or something if lit detects that these tests are check out under /tmp.
Explain that Cray packages gcc such that headers are in include/g++.
Oct 29 2018
Maybe we could just add 'REQUIRES: build-dir-not-slash-tmp' or something to the affected lit tests.
Oct 26 2018
Oct 25 2018
Corresponding compiler-rt test differential is here:
Corresponding differential is here:
This fixes some compiler-rt tests that break for us due to odd symlinks in /tmp. I haven't figured out how to generate a reasonable test within llvm sources, as any such test uses a binary with a fixed source file path encoded into it. The result is that the test will not fail if LLVM is built in a completely different place than were it was built when the test binary was generated since the test binary path prefix won't patch the -path-equivalence prefix.
Oct 24 2018
Oct 22 2018
Ok, sounds good. For some reason I'm not able to Accept this so it seems like someone else will need to.
LGTM, but I don't know if I should be the one to sign off on this since I've never touched LoopRotate.
Ping. Just looking for a yea or nay on this. It seems like a good idea to make the build less confusing, and having explicitly-given paths override implicit paths seems least surprising to me.
Ping. We're trying to clean up the last few test failures we're seeing.