User Details
- User Since
- Nov 26 2021, 11:45 AM (36 w, 5 d)
Mon, Aug 8
Fix test on Windows.
Fri, Aug 5
Use adjustAddr function declared in header.
Thu, Aug 4
Add explanatory comment for ra adjustment.
Correct enum naming convention.
Handle default PC type out of band.
Fix data test.
Wed, Aug 3
Change PC location information from angle brackets to brackets to avoid
conflicting with C++ template arguments.
Address review comments.
Tue, Jul 26
This seems to be hitting assertions when compiling BoringSSL:
https://luci-milo.appspot.com/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-release/b8807566603550542609/overview
Fri, Jul 22
Correct size directive.
Thu, Jul 21
Integrate from upstream.
Address review comments.
Wed, Jul 20
Address review comments.
Tue, Jul 19
Remove unnecessary flag from test RUN: lines.
Remove unused declaration.
Fix indentation.
I did a bit more hammering on the semantics of contexutal line elision.
Previously, contextual elements would be output as text if they were preceded
by text, which wasn't intended. Fixing this means that a non-contextual line
will be entirely deferred. This means that tryContextualLine() doesn't really
make sense anymore; it always handles the whole line. I've thus made the
modified version of it into the new body of filter().
Mon, Jul 18
Address review comments.
Thu, Jul 14
Address review comments. Refactored out printing module info line prefix.
Wed, Jul 13
Fixed use after free with MarginNodes. MarginNodes ended up being unnecessary,
since when a new module line is opened, the next thing to print will
necessarily be that module line. That means the next things to be output will
be the margin nodes, and these can be summarily printed.
Tue, Jul 12
preceeding -> preceding
Add periods. Correct typo.
Jul 11 2022
Use Densemap<unique_ptr> for Modules; fix flipped overlappingMMap condition.
Clean up diff.
Jun 30 2022
Accomodate Windows path separators in test.
Jun 29 2022
Add dwarfv5 test and use 2>&1 for error checking.
Jun 28 2022
Address review comments.
Jun 27 2022
Apologies for the long delay; this change slipped my mind for a bit.
Address review comments.
Jun 24 2022
I like MarkupFilter as a name; especially as a pair for MarkupNode and MarkupParser. I've renamed the files and classes to match.
Address review comments.
Jun 23 2022
Extract deplibs before LTO, as discussed in #56070.
Jun 22 2022
Fix TODO.
Rename coloring utils.
Integrate.
Missed comment.
Clean up usage of NextIdx.
Jun 21 2022
Add missed NextIdx=0 call.
Refactor markup parser to parse lazily on each node request.
Add comments; remove assert.
Jun 17 2022
Integrate.
Improve comment for flush().
Integrate.
Fix missed element->node comment update.
Jun 16 2022
Address review comments.
I've created https://github.com/llvm/llvm-project/issues/56070 to track the general issue and provide more background on the issue's diagnosis.
Jun 15 2022
Jun 13 2022
Remove tryFilter abstraction; unneeded complexity.
Jun 10 2022
Add pretty error location reporting.
Jun 9 2022
Integrate.
Fix tests.
Integrate.
Integrate.
Fix parsing for empty field.
Jun 8 2022
I like that; it should decouple those commits from this one, and it should be quite a bit cleaner than maintaining size counters.