User Details
- User Since
- Nov 26 2021, 11:45 AM (96 w, 8 h)
Mon, Sep 25
It looks like this change is a likely root cause for a size regression on Fuchsia. In particular, Fuchsia maintains a hermetic -fno-exceptions multilib of libc++.a that is statically linked into other binaries/libraries. Previously, the no-exceptions version of this code didn't depend on the error code or category libraries, but this change seems to bring them into the link unnecessarily. Would it be possible to revert this or to fix it forward to keep the no-exception case separate from these routines?
Fri, Sep 22
There should also be tests for this behavior in llvm/test/CodeGen/X86. I wouldn't think it necessary to fully test the calling convention; that should already be well covered; just something in those key test files (e.g., sse-regcall.ll) to verify that the uefi OS actually switches the calling convention at these key points.
Thu, Sep 21
Wed, Sep 20
Tue, Sep 19
Remove semicolon
Mon, Sep 11
More review comments
Thu, Sep 7
Another round of comments
Wed, Sep 6
Remove canned binary
Address review feedback
Aug 25 2023
Aug 22 2023
Aug 17 2023
8d3ff601a3 should fix the Darwin build issue and make the Linux unit tests sufficiently lenient. The %#x behavior was intentional; the spec is written with it in mind.
clang-format
Aug 16 2023
Address review comments.
Aug 11 2023
Jul 19 2023
Jul 18 2023
Jul 17 2023
Jul 14 2023
Could we include a similarly descriptive error message in llvm-debuginfod as in llvm-mt as part of this? As is, this will produce a binary with undefined behavior, as it will hit a llvm_unreachable when attempting to use HTTPServer. Seems like HTTPServer is the right place for this; it should probably report_fatal_error instead of llvm_unreachable, and mention the specific library dep.
Jul 12 2023
Jul 11 2023
I've spent a surprising amount of time staring at this libcall list (originally in the context of https://discourse.llvm.org/t/lto-deplibs-and-libcalls-oh-my/64510). It's struck me as a bit of a hack; targets are free to change the names of libcalls in TLI or to include additional target-specific ones, and neither would end up in this list. LTO also depends on the accuracy of this list for correctness, since the symbol table of the link must be finalized before LTO codegen begins.
Jun 28 2023
Jun 27 2023
Update test cases.
Jun 26 2023
Jun 16 2023
Jun 12 2023
Jun 1 2023
May 31 2023
May 30 2023
Fix test on Windows.
IIRC it's more typical to re-open D151273 and address the issue there, that way the diffs of the fixes are easier to review, and the context of the review is maintained.
May 26 2023
Apply black formatting to resolve merge conflict.
May 25 2023
May 24 2023
Fixed commit message typo.
Restrict description to Shell tests.
May 23 2023
May 16 2023
May 2 2023
Apr 28 2023
It looks like this change or its followup is causing test failures on the Fuchsia toolchain builders:
Apr 27 2023
Hey, looks like this is causing test failures on the Fuchsia Windows builders:
https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64/b8782647969396934929/overview
Apr 24 2023
Rebase.
Rebase.
Rebase.
Rename MarkupContext to ProcessContext.
Rename "[markup] context" to "process context".
Apr 21 2023
Apr 19 2023
Make --filter-markup a doc reference.
Add to description comment to relate MarkupContext back to the Symbolizer library.
Defined markup contexts briefly in the flag help message and more thoroughly in
the rst documentation.
Apr 17 2023
Apr 13 2023
Comment changes.
Apr 12 2023
Address comments.