Page MenuHomePhabricator

mysterymath (Daniel Thornburgh)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 26 2021, 11:45 AM (36 w, 5 d)

Recent Activity

Mon, Aug 8

mysterymath committed rG0d6cf1e8b5fa: [Symbolizer] Fix symbolizer-filter-markup-pc.test on Windows (authored by mysterymath).
[Symbolizer] Fix symbolizer-filter-markup-pc.test on Windows
Mon, Aug 8, 11:40 AM · Restricted Project, Restricted Project
mysterymath added a comment to D131115: [Symbolizer] Implement pc element in symbolizing filter..

Looks like this breaks tests on Windows: http://45.33.8.238/win/64016/step_11.txt

Please take a look, and revert for now if it takes a while to fix.

Mon, Aug 8, 11:40 AM · Restricted Project, Restricted Project
mysterymath committed rGbf48b128b028: [Symbolizer] Implement pc element in symbolizing filter. (authored by mysterymath).
[Symbolizer] Implement pc element in symbolizing filter.
Mon, Aug 8, 11:09 AM · Restricted Project, Restricted Project
mysterymath closed D131115: [Symbolizer] Implement pc element in symbolizing filter..
Mon, Aug 8, 11:09 AM · Restricted Project, Restricted Project
mysterymath updated the diff for D131115: [Symbolizer] Implement pc element in symbolizing filter..

Fix test on Windows.

Mon, Aug 8, 11:07 AM · Restricted Project, Restricted Project

Fri, Aug 5

mysterymath updated the diff for D131115: [Symbolizer] Implement pc element in symbolizing filter..

Use adjustAddr function declared in header.

Fri, Aug 5, 4:47 PM · Restricted Project, Restricted Project

Thu, Aug 4

mysterymath updated the diff for D131115: [Symbolizer] Implement pc element in symbolizing filter..

Add explanatory comment for ra adjustment.

Thu, Aug 4, 11:10 AM · Restricted Project, Restricted Project
mysterymath added inline comments to D131115: [Symbolizer] Implement pc element in symbolizing filter..
Thu, Aug 4, 11:08 AM · Restricted Project, Restricted Project
mysterymath committed rG22df238d4a64: [Symbolizer] Implement data symbolizer markup element. (authored by mysterymath).
[Symbolizer] Implement data symbolizer markup element.
Thu, Aug 4, 10:20 AM · Restricted Project, Restricted Project
mysterymath closed D130187: [Symbolizer] Implement data symbolizer markup element..
Thu, Aug 4, 10:20 AM · Restricted Project, Restricted Project
mysterymath added inline comments to D131115: [Symbolizer] Implement pc element in symbolizing filter..
Thu, Aug 4, 10:07 AM · Restricted Project, Restricted Project
mysterymath updated the diff for D131115: [Symbolizer] Implement pc element in symbolizing filter..

Correct enum naming convention.
Handle default PC type out of band.
Fix data test.

Thu, Aug 4, 10:07 AM · Restricted Project, Restricted Project

Wed, Aug 3

mysterymath updated the diff for D131115: [Symbolizer] Implement pc element in symbolizing filter..

Change PC location information from angle brackets to brackets to avoid
conflicting with C++ template arguments.

Wed, Aug 3, 2:34 PM · Restricted Project, Restricted Project
mysterymath requested review of D131115: [Symbolizer] Implement pc element in symbolizing filter..
Wed, Aug 3, 2:30 PM · Restricted Project, Restricted Project
mysterymath added inline comments to D130187: [Symbolizer] Implement data symbolizer markup element..
Wed, Aug 3, 10:52 AM · Restricted Project, Restricted Project
mysterymath updated the diff for D130187: [Symbolizer] Implement data symbolizer markup element..

Address review comments.

Wed, Aug 3, 10:52 AM · Restricted Project, Restricted Project

Tue, Jul 26

mysterymath added a comment to D130251: [DAGCombine] Mask doesn't have to be (EltSize - 1) exactly when combining rotation.
Tue, Jul 26, 1:45 PM · Restricted Project, Restricted Project
mysterymath added a comment to D130251: [DAGCombine] Mask doesn't have to be (EltSize - 1) exactly when combining rotation.

This seems to be hitting assertions when compiling BoringSSL:
https://luci-milo.appspot.com/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-release/b8807566603550542609/overview

Tue, Jul 26, 9:21 AM · Restricted Project, Restricted Project

Fri, Jul 22

mysterymath added inline comments to D130187: [Symbolizer] Implement data symbolizer markup element..
Fri, Jul 22, 2:19 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D130187: [Symbolizer] Implement data symbolizer markup element..

Correct size directive.

Fri, Jul 22, 2:19 PM · Restricted Project, Restricted Project

Thu, Jul 21

mysterymath updated the diff for D130187: [Symbolizer] Implement data symbolizer markup element..

Integrate from upstream.

Thu, Jul 21, 3:55 PM · Restricted Project, Restricted Project
mysterymath added inline comments to D130187: [Symbolizer] Implement data symbolizer markup element..
Thu, Jul 21, 3:05 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D130187: [Symbolizer] Implement data symbolizer markup element..

Address review comments.

Thu, Jul 21, 3:05 PM · Restricted Project, Restricted Project
mysterymath added a comment to D129519: [Symbolizer] Implement contextual symbolizer markup elements..

One of the tests you added symbolize-filter-markup-reset.test seems to be failing on the PS5 Windows bot, can you take a look?

https://lab.llvm.org/staging/#/builders/204/builds/1751

Looking on my Windows box; I'll revert if I can't get to the bottom of it in a few minutes.

Thu, Jul 21, 1:54 PM · Restricted Project, Restricted Project
mysterymath committed rGcc0a1078f5fb: Fix use after free in MarkupFilter.cpp (authored by mysterymath).
Fix use after free in MarkupFilter.cpp
Thu, Jul 21, 1:53 PM · Restricted Project, Restricted Project
mysterymath added a comment to D129519: [Symbolizer] Implement contextual symbolizer markup elements..

One of the tests you added symbolize-filter-markup-reset.test seems to be failing on the PS5 Windows bot, can you take a look?

https://lab.llvm.org/staging/#/builders/204/builds/1751

Thu, Jul 21, 1:42 PM · Restricted Project, Restricted Project
mysterymath added a comment to D129519: [Symbolizer] Implement contextual symbolizer markup elements..

This broke building with GCC 9:

In file included from ../tools/llvm-symbolizer/llvm-symbolizer.cpp:23:
../include/llvm/DebugInfo/Symbolize/MarkupFilter.h:55:19: error: declaration of ‘const llvm::symbolize::MarkupFilter::Module* llvm::symbolize::MarkupFilter::MMap::Module’ changes meaning of ‘Module’ [-fpermissive]
   55 |     const Module *Module;
      |                   ^~~~~~
../include/llvm/DebugInfo/Symbolize/MarkupFilter.h:46:10: note: ‘Module’ declared here as ‘struct llvm::symbolize::MarkupFilter::Module’
   46 |   struct Module {
      |          ^~~~~~
../include/llvm/DebugInfo/Symbolize/MarkupFilter.h:65:19: error: declaration of ‘const llvm::symbolize::MarkupFilter::Module* llvm::symbolize::MarkupFilter::ModuleInfoLine::Module’ changes meaning of ‘Module’ [-fpermissive]
   65 |     const Module *Module;
      |                   ^~~~~~
../include/llvm/DebugInfo/Symbolize/MarkupFilter.h:46:10: note: ‘Module’ declared here as ‘struct llvm::symbolize::MarkupFilter::Module’
   46 |   struct Module {
      |          ^~~~~~
Thu, Jul 21, 12:09 PM · Restricted Project, Restricted Project
mysterymath committed rG6605187103a2: [NFC] Fix compiler warning in MarkupFilter (authored by mysterymath).
[NFC] Fix compiler warning in MarkupFilter
Thu, Jul 21, 12:01 PM · Restricted Project, Restricted Project
mysterymath committed rG17e4c217b663: [Symbolizer] Implement contextual symbolizer markup elements. (authored by mysterymath).
[Symbolizer] Implement contextual symbolizer markup elements.
Thu, Jul 21, 11:29 AM · Restricted Project, Restricted Project
mysterymath closed D129519: [Symbolizer] Implement contextual symbolizer markup elements..
Thu, Jul 21, 11:29 AM · Restricted Project, Restricted Project

Wed, Jul 20

mysterymath added inline comments to D129519: [Symbolizer] Implement contextual symbolizer markup elements..
Wed, Jul 20, 11:18 AM · Restricted Project, Restricted Project
mysterymath updated the diff for D129519: [Symbolizer] Implement contextual symbolizer markup elements..

Address review comments.

Wed, Jul 20, 11:18 AM · Restricted Project, Restricted Project
mysterymath requested review of D130187: [Symbolizer] Implement data symbolizer markup element..
Wed, Jul 20, 11:06 AM · Restricted Project, Restricted Project
mysterymath added inline comments to D129519: [Symbolizer] Implement contextual symbolizer markup elements..
Wed, Jul 20, 10:04 AM · Restricted Project, Restricted Project

Tue, Jul 19

mysterymath updated the diff for D129519: [Symbolizer] Implement contextual symbolizer markup elements..

Remove unnecessary flag from test RUN: lines.

Tue, Jul 19, 2:41 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D129519: [Symbolizer] Implement contextual symbolizer markup elements..

Remove unused declaration.

Tue, Jul 19, 2:09 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D129519: [Symbolizer] Implement contextual symbolizer markup elements..

Fix indentation.

Tue, Jul 19, 2:07 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D129519: [Symbolizer] Implement contextual symbolizer markup elements..

I did a bit more hammering on the semantics of contexutal line elision.
Previously, contextual elements would be output as text if they were preceded
by text, which wasn't intended. Fixing this means that a non-contextual line
will be entirely deferred. This means that tryContextualLine() doesn't really
make sense anymore; it always handles the whole line. I've thus made the
modified version of it into the new body of filter().

Tue, Jul 19, 2:06 PM · Restricted Project, Restricted Project

Mon, Jul 18

mysterymath added inline comments to D129519: [Symbolizer] Implement contextual symbolizer markup elements..
Mon, Jul 18, 4:23 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D129519: [Symbolizer] Implement contextual symbolizer markup elements..

Address review comments.

Mon, Jul 18, 4:23 PM · Restricted Project, Restricted Project

Thu, Jul 14

mysterymath added inline comments to D129519: [Symbolizer] Implement contextual symbolizer markup elements..
Thu, Jul 14, 1:10 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D129519: [Symbolizer] Implement contextual symbolizer markup elements..

Address review comments. Refactored out printing module info line prefix.

Thu, Jul 14, 1:10 PM · Restricted Project, Restricted Project

Wed, Jul 13

mysterymath updated the diff for D129519: [Symbolizer] Implement contextual symbolizer markup elements..

Fixed use after free with MarginNodes. MarginNodes ended up being unnecessary,
since when a new module line is opened, the next thing to print will
necessarily be that module line. That means the next things to be output will
be the margin nodes, and these can be summarily printed.

Wed, Jul 13, 5:18 PM · Restricted Project, Restricted Project

Tue, Jul 12

mysterymath updated the diff for D129519: [Symbolizer] Implement contextual symbolizer markup elements..

preceeding -> preceding

Tue, Jul 12, 11:21 AM · Restricted Project, Restricted Project
mysterymath added inline comments to D129519: [Symbolizer] Implement contextual symbolizer markup elements..
Tue, Jul 12, 10:55 AM · Restricted Project, Restricted Project
mysterymath updated the diff for D129519: [Symbolizer] Implement contextual symbolizer markup elements..

Add periods. Correct typo.

Tue, Jul 12, 10:55 AM · Restricted Project, Restricted Project

Jul 11 2022

mysterymath added inline comments to D129519: [Symbolizer] Implement contextual symbolizer markup elements..
Jul 11 2022, 4:48 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D129519: [Symbolizer] Implement contextual symbolizer markup elements..

Use Densemap<unique_ptr> for Modules; fix flipped overlappingMMap condition.

Jul 11 2022, 4:48 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D129519: [Symbolizer] Implement contextual symbolizer markup elements..

Clean up diff.

Jul 11 2022, 2:53 PM · Restricted Project, Restricted Project
mysterymath requested review of D129519: [Symbolizer] Implement contextual symbolizer markup elements..
Jul 11 2022, 2:47 PM · Restricted Project, Restricted Project

Jun 30 2022

mysterymath committed rG05a4b640358b: [llvm-dwarfdump] --show-sources option to show all sources (authored by mysterymath).
[llvm-dwarfdump] --show-sources option to show all sources
Jun 30 2022, 9:53 AM · Restricted Project, Restricted Project
mysterymath closed D87656: [llvm-dwarfdump] --show-sources option to show all sources.
Jun 30 2022, 9:53 AM · Restricted Project, Restricted Project
mysterymath updated the diff for D87656: [llvm-dwarfdump] --show-sources option to show all sources.

Accomodate Windows path separators in test.

Jun 30 2022, 9:52 AM · Restricted Project, Restricted Project

Jun 29 2022

mysterymath added inline comments to D87656: [llvm-dwarfdump] --show-sources option to show all sources.
Jun 29 2022, 9:40 AM · Restricted Project, Restricted Project
mysterymath updated the diff for D87656: [llvm-dwarfdump] --show-sources option to show all sources.

Add dwarfv5 test and use 2>&1 for error checking.

Jun 29 2022, 9:39 AM · Restricted Project, Restricted Project

Jun 28 2022

mysterymath added inline comments to D87656: [llvm-dwarfdump] --show-sources option to show all sources.
Jun 28 2022, 1:38 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D87656: [llvm-dwarfdump] --show-sources option to show all sources.

Address review comments.

Jun 28 2022, 1:38 PM · Restricted Project, Restricted Project
mysterymath added a comment to D124686: [Symbolize] Parser for log symbolizer markup..

Is it already planned to add this markup to LLVM's own crash dumps when they aren't already symbolized? Might be a handy use-case for the feature, providing some built-in-to-llvm exercisizing/advertising/experience with the feature? (if the markup is meant to be compatible with human readers who might not be able to symbolize the data later - which seems like a nice feature too)

Jun 28 2022, 10:49 AM · Restricted Project, Restricted Project

Jun 27 2022

mysterymath added a comment to D87656: [llvm-dwarfdump] --show-sources option to show all sources.

Apologies for the long delay; this change slipped my mind for a bit.

Jun 27 2022, 3:16 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D87656: [llvm-dwarfdump] --show-sources option to show all sources.

Address review comments.

Jun 27 2022, 3:16 PM · Restricted Project, Restricted Project
mysterymath committed rGd3ff32720dbe: [Symbolize] Fix MarkupFilter tests for Windows. (authored by mysterymath).
[Symbolize] Fix MarkupFilter tests for Windows.
Jun 27 2022, 11:19 AM · Restricted Project, Restricted Project
mysterymath committed rG7598a42e2abc: [Symbolize] Fix llvm-symbolizer --filter-markup test on Windows. (authored by mysterymath).
[Symbolize] Fix llvm-symbolizer --filter-markup test on Windows.
Jun 27 2022, 11:16 AM · Restricted Project, Restricted Project
mysterymath committed rGeb5af0acf054: [Symbolize] Add log markup --filter to llvm-symbolizer. (authored by mysterymath).
[Symbolize] Add log markup --filter to llvm-symbolizer.
Jun 27 2022, 10:44 AM · Restricted Project, Restricted Project
mysterymath closed D126980: [Symbolize] Add log markup --filter to llvm-symbolizer..
Jun 27 2022, 10:44 AM · Restricted Project, Restricted Project

Jun 24 2022

mysterymath added a comment to D126980: [Symbolize] Add log markup --filter to llvm-symbolizer..

Only a few small comments. May be worth calling Filter.cpp and Filter.h MarkupFilter.cpp and MarkupFilter.h as there could be non-markup based filters in the future. Not a strong opinion as these filenames could be changed later if needed.

I like MarkupFilter as a name; especially as a pair for MarkupNode and MarkupParser. I've renamed the files and classes to match.

Jun 24 2022, 2:16 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D126980: [Symbolize] Add log markup --filter to llvm-symbolizer..

Address review comments.

Jun 24 2022, 2:16 PM · Restricted Project, Restricted Project

Jun 23 2022

mysterymath retitled D127885: [LTO] Parse deplibs sections for possible libcalls. from [LTO] Parse input files added after LTO codegen. to [LTO] Parse deplibs sections for possible libcalls..
Jun 23 2022, 5:19 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D127885: [LTO] Parse deplibs sections for possible libcalls..

Extract deplibs before LTO, as discussed in #56070.

Jun 23 2022, 5:14 PM · Restricted Project, Restricted Project

Jun 22 2022

mysterymath updated the diff for D126980: [Symbolize] Add log markup --filter to llvm-symbolizer..

Fix TODO.

Jun 22 2022, 11:20 AM · Restricted Project, Restricted Project
mysterymath updated the diff for D126980: [Symbolize] Add log markup --filter to llvm-symbolizer..

Rename coloring utils.

Jun 22 2022, 11:09 AM · Restricted Project, Restricted Project
mysterymath updated the diff for D126980: [Symbolize] Add log markup --filter to llvm-symbolizer..

Integrate.

Jun 22 2022, 10:19 AM · Restricted Project, Restricted Project
mysterymath committed rG8bd078b57c7d: [Symbolize] Parse multi-line markup elements. (authored by mysterymath).
[Symbolize] Parse multi-line markup elements.
Jun 22 2022, 10:03 AM · Restricted Project, Restricted Project
mysterymath closed D124798: [Symbolize] Parse multi-line markup elements..
Jun 22 2022, 10:03 AM · Restricted Project, Restricted Project
mysterymath updated the diff for D124798: [Symbolize] Parse multi-line markup elements..

Missed comment.

Jun 22 2022, 9:59 AM · Restricted Project, Restricted Project
mysterymath updated the diff for D124798: [Symbolize] Parse multi-line markup elements..

Clean up usage of NextIdx.

Jun 22 2022, 9:59 AM · Restricted Project, Restricted Project

Jun 21 2022

mysterymath updated the diff for D124798: [Symbolize] Parse multi-line markup elements..

Add missed NextIdx=0 call.

Jun 21 2022, 3:54 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D124798: [Symbolize] Parse multi-line markup elements..

Refactor markup parser to parse lazily on each node request.

Jun 21 2022, 3:51 PM · Restricted Project, Restricted Project
mysterymath added inline comments to D124798: [Symbolize] Parse multi-line markup elements..
Jun 21 2022, 11:24 AM · Restricted Project, Restricted Project
mysterymath updated the diff for D124798: [Symbolize] Parse multi-line markup elements..

Add comments; remove assert.

Jun 21 2022, 11:24 AM · Restricted Project, Restricted Project

Jun 17 2022

mysterymath updated the diff for D126980: [Symbolize] Add log markup --filter to llvm-symbolizer..

Integrate.

Jun 17 2022, 11:26 AM · Restricted Project, Restricted Project
mysterymath updated the diff for D124798: [Symbolize] Parse multi-line markup elements..

Improve comment for flush().

Jun 17 2022, 10:48 AM · Restricted Project, Restricted Project
mysterymath updated the diff for D124798: [Symbolize] Parse multi-line markup elements..

Integrate.

Jun 17 2022, 10:35 AM · Restricted Project, Restricted Project
mysterymath committed rG2040b6df0a3f: [Symbolize] Parser for log symbolizer markup. (authored by mysterymath).
[Symbolize] Parser for log symbolizer markup.
Jun 17 2022, 10:26 AM · Restricted Project, Restricted Project
mysterymath closed D124686: [Symbolize] Parser for log symbolizer markup..
Jun 17 2022, 10:26 AM · Restricted Project, Restricted Project
mysterymath updated the diff for D124686: [Symbolize] Parser for log symbolizer markup..

Fix missed element->node comment update.

Jun 17 2022, 10:22 AM · Restricted Project, Restricted Project
mysterymath added a comment to D124686: [Symbolize] Parser for log symbolizer markup..

LGTM thanks for the updates. I spotted what looked like one comment update for the change to Node, but that can easily be fixed up if needed.

Jun 17 2022, 10:22 AM · Restricted Project, Restricted Project
mysterymath added inline comments to D114845: [llvm] [Debuginfod] DebuginfodCollection and DebuginfodServer for tracking local debuginfo..
Jun 17 2022, 10:01 AM · Restricted Project, Restricted Project

Jun 16 2022

mysterymath added inline comments to D124686: [Symbolize] Parser for log symbolizer markup..
Jun 16 2022, 1:34 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D124686: [Symbolize] Parser for log symbolizer markup..

Address review comments.

Jun 16 2022, 1:34 PM · Restricted Project, Restricted Project
mysterymath added a comment to D127885: [LTO] Parse deplibs sections for possible libcalls..

I've created https://github.com/llvm/llvm-project/issues/56070 to track the general issue and provide more background on the issue's diagnosis.

Jun 16 2022, 10:51 AM · Restricted Project, Restricted Project

Jun 15 2022

mysterymath added a comment to D127885: [LTO] Parse deplibs sections for possible libcalls..

This breaks the symbol resolution model of LTO. The symbol resolution intends to know all symbols and no new symbol can be added after LTO compiling.

Jun 15 2022, 4:32 PM · Restricted Project, Restricted Project
mysterymath published D127885: [LTO] Parse deplibs sections for possible libcalls. for review.
Jun 15 2022, 4:17 PM · Restricted Project, Restricted Project

Jun 13 2022

mysterymath updated the diff for D126980: [Symbolize] Add log markup --filter to llvm-symbolizer..

Remove tryFilter abstraction; unneeded complexity.

Jun 13 2022, 11:17 AM · Restricted Project, Restricted Project

Jun 10 2022

mysterymath updated the diff for D126980: [Symbolize] Add log markup --filter to llvm-symbolizer..

Add pretty error location reporting.

Jun 10 2022, 4:29 PM · Restricted Project, Restricted Project

Jun 9 2022

mysterymath updated the diff for D126980: [Symbolize] Add log markup --filter to llvm-symbolizer..

Integrate.

Jun 9 2022, 5:00 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D124798: [Symbolize] Parse multi-line markup elements..

Fix tests.

Jun 9 2022, 5:00 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D126980: [Symbolize] Add log markup --filter to llvm-symbolizer..

Integrate.

Jun 9 2022, 3:45 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D124798: [Symbolize] Parse multi-line markup elements..

Integrate.

Jun 9 2022, 3:44 PM · Restricted Project, Restricted Project
mysterymath updated the diff for D124686: [Symbolize] Parser for log symbolizer markup..

Fix parsing for empty field.

Jun 9 2022, 3:43 PM · Restricted Project, Restricted Project

Jun 8 2022

mysterymath added a comment to D126815: [llvm] [Support] [Debuginfod] waitQueueSize for ThreadPool.

I suppose another direction would be to abandon the producer-consumer model altogether. In D114845, this could be done (in part) by letting the threads share access to the recursive_directory_iterator, acquiring a lock then advancing it on their own to harvest jobs from the filesystem.

I like that; it should decouple those commits from this one, and it should be quite a bit cleaner than maintaining size counters.

Jun 8 2022, 4:55 PM · Restricted Project, Restricted Project