This is an archive of the discontinued LLVM Phabricator instance.

[1/8][RISCV] Add rounding mode control variant for vfsub, vfrsub
ClosedPublic

Authored by eopXD on Jul 6 2023, 10:56 AM.

Details

Summary

Depends on D152996.

This patch-set aims to add a variant for the RVV floating-point
intrinsics that controls the rounding mode (frm). The rounding mode
variant appends _rm before the policy suffix to distinguish from
those without them.

Specification PR: riscv-non-isa/rvv-intrinsic-doc#226

This is the 1st patch of the patch-set.

Diff Detail

Event Timeline

eopXD created this revision.Jul 6 2023, 10:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2023, 10:56 AM
eopXD requested review of this revision.Jul 6 2023, 10:56 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 6 2023, 10:56 AM
eopXD retitled this revision from [RISCV] Add rounding mode control variant for vfsub, vfrsub to [1/8][RISCV] Add rounding mode control variant for vfsub, vfrsub.Jul 6 2023, 11:08 AM
eopXD edited the summary of this revision. (Show Details)
craig.topper added inline comments.Jul 6 2023, 11:57 AM
clang/lib/Sema/SemaChecking.cpp
4810–4811

Not related to this patch, but why do the builtins end in _ta when the C intrinsics don't?

llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
5725–5726

Why do we need hasSideEffects = 0 now? We didn't have it before.

eopXD marked an inline comment as done.Jul 6 2023, 10:53 PM
eopXD added inline comments.
clang/lib/Sema/SemaChecking.cpp
4810–4811

Yes this is a redundancy here, the _ta suffix should be removed. I will do this is a separate patch.

llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
5725–5726

This is redundant here. I was assuming that the table gen can't correctly infer here. Removed.

eopXD updated this revision to Diff 537993.Jul 6 2023, 10:53 PM
eopXD marked an inline comment as done.
eopXD edited the summary of this revision. (Show Details)

Address comment from Craig.

craig.topper added inline comments.Jul 10 2023, 11:14 AM
clang/lib/Sema/SemaChecking.cpp
4812

This needs to rebased after removing _ta?

This revision is now accepted and ready to land.Jul 10 2023, 11:16 AM
eopXD updated this revision to Diff 539426.Jul 12 2023, 1:39 AM
eopXD marked 2 inline comments as done.

Change:

  • Rebase upon latest main and latest parent revision
This revision was landed with ongoing or failed builds.Jul 13 2023, 12:35 AM
This revision was automatically updated to reflect the committed changes.