Details

Reviewers

craig.topper
kito-cheng
rogfer01
arcbbb
reames

Summary

Depends on D151396.

This is the 3rd patch of the patch-set. For the cover letter of the
patch-set, please checkout D151395.

This commit consists of change in both clang front-end and RISC-
back-end.

In the front-end, this commit adds an additional operand to the C
intrinsics of vaadd, vaaddu, vasub, and vasubu, that models
the control of the rounding mode.

In the back-end, using vaadd as an example, this commit replaces the
existing int.riscv.vaadd.* with int.riscv.vaadd.rm.* that was
introduced in the previous patch, with the extra operand that models
the control of the rounding mode (vxrm) for RVV fixed-point
intrinsics.

Note: The first 3 commit of the patch-set shows the intent to model the
rounding mode for fixed-point intrinsics by applying change to
vaadd, vaaddu, vasub, and vasubu. The proceeding patch will
apply the change to the rest of the other fixed-point instructions.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	3,710 ms	x64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases/Linux::auto_memory_profile_test.cpp Script: -- : 'RUN: at line 6'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only -m64 -shared-libasan /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/asan/TestCases/Linux/auto_memory_profile_test.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/asan/X86_64LinuxDynamicConfig/TestCases/Linux/Output/auto_memory_profile_test.cpp.tmp

Event Timeline

eopXD created this revision.Wed, May 24, 7:11 PM

Herald added a project: Restricted Project. · View Herald TranscriptWed, May 24, 7:11 PM

Herald added subscribers: jobnoorman, luke, VincentWu and 28 others. · View Herald Transcript

eopXD requested review of this revision.Wed, May 24, 7:11 PM

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptWed, May 24, 7:11 PM

Herald added subscribers: llvm-commits, cfe-commits, pcwang-thead, MaskRay. · View Herald Transcript

Harbormaster completed remote builds in B234372: Diff 525402.Wed, May 24, 7:12 PM

eopXD edited the summary of this revision. (Show Details)Wed, May 24, 7:44 PM

eopXD added a parent revision: D151396: [2/N][RISCV] Model vxrm in LLVM intrinsics and machine instructions for RVV fixed-point instructions.

Bump CI.

eopXD added reviewers: craig.topper, kito-cheng, rogfer01, arcbbb, reames.Wed, May 24, 7:48 PM

craig.topper added inline comments.Wed, May 24, 8:22 PM

clang/include/clang/Basic/riscv_vector.td
2134	Extra blank line
clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vaadd.c
16	The vxrm argument is unused
llvm/include/llvm/IR/IntrinsicsRISCV.td
1363–1364	Why did the intrinsic change names?

craig.topper added inline comments.Wed, May 24, 8:37 PM

llvm/include/llvm/IR/IntrinsicsRISCV.td
1363–1364	Nevermind. I misread this.

Address comments from Craig. Now the patch includes changes to vaadd, vaaddu, vasub, and vasubu.

eopXD marked an inline comment as done.Thu, May 25, 12:18 AM

eopXD added inline comments.

llvm/include/llvm/IR/IntrinsicsRISCV.td
1363–1364	Marking this as done.

Harbormaster completed remote builds in B234418: Diff 525463.Thu, May 25, 12:18 AM

eopXD edited the summary of this revision. (Show Details)Thu, May 25, 12:19 AM

eopXD edited the summary of this revision. (Show Details)Thu, May 25, 12:22 AM

Bump CI because previous diff failed in patch application.

Harbormaster completed remote builds in B234420: Diff 525473.Thu, May 25, 7:53 AM

Resolve test failure.

Harbormaster completed remote builds in B234775: Diff 525951.Thu, May 25, 11:51 PM

craig.topper added inline comments.Wed, May 31, 1:01 PM

clang/include/clang/Basic/riscv_vector.td
2079	enum name needs `__` prefix
2080	These need `__` prefix

[3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd
Needs ReviewPublic
Actions

Details

Diff Detail

Unit TestsFailed
View All

Event Timeline

Revision Contents
Changeset List

Diff 525951

clang/include/clang/Basic/riscv_vector.td

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vaadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vaaddu.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vasub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vasubu.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/overloaded/vaadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/overloaded/vaaddu.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/overloaded/vasub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/overloaded/vasubu.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vaadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vaaddu.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vasub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vasubu.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/overloaded/vaadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/overloaded/vaaddu.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/overloaded/vasub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/overloaded/vasubu.c

llvm/include/llvm/IR/IntrinsicsRISCV.td

llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td

llvm/test/CodeGen/RISCV/rvv/masked-tama.ll

llvm/test/CodeGen/RISCV/rvv/masked-tamu.ll

llvm/test/CodeGen/RISCV/rvv/masked-tuma.ll

llvm/test/CodeGen/RISCV/rvv/masked-tumu.ll

llvm/test/CodeGen/RISCV/rvv/vaadd.ll

llvm/test/CodeGen/RISCV/rvv/vaaddu.ll

llvm/test/CodeGen/RISCV/rvv/vasub.ll

llvm/test/CodeGen/RISCV/rvv/vasubu.ll

[3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaaddNeeds ReviewPublicActions

Details

Diff Detail

Unit TestsFailedView All

Event Timeline

Revision ContentsChangeset List

Diff 525951

clang/include/clang/Basic/riscv_vector.td

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vaadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vaaddu.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vasub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vasubu.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/overloaded/vaadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/overloaded/vaaddu.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/overloaded/vasub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/overloaded/vasubu.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vaadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vaaddu.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vasub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/non-overloaded/vasubu.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/overloaded/vaadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/overloaded/vaaddu.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/overloaded/vasub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/policy/overloaded/vasubu.c

llvm/include/llvm/IR/IntrinsicsRISCV.td

llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td

llvm/test/CodeGen/RISCV/rvv/masked-tama.ll

llvm/test/CodeGen/RISCV/rvv/masked-tamu.ll

llvm/test/CodeGen/RISCV/rvv/masked-tuma.ll

llvm/test/CodeGen/RISCV/rvv/masked-tumu.ll

llvm/test/CodeGen/RISCV/rvv/vaadd.ll

llvm/test/CodeGen/RISCV/rvv/vaaddu.ll

llvm/test/CodeGen/RISCV/rvv/vasub.ll

llvm/test/CodeGen/RISCV/rvv/vasubu.ll

[3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd
Needs ReviewPublic
Actions

Unit TestsFailed
View All

Revision Contents
Changeset List