This is an archive of the discontinued LLVM Phabricator instance.

Restore CodeGen/MachineValueType.h from `Support`
ClosedPublic

Authored by chapuni on Apr 23 2023, 9:22 AM.

Details

Summary

This is rework of;

Since LowLevelType.h has been restored to CodeGen, MachinveValueType.h
can be restored as well.

Depends on D148767

Diff Detail

Event Timeline

chapuni created this revision.Apr 23 2023, 9:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2023, 9:22 AM
chapuni requested review of this revision.Apr 23 2023, 9:22 AM
arsenm accepted this revision.Apr 24 2023, 1:07 PM
This revision is now accepted and ready to land.Apr 24 2023, 1:07 PM
chapuni updated this revision to Diff 518714.May 2 2023, 7:21 AM
chapuni edited the summary of this revision. (Show Details)
  • Rebase and update the desc
chapuni updated this revision to Diff 518716.May 2 2023, 7:23 AM
chapuni edited the summary of this revision. (Show Details)
  • Update the desc
chapuni updated this revision to Diff 518718.May 2 2023, 7:24 AM
chapuni retitled this revision from Restore CodeGen/MachineValueType.h to Restore CodeGen/MachineValueType.h from `Support`.
  • Update the desc
This revision was landed with ongoing or failed builds.May 2 2023, 8:18 AM
This revision was automatically updated to reflect the committed changes.

Hello @chapuni, the commit breaks MLIR build, because the old path is used e.g. in https://github.com/llvm/llvm-project/blob/main/mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp
Could you please fix it?

@vzakhari @aaron.ballman
I expect rGea2b79d48d71 will fix. Sorry for the noise.

@vzakhari @aaron.ballman
I expect rGea2b79d48d71 will fix. Sorry for the noise.

Thank you!

@vzakhari @aaron.ballman
I expect rGea2b79d48d71 will fix. Sorry for the noise.

Thank you, that seemed to fix the MLIR issues, though I notice one of the bots has a different kind of issue that is probably unrelated to your changes: https://lab.llvm.org/buildbot/#/builders/197/builds/4720/steps/7/logs/FAIL__LLVM__sme-aarch64-svcount_ll