This is an archive of the discontinued LLVM Phabricator instance.

[CMake] add_tablegen: Rename host tablegen to `${target}-host"
ClosedPublic

Authored by chapuni on Apr 27 2023, 6:37 AM.

Details

Summary

Since llvm-min-tblgen has been introduced, llvm-min-tblgen-host
would make more sense than LLVM_HEADERS-tablegen-host.

Depends on D146352

Diff Detail

Event Timeline

chapuni created this revision.Apr 27 2023, 6:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 6:37 AM
Herald added a subscriber: ekilmer. · View Herald Transcript
chapuni requested review of this revision.Apr 27 2023, 6:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 6:37 AM
mstorsjo accepted this revision.Apr 27 2023, 7:20 AM

LGTM, although the commit message is a bit cryptic. What about:

This is a pure refactoring and simplification, allowing decoupling ${target} from ${project} in the future.

This revision is now accepted and ready to land.Apr 27 2023, 7:20 AM
This revision was landed with ongoing or failed builds.May 1 2023, 7:36 PM
This revision was automatically updated to reflect the committed changes.