Page MenuHomePhabricator

chapuni (NAKAMURA Takumi)
at home

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2012, 6:50 PM (520 w, 6 d)

THE BUILDBOT BB.PGR.JP IS WATCHING YOU!11!1

Recent Activity

Sat, Jul 2

chapuni committed rG1ecfc12b0c67: [Bazel] Make `builtin_headers_gen` as subset of CMake's `clang-resource-headers` (authored by chapuni).
[Bazel] Make `builtin_headers_gen` as subset of CMake's `clang-resource-headers`
Sat, Jul 2, 11:47 PM · Restricted Project

Fri, Jul 1

chapuni added inline comments to D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC.
Fri, Jul 1, 7:12 AM · Restricted Project, Restricted Project
Herald added a project to D75788: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants: Restricted Project.
Fri, Jul 1, 7:10 AM · Restricted Project, Restricted Project

Fri, Jun 17

chapuni committed rG0716b3ec09f4: [Bazel] Rename generated *_main.cpp to [tool-name]-driver.cpp which CMake uses. (authored by chapuni).
[Bazel] Rename generated *_main.cpp to [tool-name]-driver.cpp which CMake uses.
Fri, Jun 17, 9:36 PM · Restricted Project

Wed, Jun 15

chapuni accepted D127940: [JITLink][AArch64][NFC] Suppress unused variable error..

I think this is a trivial fix and you may commit w/o review.

Wed, Jun 15, 11:23 PM · Restricted Project, Restricted Project
chapuni added inline comments to D127558: [JITLink][AArch64] Unify table managers of ELF and MachO..
Wed, Jun 15, 7:02 PM · Restricted Project, Restricted Project

Mon, Jun 6

chapuni added inline comments to D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor.
Mon, Jun 6, 6:55 PM · debug-info, Restricted Project, Restricted Project
chapuni added a comment to D109977: LLVM Driver Multicall tool.

An interesting improvement. Thanks.

Mon, Jun 6, 5:27 PM · Restricted Project, Restricted Project, Restricted Project

May 27 2022

chapuni committed rGde20fb72adb4: [bazel] BLAKE3: Adopt aarch64 and x86_64. (authored by chapuni).
[bazel] BLAKE3: Adopt aarch64 and x86_64.
May 27 2022, 3:06 PM · Restricted Project
chapuni closed D126543: [bazel] BLAKE3: Adopt aarch64 and x86_64..
May 27 2022, 3:06 PM · Restricted Project, Restricted Project
chapuni added inline comments to D126543: [bazel] BLAKE3: Adopt aarch64 and x86_64..
May 27 2022, 3:04 PM · Restricted Project, Restricted Project
chapuni updated the diff for D126543: [bazel] BLAKE3: Adopt aarch64 and x86_64..
  • Fixup
May 27 2022, 3:02 PM · Restricted Project, Restricted Project
chapuni added a reviewer for D126543: [bazel] BLAKE3: Adopt aarch64 and x86_64.: MaskRay.
May 27 2022, 7:48 AM · Restricted Project, Restricted Project
chapuni requested review of D126543: [bazel] BLAKE3: Adopt aarch64 and x86_64..
May 27 2022, 7:47 AM · Restricted Project, Restricted Project

May 26 2022

chapuni committed rG6f434776da0b: [bazel] Introduce "VE" CodeGen in LLVM. (authored by chapuni).
[bazel] Introduce "VE" CodeGen in LLVM.
May 26 2022, 6:40 AM · Restricted Project

May 25 2022

chapuni committed rG65ab6b495a6a: [bazel] Unset REVISION as if LLVM_APPEND_VC_REV=OFF, for now. (authored by chapuni).
[bazel] Unset REVISION as if LLVM_APPEND_VC_REV=OFF, for now.
May 25 2022, 2:25 PM · Restricted Project
chapuni committed rG801ac2ebf19c: [bazel] Bump to 15.0.0git (authored by chapuni).
[bazel] Bump to 15.0.0git
May 25 2022, 2:25 PM · Restricted Project

May 23 2022

chapuni committed rGc8e087082927: [TableGen] emitStringLiteralDef: Pad trailing '\0' at the end of char array. (authored by chapuni).
[TableGen] emitStringLiteralDef: Pad trailing '\0' at the end of char array.
May 23 2022, 2:25 PM · Restricted Project, Restricted Project
chapuni closed D126136: [TableGen] emitStringLiteralDef: Pad trailing '\0' at the end of char array..
May 23 2022, 2:25 PM · Restricted Project, Restricted Project
chapuni committed rG40b9a2616e45: emitStringLiteralDef: Return earlier here. NFC. (authored by chapuni).
emitStringLiteralDef: Return earlier here. NFC.
May 23 2022, 2:03 PM · Restricted Project, Restricted Project
chapuni closed D126135: emitStringLiteralDef: Return earlier here. NFC..
May 23 2022, 2:03 PM · Restricted Project, Restricted Project
chapuni added a comment to D123537: [VPlan] Model first exit values using VPLiveOut..

This brings unstable behavior.

May 23 2022, 7:03 AM · Restricted Project, Restricted Project

May 22 2022

chapuni committed rGcd5f3241c386: ADT::GenericCycleInfo: Hide validateTree() in -Asserts. (authored by chapuni).
ADT::GenericCycleInfo: Hide validateTree() in -Asserts.
May 22 2022, 9:16 AM · Restricted Project, Restricted Project

May 21 2022

chapuni added a comment to D126136: [TableGen] emitStringLiteralDef: Pad trailing '\0' at the end of char array..

I will rebase this after D126135 will be applied.

May 21 2022, 5:21 PM · Restricted Project, Restricted Project
chapuni added reviewers for D126136: [TableGen] emitStringLiteralDef: Pad trailing '\0' at the end of char array.: ldrumm, rnk.
May 21 2022, 5:20 PM · Restricted Project, Restricted Project
chapuni requested review of D126136: [TableGen] emitStringLiteralDef: Pad trailing '\0' at the end of char array..
May 21 2022, 5:18 PM · Restricted Project, Restricted Project
chapuni added a reviewer for D126135: emitStringLiteralDef: Return earlier here. NFC.: ldrumm.
May 21 2022, 5:16 PM · Restricted Project, Restricted Project
chapuni requested review of D126135: emitStringLiteralDef: Return earlier here. NFC..
May 21 2022, 5:15 PM · Restricted Project, Restricted Project

May 20 2022

chapuni committed rG8801a5d185fa: SystemZAsmPrinter.cpp: Fix a warning. [-Wunused-variable] (authored by chapuni).
SystemZAsmPrinter.cpp: Fix a warning. [-Wunused-variable]
May 20 2022, 3:55 PM · Restricted Project, Restricted Project

May 18 2022

chapuni added inline comments to D125627: [SCEV] Serialize function calls in function arguments..
May 18 2022, 7:38 AM · Restricted Project, Restricted Project
chapuni added a comment to D125627: [SCEV] Serialize function calls in function arguments..

At the moment, I have committed llvmorg-15-init-10782-g6ca7eb2c6d7d

May 18 2022, 7:25 AM · Restricted Project, Restricted Project
chapuni committed rG6ca7eb2c6d7d: [SCEV] Part 1, Serialize function calls in function arguments. (authored by chapuni).
[SCEV] Part 1, Serialize function calls in function arguments.
May 18 2022, 7:23 AM · Restricted Project, Restricted Project

May 15 2022

chapuni added reviewers for D125627: [SCEV] Serialize function calls in function arguments.: efriedma, reames.
May 15 2022, 5:23 AM · Restricted Project, Restricted Project
chapuni requested review of D125627: [SCEV] Serialize function calls in function arguments..
May 15 2022, 5:07 AM · Restricted Project, Restricted Project
chapuni committed rGda7d8de1e4ab: ScalarEvolution.cpp: Reformat. (authored by chapuni).
ScalarEvolution.cpp: Reformat.
May 15 2022, 4:52 AM · Restricted Project, Restricted Project
chapuni committed rGbdab5c4b3d20: ARMFixCortexA57AES1742098Pass.cpp: Suppress a warning. [-Wunused-but-set… (authored by chapuni).
ARMFixCortexA57AES1742098Pass.cpp: Suppress a warning. [-Wunused-but-set…
May 15 2022, 2:03 AM · Restricted Project, Restricted Project

May 10 2022

chapuni added a comment to D123782: [AArch64] Generate AND in place of CSEL for Table Based CTTZ lowering in -O3.

@chapuni @dmgreen How do I trigger this unit test failure? When I run check-llvm-unit all the tests pass for me. I don't understand what I am missing here.

May 10 2022, 3:34 PM · Restricted Project, Restricted Project
chapuni added a comment to D123782: [AArch64] Generate AND in place of CSEL for Table Based CTTZ lowering in -O3.

This causes miscompilation in llvm::lowertypetests::BitSetBuilder::build() in llvm/lib/Transforms/IPO/LowerTypeTests.cpp.
LLVM-Unit::IPOTests catches this.
BSI.AlignLog2 is masked by "and #0x1F".

May 10 2022, 7:16 AM · Restricted Project, Restricted Project

Apr 30 2022

chapuni committed rGa60ef98bb113: ClangDriverTests:ToolChainTest.cpp: Fix warnings. [-Wsign-compare] (authored by chapuni).
ClangDriverTests:ToolChainTest.cpp: Fix warnings. [-Wsign-compare]
Apr 30 2022, 1:24 AM · Restricted Project, Restricted Project

Apr 29 2022

chapuni committed rG2e6657b340f0: llvm/Support/Debug.h: Suppress warnings with -Asserts. [-Wunused-variable] (authored by chapuni).
llvm/Support/Debug.h: Suppress warnings with -Asserts. [-Wunused-variable]
Apr 29 2022, 5:06 AM · Restricted Project, Restricted Project
chapuni committed rG61d3a3afe26f: AVRExpandPseudoInsts.cpp: Fix a warning. [-Wunused-but-set-variable] (authored by chapuni).
AVRExpandPseudoInsts.cpp: Fix a warning. [-Wunused-but-set-variable]
Apr 29 2022, 5:06 AM · Restricted Project, Restricted Project

Jul 4 2021

chapuni added a comment to D74106: [CMake] Use PUBLIC link mode for static libraries.

@phosek Please let me know how to reproduce your issue. I haven't reproduced yet.

Jul 4 2021, 4:18 AM · Restricted Project

Jun 11 2021

chapuni added a comment to D103441: [SLP] Avoid std::stable_sort(properlyDominates())..

@hvdijk Thanks!

Jun 11 2021, 5:09 AM · Restricted Project

May 7 2021

chapuni accepted D102021: [NFC] Correctly assert the indents for printEnumValHelpStr..

Please remind to feed it into release/12.x, thanks!

May 7 2021, 4:46 AM · Restricted Project

May 6 2021

chapuni added a comment to D102021: [NFC] Correctly assert the indents for printEnumValHelpStr..

Okay, it's fair.
(May I wait for 3rd opinion?)

May 6 2021, 1:47 PM · Restricted Project

May 1 2021

chapuni added a comment to D93494: [Support] Indent multi-line descr of enum cli options..

It might causes assertion failure when a name in enum is long.
Reproducible with clang-scan-deps -help

May 1 2021, 6:17 AM · Restricted Project

Mar 24 2019

chapuni added a comment to D16761: clang-cl: Support loading plugins on Windows.

@v.g.vassilev, I couldn't explain what it caused. Fell free to recommit.

Mar 24 2019, 1:57 PM

Nov 21 2018

chapuni accepted D47810: [nios2] Add missing Nios2CodeGen -> Nios2AsmPrinter linkage.

I think such a fixup may be "obvious". Go ahead!

Nov 21 2018, 2:29 AM

Aug 9 2018

chapuni added a comment to D50528: Remove vestiges of configure buildsystem.

I guess, the llvm tree could be built in-tree.

Aug 9 2018, 3:46 PM

Jul 23 2018

chapuni added a comment to D49672: [CMake] Honor LLVM_EXTERNAL_<proj>_SOURCE_DIR.

I expect LLVM_EXTERNAL_*_SOURCE_DIR will work if LLVM_ENABLE_PROJECT doesn't include one.

Jul 23 2018, 3:44 PM · Restricted Project

Nov 21 2017

chapuni committed rL318743: SLPVectorizer.cpp: Avoid std::stable_sort(properlyDominates())..
SLPVectorizer.cpp: Avoid std::stable_sort(properlyDominates()).
Nov 21 2017, 1:41 AM

Nov 15 2017

chapuni committed rL318347: clang/module.modulemap: clang/Basic/X86Target.def may be textual header..
clang/module.modulemap: clang/Basic/X86Target.def may be textual header.
Nov 15 2017, 3:05 PM

Nov 14 2017

chapuni committed rL318275: GISelWorkList.h: Fix -fmodules build in rL318210..
GISelWorkList.h: Fix -fmodules build in rL318210.
Nov 14 2017, 11:36 PM
chapuni committed rL318274: ASTMatchers.h: Avoid warnings due to "@throw". [-Wdocumentation].
ASTMatchers.h: Avoid warnings due to "@throw". [-Wdocumentation]
Nov 14 2017, 10:55 PM
chapuni committed rL318273: Fix llvm/test/Transforms/LoopRotate/pr35210.ll in rL318237, it uses debug….
Fix llvm/test/Transforms/LoopRotate/pr35210.ll in rL318237, it uses debug…
Nov 14 2017, 10:47 PM

Nov 10 2017

chapuni committed rL317966: llvm/Support/TargetParser.h: Fix -fmodules build in rL317900..
llvm/Support/TargetParser.h: Fix -fmodules build in rL317900.
Nov 10 2017, 6:06 PM

Nov 7 2017

chapuni added a comment to D36073: [CGP] Extends the scope of optimizeMemoryInst optimization.

Seems it broke selfhosting. http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2/builds/13335

Nov 7 2017, 9:34 PM

Nov 6 2017

chapuni committed rL317538: ClangdTests/JSONExprTests.cpp: Appease g++-4.8 to move raw string literal out….
ClangdTests/JSONExprTests.cpp: Appease g++-4.8 to move raw string literal out…
Nov 6 2017, 6:19 PM

Nov 3 2017

chapuni committed rL317404: llvm/test/lit.cfg.py: Don't set the feature "llvm-64-bits" if -m32 is specified..
llvm/test/lit.cfg.py: Don't set the feature "llvm-64-bits" if -m32 is specified.
Nov 3 2017, 11:56 PM
chapuni committed rL317402: CMake: Let LLVM_BUILD_32_BITS aware of large file..
CMake: Let LLVM_BUILD_32_BITS aware of large file.
Nov 3 2017, 11:04 PM
chapuni committed rL317401: llvm/test/Object/archive-SYM64-write.test: Delete large temp files. They are….
llvm/test/Object/archive-SYM64-write.test: Delete large temp files. They are…
Nov 3 2017, 11:00 PM

Nov 2 2017

chapuni committed rL317191: llvm-c/DebugInfo.h: Fix warning. [-Wdocumentation].
llvm-c/DebugInfo.h: Fix warning. [-Wdocumentation]
Nov 2 2017, 1:03 AM

Nov 1 2017

chapuni committed rL317091: Fix warnings discovered by rL317076. [-Wunused-private-field].
Fix warnings discovered by rL317076. [-Wunused-private-field]
Nov 1 2017, 6:48 AM
chapuni committed rL317090: Suppress a warning discovered by rL317076. [-Wunused-private-field].
Suppress a warning discovered by rL317076. [-Wunused-private-field]
Nov 1 2017, 6:48 AM
chapuni committed rL317089: Reformat..
Reformat.
Nov 1 2017, 6:48 AM

Oct 31 2017

chapuni committed rL317077: Revert rL317019, "[ADT] Split optional to only include copy mechanics and dtor….
Revert rL317019, "[ADT] Split optional to only include copy mechanics and dtor…
Oct 31 2017, 10:15 PM
chapuni added a reverting change for rL317019: [ADT] Split optional to only include copy mechanics and dtor for non-trivial…: rL317077: Revert rL317019, "[ADT] Split optional to only include copy mechanics and dtor….
Oct 31 2017, 10:15 PM
chapuni committed rL317078: Reformat..
Reformat.
Oct 31 2017, 10:15 PM
chapuni committed rL317075: clang/lib/Format/Format.cpp: Fix warnings introduced in rL316903. [-Wpedantic].
clang/lib/Format/Format.cpp: Fix warnings introduced in rL316903. [-Wpedantic]
Oct 31 2017, 9:44 PM

Oct 30 2017

chapuni added a comment to D38586: SLPVectorizer.cpp: Ensure SLPVectorizer can visit each block by dominated order.

The issue is that std::sort is insufficient with properlyDominates() as comparator.
So, I have to propose to get rid of std::sort there.

Oct 30 2017, 3:21 AM · Restricted Project

Oct 27 2017

chapuni abandoned D39038: Mark lld/test/ELF as flaky..

I will apply this patch locally while the issue is here.

Oct 27 2017, 5:57 AM

Oct 26 2017

chapuni committed rL316743: llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h: Fix -fmodules build….
llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h: Fix -fmodules build…
Oct 26 2017, 10:45 PM

Oct 21 2017

chapuni committed rL316260: clang-tidy: Fix deps..
clang-tidy: Fix deps.
Oct 21 2017, 4:02 AM

Oct 19 2017

chapuni added a comment to D39038: Mark lld/test/ELF as flaky..

I guess the constructor std::thread(F) fails, then its method, detach() crashes.
If we live with -fno-exceptions, I think we may rewrite Parallel.cpp w/o C++11 std::thread, but with pthreads, to catch failure in pthread_create.

Oct 19 2017, 6:31 PM
chapuni added a comment to D39038: Mark lld/test/ELF as flaky..

Reproduced with RelWithDebInfo.
Crashing in pthread_detach.

Oct 19 2017, 5:12 PM

Oct 18 2017

chapuni added a comment to D39038: Mark lld/test/ELF as flaky..

For example; http://bb9.pgr.jp/#/builders/20/builds/144

Oct 18 2017, 3:54 PM
chapuni committed rL316079: Untabify..
Untabify.
Oct 18 2017, 6:31 AM
chapuni added a comment to D35541: [CMake] Use #cmakedefine01 for CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER).

@krasimir, I concluded it is trivial and committed it with the URL to close this.
Feel free to revert if you had any matters.

Oct 18 2017, 2:44 AM

Oct 17 2017

chapuni added a comment to D39038: Mark lld/test/ELF as flaky..

@davide, This is why I didn't silently commit such a trivial change. I am happy if it could be reproduced easily.

Oct 17 2017, 10:39 PM
chapuni committed rL316061: [CMake] Use #cmakedefine01 for CLANG_ENABLE_….
[CMake] Use #cmakedefine01 for CLANG_ENABLE_…
Oct 17 2017, 10:21 PM
chapuni closed D35541: [CMake] Use #cmakedefine01 for CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER) by committing rL316061: [CMake] Use #cmakedefine01 for CLANG_ENABLE_….
Oct 17 2017, 10:21 PM
chapuni created D39039: Lit: Implement RWLock to serialize retrying flaky test..
Oct 17 2017, 10:15 PM
chapuni created D39038: Mark lld/test/ELF as flaky..
Oct 17 2017, 10:07 PM
chapuni committed rL316060: Prune trailing linefeed..
Prune trailing linefeed.
Oct 17 2017, 9:45 PM
chapuni created D39037: check-libcxx: Introduce config.test_retry_attempts for std/thread..
Oct 17 2017, 9:25 PM

Oct 16 2017

chapuni committed rL315896: Revert rL315894, "SLPVectorizer.cpp: Try to appease stage2-3 difference..
Revert rL315894, "SLPVectorizer.cpp: Try to appease stage2-3 difference.
Oct 16 2017, 2:50 AM
chapuni added a reverting change for rL315894: SLPVectorizer.cpp: Try to appease stage2-3 difference. (D38586): rL315896: Revert rL315894, "SLPVectorizer.cpp: Try to appease stage2-3 difference..
Oct 16 2017, 2:50 AM
chapuni committed rL315894: SLPVectorizer.cpp: Try to appease stage2-3 difference. (D38586).
SLPVectorizer.cpp: Try to appease stage2-3 difference. (D38586)
Oct 16 2017, 2:15 AM

Oct 14 2017

chapuni updated subscribers of D38678: [Sema] Warn about unused variables if we can constant evaluate the initializer..

Excuse me, I have reverted it in rL315806. check-libcxx dislikes it.

Oct 14 2017, 7:50 AM
chapuni committed rL315806: Revert rL315787, "[Sema] Warn about unused variables if we can constant….
Revert rL315787, "[Sema] Warn about unused variables if we can constant…
Oct 14 2017, 7:46 AM
chapuni added a reverting change for rL315787: [Sema] Warn about unused variables if we can constant evaluate the initializer.: rL315806: Revert rL315787, "[Sema] Warn about unused variables if we can constant….
Oct 14 2017, 7:46 AM
chapuni committed rL315803: Revert rL315721, "Handle shared and lazy symbol in the gnu hash construction.".
Revert rL315721, "Handle shared and lazy symbol in the gnu hash construction."
Oct 14 2017, 5:22 AM
chapuni added a reverting change for rL315721: Handle shared and lazy symbol in the gnu hash construction.: rL315803: Revert rL315721, "Handle shared and lazy symbol in the gnu hash construction.".
Oct 14 2017, 5:22 AM

Oct 12 2017

chapuni added inline comments to D33989: [OpenCL] Allow targets to select address space per type.
Oct 12 2017, 3:01 AM
chapuni committed rL315573: Fix warnings. [-Wdocumentation].
Fix warnings. [-Wdocumentation]
Oct 12 2017, 2:42 AM
chapuni committed rL315572: SVal::getAsSymbol(bool IncludeBaseRegions): Follow….
SVal::getAsSymbol(bool IncludeBaseRegions): Follow…
Oct 12 2017, 2:42 AM

Oct 11 2017

chapuni committed rL315566: clang/module.modulemap: Create Clang_Frontend_CodeGenOptions to remove some….
clang/module.modulemap: Create Clang_Frontend_CodeGenOptions to remove some…
Oct 11 2017, 11:39 PM
chapuni committed rL315537: lld: Prune unused libdeps..
lld: Prune unused libdeps.
Oct 11 2017, 5:04 PM
chapuni committed rL315529: lld: Reorder libdeps..
lld: Reorder libdeps.
Oct 11 2017, 4:19 PM
chapuni closed D38828: lld: Reorder dependent libraries alphabetically by committing rL315529: lld: Reorder libdeps..
Oct 11 2017, 4:18 PM