Page MenuHomePhabricator
People chapuni

chapuni (NAKAMURA Takumi)
at home

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2012, 6:50 PM (466 w, 23 h)

THE BUILDBOT BB.PGR.JP IS WATCHING YOU!11!1

Recent Activity
View All

Fri, Jun 11

chapuni added a comment to D103441: [SLP] Avoid std::stable_sort(properlyDominates())..

@hvdijk Thanks!

Fri, Jun 11, 5:09 AM · Restricted Project

May 7 2021

chapuni accepted D102021: [NFC] Correctly assert the indents for printEnumValHelpStr..

Please remind to feed it into release/12.x, thanks!

May 7 2021, 4:46 AM · Restricted Project

May 6 2021

chapuni added a comment to D102021: [NFC] Correctly assert the indents for printEnumValHelpStr..

Okay, it's fair.
(May I wait for 3rd opinion?)

May 6 2021, 1:47 PM · Restricted Project

May 1 2021

chapuni added a comment to D93494: [Support] Indent multi-line descr of enum cli options..

It might causes assertion failure when a name in enum is long.
Reproducible with clang-scan-deps -help

May 1 2021, 6:17 AM · Restricted Project

Mar 24 2019

chapuni added a comment to D16761: clang-cl: Support loading plugins on Windows.

@v.g.vassilev, I couldn't explain what it caused. Fell free to recommit.

Mar 24 2019, 1:57 PM

Nov 21 2018

chapuni accepted D47810: [nios2] Add missing Nios2CodeGen -> Nios2AsmPrinter linkage.

I think such a fixup may be "obvious". Go ahead!

Nov 21 2018, 2:29 AM

Aug 9 2018

chapuni added a comment to D50528: Remove vestiges of configure buildsystem.

I guess, the llvm tree could be built in-tree.

Aug 9 2018, 3:46 PM

Jul 23 2018

chapuni added a comment to D49672: [CMake] Honor LLVM_EXTERNAL_<proj>_SOURCE_DIR.

I expect LLVM_EXTERNAL_*_SOURCE_DIR will work if LLVM_ENABLE_PROJECT doesn't include one.

Jul 23 2018, 3:44 PM · Restricted Project

Nov 21 2017

chapuni committed rL318743: SLPVectorizer.cpp: Avoid std::stable_sort(properlyDominates())..
SLPVectorizer.cpp: Avoid std::stable_sort(properlyDominates()).
Nov 21 2017, 1:41 AM

Nov 15 2017

chapuni committed rL318347: clang/module.modulemap: clang/Basic/X86Target.def may be textual header..
clang/module.modulemap: clang/Basic/X86Target.def may be textual header.
Nov 15 2017, 3:05 PM

Nov 14 2017

chapuni committed rL318275: GISelWorkList.h: Fix -fmodules build in rL318210..
GISelWorkList.h: Fix -fmodules build in rL318210.
Nov 14 2017, 11:36 PM
chapuni committed rL318274: ASTMatchers.h: Avoid warnings due to "@throw". [-Wdocumentation].
ASTMatchers.h: Avoid warnings due to "@throw". [-Wdocumentation]
Nov 14 2017, 10:55 PM
chapuni committed rL318273: Fix llvm/test/Transforms/LoopRotate/pr35210.ll in rL318237, it uses debug….
Fix llvm/test/Transforms/LoopRotate/pr35210.ll in rL318237, it uses debug…
Nov 14 2017, 10:47 PM

Nov 10 2017

chapuni committed rL317966: llvm/Support/TargetParser.h: Fix -fmodules build in rL317900..
llvm/Support/TargetParser.h: Fix -fmodules build in rL317900.
Nov 10 2017, 6:06 PM

Nov 7 2017

chapuni added a comment to D36073: [CGP] Extends the scope of optimizeMemoryInst optimization.

Seems it broke selfhosting. http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2/builds/13335

Nov 7 2017, 9:34 PM

Nov 6 2017

chapuni committed rL317538: ClangdTests/JSONExprTests.cpp: Appease g++-4.8 to move raw string literal out….
ClangdTests/JSONExprTests.cpp: Appease g++-4.8 to move raw string literal out…
Nov 6 2017, 6:19 PM

Nov 3 2017

chapuni committed rL317404: llvm/test/lit.cfg.py: Don't set the feature "llvm-64-bits" if -m32 is specified..
llvm/test/lit.cfg.py: Don't set the feature "llvm-64-bits" if -m32 is specified.
Nov 3 2017, 11:56 PM
chapuni committed rL317402: CMake: Let LLVM_BUILD_32_BITS aware of large file..
CMake: Let LLVM_BUILD_32_BITS aware of large file.
Nov 3 2017, 11:04 PM
chapuni committed rL317401: llvm/test/Object/archive-SYM64-write.test: Delete large temp files. They are….
llvm/test/Object/archive-SYM64-write.test: Delete large temp files. They are…
Nov 3 2017, 11:00 PM

Nov 2 2017

chapuni committed rL317191: llvm-c/DebugInfo.h: Fix warning. [-Wdocumentation].
llvm-c/DebugInfo.h: Fix warning. [-Wdocumentation]
Nov 2 2017, 1:03 AM

Nov 1 2017

chapuni committed rL317091: Fix warnings discovered by rL317076. [-Wunused-private-field].
Fix warnings discovered by rL317076. [-Wunused-private-field]
Nov 1 2017, 6:48 AM
chapuni committed rL317090: Suppress a warning discovered by rL317076. [-Wunused-private-field].
Suppress a warning discovered by rL317076. [-Wunused-private-field]
Nov 1 2017, 6:48 AM
chapuni committed rL317089: Reformat..
Reformat.
Nov 1 2017, 6:48 AM

Oct 31 2017

chapuni committed rL317077: Revert rL317019, "[ADT] Split optional to only include copy mechanics and dtor….
Revert rL317019, "[ADT] Split optional to only include copy mechanics and dtor…
Oct 31 2017, 10:15 PM
chapuni added a reverting change for rL317019: [ADT] Split optional to only include copy mechanics and dtor for non-trivial…: rL317077: Revert rL317019, "[ADT] Split optional to only include copy mechanics and dtor….
Oct 31 2017, 10:15 PM
chapuni committed rL317078: Reformat..
Reformat.
Oct 31 2017, 10:15 PM
chapuni committed rL317075: clang/lib/Format/Format.cpp: Fix warnings introduced in rL316903. [-Wpedantic].
clang/lib/Format/Format.cpp: Fix warnings introduced in rL316903. [-Wpedantic]
Oct 31 2017, 9:44 PM

Oct 30 2017

chapuni added a comment to D38586: SLPVectorizer.cpp: Ensure SLPVectorizer can visit each block by dominated order.

The issue is that std::sort is insufficient with properlyDominates() as comparator.
So, I have to propose to get rid of std::sort there.

Oct 30 2017, 3:21 AM · Restricted Project

Oct 27 2017

chapuni abandoned D39038: Mark lld/test/ELF as flaky..

I will apply this patch locally while the issue is here.

Oct 27 2017, 5:57 AM

Oct 26 2017

chapuni committed rL316743: llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h: Fix -fmodules build….
llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h: Fix -fmodules build…
Oct 26 2017, 10:45 PM

Oct 21 2017

chapuni committed rL316260: clang-tidy: Fix deps..
clang-tidy: Fix deps.
Oct 21 2017, 4:02 AM

Oct 19 2017

chapuni added a comment to D39038: Mark lld/test/ELF as flaky..

I guess the constructor std::thread(F) fails, then its method, detach() crashes.
If we live with -fno-exceptions, I think we may rewrite Parallel.cpp w/o C++11 std::thread, but with pthreads, to catch failure in pthread_create.

Oct 19 2017, 6:31 PM
chapuni added a comment to D39038: Mark lld/test/ELF as flaky..

Reproduced with RelWithDebInfo.
Crashing in pthread_detach.

Oct 19 2017, 5:12 PM

Oct 18 2017

chapuni added a comment to D39038: Mark lld/test/ELF as flaky..

For example; http://bb9.pgr.jp/#/builders/20/builds/144

Oct 18 2017, 3:54 PM
chapuni committed rL316079: Untabify..
Untabify.
Oct 18 2017, 6:31 AM
chapuni added a comment to D35541: [CMake] Use #cmakedefine01 for CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER).

@krasimir, I concluded it is trivial and committed it with the URL to close this.
Feel free to revert if you had any matters.

Oct 18 2017, 2:44 AM

Oct 17 2017

chapuni added a comment to D39038: Mark lld/test/ELF as flaky..

@davide, This is why I didn't silently commit such a trivial change. I am happy if it could be reproduced easily.

Oct 17 2017, 10:39 PM
chapuni committed rL316061: [CMake] Use #cmakedefine01 for CLANG_ENABLE_….
[CMake] Use #cmakedefine01 for CLANG_ENABLE_…
Oct 17 2017, 10:21 PM
chapuni closed D35541: [CMake] Use #cmakedefine01 for CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER) by committing rL316061: [CMake] Use #cmakedefine01 for CLANG_ENABLE_….
Oct 17 2017, 10:21 PM
chapuni created D39039: Lit: Implement RWLock to serialize retrying flaky test..
Oct 17 2017, 10:15 PM
chapuni created D39038: Mark lld/test/ELF as flaky..
Oct 17 2017, 10:07 PM
chapuni committed rL316060: Prune trailing linefeed..
Prune trailing linefeed.
Oct 17 2017, 9:45 PM
chapuni created D39037: check-libcxx: Introduce config.test_retry_attempts for std/thread..
Oct 17 2017, 9:25 PM

Oct 16 2017

chapuni committed rL315896: Revert rL315894, "SLPVectorizer.cpp: Try to appease stage2-3 difference..
Revert rL315894, "SLPVectorizer.cpp: Try to appease stage2-3 difference.
Oct 16 2017, 2:50 AM
chapuni added a reverting change for rL315894: SLPVectorizer.cpp: Try to appease stage2-3 difference. (D38586): rL315896: Revert rL315894, "SLPVectorizer.cpp: Try to appease stage2-3 difference..
Oct 16 2017, 2:50 AM
chapuni committed rL315894: SLPVectorizer.cpp: Try to appease stage2-3 difference. (D38586).
SLPVectorizer.cpp: Try to appease stage2-3 difference. (D38586)
Oct 16 2017, 2:15 AM

Oct 14 2017

chapuni updated subscribers of D38678: [Sema] Warn about unused variables if we can constant evaluate the initializer..

Excuse me, I have reverted it in rL315806. check-libcxx dislikes it.

Oct 14 2017, 7:50 AM
chapuni committed rL315806: Revert rL315787, "[Sema] Warn about unused variables if we can constant….
Revert rL315787, "[Sema] Warn about unused variables if we can constant…
Oct 14 2017, 7:46 AM
chapuni added a reverting change for rL315787: [Sema] Warn about unused variables if we can constant evaluate the initializer.: rL315806: Revert rL315787, "[Sema] Warn about unused variables if we can constant….
Oct 14 2017, 7:46 AM
chapuni committed rL315803: Revert rL315721, "Handle shared and lazy symbol in the gnu hash construction.".
Revert rL315721, "Handle shared and lazy symbol in the gnu hash construction."
Oct 14 2017, 5:22 AM
chapuni added a reverting change for rL315721: Handle shared and lazy symbol in the gnu hash construction.: rL315803: Revert rL315721, "Handle shared and lazy symbol in the gnu hash construction.".
Oct 14 2017, 5:22 AM

Oct 12 2017

chapuni added inline comments to D33989: [OpenCL] Allow targets to select address space per type.
Oct 12 2017, 3:01 AM
chapuni committed rL315573: Fix warnings. [-Wdocumentation].
Fix warnings. [-Wdocumentation]
Oct 12 2017, 2:42 AM
chapuni committed rL315572: SVal::getAsSymbol(bool IncludeBaseRegions): Follow….
SVal::getAsSymbol(bool IncludeBaseRegions): Follow…
Oct 12 2017, 2:42 AM

Oct 11 2017

chapuni committed rL315566: clang/module.modulemap: Create Clang_Frontend_CodeGenOptions to remove some….
clang/module.modulemap: Create Clang_Frontend_CodeGenOptions to remove some…
Oct 11 2017, 11:39 PM
chapuni committed rL315537: lld: Prune unused libdeps..
lld: Prune unused libdeps.
Oct 11 2017, 5:04 PM
chapuni committed rL315529: lld: Reorder libdeps..
lld: Reorder libdeps.
Oct 11 2017, 4:19 PM
chapuni closed D38828: lld: Reorder dependent libraries alphabetically by committing rL315529: lld: Reorder libdeps..
Oct 11 2017, 4:18 PM
chapuni created D38828: lld: Reorder dependent libraries alphabetically.
Oct 11 2017, 4:08 PM
chapuni committed rL315527: MachineOptimizationRemarkEmitter.h: Appease g++-4.8.2. See also rL313715..
MachineOptimizationRemarkEmitter.h: Appease g++-4.8.2. See also rL313715.
Oct 11 2017, 4:03 PM
chapuni committed rL315450: llvm/module.modulemap: Create LLVM_MC_TableGen. It is used by llvm-tblgen..
llvm/module.modulemap: Create LLVM_MC_TableGen. It is used by llvm-tblgen.
Oct 11 2017, 4:09 AM
chapuni committed rL315449: llvm/module.modulemap: Move Support_TargetRegistry to let LLVMSupport free from….
llvm/module.modulemap: Move Support_TargetRegistry to let LLVMSupport free from…
Oct 11 2017, 4:09 AM

Oct 10 2017

chapuni committed rL315435: Reorder..
Reorder.
Oct 10 2017, 9:54 PM
chapuni committed rL315428: ClangCodeGenTests: Update libdeps in rL315392, +clangAST..
ClangCodeGenTests: Update libdeps in rL315392, +clangAST.
Oct 10 2017, 9:20 PM
chapuni committed rL315283: SILoadStoreOptimizer.cpp: Fix build; Clang doesn't like "using anonymous….
SILoadStoreOptimizer.cpp: Fix build; Clang doesn't like "using anonymous…
Oct 10 2017, 1:31 AM
chapuni committed rL315282: MCWinCOFFObjectWriter.h: Fix modules build in rL315257..
MCWinCOFFObjectWriter.h: Fix modules build in rL315257.
Oct 10 2017, 1:30 AM
chapuni added a comment to D38627: [clangd] Added move-only function helpers..

Excuse me, Ubuntu 14.04's g++-4.8.4 doesn't compile it. :(
Any idea?

Oct 10 2017, 12:42 AM

Oct 7 2017

chapuni added a comment to D38586: SLPVectorizer.cpp: Ensure SLPVectorizer can visit each block by dominated order.

Does this test pass to you?

Oct 7 2017, 11:32 PM · Restricted Project
chapuni updated the diff for D38586: SLPVectorizer.cpp: Ensure SLPVectorizer can visit each block by dominated order.

Forgot to reformat.

Oct 7 2017, 6:32 PM · Restricted Project
chapuni updated the diff for D38586: SLPVectorizer.cpp: Ensure SLPVectorizer can visit each block by dominated order.

@dberlin, I got rid of std::stable_sort() itself. Confirmed all tests (with mine) passed.

Oct 7 2017, 6:24 PM · Restricted Project
chapuni added inline comments to D38586: SLPVectorizer.cpp: Ensure SLPVectorizer can visit each block by dominated order.
Oct 7 2017, 12:54 AM · Restricted Project

Oct 6 2017

chapuni updated the diff for D38586: SLPVectorizer.cpp: Ensure SLPVectorizer can visit each block by dominated order.

The test added. This comes from EmitAtomicUpdateValue() in CGAtomic.cpp.
I confirmed it fails on both libstdc++ and libc++ to me.

Oct 6 2017, 6:54 PM · Restricted Project

Oct 5 2017

chapuni created D38586: SLPVectorizer.cpp: Ensure SLPVectorizer can visit each block by dominated order.
Oct 5 2017, 7:45 AM · Restricted Project

Oct 2 2017

chapuni committed rL314759: lldCommon depends on intrinsics_gen, due to llvm/CodeGen/CommandFlags.h.
lldCommon depends on intrinsics_gen, due to llvm/CodeGen/CommandFlags.h
Oct 2 2017, 9:20 PM

Sep 30 2017

chapuni added a comment to D38266: Parallelize string merging..

@ruiu, this happened to fail check-lld on -m32 (i686). Seems x86-64 is fine.
http://bb.pgr.jp/builders/test-lld-i686-linux-RA/builds/538

Sep 30 2017, 8:54 AM
chapuni committed rL314592: SyntheticSections.cpp: Appease g++-4.8, s/const/constexpr/.
SyntheticSections.cpp: Appease g++-4.8, s/const/constexpr/
Sep 30 2017, 6:42 AM
chapuni added a comment to D38303: [Sema] Correct IUnknown to support Unknwnbase.h Header..

Appeased in rL314586. I don't think my tweak would be right, though.

Sep 30 2017, 2:57 AM
chapuni committed rL314586: clang/test/SemaCXX/ms-iunknown-template-function.cpp: Appease for targeting *….
clang/test/SemaCXX/ms-iunknown-template-function.cpp: Appease for targeting *…
Sep 30 2017, 2:18 AM

Sep 21 2017

chapuni committed rL313947: HexagonVectorLoopCarriedReuse.cpp: Apply LLVM_ATTRIBUTE_UNUSED. [-Wunused….
HexagonVectorLoopCarriedReuse.cpp: Apply LLVM_ATTRIBUTE_UNUSED. [-Wunused…
Sep 21 2017, 6:03 PM
chapuni committed rL313946: Reformat..
Reformat.
Sep 21 2017, 6:03 PM

Sep 20 2017

chapuni added a comment to D38012: Compact EhSectionPiece from 32 bytes to 16 bytes..

Reverted in rL313731.

Sep 20 2017, 4:04 AM
chapuni added a reverting change for rL313697: Compact EhSectionPiece from 32 bytes to 16 bytes.: rL313731: Revert rL313697, "Compact EhSectionPiece from 32 bytes to 16 bytes.".
Sep 20 2017, 1:05 AM
chapuni committed rL313731: Revert rL313697, "Compact EhSectionPiece from 32 bytes to 16 bytes.".
Revert rL313697, "Compact EhSectionPiece from 32 bytes to 16 bytes."
Sep 20 2017, 1:05 AM

Sep 19 2017

chapuni committed rL313715: DiagnosticInfoOptimizationBase: Appease g++-4.8.2 not confused to add an….
DiagnosticInfoOptimizationBase: Appease g++-4.8.2 not confused to add an…
Sep 19 2017, 9:40 PM

Sep 17 2017

chapuni added a reverting change for rL313511: Fix a warning discovered by rL313487. [-Wunused-lambda-capture]: rL313513: Revert rL313511, "Fix a warning discovered by rL313487. [-Wunused-lambda….
Sep 17 2017, 10:54 PM
chapuni committed rL313513: Revert rL313511, "Fix a warning discovered by rL313487. [-Wunused-lambda….
Revert rL313511, "Fix a warning discovered by rL313487. [-Wunused-lambda…
Sep 17 2017, 10:54 PM
chapuni committed rL313511: Fix a warning discovered by rL313487. [-Wunused-lambda-capture].
Fix a warning discovered by rL313487. [-Wunused-lambda-capture]
Sep 17 2017, 9:57 PM
chapuni committed rL313510: Reformat..
Reformat.
Sep 17 2017, 9:57 PM

Sep 16 2017

chapuni added a comment to D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

Fixed in rL313456.

Sep 16 2017, 5:15 AM
chapuni committed rL313457: Reformat..
Reformat.
Sep 16 2017, 5:14 AM
chapuni committed rL313456: llvm/IR/DiagnosticHandler.h: Add include guard, or -fmodules would be confused..
llvm/IR/DiagnosticHandler.h: Add include guard, or -fmodules would be confused.
Sep 16 2017, 5:14 AM

Sep 13 2017

chapuni committed rL313218: Move llvm/test/CodeGen/X86/clear-liverange-spillreg.mir to SystemZ. It was in….
Move llvm/test/CodeGen/X86/clear-liverange-spillreg.mir to SystemZ. It was in…
Sep 13 2017, 5:04 PM
chapuni committed rL313129: lldMinGW itself doesn't require libpthread..
lldMinGW itself doesn't require libpthread.
Sep 13 2017, 1:00 AM
chapuni committed rL313128: clang/lib/Driver/ToolChains/Darwin.h: Add proper style to comments..
clang/lib/Driver/ToolChains/Darwin.h: Add proper style to comments.
Sep 13 2017, 1:00 AM

Sep 11 2017

chapuni committed rL312981: lldMinGW: Add LLVMSupport in libdeps..
lldMinGW: Add LLVMSupport in libdeps.
Sep 11 2017, 5:02 PM

Sep 8 2017

chapuni committed rL312861: CoverageMappingTest.cpp: Suppress warnings. [-Wdocumentation].
CoverageMappingTest.cpp: Suppress warnings. [-Wdocumentation]
Sep 8 2017, 11:21 PM

Sep 6 2017

chapuni added a comment to D35077: [RFC] Build LLVM-C.dll on MSVC that exports only the C API.

Please honor CMAKE_CFG_INTDIR. See also LLVM_*_OUTPUT_INTDIR.

Sep 6 2017, 5:57 PM

Aug 30 2017

chapuni committed rL312137: clang-tools-extra/test/clang-tidy/hicpp-signed-bitwise.cpp: Appease *-win32 to….
clang-tools-extra/test/clang-tidy/hicpp-signed-bitwise.cpp: Appease *-win32 to…
Aug 30 2017, 9:36 AM

Aug 28 2017

chapuni committed rL311876: Prune whitespaces in blank lines..
Prune whitespaces in blank lines.
Aug 28 2017, 12:49 AM

Aug 27 2017

chapuni committed rL311875: Untabify..
Untabify.
Aug 27 2017, 11:49 PM