This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][RISCV][clang] Split out SiFive VCIX C intrinsics from riscv_vector.td
ClosedPublic

Authored by 4vtomat on Apr 14 2023, 1:02 AM.

Details

Summary

Since we don't always need the vendor extension to be in riscv_vector.td,
so it's better to make it be in separated header.

Depends on D148223

Diff Detail

Event Timeline

4vtomat created this revision.Apr 14 2023, 1:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 14 2023, 1:02 AM
4vtomat requested review of this revision.Apr 14 2023, 1:02 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 14 2023, 1:02 AM
kito-cheng added inline comments.Apr 14 2023, 2:50 AM
clang/include/clang/Basic/riscv_vector.td
15

This should be separated NFC patch.

2152
clang/lib/Headers/sifive_vector.h
15

sifive_vcix -> sifive_vector since it might not only contain VCIX in future, and also the file named sifive_vector.h

4vtomat updated this revision to Diff 514817.Apr 18 2023, 8:25 PM

Resolved Kito's comments.

kito-cheng accepted this revision.Apr 28 2023, 5:14 AM

LGTM, thanks!

This revision is now accepted and ready to land.Apr 28 2023, 5:14 AM
4vtomat retitled this revision from [RISCV] Split out SiFive VCIX C intrinsics from riscv_vector.td to [RISCV][RISCV][clang] Split out SiFive VCIX C intrinsics from riscv_vector.td.May 2 2023, 5:29 AM
This revision was landed with ongoing or failed builds.May 2 2023, 5:52 AM
This revision was automatically updated to reflect the committed changes.