The patch is splitted from D103435. The patch emits .variant_cc [0] for those
function calls that have vector arguments or vector return values.
[0]: https://github.com/riscv/riscv-elf-psabi-doc/pull/190
Initial authored by: HsiangKai
Differential D139414
[RISCV] Emit .variant_cc directives for vector function calls. fakepaper56 on Dec 6 2022, 4:19 AM. Authored by
Details The patch is splitted from D103435. The patch emits .variant_cc [0] for those [0]: https://github.com/riscv/riscv-elf-psabi-doc/pull/190 Initial authored by: HsiangKai
Diff Detail
Event TimelineComment Actions LGTM from the psABI perspective, but I would like to wait another week to make sure other review is happy :)
Comment Actions There's missing context in the review description which is important. Please add something along the lines of the following. The currently ratified calling convention in psABI does not support passing vector arguments or return values in registers. LLVM implements a non-standard calling convention for vector arguments and returns. psABI requires that such non-standard calling conventions be tagged w/ .variant_cc. With that additional context, LGTM. Comment Actions Refine commit message. Almost add all reame's description into the the commit message. |