User Details
- User Since
- Jan 13 2022, 1:26 AM (23 w, 4 d)
Today
LGTM
Tue, Jun 14
The function is done by D127576.
Rebase to origin/main and move the new test case into vsetvli-insert.ll.
Refine commit summary.
Address reames's comments.
Mon, Jun 13
Refine the comments.
Address Craig's comments.
Sun, Jun 12
LGTM.
Sat, Jun 11
Refine the commit message.
I am sorry that giving wrong comments made @sunshaoce rewrite and commit the code repeatedly. I promise I will review code more carefully and be more familiar with llvm.
Fri, Jun 10
I am sorry for creating the trouble. Should I revert the patch first?
LGTM. It's fine to me that not declare isFaultFirstLoad as a static function of class RISCVInstrInfo, although I prefer this method.
Thank you for providing your cmake command.
I am sorry to create the trouble, but I didn't encounter this problem in my local. Could you provide me your cmake command?
My cmake command:
cmake -G "Ninja" -DLLVM_ENABLE_PROJECTS="clang" -DLLVM_BUILD_EXAMPLES=False -DLLVM_PARALLEL_LINK_JOBS=2 -DCMAKE_BUILD_TYPE=Debug ../llvm
Thu, Jun 9
Remove useless definition of TSFlags.
Add comments for RISCVInsertVSETVLI and uses MI.getNumExplicitDefs() == 2 && MI.modifiesRegister(RISCV::VL) && !MI.isInlineAsm() to identify VLEFF/VLSEGFF instead of adding new TSFlag.
Tue, Jun 7
Mon, Jun 6
Sun, Jun 5
Sat, Jun 4
Address reames's comment to use exactly one set pseudo of VLEFF/VLSEGFF. Thank that reames's comments make the patch cleaner.
Fri, Jun 3
Simplify code about expanding VLEFF/VLSEGFF.
Thu, Jun 2
Wed, Jun 1
Remove test cases of "[RISCV] Make PseudoReadVL have the vtypes of the corresponding VLEFF/VLSEGFF."
Mon, May 30
LGTM.
May 24 2022
Rename fold-fadd-and-fmul.ll to fold-vp-fadd-and-vp-fmul.ll.
May 23 2022
Using clang-format.
May 18 2022
May 17 2022
May 16 2022
After fixing getNode, pass SDNodeFlags to getNode of SDVTList version.
May 15 2022
Add REQUIRES: asserts in pass-fast-math-flags-sdnode.ll.
The update removes the part of vp.fcmp support and using argument of DAG.getNode to pass flags.
May 14 2022
Rename class form [SelectionDAGBuilder] to [VP].
May 12 2022
Directly use PseudoReadVL to get VSETVLIInfo also change the commit name and summary.
Additionally, the update removes useless PseudoReadVL in the pass.
May 10 2022
May 9 2022
Refine the comments of createMIROperandComment.
Add human readable comment for vtypes of PseudoReadVL MIs.
May 8 2022
May 1 2022
Should I create a new revision for changing PseudoReadVL? Or I just do the change in the revision and also update the commit name and summary?
I think it is a better solution, we could just check vtype of PseudoReadVL for PseudoReadVL's user and we even don't need the new status VLModified.
Apr 29 2022
Apr 24 2022
The update replaces specefic function only calling combineBinOpToReduce with combineBinOpToReduce and uses array input version setTargetDAGCombine.
Apr 23 2022
Since we need to transform VECREDUCE to VP_REDUCE before legalization for Fraser's method, we need to deal with illegal type of VECREDUCE. If we don't have idea to deal with illegal type nodes of VECREDUCE, how about we just use my original combine?
Apr 14 2022
VP_REDUCE nodes are marked as Custom. VP_REDUCE opcodes are elements of IntegerVPOps and FloatingPointVPOps whose elements would be marked as Custom.
Apr 12 2022
Mar 30 2022
Fix the issue raised by reviewers.