Page MenuHomePhabricator
People smd

smd (Alexey Baturo)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 13 2020, 1:57 AM (132 w, 19 h)

Recent Activity
View All

Jan 9 2023

smd committed rG35b8bb0ab3af: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine (authored by smd).
[RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine
Jan 9 2023, 5:47 AM · Restricted Project, Restricted Project
smd closed D132994: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.
Jan 9 2023, 5:46 AM · Restricted Project, Restricted Project

Dec 23 2022

smd added a comment to D132994: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.

ping

Dec 23 2022, 9:26 AM · Restricted Project, Restricted Project

Dec 15 2022

smd added a comment to D132994: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.

With D139414 being pushed to upstream, .variant_cc symbol is now properly emitted by hwasan code:

clang -fsanitize=hwaddress -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions src/llvm-project/compiler-rt/test/hwasan/TestCases/global.c -S -c -o /tmp/globals.s | grep variant_cc /tmp/globals.s
        .variant_cc     __hwasan_tag_mismatch_v2
Dec 15 2022, 11:17 PM · Restricted Project, Restricted Project
smd updated the diff for D132994: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.

Rebase and properly emit .variant_cc

Dec 15 2022, 11:13 PM · Restricted Project, Restricted Project

Dec 14 2022

smd committed rG2eac70c1084c: [RISC-V][HWASAN] Enable HWASAN for RISC-V architecture (authored by smd).
[RISC-V][HWASAN] Enable HWASAN for RISC-V architecture
Dec 14 2022, 6:29 AM · Restricted Project, Restricted Project, Restricted Project
smd closed D131345: [RISC-V][HWASAN] Enable HWASAN for RISC-V architecture.
Dec 14 2022, 6:29 AM · Restricted Project, Restricted Project, Restricted Project
smd committed rG847fa84b3d34: [RISC-V][HWASAN] Adjust lit test support for RISC-V HWASAN feature (authored by smd).
[RISC-V][HWASAN] Adjust lit test support for RISC-V HWASAN feature
Dec 14 2022, 5:15 AM · Restricted Project, Restricted Project
smd closed D131344: [RISC-V][HWASAN] Adjust lit test support for RISC-V HWASAN feature.
Dec 14 2022, 5:15 AM · Restricted Project, Restricted Project, Restricted Project
smd committed rGf87382124f06: re-land [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V (authored by smd).
re-land [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V
Dec 14 2022, 3:56 AM · Restricted Project, Restricted Project

Dec 13 2022

smd added inline comments to D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.
Dec 13 2022, 8:14 AM · Restricted Project, Restricted Project, Restricted Project
smd committed rG0eb694bec09d: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V (authored by smd).
[RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V
Dec 13 2022, 7:01 AM · Restricted Project, Restricted Project
smd closed D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.
Dec 13 2022, 7:01 AM · Restricted Project, Restricted Project, Restricted Project
smd committed rG54e72dd4eb99: re-land [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN (authored by smd).
re-land [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN
Dec 13 2022, 4:53 AM · Restricted Project, Restricted Project
smd added a reverting change for rG11937ca56422: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN: rG5e89876538ac: Revert "[RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN".
Dec 13 2022, 4:18 AM · Restricted Project, Restricted Project
smd added a reverting change for D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN: rG5e89876538ac: Revert "[RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN".
Dec 13 2022, 4:18 AM · Restricted Project, Restricted Project
smd committed rG5e89876538ac: Revert "[RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN" (authored by smd).
Revert "[RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN"
Dec 13 2022, 4:18 AM · Restricted Project, Restricted Project
smd committed rG11937ca56422: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN (authored by smd).
[RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN
Dec 13 2022, 3:58 AM · Restricted Project, Restricted Project
smd closed D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN.
Dec 13 2022, 3:58 AM · Restricted Project, Restricted Project

Dec 9 2022

smd added a comment to D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN.

Hi @jrtc27,
If you don't have any objections, I'd like to push this patch this weekend.
Thanks

Dec 9 2022, 12:55 AM · Restricted Project, Restricted Project
smd added inline comments to D139414: [RISCV] Emit .variant_cc directives for vector function calls..
Dec 9 2022, 12:48 AM · Restricted Project, Restricted Project

Dec 5 2022

smd added a comment to D138352: [RISCV] Support .variant_cc directive for the assembler..

Do you think it's possible to support printing .variant_cc label to asm file if the proper flag for symbol is set? I believe this happens(didn't verify though) for .variant_pcs in AArch64ELFStreamer.cpp
This would help me with D132994

Dec 5 2022, 12:48 AM · Restricted Project, Restricted Project

Nov 29 2022

smd added a comment to D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN.
In D132995#3923440, @smd wrote:

@jrtc27
Hi, could you please check that your request has been addressed?
Thanks

Nov 29 2022, 1:03 PM · Restricted Project, Restricted Project

Nov 22 2022

smd added a comment to D132994: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.
In D132994#3943554, @luismarques wrote:
In D132994#3927328, @smd wrote:

I think one of possible solutions for the problem mentioned above might be the following:

  • mark __hwasan_tag_mismatch_v2 as .variant_cc directly in asm file
  • add support for reading/dumping .variant_cc as emitDirectiveVariantPCS does
  • remove setting ELF::STO_RISCV_VARIANT_CC for __hwasan_tag_mismatch_v2 in RISCVAsmPrinter.cpp

Supposedly (2) should be implemented/committed as a separate patch before this one. It looks like it's being done as part of https://reviews.llvm.org/D103435
I might have my own patch for .variant_cc support. Does it make sense to publish it for the review, since the D103435 has been sitting there for over a year?

@jrtc27 @luismarques what do you think of that?

It looks like it D103435 has started picking up activity again. You can always publish your patch with a description that references D103435, and possibly point out the ways in which the patches are different. For instance, sometimes if it's just a subset of another patch that can help that subset be merged earlier, without being blocked on other issues. In any case, perhaps now D103435 will move faster.

I suggest rebasing this patch on an implementation of (2), either D103435 or your alternative, as that seems like the proper solution. If those patches were to continue being blocked for a while I don't have a problem with (1), but I imagine other people might disagree.

Nov 22 2022, 5:33 AM · Restricted Project, Restricted Project

Nov 15 2022

smd added a comment to D132994: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.

I think one of possible solutions for the problem mentioned above might be the following:

  • mark __hwasan_tag_mismatch_v2 as .variant_cc directly in asm file
  • add support for reading/dumping .variant_cc as emitDirectiveVariantPCS does
  • remove setting ELF::STO_RISCV_VARIANT_CC for __hwasan_tag_mismatch_v2 in RISCVAsmPrinter.cpp
Nov 15 2022, 4:55 AM · Restricted Project, Restricted Project

Nov 13 2022

smd added a comment to D132994: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.
In D132994#3923439, @jrtc27 wrote:

It seems we're missing a emitDirectiveVariantCC equivalent to AArch64's emitDirectiveVariantPCS, which is what should be used here I believe otherwise Luis is right, the assembly doesn't mark the symbol as a variant CC one, so round-tripping through assembly loses the flag.

What you showed is still compiling directly from C to an object file with the integrated assembler; you'd need to either use -no-integrated-as or use -S and then assemble the .s file.

Nov 13 2022, 12:09 AM · Restricted Project, Restricted Project

Nov 12 2022

smd added a comment to D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN.

@jrtc27
Hi, could you please check that your request has been addressed?
Thanks

Nov 12 2022, 11:55 PM · Restricted Project, Restricted Project
smd added a comment to D132994: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.
In D132994#3911904, @luismarques wrote:

As far as I can tell from looking at the relevant psABI discussions and GNU patches, this overall approach is OK.

Thinking about the specifics of the patch, what happens if you separately compile and assemble this? Does it lose the STO_RISCV_VARIANT_CC?

Nov 12 2022, 11:38 PM · Restricted Project, Restricted Project

Nov 2 2022

smd added a comment to D132994: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.

@luismarques @jrtc27 Do you think it's ok if I commit this patch?
Thanks

Nov 2 2022, 2:58 AM · Restricted Project, Restricted Project
smd updated the summary of D131344: [RISC-V][HWASAN] Adjust lit test support for RISC-V HWASAN feature.
Nov 2 2022, 2:43 AM · Restricted Project, Restricted Project, Restricted Project
smd updated the summary of D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.
Nov 2 2022, 2:42 AM · Restricted Project, Restricted Project, Restricted Project
smd updated the summary of D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN.
Nov 2 2022, 2:41 AM · Restricted Project, Restricted Project
smd added inline comments to D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN.
Nov 2 2022, 2:41 AM · Restricted Project, Restricted Project
smd updated the diff for D131344: [RISC-V][HWASAN] Adjust lit test support for RISC-V HWASAN feature.

Updating tests

Nov 2 2022, 2:40 AM · Restricted Project, Restricted Project, Restricted Project
smd updated the diff for D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN.

Addressing comments

Nov 2 2022, 2:34 AM · Restricted Project, Restricted Project
smd updated the summary of D132994: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.
Nov 2 2022, 2:32 AM · Restricted Project, Restricted Project
smd abandoned D132993: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.
Nov 2 2022, 2:31 AM · Restricted Project, Restricted Project
smd retitled D132994: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine from [RISC-V][HWASAN] Update memaccess test with proper checks to [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.
Nov 2 2022, 2:30 AM · Restricted Project, Restricted Project
smd updated the diff for D132994: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.

Addressing comments

Nov 2 2022, 2:30 AM · Restricted Project, Restricted Project

Oct 26 2022

smd added inline comments to D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN.
Oct 26 2022, 1:12 PM · Restricted Project, Restricted Project
smd updated the diff for D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN.

Addressing comments

Oct 26 2022, 1:11 PM · Restricted Project, Restricted Project
smd added a comment to D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN.

Does the tagging actually change the location of globals?

No, it doesn't.

Oct 26 2022, 1:00 PM · Restricted Project, Restricted Project
smd added a comment to D132994: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.
In D132994#3885764, @luismarques wrote:

Sorry, could you please explain why this required a manually written check? It's not obvious to me.

Oct 26 2022, 12:51 PM · Restricted Project, Restricted Project

Oct 19 2022

smd added a comment to D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN.

@jrtc27, @asb, @luismarques, @MaskRay, @craig.topper
Gengle ping, could you please help with reviewing this patch?
Thanks

Oct 19 2022, 6:16 AM · Restricted Project, Restricted Project

Oct 3 2022

smd added a comment to D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN.

Could you please help with reviewing this patch.
Thanks

Oct 3 2022, 5:36 AM · Restricted Project, Restricted Project
smd added reviewers for D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN: asb, MaskRay, craig.topper.
Oct 3 2022, 5:35 AM · Restricted Project, Restricted Project

Sep 19 2022

smd added a comment to D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN.

@jrtc27 gentle ping

Sep 19 2022, 9:30 AM · Restricted Project, Restricted Project

Sep 3 2022

smd added inline comments to D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN.
Sep 3 2022, 10:56 AM · Restricted Project, Restricted Project
smd updated the diff for D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN.

Addressing comments

Sep 3 2022, 10:55 AM · Restricted Project, Restricted Project

Sep 1 2022

smd updated the diff for D132994: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.

Update test

Sep 1 2022, 9:10 AM · Restricted Project, Restricted Project

Aug 30 2022

smd added a comment to D131343: [RISC-V][HWASAN] Add support for lowering HWASAN intrinsic for RISC-V.

@jrtc27 I've created several reviews(D13299{3,4,5}) to address the issues that you mentioned. Could you please take a look? Thanks

Aug 30 2022, 11:34 PM · Restricted Project, Restricted Project, Restricted Project
smd updated the summary of D131343: [RISC-V][HWASAN] Add support for lowering HWASAN intrinsic for RISC-V.
Aug 30 2022, 11:31 PM · Restricted Project, Restricted Project, Restricted Project
smd added a comment to D131344: [RISC-V][HWASAN] Adjust lit test support for RISC-V HWASAN feature.

@vitalybuka
After all the adjustments and supporting globals I have this picture:

Failed Tests (3):
  HWAddressSanitizer-riscv64 :: TestCases/stack-oob.c
  HWAddressSanitizer-riscv64 :: TestCases/try-catch.cpp
  HWAddressSanitizer-riscv64 :: TestCases/exported-tagged-global.c
Aug 30 2022, 11:31 PM · Restricted Project, Restricted Project, Restricted Project
smd updated the summary of D132993: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.
Aug 30 2022, 11:26 PM · Restricted Project, Restricted Project
smd updated the summary of D132994: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.
Aug 30 2022, 11:24 PM · Restricted Project, Restricted Project
smd updated the summary of D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN.
Aug 30 2022, 11:24 PM · Restricted Project, Restricted Project
smd updated the summary of D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.
Aug 30 2022, 11:23 PM · Restricted Project, Restricted Project, Restricted Project
smd updated the summary of D131344: [RISC-V][HWASAN] Adjust lit test support for RISC-V HWASAN feature.
Aug 30 2022, 11:20 PM · Restricted Project, Restricted Project, Restricted Project
smd updated the summary of D131345: [RISC-V][HWASAN] Enable HWASAN for RISC-V architecture.
Aug 30 2022, 11:19 PM · Restricted Project, Restricted Project, Restricted Project
smd updated the diff for D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.

Addressing comments

Aug 30 2022, 11:19 PM · Restricted Project, Restricted Project, Restricted Project
smd requested review of D132995: [RISC-V][HWASAN] Support tagging global variables for RISC-V HWASAN.
Aug 30 2022, 11:18 PM · Restricted Project, Restricted Project
smd requested review of D132994: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.
Aug 30 2022, 11:18 PM · Restricted Project, Restricted Project
smd requested review of D132993: [RISC-V][HWASAN] Don't explicitly load GOT entry to call hwasan mismatch routine.
Aug 30 2022, 11:17 PM · Restricted Project, Restricted Project

Aug 28 2022

smd added a comment to D131343: [RISC-V][HWASAN] Add support for lowering HWASAN intrinsic for RISC-V.

@jrtc27 sorry for the mess

Aug 28 2022, 1:18 PM · Restricted Project, Restricted Project, Restricted Project
smd committed rGe3485345d30c: [RISC-V][HWASAN] Add support for lowering HWASAN intrinsic for RISC-V (authored by smd).
[RISC-V][HWASAN] Add support for lowering HWASAN intrinsic for RISC-V
Aug 28 2022, 11:23 AM · Restricted Project, Restricted Project
smd closed D131343: [RISC-V][HWASAN] Add support for lowering HWASAN intrinsic for RISC-V.
Aug 28 2022, 11:23 AM · Restricted Project, Restricted Project, Restricted Project
smd committed rGfba042dabb26: [RISC-V][HWASAN] Save sp address at the start of tag mismatch routine (authored by smd).
[RISC-V][HWASAN] Save sp address at the start of tag mismatch routine
Aug 28 2022, 11:13 AM · Restricted Project, Restricted Project
smd closed D131574: [RISC-V][HWASAN] Save sp address at the start of tag mismatch routine.
Aug 28 2022, 11:13 AM · Restricted Project, Restricted Project
smd committed rG38b04fd9c069: [RISC-V][HWASAN] Add runtime support for HWASAN for RISC-V (authored by smd).
[RISC-V][HWASAN] Add runtime support for HWASAN for RISC-V
Aug 28 2022, 10:45 AM · Restricted Project, Restricted Project
smd closed D131342: [RISC-V][HWASAN] Add runtime support for HWASAN for RISC-V.
Aug 28 2022, 10:45 AM · Restricted Project, Restricted Project
smd committed rGf8b71a307e30: [RISC-V][HWASAN] Add tag mismatch routines for HWASAN required for RISC-V (authored by smd).
[RISC-V][HWASAN] Add tag mismatch routines for HWASAN required for RISC-V
Aug 28 2022, 9:43 AM · Restricted Project, Restricted Project, Restricted Project
smd closed D131341: [RISC-V][HWASAN] Add tag mismatch routines for HWASAN required for RISC-V.
Aug 28 2022, 9:43 AM · Restricted Project, Restricted Project, Restricted Project
smd committed rG0636aec3305e: [RISC-V][HWASAN] Add intrinsics required for HWASAN support for RISC-V (authored by smd).
[RISC-V][HWASAN] Add intrinsics required for HWASAN support for RISC-V
Aug 28 2022, 8:06 AM · Restricted Project, Restricted Project
smd closed D131340: [RISC-V][HWASAN] Add intrinsics required for HWASAN support for RISC-V.
Aug 28 2022, 8:05 AM · Restricted Project, Restricted Project, Restricted Project

Aug 23 2022

smd added inline comments to D131340: [RISC-V][HWASAN] Add intrinsics required for HWASAN support for RISC-V.
Aug 23 2022, 2:19 PM · Restricted Project, Restricted Project, Restricted Project
smd added inline comments to D131343: [RISC-V][HWASAN] Add support for lowering HWASAN intrinsic for RISC-V.
Aug 23 2022, 2:13 PM · Restricted Project, Restricted Project, Restricted Project
smd updated the diff for D131343: [RISC-V][HWASAN] Add support for lowering HWASAN intrinsic for RISC-V.

Addressing comments

Aug 23 2022, 2:05 PM · Restricted Project, Restricted Project, Restricted Project
smd updated the diff for D131340: [RISC-V][HWASAN] Add intrinsics required for HWASAN support for RISC-V.

Addressing comments

Aug 23 2022, 2:05 PM · Restricted Project, Restricted Project, Restricted Project

Aug 22 2022

smd added a comment to D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.

Hi @vitalybuka
Could you please take another look at this patch series and if you wouldn't have any objections, I'd like to push it.
Thanks

Aug 22 2022, 9:54 AM · Restricted Project, Restricted Project, Restricted Project

Aug 19 2022

smd updated the diff for D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.

Fixing bug

Aug 19 2022, 2:20 AM · Restricted Project, Restricted Project, Restricted Project
smd updated the diff for D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.

Don't push tagged globals option for riscv64 hwasan tests

Aug 19 2022, 1:30 AM · Restricted Project, Restricted Project, Restricted Project

Aug 18 2022

smd removed 1 blocking reviewer(s) for D131341: [RISC-V][HWASAN] Add tag mismatch routines for HWASAN required for RISC-V: kito-cheng.
Aug 18 2022, 7:27 AM · Restricted Project, Restricted Project, Restricted Project
smd added a comment to D131341: [RISC-V][HWASAN] Add tag mismatch routines for HWASAN required for RISC-V.

@jrtc27 I would like to thank you for your such elaborate comments, your help is much appreciated. Thanks!

Aug 18 2022, 6:07 AM · Restricted Project, Restricted Project, Restricted Project
smd added inline comments to D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.
Aug 18 2022, 5:49 AM · Restricted Project, Restricted Project, Restricted Project
smd updated the diff for D131341: [RISC-V][HWASAN] Add tag mismatch routines for HWASAN required for RISC-V.

Fixed missing label

Aug 18 2022, 5:46 AM · Restricted Project, Restricted Project, Restricted Project
smd updated the diff for D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.

Addressing comments

Aug 18 2022, 5:41 AM · Restricted Project, Restricted Project, Restricted Project
smd updated the diff for D131341: [RISC-V][HWASAN] Add tag mismatch routines for HWASAN required for RISC-V.

Addressing comments

Aug 18 2022, 5:40 AM · Restricted Project, Restricted Project, Restricted Project

Aug 17 2022

smd updated the diff for D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.

Addressing comments

Aug 17 2022, 11:14 AM · Restricted Project, Restricted Project, Restricted Project
smd added inline comments to D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.
Aug 17 2022, 9:26 AM · Restricted Project, Restricted Project, Restricted Project
smd added inline comments to D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.
Aug 17 2022, 9:03 AM · Restricted Project, Restricted Project, Restricted Project

Aug 16 2022

smd updated the diff for D131344: [RISC-V][HWASAN] Adjust lit test support for RISC-V HWASAN feature.

Moving tests to previous patches

Aug 16 2022, 12:04 PM · Restricted Project, Restricted Project, Restricted Project
smd updated the diff for D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.

Addressing comments

Aug 16 2022, 12:03 PM · Restricted Project, Restricted Project, Restricted Project
smd updated the diff for D131343: [RISC-V][HWASAN] Add support for lowering HWASAN intrinsic for RISC-V.

Addressing comments

Aug 16 2022, 12:01 PM · Restricted Project, Restricted Project, Restricted Project
smd added a comment to D131341: [RISC-V][HWASAN] Add tag mismatch routines for HWASAN required for RISC-V.

LGTM, but someone who work RISC-V should take a look

@kito-cheng @craig.topper could you please help to identify someone who could help with reviewing riscv part of these patch series?
Thanks

Aug 16 2022, 11:49 AM · Restricted Project, Restricted Project, Restricted Project
smd added inline comments to D131340: [RISC-V][HWASAN] Add intrinsics required for HWASAN support for RISC-V.
Aug 16 2022, 11:47 AM · Restricted Project, Restricted Project, Restricted Project
smd updated the diff for D131340: [RISC-V][HWASAN] Add intrinsics required for HWASAN support for RISC-V.

Addressing comments

Aug 16 2022, 11:46 AM · Restricted Project, Restricted Project, Restricted Project
smd added a comment to D131343: [RISC-V][HWASAN] Add support for lowering HWASAN intrinsic for RISC-V.

@vitalybuka

llvm/test/CodeGen/RISCV/hwasan-check-memaccess.ll ?
the test essentially validates LowerHWASAN_CHECK_MEMACCESS, and does not relies on the rest of D131344
So the test needs to be moved from D131344 into this patch.

Aug 16 2022, 11:41 AM · Restricted Project, Restricted Project, Restricted Project

Aug 15 2022

smd added a comment to D131343: [RISC-V][HWASAN] Add support for lowering HWASAN intrinsic for RISC-V.
In D131343#3719618, @vitalybuka wrote:

RISCVAsmPrinter needs a test for changes in this patch.

Aug 15 2022, 5:24 AM · Restricted Project, Restricted Project, Restricted Project
smd added a comment to D131575: [RISC-V][HWASAN] Add support for HWASAN code instrumentation for RISC-V.
In D131575#3719631, @vitalybuka wrote:

some test needs to be updated/added

Aug 15 2022, 5:23 AM · Restricted Project, Restricted Project, Restricted Project
smd updated the diff for D131344: [RISC-V][HWASAN] Adjust lit test support for RISC-V HWASAN feature.

Introduce some new tests

Aug 15 2022, 5:22 AM · Restricted Project, Restricted Project, Restricted Project