This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Add SME 2 target feature for Armv8-A and Armv9-A 2022 Architecture Extension
ClosedPublic

Authored by CarolineConcatto on Oct 7 2022, 7:54 AM.

Details

Summary

First patch in a series adding MC layer support for Scalable Matrix
Extension 2 (SME2).

This patch adds the following feature:

sme2

The 2022 Architecture Extension release adds other feature flags(eg.:sme2.1),
that will be in follow-up patches.

The reference can be found here:
https://developer.arm.com/documentation/ddi0602/2022-09

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2022, 7:54 AM
CarolineConcatto requested review of this revision.Oct 7 2022, 7:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2022, 7:54 AM
Matt added a subscriber: Matt.Oct 10 2022, 10:51 PM
sdesmalen added inline comments.Oct 12 2022, 1:39 AM
llvm/test/MC/AArch64/SME2/feature.s
1

nit: Can you rename this test-file to something more descriptive, e.g. feature-sme2-implies-sme.s ?

llvm/test/MC/AArch64/SME2/feature.s
1

Yes, not a problem.
That is just the same name we have for sme.
llvm/test/MC/AArch64/SME/feature.s

  • Change the test file name from feature.s to feature-sme2-implies-sme.s
aemerson accepted this revision.Oct 12 2022, 3:53 PM

LGTM.

This revision is now accepted and ready to land.Oct 12 2022, 3:53 PM
sdesmalen accepted this revision.Oct 13 2022, 12:32 AM

Add sme2 feature in the unitest:

llvm/unittests/Support/TargetParserTest.cpp

Because
x64 debian > LLVM-Unit.Support/_/SupportTests/TargetParserTest::AArch64ExtensionFeatures
Script: -- /var/lib/buildkite-agent/builds/llvm-project/build/unittests/Support/./SupportTests --gtest_filter=TargetParserTest.AArch64ExtensionFeatures

This revision was landed with ongoing or failed builds.Oct 13 2022, 3:40 AM
This revision was automatically updated to reflect the committed changes.