Adds a fix to the diagnostic of replacing the = default to = delete
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Thank you for this, I think it's a good idea! Can you also add a release note for the changes?
This mostly LG to me but I did spot one thing I was curious about.
clang/lib/Serialization/ASTWriterDecl.cpp | ||
---|---|---|
2293 | Should this be using 6 instead of 3 as with the other location fields? (InnerLocStart, LocEnd) And if so, we should probably add some test coverage for this bit. |
clang/lib/Serialization/ASTWriterDecl.cpp | ||
---|---|---|
2293 | Whoops, Yes you're right, 6 is above 3 on on number keyboard. Technically it shouldn't make any functional change, just that the field may be expressed in more bits. |
clang/lib/AST/ASTImporter.cpp | ||
---|---|---|
3707 | This should be imported very similarly to EndLoc. |
This should be imported very similarly to EndLoc.