This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Improve vector fround lowering by changing FRM.
ClosedPublic

Authored by craig.topper on Sep 5 2022, 10:13 PM.

Details

Summary

This is a follow to D133238 which did this for ceil/floor.

Diff Detail

Event Timeline

craig.topper created this revision.Sep 5 2022, 10:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2022, 10:13 PM
craig.topper requested review of this revision.Sep 5 2022, 10:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2022, 10:13 PM
arcbbb accepted this revision.Sep 5 2022, 11:34 PM

Look good to me.

This revision is now accepted and ready to land.Sep 5 2022, 11:34 PM
frasercrmck accepted this revision.Sep 6 2022, 1:26 AM

LGTM too

llvm/lib/Target/RISCV/RISCVISelLowering.cpp
1838–1839

Mention FROUND in comment?

reames added a comment.Sep 6 2022, 7:42 AM

LGTM to me too.

llvm/lib/Target/RISCV/RISCVISelLowering.cpp
1907

Very minor style comment: the first three of these could be combined by tweaking the existing matchRoundingOp to directly map opcode to rounding mode and then reusing it here.

This revision was landed with ongoing or failed builds.Sep 6 2022, 9:33 AM
This revision was automatically updated to reflect the committed changes.