Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D133090

[LLVM] Replace `cast_or_null` with `cast_if_present`, NFC.
AbandonedPublic
Actions

Authored by bzcheeseman on Aug 31 2022, 9:29 PM.

Details

Reviewers
jdoerfert
sstefan1
lattner
Summary

cast_if_present is simply the new version of cast_or_null - indeed cast_or_null calls cast_if_present. The if_present suffix more closely represents the capabilities of the function now, as it can correctly handle optionals and things that are not "null".

Diff Detail

Event Timeline

bzcheeseman created this revision.Aug 31 2022, 9:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2022, 9:29 PM
Herald added subscribers: pmatos, asb, jeroen.dobbelaere and 10 others. · View Herald Transcript
bzcheeseman requested review of this revision.Aug 31 2022, 9:29 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptAug 31 2022, 9:29 PM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, • pcwang-thead, vkmr, aheejin. · View Herald Transcript
bzcheeseman edited the summary of this revision. (Show Details)Aug 31 2022, 9:30 PM
bzcheeseman added a reviewer: lattner.
Harbormaster completed remote builds in B184509: Diff 457170.Aug 31 2022, 10:20 PM
nikic mentioned this in D133089: [LLVM] Replace `dyn_cast_or_null` with `dyn_cast_if_present`, NFC..Sep 1 2022, 12:29 AM
bzcheeseman updated this revision to Diff 457275.Sep 1 2022, 7:50 AM
Harbormaster completed remote builds in B184582: Diff 457275.Sep 1 2022, 9:02 AM
bzcheeseman abandoned this revision.Oct 14 2022, 8:37 AM

No consensus, closing this.

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
Analysis/
2 lines
7 lines
IR/
116 lines
5 lines
16 lines
143 lines
2 lines
Transforms/
IPO/
4 lines
lib/
Analysis/
2 lines
22 lines
4 lines
AsmParser/
6 lines
Bitcode/
Reader/
4 lines
2 lines
CodeGen/
AsmPrinter/
2 lines
6 lines
SelectionDAG/
4 lines
IR/
16 lines
12 lines
12 lines
2 lines
4 lines
28 lines
2 lines
MC/
2 lines
MCParser/
2 lines
3 lines
Target/
Hexagon/
8 lines
WebAssembly/
AsmParser/
2 lines
Utils/
4 lines
Transforms/
IPO/
2 lines
InstCombine/
2 lines
Scalar/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
17 lines
Utils/
2 lines
4 lines
2 lines
2 lines
14 lines
Vectorize/
2 lines
2 lines
tools/
opt/
2 lines
utils/
TableGen/
5 lines

Diff 457275

View Options

llvm/include/llvm/Analysis/AliasSetTracker.h

Loading...
View Options

llvm/include/llvm/Analysis/MemorySSA.h

Loading...
View Options

llvm/include/llvm/IR/DebugInfoMetadata.h

Loading...
View Options

llvm/include/llvm/IR/Instructions.h

Loading...
View Options

llvm/include/llvm/IR/Metadata.h

Loading...
View Options

llvm/include/llvm/IR/OperandTraits.h

Loading...
View Options

llvm/include/llvm/IR/ValueMap.h

Loading...
View Options

llvm/include/llvm/Transforms/IPO/Attributor.h

Loading...
View Options

llvm/lib/Analysis/AssumeBundleQueries.cpp

Loading...
View Options

llvm/lib/Analysis/MemorySSAUpdater.cpp

Loading...
View Options

llvm/lib/Analysis/TargetLibraryInfo.cpp

Loading...
View Options

llvm/lib/AsmParser/LLParser.cpp

Loading...
View Options

llvm/lib/Bitcode/Reader/BitcodeReader.cpp

Loading...
View Options

llvm/lib/Bitcode/Reader/MetadataLoader.cpp

Loading...
View Options

llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

Loading...
View Options

llvm/lib/CodeGen/CodeGenPrepare.cpp

Loading...
View Options

llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

Loading...
View Options

llvm/lib/IR/DIBuilder.cpp

Loading...
View Options

llvm/lib/IR/DebugInfo.cpp

Loading...
View Options

llvm/lib/IR/DebugInfoMetadata.cpp

Loading...
View Options

llvm/lib/IR/DebugLoc.cpp

Loading...
View Options

llvm/lib/IR/Metadata.cpp

Loading...
View Options

llvm/lib/IR/Module.cpp

Loading...
View Options

llvm/lib/IR/SafepointIRVerifier.cpp

Loading...
View Options

llvm/lib/MC/ELFObjectWriter.cpp

Loading...
View Options

llvm/lib/MC/MCParser/ELFAsmParser.cpp

Loading...
View Options

llvm/lib/MC/WasmObjectWriter.cpp

Loading...
View Options

llvm/lib/Target/Hexagon/HexagonCommonGEP.cpp

Loading...
View Options

llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp

Loading...
View Options

llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.cpp

Loading...
View Options

llvm/lib/Transforms/IPO/GlobalDCE.cpp

Loading...
View Options

llvm/lib/Transforms/InstCombine/InstCombineShifts.cpp

Loading...
View Options

llvm/lib/Transforms/Scalar/FlattenCFGPass.cpp

Loading...
View Options

llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp

Loading...
View Options

llvm/lib/Transforms/Scalar/LICM.cpp

Loading...
View Options

llvm/lib/Transforms/Scalar/LoopSimplifyCFG.cpp

Loading...
View Options

llvm/lib/Transforms/Scalar/LoopSink.cpp

Loading...
View Options

llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp

Loading...
View Options

llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp

Loading...
View Options

llvm/lib/Transforms/Utils/BasicBlockUtils.cpp

Loading...
View Options

llvm/lib/Transforms/Utils/CloneFunction.cpp

Loading...
View Options

llvm/lib/Transforms/Utils/Local.cpp

Loading...
View Options

llvm/lib/Transforms/Utils/ModuleUtils.cpp

Loading...
View Options

llvm/lib/Transforms/Utils/ValueMapper.cpp

Loading...
View Options

llvm/lib/Transforms/Vectorize/LoopVectorize.cpp

Loading...
View Options

llvm/lib/Transforms/Vectorize/VPlanSLP.cpp

Loading...
View Options

llvm/tools/opt/BreakpointPrinter.cpp

Loading...
View Options

llvm/utils/TableGen/DAGISelMatcherOpt.cpp

Loading...