Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

bzcheeseman (Aman LaChapelle)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2022, 9:12 AM (87 w, 5 d)

Recent Activity

Aug 14 2023

bzcheeseman added inline comments to D157903: Add index::CmpOp canonicalization..
Aug 14 2023, 10:32 AM · Restricted Project, Restricted Project

Aug 11 2023

bzcheeseman accepted D147991: [LLVM][Casting.h] Fix dyn_cast for std::unique_ptr..

Thank you for iterating! LGTM

Aug 11 2023, 9:29 AM · Restricted Project, Restricted Project

May 22 2023

bzcheeseman accepted D150303: [LLDB] Add some declarations related to REPL support for mojo.

LGTM

May 22 2023, 1:13 PM · Restricted Project, Restricted Project
bzcheeseman added inline comments to D150303: [LLDB] Add some declarations related to REPL support for mojo.
May 22 2023, 11:25 AM · Restricted Project, Restricted Project

May 12 2023

bzcheeseman added inline comments to D147991: [LLVM][Casting.h] Fix dyn_cast for std::unique_ptr..
May 12 2023, 8:52 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D147991: [LLVM][Casting.h] Fix dyn_cast for std::unique_ptr..

<snip>
Absolutely not, I would surely ping you it was about that :) I'm sorry, this got retracted by other things. I was planning to run it with the sanitizer to see if something shows up.

May 12 2023, 8:51 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D150123: [mlir] Move casting calls from methods to function calls.

Assuming the rebases go smoothly, I will do this as a follow up in MLIR instead, but I will update the code at https://github.com/llvm/llvm-project/compare/main...tpopp:llvm-project:tidy-cast-check to also do this transformation, so others benefit when updating their own codebase.

May 12 2023, 3:26 PM · Restricted Project, Restricted Project

May 11 2023

bzcheeseman accepted D147991: [LLVM][Casting.h] Fix dyn_cast for std::unique_ptr..

@zuban32 Not sure if you were waiting on me (if so, sorry!) - I put some comments inline that would help with the concerns we talked about previously. I'd love to get this landed once the comments are resolved :)

May 11 2023, 9:48 AM · Restricted Project, Restricted Project
bzcheeseman added a comment to D150123: [mlir] Move casting calls from methods to function calls.

I'm +1 on this change for sure :) Any chance you could also do dyn_cast_or_null -> dyn_cast_if_present in that AST matcher?

May 11 2023, 8:15 AM · Restricted Project, Restricted Project

Apr 26 2023

bzcheeseman accepted D149312: [lldb] Create a way to force remove commands.
Apr 26 2023, 5:12 PM · Restricted Project, Restricted Project

Apr 18 2023

bzcheeseman added a comment to D147991: [LLVM][Casting.h] Fix dyn_cast for std::unique_ptr..

@bzcheeseman I've updated the test and it passes, i.e. I wasn't able to reproduce the behavior we discussed. It seems modern c++ compilers are able to elide the calls to move constructor in such a code, I tried with gcc 9.4 and Apple aarch64 clang-14 with no success.

Apr 18 2023, 7:43 AM · Restricted Project, Restricted Project

Apr 12 2023

bzcheeseman added a comment to D147991: [LLVM][Casting.h] Fix dyn_cast for std::unique_ptr..

Oh, you're right, haven't tried that yet but I'm pretty sure that's what's going to happen. I think we could just make dyn_cast take lvalue reference to unique_ptr instead of an rvalue one, then check it with isa<>, and then either move the pointer further or just return nullptr leaving the original pointer intact. I'll update the patch

Apr 12 2023, 7:43 AM · Restricted Project, Restricted Project

Apr 11 2023

bzcheeseman added a comment to D147991: [LLVM][Casting.h] Fix dyn_cast for std::unique_ptr..

The test looks fine to me, but I'm now realizing some tricky behavior. If you std::move a unique pointer into a dyn_cast, and casting fails, you now have no pointer anymore (it's been moved already). In the unit test, if BP couldn't be cast to foo I believe you'd see this behavior. I vaguely recall hitting some of this in the past, does it make sense to have UniquePtrCast take unique_ptr<> & rather than unique_ptr<> && and use .release()/.reset()?

Apr 11 2023, 11:01 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D147991: [LLVM][Casting.h] Fix dyn_cast for std::unique_ptr..

Are there unit tests you could add to this to ensure we don't regress? Clearly we don't have good enough coverage on this.

Apr 11 2023, 11:37 AM · Restricted Project, Restricted Project
bzcheeseman accepted D147991: [LLVM][Casting.h] Fix dyn_cast for std::unique_ptr..
Apr 11 2023, 11:37 AM · Restricted Project, Restricted Project

Apr 4 2023

bzcheeseman added a comment to D144276: [ORC] Introduce SetUpExecutorNativePlatform utility..

Quick update: I'm almost done with this -- I just need to fix a couple of outstanding bugs in ELFNixPlatform and then I think this should be good to land.

Apr 4 2023, 10:40 PM · Restricted Project, Restricted Project

Mar 9 2023

bzcheeseman committed rG82e177bbde88: [ORC] Fix name shadowing issue, NFC. (authored by bzcheeseman).
[ORC] Fix name shadowing issue, NFC.
Mar 9 2023, 2:08 PM · Restricted Project, Restricted Project
bzcheeseman closed D145710: [ORC] Fix name shadowing issue, NFC..
Mar 9 2023, 2:07 PM · Restricted Project, Restricted Project
bzcheeseman added reviewers for D145710: [ORC] Fix name shadowing issue, NFC.: sunho, lhames, rriddle.
Mar 9 2023, 11:03 AM · Restricted Project, Restricted Project
bzcheeseman requested review of D145710: [ORC] Fix name shadowing issue, NFC..
Mar 9 2023, 11:02 AM · Restricted Project, Restricted Project

Mar 6 2023

bzcheeseman accepted D145390: [ADT] Introduce `map_to_vector` helper.

Nice, thank you.

Mar 6 2023, 9:30 AM · Restricted Project, Restricted Project, Restricted Project

Mar 3 2023

bzcheeseman accepted D144276: [ORC] Introduce SetUpExecutorNativePlatform utility..

I'm happy to help fix up that one remaining issue (@sunho I might ask you for help and will definitely ask you for a review), would love to get this in :)

Mar 3 2023, 11:13 AM · Restricted Project, Restricted Project

Mar 2 2023

bzcheeseman added inline comments to D144276: [ORC] Introduce SetUpExecutorNativePlatform utility..
Mar 2 2023, 6:05 PM · Restricted Project, Restricted Project

Feb 28 2023

bzcheeseman added inline comments to D144276: [ORC] Introduce SetUpExecutorNativePlatform utility..
Feb 28 2023, 6:17 PM · Restricted Project, Restricted Project

Nov 18 2022

bzcheeseman added inline comments to D138090: [MLIR][Parser] Add `parseBase64Bytes`..
Nov 18 2022, 8:14 AM · Restricted Project, Restricted Project
bzcheeseman committed rGbf87d5ad8207: [MLIR][Parser] Add `parseBase64Bytes`. (authored by bzcheeseman).
[MLIR][Parser] Add `parseBase64Bytes`.
Nov 18 2022, 8:13 AM · Restricted Project, Restricted Project
bzcheeseman closed D138090: [MLIR][Parser] Add `parseBase64Bytes`..
Nov 18 2022, 8:13 AM · Restricted Project, Restricted Project
bzcheeseman added inline comments to D138090: [MLIR][Parser] Add `parseBase64Bytes`..
Nov 18 2022, 8:12 AM · Restricted Project, Restricted Project

Nov 15 2022

bzcheeseman updated the diff for D138090: [MLIR][Parser] Add `parseBase64Bytes`..
Nov 15 2022, 9:24 PM · Restricted Project, Restricted Project
bzcheeseman requested review of D138090: [MLIR][Parser] Add `parseBase64Bytes`..
Nov 15 2022, 9:23 PM · Restricted Project, Restricted Project

Nov 13 2022

bzcheeseman committed rGae461d8b99e6: [MLIR][Bytecode] Ensure `dataIt` is aligned coming out of `EncodingReader… (authored by bzcheeseman).
[MLIR][Bytecode] Ensure `dataIt` is aligned coming out of `EncodingReader…
Nov 13 2022, 9:27 AM · Restricted Project, Restricted Project
bzcheeseman closed D137855: [MLIR][Bytecode] Ensure `dataIt` is aligned coming out of `EncodingReader::alignTo`..
Nov 13 2022, 9:27 AM · Restricted Project, Restricted Project

Nov 12 2022

bzcheeseman added a comment to D137855: [MLIR][Bytecode] Ensure `dataIt` is aligned coming out of `EncodingReader::alignTo`..

Is there a test we could write for this?

Nov 12 2022, 9:28 AM · Restricted Project, Restricted Project

Nov 11 2022

bzcheeseman added a reviewer for D137855: [MLIR][Bytecode] Ensure `dataIt` is aligned coming out of `EncodingReader::alignTo`.: rriddle.
Nov 11 2022, 11:22 AM · Restricted Project, Restricted Project
bzcheeseman requested review of D137855: [MLIR][Bytecode] Ensure `dataIt` is aligned coming out of `EncodingReader::alignTo`..
Nov 11 2022, 11:22 AM · Restricted Project, Restricted Project

Oct 14 2022

bzcheeseman abandoned D133089: [LLVM] Replace `dyn_cast_or_null` with `dyn_cast_if_present`, NFC..

No consensus, closing this.

Oct 14 2022, 8:38 AM · Restricted Project, Restricted Project
bzcheeseman abandoned D133090: [LLVM] Replace `cast_or_null` with `cast_if_present`, NFC..

No consensus, closing this.

Oct 14 2022, 8:37 AM · Restricted Project, Restricted Project

Oct 13 2022

bzcheeseman accepted D135870: [mlir] Update Values to use new casting infra.

LGTM with river's comment applied about the code comment. Thanks nick!

Oct 13 2022, 10:45 PM · Restricted Project, Restricted Project
bzcheeseman accepted D135940: [SaveAndRestore] Upgrade this to support non-copyable types..

LGTM - I might clarify get to be getOldValue or something to make it easier on the reader at the callsite, but I don't have strong feelings about it.

Oct 13 2022, 10:43 PM · Restricted Project, Restricted Project

Oct 12 2022

bzcheeseman accepted D135823: [mlir] Update CallInterfaceCallable to use the new casting infra.

Thanks Nick :)

Oct 12 2022, 9:32 PM · Restricted Project, Restricted Project

Oct 3 2022

bzcheeseman accepted D135096: [mlir:Parser] Always splice parsed operations to the end of the parsed block.

LGTM, thanks River :)

Oct 3 2022, 4:32 PM · Restricted Project, Restricted Project

Sep 28 2022

bzcheeseman accepted D134847: [mlir] Making verification after parsing optional.

Thanks river :)

Sep 28 2022, 8:00 PM · Restricted Project, Restricted Project

Sep 20 2022

bzcheeseman accepted D134327: [mlir] Update Attributes to use the new casting infra.

Thanks River :)

Sep 20 2022, 5:50 PM · Restricted Project, Restricted Project

Sep 6 2022

bzcheeseman committed rG716b9f7a1a3c: [LLVM][Support/ADT] Add assert for isPresent to dyn_cast. (authored by bzcheeseman).
[LLVM][Support/ADT] Add assert for isPresent to dyn_cast.
Sep 6 2022, 1:59 PM · Restricted Project, Restricted Project
bzcheeseman closed D133221: [LLVM][Support/ADT] Add assert for isPresent to dyn_cast..
Sep 6 2022, 1:59 PM · Restricted Project, Restricted Project

Sep 3 2022

bzcheeseman updated the diff for D133221: [LLVM][Support/ADT] Add assert for isPresent to dyn_cast..
Sep 3 2022, 10:43 AM · Restricted Project, Restricted Project

Sep 2 2022

bzcheeseman updated the summary of D133221: [LLVM][Support/ADT] Add assert for isPresent to dyn_cast..
Sep 2 2022, 11:45 AM · Restricted Project, Restricted Project
bzcheeseman requested review of D133221: [LLVM][Support/ADT] Add assert for isPresent to dyn_cast..
Sep 2 2022, 11:44 AM · Restricted Project, Restricted Project

Sep 1 2022

bzcheeseman added a comment to D133089: [LLVM] Replace `dyn_cast_or_null` with `dyn_cast_if_present`, NFC..

Discourse thread here for folks that want to discuss more long-form: https://discourse.llvm.org/t/psa-swapping-out-or-null-with-if-present/65018

Sep 1 2022, 8:19 AM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D133090: [LLVM] Replace `cast_or_null` with `cast_if_present`, NFC..
Sep 1 2022, 7:50 AM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D133089: [LLVM] Replace `dyn_cast_or_null` with `dyn_cast_if_present`, NFC..
Sep 1 2022, 7:49 AM · Restricted Project, Restricted Project
bzcheeseman added a comment to D133089: [LLVM] Replace `dyn_cast_or_null` with `dyn_cast_if_present`, NFC..

It's also worth noting that the _or_null variants are soft-deprecated (see comments on _or_null) and this is in preparation for actually marking them deprecated. IMO, we want one way to do the "if this value exists, do the dyn_cast/cast" and the if_present naming can apply equally well to pointers and optionals.

Sep 1 2022, 7:44 AM · Restricted Project, Restricted Project

Aug 31 2022

bzcheeseman updated the summary of D133090: [LLVM] Replace `cast_or_null` with `cast_if_present`, NFC..
Aug 31 2022, 9:30 PM · Restricted Project, Restricted Project
bzcheeseman added a reviewer for D133089: [LLVM] Replace `dyn_cast_or_null` with `dyn_cast_if_present`, NFC.: lattner.
Aug 31 2022, 9:29 PM · Restricted Project, Restricted Project
bzcheeseman requested review of D133090: [LLVM] Replace `cast_or_null` with `cast_if_present`, NFC..
Aug 31 2022, 9:29 PM · Restricted Project, Restricted Project
bzcheeseman requested review of D133089: [LLVM] Replace `dyn_cast_or_null` with `dyn_cast_if_present`, NFC..
Aug 31 2022, 9:29 PM · Restricted Project, Restricted Project

Aug 30 2022

bzcheeseman committed rG688178aa2bd3: [Docs][CodeReview] Add a small paragraph on adding tokens, NFC. (authored by bzcheeseman).
[Docs][CodeReview] Add a small paragraph on adding tokens, NFC.
Aug 30 2022, 5:01 PM · Restricted Project, Restricted Project
bzcheeseman closed D131500: [Docs][CodeReview] Add a small paragraph on adding tokens, NFC..
Aug 30 2022, 5:01 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D131500: [Docs][CodeReview] Add a small paragraph on adding tokens, NFC..
Aug 30 2022, 4:59 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D131500: [Docs][CodeReview] Add a small paragraph on adding tokens, NFC..

Hey!

Sorry, I'm not sure how I missed it. Been on vacations and such... either way, I think documenting this is a good practice.

Do you have commit access or shall I commit on your behalf? If so, what do you want to have as the author name and e-mail for the commit?

Aug 30 2022, 4:27 PM · Restricted Project, Restricted Project

Aug 21 2022

bzcheeseman accepted D132009: [NFC][mlir] Add support for llvm style casting for mlir types.

Thanks for fixing the or_null to if_present too (where it makes sense). LGTM as long as everything passes CI :)

Aug 21 2022, 5:47 PM · Restricted Project, Restricted Project

Aug 19 2022

bzcheeseman added inline comments to D132009: [NFC][mlir] Add support for llvm style casting for mlir types.
Aug 19 2022, 7:58 AM · Restricted Project, Restricted Project

Aug 17 2022

bzcheeseman added inline comments to D132009: [NFC][mlir] Add support for llvm style casting for mlir types.
Aug 17 2022, 8:29 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D132009: [NFC][mlir] Add support for llvm style casting for mlir types.

+1 to the concept, many thanks for this! I think it makes more sense to implement the member versions with the llvm-style versions, it should simplify the member style code because then you won't have to manually implement the classof/isa/cast innards it'd just be cast<T>(*this) or something.

Aug 17 2022, 8:12 AM · Restricted Project, Restricted Project

Aug 10 2022

bzcheeseman awarded D131537: [mlir][LLVMIR] "Modernize" Insert/ExtractValueOp a Like token.
Aug 10 2022, 7:59 AM · Restricted Project, Restricted Project, Restricted Project

Aug 9 2022

bzcheeseman removed a reviewer for D131500: [Docs][CodeReview] Add a small paragraph on adding tokens, NFC.: lattner.
Aug 9 2022, 8:12 AM · Restricted Project, Restricted Project
bzcheeseman added a reviewer for D131500: [Docs][CodeReview] Add a small paragraph on adding tokens, NFC.: lattner.
Aug 9 2022, 8:12 AM · Restricted Project, Restricted Project
bzcheeseman added a reviewer for D131500: [Docs][CodeReview] Add a small paragraph on adding tokens, NFC.: whisperity.
Aug 9 2022, 8:12 AM · Restricted Project, Restricted Project
bzcheeseman requested review of D131500: [Docs][CodeReview] Add a small paragraph on adding tokens, NFC..
Aug 9 2022, 8:11 AM · Restricted Project, Restricted Project
bzcheeseman awarded D131319: [clang-tidy] Update llvm-prefer-isa-or-dyn-cast-in-conditionals with new syntax a Like token.
Aug 9 2022, 8:06 AM · Restricted Project, Restricted Project
bzcheeseman added a comment to D131319: [clang-tidy] Update llvm-prefer-isa-or-dyn-cast-in-conditionals with new syntax.

This is great, thank you for doing this! I'm not a competent reviewer for the actual clang-tidy code changes but the +1 for the idea :)

The problem with the approval here is that a single approval will turn the patch into a fully approved state, which breaks the dashboards for people added to the patch (i.e., other reviewers will think the patch is already approved, and thus perhaps will not consider putting effort into reviewing it!).

However, I think you should try the Award Token option from the menu on the right! Somewhere the awarded tokens should show up on the patch, tallying up support!

Aug 9 2022, 8:06 AM · Restricted Project, Restricted Project

Aug 8 2022

bzcheeseman accepted D131319: [clang-tidy] Update llvm-prefer-isa-or-dyn-cast-in-conditionals with new syntax.

This is great, thank you for doing this! I'm not a competent reviewer for the actual clang-tidy code changes but the +1 for the idea :)

Aug 8 2022, 6:46 PM · Restricted Project, Restricted Project

Jul 15 2022

bzcheeseman committed rGf382dfc06bda: [MLIR][Liveness] Add `currentlyLiveValues`, a way to get a set of values that… (authored by bzcheeseman).
[MLIR][Liveness] Add `currentlyLiveValues`, a way to get a set of values that…
Jul 15 2022, 10:11 PM · Restricted Project, Restricted Project
bzcheeseman closed D129447: [MLIR][Liveness] Add `currentlyLiveValues`, a way to get a set of values that are live as of a given operation..
Jul 15 2022, 10:11 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D129447: [MLIR][Liveness] Add `currentlyLiveValues`, a way to get a set of values that are live as of a given operation..
Jul 15 2022, 9:44 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D129447: [MLIR][Liveness] Add `currentlyLiveValues`, a way to get a set of values that are live as of a given operation..

clang-format isn't happy, please look into that.

Jul 15 2022, 9:44 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D129447: [MLIR][Liveness] Add `currentlyLiveValues`, a way to get a set of values that are live as of a given operation..
Jul 15 2022, 4:11 PM · Restricted Project, Restricted Project

Jul 13 2022

bzcheeseman added inline comments to D129447: [MLIR][Liveness] Add `currentlyLiveValues`, a way to get a set of values that are live as of a given operation..
Jul 13 2022, 11:57 AM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D129447: [MLIR][Liveness] Add `currentlyLiveValues`, a way to get a set of values that are live as of a given operation..
Jul 13 2022, 10:36 AM · Restricted Project, Restricted Project
bzcheeseman added inline comments to D129447: [MLIR][Liveness] Add `currentlyLiveValues`, a way to get a set of values that are live as of a given operation..
Jul 13 2022, 10:34 AM · Restricted Project, Restricted Project

Jul 12 2022

bzcheeseman updated the diff for D129447: [MLIR][Liveness] Add `currentlyLiveValues`, a way to get a set of values that are live as of a given operation..
Jul 12 2022, 6:02 PM · Restricted Project, Restricted Project
bzcheeseman added inline comments to D129447: [MLIR][Liveness] Add `currentlyLiveValues`, a way to get a set of values that are live as of a given operation..
Jul 12 2022, 6:01 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D129447: [MLIR][Liveness] Add `currentlyLiveValues`, a way to get a set of values that are live as of a given operation..
Jul 12 2022, 5:28 PM · Restricted Project, Restricted Project
bzcheeseman added inline comments to D129447: [MLIR][Liveness] Add `currentlyLiveValues`, a way to get a set of values that are live as of a given operation..
Jul 12 2022, 5:28 PM · Restricted Project, Restricted Project
bzcheeseman added inline comments to D129447: [MLIR][Liveness] Add `currentlyLiveValues`, a way to get a set of values that are live as of a given operation..
Jul 12 2022, 8:25 AM · Restricted Project, Restricted Project

Jul 10 2022

bzcheeseman added a comment to D129447: [MLIR][Liveness] Add `currentlyLiveValues`, a way to get a set of values that are live as of a given operation..

I had also considered a version of this patch that iterated the block with a set of refcounts for each value - that also works but this version felt a little closer to the way that the rest of the analysis is performed. I'm totally fine either way, happy to update the patch to use the other method.

Jul 10 2022, 8:29 AM · Restricted Project, Restricted Project
bzcheeseman added a reviewer for D129447: [MLIR][Liveness] Add `currentlyLiveValues`, a way to get a set of values that are live as of a given operation.: rriddle.
Jul 10 2022, 8:28 AM · Restricted Project, Restricted Project
bzcheeseman requested review of D129447: [MLIR][Liveness] Add `currentlyLiveValues`, a way to get a set of values that are live as of a given operation..
Jul 10 2022, 8:28 AM · Restricted Project, Restricted Project

Jun 28 2022

bzcheeseman accepted D128764: [mlir] Add `enableSplitting` and `insertMarkerInOutput` options to `splitAndProcessBuffer`.

Thanks River :)

Jun 28 2022, 3:09 PM · Restricted Project, Restricted Project

Jun 8 2022

bzcheeseman accepted D127231: Restore isa<Ty>(X) asserts inside cast<Ty>(X).
Jun 8 2022, 12:43 AM · Restricted Project, Restricted Project

Jun 6 2022

bzcheeseman added a comment to D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..

Is there any chance that this change removed the assert on cast<X> that the thing being pointed to isa<X>? I'm looking at a local case where I have cast<FixedVectorType(T) succeeding on something which clearly *isn't* a fixed vector, and isa<FixedVectorType>(T) returning false on the same pointer. Its possible that I'm looking at some weird bit of undefined behavior, but since I can't find where the corresponding assert is in the new version of the code, I wanted to ask.

Jun 6 2022, 8:47 PM · Restricted Project, Restricted Project

Jun 3 2022

bzcheeseman abandoned D126945: [LLVM][Docs] Fix code-block declarations in HowToSetUpLLVMStyleRTTI.rst.

Someone else already did this! great.

Jun 3 2022, 8:20 AM · Restricted Project, Restricted Project
bzcheeseman accepted D126945: [LLVM][Docs] Fix code-block declarations in HowToSetUpLLVMStyleRTTI.rst.
Jun 3 2022, 8:16 AM · Restricted Project, Restricted Project

Jun 2 2022

bzcheeseman added reviewers for D126945: [LLVM][Docs] Fix code-block declarations in HowToSetUpLLVMStyleRTTI.rst: lattner, rriddle.
Jun 2 2022, 10:58 PM · Restricted Project, Restricted Project
bzcheeseman requested review of D126945: [LLVM][Docs] Fix code-block declarations in HowToSetUpLLVMStyleRTTI.rst.
Jun 2 2022, 10:57 PM · Restricted Project, Restricted Project
bzcheeseman committed rG47231248f59b: [LLVM][Docs] Update for HowToSetUpLLVMStyleRTTI.rst, NFC. (authored by bzcheeseman).
[LLVM][Docs] Update for HowToSetUpLLVMStyleRTTI.rst, NFC.
Jun 2 2022, 10:35 PM · Restricted Project, Restricted Project
bzcheeseman closed D126943: [LLVM][Docs] Update for HowToSetUpLLVMStyleRTTI.rst, NFC..
Jun 2 2022, 10:34 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D126943: [LLVM][Docs] Update for HowToSetUpLLVMStyleRTTI.rst, NFC..
Jun 2 2022, 10:26 PM · Restricted Project, Restricted Project
bzcheeseman added reviewers for D126943: [LLVM][Docs] Update for HowToSetUpLLVMStyleRTTI.rst, NFC.: lattner, rriddle.
Jun 2 2022, 9:59 PM · Restricted Project, Restricted Project
bzcheeseman requested review of D126943: [LLVM][Docs] Update for HowToSetUpLLVMStyleRTTI.rst, NFC..
Jun 2 2022, 9:58 PM · Restricted Project, Restricted Project