Page MenuHomePhabricator

bzcheeseman (Aman LaChapelle)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2022, 9:12 AM (8 w, 2 h)

Recent Activity

Today

bzcheeseman added a comment to D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..

@bzcheeseman FYI, this is breaking the build with gcc 6 (for Debian stretch)
if you are aware of a simple fix, it would be appreciated
See https://github.com/llvm/llvm-project/issues/55626

(I am not sure I want to backport gcc 7 or 8 to Debian stretch ;)

thanks

Mon, May 23, 9:51 AM · Restricted Project, Restricted Project

Tue, May 17

bzcheeseman added a comment to D125749: [analyzer][NFC] Introduce SVal::isa<Ts...>.

Not a qualified reviewer for anything other than the llvm::isa usage and that line looks good to me!

Tue, May 17, 9:07 AM · Restricted Project, Restricted Project
bzcheeseman accepted D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals.

I had to fix the doCast to return To instead of Optional<To> to make it work.

That's fine (or it should be!), you could dereference the optional if you wanted to

Currently, we expect that casts result in regular SVal objects, instead of pointer-like objects , thus this code to compile:
NonLoc N = llvm::cast<NonLoc>(V), where V is of type SVal. I believe that is why I decided to make that change.

Tue, May 17, 7:26 AM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125543: [mlir] support isa/cast/dyn_cast<Operation *>(operation) again.

This will not happen for a random class that does not have CastInfo specialized though. For Operation *, the compiler picks the CastInfo<T, ::mlir::Operation *> specialization over the more generic CastInfo<T, T>, I don't think there is an easy way around this.

Tue, May 17, 7:04 AM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals.

I had to fix the doCast to return To instead of Optional<To> to make it work.

Tue, May 17, 7:01 AM · Restricted Project, Restricted Project

Mon, May 16

bzcheeseman added a comment to D125543: [mlir] support isa/cast/dyn_cast<Operation *>(operation) again.

I'm fine with landing this to unbreak things, but we really shouldn't need to define this IMO (the infra should automatically handle it).

Mon, May 16, 8:51 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125543: [mlir] support isa/cast/dyn_cast<Operation *>(operation) again.

@ftynse https://reviews.llvm.org/D125590 should fix this - can you please confirm and let me know if not?

Mon, May 16, 11:01 AM · Restricted Project, Restricted Project
bzcheeseman added inline comments to D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals.
Mon, May 16, 10:41 AM · Restricted Project, Restricted Project

Sun, May 15

bzcheeseman committed rG0809f63826d3: [LLVM][Casting.h] Add trivial self-cast (authored by bzcheeseman).
[LLVM][Casting.h] Add trivial self-cast
Sun, May 15, 10:22 PM · Restricted Project, Restricted Project
bzcheeseman closed D125590: [LLVM][Casting.h] Add trivial self-cast.
Sun, May 15, 10:22 PM · Restricted Project, Restricted Project
bzcheeseman accepted D125609: [ADT] Adopt the new casting infrastructure for PointerUnion.

Thank you for working on this!

Sun, May 15, 9:58 AM · Restricted Project, Restricted Project

Sat, May 14

bzcheeseman added a comment to D125609: [ADT] Adopt the new casting infrastructure for PointerUnion.
Sat, May 14, 10:23 PM · Restricted Project, Restricted Project
bzcheeseman added inline comments to D125609: [ADT] Adopt the new casting infrastructure for PointerUnion.
Sat, May 14, 10:18 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125609: [ADT] Adopt the new casting infrastructure for PointerUnion.

Thanks for feedback ;)
<snip>
It seems that partial specialization struct can't be declared as a friend.

:( I know you can have a templated friend declaration but I guess this doesn't work.

Sat, May 14, 9:26 PM · Restricted Project, Restricted Project
bzcheeseman added inline comments to D125609: [ADT] Adopt the new casting infrastructure for PointerUnion.
Sat, May 14, 8:39 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125609: [ADT] Adopt the new casting infrastructure for PointerUnion.

Define CastInfoPointerUnionImpl as below :

template <typename... PTs> struct CastInfoPointerUnionImpl {
  using From = PointerUnion<PTs...>;

  template <typename To> static inline bool isPossible(From &F) {
   return  F.Val.getInt() == FirstIndexOfType<To, PTs...>::value;
  }

  template <typename To> static To doCast(From &F) {
    assert(isPossible<To>(F) && "cast to an incompatible type !");
    return PointerLikeTypeTraits<To>::getFromVoidPointer(F.Val.getPointer());
  }
};

and declared it as a friend of PointerUnion.

Sat, May 14, 8:36 PM · Restricted Project, Restricted Project
bzcheeseman added inline comments to D125609: [ADT] Adopt the new casting infrastructure for PointerUnion.
Sat, May 14, 5:25 PM · Restricted Project, Restricted Project

Fri, May 13

bzcheeseman added a comment to D125590: [LLVM][Casting.h] Add trivial self-cast.

Found a better way to do it (I think) that avoids yet another partial specialization of CastInfo to avoid future ambiguous partial specialization shenanigans.

Fri, May 13, 10:32 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D125590: [LLVM][Casting.h] Add trivial self-cast.
Fri, May 13, 9:41 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125590: [LLVM][Casting.h] Add trivial self-cast.

The test failures look real here, can you take a look? Looks like this doesn't properly handle the non-const case.

Fri, May 13, 7:15 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D125590: [LLVM][Casting.h] Add trivial self-cast.
Fri, May 13, 3:54 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125543: [mlir] support isa/cast/dyn_cast<Operation *>(operation) again.

@ftynse PTAL at https://reviews.llvm.org/D125590 - hopefully that will just solve the problem.

Fri, May 13, 3:52 PM · Restricted Project, Restricted Project
bzcheeseman added reviewers for D125590: [LLVM][Casting.h] Add trivial self-cast: ftynse, rriddle.
Fri, May 13, 3:51 PM · Restricted Project, Restricted Project
bzcheeseman requested review of D125590: [LLVM][Casting.h] Add trivial self-cast.
Fri, May 13, 3:50 PM · Restricted Project, Restricted Project
bzcheeseman committed rGc7587080188e: [LLVM][Casting.h] Add ForwardToPointerCast trait (authored by bzcheeseman).
[LLVM][Casting.h] Add ForwardToPointerCast trait
Fri, May 13, 3:49 PM · Restricted Project, Restricted Project
bzcheeseman closed D125576: [LLVM][Casting.h] Add ForwardToPointerCast trait.
Fri, May 13, 3:49 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125576: [LLVM][Casting.h] Add ForwardToPointerCast trait.

I think Operation casting probably could have used it IIRC

Fri, May 13, 3:37 PM · Restricted Project, Restricted Project
bzcheeseman committed rGbc65fc8bb314: [LLVM][Casting.h] Remove CastInfo pointer partial specialization. (authored by bzcheeseman).
[LLVM][Casting.h] Remove CastInfo pointer partial specialization.
Fri, May 13, 3:31 PM · Restricted Project, Restricted Project
bzcheeseman closed D125578: [LLVM][Casting.h] Remove CastInfo pointer partial specialization..
Fri, May 13, 3:31 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125543: [mlir] support isa/cast/dyn_cast<Operation *>(operation) again.

Actually it'll probably be better to have a CastInfo specialization for all self-casts. I'll put up a patch hopefully shortly.

Fri, May 13, 3:27 PM · Restricted Project, Restricted Project
bzcheeseman added a reviewer for D125578: [LLVM][Casting.h] Remove CastInfo pointer partial specialization.: rriddle.
Fri, May 13, 12:58 PM · Restricted Project, Restricted Project
bzcheeseman requested review of D125578: [LLVM][Casting.h] Remove CastInfo pointer partial specialization..
Fri, May 13, 12:57 PM · Restricted Project, Restricted Project
bzcheeseman added a reviewer for D125576: [LLVM][Casting.h] Add ForwardToPointerCast trait: rriddle.
Fri, May 13, 11:53 AM · Restricted Project, Restricted Project
bzcheeseman requested review of D125576: [LLVM][Casting.h] Add ForwardToPointerCast trait.
Fri, May 13, 11:53 AM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125543: [mlir] support isa/cast/dyn_cast<Operation *>(operation) again.

Actually it'd probably be easier to just add an if (std::is_same<T, ::mlir::Operation *>::value) return true; condition to isPossible, everything else should "just work".

Fri, May 13, 10:13 AM · Restricted Project, Restricted Project

Thu, May 12

bzcheeseman committed rG0be41ed5bb57: [LLVM][Casting.h] Don't create a temporary while casting. (authored by bzcheeseman).
[LLVM][Casting.h] Don't create a temporary while casting.
Thu, May 12, 8:11 PM · Restricted Project, Restricted Project
bzcheeseman closed D125482: [LLVM][Casting.h] Don't create a temporary while casting..
Thu, May 12, 8:11 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125482: [LLVM][Casting.h] Don't create a temporary while casting..

Finally got green on Debian build (seems like check-all on build kite only works at night?) https://buildkite.com/llvm-project/premerge-checks/builds/92657#5c473a5a-6e3d-4247-a307-30df72a6482d

Thu, May 12, 8:10 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D125482: [LLVM][Casting.h] Don't create a temporary while casting..
Thu, May 12, 7:27 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D125482: [LLVM][Casting.h] Don't create a temporary while casting..
Thu, May 12, 6:35 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125482: [LLVM][Casting.h] Don't create a temporary while casting..

@qiongsiwu1 I assume you ran the whole test suite with no problems? My machine is rather slow so running check-all takes ~many hours for me

Good call - no I did not run the whole test suite. I did run ninja check-all. Let me give the test suite a try as well.

That's what I meant. I think build kite is running ninja check-clang-tools check-bolt check-mlir check-flang check-all check-lld check-openmp check-clang check-polly check-libc check-llvm

build kite is being flaky right now so I'd love a clean bill of health before landing to unblock folks.

Ah I see. I tested check-all, but I did not build flang/openmp/polly/libc for my local testing. Let me give those a go instead of running the "test-suite".

Thu, May 12, 4:38 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125482: [LLVM][Casting.h] Don't create a temporary while casting..

@qiongsiwu1 I assume you ran the whole test suite with no problems? My machine is rather slow so running check-all takes ~many hours for me

Good call - no I did not run the whole test suite. I did run ninja check-all. Let me give the test suite a try as well.

Thu, May 12, 4:34 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125482: [LLVM][Casting.h] Don't create a temporary while casting..

@qiongsiwu1 I assume you ran the whole test suite with no problems?

Thu, May 12, 4:30 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D125482: [LLVM][Casting.h] Don't create a temporary while casting..
Thu, May 12, 4:20 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D125482: [LLVM][Casting.h] Don't create a temporary while casting..
Thu, May 12, 2:44 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125482: [LLVM][Casting.h] Don't create a temporary while casting..

Hi, we're also getting the original error on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/1255/steps/6/logs/stdio

I applied your patch here and it seems to fix the original error, but there is a new one:

/llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:69:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
  cast<MyBaseType>(D);
  ^~~~~~~~~~~~~~~~ ~
/llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:70:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
  cast<MyBaseType>(BD);
  ^~~~~~~~~~~~~~~~ ~~
/llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:71:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
  cast<MyDerivedType>(BD);
  ^~~~~~~~~~~~~~~~~~~ ~~

This commit went in last night it looks like to fix that: 52328dafda13711653fd15aa4db34db350471a1f

Oh my mistake, my branch was only up to the other commit. Thank you

Thu, May 12, 2:10 PM · Restricted Project, Restricted Project
bzcheeseman retitled D125482: [LLVM][Casting.h] Don't create a temporary while casting. from [LLVM][Casting.h] Don't create a temporary while casting. r=lattner,qiongsiwu1,uabelho to [LLVM][Casting.h] Don't create a temporary while casting..
Thu, May 12, 2:05 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125482: [LLVM][Casting.h] Don't create a temporary while casting..

Hi, we're also getting the original error on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/1255/steps/6/logs/stdio

I applied your patch here and it seems to fix the original error, but there is a new one:

/llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:69:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
  cast<MyBaseType>(D);
  ^~~~~~~~~~~~~~~~ ~
/llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:70:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
  cast<MyBaseType>(BD);
  ^~~~~~~~~~~~~~~~ ~~
/llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:71:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
  cast<MyDerivedType>(BD);
  ^~~~~~~~~~~~~~~~~~~ ~~
Thu, May 12, 2:04 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D125482: [LLVM][Casting.h] Don't create a temporary while casting..
Thu, May 12, 2:00 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125482: [LLVM][Casting.h] Don't create a temporary while casting..

@qiongsiwu1 or @uabelho please let me know if this fixes the issue you saw. I don't think I see the warning emitted anywhere I was able to repro.

Thanks for the fast response @bzcheeseman ! I've tested this patch locally on a ppc machine. The warning is no longer there and all lit tests pass.

Thu, May 12, 12:33 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125482: [LLVM][Casting.h] Don't create a temporary while casting..

@qiongsiwu1 or @uabelho please let me know if this fixes the issue you saw. I no longer see the warning emitted anywhere I was able to repro.

Thu, May 12, 12:04 PM · Restricted Project, Restricted Project
bzcheeseman retitled D125482: [LLVM][Casting.h] Don't create a temporary while casting. from [LLVM][Casting.h] Don't create a temporary while casting. r=lattner,qiongsiwu1,uabelho to [LLVM][Casting.h] Don't create a temporary while casting..
Thu, May 12, 11:21 AM · Restricted Project, Restricted Project
bzcheeseman added a comment to D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..

https://reviews.llvm.org/D125482 doesn't exhibit the problem in the unit test, but now I have to wait for all the other tests to complete so hopefully nothing else breaks!

Thu, May 12, 10:42 AM · Restricted Project, Restricted Project
bzcheeseman requested review of D125482: [LLVM][Casting.h] Don't create a temporary while casting..
Thu, May 12, 10:41 AM · Restricted Project, Restricted Project
bzcheeseman added a comment to D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..

I'm just now seeing this (just woke up) so I'll take a look and hopefully resolve it shortly! Thanks for bringing this to my attention.

Thu, May 12, 7:56 AM · Restricted Project, Restricted Project

Wed, May 11

bzcheeseman added inline comments to D124963: [MLIR][Operation] Simplify Operation casting, NFC.
Wed, May 11, 10:09 PM · Restricted Project, Restricted Project
bzcheeseman added inline comments to D124963: [MLIR][Operation] Simplify Operation casting, NFC.
Wed, May 11, 9:40 PM · Restricted Project, Restricted Project
bzcheeseman committed rGbc22b5c9a2f7: [MLIR][Operation] Simplify Operation casting, NFC (authored by bzcheeseman).
[MLIR][Operation] Simplify Operation casting, NFC
Wed, May 11, 9:17 PM · Restricted Project, Restricted Project
bzcheeseman closed D124963: [MLIR][Operation] Simplify Operation casting, NFC.
Wed, May 11, 9:17 PM · Restricted Project, Restricted Project
bzcheeseman committed rGf156b51aecc6: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how… (authored by bzcheeseman).
[LLVM][Casting.h] Update dyn_cast machinery to provide more control over how…
Wed, May 11, 9:16 PM · Restricted Project, Restricted Project
bzcheeseman closed D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Wed, May 11, 9:15 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125353: [AsmParser] Improve error recovery again..

Thanks for looking into it - if this is simpler than the other thing then by all means let's keep it simple!

Wed, May 11, 12:53 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D124963: [MLIR][Operation] Simplify Operation casting, NFC.
Wed, May 11, 12:25 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Wed, May 11, 12:25 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D124963: [MLIR][Operation] Simplify Operation casting, NFC.
Wed, May 11, 11:19 AM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Wed, May 11, 11:19 AM · Restricted Project, Restricted Project
bzcheeseman added a comment to D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..

I'd prefer we have one thing. Re:

I like this idea - I originally had dyn_cast_or_null with an overload for Optional but it looked goofy. I like dyn_cast_if_present with maybe some forwarding dyn_cast_or_null to avoid breaking everyone.

it is super awesome to stage things in and give people a migration window, but if it is the right thing to rename this, then we should drop the old name, not carry it around forever.

FWIW, having a migration window makes a massive difference for downstream projects. Especially with the currently ongoing discussions about just how big the monorepo should be, this is a consideration to take seriously.

In many cases a migration window helps even if it is "only a microsecond long", i.e. if you have two patches, one to add the new name (and make the old name a plain forward), and a separate follow-up to remove the old name, that can help migrations even if the two commits are added back-to-back.

Which the current version does, so thank you very much for that :)

Wed, May 11, 9:57 AM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D124963: [MLIR][Operation] Simplify Operation casting, NFC.
Wed, May 11, 9:43 AM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Wed, May 11, 9:43 AM · Restricted Project, Restricted Project
bzcheeseman added inline comments to D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Wed, May 11, 9:42 AM · Restricted Project, Restricted Project
bzcheeseman added inline comments to D125355: [AsmParser] Adopt emitWrongTokenError more, improving QoI.
Wed, May 11, 8:38 AM · Restricted Project, Restricted Project
bzcheeseman added inline comments to D125353: [AsmParser] Improve error recovery again..
Wed, May 11, 8:35 AM · Restricted Project, Restricted Project

Tue, May 10

bzcheeseman updated the diff for D124963: [MLIR][Operation] Simplify Operation casting, NFC.
Tue, May 10, 3:01 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Tue, May 10, 3:01 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D124963: [MLIR][Operation] Simplify Operation casting, NFC.
Tue, May 10, 8:35 AM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Tue, May 10, 8:35 AM · Restricted Project, Restricted Project
bzcheeseman added a comment to D125295: [MLIR Parser] Improve QoI for "expected token" errors.

Just a couple questions, thanks for knocking this out!

Tue, May 10, 4:09 AM · Restricted Project, Restricted Project

Thu, May 5

bzcheeseman updated the diff for D124963: [MLIR][Operation] Simplify Operation casting, NFC.
Thu, May 5, 2:30 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Thu, May 5, 2:30 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D124963: [MLIR][Operation] Simplify Operation casting, NFC.
Thu, May 5, 10:46 AM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Thu, May 5, 10:46 AM · Restricted Project, Restricted Project

Wed, May 4

bzcheeseman retitled D124963: [MLIR][Operation] Simplify Operation casting, NFC from [MLIR][Operations] Simplify Operation casting to [MLIR][Operation] Simplify Operation casting, NFC.
Wed, May 4, 2:16 PM · Restricted Project, Restricted Project
bzcheeseman updated the summary of D124963: [MLIR][Operation] Simplify Operation casting, NFC.
Wed, May 4, 2:01 PM · Restricted Project, Restricted Project
bzcheeseman requested review of D124963: [MLIR][Operation] Simplify Operation casting, NFC.
Wed, May 4, 2:00 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Wed, May 4, 12:49 PM · Restricted Project, Restricted Project

Tue, May 3

bzcheeseman updated the diff for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Tue, May 3, 8:47 PM · Restricted Project, Restricted Project

Thu, Apr 28

bzcheeseman updated the diff for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Thu, Apr 28, 10:18 PM · Restricted Project, Restricted Project
bzcheeseman added a comment to D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..

Sorry for all the traffic on this last night - my machine is a bit slow so I was partly using CI to help run all the llvm-project tests. Should be ready for review at this point, all passing :)

Thu, Apr 28, 9:43 AM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Thu, Apr 28, 12:26 AM · Restricted Project, Restricted Project

Wed, Apr 27

bzcheeseman updated the diff for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Wed, Apr 27, 11:12 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Wed, Apr 27, 9:12 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Wed, Apr 27, 6:20 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Wed, Apr 27, 5:32 PM · Restricted Project, Restricted Project
bzcheeseman added inline comments to D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Wed, Apr 27, 5:03 PM · Restricted Project, Restricted Project
bzcheeseman updated the summary of D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Wed, Apr 27, 4:54 PM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Wed, Apr 27, 3:24 PM · Restricted Project, Restricted Project

Apr 18 2022

bzcheeseman added a comment to D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..

Working on updating this in accordance with comments (so folks know I'm not ignoring anyone). Thanks all for the reviews, hope to have an updated patch soon.

Apr 18 2022, 5:25 PM · Restricted Project, Restricted Project

Apr 16 2022

bzcheeseman added a comment to D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..

It may be helpful to also show the patch with the intended use-case.

Apr 16 2022, 4:52 PM · Restricted Project, Restricted Project
bzcheeseman added a reviewer for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed.: lattner.
Apr 16 2022, 11:48 AM · Restricted Project, Restricted Project
bzcheeseman updated the diff for D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..
Apr 16 2022, 11:43 AM · Restricted Project, Restricted Project