Page MenuHomePhabricator

lattner (Chris Lattner)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2016, 7:50 PM (128 w, 4 d)

Recent Activity

Oct 31 2018

lattner accepted D53950: Fix clang -Wimplicit-fallthrough warnings across llvm, NFC.
Oct 31 2018, 10:38 PM

Oct 21 2018

lattner resigned from D52707: Switch optimization in IR for known maximum switch values.
Oct 21 2018, 8:52 PM · Restricted Project

Oct 20 2018

lattner committed rL344853: dev mtg done.
dev mtg done
Oct 20 2018, 9:33 AM
lattner committed rL344851: Add S4TF GPE slides.
Add S4TF GPE slides
Oct 20 2018, 9:02 AM

Oct 16 2018

lattner committed rL344621: fix an out of date paragraph noticed by Bryce Lelbach.
fix an out of date paragraph noticed by Bryce Lelbach
Oct 16 2018, 9:56 AM

Oct 5 2018

lattner accepted D52929: Update to relicensing website with developments over the past few months..

Looks great, thanks Chandler!

Oct 5 2018, 9:27 AM

Sep 24 2018

lattner added a comment to D51664: [IR] Lazily number instructions for local dominance queries.

To be clear, I'm not necessarily saying that this patch is the wrong thing to do, I would just like more diligence and experimentation with alternate approaches. Thanks :-)

Sep 24 2018, 10:04 PM
lattner added a comment to D51664: [IR] Lazily number instructions for local dominance queries.

As I mentioned on llvmdev, I'm strongly opposed to this patch without a significant amount of analysis and diligence applied to it. I'm concerned about both memory and compile time impact. We don't just add random caches to the core IR to speed up particular clients. We care a lot about sizeof(Instruction) and its subclasses, and this adds bloat to all of them. Similarly, you don't seem interested in evaluating "tricks" to make this efficient in practice (sparse numbering), nor have you evaluated other implementation choices that will probably also work with less impact. Let's continue discussing this on llvm-dev.

Sep 24 2018, 10:04 PM

Jul 17 2018

lattner added a comment to D49328: [FileCheck] Provide an option for FileCheck to dump original input to stderr on failure.

Just a drive by, but I'm hugely +1 on this change, thank you for tackling it!

Jul 17 2018, 10:44 PM

Jul 7 2018

lattner accepted D48991: Docs: Spell C++ lambdas like functions, not variables.

Patch LGTM, I'd suggest including an example like `auto updateResult = [&](){...`

Jul 7 2018, 8:12 AM

Jun 23 2018

lattner added a comment to D48516: ADT: Use EBO to shrink SmallVector size 1.

nice!

Jun 23 2018, 10:12 AM

Jun 5 2018

lattner accepted D47796: Use the correct project name in README.txt.

How about changing it to "LLVM Compiler Infrastructure". Accepted with that tweak, thanks!

Jun 5 2018, 3:22 PM

Apr 16 2018

lattner committed rL330127: add links.
add links
Apr 16 2018, 7:25 AM
lattner committed rL330125: Put all the tidbits about the current state of relicensing into one place so it….
Put all the tidbits about the current state of relicensing into one place so it…
Apr 16 2018, 7:17 AM

Apr 7 2018

lattner committed rL329507: add the draft developer policy patch, as was proposed on Aug 7 2017 on llvm-dev..
add the draft developer policy patch, as was proposed on Aug 7 2017 on llvm-dev.
Apr 7 2018, 10:39 AM
lattner committed rL329506: Add the current draft of the Apache 2 + LLVM Exception license, for reference..
Add the current draft of the Apache 2 + LLVM Exception license, for reference.
Apr 7 2018, 10:31 AM

Mar 8 2018

lattner accepted D44216: [LangRef] make it clear that FP instructions do not have side effects.

These changes look great, but I'd suggest explicitly mentioning that SNaN behavior somewhere, the relation of the instructions to the intrinsics etc. Perhaps a section before Fast Math Flags?

Mar 8 2018, 6:21 PM

Feb 5 2018

lattner added a comment to D42850: [docs] Add guidance on duplicating doc comments to CodingStandards.

Here's a different way to interpret the current situation: instead of seeing the current behavior as "inconsistent", you could see it as "duplication only making sense in some cases". Realistically though, I agree that the code base is probably inconsistent as it is written by lots of people with different practices.

Feb 5 2018, 9:27 PM
lattner added a comment to D42850: [docs] Add guidance on duplicating doc comments to CodingStandards.

Personally, I don't see the harm in duplicating the comments, and they are useful when you're not using doxygen or some other tool. You're talking about the overriden method situation, but another common one is when you define a class in an anonymous namespace and then implement it later in the same file. The implementation should certainly have a doc comment on it, and if it helps to understand the overview of what the struct is doing, then it makes sense to document it in the class definition as well.

Feb 5 2018, 9:25 PM

Jan 31 2018

lattner accepted D42771: Coding Standards: Document library layering requirements & header isolation..

This change LGTM.

Jan 31 2018, 9:17 PM

Nov 3 2017

lattner committed rL317400: trim a bit more.
trim a bit more
Nov 3 2017, 7:43 PM
lattner committed rL317399: now that the event is over, remove the logistics so that the program is more….
now that the event is over, remove the logistics so that the program is more…
Nov 3 2017, 7:41 PM

Oct 24 2017

lattner resigned from D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter..
Oct 24 2017, 9:25 PM · debug-info
lattner resigned from D39245: [ADT] Shuffle containers before sorting to uncover non-deterministic behavior.
Oct 24 2017, 9:24 PM

Aug 30 2017

lattner accepted D37264: [Docs] Update CodingStandards to recommend range-based for loops.

LGTM! Thanks @asb

Aug 30 2017, 10:00 PM

Aug 29 2017

lattner added a comment to D37264: [Docs] Update CodingStandards to recommend range-based for loops.

FWIW, I agree with @majnemer's comments here: use of auto in those places doesn't aid in understanding/maintainability of the code, and it is important to mention that the manual loop with an explicitly evaluated end can make sense if the sequence is being mutated in the loop (but also we should recommend a comment to make that explicit!)

Aug 29 2017, 9:23 PM

Jul 11 2017

lattner resigned from D35267: Pass Divergence Analysis data to selection DAG to drive divergence dependent instruction selection.
Jul 11 2017, 10:05 AM

Jul 6 2017

lattner committed rL307299: remove an unused empty file..
remove an unused empty file.
Jul 6 2017, 12:06 PM

Jun 26 2017

lattner added a comment to D34537: Move vmkit in the ProjectsWithLLVM section.

I agree we should remove it from the main page. DragonEgg should also be removed.

Jun 26 2017, 10:43 AM

Jun 25 2017

lattner committed rL306228: Much of the web page may be my fault, but i'm not actively maintaining it, .
Much of the web page may be my fault, but i'm not actively maintaining it,
Jun 25 2017, 1:54 PM

May 21 2017

lattner added a comment to D32737: [Constants][SVE] Represent the runtime length of a scalable vector.

I've only lightly read the spec, but it looks like the vector length can be controlled by writing to the ZCR_ELn registers (so, e.g. user code could make a syscall to change the vector length)? If that's accurate, I think a constant vscale is not sufficient.

May 21 2017, 1:43 PM
lattner added a comment to D32737: [Constants][SVE] Represent the runtime length of a scalable vector.

This is not a research project, it's a spec that is being made into hardware by a large number of large corporations and it's in development by a long number of years.

May 21 2017, 9:01 AM

May 20 2017

lattner added a comment to D32737: [Constants][SVE] Represent the runtime length of a scalable vector.

@echristo @chandlerc @lattner @majnemer Ping.

This is a trivial change, discussed in the past, and I'm inclined to approve.

Uh, where was it discussed? It's entirely possible I missed it, but I can't find any consensus on any of the threads that we actually want to support runtime vector width in LLVM's IR.

...

For the record, I remain unconvinced that LLVM's IR should support non-constant vector widths

May 20 2017, 3:35 PM

Nov 5 2016

lattner resigned from D26299: Improving the efficiency of the Loop Unswitching pass.
Nov 5 2016, 7:10 PM

Oct 28 2016

lattner added a comment to D25812: X86: Introduce the "relocImm" ComplexPattern, which represents a relocatable immediate..

Thanks for improving this to allow programatic complexity! This looks overall great to me, but again, I'm not the best technical reviewer for X86 backend anymore.

Oct 28 2016, 11:51 AM

Oct 25 2016

lattner added a comment to D25878: IR, X86: Understand !range metadata on global variables..

I think there are two things going on here. I think that eli is right: LLVM IR global variables should always be assumable that they don't alias. This is guaranteed by C and other source languages and is important for LLVM to be able to represent. Separately though, I think it makes sense for LLVM globals to have !range metadata to specify that (though disjoint) they live in a specific address range that can fit into immediates.

Oct 25 2016, 10:12 PM
lattner added a comment to D25812: X86: Introduce the "relocImm" ComplexPattern, which represents a relocatable immediate..

This seems like a huge improvement over the status quo. Unfortunately, it's been a couple of years since I've worked on this area though, so I'd like you to get someone working on the X86 backend to look at it.

Oct 25 2016, 10:08 PM

Oct 24 2016

lattner requested changes to D25930: IR: Introduce a GlobalPointer type for all GlobalValues of pointer type..

This doesn't seem like the right approach. It would be better to introduce a new top level IR concept to represent this, instead of violating the model of GlobalValue.

Oct 24 2016, 9:39 PM

Oct 11 2016

lattner added a comment to D25481: CodeGen: Introduce a base class for immediates..

Ah, I didn't see it. I'll respond there.

Oct 11 2016, 2:35 PM
lattner added a comment to D25481: CodeGen: Introduce a base class for immediates..

As I mentioned on llvmdev, this approach doesn't make sense to me.

Oct 11 2016, 12:26 PM

Sep 26 2016

lattner added a comment to D24929: libclc: Remove copyright headers from top of files.

Looks reasonable, please add the standard LLVM file header blob per the coding standards.

Sep 26 2016, 2:45 PM
lattner resigned from D24930: libclc: Remove code that is not licensed under either the UIUC or MIT license.

I can't provide a technical review for this, but thank you for working on it!

Sep 26 2016, 2:43 PM
lattner added a comment to D24904: Allow StringRef to be constructed with a null pointer.

This revision LGTM, making the "const char*" ctor explicit can & should be done as a second step, thanks!

Sep 26 2016, 2:10 PM
lattner added a comment to D24904: Allow StringRef to be constructed with a null pointer.

You should be able to make string literals work if you use a template that takes an array of char with the size as a template parameter.

Sep 26 2016, 12:57 PM
lattner added a comment to D24904: Allow StringRef to be constructed with a null pointer.

The 0 is for the length, not the actual pointer.

Sep 26 2016, 11:00 AM
lattner accepted D24904: Allow StringRef to be constructed with a null pointer.

LGTM, might as well use nullptr instead of 0 though.

Sep 26 2016, 9:18 AM

Sep 13 2016

lattner resigned from D24540: [AArch64] Add Cavium ThunderX subtarget support..
Sep 13 2016, 9:02 PM

Sep 12 2016

lattner committed rL281235: Add Aug 5 board meeting minutes..
Add Aug 5 board meeting minutes.
Sep 12 2016, 10:17 AM

Aug 30 2016

lattner accepted D23982: Fix comments about IndirectBrInst in Instructions.h.
Aug 30 2016, 2:30 PM
lattner added a comment to D23982: Fix comments about IndirectBrInst in Instructions.h.

LGTM

Aug 30 2016, 2:30 PM

Aug 18 2016

lattner accepted D23591: Update coding standards for include style.

LGTM!

Aug 18 2016, 2:01 PM
lattner resigned from D23671: libLLVMSupport: Generate random block of arbitrary size.
Aug 18 2016, 9:06 AM

Aug 17 2016

lattner added a comment to D23162: [docs] Adding target status definition to dev policy.

Thanks Renato!

Aug 17 2016, 3:25 PM
lattner committed rL278994: wordsmith the "new targets" section a bit..
wordsmith the "new targets" section a bit.
Aug 17 2016, 3:25 PM

Aug 16 2016

lattner added a comment to D23404: Clarify suggestion to use "#if 0" ... "#endif" for large blocks of comments.

I think this approach (adding "Commenting out large blocks of code is discouraged, ...") is great!

Aug 16 2016, 3:37 PM

Aug 15 2016

lattner requested changes to D23162: [docs] Adding target status definition to dev policy.

Overall, looks great. I added some specific detailed comments above. Once you addressed those, I think this is good to merge, thank you for driving this forward Renato!

Aug 15 2016, 9:49 PM

Aug 11 2016

lattner accepted D23404: Clarify suggestion to use "#if 0" ... "#endif" for large blocks of comments.
Aug 11 2016, 9:36 AM
lattner added a comment to D23404: Clarify suggestion to use "#if 0" ... "#endif" for large blocks of comments.

I'm +1 for this change. While this is a good suggestion for local development of code when you're working on it, we don't want large blocks of code to be checked into the source tree. This document doesn't need legislate how you do your local development :-)

Aug 11 2016, 9:36 AM

Aug 5 2016

lattner committed rL277851: Add July 8 board meeting minutes..
Add July 8 board meeting minutes.
Aug 5 2016, 12:10 PM

Jul 28 2016

lattner committed rL277112: I dropped some text. Tanya points out that it is best to match the formal….
I dropped some text. Tanya points out that it is best to match the formal…
Jul 28 2016, 10:30 PM
lattner committed rL277110: Found one more, I think that is all of them..
Found one more, I think that is all of them.
Jul 28 2016, 10:23 PM
lattner committed rL277109: Curly quotes, seriously..
Curly quotes, seriously.
Jul 28 2016, 10:19 PM
lattner committed rL277108: Add the most recent meeting minutes, and switch to plaintext because that….
Add the most recent meeting minutes, and switch to plaintext because that…
Jul 28 2016, 10:18 PM
lattner committed rL277107: add minutes from an old meeting that were missing..
add minutes from an old meeting that were missing.
Jul 28 2016, 10:15 PM
lattner committed rL277106: Rearrange the directory structure of the foundation meeting minutes to sort.
Rearrange the directory structure of the foundation meeting minutes to sort
Jul 28 2016, 10:12 PM

Jul 25 2016

lattner requested changes to D22753: [docs] Adding target status definition.

I think it absolutely makes sense to encode the policy for this into the developer policy document, but think we should converge on the mailing list before discussing specific wording for it.

Jul 25 2016, 2:50 PM

Jul 18 2016

lattner updated subscribers of D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!.
Jul 18 2016, 7:51 PM
lattner added a comment to D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!.

Please send this to llvm-dev for discussion when it converges, thanks!

Jul 18 2016, 4:05 PM
lattner resigned from D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!.
Jul 18 2016, 4:05 PM

Jul 13 2016

lattner resigned from D22294: Add functionality for rewriting symbols.
Jul 13 2016, 10:05 PM
lattner committed rL275364: clarify a bit..
clarify a bit.
Jul 13 2016, 7:59 PM

Jun 28 2016

lattner added a comment to D21821: Bump trunk version to 4.0 and switch to new versioning scheme.

LGTM!

Jun 28 2016, 7:50 PM