Page MenuHomePhabricator

lattner (Chris Lattner)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2016, 7:50 PM (307 w, 4 d)

Recent Activity

Tue, May 17

lattner added inline comments to D125557: [APInt] Remove all uses of zextOrSelf, sextOrSelf and truncOrSelf.
Tue, May 17, 4:48 PM · Restricted Project, Restricted Project, Restricted Project

Sun, May 15

lattner accepted D125651: [mlir] Restrict dialect doc gen to a single dialect.

Nice, thank you for fixing this!

Sun, May 15, 5:28 PM · Restricted Project, Restricted Project
lattner accepted D125609: [ADT] Adopt the new casting infrastructure for PointerUnion.

I'm excited to see this, thank you or working on it. +1 with the changes aman suggested.

Sun, May 15, 11:10 AM · Restricted Project, Restricted Project
lattner added inline comments to D125595: (DRAFT) [mlir][ods] Don't allow trailing optional operands in assembly formats.
Sun, May 15, 11:08 AM · Restricted Project, Restricted Project

Sat, May 14

lattner committed rG5ac9d662093d: [DenseElementsAttr] Teach isValidRawBuffer that 1-elt values are splats. (authored by lattner).
[DenseElementsAttr] Teach isValidRawBuffer that 1-elt values are splats.
Sat, May 14, 3:50 AM · Restricted Project, Restricted Project

Fri, May 13

lattner added a comment to D125595: (DRAFT) [mlir][ods] Don't allow trailing optional operands in assembly formats.

Cool, great catch!

Fri, May 13, 11:00 PM · Restricted Project, Restricted Project
lattner accepted D125557: [APInt] Remove all uses of zextOrSelf, sextOrSelf and truncOrSelf.

nice cleanup!

Fri, May 13, 10:53 PM · Restricted Project, Restricted Project, Restricted Project
lattner committed rG27478872fd15: [ParseResult] Fix warning in flang build, incorporate feedback from River. (authored by lattner).
[ParseResult] Fix warning in flang build, incorporate feedback from River.
Fri, May 13, 3:31 PM · Restricted Project, Restricted Project, Restricted Project
lattner closed D125587: [ParseResult] Fix warning in flang build, incorporate feedback from River..
Fri, May 13, 3:30 PM · Restricted Project, Restricted Project, Restricted Project
lattner accepted D125587: [ParseResult] Fix warning in flang build, incorporate feedback from River..
Fri, May 13, 3:30 PM · Restricted Project, Restricted Project, Restricted Project
lattner requested review of D125587: [ParseResult] Fix warning in flang build, incorporate feedback from River..
Fri, May 13, 3:29 PM · Restricted Project, Restricted Project, Restricted Project
lattner added inline comments to D125549: [ParseResult] Mark this as LLVM_NODISCARD (like LogicalResult) and fix issues..
Fri, May 13, 3:18 PM · Restricted Project, Restricted Project
lattner added a comment to D125558: [APInt] Deprecate truncOrSelf, zextOrSelf and sextOrSelf.

Ok, awesome!

Fri, May 13, 3:10 PM · Restricted Project, Restricted Project
lattner added a comment to D125559: [APInt] Remove truncOrSelf, zextOrSelf and sextOrSelf.

This should wait a week or two and please send a heads up about the deprecation to llvm forums

Fri, May 13, 10:55 AM · Restricted Project, Restricted Project
lattner accepted D125558: [APInt] Deprecate truncOrSelf, zextOrSelf and sextOrSelf.

This is great in concept but I think we have macros to deprecate things in compiler.h, please also make sure all in tree uses are removed before landing this. Are there any APInt docs or comments that need to be updated? Are you keeping APSInt in sync as well?

Fri, May 13, 10:54 AM · Restricted Project, Restricted Project
lattner accepted D125556: [APInt] Allow extending and truncating to the same width.

Nice, this makes things much simpler and defines away a class of bugs

Fri, May 13, 10:44 AM · Restricted Project, Restricted Project
lattner committed rG1d7b5cd5bf8c: [ParseResult] Mark this as LLVM_NODISCARD (like LogicalResult) and fix issues. (authored by lattner).
[ParseResult] Mark this as LLVM_NODISCARD (like LogicalResult) and fix issues.
Fri, May 13, 8:29 AM · Restricted Project, Restricted Project
lattner closed D125549: [ParseResult] Mark this as LLVM_NODISCARD (like LogicalResult) and fix issues..
Fri, May 13, 8:29 AM · Restricted Project, Restricted Project
lattner accepted D125549: [ParseResult] Mark this as LLVM_NODISCARD (like LogicalResult) and fix issues..
Fri, May 13, 8:28 AM · Restricted Project, Restricted Project
lattner requested review of D125549: [ParseResult] Mark this as LLVM_NODISCARD (like LogicalResult) and fix issues..
Fri, May 13, 7:39 AM · Restricted Project, Restricted Project
lattner accepted D125427: [TableGen] Add a new json textmate description for syntax highlighting.

Very cool, if there is no good reviewer for this, I'd say "land it; advertise it; react to feedback from users" :-)

Fri, May 13, 12:29 AM · Restricted Project, Restricted Project
lattner added a comment to D125427: [TableGen] Add a new json textmate description for syntax highlighting.

I'm not a competent reviewer for this patch, but I love tblgen getting better tooling :-)

Fri, May 13, 12:05 AM · Restricted Project, Restricted Project

Thu, May 12

lattner committed rG3cce374ee663: Various improvements suggested by river NFC. (authored by lattner).
Various improvements suggested by river NFC.
Thu, May 12, 8:25 AM · Restricted Project, Restricted Project
lattner committed rGf21896f2c6dc: [DenseElementAttr] Simplify the public API for creating these. (authored by lattner).
[DenseElementAttr] Simplify the public API for creating these.
Thu, May 12, 8:25 AM · Restricted Project, Restricted Project
lattner closed D125471: Various improvements suggested by river NFC..
Thu, May 12, 8:25 AM · Restricted Project, Restricted Project
lattner closed D125447: [DenseElementAttr] Simplify the public API for creating these..
Thu, May 12, 8:25 AM · Restricted Project, Restricted Project
lattner added a comment to D125471: Various improvements suggested by river NFC..

This should be part of https://reviews.llvm.org/D125447, weird.

Thu, May 12, 8:19 AM · Restricted Project, Restricted Project
lattner requested review of D125471: Various improvements suggested by river NFC..
Thu, May 12, 8:18 AM · Restricted Project, Restricted Project
lattner added a comment to D125447: [DenseElementAttr] Simplify the public API for creating these..

Thank you for the review!

Thu, May 12, 8:17 AM · Restricted Project, Restricted Project

Wed, May 11

lattner requested review of D125447: [DenseElementAttr] Simplify the public API for creating these..
Wed, May 11, 9:33 PM · Restricted Project, Restricted Project
lattner edited reviewers for D125402: [clang][diag] warn if function returns class type by-const-value, added: rsmith; removed: lattner.

I'm not a competent reviewer for this, Richard can you recommend someone?

Wed, May 11, 12:53 PM · Restricted Project, Restricted Project
lattner added inline comments to D125353: [AsmParser] Improve error recovery again..
Wed, May 11, 12:51 PM · Restricted Project, Restricted Project
lattner committed rG86445e8c63c7: [AsmParser] Adopt emitWrongTokenError more, improving QoI (authored by lattner).
[AsmParser] Adopt emitWrongTokenError more, improving QoI
Wed, May 11, 12:43 PM · Restricted Project, Restricted Project
lattner closed D125355: [AsmParser] Adopt emitWrongTokenError more, improving QoI.
Wed, May 11, 12:43 PM · Restricted Project, Restricted Project
lattner added a comment to D125355: [AsmParser] Adopt emitWrongTokenError more, improving QoI.

Thx for the reviews!

Wed, May 11, 12:41 PM · Restricted Project, Restricted Project
lattner added a reviewer for D125355: [AsmParser] Adopt emitWrongTokenError more, improving QoI: bollu.

Pair programmed with @bollu

Wed, May 11, 12:53 AM · Restricted Project, Restricted Project
lattner added a reviewer for D125355: [AsmParser] Adopt emitWrongTokenError more, improving QoI: bzcheeseman.
Wed, May 11, 12:52 AM · Restricted Project, Restricted Project
lattner added a reviewer for D125353: [AsmParser] Improve error recovery again.: bzcheeseman.
Wed, May 11, 12:52 AM · Restricted Project, Restricted Project
lattner requested review of D125355: [AsmParser] Adopt emitWrongTokenError more, improving QoI.
Wed, May 11, 12:52 AM · Restricted Project, Restricted Project
lattner committed rG34b6f206cbab: [AsmParser] Improve error recovery again. (authored by lattner).
[AsmParser] Improve error recovery again.
Wed, May 11, 12:26 AM · Restricted Project, Restricted Project
lattner closed D125353: [AsmParser] Improve error recovery again..
Wed, May 11, 12:25 AM · Restricted Project, Restricted Project
lattner accepted D125353: [AsmParser] Improve error recovery again..
Wed, May 11, 12:25 AM · Restricted Project, Restricted Project
lattner requested review of D125353: [AsmParser] Improve error recovery again..
Wed, May 11, 12:25 AM · Restricted Project, Restricted Project

Tue, May 10

lattner accepted D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..

This looks good to me, the community discussion seems quiet. Feel free to land when the CI tests pass, thanks!

Tue, May 10, 11:54 PM · Restricted Project, Restricted Project
lattner committed rGad3b358180e8: [MLIR Parser] Improve QoI for "expected token" errors (authored by lattner).
[MLIR Parser] Improve QoI for "expected token" errors
Tue, May 10, 7:45 AM · Restricted Project, Restricted Project
lattner closed D125295: [MLIR Parser] Improve QoI for "expected token" errors.
Tue, May 10, 7:44 AM · Restricted Project, Restricted Project
lattner updated the diff for D125295: [MLIR Parser] Improve QoI for "expected token" errors.

Use fancy stringref trick; ignore comments in lines.

Tue, May 10, 7:43 AM · Restricted Project, Restricted Project
lattner added a reviewer for D125295: [MLIR Parser] Improve QoI for "expected token" errors: bzcheeseman.
Tue, May 10, 2:23 AM · Restricted Project, Restricted Project
lattner requested review of D125295: [MLIR Parser] Improve QoI for "expected token" errors.
Tue, May 10, 2:23 AM · Restricted Project, Restricted Project

Mon, May 9

lattner accepted D125277: [TableGen] Refactor TableGenParseFile to no longer use a callback.

nice, this is a more logical API

Mon, May 9, 11:33 PM · Restricted Project, Restricted Project, Restricted Project
lattner accepted D125276: [TableGen] Remove the use of global Record state.
Mon, May 9, 11:32 PM · Restricted Project, Restricted Project
lattner added a comment to D124791: [mlir] Refactoring dialect and test code to use parseCommaSeparatedList.

nice, congrats on your first patch!

Mon, May 9, 10:40 AM · Restricted Project, Restricted Project

Wed, May 4

lattner added a comment to D124902: Enable the use of ThreadPoolTaskGroup in MLIR threading helper to enable nested parallelism.

Cool!

Wed, May 4, 12:19 PM · Restricted Project, Restricted Project
lattner added a comment to D124649: [AsmParser] Introduce a new "Argument" abstraction + supporting logic.

I don't think it should exist in core if it only has one user. In fact, I'd like to see the AsmParser stuff significantly refactored to be more modular and orthogonal. Most of this stuff exists because we didn't have parseCommaSeparatedList which defines away the majority of the utility of these macro helpers in the first place. See e.g. this patch:
https://reviews.llvm.org/D124791

Wed, May 4, 12:07 PM · Restricted Project, Restricted Project, Restricted Project

Mon, May 2

lattner accepted D124791: [mlir] Refactoring dialect and test code to use parseCommaSeparatedList.

Nice, thank you! A couple more suggestions above.

Mon, May 2, 4:40 PM · Restricted Project, Restricted Project
lattner added inline comments to D124791: [mlir] Refactoring dialect and test code to use parseCommaSeparatedList.
Mon, May 2, 11:30 AM · Restricted Project, Restricted Project
lattner added a comment to D124649: [AsmParser] Introduce a new "Argument" abstraction + supporting logic.

Hello, why were parseOptionalAssignmentListWithTypesand parseAssignmentListWithTypes removed?

Mon, May 2, 11:09 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Apr 29

lattner removed a reviewer for D56906: Prototype of update to file headers for relicensing.: lattner.
Fri, Apr 29, 9:40 PM · Restricted Project, Restricted Project, Restricted Project
lattner committed rGd85eb4e2d62e: [AsmParser] Introduce a new "Argument" abstraction + supporting logic (authored by lattner).
[AsmParser] Introduce a new "Argument" abstraction + supporting logic
Fri, Apr 29, 12:22 PM · Restricted Project, Restricted Project, Restricted Project
lattner closed D124649: [AsmParser] Introduce a new "Argument" abstraction + supporting logic.
Fri, Apr 29, 12:22 PM · Restricted Project, Restricted Project, Restricted Project
lattner updated the diff for D124649: [AsmParser] Introduce a new "Argument" abstraction + supporting logic.

Flip the default on allowType/allowAttr

Fri, Apr 29, 9:30 AM · Restricted Project, Restricted Project, Restricted Project
lattner added a comment to D124649: [AsmParser] Introduce a new "Argument" abstraction + supporting logic.

Yep, you're right, it is also much less common to have attributes, and no one wants attributes without a type. I'll flip it, thanks for the suggestion!

Fri, Apr 29, 9:15 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Apr 28

lattner updated the diff for D124649: [AsmParser] Introduce a new "Argument" abstraction + supporting logic.

Two other minor comment changes I missed from River's review.

Thu, Apr 28, 11:06 PM · Restricted Project, Restricted Project, Restricted Project
lattner added inline comments to D124649: [AsmParser] Introduce a new "Argument" abstraction + supporting logic.
Thu, Apr 28, 11:06 PM · Restricted Project, Restricted Project, Restricted Project
lattner updated the diff for D124649: [AsmParser] Introduce a new "Argument" abstraction + supporting logic.

Incorporate improvements from River, still need to confirm sense of the bools in parseArgument

Thu, Apr 28, 10:59 PM · Restricted Project, Restricted Project, Restricted Project
lattner updated the diff for D124649: [AsmParser] Introduce a new "Argument" abstraction + supporting logic.

Update flang

Thu, Apr 28, 10:53 PM · Restricted Project, Restricted Project, Restricted Project
lattner updated the diff for D124649: [AsmParser] Introduce a new "Argument" abstraction + supporting logic.

Remove now-constant argument.

Thu, Apr 28, 5:40 PM · Restricted Project, Restricted Project, Restricted Project
lattner added a comment to D124649: [AsmParser] Introduce a new "Argument" abstraction + supporting logic.

This also fixes the source location parsing bug that @mehdi_amini mentioned a couple days ago.

Thu, Apr 28, 5:27 PM · Restricted Project, Restricted Project, Restricted Project
lattner requested review of D124649: [AsmParser] Introduce a new "Argument" abstraction + supporting logic.
Thu, Apr 28, 5:26 PM · Restricted Project, Restricted Project, Restricted Project
lattner committed rG99499c3ea7ca: [OpAsmParser] Simplify logic for requiredOperandCount in parseOperandList. (authored by lattner).
[OpAsmParser] Simplify logic for requiredOperandCount in parseOperandList.
Thu, Apr 28, 12:05 PM · Restricted Project, Restricted Project
lattner closed D124629: [OpAsmParser] Simplify logic for requiredOperandCount in parseOperandList..
Thu, Apr 28, 12:05 PM · Restricted Project, Restricted Project
lattner added a comment to D124629: [OpAsmParser] Simplify logic for requiredOperandCount in parseOperandList..

thx for the review!

Thu, Apr 28, 12:03 PM · Restricted Project, Restricted Project
lattner requested review of D124629: [OpAsmParser] Simplify logic for requiredOperandCount in parseOperandList..
Thu, Apr 28, 11:37 AM · Restricted Project, Restricted Project
lattner committed rG5dedf911deb4: [AsmParser] Rework logic around "region argument parsing" (authored by lattner).
[AsmParser] Rework logic around "region argument parsing"
Thu, Apr 28, 11:21 AM · Restricted Project, Restricted Project, Restricted Project
lattner closed D124470: [AsmParser] Rework logic around "region argument parsing".
Thu, Apr 28, 11:20 AM · Restricted Project, Restricted Project, Restricted Project
lattner added a comment to D124470: [AsmParser] Rework logic around "region argument parsing".

River and I discussed this offline, I'm going to land this and build on it. Thx!

Thu, Apr 28, 11:20 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Apr 27

lattner added a comment to D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..

Overall, this looks really great to me. Please get River's review, then (when any feedback is incorporated) ping an LLVM forum for visibility. This isn't normally needed but casting.h is very pervasive, so extra discussion is helpful.

Wed, Apr 27, 4:59 PM · Restricted Project, Restricted Project
lattner added inline comments to D124470: [AsmParser] Rework logic around "region argument parsing".
Wed, Apr 27, 12:32 PM · Restricted Project, Restricted Project, Restricted Project
lattner added inline comments to D124470: [AsmParser] Rework logic around "region argument parsing".
Wed, Apr 27, 9:12 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Apr 26

lattner accepted D123897: [X86] Unbreak LIT/FileCheck.

This seems reasonable to me

Tue, Apr 26, 4:06 PM · Restricted Project, Restricted Project
lattner updated the diff for D124470: [AsmParser] Rework logic around "region argument parsing".

Update flang

Tue, Apr 26, 12:32 PM · Restricted Project, Restricted Project, Restricted Project
lattner added inline comments to D124470: [AsmParser] Rework logic around "region argument parsing".
Tue, Apr 26, 12:30 PM · Restricted Project, Restricted Project, Restricted Project
lattner requested review of D124470: [AsmParser] Rework logic around "region argument parsing".
Tue, Apr 26, 12:03 PM · Restricted Project, Restricted Project, Restricted Project
lattner added a comment to D124188: [AsmParser/Printer] Rework sourceloc support for function arguments..

Sweet, I'll get on this in a few minutes, thx!

Tue, Apr 26, 9:28 AM · Restricted Project, Restricted Project

Mon, Apr 25

lattner added inline comments to D124188: [AsmParser/Printer] Rework sourceloc support for function arguments..
Mon, Apr 25, 10:44 PM · Restricted Project, Restricted Project
lattner added inline comments to D124188: [AsmParser/Printer] Rework sourceloc support for function arguments..
Mon, Apr 25, 9:06 PM · Restricted Project, Restricted Project

Fri, Apr 22

lattner accepted D124298: [mlir][NFC] Shift a bunch of dialect includes from the .h to the .cpp.

nice, this is super exciting!

Fri, Apr 22, 3:04 PM · Restricted Project, Restricted Project, Restricted Project
lattner accepted D124297: [mlir] Generate Dialect constructors in .cpp instead of .h.

Fantastic, thank you!

Fri, Apr 22, 3:02 PM · Restricted Project, Restricted Project
lattner accepted D124263: CODE_OWNERS: update information for builtins.

Thank you for taking this on Saleem!

Fri, Apr 22, 9:29 AM · Restricted Project, Restricted Project

Apr 21 2022

lattner committed rG31c8abc3f1cd: [AsmParser/Printer] Rework sourceloc support for function arguments. (authored by lattner).
[AsmParser/Printer] Rework sourceloc support for function arguments.
Apr 21 2022, 12:44 PM · Restricted Project, Restricted Project
lattner added a comment to D124188: [AsmParser/Printer] Rework sourceloc support for function arguments..

Thank you for the quick review!

Apr 21 2022, 12:43 PM · Restricted Project, Restricted Project
lattner closed D124188: [AsmParser/Printer] Rework sourceloc support for function arguments..
Apr 21 2022, 12:43 PM · Restricted Project, Restricted Project
lattner updated the diff for D124188: [AsmParser/Printer] Rework sourceloc support for function arguments..

Add missing blank line

Apr 21 2022, 12:43 PM · Restricted Project, Restricted Project
lattner accepted D124191: [DeveloperPolicy] Add invitation link for commit access..

Nice, thank you!

Apr 21 2022, 12:40 PM · Restricted Project, Restricted Project
lattner added a comment to D124188: [AsmParser/Printer] Rework sourceloc support for function arguments..

We discussed this in some other patch that I lost track of, this was just something on my deep todo list.

Apr 21 2022, 10:44 AM · Restricted Project, Restricted Project
lattner requested review of D124188: [AsmParser/Printer] Rework sourceloc support for function arguments..
Apr 21 2022, 10:43 AM · Restricted Project, Restricted Project

Apr 19 2022

lattner accepted D123957: Update the developer policy to mention release notes.

Nice, LGTM!

Apr 19 2022, 1:27 PM · Restricted Project, Restricted Project
lattner added a comment to D123957: Update the developer policy to mention release notes.

Also, when this lands, we should post on the forum about it. Every change to the developer policy warrants broader visibility than just a phab discussion IMO.

Apr 19 2022, 10:46 AM · Restricted Project, Restricted Project
lattner added a comment to D123957: Update the developer policy to mention release notes.

This is awesome, I agree completely we should curate release notes better. That said, I think this should make it more clear that there is a "difference in kind" between user-facing tools like clang/lldb etc and other libraries in LLVM. We don't want release note burden (or noise) for every little thing going into the optimizer or codegen. Do you think it would make sense to point out that this is about user-facing tools?

Apr 19 2022, 10:45 AM · Restricted Project, Restricted Project

Apr 18 2022

lattner accepted D123915: Print custom assembly on pass failure by default.

nice! Very excited this "just works" instead of being another knob for experts

Apr 18 2022, 11:07 AM · Restricted Project, Restricted Project