Page MenuHomePhabricator

lattner (Chris Lattner)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2016, 7:50 PM (220 w, 5 d)

Recent Activity

Today

lattner accepted D87967: TableGen: Change comments about superclass order.

Feel free to directly make comment changes that you think are obvious :)

Sun, Sep 20, 4:24 PM · Restricted Project

Fri, Sep 18

lattner accepted D87919: Clarify name of Record::TheInit.

Please fix the clang format issues, but otherwise LGTM!

Fri, Sep 18, 5:29 PM · Restricted Project

Tue, Sep 15

lattner accepted D87711: Add section on DAGs to TableGen Programmer's Reference.

Very nice!

Tue, Sep 15, 6:06 PM · Restricted Project

Sat, Sep 12

lattner added a comment to D87393: Enhance TableGen error message capabilities.

This patch looks generally good to me (but please fix the clang format issues if you can), but this is detailed enough that it would be best to find another reviewer to give you a full tech review, as I haven't been in this code for (too) many years :)

Sat, Sep 12, 10:56 AM · Restricted Project
lattner resigned from D87564: [VPlan] Add vplan native path vectorization test case for inner loop reduction.

Great idea! However, I think it would be better to get feedback from other folks who are actively contributing to the loop optimizer. Thank you for pushing on this!

Sat, Sep 12, 10:52 AM · Restricted Project
lattner accepted D87513: Update TableGen test files.

Nice. For "obvious" patches like this, feel free to commit after a day or two without feedback. The notion of what is "obvious" should be conservative, but documentation and other simple patches like this are good candidates. Thank you for working on this!

Sat, Sep 12, 10:00 AM · Restricted Project
lattner accepted D87560: Clarify two data member names.

nice

Sat, Sep 12, 9:11 AM · Restricted Project

Thu, Sep 10

lattner resigned from D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Thank you for working on this! I don't have cycles for a detailed review of the patch, but I'm thrilled to see this footgun get fixed.

Thu, Sep 10, 2:49 PM · Restricted Project

Tue, Sep 8

lattner accepted D86851: Minor changes to new TableGen Programmer's Reference document.

Thanks for tidying this up and making it more consistent!

Tue, Sep 8, 11:09 AM · Restricted Project
lattner added a comment to D86739: [mlir][ODS] Use c++ types for integer attributes of fixed width when possible..

Very nice, thank you again for implementing this!

Tue, Sep 8, 10:27 AM · Restricted Project
lattner accepted D87038: SearchableTables reference section.

Thank you for writing this!

Tue, Sep 8, 10:20 AM · Restricted Project

Thu, Sep 3

lattner added a comment to D86997: [APFloat] Fix uninitialized variable in IEEEFloat constructors.

LGTM, thanks for doing this.

Thu, Sep 3, 10:01 AM · Restricted Project

Wed, Sep 2

lattner accepted D86997: [APFloat] Fix uninitialized variable in IEEEFloat constructors.

This patch LGTM. I think that conservatively init the members is a good idea.

Wed, Sep 2, 11:49 AM · Restricted Project

Tue, Aug 25

lattner resigned from D86505: [RFC][Target] Add a new triple called Triple::csky.
Tue, Aug 25, 6:28 PM · Restricted Project

Aug 18 2020

lattner accepted D85585: Replace TableGen range piece punctuator with '..'.

nice! thank you

Aug 18 2020, 9:07 AM · Restricted Project

Aug 16 2020

lattner accepted D86030: Add missing parsing for attributes to std.generic_atomic_rmw op.

that was speedy, thanks!

Aug 16 2020, 3:07 PM · Restricted Project

Aug 15 2020

lattner added a comment to D85585: Replace TableGen range piece punctuator with '..'.

Makes sense - in a follow-on patch, it would be great to fix those up too, thanks!

Aug 15 2020, 1:58 PM · Restricted Project
lattner requested changes to D85585: Replace TableGen range piece punctuator with '..'.

This looks good to me, but please change this to "..." instead of "..". Also, in the documentation, please mention that this is an *inclusive* range. Thank you for working on this!

Aug 15 2020, 1:40 PM · Restricted Project

Aug 14 2020

lattner added a comment to D85838: New TableGen Programmer's Reference document.

Hi Paul,

Aug 14 2020, 5:36 PM · Restricted Project

Aug 13 2020

lattner added a comment to D85838: New TableGen Programmer's Reference document.

Yep, as long as you're committed to doing it, I'm perfectly fine with doing that in a followup patch. You might want to land this at one of the old URLs to make that easier though.

Aug 13 2020, 6:53 PM · Restricted Project
lattner accepted D85838: New TableGen Programmer's Reference document.

This is really fantastic work, thank you for doing this!

Aug 13 2020, 4:27 PM · Restricted Project

Aug 11 2020

lattner added a comment to D84719: [mlir][OpFormatGen] Add support for specifiy "custom" directives..

Just saw this in the weekly newsletter - this is really really really cool, nice work!

Aug 11 2020, 1:31 PM · Restricted Project

Aug 9 2020

lattner accepted D85159: [ConstProp] Remove ConstantPropagation.

nice, thanks for cleaning this up!

Aug 9 2020, 11:10 PM · Restricted Project
lattner resigned from D85464: [MLIR] [CMake] Support building MLIR standalone.
Aug 9 2020, 9:03 PM · Restricted Project

Aug 7 2020

lattner resigned from D82081: [z/OS] Add binary format goff and operating system zos to the triple.
Aug 7 2020, 9:13 AM · Restricted Project, Restricted Project

Aug 4 2020

lattner accepted D83372: Fix for memory leak reported by Valgrind.

Looks good, thanks!

Aug 4 2020, 9:17 AM · Restricted Project

Aug 3 2020

lattner added a comment to D83310: [mlir] Initial version of C APIs.

Yeah makes sense. One file per library should work fairly well in practice I think, given how .a files work. The only downside of this that I see is that the build for unit tests and other things in-tree that depend on the C API will be bottlenecked on building everything - this could add to the critical path of the build.

Aug 3 2020, 10:46 AM · Restricted Project
lattner accepted D83310: [mlir] Initial version of C APIs.

This looks really fantastic Alex, you really nailed the details on this! The docs look great, the choice of intptr_t is great, the naming structure and consistency is A+. Thank you!

Aug 3 2020, 9:51 AM · Restricted Project

Aug 2 2020

lattner accepted D83834: Add test utility 'split-file'.

Thank you for renaming this!

Aug 2 2020, 12:47 PM · Restricted Project

Jul 30 2020

lattner edited reviewers for D84835: [APFloat] Fix incorrect fptrunc rouning when from semantics exp lower than minimal exp of target semantics, added: scanon; removed: lattner.
Jul 30 2020, 12:27 PM · Restricted Project

Jul 28 2020

lattner added a comment to D83834: Add test utility 'split-file'.

Thank you Fangrui!

Jul 28 2020, 1:31 PM · Restricted Project
lattner added a comment to D83834: Add test utility 'split-file'.

Hi All,

Jul 28 2020, 12:55 PM · Restricted Project
lattner resigned from D84717: [ADT][BitVector][NFC] Merge find_first_in() / find_first_unset_in().
Jul 28 2020, 9:45 AM · Restricted Project

Jul 26 2020

lattner resigned from D84606: [llvm-readelf] Symbol index in symbol table printing is not reset.

Wow, yeah, static variables are wildly inappopriate for that. That said, I'm not familiar with the code, so someone else should review.

Jul 26 2020, 2:13 PM · Restricted Project

Jul 24 2020

lattner added a comment to D83372: Fix for memory leak reported by Valgrind.

Ok, then please set the pointer to null - that will cause things to explode if someone tries to use things after llvm_shutdown. Thanks!

Jul 24 2020, 10:44 AM · Restricted Project
lattner added a comment to D83834: Add test utility 'split-file'.

I'm not sure how googles test runner works or how it differs. I recall many historical examples (in clang in particular), but it is possible they all got changed.

Jul 24 2020, 9:53 AM · Restricted Project
lattner added a comment to D83834: Add test utility 'split-file'.

I don't see any reason to prefer a short name here, this isn't a simple too like 'opt' it takes command line flags etc.

Jul 24 2020, 8:59 AM · Restricted Project
lattner added a comment to D83834: Add test utility 'split-file'.

Also, it is worth pointing out that we already have an (arguably much better) way to handle the problem you're trying to solve here:

Jul 24 2020, 8:44 AM · Restricted Project
lattner added a comment to D83834: Add test utility 'split-file'.

Ok fair enough. I'd recommend a name like llvm-split-file or something like that given that we already have an llvm-extract tool that is very different.

Jul 24 2020, 8:41 AM · Restricted Project
lattner added a comment to D83372: Fix for memory leak reported by Valgrind.

Some thoughts:

Jul 24 2020, 8:39 AM · Restricted Project
lattner added a comment to D83834: Add test utility 'split-file'.

Instead of adding an explicit command 'extract', did you consider building this into llvm-mc and similar tools? This is will lead to more efficient tests and scales better to things that have diagnostic verification and other sorts of checks. This is also more consistent with the precedent MLIR has set here.

Jul 24 2020, 8:30 AM · Restricted Project

Jul 20 2020

lattner resigned from D84181: [GVN] Rewrite IsValueFullyAvailableInBlock().
Jul 20 2020, 10:02 PM · Restricted Project

Jul 15 2020

lattner accepted D83816: Document the -analyze opt flag in the LLVM testing guide (NFC).
Jul 15 2020, 1:24 PM · Restricted Project
lattner resigned from D83855: [clang] Fix printing of lambdas with capture expressions.
Jul 15 2020, 8:56 AM · Restricted Project

Jul 14 2020

lattner accepted D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC).

This looks great to me, thanks!

Jul 14 2020, 4:03 PM · Restricted Project

Jul 13 2020

lattner accepted D83709: [NFC] Add 'override' keyword where missing in include/ and lib/..

Thanks

Jul 13 2020, 12:47 PM · Restricted Project

Jul 10 2020

lattner resigned from D81728: [InstCombine] Add target-specific inst combining.

Please don't consider me a blocker on this patch, thank you for pushing on it!

Jul 10 2020, 3:33 PM · Restricted Project, Restricted Project, Restricted Project

Jul 8 2020

lattner accepted D83416: [NFC] Fix some docs warnings.

Thanks!

Jul 8 2020, 1:29 PM · Restricted Project
lattner added a comment to D83372: Fix for memory leak reported by Valgrind.

Does this add a static constructor?

Jul 8 2020, 11:02 AM · Restricted Project

Jul 7 2020

lattner committed rG79b30af0ec53: Expand the LLVM Developer Policy to include new sections on adding a project to… (authored by lattner).
Expand the LLVM Developer Policy to include new sections on adding a project to…
Jul 7 2020, 10:30 AM
lattner closed D83182: Expand the LLVM Developer Policy to include new sections on adding a project to the LLVM Monorepo, and a second about the LLVM Incubator projects..
Jul 7 2020, 10:30 AM · Restricted Project
lattner edited reviewers for D83321: [Support] Fix utf16 path's index upper bound, added: compnerd; removed: lattner.
Jul 7 2020, 9:44 AM · Restricted Project

Jul 6 2020

lattner added a comment to D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC).

int is a clearly inferior choice

It isn't clear to me, as I mention in my previous comment, I'd be happy to get more educated on this if you have resources you could point me to that would explain your point?

Jul 6 2020, 6:02 PM · Restricted Project
lattner added a comment to D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC).

I'm not sure what the contention here is. int is a clearly inferior choice and is just as unprincipled as unsigned is, we should use the correct type.

I get the sense that you're arguing for ssize_t or one of its analogues instead of size_t? Are you arguing for general principles or this specific case? In this specific case, using size_t seems completely reasonable, but I agree that ssize_t would also be fine.

I'm ok with either size_t or ssize_t here, but if you want to turn this into a general principle that we apply to the code base, then it should be discussed on llvm-dev first.

ssize_t is inferior. POSIX.1-2017 says "The type ssize_t shall be capable of storing values at least in the range [-1, {SSIZE_MAX}]." The implementation may not even support -2.

We could also use intptr_t to avoid sign extension on a 64-bit machine.

Jul 6 2020, 6:00 PM · Restricted Project

Jul 5 2020

lattner added a comment to D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC).

I'm not sure what the contention here is. int is a clearly inferior choice and is just as unprincipled as unsigned is, we should use the correct type.

Jul 5 2020, 2:56 PM · Restricted Project
lattner added a comment to D83182: Expand the LLVM Developer Policy to include new sections on adding a project to the LLVM Monorepo, and a second about the LLVM Incubator projects..

Thank you for the feedback Stephen!

Jul 5 2020, 2:56 PM · Restricted Project
lattner updated the diff for D83182: Expand the LLVM Developer Policy to include new sections on adding a project to the LLVM Monorepo, and a second about the LLVM Incubator projects..

Changes suggested by Stephen Neuendorffer

Jul 5 2020, 2:56 PM · Restricted Project
lattner added a comment to D83182: Expand the LLVM Developer Policy to include new sections on adding a project to the LLVM Monorepo, and a second about the LLVM Incubator projects..

Thanks! I'm going to let this simmer for a few days to give folks in the community time to react / improve.

Jul 5 2020, 2:24 PM · Restricted Project
lattner created D83182: Expand the LLVM Developer Policy to include new sections on adding a project to the LLVM Monorepo, and a second about the LLVM Incubator projects..
Jul 5 2020, 1:52 PM · Restricted Project
lattner added reviewers for D83182: Expand the LLVM Developer Policy to include new sections on adding a project to the LLVM Monorepo, and a second about the LLVM Incubator projects.: stellaraccident, stephenneuendorffer.

This is the Google doc translated to RST format.

Jul 5 2020, 1:52 PM · Restricted Project

Jul 2 2020

lattner added inline comments to D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC).
Jul 2 2020, 9:35 PM · Restricted Project

Jul 1 2020

lattner added inline comments to D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC).
Jul 1 2020, 10:11 PM · Restricted Project

Jun 30 2020

lattner requested changes to D81728: [InstCombine] Add target-specific inst combining.

This looks like a great direction, but please make sure to minimize public implementation details. We don't want the vast majority of instcombine to be visible outside of its library (it is hairy enough as it is :-)

Jun 30 2020, 1:35 PM · Restricted Project, Restricted Project, Restricted Project

Jun 28 2020

lattner added a comment to D82203: [FileCheck] Implement -dump-input-context.

Ok, but instead of allowing "fine grained control", why not allow a "tasteful default" and "all" option? The "all" option seems perfectly reasonable for the weird case, and eliminates a big configuration matrix. This would just entail turning the command line option into a magic number / enum.

Jun 28 2020, 12:23 PM · Restricted Project
lattner added a comment to D82203: [FileCheck] Implement -dump-input-context.

High level question - do we need additional command line flags here? Why not build this into the default actions that FileCheck takes? These detailed flags are unlikely to be used by people in practice, and this expands the surface area of FileCheck that needs to be maintained - it also expands the testing surface of FileCheck itself.

Jun 28 2020, 9:12 AM · Restricted Project
lattner added a comment to D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC).

This is looking directionally great, please ping me after hubert.reinterpretcast's comments are reviewed and resolved. Thanks!

Jun 28 2020, 8:39 AM · Restricted Project

Jun 20 2020

lattner added a comment to D82259: Deprecate error prone temporary directory APIs.

Hi Dave,

Jun 20 2020, 2:18 PM · Restricted Project, Restricted Project, Restricted Project

Jun 19 2020

lattner edited reviewers for D78867: [docs] avoid 'arc land' command, added: klimek; removed: lattner.
Jun 19 2020, 3:46 PM · Restricted Project
lattner updated subscribers of D78867: [docs] avoid 'arc land' command.

I'd recommend running this by @klimek

Jun 19 2020, 3:46 PM · Restricted Project
lattner accepted D82200: [ADT] Fix itostr handling of min int64_t value.

nice catch, thanks

Jun 19 2020, 9:12 AM · Restricted Project

Jun 18 2020

lattner resigned from D81236: Improve LegacyPassManager API to correctly report modified status.
Jun 18 2020, 9:48 PM · Restricted Project

Jun 17 2020

lattner accepted D82001: [llvm] [CommandLine] Do not suggest really hidden opts in nearest lookup.

Makes sense, thanks!

Jun 17 2020, 9:08 AM · Restricted Project

Jun 15 2020

lattner added a comment to rGc08ea0771682: Add to the Coding Standard our that single-line bodies omit braces.

No worries, thanks Erich!

Jun 15 2020, 5:08 PM
lattner added inline comments to rGc08ea0771682: Add to the Coding Standard our that single-line bodies omit braces.
Jun 15 2020, 3:29 PM

Jun 5 2020

lattner accepted D81302: Fix convertBFloatAPFloatToAPInt for NaN/Inf values.

nice catch

Jun 5 2020, 2:03 PM · Restricted Project

Jun 3 2020

lattner resigned from D80844: [TRE] Allow accumulator elimination when base case returns non-constant.
Jun 3 2020, 12:05 PM · Restricted Project

May 31 2020

lattner committed rG0cf5ef176b52: Change some extraneous /// comments to // comments inside methods. NFC. (authored by lattner).
Change some extraneous /// comments to // comments inside methods. NFC.
May 31 2020, 11:58 AM

May 28 2020

lattner accepted D80707: [legacyPM] Do not compute preserved analysis if there's no local change.

LGTM, but I'd appreciate comments from at least one other reviewer. Thanks!

May 28 2020, 2:52 PM · Restricted Project

May 22 2020

lattner resigned from D80433: [clang-tblgen][CommandLine][ManagedStatic] Fix build errors with clang-tblgen in Debug mode using MSVC 2019 v16.6.
May 22 2020, 9:38 AM · Restricted Project, Restricted Project

May 21 2020

lattner accepted D80358: [MLIR] Add RegionKindInterface.

Please fix the lint warnings, but otherwise this LGTM as a step. Thank you for driving this!

May 21 2020, 3:11 PM · Restricted Project, Restricted Project

May 19 2020

lattner accepted D80141: [IR] Simplify BasicBlock::removePredecessor. NFCI..

Very nice! Thank you for dusting off this old code

May 19 2020, 9:16 AM · Restricted Project

May 18 2020

lattner resigned from D79140: [ThinLTO] return error instead of crashing on invalid input.
May 18 2020, 9:08 PM · Restricted Project
lattner accepted D80128: [IR] Revert r2694 in BasicBlock::removePredecessor.

Thank you for cleaning this up!

May 18 2020, 10:48 AM · Restricted Project

May 14 2020

lattner accepted D79922: [MLIR] Allow unreachable blocks to violate dominance property..

This looks great, thank you!

May 14 2020, 3:14 PM · Restricted Project

May 7 2020

lattner added a comment to D79528: [ConstantFold] Optimize xor undef, undef to undef.

I agree, even though this is technically correct, the risk/reward isn't worth it. LLVM used to do this pervasively, but we switched to producing zero out of practical concerns.

May 7 2020, 8:29 AM · Restricted Project

May 6 2020

lattner accepted D79503: [MLIR][NFC] Rename op trait PolyhedralScope -> AffineScope.

Awesome, thank you for changing this, I appreciate it!

May 6 2020, 10:46 AM · Restricted Project

May 4 2020

lattner added a comment to D79060: [MLIR] Introduce op trait PolyhedralScope (revised).

Would it make sense to call this "AffineScope". I don't believe we use the word "Polyhedral" anywhere. This was intentional because of the many preexisting notions of what "Polyhedral" means, but in any case we should be consistent.

May 4 2020, 11:48 AM · Restricted Project

May 2 2020

lattner added a comment to D79266: [mlir] Add a new context flag for disabling/enabling multi-threading.

Very nice River! I incorporated this into my stuff and it sped up the parser by 18%!

May 2 2020, 5:29 PM · Restricted Project
lattner accepted D79266: [mlir] Add a new context flag for disabling/enabling multi-threading.

Awesome, thank you for tackling this River, I added some suggestions above.

May 2 2020, 10:03 AM · Restricted Project

Apr 25 2020

lattner committed rG919dcc7f6858: [SourceMgr] Tidy up the SourceMgr header file to include less stuff. (authored by lattner).
[SourceMgr] Tidy up the SourceMgr header file to include less stuff.
Apr 25 2020, 9:46 PM
lattner closed D78870: [SourceMgr] Tidy up the SourceMgr header file to include less stuff..
Apr 25 2020, 9:46 PM · Restricted Project, Restricted Project
lattner updated the diff for D78870: [SourceMgr] Tidy up the SourceMgr header file to include less stuff..

Clang depended on the transitive include, update it!

Apr 25 2020, 5:32 PM · Restricted Project, Restricted Project
lattner created D78870: [SourceMgr] Tidy up the SourceMgr header file to include less stuff..
Apr 25 2020, 2:51 PM · Restricted Project, Restricted Project
lattner committed rG969e7edd88ce: [SourceMgr/MLIR diagnostics] Introduce a new method to speed things up (authored by lattner).
[SourceMgr/MLIR diagnostics] Introduce a new method to speed things up
Apr 25 2020, 2:20 PM
lattner closed D78868: [SourceMgr/MLIR diagnostics] Introduce a new method to speed things up.
Apr 25 2020, 2:20 PM · Restricted Project
lattner added a comment to D78868: [SourceMgr/MLIR diagnostics] Introduce a new method to speed things up.

Thank you for the review River!

Apr 25 2020, 2:20 PM · Restricted Project
lattner created D78868: [SourceMgr/MLIR diagnostics] Introduce a new method to speed things up.
Apr 25 2020, 12:12 PM · Restricted Project

Apr 23 2020

lattner added a comment to D78676: llvm: IPO: handle IRMover error handling, bug #45636.

You can request commit access for yourself, just read the llvm developer policy for more info.

Apr 23 2020, 9:11 AM · Restricted Project

Apr 22 2020

lattner accepted D78676: llvm: IPO: handle IRMover error handling, bug #45636.

thanks!

Apr 22 2020, 3:48 PM · Restricted Project

Apr 16 2020

lattner committed rG953a814aae49: Remove the llvm/Support/StringPool.h file and related support now that it has… (authored by lattner).
Remove the llvm/Support/StringPool.h file and related support now that it has…
Apr 16 2020, 6:24 PM