Page MenuHomePhabricator

pmatos (Paulo Matos)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 28 2016, 2:19 AM (208 w, 13 h)

Recent Activity

Today

pmatos added a comment to D89797: [WebAssembly] Implementation of (most) table instructions.

@sbc100 if it's ok for you, feel free to merge, thanks.

Fri, Oct 23, 1:31 AM · Restricted Project
pmatos updated the diff for D89797: [WebAssembly] Implementation of (most) table instructions.

Align with local indent style

Fri, Oct 23, 1:30 AM · Restricted Project

Yesterday

pmatos added inline comments to D89797: [WebAssembly] Implementation of (most) table instructions.
Thu, Oct 22, 11:09 PM · Restricted Project
pmatos updated the diff for D89797: [WebAssembly] Implementation of (most) table instructions.

Remove unused operand type.

Thu, Oct 22, 3:31 AM · Restricted Project
pmatos added a comment to D89797: [WebAssembly] Implementation of (most) table instructions.

Is this good to merge?

Thu, Oct 22, 1:29 AM · Restricted Project

Wed, Oct 21

pmatos added inline comments to D89797: [WebAssembly] Implementation of (most) table instructions.
Wed, Oct 21, 9:36 AM · Restricted Project
pmatos added a comment to D89797: [WebAssembly] Implementation of (most) table instructions.

Regarding linter clang-format suggestions - should I reformat the code as suggested or leave it?
Some suggested changes are not necessarily on code I wrote, which is why I ask.

Wed, Oct 21, 8:10 AM · Restricted Project
pmatos updated the diff for D89797: [WebAssembly] Implementation of (most) table instructions.

These changes reflect the first set of comments. High on the list is quite a few changes related to setting registers for funcrefs and externrefs. A few things might not be strictly necessary but pave the way for future work.

Wed, Oct 21, 6:28 AM · Restricted Project
pmatos added a comment to D89797: [WebAssembly] Implementation of (most) table instructions.

Thanks for the review - I will submit a new revision.

Wed, Oct 21, 6:10 AM · Restricted Project

Tue, Oct 20

pmatos added a comment to D89797: [WebAssembly] Implementation of (most) table instructions.

So the goal here is to add most of the table instructions. This introduces some table relocations, which (in a following patch) we will resolve in the linker.

Tue, Oct 20, 8:32 AM · Restricted Project
pmatos requested review of D89797: [WebAssembly] Implementation of (most) table instructions.
Tue, Oct 20, 8:25 AM · Restricted Project

Tue, Oct 13

pmatos retitled D88815: [WebAssembly] Added .tabletype to asm and multiple table support in obj files from Added .tabletype to asm and multiple table support in obj files to [WebAssembly] Added .tabletype to asm and multiple table support in obj files.
Tue, Oct 13, 7:45 AM · Restricted Project
pmatos updated the diff for D88815: [WebAssembly] Added .tabletype to asm and multiple table support in obj files.

Further test fixes - missing index

Tue, Oct 13, 3:16 AM · Restricted Project
pmatos added a comment to D88815: [WebAssembly] Added .tabletype to asm and multiple table support in obj files.

I seeing:

llvm-project/llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:111:11: warning: enumeration value 'FUNCREF' not handled in switch [-Wswitch]
  switch (VT) {

Oh, I was not getting that. It seems to come from https://github.com/llvm/llvm-project/commit/3bba91f64eef15956f589fa446c265a714cc7893 and I hadn't pulled that in yet. If I rebase my patch on this then yes, I can see the warning. i will fix it in this patch. No worries.

Tue, Oct 13, 2:31 AM · Restricted Project
pmatos updated the diff for D88815: [WebAssembly] Added .tabletype to asm and multiple table support in obj files.

Fix warning due to missing FUNCREF in switch

Tue, Oct 13, 1:35 AM · Restricted Project

Mon, Oct 12

pmatos added a comment to D88815: [WebAssembly] Added .tabletype to asm and multiple table support in obj files.

I seeing:

llvm-project/llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:111:11: warning: enumeration value 'FUNCREF' not handled in switch [-Wswitch]
  switch (VT) {
Mon, Oct 12, 11:30 PM · Restricted Project
pmatos updated the diff for D88815: [WebAssembly] Added .tabletype to asm and multiple table support in obj files.

Fix a bunch more lld tests to include index for tables

Mon, Oct 12, 9:48 PM · Restricted Project
pmatos added a comment to D88815: [WebAssembly] Added .tabletype to asm and multiple table support in obj files.

Is this ready to land now?

Mon, Oct 12, 1:30 PM · Restricted Project
pmatos updated the diff for D88815: [WebAssembly] Added .tabletype to asm and multiple table support in obj files.

Fix tests to include table index in expected dump

Mon, Oct 12, 1:28 PM · Restricted Project
pmatos updated the diff for D88815: [WebAssembly] Added .tabletype to asm and multiple table support in obj files.

Fix build failure

Mon, Oct 12, 11:05 AM · Restricted Project
pmatos added inline comments to D88815: [WebAssembly] Added .tabletype to asm and multiple table support in obj files.
Mon, Oct 12, 10:37 AM · Restricted Project
pmatos updated the diff for D88815: [WebAssembly] Added .tabletype to asm and multiple table support in obj files.

Move Index to first position in WasmTable struct

Mon, Oct 12, 10:35 AM · Restricted Project
pmatos updated the diff for D88815: [WebAssembly] Added .tabletype to asm and multiple table support in obj files.

Fix review nits

Mon, Oct 12, 8:24 AM · Restricted Project
pmatos added inline comments to D88815: [WebAssembly] Added .tabletype to asm and multiple table support in obj files.
Mon, Oct 12, 7:40 AM · Restricted Project

Fri, Oct 9

pmatos added a comment to D88815: [WebAssembly] Added .tabletype to asm and multiple table support in obj files.

Thanks for the reviews. I will fix the nits mentioned and update the revision.

Fri, Oct 9, 3:39 AM · Restricted Project

Mon, Oct 5

pmatos requested review of D88815: [WebAssembly] Added .tabletype to asm and multiple table support in obj files.
Mon, Oct 5, 3:01 AM · Restricted Project

Thu, Sep 24

pmatos abandoned D88226: Add debug option to wasm-ld to enable LLVM style debug info.

This is already supported like via -mllvm. E.g. wasm-ld -mllvm -debug or wasm-ld -mllvm -debug-only=lld

Thu, Sep 24, 9:03 PM · Restricted Project
pmatos added reviewers for D88226: Add debug option to wasm-ld to enable LLVM style debug info: sbc100, tlively.
Thu, Sep 24, 6:47 AM · Restricted Project
pmatos requested review of D88226: Add debug option to wasm-ld to enable LLVM style debug info.
Thu, Sep 24, 6:43 AM · Restricted Project

Aug 5 2020

pmatos abandoned D66035: [WebAssembly] WIP: Add support for reference types.
Aug 5 2020, 3:40 AM · Restricted Project, Restricted Project

Jul 31 2020

pmatos updated the diff for D66035: [WebAssembly] WIP: Add support for reference types.

Update externref patch

Jul 31 2020, 5:04 AM · Restricted Project, Restricted Project
pmatos abandoned D85022: Need to ensure the datalayout differs when using externref.

Mistakingly created - this should have gone to D66035

Jul 31 2020, 4:45 AM · Restricted Project
pmatos requested review of D85022: Need to ensure the datalayout differs when using externref.
Jul 31 2020, 4:43 AM · Restricted Project
pmatos added a comment to D66035: [WebAssembly] WIP: Add support for reference types.

I will be splitting the part enabling the target feature through clang into a separate revision as suggested by @tlively

Jul 31 2020, 3:18 AM · Restricted Project, Restricted Project

Jul 29 2020

pmatos added a comment to D66035: [WebAssembly] WIP: Add support for reference types.

I will be splitting the part enabling the target feature through clang into a separate revision as suggested by @tlively

Jul 29 2020, 6:43 AM · Restricted Project, Restricted Project
pmatos updated the diff for D66035: [WebAssembly] WIP: Add support for reference types.

Update patch to compile against current master branch

Jul 29 2020, 5:47 AM · Restricted Project, Restricted Project

Jul 28 2020

pmatos added a reviewer for D66035: [WebAssembly] WIP: Add support for reference types: sbc100.
Jul 28 2020, 6:18 AM · Restricted Project, Restricted Project
pmatos added a comment to D66035: [WebAssembly] WIP: Add support for reference types.

Related work: https://reviews.llvm.org/D81977

Jul 28 2020, 6:17 AM · Restricted Project, Restricted Project
pmatos added a comment to D66035: [WebAssembly] WIP: Add support for reference types.

There's also this line of work on opaque types that could be potentially interested but seems far from being landed: https://groups.google.com/g/llvm-dev/c/Dw_DYSXGFto/m/OzzK-CkGAwAJ

Jul 28 2020, 3:09 AM · Restricted Project, Restricted Project
pmatos added a comment to D66035: [WebAssembly] WIP: Add support for reference types.

Please ignore my .gitlab-ci.yml. That's just an internal change that I got uploaded by mistake.
I am looking to see this through and start discussion on this with the goal of landing it.

Jul 28 2020, 2:54 AM · Restricted Project, Restricted Project
pmatos updated the diff for D66035: [WebAssembly] WIP: Add support for reference types.

Initial implementation of reference types in the WebAssembly backend

Jul 28 2020, 2:29 AM · Restricted Project, Restricted Project
pmatos commandeered D66035: [WebAssembly] WIP: Add support for reference types.
Jul 28 2020, 2:27 AM · Restricted Project, Restricted Project

Jul 27 2020

pmatos added a comment to D66035: [WebAssembly] WIP: Add support for reference types.

I am interested in continuing this work and have a patch in progress based on the current available one here. Should I post the new patch here or under a new bug?

Feel free to commandeer this revision

Jul 27 2020, 7:38 AM · Restricted Project, Restricted Project
pmatos added a comment to D66035: [WebAssembly] WIP: Add support for reference types.

I am interested in continuing this work and have a patch in progress based on the current available one here. Should I post the new patch here or under a new bug?

Jul 27 2020, 7:13 AM · Restricted Project, Restricted Project

Jul 10 2020

Herald added a reviewer for D62962: Clang implementation of sizeless types: aaron.ballman.
Jul 10 2020, 2:35 AM · Restricted Project

Oct 19 2017

pmatos added a comment to D37625: [DWARF] Incorrect prologue end line record..

Was this ever fixed and reapplied? The last I can find on this was r313057 where @rob.lougher reverted r313047.

Oct 19 2017, 2:44 AM
pmatos added a comment to D26256: [InstCombine] Don't set debug location when folding through a phi node.

I should point out that r289661, which is part of the 8 patches, does not show up in the review commit list.

Oct 19 2017, 1:36 AM

Mar 16 2017

pmatos updated the diff for D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo.
Mar 16 2017, 2:51 AM

Mar 14 2017

pmatos updated the diff for D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo.

Added missing testcase to previous patch.

Mar 14 2017, 2:01 AM
pmatos updated the diff for D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo.

@efriedma I have uploaded a new patch taking your comments into consideration and rebased on most recent clang sources.

Mar 14 2017, 1:58 AM
pmatos added inline comments to D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo.
Mar 14 2017, 1:55 AM
pmatos added a comment to D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo.

Thanks for the comments.

Mar 14 2017, 1:54 AM

Mar 13 2017

pmatos added a comment to D26079: Do not use CppHashInfo if reporting an error after asm file parsed.

Apologies for leaving this for so long. Are there any further comments?
How do we get this upstream given I don't have commit rights?

Mar 13 2017, 9:10 AM

Jan 22 2017

pmatos updated the diff for D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo.

Here's an updated patch including the test. Hope this is now ok for submission. Please accept my apologies with regards to the delay in submitting this.

Jan 22 2017, 11:32 PM

Jan 13 2017

pmatos added a comment to D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo.

Ah no, my mistake. I had the patch applied when I ran the test.

Jan 13 2017, 9:30 AM
pmatos added a comment to D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo.

Has this been fixed upstream already?

Jan 13 2017, 8:26 AM

Jan 10 2017

pmatos added a comment to D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo.

Apologies for the delay over the holiday season, I will look into this later on after office hours.

Jan 10 2017, 12:01 AM

Dec 15 2016

pmatos added a comment to D26079: Do not use CppHashInfo if reporting an error after asm file parsed.

Can someone please take a look at this one?

Dec 15 2016, 1:34 AM
pmatos closed D26843: Make sizeof expression context partially evaluated.

This is not supposed to be marked as accepted.

Dec 15 2016, 1:34 AM
pmatos accepted D26843: Make sizeof expression context partially evaluated.

Abandoning this revision.

Dec 15 2016, 1:32 AM
pmatos added a comment to D26843: Make sizeof expression context partially evaluated.

Please refer to the new one: https://reviews.llvm.org/D27800

Dec 15 2016, 1:31 AM
pmatos added a comment to D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo.

@efriedma Here's the new patch, thanks for your help getting here.

Dec 15 2016, 1:31 AM
pmatos retitled D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo from to Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo.
Dec 15 2016, 1:31 AM

Dec 9 2016

pmatos updated subscribers of D26843: Make sizeof expression context partially evaluated.

OK, with a lot of help from @eli.friedman I have now a fix. Shall I reuse this review by submitting a new diff or open a new one?

Dec 9 2016, 6:43 AM

Nov 18 2016

pmatos added a comment to D26843: Make sizeof expression context partially evaluated.

Apologies if I am being shallow and wasting your time but sizeof(T::m) doesn't compile at the moment with clang trunk. Using the same service you used before.

Nov 18 2016, 11:22 AM
pmatos added a comment to D26843: Make sizeof expression context partially evaluated.

But that is not valid in C afaik and in C++ I get:

error: invalid use of non-static data member 'm'
  int x = sizeof(T::m);
                 ~~~^

Can you post a full reproducible example of what the change breaks?

That is a full reproducible example because it's valid C++. Clang currently compiles it.

Nov 18 2016, 7:36 AM
pmatos added a comment to D26843: Make sizeof expression context partially evaluated.

This isn't correct. For example this change breaks:

struct T { int m; };
int x = sizeof(T::m);
Nov 18 2016, 5:44 AM
pmatos retitled D26843: Make sizeof expression context partially evaluated from to Make sizeof expression context partially evaluated.
Nov 18 2016, 1:50 AM

Oct 28 2016

pmatos added a comment to D26079: Do not use CppHashInfo if reporting an error after asm file parsed.

To the reviewers:
I believe there's a better way to handle this. However, I would like to know if this approach is a good one or the reviewers find that there's a much better way to do this and I took it in the wrong direction.

Oct 28 2016, 8:42 AM
pmatos retitled D26079: Do not use CppHashInfo if reporting an error after asm file parsed from to Do not use CppHashInfo if reporting an error after asm file parsed.
Oct 28 2016, 8:37 AM