Page MenuHomePhabricator

pmatos (Paulo Matos)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 28 2016, 2:19 AM (296 w, 8 h)

Recent Activity

Thu, Jun 23

pmatos updated the diff for D128440: [WebAssembly] Initial support for reference type funcref in clang.

Remove conflict marker

Thu, Jun 23, 7:10 AM · Restricted Project, Restricted Project, Restricted Project
pmatos planned changes to D128440: [WebAssembly] Initial support for reference type funcref in clang.

Draft patch as some tests still fail.

Thu, Jun 23, 6:49 AM · Restricted Project, Restricted Project, Restricted Project
pmatos requested review of D128440: [WebAssembly] Initial support for reference type funcref in clang.
Thu, Jun 23, 6:49 AM · Restricted Project, Restricted Project, Restricted Project
pmatos committed rG0fdfeb0847df: [WebAssembly] Update test to run it in opaque pointers mode (authored by pmatos).
[WebAssembly] Update test to run it in opaque pointers mode
Thu, Jun 23, 5:17 AM · Restricted Project, Restricted Project
pmatos closed D128282: [WebAssembly] Update test to run it in opaque pointers mode.
Thu, Jun 23, 5:16 AM · Restricted Project, Restricted Project
pmatos updated the diff for D128282: [WebAssembly] Update test to run it in opaque pointers mode.

Remove extraneous whitespace.
Make equal CHECK lines use WEBASSEMBLY:

Thu, Jun 23, 5:13 AM · Restricted Project, Restricted Project

Tue, Jun 21

pmatos updated the diff for D122215: [WebAssembly] Initial support for reference type externref in clang.

rebase on top of D128282

Tue, Jun 21, 8:42 AM · Restricted Project, Restricted Project, Restricted Project
pmatos requested review of D128282: [WebAssembly] Update test to run it in opaque pointers mode.
Tue, Jun 21, 7:22 AM · Restricted Project, Restricted Project
pmatos updated the diff for D122215: [WebAssembly] Initial support for reference type externref in clang.

Incorporate @asb semantic restrictions patch.
Generate test CHECK using update_cc_* script.

Tue, Jun 21, 3:12 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 15

pmatos updated the diff for D122215: [WebAssembly] Initial support for reference type externref in clang.

Update revision to be specific to externref only.
A different revision will be opened for further work on externref builtins and funcref.

Wed, Jun 15, 5:39 AM · Restricted Project, Restricted Project, Restricted Project

May 30 2022

pmatos planned changes to D122215: [WebAssembly] Initial support for reference type externref in clang.

Still need to implement funcrefs support as function arguments.

May 30 2022, 3:09 AM · Restricted Project, Restricted Project, Restricted Project
pmatos updated the diff for D122215: [WebAssembly] Initial support for reference type externref in clang.

Rebased the work on D126535. Added support for funcrefs as return values.
Still having problems with funcrefs as function arguments though. So, further work is required.
Not ready for review.

May 30 2022, 3:08 AM · Restricted Project, Restricted Project, Restricted Project
pmatos added a comment to D126535: [WebAssembly][NFC] Update reftype and table tests to use opaque pointers.

Thanks for the change. LGTM.
I will rebase my further changes on top of this.

May 30 2022, 2:21 AM · Restricted Project, Restricted Project

Apr 11 2022

pmatos planned changes to D122215: [WebAssembly] Initial support for reference type externref in clang.

This still requires some changes, as there are a few unhandled cases where funcref attribute is not handled properly at the edge.

Apr 11 2022, 8:37 AM · Restricted Project, Restricted Project, Restricted Project
pmatos updated the diff for D122215: [WebAssembly] Initial support for reference type externref in clang.

Moved the attribute handling to the border between clang and llvm.
In the frontend, there's no special handling of address spaces for funcref, but
this is added when converting the values to LLVM types.

Apr 11 2022, 8:36 AM · Restricted Project, Restricted Project, Restricted Project
pmatos planned changes to D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen.

A couple of weeks ago @asb pointed out we were missing an intrinsic for ref.is_null, so I got the work started. There's an issue with the polymorphic type for ref types, but I have seen this before and hopefully will get it fixed properly this time.

Apr 11 2022, 12:23 AM · Restricted Project, Restricted Project
pmatos requested review of D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen.
Apr 11 2022, 12:20 AM · Restricted Project, Restricted Project

Mar 22 2022

pmatos planned changes to D122215: [WebAssembly] Initial support for reference type externref in clang.

Test wasm-funcref.c still fails as type attribute funcref semantics are not yet implemented. Not ready to land yet.

Mar 22 2022, 1:49 AM · Restricted Project, Restricted Project, Restricted Project
pmatos requested review of D122215: [WebAssembly] Initial support for reference type externref in clang.
Mar 22 2022, 1:48 AM · Restricted Project, Restricted Project, Restricted Project
pmatos accepted D122123: [WebAssembly][NFC] Delete type checking logic for removed ref.null instruction.

lgtm, thanks.

Mar 22 2022, 1:07 AM · Restricted Project, Restricted Project

Mar 10 2022

Herald added a project to D114533: LLVM IR should allow bitcast between address spaces with the same size.: Restricted Project.
Mar 10 2022, 3:07 AM · Restricted Project, Restricted Project, Restricted Project

Mar 5 2022

pmatos committed rG219a2eb4d48f: [WebAssembly] Update WebAssemblyAsmTypeCheck for table.get (authored by nokotan).
[WebAssembly] Update WebAssemblyAsmTypeCheck for table.get
Mar 5 2022, 7:57 AM · Restricted Project
pmatos closed D120229: [WebAssembly] Update WebAssemblyAsmTypeCheck for table.get.
Mar 5 2022, 7:57 AM · Restricted Project, Restricted Project
pmatos added a comment to D120229: [WebAssembly] Update WebAssemblyAsmTypeCheck for table.get.

Thanks - all tests pass, landing again.

Mar 5 2022, 7:38 AM · Restricted Project, Restricted Project

Mar 4 2022

pmatos added a comment to D120229: [WebAssembly] Update WebAssemblyAsmTypeCheck for table.get.

@nokotan The test line should be something like: llvm-mc -mattr=+reference-types -triple=wasm32-unknown-unknown -filetype=obj -o - < %s | obj2yaml | FileCheck %s
However, I notice that MC/WebAssembly/tables.s is failing as well. Can you pls take a look?

Mar 4 2022, 6:51 AM · Restricted Project, Restricted Project
pmatos added a comment to D120229: [WebAssembly] Update WebAssemblyAsmTypeCheck for table.get.

This caused two test failures on one of our bots: https://lab.llvm.org/buildbot/#/builders/183/builds/3684

For the new test, it's possible you had a wasm-ld on your path and that's why it worked locally.

Please investigate then reland.

Mar 4 2022, 6:26 AM · Restricted Project, Restricted Project
pmatos committed rG6b2482f6f472: [WebAssembly] Update WebAssemblyAsmTypeCheck for table.get (authored by nokotan).
[WebAssembly] Update WebAssemblyAsmTypeCheck for table.get
Mar 4 2022, 4:03 AM · Restricted Project
pmatos closed D120229: [WebAssembly] Update WebAssemblyAsmTypeCheck for table.get.
Mar 4 2022, 4:03 AM · Restricted Project, Restricted Project
pmatos added a comment to D120229: [WebAssembly] Update WebAssemblyAsmTypeCheck for table.get.

I don't have access rights to the llvm repository, arc land failed from my terminal.

@pmatos do you want to take care of landing this? (since its kind of your area). If you are busy can also take care of it.

Mar 4 2022, 3:24 AM · Restricted Project, Restricted Project

Mar 3 2022

pmatos added a comment to D120229: [WebAssembly] Update WebAssemblyAsmTypeCheck for table.get.

Thanks for your time working on the patch. It would be great to address @aardappel 's comments. The idea is to merge the function getGlobal with getTable, since they are so similar. I suppose into something like getGlobalOrTable. Add another switch case for wasm::WASM_SYMBOL_TYPE_TABLE to return the appropriate type.

Mar 3 2022, 6:03 AM · Restricted Project, Restricted Project

Feb 25 2022

pmatos accepted D120521: [WebAssembly] Covert llvm/test/MC/WebAssembly/reloc-code.ll to asm. NFC.

lgtm

Feb 25 2022, 5:41 AM · Restricted Project

Feb 22 2022

pmatos added a comment to D120229: [WebAssembly] Update WebAssemblyAsmTypeCheck for table.get.

Thanks for the patch. In addition to what @sbc100 wrote, some further comments inline.

Feb 22 2022, 5:37 AM · Restricted Project, Restricted Project

Feb 4 2022

pmatos committed rGc67c9cfe3f39: [WebAssembly] Refactor and fix emission of external IR global decls (authored by pmatos).
[WebAssembly] Refactor and fix emission of external IR global decls
Feb 4 2022, 1:02 PM
pmatos closed D118995: [WebAssembly] Refactor and fix emission of external IR global decls.
Feb 4 2022, 1:02 PM · Restricted Project
pmatos added a comment to D118995: [WebAssembly] Refactor and fix emission of external IR global decls.

Looks good to me! don't worry about configuring your node correctly (if you want one that will certainly work use the emsdk version).

Feb 4 2022, 1:00 PM · Restricted Project
pmatos added a comment to D118995: [WebAssembly] Refactor and fix emission of external IR global decls.

@sbc100 might have an incorrect version of node as I keep getting /usr/bin/node: invalid value for --unhandled-rejections. Other than that there are no failures.
Maybe you can give it a go on your side just to be certain before landing?

Yup, sounds unrelated to this change, ... is that just a warning or do one or more tests fail? What version is /usr/bin/node (we should probably detect this incompatibility)?

Only the fails related to the warning:

test_openjpeg (test_core.core2) ... FAIL
-- begin program output --
/usr/bin/node: invalid value for --unhandled-rejections
-- end program output --
node --version
v12.22.5

It's the ubuntu 21.10 version. What's the minimum version for emscripten?

Feb 4 2022, 11:48 AM · Restricted Project
pmatos added a comment to D118995: [WebAssembly] Refactor and fix emission of external IR global decls.

@sbc100 might have an incorrect version of node as I keep getting /usr/bin/node: invalid value for --unhandled-rejections. Other than that there are no failures.
Maybe you can give it a go on your side just to be certain before landing?

Yup, sounds unrelated to this change, ... is that just a warning or do one or more tests fail? What version is /usr/bin/node (we should probably detect this incompatibility)?

Feb 4 2022, 11:29 AM · Restricted Project
pmatos added a comment to D118995: [WebAssembly] Refactor and fix emission of external IR global decls.

@sbc100 might have an incorrect version of node as I keep getting /usr/bin/node: invalid value for --unhandled-rejections. Other than that there are no failures.
Maybe you can give it a go on your side just to be certain before landing?

Feb 4 2022, 10:25 AM · Restricted Project
pmatos added a comment to D118995: [WebAssembly] Refactor and fix emission of external IR global decls.

Are you able to verify this against emscripten? Perhaps run the core2 test suite there? If not let me know and I can give it a go.

Yes, the ubsan tests just finished and passing. I was going to give a go on the emscripten as well, but I am having some issues with the testsuites. For some reason running tests/runner shows no testsuites available. I will contact you in pvt.

Feb 4 2022, 10:15 AM · Restricted Project
pmatos updated the diff for D118995: [WebAssembly] Refactor and fix emission of external IR global decls.

Address last set of comments.

Feb 4 2022, 10:10 AM · Restricted Project
pmatos added a comment to D118995: [WebAssembly] Refactor and fix emission of external IR global decls.

Are you able to verify this against emscripten? Perhaps run the core2 test suite there? If not let me know and I can give it a go.

Feb 4 2022, 10:09 AM · Restricted Project
pmatos updated the diff for D118995: [WebAssembly] Refactor and fix emission of external IR global decls.

@sbc100 addresses your concerns.

Feb 4 2022, 8:48 AM · Restricted Project
pmatos added inline comments to D118995: [WebAssembly] Refactor and fix emission of external IR global decls.
Feb 4 2022, 8:10 AM · Restricted Project
pmatos added inline comments to D118995: [WebAssembly] Refactor and fix emission of external IR global decls.
Feb 4 2022, 7:13 AM · Restricted Project
pmatos added a comment to D118122: [WebAssembly] Refactor and fix emission of external IR global decls.

Attempting to reland this with D118995 after fixing issues found.

Feb 4 2022, 6:59 AM · Restricted Project
pmatos requested review of D118995: [WebAssembly] Refactor and fix emission of external IR global decls.
Feb 4 2022, 6:59 AM · Restricted Project

Feb 3 2022

pmatos added a comment to D118122: [WebAssembly] Refactor and fix emission of external IR global decls.

I confirmed with Anton K. in discord that indeed it's not possible to obtain a TLI outside a function, because a function can change the subtarget. Apparently ARM allows this with ARM vs Thumb functions being defined in the same file.

Feb 3 2022, 6:44 AM · Restricted Project
pmatos added a comment to D118122: [WebAssembly] Refactor and fix emission of external IR global decls.

I guess that re-enabling the emitExternalDecls in emitEndOfAsmFile would fix the emscripten issue (although that points to a missing test case). Not sure about the other failures reported here.

Feb 3 2022, 6:12 AM · Restricted Project

Jan 31 2022

pmatos added inline comments to D118122: [WebAssembly] Refactor and fix emission of external IR global decls.
Jan 31 2022, 7:48 AM · Restricted Project
pmatos committed rG00bf4755e90c: [WebAssembly] Refactor and fix emission of external IR global decls (authored by pmatos).
[WebAssembly] Refactor and fix emission of external IR global decls
Jan 31 2022, 2:43 AM
pmatos closed D118122: [WebAssembly] Refactor and fix emission of external IR global decls.
Jan 31 2022, 2:42 AM · Restricted Project
pmatos added inline comments to D118122: [WebAssembly] Refactor and fix emission of external IR global decls.
Jan 31 2022, 2:38 AM · Restricted Project
pmatos added inline comments to D118122: [WebAssembly] Refactor and fix emission of external IR global decls.
Jan 31 2022, 12:13 AM · Restricted Project

Jan 29 2022

pmatos added inline comments to D118122: [WebAssembly] Refactor and fix emission of external IR global decls.
Jan 29 2022, 1:44 AM · Restricted Project
pmatos updated the diff for D118122: [WebAssembly] Refactor and fix emission of external IR global decls.

Move the removal of some lines setting table global type from D118121 to this revision.

Jan 29 2022, 1:43 AM · Restricted Project
pmatos committed rG864767ab09cb: [WebAssembly][NFC] Refactor WasmSymbol type setting code (authored by pmatos).
[WebAssembly][NFC] Refactor WasmSymbol type setting code
Jan 29 2022, 12:01 AM
pmatos closed D118121: [WebAssembly][NFC] Refactor WasmSymbol type setting code.
Jan 29 2022, 12:01 AM · Restricted Project

Jan 28 2022

pmatos updated the diff for D118121: [WebAssembly][NFC] Refactor WasmSymbol type setting code.

Remove non-NFC change.

Jan 28 2022, 11:59 PM · Restricted Project
pmatos added inline comments to D118121: [WebAssembly][NFC] Refactor WasmSymbol type setting code.
Jan 28 2022, 12:44 PM · Restricted Project
pmatos updated the diff for D118121: [WebAssembly][NFC] Refactor WasmSymbol type setting code.

Added [NFC] to the title, rebased on main and rechecked that tests are fine.

Jan 28 2022, 3:42 AM · Restricted Project
pmatos added inline comments to D118121: [WebAssembly][NFC] Refactor WasmSymbol type setting code.
Jan 28 2022, 3:32 AM · Restricted Project

Jan 25 2022

pmatos added a comment to D118121: [WebAssembly][NFC] Refactor WasmSymbol type setting code.

@sbc100 I have now addressed all your comments, I feel like it is ready for review.

Jan 25 2022, 4:12 AM · Restricted Project
pmatos added a comment to D118122: [WebAssembly] Refactor and fix emission of external IR global decls.

@sbc100 I addressed your questions regarding this part of the patch in D115749. I think it's ready for your review.

Jan 25 2022, 4:11 AM · Restricted Project
pmatos added inline comments to D115749: [WebAssembly] Fix linkage and visibility info of IR global syms.
Jan 25 2022, 4:10 AM · Restricted Project
pmatos updated the diff for D118121: [WebAssembly][NFC] Refactor WasmSymbol type setting code.

@sbc100 Address review comments from D115749.

Jan 25 2022, 4:05 AM · Restricted Project
pmatos added inline comments to D115749: [WebAssembly] Fix linkage and visibility info of IR global syms.
Jan 25 2022, 3:45 AM · Restricted Project
pmatos abandoned D115749: [WebAssembly] Fix linkage and visibility info of IR global syms.

@sbc100 Thanks for the comments, I have split this into D118121 and D118122. I will now apply the comments from your reviews to the new revisions.

Jan 25 2022, 3:45 AM · Restricted Project
pmatos requested review of D118122: [WebAssembly] Refactor and fix emission of external IR global decls.
Jan 25 2022, 3:28 AM · Restricted Project
pmatos requested review of D118121: [WebAssembly][NFC] Refactor WasmSymbol type setting code.
Jan 25 2022, 3:25 AM · Restricted Project

Jan 24 2022

pmatos updated the diff for D115749: [WebAssembly] Fix linkage and visibility info of IR global syms.

Update the bug summary, no code changes.

Jan 24 2022, 8:18 AM · Restricted Project
pmatos added a comment to D115749: [WebAssembly] Fix linkage and visibility info of IR global syms.

Refactored the setting of the Wasm Symbol type into WasmSymbolSetType in WebAssemblyAsmPrinter.cpp and WebAssemblyMCInstLower.cpp. However, this forced us to move the function to WebAssemblyTypeUtilities.h and refactor some other type-related functions from WebAssemblyUtilities to WebAssemblyTypeUtilities.

Jan 24 2022, 6:38 AM · Restricted Project
pmatos updated the diff for D115749: [WebAssembly] Fix linkage and visibility info of IR global syms.

Full patch for required refactoring and fix.

Jan 24 2022, 6:11 AM · Restricted Project

Jan 22 2022

pmatos added a comment to D113420: [WebAssembly] Implement table instruction intrinsics and ref.null.

After closing D111420, I moved the implementation of all intrinsics to this revision without the need for the polymorphic llvm_anyref_ty type.

@pmatos You likely referenced the wrong diff. I would suggest amending this to avoid confusion in the future :)

Jan 22 2022, 12:18 AM · Restricted Project

Jan 17 2022

pmatos added a comment to D115749: [WebAssembly] Fix linkage and visibility info of IR global syms.

@sbc100 I think I understand where this is going wrong. As far as I understand emitExternalDecls should only be emitting .functype, etc directives for external symbols and yet it's doing so for all symbols in OutContext, even those which are not external. I will have to revisit my assumptions and take a look at the code again, since the current solution of running emitExternalDecls in onFinalization means all directives come at the end and that doesn't work because it complains if, for example a reference to bar comes before bars type declaration.

Yes, it makes sense to me that emitExternalDecls only applies to external symbols (those not defined in the module). However, I would have thought that for typechecking reasons (we do basic type checking, unlike other asm backend) that all the external decls always come first.

Jan 17 2022, 11:59 PM · Restricted Project
pmatos added a comment to D115749: [WebAssembly] Fix linkage and visibility info of IR global syms.

@sbc100 I think I understand where this is going wrong. As far as I understand emitExternalDecls should only be emitting .functype, etc directives for external symbols and yet it's doing so for all symbols in OutContext, even those which are not external. I will have to revisit my assumptions and take a look at the code again, since the current solution of running emitExternalDecls in onFinalization means all directives come at the end and that doesn't work because it complains if, for example a reference to bar comes before bars type declaration.

Jan 17 2022, 7:47 AM · Restricted Project
pmatos updated the diff for D115749: [WebAssembly] Fix linkage and visibility info of IR global syms.

Refactored places where type related utility functions are and refactored some of the symbol type creation.

Jan 17 2022, 7:26 AM · Restricted Project
pmatos added a comment to D115749: [WebAssembly] Fix linkage and visibility info of IR global syms.

@sbc100 Unfortunately while adding some tests to this including testing private IR globals, which don't emit a .globl for the symbol I found a crash, which I now fixed and an issue with multiple globals in the same compilation unit. For example, two tables don't work because .tabletype is only emitted for the first. emitLinkage is called on each symbol in turn, and emitExternalDecls emits the tabletype for the symbol, however it only runs for the first symbol because emitExternalDecls only actually runs the first time it's called. This is very unfortunately and will need a bit of refactoring. I am working on it.

Jan 17 2022, 3:47 AM · Restricted Project

Jan 13 2022

pmatos committed rG97ef15ad7697: [WebAssembly] Fix reftype load/store match with idx from call (authored by pmatos).
[WebAssembly] Fix reftype load/store match with idx from call
Jan 13 2022, 2:05 AM
pmatos closed D115327: [WebAssembly] Fix reftype load/store match with idx from call.
Jan 13 2022, 2:05 AM · Restricted Project

Jan 12 2022

pmatos committed rG968be05b8fdc: [clang] Fix crash for sizeof on VLAs (authored by pmatos).
[clang] Fix crash for sizeof on VLAs
Jan 12 2022, 7:11 AM
pmatos closed D27800: [clang] Fix crash for sizeof on VLAs.
Jan 12 2022, 7:11 AM · Restricted Project
pmatos added a comment to D27800: [clang] Fix crash for sizeof on VLAs.

Looks like all the review comments have been addressed. LGTM

Jan 12 2022, 7:09 AM · Restricted Project
pmatos updated the diff for D27800: [clang] Fix crash for sizeof on VLAs.

Ensure that we only call transform on Unevaluated Contexts, avoids the failure of a couple of vla tests.

Jan 12 2022, 7:08 AM · Restricted Project
pmatos added a comment to D27800: [clang] Fix crash for sizeof on VLAs.

Looks like all the review comments have been addressed. LGTM

Jan 12 2022, 5:36 AM · Restricted Project

Jan 11 2022

pmatos added inline comments to D115749: [WebAssembly] Fix linkage and visibility info of IR global syms.
Jan 11 2022, 11:20 AM · Restricted Project
pmatos added inline comments to D115749: [WebAssembly] Fix linkage and visibility info of IR global syms.
Jan 11 2022, 9:26 AM · Restricted Project
pmatos added inline comments to D115749: [WebAssembly] Fix linkage and visibility info of IR global syms.
Jan 11 2022, 8:34 AM · Restricted Project
pmatos added a comment to D27800: [clang] Fix crash for sizeof on VLAs.

@efriedma I know it has been a long time, but are you still able to review this?

Jan 11 2022, 7:03 AM · Restricted Project
pmatos added a comment to D27800: [clang] Fix crash for sizeof on VLAs.

Fixes https://github.com/llvm/llvm-project/issues/30390

Jan 11 2022, 7:02 AM · Restricted Project
pmatos added a comment to D27800: [clang] Fix crash for sizeof on VLAs.
Jan 11 2022, 7:01 AM · Restricted Project
pmatos updated the diff for D27800: [clang] Fix crash for sizeof on VLAs.

After a long hiatus on this bug, this is still failing on HEAD so lets get it fixed.

Jan 11 2022, 7:00 AM · Restricted Project
pmatos abandoned D26079: Do not use CppHashInfo if reporting an error after asm file parsed.
Jan 11 2022, 6:12 AM
pmatos updated the diff for D115327: [WebAssembly] Fix reftype load/store match with idx from call.

Rebased on top of main. All seems good.

Jan 11 2022, 5:43 AM · Restricted Project
pmatos updated the diff for D115749: [WebAssembly] Fix linkage and visibility info of IR global syms.

Simplified code to emit labels for tables and tabletype directive.

Jan 11 2022, 3:40 AM · Restricted Project

Dec 21 2021

pmatos added inline comments to D115749: [WebAssembly] Fix linkage and visibility info of IR global syms.
Dec 21 2021, 3:33 AM · Restricted Project
pmatos updated the diff for D115327: [WebAssembly] Fix reftype load/store match with idx from call.

Remove isUndef check from code. I cannot find a codepath that generates an undef Idx at this point. All undef values end up being propogated down to the respective GEP. So simplifying and removing check.

Dec 21 2021, 3:29 AM · Restricted Project

Dec 16 2021

pmatos committed rGc92d45913c43: [WebAssembly] Fix typechecking for else MCInst (authored by pmatos).
[WebAssembly] Fix typechecking for else MCInst
Dec 16 2021, 2:24 AM
pmatos closed D115748: [WebAssembly] Fix typechecking for else MCInst.
Dec 16 2021, 2:24 AM · Restricted Project

Dec 14 2021

pmatos added inline comments to D115749: [WebAssembly] Fix linkage and visibility info of IR global syms.
Dec 14 2021, 11:46 PM · Restricted Project
pmatos added inline comments to D115327: [WebAssembly] Fix reftype load/store match with idx from call.
Dec 14 2021, 11:42 PM · Restricted Project