User Details
- User Since
- Oct 28 2016, 2:19 AM (334 w, 7 h)
Mon, Mar 20
Address concerns about table subscripting. Add warnings for that.
Remove references to table subscript. Simplify patch.
Rebase on main.
Fri, Mar 17
Thanks all for the comments, fixed and will soon land after running a check-all.
Wed, Mar 8
@erichkeane @aaron.ballman any further comments on this?
Mon, Mar 6
Tue, Feb 28
Address comments regarding tables and remove some unused code.
Address the comments.
Add forgotten comment to test.
Patch with all outstanding comments addressed.
Thanks @aaron.ballman . I think I have now address all outstanding comments.
Feb 15 2023
Rebased on current HEAD.
Rebased on current HEAD.
Rebased against HEAD. Waiting for @vitalybuka go ahead to land.
Feb 14 2023
@aaron.ballman I have finished addressing all the concerns on this patch. Do you have any further comments?
Feb 13 2023
Remove unnecessary code.
Further refinement of the patch with more diagnostics tested.
Addressed a few comments.
Feb 1 2023
Address some of the pending comments.
Jan 31 2023
Address last comment before landing.
Jan 30 2023
Rebase on main and fix a test diagnostic expectation.
Rebase on main.
Rebase on main.
Jan 24 2023
@aaron.ballman Thanks for all the comments, I have now finished addressing those. What do you think of the current patch?
Add missing newline at end of file.
Simplify and add tests for remaining diagnostics
Further tests for use of tables in conditional branches.
Jan 23 2023
Finish fixing tests after dianostic message changes
Fix some tests whose diagnostics changed
Address more comments.
Jan 18 2023
Remove some unnecessary diagnostics.
Jan 16 2023
Add new Attr Subject Function Pointer for __funcref attribute.
I feel like the latest patch addresses all concerns until now. What do you think?
Rebase on main.
Updating tests after some changes to previous diagnostics.
Jan 13 2023
Address a few comments, add new test for funcref keyword diagnostic.
Rename test that still had tables in its name.
Fix tests after changing name mangling and error messages.
Jan 12 2023
Update mangling for Microsoft.
Now under the correct revision: @aaron.ballman Added support for externref mangling in Microsoft. This follows the pattern implemented by OpenCL types.
Undo last patch. Submitted change to incorrect revision.
@aaron.ballman Added support for externref mangling in Microsoft. This follows the pattern implemented by OpenCL types.
@aaron.ballman many thanks for the thorough reviews on the patches. Happy to see this moving in the right direction.
Address all comments except a couple of issues related to ABI and mangling.
Deal with Itanium Mangle and assert false outside Wasm triple.
Address a couple of comments by @aaron.ballman
Addressed a few comments downstream. Will upload new patch next.
Jan 11 2023
@aaron.ballman Hi Aaron, since you requested an RFC for this. I wonder if you have any comments for this or the other related patches: D122215, D139010
Jan 10 2023
Fix test broken after recent change to opt call. Rebase again on main.
Jan 9 2023
Rebase on top of main.
Rebase on top of main.
Rebasing on top of main.
Dec 20 2022
Dec 15 2022
Force mem2reg on all optimization levels to avoid allocas.
Dec 14 2022
Dec 1 2022
Ready for review.
Ready for review.
This is ready for review.
RFC has been published here: https://discourse.llvm.org/t/rfc-webassembly-reference-types-in-clang/66939
Remove unnecessary attribute that lingered around after some refactoring.
Nov 30 2022
Please wait to review until the RFC (coming soon) is published.
Nov 23 2022
Nov 7 2022
Nov 3 2022
Oct 26 2022
Updated this revision on top of D122215.
Oct 25 2022
Whole integration plan still in the works, so marking as planning changes.
Removed address space wasm_externref which is unnecessary with current design.