Page MenuHomePhabricator

bogner (Justin Bogner)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 12 2014, 3:00 PM (283 w, 6 d)

Recent Activity

Thu, Aug 15

bogner committed rGe7c220c0ef94: [cmake] install_symlink should obey DESTDIR unconditionally (authored by bogner).
[cmake] install_symlink should obey DESTDIR unconditionally
Thu, Aug 15, 8:36 AM
bogner committed rL369011: [cmake] install_symlink should obey DESTDIR unconditionally.
[cmake] install_symlink should obey DESTDIR unconditionally
Thu, Aug 15, 8:36 AM

Wed, Aug 14

bogner accepted D39339: [CallGraph] Refine call graph for indirect calls with !callees metadata.

LGTM

Wed, Aug 14, 2:23 PM · Restricted Project
bogner added inline comments to D39339: [CallGraph] Refine call graph for indirect calls with !callees metadata.
Wed, Aug 14, 9:59 AM · Restricted Project
bogner added inline comments to D39339: [CallGraph] Refine call graph for indirect calls with !callees metadata.
Wed, Aug 14, 9:40 AM · Restricted Project

Mon, Aug 12

bogner accepted D66039: [GlobalISel]: Fix a bug in KnownBits where we should have been using SizeInBits.

Obvious bugfixes like this can generally be post-commit reviewed.

Mon, Aug 12, 1:55 PM · Restricted Project

Mon, Jul 29

bogner accepted D65298: [DivRemPairs] Handling for expanded-form rem - recomposition (PR42673).

LGTM

Mon, Jul 29, 1:41 PM · Restricted Project

Jul 19 2019

bogner accepted D65011: Expand pseudo-components before embedding in llvm-config.

LGTM

Jul 19 2019, 1:34 PM · Restricted Project

Jul 16 2019

bogner committed rG418516c7b865: [TableGen] Generate offsets into a flat array for getOperandType (authored by bogner).
[TableGen] Generate offsets into a flat array for getOperandType
Jul 16 2019, 3:41 PM
bogner committed rL366278: [TableGen] Generate offsets into a flat array for getOperandType.
[TableGen] Generate offsets into a flat array for getOperandType
Jul 16 2019, 3:41 PM
bogner committed rGfe66fdb8f307: [TableGen] Add "getOperandType" to get operand types from opcode/opidx (authored by bogner).
[TableGen] Add "getOperandType" to get operand types from opcode/opidx
Jul 16 2019, 3:11 PM
bogner committed rL366274: [TableGen] Add "getOperandType" to get operand types from opcode/opidx.
[TableGen] Add "getOperandType" to get operand types from opcode/opidx
Jul 16 2019, 3:10 PM
bogner closed D63320: [TableGen] Add "getOperandType" to get operand types from opcode/opidx.
Jul 16 2019, 3:10 PM · Restricted Project

Jul 8 2019

bogner accepted D56265: [DebugInfo] MCP: collect and update DBG_VALUEs encountered in local block.

Seems reasonable to me

Jul 8 2019, 3:36 PM · Restricted Project

Jun 19 2019

bogner accepted D63496: [WIP] CodeGen: Prototype class for registers.
Jun 19 2019, 4:38 PM
bogner added inline comments to D63496: [WIP] CodeGen: Prototype class for registers.
Jun 19 2019, 4:38 PM

Jun 18 2019

bogner accepted D32628: Rename ExpandISelPseudo->FinalizeISel, delay register reservation.
Jun 18 2019, 4:00 PM · Restricted Project

Jun 17 2019

bogner added a comment to D61321: [globalisel] Allow SrcOp to convert an APInt and render it as an immediate operand (MO.isImm() == true).

How terrible would it be to use APInt as the interface type, but then store it as int64_t?

That seems like a good compromise to me.

Jun 17 2019, 12:01 PM · Restricted Project
bogner added a comment to D63205: Virtualize TargetInstrInfo::getRegClass().

Maybe I'm missing something, but the override implemented in D63204 looks like a subset of the default TII::getRegClass that falls through to TRI::getRegClass, just like the default does. Is this change actually necessary?

Jun 17 2019, 11:36 AM · Restricted Project

Jun 12 2019

bogner accepted D52369: [tblgen][disasm] Allow multiple encodings to disassemble to the same instruction.

Sorry for the delay! This LGTM

Jun 12 2019, 12:29 PM · Restricted Project

Jun 5 2019

bogner added a comment to D32628: Rename ExpandISelPseudo->FinalizeISel, delay register reservation.

So if I'm reading this right this just basically just delays TLI->finalizeLowering to the end of ExpandISelPseudos/FinalizeISel. Is there motivation to this other than it makes more logical sense to freeze registers as close to regalloc as possible?

Jun 5 2019, 4:38 PM · Restricted Project

May 30 2019

bogner accepted D62617: [MIR-Canon] Fixing case where MachineFunction is empty..
May 30 2019, 2:16 PM · Restricted Project
bogner added inline comments to D62617: [MIR-Canon] Fixing case where MachineFunction is empty..
May 30 2019, 11:41 AM · Restricted Project
bogner accepted D62693: Support codesigning bundles and forcing.

Seems straightforward enough

May 30 2019, 10:54 AM · Restricted Project, Restricted Project
bogner accepted D62438: Break a couple more false dependencies on target libraries.

For future reference, obvious follow ups like this are fine for post-commit review

May 30 2019, 10:34 AM · Restricted Project

May 29 2019

bogner added inline comments to D62617: [MIR-Canon] Fixing case where MachineFunction is empty..
May 29 2019, 12:28 PM · Restricted Project
bogner accepted D62543: [MIR-Canon] Add support for rewriting VRegs that are typed but don't have an RC..

lgtm once you've addressed compnerd's comments

May 29 2019, 12:25 PM · Restricted Project

May 23 2019

bogner accepted D62331: Break false dependencies on target libraries.

This looks great. Looking forward to faster incremental builds!

May 23 2019, 1:23 PM · Restricted Project

Apr 25 2019

bogner committed rGdf5d2b3846d9: [GlobalOpt] Swap the expensive check for cold calls with the cheap TTI check (authored by bogner).
[GlobalOpt] Swap the expensive check for cold calls with the cheap TTI check
Apr 25 2019, 5:11 PM
bogner committed rL359253: [GlobalOpt] Swap the expensive check for cold calls with the cheap TTI check.
[GlobalOpt] Swap the expensive check for cold calls with the cheap TTI check
Apr 25 2019, 5:10 PM

Apr 22 2019

bogner committed rGe90d5c8db069: [IPSCCP] Add missing `AssumptionCacheTracker` dependency (authored by bogner).
[IPSCCP] Add missing `AssumptionCacheTracker` dependency
Apr 22 2019, 10:39 AM
bogner committed rL358903: [IPSCCP] Add missing `AssumptionCacheTracker` dependency.
[IPSCCP] Add missing `AssumptionCacheTracker` dependency
Apr 22 2019, 10:39 AM

Apr 14 2019

bogner added a comment to D60664: [git-svn] Add a username option for push command.

Should we (either instead or as well) make the default username try git config llvm.username before falling back to the local user? That way people can set it with git config llvm.username xyz or, if they work with a lot of llvm checkouts, git config --global llvm.username xyz instead of having to specify it every time.

Apr 14 2019, 12:03 PM · Restricted Project

Apr 9 2019

bogner committed rGc60d09597c6b: [CMake] Move configuration of LLVM_CXX_STD to HandleLLVMOptions.cmake (authored by bogner).
[CMake] Move configuration of LLVM_CXX_STD to HandleLLVMOptions.cmake
Apr 9 2019, 1:15 AM
bogner added a comment to D60399: [CMake] Replace LLVM_ENABLE_CXX1Y and friends with LLVM_CXX_STD.

I moved where we set the default into HandleLLVMOptions in r357976, this should fix both issues. Sorry for the breakage!

Apr 9 2019, 1:15 AM · Restricted Project
bogner committed rL357976: [CMake] Move configuration of LLVM_CXX_STD to HandleLLVMOptions.cmake.
[CMake] Move configuration of LLVM_CXX_STD to HandleLLVMOptions.cmake
Apr 9 2019, 1:15 AM
bogner added a comment to D60434: Add a default for LLVM_CXX_STD in HandleLLVMOptions.

This shouldn't be necessary any more after r357976. Sorry for the breakage!

Apr 9 2019, 1:15 AM · Restricted Project

Apr 8 2019

bogner added a comment to D60399: [CMake] Replace LLVM_ENABLE_CXX1Y and friends with LLVM_CXX_STD.
Apr 8 2019, 6:27 AM · Restricted Project
bogner committed rG25de7691a0e2: [CMake] Replace LLVM_ENABLE_CXX1Y and friends with LLVM_CXX_STD (authored by bogner).
[CMake] Replace LLVM_ENABLE_CXX1Y and friends with LLVM_CXX_STD
Apr 8 2019, 3:18 AM
bogner committed rL357899: [CMake] Replace LLVM_ENABLE_CXX1Y and friends with LLVM_CXX_STD.
[CMake] Replace LLVM_ENABLE_CXX1Y and friends with LLVM_CXX_STD
Apr 8 2019, 3:17 AM
bogner closed D60399: [CMake] Replace LLVM_ENABLE_CXX1Y and friends with LLVM_CXX_STD.
Apr 8 2019, 3:17 AM · Restricted Project
bogner created D60399: [CMake] Replace LLVM_ENABLE_CXX1Y and friends with LLVM_CXX_STD.
Apr 8 2019, 1:38 AM · Restricted Project

Apr 4 2019

bogner accepted D60006: [SelectionDAG] Add fcmp UNDEF handling to SelectionDAG::FoldSetCC.

lgtm

Apr 4 2019, 1:47 PM · Restricted Project

Mar 27 2019

bogner committed rGb1650f0da92b: [LegalizeVectorTypes] Allow single loads and stores for more short vectors (authored by bogner).
[LegalizeVectorTypes] Allow single loads and stores for more short vectors
Mar 27 2019, 1:36 PM
bogner committed rL357120: [LegalizeVectorTypes] Allow single loads and stores for more short vectors.
[LegalizeVectorTypes] Allow single loads and stores for more short vectors
Mar 27 2019, 1:36 PM
bogner closed D56201: [LegalizeVectorTypes] Allow single loads and stores for more short vectors.
Mar 27 2019, 1:36 PM · Restricted Project
bogner accepted D56201: [LegalizeVectorTypes] Allow single loads and stores for more short vectors.
Mar 27 2019, 1:36 PM · Restricted Project

Mar 26 2019

bogner requested changes to D56201: [LegalizeVectorTypes] Allow single loads and stores for more short vectors.

I hit a couple of minor issues trying to apply the patch:

Mar 26 2019, 1:18 PM · Restricted Project

Mar 25 2019

bogner accepted D56201: [LegalizeVectorTypes] Allow single loads and stores for more short vectors.

Sorry for the delay, I somehow completely missed this. The change looks good - I'll commit it for you today or tomorrow.

Mar 25 2019, 4:47 PM · Restricted Project

Mar 19 2019

bogner committed rGb353d6887ea5: [DAGCombine] Fix a miscompile when reducing BUILD_VECTORs to a shuffle (authored by bogner).
[DAGCombine] Fix a miscompile when reducing BUILD_VECTORs to a shuffle
Mar 19 2019, 9:52 AM
bogner committed rL356476: [DAGCombine] Fix a miscompile when reducing BUILD_VECTORs to a shuffle.
[DAGCombine] Fix a miscompile when reducing BUILD_VECTORs to a shuffle
Mar 19 2019, 9:52 AM
bogner closed D59507: [DAGCombine] Fix a miscompile when reducing BUILD_VECTORs to a shuffle.
Mar 19 2019, 9:52 AM · Restricted Project

Mar 18 2019

bogner accepted D49837: [SelectionDAG] Handle unary SelectPatternFlavor for ABS case in SelectionDAGBuilder::visitSelect..
Mar 18 2019, 4:58 PM · Restricted Project
bogner created D59507: [DAGCombine] Fix a miscompile when reducing BUILD_VECTORs to a shuffle.
Mar 18 2019, 1:14 PM · Restricted Project

Feb 18 2019

bogner added inline comments to D52954: Annotate timeline in Instruments with passes and other timed regions..
Feb 18 2019, 3:18 PM · Restricted Project

Feb 13 2019

bogner accepted D52954: Annotate timeline in Instruments with passes and other timed regions..

Is there a more generic term for this than "signpost"? If so, it might be nice to use that to avoid confusion when/if other implementations show up. If not, that's fine.

Feb 13 2019, 4:35 PM · Restricted Project

Jan 29 2019

bogner accepted D57334: [CMake] Accept ENTITLEMENTS in llvm_add_library().

LGTM

Jan 29 2019, 11:59 AM

Dec 17 2018

bogner accepted D55668: Add FMF management to common fp intrinsics in GlobalIsel.

One minor style nit, but this LGTM.

Dec 17 2018, 7:34 PM
bogner accepted D55694: GlobalISel: Improve crash on invalid mapping.

I don’t think I understand what this is trying to accomplish. ISTM that this will now hit a null dereference on line 123 when we read BreadDown in the case that NumBreakDowns is zero, but this is to avoid hitting an assert somewhere else? If this is to make it clearer as to what’s failing, shouldn’t we assert NumBreakDowns != 0 here instead of just hoping to crash on a null dereference?

No, that is what this avoids. Right now there is a null dereference on line 123. Now this function exits, so this continues until it hits
Assertion failed: (getOperandMapping(Idx).isValid() && "We must have a mapping for reg operands"), function verify, file ../lib/CodeGen/GlobalISel/RegisterBankInfo.cpp, line 572.

Dec 17 2018, 3:19 PM

Dec 15 2018

bogner added a comment to D55694: GlobalISel: Improve crash on invalid mapping.

I don’t think I understand what this is trying to accomplish. ISTM that this will now hit a null dereference on line 123 when we read BreadDown in the case that NumBreakDowns is zero, but this is to avoid hitting an assert somewhere else? If this is to make it clearer as to what’s failing, shouldn’t we assert NumBreakDowns != 0 here instead of just hoping to crash on a null dereference?

Dec 15 2018, 11:34 AM

Dec 10 2018

bogner accepted D55294: [GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs.
Dec 10 2018, 2:17 PM
bogner added a comment to D55294: [GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs.

This looks like a big improvement to the API overall, thanks for working on it.

Dec 10 2018, 11:46 AM
bogner added a comment to D55294: [GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs.

I also added{F7649492}


which is a clang-tidy implementation to automatically add {} to most buildInstr calls.

Dec 10 2018, 11:20 AM

Nov 6 2018

bogner committed rL346252: [utils] Update SmallVector lldb formatter for r337514.
[utils] Update SmallVector lldb formatter for r337514
Nov 6 2018, 10:54 AM

Nov 5 2018

bogner committed rL346185: Specify REQUIRES: default_triple in two debuginfo tests.
Specify REQUIRES: default_triple in two debuginfo tests
Nov 5 2018, 4:19 PM

Oct 31 2018

bogner accepted D53950: Fix clang -Wimplicit-fallthrough warnings across llvm, NFC.

lgtm as long as there's general consent to the idea in the llvm-dev thread.

Oct 31 2018, 3:49 PM
bogner accepted D52366: [tblgen][disasm] Separate encodings from instructions.
Oct 31 2018, 3:45 PM
bogner added inline comments to D53950: Fix clang -Wimplicit-fallthrough warnings across llvm, NFC.
Oct 31 2018, 3:24 PM
bogner added inline comments to D52366: [tblgen][disasm] Separate encodings from instructions.
Oct 31 2018, 10:24 AM
bogner added inline comments to D53414: Add instructions for migrating branches from one git repository to another..
Oct 31 2018, 9:25 AM

Oct 24 2018

bogner added inline comments to D53414: Add instructions for migrating branches from one git repository to another..
Oct 24 2018, 12:03 PM

Oct 22 2018

bogner committed rL344942: Reapply "[MachineCopyPropagation] Reimplement CopyTracker in terms of register….
Reapply "[MachineCopyPropagation] Reimplement CopyTracker in terms of register…
Oct 22 2018, 12:53 PM

Oct 9 2018

bogner committed rL344087: [LV] Move test for r343954 into x86 subdirectory.
[LV] Move test for r343954 into x86 subdirectory
Oct 9 2018, 3:41 PM

Sep 25 2018

bogner accepted D49881: docs: Emphasize ArrayRef over SmallVectorImpl.

LGTM once dberris's suggestions are taken into account

Sep 25 2018, 11:12 AM
bogner committed rL342993: Revert "[DebugInfo] Do not generate address info for removed debug labels.".
Revert "[DebugInfo] Do not generate address info for removed debug labels."
Sep 25 2018, 10:31 AM

Sep 24 2018

bogner committed rL342942: [MachineCopyPropagation] Reimplement CopyTracker in terms of register units.
[MachineCopyPropagation] Reimplement CopyTracker in terms of register units
Sep 24 2018, 10:18 PM
bogner closed D52374: [MachineCopyPropagation] Reimplement CopyTracker in terms of register units.
Sep 24 2018, 10:18 PM
bogner committed rL342940: [MachineCopyPropagation] Rework how we manage RegMask clobbers.
[MachineCopyPropagation] Rework how we manage RegMask clobbers
Sep 24 2018, 9:46 PM
bogner closed D52370: [MachineCopyPropagation] Rework how we manage RegMask clobbers.
Sep 24 2018, 9:46 PM
bogner added a comment to D52370: [MachineCopyPropagation] Rework how we manage RegMask clobbers.

I'm convinced now the clobbering works correctly because as clobberRegister does not just clobber the register at hand but the whole destination register of the copy touched by the COPY at hand.
LGTM

Sep 24 2018, 5:06 PM
bogner added inline comments to D52374: [MachineCopyPropagation] Reimplement CopyTracker in terms of register units.
Sep 24 2018, 5:00 PM
bogner updated the diff for D52374: [MachineCopyPropagation] Reimplement CopyTracker in terms of register units.

Clarify a bit based on Matthias's comments.

Sep 24 2018, 4:59 PM
bogner added inline comments to D52370: [MachineCopyPropagation] Rework how we manage RegMask clobbers.
Sep 24 2018, 3:40 PM
bogner updated the diff for D52370: [MachineCopyPropagation] Rework how we manage RegMask clobbers.

I'd accidentally sent an old version of the patch for the review originally, which didn't quite work. This one is correct and also incorporates Matthias's feedback.

Sep 24 2018, 3:40 PM

Sep 21 2018

bogner added a parent revision for D52374: [MachineCopyPropagation] Reimplement CopyTracker in terms of register units: D52370: [MachineCopyPropagation] Rework how we manage RegMask clobbers.
Sep 21 2018, 12:08 PM
bogner added a child revision for D52370: [MachineCopyPropagation] Rework how we manage RegMask clobbers: D52374: [MachineCopyPropagation] Reimplement CopyTracker in terms of register units.
Sep 21 2018, 12:08 PM
bogner created D52374: [MachineCopyPropagation] Reimplement CopyTracker in terms of register units.
Sep 21 2018, 12:08 PM
bogner created D52370: [MachineCopyPropagation] Rework how we manage RegMask clobbers.
Sep 21 2018, 11:03 AM

Sep 20 2018

bogner committed rL342703: [MachineCopyPropagation] Refactor copy tracking into a class. NFC.
[MachineCopyPropagation] Refactor copy tracking into a class. NFC
Sep 20 2018, 5:52 PM
bogner accepted D49064: DAG: Add helper for creating shifts with correct type.

Patch LGTM.

Sep 20 2018, 5:31 PM
bogner committed rL342700: [MachineCopyPropagation] Minor clang-formatting. NFC.
[MachineCopyPropagation] Minor clang-formatting. NFC
Sep 20 2018, 5:12 PM

Aug 23 2018

bogner committed rL340594: [SDAG] Add versions of computeKnownBits that return a value.
[SDAG] Add versions of computeKnownBits that return a value
Aug 23 2018, 7:43 PM

Aug 19 2018

bogner committed rL340153: [SimplifyCFG] Replace some uses of bitwise or with logical or.
[SimplifyCFG] Replace some uses of bitwise or with logical or
Aug 19 2018, 11:38 PM

Aug 16 2018

bogner committed rL339949: [docs] Try to clarify the FuzzingLLVM docs.
[docs] Try to clarify the FuzzingLLVM docs
Aug 16 2018, 2:55 PM
bogner accepted D50701: [MI] Change the array of `MachineMemOperand` pointers to be a generically extensible collection of extra info attached to a `MachineInstr`..

lg

Aug 16 2018, 1:52 PM

Aug 15 2018

bogner added inline comments to D50701: [MI] Change the array of `MachineMemOperand` pointers to be a generically extensible collection of extra info attached to a `MachineInstr`..
Aug 15 2018, 10:32 AM

Aug 13 2018

bogner accepted D50680: [SDAG] Remove the reliance on MI's allocation strategy for `MachineMemOperand` pointers attached to `MachineSDNodes` and instead have the `SelectionDAG` fully manage the memory for this array..

LGTM as long as Hal's good with your explanation of why we can't use TinyPtrVector.

Aug 13 2018, 6:18 PM
bogner added a comment to D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3.

The cmake and lit bits all look correct

Aug 13 2018, 1:37 PM

Aug 10 2018

bogner added a comment to D50285: [MC] Remove MCRegisterClass::getSize.

What exactly are out of tree targets supposed to migrate to?

Aug 10 2018, 12:51 AM

Aug 7 2018

bogner accepted D50283: Refactor FileCheck to be used as API.

LGTM.

Aug 7 2018, 2:16 PM