bogner (Justin Bogner)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 12 2014, 3:00 PM (236 w, 1 d)

Recent Activity

Today

bogner added a dependency for D52374: [MachineCopyPropagation] Reimplement CopyTracker in terms of register units: D52370: [MachineCopyPropagation] Rework how we manage RegMask clobbers.
Fri, Sep 21, 12:08 PM
bogner added a dependent revision for D52370: [MachineCopyPropagation] Rework how we manage RegMask clobbers: D52374: [MachineCopyPropagation] Reimplement CopyTracker in terms of register units.
Fri, Sep 21, 12:08 PM
bogner created D52374: [MachineCopyPropagation] Reimplement CopyTracker in terms of register units.
Fri, Sep 21, 12:08 PM
bogner created D52370: [MachineCopyPropagation] Rework how we manage RegMask clobbers.
Fri, Sep 21, 11:03 AM

Yesterday

bogner committed rL342703: [MachineCopyPropagation] Refactor copy tracking into a class. NFC.
[MachineCopyPropagation] Refactor copy tracking into a class. NFC
Thu, Sep 20, 5:52 PM
bogner accepted D49064: DAG: Add helper for creating shifts with correct type.

Patch LGTM.

Thu, Sep 20, 5:31 PM
bogner committed rL342700: [MachineCopyPropagation] Minor clang-formatting. NFC.
[MachineCopyPropagation] Minor clang-formatting. NFC
Thu, Sep 20, 5:12 PM

Thu, Aug 23

bogner committed rL340594: [SDAG] Add versions of computeKnownBits that return a value.
[SDAG] Add versions of computeKnownBits that return a value
Thu, Aug 23, 7:43 PM

Aug 19 2018

bogner committed rL340153: [SimplifyCFG] Replace some uses of bitwise or with logical or.
[SimplifyCFG] Replace some uses of bitwise or with logical or
Aug 19 2018, 11:38 PM

Aug 16 2018

bogner committed rL339949: [docs] Try to clarify the FuzzingLLVM docs.
[docs] Try to clarify the FuzzingLLVM docs
Aug 16 2018, 2:55 PM
bogner accepted D50701: [MI] Change the array of `MachineMemOperand` pointers to be a generically extensible collection of extra info attached to a `MachineInstr`..

lg

Aug 16 2018, 1:52 PM

Aug 15 2018

bogner added inline comments to D50701: [MI] Change the array of `MachineMemOperand` pointers to be a generically extensible collection of extra info attached to a `MachineInstr`..
Aug 15 2018, 10:32 AM

Aug 13 2018

bogner accepted D50680: [SDAG] Remove the reliance on MI's allocation strategy for `MachineMemOperand` pointers attached to `MachineSDNodes` and instead have the `SelectionDAG` fully manage the memory for this array..

LGTM as long as Hal's good with your explanation of why we can't use TinyPtrVector.

Aug 13 2018, 6:18 PM
bogner added a comment to D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3.

The cmake and lit bits all look correct

Aug 13 2018, 1:37 PM

Aug 10 2018

bogner added a comment to D50285: [MC] Remove MCRegisterClass::getSize.

What exactly are out of tree targets supposed to migrate to?

Aug 10 2018, 12:51 AM

Aug 7 2018

bogner accepted D50283: Refactor FileCheck to be used as API.

LGTM.

Aug 7 2018, 2:16 PM

Aug 3 2018

bogner added a comment to D49973: [LegalizeDAG] Fix FCOPYSIGN expansion.

This landed shortly after the 7.0 release branch was created. Should we merge it?

Aug 3 2018, 2:36 PM

Aug 1 2018

bogner added inline comments to D48850: [GISel]: Testing LegalizerHelper using Unit tests.
Aug 1 2018, 1:17 PM

Jul 26 2018

bogner accepted D49843: [CMake] Followup for r337366: Only export LLVM_LINK_LLVM_DYLIB it it's set to ON.

I believe this fixes the issues I was hitting.

Jul 26 2018, 9:44 PM

Jul 24 2018

bogner accepted D49771: CodeGen: use non-zero memset when possible for automatic variables.

Seems straightforward and correct to me.

Jul 24 2018, 5:52 PM

Jul 23 2018

bogner committed rL337718: [lit] Move the shtest-xunit-output check lines into shtest-format.
[lit] Move the shtest-xunit-output check lines into shtest-format
Jul 23 2018, 11:08 AM

Jul 19 2018

bogner added a comment to D48850: [GISel]: Testing LegalizerHelper using Unit tests.

Conceptually this looks pretty good, but we should definitely sink a lot of this implementation into lib/Support/FileCheck.cpp and anything that stays in the header should be moved into the llvm:: namespace, since this is library code now. There are a lot of overly generic names in the implementation as is (like Pattern), which is fine as long as they end up in anonymous namespaces in FileCheck.cpp but will have to be changed if they're really part of the API.

Jul 19 2018, 11:03 AM

Jul 10 2018

bogner closed D48797: [CMake] Teach the build system to codesign built products.

Committed in r336708.

Jul 10 2018, 10:38 AM
bogner committed rL336708: [CMake] Teach the build system to codesign built products.
[CMake] Teach the build system to codesign built products
Jul 10 2018, 10:37 AM

Jul 9 2018

bogner updated the diff for D48797: [CMake] Teach the build system to codesign built products.

Update to set path to codesign_allocate correctly and set the extra tool paths in platforms/iOS.cmake.

Jul 9 2018, 2:35 PM

Jul 3 2018

bogner accepted D48905: [ADT] Guard our use of function pointers in a `PointerUnion` by a dynamic check that the pointer is actually sufficiently aligned..

This fixes the segfault / asan error I was seeing in ADTTests with -Os on macOS, and the trade off with the runtime check seems pretty reasonable to me.

Jul 3 2018, 5:07 PM

Jun 29 2018

bogner created D48797: [CMake] Teach the build system to codesign built products.
Jun 29 2018, 3:14 PM

Jun 28 2018

bogner committed rL335900: [CMake] Respect CMAKE_STRIP and CMAKE_DSYMUTIL on apple platforms.
[CMake] Respect CMAKE_STRIP and CMAKE_DSYMUTIL on apple platforms
Jun 28 2018, 11:41 AM

Jun 27 2018

bogner committed rL335759: [Object] Allow iterating over an IRObjectFile's modules.
[Object] Allow iterating over an IRObjectFile's modules
Jun 27 2018, 11:03 AM

Jun 26 2018

bogner committed rL335698: [ADT] Pass DerivedT from pointe{e,r}_iterator to iterator_adaptor_base.
[ADT] Pass DerivedT from pointe{e,r}_iterator to iterator_adaptor_base
Jun 26 2018, 5:59 PM

Jun 14 2018

bogner added a comment to D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.

Already saw the bot and reverted, thanks. Fix on the way.

Jun 14 2018, 12:30 PM
bogner committed rL334756: Re-apply "[VirtRegRewriter] Avoid clobbering registers when expanding copy….
Re-apply "[VirtRegRewriter] Avoid clobbering registers when expanding copy…
Jun 14 2018, 12:28 PM
bogner added a comment to D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
Jun 14 2018, 12:21 PM
bogner committed rL334754: Revert "[VirtRegRewriter] Avoid clobbering registers when expanding copy….
Revert "[VirtRegRewriter] Avoid clobbering registers when expanding copy…
Jun 14 2018, 12:16 PM
bogner committed rL334750: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
[VirtRegRewriter] Avoid clobbering registers when expanding copy bundles
Jun 14 2018, 11:39 AM
bogner closed D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
Jun 14 2018, 11:39 AM
bogner added inline comments to D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
Jun 14 2018, 11:33 AM
bogner updated the diff for D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
Jun 14 2018, 11:33 AM

Jun 13 2018

bogner added a comment to D47999: MIR YAML TracksRegLiveness default to true in yaml parser.

Why? (As in, please update the commit message to explain why)

Jun 13 2018, 11:15 PM
bogner added inline comments to D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
Jun 13 2018, 11:09 PM
bogner updated the diff for D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
Jun 13 2018, 11:09 PM
bogner added a comment to D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.

Take a look at RAGreedy::selectOrSplit for an example on how to report fatal errors in the backend.

Jun 13 2018, 5:20 PM
bogner updated the diff for D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
Jun 13 2018, 5:20 PM
bogner created D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
Jun 13 2018, 3:02 PM
bogner accepted D47959: [DAG] Avoid needing to walk out legalization tables. NFCI..

A couple of very minor nitpicks about use of auto, below, but overall this looks very nice. LGTM.

Jun 13 2018, 2:37 PM

Jun 11 2018

bogner committed rL334452: [CMake] Fix dropped dependency in install-llvm-headers.
[CMake] Fix dropped dependency in install-llvm-headers
Jun 11 2018, 4:09 PM

Jun 7 2018

bogner accepted D47907: [tablegen] Improve performance on *GenRegisterInfo.inc by replacing SparseVector with BitVector. NFC.

This makes a lot of sense, especially given that the change to use SparseBitVector here instead of std::set specifically called out that this was to improve cases where there were dense register files. LGTM.

Jun 7 2018, 11:05 PM

May 23 2018

bogner accepted D47240: [GlobalISel][Tablegen] Assign small opcodes to pseudos.

lg

May 23 2018, 11:01 AM

May 10 2018

bogner added inline comments to D46018: [GlobalISel][IRTranslator] Split aggregates during IR translation.
May 10 2018, 2:58 PM

May 4 2018

bogner accepted D46413: [GlobalISel][Legalizer] Widening the second src op of shifts bug fix.

lgtm, thanks!

May 4 2018, 11:03 AM

May 3 2018

bogner added a comment to D46413: [GlobalISel][Legalizer] Widening the second src op of shifts bug fix.

Looks good, but please use update_llc_test_checks for the existing tests and move the test with the explanation to its own file

May 3 2018, 5:26 PM
bogner committed rL331487: Fix include of config.h that was incorrectly changed in r331184.
Fix include of config.h that was incorrectly changed in r331184
May 3 2018, 3:05 PM
bogner accepted D46288: Don't redefine a bunch of defines from llvm-config.h in config.h..
May 3 2018, 2:20 PM

May 2 2018

bogner added inline comments to D46288: Don't redefine a bunch of defines from llvm-config.h in config.h..
May 2 2018, 3:23 PM

Apr 30 2018

bogner added inline comments to D46288: Don't redefine a bunch of defines from llvm-config.h in config.h..
Apr 30 2018, 5:18 PM

Apr 26 2018

bogner committed rL330977: Specify REQUIRES: default_triple in a few tests.
Specify REQUIRES: default_triple in a few tests
Apr 26 2018, 12:21 PM

Apr 10 2018

bogner accepted D44611: [CodeGen] Allow printing MachineMemOperands with less context in SDAGDumper.

Would this be easier to follow if we overloaded printMemOperand with a variant that took the variables we're declaring here (M, MF, etc) and simply called into it? The "if (G)" condition would set them up and the "else" side would just pass null pointers.

Apr 10 2018, 11:28 AM
bogner added inline comments to D45394: Canonical Copy Propagation.
Apr 10 2018, 11:21 AM

Apr 4 2018

bogner accepted D45201: Speeding up MIR-Canon using named-vregs. .

Okay. lg as an incremental improvement.

Apr 4 2018, 1:30 PM
bogner accepted D45009: Reordering defs of a common user closer to the user in alphabetical order. .

LGTM

Apr 4 2018, 1:29 PM

Apr 3 2018

bogner added a comment to D45201: Speeding up MIR-Canon using named-vregs. .

Can we do better than just calling these namedVRegN? That is, is there a scheme where we could give these more meaningful names that would still be relatively stable between different input IRs?

Apr 3 2018, 2:57 PM
bogner added inline comments to D45009: Reordering defs of a common user closer to the user in alphabetical order. .
Apr 3 2018, 2:51 PM

Mar 30 2018

bogner accepted D44368: MIR-Canon Idempotent Instruction Hoisting..

LGTM. Thanks!

Mar 30 2018, 3:52 PM
bogner accepted D43916: Named VReg support for MIR.
Mar 30 2018, 11:49 AM

Mar 21 2018

bogner added a comment to D44132: [MIR] Making MIR Printing, opt -dot-cfg, and -debug printing faster.

Still looks good - two very nitpicky style comments below for when you commit.

Mar 21 2018, 9:45 AM
bogner added inline comments to D44368: MIR-Canon Idempotent Instruction Hoisting..
Mar 21 2018, 9:40 AM

Mar 14 2018

bogner accepted D44132: [MIR] Making MIR Printing, opt -dot-cfg, and -debug printing faster.

Nice improvement! I have a couple of minor style/clarity comments, but LGTM with those addressed.

Mar 14 2018, 2:43 PM
bogner added inline comments to D43916: Named VReg support for MIR.
Mar 14 2018, 2:26 PM
bogner accepted D42377: [CodeGen] Use MIR syntax for MachineMemOperand printing.

lg

Mar 14 2018, 2:10 PM

Mar 13 2018

bogner added inline comments to D44368: MIR-Canon Idempotent Instruction Hoisting..
Mar 13 2018, 4:05 PM
bogner added inline comments to D42377: [CodeGen] Use MIR syntax for MachineMemOperand printing.
Mar 13 2018, 3:32 PM

Mar 12 2018

bogner committed rL327305: update_mir_test_checks: Fix handling of IR input after r326284.
update_mir_test_checks: Fix handling of IR input after r326284
Mar 12 2018, 11:10 AM

Mar 8 2018

bogner added a comment to D44255: MIR-Canon tests and helper function additions. .

I've commented on both parts, but please keep each review to a single topic. Adding the test is one thing, and adding the helpers should be another review (or better yet, just add them when you use them).

Mar 8 2018, 4:19 PM
bogner accepted D44277: Avoid creating a Constant for each value in a ConstantDataSequential..

Seems straightforward enough. LGTM.

Mar 8 2018, 4:01 PM

Mar 7 2018

bogner accepted D44181: Support resetting STATISTIC() values using llvm::ResetStatistics().

LGTM

Mar 7 2018, 4:52 PM
bogner added inline comments to D44181: Support resetting STATISTIC() values using llvm::ResetStatistics().
Mar 7 2018, 11:47 AM

Mar 2 2018

bogner accepted D43901: Make STATISTIC() values available programmatically.

One last comment, then I think this is good to go.

Mar 2 2018, 5:15 PM
bogner added inline comments to D43916: Named VReg support for MIR.
Mar 2 2018, 12:02 PM
bogner added inline comments to D43901: Make STATISTIC() values available programmatically.
Mar 2 2018, 11:14 AM

Feb 28 2018

bogner accepted D43267: MIRParser: Accept overloaded intrinsic names w/o type suffixes.

Looks good, thanks

Feb 28 2018, 11:36 AM

Feb 27 2018

bogner committed rL326288: update_mir_test_checks: Use the regexes from UpdateTestChecks.common.
update_mir_test_checks: Use the regexes from UpdateTestChecks.common
Feb 27 2018, 4:59 PM
bogner committed rL326284: update_mir_test_checks: Drop support for vreg block checks.
update_mir_test_checks: Drop support for vreg block checks
Feb 27 2018, 4:47 PM
bogner accepted D42886: [GlobalISel][AArch64] Adding -disable-gisel-legality-check CL option.

Okay, I guess this makes sense for now. I think we should name the flag -disable-mir-legality-check instead of -disable-legality-check, as the current name is a bit too general sounding.

Feb 27 2018, 10:55 AM

Feb 22 2018

bogner accepted D43604: [utils] fixing update_mir_test_checks.py's language (mir/IR/etc) detection.

Looks good, pending what we decide to do about the testing.

Feb 22 2018, 11:34 AM
bogner added a comment to D43603: [utils] fixing update_mir_test_checks.py's greediness for `registers:` field.

I like the idea of adding tests for update_mir_test_checks itself, but I think we should stick to focused tests rather than just adding one that tries to test everything. I also think this isn't a great place for it, maybe we could add a test/tools/update_checks folder for tests for all of the update_*_tests scripts? We might need to fake out llc to get away with something like that though...

Feb 22 2018, 11:25 AM

Feb 21 2018

bogner added inline comments to D43583: [MIPS GlobalISel] Adding GlobalISel.
Feb 21 2018, 11:14 AM

Feb 16 2018

bogner accepted D43384: [llvm-opt-fuzzer] Add another pack of passes for continuous fuzzing.

Sure. I don't love the translations to underscores (it makes it a bit harder to map things) but I don't have a better idea offhand. Since this is starting to move towards "every pass" we should maybe consider doing something less hand rolled soon.

Feb 16 2018, 11:49 AM

Feb 9 2018

bogner committed rL324779: CMake: Allow specifying arbitrary CCACHE parameters.
CMake: Allow specifying arbitrary CCACHE parameters
Feb 9 2018, 3:27 PM

Feb 8 2018

bogner committed rL324659: CMake: Explicitly #undef LLVM_REVISION rather than using a blank file.
CMake: Explicitly #undef LLVM_REVISION rather than using a blank file
Feb 8 2018, 2:22 PM

Feb 7 2018

bogner added reviewers for D43028: Add DBG_VALUE support to the linear DAG scheduler: aprantl, dblaikie.

Seems reasonable. Adding a couple of folks who know a bit more about debug info than I do to approve this.

Feb 7 2018, 11:15 AM

Feb 5 2018

bogner added inline comments to D42887: [Driver] Add option to manually control discarding value names in LLVM IR..
Feb 5 2018, 1:12 PM
bogner added a comment to D42886: [GlobalISel][AArch64] Adding -disable-gisel-legality-check CL option.

This seems like a bit of a hack compared to actually fixing the TODO and moving this check into the MachineVerifier where it belongs.

Feb 5 2018, 11:02 AM
bogner accepted D41293: [DAG,X86] Improve Dependency analysis when doing multi-node Instruction Selection.

Seems reasonable. A couple of nitpicks.

Feb 5 2018, 10:36 AM

Feb 2 2018

bogner accepted D42414: [llvm-opt-fuzzer] Avoid adding incorrect inputs to the fuzzer corpus.

I think this is okay to go in, with the caveat that we need a plan for fixing up the verifier and removing this.

Feb 2 2018, 10:01 AM

Jan 30 2018

bogner committed rL323847: Mark two tests REQUIRES: x86-registered-backend.
Mark two tests REQUIRES: x86-registered-backend
Jan 30 2018, 11:33 PM
bogner added a comment to D42414: [llvm-opt-fuzzer] Avoid adding incorrect inputs to the fuzzer corpus.

I have mixed feelings about this, but I guess it's probably better than the status quo. My two main concerns are the time cost and whether we'll stop noticing the issues instead of fixing them.

Jan 30 2018, 11:19 AM

Jan 27 2018

bogner committed rL323608: Add triples or specify REQUIRES: default_triple to some tests.
Add triples or specify REQUIRES: default_triple to some tests
Jan 27 2018, 3:33 PM

Jan 26 2018

bogner accepted D42251: [globalisel][legalizer] Adapt LegalizerInfo to support inter-type dependencies and other things..

This is looking pretty good. Let's get it in tree so people can start using it and we can iterate more based on feedback.

Jan 26 2018, 6:38 PM
bogner committed rL323573: update_mir_test_checks: Accept "." in function names.
update_mir_test_checks: Accept "." in function names
Jan 26 2018, 2:58 PM

Jan 24 2018

bogner accepted D42439: [GISel]: Pattern Match helpers for MachineInstructions.

I find the naming conventions for the matchers kind of weird, but I see that they're meant to be familiar to users of the IR level matcher APIs so I suppose they at least make sense. Let's get this in and start using it.

Jan 24 2018, 5:11 PM