bogner (Justin Bogner)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 12 2014, 3:00 PM (222 w, 6 d)

Recent Activity

Thu, Jun 14

bogner added a comment to D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.

Already saw the bot and reverted, thanks. Fix on the way.

Thu, Jun 14, 12:30 PM
bogner committed rL334756: Re-apply "[VirtRegRewriter] Avoid clobbering registers when expanding copy….
Re-apply "[VirtRegRewriter] Avoid clobbering registers when expanding copy…
Thu, Jun 14, 12:28 PM
bogner added a comment to D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
Thu, Jun 14, 12:21 PM
bogner committed rL334754: Revert "[VirtRegRewriter] Avoid clobbering registers when expanding copy….
Revert "[VirtRegRewriter] Avoid clobbering registers when expanding copy…
Thu, Jun 14, 12:16 PM
bogner committed rL334750: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
[VirtRegRewriter] Avoid clobbering registers when expanding copy bundles
Thu, Jun 14, 11:39 AM
bogner closed D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
Thu, Jun 14, 11:39 AM
bogner added inline comments to D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
Thu, Jun 14, 11:33 AM
bogner updated the diff for D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
Thu, Jun 14, 11:33 AM

Wed, Jun 13

bogner added a comment to D47999: cl::opt ForceTrackRegLiveness for forcing liveness tracking on MIR (in MIR-Parser).

Why? (As in, please update the commit message to explain why)

Wed, Jun 13, 11:15 PM
bogner added inline comments to D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
Wed, Jun 13, 11:09 PM
bogner updated the diff for D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
Wed, Jun 13, 11:09 PM
bogner added a comment to D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.

Take a look at RAGreedy::selectOrSplit for an example on how to report fatal errors in the backend.

Wed, Jun 13, 5:20 PM
bogner updated the diff for D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
Wed, Jun 13, 5:20 PM
bogner created D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
Wed, Jun 13, 3:02 PM
bogner accepted D47959: [DAG] Avoid needing to walk out legalization tables. NFCI..

A couple of very minor nitpicks about use of auto, below, but overall this looks very nice. LGTM.

Wed, Jun 13, 2:37 PM

Mon, Jun 11

bogner committed rL334452: [CMake] Fix dropped dependency in install-llvm-headers.
[CMake] Fix dropped dependency in install-llvm-headers
Mon, Jun 11, 4:09 PM

Thu, Jun 7

bogner accepted D47907: [tablegen] Improve performance on *GenRegisterInfo.inc by replacing SparseVector with BitVector. NFC.

This makes a lot of sense, especially given that the change to use SparseBitVector here instead of std::set specifically called out that this was to improve cases where there were dense register files. LGTM.

Thu, Jun 7, 11:05 PM

Wed, May 23

bogner accepted D47240: [GlobalISel][Tablegen] Assign small opcodes to pseudos.

lg

Wed, May 23, 11:01 AM

May 10 2018

bogner added inline comments to D46018: [GlobalISel][IRTranslator] Split aggregates during IR translation.
May 10 2018, 2:58 PM

May 4 2018

bogner accepted D46413: [GlobalISel][Legalizer] Widening the second src op of shifts bug fix.

lgtm, thanks!

May 4 2018, 11:03 AM

May 3 2018

bogner added a comment to D46413: [GlobalISel][Legalizer] Widening the second src op of shifts bug fix.

Looks good, but please use update_llc_test_checks for the existing tests and move the test with the explanation to its own file

May 3 2018, 5:26 PM
bogner committed rL331487: Fix include of config.h that was incorrectly changed in r331184.
Fix include of config.h that was incorrectly changed in r331184
May 3 2018, 3:05 PM
bogner accepted D46288: Don't redefine a bunch of defines from llvm-config.h in config.h..
May 3 2018, 2:20 PM

May 2 2018

bogner added inline comments to D46288: Don't redefine a bunch of defines from llvm-config.h in config.h..
May 2 2018, 3:23 PM

Apr 30 2018

bogner added inline comments to D46288: Don't redefine a bunch of defines from llvm-config.h in config.h..
Apr 30 2018, 5:18 PM

Apr 26 2018

bogner committed rL330977: Specify REQUIRES: default_triple in a few tests.
Specify REQUIRES: default_triple in a few tests
Apr 26 2018, 12:21 PM

Apr 10 2018

bogner accepted D44611: [CodeGen] Allow printing MachineMemOperands with less context in SDAGDumper.

Would this be easier to follow if we overloaded printMemOperand with a variant that took the variables we're declaring here (M, MF, etc) and simply called into it? The "if (G)" condition would set them up and the "else" side would just pass null pointers.

Apr 10 2018, 11:28 AM
bogner added inline comments to D45394: Canonical Copy Propagation.
Apr 10 2018, 11:21 AM

Apr 4 2018

bogner accepted D45201: Speeding up MIR-Canon using named-vregs. .

Okay. lg as an incremental improvement.

Apr 4 2018, 1:30 PM
bogner accepted D45009: Reordering defs of a common user closer to the user in alphabetical order. .

LGTM

Apr 4 2018, 1:29 PM

Apr 3 2018

bogner added a comment to D45201: Speeding up MIR-Canon using named-vregs. .

Can we do better than just calling these namedVRegN? That is, is there a scheme where we could give these more meaningful names that would still be relatively stable between different input IRs?

Apr 3 2018, 2:57 PM
bogner added inline comments to D45009: Reordering defs of a common user closer to the user in alphabetical order. .
Apr 3 2018, 2:51 PM

Mar 30 2018

bogner accepted D44368: MIR-Canon Idempotent Instruction Hoisting..

LGTM. Thanks!

Mar 30 2018, 3:52 PM
bogner accepted D43916: Named VReg support for MIR.
Mar 30 2018, 11:49 AM

Mar 21 2018

bogner added a comment to D44132: [MIR] Making MIR Printing, opt -dot-cfg, and -debug printing faster.

Still looks good - two very nitpicky style comments below for when you commit.

Mar 21 2018, 9:45 AM
bogner added inline comments to D44368: MIR-Canon Idempotent Instruction Hoisting..
Mar 21 2018, 9:40 AM

Mar 14 2018

bogner accepted D44132: [MIR] Making MIR Printing, opt -dot-cfg, and -debug printing faster.

Nice improvement! I have a couple of minor style/clarity comments, but LGTM with those addressed.

Mar 14 2018, 2:43 PM
bogner added inline comments to D43916: Named VReg support for MIR.
Mar 14 2018, 2:26 PM
bogner accepted D42377: [CodeGen] Use MIR syntax for MachineMemOperand printing.

lg

Mar 14 2018, 2:10 PM

Mar 13 2018

bogner added inline comments to D44368: MIR-Canon Idempotent Instruction Hoisting..
Mar 13 2018, 4:05 PM
bogner added inline comments to D42377: [CodeGen] Use MIR syntax for MachineMemOperand printing.
Mar 13 2018, 3:32 PM

Mar 12 2018

bogner committed rL327305: update_mir_test_checks: Fix handling of IR input after r326284.
update_mir_test_checks: Fix handling of IR input after r326284
Mar 12 2018, 11:10 AM

Mar 8 2018

bogner added a comment to D44255: MIR-Canon tests and helper function additions. .

I've commented on both parts, but please keep each review to a single topic. Adding the test is one thing, and adding the helpers should be another review (or better yet, just add them when you use them).

Mar 8 2018, 4:19 PM
bogner accepted D44277: Avoid creating a Constant for each value in a ConstantDataSequential..

Seems straightforward enough. LGTM.

Mar 8 2018, 4:01 PM

Mar 7 2018

bogner accepted D44181: Support resetting STATISTIC() values using llvm::ResetStatistics().

LGTM

Mar 7 2018, 4:52 PM
bogner added inline comments to D44181: Support resetting STATISTIC() values using llvm::ResetStatistics().
Mar 7 2018, 11:47 AM

Mar 2 2018

bogner accepted D43901: Make STATISTIC() values available programmatically.

One last comment, then I think this is good to go.

Mar 2 2018, 5:15 PM
bogner added inline comments to D43916: Named VReg support for MIR.
Mar 2 2018, 12:02 PM
bogner added inline comments to D43901: Make STATISTIC() values available programmatically.
Mar 2 2018, 11:14 AM

Feb 28 2018

bogner accepted D43267: MIRParser: Accept overloaded intrinsic names w/o type suffixes.

Looks good, thanks

Feb 28 2018, 11:36 AM

Feb 27 2018

bogner committed rL326288: update_mir_test_checks: Use the regexes from UpdateTestChecks.common.
update_mir_test_checks: Use the regexes from UpdateTestChecks.common
Feb 27 2018, 4:59 PM
bogner committed rL326284: update_mir_test_checks: Drop support for vreg block checks.
update_mir_test_checks: Drop support for vreg block checks
Feb 27 2018, 4:47 PM
bogner accepted D42886: [GlobalISel][AArch64] Adding -disable-gisel-legality-check CL option.

Okay, I guess this makes sense for now. I think we should name the flag -disable-mir-legality-check instead of -disable-legality-check, as the current name is a bit too general sounding.

Feb 27 2018, 10:55 AM

Feb 22 2018

bogner accepted D43604: [utils] fixing update_mir_test_checks.py's language (mir/IR/etc) detection.

Looks good, pending what we decide to do about the testing.

Feb 22 2018, 11:34 AM
bogner added a comment to D43603: [utils] fixing update_mir_test_checks.py's greediness for `registers:` field.

I like the idea of adding tests for update_mir_test_checks itself, but I think we should stick to focused tests rather than just adding one that tries to test everything. I also think this isn't a great place for it, maybe we could add a test/tools/update_checks folder for tests for all of the update_*_tests scripts? We might need to fake out llc to get away with something like that though...

Feb 22 2018, 11:25 AM

Feb 21 2018

bogner added inline comments to D43583: [MIPS GlobalISel] Adding GlobalISel.
Feb 21 2018, 11:14 AM

Feb 16 2018

bogner accepted D43384: [llvm-opt-fuzzer] Add another pack of passes for continuous fuzzing.

Sure. I don't love the translations to underscores (it makes it a bit harder to map things) but I don't have a better idea offhand. Since this is starting to move towards "every pass" we should maybe consider doing something less hand rolled soon.

Feb 16 2018, 11:49 AM

Feb 9 2018

bogner committed rL324779: CMake: Allow specifying arbitrary CCACHE parameters.
CMake: Allow specifying arbitrary CCACHE parameters
Feb 9 2018, 3:27 PM

Feb 8 2018

bogner committed rL324659: CMake: Explicitly #undef LLVM_REVISION rather than using a blank file.
CMake: Explicitly #undef LLVM_REVISION rather than using a blank file
Feb 8 2018, 2:22 PM

Feb 7 2018

bogner added reviewers for D43028: Add DBG_VALUE support to the linear DAG scheduler: aprantl, dblaikie.

Seems reasonable. Adding a couple of folks who know a bit more about debug info than I do to approve this.

Feb 7 2018, 11:15 AM

Feb 5 2018

bogner added inline comments to D42887: [Driver] Add option to manually control discarding value names in LLVM IR..
Feb 5 2018, 1:12 PM
bogner added a comment to D42886: [GlobalISel][AArch64] Adding -disable-gisel-legality-check CL option.

This seems like a bit of a hack compared to actually fixing the TODO and moving this check into the MachineVerifier where it belongs.

Feb 5 2018, 11:02 AM
bogner accepted D41293: [DAG,X86] Improve Dependency analysis when doing multi-node Instruction Selection.

Seems reasonable. A couple of nitpicks.

Feb 5 2018, 10:36 AM

Feb 2 2018

bogner accepted D42414: [llvm-opt-fuzzer] Avoid adding incorrect inputs to the fuzzer corpus.

I think this is okay to go in, with the caveat that we need a plan for fixing up the verifier and removing this.

Feb 2 2018, 10:01 AM

Jan 30 2018

bogner committed rL323847: Mark two tests REQUIRES: x86-registered-backend.
Mark two tests REQUIRES: x86-registered-backend
Jan 30 2018, 11:33 PM
bogner added a comment to D42414: [llvm-opt-fuzzer] Avoid adding incorrect inputs to the fuzzer corpus.

I have mixed feelings about this, but I guess it's probably better than the status quo. My two main concerns are the time cost and whether we'll stop noticing the issues instead of fixing them.

Jan 30 2018, 11:19 AM

Jan 27 2018

bogner committed rL323608: Add triples or specify REQUIRES: default_triple to some tests.
Add triples or specify REQUIRES: default_triple to some tests
Jan 27 2018, 3:33 PM

Jan 26 2018

bogner accepted D42251: [globalisel][legalizer] Adapt LegalizerInfo to support inter-type dependencies and other things..

This is looking pretty good. Let's get it in tree so people can start using it and we can iterate more based on feedback.

Jan 26 2018, 6:38 PM
bogner committed rL323573: update_mir_test_checks: Accept "." in function names.
update_mir_test_checks: Accept "." in function names
Jan 26 2018, 2:58 PM

Jan 24 2018

bogner accepted D42439: [GISel]: Pattern Match helpers for MachineInstructions.

I find the naming conventions for the matchers kind of weird, but I see that they're meant to be familiar to users of the IR level matcher APIs so I suppose they at least make sense. Let's get this in and start using it.

Jan 24 2018, 5:11 PM
bogner added a comment to D42450: [utils] Convert update_{llc_,}test_checks.py to Python 3.

so I must've done something to be able to run these scripts on my machine. :)

Well installing any homebrew or macports python (which is often a dependency for other packages) will give you a python2 with the proper symlinks in place. It's usually people maintaining CI infrastructured that are bothered by macOS (or linux) default installations.

Jan 24 2018, 3:35 PM
bogner added a comment to D42251: [globalisel][legalizer] Adapt LegalizerInfo to support inter-type dependencies and other things..

It's now possible to declare multiple-opcodes together:

getActionDefinitions({G_ADD, G_SUB, G_MUL, G_AND, G_OR, G_XOR, G_SHL})
    .legalFor({s32, s64, v2s32, v4s32, v2s64})
    .clampScalar(0, s32, s64)
    .widenScalarToNextPow2(0)
    .clampNumElements(0, v2s32, v4s32)
    .clampNumElements(0, v2s64, v2s64)
    .moreElementsToNextPow2(0);
Jan 24 2018, 3:07 PM
bogner added a comment to D42450: [utils] Convert update_{llc_,}test_checks.py to Python 3.

Thanks for your attention... I'd like to see llvm moving away from legacy python2.7

Jan 24 2018, 1:10 PM
bogner added inline comments to D42251: [globalisel][legalizer] Adapt LegalizerInfo to support inter-type dependencies and other things..
Jan 24 2018, 12:07 PM

Jan 23 2018

bogner added a comment to D42402: [GISel]: Eliminate redundant copies b/w VRegs of same regclass at the end of InstructionSelection.

LGTM as long as Quentin's convinced the second iteration makes sense.

Jan 23 2018, 4:35 PM
bogner added inline comments to D42402: [GISel]: Eliminate redundant copies b/w VRegs of same regclass at the end of InstructionSelection.
Jan 23 2018, 2:19 PM
bogner accepted D41638: [llvm-extract] Support extracting basic blocks.

Looks good. If people don't like the behaviour of mixing -func and -bb we can revisit later.

Jan 23 2018, 1:30 PM
bogner added inline comments to D41638: [llvm-extract] Support extracting basic blocks.
Jan 23 2018, 12:17 PM
bogner accepted D42244: [globalisel] Introduce LegalityQuery to better encapsulate the legalizer decisions. NFC..

LGTM. I have a couple of style comments you can take or leave as you see fit.

Jan 23 2018, 11:46 AM
bogner accepted D41876: Add a utility to reduce GlobalISel tests.

Agreed, it doesn't hurt to have this in as is.

Jan 23 2018, 11:10 AM
bogner accepted D42412: [FuzzMutate] Inst deleter doesn't work with PhiNodes.

LGTM

Jan 23 2018, 11:08 AM
bogner accepted D42410: [llvm-opt-fuzzer] Add couple of popular passes.

No complaints here. One minor question about the implementation.

Jan 23 2018, 11:05 AM

Jan 22 2018

bogner committed rL323178: update_mir_test_checks: Improve the check for LLVM IR in MIR files.
update_mir_test_checks: Improve the check for LLVM IR in MIR files
Jan 22 2018, 10:40 PM

Jan 19 2018

bogner added a comment to D42286: [libfuzzer] Don't try to build tests with the just built compiler unless it's usable..

In that case, I think we should modify add_custom_libcxx and add a new argument USE_TEST_COMPILER, if not set it should use the host compiler (i.e. CMAKE_C_COMPILER and CMAKE_CXX_COMPILER). @vitalybuka WDYT?

Jan 19 2018, 1:17 PM

Jan 18 2018

bogner added inline comments to D42251: [globalisel][legalizer] Adapt LegalizerInfo to support inter-type dependencies and other things..
Jan 18 2018, 3:47 PM
bogner accepted D41804: [cmake] Fix typo in LLVM_UTILS_INSTALL_DIR definition..

This is obvious enough that it didn't really need pre-commit review. Please commit.

Jan 18 2018, 1:54 PM
bogner added a comment to D42251: [globalisel][legalizer] Adapt LegalizerInfo to support inter-type dependencies and other things..

As far as the diff goes it does look like we end up being much more verbose for simple cases (like, IMPLICIT_DEF), but OTOH the definitions we're adding are doing quite a bit more, so that's probably fine. I think the approach is reasonable.

Jan 18 2018, 1:21 PM
bogner added inline comments to D42244: [globalisel] Introduce LegalityQuery to better encapsulate the legalizer decisions. NFC..
Jan 18 2018, 12:59 PM

Jan 17 2018

bogner added a comment to D42159: [GlobalISel] Making MachineCSE runnable in the middle of the GlobalISel.

Roman asked me to commit this for him off-thread. It's r322805.

Jan 17 2018, 6:12 PM
bogner committed rL322805: GlobalISel: Make MachineCSE runnable in the middle of the GlobalISel.
GlobalISel: Make MachineCSE runnable in the middle of the GlobalISel
Jan 17 2018, 6:08 PM
bogner accepted D42159: [GlobalISel] Making MachineCSE runnable in the middle of the GlobalISel.

LGTM

Jan 17 2018, 5:45 PM
bogner added inline comments to D42159: [GlobalISel] Making MachineCSE runnable in the middle of the GlobalISel.
Jan 17 2018, 3:47 PM
bogner added inline comments to D42159: [GlobalISel] Making MachineCSE runnable in the middle of the GlobalISel.
Jan 17 2018, 9:44 AM

Jan 10 2018

bogner added a comment to D41876: Add a utility to reduce GlobalISel tests.

Could this be extended to reduce any isel related bug?

Yes, it can be extended to reduce the other ISel problems by adding a regex and the specific arguments for llc.

Jan 10 2018, 12:47 PM

Jan 9 2018

bogner accepted D41107: [FuzzMutate] Avoid using swifterror as a source operand.

I don't really like how specific of a special case this is, but I guess that's more of a problem with swifterror itself than with this pass. LGTM.

Jan 9 2018, 4:33 PM
bogner added inline comments to D41638: [llvm-extract] Support extracting basic blocks.
Jan 9 2018, 4:31 PM
bogner added inline comments to D41373: [GISel][RFC]: GlobalISel Combiner prototype.
Jan 9 2018, 2:31 PM

Jan 8 2018

bogner committed rL322033: AlwaysInliner: Alow setting InsertLifetime in the new-style pass.
AlwaysInliner: Alow setting InsertLifetime in the new-style pass
Jan 8 2018, 2:09 PM
bogner committed rL322025: ArgPromotion: Allow setting MaxElements in the new-style pass.
ArgPromotion: Allow setting MaxElements in the new-style pass
Jan 8 2018, 1:14 PM

Dec 18 2017

bogner committed rL321048: update_mir_test_checks: Accept IR as input as well as MIR.
update_mir_test_checks: Accept IR as input as well as MIR
Dec 18 2017, 4:50 PM