Page MenuHomePhabricator

[MC][ELF] Rename MC related "Associated" to "LinkedToSym"
ClosedPublic

Authored by MaskRay on Wed, Feb 5, 11:53 AM.

Details

Summary

"linked-to section" is used by the ELF spec. By analogy, "linked-to
symbol" is a good name for the signature symbol. The word "linked-to"
implies a directed edge and makes it clear its relation with "sh_link",
while one can argue that "associated" means an undirected edge.

Also, combine tests and add precise SMLoc to improve diagnostics.

Diff Detail

Event Timeline

MaskRay created this revision.Wed, Feb 5, 11:53 AM
Herald added a project: Restricted Project. · View Herald Transcript

Unit tests: pass. 62511 tests passed, 0 failed and 844 were skipped.

clang-tidy: unknown.

clang-format: unknown.

Build artifacts: CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

grimar accepted this revision.Wed, Feb 5, 11:19 PM

LGTM. Please wait to see if others are also happy with it.

This revision is now accepted and ready to land.Wed, Feb 5, 11:19 PM
jhenderson added inline comments.Thu, Feb 6, 12:55 AM
llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
698–699

AssociatedSymbol -> LinkedToSymbol?

MaskRay updated this revision to Diff 242827.Thu, Feb 6, 1:11 AM
MaskRay marked an inline comment as done.

Rename symbol

jhenderson accepted this revision.Thu, Feb 6, 1:16 AM

LGTM too. Might want to give it a bit before committing for other reviewers to have a chance to comment.

eugenis accepted this revision.Thu, Feb 6, 11:14 AM

LGTM

This revision was automatically updated to reflect the committed changes.