- User Since
- Sep 21 2015, 12:36 AM (116 w, 2 d)
Mon, Dec 11
Sorry for delay, I can check and review that tomorrow (if Rui will not approve it until that).
+1 to testcase request.
Fri, Dec 8
Thanks for comments, Rui. I'll update it after D40962 be landed (I think it will be and my patch intersects with it).
Patch LGTM, please wait for Rui approval.
This would not work for case when we have multiple .debug_type sections,
though it is legal and already supported. I'll update patch with the testcase for that
(if approach chosen by this patch be approved during current discussion in mail list).
Thu, Dec 7
- Changed message format.
Wed, Dec 6
Tue, Dec 5
Looks you forgot to add AArch64ErrataFix.cpp.
Mon, Dec 4
Addressed review comments:
- Split test into three.
- Use llvm::sys::fs::file_size API for finding output tar file size.
Sun, Dec 3
Abdndoned in favor of D39348.
Fri, Dec 1
Abandoning in according to discussions about this one in corresponding llvm-mails thread.
Not sure it was the best approach possible. Abandoning.
- Added testcase.
Was committed as r319473.
Committed version LGTM too.
Thu, Nov 30
- Use llvm::StringSet instead of std::set<std::string>.
- Addressed review comments.
Wed, Nov 29
Tue, Nov 28
Mon, Nov 27
Sat, Nov 25
Thu, Nov 23
BTW, there was a delay of 24h between commit and revert of this and no bots reported any failtures to me. I wonder why it happened ? Don't we have ones with memory sanitizer enabled ?
(I did not test it with -DLLVM_USE_SANITIZER=Memory yet, but just wonder how it is possible ?).
Wed, Nov 22
Tue, Nov 21
Mon, Nov 20
- Use StringRef in Tag instead of std::string*'. (Tag` remembers ID of Classes/Defs from Record and since patch changes type of map key from std::string to StringRef, this place should be updated.)
I just realized that I do not know if ordering is important or not. I know almost nothing about TableGen.
Some code iterates over std::map returned, but it does not automatially means ordering is really important.
Fri, Nov 17
(please wait approvement from Rui)
I have no futher comments, thanks !
Abandoning. Another approach was chosen (D40026) and landed (r318516 + r318518)
LLVM_OPTIMIZED_TABLEGEN speedups build more than 2x for me, I wonder why it is not default option. (we probably could emit warning or something that if no release binaries found to use).
Thanks for this patch, few comments/suggestions below.