grimar (George Rimar)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 21 2015, 12:36 AM (126 w, 5 d)

Recent Activity

Yesterday

grimar committed rLLD325887: [ELF] - Do not remove empty output sections that are explicitly assigned to….
[ELF] - Do not remove empty output sections that are explicitly assigned to…
Fri, Feb 23, 2:55 AM
grimar committed rL325887: [ELF] - Do not remove empty output sections that are explicitly assigned to….
[ELF] - Do not remove empty output sections that are explicitly assigned to…
Fri, Feb 23, 2:55 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Fri, Feb 23, 2:55 AM
grimar committed rLLD325879: Recommit "[ELF] - Do not crash with --emit-relocs and --icf=all together.".
Recommit "[ELF] - Do not crash with --emit-relocs and --icf=all together."
Fri, Feb 23, 2:40 AM
grimar committed rL325879: Recommit "[ELF] - Do not crash with --emit-relocs and --icf=all together.".
Recommit "[ELF] - Do not crash with --emit-relocs and --icf=all together."
Fri, Feb 23, 2:40 AM
grimar committed rLLD325878: [ELF] - Revert r325877 "[ELF] - Do not crash with --emit-relocs and --icf=all….
[ELF] - Revert r325877 "[ELF] - Do not crash with --emit-relocs and --icf=all…
Fri, Feb 23, 2:34 AM
grimar committed rL325878: [ELF] - Revert r325877 "[ELF] - Do not crash with --emit-relocs and --icf=all….
[ELF] - Revert r325877 "[ELF] - Do not crash with --emit-relocs and --icf=all…
Fri, Feb 23, 2:33 AM
grimar committed rL325877: [ELF] - Do not crash with --emit-relocs and --icf=all together..
[ELF] - Do not crash with --emit-relocs and --icf=all together.
Fri, Feb 23, 2:30 AM
grimar committed rLLD325877: [ELF] - Do not crash with --emit-relocs and --icf=all together..
[ELF] - Do not crash with --emit-relocs and --icf=all together.
Fri, Feb 23, 2:30 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Fri, Feb 23, 2:30 AM
grimar committed rL325875: [ELF] - Report error if removed empty output section declaration used undefined….
[ELF] - Report error if removed empty output section declaration used undefined…
Fri, Feb 23, 2:18 AM
grimar committed rLLD325875: [ELF] - Report error if removed empty output section declaration used undefined….
[ELF] - Report error if removed empty output section declaration used undefined…
Fri, Feb 23, 2:18 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Fri, Feb 23, 2:18 AM
grimar committed rL325874: [ELF] - Added testcase for testing visibility of weak_odr symbols..
[ELF] - Added testcase for testing visibility of weak_odr symbols.
Fri, Feb 23, 2:10 AM
grimar committed rLLD325874: [ELF] - Added testcase for testing visibility of weak_odr symbols..
[ELF] - Added testcase for testing visibility of weak_odr symbols.
Fri, Feb 23, 2:10 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Fri, Feb 23, 2:10 AM
grimar committed rLLD325873: [ELF] - Add testcase documenting flags assigned when empty synthetic section is….
[ELF] - Add testcase documenting flags assigned when empty synthetic section is…
Fri, Feb 23, 1:59 AM
grimar committed rL325873: [ELF] - Add testcase documenting flags assigned when empty synthetic section is….
[ELF] - Add testcase documenting flags assigned when empty synthetic section is…
Fri, Feb 23, 1:59 AM
grimar closed D43632: [ELF] - Add testcase documenting flags assigned when empty synthetic section is removed..
Fri, Feb 23, 1:59 AM

Thu, Feb 22

grimar committed rL325809: [ELF] - Rewrote outdated comment. NFC..
[ELF] - Rewrote outdated comment. NFC.
Thu, Feb 22, 9:55 AM
grimar committed rLLD325809: [ELF] - Rewrote outdated comment. NFC..
[ELF] - Rewrote outdated comment. NFC.
Thu, Feb 22, 9:55 AM
grimar created D43632: [ELF] - Add testcase documenting flags assigned when empty synthetic section is removed..
Thu, Feb 22, 9:49 AM
grimar added inline comments to D43574: [ELF] - Introduce getInputSections() helper..
Thu, Feb 22, 8:49 AM
grimar added inline comments to D43574: [ELF] - Introduce getInputSections() helper..
Thu, Feb 22, 8:36 AM
grimar added a comment to D43574: [ELF] - Introduce getInputSections() helper..

LGTM

Thu, Feb 22, 2:04 AM
grimar committed rLLD325763: [ELF] - Introduce getInputSections() helper..
[ELF] - Introduce getInputSections() helper.
Thu, Feb 22, 2:00 AM
grimar committed rL325763: [ELF] - Introduce getInputSections() helper..
[ELF] - Introduce getInputSections() helper.
Thu, Feb 22, 1:57 AM
grimar closed D43574: [ELF] - Introduce getInputSections() helper..
Thu, Feb 22, 1:57 AM

Wed, Feb 21

grimar created D43574: [ELF] - Introduce getInputSections() helper..
Wed, Feb 21, 7:26 AM
grimar committed rL325681: [ELF] - Simplify. NFC..
[ELF] - Simplify. NFC.
Wed, Feb 21, 6:23 AM
grimar committed rLLD325681: [ELF] - Simplify. NFC..
[ELF] - Simplify. NFC.
Wed, Feb 21, 6:23 AM
grimar created D43571: [ELF] - Do not remove empty output sections that are explicitly assigned to phdr in script..
Wed, Feb 21, 5:54 AM
grimar committed rLLD325673: [ELF] - Simplify testcase. NFC..
[ELF] - Simplify testcase. NFC.
Wed, Feb 21, 4:02 AM
grimar committed rL325673: [ELF] - Simplify testcase. NFC..
[ELF] - Simplify testcase. NFC.
Wed, Feb 21, 3:59 AM

Tue, Feb 20

grimar added inline comments to D43347: [ELF][MIPS] Support linking of PIE for MIPS.
Tue, Feb 20, 11:45 PM · lld
grimar committed rL325569: [llvm-mc] - Produce R_X86_64_PLT32 for "call/jmp foo"..
[llvm-mc] - Produce R_X86_64_PLT32 for "call/jmp foo".
Tue, Feb 20, 2:22 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Tue, Feb 20, 2:22 AM
grimar updated the summary of D43383: [llvm-mc] - Produce R_X86_64_PLT32 for "call/jmp foo"..
Tue, Feb 20, 2:18 AM
grimar committed rL325564: [MC] - Don't crash on unclosed frame..
[MC] - Don't crash on unclosed frame.
Tue, Feb 20, 1:09 AM
grimar closed D43456: [MC] - Don't crash on unclosed frame..
Tue, Feb 20, 1:09 AM

Mon, Feb 19

grimar created D43468: [ELF] - Support "INSERT AFTER" statement..
Mon, Feb 19, 7:52 AM
grimar abandoned D42482: [ELF] - Support INSERT AFTER statement in linker script..

As was reported on PR page it does not work good there. Going to try reimplement in a different way.

Mon, Feb 19, 4:55 AM
grimar updated the diff for D43456: [MC] - Don't crash on unclosed frame..
  • Add forgotten code change.
Mon, Feb 19, 3:33 AM
grimar created D43456: [MC] - Don't crash on unclosed frame..
Mon, Feb 19, 3:33 AM
grimar added a comment to D43241: [ELF] - Do not crash with --emit-relocs and --icf=all together..

replace is not designed to be smart, and adding new code there seems semantically incorrect, as replacing some section doesn't necessarily mean that its dependent sections should be marked as dead.

You could instead add code to ICF.cpp.

Mon, Feb 19, 1:05 AM
grimar updated the diff for D43241: [ELF] - Do not crash with --emit-relocs and --icf=all together..
  • Addressed comments.
Mon, Feb 19, 1:01 AM
grimar added a comment to D43383: [llvm-mc] - Produce R_X86_64_PLT32 for "call/jmp foo"..

Does this change add reference to _GLOBAL_OFFSET_TABLE_?

 [hjl@gnu-tools-1 tmp]$ cat x.s
	call foo

[hjl@gnu-tools-1 tmp]$ cat y.s

	call foo@PLT

[hjl@gnu-tools-1 tmp]$ gcc -c x.s y.s
[hjl@gnu-tools-1 tmp]$ readelf -rs x.o y.o

Mon, Feb 19, 12:13 AM

Sun, Feb 18

grimar updated the diff for D43069: [ELF] - Report error if removed empty output section declaration used undefined symbols..
  • Comment update. NFC.
Sun, Feb 18, 11:43 PM
grimar added a comment to D41640: [ELF] - Do not ignore discarding of .rela.plt/.rela.dyn, allow doing custom layout for them..

Ping.

Sun, Feb 18, 11:32 PM

Sat, Feb 17

grimar updated the diff for D43383: [llvm-mc] - Produce R_X86_64_PLT32 for "call/jmp foo"..
  • Addressed commen, added case for call foo@GOTPCREL to basic-elf-64.s.
Sat, Feb 17, 4:46 AM

Fri, Feb 16

grimar updated the diff for D43383: [llvm-mc] - Produce R_X86_64_PLT32 for "call/jmp foo"..
  • NFC update.
Fri, Feb 16, 8:24 AM
grimar updated the diff for D43234: [ELF] - Fix case of using both --icf and --symbol-ordering-file together..
  • Addressed comment.
Fri, Feb 16, 8:14 AM
grimar updated subscribers of D43383: [llvm-mc] - Produce R_X86_64_PLT32 for "call/jmp foo"..
Fri, Feb 16, 6:02 AM
grimar created D43383: [llvm-mc] - Produce R_X86_64_PLT32 for "call/jmp foo"..
Fri, Feb 16, 6:02 AM
grimar committed rL325332: [ELF] - Fix comment. NFC..
[ELF] - Fix comment. NFC.
Fri, Feb 16, 2:50 AM
grimar committed rLLD325332: [ELF] - Fix comment. NFC..
[ELF] - Fix comment. NFC.
Fri, Feb 16, 2:50 AM
grimar committed rL325331: [ELF] - Support COPY, INFO, OVERLAY output sections attributes..
[ELF] - Support COPY, INFO, OVERLAY output sections attributes.
Fri, Feb 16, 2:45 AM
grimar committed rLLD325331: [ELF] - Support COPY, INFO, OVERLAY output sections attributes..
[ELF] - Support COPY, INFO, OVERLAY output sections attributes.
Fri, Feb 16, 2:45 AM
grimar closed D43071: [ELF] - Support COPY, INFO, OVERLAY output sections attributes..
Fri, Feb 16, 2:45 AM

Thu, Feb 15

grimar added a comment to D43336: [ELF] Add ICF test case to symbol-ordering-file-warnings.s.

I also don't know. See D43234. Warning seems good idea for me.
Does it make sence to disable ICF for sections involved in ordering ?

Thu, Feb 15, 7:23 AM

Wed, Feb 14

grimar added inline comments to D43284: [ELF] Simplify handling of AT section attribute..
Wed, Feb 14, 5:21 AM · lld
grimar added inline comments to D43284: [ELF] Simplify handling of AT section attribute..
Wed, Feb 14, 5:21 AM · lld

Tue, Feb 13

grimar created D43241: [ELF] - Do not crash with --emit-relocs and --icf=all together..
Tue, Feb 13, 8:28 AM
grimar created D43234: [ELF] - Fix case of using both --icf and --symbol-ordering-file together..
Tue, Feb 13, 6:05 AM

Mon, Feb 12

grimar added inline comments to D42475: [ELF] Add warnings for various symbols that cannot be ordered.
Mon, Feb 12, 8:30 AM
grimar created D43193: [ELF] - Added testcase for testing visibility of weak_odr symbols..
Mon, Feb 12, 7:47 AM
grimar added inline comments to D42475: [ELF] Add warnings for various symbols that cannot be ordered.
Mon, Feb 12, 1:43 AM

Fri, Feb 9

grimar updated the diff for D43071: [ELF] - Support COPY, INFO, OVERLAY output sections attributes..
  • Addressed review comments.
Fri, Feb 9, 8:56 AM
grimar updated the diff for D43069: [ELF] - Report error if removed empty output section declaration used undefined symbols..
  • Reimplemented to keep output sections with custom address/align expressions alive in isAllSectionDescription.
Fri, Feb 9, 8:29 AM
grimar planned changes to D43069: [ELF] - Report error if removed empty output section declaration used undefined symbols..
Fri, Feb 9, 7:09 AM
grimar planned changes to D43071: [ELF] - Support COPY, INFO, OVERLAY output sections attributes..
Fri, Feb 9, 7:09 AM
grimar added a comment to D43071: [ELF] - Support COPY, INFO, OVERLAY output sections attributes..

I mean, for any language, if you google for some extremely minor feature of that language, I'm pretty sure that you can always find one. So the fact that you can find a use case on the internet isn't very convincing that we should support it.

Fri, Feb 9, 7:01 AM
grimar accepted D43011: [ELF] Create and export symbols provided by a linker script if they referenced by DSOs..

This LGTM, thanks (minor nit below).
Please wait for approval from other reviewers.

Fri, Feb 9, 6:34 AM · lld
grimar updated the summary of D43069: [ELF] - Report error if removed empty output section declaration used undefined symbols..
Fri, Feb 9, 6:20 AM
grimar added a comment to D43069: [ELF] - Report error if removed empty output section declaration used undefined symbols..

This patch seems somewhat irrelevant to me because the issue you found is not actually related to the issue you described in the patch description. The issue you found is that we do not recognize "(INFO)" as a special tag, and that's different from ignoring symbols in dead sections.

Fri, Feb 9, 6:19 AM

Thu, Feb 8

grimar retitled D43069: [ELF] - Report error if removed empty output section declaration used undefined symbols. from [ELF] - Report error if removed empty output section used undefined symbols. to [ELF] - Report error if removed empty output section declaration used undefined symbols..
Thu, Feb 8, 7:38 AM
grimar updated the diff for D43069: [ELF] - Report error if removed empty output section declaration used undefined symbols..
  • Simplified implementation, added missing testcases.
Thu, Feb 8, 7:22 AM
grimar planned changes to D43069: [ELF] - Report error if removed empty output section declaration used undefined symbols..

Will update soon.

Thu, Feb 8, 7:13 AM
grimar created D43071: [ELF] - Support COPY, INFO, OVERLAY output sections attributes..
Thu, Feb 8, 7:05 AM
grimar updated the summary of D43069: [ELF] - Report error if removed empty output section declaration used undefined symbols..
Thu, Feb 8, 5:45 AM
grimar created D43069: [ELF] - Report error if removed empty output section declaration used undefined symbols..
Thu, Feb 8, 5:45 AM
grimar added inline comments to D43011: [ELF] Create and export symbols provided by a linker script if they referenced by DSOs..
Thu, Feb 8, 2:09 AM · lld
grimar added a comment to D43008: [ELF] Process linker scripts deeper when declaring symbols..

LGTM with a nit.
(please wait for other reviewers approval)

Thu, Feb 8, 1:34 AM · lld
grimar accepted D43008: [ELF] Process linker scripts deeper when declaring symbols..
Thu, Feb 8, 1:34 AM · lld
grimar added a comment to D43038: [ELF] Don't sort non reorderable sections with --symbol-ordering-file.

Can we exclude such sections from Order in buildSectionOrder. With that after landing D42475 we could
warn/error on out such file entries too.

Thu, Feb 8, 1:16 AM · lld

Wed, Feb 7

grimar committed rL324574: Recommit r324455 "[ThinLTO] - Simplify code in ThinLTOBitcodeWriter.".
Recommit r324455 "[ThinLTO] - Simplify code in ThinLTOBitcodeWriter."
Wed, Feb 7, 11:26 PM
grimar closed D42971: [ThinLTO] - Simplify code in ThinLTOBitcodeWriter..
Wed, Feb 7, 11:26 PM
grimar added a comment to D42475: [ELF] Add warnings for various symbols that cannot be ordered.

I haven't gone as far as @rafael suggested on the mailing list and moved everything back into the Writer (except for the reading in), since that seemed to be against what @ruiu and @grimar prefer. I'm happy with it either way.

Wed, Feb 7, 7:43 AM
grimar requested review of D42971: [ThinLTO] - Simplify code in ThinLTOBitcodeWriter..

Sorry, I had to revert it after commit, it broke few bots.

Wed, Feb 7, 5:29 AM
grimar updated the diff for D42971: [ThinLTO] - Simplify code in ThinLTOBitcodeWriter..

Reimplemented.

Wed, Feb 7, 5:29 AM
grimar reopened D42971: [ThinLTO] - Simplify code in ThinLTOBitcodeWriter..
Wed, Feb 7, 4:15 AM
grimar added inline comments to D43011: [ELF] Create and export symbols provided by a linker script if they referenced by DSOs..
Wed, Feb 7, 4:11 AM · lld
grimar added a comment to D43008: [ELF] Process linker scripts deeper when declaring symbols..

Looks fine for me. Suggestions below.

Wed, Feb 7, 3:19 AM · lld
grimar committed rLLD324464: [ELF] - Fix BB after r324463..
[ELF] - Fix BB after r324463.
Wed, Feb 7, 1:45 AM
grimar committed rL324464: [ELF] - Fix BB after r324463..
[ELF] - Fix BB after r324463.
Wed, Feb 7, 1:44 AM
grimar committed rLLD324463: [ELF] - Remove unused synthetic sections correctly..
[ELF] - Remove unused synthetic sections correctly.
Wed, Feb 7, 1:13 AM
grimar committed rL324463: [ELF] - Remove unused synthetic sections correctly..
[ELF] - Remove unused synthetic sections correctly.
Wed, Feb 7, 1:13 AM
grimar closed D42681: [ELF] - Remove unused synthetic sections correctly..
Wed, Feb 7, 1:13 AM
grimar committed rLLD324461: [ELF] - Make defsym to work correctly with reserved symbols..
[ELF] - Make defsym to work correctly with reserved symbols.
Wed, Feb 7, 1:02 AM
grimar committed rL324461: [ELF] - Make defsym to work correctly with reserved symbols..
[ELF] - Make defsym to work correctly with reserved symbols.
Wed, Feb 7, 1:02 AM