grimar (George Rimar)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 21 2015, 12:36 AM (92 w, 4 h)

Recent Activity

Today

grimar added inline comments to D33680: [ELF] - Resolve references properly when using .symver directive.
Mon, Jun 26, 3:14 AM
grimar updated the diff for D33680: [ELF] - Resolve references properly when using .symver directive.
  • Addressed review comments.
Mon, Jun 26, 3:14 AM

Wed, Jun 21

grimar abandoned D34326: [ELF] - Support SORT_BY_INIT_PRIORITY for .ctors.*/.dtors sections in linkerscript..

Abandoning then.

Wed, Jun 21, 11:11 PM
grimar accepted D34422: Implement the --exclude-libs option..

So LGTM.

Wed, Jun 21, 5:54 AM
grimar added a comment to D34422: Implement the --exclude-libs option..

Yeah, it is really much simpler. I like this approach. Minor nits.

Wed, Jun 21, 5:52 AM
grimar added a comment to D34326: [ELF] - Support SORT_BY_INIT_PRIORITY for .ctors.*/.dtors sections in linkerscript..
In D34326#786241, @ruiu wrote:

If you use SORT_BY_INIT_PRIORITY on .ctors or .dtors, that is a misuse of the feature.

Wed, Jun 21, 3:17 AM
grimar added inline comments to D33680: [ELF] - Resolve references properly when using .symver directive.
Wed, Jun 21, 3:13 AM
grimar updated the diff for D33680: [ELF] - Resolve references properly when using .symver directive.
  • Addressed review comments.
Wed, Jun 21, 3:13 AM

Tue, Jun 20

grimar updated the diff for D34326: [ELF] - Support SORT_BY_INIT_PRIORITY for .ctors.*/.dtors sections in linkerscript..
  • Updated according to my last comment.
Tue, Jun 20, 1:29 AM

Mon, Jun 19

grimar added a comment to D34326: [ELF] - Support SORT_BY_INIT_PRIORITY for .ctors.*/.dtors sections in linkerscript..
In D34326#784305, @ruiu wrote:

I don't know if we need this, as it implements a feature that is different from what the manual says, and no one is complaining about this.

Mon, Jun 19, 12:41 PM
grimar updated the summary of D34326: [ELF] - Support SORT_BY_INIT_PRIORITY for .ctors.*/.dtors sections in linkerscript..
Mon, Jun 19, 8:04 AM
grimar planned changes to D34327: [ELF] - Produce fatal error if we not able to create DWARFContextInMemory object..
Mon, Jun 19, 7:16 AM
grimar planned changes to D34328: [ELF] - Add ability for DWARFContextInMemory to exit early when any error happen..
Mon, Jun 19, 7:15 AM
grimar updated the diff for D34326: [ELF] - Support SORT_BY_INIT_PRIORITY for .ctors.*/.dtors sections in linkerscript..
  • Changed implementation, simplified testcase.
Mon, Jun 19, 6:57 AM
grimar planned changes to D34326: [ELF] - Support SORT_BY_INIT_PRIORITY for .ctors.*/.dtors sections in linkerscript..
Mon, Jun 19, 4:06 AM
grimar retitled D34326: [ELF] - Support SORT_BY_INIT_PRIORITY for .ctors.*/.dtors sections in linkerscript. from [ELF] - Allow mixing .init_array.* and .ctors.* sections in linkerscript. to [ELF] - Support SORT_BY_INIT_PRIORITY for .ctors.*/.dtors sections in linkerscript..
Mon, Jun 19, 1:55 AM
grimar added a comment to D34326: [ELF] - Support SORT_BY_INIT_PRIORITY for .ctors.*/.dtors sections in linkerscript..

Please also note that lld doesn't really handle the case when we have mixed .ctors and .init_array from multiple object files in the non-linkerscript path.

Mon, Jun 19, 1:35 AM

Sun, Jun 18

grimar added a comment to D34328: [ELF] - Add ability for DWARFContextInMemory to exit early when any error happen..

I'd probably favor the API change of returning Expected<unique_ptr<DWARFContext>> - potentially with a backwards-compatible API that maintains the old API (& calls the new API, reports any Error and silently returns the DWARFContext). Though as you say, some callers want to continue on error - so this new API wouldn't express that.

Sun, Jun 18, 10:30 AM
grimar added a dependency for D34327: [ELF] - Produce fatal error if we not able to create DWARFContextInMemory object.: D34328: [ELF] - Add ability for DWARFContextInMemory to exit early when any error happen..
Sun, Jun 18, 8:55 AM
grimar added a dependent revision for D34328: [ELF] - Add ability for DWARFContextInMemory to exit early when any error happen.: D34327: [ELF] - Produce fatal error if we not able to create DWARFContextInMemory object..
Sun, Jun 18, 8:55 AM
grimar created D34328: [ELF] - Add ability for DWARFContextInMemory to exit early when any error happen..
Sun, Jun 18, 8:54 AM
grimar created D34327: [ELF] - Produce fatal error if we not able to create DWARFContextInMemory object..
Sun, Jun 18, 8:33 AM
grimar updated the diff for D34326: [ELF] - Support SORT_BY_INIT_PRIORITY for .ctors.*/.dtors sections in linkerscript..
  • Fixed mistype.
Sun, Jun 18, 3:48 AM
grimar added a comment to D34326: [ELF] - Support SORT_BY_INIT_PRIORITY for .ctors.*/.dtors sections in linkerscript..

Pretty much every version of gas released in the last 10 years emits exclusively .init_array.
I see what you're fixing here, but is this something that can happen in practice?

Sun, Jun 18, 3:46 AM
grimar created D34326: [ELF] - Support SORT_BY_INIT_PRIORITY for .ctors.*/.dtors sections in linkerscript..
Sun, Jun 18, 3:26 AM

Sat, Jun 17

grimar abandoned D34221: [ELF] - Resolve references properly when using .symver directive (2).

So looks we agreed to go with D33680 version for now.

Sat, Jun 17, 10:14 PM
grimar updated the diff for D33680: [ELF] - Resolve references properly when using .symver directive.
  • Removed temp vector according to review suggestions. I am sorry for delay.
Sat, Jun 17, 9:51 PM

Thu, Jun 15

grimar added inline comments to D33680: [ELF] - Resolve references properly when using .symver directive.
Thu, Jun 15, 4:49 AM
grimar updated the diff for D33680: [ELF] - Resolve references properly when using .symver directive.
  • Addressed review comments.
Thu, Jun 15, 4:49 AM

Wed, Jun 14

grimar created D34221: [ELF] - Resolve references properly when using .symver directive (2).
Wed, Jun 14, 2:28 PM
grimar updated the diff for D33680: [ELF] - Resolve references properly when using .symver directive.
  • Fixing silly last minute mistype.
Wed, Jun 14, 2:12 PM
grimar updated the diff for D33680: [ELF] - Resolve references properly when using .symver directive.

I played with few variations of this patch and found combination that looks fine for me finally.
I think this way of solving initial issue is simple and short and that is why I prefer it in general.

Wed, Jun 14, 5:17 AM

Tue, Jun 13

grimar added a comment to D34140: [ELF] Add armelf emulation mode.

Looks we want to update emulation.s to support this case too ?

Tue, Jun 13, 10:08 AM · lld

Mon, Jun 12

grimar added inline comments to D34067: Use symbols with the default version to resolve unversioned symbols..
Mon, Jun 12, 10:39 AM
grimar added a comment to D33680: [ELF] - Resolve references properly when using .symver directive.

Going to do an update I mentioned earlier for this one tomorrow, I am sorry for delay.

Mon, Jun 12, 9:08 AM

Sat, Jun 10

grimar added a comment to D33964: [LLVM][llvm-objcopy] Added basic plumbing to get things started.

Have few general comments.

Sat, Jun 10, 12:20 AM

Fri, Jun 9

grimar added a comment to D34067: Use symbols with the default version to resolve unversioned symbols..

Thanks for taking a look on that ! Really.

Fri, Jun 9, 11:31 PM
grimar committed rL305073: [ELF] - Simplify gdb-index-empty.s.
[ELF] - Simplify gdb-index-empty.s
Fri, Jun 9, 6:31 AM
grimar closed D33986: [ELF] - Simplify gdb-index-empty.s by committing rL305073: [ELF] - Simplify gdb-index-empty.s.
Fri, Jun 9, 6:31 AM
grimar committed rL305071: [ELF] - Fix build bot..
[ELF] - Fix build bot.
Fri, Jun 9, 5:58 AM
grimar committed rL305069: [ELF] - Allow producing -r output if only empty archive is given..
[ELF] - Allow producing -r output if only empty archive is given.
Fri, Jun 9, 5:27 AM
grimar closed D33937: [ELF] - Allow producing -r output if only empty archive is given. by committing rL305069: [ELF] - Allow producing -r output if only empty archive is given..
Fri, Jun 9, 5:27 AM
grimar updated the diff for D33680: [ELF] - Resolve references properly when using .symver directive.
  • Addressed comments.
Fri, Jun 9, 5:14 AM

Thu, Jun 8

grimar committed rL305054: [ELF] - Fix build bot..
[ELF] - Fix build bot.
Thu, Jun 8, 9:49 PM

Wed, Jun 7

grimar updated the diff for D33937: [ELF] - Allow producing -r output if only empty archive is given..
  • Updated.
Wed, Jun 7, 10:23 PM
grimar committed rL304927: [ELF] - Make implementation of .gdb index to be more natural for futher….
[ELF] - Make implementation of .gdb index to be more natural for futher…
Wed, Jun 7, 9:59 AM
grimar closed D33552: [ELF] - Make implementation of .gdb index to be more natural for futher paralleling. by committing rL304927: [ELF] - Make implementation of .gdb index to be more natural for futher….
Wed, Jun 7, 9:59 AM
grimar committed rL304925: [ELF] - Linkerscript: implement NOLOAD section type..
[ELF] - Linkerscript: implement NOLOAD section type.
Wed, Jun 7, 9:31 AM
grimar closed D33647: [ELF] - Linkerscript: implement NOLOAD section type. by committing rL304925: [ELF] - Linkerscript: implement NOLOAD section type..
Wed, Jun 7, 9:31 AM
grimar planned changes to D33937: [ELF] - Allow producing -r output if only empty archive is given..

Planning changes according to Rafael's comments.

Wed, Jun 7, 8:38 AM
grimar added inline comments to D33647: [ELF] - Linkerscript: implement NOLOAD section type..
Wed, Jun 7, 8:33 AM
grimar updated the diff for D33647: [ELF] - Linkerscript: implement NOLOAD section type..
  • Addressed review comments.
Wed, Jun 7, 8:33 AM
grimar updated the diff for D33552: [ELF] - Make implementation of .gdb index to be more natural for futher paralleling..
  • Rebased after recent commits done today.
Wed, Jun 7, 8:20 AM
grimar added inline comments to D33937: [ELF] - Allow producing -r output if only empty archive is given..
Wed, Jun 7, 8:03 AM
grimar updated the diff for D33937: [ELF] - Allow producing -r output if only empty archive is given..
  • Addressed review comments.
Wed, Jun 7, 8:03 AM
grimar created D33986: [ELF] - Simplify gdb-index-empty.s.
Wed, Jun 7, 5:30 AM
grimar committed rL304895: [ELF] - Simplify readAddressArea() implementation..
[ELF] - Simplify readAddressArea() implementation.
Wed, Jun 7, 3:52 AM
grimar closed D33183: [ELF] - Simplify readAddressArea() implementation. by committing rL304895: [ELF] - Simplify readAddressArea() implementation..
Wed, Jun 7, 3:52 AM
grimar added a comment to D33183: [ELF] - Simplify readAddressArea() implementation..

Rafael, Rui, thanks for review.

Wed, Jun 7, 3:48 AM
grimar committed rL304886: [ELF] - Do not merge relocation sections by name when using --emit-relocs..
[ELF] - Do not merge relocation sections by name when using --emit-relocs.
Wed, Jun 7, 2:21 AM
grimar closed D33824: [ELF] - Do not merge relocation sections by name when using --emit-relocs. by committing rL304886: [ELF] - Do not merge relocation sections by name when using --emit-relocs..
Wed, Jun 7, 2:21 AM
grimar committed rL304881: [ELF] - Linkerscript: improved error reporting..
[ELF] - Linkerscript: improved error reporting.
Wed, Jun 7, 1:55 AM
grimar closed D33943: [ELF] - Linkerscript: improved error reporting. by committing rL304881: [ELF] - Linkerscript: improved error reporting..
Wed, Jun 7, 1:55 AM

Tue, Jun 6

grimar updated the summary of D33943: [ELF] - Linkerscript: improved error reporting..
Tue, Jun 6, 8:08 AM
grimar created D33943: [ELF] - Linkerscript: improved error reporting..
Tue, Jun 6, 8:03 AM
grimar created D33937: [ELF] - Allow producing -r output if only empty archive is given..
Tue, Jun 6, 6:31 AM
grimar added a comment to D33680: [ELF] - Resolve references properly when using .symver directive.
In D33680#772682, @ruiu wrote:

I don't think we want to add a new function resolve for this feature. That function seems a bit too ad-hoc. You probably should resolve any symbol whose name is "foo@@bar" as "foo" from the beginning, by stripping "@@" and any characters that follows double-atsign before inserting symbols to the symbol table.

Tue, Jun 6, 3:13 AM
grimar added inline comments to D33552: [ELF] - Make implementation of .gdb index to be more natural for futher paralleling..
Tue, Jun 6, 1:27 AM
grimar updated the diff for D33552: [ELF] - Make implementation of .gdb index to be more natural for futher paralleling..
  • Addressed review comments.
Tue, Jun 6, 1:27 AM
grimar added a comment to D33183: [ELF] - Simplify readAddressArea() implementation..

Rui, could you look at this, please ?

Tue, Jun 6, 12:50 AM
grimar added inline comments to D33646: [ELF] - Do not crash when linkerscript applies fill to .bss..
Tue, Jun 6, 12:47 AM
grimar committed rL304777: [ELF] - Early return from writeTo() if section is SHT_NOBITS. NFCi..
[ELF] - Early return from writeTo() if section is SHT_NOBITS. NFCi.
Tue, Jun 6, 12:47 AM
grimar abandoned D33780: [ELF] - Linkerscript - do not emit multiple relocation sections when using --emit-relocs..

Consumed by D33824

Tue, Jun 6, 12:41 AM
grimar added inline comments to D33824: [ELF] - Do not merge relocation sections by name when using --emit-relocs..
Tue, Jun 6, 12:40 AM
grimar updated the diff for D33824: [ELF] - Do not merge relocation sections by name when using --emit-relocs..
  • Addressed review comments.
  • Switched to linkerscript testcase.
Tue, Jun 6, 12:39 AM
grimar added inline comments to D33647: [ELF] - Linkerscript: implement NOLOAD section type..
Tue, Jun 6, 12:06 AM
grimar updated the diff for D33647: [ELF] - Linkerscript: implement NOLOAD section type..
  • Addressed review comments.
Tue, Jun 6, 12:06 AM

Mon, Jun 5

grimar committed rL304769: [ELF] - Allow multiple comdats when producing relocatable output..
[ELF] - Allow multiple comdats when producing relocatable output.
Mon, Jun 5, 11:39 PM
grimar closed D33643: [ELF] - Allow multiple comdats when producing relocatable output. by committing rL304769: [ELF] - Allow multiple comdats when producing relocatable output..
Mon, Jun 5, 11:39 PM
grimar added inline comments to D33824: [ELF] - Do not merge relocation sections by name when using --emit-relocs..
Mon, Jun 5, 10:42 PM
grimar added a comment to D33643: [ELF] - Allow multiple comdats when producing relocatable output..
In D33643#772824, @ruiu wrote:

How can this happen? I believe we dedup SHT_GROUP sections even if the -r option is given, so we want to emit only one SHT_GROUP for each unique name, no?

Mon, Jun 5, 8:16 AM
grimar added inline comments to D33824: [ELF] - Do not merge relocation sections by name when using --emit-relocs..
Mon, Jun 5, 8:10 AM
grimar committed rL304711: [ELF] - Make LLD remove gnu-lib compression prefix (".z") after decompression….
[ELF] - Make LLD remove gnu-lib compression prefix (".z") after decompression…
Mon, Jun 5, 5:49 AM
grimar closed D33885: [ELF] - Make LLD remove gnu-lib compression prefix (".z") after decompression when using -r by committing rL304711: [ELF] - Make LLD remove gnu-lib compression prefix (".z") after decompression….
Mon, Jun 5, 5:49 AM
grimar created D33885: [ELF] - Make LLD remove gnu-lib compression prefix (".z") after decompression when using -r.
Mon, Jun 5, 1:29 AM

Fri, Jun 2

grimar created D33824: [ELF] - Do not merge relocation sections by name when using --emit-relocs..
Fri, Jun 2, 4:01 AM
grimar committed rL304539: [ELF] - Following commit for r304531 to fix BB..
[ELF] - Following commit for r304531 to fix BB.
Fri, Jun 2, 3:39 AM
grimar committed rL304531: [ELF] - Assign SHF_INFO_LINK flag to REL[A] sections..
[ELF] - Assign SHF_INFO_LINK flag to REL[A] sections.
Fri, Jun 2, 2:18 AM
grimar closed D33763: [ELF] - Assign SHF_INFO_LINK flag to REL[A] sections. by committing rL304531: [ELF] - Assign SHF_INFO_LINK flag to REL[A] sections..
Fri, Jun 2, 2:18 AM
grimar updated the diff for D33680: [ELF] - Resolve references properly when using .symver directive.
  • Addressed review comments.
Fri, Jun 2, 1:42 AM

Thu, Jun 1

grimar updated the summary of D33780: [ELF] - Linkerscript - do not emit multiple relocation sections when using --emit-relocs..
Thu, Jun 1, 8:02 AM
grimar created D33780: [ELF] - Linkerscript - do not emit multiple relocation sections when using --emit-relocs..
Thu, Jun 1, 7:56 AM
grimar created D33763: [ELF] - Assign SHF_INFO_LINK flag to REL[A] sections..
Thu, Jun 1, 2:02 AM
grimar committed rL304393: [ELF] - Properly handle R_386_GOTPC relocation..
[ELF] - Properly handle R_386_GOTPC relocation.
Thu, Jun 1, 12:54 AM
grimar closed D33717: [ELF] - Properly handle R_386_GOTPC relocation. by committing rL304393: [ELF] - Properly handle R_386_GOTPC relocation..
Thu, Jun 1, 12:54 AM
grimar committed rL304392: [ELF] - Do not crash when proccessing absolute symbols during GC..
[ELF] - Do not crash when proccessing absolute symbols during GC.
Thu, Jun 1, 12:48 AM
grimar closed D33713: [ELF] - Do not crash when proccessing absolute symbols during GC. by committing rL304392: [ELF] - Do not crash when proccessing absolute symbols during GC..
Thu, Jun 1, 12:48 AM

Wed, May 31

grimar created D33717: [ELF] - Properly handle R_386_GOTPC relocation..
Wed, May 31, 3:46 AM
grimar created D33713: [ELF] - Do not crash when proccessing absolute symbols during GC..
Wed, May 31, 1:45 AM

Tue, May 30

grimar updated the summary of D33680: [ELF] - Resolve references properly when using .symver directive.
Tue, May 30, 8:46 AM