Page MenuHomePhabricator

grimar (George Rimar)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 21 2015, 12:36 AM (260 w, 4 d)

Recent Activity

Today

grimar added inline comments to D87764: [llvm-readelf/obj] - Stop printing invalid names for unnamed section symbols..
Fri, Sep 18, 2:47 AM · Restricted Project
grimar updated the diff for D87764: [llvm-readelf/obj] - Stop printing invalid names for unnamed section symbols..
  • Addressed review comment about SHN_UNDEF section symbols.
Fri, Sep 18, 2:46 AM · Restricted Project
grimar added a comment to D87758: Provide a hook to customize missing library error handling.

Should the option name be more specific? --error-handling-script sounds like all errors can be handled with a script,
though this is only intended to be used for missing libraries errors, right?

Fri, Sep 18, 1:47 AM
grimar added inline comments to D87764: [llvm-readelf/obj] - Stop printing invalid names for unnamed section symbols..
Fri, Sep 18, 12:15 AM · Restricted Project
grimar updated the diff for D87764: [llvm-readelf/obj] - Stop printing invalid names for unnamed section symbols..
  • Addressed review comments.
Fri, Sep 18, 12:15 AM · Restricted Project

Yesterday

grimar accepted D87824: [lld][ELF][test] Add additional LTO testing.

LGTM. Worth waiting for @MaskRay or someone else opinion too.

Thu, Sep 17, 6:16 AM · Restricted Project
grimar committed rG279943edf878: [obj2yaml] - Don't emit EM_NONE. (authored by grimar).
[obj2yaml] - Don't emit EM_NONE.
Thu, Sep 17, 6:00 AM
grimar closed D87829: [obj2yaml] - Don't emit EM_NONE..
Thu, Sep 17, 6:00 AM · Restricted Project
grimar committed rG0dca1ac617d8: [llvm-readelf/obj][test] - Document what we print in various places for unnamed… (authored by grimar).
[llvm-readelf/obj][test] - Document what we print in various places for unnamed…
Thu, Sep 17, 5:57 AM
grimar closed D87763: [llvm-readelf/obj][test] - Document what we print in various places for unnamed section symbols..
Thu, Sep 17, 5:57 AM · Restricted Project
grimar requested review of D87829: [obj2yaml] - Don't emit EM_NONE..
Thu, Sep 17, 5:46 AM · Restricted Project
grimar added inline comments to D87763: [llvm-readelf/obj][test] - Document what we print in various places for unnamed section symbols..
Thu, Sep 17, 4:54 AM · Restricted Project
grimar updated the diff for D87763: [llvm-readelf/obj][test] - Document what we print in various places for unnamed section symbols..
  • Addressed review comments.
Thu, Sep 17, 4:54 AM · Restricted Project
grimar added inline comments to D87824: [lld][ELF][test] Add additional LTO testing.
Thu, Sep 17, 4:38 AM · Restricted Project

Wed, Sep 16

grimar updated the summary of D87763: [llvm-readelf/obj][test] - Document what we print in various places for unnamed section symbols..
Wed, Sep 16, 7:44 AM · Restricted Project
grimar requested review of D87764: [llvm-readelf/obj] - Stop printing invalid names for unnamed section symbols..
Wed, Sep 16, 7:43 AM · Restricted Project
grimar requested review of D87763: [llvm-readelf/obj][test] - Document what we print in various places for unnamed section symbols..
Wed, Sep 16, 7:40 AM · Restricted Project
grimar added inline comments to D86923: [llvm-readobj/elf] - Don't crash when the size of a dynamic symbol table, inferred from the hash table, is broken..
Wed, Sep 16, 2:55 AM · Restricted Project
grimar added a comment to D86923: [llvm-readobj/elf] - Don't crash when the size of a dynamic symbol table, inferred from the hash table, is broken..

Looks like this breaks tests on mac: http://45.33.8.238/mac/20491/step_11.txt

Please take a look and revert for now if it takes a while to fix.

Wed, Sep 16, 2:42 AM · Restricted Project
grimar committed rGa8d02015fcb7: [llvm-readobj][test] - Improve section-symbols.test (authored by grimar).
[llvm-readobj][test] - Improve section-symbols.test
Wed, Sep 16, 2:36 AM
grimar closed D87612: [llvm-readobj][test] - Improve section-symbols.test.
Wed, Sep 16, 2:36 AM · Restricted Project
grimar added a comment to D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..

nit: add a "[obj2yaml]" prefix to the patch name:

Wed, Sep 16, 2:03 AM · Restricted Project
grimar accepted D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..

LGTM, thanks!

Wed, Sep 16, 2:02 AM · Restricted Project
grimar added a reviewer for D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name.: jhenderson.
Wed, Sep 16, 2:02 AM · Restricted Project
grimar committed rGef4851742de5: [llvm-readobj][test] - Address a forgotten review comment for D86923. (authored by grimar).
[llvm-readobj][test] - Address a forgotten review comment for D86923.
Wed, Sep 16, 1:52 AM
grimar accepted D86137: Add ignore-unknown-options flag to clang-format..

LGTM. It worth wainting for a second approvement and/or other comments to verify that people are happy with doing this for clang-format.

Wed, Sep 16, 1:01 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Sep 15

grimar updated the diff for D87612: [llvm-readobj][test] - Improve section-symbols.test.
  • Merged tests.
Tue, Sep 15, 8:06 AM · Restricted Project
grimar committed rG7df873f9c670: [llvm-readobj/elf] - Don't crash when the size of s dynamic symbol table… (authored by grimar).
[llvm-readobj/elf] - Don't crash when the size of s dynamic symbol table…
Tue, Sep 15, 7:44 AM
grimar closed D86923: [llvm-readobj/elf] - Don't crash when the size of a dynamic symbol table, inferred from the hash table, is broken..
Tue, Sep 15, 7:44 AM · Restricted Project
grimar planned changes to D87613: [llvm-readelf/obj] - Print section symbol names properly when dumping relocations..
Tue, Sep 15, 5:06 AM · Restricted Project
grimar added inline comments to D87612: [llvm-readobj][test] - Improve section-symbols.test.
Tue, Sep 15, 3:12 AM · Restricted Project
grimar updated the diff for D87612: [llvm-readobj][test] - Improve section-symbols.test.
  • Addressed review comments.
Tue, Sep 15, 3:12 AM · Restricted Project
grimar added inline comments to D86923: [llvm-readobj/elf] - Don't crash when the size of a dynamic symbol table, inferred from the hash table, is broken..
Tue, Sep 15, 2:58 AM · Restricted Project
grimar updated the diff for D86923: [llvm-readobj/elf] - Don't crash when the size of a dynamic symbol table, inferred from the hash table, is broken..
  • Addressed review comments.
Tue, Sep 15, 2:58 AM · Restricted Project
grimar committed rGbccd2ec3e216: [llvm-readobj/elf] - Simplify and refine the implementation which dumps . (authored by grimar).
[llvm-readobj/elf] - Simplify and refine the implementation which dumps .
Tue, Sep 15, 1:57 AM
grimar closed D87362: [llvm-readobj/elf] - Simplify and refine the implementation which dumps .stack_sizes.
Tue, Sep 15, 1:57 AM · Restricted Project
grimar committed rG4845531fa88c: [lib/Object] - Refine interface of ELFFile<ELFT>. NFCI. (authored by grimar).
[lib/Object] - Refine interface of ELFFile<ELFT>. NFCI.
Tue, Sep 15, 1:39 AM
grimar closed D87385: [lib/Object] - Refine interface of ELFFile<ELFT>. NFCI..
Tue, Sep 15, 1:39 AM · Restricted Project
grimar added inline comments to D87612: [llvm-readobj][test] - Improve section-symbols.test.
Tue, Sep 15, 1:36 AM · Restricted Project

Mon, Sep 14

grimar requested review of D87613: [llvm-readelf/obj] - Print section symbol names properly when dumping relocations..
Mon, Sep 14, 7:35 AM · Restricted Project
grimar requested review of D87612: [llvm-readobj][test] - Improve section-symbols.test.
Mon, Sep 14, 7:31 AM · Restricted Project
grimar committed rG7448e64a790b: [llvm-readobj/elf] - Don't use unwrapOrError when reporting errors about… (authored by grimar).
[llvm-readobj/elf] - Don't use unwrapOrError when reporting errors about…
Mon, Sep 14, 5:02 AM
grimar closed D87503: [llvm-readobj/elf] - Don't use unwrapOrError when reporting errors about SHT_DYNAMIC sections..
Mon, Sep 14, 5:01 AM · Restricted Project
grimar committed rG14e191a0e7c5: [llvm-readobj] - Cleanup implementation LLVMStyle<ELFT>::printAddrsig(). (authored by grimar).
[llvm-readobj] - Cleanup implementation LLVMStyle<ELFT>::printAddrsig().
Mon, Sep 14, 4:52 AM
grimar closed D87507: [llvm-readobj] - Cleanup implementation LLVMStyle<ELFT>::printAddrsig()..
Mon, Sep 14, 4:52 AM · Restricted Project
grimar committed rGe9c314611bc9: [llvm-readelf/obj] - Refine and generalize the code that is used to dump notes. (authored by grimar).
[llvm-readelf/obj] - Refine and generalize the code that is used to dump notes.
Mon, Sep 14, 4:40 AM
grimar closed D87454: [llvm-readelf/obj] - Refine and generalize the code that is used to dump notes..
Mon, Sep 14, 4:40 AM · Restricted Project
grimar committed rGf4eb94e1db88: [llvm-readobj/elf][test] - Test all core note types properly. (authored by grimar).
[llvm-readobj/elf][test] - Test all core note types properly.
Mon, Sep 14, 4:27 AM
grimar closed D87453: [llvm-readobj/elf][test] - Test all core note types properly..
Mon, Sep 14, 4:27 AM · Restricted Project
grimar added inline comments to D86137: Add ignore-unknown-options flag to clang-format..
Mon, Sep 14, 4:10 AM · Restricted Project, Restricted Project, Restricted Project
grimar added a comment to D87453: [llvm-readobj/elf][test] - Test all core note types properly..

If you haven't already, could you run this test on Windows and make sure it doesn't take an unreasonable amount of time (since there are a lot of process executions, which are expensive on Windows), please. In theory, the test could be written with a single large input testing each individual value. This would make the test check/input bigger, but would at least avoid 150 or so process executions within a single test.

Mon, Sep 14, 3:44 AM · Restricted Project
grimar added inline comments to D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section..
Mon, Sep 14, 3:23 AM · Restricted Project
grimar accepted D87469: [LLD][ELF] Optimize linker script filename glob pattern matching NFC.

LGTM. Please wait for @MaskRay opinion.

Mon, Sep 14, 2:10 AM · Restricted Project
grimar accepted D87486: [ELF] Define a reportRangeError() overload for thunks and tidy up recent PPC64 thunk range errors.

LGTM

Mon, Sep 14, 1:35 AM · Restricted Project
grimar accepted D87468: [Support] Add GlobPattern::isTrivialMatchAll().

LGTM

Mon, Sep 14, 1:28 AM · Restricted Project

Fri, Sep 11

grimar requested review of D87507: [llvm-readobj] - Cleanup implementation LLVMStyle<ELFT>::printAddrsig()..
Fri, Sep 11, 4:44 AM · Restricted Project
grimar requested review of D87503: [llvm-readobj/elf] - Don't use unwrapOrError when reporting errors about SHT_DYNAMIC sections..
Fri, Sep 11, 3:36 AM · Restricted Project
grimar added a comment to D87469: [LLD][ELF] Optimize linker script filename glob pattern matching NFC.

I think this is fine approach in general. I wonder if it should/could be splitted into 2 patches though:
one for InputSectionDescription and one for SectionPattern?

Fri, Sep 11, 2:59 AM · Restricted Project
grimar added inline comments to D87468: [Support] Add GlobPattern::isTrivialMatchAll().
Fri, Sep 11, 2:34 AM · Restricted Project
grimar added inline comments to D87486: [ELF] Define a reportRangeError() overload for thunks and tidy up recent PPC64 thunk range errors.
Fri, Sep 11, 1:42 AM · Restricted Project
grimar added a comment to D87453: [llvm-readobj/elf][test] - Test all core note types properly..

Emm. I am a bit less sure about the value enumerating every value. It just repeats the getCoreNoteTypeName list in the test file. Two or three values should work, right?

Fri, Sep 11, 12:59 AM · Restricted Project

Thu, Sep 10

grimar requested review of D87454: [llvm-readelf/obj] - Refine and generalize the code that is used to dump notes..
Thu, Sep 10, 7:46 AM · Restricted Project
grimar requested review of D87453: [llvm-readobj/elf][test] - Test all core note types properly..
Thu, Sep 10, 7:07 AM · Restricted Project
grimar added inline comments to D86923: [llvm-readobj/elf] - Don't crash when the size of a dynamic symbol table, inferred from the hash table, is broken..
Thu, Sep 10, 3:49 AM · Restricted Project
grimar updated the diff for D86923: [llvm-readobj/elf] - Don't crash when the size of a dynamic symbol table, inferred from the hash table, is broken..
  • Addressed review comments.
Thu, Sep 10, 3:49 AM · Restricted Project
grimar added inline comments to D87365: [llvm-readobj] [ARMWinEH] Fix printing of exception handlers with packed epilogues.
Thu, Sep 10, 1:16 AM · Restricted Project
grimar added inline comments to D87365: [llvm-readobj] [ARMWinEH] Fix printing of exception handlers with packed epilogues.
Thu, Sep 10, 1:06 AM · Restricted Project

Wed, Sep 9

grimar requested review of D87385: [lib/Object] - Refine interface of ELFFile<ELFT>. NFCI..
Wed, Sep 9, 8:20 AM · Restricted Project
grimar requested review of D87362: [llvm-readobj/elf] - Simplify and refine the implementation which dumps .stack_sizes.
Wed, Sep 9, 4:31 AM · Restricted Project
grimar accepted D87346: [elf2yaml] Fix dumping a debug section whose name is not recognized..

LGTM

Wed, Sep 9, 1:38 AM · Restricted Project
grimar added inline comments to D87346: [elf2yaml] Fix dumping a debug section whose name is not recognized..
Wed, Sep 9, 1:18 AM · Restricted Project
grimar added inline comments to D86137: Add ignore-unknown-options flag to clang-format..
Wed, Sep 9, 12:41 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Sep 8

grimar added inline comments to D87272: [lld] Buffer writes when composing a single diagnostic.
Tue, Sep 8, 1:19 AM · Restricted Project

Mon, Sep 7

grimar updated subscribers of D86137: Add ignore-unknown-options flag to clang-format..
Mon, Sep 7, 7:27 AM · Restricted Project, Restricted Project, Restricted Project
grimar added a comment to D86137: Add ignore-unknown-options flag to clang-format..

I am not familar with clang-format, but have a few comments inlined about the rest.
I think the new setIgnoreUnknown YAMLlib API is probably OK generally.
I'd perhaps call it differently, e.g. setAllowUnknownKeys though.

Mon, Sep 7, 7:26 AM · Restricted Project, Restricted Project, Restricted Project
grimar committed rG4368739941eb: [llvm-readobj] - Remove code duplication when printing dynamic relocations. (authored by grimar).
[llvm-readobj] - Remove code duplication when printing dynamic relocations.
Mon, Sep 7, 6:12 AM
grimar closed D87089: [llvm-readobj] - Remove code duplication when printing dynamic relocations. NFCI..
Mon, Sep 7, 6:11 AM · Restricted Project
grimar committed rGdbb81881955d: [llvm-readobj/elf] - Generalize the code for printing dynamic relocations. NFCI. (authored by grimar).
[llvm-readobj/elf] - Generalize the code for printing dynamic relocations. NFCI.
Mon, Sep 7, 5:37 AM
grimar closed D87087: [llvm-readobj/elf] - Generalize the code for printing dynamic relocations. NFCI..
Mon, Sep 7, 5:37 AM · Restricted Project
grimar committed rG3a86eb03d54e: [llvm-readobj/elf] - Introduce Relocation<ELFT> helper. (authored by grimar).
[llvm-readobj/elf] - Introduce Relocation<ELFT> helper.
Mon, Sep 7, 5:09 AM
grimar closed D87141: [llvm-readobj/elf] - Introduce Relocation<ELFT> helper..
Mon, Sep 7, 5:08 AM · Restricted Project
grimar added inline comments to D87141: [llvm-readobj/elf] - Introduce Relocation<ELFT> helper..
Mon, Sep 7, 3:50 AM · Restricted Project
grimar updated the diff for D87141: [llvm-readobj/elf] - Introduce Relocation<ELFT> helper..
  • Addressed review comment.
Mon, Sep 7, 3:50 AM · Restricted Project

Fri, Sep 4

grimar updated the diff for D87087: [llvm-readobj/elf] - Generalize the code for printing dynamic relocations. NFCI..
  • Updated in according to discussion. Now depends on D87141.
Fri, Sep 4, 6:26 AM · Restricted Project
grimar requested review of D87141: [llvm-readobj/elf] - Introduce Relocation<ELFT> helper..
Fri, Sep 4, 6:22 AM · Restricted Project
grimar committed rG0faf3930c405: [llvm-readelf/obj] - Use `RelSymbol<ELFT>` instead of std::pair. NFCI. (authored by grimar).
[llvm-readelf/obj] - Use `RelSymbol<ELFT>` instead of std::pair. NFCI.
Fri, Sep 4, 3:18 AM
grimar closed D87092: [llvm-readelf/obj] - Use `RelSymbol<ELFT>` instead of std::pair. NFCI..
Fri, Sep 4, 3:18 AM · Restricted Project
grimar committed rGb7c181098675: [llvm-readobj/elf] - Refine signature of print*Reloc methods. (authored by grimar).
[llvm-readobj/elf] - Refine signature of print*Reloc methods.
Fri, Sep 4, 2:54 AM
grimar closed D87086: [llvm-readobj/elf] - Refine signature of print*Reloc methods..
Fri, Sep 4, 2:54 AM · Restricted Project
grimar added inline comments to D87087: [llvm-readobj/elf] - Generalize the code for printing dynamic relocations. NFCI..
Fri, Sep 4, 2:21 AM · Restricted Project
grimar added inline comments to D87087: [llvm-readobj/elf] - Generalize the code for printing dynamic relocations. NFCI..
Fri, Sep 4, 1:29 AM · Restricted Project
grimar updated the diff for D87087: [llvm-readobj/elf] - Generalize the code for printing dynamic relocations. NFCI..
  • Addressed review comment.
Fri, Sep 4, 1:29 AM · Restricted Project

Thu, Sep 3

grimar requested review of D87092: [llvm-readelf/obj] - Use `RelSymbol<ELFT>` instead of std::pair. NFCI..
Thu, Sep 3, 7:52 AM · Restricted Project
grimar added inline comments to D86867: [obj2yaml] Add support for dumping the .debug_str section..
Thu, Sep 3, 7:09 AM · Restricted Project
grimar updated the diff for D87087: [llvm-readobj/elf] - Generalize the code for printing dynamic relocations. NFCI..
  • Fix minor nit.
Thu, Sep 3, 6:49 AM · Restricted Project
grimar updated the diff for D87086: [llvm-readobj/elf] - Refine signature of print*Reloc methods..
  • Fix minor nit.
Thu, Sep 3, 6:47 AM · Restricted Project
grimar requested review of D87089: [llvm-readobj] - Remove code duplication when printing dynamic relocations. NFCI..
Thu, Sep 3, 6:39 AM · Restricted Project
grimar requested review of D87087: [llvm-readobj/elf] - Generalize the code for printing dynamic relocations. NFCI..
Thu, Sep 3, 6:23 AM · Restricted Project
grimar requested review of D87086: [llvm-readobj/elf] - Refine signature of print*Reloc methods..
Thu, Sep 3, 6:19 AM · Restricted Project
grimar committed rG269984e772dd: [llvm-readelf] - Move a bit of common code to printDynamicRelocHeader(). NFC. (authored by grimar).
[llvm-readelf] - Move a bit of common code to printDynamicRelocHeader(). NFC.
Thu, Sep 3, 3:32 AM