User Details
- User Since
- Sep 21 2015, 12:36 AM (391 w, 6 d)
Mar 16 2021
Mar 15 2021
I think I can accept it (with nits fixed), so LGTM. I've added few last minor comments/notes.
(there also seems to be some issues with English grammar in comments, but it is not a place where I can help much).
Mar 12 2021
Looks mostly good to me. I'd suggest to focus on refining the comments in test cases.
Currenty it is often not clear what is tested and what is expected result.
E.g:
Mar 10 2021
Few more comments. I think that error reporting could be better, we should probably use
the power of Expected<> and show the real errors, rather than hiding them under standard messages for error codes.
Mar 9 2021
I apologize for my belated feedback. I am still on vacation, but I'd like to add my 5 cents about this particular patch to try to push it forward.
Jan 30 2021
Jan 29 2021
- Addressed review comment.
- Fix the obj2yaml crash on a binary processed by llvm-strip --remove-sections. The issue happened when there was no section header table. I've fixed it and added a test case to program-headers.yaml. Note that currently obj2yaml doesn't emit a SectionHeaderTable chunk with NoHeaders = true for such a case. But this issue is unrelated to this patch, we already have the following FIXME in the eshnum.yaml test:
- Addressed review comments.
Jan 28 2021
- Addressed review comments.
- Addressed review comments.
- Improved testing.
Jan 27 2021
Jan 26 2021
Hi guys.
I am sorry for pinging this too early, but I am planning a ~6 weeks vacation starting from 1st of february
and I wonder if there is something I can do for this to land it or if there are any concerns about this change?
E.g. it seems that the expected behavior of llvm-objcopy would be to drop the sh_link for symbol table in this case. Because it is of SHT_NOBITS type.
Perhaps I'd wait from some input from @MaskRay as he was the author of the test case I think.
It turns out this wasn't NFC, one of LLDB test cases started to crash.
I've fixed it in rG2a33b092f5b175a21680b3980ff2019bc1c65b12.
I like this approach.
Jan 25 2021
- Addressed review comment.
As far I understand, looking on the description of D94239, the message on z/OS looks like "EDC5129I No such file or directory.".
I guess the EDC5129I is a stable error code? So why not to check for a possible EDC5129I prefix word instead of .*?
(The same applies for other possible errors)
A minor nit from me, the rest looks fine.
This looks to me it solves a specific corner case, but I really don't feel I have enough knowledges about embedded world/scripts to say whether it is a good or bad thing to support it.
It seems matches to what GNU ld/gold do. I'll add Peter who I guess might have an opinion about this.
Jan 22 2021
- Addressed review comments.
D95140 was posted instead.
- Addressed review comments.
Jan 21 2021
LGTM with a nit, please wait for others.
Jan 20 2021
This LGTM, but please wait for others.
@MaskRay, are you OK with it?
Jan 19 2021
Ping.
- Added test cases.
- Addressed review comment.
- Addressed review comments.
Jan 18 2021
- Format.
- Addressed review comments.