- User Since
- Sep 21 2015, 12:36 AM (174 w, 4 h)
Patch looks reasonable to me too.
! In D56920#1364896, @MaskRay wrote:
Both ld.bfd and gold have the similar "small_toc_reloc" notation and binutils-gdb/gold/power.cc does similar TOC sorting (ld.bfd has a much more complicated rule).
I think this is OK. Please wait for Rui's opinion.
I am not PPC expert, but approach itself seems probably OK to me. At least I do not have good ideas on how to do what you want much simpler/better atm.
Maybe other reviewers will have something.
Sat, Jan 19
Can it be tested with a test case?
Fri, Jan 18
Thu, Jan 17
This is probably fine.
I added a requested test showing how -all-headers now dumps the archive headers.
(and removed the old test since the new one covers the added functionality).
Thanks for the answers, James. LGTM.
This patch only moves the code and renames the few methods. No other changes were performed.
Wed, Jan 16
I think it is good. My comments are below (please wait for Rui's ones though, he might have different opinions I guess).
OK, I have no more comments.
Tue, Jan 15
Given the following external comment, can this be closed?
Mon, Jan 14
Yep, MSVS2017 works fine here for me too. Thanks, Pavel! I am abandoning it.
I ended up with the following test case:
- Addressed review comments.
Sat, Jan 12
Fri, Jan 11
Thu, Jan 10
I'll try to switch to MSVS 2017 and recheck this.
I am pretty sure we can land this because having a patch on a review for about a year is always a terrible thing. My comments are inline.