Page MenuHomePhabricator

grimar (George Rimar)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 21 2015, 12:36 AM (200 w, 6 h)

Recent Activity

Today

grimar planned changes to D64913: [yaml2obj] - Add a support for defining null sections in YAMLs..
Mon, Jul 22, 6:30 AM
grimar updated the diff for D65087: [yaml2elf] - Treat the SHT_NULL section as kind of regular section..
  • A minor simplification.
Mon, Jul 22, 6:30 AM
grimar created D65087: [yaml2elf] - Treat the SHT_NULL section as kind of regular section..
Mon, Jul 22, 6:25 AM
grimar committed rG13a364e1cc9a: [yaml2obj] - Change how we handle implicit sections. (authored by grimar).
[yaml2obj] - Change how we handle implicit sections.
Mon, Jul 22, 5:03 AM
grimar committed rL366677: [yaml2obj] - Change how we handle implicit sections..
[yaml2obj] - Change how we handle implicit sections.
Mon, Jul 22, 5:03 AM
grimar closed D64999: [yaml2obj] - Change how we handle implicit sections..
Mon, Jul 22, 5:03 AM · Restricted Project
grimar added inline comments to D64987: [Object/ELF.h] - Improve testing of the fields in ELFFile<ELFT>::sections()..
Mon, Jul 22, 4:40 AM
grimar updated the diff for D64987: [Object/ELF.h] - Improve testing of the fields in ELFFile<ELFT>::sections()..
  • Addressed review comments.
Mon, Jul 22, 4:40 AM
grimar updated the diff for D64999: [yaml2obj] - Change how we handle implicit sections..
  • Addressed review comments.
Mon, Jul 22, 3:45 AM · Restricted Project
grimar committed rL366668: [llvm-readobj] - Stop using precompiled objects in file-headers.test.
[llvm-readobj] - Stop using precompiled objects in file-headers.test
Mon, Jul 22, 3:02 AM
grimar updated the summary of D65068: [Object/llvm-readobj] - Cleanup testing of the dynamic objects..
Mon, Jul 22, 2:41 AM
grimar updated the summary of D65068: [Object/llvm-readobj] - Cleanup testing of the dynamic objects..
Mon, Jul 22, 2:38 AM
grimar created D65068: [Object/llvm-readobj] - Cleanup testing of the dynamic objects..
Mon, Jul 22, 2:38 AM
grimar added inline comments to D64999: [yaml2obj] - Change how we handle implicit sections..
Mon, Jul 22, 1:51 AM · Restricted Project
grimar committed rG6522a7df544e: [llvm-readobj] - Stop using precompiled objects in file-headers.test (authored by grimar).
[llvm-readobj] - Stop using precompiled objects in file-headers.test
Mon, Jul 22, 1:20 AM
grimar closed D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test.

r366668

Mon, Jul 22, 1:17 AM
grimar added a comment to D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test.

I am going to commit this to free road for another patches. If during futher discussion(s)
will be decided to keep these or other binaries checked in for something, we can do it
in a follow-up independent commit(s) with appropriate test case(s) and comment(s) about
how exactly binaries were produced and for what we keep them.

Mon, Jul 22, 1:17 AM
grimar added inline comments to D64999: [yaml2obj] - Change how we handle implicit sections..
Mon, Jul 22, 12:50 AM · Restricted Project
grimar updated the diff for D64999: [yaml2obj] - Change how we handle implicit sections..
  • Addressed review comments.
Mon, Jul 22, 12:50 AM · Restricted Project

Yesterday

grimar added inline comments to D64913: [yaml2obj] - Add a support for defining null sections in YAMLs..
Sun, Jul 21, 11:47 PM

Fri, Jul 19

grimar added a comment to D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test.

Is there a danger that by moving in this direction we loose some test coverage since we are no longer verifying the libObject can read a know set of binaries, but only that libObject can read the output yaml2obj?

Fri, Jul 19, 10:23 AM
grimar updated the diff for D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test.
  • --DFILE -> -DFILE
Fri, Jul 19, 8:58 AM
grimar added a comment to D64999: [yaml2obj] - Change how we handle implicit sections..

As an alternative if we do not want to make document non-const, I can introduce a new list of Section *
and populate it using Doc.Sections and new sections. yaml2elf will refer to this new list instead of Doc.Sections.
I did not try, but this also should work.

Fri, Jul 19, 8:49 AM · Restricted Project
grimar created D64999: [yaml2obj] - Change how we handle implicit sections..
Fri, Jul 19, 8:41 AM · Restricted Project
grimar requested review of D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test.

Seems fine as is. (We do not want to swich -h to --h, right?)

Fri, Jul 19, 7:01 AM
grimar planned changes to D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test.

Plan more cosmetic changes.

Fri, Jul 19, 7:00 AM
grimar updated the diff for D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test.
  • Addressed review comments.
Fri, Jul 19, 6:56 AM
grimar added inline comments to D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test.
Fri, Jul 19, 6:56 AM
grimar added a parent revision for D64987: [Object/ELF.h] - Improve testing of the fields in ELFFile<ELFT>::sections().: D64913: [yaml2obj] - Add a support for defining null sections in YAMLs..
Fri, Jul 19, 5:47 AM
grimar added a child revision for D64913: [yaml2obj] - Add a support for defining null sections in YAMLs.: D64987: [Object/ELF.h] - Improve testing of the fields in ELFFile<ELFT>::sections()..
Fri, Jul 19, 5:47 AM
grimar created D64987: [Object/ELF.h] - Improve testing of the fields in ELFFile<ELFT>::sections()..
Fri, Jul 19, 5:42 AM
grimar updated the diff for D64913: [yaml2obj] - Add a support for defining null sections in YAMLs..
  • Addressed review comment.
Fri, Jul 19, 3:24 AM
grimar updated the summary of D64913: [yaml2obj] - Add a support for defining null sections in YAMLs..
Fri, Jul 19, 3:21 AM
grimar committed rGce2ef288b20f: [llvm-readelf] - A fix for: "--hash-symbols asserts for 64-bit ELFs" (authored by grimar).
[llvm-readelf] - A fix for: "--hash-symbols asserts for 64-bit ELFs"
Fri, Jul 19, 3:16 AM
grimar committed rL366558: [llvm-readelf] - A fix for: "--hash-symbols asserts for 64-bit ELFs".
[llvm-readelf] - A fix for: "--hash-symbols asserts for 64-bit ELFs"
Fri, Jul 19, 3:15 AM
grimar closed D64788: [llvm-readelf] - A fix for: "--hash-symbols asserts for 64-bit ELFs".
Fri, Jul 19, 3:15 AM · Restricted Project
grimar added inline comments to D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test.
Fri, Jul 19, 2:45 AM

Thu, Jul 18

grimar added inline comments to D64788: [llvm-readelf] - A fix for: "--hash-symbols asserts for 64-bit ELFs".
Thu, Jul 18, 8:07 AM · Restricted Project
grimar updated the diff for D64788: [llvm-readelf] - A fix for: "--hash-symbols asserts for 64-bit ELFs".
  • Addressed review comments.
Thu, Jul 18, 8:07 AM · Restricted Project
grimar updated the diff for D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test.

I splitted the huge test into a few little,
used -DFILE to test file names, used
--strict-whitespace and --match-full-lines.

Thu, Jul 18, 8:04 AM
grimar updated the diff for D64788: [llvm-readelf] - A fix for: "--hash-symbols asserts for 64-bit ELFs".
  • Addressed review comments.
Thu, Jul 18, 5:46 AM · Restricted Project
grimar committed rG37d7cb2df0c4: [llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test (authored by grimar).
[llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test
Thu, Jul 18, 5:15 AM
grimar committed rL366430: [llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test.
[llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test
Thu, Jul 18, 5:14 AM
grimar closed D64750: [llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test..
Thu, Jul 18, 5:14 AM · Restricted Project
grimar created D64913: [yaml2obj] - Add a support for defining null sections in YAMLs..
Thu, Jul 18, 5:05 AM
grimar added a comment to D64903: [ELF] Pad the last page of last PF_X PT_LOAD with traps when -z separate-code is specified.

OK. I have no more comments.

Thu, Jul 18, 3:02 AM · Restricted Project
grimar planned changes to D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test.

I feel look we've lost some test coverage here: a number of the checked fields have gone from being non-zero to being zero. This means that we're no longer testing that the property is actually read and printed correctly, so I think the YAML needs updating in these cases.

Let me clarify. Do you mean, for example, that for COFF-ARM64, SectionCount became 0, but was non-zero before?

Yes, that's exactly what I was talking about.

(Btw, my motivation of doing this patch was: I want to simplify another test by moving its parts to another places,
like this one and eliminate. Generally I found very usefull to have no binaries in the any inputs, removing them should allow us to significantly
cleanup and improve the existent tests and also the tools).

No problem with the motivation at all. Having canned inputs can cause headaches too.

I think part of the problem is that there are WAY too many test cases in this single test file. I think it would be much simpler if we split it up into e.g. file-headers-coff.test, file-headers-elf.test etc (or similar). Further, I think they could be further divided to separate out the machine type testing from testing the other fields (i.e. having a test for file-headers-elf-machine.test or similar, which tests just the Format and Arch values). This would be a much smaller test. Only when an architecture has special behaviour for certain fields should we consider testing it more in detail. Each of the fields could then be tested individually in this way (or to a limited extent at least). It would lead to many more tests, but each individual test case would be much smaller, as it only needs to check one small thing.

I do think there is value in both 0 and non-zero values for most fields. These would become much simpler if the test cases were split up as I've described. Thus there could be elf-file-headers-section-count.s, elf-file-headers-shentsize.s, elf-file-headers-shstrndx.s, coff-file-headers-section-count.s etc.

Does that make sense? I know it's more work, and perhaps this is an okay change as an interim level, as long as we're moving towards the suggestion, and long-term don't lose test coverage.

Thu, Jul 18, 2:05 AM
grimar planned changes to D64750: [llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test..

Plan a minor change.

Thu, Jul 18, 1:51 AM · Restricted Project
grimar added a comment to D64903: [ELF] Pad the last page of last PF_X PT_LOAD with traps when -z separate-code is specified.

My first impression: seems adding the new -z separate-code/-z noseparate-code is a good thing to do. But
it is probably arguable what should be the default. Can we just keep the existent behavior as a default?

Thu, Jul 18, 12:30 AM · Restricted Project
grimar accepted D64880: ELF: Allow forward references to linked sections..

LGTM. A few "up to you" suggestions are below

Thu, Jul 18, 12:06 AM · Restricted Project

Wed, Jul 17

grimar added inline comments to D64750: [llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test..
Wed, Jul 17, 11:33 AM · Restricted Project
grimar updated the diff for D64750: [llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test..
  • Addressed review comments.
Wed, Jul 17, 11:33 AM · Restricted Project
grimar added a comment to D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test.

I feel look we've lost some test coverage here: a number of the checked fields have gone from being non-zero to being zero. This means that we're no longer testing that the property is actually read and printed correctly, so I think the YAML needs updating in these cases.

Wed, Jul 17, 10:45 AM
grimar added a comment to D64674: [llvm-readobj] Refactor dynamic string table indexing into a function..

I am OK with this patch.

Wed, Jul 17, 9:55 AM · Restricted Project

Tue, Jul 16

grimar created D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test.
Tue, Jul 16, 8:15 AM
grimar added inline comments to D64750: [llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test..
Tue, Jul 16, 5:32 AM · Restricted Project
grimar added inline comments to D64750: [llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test..
Tue, Jul 16, 5:14 AM · Restricted Project
grimar updated the diff for D64750: [llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test..
  • Addressed review comments.
Tue, Jul 16, 5:13 AM · Restricted Project
grimar planned changes to D64750: [llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test..

I did not see MaskRay`s comments. Going to address them.

Tue, Jul 16, 5:09 AM · Restricted Project
grimar added inline comments to D64750: [llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test..
Tue, Jul 16, 5:07 AM · Restricted Project
grimar updated the diff for D64750: [llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test..
  • Addressed review comments.
Tue, Jul 16, 5:07 AM · Restricted Project
grimar committed rGa1370877d7f4: [Object/llvm-readelf/llvm-readobj] - Improve error reporting when e_shstrndx is… (authored by grimar).
[Object/llvm-readelf/llvm-readobj] - Improve error reporting when e_shstrndx is…
Tue, Jul 16, 4:09 AM
grimar committed rL366203: [Object/llvm-readelf/llvm-readobj] - Improve error reporting when e_shstrndx is….
[Object/llvm-readelf/llvm-readobj] - Improve error reporting when e_shstrndx is…
Tue, Jul 16, 4:07 AM
grimar closed D64714: [Object/llvm-readelf/llvm-readobj] - Improve error reporting when e_shstrndx is broken..
Tue, Jul 16, 4:07 AM · Restricted Project
grimar added inline comments to D64788: [llvm-readelf] - A fix for: "--hash-symbols asserts for 64-bit ELFs".
Tue, Jul 16, 3:22 AM · Restricted Project
grimar added inline comments to D64788: [llvm-readelf] - A fix for: "--hash-symbols asserts for 64-bit ELFs".
Tue, Jul 16, 2:44 AM · Restricted Project
grimar updated the diff for D64788: [llvm-readelf] - A fix for: "--hash-symbols asserts for 64-bit ELFs".
  • Updated comments.
Tue, Jul 16, 2:12 AM · Restricted Project
grimar created D64788: [llvm-readelf] - A fix for: "--hash-symbols asserts for 64-bit ELFs".
Tue, Jul 16, 2:09 AM · Restricted Project
grimar added a child revision for D64750: [llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test.: D64788: [llvm-readelf] - A fix for: "--hash-symbols asserts for 64-bit ELFs".
Tue, Jul 16, 2:09 AM · Restricted Project
grimar added inline comments to D64714: [Object/llvm-readelf/llvm-readobj] - Improve error reporting when e_shstrndx is broken..
Tue, Jul 16, 1:27 AM · Restricted Project
grimar updated the diff for D64714: [Object/llvm-readelf/llvm-readobj] - Improve error reporting when e_shstrndx is broken..
  • Addressed review comments.
Tue, Jul 16, 1:26 AM · Restricted Project
grimar updated the diff for D64750: [llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test..
  • Addressed review comments.
Tue, Jul 16, 1:18 AM · Restricted Project
grimar added inline comments to D64674: [llvm-readobj] Refactor dynamic string table indexing into a function..
Tue, Jul 16, 1:02 AM · Restricted Project
grimar added inline comments to D64674: [llvm-readobj] Refactor dynamic string table indexing into a function..
Tue, Jul 16, 12:21 AM · Restricted Project

Mon, Jul 15

grimar created D64750: [llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test..
Mon, Jul 15, 9:04 AM · Restricted Project
grimar updated the diff for D64714: [Object/llvm-readelf/llvm-readobj] - Improve error reporting when e_shstrndx is broken..
  • Addressed review comments.
Mon, Jul 15, 6:35 AM · Restricted Project
grimar added a comment to D64714: [Object/llvm-readelf/llvm-readobj] - Improve error reporting when e_shstrndx is broken..

I wonder if it would make sense if the file name was included in the error message, at least in the llvm-readobj/llvm-readelf case? In that case, there can be more than one file, or indeed it could be an archive member that is broken, so reporting the file name would make sense.

Mon, Jul 15, 5:16 AM · Restricted Project
grimar committed rG224816ba1699: Recommit r366052 "[obj2yaml] - Rework tool's error reporting logic for ELF… (authored by grimar).
Recommit r366052 "[obj2yaml] - Rework tool's error reporting logic for ELF…
Mon, Jul 15, 4:55 AM
grimar committed rL366058: Recommit r366052 "[obj2yaml] - Rework tool's error reporting logic for ELF….
Recommit r366052 "[obj2yaml] - Rework tool's error reporting logic for ELF…
Mon, Jul 15, 4:53 AM
grimar committed rG8d9b9f6bf2cd: [LLD][ELF] - Minor simplification. NFC. (authored by grimar).
[LLD][ELF] - Minor simplification. NFC.
Mon, Jul 15, 4:49 AM
grimar committed rL366057: [LLD][ELF] - Minor simplification. NFC..
[LLD][ELF] - Minor simplification. NFC.
Mon, Jul 15, 4:49 AM
grimar committed rGb91403d46701: Revert r366052 "[obj2yaml] - Rework tool's error reporting logic for ELF target. (authored by grimar).
Revert r366052 "[obj2yaml] - Rework tool's error reporting logic for ELF target.
Mon, Jul 15, 4:02 AM
grimar committed rL366053: Revert r366052 "[obj2yaml] - Rework tool's error reporting logic for ELF target..
Revert r366052 "[obj2yaml] - Rework tool's error reporting logic for ELF target.
Mon, Jul 15, 4:00 AM
grimar committed rG309246e4e2fe: [obj2yaml] - Rework tool's error reporting logic for ELF target. (authored by grimar).
[obj2yaml] - Rework tool's error reporting logic for ELF target.
Mon, Jul 15, 3:51 AM
grimar committed rL366052: [obj2yaml] - Rework tool's error reporting logic for ELF target..
[obj2yaml] - Rework tool's error reporting logic for ELF target.
Mon, Jul 15, 3:50 AM
grimar closed D64631: [obj2yaml] - Rework tool's error reporting logic for ELF target..
Mon, Jul 15, 3:50 AM · Restricted Project
grimar created D64714: [Object/llvm-readelf/llvm-readobj] - Improve error reporting when e_shstrndx is broken..
Mon, Jul 15, 3:48 AM · Restricted Project
grimar added inline comments to D64631: [obj2yaml] - Rework tool's error reporting logic for ELF target..
Mon, Jul 15, 2:00 AM · Restricted Project
grimar updated the diff for D64631: [obj2yaml] - Rework tool's error reporting logic for ELF target..
  • Addressed review comments.
Mon, Jul 15, 2:00 AM · Restricted Project
grimar added inline comments to D64631: [obj2yaml] - Rework tool's error reporting logic for ELF target..
Mon, Jul 15, 1:30 AM · Restricted Project
grimar updated the diff for D64631: [obj2yaml] - Rework tool's error reporting logic for ELF target..
  • Addressed review comments.
Mon, Jul 15, 1:30 AM · Restricted Project
grimar added inline comments to D64674: [llvm-readobj] Refactor dynamic string table indexing into a function..
Mon, Jul 15, 12:51 AM · Restricted Project

Fri, Jul 12

grimar created D64631: [obj2yaml] - Rework tool's error reporting logic for ELF target..
Fri, Jul 12, 6:21 AM · Restricted Project
grimar committed rG75874ca31ef0: [test/Object, obj2yaml] - Move test cases from test/Object and cleanup. (authored by grimar).
[test/Object, obj2yaml] - Move test cases from test/Object and cleanup.
Fri, Jul 12, 3:30 AM
grimar committed rL365891: [test/Object, obj2yaml] - Move test cases from test/Object and cleanup..
[test/Object, obj2yaml] - Move test cases from test/Object and cleanup.
Fri, Jul 12, 3:30 AM
grimar closed D64555: [test/Object, obj2yaml] - Move test cases from test/Object and cleanup..
Fri, Jul 12, 3:30 AM · Restricted Project
grimar updated the diff for D64555: [test/Object, obj2yaml] - Move test cases from test/Object and cleanup..
  • Addressed review comments.
Fri, Jul 12, 3:16 AM · Restricted Project
grimar added inline comments to D64555: [test/Object, obj2yaml] - Move test cases from test/Object and cleanup..
Fri, Jul 12, 3:16 AM · Restricted Project
grimar committed rG52d85fc3cfa7: [Object/ELF] - Improve error reporting for notes. (authored by grimar).
[Object/ELF] - Improve error reporting for notes.
Fri, Jul 12, 2:30 AM
grimar committed rL365884: [Object/ELF] - Improve error reporting for notes..
[Object/ELF] - Improve error reporting for notes.
Fri, Jul 12, 2:29 AM