Page MenuHomePhabricator

grimar (George Rimar)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 21 2015, 12:36 AM (236 w, 1 d)

Recent Activity

Today

grimar committed rGb3f13bc16575: [obj2yaml] - Teach tool to dump program headers. (authored by grimar).
[obj2yaml] - Teach tool to dump program headers.
Tue, Mar 31, 8:17 AM
grimar closed D75342: [obj2yaml] - Teach tool to dump program headers..
Tue, Mar 31, 8:17 AM · Restricted Project
grimar updated the diff for D76834: [yaml2obj] - Add NBucket and NChain fields for the SHT_HASH section..
  • Fixed a gcc compilation issue .
Tue, Mar 31, 8:16 AM
grimar created D77147: [llvm-readobj] - Do not crash when SHT_HASH table is broken..
Tue, Mar 31, 8:16 AM
grimar added a child revision for D76834: [yaml2obj] - Add NBucket and NChain fields for the SHT_HASH section.: D77147: [llvm-readobj] - Do not crash when SHT_HASH table is broken..
Tue, Mar 31, 8:16 AM
grimar added a comment to D76851: [lld][ELF][test] Improve deplib.s.

The update LG too.

Tue, Mar 31, 4:56 AM · Restricted Project
grimar added inline comments to D76999: [ELF] Print versioned name for better "undefined symbol" diagnostics.
Tue, Mar 31, 4:23 AM · Restricted Project
grimar accepted D76915: [LLD][ELF] Allow empty (.init|.preinit|.fini)_array to be RELRO.

LGTM with 2 nits.

Tue, Mar 31, 2:42 AM · Restricted Project
grimar added inline comments to D76915: [LLD][ELF] Allow empty (.init|.preinit|.fini)_array to be RELRO.
Tue, Mar 31, 2:42 AM · Restricted Project
grimar accepted D76851: [lld][ELF][test] Improve deplib.s.

LGTM. Have a suggestion inlined though.

Tue, Mar 31, 2:10 AM · Restricted Project

Yesterday

grimar committed rG4cbfb98eb362: [llvm-readobj] - Improve test of --elf-hash-histogram option. (authored by grimar).
[llvm-readobj] - Improve test of --elf-hash-histogram option.
Mon, Mar 30, 5:55 AM
grimar closed D76920: [llvm-readobj] - Improve test of --elf-hash-histogram option..
Mon, Mar 30, 5:55 AM · Restricted Project
grimar added inline comments to D76920: [llvm-readobj] - Improve test of --elf-hash-histogram option..
Mon, Mar 30, 5:22 AM · Restricted Project
grimar updated the diff for D76920: [llvm-readobj] - Improve test of --elf-hash-histogram option..
  • Addressed review comments.
Mon, Mar 30, 5:22 AM · Restricted Project
grimar committed rG821439a45a26: [llvm-readobj][test] - Simplify hash-symbols test. (authored by grimar).
[llvm-readobj][test] - Simplify hash-symbols test.
Mon, Mar 30, 4:50 AM
grimar closed D76924: [llvm-readobj][test] - Simplify hash-symbols.test test..
Mon, Mar 30, 4:50 AM · Restricted Project
grimar added inline comments to D76999: [ELF] Print versioned name for better "undefined symbol" diagnostics.
Mon, Mar 30, 4:17 AM · Restricted Project
grimar added a comment to D76995: [ELF] Propagate LMA offset to sections with neither AT() nor AT>.

This looks fine to me. I'd suggest to wait for Peter's opinion regarding this.

Mon, Mar 30, 3:44 AM · Restricted Project
grimar added inline comments to D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.
Mon, Mar 30, 2:07 AM · Restricted Project

Fri, Mar 27

grimar updated the summary of D76924: [llvm-readobj][test] - Simplify hash-symbols.test test..
Fri, Mar 27, 8:12 AM · Restricted Project
grimar added a comment to D76834: [yaml2obj] - Add NBucket and NChain fields for the SHT_HASH section..

Going to work and post a patch that uses this functionality.

Fri, Mar 27, 7:03 AM
grimar created D76924: [llvm-readobj][test] - Simplify hash-symbols.test test..
Fri, Mar 27, 7:03 AM · Restricted Project
grimar created D76920: [llvm-readobj] - Improve test of --elf-hash-histogram option..
Fri, Mar 27, 5:56 AM · Restricted Project
grimar committed rG30c1f9a5584e: [llvm-readobj] - Fix a crash when DT_STRTAB is broken. (authored by grimar).
[llvm-readobj] - Fix a crash when DT_STRTAB is broken.
Fri, Mar 27, 3:45 AM
grimar added inline comments to D75342: [obj2yaml] - Teach tool to dump program headers..
Fri, Mar 27, 3:45 AM · Restricted Project
grimar updated the diff for D75342: [obj2yaml] - Teach tool to dump program headers..
  • Addressed review comments.
Fri, Mar 27, 3:45 AM · Restricted Project
grimar closed D76706: [llvm-readobj] - Fix the crash when DT_STRTAB is broken..
Fri, Mar 27, 3:44 AM · Restricted Project
grimar updated subscribers of D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.
Fri, Mar 27, 2:38 AM · Restricted Project
grimar added inline comments to D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.
Fri, Mar 27, 2:38 AM · Restricted Project

Thu, Mar 26

grimar accepted D76846: [lld][ELF] Fix error message.

LGTM

Thu, Mar 26, 8:06 AM · Restricted Project
grimar updated the diff for D76834: [yaml2obj] - Add NBucket and NChain fields for the SHT_HASH section..
  • Addressed review comments.
Thu, Mar 26, 7:33 AM
grimar added inline comments to D76706: [llvm-readobj] - Fix the crash when DT_STRTAB is broken..
Thu, Mar 26, 7:00 AM · Restricted Project
grimar updated the diff for D76706: [llvm-readobj] - Fix the crash when DT_STRTAB is broken..
  • Addressed review comments.
Thu, Mar 26, 7:00 AM · Restricted Project
grimar added inline comments to D75342: [obj2yaml] - Teach tool to dump program headers..
Thu, Mar 26, 5:23 AM · Restricted Project
grimar updated the diff for D75342: [obj2yaml] - Teach tool to dump program headers..
  • Addressed review comments, rebased.
Thu, Mar 26, 5:23 AM · Restricted Project
grimar committed rGaefec9ed77f6: [obj2yaml] - Refactor how we dump sections. NFCI. (authored by grimar).
[obj2yaml] - Refactor how we dump sections. NFCI.
Thu, Mar 26, 4:18 AM
grimar closed D76684: [obj2yaml] - Refactor how we dump sections. NFCI..
Thu, Mar 26, 4:18 AM · Restricted Project
grimar created D76834: [yaml2obj] - Add NBucket and NChain fields for the SHT_HASH section..
Thu, Mar 26, 3:44 AM
grimar removed a reviewer for D57975: [ObjectYAML] Let dynamic entries use section names as values: grimar.
Thu, Mar 26, 2:07 AM · Restricted Project
grimar added a comment to D76746: [MC][ARM] Make .reloc support arbitrary relocation types.

I have no more comments either, but I do not feel I am a right person to accept.

Thu, Mar 26, 2:07 AM · Restricted Project
grimar added a comment to D76410: [ELF] Don't combine SHF_LINK_ORDER sections linking different output sections.

I actually started a generic-abi thread just after I created the patch. https://groups.google.com/g/generic-abi/c/avQCrdIALKE

Shows Error 404 for me..

Updated to a link I found in incognito mode...

Thu, Mar 26, 2:07 AM · Restricted Project
grimar added a comment to D76765: [LLD][ELF] - Linkerscript: support the case when INPUT_SECTION_FLAGS is used without section patterns..
The raw wildcard syntax is questionable because it can potentially cause parsing ambiguity.

...
I also left a comment on https://bugs.llvm.org/show_bug.cgi?id=39885

Thu, Mar 26, 1:35 AM

Wed, Mar 25

grimar accepted D76777: [NFC][llvm-readobj] Refactor unique warning handler.

LGTM

Wed, Mar 25, 9:44 AM · Restricted Project
grimar updated the diff for D76765: [LLD][ELF] - Linkerscript: support the case when INPUT_SECTION_FLAGS is used without section patterns..
  • Move the new test case to a proper position in the file.
Wed, Mar 25, 5:22 AM
grimar created D76765: [LLD][ELF] - Linkerscript: support the case when INPUT_SECTION_FLAGS is used without section patterns..
Wed, Mar 25, 5:22 AM
grimar updated the diff for D76684: [obj2yaml] - Refactor how we dump sections. NFCI..
  • Addressed review comments.
Wed, Mar 25, 3:13 AM · Restricted Project
grimar added inline comments to D76684: [obj2yaml] - Refactor how we dump sections. NFCI..
Wed, Mar 25, 3:13 AM · Restricted Project
grimar added inline comments to D76746: [MC][ARM] Make .reloc support arbitrary relocation types.
Wed, Mar 25, 2:40 AM · Restricted Project
grimar added inline comments to D76754: [MC][AArch64] Make .reloc support arbitrary relocation types.
Wed, Mar 25, 2:40 AM · Restricted Project
grimar added inline comments to D76746: [MC][ARM] Make .reloc support arbitrary relocation types.
Wed, Mar 25, 2:40 AM · Restricted Project
grimar added a comment to D76410: [ELF] Don't combine SHF_LINK_ORDER sections linking different output sections.

I actually started a generic-abi thread just after I created the patch. https://groups.google.com/g/generic-abi/c/avQCrdIALKE

Wed, Mar 25, 2:08 AM · Restricted Project
grimar added a comment to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

I do not have a good answer right now. Seems the API could be revisited and refined.
section_begin() and section_end() just ignore errors now.
symbol_begin() has a different logic from dynamic_symbol_begin that does not look ideal to me either:

DataRefImpl Sym =
    toDRI(DotSymtabSec,
          DotSymtabSec && DotSymtabSec->sh_size >= sizeof(Elf_Sym) ? 1 : 0);

(it is unclear to me how it works when sh_size==1, for example)

When sh_size == 1, it's similar to toDRI(DotSymtabSec, 0) and symbol_end() will return toDRI(DotSymtabSec, sh_size / sizeof(Elf_Sym). Hence, no symbol is returned.

Wed, Mar 25, 1:35 AM · Restricted Project

Tue, Mar 24

grimar retitled D76706: [llvm-readobj] - Fix the crash when DT_STRTAB is broken. from [llvm-readobj] - Fix a crash when DT_STRTAB is broken. to [llvm-readobj] - Fix the crash when DT_STRTAB is broken..
Tue, Mar 24, 8:02 AM · Restricted Project
grimar created D76706: [llvm-readobj] - Fix the crash when DT_STRTAB is broken..
Tue, Mar 24, 8:02 AM · Restricted Project
grimar added a comment to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

I do not have a good answer right now. Seems the API could be revisited and refined.
section_begin() and section_end() just ignore errors now.
symbol_begin() has a different logic from dynamic_symbol_begin that does not look ideal to me either:

Tue, Mar 24, 8:02 AM · Restricted Project
grimar added a comment to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.
  • Make llvm-nm imitate gnu-nm's behavior.

    To make llvm-nm behave like gnu-nm, I have to remove sh_size % sizeof(Elf_Sym) check in dynamic_symbol_begin(), I'm wondering if @grimar is happy with this, since you are concerned about this.
Tue, Mar 24, 6:24 AM · Restricted Project
grimar created D76684: [obj2yaml] - Refactor how we dump sections. NFCI..
Tue, Mar 24, 4:16 AM · Restricted Project
grimar added inline comments to D75342: [obj2yaml] - Teach tool to dump program headers..
Tue, Mar 24, 3:44 AM · Restricted Project
grimar added inline comments to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.
Tue, Mar 24, 2:39 AM · Restricted Project
grimar added a comment to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

Almost there.
I also think that comments in the test perhaps need a bit of polishing, but I am not a native speaker to suggest much better versions, so will refrain.

Tue, Mar 24, 2:39 AM · Restricted Project

Mon, Mar 23

grimar added a comment to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

Can we use these tests as --dynamic dedicated tests as well (@jhenderson metioned here)?

Mon, Mar 23, 7:03 AM · Restricted Project
grimar added a comment to D75342: [obj2yaml] - Teach tool to dump program headers..

Note: I've changed implementation slightly. Now we dump all sections and then after dumping program headers we remove sections we do not want to see in an output.
It allows us to dump sections in one place and work with array of Chunks. It also should help to support Filler and seems makes the whole logic a bit nicer (in context of this patch).

Mon, Mar 23, 6:30 AM · Restricted Project
grimar updated the diff for D75342: [obj2yaml] - Teach tool to dump program headers..
  • Changed implementation to support non-allocatable sections as requested.
  • Addressed review comments.
Mon, Mar 23, 6:30 AM · Restricted Project
grimar added inline comments to D75342: [obj2yaml] - Teach tool to dump program headers..
Mon, Mar 23, 6:30 AM · Restricted Project
grimar added a comment to D76575: [LLD][ELF][ARM] Replace assembler files with yaml.

I think it is fine. When llvm-mc can't be used it is a job for yaml2obj.

Mon, Mar 23, 2:10 AM
grimar accepted D75225: [ELF] Keep orphan section names (.rodata.foo .text.foo) unchanged if !hasSectionsCommand.

LGTM

Mon, Mar 23, 1:38 AM · Restricted Project

Sat, Mar 21

grimar committed rG601d25cb736d: [obj2yaml] - Simplify and reduce `ELFDumper<ELFT>::dumpSections`. NFCI. (authored by grimar).
[obj2yaml] - Simplify and reduce `ELFDumper<ELFT>::dumpSections`. NFCI.
Sat, Mar 21, 8:33 AM
grimar closed D76499: [obj2yaml] - Simplify and reduce `ELFDumper<ELFT>::dumpSections`. NFCI..
Sat, Mar 21, 8:33 AM · Restricted Project

Fri, Mar 20

grimar added inline comments to D76499: [obj2yaml] - Simplify and reduce `ELFDumper<ELFT>::dumpSections`. NFCI..
Fri, Mar 20, 2:07 PM · Restricted Project
grimar accepted D76410: [ELF] Don't combine SHF_LINK_ORDER sections linking different output sections.

LGTM, just please update comments accordingly.

Fri, Mar 20, 8:38 AM · Restricted Project
grimar created D76499: [obj2yaml] - Simplify and reduce `ELFDumper<ELFT>::dumpSections`. NFCI..
Fri, Mar 20, 8:05 AM · Restricted Project
grimar committed rG63778bc653a2: [llvm-readobj][llvm-readelf][test] - Add a test to check how we dump relocation… (authored by grimar).
[llvm-readobj][llvm-readelf][test] - Add a test to check how we dump relocation…
Fri, Mar 20, 3:46 AM
grimar closed D75671: [llvm-readobj][llvm-readelf][test] - Add a test to check how we dump relocation addends..
Fri, Mar 20, 3:46 AM · Restricted Project
grimar accepted D76003: [ELF][test] Add test for --gc-sections + many sections.

This LGTM, please wait for @MaskRay since he had concerns before.

Fri, Mar 20, 3:45 AM · Restricted Project
grimar accepted D76425: [llvm-readobj] Allow syms from all sections to match stack size entries.

(Looking on the code I am a bit unsure why we preferred to consumeError
in functions that print stack sizes, but this consern is unrelated to this patch.)

Fri, Mar 20, 2:08 AM · Restricted Project
grimar added a comment to D76410: [ELF] Don't combine SHF_LINK_ORDER sections linking different output sections.

The logic looks reasonable to me. 2 more comments about comments are inlined.
(I think it worth to hold this for a day or too to see if there will be any other comments).

Fri, Mar 20, 1:35 AM · Restricted Project

Thu, Mar 19

grimar committed rGfecce903db2f: [obj2yaml][test] - Update test after output change. (authored by grimar).
[obj2yaml][test] - Update test after output change.
Thu, Mar 19, 8:05 AM
grimar committed rGa02b38698b40: [obj2yaml] - SHT_DYNAMIC and SHT_REL* sections: stop dumping sh_entsize field… (authored by grimar).
[obj2yaml] - SHT_DYNAMIC and SHT_REL* sections: stop dumping sh_entsize field…
Thu, Mar 19, 7:32 AM
grimar closed D76227: [obj2yaml] - SHT_DYNAMIC and SHT_REL* sections: stop dumping sh_entsize field when it has the default value..
Thu, Mar 19, 7:32 AM · Restricted Project
grimar committed rG9c69cc109bc0: [obj2yaml] - SHT_REL*, SHT_DYNAMIC sections: add tests to document the behavior… (authored by grimar).
[obj2yaml] - SHT_REL*, SHT_DYNAMIC sections: add tests to document the behavior…
Thu, Mar 19, 7:00 AM
grimar closed D76282: [obj2yaml] - SHT_REL*, SHT_DYNAMIC sections: add tests to document the behavior when sh_entsize is broken..
Thu, Mar 19, 7:00 AM · Restricted Project
grimar added inline comments to D76425: [llvm-readobj] Allow syms from all sections to match stack size entries.
Thu, Mar 19, 6:26 AM · Restricted Project
grimar added a comment to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

This need test cases I think.

Seems that we don't have any test on sh_size % sizeof(Elf_Sym) != 0. Do you have any suggestion on crafting such test?

Thu, Mar 19, 5:54 AM · Restricted Project
grimar added inline comments to D76352: [llvm-readobj] Derive dynamic symtab size from hash table.
Thu, Mar 19, 5:21 AM · Restricted Project
grimar added inline comments to D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..
Thu, Mar 19, 4:50 AM · Restricted Project
grimar accepted D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

I have only 2 minor nits and a question to others, otherwise this looks good, thanks!
So I've accepted, but let's wait for one more opinion.

Thu, Mar 19, 4:49 AM · Restricted Project
grimar committed rGe26e9ba288ce: [obj2yaml] - Stop dumping an empty sh_info field for SHT_RELA/SHT_REL sections. (authored by grimar).
[obj2yaml] - Stop dumping an empty sh_info field for SHT_RELA/SHT_REL sections.
Thu, Mar 19, 4:17 AM
grimar closed D76281: [obj2yaml] - Stop dumping an empty sh_info field for SHT_RELA/SHT_REL sections..
Thu, Mar 19, 4:17 AM · Restricted Project
grimar added inline comments to D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..
Thu, Mar 19, 4:17 AM · Restricted Project
grimar added inline comments to D76281: [obj2yaml] - Stop dumping an empty sh_info field for SHT_RELA/SHT_REL sections..
Thu, Mar 19, 3:44 AM · Restricted Project
grimar added inline comments to D75342: [obj2yaml] - Teach tool to dump program headers..
Thu, Mar 19, 3:44 AM · Restricted Project
grimar added a comment to D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Can we do this in next few patches? It seems that we have to resolve some continue; and break; statements.

I think we should commit the nice code from start. If we can't because of a minor refactoring needed, this refactoring should be done first.

Sure. Let me have a try, thanks a lot.

Thu, Mar 19, 3:44 AM · Restricted Project
grimar planned changes to D75342: [obj2yaml] - Teach tool to dump program headers..
Thu, Mar 19, 3:44 AM · Restricted Project
grimar committed rGbb7d2b178022: [LLD][ELF] - Disambiguate "=fillexp" with a primary expression to allow =0x90… (authored by grimar).
[LLD][ELF] - Disambiguate "=fillexp" with a primary expression to allow =0x90…
Thu, Mar 19, 3:12 AM
grimar closed D74687: [LLD][ELF] - Disambiguate "=fillexp" with a primary expression to allow =0x90 /DISCARD/.
Thu, Mar 19, 3:11 AM · Restricted Project
grimar added a comment to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

This need test cases I think.

Thu, Mar 19, 3:11 AM · Restricted Project
grimar added a comment to D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Can we do this in next few patches? It seems that we have to resolve some continue; and break; statements.

Thu, Mar 19, 3:11 AM · Restricted Project
grimar retitled D74687: [LLD][ELF] - Disambiguate "=fillexp" with a primary expression to allow =0x90 /DISCARD/ from [LLD][ELF] - Linker script: do not fail parsing when "/DISCARD/" follows the fill expression. to [LLD][ELF] - Disambiguate "=fillexp" with a primary expression to allow =0x90 /DISCARD/.
Thu, Mar 19, 2:39 AM · Restricted Project
grimar added a comment to D76240: [Sanitizers][Test] If the default linker is LLD, disable threads.

For lld, I think --threads={0,1,2,...} is better than the current --(no-)threads.

Thu, Mar 19, 2:39 AM · Restricted Project
grimar added inline comments to D76410: [ELF] Don't combine SHF_LINK_ORDER sections linking different output sections.
Thu, Mar 19, 2:39 AM · Restricted Project