Page MenuHomePhabricator

grimar (George Rimar)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 21 2015, 12:36 AM (225 w, 5 d)

Recent Activity

Yesterday

grimar added inline comments to D72756: [LLD][ELF] Add support for INPUT_SECTION_FLAGS.
Fri, Jan 17, 5:41 AM · Restricted Project
grimar added inline comments to D72756: [LLD][ELF] Add support for INPUT_SECTION_FLAGS.
Fri, Jan 17, 5:41 AM · Restricted Project
grimar added a comment to D72843: [llvm-readelf][llvm-readobj] - Fix the indentation when printing dynamic tags..

In both cases, I'm struggling to follow why specific numbers are used, e.g. where does the "-1" "-3" etc come from?

Fri, Jan 17, 4:44 AM · Restricted Project
grimar updated the diff for D72838: [llvm-objdump] - Fix the indentation when printing dynamic tags..
  • Addressed review comments.
  • Refined the comment in the test.
Fri, Jan 17, 2:47 AM · Restricted Project
grimar updated the summary of D72838: [llvm-objdump] - Fix the indentation when printing dynamic tags..
Fri, Jan 17, 2:43 AM · Restricted Project
grimar added inline comments to D72756: [LLD][ELF] Add support for INPUT_SECTION_FLAGS.
Fri, Jan 17, 2:34 AM · Restricted Project
grimar added inline comments to D72756: [LLD][ELF] Add support for INPUT_SECTION_FLAGS.
Fri, Jan 17, 1:48 AM · Restricted Project

Thu, Jan 16

grimar created D72843: [llvm-readelf][llvm-readobj] - Fix the indentation when printing dynamic tags..
Thu, Jan 16, 7:02 AM · Restricted Project
grimar created D72838: [llvm-objdump] - Fix the indentation when printing dynamic tags..
Thu, Jan 16, 5:27 AM · Restricted Project
grimar created D72831: [llvm-mc] - Produce R_X86_64_PLT32 relocation for branches with JCC opcodes too..
Thu, Jan 16, 3:43 AM · Restricted Project

Wed, Jan 15

grimar committed rG66a35d330b3d: [llvm-readobj][test] - Cleanup SHT_RELR sections testing. (authored by grimar).
[llvm-readobj][test] - Cleanup SHT_RELR sections testing.
Wed, Jan 15, 7:44 AM
grimar closed D71874: [llvm-readobj][test] - Cleanup SHT_RELR sections testing..
Wed, Jan 15, 7:44 AM · Restricted Project
grimar added inline comments to D71874: [llvm-readobj][test] - Cleanup SHT_RELR sections testing..
Wed, Jan 15, 7:44 AM · Restricted Project
grimar added a comment to D72756: [LLD][ELF] Add support for INPUT_SECTION_FLAGS.

First round of comments from me.
I mostly was focused on "is it possible to simplify the implementation for start?" question.

Wed, Jan 15, 6:48 AM · Restricted Project
grimar added inline comments to D71874: [llvm-readobj][test] - Cleanup SHT_RELR sections testing..
Wed, Jan 15, 5:24 AM · Restricted Project
grimar updated the diff for D71874: [llvm-readobj][test] - Cleanup SHT_RELR sections testing..
  • Rebased.
Wed, Jan 15, 5:24 AM · Restricted Project
grimar committed rG7570d387c219: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections. (authored by grimar).
[yaml2obj/obj2yaml] - Add support for SHT_RELR sections.
Wed, Jan 15, 4:20 AM
grimar committed rGca6f61653278: Revert "[yaml2obj/obj2yaml] - Add support for SHT_RELR sections." (authored by grimar).
Revert "[yaml2obj/obj2yaml] - Add support for SHT_RELR sections."
Wed, Jan 15, 3:24 AM
grimar added a reverting change for rG46d11e30ee80: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections.: rGca6f61653278: Revert "[yaml2obj/obj2yaml] - Add support for SHT_RELR sections.".
Wed, Jan 15, 3:24 AM
grimar committed rG46d11e30ee80: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections. (authored by grimar).
[yaml2obj/obj2yaml] - Add support for SHT_RELR sections.
Wed, Jan 15, 2:56 AM
grimar closed D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..
Wed, Jan 15, 2:56 AM · Restricted Project
grimar updated the diff for D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..
  • Addressed review comments.
Wed, Jan 15, 2:00 AM · Restricted Project
grimar added inline comments to D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..
Wed, Jan 15, 2:00 AM · Restricted Project
grimar added a comment to D71835: [llvm-readobj] - Remove an excessive helper for printing dynamic tags..

Assuming we want to keep them, I am thinking about shortening and lower-casing:

0x0000000012345678 (unknown) 0x8765432187654321
0x000000006abcdef0 (OS specific) 0x9988776655443322
0x0000000076543210 (processor specific) 0x5555666677778888

This looks good.

Wed, Jan 15, 1:32 AM · Restricted Project
grimar updated the diff for D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..
  • Addressed review comments.
Wed, Jan 15, 1:05 AM · Restricted Project
grimar added inline comments to D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..
Wed, Jan 15, 1:05 AM · Restricted Project
grimar accepted D72567: [ELF] Avoid false-positive assert in getErrPlace().

LGTM too.

Wed, Jan 15, 12:27 AM · Restricted Project

Tue, Jan 14

grimar committed rGe1f524ea43f9: [llvm-readobj][llvm-readelf][test] - Add a few more dynamic section tests. (authored by grimar).
[llvm-readobj][llvm-readelf][test] - Add a few more dynamic section tests.
Tue, Jan 14, 6:16 AM
grimar closed D71896: [llvm-readobj][llvm-readelf][test] - Add a few more dynamic section tests..
Tue, Jan 14, 6:16 AM · Restricted Project
grimar updated the diff for D71896: [llvm-readobj][llvm-readelf][test] - Add a few more dynamic section tests..
  • Addressed review comments.
Tue, Jan 14, 5:16 AM · Restricted Project
grimar updated the summary of D71896: [llvm-readobj][llvm-readelf][test] - Add a few more dynamic section tests..
Tue, Jan 14, 5:16 AM · Restricted Project
grimar added a comment to D71896: [llvm-readobj][llvm-readelf][test] - Add a few more dynamic section tests..

What are the formatting issues you are referring to in your description?

Things like below in ELF/dynamic-tags.test:

Tue, Jan 14, 4:29 AM · Restricted Project
grimar updated the diff for D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..
  • Addressed review comments.
Tue, Jan 14, 4:02 AM · Restricted Project
grimar added inline comments to D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..
Tue, Jan 14, 4:02 AM · Restricted Project
grimar added a comment to D71766: [llvm-readobj/llvm-readelf][test] - Add testing for EI_OSABI and EI_ABIVERSION fields of an ELF header..

Two post-commit nits, otherwise this was fine, thanks!

Tue, Jan 14, 2:00 AM · Restricted Project
grimar committed rGec6579fc047f: [llvm-readobj][test] - Fix grammar in comments. (authored by grimar).
[llvm-readobj][test] - Fix grammar in comments.
Tue, Jan 14, 1:54 AM
grimar accepted D72681: [ELF] --exclude-libs: don't assign VER_NDX_LOCAL to undefined symbols.

LGTM, but please wait for another possible comments too.

Tue, Jan 14, 1:34 AM · Restricted Project
grimar added inline comments to D72344: [LLD][ELF][ARM][AArch64] Only round up ThunkSection Size when large OS..
Tue, Jan 14, 1:33 AM · Restricted Project
grimar added a comment to D71835: [llvm-readobj] - Remove an excessive helper for printing dynamic tags..

I think our goal is to make llvm-readobj -d and llvm-readelf -d consistent. It seems we have a preferable output in mind which is inconsistent with GNU readelf. I agree that omitting the value from the (unknown) column is better.

0x0000000012345678 (unknown) 0x8765432187654321

@grimar Can you send an email to the mailing list binutils@sourceware.org and ask whether they'd like to change?

Tue, Jan 14, 1:04 AM · Restricted Project
grimar added a comment to D72681: [ELF] --exclude-libs: don't assign VER_NDX_LOCAL to undefined symbols.

I think this is fine.
I'd suggest to add a comment to the test case (its generally helpfull in a long term, though I know we often do not add them in LLDs tests.)

Tue, Jan 14, 12:45 AM · Restricted Project
grimar added inline comments to D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.
Tue, Jan 14, 12:36 AM · Restricted Project
grimar added a comment to D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.

A few comments/suggestions from me.

Tue, Jan 14, 12:27 AM · Restricted Project
grimar updated subscribers of D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.
Tue, Jan 14, 12:27 AM · Restricted Project

Mon, Jan 13

grimar added inline comments to D72567: [ELF] Avoid false-positive assert in getErrPlace().
Mon, Jan 13, 11:49 PM · Restricted Project
grimar added a comment to D71835: [llvm-readobj] - Remove an excessive helper for printing dynamic tags..

I am not sure we want to follow GNU here. Even if we do, it should be separate patch probably. The new output looks better and closer to GNU anyways, and the code is a bit simpler.

FWIW, I'm not sure I see a benefit from diverging from GNU here. The only thing I can think of is the lack of '0x' potentially making the value confusing, but the value is actually listed in the first column anyway, so that point isn't exactly an issue.

Mon, Jan 13, 1:57 AM · Restricted Project

Sun, Dec 29

grimar added inline comments to D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..
Sun, Dec 29, 4:15 AM · Restricted Project
grimar updated the diff for D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..
  • Addressed review comments.
Sun, Dec 29, 4:15 AM · Restricted Project

Fri, Dec 27

grimar added inline comments to D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..
Fri, Dec 27, 2:04 AM · Restricted Project
grimar updated the diff for D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..
  • Addressed review comments.
Fri, Dec 27, 2:04 AM · Restricted Project
grimar removed a child revision for D71895: [llvm-readobj][llvm-objdump][test] - Improve dynamic section testing.: D71896: [llvm-readobj][llvm-readelf][test] - Add a few more dynamic section tests..
Fri, Dec 27, 1:10 AM · Restricted Project
grimar removed a parent revision for D71896: [llvm-readobj][llvm-readelf][test] - Add a few more dynamic section tests.: D71895: [llvm-readobj][llvm-objdump][test] - Improve dynamic section testing..
Fri, Dec 27, 1:10 AM · Restricted Project
grimar updated the diff for D71896: [llvm-readobj][llvm-readelf][test] - Add a few more dynamic section tests..
  • Rebase.
Fri, Dec 27, 1:10 AM · Restricted Project
grimar committed rGe7a296a312c6: [llvm-readobj][llvm-objdump][test] - Improve dynamic section testing. (authored by grimar).
[llvm-readobj][llvm-objdump][test] - Improve dynamic section testing.
Fri, Dec 27, 12:33 AM
grimar closed D71895: [llvm-readobj][llvm-objdump][test] - Improve dynamic section testing..
Fri, Dec 27, 12:33 AM · Restricted Project
grimar retitled D71895: [llvm-readobj][llvm-objdump][test] - Improve dynamic section testing. from [llvm-readobj][llvm-readelf][test] - Improve dynamic section testing. to [llvm-readobj][llvm-objdump][test] - Improve dynamic section testing..
Fri, Dec 27, 12:06 AM · Restricted Project

Thu, Dec 26

grimar added a child revision for D71895: [llvm-readobj][llvm-objdump][test] - Improve dynamic section testing.: D71896: [llvm-readobj][llvm-readelf][test] - Add a few more dynamic section tests..
Thu, Dec 26, 4:14 AM · Restricted Project
grimar added a parent revision for D71896: [llvm-readobj][llvm-readelf][test] - Add a few more dynamic section tests.: D71895: [llvm-readobj][llvm-objdump][test] - Improve dynamic section testing..
Thu, Dec 26, 4:14 AM · Restricted Project
grimar created D71896: [llvm-readobj][llvm-readelf][test] - Add a few more dynamic section tests..
Thu, Dec 26, 4:14 AM · Restricted Project
grimar retitled D71895: [llvm-readobj][llvm-objdump][test] - Improve dynamic section testing. from [llvm-readobj][llvm-readelf][test] - Improve dynamic section dumping. to [llvm-readobj][llvm-readelf][test] - Improve dynamic section testing..
Thu, Dec 26, 3:55 AM · Restricted Project
grimar created D71895: [llvm-readobj][llvm-objdump][test] - Improve dynamic section testing..
Thu, Dec 26, 3:04 AM · Restricted Project
grimar updated the diff for D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..
  • Rename OffsetsAndBitmaps to Entries.
  • Improved, added tests.
Thu, Dec 26, 1:09 AM · Restricted Project
grimar accepted D71819: [ELF] Support input section description .gnu.version* in /DISCARD/.

LGTM

Thu, Dec 26, 12:35 AM · Restricted Project
grimar added inline comments to D71819: [ELF] Support input section description .gnu.version* in /DISCARD/.
Thu, Dec 26, 12:06 AM · Restricted Project

Wed, Dec 25

grimar added inline comments to D71819: [ELF] Support input section description .gnu.version* in /DISCARD/.
Wed, Dec 25, 11:58 PM · Restricted Project
grimar planned changes to D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..

Going to improve test cases and add a forgotten obj2yaml test.

Wed, Dec 25, 11:56 PM · Restricted Project
grimar added inline comments to D71819: [ELF] Support input section description .gnu.version* in /DISCARD/.
Wed, Dec 25, 11:20 PM · Restricted Project
grimar committed rG1a2d2b492a3d: [llvm-readobj] - Merge `gnu-symbols.test` to `symbols.test` and cleanup. (authored by grimar).
[llvm-readobj] - Merge `gnu-symbols.test` to `symbols.test` and cleanup.
Wed, Dec 25, 4:36 AM
grimar closed D71697: [llvm-readobj] - Merge `gnu-symbols.test` to `symbols.test` and cleanup..
Wed, Dec 25, 4:36 AM · Restricted Project
grimar added inline comments to D71697: [llvm-readobj] - Merge `gnu-symbols.test` to `symbols.test` and cleanup..
Wed, Dec 25, 4:30 AM · Restricted Project
grimar added inline comments to D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..
Wed, Dec 25, 4:18 AM · Restricted Project
grimar added a parent revision for D71874: [llvm-readobj][test] - Cleanup SHT_RELR sections testing.: D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..
Wed, Dec 25, 4:12 AM · Restricted Project
grimar added a child revision for D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections.: D71874: [llvm-readobj][test] - Cleanup SHT_RELR sections testing..
Wed, Dec 25, 4:12 AM · Restricted Project
grimar committed rG604d7fbfc1e3: [llvm-readobj/llvm-readelf][test] - Add testing for EI_OSABI and EI_ABIVERSION… (authored by grimar).
[llvm-readobj/llvm-readelf][test] - Add testing for EI_OSABI and EI_ABIVERSION…
Wed, Dec 25, 4:09 AM
grimar closed D71766: [llvm-readobj/llvm-readelf][test] - Add testing for EI_OSABI and EI_ABIVERSION fields of an ELF header..
Wed, Dec 25, 4:08 AM · Restricted Project
grimar created D71874: [llvm-readobj][test] - Cleanup SHT_RELR sections testing..
Wed, Dec 25, 3:50 AM · Restricted Project
grimar created D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..
Wed, Dec 25, 1:36 AM · Restricted Project

Tue, Dec 24

grimar accepted D71803: [llvm-nm] Display STT_GNU_IFUNC as 'i'.

LGTM

Tue, Dec 24, 11:20 PM · Restricted Project
grimar updated the diff for D71766: [llvm-readobj/llvm-readelf][test] - Add testing for EI_OSABI and EI_ABIVERSION fields of an ELF header..
  • Addressed comments.
Tue, Dec 24, 1:21 AM · Restricted Project
grimar committed rG301cb91428ee: [llvm-readobj] - Remove an excessive helper for printing dynamic tags. (authored by grimar).
[llvm-readobj] - Remove an excessive helper for printing dynamic tags.
Tue, Dec 24, 1:03 AM
grimar closed D71835: [llvm-readobj] - Remove an excessive helper for printing dynamic tags..
Tue, Dec 24, 1:03 AM · Restricted Project
grimar added inline comments to D71803: [llvm-nm] Display STT_GNU_IFUNC as 'i'.
Tue, Dec 24, 12:25 AM · Restricted Project

Mon, Dec 23

grimar updated the diff for D71835: [llvm-readobj] - Remove an excessive helper for printing dynamic tags..
  • Removed a piece of code that belongs to a different change.
Mon, Dec 23, 5:25 AM · Restricted Project
grimar created D71835: [llvm-readobj] - Remove an excessive helper for printing dynamic tags..
Mon, Dec 23, 5:25 AM · Restricted Project
grimar added inline comments to D71834: [DWARF] Fix DWARFDebugAranges to support 64-bit CU offsets..
Mon, Dec 23, 4:30 AM · Restricted Project, debug-info
grimar updated the diff for D71766: [llvm-readobj/llvm-readelf][test] - Add testing for EI_OSABI and EI_ABIVERSION fields of an ELF header..
  • Addressed review comments.
Mon, Dec 23, 3:34 AM · Restricted Project
grimar updated the summary of D71766: [llvm-readobj/llvm-readelf][test] - Add testing for EI_OSABI and EI_ABIVERSION fields of an ELF header..
Mon, Dec 23, 2:42 AM · Restricted Project
grimar committed rGf027e1a68dac: [yaml2obj] - Allow using an arbitrary value for OSABI. (authored by grimar).
[yaml2obj] - Allow using an arbitrary value for OSABI.
Mon, Dec 23, 2:33 AM
grimar closed D71765: [yaml2obj] - Allow using an arbitrary value for OSABI..
Mon, Dec 23, 2:33 AM · Restricted Project
grimar committed rG1f985775566d: [yaml2obj] - Add support for ELFOSABI_LINUX. (authored by grimar).
[yaml2obj] - Add support for ELFOSABI_LINUX.
Mon, Dec 23, 2:29 AM
grimar closed D71764: [yaml2obj] - Add support for ELFOSABI_LINUX..
Mon, Dec 23, 2:29 AM · Restricted Project
grimar committed rG2cebc1a7170f: [yaml2obj] - Add testing for OSABI field. (authored by grimar).
[yaml2obj] - Add testing for OSABI field.
Mon, Dec 23, 2:24 AM
grimar closed D71763: [yaml2obj] - Add testing for OSABI field..
Mon, Dec 23, 2:24 AM · Restricted Project
grimar committed rGcc522bc4e3e5: [llvm-readobj][test] - Stop using Inputs/trivial.obj.elf-x86-64. (authored by grimar).
[llvm-readobj][test] - Stop using Inputs/trivial.obj.elf-x86-64.
Mon, Dec 23, 2:14 AM
grimar closed D71662: [llvm-readobj][test] - Stop using Inputs/trivial.obj.elf-x86-64..
Mon, Dec 23, 2:14 AM · Restricted Project
grimar added a comment to D71822: [ELF] Delete the RelExpr member R_HINT. NFC.

I think this is fine, but would like to hear what others think.

Mon, Dec 23, 1:20 AM · Restricted Project
grimar accepted D71819: [ELF] Support input section description .gnu.version* in /DISCARD/.

LGTM

Mon, Dec 23, 1:19 AM · Restricted Project
grimar added inline comments to D71803: [llvm-nm] Display STT_GNU_IFUNC as 'i'.
Mon, Dec 23, 1:10 AM · Restricted Project
grimar accepted D71735: [ELF] Don't suggest an alternative spelling for a symbol in a discarded section.

LGTM with a few nits/suggestions.

Mon, Dec 23, 1:01 AM · Restricted Project

Sun, Dec 22

grimar added inline comments to D71735: [ELF] Don't suggest an alternative spelling for a symbol in a discarded section.
Sun, Dec 22, 11:40 AM · Restricted Project

Sat, Dec 21

grimar added inline comments to D71735: [ELF] Don't suggest an alternative spelling for a symbol in a discarded section.
Sat, Dec 21, 1:28 AM · Restricted Project