Page MenuHomePhabricator

bd1976llvm (ben)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 18 2017, 9:47 AM (278 w, 5 d)

Recent Activity

Wed, May 18

bd1976llvm added a reviewer for D125785: [llvm-ar][test] Add regression test for special case of replace converting a regular to a full archive (issue 55527): gbreynoo.
Wed, May 18, 4:03 AM · Restricted Project, Restricted Project

Tue, May 17

bd1976llvm updated the diff for D125785: [llvm-ar][test] Add regression test for special case of replace converting a regular to a full archive (issue 55527).

update diff to a working regression test!

Tue, May 17, 6:52 AM · Restricted Project, Restricted Project
bd1976llvm requested review of D125785: [llvm-ar][test] Add regression test for special case of replace converting a regular to a full archive (issue 55527).
Tue, May 17, 6:51 AM · Restricted Project, Restricted Project
bd1976llvm added a comment to D123949: [AIX] support write operation of big archive..

@DiggerLin there are a number of tests e.g: llvm\test\tools\llvm-ar\regular-to-thin-archive.test that are still marked "XFAIL: system-aix" that probably need looking at. It might be good to write down what testing strategy you want for AIX. Are you happy to rely on --format=gnu test coverage for most of the tests and have a few specifically --format=aix tests?

Tue, May 17, 3:09 AM · Restricted Project, Restricted Project

Mon, May 16

bd1976llvm added a comment to D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately.

@MaskRay - thanks for the review comments, I will keep your advise w.r.t. urls in commit comments in mind.

Mon, May 16, 4:52 PM · Restricted Project, Restricted Project
bd1976llvm added a comment to D123949: [AIX] support write operation of big archive..

Hi @DiggerLin. Currently the --help text states --format=aix but llvm-ar accepts --format=bigarchive. Could you fix that please.

Mon, May 16, 3:48 PM · Restricted Project, Restricted Project
bd1976llvm added a comment to D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately.

@bd1976llvm do you have an ETA to address the AIX failure Jake mentions above?

Mon, May 16, 2:53 PM · Restricted Project, Restricted Project

Fri, May 13

bd1976llvm added inline comments to D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately.
Fri, May 13, 9:43 AM · Restricted Project, Restricted Project
bd1976llvm updated the diff for D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately.

Address final comments.

Fri, May 13, 9:43 AM · Restricted Project, Restricted Project

Thu, May 12

bd1976llvm added inline comments to D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately.
Thu, May 12, 8:44 AM · Restricted Project, Restricted Project
bd1976llvm updated the diff for D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately.

Now using split-file and cd. Removed an invalid test-case. Addresed reivew comments.

Thu, May 12, 8:43 AM · Restricted Project, Restricted Project
bd1976llvm updated the diff for D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately.

Improved test and addressed review comments.

Thu, May 12, 7:30 AM · Restricted Project, Restricted Project
bd1976llvm added inline comments to D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately.
Thu, May 12, 7:29 AM · Restricted Project, Restricted Project

Wed, May 11

bd1976llvm added reviewers for D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately: MaskRay, rupprecht, Jake-Egan, DiggerLin, jhenderson.
Wed, May 11, 7:07 PM · Restricted Project, Restricted Project
bd1976llvm requested review of D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately.
Wed, May 11, 7:05 PM · Restricted Project, Restricted Project

Feb 15 2022

bd1976llvm added a comment to D119074: [ELF] Parse archives as --start-lib object files.

I am slightly concerned about penalising links with low utilisation archives. However, I don't have any specific data on low utilisation archives or any example of them. We did do some testing of a similar feature (in our proprietary linker) on game code, and low utilisation archives did not cause a problem for any of the games tested. Users should be able to create high utilisation versions of problematic archives in any case.

Feb 15 2022, 9:22 AM · Restricted Project
bd1976llvm added inline comments to D119074: [ELF] Parse archives as --start-lib object files.
Feb 15 2022, 1:15 AM · Restricted Project

Feb 9 2022

bd1976llvm closed D119135: Adjust exportDynamic comment after change to allow STV_PROTECTED shared definition to set exportDynamic.

Committed in https://github.com/llvm/llvm-project/commit/666aa43cbf829421b470c1ef6cf585d1dd3c94fd.

Feb 9 2022, 4:23 PM

Feb 7 2022

bd1976llvm requested review of D119135: Adjust exportDynamic comment after change to allow STV_PROTECTED shared definition to set exportDynamic.
Feb 7 2022, 6:39 AM

Feb 2 2022

bd1976llvm added a comment to D118577: [ELF] Deduplicate names of local symbols only with -O2.

This .strtab deduplication makes parallel .symtab write difficult. I suspect we may need to disable it entirely in the future.

Feb 2 2022, 1:36 AM · Restricted Project

Jan 24 2022

bd1976llvm added a comment to D117933: [ELF] Don't consider directories of the same name as libraries.

Currently a deplib name (${name}) indicates either the literal ${name} or the -l style lib${name}.{a,so}.
We have a conflict if ${name} is foo and there is a directory named foo.

What if we do

if (name.endswith(".a") || name.endswith(".so"))
  findFromSearchPaths
else
  searchLibraryBaseName

?

That should avoid the conflict, too. A directory is unlikely named .so or .a.

I don't think introducing more magical rules about naming patterns ever makes things easier.

It is surprising at first blush that deplibs searches for "foo" and not just what "-lfoo" would do, but it makes sense if you want to allow saying "libfoo.a" in deplibs to avoid matching "libfoo.so" in arcane cases.
So I think just the fix here to make all cases of not-existing-files candidates on search paths be ignored robustly is sufficient. The extra set of candidates that deplibs cases will attempt is tolerable and IMHO it's far preferable to having any more magic in the semantics of the behavior than there already is

It's not adding more magical rules. The chained findFromSearchPaths and searchLibraryBaseName is replaced with testing just one form.
We can then get rid of llvm::function_ref<bool(StringRef)>.

Jan 24 2022, 3:59 PM · Restricted Project

Jan 19 2022

bd1976llvm added a comment to D117284: [ELF] Allow non-bitcode archive with an empty index.

No objections. Reading your blog post and my copy of Linkers and Loaders it does seem that early linkers would handle archives with indexes, it just seems like indexes were ubiquitous when GNU ld were written. So it does seem like rejecting archives without an index is a property of the implentation of GNU ld rather than something that should be relied upon.

Jan 19 2022, 7:51 AM · Restricted Project

Jan 14 2022

bd1976llvm added a comment to D117284: [ELF] Allow non-bitcode archive with an empty index.

Another advantage is that this behaviour allows users to "repair" archives with incomplete symbol tables by stripping the symbol table (maybe someone has added both ET_RELs and bitcode objects to the same archive with an ar which ignored the bitcocde symbols).

Isn't it already trivial to "repair" such libraries by running ranlib on them?

Jan 14 2022, 5:52 AM · Restricted Project
bd1976llvm added a comment to D117284: [ELF] Allow non-bitcode archive with an empty index.

Another advantage is that this behaviour allows users to "repair" archives with incomplete symbol tables by stripping the symbol table (maybe someone has added both ET_RELs and bitcode objects to the same archive with an ar which ignored the bitcocde symbols).

Jan 14 2022, 3:24 AM · Restricted Project

Dec 9 2021

bd1976llvm added a comment to D114783: [ELF] Split scanRelocations into scanRelocations/postScanRelocations.

Sorry I missed this review - looks great! Did you try getting performance numbers using the tar packages that Rafael gathered up?

Dec 9 2021, 1:54 AM · Restricted Project

Oct 11 2021

bd1976llvm added a comment to D110716: [LLD] [TEST] Add test case for patching an absolute relocation to a weak undef.

Sorry for the slow response. I was out of town for one week.

Oct 11 2021, 5:18 AM · Restricted Project
bd1976llvm updated the diff for D110716: [LLD] [TEST] Add test case for patching an absolute relocation to a weak undef.

Do not test reloc offset as its value isn't important.

Oct 11 2021, 5:08 AM · Restricted Project

Sep 30 2021

bd1976llvm updated the diff for D110716: [LLD] [TEST] Add test case for patching an absolute relocation to a weak undef.

Additionally augmented weak-undef.s and weak-undef-rw.s with a --hex-dump test.

Sep 30 2021, 6:25 PM · Restricted Project

Sep 29 2021

bd1976llvm added reviewers for D110716: [LLD] [TEST] Add test case for patching an absolute relocation to a weak undef: MaskRay, grimar, peter.smith.
Sep 29 2021, 7:14 AM · Restricted Project
bd1976llvm requested review of D110716: [LLD] [TEST] Add test case for patching an absolute relocation to a weak undef.
Sep 29 2021, 7:13 AM · Restricted Project

Sep 23 2021

bd1976llvm updated the summary of D109804: [LLD] [ELF] Add emission of an optional linkmap section .
Sep 23 2021, 5:42 PM · Restricted Project

Sep 20 2021

bd1976llvm added a comment to D109572: [ELF] Add --why-extract= to query why archive members/lazy object files are extracted.

Thanks for working on this. In the past I have resorted to hacking in my own ad-hoc versions of such features to solve particularly horrible dependency cases. As mentioned above there's a case for more powerful dependency tracking e.g. https://reviews.llvm.org/D69607. The more of these debugging features available the better IMO :)

Sep 20 2021, 6:17 PM · Restricted Project

Sep 16 2021

bd1976llvm updated the summary of D109804: [LLD] [ELF] Add emission of an optional linkmap section .
Sep 16 2021, 3:44 PM · Restricted Project
bd1976llvm updated the summary of D109804: [LLD] [ELF] Add emission of an optional linkmap section .
Sep 16 2021, 9:25 AM · Restricted Project
bd1976llvm updated the diff for D109804: [LLD] [ELF] Add emission of an optional linkmap section .

Fix off-by-one problem.

Sep 16 2021, 9:02 AM · Restricted Project

Sep 15 2021

bd1976llvm updated the diff for D109804: [LLD] [ELF] Add emission of an optional linkmap section .

Fix linux build and formatting issues.

Sep 15 2021, 4:48 PM · Restricted Project

Sep 14 2021

bd1976llvm retitled D109804: [LLD] [ELF] Add emission of an optional linkmap section from [LLD] Add emission of an optional linkmap section to [LLD] [ELF] Add emission of an optional linkmap section .
Sep 14 2021, 7:53 PM · Restricted Project
bd1976llvm requested review of D109804: [LLD] [ELF] Add emission of an optional linkmap section .
Sep 14 2021, 7:42 PM · Restricted Project

Sep 6 2021

bd1976llvm added a comment to D108689: [Linker] Support weak symbols in nodeduplicate COMDAT group.

Thanks for the timely fix :)

Sep 6 2021, 10:28 AM · Restricted Project

Aug 6 2021

bd1976llvm updated the diff for D107555: [LLD][Test] Add thin archives to map file test.

Remove debugging tee.

Aug 6 2021, 3:33 AM · Restricted Project

Aug 5 2021

bd1976llvm requested review of D107555: [LLD][Test] Add thin archives to map file test.
Aug 5 2021, 4:45 AM · Restricted Project
bd1976llvm updated the diff for D107471: [llvm-ar] Add some test-cases for empty archives.

Arrg sorry! Uploaded an earlier incomplete revision by mistake.

Aug 5 2021, 1:34 AM · Restricted Project

Aug 4 2021

bd1976llvm requested review of D107471: [llvm-ar] Add some test-cases for empty archives.
Aug 4 2021, 8:39 AM · Restricted Project

Aug 2 2021

bd1976llvm added a comment to D107216: Revert [MC][ELF] Emit separate unique sections for different flags.

I think @bd1976llvm have found a way forward.

Aug 2 2021, 8:07 AM · Restricted Project

Jul 14 2021

bd1976llvm added a comment to D100944: [MC][ELF] Emit separate unique sections for different flags.

Augment compiler section attribute to allow specifying the section flags as well as the section name.

Recent GNU as reports errors for changed section attributes, so gcc with such a GNU as will report an error

% cat a.c
asm(".section debug_special,\"\",@progbits");
__attribute__((used, section("debug_special"))) int var;

% gcc -c a.c
/tmp/ccrwXjUO.s: Assembler messages:
/tmp/ccrwXjUO.s:7: Error: changed section attributes for debug_special

So I think a compiler oriented solution is more appropriate than a linker oriented one.
A GNU attribute beside section looks good to me. Such a request needed to be raised on the GCC Bugzilla.

Jul 14 2021, 1:48 AM · Restricted Project

Jun 29 2021

bd1976llvm added a comment to D100944: [MC][ELF] Emit separate unique sections for different flags.

Thanks for replying with some potential solutions. I'm sorry for not raising this earlier we have been slow to keep up with upstream changes recently so this change didn't get merged and tested until last week.

Jun 29 2021, 11:41 AM · Restricted Project

Jun 25 2021

bd1976llvm added a comment to D100944: [MC][ELF] Emit separate unique sections for different flags.

We have found a problem whist testing this change. We have some internal code that was exploiting the old behaviour:

Jun 25 2021, 8:35 AM · Restricted Project

Jun 11 2021

bd1976llvm updated the summary of D104114: [llvm-symbolizer] improve test and fix doc example after recent --print-source-context-lines behaviour change.
Jun 11 2021, 6:56 AM · Restricted Project
bd1976llvm updated the summary of D104114: [llvm-symbolizer] improve test and fix doc example after recent --print-source-context-lines behaviour change.
Jun 11 2021, 6:56 AM · Restricted Project
bd1976llvm added reviewers for D104114: [llvm-symbolizer] improve test and fix doc example after recent --print-source-context-lines behaviour change: hiraditya, dblaikie, aorlov, gbreynoo.
Jun 11 2021, 5:52 AM · Restricted Project
bd1976llvm requested review of D104114: [llvm-symbolizer] improve test and fix doc example after recent --print-source-context-lines behaviour change.
Jun 11 2021, 5:50 AM · Restricted Project

Jun 7 2021

bd1976llvm added a comment to D100944: [MC][ELF] Emit separate unique sections for different flags.

Thanks very much for working on this. I agree with the approach of putting out a separate section when the flags don't match as this matches the non-lto behaviour when the files are compiled separately.

Jun 7 2021, 6:23 PM · Restricted Project

May 25 2021

nasalodor awarded D29185: [lit] Allow llvm's build and test systems to support paths with spaces a Like token.
May 25 2021, 8:25 PM

May 10 2021

bd1976llvm added a comment to D101890: [LLD] Improve --strip-all help text.

@tstellar sorry to be a pain but could you give a go or no-go for putting this on the release branch please? For internal reasons I have to finish LLVM 12 changes this week. Thanks!

May 10 2021, 3:07 AM · Restricted Project

May 7 2021

bd1976llvm added a comment to D101890: [LLD] Improve --strip-all help text.

Can you file a bug for this?

May 7 2021, 8:42 AM · Restricted Project

May 6 2021

bd1976llvm updated subscribers of D101890: [LLD] Improve --strip-all help text.

@tstellar this is a very safe change and we did have a customer confused by this option. Would it be possible to put this change onto the 12 release branch? Thanks.

May 6 2021, 4:40 AM · Restricted Project

May 5 2021

bd1976llvm added inline comments to D101890: [LLD] Improve --strip-all help text.
May 5 2021, 10:48 AM · Restricted Project
bd1976llvm updated the diff for D101890: [LLD] Improve --strip-all help text.

Conform to mandoc style.

May 5 2021, 10:48 AM · Restricted Project
bd1976llvm updated the diff for D101890: [LLD] Improve --strip-all help text.

Thanks @peter.smith. I have added the man page update.

May 5 2021, 7:58 AM · Restricted Project
bd1976llvm requested review of D101890: [LLD] Improve --strip-all help text.
May 5 2021, 3:52 AM · Restricted Project

Apr 21 2021

bd1976llvm added a comment to D100944: [MC][ELF] Emit separate unique sections for different flags.

Hi. Can you add some background information to the description. I assume the discussion on https://reviews.llvm.org/D93948 is relevant. Is there an associated bug?

Apr 21 2021, 8:23 AM · Restricted Project

Mar 24 2021

bd1976llvm added a comment to D93203: [PS4] handle dllimport/export w.r.t vtables/rtti.

@compnerd, @smeenai do you have any further comments?

Mar 24 2021, 6:58 AM · Restricted Project

Mar 22 2021

bd1976llvm added a reviewer for D93203: [PS4] handle dllimport/export w.r.t vtables/rtti: mstorsjo.
Mar 22 2021, 4:48 AM · Restricted Project

Mar 15 2021

bd1976llvm added a comment to D93203: [PS4] handle dllimport/export w.r.t vtables/rtti.

ping.

Mar 15 2021, 6:24 PM · Restricted Project

Mar 12 2021

bd1976llvm updated the summary of D93203: [PS4] handle dllimport/export w.r.t vtables/rtti.
Mar 12 2021, 3:04 AM · Restricted Project

Mar 8 2021

bd1976llvm added a comment to D89518: [windows-itanium] Add Windows Itanium How-To Guide.

Sorry for the delay here. This looks good; thank you!

Mar 8 2021, 3:52 PM · Restricted Project

Feb 17 2021

bd1976llvm added a comment to D89518: [windows-itanium] Add Windows Itanium How-To Guide.

ping :)

Feb 17 2021, 5:59 AM · Restricted Project
bd1976llvm added inline comments to D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.
Feb 17 2021, 5:59 AM · Restricted Project
bd1976llvm added a comment to D93203: [PS4] handle dllimport/export w.r.t vtables/rtti.

ping!

Feb 17 2021, 5:57 AM · Restricted Project
bd1976llvm added a comment to D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.
Feb 17 2021, 5:56 AM · Restricted Project, Restricted Project

Feb 8 2021

bd1976llvm updated the summary of D95949: Remove unused CHECK of dllexport declaration.
Feb 8 2021, 8:58 AM
bd1976llvm updated the summary of D95949: Remove unused CHECK of dllexport declaration.
Feb 8 2021, 8:39 AM

Feb 3 2021

bd1976llvm requested review of D95949: Remove unused CHECK of dllexport declaration.
Feb 3 2021, 5:59 AM

Feb 1 2021

bd1976llvm added a comment to D89518: [windows-itanium] Add Windows Itanium How-To Guide.

@mstorsjo are you happy with this now?

Feb 1 2021, 6:07 PM · Restricted Project
bd1976llvm updated the diff for D89518: [windows-itanium] Add Windows Itanium How-To Guide.

Added the cmake defines from https://reviews.llvm.org/D90021 for the libcxxabi build.

Feb 1 2021, 6:06 PM · Restricted Project
bd1976llvm added inline comments to D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.
Feb 1 2021, 5:53 PM · Restricted Project

Jan 29 2021

bd1976llvm added a comment to D83069: [LIT] error if directly named test won't be run indirectly.

Hi @bd1976llvm

I've just realized in many projects I'm involved in testsuites are managed by cmake and lit is only ever invoked on single testcase. Without passing --no-indirectly-run-check tests fail but when using an old lit I get an error if using this option. Can we allow to turn off the feature via environment variable or configuration?

Thanks in advance.

Jan 29 2021, 8:22 AM · Restricted Project

Jan 22 2021

bd1976llvm added a comment to D93203: [PS4] handle dllimport/export w.r.t vtables/rtti.

I have added this patch to https://reviews.llvm.org/D88124 along with some end to end tests to show the scei vendor windows-itanium behaviour. From the 'wi-test/test/dll_vtable_missing/test.py' test you can see that the link error given by the scei vendor variant is more consistent than the standard windows-itanium. Both variants should be equivalent in terms of runtime behaviour.

Jan 22 2021, 5:10 PM · Restricted Project
bd1976llvm updated the diff for D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.

Added the patch from https://reviews.llvm.org/D93203 and the scei vendor variant of windows itanium to the relevant tests.

Jan 22 2021, 3:42 PM · Restricted Project
bd1976llvm added inline comments to D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.
Jan 22 2021, 3:40 PM · Restricted Project
bd1976llvm added a reviewer for D93203: [PS4] handle dllimport/export w.r.t vtables/rtti: smeenai.
Jan 22 2021, 7:52 AM · Restricted Project
bd1976llvm updated the diff for D93203: [PS4] handle dllimport/export w.r.t vtables/rtti.

Thanks for the suggestions. I have reworded the comments so that they are hopefully much clearer.

Jan 22 2021, 7:46 AM · Restricted Project
bd1976llvm updated the diff for D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.

rebased build script and some minor improvements.

Jan 22 2021, 4:01 AM · Restricted Project
bd1976llvm added a comment to D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.

Thanks for your comments. I tried to do a rebase right up to the head of main - but it proved very difficult to resolve all the problems this caused. Instead I have rebased to your https://github.com/llvm/llvm-project/commit/8a73aa8c4c3ee82e7d650c6a957937713a4a9ab4

Jan 22 2021, 3:58 AM · Restricted Project

Jan 7 2021

bd1976llvm added a comment to D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.

@mstorsjo I'm looking at this again after the winter break. Do you have any further comments?

Jan 7 2021, 3:59 AM · Restricted Project

Dec 14 2020

bd1976llvm added inline comments to D93203: [PS4] handle dllimport/export w.r.t vtables/rtti.
Dec 14 2020, 6:15 PM · Restricted Project
bd1976llvm requested review of D93203: [PS4] handle dllimport/export w.r.t vtables/rtti.
Dec 14 2020, 3:59 AM · Restricted Project

Dec 9 2020

bd1976llvm updated the diff for D89518: [windows-itanium] Add Windows Itanium How-To Guide.

Removed COMDAT limitation text.

Dec 9 2020, 5:46 PM · Restricted Project

Dec 7 2020

bd1976llvm added a comment to D89518: [windows-itanium] Add Windows Itanium How-To Guide.

@compnerd @smeenai are you basically happy with this doc now?

Dec 7 2020, 5:18 PM · Restricted Project

Nov 26 2020

bd1976llvm added inline comments to D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.
Nov 26 2020, 3:59 AM · Restricted Project, Restricted Project
bd1976llvm updated the diff for D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.

Addressed review comments.

Nov 26 2020, 3:59 AM · Restricted Project, Restricted Project

Nov 25 2020

bd1976llvm added inline comments to D89518: [windows-itanium] Add Windows Itanium How-To Guide.
Nov 25 2020, 9:08 AM · Restricted Project
bd1976llvm updated the diff for D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.

Added type_info tests.

Nov 25 2020, 8:46 AM · Restricted Project

Nov 24 2020

bd1976llvm updated the diff for D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.

Updated comment to state that "semantic compatibility" is the goal.

Nov 24 2020, 5:00 PM · Restricted Project, Restricted Project
bd1976llvm added a comment to D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.

Thanks for the comments. I have updated the diff.

Nov 24 2020, 4:56 PM · Restricted Project, Restricted Project

Nov 20 2020

bd1976llvm updated the diff for D91779: [Clang][-fvisibility-from-dllstorageclass] Set DSO Locality from final visibility.

Fixed spelling errors.

Nov 20 2020, 2:23 PM · Restricted Project
bd1976llvm updated the diff for D91779: [Clang][-fvisibility-from-dllstorageclass] Set DSO Locality from final visibility.

Improved comment.

Nov 20 2020, 2:20 PM · Restricted Project

Nov 19 2020

bd1976llvm added a comment to D91779: [Clang][-fvisibility-from-dllstorageclass] Set DSO Locality from final visibility.

Im not sure if renaming the check prefix is actually helpful, but sure. This does seem like somewhat unfortunate. For the dllexport case, you really want dso_local. define dso_local global and declare dso_local global are preferable in this case as that guarantees a local definition, which is always the case for an exported symbol. You definitely do not want declare extern dso_local global. A few of the changes here are actually changing the IRGen from the desired state, is that intentional?

Nov 19 2020, 3:14 PM · Restricted Project
bd1976llvm requested review of D91779: [Clang][-fvisibility-from-dllstorageclass] Set DSO Locality from final visibility.
Nov 19 2020, 3:26 AM · Restricted Project

Nov 18 2020

bd1976llvm added a comment to D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4.

Let me know if you think that more tests need adding. I have added support for LIT based run tests to the build recipe (https://reviews.llvm.org/D88124) I can use this to add any run tests that might be useful for this review.

Nov 18 2020, 5:18 AM · Restricted Project, Restricted Project