- User Since
- Jan 18 2017, 9:47 AM (221 w, 6 d)
Wed, Mar 24
Mon, Mar 22
Mar 15 2021
Mar 12 2021
Mar 8 2021
Feb 17 2021
Feb 8 2021
Feb 3 2021
Feb 1 2021
@mstorsjo are you happy with this now?
Added the cmake defines from https://reviews.llvm.org/D90021 for the libcxxabi build.
Jan 29 2021
Jan 22 2021
I have added this patch to https://reviews.llvm.org/D88124 along with some end to end tests to show the scei vendor windows-itanium behaviour. From the 'wi-test/test/dll_vtable_missing/test.py' test you can see that the link error given by the scei vendor variant is more consistent than the standard windows-itanium. Both variants should be equivalent in terms of runtime behaviour.
Added the patch from https://reviews.llvm.org/D93203 and the scei vendor variant of windows itanium to the relevant tests.
Thanks for the suggestions. I have reworded the comments so that they are hopefully much clearer.
rebased build script and some minor improvements.
Thanks for your comments. I tried to do a rebase right up to the head of main - but it proved very difficult to resolve all the problems this caused. Instead I have rebased to your https://github.com/llvm/llvm-project/commit/8a73aa8c4c3ee82e7d650c6a957937713a4a9ab4
Jan 7 2021
@mstorsjo I'm looking at this again after the winter break. Do you have any further comments?
Dec 14 2020
Dec 9 2020
Removed COMDAT limitation text.
Dec 7 2020
Nov 26 2020
Addressed review comments.
Nov 25 2020
Added type_info tests.
Nov 24 2020
Updated comment to state that "semantic compatibility" is the goal.
Thanks for the comments. I have updated the diff.
Nov 20 2020
Fixed spelling errors.
Nov 19 2020
Nov 18 2020
Let me know if you think that more tests need adding. I have added support for LIT based run tests to the build recipe (https://reviews.llvm.org/D88124) I can use this to add any run tests that might be useful for this review.
Nov 17 2020
Added LIT based tests.
Nov 13 2020
I think this needs a re-review as I have deviated from the original simple approach.
Nov 11 2020
Will this land soon? We are eagerly anticipating its arrival :)
Updated the diff following helpful review comments.
Nov 5 2020
Add tests and prevent SemaTemplate and ItaniumCXXABI code paths from executing for PS4 (for now).
Nov 2 2020
Addressed review comments.
Oct 29 2020
Hi @mstorsjo - I have been a bit short of time recently; but, I am going to look into everything that you have pointed out here. I should be able to make a reply by Monday.
Addressed the review comments and made some minor improvements.
Oct 28 2020
Oct 23 2020
addressed review comments and made some other improvements:
Oct 22 2020
Oct 20 2020
Apologies that I haven't had much time to look into this. I tried this style of patching with Sony's proprietary debugger and the user experience w.r.t. source locations and setting breakpoints was degraded. When I find time I will try to determine what is theoretically best here and whether the degradation in the debugging experience that I saw is an artefact of our proprietary debuggers implementation or if it points to something important. We should try with other consumers as well.
Oct 19 2020
Removed check for error message not being emitted.
Oct 15 2020
Oct 14 2020
Oct 13 2020
- Error rather than warn - lit tests are regression tests!
- Add option to supress check (there is no performance cost if this option is specified).
- Standardized on the terms "direct" and "indirect" in comments and diagnostics.
- Added missing test file.
Oct 9 2020
I plan to investigate this further after the weekend; but, I wanted to say that the current scheme is known to be compatible with gdb and with Sony's proprietary debugger and yields a reasonable, if not ideal, debugging experience.
Sep 28 2020
Use lld's mingw autolinking feature. Add a testcase that will fail without this.
Sep 24 2020
Hi mstorsjo, thanks for looking at this. Please add anyone else to this review that might be interested.
Sep 23 2020
Removed the code patch and --patch functionality. These are not needed given that this review *is* a patch and having a patch in a patch is confusing.
Sep 22 2020
Sep 16 2020
Sep 15 2020
@hans, I think that we should put this change onto the release branch for llvm11.
Aug 28 2020
Aug 27 2020
Aug 25 2020
Aug 14 2020
Aug 12 2020
Aug 11 2020
Moved testing into linux-preemption.ll