- User Since
- Jan 18 2017, 9:47 AM (112 w, 5 d)
Jan 16 2019
I strongly feel that we shouldn't implement this. This will tie groups and --gc-sections together when they are orthogonal features; e.g. COMDAT groups will *also* have to be considered by --gc-sections as a single unit. The ability to strip individual sections form COMDAT groups is an important feature. I will add similar comment to the abi list. I'm surprised that gold implements this behavior, back in 2017 gold and bfd-ld disagreed on this.
Jan 10 2019
Jan 9 2019
The wording of the standard is unfortunate. This has been brought up and clarified (that COMDATs are the only legal groups currently) on the list previously.
There is a relevant discussion about non-COMDAT groups here: https://reviews.llvm.org/D56437.
I agree with Rui. My understanding is that groups in ELF were designed specifically to support C++ templates and inline functions which is why COMDAT groups are the only allowed kind.
Interestingly, I have been having a somewhat related discussion on this review: https://reviews.llvm.org/D53234.
Could the annobin tool use SHF_LINK_ORDER instead?
Dec 21 2018
Nov 28 2018
Nov 26 2018
Trying again... Phabricator didn't like the markup in my last comment attempt.
Nov 16 2018
Oct 31 2018
Hi Aron, I'm interested in reviewing this. Would you mind responding to my comments on https://reviews.llvm.org/D53234 first, as you have based the correctness of this on the correctness of that change?
Sep 5 2018
Thanks for the comments everyone.
Aug 31 2018
Added missing newline at end of test file
Aug 23 2018
Aug 22 2018
Thanks for the detailed reply Peter!
Aug 21 2018
Hi George. Do we actually want this behaviour?
Aug 20 2018
Hi. Sorry to be slow to comment on this.
Aug 2 2018
Jul 23 2018
Jun 28 2018
updated diff to address review comments
Jun 26 2018
Having thought about this I have decided to try to simplify the help text as much as possible to aid maintenance.
Jun 25 2018
Jun 22 2018
Jun 19 2018
I would propose adding the ability to retrieve a unique filtered list of arguments.
Jun 4 2018
May 31 2018
Hi Rui! Thanks for looking at the patch.
Mar 27 2018
Why are extra symbols *in the assembly* a problem? We normally don't print assembly
Hi Rafael. The SN-Linker has the following rule for metadata sections:
Mar 26 2018
LGTM., as long as this doesn't cause the number of symbols to double up?
Jan 19 2018
Dec 22 2017
Addressed review comments
Dec 21 2017
I have reworked this now, see: https://reviews.llvm.org/D41497.
Dec 19 2017
Dec 18 2017
Explicitly cast system_clock::now type as well.
Thanks for the great review comments.
Dec 15 2017
Updated patch to address review comments
I removed the comment change.
Dec 14 2017
I like your proposal.
Nov 17 2017
Nov 16 2017
Sep 29 2017
Sep 28 2017
Missed a review comment. Now addressed.
Addressed review comments.
Sep 26 2017
updated with review comments.
Sep 25 2017
Updated as per review comments.
Apologies that it took some time to update the patch.
Sep 21 2017
Updated the diff to address review comments.
Having thought about this I still think that we want this patch.
Check out lld/trunk/test/ELF/common-gc3.s for a test case.
This case commonly arises where the section that is being patched is informational and the linker can't garbage collect it e.g .debug_info.
I posted this to the mailing list (copy here):