User Details
- User Since
- Jan 18 2017, 9:47 AM (278 w, 5 d)
Wed, May 18
Tue, May 17
update diff to a working regression test!
@DiggerLin there are a number of tests e.g: llvm\test\tools\llvm-ar\regular-to-thin-archive.test that are still marked "XFAIL: system-aix" that probably need looking at. It might be good to write down what testing strategy you want for AIX. Are you happy to rely on --format=gnu test coverage for most of the tests and have a few specifically --format=aix tests?
Mon, May 16
@MaskRay - thanks for the review comments, I will keep your advise w.r.t. urls in commit comments in mind.
Hi @DiggerLin. Currently the --help text states --format=aix but llvm-ar accepts --format=bigarchive. Could you fix that please.
Fri, May 13
Address final comments.
Thu, May 12
Now using split-file and cd. Removed an invalid test-case. Addresed reivew comments.
Improved test and addressed review comments.
Wed, May 11
Feb 15 2022
I am slightly concerned about penalising links with low utilisation archives. However, I don't have any specific data on low utilisation archives or any example of them. We did do some testing of a similar feature (in our proprietary linker) on game code, and low utilisation archives did not cause a problem for any of the games tested. Users should be able to create high utilisation versions of problematic archives in any case.
Feb 9 2022
Feb 7 2022
Feb 2 2022
Jan 24 2022
Jan 19 2022
Jan 14 2022
Another advantage is that this behaviour allows users to "repair" archives with incomplete symbol tables by stripping the symbol table (maybe someone has added both ET_RELs and bitcode objects to the same archive with an ar which ignored the bitcocde symbols).
Dec 9 2021
Sorry I missed this review - looks great! Did you try getting performance numbers using the tar packages that Rafael gathered up?
Oct 11 2021
Do not test reloc offset as its value isn't important.
Sep 30 2021
Additionally augmented weak-undef.s and weak-undef-rw.s with a --hex-dump test.
Sep 29 2021
Sep 23 2021
Sep 20 2021
Thanks for working on this. In the past I have resorted to hacking in my own ad-hoc versions of such features to solve particularly horrible dependency cases. As mentioned above there's a case for more powerful dependency tracking e.g. https://reviews.llvm.org/D69607. The more of these debugging features available the better IMO :)
Sep 16 2021
Fix off-by-one problem.
Sep 15 2021
Fix linux build and formatting issues.
Sep 14 2021
Sep 6 2021
Thanks for the timely fix :)
Aug 6 2021
Remove debugging tee.
Aug 5 2021
Arrg sorry! Uploaded an earlier incomplete revision by mistake.
Aug 4 2021
Aug 2 2021
Jul 14 2021
Jun 29 2021
Thanks for replying with some potential solutions. I'm sorry for not raising this earlier we have been slow to keep up with upstream changes recently so this change didn't get merged and tested until last week.
Jun 25 2021
We have found a problem whist testing this change. We have some internal code that was exploiting the old behaviour:
Jun 11 2021
Jun 7 2021
May 25 2021
May 10 2021
@tstellar sorry to be a pain but could you give a go or no-go for putting this on the release branch please? For internal reasons I have to finish LLVM 12 changes this week. Thanks!
May 7 2021
May 6 2021
@tstellar this is a very safe change and we did have a customer confused by this option. Would it be possible to put this change onto the 12 release branch? Thanks.
May 5 2021
Conform to mandoc style.
Thanks @peter.smith. I have added the man page update.
Apr 21 2021
Hi. Can you add some background information to the description. I assume the discussion on https://reviews.llvm.org/D93948 is relevant. Is there an associated bug?
Mar 24 2021
Mar 22 2021
Mar 15 2021
ping.
Mar 12 2021
Mar 8 2021
Feb 17 2021
ping :)
ping!
Feb 8 2021
Feb 3 2021
Feb 1 2021
@mstorsjo are you happy with this now?
Added the cmake defines from https://reviews.llvm.org/D90021 for the libcxxabi build.
Jan 29 2021
Jan 22 2021
I have added this patch to https://reviews.llvm.org/D88124 along with some end to end tests to show the scei vendor windows-itanium behaviour. From the 'wi-test/test/dll_vtable_missing/test.py' test you can see that the link error given by the scei vendor variant is more consistent than the standard windows-itanium. Both variants should be equivalent in terms of runtime behaviour.
Added the patch from https://reviews.llvm.org/D93203 and the scei vendor variant of windows itanium to the relevant tests.
Thanks for the suggestions. I have reworded the comments so that they are hopefully much clearer.
rebased build script and some minor improvements.
Thanks for your comments. I tried to do a rebase right up to the head of main - but it proved very difficult to resolve all the problems this caused. Instead I have rebased to your https://github.com/llvm/llvm-project/commit/8a73aa8c4c3ee82e7d650c6a957937713a4a9ab4
Jan 7 2021
@mstorsjo I'm looking at this again after the winter break. Do you have any further comments?
Dec 14 2020
Dec 9 2020
Removed COMDAT limitation text.
Dec 7 2020
Nov 26 2020
Addressed review comments.
Nov 25 2020
Added type_info tests.
Nov 24 2020
Updated comment to state that "semantic compatibility" is the goal.
Thanks for the comments. I have updated the diff.
Nov 20 2020
Fixed spelling errors.
Improved comment.
Nov 19 2020
Nov 18 2020
Let me know if you think that more tests need adding. I have added support for LIT based run tests to the build recipe (https://reviews.llvm.org/D88124) I can use this to add any run tests that might be useful for this review.