Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

eugenis (Evgenii Stepanov)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 3 2012, 3:00 AM (573 w, 11 h)

Recent Activity

Aug 3 2023

eugenis accepted D155736: Fix __cfi_check not aligned to 4k on relocatable files with no executable code.

LGTM, thank you.

Aug 3 2023, 3:24 AM · Restricted Project, Restricted Project

Aug 2 2023

eugenis added inline comments to D155736: Fix __cfi_check not aligned to 4k on relocatable files with no executable code.
Aug 2 2023, 3:46 AM · Restricted Project, Restricted Project

Jul 20 2023

eugenis added a comment to D155736: Fix __cfi_check not aligned to 4k on relocatable files with no executable code.

Hmm, this is not 100% correct. CFI by design respects caller's settings for -fsanitize-recover and -fsanitize-trap, communicated through the DiagData argument to __cfi_check. A better default implementation would call __cfi_check_fail instead of trap unconditionally.

Jul 20 2023, 11:03 AM · Restricted Project, Restricted Project

Jun 15 2023

eugenis committed rGed552f2151ac: [scudo] Disable OddEvenTags by default. (authored by eugenis).
[scudo] Disable OddEvenTags by default.
Jun 15 2023, 4:37 PM · Restricted Project, Restricted Project
eugenis closed D152984: [scudo] Disable OddEvenTags by default..
Jun 15 2023, 4:37 PM · Restricted Project, Restricted Project

Jun 14 2023

eugenis requested review of D152984: [scudo] Disable OddEvenTags by default..
Jun 14 2023, 5:05 PM · Restricted Project, Restricted Project

Jun 12 2023

eugenis accepted D152604: [Driver] Default -fsanitize-address-globals-dead-stripping to true for ELF.

This is long overdue, I think. Thank you!

Jun 12 2023, 2:32 PM · Restricted Project, Restricted Project

May 24 2023

eugenis accepted D143675: Discussion: Darwin Sanitizers Stable ABI.
May 24 2023, 2:38 PM · Restricted Project, Restricted Project, Restricted Project

May 18 2023

eugenis added a comment to D150218: [ConstantMerge] Only merge constant w/unnamed_addr.

I'm far from a C or C++ expert, but FWIW I'm not entirely convinced that this example breaks language semantics.

May 18 2023, 12:39 PM · Restricted Project, Restricted Project

May 11 2023

eugenis accepted D150401: [HWASAN] Prevent crashes on thread exit.

LGTM

May 11 2023, 3:55 PM · Restricted Project, Restricted Project
eugenis added inline comments to D150104: [NFC][sanitizer] Add class to track thread arg and retval.
May 11 2023, 3:03 PM · Restricted Project, Restricted Project
eugenis added a comment to D150401: [HWASAN] Prevent crashes on thread exit.

I do not understand the bionic issue. __hwasan_thread_exit is called very late (as the last thing in that function), while the signals are blocked. Why do thread cleanup functions matter?

May 11 2023, 2:51 PM · Restricted Project, Restricted Project

May 1 2023

eugenis added a comment to D143675: Discussion: Darwin Sanitizers Stable ABI.

I'm fine with it in general. Is asan_abi.cpp meant as a temporary stub? It's not even link anywhere in the current version.

May 1 2023, 2:35 PM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2023

eugenis accepted D149491: [msan] Improve handling of Intrinsic::is_fpclass after c55fffe.
Apr 28 2023, 4:09 PM · Restricted Project, Restricted Project

Apr 26 2023

eugenis accepted D149228: [HWASAN] Support tagged stack pointer.
Apr 26 2023, 2:52 PM · Restricted Project, Restricted Project
eugenis accepted D149221: [NFC][HWASAN] Move getUARTag into the Entry.
Apr 26 2023, 2:51 PM · Restricted Project, Restricted Project
eugenis accepted D149220: [HWASAN] Remove UAR tag branch !ClUARRetagToZero.
Apr 26 2023, 2:45 PM · Restricted Project, Restricted Project

Apr 20 2023

eugenis accepted D148596: [KMSAN] Enable on SystemZ.

LGTM

Apr 20 2023, 4:02 PM · Restricted Project, Restricted Project, Restricted Project
eugenis added a comment to D148508: [AArch64] Make stack tagging compatible with SLH.

LGTM, thanks!

Apr 20 2023, 12:33 PM · Restricted Project, Restricted Project

Apr 12 2023

eugenis added a comment to D147121: [hwasan] remove requirment for PIE.

Sorry, I do not remember why this requirement is there. Must be related to shadow / allocator placement and kernel mapping conflicts, but hwasan is using dynamic shadow so that should not be an issue... LGTM as long as it works.

Apr 12 2023, 12:55 PM · Restricted Project, Restricted Project

Apr 4 2023

eugenis committed rGe0f7ef4b9ccf: [msan] Fix handling of ParamTLS overflow. (authored by eugenis).
[msan] Fix handling of ParamTLS overflow.
Apr 4 2023, 1:53 PM · Restricted Project, Restricted Project
eugenis closed D146858: [msan] Fix handling of ParamTLS overflow..
Apr 4 2023, 1:52 PM · Restricted Project, Restricted Project

Mar 29 2023

eugenis added inline comments to D146858: [msan] Fix handling of ParamTLS overflow..
Mar 29 2023, 11:40 AM · Restricted Project, Restricted Project

Mar 24 2023

eugenis requested review of D146858: [msan] Fix handling of ParamTLS overflow..
Mar 24 2023, 6:10 PM · Restricted Project, Restricted Project

Mar 3 2023

eugenis added a comment to D144057: [GVN] permit GVN of non-local loads for ASAN unless undef or alloca is produced.

Not convinced that this is right. The original fix is for a false postive, not a false negative - i.e., we want to prevent speculation of a memory access that is not provably safe.

Mar 3 2023, 1:07 PM · Restricted Project, Restricted Project

Feb 9 2023

eugenis added a reviewer for D143675: Discussion: Darwin Sanitizers Stable ABI: vitalybuka.
Feb 9 2023, 1:59 PM · Restricted Project, Restricted Project, Restricted Project
eugenis added a comment to D143675: Discussion: Darwin Sanitizers Stable ABI.

I think this should generally work.

Feb 9 2023, 1:59 PM · Restricted Project, Restricted Project, Restricted Project

Feb 8 2023

eugenis accepted D143544: [MTE stack] fix incorrect offset for st2g.

LGTM

Feb 8 2023, 4:08 PM · Restricted Project, Restricted Project
eugenis added a comment to D143544: [MTE stack] fix incorrect offset for st2g.

LGTM but please make a better test case.

Feb 8 2023, 4:07 PM · Restricted Project, Restricted Project

Jan 19 2023

eugenis added a reverting change for rG571c8c5263a7: [AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP): rGbd3ee371e9f0: Revert "[AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP)".
Jan 19 2023, 2:09 PM
eugenis committed rGbd3ee371e9f0: Revert "[AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP)" (authored by eugenis).
Revert "[AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP)"
Jan 19 2023, 2:09 PM · Restricted Project, Restricted Project
eugenis added a reverting change for D101920: [AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP): rGbd3ee371e9f0: Revert "[AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP)".
Jan 19 2023, 2:09 PM · Restricted Project, Restricted Project
eugenis closed D141978: Revert "[AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP)".
Jan 19 2023, 2:09 PM · Restricted Project, Restricted Project
eugenis accepted D141315: Verifier: Add checks for associated metadata.

LGTM, thank you!

Jan 19 2023, 11:17 AM · Restricted Project, Restricted Project

Jan 17 2023

eugenis added a comment to D101920: [AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP).

I've uploaded D141978 with a revert. I've opted against introducing a new subtarget feature because that would mean keeping dead code in the repo, without a way of testing it.

Jan 17 2023, 4:51 PM · Restricted Project, Restricted Project
eugenis added a reverting change for rG571c8c5263a7: [AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP): D141978: Revert "[AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP)".
Jan 17 2023, 4:50 PM
eugenis requested review of D141978: Revert "[AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP)".
Jan 17 2023, 4:50 PM · Restricted Project, Restricted Project
eugenis added a reverting change for D101920: [AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP): D141978: Revert "[AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP)".
Jan 17 2023, 4:50 PM · Restricted Project, Restricted Project
eugenis accepted D141973: [HWASan] link to doc in reports on Android.

LGTM

Jan 17 2023, 3:57 PM · Restricted Project, Restricted Project
eugenis accepted D141315: Verifier: Add checks for associated metadata.

LGTM with a comment

Jan 17 2023, 2:20 PM · Restricted Project, Restricted Project

Jan 12 2023

eugenis accepted D141631: allocation_ring_buffer_size to 0 disables stack collection.

Perfect, LGTM

Jan 12 2023, 3:52 PM · Restricted Project, Restricted Project
eugenis added a comment to D141631: allocation_ring_buffer_size to 0 disables stack collection.

Hmm do we allocate the ring buffer when tracking is not required? This would be a waste of a page.

Jan 12 2023, 1:56 PM · Restricted Project, Restricted Project

Jan 11 2023

eugenis added a comment to D101920: [AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP).

I think using the environment part of the triple is the right choice. We could also just go ahead and flip the current behavior until there is evidence of a platform that configures SCTRL_EL1.BT0 differently, at which point they can implement the triple logic.

Jan 11 2023, 3:59 PM · Restricted Project, Restricted Project
eugenis accepted D140932: Dynamically allocate scudo allocation buffer..

LGTM

Jan 11 2023, 3:52 PM · Restricted Project, Restricted Project

Jan 10 2023

Herald added a project to D101920: [AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP): Restricted Project.

This change claims that PACIASP has an implicit BTI JC. Is that correct? From my reading of the spec (and I have about 50% certainty that I'm right), the behavior is actually the same as of BTI C. At least this is true on Linux, where SCTRL_EL1.BT0 is set to 1.

Jan 10 2023, 2:37 PM · Restricted Project, Restricted Project
eugenis accepted D133392: [MTE] Add AArch64GlobalsTagging Pass.

LGTM

Jan 10 2023, 1:27 PM · Restricted Project, Restricted Project, Restricted Project
eugenis accepted D140173: [GWP-ASan] Add recoverable mode..

LGTM

Jan 10 2023, 1:20 PM · Restricted Project, Restricted Project

Dec 20 2022

eugenis added a comment to D140173: [GWP-ASan] Add recoverable mode..

Do you have a stress test to exhaust all gwp-asan slots?

Dec 20 2022, 1:26 PM · Restricted Project, Restricted Project

Dec 16 2022

eugenis added inline comments to D140173: [GWP-ASan] Add recoverable mode..
Dec 16 2022, 1:59 PM · Restricted Project, Restricted Project

Dec 15 2022

eugenis added a comment to D140173: [GWP-ASan] Add recoverable mode..

It's a single mprotect across the gwp-asan region. Also no need to bother with recursive guards as no new allocations can reach gwp-asan.

Dec 15 2022, 5:15 PM · Restricted Project, Restricted Project
eugenis added a comment to D140173: [GWP-ASan] Add recoverable mode..

It seems like this could become much simpler if we disable gwp-asan on the first report instead of killing slots one-by-one.

Dec 15 2022, 5:03 PM · Restricted Project, Restricted Project

Dec 9 2022

eugenis accepted D139748: [GWP-ASan] Fix sanitizer backtrace util using wrong print..

LGTM

Dec 9 2022, 4:31 PM · Restricted Project, Restricted Project

Nov 23 2022

eugenis added a comment to D137666: [msan] Increase size of app/shadow/origin mappings on aarch64.

If there are no concerns about deprecating 39 and 42 bit VMA support in MSan, then I'm fine with this. I'd love to see performance comparison of static vs dynamic shadow, but this is a separate issue.

Nov 23 2022, 12:50 PM · Restricted Project, Restricted Project, Restricted Project
eugenis added a reviewer for D137666: [msan] Increase size of app/shadow/origin mappings on aarch64: zatrazz.
Nov 23 2022, 12:46 PM · Restricted Project, Restricted Project, Restricted Project

Nov 21 2022

eugenis added a reverting change for rG1dd54691b20d: [scudo] Detect double free when running with MTE.: rG8add770417ca: Revert "[scudo] Detect double free when running with MTE.".
Nov 21 2022, 4:58 PM · Restricted Project, Restricted Project
eugenis committed rG8add770417ca: Revert "[scudo] Detect double free when running with MTE." (authored by eugenis).
Revert "[scudo] Detect double free when running with MTE."
Nov 21 2022, 4:58 PM · Restricted Project, Restricted Project
eugenis added a reverting change for D137352: [scudo] Detect double free when running with MTE.: rG8add770417ca: Revert "[scudo] Detect double free when running with MTE.".
Nov 21 2022, 4:58 PM · Restricted Project, Restricted Project

Nov 18 2022

eugenis committed rG1dd54691b20d: [scudo] Detect double free when running with MTE. (authored by eugenis).
[scudo] Detect double free when running with MTE.
Nov 18 2022, 1:18 PM · Restricted Project, Restricted Project
eugenis closed D137352: [scudo] Detect double free when running with MTE..
Nov 18 2022, 1:18 PM · Restricted Project, Restricted Project
eugenis updated the diff for D137352: [scudo] Detect double free when running with MTE..

addressed Florian's comment

Nov 18 2022, 12:46 PM · Restricted Project, Restricted Project
eugenis added a comment to D137352: [scudo] Detect double free when running with MTE..

ping

Nov 18 2022, 11:02 AM · Restricted Project, Restricted Project

Nov 17 2022

eugenis committed rG48dbf353025d: [scudo] Extend basic test to cover zero size allocs. (authored by eugenis).
[scudo] Extend basic test to cover zero size allocs.
Nov 17 2022, 11:28 AM · Restricted Project, Restricted Project
eugenis closed D137354: [scudo] Extend basic test to cover zero size allocs..
Nov 17 2022, 11:28 AM · Restricted Project, Restricted Project

Nov 16 2022

eugenis updated the diff for D137352: [scudo] Detect double free when running with MTE..

expanded comments

Nov 16 2022, 3:54 PM · Restricted Project, Restricted Project

Nov 10 2022

eugenis added a comment to D137666: [msan] Increase size of app/shadow/origin mappings on aarch64.

If we are changing the mapping + the ABI, we should be 100% confident the new one covers all ASLR possibilities. Why not just run some binary a lot of times and collect the range of addresses, or even inspect the kernel source for possible executable locations? Also, make it a large binary.

Nov 10 2022, 12:37 PM · Restricted Project, Restricted Project, Restricted Project
eugenis added a comment to D137352: [scudo] Detect double free when running with MTE..

ping

Nov 10 2022, 10:49 AM · Restricted Project, Restricted Project
eugenis added a comment to D137354: [scudo] Extend basic test to cover zero size allocs..

ping

Nov 10 2022, 10:49 AM · Restricted Project, Restricted Project
eugenis added a comment to D137666: [msan] Increase size of app/shadow/origin mappings on aarch64.

Ah, so is the problem with ASLR randomizing the initial executable mappings over a region larger than 64Gb? We do not care about app allocating memory, heap placement is defined by msan. Could you confirm that the new mapping covers all possible locations? Even with ex. a huge executable binary.

Nov 10 2022, 10:17 AM · Restricted Project, Restricted Project, Restricted Project
eugenis added a comment to D137666: [msan] Increase size of app/shadow/origin mappings on aarch64.

Sorry, I don't follow. What is limited to 64Gb (the sum of all app regions? why does it matter?) and why can't an "invalid" region be mapped?

Nov 10 2022, 7:57 AM · Restricted Project, Restricted Project, Restricted Project

Nov 7 2022

eugenis added inline comments to D137352: [scudo] Detect double free when running with MTE..
Nov 7 2022, 11:02 AM · Restricted Project, Restricted Project
eugenis requested changes to D137404: [sanitizer][test] Don't hard-code page size in CompactRingBuffer.int64.

As explained in D117635, kPageSizeBits is part of the compiler contract and must be a compile-time constant.

Nov 7 2022, 9:44 AM · Restricted Project, Restricted Project

Nov 3 2022

eugenis requested review of D137354: [scudo] Extend basic test to cover zero size allocs..
Nov 3 2022, 1:25 PM · Restricted Project, Restricted Project
eugenis requested review of D137352: [scudo] Detect double free when running with MTE..
Nov 3 2022, 1:24 PM · Restricted Project, Restricted Project

Oct 24 2022

eugenis added a comment to D136523: [MSAN] Add handleCountZeroes for ctlz and cttz..

LGTM, but I'd merge the two changes. I don't really see the point of submitting a test for the broken behavior first.

Oct 24 2022, 2:55 PM · Restricted Project, Restricted Project
eugenis added inline comments to D136523: [MSAN] Add handleCountZeroes for ctlz and cttz..
Oct 24 2022, 10:54 AM · Restricted Project, Restricted Project

Oct 17 2022

eugenis updated subscribers of D135925: Fix LazyInitialization in tsan.
Oct 17 2022, 11:25 AM · Restricted Project, Restricted Project
eugenis added a comment to D136062: [AArch64] Make ACLE intrinsics always available part MTE.

LGTM

Oct 17 2022, 11:20 AM · Restricted Project, Restricted Project
eugenis added a comment to D136062: [AArch64] Make ACLE intrinsics always available part MTE.

I like the direction of this change and agree that it needs a test.

Oct 17 2022, 11:17 AM · Restricted Project, Restricted Project

Oct 14 2022

eugenis added a comment to D135925: Fix LazyInitialization in tsan.

I think this is a fix for LazyInitialize in the tsan_rtl.h - the logic there assumes that when preinit_array is always used whenever it can be used, and no further initialization is necessary. This assumption does not hold under -shared-libsan. IMO this should be fixed in LazyInitialize, not here.

Oct 14 2022, 1:30 PM · Restricted Project, Restricted Project

Oct 12 2022

eugenis accepted D135638: [MC] Also sort on IsBKeyFrame.

LGTM

Oct 12 2022, 12:55 PM · Restricted Project, Restricted Project
eugenis accepted D135639: [MC] Consider IsMTETaggedFrame in CIEKey.

LGTM

Oct 12 2022, 12:52 PM · Restricted Project, Restricted Project

Sep 28 2022

eugenis accepted D134779: [MTE] [HWASan] unify isInterestingAlloca.

LGTM

Sep 28 2022, 3:51 PM · Restricted Project, Restricted Project

Sep 20 2022

eugenis added a comment to D128998: [libunwind] Handle G in personality string.

stage2 is fine with me, too
LGTM

Sep 20 2022, 2:33 PM · Restricted Project, Restricted Project, Restricted Project

Sep 12 2022

eugenis added a comment to D133582: [ASan] rename internal references to left of/right of..

I think I'd rather keep left/right as internal concepts and only translate them to before/after in the output.

Sep 12 2022, 2:09 PM · Restricted Project, Restricted Project, Restricted Project

Sep 9 2022

eugenis added inline comments to D128958: Add assembler plumbing for sanitize_memtag.
Sep 9 2022, 11:52 AM · Restricted Project, Restricted Project, Restricted Project
eugenis added a comment to D133392: [MTE] Add AArch64GlobalsTagging Pass.

Change description says that the new pass "marks them as tagged". That's not what is happening.

Sep 9 2022, 11:51 AM · Restricted Project, Restricted Project, Restricted Project

Sep 7 2022

eugenis added a comment to D133391: [ASan] Show memory rather than tag addresses in tag dump.

Well compile-time may be hard. Hwasan does some runtime checks in InitShadow, that's ok too

Sep 7 2022, 12:43 PM · Restricted Project, Restricted Project
eugenis accepted D133391: [ASan] Show memory rather than tag addresses in tag dump.

Maybe add a few compile-time checks that mem->shadow->mem returns the original value? At least the sparc equations are complicated enough.

Sep 7 2022, 12:42 PM · Restricted Project, Restricted Project

Sep 6 2022

eugenis accepted D133380: [HWASan] Show memory rather than tag addresses in tag dump.

Could you also fix asan and msan for consistency?

Sep 6 2022, 3:58 PM · Restricted Project, Restricted Project
eugenis accepted D132611: [ASan] rename left/right to before/after..

LGTM

Sep 6 2022, 10:06 AM · Restricted Project, Restricted Project
eugenis accepted D132622: [HWASan] rename left/right to before/after..

LGTM

Sep 6 2022, 10:05 AM · Restricted Project, Restricted Project

Aug 30 2022

eugenis added reviewers for D132611: [ASan] rename left/right to before/after.: phosek, yln.
Aug 30 2022, 1:58 PM · Restricted Project, Restricted Project

Aug 26 2022

eugenis accepted D132761: [msan] Fix handling of constant shadow.

LGTM

Aug 26 2022, 3:33 PM · Restricted Project, Restricted Project
eugenis accepted D132765: [msan] Enable msan-check-constant-shadow by default.

LGTM

Aug 26 2022, 3:31 PM · Restricted Project, Restricted Project

Aug 24 2022

eugenis added a comment to D132611: [ASan] rename left/right to before/after..

I think this is a pretty minor change - we are not touching the general structure of the report, nor introducing a new error type (even though the latter happens from time to time).

Aug 24 2022, 2:53 PM · Restricted Project, Restricted Project

Aug 23 2022

eugenis accepted D131846: [MSAN] Handle array alloca with non-i64 size specification.

LGTM

Aug 23 2022, 6:17 PM · Restricted Project, Restricted Project
eugenis accepted D131845: [MSAN] Correct shadow type for atomicrmw instrumentation.

LGTM

Aug 23 2022, 6:16 PM · Restricted Project, Restricted Project

Aug 10 2022

eugenis added a comment to D131438: [clang][dataflow] Analyze constructor bodies.

Sorry but I had to revert this because of the conflicts with another revert: https://reviews.llvm.org/D131065

Aug 10 2022, 2:30 PM · Restricted Project, Restricted Project
eugenis added a reverting change for rG8a4c40bfe8e6: [clang][dataflow] Store DeclContext of block being analysed in Environment if…: rG8d3c9602959d: Revert "[clang][dataflow] Store DeclContext of block being analysed in….
Aug 10 2022, 2:30 PM · Restricted Project, Restricted Project
eugenis committed rG8d3c9602959d: Revert "[clang][dataflow] Store DeclContext of block being analysed in… (authored by eugenis).
Revert "[clang][dataflow] Store DeclContext of block being analysed in…
Aug 10 2022, 2:30 PM · Restricted Project, Restricted Project