eugenis (Evgenii Stepanov)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 3 2012, 3:00 AM (311 w, 2 d)

Recent Activity

Today

eugenis accepted D52363: [sanitizer] Move __sanitizer_set_death_callback to a more appropriate file.

LGTM

Fri, Sep 21, 10:05 AM

Yesterday

eugenis accepted D52305: [Hwasan] interceptor macro / extra comma removal.

LGTM, thank you

Thu, Sep 20, 11:20 AM

Wed, Sep 19

eugenis added a comment to D52249: [hwasan] Record and display stack history in stack-based reports..

I've moved initialization code around a little.

Wed, Sep 19, 5:35 PM
eugenis updated the diff for D52249: [hwasan] Record and display stack history in stack-based reports..

.

Wed, Sep 19, 5:34 PM
eugenis accepted D52279: [sanitizer] Make __sanitizer::CheckFailed not public.

LGTM from Linux PoV

Wed, Sep 19, 4:50 PM
eugenis committed rCRT342596: Revert "[XRay][compiler-rt] FDRLogWriter Abstraction" and 1 more..
Revert "[XRay][compiler-rt] FDRLogWriter Abstraction" and 1 more.
Wed, Sep 19, 3:32 PM
eugenis committed rL342596: Revert "[XRay][compiler-rt] FDRLogWriter Abstraction" and 1 more..
Revert "[XRay][compiler-rt] FDRLogWriter Abstraction" and 1 more.
Wed, Sep 19, 3:32 PM
eugenis accepted D52272: [InstCombine] Disable strcmp->memcmp transform for MSan..

LGTM, thanks!

Wed, Sep 19, 12:35 PM

Tue, Sep 18

eugenis updated the diff for D52249: [hwasan] Record and display stack history in stack-based reports..

add missing file

Tue, Sep 18, 2:40 PM
eugenis created D52249: [hwasan] Record and display stack history in stack-based reports..
Tue, Sep 18, 2:37 PM

Mon, Sep 17

eugenis requested changes to D48445: [sanitizer] Use "fast mmap" kernel flag for shadow memory on macOS 10.13.4+.
Mon, Sep 17, 1:04 PM · Restricted Project
eugenis added a comment to D48445: [sanitizer] Use "fast mmap" kernel flag for shadow memory on macOS 10.13.4+.

I don't like the new Mmap*Shadow functions. The number of different Mmap* functions is growing exponentially with any new feature, let's use flags and/or arguments instead.

Mon, Sep 17, 1:03 PM · Restricted Project

Thu, Sep 13

eugenis accepted D51902: [SanitizerCoverage] Create comdat for global arrays..

LGTM, I'm almost 100% sure this is safe, but I don't remember all the linker quirks around associated sections now.

Thu, Sep 13, 2:40 PM
eugenis added inline comments to D51902: [SanitizerCoverage] Create comdat for global arrays..
Thu, Sep 13, 2:20 PM
eugenis updated subscribers of D51882: [Sanitizers] [MinGW] Produce undecorated symbols for /export: directives when in MinGW mode.

So far the changes look fine to me.
Let's wait for @kcc, who hates ifdefs, to chime in.

Thu, Sep 13, 1:42 PM

Tue, Sep 11

eugenis added inline comments to D51902: [SanitizerCoverage] Create comdat for global arrays..
Tue, Sep 11, 4:36 PM
eugenis added inline comments to D51902: [SanitizerCoverage] Create comdat for global arrays..
Tue, Sep 11, 1:53 PM

Mon, Sep 10

eugenis added a comment to D51902: [SanitizerCoverage] Create comdat for global arrays..

Btw what if getUniqueModuleId returns ""? It may happens for files without external symbols.
I think we need to fall back to non-GCed counters.

Mon, Sep 10, 6:15 PM
eugenis accepted D51902: [SanitizerCoverage] Create comdat for global arrays..

LGTM
FTR, http://llvm.org/docs/LangRef.html#associated-metadata mentions that comdat is "recommended".
It would be nice to factor this out into a utility function (create associated global for a global) and use it in asan, too.

Mon, Sep 10, 6:14 PM
eugenis committed rL341875: [hwasan] Re-enable print-memory-usage-android test..
[hwasan] Re-enable print-memory-usage-android test.
Mon, Sep 10, 3:23 PM
eugenis committed rCRT341875: [hwasan] Re-enable print-memory-usage-android test..
[hwasan] Re-enable print-memory-usage-android test.
Mon, Sep 10, 3:23 PM

Fri, Sep 7

eugenis committed rCRT341738: [hwasan] Disable print-memory-usage-android test..
[hwasan] Disable print-memory-usage-android test.
Fri, Sep 7, 6:18 PM
eugenis committed rL341738: [hwasan] Disable print-memory-usage-android test..
[hwasan] Disable print-memory-usage-android test.
Fri, Sep 7, 6:18 PM
eugenis committed rCRT341735: [hwasan] Export memory stats through /proc/$PID/maps..
[hwasan] Export memory stats through /proc/$PID/maps.
Fri, Sep 7, 5:17 PM
eugenis committed rL341735: [hwasan] Export memory stats through /proc/$PID/maps..
[hwasan] Export memory stats through /proc/$PID/maps.
Fri, Sep 7, 5:12 PM
eugenis updated subscribers of D44077: Clear the stack protector after checking it.

This looks fine to me in general. @timshen @etienneb @rnk

Fri, Sep 7, 11:01 AM

Thu, Sep 6

eugenis committed rL341612: [hwasan] Fix malloc overflow detection..
[hwasan] Fix malloc overflow detection.
Thu, Sep 6, 5:28 PM
eugenis committed rCRT341612: [hwasan] Fix malloc overflow detection..
[hwasan] Fix malloc overflow detection.
Thu, Sep 6, 5:28 PM
eugenis committed rL341598: [hwasan] Remove allocator interceptors..
[hwasan] Remove allocator interceptors.
Thu, Sep 6, 3:54 PM
eugenis committed rCRT341598: [hwasan] Remove allocator interceptors..
[hwasan] Remove allocator interceptors.
Thu, Sep 6, 3:54 PM
eugenis closed D51711: [hwasan] Remove allocator interceptors..
Thu, Sep 6, 3:54 PM
eugenis closed D51711: [hwasan] Remove allocator interceptors..
Thu, Sep 6, 3:54 PM
eugenis added a comment to D51755: cmake: Only require python if COMPILER_RT_INCLUDE_TESTS is enabled.

lib/sanitizer_common/scripts/gen_dynamic_list.py needs python, and it is used to build asan (and others) runtime library.

Thu, Sep 6, 3:25 PM
eugenis accepted D34451: Add KMSAN instrumentation to MSan pass.

LGTM

Thu, Sep 6, 2:57 PM · Restricted Project

Wed, Sep 5

eugenis created D51711: [hwasan] Remove allocator interceptors..
Wed, Sep 5, 6:14 PM
eugenis committed rCRT341500: [hwasan] Don't handle signals on Android..
[hwasan] Don't handle signals on Android.
Wed, Sep 5, 3:47 PM
eugenis committed rL341500: [hwasan] Don't handle signals on Android..
[hwasan] Don't handle signals on Android.
Wed, Sep 5, 3:47 PM
eugenis accepted D51627: [MSan] Make sure variadic function arguments do not overflow __msan_va_arg_tls.

LGTM

Wed, Sep 5, 1:19 PM · Restricted Project
eugenis accepted D51412: [MSan] store origins for variadic function parameters in __msan_va_arg_origin_tls .

Right! Sorry I missed that.
LGTM.

Wed, Sep 5, 12:42 PM · Restricted Project

Tue, Sep 4

eugenis added a comment to D51412: [MSan] store origins for variadic function parameters in __msan_va_arg_origin_tls .

Looks like you forgot to add the test.

Tue, Sep 4, 1:45 PM · Restricted Project
eugenis added a comment to D51627: [MSan] Make sure variadic function arguments do not overflow __msan_va_arg_tls.

In fact, getShadow() already checks for kParamTLSSize and returns clean shadow if the argument does not fit.
We just need to skip storing argument shadow for such arguments instead of asserting.

Tue, Sep 4, 1:39 PM · Restricted Project
eugenis requested changes to D51627: [MSan] Make sure variadic function arguments do not overflow __msan_va_arg_tls.
Tue, Sep 4, 1:38 PM · Restricted Project
eugenis accepted D51627: [MSan] Make sure variadic function arguments do not overflow __msan_va_arg_tls.

LGTM

Tue, Sep 4, 1:38 PM · Restricted Project
eugenis added a comment to D50233: [InstCombine] Transform str(n)cmp to memcmp.

GCC does not have MemorySanitizer.

Tue, Sep 4, 12:04 PM
eugenis updated subscribers of D50233: [InstCombine] Transform str(n)cmp to memcmp.

There are concerns about this optimization expressed in

https://github.com/google/sanitizers/issues/993

Specifically, it can transform

strcmp("abc\0...undef...undef...", "foobar")

into a similar memcmp() which would observe uninitialized data at the end of the first string.

Tue, Sep 4, 11:40 AM

Fri, Aug 31

eugenis added inline comments to D51412: [MSan] store origins for variadic function parameters in __msan_va_arg_origin_tls .
Fri, Aug 31, 11:35 AM · Restricted Project
eugenis committed rCRT341229: [hwasan] Fix new[] with zero size..
[hwasan] Fix new[] with zero size.
Fri, Aug 31, 10:51 AM
eugenis committed rL341229: [hwasan] Fix new[] with zero size..
[hwasan] Fix new[] with zero size.
Fri, Aug 31, 10:50 AM

Thu, Aug 30

eugenis added a comment to D34451: Add KMSAN instrumentation to MSan pass.

LGTM, but you probably want to rebase it on top of D51412, instead of including that change in this one.

Thu, Aug 30, 1:26 PM · Restricted Project
eugenis added a comment to D51412: [MSan] store origins for variadic function parameters in __msan_va_arg_origin_tls .

Please add a test for accessing origin of a va_arg argument in the callee.
Please add a compiler-rt test (or extend an existing one).

Thu, Aug 30, 1:07 PM · Restricted Project
eugenis accepted D51334: SafeStack: Prevent OOB reads with mem intrinsics.

LGTM

Thu, Aug 30, 11:24 AM

Wed, Aug 29

eugenis added a comment to D51394: Add a thread-local ring buffer of heap allocations.

Looks good for a start.
A test would be nice.

Wed, Aug 29, 12:47 PM
eugenis accepted D51451: [sanitizer] Revert D50940.

LGTM

Wed, Aug 29, 12:39 PM
eugenis added a comment to D51364: [msan] Tentative fix for failing aarch64 test.

I wonder if ProtectMemoryRange in msan_linux.cc needs updating?

Wed, Aug 29, 11:50 AM
eugenis added a comment to D51364: [msan] Tentative fix for failing aarch64 test.

Looking at msan.h, 0x000F00000000 is not a valid mapping address:

{0x00000000000ULL, 0x01000000000ULL, MappingDesc::INVALID, "invalid"},

Something's broken.

Wed, Aug 29, 11:33 AM

Tue, Aug 28

eugenis accepted D51196: Add a RingBuffer class to sanitizer_common.

LGTM, thanks!

Tue, Aug 28, 4:31 PM
eugenis added inline comments to D51196: Add a RingBuffer class to sanitizer_common.
Tue, Aug 28, 3:41 PM
eugenis accepted D51368: SafeStack: Fix thread liveness check on *BSD.

LGTM

Tue, Aug 28, 11:02 AM

Fri, Aug 24

eugenis added a comment to D51075: [SafeStack] Set debug location for calls to __safestack_pointer_address..

How interesting, "accept revision" goes to reviewers only, not to the mailing list.

Fri, Aug 24, 10:48 AM
eugenis accepted D51224: [scudo] Replace eraseHeader with compareExchangeHeader for Quarantined chunks.
Fri, Aug 24, 10:46 AM
eugenis accepted D51075: [SafeStack] Set debug location for calls to __safestack_pointer_address..
Fri, Aug 24, 10:18 AM

Aug 21 2018

eugenis added inline comments to D51075: [SafeStack] Set debug location for calls to __safestack_pointer_address..
Aug 21 2018, 5:05 PM
eugenis accepted D51070: [SafeStack] Handle unreachable code with safe stack coloring..
Aug 21 2018, 4:48 PM

Aug 20 2018

eugenis accepted D51016: SafeStack: Use correct unsafe stack sizes.

Nice catch!

Aug 20 2018, 4:53 PM
eugenis committed rCRT340216: [hwasan] Add a (almost) no-interceptor mode..
[hwasan] Add a (almost) no-interceptor mode.
Aug 20 2018, 2:50 PM
eugenis committed rL340216: [hwasan] Add a (almost) no-interceptor mode..
[hwasan] Add a (almost) no-interceptor mode.
Aug 20 2018, 2:50 PM
eugenis closed D50922: [hwasan] Add a (almost) no-interceptor mode..
Aug 20 2018, 2:50 PM
eugenis added a comment to D50922: [hwasan] Add a (almost) no-interceptor mode..

Sure. Eventually the entire hwasan_interceptors.cc would be under one big ifdef, if things go as planned.

Aug 20 2018, 1:50 PM

Aug 17 2018

eugenis created D50922: [hwasan] Add a (almost) no-interceptor mode..
Aug 17 2018, 1:48 PM

Aug 16 2018

eugenis committed rCRT339963: Revert "Revert "[hwasan] Add __hwasan_handle_longjmp."".
Revert "Revert "[hwasan] Add __hwasan_handle_longjmp.""
Aug 16 2018, 4:18 PM
eugenis committed rL339963: Revert "Revert "[hwasan] Add __hwasan_handle_longjmp."".
Revert "Revert "[hwasan] Add __hwasan_handle_longjmp.""
Aug 16 2018, 4:18 PM
eugenis committed rCRT339957: Revert "[hwasan] Add __hwasan_handle_longjmp.".
Revert "[hwasan] Add __hwasan_handle_longjmp."
Aug 16 2018, 3:28 PM
eugenis added a reverting commit for rCRT339935: [hwasan] Add __hwasan_handle_longjmp.: rCRT339957: Revert "[hwasan] Add __hwasan_handle_longjmp.".
Aug 16 2018, 3:28 PM
eugenis committed rL339957: Revert "[hwasan] Add __hwasan_handle_longjmp.".
Revert "[hwasan] Add __hwasan_handle_longjmp."
Aug 16 2018, 3:28 PM
eugenis added a reverting commit for rL339935: [hwasan] Add __hwasan_handle_longjmp.: rL339957: Revert "[hwasan] Add __hwasan_handle_longjmp.".
Aug 16 2018, 3:28 PM
eugenis committed rL339950: [hwasan] Enable Android logging..
[hwasan] Enable Android logging.
Aug 16 2018, 2:56 PM
eugenis committed rCRT339950: [hwasan] Enable Android logging..
[hwasan] Enable Android logging.
Aug 16 2018, 2:56 PM
eugenis closed D50865: [hwasan] Enable Android logging..
Aug 16 2018, 2:56 PM
eugenis created D50865: [hwasan] Enable Android logging..
Aug 16 2018, 2:32 PM
eugenis added inline comments to D48792: [ARM] Set execute-only flags in .text..
Aug 16 2018, 1:56 PM
eugenis committed rL339935: [hwasan] Add __hwasan_handle_longjmp..
[hwasan] Add __hwasan_handle_longjmp.
Aug 16 2018, 1:47 PM
eugenis committed rCRT339935: [hwasan] Add __hwasan_handle_longjmp..
[hwasan] Add __hwasan_handle_longjmp.
Aug 16 2018, 1:47 PM
eugenis closed D50752: [hwasan] Add __hwasan_handle_longjmp..
Aug 16 2018, 1:47 PM
eugenis added inline comments to D49383: [cfi-verify] Support cross-DSO.
Aug 16 2018, 1:46 PM
eugenis committed rCRT339932: [hwasan] Add malloc_fill_byte and free_fill_byte flags..
[hwasan] Add malloc_fill_byte and free_fill_byte flags.
Aug 16 2018, 1:14 PM
eugenis committed rL339932: [hwasan] Add malloc_fill_byte and free_fill_byte flags..
[hwasan] Add malloc_fill_byte and free_fill_byte flags.
Aug 16 2018, 1:14 PM
eugenis closed D50753: [hwasan] Add malloc_fill_byte and free_fill_byte flags..
Aug 16 2018, 1:13 PM
eugenis added a comment to D50752: [hwasan] Add __hwasan_handle_longjmp..

ping

Aug 16 2018, 1:03 PM
eugenis added a comment to D50753: [hwasan] Add malloc_fill_byte and free_fill_byte flags..

ping

Aug 16 2018, 1:02 PM

Aug 14 2018

eugenis created D50753: [hwasan] Add malloc_fill_byte and free_fill_byte flags..
Aug 14 2018, 6:05 PM
eugenis committed rL339746: [hwasan] Add a basic API..
[hwasan] Add a basic API.
Aug 14 2018, 5:40 PM
eugenis committed rCRT339746: [hwasan] Add a basic API..
[hwasan] Add a basic API.
Aug 14 2018, 5:40 PM
eugenis closed D50746: [hwasan] Add a basic API..
Aug 14 2018, 5:40 PM
eugenis created D50752: [hwasan] Add __hwasan_handle_longjmp..
Aug 14 2018, 5:38 PM
eugenis updated the diff for D50746: [hwasan] Add a basic API..

addressed 2 comments

Aug 14 2018, 4:59 PM
eugenis created D50746: [hwasan] Add a basic API..
Aug 14 2018, 4:43 PM
eugenis accepted D50483: [SanitizerCoverage] Add associated metadata to PC guards..

OK. But please mention the fact that runtime library relies on the section entry order in the patch description.

Aug 14 2018, 2:49 PM
eugenis accepted D50655: [scudo] Fix race condition in deallocation path when Quarantine is bypassed.

LGTM

Aug 14 2018, 11:32 AM

Aug 13 2018

eugenis committed rCRT339614: [hwasan] Provide __sanitizer_* aliases to allocator functions..
[hwasan] Provide __sanitizer_* aliases to allocator functions.
Aug 13 2018, 2:08 PM
eugenis committed rL339614: [hwasan] Provide __sanitizer_* aliases to allocator functions..
[hwasan] Provide __sanitizer_* aliases to allocator functions.
Aug 13 2018, 2:08 PM