Page MenuHomePhabricator

eugenis (Evgenii Stepanov)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 3 2012, 3:00 AM (341 w, 2 d)

Recent Activity

Yesterday

eugenis added a comment to D60589: [sanitizer_common] Expose a variadic version of the sanitizer Printf function..

IMHO, we could use printf() in gwpasan directly, with a guard against recursive malloc.

I don't think this will work in a signal-safe manner. The only times that GwpAsan calls printf() is in the signal handler, and even if we temporarily disable sampled allocations, we still are exercising non-reentrant functions in a signal handler.

Fri, Apr 19, 2:33 PM · Restricted Project, Restricted Project
eugenis added inline comments to D60617: MSan: handle llvm.lifetime.start intrinsic.
Fri, Apr 19, 10:25 AM · Restricted Project

Thu, Apr 18

eugenis accepted D60806: [HWASan] Added no-FP unit test for register dump..

LGTM

Thu, Apr 18, 4:32 PM · Restricted Project, Restricted Project
eugenis added a comment to D60593: [GwpAsan] Introduce GWP-ASan..

If the atomic load ends up on the hot path, we could try moving it to the same cache line as NextSampleCounter. That would make it thread local, but it can be initialized from the global variable on the slow path.

Thu, Apr 18, 4:30 PM · Restricted Project, Restricted Project
eugenis added inline comments to D60806: [HWASan] Added no-FP unit test for register dump..
Thu, Apr 18, 2:50 PM · Restricted Project, Restricted Project

Tue, Apr 16

eugenis added inline comments to D60617: MSan: handle llvm.lifetime.start intrinsic.
Tue, Apr 16, 6:02 PM · Restricted Project
eugenis added inline comments to D60686: Asan use-after-scope: don't poison allocas if there were untraced lifetime intrinsics in the function (PR41481).
Tue, Apr 16, 5:32 PM · Restricted Project
eugenis added inline comments to D60686: Asan use-after-scope: don't poison allocas if there were untraced lifetime intrinsics in the function (PR41481).
Tue, Apr 16, 5:27 PM · Restricted Project
eugenis added inline comments to D60806: [HWASan] Added no-FP unit test for register dump..
Tue, Apr 16, 5:26 PM · Restricted Project, Restricted Project
eugenis accepted D60798: [HWASan] Fixed slow DWARF unwinding..

LGTM

Tue, Apr 16, 3:12 PM · Restricted Project, Restricted Project

Mon, Apr 15

eugenis added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Mon, Apr 15, 5:04 PM · Restricted Project, Restricted Project
eugenis added a comment to D60617: MSan: handle llvm.lifetime.start intrinsic.

Please test the case when alloca can not be found.
See https://bugs.llvm.org/show_bug.cgi?id=41481 for the reference.

Ok, will do. The repro in the bug doesn't produce IR containing a select statement for me, but the idea is clear.

With this change msan will start detecting new bugs, ex.:
for (int i = 0; ...; ++i) {

int x;
if (i == 0) x=0;
read(x);

}

It can also slow down some programs a lot.

Agreed. This also makes less sense without origins - do you think we shall hide it behind track-origins>0 ?

Mon, Apr 15, 1:49 PM · Restricted Project
eugenis accepted D60686: Asan use-after-scope: don't poison allocas if there were untraced lifetime intrinsics in the function (PR41481).

LGTM
Consider extending the test with another alloca which does not participate in any untraceable lifetimes, but has to be poisoned in entry block anyway.

Mon, Apr 15, 1:39 PM · Restricted Project

Fri, Apr 12

eugenis added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Fri, Apr 12, 1:57 PM · Restricted Project, Restricted Project
eugenis added a comment to D60617: MSan: handle llvm.lifetime.start intrinsic.

Please test the case when alloca can not be found.
See https://bugs.llvm.org/show_bug.cgi?id=41481 for the reference.

Fri, Apr 12, 1:37 PM · Restricted Project
eugenis accepted D60615: [Transforms][ASan] Move findAllocaForValue() to Utils/Local.cpp. NFC.

This is very similar to GetUnderlyingObject, but it also handles PHIs, has a cache, but does not do InstructionSimplify and does not have a lookup limit.
It would be nice to merge the two.

Fri, Apr 12, 1:05 PM · Restricted Project
eugenis added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Fri, Apr 12, 11:32 AM · Restricted Project, Restricted Project

Thu, Apr 11

eugenis added a comment to D60589: [sanitizer_common] Expose a variadic version of the sanitizer Printf function..

Is this meant as a test-only thing?
I don't think we want sanitizer Printf anywhere close to production.

Thu, Apr 11, 6:24 PM · Restricted Project, Restricted Project

Mon, Apr 8

eugenis accepted D60355: hwasan: Enable -hwasan-allow-ifunc by default..

LGTM

Mon, Apr 8, 5:16 PM · Restricted Project, Restricted Project

Thu, Apr 4

eugenis accepted D60045: [Sanitizers] Provide __internal_dup on Solaris.

Yes, seems pretty obvious.
LGTM.

Thu, Apr 4, 11:32 AM · Restricted Project, Restricted Project
eugenis accepted D60044: [Sanitizers] Fix sanitizer_linux_libcdep.cc compilation on Solaris.

LGTM

Thu, Apr 4, 11:29 AM · Restricted Project, Restricted Project

Wed, Apr 3

eugenis added a comment to D60176: [libc++][libc++abi] Don't provide new/delete when built with ASan, HWASan or TSan.

I think I prefer the cmake flag, too.
It's not unthinkable that hwasan might stop providing operator new and friends in the future. I was a bit surprised that we even do it now in COMPILER_RT_HWASAN_WITH_INTERCEPTORS=OFF configuration - but it looks like we are keeping it.
Anyway, lets not hardcode this decision.

Wed, Apr 3, 4:45 PM · Restricted Project
eugenis accepted D60176: [libc++][libc++abi] Don't provide new/delete when built with ASan, HWASan or TSan.

LGTM

Wed, Apr 3, 2:32 PM · Restricted Project

Wed, Mar 27

eugenis committed rG67646d0570b4: Fix llvm-rc tests. (authored by eugenis).
Fix llvm-rc tests.
Wed, Mar 27, 1:15 PM
eugenis committed rL357118: Fix llvm-rc tests..
Fix llvm-rc tests.
Wed, Mar 27, 1:14 PM
eugenis closed D59858: Fix llvm-rc tests..
Wed, Mar 27, 1:14 PM · Restricted Project

Tue, Mar 26

eugenis added a comment to D59858: Fix llvm-rc tests..

To see this problem, move your build directory to a full path starting with "/c".

Tue, Mar 26, 6:05 PM · Restricted Project
eugenis created D59858: Fix llvm-rc tests..
Tue, Mar 26, 6:03 PM · Restricted Project
Herald added a project to D56743: [llvm-rc] Support '--' for delimiting options from input paths: Restricted Project.
Tue, Mar 26, 6:00 PM · Restricted Project

Mar 14 2019

eugenis added a comment to D58858: [msan] Instrument x86 BMI intrinsics..

As far as I can see, "unit" tests in lib/msan/tests also use the freshly built compiler through msan_compile / clang_compile cmake macros. Otherwise this CL would break everyone's builds.

Mar 14 2019, 3:03 PM · Restricted Project, Restricted Project

Mar 12 2019

eugenis committed rG6e64a14804e9: Revert "[llvm] Skip over empty line table entries." (authored by eugenis).
Revert "[llvm] Skip over empty line table entries."
Mar 12 2019, 6:37 PM
eugenis committed rL356001: Revert "[llvm] Skip over empty line table entries.".
Revert "[llvm] Skip over empty line table entries."
Mar 12 2019, 6:37 PM
eugenis added a comment to D58952: [llvm] Skip over empty line table entries..

Reverted in r356001.

Mar 12 2019, 6:37 PM · debug-info, Restricted Project
eugenis added a comment to D58858: [msan] Instrument x86 BMI intrinsics..

I'm running that configuration for years and it always worked. Do you have a change at hand that did such compiler change?

Mar 12 2019, 1:18 PM · Restricted Project, Restricted Project

Mar 11 2019

eugenis committed rG17ee3b4b74de: [msan] Fix BMI2 detection in msan tests. (authored by eugenis).
[msan] Fix BMI2 detection in msan tests.
Mar 11 2019, 5:21 PM
eugenis committed rCRT355885: [msan] Fix BMI2 detection in msan tests..
[msan] Fix BMI2 detection in msan tests.
Mar 11 2019, 5:21 PM
eugenis committed rL355885: [msan] Fix BMI2 detection in msan tests..
[msan] Fix BMI2 detection in msan tests.
Mar 11 2019, 5:21 PM
eugenis added a comment to D58858: [msan] Instrument x86 BMI intrinsics..

This is expected to break. I'm surprised it did not break earlier - we often do a compiler change and corresponding integration tests in compiler-rt as a single commit, or two consecutive commits.

Mar 11 2019, 5:21 PM · Restricted Project, Restricted Project
eugenis committed rGaedec3f68410: Remove ASan asm instrumentation. (authored by eugenis).
Remove ASan asm instrumentation.
Mar 11 2019, 2:50 PM
eugenis committed rL355870: Remove ASan asm instrumentation..
Remove ASan asm instrumentation.
Mar 11 2019, 2:49 PM
eugenis committed rCRT355870: Remove ASan asm instrumentation..
Remove ASan asm instrumentation.
Mar 11 2019, 2:49 PM
eugenis closed D59154: Remove ASan asm instrumentation..
Mar 11 2019, 2:49 PM · Restricted Project, Restricted Project

Mar 8 2019

eugenis created D59154: Remove ASan asm instrumentation..
Mar 8 2019, 1:40 PM · Restricted Project, Restricted Project
eugenis added a comment to D59116: [scudo][standalone] Implement checksumming functions.

Could this be done with a target("sse4.2") function attribute instead of cmake conditions?

Mar 8 2019, 11:05 AM · Restricted Project, Restricted Project
eugenis accepted D59133: Remove esan..

LGTM, good job!

Mar 8 2019, 10:49 AM · Restricted Project, Restricted Project

Mar 5 2019

eugenis added a comment to D58081: [GlobalISel][AArch64] Select llvm.bswap* for non-vector types.

you have a test file under lib/Target/AArch64.
Is it intentional? I don't think it does anything...

Mar 5 2019, 5:35 PM · Restricted Project
eugenis accepted D58857: [HWASan] Save + print registers when tag mismatch occurs in AArch64..

LGTM

Mar 5 2019, 1:45 PM · Restricted Project, Restricted Project
eugenis added inline comments to D58857: [HWASan] Save + print registers when tag mismatch occurs in AArch64..
Mar 5 2019, 11:28 AM · Restricted Project, Restricted Project

Mar 4 2019

eugenis committed rG53d7c5cd4479: [msan] Instrument x86 BMI intrinsics. (authored by eugenis).
[msan] Instrument x86 BMI intrinsics.
Mar 4 2019, 3:02 PM
eugenis committed rG8cee2e8539ae: [sanitizer] Intercept bzero. (authored by eugenis).
[sanitizer] Intercept bzero.
Mar 4 2019, 3:02 PM
eugenis committed rL355348: [msan] Instrument x86 BMI intrinsics..
[msan] Instrument x86 BMI intrinsics.
Mar 4 2019, 3:02 PM
eugenis committed rL355347: [sanitizer] Intercept bzero..
[sanitizer] Intercept bzero.
Mar 4 2019, 3:02 PM
eugenis committed rCRT355348: [msan] Instrument x86 BMI intrinsics..
[msan] Instrument x86 BMI intrinsics.
Mar 4 2019, 3:01 PM
eugenis closed D58858: [msan] Instrument x86 BMI intrinsics..
Mar 4 2019, 3:01 PM · Restricted Project, Restricted Project
eugenis committed rCRT355347: [sanitizer] Intercept bzero..
[sanitizer] Intercept bzero.
Mar 4 2019, 3:01 PM
eugenis closed D58850: [sanitizer] Intercept bzero..
Mar 4 2019, 3:01 PM · Restricted Project, Restricted Project
eugenis committed rGe800a32b93cc: Fix wrong enum value in switch. (authored by eugenis).
Fix wrong enum value in switch.
Mar 4 2019, 1:00 PM
eugenis committed rL355338: Fix wrong enum value in switch..
Fix wrong enum value in switch.
Mar 4 2019, 1:00 PM
eugenis added inline comments to D58857: [HWASan] Save + print registers when tag mismatch occurs in AArch64..
Mar 4 2019, 11:45 AM · Restricted Project, Restricted Project
eugenis added a comment to D58857: [HWASan] Save + print registers when tag mismatch occurs in AArch64..

This needs a compiler-rt test.

Mar 4 2019, 10:23 AM · Restricted Project, Restricted Project

Mar 1 2019

eugenis updated the diff for D58850: [sanitizer] Intercept bzero..

rebase

Mar 1 2019, 6:13 PM · Restricted Project, Restricted Project
eugenis committed rG02a913367a62: Revert "[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors." (authored by eugenis).
Revert "[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors."
Mar 1 2019, 5:34 PM
eugenis committed rCRT355256: Revert "[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors.".
Revert "[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors."
Mar 1 2019, 5:34 PM
eugenis committed rL355256: Revert "[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors.".
Revert "[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors."
Mar 1 2019, 5:34 PM
eugenis created D58858: [msan] Instrument x86 BMI intrinsics..
Mar 1 2019, 5:02 PM · Restricted Project, Restricted Project
eugenis created D58850: [sanitizer] Intercept bzero..
Mar 1 2019, 2:22 PM · Restricted Project, Restricted Project
eugenis committed rGddc4b7c1d6d4: [sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors. (authored by eugenis).
[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors.
Mar 1 2019, 1:59 PM
eugenis committed rL355231: [sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors..
[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors.
Mar 1 2019, 1:58 PM
eugenis committed rCRT355231: [sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors..
[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors.
Mar 1 2019, 1:58 PM
eugenis committed rG72e83488f32a: Revert "[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors." (authored by eugenis).
Revert "[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors."
Mar 1 2019, 1:49 PM
eugenis committed rL355230: Revert "[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors.".
Revert "[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors."
Mar 1 2019, 1:49 PM
eugenis committed rCRT355230: Revert "[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors.".
Revert "[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors."
Mar 1 2019, 1:48 PM
eugenis committed rG3bbac856f993: [sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors. (authored by eugenis).
[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors.
Mar 1 2019, 12:54 PM
eugenis committed rCRT355225: [sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors..
[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors.
Mar 1 2019, 12:54 PM
eugenis committed rL355225: [sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors..
[sanitizer] Fix return type of __bzero and __aeabi_mem* interceptors.
Mar 1 2019, 12:54 PM
eugenis committed rGc7b322a3d96b: [msan] Add an interceptor for ttyname(). (authored by eugenis).
[msan] Add an interceptor for ttyname().
Mar 1 2019, 10:22 AM
eugenis committed rCRT355214: [msan] Add an interceptor for ttyname()..
[msan] Add an interceptor for ttyname().
Mar 1 2019, 10:22 AM
eugenis committed rL355214: [msan] Add an interceptor for ttyname()..
[msan] Add an interceptor for ttyname().
Mar 1 2019, 10:22 AM

Feb 28 2019

eugenis committed rGdc3870d64dfe: [hwasan] Disable vfork code when building w/o interceptors. (authored by eugenis).
[hwasan] Disable vfork code when building w/o interceptors.
Feb 28 2019, 6:07 PM
eugenis committed rL355165: [hwasan] Disable vfork code when building w/o interceptors..
[hwasan] Disable vfork code when building w/o interceptors.
Feb 28 2019, 6:06 PM
eugenis committed rCRT355165: [hwasan] Disable vfork code when building w/o interceptors..
[hwasan] Disable vfork code when building w/o interceptors.
Feb 28 2019, 6:06 PM
eugenis committed rG9ca1755f76c5: [sanitizer] Build everything whereever possible with -z text. (authored by eugenis).
[sanitizer] Build everything whereever possible with -z text.
Feb 28 2019, 5:45 PM
eugenis committed rCRT355164: [sanitizer] Build everything whereever possible with -z text..
[sanitizer] Build everything whereever possible with -z text.
Feb 28 2019, 5:44 PM
eugenis committed rL355164: [sanitizer] Build everything whereever possible with -z text..
[sanitizer] Build everything whereever possible with -z text.
Feb 28 2019, 5:44 PM
eugenis closed D58755: [sanitizer] Build everything everywhere with -z text..
Feb 28 2019, 5:44 PM · Restricted Project, Restricted Project
eugenis added inline comments to D58533: [hwasan, asan] Intercept vfork..
Feb 28 2019, 12:47 PM · Restricted Project, Restricted Project
eugenis committed rGecb2c1fd5bfc: [hwasan] Fix vfork handling with large stack limit. (authored by eugenis).
[hwasan] Fix vfork handling with large stack limit.
Feb 28 2019, 12:45 PM
eugenis committed rL355137: [hwasan] Fix vfork handling with large stack limit..
[hwasan] Fix vfork handling with large stack limit.
Feb 28 2019, 12:45 PM
eugenis committed rCRT355137: [hwasan] Fix vfork handling with large stack limit..
[hwasan] Fix vfork handling with large stack limit.
Feb 28 2019, 12:44 PM
eugenis committed rG37ce064082c6: [sanitizer] Fix vfork interceptor on i386 w/ dynamic runtime. (authored by eugenis).
[sanitizer] Fix vfork interceptor on i386 w/ dynamic runtime.
Feb 28 2019, 11:21 AM
eugenis committed rCRT355125: [sanitizer] Fix vfork interceptor on i386 w/ dynamic runtime..
[sanitizer] Fix vfork interceptor on i386 w/ dynamic runtime.
Feb 28 2019, 11:20 AM
eugenis committed rL355125: [sanitizer] Fix vfork interceptor on i386 w/ dynamic runtime..
[sanitizer] Fix vfork interceptor on i386 w/ dynamic runtime.
Feb 28 2019, 11:20 AM

Feb 27 2019

eugenis added a comment to D58533: [hwasan, asan] Intercept vfork..

And D58755 to make sure this never happens again.

Feb 27 2019, 6:07 PM · Restricted Project, Restricted Project
eugenis created D58755: [sanitizer] Build everything everywhere with -z text..
Feb 27 2019, 6:07 PM · Restricted Project, Restricted Project
eugenis committed rGd4b4e17d2c70: [sanitizer] Got rid of text relocations in i386 vfork interceptor. (authored by eugenis).
[sanitizer] Got rid of text relocations in i386 vfork interceptor.
Feb 27 2019, 5:55 PM
eugenis committed rCRT355064: [sanitizer] Got rid of text relocations in i386 vfork interceptor..
[sanitizer] Got rid of text relocations in i386 vfork interceptor.
Feb 27 2019, 5:54 PM
eugenis committed rL355064: [sanitizer] Got rid of text relocations in i386 vfork interceptor..
[sanitizer] Got rid of text relocations in i386 vfork interceptor.
Feb 27 2019, 5:54 PM
eugenis added a comment to D58533: [hwasan, asan] Intercept vfork..

r355064 should do this.

Feb 27 2019, 5:54 PM · Restricted Project, Restricted Project
eugenis added a comment to D58533: [hwasan, asan] Intercept vfork..

Thanks, I'll fix it in a moment.

Feb 27 2019, 5:41 PM · Restricted Project, Restricted Project
eugenis added a comment to D58557: [NFC][Sanitizer] Hard-code fast/slow unwinder at call site.

This bot seems unhappy:
http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/6651

Feb 27 2019, 3:38 PM · Restricted Project, Restricted Project