This is an archive of the discontinued LLVM Phabricator instance.

[Alignment][NFC] Use Align for getMemcpy/Memmove/Memset
ClosedPublic

Authored by gchatelet on Feb 3 2020, 5:52 AM.

Details

Summary

This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790

Event Timeline

gchatelet created this revision.Feb 3 2020, 5:52 AM
gchatelet updated this revision to Diff 242047.Feb 3 2020, 5:56 AM
  • Improve documentation
courbet added inline comments.Feb 3 2020, 6:15 AM
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
4228

getByValAlign() can return zero, can you add a comment ?

llvm/lib/Target/AMDGPU/SIISelLowering.cpp
2867

ditto.

llvm/lib/Target/Hexagon/HexagonISelLowering.cpp
171

ditto

llvm/lib/Target/RISCV/RISCVISelLowering.cpp
2143

ditto

gchatelet updated this revision to Diff 242071.Feb 3 2020, 7:32 AM
gchatelet marked 2 inline comments as done.
  • Introduce getNonZeroByValAlign()
gchatelet added inline comments.Feb 3 2020, 7:32 AM
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
4228

I've introduced getNonZeroByValAlign() which cannot return zero,
As a matter of fact getByValAlign() is now useless and deprecated.

gchatelet marked 3 inline comments as done.Feb 3 2020, 7:33 AM
courbet accepted this revision.Feb 3 2020, 8:11 AM
This revision is now accepted and ready to land.Feb 3 2020, 8:11 AM
This revision was automatically updated to reflect the committed changes.