Page MenuHomePhabricator

[codeview] Workaround for PR43479, don't re-emit instr labels
ClosedPublic

Authored by rnk on Wed, Oct 16, 1:16 PM.

Details

Summary

In the long run we should come up with another mechanism for marking
call instructions as heap allocation sites, and remove this workaround.
For now, we've had two bug reports about this, so let's apply this
workaround. SLH (the other client of instruction labels) probably has
the same bug, but the solution there is more likely to be to mark the
call instruction as not duplicatable, which doesn't work for debug info.

Diff Detail

Event Timeline

rnk created this revision.Wed, Oct 16, 1:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Oct 16, 1:16 PM
akhuang accepted this revision.Wed, Oct 16, 1:21 PM

Thanks; I also tried compiling something with SLH the other day and I think it already doesn't do tail duplication there.

This revision is now accepted and ready to land.Wed, Oct 16, 1:21 PM
aganea added a subscriber: saudi.Wed, Oct 16, 1:24 PM
This revision was automatically updated to reflect the committed changes.